1. 26 Sep, 2011 40 commits
    • mhahnenberg@apple.com's avatar
      Make JSCell::toBoolean non-virtual · f2fa8ff1
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67727
      
      Reviewed by Geoffrey Garen.
      
      JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
      before it was simply virtual and would crash if its implementation was called).
      Its descendants in JSObject and JSString have also been made non-virtual.  JSCell now
      explicitly covers all cases of toBoolean, so having a virtual implementation of
      JSCell::toBoolean is no longer necessary.  This is part of a larger process of un-virtualizing JSCell.
      
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * runtime/JSCell.cpp:
      * runtime/JSCell.h:
      * runtime/JSNotAnObject.cpp:
      * runtime/JSNotAnObject.h:
      * runtime/JSObject.h:
      * runtime/JSString.h:
      (JSC::JSCell::toBoolean):
      (JSC::JSValue::toBoolean):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2fa8ff1
    • mihaip@chromium.org's avatar
      Remove failing Chromium test expectations for tests that now pass · 13e4b878
      mihaip@chromium.org authored
      (mainly due to r95751, which implemented Function.prototype.bind for
      JSC, resulting in baseline updates that now work for V8 too).
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13e4b878
    • commit-queue@webkit.org's avatar
      Set but unused variables cleanup in v8 bindings (gcc 4.6) · 30febf1f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68079
      
      Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-26
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Test: http/tests/websocket/tests/hybi/send-object-tostring-check.html
      
      * bindings/scripts/CodeGeneratorV8.pm:
      * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
      (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::ConfigureV8TestObjTemplate):
      * bindings/v8/WorkerScriptDebugServer.cpp:
      (WebCore::WorkerScriptDebugServer::addListener):
      * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
      (WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
      * bindings/v8/custom/V8WebSocketCustom.cpp:
      (WebCore::V8WebSocket::sendCallback):
      
      LayoutTests:
      
      * http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt: Added.
      * http/tests/websocket/tests/hybi/send-object-tostring-check.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30febf1f
    • tony@chromium.org's avatar
      switch the initial value of flex-order to 0 · afbd82b9
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68820
      
      Source/WebCore:
      
      The spec changed from having an initial value of 1 to 0.
      
      Reviewed by Ojan Vafai.
      
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::initialFlexOrder):
      
      LayoutTests:
      
      Reviewed by Ojan Vafai.
      
      * css3/flexbox/flex-order.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afbd82b9
    • cmarrin@apple.com's avatar
      Enable requestAnimationFrame on Windows · d01e0567
      cmarrin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68397
      
      Reviewed by Simon Fraser.
      
      Source/JavaScriptCore: 
      
      Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows
      
      * wtf/Platform.h:
      
      WebKitLibraries: 
      
      Enable REQUEST_ANIMATION_FRAME for Windows
      
      * win/tools/vsprops/FeatureDefines.vsprops:
      
      LayoutTests: 
      
      Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
      is still skipped because it uses showModalDialog which is not supported in DRT on Windows
      
      * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d01e0567
    • simon.fraser@apple.com's avatar
      Fix WebKitTestRunner builds for Cairo, Windows and Qt. · 9663d58a
      simon.fraser@apple.com authored
      * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
      (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
      * WebKitTestRunner/win/TestInvocationWin.cpp:
      (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9663d58a
    • crogers@google.com's avatar
      OfflineAudioDestinationNode must wait for thread completion in uninitialize() · d2b69a97
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68725
      
      Reviewed by Kenneth Russell.
      
      No new tests.  This fixes internal implementation details.
      
      * webaudio/OfflineAudioDestinationNode.cpp:
      (WebCore::OfflineAudioDestinationNode::uninitialize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2b69a97
    • rniwa@webkit.org's avatar
      editing/selection/select-bidi-run.html timeouts on non-Mac platforms · 1556ddef
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68831
      
      Reviewed by Enrica Casucci.
      
      Click at (0,0) to reset click count instead of a long leapForward.
      
      * editing/selection/select-bidi-run.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1556ddef
    • ap@apple.com's avatar
      REGRESSION (r95747): Activating the web inspector causes the web process to be killed · 64b6cb10
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68762
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage):
      Tell Web process that loading resources from WebCore resources directory is OK.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::loadHTMLString):
      (WebKit::WebPageProxy::loadAlternateHTMLString):
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::assumeReadAccessToBaseURL):
      * UIProcess/WebProcessProxy.h:
      Renamed willLoadHTMLStringWithBaseURL to more generic assumeReadAccessToBaseURL.
      
      * UIProcess/WebInspectorProxy.h:
      * UIProcess/efl/WebInspectorEfl.cpp:
      (WebKit::WebInspectorProxy::inspectorBaseURL):
      * UIProcess/gtk/WebInspectorGtk.cpp:
      (WebKit::WebInspectorProxy::inspectorBaseURL):
      * UIProcess/mac/WebInspectorProxyMac.mm:
      (WebKit::WebInspectorProxy::inspectorBaseURL):
      * UIProcess/qt/WebInspectorProxyQt.cpp:
      (WebKit::WebInspectorProxy::inspectorBaseURL):
      * UIProcess/win/WebInspectorProxyWin.cpp:
      (WebKit::WebInspectorProxy::inspectorBaseURL):
      Report what base directory Inspector has access to.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64b6cb10
    • imasaki@chromium.org's avatar
      [Chromium] Update the test expectaion file for media related tests. · eb589e5c
      imasaki@chromium.org authored
      It includes updating bug numbers, removing
      media/video-controls-visible-audio-only.html, and unskipping
      media/media-document-audio-repaint.html.
      https://bugs.webkit.org/show_bug.cgi?id=68254
      
      Reviewed by David Levin.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb589e5c
    • mihaip@chromium.org's avatar
      Source/WebKit/chromium: Fix copy and paste error in r96002. · 75497c98
      mihaip@chromium.org authored
      * tests/InnerGestureRecognizerTest.cpp:
      (TEST_F):
      
      LayoutTests: Remove test that no longer crashes (fixed by r95985).
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75497c98
    • xan@webkit.org's avatar
      [GTK] Do not ignore 'Replaceable' attributes in the DOM bindings · 32b26b25
      xan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68837
      
      Reviewed by Martin Robinson.
      
      * bindings/scripts/CodeGeneratorGObject.pm: add getters (but not
      setters) for 'Replaceable' attributes. Punt for the future
      actually making them settable, since it seems non trivial.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32b26b25
    • rniwa@webkit.org's avatar
      Leopard build fix. · 2f186d54
      rniwa@webkit.org authored
      * testing/Internals.cpp:
      (WebCore::Internals::setZoomAnimatorTransform):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f186d54
    • commit-queue@webkit.org's avatar
      IndexedDB: Null key path gets stored as empty string key path · 46a2a7b4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68726
      
      Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
      Reviewed by Tony Chang.
      
      Store additional flag to indicate if object store key path
      is null vs. empty. Added additional runtime tests for integrity
      of object store metadata.
      
      * storage/IDBLevelDBBackingStore.cpp:
      (WebCore::checkObjectStoreAndMetaDataType):
      (WebCore::IDBLevelDBBackingStore::getObjectStores):
      (WebCore::IDBLevelDBBackingStore::createObjectStore):
      * storage/IDBLevelDBCoding.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46a2a7b4
    • reed@google.com's avatar
      [skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu · 7c5444c7
      reed@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68807
      
      Reviewed by Stephen White.
      
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c5444c7
    • simon.fraser@apple.com's avatar
      Repaint tests don't work in WebKit2 · f597945d
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68453
      
      Tools:
      
      Reviewed by Sam Weinig.
      
      Convert DumpRenderTree to use use the repaint rects
      exposed via WebKit API when generating the repaint test
      overlay.
      
      Fix WebKitTestRunner to work with repaint tests, again
      using the repaint rects exposed from WK2.
      
      In both cases, layoutTestController.display() now just
      forces a display of the web view, and turns on repaint
      rect tracking on the main FrameView.
      
      Later, when pixel results are requested, the alpha overlay
      that shows the repaint rects is generated using the list
      of rects supplied by WebCore.
      
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (resetDefaultsToConsistentValues):
      (resetWebViewToConsistentStateBeforeTesting):
      (displayWebView):
      * DumpRenderTree/mac/PixelDumpSupportMac.mm:
      (paintRepaintRectOverlay):
      (createBitmapContextFromWebView):
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      (WTR::InjectedBundle::done):
      * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
      (WTR::InjectedBundle::setRepaintRects):
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::reset):
      (WTR::InjectedBundlePage::dump):
      * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
      (WTR::LayoutTestController::display):
      * WebKitTestRunner/TestInvocation.cpp:
      (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
      * WebKitTestRunner/TestInvocation.h:
      * WebKitTestRunner/cg/TestInvocationCG.cpp:
      (WTR::paintRepaintRectOverlay):
      (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
      
      LayoutTests:
      
      Reviewed by Sam Weinig.
      
      Update Mac results to use the new repaint rects. Differences from old results:
      	        * There are no longer invalidates from scrolling.
      	        * We no longer see the effects of AppKit rect coalescing.
      	        * Composting tests show the overlay now, but repaints in compositing layers do not show.
      
      	    Bad results in a couple of tests are covered by bugs 68830 and 68829.
      
      * platform/mac/fast/repaint/4774354-expected.png:
      * platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
      * platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
      * platform/mac/fast/repaint/border-radius-repaint-expected.png:
      * platform/mac/fast/repaint/clipped-relative-expected.png:
      * platform/mac/fast/repaint/containing-block-position-change-expected.png:
      * platform/mac/fast/repaint/control-clip-expected.png:
      * platform/mac/fast/repaint/delete-into-nested-block-expected.png:
      * platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
      * platform/mac/fast/repaint/fixed-scroll-simple-expected.png:
      * platform/mac/fast/repaint/flexible-box-overflow-expected.png:
      * platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.png:
      * platform/mac/fast/repaint/float-move-during-layout-expected.png:
      * platform/mac/fast/repaint/float-overflow-expected.png:
      * platform/mac/fast/repaint/float-overflow-right-expected.png:
      * platform/mac/fast/repaint/iframe-scroll-repaint-expected.png:
      * platform/mac/fast/repaint/inline-block-overflow-expected.png:
      * platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
      * platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
      * platform/mac/fast/repaint/layer-child-outline-expected.png:
      * platform/mac/fast/repaint/layer-outline-expected.png:
      * platform/mac/fast/repaint/layer-outline-horizontal-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
      * platform/mac/fast/repaint/line-overflow-expected.png:
      * platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png:
      * platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png:
      * platform/mac/fast/repaint/outline-child-repaint-expected.png:
      * platform/mac/fast/repaint/outline-shrinking-expected.png:
      * platform/mac/fast/repaint/overflow-delete-line-expected.png:
      * platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
      * platform/mac/fast/repaint/repaint-during-scroll-expected.png:
      * platform/mac/fast/repaint/scale-page-shrink-expected.png:
      * platform/mac/fast/repaint/search-field-cancel-expected.png:
      * platform/mac/fast/repaint/selection-after-remove-expected.png:
      * platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
      * platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
      * platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
      * platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:
      * platform/mac/fast/repaint/static-to-positioned-expected.png:
      * platform/mac/fast/repaint/table-cell-move-expected.png:
      * platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
      * platform/mac/fast/repaint/text-shadow-expected.png:
      * platform/mac/fast/repaint/text-shadow-horizontal-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f597945d
    • mihaip@chromium.org's avatar
      Disable Chromium gesture recognizer tests that started to fail on the · 13c10c72
      mihaip@chromium.org authored
      Mac bots recently.
      
      * tests/InnerGestureRecognizerTest.cpp:
      (TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13c10c72
    • noel.gordon@gmail.com's avatar
      [Chromium] Remove DFGAliasTracker.h references from gyp project files · 2e043089
      noel.gordon@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68787
      
      Reviewed by Geoffrey Garen.
      
      DFG/DFGAliasTracker.h was removed in r95389.  Cleanup (remove) references
      to that file from the gyp project files.
      
      * JavaScriptCore.gypi:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e043089
    • commit-queue@webkit.org's avatar
      Fix nonpremultiplied webgl toDataURL to jpeg · a1a06055
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68366
      
      Source/WebCore:
      
      The canvas spec says that toDataURL to formats without an alpha must
      be "composited onto a solid black background using the source-over
      operator." Do that.
      
      Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
      Reviewed by Kenneth Russell.
      
      * platform/graphics/cg/ImageBufferCG.cpp:
      (WebCore::CGImageToDataURL):
      (WebCore::ImageBuffer::toDataURL):
      (WebCore::ImageDataToDataURL):
      * platform/image-encoders/skia/JPEGImageEncoder.cpp:
      (WebCore::RGBAtoRGB):
      
      LayoutTests:
      
      Update the premultiplyalpha-test from the WebGL conformance tests.
      Also use the correct expected result for toDataURL.jpeg.alpha.html.
      
      Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
      Reviewed by Kenneth Russell.
      
      * fast/canvas/webgl/premultiplyalpha-test-expected.txt:
      * fast/canvas/webgl/premultiplyalpha-test.html:
      * platform/mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1a06055
    • commit-queue@webkit.org's avatar
      Source/WebKit2: Added WKHitTestResult API's. · 6efc060b
      commit-queue@webkit.org authored
      WKHitTestResult API's are added. These API's can be used to
      get the hover'ed link/image/media URL as well as link lable and
      title.
      https://bugs.webkit.org/show_bug.cgi?id=68426
      
      Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
      Reviewed by Anders Carlsson.
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * UIProcess/API/C/WKHitTestResult.cpp: Added.
      (WKHitTestResultGetTypeID):
      (WKHitTestResultCopyAbsoluteImageURL):
      (WKHitTestResultCopyAbsoluteLinkURL):
      (WKHitTestResultCopyAbsoluteMediaURL):
      (WKHitTestResultCopyLinkLabel):
      (WKHitTestResultCopyLinkTitle):
      * UIProcess/API/C/WKHitTestResult.h: Added.
      * UIProcess/API/C/WebKit2.h:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebKit2API.pri:
      * win/WebKit2.vcproj:
      * win/WebKit2Generated.make:
      
      Tools: Get hover'ed element URL from HitTest.
      
      mouseDidMoveOverElement now gets the hover'ed element link using
      WKHitTestResult API's.
      https://bugs.webkit.org/show_bug.cgi?id=68426
      
      Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
      Reviewed by Anders Carlsson.
      
      * MiniBrowser/gtk/BrowserWindow.c:
      (mouseDidMoveOverElement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6efc060b
    • commit-queue@webkit.org's avatar
      [CMake] Remove FindFreetype.cmake · 64415dd9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68778
      
      Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
      Reviewed by Adam Barth.
      
      CMake has provided its own FindFreetype.cmake forever, so there is no
      need to have another implementation in WebKit.
      
      .:
      
      * Source/cmake/FindCairo.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}
      instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.
      * Source/cmake/FindFreetype.cmake: Removed.
      * Source/cmake/FindPango.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}
      instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.
      * Source/cmake/OptionsEfl.cmake: Remove minimum required version
      check, it has never been checked and Freetype 2.1.10 from 2005 is
      already > 9.0.
      
      Source/WebCore:
      
      No new tests, just a buildsystem change.
      
      * CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of
      Freetype_{LIBRARIES,INCLUDE_DIRS}.
      
      Source/WebKit/efl:
      
      * CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of
      Freetype_{LIBRARIES,INCLUDE_DIRS}.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64415dd9
    • commit-queue@webkit.org's avatar
      Fix full-page rubber band overhang appearing when gesturing during a slow page load. · a9dcd174
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68568
      
      Chromium bug: http://code.google.com/p/chromium/issues/detail?id=97243
      
      (This also happens on Safari.)
      
      The problem was that ScrollView::overhangAmount() was returning a full-page overhang due to contentsSize() being 0 briefly during a page load, which was then getting used by ScrollAnimatorChromiumMac.mm to update the overhang on a gesture event. This change makes the relevant logic not return an overhang if the contentsSize() is empty.
      
      Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-26
      Reviewed by Adam Barth.
      
      No new tests, since this is highly timing-related.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::overhangAmount):
      (WebCore::ScrollView::wheelEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9dcd174
    • alex@webkit.org's avatar
      2011-09-26 Alejandro G. Castro <alex@igalia.com> · a3615437
      alex@webkit.org authored
              [GTK] pot file is not properly remove during distcheck
              https://bugs.webkit.org/show_bug.cgi?id=68797
      
              Defined DOMAIN variable before DISTCLEANFILES because we are using
              it there to identify the .pot file.
      
              Reviewed by Martin Robinson.
      
              * GNUmakefile.am:
      
      2011-09-26  Alejandro G. Castro  <alex@igalia.com>
      
              [GTK] pot file is not properly remove during distcheck
              https://bugs.webkit.org/show_bug.cgi?id=68797
      
              DOMAIN is already defined, we just add the value to the variable.
      
              Reviewed by Martin Robinson.
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3615437
    • levin@chromium.org's avatar
      Add skeleton parsing for a WatchList. · 3b48a8fe
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68823
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
      Parses the top level watch list sections -- none are defined yet -- and
      throws an exception if an invalid one is listed.
      * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
      Verify the exception for an invalid section in a watch list.
      * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b48a8fe
    • rniwa@webkit.org's avatar
      Add a failing expectation to the test added by r95964 on Chromium Linux and Chromium Windows. · cded1805
      rniwa@webkit.org authored
      The failure is tracked by the bug 68832.
      
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cded1805
    • ossy@webkit.org's avatar
      [Qt][WK2]Unreviewed speculative buildfix after r95968. · 63cc299b
      ossy@webkit.org authored
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::contentsSizeChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63cc299b
    • wjmaclean@chromium.org's avatar
      [chromium] Revise zoom animator backend to use full transform instead of just scale. · 0beb516e
      wjmaclean@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68535
      
      Reviewed by Kenneth Russell.
      
      Source/WebCore:
      
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      * page/Settings.h:
      (WebCore::Settings::setZoomAnimatorScale):
      (WebCore::Settings::zoomAnimatorScale):
      (WebCore::Settings::setZoomAnimatorPosition):
      (WebCore::Settings::zoomAnimatorPosX):
      (WebCore::Settings::zoomAnimatorPosY):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::LayerRendererChromium):
      (WebCore::LayerRendererChromium::drawLayersInternal):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore::LayerRendererChromium::setZoomAnimatorTransform):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::CCLayerTreeHost):
      (WebCore::CCLayerTreeHost::commitTo):
      (WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
      (WebCore::CCLayerTreeHost::updateLayers):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      * testing/Internals.cpp:
      (WebCore::Internals::setZoomAnimatorTransform):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setZoomLevel):
      (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
      
      LayoutTests:
      
      * platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
      * platform/chromium/compositing/zoom-animator-scale-test.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0beb516e
    • mihaip@chromium.org's avatar
      Layout Test fast/animation/request-animation-frame-timestamps-advance.html is failing · ed168ee0
      mihaip@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68821
      
      Switch test to use finishJSTest(), which handles js-test-post.js loading
      after the test is complete better.
      
      * fast/animation/request-animation-frame-timestamps-advance.html:
      * fast/animation/script-tests/request-animation-frame-timestamps-advance.js:
      (window.webkitRequestAnimationFrame):
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed168ee0
    • commit-queue@webkit.org's avatar
      [CMake] Detect the operating system in a more generic way. · 93f5b484
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67482
      
      Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
      Reviewed by Adam Barth.
      
      So far the buildsystem only considered Windows, Linux and Mac OS X as
      valid operating systems, but any Unix (or at least the BSDs) should also
      work fine.
      
      By using the OS values CMake itself defines we can check for Unix
      systems in a more generic fashion.
      
      * Source/CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93f5b484
    • mitz@apple.com's avatar
      REGRESSION (r95926) Assert firing in svg/clip-path/clip-path-on-svg.svg · 6a470b46
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68819
      
      Reviewed by Dave Hyatt.
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::scheduleRelayout): Revert to using view() instead of the RenderView**
      parameter of isRooted, since only the former returns 0 when the document is detached.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a470b46
    • vsevik@chromium.org's avatar
      Web Inspector: XMLHttpRequest console logging messages should link to network panel when possible. · 3bf20d94
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67399
      
      Reviewed by Pavel Feldman.
      
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
      * inspector/ConsoleMessage.h:
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
      * inspector/front-end/ConsoleMessage.js:
      (WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
      (WebInspector.ConsoleMessage.prototype._formatMessage):
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
      * inspector/front-end/inspector.js:
      (WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
      (WebInspector.linkifyStringAsFragment):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bf20d94
    • demarchi@webkit.org's avatar
      [EFL] Add virtual method to notify user when wrapping focus · 42e47f5c
      demarchi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68699
      
      Reviewed by Antonio Gomes.
      
      Add a virtual method to ewk_view, so the Chrome gets notified if we
      finished focusing all the items and would start over. This way the
      browser can decide to handle the subsequent focus changes among its
      widgets.
      
      * WebCoreSupport/ChromeClientEfl.cpp: call ewk_view's virtual method to
      give it a chance to grab focus
      (WebCore::ChromeClientEfl::canTakeFocus):
      * ewk/ewk_private.h:
      * ewk/ewk_view.cpp: add virtual method
      (ewk_view_focus_can_cycle):
      * ewk/ewk_view.h: add focus direction enum and virtual method
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42e47f5c
    • andersca@apple.com's avatar
      Remove an old DrawingAreaProxy::paint member function · 40dc6711
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68825
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/DrawingAreaProxy.h:
      * UIProcess/DrawingAreaProxyImpl.cpp:
      * UIProcess/DrawingAreaProxyImpl.h:
      * UIProcess/TiledDrawingAreaProxy.cpp:
      * UIProcess/TiledDrawingAreaProxy.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40dc6711
    • mihaip@chromium.org's avatar
      Rebaseline fast/dom/Window/window-resize-contents.html for non-Chromium ports. · 09d0f61b
      mihaip@chromium.org authored
      Previous expected result was Chromium-specific because console line
      numbers were different in JSC.
      
      Additionally, the test doesn't behave as expected for non-Chromium
      ports (window size remains at 800x600). Update the baselines to use
      that for now, so that we're still aware of regressions/progressions.
      
      * fast/dom/Window/window-resize-contents-expected.txt:
      * platform/chromium/fast/dom/Window/window-resize-contents-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-contents-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09d0f61b
    • jer.noble@apple.com's avatar
      White flash when entering full-screen using element.webkitRequestFullScreen() · 17a58cea
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68481
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      No new tests; covered by existing full screen tests.
      
      During an animation, renderers may try to paint into the FullScreenRenderer's
      GraphicsLayer, and an optimization we previously added for the FullScreenRenderer's
      background will cause these paints to fail. Remove this optimization in
      containsPaintedContent, and taking non-composited elements into full screen will
      animate correctly.
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::containsPaintedContent):
      
      Source/WebKit2:
      
      Do not re-enable screen updates after exiting compositing mode until a repaint has completed.
      
      * UIProcess/mac/WKFullScreenWindowController.mm:
      (-[WKFullScreenWindowController exitAcceleratedCompositingMode]):
      (continueExitCompositingModeAfterRepaintCallback):
      (-[WKFullScreenWindowController _continueExitCompositingModeAfterRepaint]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17a58cea
    • mihaip@chromium.org's avatar
      Unreviewed, rolling out r95960. · 162ff9c6
      mihaip@chromium.org authored
      http://trac.webkit.org/changeset/95960
      https://bugs.webkit.org/show_bug.cgi?id=58608
      
      Significantly changes table border rendering
      
      Source/WebCore:
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::drawLineForBoxSide):
      
      LayoutTests:
      
      * fast/borders/border-groove-expected.png: Removed.
      * fast/borders/border-groove-expected.txt: Removed.
      * fast/borders/border-groove.html: Removed.
      * fast/borders/border-inset-expected.png: Removed.
      * fast/borders/border-inset-expected.txt: Removed.
      * fast/borders/border-inset.html: Removed.
      * fast/borders/border-outset-expected.png: Removed.
      * fast/borders/border-outset-expected.txt: Removed.
      * fast/borders/border-outset.html: Removed.
      * fast/borders/border-ridge-expected.png: Removed.
      * fast/borders/border-ridge-expected.txt: Removed.
      * fast/borders/border-ridge.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      162ff9c6
    • mihaip@chromium.org's avatar
      Chromium test expectations update. · 07ec8782
      mihaip@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07ec8782
    • simon.fraser@apple.com's avatar
      Repaint tests don't work in WebKit2 · 87dea525
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68453
      
      Reviewed by Sam Weinig.
      
      Expose WKBundlePage methods to turn on repaint rect tracking
      in WebKit2, for WebKitTestRunner.
      
      As part of the change, expose utility methods on WebPage
      to get the main Frame and FrameView, which required renaming
      the exisiting method that returns a WebFrame. Fix callers
      of that method to handle null when necessary.
      
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      (WKBundlePageGetMainFrame):
      (WKBundlePageSetTracksRepaints):
      (WKBundlePageIsTrackingRepaints):
      (WKBundlePageResetTrackedRepaints):
      (WKBundlePageCopyTrackedRepaintRects):
      * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::findLargestFrameInFrameSet):
      (WebKit::WebChromeClient::closeWindowSoon):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
      (WebKit::WebFrameLoaderClient::dispatchDidLayout):
      (WebKit::WebFrameLoaderClient::frameLoadCompleted):
      (WebKit::WebFrameLoaderClient::restoreViewState):
      (WebKit::WebFrameLoaderClient::provisionalLoadStarted):
      (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
      (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
      (WebKit::WebFrameLoaderClient::createPlugin):
      * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
      (WebKit::WebEditorClient::documentFragmentFromAttributedString):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::isMainFrame):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setTracksRepaints):
      (WebKit::WebPage::isTrackingRepaints):
      (WebKit::WebPage::resetTrackedRepaints):
      (WebKit::WebPage::trackedRepaintRects):
      (WebKit::WebPage::clearMainFrameName):
      (WebKit::WebPage::layoutIfNeeded):
      (WebKit::WebPage::mainFrameHasCustomRepresentation):
      (WebKit::WebPage::mainFrame):
      (WebKit::WebPage::mainFrameView):
      * WebProcess/WebPage/WebPage.h:
      (WebKit::WebPage::mainWebFrame):
      * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
      (-[WKAccessibilityWebPageObject accessibilityHitTest:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87dea525
    • simon.fraser@apple.com's avatar
      Repaint tests don't work in WebKit2 · dfe92f85
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68453
      
      Reviewed by Sam Weinig.
      
      Source/WebCore:
      
      Have FrameView keep track of repaint rects when asked to, and
      expose this set of repaint rects via private WebKit API for later
      use by DumpRenderTree.
      
      The repaint rects are in WebView coordinates, so we have to
      unapply the scroll offset.
      
      * WebCore.exp.in:
      * page/FrameView.cpp:
      (WebCore::FrameView::FrameView):
      (WebCore::FrameView::reset):
      (WebCore::FrameView::repaintContentRectangle):
      (WebCore::FrameView::setTracksRepaints):
      * page/FrameView.h:
      (WebCore::FrameView::isTrackingRepaints):
      (WebCore::FrameView::resetTrackedRepaints):
      (WebCore::FrameView::trackedRepaintRects):
      
      Source/WebKit/mac:
      
      Have FrameView keep track of repaint rects when asked to, and
      expose this set of repaint rects via private WebKit API for later
      use by DumpRenderTree.
      
      * WebView/WebView.mm:
      (-[WebView setTracksRepaints:]):
      (-[WebView isTrackingRepaints]):
      (-[WebView resetTrackedRepaints]):
      (-[WebView trackedRepaintRects]):
      * WebView/WebViewPrivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfe92f85
    • antti@apple.com's avatar
      Optimize matching of common pseudo classes · f7906460
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68633
      
      Reviewed by Dave Hyatt, Darin Adler, Dimitri Glazkov.
              
      :link, :visited and :focus are quite common. They often used as univeral selectors (including in our
      default stylesheet) so we try to match them for all elements in the document. They take always the 
      slow matching path. In addition we match link styles twice due to visited link pseudo style generation
      so the overhead is doubled. As a result substantial portion of our style matching time is spent 
      dealing with these pseudo classes. 
              
      This patch adds new lists to RuleSet for common pseudo class rules. The rules on the lists are only checked
      if the element has approprate type and stat. ases where the rightmost pseudo class can then be rejected immediately.
      We can also enable the fast path checking for the rest of the selector in many cases.
          
      This seems to be >30% progression in selector matching performance with typical style sheets. It saves ~0.9s
      when loading the full HTML5 spec.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
      (WebCore::RuleSet::idRules):
      (WebCore::RuleSet::classRules):
      (WebCore::RuleSet::tagRules):
      (WebCore::RuleSet::shadowPseudoElementRules):
      (WebCore::RuleSet::linkPseudoClassRules):
      (WebCore::RuleSet::visitedPseudoClassRules):
      (WebCore::RuleSet::focusPseudoClassRules):
      (WebCore::RuleSet::universalRules):
      (WebCore::RuleSet::pageRules):
              
          Add a new lists, some stylistic renamings.
          
      (WebCore::CSSStyleSelector::matchRules):
              
          New link and focus checks.
      
      (WebCore::CSSStyleSelector::matchRulesForList):
      (WebCore::CSSStyleSelector::checkSelector):
              
          Inline the rightmost selector tag checking, skip if unnecessary.
              
      (WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
              
          Common pseudo classes now match based on early filtering (though it is not a hash in this case).
      
      (WebCore::RuleData::RuleData):
      (WebCore::RuleSet::~RuleSet):
      (WebCore::RuleSet::addRule):
              
          Sort pseudo classes to new lists.
              
      (WebCore::RuleSet::collectFeatures):
      (WebCore::RuleSet::shrinkToFit):
      (WebCore::CSSStyleSelector::matchPageRules):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkSelector):
              
          Adopt to expanded fast path (this is used by querySelectorAll).
      
      (WebCore::SelectorChecker::fastCheckRightmostSelector):
      (WebCore::SelectorChecker::fastCheckSelector):
              
          Rightmost selector is now checked differently than the rest. RuleSet based selection in CSSStyleSelector
          is equivalent to fastCheckRightmostSelector().
              
      (WebCore::isFastCheckableRelation):
      (WebCore::isFastCheckableMatch):
      (WebCore::isFastCheckableRightmostSelector):
      (WebCore::SelectorChecker::isFastCheckableSelector):
      (WebCore::SelectorChecker::checkOneSelector):
      (WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
      (WebCore::SelectorChecker::isFrameFocused):
      * css/SelectorChecker.h:
      (WebCore::SelectorChecker::isCommonPseudoClassSelector):
      (WebCore::SelectorChecker::linkMatchesVisitedPseudoClass):
      (WebCore::SelectorChecker::matchesFocusPseudoClass):
      (WebCore::SelectorChecker::tagMatches):
              
          Refactor a bunch of shared checks into functions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7906460