1. 29 Aug, 2012 40 commits
    • ggaren@apple.com's avatar
      2012-08-29 Geoffrey Garen <ggaren@apple.com> · f2e86275
      ggaren@apple.com authored
              Try to fix the Windows build.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export!
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2e86275
    • commit-queue@webkit.org's avatar
      [EFL] Unskip 2 willSendRequest tests that are passing consistently · 8fa64321
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95289
      
      Unreviewed EFL gardening.
      
      Unskip the following tests are EFL port:
      fast/loader/onload-willSendRequest-null-for-script.html
      fast/loader/willSendRequest-null-for-preload.html
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-29
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fa64321
    • jchaffraix@webkit.org's avatar
      [Chromium] CCLayerTreeHostTestScrollChildLayer makes the wrong assumptions · 6b105f27
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95358
      
      Unreviewed gardening.
      
      * tests/CCLayerTreeHostTest.cpp:
      Disabled the test until it is fixed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b105f27
    • wangxianzhu@chromium.org's avatar
      '\r's in test expectations files confuse chromium-android layout test driver · 00af37e7
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95353
      
      Reviewed by Adam Barth.
      
      Modified the test cases not to output '\r's.
      Removed the '\r's from expectation files.
      
      * fast/dom/Window/window-property-clearing-expected.txt:
      * fast/dom/Window/window-property-clearing.html:
      * fast/dom/simultaneouslyRegsiteredTimerFireOrder-expected.txt:
      * fast/dom/simultaneouslyRegsiteredTimerFireOrder.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00af37e7
    • jonlee@apple.com's avatar
      Fix ChangeLog · fe6d99ad
      jonlee@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe6d99ad
    • ggaren@apple.com's avatar
      Introduced JSWithScope, making all scope objects subclasses of JSScope · bc3ae3f9
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95295
      
      Reviewed by Filip Pizlo.
      
      This is a step toward removing ScopeChainNode. With a uniform representation
      for objects in the scope chain, we can move data from ScopeChainNode
      into JSScope.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri: Build!
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::privateExecute):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::LLINT_SLOW_PATH_DECL): Use an explicit JSWithScope object
      for 'with' statements. Since 'with' can put any object in the scope
      chain, we'll need an adapter object to hold the data ScopeChainNode
      currently holds.
      
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData): Support for JSWithScope.
      
      * runtime/JSScope.cpp:
      (JSC::JSScope::objectAtScope):
      * runtime/JSScope.h: Check for and unwrap JSWithScope.
      
      * runtime/JSType.h: Support for JSWithScope.
      
      * runtime/StrictEvalActivation.cpp:
      (JSC::StrictEvalActivation::StrictEvalActivation):
      * runtime/StrictEvalActivation.h:
      (StrictEvalActivation): Inherit from JSScope, to make the scope chain uniform.
      
      * runtime/JSWithScope.cpp: Added.
      (JSC::JSWithScope::visitChildren):
      * runtime/JSWithScope.h: Added.
      (JSWithScope):
      (JSC::JSWithScope::create):
      (JSC::JSWithScope::object):
      (JSC::JSWithScope::createStructure):
      (JSC::JSWithScope::JSWithScope): New adapter object. Since this object
      is never exposed to scripts, it doesn't need any meaningful implementation
      of property access or other callbacks.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc3ae3f9
    • jonlee@apple.com's avatar
      [Mac] Add iconURL to WebNotification · b0256ffc
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95249
      <rdar://problem/12192060>
      
      Reviewed by Jessie Berlin.
      
      * WebView/WebNotification.h: Expose iconURL.
      * WebView/WebNotification.mm: Remove unnecessary ASSERTs.
      (-[WebNotification title]):
      (-[WebNotification body]):
      (-[WebNotification tag]):
      (-[WebNotification iconURL]): Added.
      (-[WebNotification origin]):
      (-[WebNotification notificationID]):
      (-[WebNotification dispatchShowEvent]):
      (-[WebNotification dispatchCloseEvent]):
      (-[WebNotification dispatchClickEvent]):
      (-[WebNotification dispatchErrorEvent]):
      
      Reviewed by Jessie Berlin.
      
      * WebView/WebNotification.h: Expose iconURL.
      * WebView/WebNotification.mm:
      (-[WebNotification iconURL]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0256ffc
    • hyatt@apple.com's avatar
      [New Multicolumn] Implement column contents painting. · 535aea52
      hyatt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95251
      
      Reviewed by Simon Fraser.
      
      This patch implements paintColumnContents for the new multicolumn blocks. There are a number of
      improvements made over the current multi-column implementation. They include the fact that left
      and right columns will now be unclipped, so contents of columns can actually spill out of the block now.
      Outlines now also work properly. The contents of the first column and last column can also now overflow
      visually out of the top and bottom of those columns respectively.
      
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::flowThreadPortionRectAt):
      This method returns the exact portion of the flow thread that matches the column dimensions.
      The width and height are the column width and height. It is equivalent to RenderRegion::flowThreadPortionRect,
      but is applied only for a specific column in the set.
      
      (WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
      This method expands the flowThreadPortionRect to unclip the edges of left and right columns, the top and
      bottom edges of first and last columns, and it also expands the painting to go into half of the column
      gap. It is analogous to RenderRegion::flowThreadPortionOverflowRect, but it's doing the right thing
      for each individual column.
      
      (WebCore::RenderMultiColumnSet::paintColumnContents):
      The implementation of column contents painting. Each column is iterated over, and the two rects above
      are computed and passed in to RenderFlowThread::paintFlowThreadPortionInRegion. This code does the right
      thing with offsets and clipping when handed these two rects and handles all of the rest.
      
      * rendering/RenderMultiColumnSet.h:
      Declare the new functions that return the flow thread portion rects.
      
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::flowThreadPortionOverflowRect):
      (WebCore):
      (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
      * rendering/RenderRegion.h:
      (RenderRegion):
      * rendering/RenderRegionSet.cpp:
      Refactor this so that it can be invoked by column sets and operate on the first and last columns instead
      of only being tied to the first and last regions.
      
      (WebCore::RenderRegionSet::expandToEncompassFlowThreadContentsIfNeeded):
      Fix a bug here where the flowThread.y() should not have been subtracted. We're in local flow thread
      coordinates.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      535aea52
    • jchaffraix@webkit.org's avatar
      Unreviewed gardening. · f23a984e
      jchaffraix@webkit.org authored
      * platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
      Added missing baseline for this test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f23a984e
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r126972. · 6aa5c7e9
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/126972
      https://bugs.webkit.org/show_bug.cgi?id=95349
      
      accessibility/canvas-description-and-role.html has been
      failing consistently on several bots and Dominic needs some
      time to investigate why (Requested by jchaffraix on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-29
      
      Source/WebCore:
      
      * accessibility/AccessibilityNodeObject.cpp:
      * accessibility/AccessibilityNodeObject.h:
      * accessibility/AccessibilityObject.h:
      (AccessibilityObject):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityDescription):
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::canHaveChildren):
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper role]):
      
      Source/WebKit/chromium:
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      Source/WebKit/win:
      
      * AccessibleBase.cpp:
      (MSAARole):
      
      Tools:
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString):
      
      LayoutTests:
      
      * accessibility/canvas-description-and-role.html: Removed.
      * accessibility/canvas-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/canvas-expected.txt.
      * accessibility/canvas.html: Renamed from LayoutTests/platform/mac/accessibility/canvas.html.
      * platform/chromium/accessibility/canvas-description-and-role-expected.txt: Removed.
      * platform/gtk/TestExpectations:
      * platform/mac/accessibility/canvas-description-and-role-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aa5c7e9
    • vsevik@chromium.org's avatar
      Web Inspector: Minor ResourceScriptMapping polish. · ca4eb30b
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95350
      
      Reviewed by Alexander Pavlov.
      
      Added some compiler annotations.
      ResourceScriptMapping is no longer a UISourceCodeProvider, removed unused methods and obsolete compiler annotations.
      
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca4eb30b
    • vsevik@chromium.org's avatar
      Web Inspector: Minor debugger-test polish. · d14ac77a
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95348
      
      Reviewed by Alexander Pavlov.
      
      Added meaningful assertion messages to facilitate debugging.
      Added meaningful mimeType to script mock.
      
      * http/tests/inspector/debugger-test.js:
      (initialize_DebuggerTest.):
      (initialize_DebuggerTest):
      * inspector/debugger/raw-source-code-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d14ac77a
    • rakuco@webkit.org's avatar
      [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build · eefa73d8
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84707
      
      Reviewed by Gustavo Noronha Silva.
      
      Most of the warnings have been fixed now that FindCairo.cmake and
      FindGLIB.cmake have been rewritten. The remaining one, related to
      FindFontconfig.cmake, shows up when building on a 64-bit
      Debian-based systems.
      
      jhbuild installs libraries into lib64/ by default on 64-bit Linux
      installations, while CMake does not look for libraries in lib64/
      when /etc/debian_version exists on the system. The FIND_LIBRARY()
      would then sometimes end up using the system installation instead of
      the jhbuild one, causing mismatches and, when pkg-config is not used
      at all, failing to find libraries altogether.
      
      * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
      when use_lib64 is set to force CMake to look into lib64/ regardless
      of the presence of /etc/debian_version.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eefa73d8
    • vsevik@chromium.org's avatar
      Web Inspector: Extract StylesSourceMapping from StylesUISourceCodeProvider. · cb9d7df6
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95345
      
      Reviewed by Alexander Pavlov.
      
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * inspector/compile-front-end.py:
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping): Drive-by: ResourceScriptMapping now uses workspace object passed in parameters, not the global one.
      (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
      (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
      * inspector/front-end/StylesSourceMapping.js: Copied from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
      (WebInspector.StylesSourceMapping):
      (WebInspector.StylesSourceMapping.prototype.addUISourceCode):
      (WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
      (WebInspector.StylesSourceMapping.prototype.uiLocationToRawLocation):
      (WebInspector.StylesSourceMapping.prototype.reset):
      * inspector/front-end/StylesUISourceCodeProvider.js:
      (WebInspector.StylesUISourceCodeProvider):
      (WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
      (WebInspector.StylesUISourceCodeProvider.prototype._reset): Drive-by: _populate is now called with setTimeout.
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb9d7df6
    • dominik.rottsches@intel.com's avatar
      The 2d.imageData.object.round canvas test is failing · 369b35be
      dominik.rottsches@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=40272
      
      Reviewed by Benjamin Poulain.
      
      Source/WTF:
      
      Updating previous patch to address Benjamin's comments.
      #ifdef in Uint8ClampedArray removed, fallback implementation for MSVC on non-X86 added.
      
      * wtf/MathExtras.h:
      (lrint): Fallback implementation for non-X86 & MSVC case.
      * wtf/Uint8ClampedArray.h: Removed #ifdef.
      
      Tools:
      
      Updating patch to address Benjamin's review comments.
      Adding a WTF test to test lrint implementation.
      
      * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
      * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
      * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
      * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
      (TestWebKitAPI):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      369b35be
    • apavlov@chromium.org's avatar
      Web Inspector: Page with @import and :last-child in an edited stylesheet will crash · faaf2458
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95324
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Ensure the destroyed StyleRules removal from StyleResolver by creating a separate RuleMutationScope for clearing the StyleSheetContents.
      
      Test: inspector/styles/import-pseudoclass-crash.html
      
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::reparseStyleSheet):
      
      LayoutTests:
      
      * inspector/styles/import-pseudoclass-crash-expected.txt: Added.
      * inspector/styles/import-pseudoclass-crash.html: Added.
      * inspector/styles/resources/import-pseudoclass-crash-empty.css: Added.
      * inspector/styles/resources/import-pseudoclass-crash.css: Added.
      (:last-child):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faaf2458
    • vsevik@chromium.org's avatar
      Web Inspector: Turn workspace into a container of UiSourceCodes put in different projects. · 2d3a2083
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95335
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Workspace now contains a project that could be filled with uiSourceCodes.
      Workspace project is still filled by script / style mappings as before.
      The next step would be to extract NetworkUISourceCodeProvider.
      
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager):
      * inspector/front-end/CompilerScriptMapping.js:
      (WebInspector.CompilerScriptMapping):
      (WebInspector.CompilerScriptMapping.prototype._reset):
      * inspector/front-end/DebuggerScriptMapping.js:
      (WebInspector.DebuggerScriptMapping):
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping):
      (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
      (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
      (WebInspector.ResourceScriptMapping.prototype._reset):
      * inspector/front-end/RevisionHistoryView.js:
      (WebInspector.RevisionHistoryView):
      * inspector/front-end/SASSSourceMapping.js:
      (WebInspector.SASSSourceMapping):
      (_bindUISourceCode):
      (rawLocationToUILocation):
      (_reset):
      * inspector/front-end/ScriptSnippetModel.js:
      (WebInspector.ScriptSnippetModel):
      (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
      (WebInspector.ScriptSnippetModel.prototype.deleteScriptSnippet):
      (WebInspector.SnippetScriptMapping.prototype.addScript):
      * inspector/front-end/ScriptsPanel.js:
      (WebInspector.ScriptsPanel):
      * inspector/front-end/StylesUISourceCodeProvider.js:
      (WebInspector.StylesUISourceCodeProvider):
      (WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
      (WebInspector.StylesUISourceCodeProvider.prototype._reset):
      * inspector/front-end/Workspace.js:
      (WebInspector.WorkspaceController):
      (WebInspector.WorkspaceController.prototype._mainFrameNavigated):
      (WebInspector.Project):
      (WebInspector.Project.prototype.reset):
      (WebInspector.Project.prototype.addUISourceCode):
      (WebInspector.Project.prototype.replaceUISourceCode):
      (WebInspector.Project.prototype.removeUISourceCode):
      (WebInspector.Project.prototype.uiSourceCodeForURL):
      (WebInspector.Project.prototype.uiSourceCodes):
      (WebInspector.Workspace):
      (WebInspector.Workspace.prototype.uiSourceCodeForURL):
      (WebInspector.Workspace.prototype.project):
      (WebInspector.Workspace.prototype.uiSourceCodes):
      * inspector/front-end/inspector.js:
      
      LayoutTests:
      
      * http/tests/inspector/compiler-script-mapping.html:
      * inspector/debugger/breakpoint-manager.html:
      * inspector/debugger/script-snippet-model.html:
      * inspector/debugger/scripts-panel.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d3a2083
    • hausmann@webkit.org's avatar
      [Qt] Fix doc generation with make docs · 1069635f
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95340
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Fix doc target, similar to what the other Qt 5 modules are using and comment out the indexes
      line, because cross-referencing doesn't work right now and the use of the QTDIR environment
      is wrong, too.
      
      * docs/docs.pri:
      * docs/qtwebkit.qdocconf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1069635f
    • fmalita@chromium.org's avatar
      Unreviewed, updating Kelly Norton's email address at his request. · 7c70ce9c
      fmalita@chromium.org authored
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c70ce9c
    • tonikitoo@webkit.org's avatar
      [BlackBerry] crash while trying to scroll any inner frame · 30572982
      tonikitoo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95287
      PR #198510
      
      Reviewed by George Staikos.
      Patch by Antonio Gomes <agomes@rim.com>
      
      Set the starting point of scrolling (slow path only still)
      for inner frames. It was left over as set to 0 by r126474.
      
      In practice, patch fixes a crash on gmail.com desktop edition.
      
      * WebKitSupport/InRegionScrollableArea.cpp:
      (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30572982
    • kadam@inf.u-szeged.hu's avatar
      [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908 · 5690e7c8
      kadam@inf.u-szeged.hu authored
      https://bugs.webkit.org/show_bug.cgi?id=95329
      
      Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-08-29
      Reviewed by Csaba Osztrogonác.
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5690e7c8
    • dominik.rottsches@intel.com's avatar
      [EFL] Unreviewed EFL gardening. · 89930d8e
      dominik.rottsches@intel.com authored
      Moving fast/forms/color/input-value-sanitization-color.html out as flaky.
      
      * platform/efl-wk2/TestExpectations: Flakily crashing test marked.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89930d8e
    • fmalita@chromium.org's avatar
      Incorrect large-area clipping · 6e98f5a1
      fmalita@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95197
      
      Reviewed by Nikolas Zimmermann.
      
      Source/WebCore:
      
      ImageBuffers allocated for clipping and masking are clamped to kMaxImageBufferSize max
      (4096x4096). In order to properly account for the scaling factor introduced by this
      clamping, the repaintRect translation component needs to be pushed after the scaling
      transform.
      
      Tests: svg/custom/clamped-masking-clipping-expected.svg
             svg/custom/clamped-masking-clipping.svg
      
      * rendering/svg/SVGRenderingContext.cpp:
      (WebCore::SVGRenderingContext::createImageBuffer):
      
      LayoutTests:
      
      * svg/custom/clamped-masking-clipping-expected.svg: Added.
      * svg/custom/clamped-masking-clipping.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e98f5a1
    • kkristof@inf.u-szeged.hu's avatar
      [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files · 3d42e089
      kkristof@inf.u-szeged.hu authored
      https://bugs.webkit.org/show_bug.cgi?id=93723
      
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (TestExpectationParser.expectation_for_skipped_test):
      * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
      (SkippedTests.test_skipped_entry_dont_exist):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d42e089
    • dominik.rottsches@intel.com's avatar
      [EFL] Move known crash issue to TestExpectations · c8753dc0
      dominik.rottsches@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95327
      
      Unreviewed, EFL gardening.
      
      Moving out x-frame-options-deny-meta-tag-in-body.html with details discussed in bug 94458.
      
      
      * platform/efl/TestExpectations: Marked crash issue, discussed in bug 94458.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8753dc0
    • paroga@webkit.org's avatar
      Unreviewed. Build fix for !ENABLE(JIT) after r126962. · 3ecfcc01
      paroga@webkit.org authored
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::privateExecute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ecfcc01
    • yurys@chromium.org's avatar
      Web Inspector: unsafe static_cast in RetainedDOMInfo::IsEquivalent · e4c71968
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95315
      
      Reviewed by Vsevolod Vlasov.
      
      * bindings/v8/RetainedDOMInfo.cpp:
      (WebCore::RetainedDOMInfo::IsEquivalent): compare retained object info
      labels before casting v8::RetainedObjectInfo to WebCore::RetainedObjectInfo
      as the |other| object may not be a descendant of WebCore::RetainedObjectInfo.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4c71968
    • dominik.rottsches@intel.com's avatar
      [EFL] Unreviewed EFL gardening. · ed190dbe
      dominik.rottsches@intel.com authored
      EFL requires a newline at the end of the test expectations here.
      
      * platform/efl/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed190dbe
    • ryuan.choi@samsung.com's avatar
      [EFL] Add *explicit* keyword to constructors in WebCoreSupport · 564d3fc2
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95307
      
      Reviewed by Kentaro Hara.
      
      Added explicit keyword in constructors in order to avoid implicit type conversion.
      
      * WebCoreSupport/ColorChooserEfl.h:
      (ColorChooserEfl):
      * WebCoreSupport/PopupMenuEfl.h:
      (PopupMenuEfl):
      * WebCoreSupport/SearchPopupMenuEfl.h:
      (SearchPopupMenuEfl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      564d3fc2
    • jochen@chromium.org's avatar
      REGRESSION(r126816): Missing includes when compiling without SVG · 96dee770
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95312
      
      Reviewed by Eric Seidel.
      
      * rendering/FilterEffectRenderer.h:
      * rendering/RenderLayerFilterInfo.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96dee770
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r120113. · facfc563
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/120113
      https://bugs.webkit.org/show_bug.cgi?id=95320
      
      Wrong fix for the problem, experimentally rolling it out for
      bug 95237. (Requested by rakuco on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-29
      
      * efl/jhbuildrc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      facfc563
    • abarth@webkit.org's avatar
      Improve string efficiency using StringBuilder and StringOperations · 956b9c2f
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95304
      
      Reviewed by Eric Seidel.
      
      As recommended by http://trac.webkit.org/wiki/EfficientStrings.
      
      * css/CSSLineBoxContainValue.cpp:
      (WebCore::CSSLineBoxContainValue::customCssText):
      * css/CSSPropertySourceData.cpp:
      (WebCore::CSSPropertySourceData::toString):
      * css/MediaList.cpp:
      (WebCore::MediaQuerySet::mediaText):
      * css/ShadowValue.cpp:
      (WebCore::ShadowValue::customCssText):
      * dom/MicroDataItemList.cpp:
      (WebCore::MicroDataItemList::undefinedItemType):
      * editing/HTMLInterchange.cpp:
      (WebCore::convertedSpaceString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      956b9c2f
    • dominik.rottsches@intel.com's avatar
      [EFL] Clean up Skipped file · afeff501
      dominik.rottsches@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95306
      
      Unreviewed EFL gardening.
      
      Remove from Skipped list several test cases that are now passing
      consistently on EFL port. Some other tests have been moved to
      TestExpectations since we need to get rid of the Skipped list
      progressively.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-29
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/Skipped:
      * platform/efl/TestExpectations:
      * platform/efl/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
      * platform/efl/editing/selection/extend-selection-bidi-expected.png: Added.
      * platform/efl/editing/selection/extend-selection-bidi-expected.txt: Added.
      * platform/efl/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
      * platform/efl/fast/forms/color/input-color-onchange-event-expected.txt: Added.
      * platform/efl/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
      * platform/efl/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
      * platform/efl/fast/replaced/object-with-embed-url-param-expected.txt: Added.
      * platform/efl/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
      * platform/efl/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afeff501
    • commit-queue@webkit.org's avatar
      [EFL] Rebaseline after r126864 · db969330
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95278
      
      Unreviewed, rebaseline.
      
      Updated range with datalist pixel test expectations because slider theme is changed.
      
      Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-29
      
      * platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
      * platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db969330
    • commit-queue@webkit.org's avatar
      [chromium] Use floating point literals in expressions that initialize floats · ff3ba4e5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95293
      
      Patch by James Robinson <jamesr@chromium.org> on 2012-08-29
      Reviewed by Adam Barth.
      
      Visual studio's C4305, which is on for some chromium code, complains about these.
      
      * platform/graphics/chromium/cc/CCLayerSorter.cpp:
      (WebCore::CCLayerSorter::createGraphEdges):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::scrollBy):
      (WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff3ba4e5
    • peter@chromium.org's avatar
      Unreviewed. Rolled DEPS. · 6d17439b
      peter@chromium.org authored
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d17439b
    • vsevik@chromium.org's avatar
      Web Inspector: Extract StylesUISourceCodeProvider to separate file. · ca94306a
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95319
      
      Reviewed by Alexander Pavlov.
      
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj: Also added WebGLProfiler files forgotten before.
      * inspector/compile-front-end.py:
      * inspector/front-end/StyleSource.js:
      * inspector/front-end/StylesUISourceCodeProvider.js: Copied from Source/WebCore/inspector/front-end/StyleSource.js.
      (WebInspector.StylesUISourceCodeProvider):
      (WebInspector.StylesUISourceCodeProvider.prototype.uiSourceCodes):
      (WebInspector.StylesUISourceCodeProvider.prototype.rawLocationToUILocation):
      (WebInspector.StylesUISourceCodeProvider.prototype.uiLocationToRawLocation):
      (WebInspector.StylesUISourceCodeProvider.prototype._populate):
      (WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
      (WebInspector.StylesUISourceCodeProvider.prototype.reset):
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca94306a
    • pdr@google.com's avatar
      Use SVGImage instead of cached image when drawing without a render tree. · 81e9c6cd
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95002
      
      Reviewed by Nikolas Zimmermann.
      
      Source/WebCore:
      
      Previously if we tried to use canvas.context2d.drawImage() with an SVG image
      that was not in the render tree, we would crash. This patch changes this behavior
      so that we use SVGImage::draw() to draw images that are not in the render tree.
      
      Test: svg/as-image/svg-canvas-draw-image-detached.html
      
      * svg/graphics/SVGImageCache.cpp:
      (WebCore::SVGImageCache::requestedSizeAndScales):
      (WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
      
      LayoutTests:
      
      * svg/as-image/svg-canvas-draw-image-detached-expected.txt: Added.
      * svg/as-image/svg-canvas-draw-image-detached.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81e9c6cd
    • hausmann@webkit.org's avatar
      [Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails · e52dea9b
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93897
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Before r125428 run-time methods (wrapped signals, slots or invokable
      functions) were subclasses of JSInternalFunction and therefore real
      function objects in the JavaScript sense. r125428 changed them to be
      just callable objects, but they did not have Function.prototype as
      prototype anymore for example nor was their name correct (resulting in
      a layout test failure).
      
      This patch changes run-time methods back to being real function objects
      that have a correct name and have Function.prototype in their prototype
      change
      
      The objects returned by JSObjectMakeFunctionWithCallbackInjected are
      light-weight internal function objects that do not support
      JSObject{Set/Get}Private. Therefore we inject our own prototype right
      before the Function.prototype prototype, which uses private data to
      store a pointer to our C++ QtRuntimeMethod object.  This complicates
      the retrieval of the pointer to that instance slightly, which is why
      this patch introduces the toRuntimeMethod convenience function that
      looks up our prototype first and does a check for type-safety.
      
      At the same time the patch removes the length properties from the
      run-time method itself as well as connect/disconnect.  The length
      property on a function signifies the number of arguments, but in all
      three cases that number is actually variable, because of overloading.
      That is why we choose not to expose it in the first place.
      
      In QtInstance we cache the JS wrapper objects for QtRuntimeMethod in a
      JSWeakObjectMap. JSWeakObjectMap requires the stored objects to be
      either the result of JSObjectMake or the global object of a context ref
      (AFAICS), which is ensured using an ASSERT. Objects created via
      JSObjectMakeFunctionWithCalllback do not fall into the required
      category, cause a failing assertion and can therefore not be stored in
      the weak object map.
      
      Consequently this patch removes the use of JSWeakObjectMap again and
      goes back to the old way of using the internal Weak<> API, for the time
      being. In a future patch the storage will be simplified to not require
      the use of a weak object map cache for the run-time methods anymore.
      
      * bridge/qt/qt_instance.cpp: Remove unused WeakMap code.
      * bridge/qt/qt_instance.h: Remove method cache.
      (QtInstance):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::prototypeForSignalsAndSlots):
      (JSC::Bindings::QtRuntimeMethod::call):
      (JSC::Bindings::QtRuntimeMethod::jsObjectRef):
      (JSC::Bindings::QtRuntimeMethod::toRuntimeMethod):
      (Bindings):
      (JSC::Bindings::QtRuntimeMethod::connectOrDisconnect):
      * bridge/qt/qt_runtime.h:
      (QtRuntimeMethod): Remove unused member variables.
      
      Source/WebKit/qt:
      
      Fixed some test expectations.
      
      * tests/qobjectbridge/tst_qobjectbridge.cpp:
      (tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
      can go back to testing Function.prototype.call, as it was done before r125428.
      (tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
      (tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
      run-time methods back to being non-configurable, as before r125428.
      
      LayoutTests:
      
      * platform/qt/Skipped: Unskip test that is now passing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e52dea9b
    • loislo@chromium.org's avatar
      Unreviewed: Single line build fix. · 31239d0f
      loislo@chromium.org authored
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::reportMemoryUsage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31239d0f