1. 26 Jul, 2011 1 commit
  2. 25 Jul, 2011 1 commit
    • mrobinson@webkit.org's avatar
      Reviewed by Gustavo Noronha Silva. · ee95f301
      mrobinson@webkit.org authored
      [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
      https://bugs.webkit.org/show_bug.cgi?id=62252
      
      Source/WebCore:
      
      Properly handle the situation where the GtkWidget wants WebCore to draw its
      own main frame scrollbars.
      
      * platform/gtk/ScrollViewGtk.cpp:
      (WebCore::shouldCreateMainFrameScrollbar): Abstract this logic into a helper function.
      (WebCore::ScrollView::createScrollbar): Use the new helper.
      (WebCore::ScrollView::visibleContentRect): Use the new helper.
      
      Source/WebKit/gtk:
      
      Added an undocumented self-scrolling property to WebKitWebView which
      communicates to WebCore whether or not this widget is expected to draw
      its own main frame scrollbars or not.
      
      * webkit/webkitwebview.cpp: Add the self-scrolling property.
      * webkit/webkitwebviewprivate.h: Add the selfScrolling private member.
      
      Tools:
      
      Add a new subclass of WebKitWebView that overrides the size request to
      return 1 pixel by 1 pixel. This ensure that it operates properly when
      not packed into a GtkScrolledWindow. Also construct the WebKitWebView
      with self-scrolling set to true.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
      (createWebView): Ditto.
      (main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.
      * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.
      (self_scrolling_webkit_web_view_class_init):
      (self_scrolling_webkit_web_view_init):
      (self_scrolling_webkit_web_view_new):
      (sizeRequestMethod):
      (getPreferredSizeMethod):
      * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
      * GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.
      
      LayoutTests:
      
      Unskip tests which are now passing and update results for tests which
      previously had incorrect results.
      
      * platform/gtk/Skipped: Unskip now-passing tests.
      * platform/gtk/fast/css/MarqueeLayoutTest-expected.png:
      * platform/gtk/fast/css/MarqueeLayoutTest-expected.txt:
      * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
      * platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.png:
      * platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
      * platform/gtk/fast/flexbox/flex-hang-expected.png:
      * platform/gtk/fast/flexbox/flex-hang-expected.txt:
      * platform/gtk/fast/forms/search-vertical-alignment-expected.png:
      * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
      * platform/gtk/fast/forms/searchfield-heights-expected.png:
      * platform/gtk/fast/forms/searchfield-heights-expected.txt:
      * platform/gtk/fast/forms/textfield-overflow-expected.png:
      * platform/gtk/fast/forms/textfield-overflow-expected.txt:
      * platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
      * platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
      * platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
      * platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
      * platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
      * platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
      * platform/gtk/fast/frames/inline-object-inside-frameset-expected.png: Added.
      * platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
      * platform/gtk/fast/lists/001-vertical-expected.png: Added.
      * platform/gtk/fast/lists/001-vertical-expected.txt:
      * platform/gtk/fast/multicol/float-multicol-expected.png: Added.
      * platform/gtk/fast/multicol/float-multicol-expected.txt:
      * platform/gtk/fast/multicol/table-vertical-align-expected.png: Added.
      * platform/gtk/fast/multicol/table-vertical-align-expected.txt:
      * platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
      * platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
      * platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
      * platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
      * platform/gtk/tables/mozilla/bugs/bug145572-expected.png:
      * platform/gtk/tables/mozilla/bugs/bug145572-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee95f301
  3. 19 Jul, 2011 1 commit
    • kov@webkit.org's avatar
      [GTK] Google Calendar thinks we're mobile · adab7955
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63994
      
      Patch by Gustavo Noronha Silva  <gns@gnome.org> on 2011-07-11
      Reviewed by Xan Lopez.
      
      Further special-case Google Calendar, for it thinks WebKit+Linux
      means mobile, so we also have to spoof the OS.
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
      private API that centralizes the logic now.
      * tests/testwebsettings.c: Add tests to make sure the Google
      special-cases only apply for the expected domains and when quirks
      special-casing is enabled.
      (test_non_quirky_user_agents):
      (test_webkit_web_settings_user_agent):
      * webkit/webkitwebsettings.cpp:
      (webkitUserAgent): make it static.
      (safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
      (initializeDomainsList): moved from FrameLoaderClientGtk.
      (isGoogleDomain):ditto.
      (isGoogleCalendar): ditto.
      (userAgentForURL): ditto.
      (webkitWebSettingsUserAgentForUri): centralize the whole
      user agent spoofing logic in this new private API that can be used
      by the browser to know what's going to happen for a specific URI
      and also allows our API testing.
      * webkit/webkitwebsettingsprivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adab7955
  4. 15 Jul, 2011 2 commits
    • mitz@apple.com's avatar
      REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides · bf4519a5
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64615
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::enteredFullscreen): Hide the mouse cursor immediately when
      entering full screen.
      (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide the mouse cursor when
      hiding the HUD.
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::setCursorHiddenUntilMouseMoves): Added empty implementation.
      * page/Chrome.cpp:
      (WebCore::Chrome::setCursorHiddenUntilMouseMoves): Added. Calls through to the client.
      * page/Chrome.h:
      * page/ChromeClient.h:
      * platform/HostWindow.h:
      
      Source/WebKit/chromium: 
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.
      * src/ChromeClientImpl.h:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/haiku: 
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/ChromeClientHaiku.h:
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
      +[NSCursor setHiddenUntilMouseMoves:].
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/ChromeClientQt.h:
      (WebCore::ChromeClientQt::setCursorHiddenUntilMouseMoves): Added this stub.
      
      Source/WebKit/win: 
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince: 
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit/wx: 
      
      * WebKitSupport/ChromeClientWx.h:
      (WebCore::ChromeClientWx::setCursorHiddenUntilMouseMoves): Added this stub.
      
      Source/WebKit2: 
      
      * UIProcess/API/efl/PageClientImpl.cpp:
      (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added this stub.
      * UIProcess/API/efl/PageClientImpl.h:
      * UIProcess/API/gtk/PageClientImpl.cpp:
      (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Ditto.
      * UIProcess/API/gtk/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::setCursorHiddenUntilMouseMoves): Added. Calls +[NSCursor setHiddenUntilMouseMoves:].
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves): Added. Calls through to the PageClient.
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in: Added SetCursorHiddenUntilMouseMoves message.
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::setCursorHiddenUntilMouseMoves): Added this stub.
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Sends SetCursorHiddenUntilMouseMoves message
      to the page proxy.
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf4519a5
    • mrobinson@webkit.org's avatar
      Build fixes for WebKit2. Ensure that all generated sources are · 26c1c9a6
      mrobinson@webkit.org authored
      on nodist primaries, that they are on forward declared variables
      so that BUILT_SOURCES is calculated properly and that zlib is
      included during linking (for WOFF support).
      
      .:
      
      * GNUmakefile.am:
      * Source/autotools/webkit.m4: Include test for zlib.
      
      Source/WebKit/gtk:
      
      * GNUmakefile.am:
      
      Source/WebKit2:
      
      * GNUmakefile.am:
      
      Tools:
      
      * WebKitTestRunner/GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26c1c9a6
  5. 14 Jul, 2011 1 commit
  6. 12 Jul, 2011 1 commit
    • joepeck@webkit.org's avatar
      ApplicationCache update should not immediately fail when reaching per-origin quota · 98b3b582
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64177
      
      Reviewed by Alexey Proskuryakov.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              Include spaceNeeded information in the output dumped for appcache quota delegates.
              Add and update tests related to handling of per-origin quotas.
      
              * http/tests/appcache/origin-quota-continued-download-expected.txt: Added.
              * http/tests/appcache/origin-quota-continued-download.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download.manifest: Added.
              New test which checks that there will still be a successful cache
              when the per-origin quota is reached and increased at the end of downloading.
      
              * http/tests/appcache/origin-quota-continued-download-multiple-manifests-expected.txt: Added.
              * http/tests/appcache/origin-quota-continued-download-multiple-manifests.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-1.manifest: Added.
              * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download-multiple-manifests-2.manifest: Added.
              * http/tests/appcache/resources/quota-origin-continued-download.html: Added.
              * http/tests/appcache/resources/quota-origin-continued-download.manifest: Added.
              New test which checks that the spaceNeeded appropriately lists enough space for
              multiple manifests across multiple frames for the same origin.
      
              * http/tests/appcache/resources/quota-origin-iframe-3.manifest: Fix a typo.
              * http/tests/appcache/origin-quota.html:
              Update the old test to disallow automatic increase of the quota,
              which is the default handling of DRT when reaching the quota.
      
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
              * platform/wk2/Skipped:
              Skip the test on ports that don't implement ApplicationCache per-origin quotas.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              New behavior of handling ApplicationCache per-origin quotas. Previously,
              if the quota was reached while downloading we would fail the download
              and then prompt the user for a storage increase. This required a refresh,
              a redownload of resources, and the total storage was not known so the
              process could be repeated multiple times before an acceptable quota
              was found or the user disallowed an increase.
      
              The new behavior is to complete the download of the entire appcache.
              When the cache completes downloading and it is greater than the origin
              quota, prompt the user to allow a quota increase with the known space
              needed. If the quota is increased, the cache will succeed, otherwise
              it will fail with the normal failure steps.
      
              An alternative behavior is prompting while downloading immediately
              when the origin quota is reached, however at that point the entire
              space needed is unknown and so quota increases might not be enough
              and could result in multiple prompts to the user.
      
              Tests: http/tests/appcache/origin-quota-continued-download-multiple-manifests.html
                     http/tests/appcache/origin-quota-continued-download.html
      
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
              Rename instance variable to be more clear on its intent.
      
              (WebCore::ApplicationCacheGroup::didFinishLoading):
              Check the quota limit while downloading so we can fail early
              if the user already denied a quota increase.
      
              (WebCore::ApplicationCacheGroup::didReachOriginQuota):
              Pass the space needed information to the chrome client.
      
              (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota):
              Removed. Instead convert the callers to update state and console
              log when the per-origin quota is reached. This allows us to follow
              the normal failure steps if the quota is reached at the end of a
              download, and the alternative short path when we fail during downloading.
      
              (WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota):
              Extract to a helper function.
      
              (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
              Allow for a quota increase at the end of the download now that
              we know the space needed. Then proceed to fail or succeed
              as we normally would.
      
              * loader/appcache/ApplicationCacheStorage.h:
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::checkOriginQuota):
              (WebCore::ApplicationCacheStorage::storeNewestCache):
              Extract checking the origin quota for when an ApplicationCacheGroup
              will be replacing an ApplicationCacheGroup into a helper function.
              The helper also provides an out parameter for the space needed
              to properly fit the new cache group if it wouldn't fit.
      
              * page/ChromeClient.h:
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota):
              Add a space needed parameter when reaching the per-origin quota.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              * WebView/WebUIDelegatePrivate.h:
              * DefaultDelegates/WebDefaultUIDelegate.m:
              (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
              Update the delegate to include a space needed parameter.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::reachedApplicationCacheOriginQuota):
              Call the delegate with the new space needed information.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              * Api/qwebpage.cpp:
              * Api/qwebpage.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
              * WebCoreSupport/ChromeClientQt.h:
              Pass the spaceNeeded value through to the applicationCacheQuotaExceeded signal.
      
      2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
      
              Add layoutTestController.disallowIncreaseForApplicationCacheQuota()
              to disable the default behavior of raising the default per-origin
              quota to 5MB when reached. This allows us to test what happens
              when the quota is reached and not increased.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (disallowIncreaseForApplicationCacheQuotaCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
              (LayoutTestController::setDisallowIncreaseForApplicationCacheQuota):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
              (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
              Expose a function to prevent automatically increasing the per-origin
              quota when the quota is reached. This allows us to test what happens
              when a user would "disallow" a quota increase.
      
              * DumpRenderTree/mac/UIDelegate.mm:
              (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
              Respect the new disallowIncrease flag and dump the spaceNeeded values
              for ports that implement application cache quotas.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98b3b582
  7. 11 Jul, 2011 1 commit
  8. 08 Jul, 2011 1 commit
  9. 01 Jul, 2011 1 commit
    • joone.hur@collabora.co.uk's avatar
      2011-07-01 Joone Hur <joone.hur@collabora.co.uk> · 0e25eeaf
      joone.hur@collabora.co.uk authored
              Reviewed by Martin Robinson.
      
              [GTK] Add DeviceOrientation feature
              https://bugs.webkit.org/show_bug.cgi?id=63720
      
              Add configure option to enable/disable DeviceOrientation feature.
      
              * configure.ac:
      2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add DeviceOrientation feature
              https://bugs.webkit.org/show_bug.cgi?id=63720
      
              Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.
      
              * GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.
      2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add DeviceOrientation feature
              https://bugs.webkit.org/show_bug.cgi?id=63720
      
              Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.
      
              * GNUmakefile.am:
              * WebCoreSupport/DeviceMotionClientGtk.cpp: Added.
              (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk):
              (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk):
              (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed):
              (WebCore::DeviceMotionClientGtk::setController):
              (WebCore::DeviceMotionClientGtk::startUpdating):
              (WebCore::DeviceMotionClientGtk::stopUpdating):
              (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
              * WebCoreSupport/DeviceMotionClientGtk.h: Added.
              * WebCoreSupport/DeviceOrientationClientGtk.cpp: Added.
              (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk):
              (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk):
              (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed):
              (WebCore::DeviceOrientationClientGtk::setController):
              (WebCore::DeviceOrientationClientGtk::startUpdating):
              (WebCore::DeviceOrientationClientGtk::stopUpdating):
              (WebCore::DeviceOrientationClientGtk::lastOrientation):
              * WebCoreSupport/DeviceOrientationClientGtk.h: Added.
              * webkit/webkitwebview.cpp:
              (webkit_web_view_init):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e25eeaf
  10. 28 Jun, 2011 1 commit
    • joone.hur@collabora.co.uk's avatar
      2011-06-28 Joone Hur <joone.hur@collabora.co.uk> · 8f628103
      joone.hur@collabora.co.uk authored
              Reviewed by Martin Robinson.
      
              [GTK] Allow to build WebKitGtk+ with accelerated compositing
              https://bugs.webkit.org/show_bug.cgi?id=63404
      
              WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
              and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.
      
              * GNUmakefile.list.am:
              * platform/graphics/clutter/GraphicsLayerClutter.cpp: Added.
              (WebCore::GraphicsLayer::create): Not implemented yet.
              (WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
              (WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
              (WebCore::GraphicsLayerClutter::setNeedsDisplay): Ditto.
              (WebCore::GraphicsLayerClutter::setNeedsDisplayInRect): Ditto.
              * platform/graphics/clutter/GraphicsLayerClutter.h: Added.
      2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Allow to build WebKitGtk+ with accelerated compositing
              https://bugs.webkit.org/show_bug.cgi?id=63404
      
              WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
              and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::attachRootGraphicsLayer): not implemented yet.
              (WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization): Ditto.
              (WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.
              (WebKit::ChromeClient::allowedCompositingTriggers): Ditto.
              * WebCoreSupport/ChromeClientGtk.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f628103
  11. 27 Jun, 2011 1 commit
  12. 24 Jun, 2011 1 commit
    • dominicc@chromium.org's avatar
      2011-06-24 Dominic Cooney <dominicc@chromium.org> · 958d2e44
      dominicc@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * Source/autotools/symbols.filter: Export symbols for GTK.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Update tests to use internals.{ensureShadowRoot, shadowRoot,
              shadowPseudoId, removeShadowRoot} instead of layoutTestController.
      
              * fast/dom/HTMLKeygenElement/keygen-expected.txt:
              * fast/dom/HTMLKeygenElement/keygen.html:
              * fast/dom/HTMLMeterElement/meter-clone-expected.txt:
              * fast/dom/HTMLMeterElement/meter-clone.html:
              * fast/dom/HTMLProgressElement/progress-clone-expected.txt:
              * fast/dom/HTMLProgressElement/progress-clone.html:
              * fast/dom/shadow/activeelement-should-be-shadowhost.html:
              * fast/dom/shadow/create-content-element.html:
              * fast/dom/shadow/gc-shadow-expected.txt:
              * fast/dom/shadow/gc-shadow.html:
              * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
              * fast/dom/shadow/layout-tests-can-access-shadow.html:
              * fast/dom/shadow/nodetype.html:
              * fast/dom/shadow/tab-order-iframe-and-shadow.html:
              * fast/events/shadow-boundary-crossing.html:
              * fast/forms/resources/common.js:
              (getValidationMessageBubbleNode):
              * fast/html/clone-keygen-expected.txt:
              * fast/html/clone-keygen.html:
              * fast/html/clone-range-expected.txt:
              * fast/html/clone-range.html:
              * fast/html/details-clone.html:
              * fullscreen/video-controls-override-expected.txt:
              * fullscreen/video-controls-override.html:
              * media/audio-controls-do-not-fade-out.html:
              * media/media-controls.js:
              (mediaControlsButtonCoordinates):
              * media/video-controls-in-media-document.html:
              * platform/win/Skipped: shadowRoot and friends now available on win.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
              * testing/Internals.cpp: The new home of shadowRoot and friends.
              (WebCore::Internals::ensureShadowRoot):
              (WebCore::Internals::shadowRoot):
              (WebCore::Internals::removeShadowRoot):
              (WebCore::Internals::shadowPseudoId):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Chromium API. These are not
              required any more.
      
              * public/WebElement.h:
              * src/WebElement.cpp:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from GTK DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Mac API. These are not
              required any more.
      
              * DOM/WebDOMOperations.mm:
              * DOM/WebDOMOperationsPrivate.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow-DOM related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from Qt DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from WebKit2 API. These are not
              required any more.
      
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
              * win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
              * win/WebKit2CFLite.def: Same for Cairo.
      2011-06-24  Dominic Cooney   <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
              removeShadowRoot from layoutTestController; these have been
              replaced by equivalents in window.internals instead.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      958d2e44
  13. 22 Jun, 2011 2 commits
    • dglazkov@chromium.org's avatar
      2011-06-20 Dimitri Glazkov <dglazkov@chromium.org> · 3c9177a1
      dglazkov@chromium.org authored
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              1) Introduce FileChooserSettings to decouple setting querying from
              FileChooser. It's a simple copyable settings object, which allows us
              to capture the settings atomically and treat them as discardable data.
      
              2) Encapsulate lifetime management of FileChooser entirely in
              FileChooserClient. It's now a "smart" client, and allows us to
              completely remove FileChooser management concerns from a FileChooserClient
              implementor.
      
              3) Change creation of FileChooser to be on-demand, only when we actually
              need to choose file.
      
              4) Rearrange calling of dispatchFormControlChangeEvent to be at the end
              of a function and remove "am-I-dead" checks that are now unnecessary.
      
              5) Clean up directory upload code a bit, and make use of FileChooserSettings
              to pass directory name.
      
              Refactoring, covered by existing tests.
      
              * WebCore.exp.in: Removed unneeded export.
              * loader/EmptyClients.h: Removed now-unneded param.
              (WebCore::EmptyChromeClient::enumerateChosenDirectory): Ditto.
              * page/Chrome.cpp:
              (WebCore::Chrome::enumerateChosenDirectory): Ditto.
              * page/Chrome.h: Ditto.
              * page/ChromeClient.h: Ditto.
              * platform/FileChooser.cpp:
              (WebCore::FileChooserClient::~FileChooserClient): Added discarding of chooser.
              (WebCore::FileChooserClient::newFileChooser): Added.
              (WebCore::FileChooserClient::discardChooser): Added.
              (WebCore::FileChooser::FileChooser): Changed to use FileChooserSettings.
              (WebCore::FileChooser::create): Ditto.
              (WebCore::FileChooser::~FileChooser): Removed unneeded code.
              (WebCore::FileChooser::chooseFiles): Changed to pass results to the client.
              * platform/FileChooser.h:
              (WebCore::FileChooser::settings): Added.
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::filenamesFromFileList): Added a helper.
              (WebCore::RenderFileUploadControl::RenderFileUploadControl): Changed to use the helper, removed
                  chooser initialization code.
              (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed disconnection code, now
                  handled in FileChooserClient.
              (WebCore::RenderFileUploadControl::filesChosen): Renamed from valueChanged, rearranged to
                  fire dispatchFormControlChangeEvent last.
              (WebCore::RenderFileUploadControl::receiveDropForDirectoryUpload): Changed to use settings.
              (WebCore::RenderFileUploadControl::click): Ditto.
              (WebCore::RenderFileUploadControl::updateFromElement): Removed now-unneeded check.
              (WebCore::RenderFileUploadControl::receiveDroppedFiles): Changed to avoid using the chooser, since
                  it is not necessary.
              (WebCore::RenderFileUploadControl::fileTextValue): Changed to use input data, not chooser data.
              * rendering/RenderFileUploadControl.h: Updated decls.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::runOpenPanel): Changed to use settings.
              (WebKit::ChromeClientImpl::enumerateChosenDirectory): Updated decls.
              * src/ChromeClientImpl.h:
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::runOpenPanel): Changed to use settings.
      2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Kent Tamura.
      
              FileChooser should be only created when we need to choose files.
              https://bugs.webkit.org/show_bug.cgi?id=63039
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::runOpenPanel): Changed to use settings.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c9177a1
    • carlosgc@webkit.org's avatar
      2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com> · 8e8a78c5
      carlosgc@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Make sure libsoup password manager macro is defined before including libsoup in webkitsoupauthdialog
              https://bugs.webkit.org/show_bug.cgi?id=63124
      
              Fixes a crash when building with --enable-debug.
      
              * webkit/webkitsoupauthdialog.h: Define
              LIBSOUP_I_HAVE_READ_BUG_594377_AND_KNOW_SOUP_PASSWORD_MANAGER_MIGHT_GO_AWAY
              before including libsoup.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e8a78c5
  14. 20 Jun, 2011 3 commits
    • mrobinson@webkit.org's avatar
      2011-06-10 Martin Robinson <mrobinson@igalia.com> · 4892916a
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] webkit_web_settings_copy does not copy all settings
              https://bugs.webkit.org/show_bug.cgi?id=62424
      
              Instead of trying to keep webkit_web_settings_copy up to date with
              property additions, create the object copy by dynamically initializing
              all webkit_web_settings properties at once.
      
              * tests/testwebsettings.c:
              (test_webkit_web_settings_copy): Create a test for webkit_web_settings copy.
              (main): Run the new test.
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_copy): Dynamically initialize all properties of the copy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4892916a
    • mrobinson@webkit.org's avatar
      2011-06-20 Martin Robinson <mrobinson@igalia.com> · eb3daffd
      mrobinson@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Clean up unecessary boilerplate from WebKitWebSettings and make private members meet WebKit style guidelines
              https://bugs.webkit.org/show_bug.cgi?id=61972
      
              Rename all private members of WebKitWebSettings to meet WebKit style guidelines and
              put the private struct definition in webkitwebsettingsprivate.h so it can be
              accessed from webkitwebview.cpp. This cuts down on the boilerplate immensely.
      
              * webkit/webkitwebsettings.cpp: Rename private members to meet WebKit style guidelines
              and allocate the private section with new/delete. This allows for using CString and removes
              the need for manual string memory management.
              * webkit/webkitwebsettingsprivate.h: Move the private struct definition here.
              * webkit/webkitwebview.cpp: Update to reflect new struct names. Remove boilerplate
              and other very small code cleanups.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb3daffd
    • carlosgc@webkit.org's avatar
      2011-06-20 Carlos Garcia Campos <cgarcia@igalia.com> · 63e230bf
      carlosgc@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Split libWebCore into two libWebCore and libWebCoreGtk
              https://bugs.webkit.org/show_bug.cgi?id=60539
      
              libWebCore contains all the webcore files except the ones actually
              using gtk while libWebCoreGtk contains only the files using
              gtk. It allows us to build a common WebCore lib and two different
              gtk WebCore libs depending on the gtk version. In WeKit2 gtk2 is
              not supported, but the plugin process needs to be built using gtk2
              because plugins like flash still use gtk2. For WebKit2, we build
              the common libWebCore and two libWebCoreGtk, one using gtk3 and
              the other one using gtk2.
      
              * GNUmakefile.am:
              * GNUmakefile.list.am:
      2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] Split libWebCore into two libWebCore and libWebCoreGtk
              https://bugs.webkit.org/show_bug.cgi?id=60539
      
              * GNUmakefile.am: Link to libWebCoreGtk.la too.
      2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] Split libWebCore into two libWebCore and libWebCoreGtk
              https://bugs.webkit.org/show_bug.cgi?id=60539
      
              * GNUmakefile.am: Link to libWebCoreGtk.la too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63e230bf
  15. 19 Jun, 2011 1 commit
    • dglazkov@chromium.org's avatar
      2011-06-18 Dimitri Glazkov <dglazkov@chromium.org> · b32a1efe
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              Loading an icon and choosing files have similar async nature, but completely different
              lifetimes: FileChooser should only exist when we are actually attempting to choose a file,
              not anytime we need to render an input with a proper icon.
      
              This patch introduces FileIconLoader, a separate abstraction for loading an icon, and removes
              any notion of an icon from the FileChooser.
      
              Also, the loaded icon is now stored on the RenderFileUploadControl, which better matches its
              purpose.
      
              Refactoring, covered by existing tests.
      
              * CMakeLists.txt: Added FileIconLoader to build system.
              * GNUmakefile.list.am: Ditto.
              * WebCore.exp.in: Updated.
              * WebCore.gypi: Added FileIconLoader to build system.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * loader/EmptyClients.h: Updated.
              (WebCore::EmptyChromeClient::loadIconForFiles): Renamed function to better reflect what it does.
              * page/Chrome.cpp:
              (WebCore::Chrome::loadIconForFiles): Ditto.
              * page/Chrome.h: Ditto.
              * page/ChromeClient.h: Ditto.
              * platform/FileChooser.cpp:
              (WebCore::FileChooser::FileChooser): Removed now-unnecessary bool.
              (WebCore::FileChooser::create): Removed the tangled web.
              (WebCore::FileChooser::clear): Removed icon-related code.
              (WebCore::FileChooser::chooseFiles): Ditto.
              * platform/FileChooser.h:
              * platform/FileIconLoader.cpp: Copied from Source/WebCore/platform/FileChooser.cpp.
              (WebCore::FileIconLoaderClient::~FileIconLoaderClient): Added.
              (WebCore::FileIconLoader::create): Added.
              (WebCore::FileIconLoader::disconnectClient): Added.
              (WebCore::FileIconLoader::notifyFinished): Added.
              (WebCore::FileIconLoader::FileIconLoader): Added.
              * platform/FileIconLoader.h: Copied from Source/WebCore/platform/FileChooser.cpp.
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::RenderFileUploadControl): Added new member initializations.
              (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Added FileIconLoader disconnect.s
              (WebCore::RenderFileUploadControl::requestIcon): Added a helper.
              (WebCore::RenderFileUploadControl::valueChanged): Changed to request an icon load.
              (WebCore::RenderFileUploadControl::updateRendering): Added implementation of FileIconLoaderClient func.
              (WebCore::RenderFileUploadControl::updateFromElement): Added clearing of icon.
              (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use new member directly.
              (WebCore::RenderFileUploadControl::paintObject): Ditto.
              (WebCore::RenderFileUploadControl::fileTextValue): Ditto.
              * rendering/RenderFileUploadControl.h: Updated decls.
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::loadIconForFiles): Renamed to better reflect the intent.
              * src/ChromeClientImpl.h: Ditto.
              * src/WebIconLoadingCompletionImpl.cpp:
              (WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl): Changed to use FileIconLoader.
              (WebKit::WebIconLoadingCompletionImpl::didLoadIcon): Ditto.
              * src/WebIconLoadingCompletionImpl.h: Dito.
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientEfl.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientGtk.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              (WebCore::ChromeClientHaiku::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientHaiku.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::loadIconForFiles): Renamed.
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientQt.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::loadIconForFiles): Renamed.
              * WebCoreSupport/WebChromeClient.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebCoreSupport/ChromeClientWinCE.cpp:
              (WebKit::ChromeClientWinCE::loadIconForFiles): Renamed.
              * WebCoreSupport/ChromeClientWinCE.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::chooseIconForFiles): Renamed.
              * WebKitSupport/ChromeClientWx.h:
      2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              Separate concerns of loading file icons and choosing files.
              https://bugs.webkit.org/show_bug.cgi?id=62931
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::loadIconForFiles): Renamed.
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b32a1efe
  16. 17 Jun, 2011 1 commit
    • joone.hur@collabora.co.uk's avatar
      2011-06-17 Joone Hur <joone.hur@collabora.co.uk> · 910be159
      joone.hur@collabora.co.uk authored
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * configure.ac: Check whether Cairo version is higher than 1.10.
      2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * wtf/gobject/GTypedefs.h: Replace GdkRectangle by cairo_rectangle_int_t.
      2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * GNUmakefile.list.am: Added IntRectCairo.cpp instead of IntRectGtk.cpp
              * platform/graphics/IntRect.h: IntRect class can be instantiated through the given cairo_rectangle_int_t
              instead of GdkRectangle.
              * platform/graphics/cairo/IntRectCairo.cpp: Add the constructor and operator for handling cairo_rectangle_int_t.
              (WebCore::IntRect::IntRect):
              (WebCore::IntRect::operator cairo_rectangle_int_t):
              * platform/graphics/gtk/IntRectGtk.cpp: Include this file only for Gtk+2.
              * platform/gtk/GtkPluginWidget.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
              (WebCore::GtkPluginWidget::invalidateRect):
      2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
              (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
              (DumpRenderTreeSupportGtk::rectangleForSelection):
              * WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.
      2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Replace GdkRectangle by cairo_rectangle_int_t
              https://bugs.webkit.org/show_bug.cgi?id=60687
      
              Replace GdkRectangle by cairo_rectangle_int_t.
      
              * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
              (createBitmapContextFromWebView):
              * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
              (firstRectForCharacterRangeCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      910be159
  17. 16 Jun, 2011 3 commits
    • commit-queue@webkit.org's avatar
      2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com> · 62c8e334
      commit-queue@webkit.org authored
              Unreviewed, rolling out r89026.
              http://trac.webkit.org/changeset/89026
              https://bugs.webkit.org/show_bug.cgi?id=62804
      
              These patches were likely correct.  I'll investigate the
              browser_test failures. (Requested by abarth on #webkit).
      
              * WebCore.exp.in:
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::ScriptController):
              (WebCore::ScriptController::processingUserGesture):
              * bindings/js/ScriptController.h:
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::ScriptController):
              (WebCore::ScriptController::processingUserGesture):
              * bindings/v8/ScriptController.h:
              * dom/Event.cpp:
              * dom/Event.h:
              * dom/UserGestureIndicator.cpp:
              (WebCore::isDefinite):
              (WebCore::UserGestureIndicator::UserGestureIndicator):
              (WebCore::UserGestureIndicator::~UserGestureIndicator):
              * dom/UserGestureIndicator.h:
              (WebCore::UserGestureIndicator::processingUserGesture):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::removedFromDocument):
              (WebCore::HTMLMediaElement::load):
              (WebCore::HTMLMediaElement::play):
              (WebCore::HTMLMediaElement::pause):
              (WebCore::HTMLMediaElement::beginScrubbing):
              (WebCore::HTMLMediaElement::resume):
              * html/HTMLMediaElement.h:
              * html/HTMLMediaElement.idl:
              * html/HTMLVideoElement.cpp:
              (WebCore::HTMLVideoElement::webkitEnterFullscreen):
              * html/HTMLVideoElement.h:
              (WebCore::HTMLVideoElement::webkitEnterFullScreen):
              * html/HTMLVideoElement.idl:
              * html/MediaDocument.cpp:
              (WebCore::MediaDocument::defaultEventHandler):
              * html/shadow/MediaControlElements.cpp:
              (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
              * html/shadow/TextControlInnerElements.cpp:
              (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
      2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r89026.
              http://trac.webkit.org/changeset/89026
              https://bugs.webkit.org/show_bug.cgi?id=62804
      
              These patches were likely correct.  I'll investigate the
              browser_test failures. (Requested by abarth on #webkit).
      
              * src/WebPluginContainerImpl.cpp:
              (WebKit::WebPluginContainerImpl::loadFrameRequest):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::performMediaPlayerAction):
      2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r89026.
              http://trac.webkit.org/changeset/89026
              https://bugs.webkit.org/show_bug.cgi?id=62804
      
              These patches were likely correct.  I'll investigate the
              browser_test failures. (Requested by abarth on #webkit).
      
              * WebCoreSupport/FullscreenVideoController.cpp:
              (FullscreenVideoController::play):
              (FullscreenVideoController::pause):
      2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r89026.
              http://trac.webkit.org/changeset/89026
              https://bugs.webkit.org/show_bug.cgi?id=62804
      
              These patches were likely correct.  I'll investigate the
              browser_test failures. (Requested by abarth on #webkit).
      
              * WebView/WebVideoFullscreenHUDWindowController.mm:
              (-[WebVideoFullscreenHUDWindowController setPlaying:]):
      2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r89026.
              http://trac.webkit.org/changeset/89026
              https://bugs.webkit.org/show_bug.cgi?id=62804
      
              These patches were likely correct.  I'll investigate the
              browser_test failures. (Requested by abarth on #webkit).
      
              * FullscreenVideoController.cpp:
              (FullscreenVideoController::play):
              (FullscreenVideoController::pause):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62c8e334
    • vitalyr@chromium.org's avatar
      2011-06-16 Vitaly Repeshko <vitalyr@chromium.org> · fce71068
      vitalyr@chromium.org authored
              Unreviewed.
      
              Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
              https://bugs.webkit.org/show_bug.cgi?id=62796
      
              The patches broke chromium browser tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fce71068
    • abarth@webkit.org's avatar
      2011-06-16 Adam Barth <abarth@webkit.org> · 5906d909
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove HTMLVideoElement::processingUserGesture
              https://bugs.webkit.org/show_bug.cgi?id=62784
      
              HTMLMediaElement shouldn't have its own notion of the user gesture
              state.  It should just use the normal user gesture state.  Also,
              there's no point in having the bindings send the user gesture state in
              a boolean parameter.
      
              * WebCore.exp.in:
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::removedFromDocument):
              (WebCore::HTMLMediaElement::load):
              (WebCore::HTMLMediaElement::play):
              (WebCore::HTMLMediaElement::pause):
              (WebCore::HTMLMediaElement::beginScrubbing):
              (WebCore::HTMLMediaElement::resume):
              * html/HTMLMediaElement.h:
              * html/HTMLMediaElement.idl:
              * html/HTMLVideoElement.cpp:
              (WebCore::HTMLVideoElement::webkitEnterFullscreen):
              * html/HTMLVideoElement.h:
              (WebCore::HTMLVideoElement::webkitEnterFullScreen):
              * html/HTMLVideoElement.idl:
              * html/MediaDocument.cpp:
              (WebCore::MediaDocument::defaultEventHandler):
              * html/shadow/MediaControlElements.cpp:
              (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
      2011-06-16  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove HTMLVideoElement::processingUserGesture
              https://bugs.webkit.org/show_bug.cgi?id=62784
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::performMediaPlayerAction):
      2011-06-16  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove HTMLVideoElement::processingUserGesture
              https://bugs.webkit.org/show_bug.cgi?id=62784
      
              * WebCoreSupport/FullscreenVideoController.cpp:
              (FullscreenVideoController::play):
              (FullscreenVideoController::pause):
      2011-06-16  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove HTMLVideoElement::processingUserGesture
              https://bugs.webkit.org/show_bug.cgi?id=62784
      
              * WebView/WebVideoFullscreenHUDWindowController.mm:
              (-[WebVideoFullscreenHUDWindowController setPlaying:]):
      2011-06-16  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Remove HTMLVideoElement::processingUserGesture
              https://bugs.webkit.org/show_bug.cgi?id=62784
      
              * FullscreenVideoController.cpp:
              (FullscreenVideoController::play):
              (FullscreenVideoController::pause):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5906d909
  18. 15 Jun, 2011 1 commit
  19. 14 Jun, 2011 3 commits
    • xan@webkit.org's avatar
      2011-06-14 Xan Lopez <xlopez@igalia.com> · 57710272
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Remove G_CONST_RETURN usage
              https://bugs.webkit.org/show_bug.cgi?id=62673
      
              Change G_CONST_RETURN for a simple "const" throughout the
              codebase, since G_CONST_RETURN is deprecated now. This should be
              totally equivalent since for all practical purposes the macro is
              always expanded to const.
      
              * webkit/webkitapplicationcache.cpp:
              (webkit_application_cache_get_database_directory_path): use const
              instead of G_CONST_RETURN.
              * webkit/webkitapplicationcache.h:
              * webkit/webkiticondatabase.cpp:
              (webkit_icon_database_get_path): ditto.
              * webkit/webkiticondatabase.h:
              * webkit/webkitnetworkrequest.cpp:
              (webkit_network_request_get_uri): ditto.
              * webkit/webkitnetworkrequest.h:
              * webkit/webkitnetworkresponse.cpp:
              (webkit_network_response_get_uri): ditto.
              * webkit/webkitnetworkresponse.h:
              * webkit/webkitsecurityorigin.cpp:
              (webkit_security_origin_get_protocol): ditto.
              (webkit_security_origin_get_host): ditto.
              * webkit/webkitsecurityorigin.h:
              * webkit/webkitwebdatabase.cpp:
              (webkit_web_database_get_name): ditto.
              (webkit_web_database_get_display_name): ditto.
              (webkit_web_database_get_filename): ditto.
              (webkit_get_web_database_directory_path): ditto.
              * webkit/webkitwebdatabase.h:
              * webkit/webkitwebdatasource.cpp:
              (webkit_web_data_source_get_encoding): ditto.
              (webkit_web_data_source_get_unreachable_uri): ditto.
              * webkit/webkitwebdatasource.h:
              * webkit/webkitwebframe.cpp:
              (webkit_web_frame_get_title): ditto.
              (webkit_web_frame_get_uri): ditto.
              (webkit_web_frame_get_name): ditto.
              * webkit/webkitwebframe.h:
              * webkit/webkitwebhistoryitem.cpp:
              (webkit_web_history_item_get_title): ditto.
              (webkit_web_history_item_get_alternate_title): ditto.
              (webkit_web_history_item_get_uri): ditto.
              (webkit_web_history_item_get_original_uri): ditto.
              (webkit_web_history_item_get_target): ditto.
              * webkit/webkitwebhistoryitem.h:
              * webkit/webkitwebhistoryitemprivate.h:
              * webkit/webkitwebnavigationaction.cpp:
              (webkit_web_navigation_action_get_target_frame): ditto.
              * webkit/webkitwebnavigationaction.h:
              * webkit/webkitwebresource.cpp:
              (webkit_web_resource_get_uri): ditto.
              (webkit_web_resource_get_mime_type): ditto.
              (webkit_web_resource_get_encoding): ditto.
              (webkit_web_resource_get_frame_name): ditto.
              * webkit/webkitwebresource.h:
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_get_user_agent): ditto.
              * webkit/webkitwebsettings.h:
              * webkit/webkitwebview.cpp:
              (webkit_web_view_get_title): ditto.
              (webkit_web_view_get_uri): ditto.
              (webkit_web_view_get_icon_uri): ditto.
              * webkit/webkitwebview.h:
              * webkit/webkitwebviewcommon.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57710272
    • carlosgc@webkit.org's avatar
      2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com> · 85bd6c10
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
              https://bugs.webkit.org/show_bug.cgi?id=62626
      
              The method actually converts coordinates, the rectangle size is
              not affected, so it can be modified to return a point
              instead. Fix also a bug in the implementation, it was translating
              the coordinates twice returning the wrong position when the given
              rectangle was not at 0,0.
      
              * platform/gtk/GtkUtilities.cpp:
              (WebCore::convertWidgetPointToScreenPoint):
              * platform/gtk/GtkUtilities.h:
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenuGtk::show): Use
              convertWidgetPointToScreenPoint().
      2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
              https://bugs.webkit.org/show_bug.cgi?id=62626
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::windowToScreen): Update to use
              convertWidgetPointToScreenPoint()
              (WebKit::ChromeClient::screenToWindow): Ditto.
              * webkit/webkitwebview.cpp: Remove globalPointForClientPoint()
              since it does the same than convertWidgetPointToScreenPoint().
              (webkit_web_view_popup_menu_handler): Use
              convertWidgetPointToScreenPoint() instead of globalPointForClientPoint().
              (doDragLeaveLater): Ditto.
              (webkit_web_view_drag_motion): Ditto.
              (webkit_web_view_drag_data_received): Ditto.
              (webkit_web_view_drag_drop): Ditto.
      2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
              https://bugs.webkit.org/show_bug.cgi?id=62626
      
              * UIProcess/API/gtk/PageClientImpl.cpp:
              (WebKit::PageClientImpl::screenToWindow): Implement this method
              using convertWidgetPointToScreenPoint().
              (WebKit::PageClientImpl::windowToScreen): Update to use
              convertWidgetPointToScreenPoint().
              * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
              (WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use
              convertWidgetPointToScreenPoint().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85bd6c10
    • carlosgc@webkit.org's avatar
      2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com> · c0c956a1
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Support authentication dialogs in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=62366
      
              Add a new class to show an authentication dialog that is used by
              both WebKit1 and WebKit2.
      
              * GNUmakefile.list.am: Add new files to compilation.
              * platform/gtk/GtkAuthenticationDialog.cpp: Added.
              (WebCore::addEntryToTable):
              (WebCore::sessionCanSavePasswords):
              (WebCore::GtkAuthenticationDialog::~GtkAuthenticationDialog):
              (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
              (WebCore::getSavedLogin):
              (WebCore::GtkAuthenticationDialog::show):
              (WebCore::GtkAuthenticationDialog::destroy):
              (WebCore::GtkAuthenticationDialog::savePasswordCallback):
              (WebCore::GtkAuthenticationDialog::savePassword):
              (WebCore::GtkAuthenticationDialog::authenticate):
              (WebCore::GtkAuthenticationDialog::authenticationDialogResponseCallback):
              * platform/gtk/GtkAuthenticationDialog.h: Added.
      2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Support authentication dialogs in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=62366
      
              Move the common code of webkitsoupauthdialog to a common C++ class
              in WebCore so that it can be used by WebKit2 too. The file has
              been converted into a C++ file.
      
              * GNUmakefile.am: Rename webkitsoupauthdialog.c to
              webkitsoupauthdialog.cpp.
              * webkit/webkitsoupauthdialog.c: Removed.
              * webkit/webkitsoupauthdialog.cpp: Added.
              (webkit_soup_auth_dialog_class_init):
              (webkit_soup_auth_dialog_init):
              (webkit_soup_auth_dialog_session_feature_init):
              (sessionAuthenticate): Use GtkAuthenticationDialog object from
              WebCore.
              (attach):
              (detach):
              * webkit/webkitsoupauthdialog.h:
      2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Support authentication dialogs in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=62366
      
              Add a new soup feature to show an authentication dialog when it
              gets a 401 HTTP response.
      
              * GNUmakefile.am: Add new files to compilation.
              * WebProcess/gtk/WebAuthDialog.cpp: Added.
              (web_auth_dialog_class_init):
              (web_auth_dialog_init):
              (sessionAuthenticate):
              (attach):
              (detach):
              (webAuthDialogSessionFeatureInit):
              * WebProcess/gtk/WebAuthDialog.h: Added.
              * WebProcess/gtk/WebProcessMainGtk.cpp:
              (WebKit::WebProcessMainGtk):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0c956a1
  20. 13 Jun, 2011 6 commits
    • joone.hur@collabora.co.uk's avatar
      2011-06-13 Joone Hur <joone.hur@collabora.co.uk> · bc9a3732
      joone.hur@collabora.co.uk authored
              Reviewed by Martin Robinson.
      
              [GTK] Add configure option to enable/disable register protocol handler
              https://bugs.webkit.org/show_bug.cgi?id=62534
      
              This patch just adds configure option to enable/disable register protocol handler.
              So, it needs more code to use register protocol handler.
      
              * configure.ac: Add configure option to enable/disable register protocol handler.
      2011-06-13  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add configure option to enable/disable register protocol handler
              https://bugs.webkit.org/show_bug.cgi?id=62534
      
              * GNUmakefile.am: Add ENABLE_REGISTER_PROTOCOL_HANDLER.
      2011-06-13  Joone Hur  <joone.hur@collabora.co.uk>
      
              Reviewed by Martin Robinson.
      
              [GTK] Add configure option to enable/disable register protocol handler
              https://bugs.webkit.org/show_bug.cgi?id=62534
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::registerProtocolHandler): Added.
              * WebCoreSupport/ChromeClientGtk.h: Add the registerProtocolHandler method defintion.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc9a3732
    • mrobinson@webkit.org's avatar
      2011-06-13 Martin Robinson <mrobinson@igalia.com> · a80155f9
      mrobinson@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              Update gtkdoc files and inline documentation to reduce gtkdoc errors
              and ensure complete documentation output.
      
              * docs/webkitgtk-sections.txt: Add missing sections to the list and remove
              unneeded sections.
              * docs/webkitgtk.types: Update the types list.
              * webkit/webkithittestresult.cpp: Fix inline documentation errors.
              (webkit_hit_test_result_class_init): Ditto.
              * webkit/webkiticondatabase.cpp: Ditto.
              * webkit/webkitwebsettings.cpp: Ditto.
              (webkit_web_settings_class_init): Ditto.
              * webkit/webkitwebview.cpp: Ditto.
              (webkit_web_view_class_init): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a80155f9
    • mrobinson@webkit.org's avatar
      2011-06-13 Martin Robinson <mrobinson@igalia.com> · 09f531fd
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              Update the list of ignored GTK+ header files for the documentation
              generation.
      
              * docs/GNUmakefile.am: Update ignored header list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09f531fd
    • xan@webkit.org's avatar
      2011-06-13 Xan Lopez <xlopez@igalia.com> · 196419ea
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              Update NEWS for 1.5.1 release.
      
              * NEWS: update.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      196419ea
    • xan@webkit.org's avatar
      Source/WebCore: · 534853e1
      xan@webkit.org authored
      2011-06-13  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              Distcheck fixes.
      
              * GNUmakefile.am:
              * GNUmakefile.list.am:
      
      Source/WebKit/gtk:
      
      2011-06-13  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              Distcheck fixes.
      
              * GNUmakefile.am:
      
      Source/JavaScriptCore:
      
      2011-06-13  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              Distcheck fixes.
      
              * GNUmakefile.am:
              * GNUmakefile.list.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      534853e1
    • carlosgc@webkit.org's avatar
      2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com> · 13ad7ece
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Export an API similar to WebKit1
              https://bugs.webkit.org/show_bug.cgi?id=57820
      
              * GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
              * webkit/webkitwebview.h: Move declarations common to WebKit2 to
              webkitwebviewcommon.h.
              * webkit/webkitwebviewcommon.h: Added.
      2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Export an API similar to WebKit1
              https://bugs.webkit.org/show_bug.cgi?id=57820
      
              Add first implementation of WebKitWebView, a class with the same
              API than webkit1, that wraps the C API to provide a high level
              WebKit2 API for GTK port.
      
              * GNUmakefile.am: Add new files to compilation.
              * UIProcess/API/gtk/WebKitWebView.cpp: Added.
              (webkit_web_view_init):
              (webkit_web_view_class_init):
              (webkit_web_view_new):
              (webkit_web_view_load_uri):
              (webkit_web_view_go_back):
              (webkit_web_view_go_forward):
              * UIProcess/API/gtk/WebKitWebView.h: Added.
              * UIProcess/API/gtk/WebKitWebViewBase.cpp:
              (webkitWebViewBaseCreate):
              (webkitWebViewBaseCreateWebPage):
              * UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
              * UIProcess/API/gtk/webkit/webkit.h: Added.
      2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Export an API similar to WebKit1
              https://bugs.webkit.org/show_bug.cgi?id=57820
      
              Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
              code, but linking to libwebkit2gtk.
      
              * GNUmakefile.am:
              * GtkLauncher/main.c:
              (createBrowser):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13ad7ece
  21. 12 Jun, 2011 3 commits
    • abarth@webkit.org's avatar
      2011-06-12 Adam Barth <abarth@webkit.org> · 4fc62a9e
      abarth@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
              * loader/FrameLoaderClient.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::interruptedForPolicyChangeError):
              (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
              (WebCore::MainResourceLoader::continueAfterContentPolicy):
              * loader/MainResourceLoader.h:
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError):
              * src/FrameLoaderClientImpl.h:
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * WebCoreSupport/FrameLoaderClientEfl.cpp:
              (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
              * WebCoreSupport/FrameLoaderClientEfl.h:
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * WebCoreSupport/FrameLoaderClientHaiku.cpp:
              (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError):
              * WebCoreSupport/FrameLoaderClientHaiku.h:
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::interruptedForPolicyChangeError):
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
              * WebCoreSupport/FrameLoaderClientQt.h:
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * WebFrame.cpp:
              (WebFrame::interruptedForPolicyChangeError):
              * WebFrame.h:
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * WebCoreSupport/FrameLoaderClientWinCE.cpp:
              (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError):
              * WebCoreSupport/FrameLoaderClientWinCE.h:
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError):
              * WebKitSupport/FrameLoaderClientWx.h:
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
              https://bugs.webkit.org/show_bug.cgi?id=62516
      
              * WebProcess/WebCoreSupport/WebErrors.h:
              * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError):
              * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
              * WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
              (WebKit::interruptedForPolicyChangeError):
              * WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
              (WebKit::interruptedForPolicyChangeError):
              * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
              (WebKit::interruptedForPolicyChangeError):
              * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
              (WebKit::interruptedForPolicyChangeError):
              * WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
              (WebKit::interruptedForPolicyChangeError):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fc62a9e
    • xan@webkit.org's avatar
      2011-06-12 Xan Lopez <xlopez@igalia.com> · 5ed2041f
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Remove webkit_web_view_get_selected_text
              https://bugs.webkit.org/show_bug.cgi?id=62512
      
              It's no longer used and it's a private method, so it can be
              removed.
      
              * webkit/webkitwebview.cpp: kill it.
              * webkit/webkitwebviewprivate.h: ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ed2041f
    • abarth@webkit.org's avatar
      2011-06-12 Adam Barth <abarth@webkit.org> · 4aa7e197
      abarth@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Remove trival "forward-to-client" member functions from FrameLoader
              https://bugs.webkit.org/show_bug.cgi?id=62510
      
              Update to call the FrameLoaderClient directly.  Also, remove cargo-cult
              code that checks whether FrameLoader is null.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_stop_loading):
              (webkit_web_view_can_show_mime_type):
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Remove trival "forward-to-client" member functions from FrameLoader
              https://bugs.webkit.org/show_bug.cgi?id=62510
      
              * WebCoreSupport/WebFrameNetworkingContext.cpp:
              (WebFrameNetworkingContext::blockedError):
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Remove trival "forward-to-client" member functions from FrameLoader
              https://bugs.webkit.org/show_bug.cgi?id=62510
      
              * WebCoreSupport/WebFrameNetworkingContext.mm:
              (WebFrameNetworkingContext::blockedError):
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Remove trival "forward-to-client" member functions from FrameLoader
              https://bugs.webkit.org/show_bug.cgi?id=62510
      
              Originally, FrameLoader was supposed to abstract FrameLoaderClient, but
              we lost that battle log ago.  Nowadays, it's easier if folks just call
              into FrameLoaderClient directly.  Many of these functions have direct
              callers already anyway.
      
              * WebCore.exp.in:
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::createRenderer):
              (WebCore::HTMLMediaElement::attach):
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::setRequest):
              (WebCore::DocumentLoader::setMainDocumentError):
              (WebCore::DocumentLoader::setupForReplaceByMIMEType):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didFirstLayout):
              * loader/FrameLoader.h:
                  - cancelledError is slightly more delicate, so I'm going to move it in
                    a separate patch.
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::interruptForPolicyChangeError):
              (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
              (WebCore::MainResourceLoader::continueAfterContentPolicy):
              (WebCore::MainResourceLoader::handleEmptyLoad):
              (WebCore::MainResourceLoader::loadNow):
              * loader/MainResourceLoader.h:
              * loader/NetscapePlugInStreamLoader.cpp:
              (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
              * loader/PingLoader.cpp:
              (WebCore::PingLoader::PingLoader):
              * loader/PolicyChecker.cpp:
              (WebCore::PolicyChecker::continueAfterNavigationPolicy):
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::blockedError):
              (WebCore::ResourceLoader::cannotShowURLError):
              (WebCore::ResourceLoader::shouldUseCredentialStorage):
              (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::populate):
      2011-06-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Remove trival "forward-to-client" member functions from FrameLoader
              https://bugs.webkit.org/show_bug.cgi?id=62510
      
              * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
              (WebKit::WebFrameNetworkingContext::blockedError):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4aa7e197
  22. 09 Jun, 2011 1 commit
    • mrobinson@webkit.org's avatar
      2011-06-09 Martin Robinson <mrobinson@igalia.com> · 5d92606e
      mrobinson@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
              https://bugs.webkit.org/show_bug.cgi?id=55603
      
              * platform/gtk/Skipped: Unskip a test that is now passing. Better describe remaining failures.
      2011-06-09  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
              https://bugs.webkit.org/show_bug.cgi?id=55603
      
              Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and
              end. This matches other ports. Only use GLib style early returns when checking the
              validity of GObjects.
              (DumpRenderTreeSupportGtk::hasComposition):  Added.
              (DumpRenderTreeSupportGtk::compositionRange): Added.
              (DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above.
              (DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above.
              (DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above.
              * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations.
      2011-06-09  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
              https://bugs.webkit.org/show_bug.cgi?id=55603
      
              Add callbacks to support hasMarkedText and markedRange and also clean up existing
              TextInputController support.
      
              * DumpRenderTree/gtk/TextInputController.cpp:
              (setMarkedTextCallback): Accept parameters in terms of start and length, instead
              of start and end. This matches the other ports. Do not use GLib style early returns.
              (hasMarkedTextCallback): Added.
              (markedRangeCallback): Added.
              (insertTextCallback): Cleanup as described above.
              (unmarkTextCallback): Cleanup as described above.
              (firstRectForCharacterRangeCallback): Cleanup as described above.
              (selectedRangeCallback): Cleanup as described above.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d92606e
  23. 08 Jun, 2011 1 commit
    • xan@webkit.org's avatar
      2011-06-08 Xan Lopez <xlopez@igalia.com> · e826ea9d
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Add WebKitSpellChecker interface and implementations
              https://bugs.webkit.org/show_bug.cgi?id=61787
      
              Expose the spell checking functionality to the UAs through a
              generic interface, and provide a default Enchant-based
              implementation. On top of allowing UAs to use this functionality
              this makes it possible to change the spell checking backend at
              runtime.
      
              * GNUmakefile.am: add new files.
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::EditorClient): set the spell checker using
              the new classes.
              * WebCoreSupport/TextCheckerClientEnchant.cpp: Removed.
              * WebCoreSupport/TextCheckerClientGtk.cpp: Added
              (WebKit::TextCheckerClientGtk::TextCheckerClientGtk): just
              chain up to the WebKitSpellChecker.
              (WebKit::TextCheckerClientGtk::~TextCheckerClientGtk): ditto.
              (WebKit::TextCheckerClientGtk::ignoreWordInSpellDocument): ditto.
              (WebKit::TextCheckerClientGtk::learnWord): ditto.
              (WebKit::TextCheckerClientGtk::checkSpellingOfString): ditto.
              (WebKit::TextCheckerClientGtk::getAutoCorrectSuggestionForMisspelledWord): ditto.
              (WebKit::TextCheckerClientGtk::getGuessesForWord): ditto.
              (WebKit::TextCheckerClientGtk::updateSpellCheckingLanguage): ditto.
              * WebCoreSupport/TextCheckerClientGtk.h: store a reference to
              the WebKitSpellChecker.
              * webkit/webkit.h: the webkitspellchecker.h header is public.
              * webkit/webkitdefines.h: defines for spell checker interface.
              * webkit/webkitglobals.cpp: Add APIs to get and set the global
              spell checker.
              (webkit_get_spell_checker): get API.
              (webkit_set_spell_checker): set API.
              * webkit/webkitglobals.h:
              * webkit/webkitspellchecker.cpp: Added. Spell checking interface.
              * webkit/webkitspellchecker.h: Added.
              * webkit/webkitspellcheckerenchant.cpp: Added. Default
              implemention, uses Enchant library.
              * webkit/webkitspellcheckerenchant.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e826ea9d
  24. 07 Jun, 2011 1 commit
  25. 03 Jun, 2011 1 commit
    • mrobinson@webkit.org's avatar
      2011-05-31 Martin Robinson <mrobinson@igalia.com> · 8e67bae7
      mrobinson@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              [GTK] Support smart replace for the pasteboard
              https://bugs.webkit.org/show_bug.cgi?id=61734
      
              Unskip tests which are now passing and update results for other tests
              which vary depending on smart replace support.
      
              * platform/gtk/Skipped: Unskip tests which are now passing.
              * platform/gtk/editing/deleting/smart-delete-003-expected.txt:
              * platform/gtk/editing/deleting/smart-delete-004-expected.txt:
              * platform/gtk/editing/pasteboard/4944770-2-expected.txt:
              * platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
              * platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
              * platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
              * platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
              * platform/gtk/fast/lists/drag-into-marker-expected.txt:
      2011-05-31  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Ryosuke Niwa.
      
              [GTK] Support smart replace for the pasteboard
              https://bugs.webkit.org/show_bug.cgi?id=61734
      
              Add smart replace support to WebCore and add hooks for it in WebKit
              via DumpRenderTreeSupportGtk. When a platform supports smart replace,
              WebCore will remove extra spaces that appear when pasting text. Eventually
              WebKitGTK+ may want to expose this in the public API.
      
              * platform/gtk/PasteboardGtk.cpp:
              (WebCore::Pasteboard::writeSelection): Now pass whether or not to use smart replace
              when calling writeSelection.
              (WebCore::Pasteboard::canSmartReplace): Added an implementation that checks the clipboard
              for whether or not it supports smart paste.
              * platform/gtk/PasteboardHelper.cpp:
              (WebCore::initGdkAtoms): Added initialization for smart replace atom.
              (WebCore::PasteboardHelper::fillSelectionData): Added no-op handler for smart replace atom.
              (WebCore::PasteboardHelper::targetListForDataObject): Properly handle new smart replace parameter.
              (WebCore::PasteboardHelper::writeClipboardContents): Properly handle new smart replace parameter.
              (WebCore::PasteboardHelper::clipboardContentSupportsSmartReplace): Added helper for Pasteboard.
              * platform/gtk/PasteboardHelper.h: Add new method definition.
      2011-05-31  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Ryosuke Niwa.
      
              [GTK] Support smart replace for the pasteboard
              https://bugs.webkit.org/show_bug.cgi?id=61734
      
              Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling
              smart replace in the tests.
      
              * WebCoreSupport/DragClientGtk.cpp:
              (WebKit::DragClient::startDrag): targeListForDataObject now takes another
              parameter determining whether or not to add smart paste support. Add it here.
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added.
              * WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition.
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation.
              (WebKit::EditorClient::smartInsertDeleteEnabled): Added.
              (WebKit::EditorClient::EditorClient):
              * WebCoreSupport/EditorClientGtk.h: Add new method definition.
      2011-05-31  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Ryosuke Niwa.
      
              [GTK] Support smart replace for the pasteboard
              https://bugs.webkit.org/show_bug.cgi?id=61734
      
              Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
              This is required to produce consistent test results.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
              methods which calls into DumpRenderTreeSupportGtk.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e67bae7