1. 26 Jul, 2011 12 commits
    • commit-queue@webkit.org's avatar
      [GTK] Remove header webkitwebviewcommon.h · f232c5d4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65177
      
      Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-07-26
      Reviewed by Martin Robinson.
      
      Source/WebKit/gtk:
      
      Move webkitwebviewcommon.h contents back to webkitwebview.h.
      
      * GNUmakefile.am: Remove webkitwebviewcommon.h
      * webkit/webkitwebview.h:
      * webkit/webkitwebviewcommon.h: Removed.
      
      Source/WebKit2:
      
      * UIProcess/API/gtk/WebKitWebView.h: Add function prototypes
      instead of including webkitwebviewcommon.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f232c5d4
    • pfeldman@chromium.org's avatar
      Web Inspector: Better represent custom getters in the properties pane · 7e2e12f8
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=16734
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Test: inspector/runtime/runtime-getProperties.html
      
      * inspector/InjectedScriptSource.js:
      (.):
      * inspector/Inspector.json:
      * inspector/front-end/ObjectPropertiesSection.js:
      (WebInspector.ObjectPropertyTreeElement.prototype.update):
      
      LayoutTests:
      
      * inspector/runtime/runtime-getProperties-expected.txt: Added.
      * inspector/runtime/runtime-getProperties.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e2e12f8
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening. · 50341dd0
      ossy@webkit.org authored
      * platform/qt/fast/css/font-face-opentype-expected.png: Added.
      * platform/qt/fast/css/font-face-opentype-expected.txt: Updated after r91738.
      * platform/qt/svg/custom/image-with-transform-clip-filter-expected.png: Updated after r91748.
      * platform/qt/svg/custom/image-with-transform-clip-filter-expected.txt: Updated after r91748.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50341dd0
    • abecsi@webkit.org's avatar
      Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-07-26 · fa30de9e
      abecsi@webkit.org authored
      Reviewed by Andreas Kling.
      
      [Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
      https://bugs.webkit.org/show_bug.cgi?id=63472
      
      Source/JavaScriptCore:
      
      Enable the bits needed for GStreamer only when QtMultimedia is not used.
      
      * wtf/wtf.pri:
      
      Source/WebCore:
      
      Enable the GStreamer backend and the QuickTime backend as default media players
      for the Qt port on Mac and Linux. QtMultimedia is now a fallback option that you
      can enable by passing DEFINES+=USE_QT_MULTIMEDIA=1 to enforce its usage.
      
      No new tests. The media layout tests are disabled on the Qt port but hopefully with this
      switch we can enable them again.
      
      * WebCore.pri:
      * WebCore.pro:
      * features.pri:
      
      Source/WebKit/qt:
      
      Use the flag WTF_USE_QTKIT=1 rather than USE_QTKIT=1 because that flag doesn't
      exist anymore, it's the default. Ditto for GStreamer.
      
      * QtWebKit.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa30de9e
    • carlosgc@webkit.org's avatar
      2011-07-26 Carlos Garcia Campos <cgarcia@igalia.com> · f02cdc85
      carlosgc@webkit.org authored
              Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.
      
              * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
              (getPreferredSizeMethod):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f02cdc85
    • pfeldman@chromium.org's avatar
      Web Inspector: Implement setPropertyValue using evaluate and callFunctionOn · 3db22ea2
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65112
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Test: inspector/runtime/runtime-setPropertyValue.html
      
      * inspector/InjectedScript.cpp:
      * inspector/InjectedScript.h:
      * inspector/InjectedScriptSource.js:
      (.):
      * inspector/Inspector.json:
      * inspector/InspectorRuntimeAgent.cpp:
      * inspector/InspectorRuntimeAgent.h:
      * inspector/front-end/RemoteObject.js:
      (WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback.setPropertyValue):
      (WebInspector.RemoteObject.prototype.setPropertyValue.evaluatedCallback):
      (WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
      (WebInspector.RemoteObject.prototype.setPropertyValue):
      
      LayoutTests:
      
      * inspector/runtime/runtime-setPropertyValue-expected.txt: Added.
      * inspector/runtime/runtime-setPropertyValue.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3db22ea2
    • pfeldman@chromium.org's avatar
      2011-07-26 Pavel Feldman <pfeldman@google.com> · 19665e8c
      pfeldman@chromium.org authored
              Re-applying r91665 and r91668 with JSC issues fixed.
      
              Web Inspector: use dedicated type for object id in the protocol.
              Web Inspector: refactor remote object structure to contain value for primitive values.
      
              https://bugs.webkit.org/show_bug.cgi?id=65103
              https://bugs.webkit.org/show_bug.cgi?id=65110
      
              Reviewed by Yury Semikhatsky.
      
              * inspector/InjectedScript.cpp:
              (WebCore::InjectedScript::callFunctionOn):
              * inspector/InjectedScript.h:
              * inspector/InjectedScriptSource.js:
              * inspector/Inspector.json:
              * inspector/InspectorRuntimeAgent.cpp:
              (WebCore::InspectorRuntimeAgent::callFunctionOn):
              * inspector/InspectorValues.cpp:
              (WebCore::InspectorBasicValue::writeJSON):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype._format):
              (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
              (WebInspector.ConsoleMessage.prototype._format):
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
              * inspector/front-end/ObjectPropertiesSection.js:
              (WebInspector.ObjectPropertyTreeElement.prototype.update):
              * inspector/front-end/PropertiesSidebarPane.js:
              (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
              * inspector/front-end/RemoteObject.js:
              (WebInspector.RemoteObject):
              (WebInspector.RemoteObject.fromPrimitiveValue):
              (WebInspector.RemoteObject.fromPayload):
              (WebInspector.RemoteObject.prototype.get subtype):
              (WebInspector.RemoteObject.prototype.callFunction):
              (WebInspector.LocalJSONObject.prototype.get description):
              (WebInspector.LocalJSONObject.prototype.get type):
              (WebInspector.LocalJSONObject.prototype.get subtype):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
              (WebInspector.SourceFrame.prototype._showPopup):
              * inspector/front-end/inspector.js:
              (WebInspector.log.logMessage):
              (WebInspector.log):
              (WebInspector.inspect):
      
      2011-07-26  Pavel Feldman  <pfeldman@google.com>
      
              Re-applying r91665 and r91668 with JSC issues fixed.
      
              Web Inspector: use dedicated type for object id in the protocol.
              Web Inspector: refactor remote object structure to contain value for primitive values.
      
              https://bugs.webkit.org/show_bug.cgi?id=65103
              https://bugs.webkit.org/show_bug.cgi?id=65110
      
              Reviewed by Yury Semikhatsky.
      
              * http/tests/inspector/extensions-test.js:
              (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
              (initialize_ExtensionsTest):
              * inspector/console/console-format-expected.txt:
              * inspector/console/console-format.html:
              * inspector/protocol/console-agent-expected.txt:
              * inspector/protocol/runtime-agent-expected.txt:
              * inspector/runtime/runtime-callFunctionOn-expected.txt:
              * inspector/runtime/runtime-callFunctionOn.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19665e8c
    • zimmermann@webkit.org's avatar
      2011-07-26 Nikolas Zimmermann <nzimmermann@rim.com> · 3f0b1689
      zimmermann@webkit.org authored
              Prepare animVal support - phase 2
              https://bugs.webkit.org/show_bug.cgi?id=65167
      
              Reviewed by Dirk Schulze.
      
              Next patch preparing animVal support. Modify the SVGAnimatedProperty* classes & macros to assure that calling someElement->someProperty()
              will return the animVal, when the property is being animated. Not yet hooked into SVGAnimateElement, this is just a preparation.
      
              Doesn't affect any tests, yet.
      
              * svg/SVGPathElement.cpp: Adapt to SVGAnimatedProperty::lookupWrapper changes (new template parameters have been added).
              (WebCore::SVGPathElement::svgAttributeChanged):
              * svg/SVGPathSegWithContext.h: Ditto.
              (WebCore::SVGPathSegWithContext::animatedProperty):
              * svg/SVGPolyElement.cpp: Ditto.
              (WebCore::SVGPolyElement::parseMappedAttribute):
              * svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Implement currentAnimatedValue, an abstract way to retrieve the underlying animated value for any animated type.
              (WebCore::SVGAnimatedEnumerationPropertyTearOff::currentAnimatedValue): Forward call to SVGAnimatedStaticPropertyTearOff<int>, our base.
              * svg/properties/SVGAnimatedListPropertyTearOff.h:
              (WebCore::SVGAnimatedListPropertyTearOff::isAnimating): Returns whether this property is being animated or not.
              (WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
              * svg/properties/SVGAnimatedProperty.h:
              (WebCore::SVGAnimatedProperty::updateAnimVal): Will be used from SVGAnim*Element to update the current animVal, exposed to JS.
              (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper): Share more code with lookupWrapper.
              (WebCore::SVGAnimatedProperty::lookupWrapper): Cleanup code, avoid doing any work for non-SVGElement derived objects, like SVGViewSpec.
              * svg/properties/SVGAnimatedPropertyMacros.h: Make all lowerProperty() calls (eg. myRectElement->x()) return the animVal, if the property is being animated.
              * svg/properties/SVGAnimatedPropertyTearOff.h: Main logic for the new animVal stuff.
              (WebCore::SVGAnimatedPropertyTearOff::isAnimating):
              (WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue):
              (WebCore::SVGAnimatedPropertyTearOff::updateAnimVal):
              (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):
              * svg/properties/SVGAnimatedStaticPropertyTearOff.h:
              (WebCore::SVGAnimatedStaticPropertyTearOff::isAnimating):
              (WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
              * svg/properties/SVGPropertyTearOff.h:
              (WebCore::SVGPropertyTearOff::updateAnimVal):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f0b1689
    • hans@chromium.org's avatar
      Update another test that relied on fonts loading synchronously. · 9af69e40
      hans@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65169
      
      Not Reviewed, tests fix.
      
      * platform/chromium-linux/fast/text/international/arabic-vertical-offset.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9af69e40
    • commit-queue@webkit.org's avatar
      Source/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr. · f1ec6dc3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57746
      
      Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-26
      Reviewed by Kent Tamura.
      
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::stripWhiteSpace):
        Added an interface to take IsWhiteSpaceFunctionPtr.
      (WTF::StringImpl::simplifyWhiteSpace): ditto.
      * wtf/text/StringImpl.h:
      * wtf/text/WTFString.cpp:
      (WTF::String::stripWhiteSpace): ditto.
      (WTF::String::simplifyWhiteSpace): ditto.
      * wtf/text/WTFString.h:
      
      Source/WebCore: Uses isHTMLSpace to normalize white spaces.
      https://bugs.webkit.org/show_bug.cgi?id=57746
      
      Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-26
      Reviewed by Kent Tamura.
      
      Test: fast/forms/option-strip-unicode-spaces.html
      
      * dom/OptionElement.cpp:
      (WebCore::OptionElement::normalizeText):
        Uses isHTMLSpace to trim and replace white spaces.
      
      LayoutTests: Added a test to normalize option.text.
      https://bugs.webkit.org/show_bug.cgi?id=57746
      
      Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-26
      Reviewed by Kent Tamura.
      
      * fast/forms/option-strip-unicode-spaces-expected.txt: Added.
      * fast/forms/option-strip-unicode-spaces.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1ec6dc3
    • morrita@google.com's avatar
      [Chromium][DRT] MockSpellCheck.cpp should be clang clean · 9ad89a96
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65166
      
      Reviewed by Kent Tamura.
      
      * DumpRenderTree/chromium/MockSpellCheck.cpp:
      (MockSpellCheck::spellCheckWord): -Wsign-compare warning.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ad89a96
    • commit-queue@webkit.org's avatar
      Add regression test for :empty { display: none } · 11761068
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=26570
      
      Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-07-26
      Reviewed by Alexey Proskuryakov.
      
      * fast/css/pseudo-empty-display-none-expected.txt: Added.
      * fast/css/pseudo-empty-display-none.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11761068
  2. 25 Jul, 2011 28 commits