1. 07 Sep, 2011 4 commits
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r94627 and r94632. · f192b44a
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/94627
      http://trac.webkit.org/changeset/94632
      https://bugs.webkit.org/show_bug.cgi?id=67698
      
      It broke tests on GTK and Qt (Requested by Ossy on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07
      
      Source/JavaScriptCore:
      
      * API/JSCallbackConstructor.cpp:
      (JSC::JSCallbackConstructor::JSCallbackConstructor):
      * API/JSCallbackConstructor.h:
      (JSC::JSCallbackConstructor::create):
      * API/JSCallbackFunction.cpp:
      (JSC::JSCallbackFunction::JSCallbackFunction):
      * API/JSCallbackFunction.h:
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::create):
      * debugger/DebuggerActivation.h:
      * jsc.cpp:
      (GlobalObject::constructorBody):
      (GlobalObject::GlobalObject):
      * runtime/ArrayConstructor.cpp:
      (JSC::ArrayConstructor::ArrayConstructor):
      * runtime/ArrayConstructor.h:
      * runtime/ArrayPrototype.cpp:
      (JSC::ArrayPrototype::ArrayPrototype):
      * runtime/ArrayPrototype.h:
      (JSC::ArrayPrototype::create):
      * runtime/BooleanConstructor.cpp:
      (JSC::BooleanConstructor::BooleanConstructor):
      * runtime/BooleanConstructor.h:
      * runtime/BooleanObject.cpp:
      (JSC::BooleanObject::BooleanObject):
      * runtime/BooleanObject.h:
      (JSC::BooleanObject::create):
      * runtime/BooleanPrototype.cpp:
      (JSC::BooleanPrototype::BooleanPrototype):
      * runtime/BooleanPrototype.h:
      * runtime/DateConstructor.cpp:
      (JSC::DateConstructor::DateConstructor):
      * runtime/DateConstructor.h:
      * runtime/DateInstance.cpp:
      (JSC::DateInstance::DateInstance):
      * runtime/DateInstance.h:
      (JSC::DateInstance::create):
      * runtime/DatePrototype.cpp:
      (JSC::DatePrototype::DatePrototype):
      * runtime/DatePrototype.h:
      * runtime/Error.cpp:
      (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
      * runtime/ErrorConstructor.cpp:
      (JSC::ErrorConstructor::ErrorConstructor):
      * runtime/ErrorConstructor.h:
      (JSC::ErrorConstructor::create):
      * runtime/ErrorPrototype.cpp:
      (JSC::ErrorPrototype::ErrorPrototype):
      * runtime/ErrorPrototype.h:
      (JSC::ErrorPrototype::create):
      * runtime/FunctionConstructor.cpp:
      (JSC::FunctionConstructor::FunctionConstructor):
      * runtime/FunctionConstructor.h:
      * runtime/FunctionPrototype.cpp:
      (JSC::FunctionPrototype::FunctionPrototype):
      * runtime/FunctionPrototype.h:
      * runtime/InternalFunction.cpp:
      (JSC::InternalFunction::InternalFunction):
      * runtime/InternalFunction.h:
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::JSActivation):
      * runtime/JSActivation.h:
      (JSC::JSActivation::create):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::create):
      (JSC::JSGlobalObject::JSGlobalObject):
      * runtime/JSONObject.cpp:
      (JSC::JSONObject::JSONObject):
      * runtime/JSONObject.h:
      (JSC::JSONObject::create):
      * runtime/JSStaticScopeObject.h:
      (JSC::JSStaticScopeObject::create):
      (JSC::JSStaticScopeObject::JSStaticScopeObject):
      * runtime/JSString.cpp:
      (JSC::StringObject::create):
      * runtime/MathObject.cpp:
      (JSC::MathObject::MathObject):
      * runtime/MathObject.h:
      (JSC::MathObject::create):
      * runtime/NativeErrorConstructor.cpp:
      (JSC::NativeErrorConstructor::NativeErrorConstructor):
      * runtime/NativeErrorConstructor.h:
      (JSC::NativeErrorConstructor::constructorBody):
      * runtime/NativeErrorPrototype.cpp:
      (JSC::NativeErrorPrototype::NativeErrorPrototype):
      (JSC::NativeErrorPrototype::constructorBody):
      * runtime/NativeErrorPrototype.h:
      * runtime/NumberConstructor.cpp:
      (JSC::NumberConstructor::NumberConstructor):
      * runtime/NumberConstructor.h:
      * runtime/NumberObject.cpp:
      (JSC::NumberObject::NumberObject):
      * runtime/NumberObject.h:
      (JSC::NumberObject::create):
      * runtime/NumberPrototype.cpp:
      (JSC::NumberPrototype::NumberPrototype):
      * runtime/NumberPrototype.h:
      * runtime/ObjectConstructor.cpp:
      (JSC::ObjectConstructor::ObjectConstructor):
      * runtime/ObjectConstructor.h:
      * runtime/RegExpConstructor.cpp:
      (JSC::RegExpConstructor::RegExpConstructor):
      (JSC::RegExpMatchesArray::RegExpMatchesArray):
      * runtime/RegExpConstructor.h:
      * runtime/RegExpMatchesArray.h:
      (JSC::RegExpMatchesArray::create):
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::RegExpObject):
      * runtime/RegExpObject.h:
      (JSC::RegExpObject::create):
      * runtime/RegExpPrototype.cpp:
      (JSC::RegExpPrototype::RegExpPrototype):
      * runtime/StringConstructor.cpp:
      (JSC::StringConstructor::StringConstructor):
      * runtime/StringConstructor.h:
      * runtime/StringObject.cpp:
      (JSC::StringObject::StringObject):
      * runtime/StringObject.h:
      (JSC::StringObject::create):
      * runtime/StringObjectThatMasqueradesAsUndefined.h:
      (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
      * runtime/StringPrototype.cpp:
      (JSC::StringPrototype::StringPrototype):
      * runtime/StringPrototype.h:
      
      Source/JavaScriptGlue:
      
      * JSRun.cpp:
      (JSGlueGlobalObject::JSGlueGlobalObject):
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * bindings/js/JSDOMBinding.h:
      (WebCore::DOMConstructorObject::DOMConstructorObject):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
      * bindings/js/JSDOMGlobalObject.h:
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::create):
      * bindings/js/JSDOMWindowShell.h:
      * bindings/js/JSDOMWrapper.h:
      (WebCore::JSDOMWrapper::JSDOMWrapper):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore::JSTestInterface::JSTestInterface):
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::JSTestObj::JSTestObj):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
      * bridge/c/CRuntimeObject.cpp:
      (JSC::Bindings::CRuntimeObject::CRuntimeObject):
      * bridge/c/CRuntimeObject.h:
      * bridge/jni/jsc/JavaRuntimeObject.cpp:
      (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
      * bridge/jni/jsc/JavaRuntimeObject.h:
      * bridge/objc/ObjCRuntimeObject.h:
      * bridge/objc/ObjCRuntimeObject.mm:
      (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
      * bridge/objc/objc_runtime.h:
      (JSC::Bindings::ObjcFallbackObjectImp::create):
      * bridge/objc/objc_runtime.mm:
      (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
      * bridge/qt/qt_pixmapruntime.cpp:
      (JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
      * bridge/qt/qt_runtime.h:
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::RuntimeArray):
      * bridge/runtime_array.h:
      (JSC::RuntimeArray::create):
      * bridge/runtime_method.cpp:
      (JSC::RuntimeMethod::RuntimeMethod):
      * bridge/runtime_method.h:
      * bridge/runtime_object.cpp:
      (JSC::Bindings::RuntimeObject::RuntimeObject):
      * bridge/runtime_object.h:
      (JSC::Bindings::RuntimeObject::create):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/ProxyRuntimeObject.h:
      * Plugins/Hosted/ProxyRuntimeObject.mm:
      (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
      (WebKit::JSNPMethod::JSNPMethod):
      (WebKit::JSNPMethod::create):
      * WebProcess/Plugins/Netscape/JSNPMethod.h:
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::JSNPObject::JSNPObject):
      (WebKit::JSNPObject::create):
      * WebProcess/Plugins/Netscape/JSNPObject.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f192b44a
    • yurys@chromium.org's avatar
      fast/workers/worker-script-error.html fails on Chromium after r94061 · aa8719b9
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67206
      
      Source/WebCore:
      
      Default action should be prevented if window.onerror returned true and stay
      not prevented otherwise.
      
      Reviewed by Dmitry Titov.
      
      Tests: fast/events/window-onerror14.html
             fast/events/window-onerror15.html
             fast/events/window-onerror16.html
      
      * bindings/v8/V8AbstractEventListener.cpp:
      (WebCore::V8AbstractEventListener::invokeEventHandler):
      (WebCore::V8AbstractEventListener::shouldPreventDefault): allow specific
      event listeners to decide when to prevent default action based on the handler
      return value.
      * bindings/v8/V8AbstractEventListener.h:
      * bindings/v8/V8WindowErrorHandler.cpp:
      (WebCore::V8WindowErrorHandler::callListenerFunction):
      (WebCore::V8WindowErrorHandler::shouldPreventDefault):
      * bindings/v8/V8WindowErrorHandler.h:
      * bindings/v8/V8WorkerContextErrorHandler.cpp:
      (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
      (WebCore::V8WorkerContextErrorHandler::shouldPreventDefault):
      * bindings/v8/V8WorkerContextErrorHandler.h:
      
      LayoutTests:
      
      Add a couple more tests for window.onerror handler that check whether
      error message is printed to the console pending on the handler return
      value.
      
      Reviewed by Dmitry Titov.
      
      * fast/events/window-onerror14-expected.txt: Added.
      * fast/events/window-onerror14.html: Added.
      * fast/events/window-onerror15-expected.txt: Added.
      * fast/events/window-onerror15.html: Added.
      * fast/events/window-onerror16-expected.txt: Added.
      * fast/events/window-onerror16.html: Added.
      * platform/chromium/fast/events/window-onerror16-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa8719b9
    • yurys@chromium.org's avatar
      [Chromium] Web Inspector: repair console sniffing for interactive ui tests · 02eacc22
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67608
      
      Reviewed by Pavel Feldman.
      
      * src/js/Tests.js:
      (.TestSuite.prototype.evaluateInConsole_):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02eacc22
    • ossy@webkit.org's avatar
      Unreviewed buildfix after r94620. · 23f7590f
      ossy@webkit.org authored
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::createFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23f7590f
  2. 06 Sep, 2011 36 commits
    • commit-queue@webkit.org's avatar
      Replace usages of Vector<UChar> with existing StringBuilder · c28243e3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67079
      
      Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-06
      Reviewed by Gavin Barraclough.
      
      Source/JavaScriptCore:
      
      This is part of work to support 8-bit string buffers.
      Adds StringBuilder::characters() because the original Vector<UChar>::data()
      is widely used.
      Sets the minimum size of buffer to 16 to prevent possible performance
      regression. Further performance investigation should be done in
      https://bugs.webkit.org/show_bug.cgi?id=67084.
      
      * wtf/Forward.h:
      * wtf/text/StringBuilder.cpp:
      (WTF::StringBuilder::appendUninitialized): Sets minimum buffer size to 16 bytes.
      * wtf/text/StringBuilder.h:
      (WTF::StringBuilder::operator[]):
      (WTF::StringBuilder::characters): Added.
      
      Source/WebCore:
      
      No new tests. All existing unit tests and layout tests should run
      as before.
      
      * css/CSSOMUtils.cpp:
      (WebCore::appendCharacter):
      (WebCore::serializeCharacter):
      (WebCore::serializeCharacterAsCodePoint):
      (WebCore::serializeIdentifier):
      (WebCore::serializeString):
      * css/CSSOMUtils.h:
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::cssText):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase):
      * css/CSSWrapShapes.cpp:
      (WebCore::CSSWrapShapeRect::cssText):
      (WebCore::CSSWrapShapeCircle::cssText):
      (WebCore::CSSWrapShapeEllipse::cssText):
      (WebCore::CSSWrapShapePolygon::cssText):
      * editing/HTMLInterchange.cpp:
      (WebCore::convertHTMLTextToInterchangeFormat):
      * editing/MarkupAccumulator.cpp:
      (WebCore::appendCharactersReplacingEntities):
      (WebCore::MarkupAccumulator::serializeNodes):
      (WebCore::MarkupAccumulator::appendStartTag):
      (WebCore::MarkupAccumulator::appendEndTag):
      (WebCore::MarkupAccumulator::concatenateMarkup):
      (WebCore::MarkupAccumulator::appendAttributeValue):
      (WebCore::MarkupAccumulator::appendCustomAttributes):
      (WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
      (WebCore::MarkupAccumulator::appendNodeValue):
      (WebCore::MarkupAccumulator::appendNamespace):
      (WebCore::MarkupAccumulator::appendText):
      (WebCore::MarkupAccumulator::appendComment):
      (WebCore::MarkupAccumulator::appendDocumentType):
      (WebCore::MarkupAccumulator::appendProcessingInstruction):
      (WebCore::MarkupAccumulator::appendElement):
      (WebCore::MarkupAccumulator::appendOpenTag):
      (WebCore::MarkupAccumulator::appendCloseTag):
      (WebCore::MarkupAccumulator::appendAttribute):
      (WebCore::MarkupAccumulator::appendCDATASection):
      (WebCore::MarkupAccumulator::appendStartMarkup):
      (WebCore::MarkupAccumulator::appendEndMarkup):
      * editing/MarkupAccumulator.h:
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::appendElement):
      (WebCore::StyledMarkupAccumulator::wrapWithNode):
      (WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
      (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
      (WebCore::StyledMarkupAccumulator::takeResults):
      (WebCore::StyledMarkupAccumulator::appendText):
      (WebCore::urlToMarkup):
      * html/DOMTokenList.cpp:
      (WebCore::DOMTokenList::removeToken):
      * html/HTMLFontElement.cpp:
      (WebCore::parseFontSize):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::strippedPlaceholder):
      * html/parser/CSSPreloadScanner.cpp:
      (WebCore::CSSPreloadScanner::emitRule):
      * html/parser/CSSPreloadScanner.h:
      * html/parser/HTMLEntityParser.cpp:
      (WebCore::consumeHTMLEntity):
      * html/parser/HTMLEntityParser.h:
      * html/parser/HTMLParserIdioms.cpp:
      (WebCore::parseHTMLInteger):
      (WebCore::parseHTMLNonNegativeInteger):
      * html/parser/HTMLTokenizer.cpp:
      (WebCore::HTMLTokenizer::processEntity):
      (WebCore::HTMLTokenizer::nextToken):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::giveRemainingTo):
      (WebCore::HTMLTreeBuilder::defaultForInTableText):
      * html/parser/HTMLTreeBuilder.h:
      * inspector/InspectorValues.cpp:
      (WebCore::InspectorValue::toJSONString):
      (WebCore::InspectorValue::writeJSON):
      (WebCore::InspectorBasicValue::writeJSON):
      (WebCore::InspectorString::writeJSON):
      (WebCore::InspectorObject::writeJSON):
      (WebCore::InspectorArray::writeJSON):
      * inspector/InspectorValues.h:
      * loader/CrossOriginAccessControl.cpp:
      (WebCore::createAccessControlPreflightRequest):
      * loader/appcache/ApplicationCacheStorage.cpp:
      (WebCore::ApplicationCacheStorage::store):
      * page/Chrome.cpp:
      (WebCore::Chrome::setToolTip):
      * page/PageSerializer.cpp:
      (WebCore::SerializerMarkupAccumulator::appendText):
      (WebCore::SerializerMarkupAccumulator::appendElement):
      (WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
      * page/SecurityOrigin.cpp:
      (WebCore::SecurityOrigin::toString):
      * platform/KURL.cpp:
      (WebCore::KURL::deprecatedString):
      (WebCore::decodeURLEscapeSequences):
      * platform/LinkHash.cpp:
      (WebCore::squeezeOutNullCharacters):
      (WebCore::cleanSlashDotDotSlashes):
      (WebCore::mergeDoubleSlashes):
      (WebCore::cleanSlashDotSlashes):
      (WebCore::cleanPath):
      (WebCore::visitedURLInline):
      (WebCore::visitedURL):
      (WebCore::visitedLinkHash):
      * platform/LinkHash.h:
      * platform/gtk/DataObjectGtk.cpp:
      (WebCore::DataObjectGtk::setURL):
      * platform/network/HTTPParsers.cpp:
      (WebCore::extractMIMETypeFromMediaType):
      * platform/text/TextCodecICU.cpp:
      (WebCore::TextCodecICU::decode):
      * platform/text/TextStream.cpp:
      (WebCore::TextStream::operator<<):
      (WebCore::TextStream::release):
      * platform/text/TextStream.h:
      * plugins/PluginStream.cpp:
      (WebCore::PluginStream::startStream):
      * rendering/InlineTextBox.cpp:
      (WebCore::adjustCharactersAndLengthForHyphen):
      * rendering/InlineTextBox.h:
      (WebCore::BufferForAppendingHyphen::BufferForAppendingHyphen):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::markerTextWithSuffix):
      * rendering/RenderListMarker.cpp:
      (WebCore::toSymbolic):
      (WebCore::RenderListMarker::paint):
      (WebCore::RenderListMarker::suffix):
      * rendering/RenderTreeAsText.cpp:
      (WebCore::quoteAndEscapeNonPrintables):
      * rendering/mathml/RenderMathMLFenced.cpp:
      (WebCore::RenderMathMLFenced::updateFromElement):
      * storage/IDBLevelDBCoding.cpp:
      (WebCore::IDBLevelDBCoding::decodeString):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::getAllResponseHeaders):
      * xml/XPathFunctions.cpp:
      (WebCore::XPath::FunId::evaluate):
      (WebCore::XPath::FunConcat::evaluate):
      * xml/XPathUtil.cpp:
      (WebCore::XPath::stringValue):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::writeToStringBuilder):
      (WebCore::saveResultToString):
      * xml/parser/CharacterReferenceParserInlineMethods.h:
      (WebCore::unconsumeCharacters):
      (WebCore::consumeCharacterReference):
      * xml/parser/XMLCharacterReferenceParser.cpp:
      (WebCore::consumeXMLCharacterReference):
      * xml/parser/XMLCharacterReferenceParser.h:
      * xml/parser/XMLTokenizer.cpp:
      (WebCore::XMLTokenizer::nextToken):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c28243e3
    • tkent@chromium.org's avatar
      REGRESSION (Safari 5.1 - ToT): File input retains its file icon when the value is reset · 97ec98f9
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67567
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      - Introduce InputType::setValue(), which is called by HTMLInputElement::setValue().
      - Clear m_icon in FileInputType::setValue().
      
      Tests: fast/forms/file/file-reset-in-change-expected.html
             fast/forms/file/file-reset-in-change.html
      
      * html/BaseButtonInputType.cpp:
      (WebCore::BaseButtonInputType::setValue):
      Implemenation for the "default" mode.
      http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-default
      * html/BaseButtonInputType.h:
      * html/BaseCheckableInputType.cpp:
      (WebCore::BaseCheckableInputType::setValue):
      Implemenation for the "default/on" mode.
      http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-default-on
      * html/BaseCheckableInputType.h:
      * html/FileInputType.cpp:
      (WebCore::FileInputType::setValue):
      Implemenation for the "filename" mode, and clearing m_icon.
      http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-filename
      * html/FileInputType.h:
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::setValue):
      Move some code to InputType::setValue().
      (WebCore::HTMLInputElement::setValueInternal): A helper for InputType::setValue().
      * html/HTMLInputElement.h:
      * html/HiddenInputType.cpp:
      (WebCore::HiddenInputType::setValue):
      Implementation for the "default" mode.
      * html/HiddenInputType.h:
      * html/InputType.cpp:
      (WebCore::InputType::setValue):
      Implementation for the "value" mode.
      http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-value-value
      * html/InputType.h:
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::setValue):
      In addition to the "value" mode processing, updates placeholder visibililty.
      * html/TextFieldInputType.h:
      
      LayoutTests:
      
      * fast/forms/file/file-reset-in-change-expected.html: Added.
      * fast/forms/file/file-reset-in-change.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97ec98f9
    • rniwa@webkit.org's avatar
      Qt rebaseline after r94614. · 8ba899a6
      rniwa@webkit.org authored
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/qt/fast/js/global-constructors-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ba899a6
    • rniwa@webkit.org's avatar
      REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set · fb527461
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67681
      
      Reviewed by Kent Tamura.
      
      Source/WebCore: 
      
      The bug was caused by HTMLInputElement::setValue's not clearing m_suggestedValue before updateInnerTextValue is called.
      Since updateInnerTextValue uses the suggested value when one is present, we need to clear m_suggestedValue in advance.
      
      Test: fast/forms/suggested-value-after-setvalue.html
      
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::setValue):
      
      LayoutTests: 
      
      Added a test that overrides the suggested value by modifying the value IDL attribute of an input element.
      
      * fast/forms/suggested-value-after-setvalue-expected.txt: Added.
      * fast/forms/suggested-value-after-setvalue.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb527461
    • abarth@webkit.org's avatar
      Attempt to fix GTK build. · 05e42505
      abarth@webkit.org authored
      * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
      (WebKit::createHTMLElementWrapper):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05e42505
    • commit-queue@webkit.org's avatar
      [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent · ad0dadcd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66800
      
      Patch by Eric Boren <borenet@gmail.com> on 2011-09-06
      Reviewed by Darin Fisher.
      
      Source/WebKit/chromium:
      
      * public/WebInputEvent.h:
      (WebKit::WebTouchEvent::WebTouchEvent):
      * public/WebTouchPoint.h:
      (WebKit::WebTouchPoint::WebTouchPoint):
      * src/WebInputEventConversion.cpp:
      (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
      (WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
      * src/WebInputEventConversion.h:
      
      Tools:
      
      * DumpRenderTree/chromium/EventSender.cpp:
      (EventSender::sendCurrentTouchEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad0dadcd
    • ap@apple.com's avatar
      Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is flaky · 52649455
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67653
      
      Reviewed by James Robinson.
      
      * fast/dom/HTMLMeterElement/meter-element-crash.html: Added waitUntilDone/notifyDone,
      and changed "1" that's displayed after testing to "PASS".
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52649455
    • rniwa@webkit.org's avatar
      fast/forms/suggested-value-crash.html crashes on Windows · 8f35f0e6
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67688
      
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      The crash was caused because functions in internals were accessing uninitialized QualifiedNames.
      Fixed the bug by avoiding to link to inputTag and textareaTag. Instead, we resort to toInputElement
      and string comparison.
      
      * testing/Internals.cpp:
      (WebCore::Internals::wasLastChangeUserEdit):
      (WebCore::Internals::suggestedValue):
      (WebCore::Internals::setSuggestedValue):
      
      Source/WebKit2: 
      
      Removed sybmols for inputTag and textareaTag. Added the symbol for StringImpl::equal.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f35f0e6
    • commit-queue@webkit.org's avatar
      Fix broken snow leopard build · 5c17ddf0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67693
      
      Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
      Reviewed by Daniel Bates.
      
      Removed unnecessary symbol export.
      
      * JavaScriptCore.exp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c17ddf0
    • abarth@webkit.org's avatar
      garden-o-matic details view should having working rebaseline and next/previous buttons · e3c8dc4e
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67659
      
      Reviewed by Dimitri Glazkov.
      
      This patch wires up basic back/forward buttons that let you traverse
      through the results we're examining in the details view.  This ended up
      being more code than I expected, but I wanted to keep all the state
      information in the DOM itself.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3c8dc4e
    • commit-queue@webkit.org's avatar
      [chromium] Fix WebFrameClient receiving isRedirect when reloading · eb6bb057
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63591
      
      Patch by Ben Smith <binji@chromium.org> on 2011-09-06
      Reviewed by Adam Barth.
      
      Fix bug when quickly reloading a WebFrame where the
      WebFrameClient would get called with decidePolicyForNavigation
      isRedirect=true.
      
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
      * src/WebDataSourceImpl.h:
      (WebKit::WebDataSourceImpl::isRedirect):
      * tests/WebFrameTest.cpp:
      (WebKit::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation):
      (WebKit::TestReloadDoesntRedirectWebFrameClient::cancelledError):
      (WebKit::TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb6bb057
    • fpizlo@apple.com's avatar
      DFG JIT does not optimize booleans · 746c6d07
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67670
      
      Reviewed by Gavin Barraclough.
      
      This adds boolean value profiling, boolean prediction in the DFG,
      boolean forward flow propagation in the DFGPropagator, boolean
      data format in DFG generation info, and comprehensive optimizations
      based on both boolean prediction and boolean generation info.
      This is brings the speed-up on v8-richards to 12%, and gives slight
      speed-ups elsewhere as well.
      
      Making this work right required navigating some subtleties in
      value profiling.  Some functions get compiled with insufficient
      information because some important path of the function never
      executed.  In these cases, we wish to fall back on static
      speculation.  But to do so, we need to ensure that predictions that
      are inherent in the code (like that GetById almost certainly takes
      a cell operand) are reflected in predictions that we make in
      DFGPropagator.  Thus, DFGPropagator now does both backward and
      forward flow, using a both forward and backward fixpoint.
      
      The backward flow in DFGPropagator is a separate static analysis,
      and needs to keep a set of backward flow abstract values for
      variables, arguments, and globals.  To make this easy, this patch
      factors out DFGGraph's prediction tracking capability into
      DFGPredictionTracker, which now gets used by both DFGGraph (for
      forward flow predictions) and DFGPropagator (for backward flow
      predictions).  Backward flow predictions eventually get merged
      into forward flow ones, but the two are not equivalent: a forward
      flow prediction is a superset of the backward flow prediction.
      
      Debugging these prediction issues required a better understanding
      of where we fail speculation, and what our value predictions look
      like.  This patch also adds optional verbose speculation failure
      (so an informative printf fires whenever speculation failure occurs)
      and slight improvements to the verbosity in other places.
      
      * bytecode/ValueProfile.h:
      (JSC::ValueProfile::numberOfBooleans):
      (JSC::ValueProfile::probabilityOfBoolean):
      (JSC::ValueProfile::dump):
      (JSC::ValueProfile::computeStatistics):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::stronglyPredict):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGGenerationInfo.h:
      (JSC::DFG::dataFormatToString):
      (JSC::DFG::needDataFormatConversion):
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::dump):
      (JSC::DFG::Graph::predictArgumentTypes):
      * dfg/DFGGraph.h:
      (JSC::DFG::Graph::Graph):
      (JSC::DFG::Graph::predictions):
      (JSC::DFG::Graph::predict):
      (JSC::DFG::Graph::predictGlobalVar):
      (JSC::DFG::Graph::getPrediction):
      (JSC::DFG::Graph::getGlobalVarPrediction):
      (JSC::DFG::Graph::isBooleanConstant):
      (JSC::DFG::Graph::valueOfBooleanConstant):
      * dfg/DFGJITCodeGenerator.cpp:
      (JSC::DFG::JITCodeGenerator::fillInteger):
      (JSC::DFG::JITCodeGenerator::fillDouble):
      (JSC::DFG::JITCodeGenerator::fillJSValue):
      (JSC::DFG::JITCodeGenerator::isKnownNotInteger):
      (JSC::DFG::JITCodeGenerator::isKnownBoolean):
      (JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
      (JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
      (JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
      (JSC::DFG::JITCodeGenerator::emitBranch):
      (JSC::DFG::JITCodeGenerator::speculationCheck):
      (JSC::DFG::GPRTemporary::GPRTemporary):
      * dfg/DFGJITCodeGenerator.h:
      (JSC::DFG::JITCodeGenerator::isBooleanConstant):
      (JSC::DFG::JITCodeGenerator::valueOfBooleanConstant):
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
      (JSC::DFG::JITCompiler::link):
      * dfg/DFGJITCompiler.h:
      (JSC::DFG::JITCompiler::debugCall):
      (JSC::DFG::JITCompiler::isBooleanConstant):
      (JSC::DFG::JITCompiler::valueOfBooleanConstant):
      * dfg/DFGNode.h:
      (JSC::DFG::isBooleanPrediction):
      (JSC::DFG::predictionToString):
      (JSC::DFG::mergePredictions):
      (JSC::DFG::makePrediction):
      (JSC::DFG::Node::isBooleanConstant):
      (JSC::DFG::Node::valueOfBooleanConstant):
      (JSC::DFG::Node::hasBooleanResult):
      (JSC::DFG::Node::hasNumericResult):
      (JSC::DFG::Node::predict):
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h:
      * dfg/DFGPredictionTracker.h: Added.
      (JSC::DFG::operandIsArgument):
      (JSC::DFG::PredictionSlot::PredictionSlot):
      (JSC::DFG::PredictionTracker::PredictionTracker):
      (JSC::DFG::PredictionTracker::initializeSimilarTo):
      (JSC::DFG::PredictionTracker::numberOfArguments):
      (JSC::DFG::PredictionTracker::numberOfVariables):
      (JSC::DFG::PredictionTracker::argumentIndexForOperand):
      (JSC::DFG::PredictionTracker::predictArgument):
      (JSC::DFG::PredictionTracker::predict):
      (JSC::DFG::PredictionTracker::predictGlobalVar):
      (JSC::DFG::PredictionTracker::getArgumentPrediction):
      (JSC::DFG::PredictionTracker::getPrediction):
      (JSC::DFG::PredictionTracker::getGlobalVarPrediction):
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::Propagator):
      (JSC::DFG::Propagator::fixpoint):
      (JSC::DFG::Propagator::setPrediction):
      (JSC::DFG::Propagator::mergeUse):
      (JSC::DFG::Propagator::mergePrediction):
      (JSC::DFG::Propagator::propagateNode):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
      (JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
      (JSC::DFG::SpeculativeJIT::fillSpeculateCell):
      (JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
      (JSC::DFG::SpeculativeJIT::compare):
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
      (JSC::DFG::SpeculateBooleanOperand::~SpeculateBooleanOperand):
      (JSC::DFG::SpeculateBooleanOperand::index):
      (JSC::DFG::SpeculateBooleanOperand::gpr):
      (JSC::DFG::SpeculateBooleanOperand::use):
      * runtime/JSGlobalData.h:
      * runtime/JSValue.cpp:
      (JSC::JSValue::description):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      746c6d07
    • commit-queue@webkit.org's avatar
      Rebaseline for bug 65583 (path based border radius drawing on skia) · 68fa5def
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67596
      
      Patch by Ben Wells <benwells@chromium.org> on 2011-09-06
      Reviewed by Kenneth Russell.
      
      * fast/backgrounds/gradient-background-leakage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/gradient-background-leakage-expected.txt.
      * fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt.
      * fast/box-shadow/spread-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/spread-expected.txt.
      * fast/css/box-shadow-and-border-radius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt.
      * fast/css/color-leakage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/color-leakage-expected.txt.
      * fast/css/nested-rounded-corners-expected.txt:
      * platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png: Added.
      * platform/chromium-linux/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
      * platform/chromium-linux/fast/: 17 changes
      * platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png: Added.
      * platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png: Added.
      * platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
      * platform/chromium-win/fast/: 19 changes
      * platform/chromium/test_expectations.txt:
      * platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Renamed from LayoutTests/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png.
      * platform/gtk/fast/css/nested-rounded-corners-expected.txt: Removed.
      * platform/mac/fast/: 5 files removed
      * platform/mac/fast/css/nested-rounded-corners-expected.txt: Copied from LayoutTests/fast/css/nested-rounded-corners-expected.txt.
      * platform/qt/: 6 files removed
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68fa5def
    • commit-queue@webkit.org's avatar
      Unzip initialization lists and constructors in JSCell hierarchy (5/7) · 5ab29813
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67420
      
      Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * API/JSCallbackConstructor.cpp:
      (JSC::JSCallbackConstructor::JSCallbackConstructor):
      * API/JSCallbackConstructor.h:
      (JSC::JSCallbackConstructor::create):
      * API/JSCallbackFunction.cpp:
      (JSC::JSCallbackFunction::JSCallbackFunction):
      (JSC::JSCallbackFunction::finishCreation):
      * API/JSCallbackFunction.h:
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * debugger/DebuggerActivation.cpp:
      * debugger/DebuggerActivation.h:
      (JSC::DebuggerActivation::create):
      * jsc.cpp:
      (GlobalObject::finishCreation):
      (GlobalObject::GlobalObject):
      * runtime/ArrayConstructor.cpp:
      (JSC::ArrayConstructor::ArrayConstructor):
      (JSC::ArrayConstructor::finishCreation):
      * runtime/ArrayConstructor.h:
      * runtime/ArrayPrototype.cpp:
      (JSC::ArrayPrototype::ArrayPrototype):
      * runtime/ArrayPrototype.h:
      (JSC::ArrayPrototype::create):
      * runtime/BooleanConstructor.cpp:
      (JSC::BooleanConstructor::BooleanConstructor):
      (JSC::BooleanConstructor::finishCreation):
      * runtime/BooleanConstructor.h:
      * runtime/BooleanObject.cpp:
      (JSC::BooleanObject::BooleanObject):
      * runtime/BooleanObject.h:
      (JSC::BooleanObject::create):
      * runtime/BooleanPrototype.cpp:
      (JSC::BooleanPrototype::BooleanPrototype):
      (JSC::BooleanPrototype::finishCreation):
      * runtime/BooleanPrototype.h:
      * runtime/DateConstructor.cpp:
      (JSC::DateConstructor::DateConstructor):
      (JSC::DateConstructor::finishCreation):
      * runtime/DateConstructor.h:
      * runtime/DateInstance.cpp:
      (JSC::DateInstance::DateInstance):
      * runtime/DateInstance.h:
      (JSC::DateInstance::create):
      * runtime/DatePrototype.cpp:
      (JSC::DatePrototype::DatePrototype):
      (JSC::DatePrototype::finishCreation):
      * runtime/DatePrototype.h:
      * runtime/Error.cpp:
      (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
      * runtime/ErrorConstructor.cpp:
      (JSC::ErrorConstructor::ErrorConstructor):
      (JSC::ErrorConstructor::finishCreation):
      * runtime/ErrorConstructor.h:
      * runtime/ErrorPrototype.cpp:
      (JSC::ErrorPrototype::ErrorPrototype):
      * runtime/ErrorPrototype.h:
      (JSC::ErrorPrototype::create):
      * runtime/FunctionConstructor.cpp:
      (JSC::FunctionConstructor::FunctionConstructor):
      (JSC::FunctionConstructor::finishCreation):
      * runtime/FunctionConstructor.h:
      * runtime/FunctionPrototype.cpp:
      (JSC::FunctionPrototype::FunctionPrototype):
      (JSC::FunctionPrototype::finishCreation):
      * runtime/FunctionPrototype.h:
      * runtime/InternalFunction.cpp:
      (JSC::InternalFunction::InternalFunction):
      * runtime/InternalFunction.h:
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::JSActivation):
      * runtime/JSActivation.h:
      (JSC::JSActivation::create):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::create):
      (JSC::JSGlobalObject::JSGlobalObject):
      * runtime/JSONObject.cpp:
      (JSC::JSONObject::JSONObject):
      * runtime/JSONObject.h:
      (JSC::JSONObject::create):
      * runtime/JSStaticScopeObject.h:
      (JSC::JSStaticScopeObject::create):
      (JSC::JSStaticScopeObject::JSStaticScopeObject):
      * runtime/JSString.cpp:
      (JSC::StringObject::create):
      * runtime/MathObject.cpp:
      (JSC::MathObject::MathObject):
      * runtime/MathObject.h:
      (JSC::MathObject::create):
      * runtime/NativeErrorConstructor.cpp:
      (JSC::NativeErrorConstructor::NativeErrorConstructor):
      * runtime/NativeErrorConstructor.h:
      (JSC::NativeErrorConstructor::finishCreation):
      * runtime/NativeErrorPrototype.cpp:
      (JSC::NativeErrorPrototype::NativeErrorPrototype):
      (JSC::NativeErrorPrototype::finishCreation):
      * runtime/NativeErrorPrototype.h:
      * runtime/NumberConstructor.cpp:
      (JSC::NumberConstructor::NumberConstructor):
      (JSC::NumberConstructor::finishCreation):
      * runtime/NumberConstructor.h:
      * runtime/NumberObject.cpp:
      (JSC::NumberObject::NumberObject):
      * runtime/NumberObject.h:
      (JSC::NumberObject::create):
      * runtime/NumberPrototype.cpp:
      (JSC::NumberPrototype::NumberPrototype):
      (JSC::NumberPrototype::finishCreation):
      * runtime/NumberPrototype.h:
      * runtime/ObjectConstructor.cpp:
      (JSC::ObjectConstructor::ObjectConstructor):
      (JSC::ObjectConstructor::finishCreation):
      * runtime/ObjectConstructor.h:
      * runtime/RegExpConstructor.cpp:
      (JSC::RegExpConstructor::RegExpConstructor):
      (JSC::RegExpConstructor::finishCreation):
      (JSC::RegExpMatchesArray::RegExpMatchesArray):
      * runtime/RegExpConstructor.h:
      * runtime/RegExpMatchesArray.h:
      (JSC::RegExpMatchesArray::create):
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::RegExpObject):
      * runtime/RegExpObject.h:
      (JSC::RegExpObject::create):
      * runtime/RegExpPrototype.cpp:
      (JSC::RegExpPrototype::RegExpPrototype):
      * runtime/StringConstructor.cpp:
      (JSC::StringConstructor::StringConstructor):
      (JSC::StringConstructor::finishCreation):
      * runtime/StringConstructor.h:
      * runtime/StringObject.cpp:
      (JSC::StringObject::StringObject):
      * runtime/StringObject.h:
      (JSC::StringObject::create):
      * runtime/StringObjectThatMasqueradesAsUndefined.h:
      (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
      * runtime/StringPrototype.cpp:
      (JSC::StringPrototype::StringPrototype):
      (JSC::StringPrototype::finishCreation):
      * runtime/StringPrototype.h:
      
      Source/JavaScriptGlue:
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * JSRun.cpp:
      (JSGlueGlobalObject::JSGlueGlobalObject):
      
      Source/WebCore:
      
      No new tests.
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * WebCore.exp.in:
      * bindings/js/JSDOMBinding.h:
      (WebCore::DOMConstructorObject::DOMConstructorObject):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
      (WebCore::JSDOMGlobalObject::finishCreation):
      * bindings/js/JSDOMGlobalObject.h:
      * bindings/js/JSDOMWindowShell.cpp:
      * bindings/js/JSDOMWindowShell.h:
      (WebCore::JSDOMWindowShell::create):
      * bindings/js/JSDOMWrapper.h:
      (WebCore::JSDOMWrapper::JSDOMWrapper):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore::JSTestInterface::JSTestInterface):
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::JSTestObj::JSTestObj):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
      * bridge/c/CRuntimeObject.cpp:
      (JSC::Bindings::CRuntimeObject::CRuntimeObject):
      (JSC::Bindings::CRuntimeObject::finishCreation):
      * bridge/c/CRuntimeObject.h:
      * bridge/jni/jsc/JavaRuntimeObject.cpp:
      (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
      (JSC::Bindings::JavaRuntimeObject::finishCreation):
      * bridge/jni/jsc/JavaRuntimeObject.h:
      * bridge/objc/ObjCRuntimeObject.h:
      * bridge/objc/ObjCRuntimeObject.mm:
      (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
      (JSC::Bindings::ObjCRuntimeObject::finishCreation):
      * bridge/objc/objc_runtime.h:
      (JSC::Bindings::ObjcFallbackObjectImp::create):
      * bridge/objc/objc_runtime.mm:
      (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
      * bridge/qt/qt_pixmapruntime.cpp:
      (JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
      (JSC::Bindings::QtRuntimeMethod::finishCreation):
      * bridge/qt/qt_runtime.h:
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::RuntimeArray):
      * bridge/runtime_array.h:
      (JSC::RuntimeArray::create):
      * bridge/runtime_method.cpp:
      (JSC::RuntimeMethod::RuntimeMethod):
      (JSC::RuntimeMethod::finishCreation):
      * bridge/runtime_method.h:
      * bridge/runtime_object.cpp:
      (JSC::Bindings::RuntimeObject::RuntimeObject):
      * bridge/runtime_object.h:
      (JSC::Bindings::RuntimeObject::create):
      
      Source/WebKit/mac:
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * Plugins/Hosted/ProxyRuntimeObject.h:
      * Plugins/Hosted/ProxyRuntimeObject.mm:
      (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
      (WebKit::ProxyRuntimeObject::finishCreation):
      
      Source/WebKit2:
      
      Completed the fifth level of the refactoring to add finishCreation()
      methods to all classes within the JSCell hierarchy with non-trivial
      constructor bodies.
      
      This primarily consists of pushing the calls to finishCreation() down
      into the constructors of the subclasses of the second level of the hierarchy
      as well as pulling the finishCreation() calls out into the class's corresponding
      create() method if it has one.  Doing both simultaneously allows us to
      maintain the invariant that the finishCreation() method chain is called exactly
      once during the creation of an object, since calling it any other number of
      times (0, 2, or more) will cause an assertion failure.
      
      * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
      (WebKit::JSNPMethod::JSNPMethod):
      (WebKit::JSNPMethod::finishCreation):
      * WebProcess/Plugins/Netscape/JSNPMethod.h:
      (WebKit::JSNPMethod::create):
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::JSNPObject::JSNPObject):
      * WebProcess/Plugins/Netscape/JSNPObject.h:
      (WebKit::JSNPObject::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ab29813
    • jamesr@google.com's avatar
      [chromium] Update chromium gpu baseline due to skia roll · 344e1970
      jamesr@google.com authored
      * platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      344e1970
    • macpherson@chromium.org's avatar
      Implement list style properties in CSSStyleApplyProperty. · 40587a9d
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67103
      
      Reviewed by Eric Seidel.
      
      No new tests / no behavioral changes.
      
      * css/CSSStyleApplyProperty.cpp:
      Add class to wrap call to CSSStyleSelector::styleImage().
      (WebCore::ApplyPropertyStyleImage::ApplyPropertyStyleImage):
      (WebCore::ApplyPropertyStyleImage::applyValue):
      (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
      Initialize handlers for list style properties.
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      Remove existing property implementations.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40587a9d
    • jamesr@google.com's avatar
      [chromium] Update various chromium baselines. · e55757db
      jamesr@google.com authored
      * platform/chromium-cg-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.png:
      * platform/chromium-cg-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
      * platform/chromium-mac/fast/dom/Window/window-lookup-precedence-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt.
      * platform/chromium-mac/fast/dom/wrapper-classes-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/wrapper-classes-expected.txt.
      * platform/chromium-win/svg/batik/text/textStyles-expected.png:
      * platform/chromium-win/svg/batik/text/textStyles-expected.txt:
      * platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
      * platform/chromium/fast/dom/wrapper-classes-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e55757db
    • fpizlo@apple.com's avatar
      Accessibility tests crashing in BasicRawSentinelNode code · a4749644
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67682
      
      Reviewed by Geoffrey Garen.
      
      A CodeBlock should ensure that no other CodeBlocks have references to it after
      it is destroyed.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::~CodeBlock):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4749644
    • commit-queue@webkit.org's avatar
      Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=67486 · 4f9ccebd
      commit-queue@webkit.org authored
      This reverts r65993 which gives wrong results for rshift
      in some corner cases (see the test).
      
      Patch by Yong Li <yoli@rim.com> on 2011-09-06
      Reviewed by Gavin Barraclough.
      
      New test: fast/js/floating-point-truncate-rshift.html
      
      * assembler/ARMAssembler.h:
      * assembler/MacroAssemblerARM.h:
      (JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
      (JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=67486
      Add a test case for branchTruncateDoubleToInt32() which is
      used in right shift optimization when the assembler
      "supportsFloatingPointTruncate".
      
      Patch by Yong Li <yoli@rim.com> on 2011-09-06
      Reviewed by Gavin Barraclough.
      
      * fast/js/floating-point-truncate-rshift-expected.txt: Added.
      * fast/js/floating-point-truncate-rshift.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f9ccebd
    • mrowe@apple.com's avatar
      Versioning. · 5c6cdf86
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c6cdf86
    • alexis.menard@openbossa.org's avatar
      [Qt] Move away from QPointer as it is slow and it has a replacement QWeakPointer. · 7f056151
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67673
      
      Reviewed by Ariya Hidayat.
      
      Source/WebCore:
      
      Move away from QPointer to QWeakPointer, it is faster.
      
      No new tests, the existing ones should cover.
      
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtInstance::~QtInstance):
      (JSC::Bindings::QtInstance::getClass):
      (JSC::Bindings::QtField::name):
      (JSC::Bindings::QtField::valueFromInstance):
      * bridge/qt/qt_instance.h:
      (JSC::Bindings::QtInstance::getObject):
      * bridge/qt/qt_runtime.h:
      * platform/qt/SharedTimerQt.cpp:
      (WebCore::SharedTimerQt::inst):
      
      Source/WebKit/qt:
      
      Move away from QPointer as Qt provides a better and faster solution : QWeakPointer.
      
      * Api/qwebframe.cpp:
      (QWebHitTestResult::linkTargetFrame):
      (QWebHitTestResult::frame):
      * Api/qwebframe_p.h:
      * Api/qwebpage.cpp:
      (QWebPagePrivate::QWebPagePrivate):
      (QWebPagePrivate::~QWebPagePrivate):
      (QWebPagePrivate::acceptNavigationRequest):
      (QWebPagePrivate::createMainFrame):
      (QWebPagePrivate::updateAction):
      (QWebPagePrivate::mouseMoveEvent):
      (QWebPagePrivate::mousePressEvent):
      (QWebPagePrivate::mouseDoubleClickEvent):
      (QWebPagePrivate::mouseTripleClickEvent):
      (QWebPagePrivate::mouseReleaseEvent):
      (QWebPage::createStandardContextMenu):
      (QWebPagePrivate::wheelEvent):
      (QWebPagePrivate::focusInEvent):
      (QWebPage::setPalette):
      (QWebPagePrivate::touchEvent):
      (QWebPage::~QWebPage):
      (QWebPage::mainFrame):
      (QWebPage::viewportSize):
      (QWebPage::preferredContentsSize):
      (QWebPage::setContentEditable):
      (QWebPage::updatePositionDependentActions):
      * Api/qwebpage_p.h:
      * Api/qwebview.cpp:
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::contextMenu):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::createFrame):
      * tests/qwebframe/tst_qwebframe.cpp:
      (tst_QWebFrame::ownership):
      * tests/qwebpage/tst_qwebpage.cpp:
      (PluginCounterPage::PluginCounterPage):
      (PluginTracerPage::createPlugin):
      (tst_QWebPage::createViewlessPlugin):
      * tests/qwebview/tst_qwebview.cpp:
      (tst_QWebView::reusePage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f056151
    • dpranke@chromium.org's avatar
      fix MockFileSystem.glob(), refactor filesystem tests · 694ee7a7
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67462
      
      Reviewed by Eric Seidel.
      
      In debugging why my proposed change for MockFileSystem.glob()
      in bug 66228 didn't work, I stumbled across two real bugs
      that cancelled each other out for the unit tests. I fixed those
      (glob shouldn't recurse into subdirs, and we weren't populating
      self.dirs from self.files properly).
      
      I have also created a "mixin" class for tests that can be shared
      between the real filesystem and the mock filesystem - MockFileSystem
      is being used enough it needs its own tests.
      
      * Scripts/webkitpy/common/system/filesystem_mock.py:
      * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
      * Scripts/webkitpy/common/system/filesystem_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      694ee7a7
    • oliver@apple.com's avatar
      Update expected results of bindings tests. · 954c00b6
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      954c00b6
    • fpizlo@apple.com's avatar
      Unreviewed build fix for r94559. · af478bbc
      fpizlo@apple.com authored
              
      Marked the relevant parameters as unused if !ENABLE(JIT), and surrounded
      new out-of-line JIT-specific method definitions with !ENABLE(JIT).
      
      * bytecode/CodeBlock.cpp:
      * runtime/Executable.cpp:
      (JSC::EvalExecutable::compileInternal):
      (JSC::ProgramExecutable::compileInternal):
      (JSC::FunctionExecutable::compileForCallInternal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af478bbc
    • abarth@webkit.org's avatar
      editing/selection/mixed-editability-10.html is failing on the bots · 8958327d
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67683
      
      Update editing/selection/mixed-editability-10.html baselines after
      HTMLSpanElement introduction.
      
      * editing/selection/mixed-editability-10-expected.txt:
      * platform/qt/editing/selection/mixed-editability-10-expected.png: Removed.
          - This test is no longer an image test.
      * platform/qt/editing/selection/mixed-editability-10-expected.txt:
      * platform/win/editing/selection/mixed-editability-10-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8958327d
    • eric@webkit.org's avatar
      Remove window.HTMLBlockquoteElement per HTML5 (and DOM Core 1) · dd5a3fe4
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67678
      
      Reviewed by Darin Adler.
      
      This is why we can't have nice things.
      
      There was some confusion in the original DOM HTML 1 spec about
      the existence of HTMlBlockquoteElement which was clarified by
      a later errata, removing HTMLBlockquoteElement:
      http://www.w3.org/DOM/updates/REC-DOM-Level-1-19981001-errata.html
      "This interface is an error and must be ignored. The Interface HTMLQuoteElement is used for both the Q and BLOCKQUOTE elements"
      
      Le sigh.  Personally I think having a separate HTMLBlockquoteElement
      is clearer, but thats not how the web works.  Removed it and updated test results.
      
      * CMakeLists.txt:
      * CodeGenerators.pri:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/gobject/GNUmakefile.am:
      * editing/IndentOutdentCommand.cpp:
      * html/HTMLBlockquoteElement.cpp: Removed.
      * html/HTMLBlockquoteElement.h: Removed.
      * html/HTMLBlockquoteElement.idl: Removed.
      * html/HTMLElementsAllInOne.cpp:
      * html/HTMLQuoteElement.cpp:
      (WebCore::HTMLQuoteElement::HTMLQuoteElement):
      (WebCore::HTMLQuoteElement::insertedIntoDocument):
      * html/HTMLTagNames.in:
      * page/DOMWindow.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd5a3fe4
    • rniwa@webkit.org's avatar
      Rename confirmCompositionWithoutDisturbingSelection to cancelComposition · ce2a1a3d
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67569
      
      Reviewed by Antonio Gomes.
      
      Source/WebCore: 
      
      Renamed Editor::confirmCompositionWithoutDisturbingSelection to Editor::cancelComposition.
      Also renamed the shared function from confirmComposition to setComposition.
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      (WebCore::Editor::confirmComposition):
      (WebCore::Editor::cancelComposition):
      (WebCore::Editor::setComposition):
      * editing/Editor.h:
      
      Source/WebKit/chromium: 
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::unmarkText):
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/EditorClientGtk.cpp:
      (WebKit::EditorClient::respondToChangedSelection):
      
      Source/WebKit/mac: 
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _updateSelectionForInputManager]):
      
      Source/WebKit/win: 
      
      * WebView.cpp:
      (WebView::resetIME):
      
      Source/WebKit2: 
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView resignFirstResponder]):
      (-[WKView _updateTextInputStateIncludingSecureInputState:]):
      * UIProcess/WebPageProxy.h:
      * UIProcess/mac/WebPageProxyMac.mm:
      (WebKit::WebPageProxy::cancelComposition):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::cancelComposition):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce2a1a3d
    • jamesr@google.com's avatar
      [chromium] Update expectations for a few tests that render oddly on xp due to r94589 · 4172e9cf
      jamesr@google.com authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4172e9cf
    • weinig@apple.com's avatar
      WebVTTTokenizer files in the wrong place in the Xcode project. · e37399ef
      weinig@apple.com authored
      * WebCore.xcodeproj/project.pbxproj:
      Move WebVTTTokenizer files so they are in the right place in the project.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e37399ef
    • crogers@google.com's avatar
      MediaElementAudioSourceNode destruction triggers ASSERTS · baa073da
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67665
      
      Reviewed by Nate Chapin.
      
      Source/WebCore:
      
      Test: webaudio/mediaelementaudiosourcenode-gc.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::setAudioSourceNode):
      * webaudio/AudioContext.cpp:
      (WebCore::AudioContext::uninitializeDispatch):
      (WebCore::AudioContext::stop):
      * webaudio/AudioContext.h:
      
      LayoutTests:
      
      * webaudio/mediaelementaudiosourcenode-gc-expected.txt: Added.
      * webaudio/mediaelementaudiosourcenode-gc.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baa073da
    • mrowe@apple.com's avatar
      Fix broken PPC build due to new dtoa library · ab4856c5
      mrowe@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67654
      
      Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-06
      Reviewed by Dan Bernstein.
      
      Added condition for PPC in the new dtoa compatibility check so that
      building won't fail.
      
      * wtf/dtoa/utils.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab4856c5
    • jamesr@google.com's avatar
      [chromium] Update pixel baselines for r94597 · cedf32e6
      jamesr@google.com authored
      * platform/chromium-cg-mac/fast/borders/border-image-scaled-expected.png: Added.
      * platform/chromium-cg-mac/fast/borders/border-image-side-reduction-expected.png: Added.
      * platform/chromium-cg-mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
      * platform/chromium-cg-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
      * platform/chromium-linux/fast/borders/border-image-scaled-expected.png: Added.
      * platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png:
      * platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
      * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
      * platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt.
      * platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
      * platform/chromium-win/fast/borders/border-image-longhand-expected.png: Added.
      * platform/chromium-win/fast/borders/border-image-longhand-expected.txt: Added.
      * platform/chromium-win/fast/borders/border-image-scaled-expected.png: Added.
      * platform/chromium-win/fast/borders/border-image-scaled-expected.txt: Added.
      * platform/chromium-win/fast/borders/border-image-side-reduction-expected.png: Added.
      * platform/chromium-win/fast/borders/border-image-side-reduction-expected.txt: Added.
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
      * platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
      * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cedf32e6
    • abarth@webkit.org's avatar
      [Chromium] Add WebFloatQuad.h for Android · 77afb8fe
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67573
      
      Reviewed by Darin Fisher.
      
      Android uses this wrapper of WebCore::FloatQuad in some API methods
      (which will appear in subsequent patches).
      
      * WebKit.gyp:
      * public/WebFloatQuad.h: Added.
      * src/WebFloatQuad.cpp: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77afb8fe
    • alexis.menard@openbossa.org's avatar
      [Qt] Fix API test failure after r92823 and r93001. · 425c3eb5
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67676
      
      Reviewed by Kenneth Rohde Christiansen.
      
      r92823 and r93001 make WebKit no longer produce wrapping style
      spans on copy and paste and class="Apple-style-span" anymore.
      Our expectations need to be updated.
      
      * tests/qwebpage/tst_qwebpage.cpp:
      (tst_QWebPage::cursorMovements):
      (tst_QWebPage::textSelection):
      (tst_QWebPage::findText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      425c3eb5
    • abarth@webkit.org's avatar
      [Chromium] Add didAcceptIndices to ExternalPopupMenuClient for Android · f2b42f21
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67574
      
      Reviewed by Darin Fisher.
      
      In Android, external popup menus can admit multiple selection (e.g.,
      for listboxes presented using external UI).
      
      * public/WebExternalPopupMenuClient.h:
      * src/ExternalPopupMenu.cpp:
      (WebKit::ExternalPopupMenu::didAcceptIndices):
      * src/ExternalPopupMenu.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2b42f21
    • oliver@apple.com's avatar
      An object's structure should reference the global object responsible for its creation · ee1bdc80
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67624
      
      Reviewed by Gavin Barraclough.
      
      Source/JavaScriptCore:
      
      Add a reference to a GlobalObject to Structure, and update all calls to
      Structure::create() to pass the global object that is the origin for that
      structure.  For objects where the appropriate global object isn't available
      at construction time (global object prototypes, etc), or objects that
      logically don't have a global object (strings, etc) we just pass null.
      
      This change is largely mechanical (passing a new globalObject parameter
      around).
      
      * API/JSCallbackConstructor.h:
      (JSC::JSCallbackConstructor::createStructure):
      * API/JSCallbackFunction.h:
      (JSC::JSCallbackFunction::createStructure):
      * API/JSCallbackObject.h:
      (JSC::JSCallbackObject::createStructure):
      * API/JSContextRef.cpp:
      * JavaScriptCore.exp:
      * debugger/DebuggerActivation.h:
      (JSC::DebuggerActivation::createStructure):
      * runtime/Arguments.h:
      (JSC::Arguments::createStructure):
      * runtime/ArrayConstructor.h:
      (JSC::ArrayConstructor::createStructure):
      * runtime/ArrayPrototype.h:
      (JSC::ArrayPrototype::createStructure):
      * runtime/BooleanObject.h:
      (JSC::BooleanObject::createStructure):
      * runtime/BooleanPrototype.h:
      (JSC::BooleanPrototype::createStructure):
      * runtime/DateConstructor.h:
      (JSC::DateConstructor::createStructure):
      * runtime/DateInstance.h:
      (JSC::DateInstance::createStructure):
      * runtime/DatePrototype.h:
      (JSC::DatePrototype::createStructure):
      * runtime/ErrorInstance.h:
      (JSC::ErrorInstance::createStructure):
      * runtime/ErrorPrototype.h:
      (JSC::ErrorPrototype::createStructure):
      * runtime/Executable.h:
      (JSC::ExecutableBase::createStructure):
      (JSC::NativeExecutable::createStructure):
      (JSC::EvalExecutable::createStructure):
      (JSC::ProgramExecutable::createStructure):
      (JSC::FunctionExecutable::createStructure):
      * runtime/FunctionPrototype.h:
      (JSC::FunctionPrototype::createStructure):
      * runtime/GetterSetter.h:
      (JSC::GetterSetter::createStructure):
      * runtime/InternalFunction.h:
      (JSC::InternalFunction::createStructure):
      * runtime/JSAPIValueWrapper.h:
      (JSC::JSAPIValueWrapper::createStructure):
      * runtime/JSActivation.h:
      (JSC::JSActivation::createStructure):
      * runtime/JSArray.h:
      (JSC::JSArray::createStructure):
      * runtime/JSByteArray.cpp:
      (JSC::JSByteArray::createStructure):
      * runtime/JSByteArray.h:
      * runtime/JSFunction.h:
      (JSC::JSFunction::createStructure):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::finishCreation):
      (JSC::JSGlobalObject::createStructure):
      * runtime/JSNotAnObject.h:
      (JSC::JSNotAnObject::createStructure):
      * runtime/JSONObject.h:
      (JSC::JSONObject::createStructure):
      * runtime/JSObject.cpp:
      (JSC::JSObject::createInheritorID):
      * runtime/JSObject.h:
      (JSC::JSObject::createStructure):
      (JSC::JSNonFinalObject::createStructure):
      (JSC::JSFinalObject::createStructure):
      (JSC::createEmptyObjectStructure):
      * runtime/JSObjectWithGlobalObject.h:
      (JSC::JSObjectWithGlobalObject::createStructure):
      * runtime/JSPropertyNameIterator.h:
      (JSC::JSPropertyNameIterator::createStructure):
      * runtime/JSStaticScopeObject.h:
      (JSC::JSStaticScopeObject::createStructure):
      * runtime/JSString.h:
      (JSC::RopeBuilder::createStructure):
      * runtime/JSVariableObject.h:
      (JSC::JSVariableObject::createStructure):
      * runtime/JSWrapperObject.h:
      (JSC::JSWrapperObject::createStructure):
      * runtime/MathObject.h:
      (JSC::MathObject::createStructure):
      * runtime/NativeErrorConstructor.h:
      (JSC::NativeErrorConstructor::createStructure):
      (JSC::NativeErrorConstructor::constructorBody):
      * runtime/NumberConstructor.h:
      (JSC::NumberConstructor::createStructure):
      * runtime/NumberObject.h:
      (JSC::NumberObject::createStructure):
      * runtime/NumberPrototype.h:
      (JSC::NumberPrototype::createStructure):
      * runtime/ObjectConstructor.h:
      (JSC::ObjectConstructor::createStructure):
      * runtime/ObjectPrototype.h:
      (JSC::ObjectPrototype::createStructure):
      * runtime/RegExp.h:
      (JSC::RegExp::createStructure):
      * runtime/RegExpConstructor.h:
      (JSC::RegExpConstructor::createStructure):
      * runtime/RegExpObject.h:
      (JSC::RegExpObject::createStructure):
      * runtime/RegExpPrototype.h:
      (JSC::RegExpPrototype::createStructure):
      * runtime/ScopeChain.h:
      (JSC::ScopeChainNode::createStructure):
      * runtime/StrictEvalActivation.h:
      (JSC::StrictEvalActivation::createStructure):
      * runtime/StringConstructor.h:
      (JSC::StringConstructor::createStructure):
      * runtime/StringObject.h:
      (JSC::StringObject::createStructure):
      * runtime/StringObjectThatMasqueradesAsUndefined.h:
      (JSC::StringObjectThatMasqueradesAsUndefined::create):
      (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
      * runtime/StringPrototype.h:
      (JSC::StringPrototype::createStructure):
      * runtime/Structure.cpp:
      (JSC::Structure::Structure):
      (JSC::Structure::visitChildren):
      * runtime/Structure.h:
      (JSC::Structure::create):
      (JSC::Structure::globalObject):
      (JSC::Structure::setGlobalObject):
      * runtime/StructureChain.h:
      (JSC::StructureChain::createStructure):
      
      Source/JavaScriptGlue:
      
      Update for Structure::create() requiring a global object.
      
      * JSRun.h:
      (JSGlueGlobalObject::create):
      * UserObjectImp.h:
      (UserObjectImp::createStructure):
      
      Source/WebCore:
      
      Update calls to Structure::create() to pass the globalObject in,
      and update the CodeGenerator to generate appropriate createStructure
      methods.
      
      * bindings/js/JSAudioConstructor.h:
      (WebCore::JSAudioConstructor::createStructure):
      * bindings/js/JSDOMBinding.h:
      (WebCore::DOMConstructorObject::createStructure):
      (WebCore::getDOMStructure):
      * bindings/js/JSDOMGlobalObject.h:
      (WebCore::JSDOMGlobalObject::createStructure):
      (WebCore::getDOMConstructor):
      * bindings/js/JSDOMWindowBase.h:
      (WebCore::JSDOMWindowBase::createStructure):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::setWindow):
      * bindings/js/JSDOMWindowShell.h:
      (WebCore::JSDOMWindowShell::createStructure):
      * bindings/js/JSDOMWrapper.h:
      (WebCore::JSDOMWrapper::createStructure):
      * bindings/js/JSImageConstructor.h:
      (WebCore::JSImageConstructor::createStructure):
      * bindings/js/JSImageDataCustom.cpp:
      (WebCore::toJS):
      * bindings/js/JSOptionConstructor.h:
      (WebCore::JSOptionConstructor::createStructure):
      * bindings/js/JSWorkerContextBase.h:
      (WebCore::JSWorkerContextBase::createStructure):
      * bindings/js/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::initScript):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (GenerateConstructorDeclaration):
      * bridge/c/CRuntimeObject.h:
      (JSC::Bindings::CRuntimeObject::createStructure):
      * bridge/c/c_instance.cpp:
      (JSC::Bindings::CRuntimeMethod::createStructure):
      * bridge/jni/jsc/JavaInstanceJSC.cpp:
      (JavaRuntimeMethod::createStructure):
      * bridge/jni/jsc/JavaRuntimeObject.h:
      (JSC::Bindings::JavaRuntimeObject::createStructure):
      * bridge/objc/ObjCRuntimeObject.h:
      (JSC::Bindings::ObjCRuntimeObject::createStructure):
      * bridge/objc/objc_instance.mm:
      (ObjCRuntimeMethod::createStructure):
      * bridge/objc/objc_runtime.h:
      (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
      * bridge/runtime_array.h:
      (JSC::RuntimeArray::createStructure):
      * bridge/runtime_method.h:
      (JSC::RuntimeMethod::createStructure):
      * bridge/runtime_object.h:
      (JSC::Bindings::RuntimeObject::createStructure):
      
      Source/WebKit/mac:
      
      Update for new Structure::create() globalObject parameter.
      
      * Plugins/Hosted/ProxyInstance.mm:
      (WebKit::ProxyRuntimeMethod::createStructure):
      * Plugins/Hosted/ProxyRuntimeObject.h:
      (WebKit::ProxyRuntimeObject::createStructure):
      
      Source/WebKit2:
      
      Update for new Structure::create globalObject parameter.
      
      * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
      (WebKit::JSNPMethod::create):
      * WebProcess/Plugins/Netscape/JSNPMethod.h:
      (WebKit::JSNPMethod::createStructure):
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::JSNPObject::create):
      * WebProcess/Plugins/Netscape/JSNPObject.h:
      (WebKit::JSNPObject::createStructure):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee1bdc80