1. 31 Jan, 2011 1 commit
    • kbr@google.com's avatar
      2011-01-31 Kenneth Russell <kbr@google.com> · f18f02c7
      kbr@google.com authored
              Unreviewed, test and expectations update. Stop reporting the precise
              pixel value for tests that are supposed to be within a certain range.
              Remove now-unneeded Chromium expectations.
      
              * fast/canvas/webgl/gl-teximage-expected.txt:
              * fast/canvas/webgl/gl-teximage.html:
              * platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
              * platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
              * platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f18f02c7
  2. 30 Jan, 2011 1 commit
    • kbr@google.com's avatar
      2011-01-28 Kenneth Russell <kbr@google.com> · bb1c5656
      kbr@google.com authored
              Reviewed by Chris Marrin.
      
              WebGL shows PNG Textures with indexed colors too dark
              https://bugs.webkit.org/show_bug.cgi?id=47477
      
              Added test case for upload of indexed PNG images to
              gl-teximage.html in the Khronos WebGL conformance tests.
              Synchronized this test with the Khronos repository.
      
              * fast/canvas/webgl/gl-teximage-expected.txt:
              * fast/canvas/webgl/gl-teximage.html:
              * fast/canvas/webgl/resources/red-indexed.png: Added.
      2011-01-28  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Chris Marrin.
      
              WebGL shows PNG Textures with indexed colors too dark
              https://bugs.webkit.org/show_bug.cgi?id=47477
      
              Properly handle indexed PNG images by re-rendering them as RGBA
              images before upload. Verified with this layout test and the test
              cases from bugs 47477 and 53269.
      
              * platform/graphics/cg/GraphicsContext3DCG.cpp:
              (WebCore::GraphicsContext3D::getImageData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb1c5656
  3. 18 Nov, 2010 1 commit
    • zmo@google.com's avatar
      2010-11-17 Zhenyao Mo <zmo@google.com> · e65a82f7
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
              https://bugs.webkit.org/show_bug.cgi?id=47196
      
              * platform/image-decoders/ImageDecoder.h:
              (WebCore::ImageDecoder::ignoresGammaAndColorProfile): Add a getter function for the ignoreGammaAndColorProfile setting.
              * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
              (WebCore::JPEGImageReader::decode): Hookup ignoreGammaAndColorProfile setting with color profile processing.
              * platform/image-decoders/png/PNGImageDecoder.cpp:
              (WebCore::PNGImageDecoder::headerAvailable): Ditto.
      2010-11-17  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
              https://bugs.webkit.org/show_bug.cgi?id=47196
      
              * fast/canvas/webgl/gl-teximage-expected.txt:
              * fast/canvas/webgl/gl-teximage.html: Add test cases for images with ICC profiles.
              * fast/canvas/webgl/resources/small-square-with-cie-rgb-profile.png: Added.
              * fast/canvas/webgl/resources/small-square-with-colormatch-profile.png: Added.
              * fast/canvas/webgl/resources/small-square-with-colorspin-profile.jpg: Added.
              * fast/canvas/webgl/resources/small-square-with-colorspin-profile.png: Added.
              * fast/canvas/webgl/resources/small-square-with-e-srgb-profile.png: Added.
              * fast/canvas/webgl/resources/small-square-with-smpte-c-profile.png: Added.
              * fast/canvas/webgl/resources/small-square-with-srgb-iec61966-2.1-profile.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e65a82f7
  4. 16 Nov, 2010 1 commit
    • zmo@google.com's avatar
      2010-11-11 Zhenyao Mo <zmo@google.com> · ac07f23e
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
              https://bugs.webkit.org/show_bug.cgi?id=47196
      
              * src/WebImageDecoder.cpp:
              (WebKit::WebImageDecoder::init): Add ignoreGammaAndColorProfile parameter.
      2010-11-11  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
              https://bugs.webkit.org/show_bug.cgi?id=47196
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::texImage2DImpl): Apply UNPACK_COLORSPACE_CONVERSION settings to image uploading.
              (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
              * platform/graphics/GraphicsContext3D.cpp:
              (WebCore::GraphicsContext3D::extractImageData): Ditto.
              * platform/graphics/GraphicsContext3D.h:
              * platform/graphics/ImageSource.cpp:
              (WebCore::ImageSource::ImageSource): Add ignoreGammaColorProfile parameter.
              (WebCore::ImageSource::setData): Ditto.
              * platform/graphics/ImageSource.h:
              * platform/graphics/cg/GraphicsContext3DCG.cpp:
              (WebCore::GraphicsContext3D::getImageData): Ditto.
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::ImageSource): Ditto.
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::getImageData): Ditto.
              * platform/graphics/qt/ImageDecoderQt.cpp:
              (WebCore::ImageDecoder::create): Ditto.
              (WebCore::ImageDecoderQt::ImageDecoderQt): Ditto.
              * platform/graphics/qt/ImageDecoderQt.h:
              * platform/graphics/skia/GraphicsContext3DSkia.cpp:
              (WebCore::GraphicsContext3D::getImageData): Ditto.
              * platform/image-decoders/ImageDecoder.cpp:
              (WebCore::ImageDecoder::create): Ditto.
              * platform/image-decoders/ImageDecoder.h:
              (WebCore::ImageDecoder::ImageDecoder): Ditto.
              * platform/image-decoders/bmp/BMPImageDecoder.cpp:
              (WebCore::BMPImageDecoder::BMPImageDecoder):
              * platform/image-decoders/bmp/BMPImageDecoder.h:
              * platform/image-decoders/gif/GIFImageDecoder.cpp:
              (WebCore::GIFImageDecoder::GIFImageDecoder): Ditto.
              * platform/image-decoders/gif/GIFImageDecoder.h:
              * platform/image-decoders/ico/ICOImageDecoder.cpp:
              (WebCore::ICOImageDecoder::ICOImageDecoder): Ditto.
              (WebCore::ICOImageDecoder::decodeAtIndex): Ditto.
              * platform/image-decoders/ico/ICOImageDecoder.h:
              * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
              (WebCore::JPEGImageDecoder::JPEGImageDecoder): Ditto.
              * platform/image-decoders/jpeg/JPEGImageDecoder.h:
              * platform/image-decoders/png/PNGImageDecoder.cpp:
              (WebCore::PNGImageDecoder::PNGImageDecoder): Ditto.
              (WebCore::PNGImageDecoder::headerAvailable): Ignore gamma settings if ignoreGammaAndColorProfile is true.
              * platform/image-decoders/png/PNGImageDecoder.h:
              * platform/image-decoders/webp/WEBPImageDecoder.cpp:
              (WebCore::WEBPImageDecoder::WEBPImageDecoder): Add ignoreGammaAndColorProfile parameter.
              * platform/image-decoders/webp/WEBPImageDecoder.h:
      2010-11-11  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
              https://bugs.webkit.org/show_bug.cgi?id=47196
      
              * fast/canvas/webgl/gl-teximage-expected.txt:
              * fast/canvas/webgl/gl-teximage.html: Testing that if UNPACK_COLORSPACE_CONVERSION is NONE, gamma settings are not applied to images.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac07f23e
  5. 01 Oct, 2010 1 commit
    • zmo@google.com's avatar
      2010-09-30 Zhenyao Mo <zmo@google.com> · 3ca86b79
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              texImage2D fails on 16-bit-per-channel images
              https://bugs.webkit.org/show_bug.cgi?id=46947
      
              * platform/graphics/GraphicsContext3D.cpp: Handling 16-bit-per-channel source formats.
              (WebCore::convertColor16To8):
              (WebCore::doPacking):
              * platform/graphics/GraphicsContext3D.h: Ditto.
              * platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto.
              (WebCore::GraphicsContext3D::getImageData):
      2010-09-30  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              texImage2D fails on 16-bit-per-channel images
              https://bugs.webkit.org/show_bug.cgi?id=46947
      
              * fast/canvas/webgl/gl-teximage-expected.txt: Add a test case for loading 16-bit-per-channel images as textures.
              * fast/canvas/webgl/gl-teximage.html: Ditto.
              * fast/canvas/webgl/resources/green-2x2-16bit.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ca86b79
  6. 07 Sep, 2010 1 commit
  7. 27 Aug, 2010 1 commit
  8. 25 Aug, 2010 1 commit
    • zmo@google.com's avatar
      2010-08-24 Zhenyao Mo <zmo@google.com> · cf7ab461
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
              https://bugs.webkit.org/show_bug.cgi?id=38282
      
              * src/WebImageDecoder.cpp:
              (WebKit::WebImageDecoder::init): Add premultiplyAlpha flag.
      2010-08-24  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
              https://bugs.webkit.org/show_bug.cgi?id=38282
      
              Test: fast/canvas/webgl/gl-teximage.html
      
              * platform/graphics/GraphicsContext3D.cpp: Fix a bug where alpha channel is ignored.
              * platform/graphics/ImageSource.cpp: Add premultiplyAlpha flag.
              (WebCore::ImageSource::ImageSource):
              (WebCore::ImageSource::setData):
              * platform/graphics/ImageSource.h: Ditto.
              * platform/graphics/cg/ImageSourceCG.cpp: Ditto.
              (WebCore::ImageSource::ImageSource):
              * platform/graphics/qt/ImageDecoderQt.cpp: Ditto.
              (WebCore::ImageDecoder::create):
              (WebCore::ImageDecoderQt::ImageDecoderQt):
              (WebCore::ImageDecoderQt::frameCount):
              (WebCore::ImageDecoderQt::forceLoadEverything):
              * platform/graphics/qt/ImageDecoderQt.h: Ditto.
              * platform/graphics/skia/GraphicsContext3DSkia.cpp: Fix the premultiplyAlpha data loss issue in skia.
              (WebCore::GraphicsContext3D::getImageData):
              * platform/image-decoders/ImageDecoder.cpp: Add premultiplyAlpha flag.
              (WebCore::ImageDecoder::create):
              (WebCore::RGBA32Buffer::RGBA32Buffer):
              (WebCore::RGBA32Buffer::operator=):
              * platform/image-decoders/ImageDecoder.h: Ditto.
              (WebCore::RGBA32Buffer::premultiplyAlpha):
              (WebCore::RGBA32Buffer::setPremultiplyAlpha):
              (WebCore::RGBA32Buffer::setRGBA):
              (WebCore::ImageDecoder::ImageDecoder):
              * platform/image-decoders/bmp/BMPImageDecoder.cpp: Ditto.
              (WebCore::BMPImageDecoder::BMPImageDecoder):
              (WebCore::BMPImageDecoder::frameBufferAtIndex):
              * platform/image-decoders/bmp/BMPImageDecoder.h: Ditto.
              * platform/image-decoders/gif/GIFImageDecoder.cpp: Ditto.
              (WebCore::GIFImageDecoder::GIFImageDecoder):
              (WebCore::GIFImageDecoder::frameCount):
              * platform/image-decoders/gif/GIFImageDecoder.h: Ditto.
              * platform/image-decoders/ico/ICOImageDecoder.cpp: Ditto.
              (WebCore::ICOImageDecoder::ICOImageDecoder):
              (WebCore::ICOImageDecoder::frameCount):
              (WebCore::ICOImageDecoder::decodeAtIndex):
              * platform/image-decoders/ico/ICOImageDecoder.h: Ditto.
              * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto.
              (WebCore::JPEGImageDecoder::JPEGImageDecoder):
              (WebCore::JPEGImageDecoder::frameBufferAtIndex):
              * platform/image-decoders/jpeg/JPEGImageDecoder.h: Ditto.
              * platform/image-decoders/png/PNGImageDecoder.cpp: Ditto.
              (WebCore::PNGImageDecoder::PNGImageDecoder):
              (WebCore::PNGImageDecoder::frameBufferAtIndex):
              * platform/image-decoders/png/PNGImageDecoder.h: Ditto.
              * platform/image-decoders/skia/ImageDecoderSkia.cpp: Ditto.
              (WebCore::RGBA32Buffer::RGBA32Buffer):
              (WebCore::RGBA32Buffer::operator=):
      2010-08-24  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
              https://bugs.webkit.org/show_bug.cgi?id=38282
      
              * fast/canvas/webgl/gl-teximage-expected.txt: Added.
              * fast/canvas/webgl/gl-teximage.html: Added.
              * fast/canvas/webgl/resources/3x3.png: Added.
              * fast/canvas/webgl/resources/gray-ramp-256-with-128-alpha.png: Added.
              * fast/canvas/webgl/resources/gray-ramp-256.png: Added.
              * fast/canvas/webgl/resources/gray-ramp-default-gamma.png: Added.
              * fast/canvas/webgl/resources/gray-ramp-gamma0.1.png: Added.
              * fast/canvas/webgl/resources/gray-ramp-gamma1.0.png: Added.
              * fast/canvas/webgl/resources/gray-ramp-gamma2.0.png: Added.
              * fast/canvas/webgl/resources/gray-ramp-gamma4.0.png: Added.
              * fast/canvas/webgl/resources/gray-ramp-gamma9.0.png: Added.
              * fast/canvas/webgl/resources/gray-ramp.png: Added.
              * fast/canvas/webgl/resources/webgl-test-utils.js: Sync with khronos.
              (WebGLTestUtils):
              * fast/canvas/webgl/resources/zero-alpha.png: Added.
              * platform/chromium/test_expectations.txt: Don't run gl-teximage.html for mac.
              * platform/mac/Skipped: Don't run gl-teximage.html for mac.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf7ab461