1. 31 Jan, 2011 6 commits
    • kbr@google.com's avatar
      2011-01-31 Kenneth Russell <kbr@google.com> · f18f02c7
      kbr@google.com authored
              Unreviewed, test and expectations update. Stop reporting the precise
              pixel value for tests that are supposed to be within a certain range.
              Remove now-unneeded Chromium expectations.
      
              * fast/canvas/webgl/gl-teximage-expected.txt:
              * fast/canvas/webgl/gl-teximage.html:
              * platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
              * platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
              * platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f18f02c7
    • yurys@chromium.org's avatar
      2011-01-31 Yury Semikhatsky <yurys@chromium.org> · 2f9af086
      yurys@chromium.org authored
              Unreviewed. Update Chromium test expectations.
      
              * platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
              * platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
              * platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
              * platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
              * platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
              * platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
              * platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
              * platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
              * platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png: Added.
              * platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum:
              * platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
              * platform/chromium-mac/fast/repaint/box-shadow-v-expected.checksum: Added.
              * platform/chromium-mac/fast/repaint/box-shadow-v-expected.png: Added.
              * platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.checksum: Added.
              * platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.png: Added.
              * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
              * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
              * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
              * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
              * platform/chromium-mac/fast/transforms/shadows-expected.checksum: Added.
              * platform/chromium-mac/fast/transforms/shadows-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f9af086
    • kov@webkit.org's avatar
      2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 9a7cede6
      kov@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
              https://bugs.webkit.org/show_bug.cgi?id=53379
      
              Remove left over mentions of HAVE_SOUP_2_29_90, and apply the
              dependency on newer soup to efl as well.
      
              * Source/cmake/OptionsEfl.cmake:
      2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
      
              Reviewed by Xan Lopez.
      
              [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
              https://bugs.webkit.org/show_bug.cgi?id=53379
      
              Unskip tests that pass again.
      
              * platform/gtk/Skipped:
      2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
      
              Reviewed by Xan Lopez.
      
              [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
              https://bugs.webkit.org/show_bug.cgi?id=53379
      
              Remove left over #ifdef's. I thought all of the conditional code
              had been freed from the condition, but I forgot to check DRT.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setAlwaysAcceptCookies):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a7cede6
    • yurys@chromium.org's avatar
      2011-01-31 Yury Semikhatsky <yurys@chromium.org> · 5c343d18
      yurys@chromium.org authored
              Unreviewed. Update Chromium test expectations after r77108
      
              * platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Added.
              * platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Added.
              * platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c343d18
    • yurys@chromium.org's avatar
      2011-01-31 Yury Semikhatsky <yurys@chromium.org> · 19208d59
      yurys@chromium.org authored
              Unreviewed. Update Chromium test expectations after r77101
      
              * platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
              * platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png: Added.
              * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
              * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
              * platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum: Added.
              * platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png: Added.
              * platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.txt: Added.
              * platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
              * platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png: Added.
              * platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.txt: Added.
              * platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum: Added.
              * platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
              * platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
              * platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
              * platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
              * platform/chromium-win/fast/repaint/gradients-em-stops-repaint-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19208d59
    • tkent@chromium.org's avatar
      2011-01-30 Kenichi Ishibashi <bashi@google.com> · fc192901
      tkent@chromium.org authored
              Reviewed by Kent Tamura.
      
              Dangling form associated elements should not be registered on the document
              https://bugs.webkit.org/show_bug.cgi?id=53223
      
              Adds insertedIntoDocument() and remvoedFromDocument() to
              FormAssociatedElement class to register the element on the document
              if and only if it actually inserted into (removed from) the document.
      
              Test: fast/forms/dangling-form-element-crash.html
      
              * html/FormAssociatedElement.cpp:
              (WebCore::FormAssociatedElement::insertedIntoDocument): Added.
              (WebCore::FormAssociatedElement::removedFromDocument): Ditto.
              (WebCore::FormAssociatedElement::insertedIntoTree): Don't register
              the element to a document.
              (WebCore::FormAssociatedElement::removedFromTree): Don't unregister
              the element from a document.
              * html/FormAssociatedElement.h:
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::insertedIntoDocument): Added.
              (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
              * html/HTMLFormControlElement.h:
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::insertedIntoDocument): Calls
              FormAssociatedElement::insertedIntoDocument().
              (WebCore::HTMLObjectElement::removedFromDocument): Calls
              FormAssociatedElement::removedFromDocument().
      
      2011-01-30  Kenichi Ishibashi  <bashi@google.com>
      
              Reviewed by Kent Tamura.
      
              Dangling form associated elements should not be registered on the document
              https://bugs.webkit.org/show_bug.cgi?id=53223
      
              Adds a test that ensures dangling form associated elements are not
              registered on the document.
      
              * fast/forms/dangling-form-element-crash-expected.txt: Added.
              * fast/forms/dangling-form-element-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc192901
  2. 30 Jan, 2011 5 commits
    • simon.fraser@apple.com's avatar
      2011-01-30 Simon Fraser <simon.fraser@apple.com> · 36a7cc24
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              Enhance ShadowBlur to render inset box shadows
              https://bugs.webkit.org/show_bug.cgi?id=51567
      
              Use ShadowBlur for inset box-shadows with CG. It
              currently lacks a tiled version, but is still much
              faster than CG shadows.
      
              Test: fast/box-shadow/inset-box-shadow-radius.html
      
              * platform/graphics/ShadowBlur.cpp:
              * platform/graphics/ShadowBlur.h: New method for inset
              shadows.
              (WebCore::ShadowBlur::drawInsetShadow):
      
              * platform/graphics/GraphicsContext.cpp: #ifdef out
              fillRectWithRoundedHole() for CG.
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillRectWithRoundedHole): If there's
              a shadow with a radius > 0, use ShadowBlur.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36a7cc24
    • kbr@google.com's avatar
      2011-01-28 Kenneth Russell <kbr@google.com> · bb1c5656
      kbr@google.com authored
              Reviewed by Chris Marrin.
      
              WebGL shows PNG Textures with indexed colors too dark
              https://bugs.webkit.org/show_bug.cgi?id=47477
      
              Added test case for upload of indexed PNG images to
              gl-teximage.html in the Khronos WebGL conformance tests.
              Synchronized this test with the Khronos repository.
      
              * fast/canvas/webgl/gl-teximage-expected.txt:
              * fast/canvas/webgl/gl-teximage.html:
              * fast/canvas/webgl/resources/red-indexed.png: Added.
      2011-01-28  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Chris Marrin.
      
              WebGL shows PNG Textures with indexed colors too dark
              https://bugs.webkit.org/show_bug.cgi?id=47477
      
              Properly handle indexed PNG images by re-rendering them as RGBA
              images before upload. Verified with this layout test and the test
              cases from bugs 47477 and 53269.
      
              * platform/graphics/cg/GraphicsContext3DCG.cpp:
              (WebCore::GraphicsContext3D::getImageData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb1c5656
    • morrita@google.com's avatar
      2011-01-23 MORITA Hajime <morrita@google.com> · 2d33a85b
      morrita@google.com authored
              Reviewed by Eric Seidel.
      
              REGRESSION: Inset shadow with too large border radius misses rounded corner.
              https://bugs.webkit.org/show_bug.cgi?id=52800
      
              * fast/box-shadow/inset-with-extraordinary-radii-and-border.html: Added.
              * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
              * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
              * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.
      2011-01-23  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Eric Seidel.
      
              REGRESSION: Inset shadow with too large border radius misses rounded corner.
              https://bugs.webkit.org/show_bug.cgi?id=52800
      
              The refactoring on r76083 broke the invariant between border
              IntRect and its radii because RoundedIntRect::setRect() is called
              after getRoundedInnerBorderWithBorderWidths(), which enforces the
              invariant. Th rounded-rect clipping code verifies the invariant,
              and discard the invalid radii, that results broken paintings.
      
              This change moved setRect() before
              getRoundedInnerBorderWithBorderWidths() not to modify the valid
              RoundedIntRect value.
      
              Test: fast/box-shadow/inset-with-extraordinary-radii-and-border.html
      
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintBoxShadow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d33a85b
    • simon.fraser@apple.com's avatar
      2011-01-30 Simon Fraser <simon.fraser@apple.com> · 9d92cc2a
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              -webkit-box-shadow causes awful scroll/resize/redraw performance
              https://bugs.webkit.org/show_bug.cgi?id=22102
      
              Use ShadowBlur for CG, whe rendering shadows on rects and
              rounded rects outside of canvas.
      
              CG shadows with a radius of more than 8px do not render
              correctly. We preserve this incorrect rendering by compensating
              for it when rending -webkit-box-shadow. Calls that should use
              this deprecated radius behavior now use setLegacyShadow().
      
              Test: fast/box-shadow/box-shadow-transformed.html
      
              * html/canvas/CanvasRenderingContext2D.cpp: Use setLegacyShadow()
              for canvas, to indicate that it should use the deprecated radius
              behavior.
              (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Ditto.
              (WebCore::CanvasRenderingContext2D::setShadow): Ditto.
              (WebCore::CanvasRenderingContext2D::applyShadow): Ditto.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::setLegacyShadow): Set the m_state.shadowsUseLegacyRadius bit.
      
              * platform/graphics/GraphicsContext.h:
              (WebCore::GraphicsContextState::GraphicsContextState): Add a
              shadowsUseLegacyRadius bit to the state.
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::radiusToLegacyRadius): Map from the actual radius to one
              that approximates CG behavior.
              (WebCore::hasBlurredShadow): Helper that returns true if we have a shadow
              with a non-zero blur radius.
              (WebCore::GraphicsContext::fillRect): Use ShadowBlur if not canvas.
              (WebCore::GraphicsContext::fillRoundedRect): Ditto.
              (WebCore::GraphicsContext::setPlatformShadow): Comment.
      
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintBoxShadow): Call setLegacyShadow()
              for -webkit-box-shadow.
      
              * platform/graphics/ShadowBlur.cpp:
              (WebCore::ShadowBlur::calculateLayerBoundingRect): Fix some pixel crack issues
              by rounding up the blur radius.
              (WebCore::ShadowBlur::drawRectShadow): Ditto
              (WebCore::ShadowBlur::drawRectShadowWithTiling): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d92cc2a
    • simon.fraser@apple.com's avatar
      2011-01-29 Simon Fraser <simon.fraser@apple.com> · 4f8c2fc9
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              CSS3 gradients with em-based stops fail to repaint when font size changes
              https://bugs.webkit.org/show_bug.cgi?id=51845
      
              Mark as uncacheable gradidients whose color stops depend on font size,
              and don't attempt to put these into CSSImageGeneratorValue's image cache.
              This means we return a new gradient each time, which is fairly cheap, and
              fixes repaint issues under changing font size.
      
              Test: fast/repaint/gradients-em-stops-repaint.html
      
              * css/CSSGradientValue.cpp:
              (WebCore::CSSGradientValue::image):
              (WebCore::CSSGradientValue::isCacheable):
              * css/CSSGradientValue.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f8c2fc9
  3. 29 Jan, 2011 9 commits
  4. 28 Jan, 2011 20 commits