1. 05 Nov, 2007 13 commits
    • mrowe@apple.com's avatar
      2007-11-05 Mark Rowe <mrowe@apple.com> · f13f4b57
      mrowe@apple.com authored
              Reviewed by Alp Toker.
      
              Add DEPENDPATH to JavaScriptCore and pcre to help qmake with dependencies.
      
              * JavaScriptCore.pri:
              * pcre/pcre.pri:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f13f4b57
    • aroben's avatar
      Add support on Windows for WEBKIT_TESTFONTS · a218c400
      aroben authored
               This environment variable lets you specify where the fonts to be used
               by DumpRenderTree reside. The Qt port is already using this, so I'm
               just following their lead.
      
               Reviewed by Darin.
      
               * DumpRenderTree/win/DumpRenderTree.cpp:
               (exePath): Refactored code out of initialize().
               (fontsPath): Returns either $WEBKIT_TESTFONTS or
               DumpRenderTree.resources.
               (initialize): Use the new fontsPath function.
               (main): Use the new exePath function.
               * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
               variable to DRT, like Qt does.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a218c400
    • aroben's avatar
      Add IWebCache::disabled · ea3c1cae
      aroben authored
               This matches the Mac WebCache class.
      
               Reviewed by Sam.
      
               * Interfaces/IWebCache.idl:
               * WebCache.cpp:
               (WebCache::disabled):
               * WebCache.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea3c1cae
    • aroben's avatar
      Add IWebInspector and a way to get one from a WebView · 547529d7
      aroben authored
       WebCore:
      
               Allow passing a base class pointer to COMPtr::copyRefTo
      
               Reviewed by Sam.
      
               * platform/win/COMPtr.h:
      
       WebKit/win:
      
               Add IWebInspector and a way to get one from a WebView
      
               This API matches the Mac one added in r27266.
      
               Reviewed by Sam.
      
               * Interfaces/IWebInspector.idl: Added.
               * Interfaces/IWebViewPrivate.idl: Added a new inspector method to
               match Mac.
               * WebInspector.cpp: Added.
               (WebInspector::createInstance):
               (WebInspector::WebInspector):
               (WebInspector::~WebInspector):
               (WebInspector::webViewClosed):
               (WebInspector::QueryInterface):
               (WebInspector::AddRef):
               (WebInspector::Release):
               (WebInspector::show):
               (WebInspector::showConsole):
               (WebInspector::showTimeline):
               (WebInspector::close):
               (WebInspector::attach):
               (WebInspector::detach):
               * WebInspector.h: Added.
               * WebKit.vcproj/Interfaces.vcproj: Added IWebInspector.idl.
               * WebKit.vcproj/WebKit.vcproj: Added WebInspector.{cpp,h}.
               * WebKit.vcproj/WebKitGUID.vcproj: Added IWebInspector_i.c.
               * WebView.cpp:
               (WebView::close): Notify the WebInspector that we're closing.
               (WebView::inspector): Added.
               * WebView.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      547529d7
    • aroben's avatar
      Cache strings that come directly from WebLocalizedString · 098e992b
      aroben authored
               Reviewed by Steve.
      
               * WebLocalizableStrings.cpp:
               (copyLocalizedStringFromBundle): This used to be WebLocalizedString,
               but is now just a static helper function.
               (findCachedStringInMap): Added static helper.
               (findCachedString): Refactored and cleaned up code from
               WebLocalizedLPCTSTR.
               (cacheString): Ditto.
               (WebLocalizedString): Rewrote to use the new helper functions.
               (WebLocalizedLPCTSTR): Changed to use the new helper functions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      098e992b
    • aroben's avatar
      Only override the default user agent string if we're actually given a custom one · 704cea3b
      aroben authored
               Reviewed by Sam.
      
               * WebView.cpp:
               (WebView::setCustomUserAgent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      704cea3b
    • mitz@apple.com's avatar
      WebCore: · 226000bb
      mitz@apple.com authored
              Reviewed by Oliver Hunt.
      
              - fix ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) when a class attribute is all-whitespace
      
              Test: fast/dom/class-all-whitespace.html
      
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::parseMappedAttribute): Check if there is any
              non-whitespace character in the class attribute.
      
      LayoutTests:
      
              Reviewed by Oliver Hunt.
      
              - test that an all-whitespace class attribute does not cause an assertion failure
      
              * fast/dom/class-all-whitespace-expected.txt: Added.
              * fast/dom/class-all-whitespace.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      226000bb
    • beidson@apple.com's avatar
      Reviewed by Sam · 2e7103f3
      beidson@apple.com authored
              Add transaction blocking to the DatabaseAuthorizer in preparation for the new version
              of the sql storage API
      
              * storage/DatabaseAuthorizer.cpp:
              (WebCore::DatabaseAuthorizer::allowTransaction):
              * storage/DatabaseAuthorizer.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e7103f3
    • mrowe@apple.com's avatar
      2007-11-05 Mark Rowe <mrowe@apple.com> · 1d369d29
      mrowe@apple.com authored
              Reviewed by Alp Toker.
      
              Have getMIMETypeForExtension return a null string when no MIME type is known
              for the extension rather than returning "text/plain".  This prevents plugin data
              being dumped into object elements when plugins are disabled.
      
              * platform/gtk/MIMETypeRegistryGtk.cpp:
              (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d369d29
    • mrowe@apple.com's avatar
      2007-11-05 Mark Rowe <mrowe@apple.com> · 044ed128
      mrowe@apple.com authored
              Rubber-stamped by Alp Toker.
      
              Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
      
              * GtkLauncher/main.cpp:
              (goToURLBarText):
              (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      044ed128
    • mrowe@apple.com's avatar
      2007-11-05 Mark Rowe <mrowe@apple.com> · 84094c00
      mrowe@apple.com authored
              Rubber-stamped by Alp Toker.
      
              Remove unused m_firstData member from FrameLoaderClientGtk.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84094c00
    • mrowe@apple.com's avatar
      2007-11-05 Mark Rowe <mrowe@apple.com> · 13752c6c
      mrowe@apple.com authored
              Reviewed by Alp Toker.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=15842
              Bug 15842: [Gtk] about:blank doesn't work
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::finishedLoading): Set the encoding on the frame loader to
              get work done that is normally done when the first bit of data is received, even in the
              case of a document with no data (like about:blank).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13752c6c
    • ap's avatar
      Reviewed by Darin. · a0a5bd67
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=15841
              fast/dom/Document/early-document-access.html crashes under GuardMalloc
      
              * fast/dom/Document/early-document-access.html: Don't check for open() timeout;
              wait for popup window to close as long as it takes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0a5bd67
  2. 04 Nov, 2007 15 commits
    • ddkilzer's avatar
      bisect-builds doesn't work with nightly build r19992 or newer on Leopard · 697486e9
      ddkilzer authored
              <http://bugs.webkit.org/show_bug.cgi?id=15830>
      
              Reviewed by Timothy.
      
              Restrict the range of nightly builds used by the bisect-builds script
              based on the version of Safari and the version of Mac OS X being used.
      
              Mac OS X 10.4: Safari 2.0: r11976 or newer
              Mac OS X 10.4: Safari 3.0: r19992 or newer
      
              Mac OS X 10.5: Safari 2.0: r19594 or newer
              Mac OS X 10.5: Safari 3.0: r25124 or newer
      
              * Scripts/bisect-builds:
              (findMacOSXVersion): Added.
              (makeNightlyList): Added argument to provide version of Mac OS X.
              Restrict range of nightly builds based on Safari and Mac OS X versions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      697486e9
    • weinig@apple.com's avatar
      Rubber-stamped by Adam Roben. · 600d0d05
      weinig@apple.com authored
              Rename SecurityOrigin::allowsAccessFrom to SecurityOrigin::canAccess to 
              clear up ambiguity.
      
              * bindings/js/kjs_window.cpp:
              (KJS::Window::isSafeScript):
              * platform/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::canAccess):
              * platform/SecurityOrigin.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      600d0d05
    • timothy@apple.com's avatar
      Land the HTML Editing Toolbar demo from WWDC 2007. · 48910aea
      timothy@apple.com authored
              * demos: Added.
              * demos/editingToolbar: Added.
              * demos/editingToolbar/FancyToolbar.css: Added.
              * demos/editingToolbar/FancyToolbar.js: Added.
              * demos/editingToolbar/FancyToolbarImages: Added.
              * demos/editingToolbar/FancyToolbarImages/button.png: Added.
              * demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Added.
              * demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Added.
              * demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Added.
              * demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Added.
              * demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Added.
              * demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Added.
              * demos/editingToolbar/FancyToolbarImages/buttonRight.png: Added.
              * demos/editingToolbar/FancyToolbarImages/camera.png: Added.
              * demos/editingToolbar/FancyToolbarImages/link.png: Added.
              * demos/editingToolbar/FancyToolbarImages/textAlign.png: Added.
              * demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Added.
              * demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Added.
              * demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Added.
              * demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Added.
              * demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Added.
              * demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Added.
              * demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Added.
              * demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Added.
              * demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Added.
              * demos/editingToolbar/content.html: Added.
              * demos/editingToolbar/images: Added.
              * demos/editingToolbar/images/safari.png: Added.
              * demos/editingToolbar/index.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48910aea
    • timothy@apple.com's avatar
      Reviewed by Adam. · 0e2e1176
      timothy@apple.com authored
              Bug 15834: There are many subtle bugs in the Styles pane of the Web Inspector
              http://bugs.webkit.org/show_bug.cgi?id=15834
      
              - Broke up DocumentPanel and added three SidebarPane sub-classes.
              - Fixed many Style pane bugs, including:
                * Poor handling of duplicate properties in the same rule. Some of this can't be
                  fixed since we can't only get the "winning" value for duplicate properties.
                  So we should only show one entry per unique property name.
                * Computed style does not show font shorthand sub-properties if 'font' was used.
                * Property priority was broken, the wrong properties were crossed out.
                * The 'border' shorthand shows null for the shorthand value.
                * Shorthands didn't show their priority (e.g. !important).
                * HSL and HTML hex colors didn't have preview swatch blocks.
                * Code refactoring, making it easier to reuse for console.log later.
      
              * page/inspector/DocumentPanel.js: Move sidebar pane code to three seperate
                classes in new files.
              * page/inspector/MetricsSidebarPane.js: Added.
              * page/inspector/Panel.js: Remove an InspectorController.log() call.
              * page/inspector/PropertiesSection.js: Add the section to the TreeOutline.
                So TreeElements can access properties on their section.
              * page/inspector/PropertiesSidebarPane.js: Added.
              * page/inspector/SidebarPane.js: Remove the explicit asignment of the
                onexpand and oncollapse to null. These were hiding prototypes.
              * page/inspector/StylesSidebarPane.js: Added.
              * page/inspector/inspector.html: Include the new script files.
              * page/inspector/treeoutline.js: If a null representedObject is passed
                in just use a empty object.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e2e1176
    • kmccullo's avatar
      Reviewed by Maciej. · d5ea3672
      kmccullo authored
              - This patch involves several changes, all of them were noticed that
              they were needed by the work being done in WebKit to get Drosera and
              WebKit working together on Windows.
              - The changes are:
              1) Added a debugger console for output messages.
              2) Drosera now listens for the WebKit server (before, the server would
              have to be running before Drosera was started.)
              3) Fixed a bug where the WebView started out as 0x0 pixels.
              4) Fixed a bug when there is no scope.
              5) Added the HTML, JS, and CSS to the project file to make them easy to
              find.
              6) Made the ServerConnection functions virtual.
      
              * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
              for the WebKit server.
              (DebuggerClient::DebuggerClient):
              (DebuggerClient::~DebuggerClient):
              (DebuggerClient::didFinishLoadForFrame):
              (DebuggerClient::serverConnected):
              (DebuggerClient::attemptToCreateServerConnection):
              * Drosera/win/DebuggerClient.h: Ditto.
              * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
              scope.
              (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
              (DebuggerDocument::platformValueForScopeVariableNamed):
              * Drosera/win/Drosera.cpp:
              (_tWinMain): Added a console in debug for output messages.
              (Drosera::Drosera): Listen for server.
              (Drosera::initUI): The server now Initializes COM.
              (Drosera::serverConnected): Part of the listening for the server.
              (Drosera::attemptToCreateServerConnection): Ditto.
              * Drosera/win/Drosera.h: New interface for listening for the server.
              * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
              files to the VS project.
              * Drosera/win/ServerConnection.cpp: Part of listening for the server
              connection.
              (ServerConnection::ServerConnection):
              (ServerConnection::attemptToCreateServerConnection):
              * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
              methods.
              (ServerConnection::serverConnected):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5ea3672
    • weinig's avatar
      Add svn:ignore for vcproj temp files under FindSafari. · b7fc478f
      weinig authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7fc478f
    • ap's avatar
      Reviewed by Maciej. · 6cf86c6d
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=15832
              fast/dom/gc-10.html crashes when run alone
      
              Check for !done before using objects that can be already deallocated.
      
              * DumpRenderTree/mac/EditingDelegate.mm:
              (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
              (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
              (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
              (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
              (-[EditingDelegate webView:shouldDeleteDOMRange:]):
              (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
              (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
              (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
              (-[EditingDelegate webViewDidBeginEditing:]):
              (-[EditingDelegate webViewDidChange:]):
              (-[EditingDelegate webViewDidEndEditing:]):
              (-[EditingDelegate webViewDidChangeTypingStyle:]):
              (-[EditingDelegate webViewDidChangeSelection:]):
              * DumpRenderTree/mac/FrameLoadDelegate.mm:
              (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
              (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
              (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
              (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
              (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
              (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
              (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
              (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
              (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
              (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
              (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
              (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
              (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
              (-[FrameLoadDelegate webView:willCloseFrame:]):
              (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
              (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
              * DumpRenderTree/mac/ResourceLoadDelegate.mm:
              (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
              (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
              (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
              (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
              (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
              (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cf86c6d
    • ddkilzer's avatar
      Fix build when spaces appear in the WebKit source path. · 7939a078
      ddkilzer authored
              Reviewed by Mark Rowe.
      
              * bindings/scripts/IDLParser.pm: Use safer open() method which lists
              arguments individually and prevents the need to work around spaces
              in the path.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7939a078
    • ddkilzer's avatar
      CIA has changed its hostname from cia.navi.cx to cia.vc · 004b91dd
      ddkilzer authored
              <http://bugs.webkit.org/show_bug.cgi?id=15829>
      
              Reviewed by Mitz.
      
              * contact.html: Updated links to CIA.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      004b91dd
    • alp's avatar
      2007-11-04 Alp Toker <alp@atoker.com> · 3631608c
      alp authored
              Reviewed by Alexey Proskuryakov.
      
              Fix a crash when no clipboard text is available
      
              * platform/gtk/PasteboardGtk.cpp:
              (WebCore::Pasteboard::plainText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3631608c
    • mrowe@apple.com's avatar
      2007-11-04 Mark Rowe <mrowe@apple.com> · 07a352d7
      mrowe@apple.com authored
              Build fix.  Don't use Carbon.h as the prefix header as it triggers
              warnings that would otherwise be suppressed due to it being a system header.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07a352d7
    • darin@apple.com's avatar
      * hosted/sunspider.html: Tweaked formatting a bit. · 067636d1
      darin@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      067636d1
    • darin@apple.com's avatar
      Reviewed by Maciej. · af5544c6
      darin@apple.com authored
              - http://bugs.webkit.org/show_bug.cgi?id=15826
                optimize opcode loop and case insensitive ASCII compares for a 30% speedup
      
              SunSpider says it's 2.6% faster overall, 32.5% in the regular expression tests.
      
              * pcre/pcre_internal.h: Added OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
      
              * pcre/pcre_compile.c:
              (find_fixedlength): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC. Also
              added OP_NOT since there was no reason it should not be in here.
              (could_be_empty_branch): Ditto.
              (compile_branch): Streamlined all the single-character cases; there was a bit of
              duplicate code. Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC as needed.
              But in particular, compile to those opcodes when the single character match is
              ASCII.
              (find_firstassertedchar): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
      
              * pcre/pcre_exec.c: (match): Removed the "min", "minimize", and "op" fields from
              the matchframe, after I discovered that none of them needed to be saved and restored
              across recursive match calls. Also eliminated the ignored result field from the
              matchframe, since I discovered that rrc ("recursive result code") was already the
              exact same thing. Moved the handling of opcodes higher than OP_BRA into the default
              statement of the switch instead of doing them before the switch. This removes a
              branch from each iteration of the opcode interpreter, just as removal of "op"
              removed at least one store from each iteration. Last, but not least, add the
              OP_ASCII_CHAR and OP_ASCII_LETTER_NC functions. Neither can ever match a
              surrogate pair and the letter case can be handled efficiently.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af5544c6
    • darin@apple.com's avatar
    • darin@apple.com's avatar
      - fix non-Mac builds; remove some more unused PCRE stuff · 7ecf0c3c
      darin@apple.com authored
              * pcre/pcre_compile.c:
              (compile_branch): Removed branch chain and some unused ESC values.
              (compile_regex): Ditto.
              (jsRegExpCompile): Ditto.
              * pcre/pcre_exec.c:
              (match): Removed unused branch targets. Don't use macros any more.
              (jsRegExpExecute): More of the same.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update for removed files.
              * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
              * pcre/pcre.pri: Ditto.
      
              * pcre/MERGING: Removed.
              * pcre/pcre_fullinfo.c: Removed.
              * pcre/pcre_get.c: Removed.
              * pcre/pcre_internal.h:
              * pcre/ucp.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ecf0c3c
  3. 03 Nov, 2007 12 commits
    • darin@apple.com's avatar
      JavaScriptCore: · a7c3b87f
      darin@apple.com authored
              Reviewed by Maciej.
      
              - http://bugs.webkit.org/show_bug.cgi?id=15821
                remove unused PCRE features for speed
      
              A first step toward removing the PCRE features we don't use.
              This gives a 0.8% speedup on SunSpider, and a 6.5% speedup on
              the SunSpider regular expression test.
      
              Replaced the public interface with one that doesn't use the
              name PCRE. Removed code we don't need for JavaScript and various
              configurations we don't use. This is in preparation for still
              more changes in the future. We'll probably switch to C++ and
              make some even more significant changes to the regexp engine
              to get some additional speed.
      
              There's probably additional unused stuff that I haven't
              deleted yet.
      
              This does mean that our PCRE is now a fork, but I think that's
              not really a big deal.
      
              * JavaScriptCore.exp: Remove the 5 old entry points and add
              the 3 new entry points for WebCore's direct use of the regular
              expression engine.
      
              * kjs/config.h: Remove the USE(PCRE16) define. I decided to flip
              its sense and now there's a USE(POSIX_REGEX) instead, which should
              probably not be set by anyone. Maybe later we'll just get rid of it
              altogether.
      
              * kjs/regexp.h:
              * kjs/regexp.cpp:
              (KJS::RegExp::RegExp): Switch to new jsRegExp function names and
              defines. Cut down on the number of functions used.
              (KJS::RegExp::~RegExp): Ditto.
              (KJS::RegExp::match): Ditto.
      
              * pcre/dftables.c: (main): Get rid of ctype_letter and ctype_meta,
              which are unused.
      
              * pcre/pcre-config.h: Get rid of EBCIDIC, PCRE_DATA_SCOPE, const,
              size_t, HAVE_STRERROR, HAVE_MEMMOVE, HAVE_BCOPY, NEWLINE,
              POSIX_MALLOC_THRESHOLD, NO_RECURSE, SUPPORT_UCP, SUPPORT_UTF8,
              and JAVASCRIPT. These are all no longer configurable in our copy
              of the library.
      
              * pcre/pcre.h: Remove the macro-based kjs prefix hack, the PCRE
              version macros, PCRE_UTF16, the code to set up PCRE_DATA_SCOPE,
              the include of <stdlib.h>, and most of the constants and
              functions defined in this header. Changed the naming scheme to
              use a JSRegExp prefix rather than a pcre prefix. In the future,
              we'll probably change this to be a C++ header.
      
              * pcre/pcre_compile.c: Removed all unused code branches,
              including many whole functions and various byte codes.
              Kept changes outside of removal to a minimum.
              (check_escape):
              (first_significant_code):
              (find_fixedlength):
              (find_recurse):
              (could_be_empty_branch):
              (compile_branch):
              (compile_regex):
              (is_anchored):
              (is_startline):
              (find_firstassertedchar):
              (jsRegExpCompile): Renamed from pcre_compile2 and changed the
              parameters around a bit.
              (jsRegExpFree): Added.
      
              * pcre/pcre_exec.c: Removed many unused opcodes and variables.
              Also started tearing down the NO_RECURSE mechanism since it's
              now the default. In some cases there were things in the explicit
              frame that could be turned into plain old local variables and
              other small like optimizations.
              (pchars):
              (match_ref):
              (match): Changed parameters quite a bit since it's now not used
              recursively.
              (jsRegExpExecute): Renamed from pcre_exec.
      
              * pcre/pcre_internal.h: Get rid of PCRE_DEFINITION, PCRE_SPTR,
              PCRE_IMS, PCRE_ICHANGED, PCRE_NOPARTIAL, PCRE_STUDY_MAPPED,
              PUBLIC_OPTIONS, PUBLIC_EXEC_OPTIONS, PUBLIC_DFA_EXEC_OPTIONS,
              PUBLIC_STUDY_OPTIONS, MAGIC_NUMBER, 16 of the opcodes,
              _pcre_utt, _pcre_utt_size, _pcre_try_flipped, _pcre_ucp_findprop,
              and _pcre_valid_utf8. Also moved pcre_malloc and pcre_free here.
      
              * pcre/pcre_maketables.c: Changed to only compile in dftables.
              Also got rid of many of the tables that we don't use.
      
              * pcre/pcre_tables.c: Removed the unused Unicode property tables.
      
              * pcre/pcre_ucp_searchfuncs.c: Removed everything except for
              _pcre_ucp_othercase.
      
              * pcre/pcre_xclass.c: (_pcre_xclass): Removed uneeded support
              for classes based on Unicode properties.
      
              * wtf/FastMallocPCRE.cpp: Removed unused bits. It would be good
              to eliminate this completely, but we need the regular expression
              code to be C++ first.
      
              * pcre/pcre_fullinfo.c:
              * pcre/pcre_get.c:
              * pcre/ucp.h:
              Files that are no longer needed. I didn't remove them with this
              check-in, because I didn't want to modify all the project files.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - WebCore part of http://bugs.webkit.org/show_bug.cgi?id=15821
                remove unused PCRE features for speed
      
              * page/Frame.cpp: (WebCore::Frame::matchLabelsAgainstElement):
              * page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement):
              Remove use of "[[:digit:]]" syntax. This hasn't worked for some time.
              Use "\d" instead.
      
              * platform/RegularExpression.h: Remove the unused cap function. We can
              add it back later if we find we need it.
              * platform/RegularExpression.cpp:
              (WebCore::RegularExpression::Private::compile): Update for JavaScriptCore
              regular expression entry point changes.
              (WebCore::RegularExpression::Private::~Private): Ditto.
              (WebCore::RegularExpression::match): Remove the code to set PCRE_NOTBOL.
              This means that regular expressions with metacharactesr like ^ in them
              won't work any more with non-whole-string searches, but we don't use
              any regular expressions like that.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7c3b87f
    • kevino's avatar
      Update the link stubs to match the current build, and fix coding style issues. · c1df7e02
      kevino authored
      Reviewed by Mark Rowe.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1df7e02
    • weinig@apple.com's avatar
      Build-fix. · 3082dc92
      weinig@apple.com authored
              * UserObjectImp.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3082dc92
    • mjs's avatar
      Reviewed by Sam. · bf8872b6
      mjs authored
              
              - remove NaN check from JSImmediate::fromDouble for 0.5% SunSpider speedup
      
              It turns out that doing this check costs more than it saves.
              
              * kjs/JSImmediate.h:
              (KJS::JSImmediate::fromDouble):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf8872b6
    • kevino's avatar
      wx <-> WebKit conversions for IntPoint, IntRect and FloatRect · 6ab70b36
      kevino authored
      Reviewed by Mark Rowe.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ab70b36
    • kevino's avatar
      wx <-> WebKit data type conversions for Pen and Color. · eb4e48cc
      kevino authored
      Reviewed by Darin Adler.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb4e48cc
    • weinig@apple.com's avatar
      JavaScriptCore: · a845d282
      weinig@apple.com authored
              Reviewed by Oliver.
      
              Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
              The variable had been kept around for binary compatibility, but since nothing
              else is there is no point in continuing to keep it around.
      
              * API/JSCallbackConstructor.cpp:
              (KJS::):
              * API/JSCallbackFunction.cpp:
              (KJS::):
              * API/JSCallbackObject.cpp:
              (KJS::):
              * bindings/objc/objc_runtime.mm:
              * bindings/runtime_array.cpp:
              * bindings/runtime_object.cpp:
              * kjs/array_instance.cpp:
              (KJS::):
              * kjs/array_object.cpp:
              (KJS::):
              * kjs/bool_object.cpp:
              * kjs/date_object.cpp:
              (KJS::):
              * kjs/error_object.cpp:
              * kjs/function.cpp:
              (KJS::):
              * kjs/internal.cpp:
              (KJS::):
              * kjs/lookup.h:
              * kjs/math_object.cpp:
              * kjs/number_object.cpp:
              * kjs/object.h:
              * kjs/regexp_object.cpp:
              * kjs/string_object.cpp:
              (KJS::):
      
      WebCore:
      
              Reviewed by Oliver.
      
              Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
              The variable had been kept around for binary compatibility, but since nothing
              else is there is no point in continuing to keep it around.
      
              * bindings/js/JSDOMExceptionConstructor.cpp:
              (WebCore::):
              * bindings/js/JSHTMLInputElementBase.cpp:
              (WebCore::):
              * bindings/js/JSNamedNodesCollection.cpp:
              (WebCore::):
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::):
              * bindings/js/JSXSLTProcessor.cpp:
              (KJS::):
              * bindings/js/kjs_css.cpp:
              (WebCore::):
              * bindings/js/kjs_events.cpp:
              (WebCore::):
              * bindings/js/kjs_navigator.cpp:
              (KJS::):
              * bindings/js/kjs_window.cpp:
              (KJS::):
              * bindings/scripts/CodeGeneratorJS.pm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a845d282
    • kmccullo's avatar
      - Updated testkjs results to make the build bots green until we · 92087888
      kmccullo authored
              can fix the tests that are failing.  The new failures are in DST.
      
              * tests/mozilla/expected.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92087888
    • mjs's avatar
      Reviewed by Darin. · 13dff998
      mjs authored
              - Add compare mode and a description of the benchmark to the hosted version.
      
              * hosted/sunspider-results.html: Add compare mode - you can just paste in another results URL.
              * hosted/sunspider.html: Added intro text.
              * make-hosted: Copy new file.
              * resources/sunspider-compare-results.js: Made more reusable by putting the implementation in
              a function.
              * resources/sunspider-standalone-compare.js: Added. Calls the function in the way standalone mode
              expects.
              * sunspider-compare-results: Use sunspider-standalone-compare.js.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13dff998
    • mjs's avatar
      Reviewed by Adam. · c3c01525
      mjs authored
              
              - don't print the var twice for ForInNodes with a var declaration
      
              * kjs/nodes2string.cpp:
              (KJS::ForInNode::streamTo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3c01525
    • mjs's avatar
      Rubber stamped by Adam. · 36e42b45
      mjs authored
              
              - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36e42b45
    • darin@apple.com's avatar
      * pcre/pcre_compile.c: (check_escape): Windows build fix. Get rid of · fd93acd9
      darin@apple.com authored
              C-incompatible declaration.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd93acd9