1. 28 Mar, 2013 40 commits
    • zandobersek@gmail.com's avatar
      [GTK] Build GTK-specific, non-layer-violating source code into... · f12ef742
      zandobersek@gmail.com authored
      [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
      https://bugs.webkit.org/show_bug.cgi?id=112546
      
      Reviewed by Martin Robinson.
      
      .: 
      
      * GNUmakefile.am: Define the new platform_webcore_cppflags.
      
      Source/Platform: 
      
      * GNUmakefile.am: Only specify the very minimal set of inclusion directories, containing the Source/WebCore/platform
      directory and its subdirectories. This will allow only for the WebCore-independent GTK-specific sources to be built into
      libPlatformGtk.la. Also include the GTK, libsecret and libsoup dependencies' cflags amongst the libPlatformGtk's
      CPPFLAGS.
      * GNUmakefile.list.am: Removed. The build targets are now listed (and will be listed until the migration) in the
      GNUmakefile.list.am under Source/WebCore, following the common sense of specifying the build target in the
      GNUmakefile.list.am placed in the same framework directory in which the source file is located.
      
      Source/WebCore: 
      
      No new tests - no new functionality.
      
      * GNUmakefile.am: Passing the DATA_DIR value through the cppflags is not required anymore as the affected source is now
      built into libPlatformGtk.la.
      * GNUmakefile.list.am: Build the GTK-specific source files that are already independent of WebCore into the
      libPlatformGtk.la by assigning the build targets listing to the platformgtk_sources variable.
      * platform/gtk/GtkVersioning.c: Renamed from Source/Platform/gtk/GtkVersioning.c.
      * platform/gtk/GtkVersioning.h: Renamed from Source/Platform/gtk/GtkVersioning.h.
      
      Source/WebKit/gtk: 
      
      * GNUmakefile.am: The GtkVersioning.c file has moved back under Source/WebCore/platform.
      
      Source/WebKit2: 
      
      * GNUmakefile.am: Reference the platform_webcore_cppflags and GTK, libsecret and libsoup dependencies' cflags amongst the
      libPlatformGtk2's CPPFLAGS.
      * Scripts/generate-forwarding-headers.pl: Remove the Platform framework from the list of the frameworks to be searched
      for forwarding headers, it's at the moment not necessary to be included.
      * Shared/gtk/ArgumentCodersGtk.cpp: Adjust the forwarding header for GtkVersioning.h that's been moved back under the
      WebCore framework.
      * Shared/gtk/WebEventFactory.cpp: Ditto.
      * UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
      * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Ditto.
      
      Tools: 
      
      * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
      moved back to Source/WebCore/platform. Fix an indentation issue as well.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f12ef742
    • commit-queue@webkit.org's avatar
      [BlackBerry] Don't use WebKit thread scale information in WebPageCompositor. · d503b051
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113447
      Internal PR 313452
      
      Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-03-28
      Reviewed by Rob Buis.
      
      Potential threading problems are avoided by moving from
      WebPage members and mapToTransformed() to the web page
      client's userInterfaceViewportAccessor().
      
      As part of this cleaning effort, the WebPageCompositor's
      render() method is changed to now take document instead of
      pixel coordinates.
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::compositeContents):
      * Api/WebPageCompositor.cpp:
      (BlackBerry::WebKit::WebPageCompositorPrivate::render):
      (BlackBerry::WebKit::WebPageCompositor::render):
      * Api/WebPageCompositor.h:
      * Api/WebPageCompositor_p.h:
      (WebPageCompositorPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d503b051
    • falken@chromium.org's avatar
      Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl · 2113254c
      falken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113273
      
      Reviewed by Kent Tamura.
      
      Element::disabled is about form controls and Element::isEnabledFormControl
      is redundant with it, so replace them with a single function
      Element::isDisabledFormControl.
      
      Source/WebCore:
      
      No new tests, there should be no behavior change.
      
      * accessibility/AccessibilityListBox.cpp:
      (WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::canSetFocusAttribute):
      * accessibility/AccessibilityMenuListOption.cpp:
      (WebCore::AccessibilityMenuListOption::isEnabled):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::isEnabled):
      (WebCore::AccessibilityNodeObject::actionElement):
      (WebCore::AccessibilityNodeObject::canSetFocusAttribute):
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::canShareStyleWithControl):
      * dom/Element.cpp:
      (WebCore::Element::isDisabledFormControl):
      * dom/Element.h:
      (Element):
      (WebCore::isDisabledFormControl): Add helper function for convenience.
      (WebCore):
      * dom/EventDispatcher.cpp:
      (WebCore::EventDispatcher::dispatchSimulatedClick):
      * dom/GestureEvent.cpp:
      (WebCore::GestureEventDispatchMediator::dispatchEvent):
      * dom/MouseEvent.cpp:
      (WebCore::MouseEventDispatchMediator::dispatchEvent):
      * dom/Node.cpp:
      (WebCore::Node::handleLocalEvents):
      (WebCore::Node::willRespondToMouseMoveEvents):
      (WebCore::Node::willRespondToMouseClickEvents):
      (WebCore::Node::willRespondToTouchEvents):
      * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
      (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
      * html/DOMFormData.cpp:
      (WebCore::DOMFormData::DOMFormData):
      * html/FileInputType.cpp:
      (WebCore::FileInputType::handleDOMActivateEvent):
      (WebCore::FileInputType::disabledAttributeChanged):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::defaultEventHandler):
      (WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
      (WebCore::HTMLButtonElement::isSuccessfulSubmitButton):
      * html/HTMLCollection.cpp:
      (WebCore::isMatchingElement):
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::updateAncestorDisabledState):
      (WebCore::HTMLFormControlElement::isDisabledFormControl):
      (WebCore::HTMLFormControlElement::supportsFocus):
      * html/HTMLFormControlElement.h:
      (HTMLFormControlElement):
      (WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::isSuccessfulSubmitButton):
      (WebCore::HTMLInputElement::willRespondToMouseClickEvents):
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::isDisabledFormControl):
      * html/HTMLOptGroupElement.h:
      (HTMLOptGroupElement):
      * html/HTMLOptionElement.cpp:
      (WebCore::HTMLOptionElement::isDisabledFormControl):
      * html/HTMLOptionElement.h:
      (HTMLOptionElement):
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::nextValidIndex):
      (WebCore::HTMLSelectElement::updateListBoxSelection):
      (WebCore::HTMLSelectElement::recalcListItems):
      (WebCore::HTMLSelectElement::appendFormData):
      (WebCore::HTMLSelectElement::updateSelectedState):
      (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
      (WebCore::HTMLSelectElement::defaultEventHandler):
      (WebCore::HTMLSelectElement::optionAtIndex):
      * html/ImageInputType.cpp:
      (WebCore::ImageInputType::handleDOMActivateEvent):
      * html/ResetInputType.cpp:
      (WebCore::ResetInputType::handleDOMActivateEvent):
      * html/SubmitInputType.cpp:
      (WebCore::SubmitInputType::handleDOMActivateEvent):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::isDisabledFormControl):
      (WebCore::SliderThumbElement::defaultEventHandler):
      (WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
      (WebCore::SliderThumbElement::willRespondToMouseClickEvents):
      * html/shadow/SliderThumbElement.h:
      (SliderThumbElement):
      * html/shadow/SpinButtonElement.h:
      * html/shadow/TextFieldDecorationElement.cpp:
      (WebCore::TextFieldDecorationElement::updateImage):
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create):
      * page/DragController.cpp:
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::concludeEditDrag):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::addFocusRingRects):
      (WebCore::RenderListBox::paintItemForeground):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemIsEnabled):
      * rendering/RenderTextControl.cpp:
      (WebCore::updateUserModifyProperty):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isEnabled):
      * rendering/RenderThemeMac.mm:
      (WebCore::getMediaUIPartStateFlags):
      * rendering/RenderThemeMacShared.mm:
      (WebCore::RenderThemeMacShared::adjustMenuListStyle):
      (WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):
      * rendering/RenderThemeSafari.cpp:
      (WebCore::RenderThemeSafari::adjustMenuListStyle):
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/CredentialTransformData.cpp:
      (WebCore::CredentialTransformData::findPasswordFormFields):
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::openSelectPopup):
      
      Source/WebKit/chromium:
      
      * src/WebFormControlElement.cpp:
      (WebKit::WebFormControlElement::isEnabled):
      * src/WebOptionElement.cpp:
      (WebKit::WebOptionElement::isEnabled):
      * src/WebPasswordFormUtils.cpp:
      (WebKit::findPasswordFormFields):
      * src/WebSearchableFormData.cpp:
      (HTMLNames::findSuitableSearchInputElement):
      (HTMLNames::buildSearchString):
      
      Source/WebKit/win:
      
      * DOMHTMLClasses.cpp:
      (DOMHTMLInputElement::disabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2113254c
    • beidson@apple.com's avatar
      Remove workaround for <rdar://problem/5321972>. · 690279bf
      beidson@apple.com authored
      <rdar://problem/12022862> and https://bugs.webkit.org/show_bug.cgi?id=113516
      
      Reviewed by Sam Weinig.
      
      No new tests (No point in testing the removal of bizarre behavior).
      
      * platform/network/mac/WebCoreURLResponse.mm:
      (WebCore::adjustMIMETypeIfNecessary): This workaround isn't needed on Lion+
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      690279bf
    • commit-queue@webkit.org's avatar
      use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl · 31f06f24
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113456
      
      Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      Use enum CanvasWindingRule type instead of DOMString for winding
      arguments when needed. Changed methods are: fill, stroke and isPointInPath.
      
      Test: fast/canvas/winding-enumeration.html
      
      * html/canvas/CanvasRenderingContext2D.idl:
      
      LayoutTests:
      
      When calling methods accepting a CanvasWindingRule with an invalid
      string, check that a TypeError is thrown.
      
      * fast/canvas/winding-enumeration-expected.txt: Added.
      * fast/canvas/winding-enumeration.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31f06f24
    • allan.jensen@digia.com's avatar
      Rebaseline font-face-woff after r147020 · 5c5d1d42
      allan.jensen@digia.com authored
      Unreviewed gardening.
      
      Updated using garden-o-matic.
      
      * fast/css/font-face-woff-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/font-face-woff-expected.txt.
      * platform/mac/fast/css/font-face-woff-expected.txt: Removed.
      * platform/qt/fast/css/font-face-woff-expected.png: Added.
      * platform/qt/fast/css/font-face-woff-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c5d1d42
    • mark.lam@apple.com's avatar
      Gardening: bypassing inspector/styles/paste-property.html,... · 0189624a
      mark.lam@apple.com authored
      Gardening: bypassing inspector/styles/paste-property.html, compositing/iframes/remove-iframe-crash.html.
      
      Not Reviewed.
      
      * platform/mac-wk2/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0189624a
    • commit-queue@webkit.org's avatar
      Move preprocessing of idl to pre-pass for gyp · d1c4339a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113448
      
      Patch by Scott Graham <scottmg@chromium.org> on 2013-03-28
      Reviewed by Tony Chang.
      
      Moves the preprocessor invocations when parsing IDL files to a
      pre-pass to avoid reinvocations when IDLs are referenced from others.
      This reduces the number of invocations of the preprocessor from 20071
      to 633, which reduces the runtime from 12m30 to 1m (on a Windows box).
      
      No new tests, this is a build time improvement, and shouldn't have any
      visible effect.
      
      * WebCore.gyp/WebCore.gyp:
      * bindings/scripts/CodeGenerator.pm:
      (ParseInterface):
      * bindings/scripts/IDLParser.pm:
      (Parse):
      * bindings/scripts/generate-bindings.pl:
      * bindings/scripts/generate-preprocessed-idls.pl: Added.
      * bindings/scripts/preprocessor.pm:
      (applyPreprocessor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1c4339a
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardneing. Updated png expected results after r146206. · 18716245
      kadam@inf.u-szeged.hu authored
      * platform/qt-5.0-wk2/editing/deleting/5126166-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/5206311-1-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/5369009-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/5433862-2-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-3608445-fix-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-block-contents-003-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-br-002-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-br-003-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-br-004-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-br-006-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-hr-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/delete-listitem-001-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/merge-different-styles-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/pruning-after-merge-2-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/smart-delete-003-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/smart-delete-004-expected.png: Added.
      * platform/qt-5.0-wk2/editing/deleting/type-delete-after-quote-expected.png: Added.
      * platform/qt-5.0-wk2/editing/execCommand/4580583-1-expected.png: Added.
      * platform/qt-5.0-wk2/editing/execCommand/4924441-expected.png: Added.
      * platform/qt-5.0-wk2/editing/execCommand/indent-empty-root-expected.png: Added.
      * platform/qt-5.0-wk2/editing/execCommand/insertHorizontalRule-expected.png: Added.
      * platform/qt-5.0-wk2/editing/execCommand/insertImage-expected.png: Added.
      * platform/qt-5.0-wk2/editing/execCommand/nsresponder-indent-expected.png: Added.
      * platform/qt-5.0-wk2/editing/execCommand/nsresponder-outdent-expected.png: Added.
      * platform/qt-5.0-wk2/editing/execCommand/remove-list-item-1-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/4875189-1-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/4875189-2-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/4959067-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/5418891-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/insert-3778059-fix-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/insert-3800346-fix-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/insert-div-025-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/insert-paragraph-02-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/paragraph-separator-03-expected.png: Added.
      * platform/qt-5.0-wk2/editing/inserting/redo-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/4076267-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/4242293-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/4641033-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/5032095-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/5134759-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/merge-end-borders-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/merge-start-list-expected.png: Added.
      * platform/qt-5.0-wk2/editing/pasteboard/styled-element-markup-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/13804-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/4866671-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/5076323-1-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/5099303-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/5195166-2-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/expanding-selections-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/expanding-selections2-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/extend-by-character-003-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/extend-by-character-005-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/extend-by-sentence-001-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/inline-table-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/mixed-editability-4-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/mixed-editability-5-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/mixed-editability-9-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/move-by-character-003-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/move-by-character-005-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/replace-selection-1-expected.png: Added.
      * platform/qt-5.0-wk2/editing/selection/table-caret-3-expected.png: Added.
      * platform/qt-5.0-wk2/editing/style/4916887-expected.png: Added.
      * platform/qt-5.0-wk2/editing/style/5084241-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18716245
    • commit-queue@webkit.org's avatar
      Fix layout test for blending in the background · 6be0a61c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113402
      
      Patch by Mirela Budaes <mbudaes@adobe.com> on 2013-03-28
      Reviewed by Dirk Schulze.
      
      Fixed the layout test effect-background-blend-mode.html typo
      Also rebaselined the test
      
      * css3/compositing/effect-background-blend-mode.html:
      * platform/mac/css3/compositing/effect-background-blend-mode-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6be0a61c
    • alokp@chromium.org's avatar
      RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements · c8e31f7f
      alokp@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113419
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.
      
      Test: compositing/contents-opaque/control-layer.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
      
      LayoutTests:
      
      * compositing/contents-opaque/control-layer-expected.txt: Added.
      * compositing/contents-opaque/control-layer.html: Added.
      * platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8e31f7f
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. Adding failure expectation for a reftest added in r147111 · f9d6311f
      zandobersek@gmail.com authored
      that's failing due to subpixel layout being disabled on the GTK port.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9d6311f
    • mrobinson@webkit.org's avatar
      [GTK] [gyp] Improve support for rerunning gyp automatically · ea375457
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113360
      
      Reviewed by Gustavo Noronha Silva.
      
      Add support for automatically rerunning gyp when input file changes are detected
      while running make.
      
      * gyp/GNUmakefile: Added. A wrapper that invokes the generated makefile.
      * gyp/autogen.sh: Add a symlink to the wrapper script.
      * gyp/configure.ac: "Freeze" the TOPLEVEL_DIRECTORY command-line argument so that
      run-gyp reads it properly when configure is run independently of autogen.sh.
      * gyp/run-gyp: Prevent generation of auto-regeneration rules in gyp. They are buggy.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea375457
    • commit-queue@webkit.org's avatar
      [BlackBerry] Committer Email Updates · c2d2a9a8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113435
      
      Patch by Ming Xie <mxie@blackberry.com> on 2013-03-28
      Reviewed by Rob Buis.
      
      Add the @blackberry.com email address for all our BlackBerry
      WebKit committers. This is the first step for our email address
      migration.
      
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2d2a9a8
    • commit-queue@webkit.org's avatar
      Layout Test inspector/console/console-css-warnings.html is failing on debug. · 4da11865
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113483
      
      Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-28
      Reviewed by Alexander Pavlov.
      
      This test is temporatily disabled in TestExpectations. platform/chromium/TestExpectations override this expectation for chromium/debug.
      It removed for now.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4da11865
    • philn@webkit.org's avatar
      [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild · 0e5ff136
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113508
      
      Reviewed by Martin Robinson.
      
      Prevent the GStreamer plugin scanner to load system-wide
      plugins. Only the ones built in JHBuild should be loaded and used
      at runtime.
      
      * efl/jhbuildrc:
      * gtk/jhbuildrc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e5ff136
    • commit-queue@webkit.org's avatar
      [GTK][AC] Animating layer disappears while running with clutter backend · f880b036
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110470
      
      Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-03-28
      Reviewed by Gustavo Noronha Silva.
      
      The reason of this issue is that clutter_actor_remove_child leads to stopping animations
      of child actor. ClutterActor's animation could be defined only when it has a parent actor.
      So we should avoid the case calling the api as much as we can. At least we don't
      need to reset a actor's parent at all if the current parent is same with new one.
      If we can't avoid invoking clutter_actor_remove_child for an animating actor, we may apply
      a more complicated way to keep the animation. But I haven't faced such a case yet.
      
      Covered by existing animation tests.
      
      * platform/graphics/clutter/GraphicsLayerActor.cpp:
      (graphicsLayerActorSetSublayers):
      * platform/graphics/clutter/GraphicsLayerClutter.cpp:
      (WebCore::GraphicsLayerClutter::recursiveCommitChanges):
      (WebCore::GraphicsLayerClutter::updateSublayerList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f880b036
    • wangxianzhu@chromium.org's avatar
      Non-painting fixed elements should not cause repaints on scroll · 5c934e08
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110430
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Test: compositing/repaint/scroll-fixed-layer-no-content.html
      Test: compositing/repaint/scroll-fixed-layer-out-of-view.html
      
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollContentsFastPath): Check for no-content and out-of-view flag set by RLC.
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::requiresCompositingForPosition): Moved the check for no-content above out-of-view because it's faster.
      
      LayoutTests:
      
      * compositing/repaint/scroll-fixed-layer-no-content.html: Added.
      * compositing/repaint/scroll-fixed-layer-no-content-expected.txt: Added.
      * compositing/repaint/scroll-fixed-layer-out-of-view.html: Added.
      * compositing/repaint/scroll-fixed-layer-out-of-view-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c934e08
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed gardening. · f6a5432c
      ch.dumez@sisa.samsung.com authored
      Fix bad rebaseline in r147115.
      
      * fast/forms/validationMessage-expected.txt:
      * platform/efl/fast/forms/validationMessage-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6a5432c
    • apavlov@chromium.org's avatar
      Unreviewed, revert accidentally added line committed in r147117. · 547a7cc4
      apavlov@chromium.org authored
      * inspector/front-end/ElementsTreeOutline.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      547a7cc4
    • apavlov@chromium.org's avatar
      Web Inspector: [Elements] Syntax-highlight the "Edit as HTML" editor · 537ce695
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113306
      
      Reviewed by Vsevolod Vlasov.
      
      Source/WebCore:
      
      Use CodeMirror as the raw HTML editor for the "Edit as HTML" menu item
      (and all multiline editors for WebInspector.startEditing()).
      Drive-by fix for handling the editing when the editor has been invoked on the closing tag.
      
      * inspector/front-end/ElementsTreeOutline.js:
      (WebInspector.ElementsTreeElement.prototype.commit):
      (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
      * inspector/front-end/UIUtils.js:
      (WebInspector.EditingConfig.prototype.setMultiline):
      (WebInspector.startEditing):
      (WebInspector.CodeMirrorCSSLoadView): A bogus view to load-unload CodeMirror-related CSS on demand.
      * inspector/front-end/elementsPanel.css:
      (#elements-content .CodeMirror):
      (#elements-content .CodeMirror pre):
      (#elements-content .CodeMirror-lines):
      * inspector/front-end/elementsPanel.css: CodeMirror styles for the "Edit as HTML" editor.
      * inspector/front-end/externs.js: Declare CodeMirror type with some members, as it is third-party code.
      * inspector/front-end/inspector.html: Fix script order (UIUtils.js requires View.js).
      
      LayoutTests:
      
      * inspector/elements/edit-dom-actions.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      537ce695
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL gardening. · 1b13a7b3
      ch.dumez@sisa.samsung.com authored
      Mark several tests as failing due to missing WKTR / DRT functionality.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b13a7b3
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL gardening. · c5334425
      ch.dumez@sisa.samsung.com authored
      Rebaseline fast/forms/validationMessage.html after r145024.
      
      * fast/forms/validationMessage-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5334425
    • zandobersek@gmail.com's avatar
      Unreviewed gardening of test failures after r147086 and r147090. · 318fbb35
      zandobersek@gmail.com authored
      * platform/gtk-wk1/TestExpectations:
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      318fbb35
    • morrita@google.com's avatar
      Custom Elements: should support non-HTML namespaces. · d2d3b7da
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111693
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Some existing code assumes that the element extends HTMLElements.
      This change allow it to extend from Element. Note that the
      namespace URI of a custom element is determined by given element
      prototype: An element will have XHTML namespace if its prototype
      chain includes HTMLElements, SVGElement leads SVG namespace and
      null otherwise, respectively.
      
      Test: fast/dom/custom/document-register-namespace.html
      
      * bindings/v8/CustomElementHelpers.cpp:
      (WebCore::hasValidPrototypeChainFor): Factored out from isValidPrototypeParameter()
      (WebCore::CustomElementHelpers::isValidPrototypeParameter): Extend to support non HTMLElement prototype
      (WebCore::CustomElementHelpers::findLocalName): Support non-HTML element names.
      * bindings/v8/CustomElementHelpers.h:
      (CustomElementHelpers):
      * dom/CustomElementConstructor.cpp:
      (WebCore::CustomElementConstructor::createElementInternal):
      * dom/CustomElementRegistry.cpp:
      (WebCore::CustomElementRegistry::registerElement): No longer hard-codes namespace and picks one based on the prototype value.
      * dom/CustomElementRegistry.h:
      (CustomElementRegistry):
      
      LayoutTests:
      
      * fast/dom/custom/document-register-namespace-expected.txt: Added.
      * fast/dom/custom/document-register-namespace.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2d3b7da
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL gardening. · 521e5d47
      ch.dumez@sisa.samsung.com authored
      Add platform specific expectation for http/tests/inspector/console-resource-errors.html.
      We get the same result as mac port.
      
      * platform/efl/http/tests/inspector/console-resource-errors-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      521e5d47
    • hmuller@adobe.com's avatar
      [CSS Exclusions] Add support for the simple case of padding a polygonal shape-inside · 6592248d
      hmuller@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112592
      
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      First pass at computing the padded or inset boundary of a polygon.  This version does not handle
      self-intersecting polygons, or values of shape-padding large enough to change the shape of the
      original polygon. The implementation computes an offset edge for each polgon edge, where the offset
      edge is parallel to the original edge and separated by shape-padding. The padded polygon's vertices
      are the intersections of each pair of adjacent offset edges. When adjacent offset edges do not intersect,
      because they share a reflex vertex in the original polygon, an approximation to a circular arc
      connects the offset edges.
      
      Tests: fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html
             fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html
             fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html
      
      * rendering/ExclusionPolygon.cpp:
      (WebCore::isReflexVertex): Just moved this function earlier in the file.
      (WebCore::inwardEdgeNormal): Unit vector that's perpindicular to the edge and that points inwards.
      (WebCore::outwardEdgeNormal): Unit vector that's perpindicular to the edge and that points outwards.
      (WebCore::appendArc): Append a linear approximation to a circular arc to a vector of vertices.
      (WebCore::computeShapePaddingBounds): Return a polygon whose edges are all inset by shape-padding from m_polygon.
      (WebCore::computeShapeMarginBounds): Just a stub, see bug 112917.
      (WebCore::ExclusionPolygon::shapePaddingBounds): Lazily use computeShapePaddingBounds() to initialize m_paddingBounds.
      (WebCore::ExclusionPolygon::shapeMarginBounds): Lazily use computeShapeMarginBounds() to initialize m_marginBounds.
      (WebCore::ExclusionPolygon::getIncludedIntervals): Now based on the value of shapePaddingBounds().
      (WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Now based on the value of shapePaddingBounds().
      * rendering/ExclusionPolygon.h:
      (WebCore::ExclusionPolygon::ExclusionPolygon):
      
      LayoutTests:
      
      Verify that the CSS shape-padding property works correctly for some simple polygonal shapes:
      a rectangle, a rectangle rotated 45 degress, and rectangular shape with a single reflex vertex.
      
      * fast/exclusions/shape-inside/shape-inside-polygon-padding-001-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html: Added.
      * fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html: Added.
      * fast/exclusions/shape-inside/shape-inside-polygon-padding-003-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6592248d
    • commit-queue@webkit.org's avatar
      [BlackBerry] Handle EXIF orientation for ImageDocuments · f9edbe47
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113423
      
      Internal Bug: PR 293648
      Informally Reviewed by Jeff Rogers
      Patch by Chris Hutten-Czapski <chutten@blackberry.com> on 2013-03-28
      Reviewed by Rob Buis.
      
      Support image orientation in our image draw calls, and advertise
      the capability to the calling code. This allows us to respect EXIF
      orientation data.
      
      * platform/graphics/BitmapImage.h:
      * platform/graphics/blackberry/ImageBlackBerry.cpp:
      (WebCore::BitmapImage::draw):
      (WebCore):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::shouldRespectImageOrientation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9edbe47
    • caseq@chromium.org's avatar
      Web Inspector: name timeline overview controls consistently · be97945d
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113503
      
      Reviewed by Yury Semikhatsky.
      
      Refactoring, covered by existing tests.
      
      - rename HeapGraph to TimelineMemoryOverview;
      - rename TimelineCategoryStrips to TimelineEventOvrview.
      
      * inspector/front-end/TimelineOverviewPane.js:
      (WebInspector.TimelineOverviewPane):
      (WebInspector.TimelineOverviewPane.prototype.setMode):
      (WebInspector.TimelineOverviewPane.prototype._setFrameMode):
      (WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
      (WebInspector.TimelineOverviewPane.prototype._update):
      (WebInspector.TimelineOverviewPane.prototype.setMinimumRecordDuration):
      (WebInspector.TimelineMemoryOverview):
      (WebInspector.TimelineEventOverview):
      (WebInspector.TimelineEventOverview.prototype._renderBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be97945d
    • philn@webkit.org's avatar
      [GTK] run-launcher --gtk -2 fails on a WK2-only build · 06ea9f5b
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113386
      
      Reviewed by Carlos Garcia Campos.
      
      * Scripts/webkitdirs.pm:
      (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
      version to 3.0. Reflect this change so the builtDylibPathForName
      function doesn't fail to report the library as found.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06ea9f5b
    • commit-queue@webkit.org's avatar
      [BlackBerry] Correct glyph contour winding direction when fake-bolding · cdab1e55
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113411
      
      Patch by Eli Fidler <efidler@blackberry.com> on 2013-03-28
      Reviewed by Rob Buis.
      
      * platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:
      (WebCore::FontPlatformData::applyState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdab1e55
    • vsevik@chromium.org's avatar
      Web Inspector: Make JavaScriptSourceFrame work correctly with breakpoints when... · 7acef060
      vsevik@chromium.org authored
      Web Inspector: Make JavaScriptSourceFrame work correctly with breakpoints when uiSourceCode does not have a scriptFile.
      https://bugs.webkit.org/show_bug.cgi?id=113500
      
      Reviewed by Pavel Feldman.
      
      JavaScriptSourceFrame now listens for uiSourceCode working copy related events and supports muting breakpoints without script file.
      
      * inspector/front-end/JavaScriptSourceFrame.js:
      (WebInspector.JavaScriptSourceFrame):
      (WebInspector.JavaScriptSourceFrame.prototype._workingCopyChanged):
      (WebInspector.JavaScriptSourceFrame.prototype._workingCopyCommitted):
      (WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
      (WebInspector.JavaScriptSourceFrame.prototype.dispose):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7acef060
    • caseq@chromium.org's avatar
      Web Inspector: factor out node search controller from inspector.js · 60f0dce4
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112689
      
      Reviewed by Pavel Feldman.
      
      This just extracts the existing logic of toggling node search
      from inspector.js into a class of its own, InspectElementModeController.
      Drive-by: add CtrlOrMeta+Shift+C to help screen.
      
      * English.lproj/localizedStrings.js:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * inspector/compile-front-end.py:
      * inspector/front-end/InspectElementModeController.js: Added.
      (WebInspector.InspectElementModeController):
      (WebInspector.InspectElementModeController.createShortcut):
      (WebInspector.InspectElementModeController.prototype.enabled):
      (WebInspector.InspectElementModeController.prototype.disable):
      (WebInspector.InspectElementModeController.prototype.toggleSearch.callback):
      (WebInspector.InspectElementModeController.prototype.toggleSearch):
      (WebInspector.InspectElementModeController.prototype.handleShortcut):
      * inspector/front-end/InspectorFrontendAPI.js:
      (InspectorFrontendAPI.enterInspectElementMode):
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/inspector.html:
      * inspector/front-end/inspector.js:
      (WebInspector._createGlobalStatusBarItems):
      (WebInspector._registerShortcuts):
      (WebInspector.documentKeyDown):
      (WebInspector._updateFocusedNode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60f0dce4
    • eustas@chromium.org's avatar
      Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota. · a86fc7bb
      eustas@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113375
      
      Reviewed by Pavel Feldman.
      
      Serialized "previouslyViewedFiles" may make local storage overflow.
      Two fixed applied:
      - limit number of history log items
      - limit length of URIs that get serialized;
        this would affect only data-url URIs.
      
      * inspector/front-end/TabbedEditorContainer.js:
      (WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
      Added length check.
      (WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
      Added output array length limit.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a86fc7bb
    • commit-queue@webkit.org's avatar
      Web Inspector: Heap snapshots retained size falls out of the grid if column is too narrow · abae6bc5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113497
      
      Patch by Alexei Filippov <alph@chromium.org> on 2013-03-28
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/HeapSnapshotGridNodes.js:
      (WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
      * inspector/front-end/heapProfiler.css:
      (.heap-snapshot-view .data-grid div.heap-snapshot-multiple-values):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abae6bc5
    • vsevik@chromium.org's avatar
      Web Inspector: ResourceScriptFile should check if resource content really... · fdcdf1db
      vsevik@chromium.org authored
      Web Inspector: ResourceScriptFile should check if resource content really matches VM script when determining hasDiverged state.
      https://bugs.webkit.org/show_bug.cgi?id=113488
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Enabled support for checking that file content matches VM script in ResourceScriptFile (For script resources only).
      This check is never done before content is loaded in corresponding editor to avoid regressing performance.
      File - script content matching is done bearing in mind sourceURLs.
      Live edit keeps sourceURL in script content now even if it is not present in file's content.
      
      * inspector/front-end/JavaScriptSourceFrame.js:
      (WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
      (WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):
      * inspector/front-end/LiveEditSupport.js:
      (WebInspector.LiveEditScriptFile.prototype.checkMapping):
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
      (WebInspector.ScriptFile.prototype.checkMapping):
      (WebInspector.ResourceScriptFile):
      (WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
      (WebInspector.ResourceScriptFile.prototype._isDiverged):
      (WebInspector.ResourceScriptFile.prototype._sourceMatchesScriptSource):
      (WebInspector.ResourceScriptFile.prototype._sourceEndsWithSourceURL):
      (WebInspector.ResourceScriptFile.prototype.checkMapping.callback):
      (WebInspector.ResourceScriptFile.prototype.checkMapping):
      * inspector/front-end/ScriptSnippetModel.js:
      (WebInspector.SnippetScriptFile.prototype.checkMapping):
      
      LayoutTests:
      
      * http/tests/inspector/debugger-test.js:
      * inspector/debugger/file-system-project-mapping-expected.txt:
      * inspector/debugger/file-system-project-mapping.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdcdf1db
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Updated png expected results after r146206. · 7e9733e2
      kadam@inf.u-szeged.hu authored
      * platform/qt/editing/deleting/5126166-expected.png:
      * platform/qt/editing/deleting/5206311-1-expected.png:
      * platform/qt/editing/deleting/5272440-expected.png:
      * platform/qt/editing/deleting/5369009-expected.png:
      * platform/qt/editing/deleting/5433862-2-expected.png:
      * platform/qt/editing/deleting/delete-3608445-fix-expected.png:
      * platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
      * platform/qt/editing/deleting/delete-block-contents-003-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-018-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-021-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-022-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png:
      * platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png:
      * platform/qt/editing/deleting/delete-br-002-expected.png:
      * platform/qt/editing/deleting/delete-br-003-expected.png:
      * platform/qt/editing/deleting/delete-br-004-expected.png:
      * platform/qt/editing/deleting/delete-br-005-expected.png:
      * platform/qt/editing/deleting/delete-br-006-expected.png:
      * platform/qt/editing/deleting/delete-hr-expected.png:
      * platform/qt/editing/deleting/delete-image-002-expected.png:
      * platform/qt/editing/deleting/delete-line-003-expected.png:
      * platform/qt/editing/deleting/delete-line-004-expected.png:
      * platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
      * platform/qt/editing/deleting/delete-line-end-ws-002-expected.png:
      * platform/qt/editing/deleting/delete-listitem-001-expected.png:
      * platform/qt/editing/deleting/forward-delete-expected.png:
      * platform/qt/editing/deleting/merge-different-styles-expected.png:
      * platform/qt/editing/deleting/pruning-after-merge-2-expected.png:
      * platform/qt/editing/deleting/smart-delete-003-expected.png:
      * platform/qt/editing/deleting/smart-delete-004-expected.png:
      * platform/qt/editing/deleting/type-delete-after-quote-expected.png:
      * platform/qt/editing/execCommand/4580583-1-expected.png:
      * platform/qt/editing/execCommand/4924441-expected.png:
      * platform/qt/editing/execCommand/5482023-expected.png:
      * platform/qt/editing/execCommand/findString-2-expected.png:
      * platform/qt/editing/execCommand/indent-empty-root-expected.png:
      * platform/qt/editing/execCommand/insertHorizontalRule-expected.png:
      * platform/qt/editing/execCommand/insertImage-expected.png:
      * platform/qt/editing/execCommand/nsresponder-indent-expected.png:
      * platform/qt/editing/execCommand/nsresponder-outdent-expected.png:
      * platform/qt/editing/execCommand/paste-1-expected.png:
      * platform/qt/editing/execCommand/paste-2-expected.png:
      * platform/qt/editing/execCommand/remove-list-item-1-expected.png:
      * platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png:
      * platform/qt/editing/inserting/4875189-1-expected.png:
      * platform/qt/editing/inserting/4875189-2-expected.png:
      * platform/qt/editing/inserting/4959067-expected.png:
      * platform/qt/editing/inserting/5418891-expected.png:
      * platform/qt/editing/inserting/before-after-input-element-expected.png:
      * platform/qt/editing/inserting/editable-html-element-expected.png:
      * platform/qt/editing/inserting/edited-whitespace-1-expected.png:
      * platform/qt/editing/inserting/insert-3654864-fix-expected.png:
      * platform/qt/editing/inserting/insert-3778059-fix-expected.png:
      * platform/qt/editing/inserting/insert-3800346-fix-expected.png:
      * platform/qt/editing/inserting/insert-3851164-fix-expected.png:
      * platform/qt/editing/inserting/insert-div-011-expected.png:
      * platform/qt/editing/inserting/insert-div-012-expected.png:
      * platform/qt/editing/inserting/insert-div-013-expected.png:
      * platform/qt/editing/inserting/insert-div-014-expected.png:
      * platform/qt/editing/inserting/insert-div-015-expected.png:
      * platform/qt/editing/inserting/insert-div-016-expected.png:
      * platform/qt/editing/inserting/insert-div-017-expected.png:
      * platform/qt/editing/inserting/insert-div-018-expected.png:
      * platform/qt/editing/inserting/insert-div-019-expected.png:
      * platform/qt/editing/inserting/insert-div-020-expected.png:
      * platform/qt/editing/inserting/insert-div-025-expected.png:
      * platform/qt/editing/inserting/insert-div-027-expected.png:
      * platform/qt/editing/inserting/insert-paragraph-02-expected.png:
      * platform/qt/editing/inserting/paragraph-separator-03-expected.png:
      * platform/qt/editing/inserting/redo-expected.png:
      * platform/qt/editing/pasteboard/4076267-expected.png:
      * platform/qt/editing/pasteboard/4242293-expected.png:
      * platform/qt/editing/pasteboard/4641033-expected.png:
      * platform/qt/editing/pasteboard/4944770-1-expected.png:
      * platform/qt/editing/pasteboard/4944770-2-expected.png:
      * platform/qt/editing/pasteboard/4989774-expected.png:
      * platform/qt/editing/pasteboard/5028447-expected.png:
      * platform/qt/editing/pasteboard/5032095-expected.png:
      * platform/qt/editing/pasteboard/5134759-expected.png:
      * platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
      * platform/qt/editing/pasteboard/input-field-1-expected.png:
      * platform/qt/editing/pasteboard/merge-after-delete-expected.png:
      * platform/qt/editing/pasteboard/merge-end-borders-expected.png:
      * platform/qt/editing/pasteboard/merge-start-list-expected.png:
      * platform/qt/editing/pasteboard/paste-text-004-expected.png:
      * platform/qt/editing/pasteboard/paste-text-008-expected.png:
      * platform/qt/editing/pasteboard/paste-text-009-expected.png:
      * platform/qt/editing/pasteboard/paste-text-013-expected.png:
      * platform/qt/editing/pasteboard/paste-text-014-expected.png:
      * platform/qt/editing/pasteboard/paste-text-016-expected.png:
      * platform/qt/editing/pasteboard/styled-element-markup-expected.png:
      * platform/qt/editing/selection/13804-expected.png:
      * platform/qt/editing/selection/4402375-expected.png:
      * platform/qt/editing/selection/4776665-expected.png:
      * platform/qt/editing/selection/4866671-expected.png:
      * platform/qt/editing/selection/4889598-expected.png:
      * platform/qt/editing/selection/4895428-2-expected.png:
      * platform/qt/editing/selection/4895428-3-expected.png:
      * platform/qt/editing/selection/4947387-expected.png:
      * platform/qt/editing/selection/4960116-expected.png:
      * platform/qt/editing/selection/4960137-expected.png:
      * platform/qt/editing/selection/4975120-expected.png:
      * platform/qt/editing/selection/4983858-expected.png:
      * platform/qt/editing/selection/5076323-1-expected.png:
      * platform/qt/editing/selection/5081257-1-expected.png:
      * platform/qt/editing/selection/5081257-2-expected.png:
      * platform/qt/editing/selection/5099303-expected.png:
      * platform/qt/editing/selection/5195166-2-expected.png:
      * platform/qt/editing/selection/5240265-expected.png:
      * platform/qt/editing/selection/7152-1-expected.png:
      * platform/qt/editing/selection/7152-2-expected.png:
      * platform/qt/editing/selection/addRange-expected.png:
      * platform/qt/editing/selection/caret-ltr-2-expected.png:
      * platform/qt/editing/selection/caret-ltr-2-left-expected.png:
      * platform/qt/editing/selection/caret-ltr-expected.png:
      * platform/qt/editing/selection/caret-ltr-right-expected.png:
      * platform/qt/editing/selection/caret-rtl-2-left-expected.png:
      * platform/qt/editing/selection/caret-rtl-right-expected.png:
      * platform/qt/editing/selection/clear-selection-expected.png:
      * platform/qt/editing/selection/contenteditable-click-inside-expected.png:
      * platform/qt/editing/selection/drag-select-1-expected.png:
      * platform/qt/editing/selection/editable-html-element-expected.png:
      * platform/qt/editing/selection/expanding-selections-expected.png:
      * platform/qt/editing/selection/expanding-selections2-expected.png:
      * platform/qt/editing/selection/extend-by-character-003-expected.png:
      * platform/qt/editing/selection/extend-by-character-005-expected.png:
      * platform/qt/editing/selection/extend-inside-transforms-backward-expected.png:
      * platform/qt/editing/selection/extend-inside-transforms-forward-expected.png:
      * platform/qt/editing/selection/focus_editable_html-expected.png:
      * platform/qt/editing/selection/inline-table-expected.png:
      * platform/qt/editing/selection/mixed-editability-1-expected.png:
      * platform/qt/editing/selection/mixed-editability-3-expected.png:
      * platform/qt/editing/selection/mixed-editability-4-expected.png:
      * platform/qt/editing/selection/mixed-editability-5-expected.png:
      * platform/qt/editing/selection/mixed-editability-8-expected.png:
      * platform/qt/editing/selection/mixed-editability-9-expected.png:
      * platform/qt/editing/selection/move-3875618-fix-expected.png:
      * platform/qt/editing/selection/move-3875641-fix-expected.png:
      * platform/qt/editing/selection/move-between-blocks-yes-001-expected.png:
      * platform/qt/editing/selection/move-by-character-003-expected.png:
      * platform/qt/editing/selection/move-by-character-005-expected.png:
      * platform/qt/editing/selection/node-removal-1-expected.png:
      * platform/qt/editing/selection/node-removal-2-expected.png:
      * platform/qt/editing/selection/paragraph-granularity-expected.png:
      * platform/qt/editing/selection/range-between-block-and-inline-expected.png:
      * platform/qt/editing/selection/replace-selection-1-expected.png:
      * platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
      * platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
      * platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
      * platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
      * platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
      * platform/qt/editing/selection/select-all-003-expected.png:
      * platform/qt/editing/selection/select-all-005-expected.png:
      * platform/qt/editing/selection/select-all-006-expected.png:
      * platform/qt/editing/selection/select-all-iframe-expected.png:
      * platform/qt/editing/selection/select-text-overflow-ellipsis-expected.png:
      * platform/qt/editing/selection/selectNode-expected.png:
      * platform/qt/editing/selection/selectNodeContents-expected.png:
      * platform/qt/editing/selection/selection-actions-expected.png:
      * platform/qt/editing/selection/selection-button-text-expected.png:
      * platform/qt/editing/selection/table-caret-3-expected.png:
      * platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
      * platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
      * platform/qt/editing/selection/word-granularity-expected.png:
      * platform/qt/editing/selection/wrapped-line-caret-1-expected.png:
      * platform/qt/editing/selection/wrapped-line-caret-2-expected.png:
      * platform/qt/editing/style/4916887-expected.png:
      * platform/qt/editing/style/5084241-expected.png:
      * platform/qt/editing/style/apple-style-editable-mix-expected.png:
      * platform/qt/editing/style/block-style-001-expected.png:
      * platform/qt/editing/style/block-style-002-expected.png:
      * platform/qt/editing/style/block-style-003-expected.png:
      * platform/qt/editing/style/create-block-for-style-001-expected.png:
      * platform/qt/editing/style/create-block-for-style-002-expected.png:
      * platform/qt/editing/style/create-block-for-style-003-expected.png:
      * platform/qt/editing/style/create-block-for-style-004-expected.png:
      * platform/qt/editing/style/create-block-for-style-005-expected.png:
      * platform/qt/editing/style/create-block-for-style-006-expected.png:
      * platform/qt/editing/style/create-block-for-style-007-expected.png:
      * platform/qt/editing/style/create-block-for-style-008-expected.png:
      * platform/qt/editing/style/create-block-for-style-009-expected.png:
      * platform/qt/editing/style/create-block-for-style-010-expected.png:
      * platform/qt/editing/style/create-block-for-style-011-expected.png:
      * platform/qt/editing/style/create-block-for-style-012-expected.png:
      * platform/qt/editing/style/create-block-for-style-013-expected.png:
      * platform/qt/editing/style/designmode-expected.png:
      * platform/qt/editing/style/relative-font-size-change-001-expected.png:
      * platform/qt/editing/style/relative-font-size-change-002-expected.png:
      * platform/qt/editing/style/relative-font-size-change-003-expected.png:
      * platform/qt/editing/style/relative-font-size-change-004-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e9733e2
    • zarvai@inf.u-szeged.hu's avatar
      [Qt][WK2] Unreviewed gardening. Rebaselining after r147086. · bc5185b9
      zarvai@inf.u-szeged.hu authored
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc5185b9
    • vsevik@chromium.org's avatar
      Web Inspector: Simplify ResourceScriptFile so that it stores hasDiverged state in it. · 1bbea216
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113489
      
      Reviewed by Pavel Feldman.
      
      ResourceScriptFile._hasDiverged is the one flag that shows whether we have diverged from VM.
      It's values is based both on dirty flag on uiSourceCode and information about live edit failures stored in _lastLiveEditFailed field.
      Removed willMerge/Diverge events from ScriptFile.
      JavaScriptSourceFrame now uses isMergingToVM/DivergingFromVM methods on ScriptFile.
      to determine whether breakpointAdded/Removed events should be ignored.
      Introduced muted state on JavaScriptSourceFrame to determine whether it should ignore user attempts to set/remove breakpoints.
      
      * inspector/front-end/JavaScriptSourceFrame.js:
      (WebInspector.JavaScriptSourceFrame):
      (WebInspector.JavaScriptSourceFrame.prototype._didMergeToVM):
      (WebInspector.JavaScriptSourceFrame.prototype._didDivergeFromVM):
      (WebInspector.JavaScriptSourceFrame.prototype._muteBreakpointsWhileEditing):
      (WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
      (WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
      (WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
      (WebInspector.JavaScriptSourceFrame.prototype._shouldIgnoreExternalBreakpointEvents):
      (WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
      (WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
      (WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
      (WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):
      * inspector/front-end/LiveEditSupport.js:
      (WebInspector.LiveEditScriptFile.prototype.isMergingToVM):
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
      (WebInspector.ScriptFile.prototype.isMergingToVM):
      (WebInspector.ResourceScriptFile):
      (WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
      (WebInspector.ResourceScriptFile.prototype._isDiverged):
      (WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
      (WebInspector.ResourceScriptFile.prototype._update):
      (WebInspector.ResourceScriptFile.prototype._divergeFromVM):
      (WebInspector.ResourceScriptFile.prototype._mergeToVM):
      (WebInspector.ResourceScriptFile.prototype.hasDivergedFromVM):
      (WebInspector.ResourceScriptFile.prototype.isMergingToVM):
      * inspector/front-end/ScriptSnippetModel.js:
      (WebInspector.SnippetScriptFile.prototype.isMergingToVM):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bbea216
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Updated png expected results after r146206.. · dad5d466
      kadam@inf.u-szeged.hu authored
      * platform/qt-5.0-wk2/fast/backgrounds/mask-box-image-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize08-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/border-image-scaled-gradient-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/border-image-slice-constrained-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/border-image-slices-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
      * platform/qt-5.0-wk2/fast/box-shadow/box-shadow-radius-expected.png: Added.
      * platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
      * platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
      * platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadows-expected.png: Added.
      * platform/qt-5.0-wk2/fast/box-shadow/inset-expected.png: Added.
      * platform/qt-5.0-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/canvas-as-image-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/canvas-bg-zoom-expected.png: Added.
      * platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png:
      * platform/qt-5.0-wk2/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
      * platform/qt-5.0-wk2/fast/forms/listbox-clip-expected.png:
      * platform/qt-5.0-wk2/fast/forms/select-background-none-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dad5d466