1. 21 Nov, 2013 40 commits
    • commit-queue@webkit.org's avatar
      Remove ENABLE_WORKERS · f0eff209
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105784
      
      .:
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
      Reviewed by Darin Adler.
      
      * Source/autotools/SetupWebKitFeatures.m4:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/WebCore:
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
      Reviewed by Darin Adler.
      
      Source/WebKit:
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
      Reviewed by Darin Adler.
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      Source/WebKit/efl:
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
      Reviewed by Darin Adler.
      
      * ewk/ewk_settings.cpp:
      (ewk_settings_memory_cache_clear):
      
      Source/WebKit/win:
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
      Reviewed by Darin Adler.
      
      * WebWorkersPrivate.cpp:
      (WebWorkersPrivate::workerThreadCount):
      
      Source/WTF:
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
      Reviewed by Darin Adler.
      
      * wtf/FeatureDefines.h:
      * wtf/nix/FeatureDefinesNix.h:
      
      Tools:
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
      Reviewed by Darin Adler.
      
      * Scripts/webkitperl/FeatureList.pm:
      
      WebKitLibraries:
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
      Reviewed by Darin Adler.
      
      * win/tools/vsprops/FeatureDefines.props:
      * win/tools/vsprops/FeatureDefinesCairo.props:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0eff209
    • alex.christensen@flexsim.com's avatar
      [Win] Unreviewed build fix after r159632. · eca09750
      alex.christensen@flexsim.com authored
      * platform/network/curl/SSLHandle.cpp:
      (WebCore::certVerifyCallback):
      Fixed template syntax.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eca09750
    • fpizlo@apple.com's avatar
      Fix a typo (requriements->requirements). · bae5e2c5
      fpizlo@apple.com authored
      * runtime/StackAlignment.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bae5e2c5
    • darin@apple.com's avatar
      Try to fix buildbot Dashboard for people who have not hidden anything. · 186526ab
      darin@apple.com authored
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
      Add a null check for hidden platforms.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      186526ab
    • commit-queue@webkit.org's avatar
      Remove chrome/chromium related things from webkitpy. · 19f6c282
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124493
      
      Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2013-11-21
      Reviewed by Darin Adler.
      
      * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      (PortTest.assert_mock_port_works):
      * Scripts/webkitpy/port/base.py:
      (Port.to.setup_environ_for_server):
      * Scripts/webkitpy/port/mac_unittest.py:
      (test_tests_for_other_platforms):
      * Scripts/webkitpy/port/mock_drt.py:
      (MockTestShell.output_for_test):
      * Scripts/webkitpy/tool/bot/irc_command.py:
      (Restart.execute):
      * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
      (IRCBotTest.test_help):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19f6c282
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Fix build after r159656 · 5c581fb5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124755
      
      Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-11-21
      Reviewed by Gyuyoung Kim.
      
      Page title was moved to page load state.
      
      * UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
      (WebKit::WebInspectorServer::buildPageList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c581fb5
    • alex.christensen@flexsim.com's avatar
      Unreviewed build fix. · d7cbffe4
      alex.christensen@flexsim.com authored
      * src/libGLESv2/Constants.h: Added from checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7cbffe4
    • commit-queue@webkit.org's avatar
      In filereader.py, process_file() should throw instead of exiting directly when... · 87eecb0f
      commit-queue@webkit.org authored
      In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
      https://bugs.webkit.org/show_bug.cgi?id=124717
      
      Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-21
      Reviewed by Ryosuke Niwa.
      
      * Scripts/webkitpy/style/filereader.py:
      (TextFileReader.process_file):
      * Scripts/webkitpy/style/filereader_unittest.py:
      (TextFileReaderTest.test_process_file__does_not_exist):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87eecb0f
    • betravis@adobe.com's avatar
      Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface · 3239a7c0
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124737
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Add a virtual method to Shapes, buildPath, that can be used to build the
      path (in the Shape coordinate system) for display in the Inspector. This allows us
      to remove methods such as type(), polygon(), and logicalRx/Ry() which exposed the
      inner workings of the Shapes classes. Also covers the addition of the BoxShape type.
      
      Refactoring, existing test is inspector-protocol/model/highlight-shape-outside.html.
      
      * inspector/InspectorOverlay.cpp:
      (WebCore::appendPathCommandAndPoints): Points need to be translated from shape space
      to renderer space using ShapeInfo.
      (WebCore::buildObjectForShapeOutside): Add the ShapeOutsideInfo to the path info struct.
      * rendering/shapes/BoxShape.cpp:
      (WebCore::BoxShape::buildPath): Build the path for a BoxShape.
      * rendering/shapes/BoxShape.h:
      * rendering/shapes/PolygonShape.cpp:
      (WebCore::PolygonShape::buildPath): Build the path for a PolygonShape.
      * rendering/shapes/PolygonShape.h:
      * rendering/shapes/RasterShape.h:
      * rendering/shapes/RectangleShape.cpp:
      (WebCore::RectangleShape::buildPath): Build the path for a RectangleShape.
      * rendering/shapes/RectangleShape.h:
      * rendering/shapes/Shape.h:
      
      LayoutTests:
      
      The shapes paths are now drawn in shape-coordinate space before being translated to
      renderer space. With different writing modes, shapes may have their coordinates
      translated. For example, a rectangle specified as four points [top left, top right,
      bottom right, bottom left] in vertical-lr space would appear as [top left, bottom left,
      bottom right, top right] in horizontal-tb space. Adjusting the previous tests, and
      adding a test for the new box value.
      
      * inspector-protocol/model/highlight-shape-outside-expected.txt:
      * inspector-protocol/model/highlight-shape-outside.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3239a7c0
    • mark.lam@apple.com's avatar
      CodeBlock::m_numCalleeRegisters need to honor native stack alignment. · c4ed0fc6
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124754.
      
      Reviewed by Filip Pizlo.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::newRegister):
      * dfg/DFGVirtualRegisterAllocationPhase.cpp:
      (JSC::DFG::VirtualRegisterAllocationPhase::run):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4ed0fc6
    • mrowe@apple.com's avatar
      <https://webkit.org/b/124702> Stop overriding VALID_ARCHS. · 836db138
      mrowe@apple.com authored
      All modern versions of Xcode set it appropriately for our needs.
      
      Reviewed by Alexey Proskuryakov.
      
      Source/JavaScriptCore:
      
      * Configurations/Base.xcconfig:
      
      Source/WebCore:
      
      * Configurations/Base.xcconfig:
      
      Source/WebInspectorUI:
      
      * Configurations/Base.xcconfig:
      
      Source/WebKit/mac:
      
      * Configurations/Base.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/Base.xcconfig:
      
      Tools:
      
      * MiniBrowser/Configurations/Base.xcconfig:
      * WebKitTestRunner/Configurations/Base.xcconfig:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      836db138
    • commit-queue@webkit.org's avatar
      webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element · ae24f307
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124676
      
      Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-21
      Reviewed by Daniel Bates.
      
      checkForArgumentAndRemoveFromArrayRef functions was removing wrong
      elements when there were more then one occurrence of that argument.
      E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
      {b, a}, when it should be {b, c}.
      
      * Scripts/webkitdirs.pm:
      (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
      * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
      Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae24f307
    • ryumiel@company100.net's avatar
      [GTK] Unreviewed buildfix after r159614 and r159656. · 99adce44
      ryumiel@company100.net authored
      Source/WebCore:
      
      * bindings/gobject/WebKitDOMCustom.cpp: Add missing header
      
      Source/WebKit2:
      
      * UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
      (WebKit::WebInspectorServer::buildPageList): Use the page load state to get page title.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99adce44
    • commit-queue@webkit.org's avatar
      Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp · 32f52b52
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124704
      
      Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-21
      Reviewed by Antti Koivisto.
      
      Fix unreachable code warnings using conditional directives.
      
      * rendering/SimpleLineLayout.cpp:
      (WebCore::SimpleLineLayout::canUseFor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32f52b52
    • mrowe@apple.com's avatar
      <https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files. · 2a0e83e0
      mrowe@apple.com authored
      Reviewed by Alexey Proskuryakov.
      
      Source/JavaScriptCore:
      
      * Configurations/Base.xcconfig:
      
      Source/ThirdParty/ANGLE:
      
      * Configurations/Base.xcconfig:
      
      Source/WebCore:
      
      * Configurations/Base.xcconfig:
      
      Source/WebKit/mac:
      
      * Configurations/Base.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/Base.xcconfig:
      
      Source/WTF:
      
      * Configurations/Base.xcconfig:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a0e83e0
    • rniwa@webkit.org's avatar
      Update build-webkit after r159550. · 6ada208c
      rniwa@webkit.org authored
      * Scripts/webkitperl/FeatureList.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ada208c
    • mrowe@apple.com's avatar
      <https://webkit.org/b/124700> Fix some deprecation warnings. · 01352df3
      mrowe@apple.com authored
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      * platform/mac/HTMLConverter.mm:
      (fileWrapperForURL): Move off a deprecated NSFileWrapper method.
      
      Source/WebKit/mac:
      
      * Plugins/WebNetscapePluginStream.mm:
      (WebNetscapePluginStream::startStream): Move off a deprecated NSData method.
      * WebView/WebDataSource.mm:
      (-[WebDataSource _fileWrapperForURL:]): Move off a deprecated NSFileWrapper method.
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
      
      Source/WebKit2:
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView namesOfPromisedFilesDroppedAtDestination:]): Move off a deprecated NSFileWrapper method.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01352df3
    • commit-queue@webkit.org's avatar
      [EFL] Layout tests with editing need to be rebaselined. · 9b6c3a6c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124751
      
      Unreviewed, EFL rebaseline.
      
      editing/input/reveal-caret-of-multiline-contenteditable.html test is rebaselined after r137239.
      editing/selection/5354455-2.html test is rebaselined after r133000.
      Rebaseline the expected results to suit editing-related performance in EFL.
      
      Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-21
      
      * platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
      * platform/efl/editing/selection/5354455-2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b6c3a6c
    • lforschler@apple.com's avatar
      Update apple builders. · 08fc0339
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08fc0339
    • rniwa@webkit.org's avatar
      Import some W3C tests for HTML template element · 38ae7021
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124699
      
      Reviewed by Antti Koivisto.
      
      LayoutTests/imported/w3c:
      
      Imported the shared resources for web-platform-tests/html-templates as well as tests under
      serializing-html-templates and template-element at a274ad93ef5dc02ac042e0a5d58327d4135178ac.
      
      * ChangeLog: Added.
      * html-templates/resources/end-template-tag-in-body.html: Added.
      * html-templates/resources/end-template-tag-in-head.html: Added.
      * html-templates/resources/frameset-end-tag.html: Added.
      * html-templates/resources/head-template-contents-div-no-end-tag.html: Added.
      * html-templates/resources/head-template-contents-table-no-end-tag.html: Added.
      * html-templates/resources/html-start-tag.html: Added.
      * html-templates/resources/template-child-nodes-div.xhtml: Added.
      * html-templates/resources/template-child-nodes-nested.xhtml: Added.
      * html-templates/resources/template-contents-attribute.html: Added.
      * html-templates/resources/template-contents-body.html: Added.
      * html-templates/resources/template-contents-div-no-end-tag.html: Added.
      * html-templates/resources/template-contents-empty.html: Added.
      * html-templates/resources/template-contents-frameset.html: Added.
      * html-templates/resources/template-contents-head.html: Added.
      * html-templates/resources/template-contents-html.html: Added.
      * html-templates/resources/template-contents-nested.html: Added.
      * html-templates/resources/template-contents-table-no-end-tag.html: Added.
      * html-templates/resources/template-contents-text.html: Added.
      * html-templates/resources/template-contents.html: Added.
      * html-templates/resources/template-descendant-body.html: Added.
      * html-templates/resources/template-descendant-frameset.html: Added.
      * html-templates/resources/template-descendant-head.html: Added.
      * html-templates/resources/two-templates.html: Added.
      * html-templates/serializing-html-templates/outerhtml-expected.txt: Added.
      * html-templates/serializing-html-templates/outerhtml.html: Added.
      * html-templates/template-element/content-attribute-expected.txt: Added.
      * html-templates/template-element/content-attribute.html: Added.
      * html-templates/template-element/node-document-changes-expected.txt: Added.
      * html-templates/template-element/node-document-changes.html: Added.
      * html-templates/template-element/template-as-a-descendant-expected.txt: Added.
      * html-templates/template-element/template-as-a-descendant.html: Added.
      * html-templates/template-element/template-content-expected.txt: Added.
      * html-templates/template-element/template-content-node-document-expected.txt: Added.
      * html-templates/template-element/template-content-node-document.html: Added.
      * html-templates/template-element/template-content.html: Added.
      * html-templates/template-element/template-descendant-body-expected.txt: Added.
      * html-templates/template-element/template-descendant-body.html: Added.
      * html-templates/template-element/template-descendant-frameset-expected.txt: Added.
      * html-templates/template-element/template-descendant-frameset.html: Added.
      * html-templates/template-element/template-descendant-head-expected.txt: Added.
      * html-templates/template-element/template-descendant-head.html: Added.
      * html-templates/testcommon.js: Added.
      
      LayoutTests:
      
      * imported/w3c/: Added.
      * platform/win/TestExpectations: Skip the imported tests since the template element is disabled on Windows.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38ae7021
    • dino@apple.com's avatar
      Don't fetch hidden platforms on build.webkit.org/dashboard · 61c3f4c0
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124750
      
      Reviewed by Tim Horton.
      
      If a platform is hidden, don't fetch its data. If it
      becomes unhidden, try to fetch immediately (unless
      you've recently fetched).
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61c3f4c0
    • andersca@apple.com's avatar
      Didn't mean to commit this. · 35afcabb
      andersca@apple.com authored
      * UIProcess/PageLoadState.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35afcabb
    • bfulgham@apple.com's avatar
      Unreviewed gardening to hide annoying *.user files when. · c50f172a
      bfulgham@apple.com authored
      * ANGLE.vcxproj: Added property svn:ignore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c50f172a
    • andersca@apple.com's avatar
      Move page title handling to the page load state · 72bc5df2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124748
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/API/C/WKPage.cpp:
      (WKPageCopyTitle):
      * UIProcess/PageLoadState.cpp:
      (WebKit::PageLoadState::reset):
      (WebKit::PageLoadState::didCommitLoad):
      (WebKit::PageLoadState::title):
      (WebKit::PageLoadState::setTitle):
      * UIProcess/PageLoadState.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didReceiveTitleForFrame):
      * UIProcess/WebPageProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72bc5df2
    • msaboff@apple.com's avatar
      ARM64: Implement push/pop equivalents in LLInt · 6175888a
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124721
      
      Reviewed by Filip Pizlo.
      
      Added pushLRAndFP and popLRAndFP that push and pop the link register and frame pointer register.
      These ops emit code just like what the compiler emits in the prologue and epilogue.  Also changed
      pushCalleeSaves and popCalleeSaves to use the same store pair and load pair instructions to do
      the actually pushing and popping.  Finally changed the implementation of push and pop to raise
      an exception since we don't have (or need) a single register push or pop.
      
      * llint/LowLevelInterpreter64.asm:
      * offlineasm/arm64.rb:
      * offlineasm/instructions.rb:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6175888a
    • msaboff@apple.com's avatar
      JSC: Removed unused opcodes from offline assembler · ff9d4ce5
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124749
      
      Reviewed by Mark Hahnenberg.
      
      Removed the unused, X86 only peekq and pokeq.
      
      * offlineasm/instructions.rb:
      * offlineasm/x86.rb:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff9d4ce5
    • msaboff@apple.com's avatar
      REGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler · d72c71a2
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124688
      
      Reviewed by Geoffrey Garen.
      
      Changed handling of the address for the load8() in the branch8(AbsoluteAddress) to be like
      the rest of the branchXX(AbsoluteAddress) fucntions.
      
      * assembler/MacroAssemblerARM64.h:
      (JSC::MacroAssemblerARM64::branch8):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d72c71a2
    • fpizlo@apple.com's avatar
      BytecodeGenerator should align the stack according to native conventions · 11a11359
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124735
      
      Reviewed by Mark Lam.
      
      * bytecompiler/BytecodeGenerator.h:
      (JSC::CallArguments::registerOffset):
      (JSC::CallArguments::argumentCountIncludingThis):
      * bytecompiler/NodesCodegen.cpp:
      (JSC::CallArguments::CallArguments):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11a11359
    • dbates@webkit.org's avatar
      [iOS] Build fix; export symbol for WebCore::provideDeviceOrientationTo() · dfbf4350
      dbates@webkit.org authored
      Add the symbol __ZN7WebCore26provideDeviceOrientationToEPNS_4PageEPNS_23DeviceOrientationClientE.
      
      * WebCore.exp.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfbf4350
    • dbates@webkit.org's avatar
      Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard · 1404d558
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124741
      
      Reviewed by Alexey Proskuryakov.
      
      Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused
      when building with feature NETWORK_CFDATA_ARRAY_CALLBACK.
      
      Additionally, add a declaration for allocateSegment() with attribute WARN_UNUSED_RETURN
      to have the compiler warn when the return value of this function is unused. Together with
      warnings treated as errors this change will prevent a memory leak.
      
      * platform/SharedBuffer.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1404d558
    • dbates@webkit.org's avatar
      Remove unused functions from WebCore and WebKit2 · efa37bfb
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124739
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      * editing/markup.cpp: Remove unused functions isHTMLBlockElement and
      ancestorToRetainStructureAndAppearanceWithNoRenderer.
      * rendering/InlineElementBox.cpp: Append newline to the end of the file.
      
      Source/WebKit2:
      
      Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).
      
      * UIProcess/API/mac/WKBrowsingContextController.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efa37bfb
    • dbates@webkit.org's avatar
      Only generate isObservable() when IDL specifies GenerateIsReachable · 1ccf4754
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124729
      
      Reviewed by Geoffrey Garen.
      
      We should only generate the static inline function isObservable() when the IDL
      specifies GenerateIsReachable. Otherwise, this function is unused.
      
      Added a new test IDL TestGenerateIsReachable.idl and expected results to test that
      we generate isObservable() when an IDL specifies GenerateIsReachable. Additionally,
      rebased existing test results.
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateImplementation):
      * bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.cpp: Added.
      * bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.h: Added.
      * bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp: Added.
      * bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h: Added.
      * bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachablePrivate.h: Added.
      * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Removed unused function isObservable().
      * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
      * bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
      * bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
      * bindings/scripts/test/JS/JSTestException.cpp: Ditto.
      * bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: Added.
      * bindings/scripts/test/JS/JSTestGenerateIsReachable.h: Added.
      * bindings/scripts/test/JS/JSTestInterface.cpp: Removed unused function isObservable().
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
      * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
      * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Ditto.
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
      * bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
      * bindings/scripts/test/JS/JSattribute.cpp: Ditto.
      * bindings/scripts/test/JS/JSreadonly.cpp: Ditto.
      * bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h: Added.
      * bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm: Added.
      * bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h: Added.
      * bindings/scripts/test/TestGenerateIsReachable.idl: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ccf4754
    • ossy@webkit.org's avatar
      Rename PlatformCertificateInfo to CertificateInfo · 1b45c5d8
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124150
      
      Reviewed by Darin Adler.
      
      * GNUmakefile.list.am:
      * NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
      (WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
      * NetworkProcess/NetworkProcess.h:
      * NetworkProcess/NetworkProcess.messages.in:
      * NetworkProcess/NetworkResourceLoader.cpp:
      * NetworkProcess/mac/NetworkProcessMac.mm:
      (WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
      * NetworkProcess/soup/NetworkProcessSoup.cpp:
      (WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
      * PlatformEfl.cmake:
      * PlatformGTK.cmake:
      * Shared/API/c/mac/WKCertificateInfoMac.mm:
      (WKCertificateInfoCreateWithCertficateChain):
      (WKCertificateInfoGetCertificateChain):
      * Shared/Authentication/AuthenticationManager.cpp:
      (WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
      (WebKit::AuthenticationManager::useCredentialForChallenge):
      * Shared/Authentication/AuthenticationManager.h:
      * Shared/Authentication/AuthenticationManager.messages.in:
      * Shared/Authentication/mac/AuthenticationManager.mac.mm:
      (WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
      * Shared/UserMessageCoders.h:
      (WebKit::UserMessageEncoder::baseEncode):
      (WebKit::UserMessageDecoder::baseDecode):
      * Shared/WebCertificateInfo.h:
      (WebKit::WebCertificateInfo::create):
      (WebKit::WebCertificateInfo::certificateInfo):
      (WebKit::WebCertificateInfo::WebCertificateInfo):
      * Shared/mac/CertificateInfo.h: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.h.
      (WebKit::CertificateInfo::certificateChain):
      * Shared/mac/CertificateInfo.mm: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.
      (WebKit::CertificateInfo::CertificateInfo):
      (WebKit::CertificateInfo::encode):
      (WebKit::CertificateInfo::decode):
      (WebKit::CertificateInfo::dump):
      * Shared/mac/WebCoreArgumentCodersMac.mm:
      (CoreIPC::::encodePlatformData):
      (CoreIPC::::decodePlatformData):
      * Shared/soup/CertificateInfo.cpp: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp.
      (WebKit::CertificateInfo::CertificateInfo):
      (WebKit::CertificateInfo::~CertificateInfo):
      (WebKit::CertificateInfo::encode):
      (WebKit::CertificateInfo::decode):
      * Shared/soup/CertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.h.
      (WebKit::CertificateInfo::certificate):
      (WebKit::CertificateInfo::tlsErrors):
      * Shared/soup/WebCoreArgumentCodersSoup.cpp:
      (CoreIPC::::encodePlatformData):
      (CoreIPC::::decodePlatformData):
      * UIProcess/API/gtk/WebKitCertificateInfo.cpp:
      (webkitCertificateInfoGetCertificateInfo):
      * UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkit_web_view_get_tls_info):
      * UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
      (WebKit::AuthenticationChallengeProxy::useCredential):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::allowSpecificHTTPSCertificateForHost):
      * UIProcess/WebFrameProxy.cpp:
      (WebKit::WebFrameProxy::didCommitLoad):
      * UIProcess/WebFrameProxy.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didCommitLoadForFrame):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/Network/WebResourceLoader.cpp:
      (WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
      * WebProcess/Network/WebResourceLoader.h:
      * WebProcess/Network/WebResourceLoader.messages.in:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
      * WebProcess/WebProcess.h:
      * WebProcess/WebProcess.messages.in:
      * WebProcess/soup/WebProcessSoup.cpp:
      (WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b45c5d8
    • ossy@webkit.org's avatar
      [EFL][GTK][WK2] Build fix after r159641 · 40204b71
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124742
      
      Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-11-21
      Reviewed by Csaba Osztrogonác.
      
      Should fetch activeURL from page load state.
      
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkitWebViewUpdateURI):
      * UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
      (WebKit::WebInspectorServer::buildPageList):
      * UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
      (WebKit::WebInspectorServer::buildPageList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40204b71
    • bdakin@apple.com's avatar
      Add a new mode to extend the tile cache beyond the page · 8af619cc
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124216
      
      Reviewed by Simon Fraser.
      
      This patch makes it possible to give the tile cache a margin of tiles. If there is 
      a margin of tiles, this patch paints those tiles with the background color. Note 
      that this patch does not actually give the tile cache a margin at this time.
      
      You opt into a margined tiled cache by called setTileMargins() with number of 
      pixels that the margin on that side should be. 
      * platform/graphics/TiledBacking.h:
      * platform/graphics/ca/mac/TileController.h:
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::TileController):
      (WebCore::TileController::tilesWouldChangeForVisibleRect):
      
      TileController::bounds() now computes the bounds INCLUDING the margin.
      (WebCore::TileController::bounds):
      
      adjustRectAtTileIndexForMargin() is a new function that is required to get the 
      rect size for tiles in the margin right. rectForTileIndex() assumes all tiles 
      strive to be the size of m_tileSize, but now margin tiles will be whatever the 
      margin sizes were set to.
      (WebCore::TileController::adjustRectAtTileIndexForMargin):
      (WebCore::TileController::rectForTileIndex):
      
      This is another instance where m_tileSize is not always the right size to use.
      (WebCore::TileController::getTileIndexRangeForRect):
      
      The tile coverage rect now might include the margin tiles. Only include them in 
      slow-scrolling mode if the current position is within one tile of the edge.
      (WebCore::TileController::computeTileCoverageRect):
      
      tileSizeForCoverageRect() does not make sense in a world where the coverage rect 
      will include margin. Instead, this patch implements the current strategy more 
      explicitly by returning the visibleRect in the slow scrolling case, and in the 
      process this patch also re-names tileSizeForCoverageRect() to computeTileSize() 
      since it no longer takes a coverageRect.
      (WebCore::TileController::computeTileSize):
      (WebCore::TileController::revalidateTiles):
      
      New setters and getters for the tile margins on each side.
      (WebCore::TileController::setTileMargins):
      (WebCore::TileController::hasMargins):
      (WebCore::TileController::topMarginHeight):
      (WebCore::TileController::bottomMarginHeight):
      (WebCore::TileController::leftMarginWidth):
      (WebCore::TileController::rightMarginWidth):
      
      New function to add margin onto the composited bounds if there is one.
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::tiledBackingHasMargin):
      (WebCore::RenderLayerBacking::paintContents):
      (WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):
      * rendering/RenderLayerBacking.h:
      
      Do not set masks to bounds if there is a margin on the root layer.
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::updateBacking):
      (WebCore::RenderLayerCompositor::mainFrameBackingIsTiledWithMargin):
      * rendering/RenderLayerCompositor.h:
      
      Allow background color to paint into the margin tiles.
      * rendering/RenderView.cpp:
      (WebCore::RenderView::paintBoxDecorations):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8af619cc
    • ap@apple.com's avatar
      Implement WebCrypto wrapKey · abd0bbca
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124738
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Tests: crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html
             crypto/subtle/aes-cbc-wrap-rsa.html
      
      * bindings/js/JSSubtleCryptoCustom.cpp:
      (WebCore::exportKey): Factored out the actual operation that can be chained with
      encryption for wrapKey.
      (WebCore::JSSubtleCrypto::exportKey):
      (WebCore::JSSubtleCrypto::wrapKey):
      (WebCore::JSSubtleCrypto::unwrapKey): Fixed a memory leak in failure code path.
      
      * crypto/SubtleCrypto.idl: Added wrapKey.
      
      LayoutTests: 
      
      * crypto/subtle/aes-cbc-wrap-rsa-expected.txt: Added.
      * crypto/subtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Added.
      * crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html: Added.
      * crypto/subtle/aes-cbc-wrap-rsa.html: Added.
      
      * crypto/subtle/aes-export-key-expected.txt:
      * crypto/subtle/hmac-export-key-expected.txt:
      There is no longer a console message, the error is in an exception.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abd0bbca
    • fpizlo@apple.com's avatar
      Unreviewed, preemptive build fix. · 35569e79
      fpizlo@apple.com authored
      * runtime/StackAlignment.h:
      (JSC::stackAlignmentBytes):
      (JSC::stackAlignmentRegisters):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35569e79
    • fpizlo@apple.com's avatar
      JSC should know what the stack alignment conventions are · 802ad32f
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124736
      
      Reviewed by Mark Lam.
      
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * runtime/StackAlignment.h: Added.
      (JSC::stackAlignmentBytes):
      (JSC::stackAlignmentRegisters):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      802ad32f
    • andersca@apple.com's avatar
      Fetch all page loading related URLs from the page load state · a8f218e8
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124732
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/API/C/WKPage.cpp:
      (WKPageCopyActiveURL):
      (WKPageCopyProvisionalURL):
      (WKPageCopyCommittedURL):
      * UIProcess/API/mac/WKBrowsingContextController.mm:
      (-[WKBrowsingContextController unreachableURL]):
      * UIProcess/PageLoadState.h:
      (WebKit::PageLoadState::provisionalURL):
      (WebKit::PageLoadState::url):
      (WebKit::PageLoadState::unreachableURL):
      * UIProcess/WebPageProxy.cpp:
      * UIProcess/WebPageProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8f218e8
    • stavila@adobe.com's avatar
      Added test for :hover and javascript events on the visual overflow of a region. · e1657751
      stavila@adobe.com authored
      [CSS Regions] Content in a region's visible overflow does not trigger :hover state, nor JavaScript events
      https://bugs.webkit.org/show_bug.cgi?id=112010
      
      Reviewed by Antti Koivisto.
      
      * fast/regions/hover-and-js-in-visual-overflow-expected.html: Added.
      * fast/regions/hover-and-js-in-visual-overflow.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1657751