1. 10 Dec, 2010 1 commit
    • chang.shu@nokia.com's avatar
      2010-12-10 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com> · eff3dea4
      chang.shu@nokia.com authored
              Reviewed by Joseph Pecoraro.
      
              Bug 43455 - [Qt]: Implement Application Cache Quotas
              https://bugs.webkit.org/show_bug.cgi?id=43455
      
              Added new signal to report ApplicationCache Database
              quota.
      
              * Api/qwebpage.cpp:
              * Api/qwebpage.h:
      
              Added new functions to accomodate new appcache layout
              test origin-quota.html.
      
              * Api/qwebsecurityorigin.cpp:
              (QWebSecurityOrigin::setApplicationCacheQuota):
              * Api/qwebsecurityorigin.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::clearAllApplicationCaches):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
      
              Reviewed by Joseph Pecoraro.
      
              [Qt]: Implement Application Cache Quotas
              https://bugs.webkit.org/show_bug.cgi?id=43455
      
              * platform/qt/Skipped: Unskip now passing test origin-quota.html
      
      2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
      
              Reviewed by Joseph Pecoraro.
      
              Bug 43455 - [Qt]: Implement Application Cache Quotas
              https://bugs.webkit.org/show_bug.cgi?id=43455
      
              Introduce functions to allow new appcache layout test origin-quota.html
              to work correctly under Qt.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
      
              Introduce functions to allow new appcache layout test origin-quota.html
              to be successful under qt. Changes required because LayoutTestControllerQt
              does not inherit from LayoutController.
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::clearAllApplicationCaches):
              (LayoutTestController::setApplicationCacheOriginQuota):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
              (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eff3dea4
  2. 23 Nov, 2010 1 commit
    • hausmann@webkit.org's avatar
      [Qt] Review the setUserPermission & friends API · 650e31e3
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=46810
      
      Reviewed by Tor Arne Vestbø.
      
      Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
      and GeolocationPermissionDomain to Geolocation.
      
      WebKit/qt:
      
      * Api/qwebpage.cpp:
      (QWebPage::setUserPermission):
      * Api/qwebpage.h:
      * WebCoreSupport/GeolocationPermissionClientQt.cpp:
      (WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
      (WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::requestPermission):
      (WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
      * tests/qwebpage/tst_qwebpage.cpp:
      (JSTestPage::requestPermission):
      (tst_QWebPage::geolocationRequestJS):
      
      WebKitTools:
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::WebPage::WebPage):
      (WebCore::WebPage::requestPermission):
      (WebCore::WebPage::cancelPermission):
      (WebCore::WebPage::permissionSet):
      (WebCore::DumpRenderTree::geolocationPermissionSet):
      * DumpRenderTree/qt/DumpRenderTreeQt.h:
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::grantDesktopNotificationPermission):
      * QtTestBrowser/webpage.cpp:
      (WebPage::WebPage):
      (WebPage::requestPermission):
      (WebPage::cancelRequestsForPermission):
      * QtTestBrowser/webpage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650e31e3
  3. 16 Nov, 2010 1 commit
    • hausmann@webkit.org's avatar
      [Qt] Remove synchronous QWebPage::checkPermissions signal · ed8997b7
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=46810
      
      Reviewed by Andreas Kling.
      
      WebKit/qt:
      
      As decided in the API review, we remove this signal and replace its only use currently
      with cached credentials.
      
      * Api/qwebpage.cpp:
      (QWebPage::setUserPermission): Pass the WebCore frame instead of the QWebFrame.
      * Api/qwebpage.h:
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::checkPermission): Replaced explicit
      signal emission with hash lookup of previously granted permission (or not).
      (WebCore::NotificationPresenterClientQt::cancelRequestsForPermission): Remove
      any previously cached/granted permission for the given script execution context.
      (WebCore::NotificationPresenterClientQt::allowNotificationForFrame): Do not
      only serve pending permission requests but before calling the JS callbacks, remember
      the permission for subsequent synchronous checkPermission() calls.
      * WebCoreSupport/NotificationPresenterClientQt.h: Add cache for permissions.
      
      WebKitTools:
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::WebPage::WebPage):
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::grantDesktopNotificationPermission): When granting
      permission, grant it directly on the QWebPage/Frame, that will remember it.
      * QtTestBrowser/webpage.cpp:
      (WebPage::WebPage):
      * QtTestBrowser/webpage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed8997b7
  4. 30 Sep, 2010 1 commit
    • robert@webkit.org's avatar
      2010-09-30 Robert Hogan <robert@webkit.org> · 063b6764
      robert@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Support for PlainTextController
      
              Unskip editing/text-iterator/basic-iteration.html
      
              https://bugs.webkit.org/show_bug.cgi?id=38805
      
              * platform/qt/Skipped:
      2010-09-30  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Support for PlainTextController
      
              Unskip editing/text-iterator/basic-iteration.html
      
              https://bugs.webkit.org/show_bug.cgi?id=38805
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::plainText):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2010-09-30  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Support for PlainTextController
      
              Unskip editing/text-iterator/basic-iteration.html
      
              https://bugs.webkit.org/show_bug.cgi?id=38805
      
              * DumpRenderTree/qt/DumpRenderTree.pro:
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::initJSObjects):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
              (PlainTextController::PlainTextController):
              (PlainTextController::plainText):
              * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      063b6764
  5. 01 Sep, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-09-01 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> · 63ddb60a
      commit-queue@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt] QWebPage::allowGeolocationRequest should be async API
              https://bugs.webkit.org/show_bug.cgi?id=41364
      
              Enable all geolocation delayed permission layout test for Qt port
      
              * platform/qt/Skipped:
      2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] QWebPage::allowGeolocationRequest should be async API
              https://bugs.webkit.org/show_bug.cgi?id=41364
      
              Adding GeolocationPermissionClientQt.cpp/h to build script
      
              * WebCore.pro:
      2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] QWebPage::allowGeolocationRequest should be async API
              https://bugs.webkit.org/show_bug.cgi?id=41364
      
              Provides a new async API for geolocation permission. Using
              Notification API approach from qtwebkit. GeolocationPermissionClientQt
              maintains list of pending requests from WebCore and intimates them
              when client either allowes/denies the request. Also implements
              ChromeClientQt::cancelGeolocationPermissionRequestForFrame.
      
              * Api/qwebpage.cpp:
              (QWebPage::setUserPermission):
              * Api/qwebpage.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
              (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
              * WebCoreSupport/ChromeClientQt.h:
              * WebCoreSupport/GeolocationPermissionClientQt.cpp: Added.
              (WebCore::GeolocationPermissionClientQt::geolocationPermissionClient):
              (WebCore::GeolocationPermissionClientQt::GeolocationPermissionClientQt):
              (WebCore::GeolocationPermissionClientQt::~GeolocationPermissionClientQt):
              (WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
              (WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
              (WebCore::GeolocationPermissionClientQt::setPermission):
              * WebCoreSupport/GeolocationPermissionClientQt.h: Added.
              * tests/qwebpage/tst_qwebpage.cpp:
              (JSTestPage::requestPermission):
              (tst_QWebPage::geolocationRequestJS):
      2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] QWebPage::allowGeolocationRequest should be async API
              https://bugs.webkit.org/show_bug.cgi?id=41364
      
              Implements new async API for geolocation permission similar to
              Notification. WebPage maintains list of geolocation permission request
              QtWebkit and set's when LayoutTestController gets the access from test JS
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::WebPage::resetSettings):
              (WebCore::WebPage::requestPermission):
              (WebCore::WebPage::cancelPermission):
              (WebCore::WebPage::permissionSet):
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::processLine):
              (WebCore::DumpRenderTree::geolocationPermissionSet):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::setGeolocationPermission):
              (LayoutTestController::setGeolocationPermissionCommon):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63ddb60a
  6. 26 Aug, 2010 1 commit
    • abecsi@webkit.org's avatar
      [Qt] DumpRenderTree runs only one test from command mode · e8ac1333
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=44012
      
      Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-08-26
      Reviewed by Kenneth Rohde Christiansen.
      
      Enables support to run multiple test files and single
      folder containing html files in stand alone mode
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::DumpRenderTree):
      (WebCore::DumpRenderTree::processArgsLine):
      (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
      (WebCore::DumpRenderTree::processLine):
      (WebCore::DumpRenderTree::dump):
      * DumpRenderTree/qt/DumpRenderTreeQt.h:
      (WebCore::DumpRenderTree::setStandAloneMode):
      (WebCore::DumpRenderTree::isStandAloneMode):
      * DumpRenderTree/qt/main.cpp:
      (main):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8ac1333
  7. 22 Jul, 2010 1 commit
    • yael.aharon@nokia.com's avatar
      2010-07-22 Yael Aharon <yael.aharon@nokia.com> · 17417c27
      yael.aharon@nokia.com authored
              Reviewed by Laszlo Gombos.
      
              [Qt] QtWebKit needs public API for Notifications.
              https://bugs.webkit.org/show_bug.cgi?id=41413
      
              Add a DRT API to set a flag so that notification requests are ignored,
              and add a test for cancelling a pending notification request.
              New API and test are disabled for Chromium port.
      
              * fast/notifications/notifications-cancel-request-permission-expected.txt: Added.
              * fast/notifications/notifications-cancel-request-permission.html: Added.
              * fast/notifications/resources: Added.
              * fast/notifications/resources/notifications-cancel-request-permission.html: Added.
              * platform/chromium/test_expectations.txt:
      2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] QtWebKit needs public API for Notifications.
              https://bugs.webkit.org/show_bug.cgi?id=41413
      
              Remove DumpRenderTree private API and introduce new API.
              Also add support for informing the UI when a notification request is cancelled.
      
              * Api/qwebpage.cpp:
              (QWebPage::setUserPermission):
              * Api/qwebpage.h:
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
              * WebCoreSupport/NotificationPresenterClientQt.cpp:
              (WebCore::NotificationPresenterClientQt::requestPermission):
              (WebCore::NotificationPresenterClientQt::checkPermission):
              (WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
              (WebCore::NotificationPresenterClientQt::allowNotificationForFrame):
              (WebCore::NotificationPresenterClientQt::toPage):
              (WebCore::NotificationPresenterClientQt::toFrame):
              * WebCoreSupport/NotificationPresenterClientQt.h:
      2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] QtWebKit needs public API for Notifications.
              https://bugs.webkit.org/show_bug.cgi?id=41413
      
              Update DumpRenderTree and QtTestBrowser to use the new API.
              Add new DRT API to flag that notifications permission requests should be ignored.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::WebPage::requestPermission):
              (WebCore::WebPage::checkPermission):
              (WebCore::WebPage::cancelRequestsForPermission):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
              (LayoutTestController::checkDesktopNotificationPermission):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::ignoreReqestForPermission):
              * QtTestBrowser/main.cpp:
              (LauncherWindow::LauncherWindow):
              * QtTestBrowser/webpage.cpp:
              (WebPage::WebPage):
              (WebPage::requestPermission):
              (WebPage::checkPermission):
              (WebPage::cancelRequestsForPermission):
              * QtTestBrowser/webpage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17417c27
  8. 03 Jul, 2010 1 commit
    • robert@webkit.org's avatar
      2010-07-03 Robert Hogan <robert@webkit.org> · ddd9ea55
      robert@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] support dumpChildFrameScrollPositions
      
              https://bugs.webkit.org/show_bug.cgi?id=41088
      
              Unskip:
      
              http/tests/navigation/anchor-subframeload.html
              http/tests/navigation/relativeanchor-frames.html
      
              * platform/qt/Skipped:
      2010-07-03  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] support dumpChildFrameScrollPositions
      
              https://bugs.webkit.org/show_bug.cgi?id=41088
      
              Unskip:
      
              http/tests/navigation/anchor-subframeload.html
              http/tests/navigation/relativeanchor-frames.html
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::dumpFrameScrollPosition):
              (WebCore::DumpRenderTree::dump):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::shouldDumpChildFrameScrollPositions):
              (LayoutTestController::dumpChildFrameScrollPositions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddd9ea55
  9. 29 Jun, 2010 1 commit
  10. 28 Jun, 2010 1 commit
  11. 14 Jun, 2010 1 commit
    • ossy@webkit.org's avatar
      [Qt] navigator.geolocation support for Qt port · 2880b949
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39724
      
      Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-06-14
      Reviewed by Laszlo Gombos.
      
      WebCore: 
      
      Implemetion for Qt port of navigator.gelocation. Using qtmobility location service.
      
      * WebCore.pri:
      * WebCore.pro:
      * platform/qt/GeolocationServiceQt.cpp: Added.
      (WebCore::GeolocationServiceQt::create):
      (WebCore::GeolocationServiceQt::GeolocationServiceQt):
      (WebCore::GeolocationServiceQt::~GeolocationServiceQt):
      (WebCore::GeolocationServiceQt::positionUpdated):
      (WebCore::GeolocationServiceQt::startUpdating):
      (WebCore::GeolocationServiceQt::stopUpdating):
      * platform/qt/GeolocationServiceQt.h: Added.
      (WebCore::GeolocationServiceQt::lastPosition):
      (WebCore::GeolocationServiceQt::lastError):
      
      WebKit/qt: 
      
      Implement ChromeClientQt::requestGeolocationPermissionForFrame() which delegates call to QWebPage::allowGeolocationRequest
      Layout and unit test cases for the are also added. 
      
      * Api/qwebpage.cpp:
      (QWebPage::allowGeolocationRequest):
      * Api/qwebpage.h:
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setMockGeolocationPosition):
      (DumpRenderTreeSupportQt::setMockGeolocationError):
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      * tests/qwebpage/tst_qwebpage.cpp:
      (JSTestPage::shouldInterruptJavaScript):
      (JSTestPage::allowGeolocationRequest):
      (JSTestPage::setGeolocationPermission):
      (tst_QWebPage::geolocationRequestJS):
      
      WebKitTools: 
      
      Implementation for geolocation cases to DumpRenderTreeQt
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::WebPage::allowGeolocationRequest):
      * DumpRenderTree/qt/DumpRenderTreeQt.h:
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::setGeolocationPermission):
      (LayoutTestController::setMockGeolocationError):
      (LayoutTestController::setMockGeolocationPosition):
      * DumpRenderTree/qt/LayoutTestControllerQt.h:
      (LayoutTestController::isGeolocationPermissionSet):
      (LayoutTestController::geolocationPermission):
      
      LayoutTests: 
      
      Uncommenting gelocation cases from Qt. Skipped one case: fast/dom/Geolocation/callback-to-remote-context2.html
      
      * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2880b949
  12. 02 Jun, 2010 2 commits
    • eric@webkit.org's avatar
      2010-06-02 Diego Gonzalez <diegohcg@webkit.org> · a1bf9a61
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Make possible run DRT with QGraphicsWebView
              https://bugs.webkit.org/show_bug.cgi?id=40016
      
              Make possible to use a environment variable for switching backend.
              Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
              (WebCore::DumpRenderTree::DumpRenderTree):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              (WebCore::DumpRenderTree::setGraphicsBased):
              (WebCore::DumpRenderTree::isGraphicsBased):
              (WebCore::WebViewGraphicsBased::graphicsView):
              (WebCore::WebViewGraphicsBased::setPage):
              * Scripts/old-run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1bf9a61
    • yael.aharon@nokia.com's avatar
      [Qt] Fix the lifecycle of notification objects · bdc54d7f
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=40003
      
      Reviewed by Kenneth Rohde Christiansen.
      
      WebKit/qt: 
      
      Notification objects are not tightly related to the page that created them,
      and should be decoupled from the page.
      Create one NotificationPresenter that handles all notifications.
      Add ref/deref to the notification objects when they are added/removed from
      the queue of active notifications. The same technique is used for XMLHttpRequest.
      Instead of deleting all notifications associated with a page when the page is navigated,
      delete them on a timer, using the same timeout that QSystemTrayIcon is using.
      Break up the show() method into smaller methods.
      Use OwnPtr instead of raw pointer for QSystemTrayIcon.
      Move creating the QIcon to just before showing it in the QSyetemTrayIcon.
      
      No new tests as this is just a refactoring. Existing notifications test cover the code.
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::QWebPagePrivate):
      (QWebPagePrivate::~QWebPagePrivate):
      * Api/qwebpage_p.h:
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::notificationPresenter):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setNotificationsReceiver):
      (DumpRenderTreeSupportQt::allowNotificationForOrigin):
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::notificationPresenter):
      (WebCore::NotificationIconWrapper::NotificationIconWrapper):
      (WebCore::NotificationIconWrapper::~NotificationIconWrapper):
      (WebCore::NotificationIconWrapper::close):
      (WebCore::NotificationPresenterClientQt::NotificationPresenterClientQt):
      (WebCore::NotificationPresenterClientQt::removeClient):
      (WebCore::NotificationPresenterClientQt::show):
      (WebCore::NotificationPresenterClientQt::displayNotification):
      (WebCore::NotificationPresenterClientQt::cancel):
      (WebCore::NotificationPresenterClientQt::notificationObjectDestroyed):
      (WebCore::NotificationPresenterClientQt::requestPermission):
      (WebCore::NotificationPresenterClientQt::sendEvent):
      (WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
      (WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
      (WebCore::NotificationPresenterClientQt::dumpShowText):
      * WebCoreSupport/NotificationPresenterClientQt.h:
      (WebCore::NotificationPresenterClientQt::addClient):
      
      WebKitTools: 
      
      Remove the dependency of notifications on QWebPage.
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::requestPermissionCallback):
      (WebCore::WebPage::WebPage):
      (WebCore::DumpRenderTree::requestPermission):
      * DumpRenderTree/qt/DumpRenderTreeQt.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdc54d7f
  13. 28 May, 2010 1 commit
    • eric@webkit.org's avatar
      2010-05-28 Yael Aharon <yael.aharon@nokia.com> · ff124320
      eric@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt] Pass all web notification layout tests
              https://bugs.webkit.org/show_bug.cgi?id=39146
      
              * platform/qt/Skipped:
      2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] Pass all web notification layout tests
              https://bugs.webkit.org/show_bug.cgi?id=39146
      
              Add support for multiple simultaneous notifications.
              Add a private callback mechanism to the client for security checks.
              Notifications are disabled if the client does not set the callbacks.
              Support replaceId and cancel.
              Send close and display events when needed.
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::QWebPagePrivate):
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::setNotificationsReceiver):
              (DumpRenderTreeSupportQt::allowNotificationForOrigin):
              (DumpRenderTreeSupportQt::setCheckPermissionFunction):
              (DumpRenderTreeSupportQt::setRequestPermissionFunction):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
              * WebCoreSupport/NotificationPresenterClientQt.cpp:
              (NotificationIconWrapper::NotificationIconWrapper):
              (NotificationIconWrapper::~NotificationIconWrapper):
              (NotificationPresenterClientQt::NotificationPresenterClientQt):
              (NotificationPresenterClientQt::show):
              (NotificationPresenterClientQt::cancel):
              (NotificationPresenterClientQt::notificationObjectDestroyed):
              (NotificationPresenterClientQt::requestPermission):
              (NotificationPresenterClientQt::checkPermission):
              (NotificationPresenterClientQt::allowNotificationForOrigin):
              (NotificationPresenterClientQt::clearNotificationsList):
              (NotificationPresenterClientQt::sendEvent):
              * WebCoreSupport/NotificationPresenterClientQt.h:
              (WebCore::NotificationPresenterClientQt::~NotificationPresenterClientQt):
              (WebCore::NotificationPresenterClientQt::setReceiver):
      2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] Pass all web notification layout tests
              https://bugs.webkit.org/show_bug.cgi?id=39146
      
              Mimic Chromium's test_shell security model in Qt's DRT.
              It makes a list of origins which were granted permission to display
              notifications, and only those origins can display notifications.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::checkPermissionCallback):
              (WebCore::requestPermissionCallback):
              (WebCore::WebPage::WebPage):
              (WebCore::DumpRenderTree::checkPermission):
              (WebCore::DumpRenderTree::requestPermission):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::grantDesktopNotificationPermission):
              (LayoutTestController::checkDesktopNotificationPermission):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff124320
  14. 18 May, 2010 1 commit
    • hausmann@webkit.org's avatar
      [Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html · d64d36e5
      hausmann@webkit.org authored
      2010-05-08  Robert Hogan  <robert@roberthogan.net>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html
                   and http/tests/xmlhttprequest/cross-origin-authorization.html
      
              QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
              without knowing if this is valid behaviour or not. In order to allow
              Qt to decide whether Cookie/Authorization headers should be added
              to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
              These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
              QNetworkRequest::CookieSaveControlAttribute,and
              QNetworkRequest::AuthenticationReuseControlAttribute.
      
              QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
              unless withCredentials is set to true in the XHR.
      
              QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
              is set to true in the XHR.
      
              Qt will pass the values onto QHttpNetworkRequest and this will permit
              the Qt network access processing to decide whether or not to add either
              or both of the Cookie/Authorisation headers, and whether to save cookies
              returned from such requests. By default the attribute
              will always be true so unless QtWebKit sets it to false normal
              header processing is unaffected.
      
              There are platform-specific results for cross-origin-no-authorization.html:
      
              1. Qt's DRT does not capture the final 'DONE'.
              2. QNetworkReplyHandler.cpp's ignoreHttpError() means that async requests
                 do not execute didFail() when they receive a 401 HTTP response. This
                 results in async tests passing with '401 Authorisation required' rather
                 than 'received error event'.
      
              The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592
      
              In order to properly support the tests, Qt's DRT needs to use one
              NetworkAccessManager for all pages. This allows it to use cached
              credentials where appropriate.
      
              The tests now pass when run individually but there seems to be a problem with
              leaking the results of requests across tests when run with the others in
              http/tests. This will be addressed in a separate patch.
      
              https://bugs.webkit.org/show_bug.cgi?id=32967
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::DumpRenderTree::DumpRenderTree):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * platform/network/qt/ResourceRequestQt.cpp:
              (WebCore::ResourceRequest::toNetworkRequest):
              * platform/qt/Skipped: Group together the tests that are waiting for 4.7 to be unskipped.
              * platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d64d36e5
  15. 17 May, 2010 1 commit
    • robert@webkit.org's avatar
      2010-05-17 Robert Hogan <robert@webkit.org> · d08c8d81
      robert@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Disable Icon Database by default in Qt DRT
      
              Unskip:
               http/tests/misc/favicon-loads-with-images-disabled.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
      
              Qt returns 5 (QNetworkReply::OperationCanceledError) instead of -999 for the XFrameOptions tests,
              so update accordingly.
      
              https://bugs.webkit.org/show_bug.cgi?id=37382
      
              * platform/qt/Skipped:
              * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added. Qt returns 5 instead of -999.
              * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added. Qt returns 5 instead of -999.
              * platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added. Qt returns 5 instead of -999.
      2010-05-17  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Disable Icon Database by default in Qt DRT
      
              Unskip:
               http/tests/misc/favicon-loads-with-images-disabled.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
               http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
      
              https://bugs.webkit.org/show_bug.cgi?id=37382
      
              Add support for layoutTestController.setIconDatabaseEnabled and layoutTestController.disableImageLoading().
              The XFrameOptions tests were failing because of an extra resource load callback for favicon.ico requests.
              These extra callbacks are removed by supporting both of the above layoutTestContoller commands.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::resetSettings):
              (WebCore::DumpRenderTree::DumpRenderTree):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              (WebCore::DumpRenderTree::drtStoragePath):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::disableImageLoading):
              (LayoutTestController::setIconDatabaseEnabled):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d08c8d81
  16. 10 May, 2010 1 commit
  17. 08 May, 2010 1 commit
    • robert@webkit.org's avatar
      [Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html · bb7851be
      robert@webkit.org authored
      2010-05-08  Robert Hogan  <robert@roberthogan.net>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html
                   and http/tests/xmlhttprequest/cross-origin-authorization.html
      
              QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
              without knowing if this is valid behaviour or not. In order to allow
              Qt to decide whether Cookie/Authorization headers should be added
              to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
              These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
              QNetworkRequest::CookieSaveControlAttribute,and
              QNetworkRequest::AuthenticationReuseControlAttribute.
      
              QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
              unless withCredentials is set to true in the XHR.
      
              QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
              is set to true in the XHR.
      
              Qt will pass the values onto QHttpNetworkRequest and this will permit
              the Qt network access processing to decide whether or not to add either
              or both of the Cookie/Authorisation headers, and whether to save cookies
              returned from such requests. By default the attribute
              will always be true so unless QtWebKit sets it to false normal
              header processing is unaffected.
      
              There are platform-specific results for cross-origin-no-authorization.html:
      
              1. Qt's DRT does not capture the final 'DONE'.
              2. QNetworkReplyHandler.cpp's ignoreHttpError() means that async requests
                 do not execute didFail() when they receive a 401 HTTP response. This
                 results in async tests passing with '401 Authorisation required' rather
                 than 'received error event'.
      
              The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592
      
              In order to properly support the tests, Qt's DRT needs to use one
              NetworkAccessManager for all pages. This allows it to use cached
              credentials where appropriate.
      
              The tests now pass when run individually but there seems to be a problem with
              leaking the results of requests across tests when run with the others in
              http/tests. This will be addressed in a separate patch.
      
              https://bugs.webkit.org/show_bug.cgi?id=32967
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::DumpRenderTree::DumpRenderTree):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * platform/network/qt/ResourceRequestQt.cpp:
              (WebCore::ResourceRequest::toNetworkRequest):
              * platform/qt/Skipped: Group together the tests that are waiting for 4.7 to be unskipped.
              * platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb7851be
  18. 10 Apr, 2010 1 commit
    • eric@webkit.org's avatar
      2010-04-10 Robert Hogan <robert@webkit.org> · 03765508
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Refactor Qt DRT support in QtWebKit
      
              https://bugs.webkit.org/show_bug.cgi?id=35844
      
              * WebCore.pro: Add DumpRenderTreeSupportQt.cpp
      2010-04-10  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Refactor Qt DRT support in QtWebKit
      
              Move all QT DRT support functions to a static class.
      
              https://bugs.webkit.org/show_bug.cgi?id=35844
      
              * Api/qwebframe.cpp: Remove static functions.
              * Api/qwebframe.h: Make DumpRenderTreeSupportQt a friend.
              * Api/qwebpage.cpp: Remove static functions.
              * Api/qwebpage.h: Make DumpRenderTreeSupportQt a friend.
              * Api/qwebsecurityorigin.cpp: Remove static functions.
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp: Added.
              (DumpRenderTreeSupportQt::DumpRenderTreeSupportQt):
              (DumpRenderTreeSupportQt::~DumpRenderTreeSupportQt):
              (DumpRenderTreeSupportQt::overwritePluginDirectories):
              (DumpRenderTreeSupportQt::workerThreadCount):
              (DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled):
              (DumpRenderTreeSupportQt::setFrameFlatteningEnabled):
              (DumpRenderTreeSupportQt::webPageSetGroupName):
              (DumpRenderTreeSupportQt::webPageGroupName):
              (DumpRenderTreeSupportQt::webInspectorExecuteScript):
              (DumpRenderTreeSupportQt::webInspectorClose):
              (DumpRenderTreeSupportQt::webInspectorShow):
              (DumpRenderTreeSupportQt::setTimelineProfilingEnabled):
              (DumpRenderTreeSupportQt::hasDocumentElement):
              (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled):
              (DumpRenderTreeSupportQt::pauseAnimation):
              (DumpRenderTreeSupportQt::pauseTransitionOfProperty):
              (DumpRenderTreeSupportQt::pauseSVGAnimation):
              (DumpRenderTreeSupportQt::numberOfActiveAnimations):
              (DumpRenderTreeSupportQt::clearFrameName):
              (DumpRenderTreeSupportQt::javaScriptObjectsCount):
              (DumpRenderTreeSupportQt::garbageCollectorCollect):
              (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
              (DumpRenderTreeSupportQt::counterValueForElementById):
              (DumpRenderTreeSupportQt::pageNumberForElementById):
              (DumpRenderTreeSupportQt::numberOfPages):
              (DumpRenderTreeSupportQt::suspendActiveDOMObjects):
              (DumpRenderTreeSupportQt::resumeActiveDOMObjects):
              (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
              (DumpRenderTreeSupportQt::whiteListAccessFromOrigin):
              (DumpRenderTreeSupportQt::resetOriginAccessWhiteLists):
              (DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):
              (DumpRenderTreeSupportQt::setCaretBrowsingEnabled):
              (DumpRenderTreeSupportQt::setMediaType):
              (DumpRenderTreeSupportQt::setViewMode):
              * WebCoreSupport/DumpRenderTreeSupportQt.h: Added.
              * WebCoreSupport/EditorClientQt.h:
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::multiplePageGroupsAndLocalStorage):
              (tst_QWebPage::inputMethodsTextFormat):
              (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):
      2010-04-10  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Refactor Qt DRT support in QtWebKit
      
              Update Qt DRT to use new DumpRenderTreeSupportQt static class.
      
              https://bugs.webkit.org/show_bug.cgi?id=35844
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
              (WebCore::DumpRenderTree::dumpFramesAsText):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/GCControllerQt.cpp:
              (GCController::collect):
              (GCController::collectOnAlternateThread):
              (GCController::getJSObjectCount):
              * DumpRenderTree/qt/GCControllerQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::counterValueForElementById):
              (LayoutTestController::setViewModeMediaFeature):
              (LayoutTestController::setMediaType):
              (LayoutTestController::closeWebInspector):
              (LayoutTestController::showWebInspector):
              (LayoutTestController::evaluateInWebInspector):
              (LayoutTestController::setFrameFlatteningEnabled):
              (LayoutTestController::setJavaScriptProfilingEnabled):
              (LayoutTestController::setTimelineProfilingEnabled):
              (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
              (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
              (LayoutTestController::sampleSVGAnimationForElementAtTime):
              (LayoutTestController::numberOfActiveAnimations):
              (LayoutTestController::whiteListAccessFromOrigin):
              (LayoutTestController::setCaretBrowsingEnabled):
              (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
              (LayoutTestController::workerThreadCount):
              (LayoutTestController::pageNumberForElementById):
              (LayoutTestController::numberOfPages):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03765508
  19. 18 Mar, 2010 1 commit
    • eric@webkit.org's avatar
      2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org> · f6a6237c
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Add a new test for testing whether the media type is restores
              properly after printing a page (changing media type to 'print').
      
              Add expected result and skip the test for platform that do not
              implement setMediaType().
      
              * fast/media/print-restores-previous-mediatype-expected.txt: Added.
              * fast/media/print-restores-previous-mediatype.html: Added.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/win/Skipped:
      2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Make setPrinting() with printing=false, restore the previous
              media type in use.
      
              Test: fast/media/print-restores-previous-mediatype.html
      
              * page/Frame.cpp:
              (WebCore::Frame::setPrinting):
              * page/FrameView.cpp:
              (WebCore::FrameView::adjustMediaTypeForPrinting):
              * page/FrameView.h:
      2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Make it possible for the Qt DRT to set the media type from
              the LayoutTestController.
      
              * Api/qwebframe.cpp:
              (qt_drt_setMediaType):
      2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Add a new method to the Qt LayoutTestController for
              changing media type and make the DRT support dry-run printing.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::dryRunPrint):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setMediaType):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6a6237c
  20. 15 Feb, 2010 1 commit
    • eric@webkit.org's avatar
      2010-02-15 Robert Hogan <robert@roberthogan.net> · 70d26c33
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
      
              Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
      
              https://bugs.webkit.org/show_bug.cgi?id=33096
      
              This allows the following tests to pass:
      
              inspector/console-format-collections.html
              inspector/styles-iframe.html
              inspector/syntax-highlight-css.html
              inspector/syntax-highlight-javascript.html
              inspector/timeline-enum-stability.html
              inspector/timeline-layout.html
              inspector/timeline-mark-timeline.html
              inspector/timeline-paint.html
              inspector/timeline-parse-html.html
              inspector/timeline-recalculate-styles.html
              inspector/timeline-script-tag-1.html
              inspector/timeline-script-tag-2.html
              inspector/timeline-trivial.html
              inspector/cookie-resource-match.html
              inspector/elements-img-tooltip.html
              inspector/elements-panel-selection-on-refresh.html
              inspector/inspected-objects-not-overriden.html
              inspector/timeline-event-dispatch.html
              inspector/timeline-network-resource.html
              inspector/elements-panel-rewrite-href.html
              inspector/console-dir.html
              inspector/console-dirxml.html
              inspector/console-format.html
              inspector/console-tests.html
              inspector/elements-panel-structure.html
              inspector/evaluate-in-frontend.html
              inspector/console-clear.html
      
              * platform/qt/Skipped:
      2010-02-15  Robert Hogan  <robert@roberthogan.net>, Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
      
              Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
      
              https://bugs.webkit.org/show_bug.cgi?id=33096
      
              This allows the following tests to pass:
      
              inspector/console-format-collections.html
              inspector/styles-iframe.html
              inspector/syntax-highlight-css.html
              inspector/syntax-highlight-javascript.html
              inspector/timeline-enum-stability.html
              inspector/timeline-layout.html
              inspector/timeline-mark-timeline.html
              inspector/timeline-paint.html
              inspector/timeline-parse-html.html
              inspector/timeline-recalculate-styles.html
              inspector/timeline-script-tag-1.html
              inspector/timeline-script-tag-2.html
              inspector/timeline-trivial.html
              inspector/cookie-resource-match.html
              inspector/elements-img-tooltip.html
              inspector/elements-panel-selection-on-refresh.html
              inspector/inspected-objects-not-overriden.html
              inspector/timeline-event-dispatch.html
              inspector/timeline-network-resource.html
              inspector/elements-panel-rewrite-href.html
              inspector/console-dir.html
              inspector/console-dirxml.html
              inspector/console-format.html
              inspector/console-tests.html
              inspector/elements-panel-structure.html
              inspector/evaluate-in-frontend.html
              inspector/console-clear.html
      
              * Api/qwebpage.cpp:
              (qt_drt_webinspector_executeScript):
              (qt_drt_webinspector_close):
              (qt_drt_webinspector_show):
              (qt_drt_setTimelineProfilingEnabled):
      
              * WebCoreSupport/InspectorClientQt.cpp:
              (InspectorClientQt::createPage)
      2010-02-15  Robert Hogan  <robert@roberthogan.net>
      
              Reviewed by Simon Hausmann.
      
              [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
      
              Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
      
              https://bugs.webkit.org/show_bug.cgi?id=33096
      
              This allows the following tests to pass:
      
              inspector/console-format-collections.html
              inspector/styles-iframe.html
              inspector/syntax-highlight-css.html
              inspector/syntax-highlight-javascript.html
              inspector/timeline-enum-stability.html
              inspector/timeline-layout.html
              inspector/timeline-mark-timeline.html
              inspector/timeline-paint.html
              inspector/timeline-parse-html.html
              inspector/timeline-recalculate-styles.html
              inspector/timeline-script-tag-1.html
              inspector/timeline-script-tag-2.html
              inspector/timeline-trivial.html
              inspector/cookie-resource-match.html
              inspector/elements-img-tooltip.html
              inspector/elements-panel-selection-on-refresh.html
              inspector/inspected-objects-not-overriden.html
              inspector/timeline-event-dispatch.html
              inspector/timeline-network-resource.html
              inspector/elements-panel-rewrite-href.html
              inspector/console-dir.html
              inspector/console-dirxml.html
              inspector/console-format.html
              inspector/console-tests.html
              inspector/elements-panel-structure.html
              inspector/evaluate-in-frontend.html
              inspector/console-clear.html
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
              (WebCore::isWebInspectorTest):
              (WebCore::DumpRenderTree::open):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              (WebCore::DumpRenderTree::display):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::closeWebInspector):
              (LayoutTestController::showWebInspector):
              (LayoutTestController::evaluateInWebInspector):
              (LayoutTestController::setTimelineProfilingEnabled):
              (LayoutTestController::display):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70d26c33
  21. 29 Jan, 2010 1 commit
  22. 28 Jan, 2010 2 commits
  23. 23 Jan, 2010 1 commit
    • eric@webkit.org's avatar
      2010-01-23 Robert Hogan <robert@roberthogan.net> · 2d0be25e
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt DRT: respect window.close() and window.closed()
      
              Qt DRT needs to maintain a correct count of open windows
              for windowCount(). It also needs to delete windows that
              have been closed by window.close().
      
              This fixes the following tests:
      
              plugins/destroy-during-npp-new.html
              fast/dom/Document/early-document-access.html
              fast/dom/Window/window-early-properties.html
              fast/events/open-window-from-another-frame.html
              fast/events/popup-blocking-click-in-iframe.html
      
              https://bugs.webkit.org/show_bug.cgi?id=32953
      
              * platform/qt/Skipped:
      2010-01-23  Robert Hogan  <robert@roberthogan.net>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt DRT: respect window.close() and window.closed()
      
              Qt DRT needs to maintain a correct count of open windows
              for windowCount(). It also needs to delete windows that
              have been closed by window.close().
      
              This fixes the following tests:
      
              plugins/destroy-during-npp-new.html
              fast/dom/Document/early-document-access.html
              fast/dom/Window/window-early-properties.html
              fast/events/open-window-from-another-frame.html
              fast/events/popup-blocking-click-in-iframe.html
      
              https://bugs.webkit.org/show_bug.cgi?id=32953
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::createWindow):
              (WebCore::DumpRenderTree::windowCloseRequested):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::maybeDump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d0be25e
  24. 21 Jan, 2010 2 commits
    • hausmann@webkit.org's avatar
      No review, rolling out 53615 as it causes two · 23a26eed
      hausmann@webkit.org authored
      crashes on the bot.
      
      WebKitTools:
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::DumpRenderTree):
      (WebCore::DumpRenderTree::createWindow):
      * DumpRenderTree/qt/DumpRenderTreeQt.h:
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::maybeDump):
      
      LayoutTests:
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23a26eed
    • eric@webkit.org's avatar
      2010-01-21 Robert Hogan <robert@roberthogan.net> · 4adfee8d
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Qt DRT: respect window.close() and window.closed()
      
              Qt DRT needs to maintain a correct count of open windows
              for windowCount(). It also needs to delete windows that
              have been closed by window.close().
      
              This fixes the following tests:
      
              plugins/destroy-during-npp-new.html
              fast/dom/Document/early-document-access.html
              fast/dom/Window/window-early-properties.html
              fast/events/open-window-from-another-frame.html
              fast/events/popup-blocking-click-in-iframe.html
      
              https://bugs.webkit.org/show_bug.cgi?id=32953
      
              * platform/qt/Skipped:
      2010-01-21  Robert Hogan  <robert@roberthogan.net>
      
              Reviewed by Simon Hausmann.
      
              Qt DRT: respect window.close() and window.closed()
      
              Qt DRT needs to maintain a correct count of open windows
              for windowCount(). It also needs to delete windows that
              have been closed by window.close().
      
              This fixes the following tests:
      
              plugins/destroy-during-npp-new.html
              fast/dom/Document/early-document-access.html
              fast/dom/Window/window-early-properties.html
              fast/events/open-window-from-another-frame.html
              fast/events/popup-blocking-click-in-iframe.html
      
              https://bugs.webkit.org/show_bug.cgi?id=32953
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::createWindow):
              (WebCore::DumpRenderTree::windowCloseRequested):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::maybeDump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4adfee8d
  25. 20 Jan, 2010 2 commits
  26. 29 Dec, 2009 1 commit
    • eric@webkit.org's avatar
      2009-12-29 Robert Hogan <robert@roberthogan.net> · 14a82efe
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Qt] fix fast/dom/Window/window-onFocus.html
              
              Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
              window.onblur was getting dispatched twice from QtWebKit.
              
              https://bugs.webkit.org/show_bug.cgi?id=32990
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::focusOutEvent):
      2009-12-29  Robert Hogan  <robert@roberthogan.net>
      
              Reviewed by Eric Seidel.
      
              [Qt] fix fast/dom/Window/window-onFocus.html
              
              Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
              window.onblur was getting dispatched twice from QtWebKit.
              
              https://bugs.webkit.org/show_bug.cgi?id=32990
      
              * platform/qt/Skipped:
      2009-12-29  Robert Hogan  <robert@roberthogan.net>
      
              Reviewed by Eric Seidel.
      
              [Qt] fix fast/dom/Window/window-onFocus.html
              
              Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
              window.onblur was getting dispatched twice from QtWebKit.
              
              https://bugs.webkit.org/show_bug.cgi?id=32990
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::switchFocus):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setWindowIsKey):
              (LayoutTestController::setMainFrameIsFirstResponder):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14a82efe
  27. 15 Dec, 2009 1 commit
    • ossy@webkit.org's avatar
      [Qt] Rename Qt DRT components to match other ports' naming convention and to... · b82c4ad9
      ossy@webkit.org authored
      [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
      
      Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-15
      Reviewed by Tor Arne Vestbø.
      
      * DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
      * DumpRenderTree/qt/DumpRenderTree.h: Removed.
      * DumpRenderTree/qt/DumpRenderTree.pro: Updated.
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
      * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
      * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
      (GCController::GCController):
      * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      * DumpRenderTree/qt/WorkQueueItem.h: Removed.
      * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
      * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
      * DumpRenderTree/qt/jsobjects.cpp: Removed.
      * DumpRenderTree/qt/jsobjects.h: Removed.
      * DumpRenderTree/qt/main.cpp: Updated includes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b82c4ad9
  28. 04 Dec, 2009 1 commit
    • kenneth@webkit.org's avatar
      Add some missing methods for showing and hiding the · 02644cc6
      kenneth@webkit.org authored
      Web Inspector.
      
      Reviewed by Adam Treat.
      
      * DumpRenderTree/qt/DumpRenderTree.cpp:
      (WebCore::WebPage::WebPage):
      (WebCore::WebPage::~WebPage):
      (WebCore::WebPage::webInspector):
      * DumpRenderTree/qt/DumpRenderTree.h:
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::showWebInspector):
      (LayoutTestController::hideWebInspector):
      * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02644cc6
  29. 03 Dec, 2009 1 commit
  30. 26 Nov, 2009 1 commit
    • zecke@webkit.org's avatar
      [Qt] Add automatic test case for plugins that use QWidget · 87659e2a
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=31203
      
      Change the RenderTreeAsText to look into the WebCore::Widget
      and print the state of the platformWidget. Change the DRT to
      use QtUiTools to be able to initiate QProgressBar and such
      as a plugin. Add the test case, add the result, update the
      other results due the new test.
      
      WebCore:
      * rendering/RenderTreeAsText.cpp:
      (WebCore::operator<<): Add special case for RenderPart
      
      WebKitTools:
      * DumpRenderTree/qt/DumpRenderTree.cpp:
      (WebCore::WebPage::createPlugin):
      * DumpRenderTree/qt/DumpRenderTree.h:
      * DumpRenderTree/qt/DumpRenderTree.pro:
      
      LayoutTest:
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/plugins/netscape-dom-access-expected.txt: Added
      * platform/qt/plugins/qt-qwidget-plugin-expected.txt: Added
      * platform/win/Skipped:
      * plugins/qt-qwidget-plugin.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87659e2a
  31. 22 Nov, 2009 1 commit
  32. 16 Nov, 2009 2 commits
    • kenneth@webkit.org's avatar
      r50942 broke output from created windows. Make the · 31f5183b
      kenneth@webkit.org authored
      m_enableTextOutput a member of the DRT and not the
      WebPage.
      
      Reviewed by Simon Hausmann.
      
      * DumpRenderTree/qt/DumpRenderTree.cpp:
      (WebCore::WebPage::WebPage):
      (WebCore::WebPage::javaScriptAlert):
      (WebCore::WebPage::javaScriptConsoleMessage):
      (WebCore::WebPage::javaScriptConfirm):
      (WebCore::WebPage::javaScriptPrompt):
      (WebCore::WebPage::acceptNavigationRequest):
      (WebCore::DumpRenderTree::DumpRenderTree):
      (WebCore::DumpRenderTree::open):
      (WebCore::DumpRenderTree::createWindow):
      * DumpRenderTree/qt/DumpRenderTree.h:
      (WebCore::DumpRenderTree::setTextOutputEnabled):
      (WebCore::DumpRenderTree::isTextOutputEnabled):
      (WebCore::WebPage::shouldInterruptJavaScript):
      (WebCore::WebPage::isTextOutputEnabled):
      (WebCore::WebPage::setViewGeometry):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31f5183b
    • tonikitoo@webkit.org's avatar
      [Qt] Implement load error pages support for Qt's DRT. · 879ec18f
      tonikitoo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=31509
      
      Reviewed by Kenneth Christiansen.
      
      For now, it will not be a default feature, and layout tests
      that want to make use of this have to explicitily call
      'handleErrorPages();' for the test source.
      
      Any of the other DumpRenderTree's (mac, win and gtk)
      support handling error pages. Qt's will be the first.
      
      * DumpRenderTree/qt/DumpRenderTree.cpp:
      (WebCore::WebPage::supportsExtension):
      (WebCore::WebPage::extension):
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::reset):
      * DumpRenderTree/qt/LayoutTestControllerQt.h:
      (LayoutTestController::shouldHandleErrorPages):
      (LayoutTestController::handleErrorPages):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      879ec18f
  33. 13 Nov, 2009 1 commit
  34. 06 Oct, 2009 1 commit
    • eric@webkit.org's avatar
      2009-10-06 Jakub Wieczorek <faw217@gmail.com> · 132658de
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
              fast/dom/assign-to-window-status.html test, which is passing as a result.
      
              https://bugs.webkit.org/show_bug.cgi?id=30127
      
              * platform/qt/Skipped:
      2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
              fast/dom/assign-to-window-status.html test, which is passing as a result.
      
              https://bugs.webkit.org/show_bug.cgi?id=30127
      
              * DumpRenderTree/qt/DumpRenderTree.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::statusBarMessage):
              * DumpRenderTree/qt/DumpRenderTree.h:
              * DumpRenderTree/qt/jsobjects.h:
              (LayoutTestController::shouldDumpStatusCallbacks):
              (LayoutTestController::dumpStatusCallbacks):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      132658de
  35. 05 Aug, 2009 1 commit
    • kenneth@webkit.org's avatar
      2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org> · dc09fac2
      kenneth@webkit.org authored
              Reviewed by Simon Hausmann.
      
              A minor refactoring of the Qt DRT to be a bit more similar to
              the other DRTs, as well as more understandable.
      
              Splitting up resetJSObjects into a LayoutTestController->reset()
              plus a new closeRemainingWindows() method.
      
              Added a resetToConsistentStateBeforeTesting() method to keep
              the code in one place, making it easier to verify that we are
              doing things properly.
      
              * DumpRenderTree/qt/DumpRenderTree.cpp:
              (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
              (WebCore::DumpRenderTree::open):
              (WebCore::DumpRenderTree::closeRemainingWindows):
              * DumpRenderTree/qt/DumpRenderTree.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc09fac2