1. 10 Dec, 2010 1 commit
    • chang.shu@nokia.com's avatar
      2010-12-10 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com> · eff3dea4
      chang.shu@nokia.com authored
              Reviewed by Joseph Pecoraro.
      
              Bug 43455 - [Qt]: Implement Application Cache Quotas
              https://bugs.webkit.org/show_bug.cgi?id=43455
      
              Added new signal to report ApplicationCache Database
              quota.
      
              * Api/qwebpage.cpp:
              * Api/qwebpage.h:
      
              Added new functions to accomodate new appcache layout
              test origin-quota.html.
      
              * Api/qwebsecurityorigin.cpp:
              (QWebSecurityOrigin::setApplicationCacheQuota):
              * Api/qwebsecurityorigin.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::clearAllApplicationCaches):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
      
              Reviewed by Joseph Pecoraro.
      
              [Qt]: Implement Application Cache Quotas
              https://bugs.webkit.org/show_bug.cgi?id=43455
      
              * platform/qt/Skipped: Unskip now passing test origin-quota.html
      
      2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
      
              Reviewed by Joseph Pecoraro.
      
              Bug 43455 - [Qt]: Implement Application Cache Quotas
              https://bugs.webkit.org/show_bug.cgi?id=43455
      
              Introduce functions to allow new appcache layout test origin-quota.html
              to work correctly under Qt.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
      
              Introduce functions to allow new appcache layout test origin-quota.html
              to be successful under qt. Changes required because LayoutTestControllerQt
              does not inherit from LayoutController.
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::clearAllApplicationCaches):
              (LayoutTestController::setApplicationCacheOriginQuota):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
              (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eff3dea4
  2. 30 Nov, 2010 1 commit
    • vangelis@chromium.org's avatar
      2010-11-29 Vangelis Kokkevis <vangelis@chromium.org> · 1bbe613e
      vangelis@chromium.org authored
              Reviewed by Simon Fraser.
      
              Provide more fine grained control to ports over when to turn on accelerated
              compositing.
              https://bugs.webkit.org/show_bug.cgi?id=49998
      
              As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
              has now been replaced by allowedCompositingTriggers which returns a bitfield of
              all the features which can trigger the compositor.
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::allowedCompositingTriggers):
              * src/ChromeClientImpl.h:
      2010-11-29  Vangelis Kokkevis  <vangelis@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Provide more fine grained control to ports over when to turn on accelerated
              compositing.
              https://bugs.webkit.org/show_bug.cgi?id=49998
      
              As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
              has now been replaced by allowedCompositingTriggers which returns a bitfield of
              all the features which can trigger the compositor.
      
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::allowedCompositingTriggers):
              * WebCoreSupport/ChromeClientQt.h:
      2010-11-30  Vangelis Kokkevis  <vangelis@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Provide more fine grained control to ports over when to turn on 
              accelerated compositing.
              https://bugs.webkit.org/show_bug.cgi?id=49998
      
              The RenderLayerCompositor now checks with the chrome client whether
              3d transforms, video, plugins, canvas and animation require
              switching over to the composited path. Layers that overlap composited
              content will still turn into composited layers regardless of the
              setting.
      
              * css/MediaQueryEvaluator.cpp:
              (WebCore::transform_3dMediaFeatureEval):
              * page/ChromeClient.h:
              (WebCore::ChromeClient::allowedCompositingTriggers):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::canRender3DTransforms):
              (WebCore::RenderLayer::updateTransform):
              (WebCore::RenderLayer::currentTransform):
              * rendering/RenderLayer.h:
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::updateLayerTransform):
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::RenderLayerCompositor):
              (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
              (WebCore::RenderLayerCompositor::canRender3DTransforms):
              (WebCore::RenderLayerCompositor::requiresCompositingLayer):
              (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
              (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
              (WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
              (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
              (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
              * rendering/RenderLayerCompositor.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bbe613e
  3. 25 Nov, 2010 1 commit
  4. 08 Nov, 2010 1 commit
  5. 04 Nov, 2010 1 commit
    • andreas.kling@nokia.com's avatar
      2010-11-04 Kenneth Rohde Christiansen <kenneth@webkit.org> · 9667f50d
      andreas.kling@nokia.com authored
              Reviewed by David Hyatt.
      
              Delegate scrolling via a separate method
              https://bugs.webkit.org/show_bug.cgi?id=48988
      
              Implement delegatedScrollRequested and make it emit the
              scrollRequested signal for Qt.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::delegatedScrollRequested):
              * WebCoreSupport/ChromeClientQt.h:
      2010-11-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
      
              Reviewed by David Hyatt.
      
              Delegate scrolling via a separate method
              https://bugs.webkit.org/show_bug.cgi?id=48988
      
              Add a delegatedScrollRequested method to HostWindow for delegating
              scrolling to the view. This is only used in conjunction with tiling,
              and is ifdef'ed.
      
              * page/Chrome.cpp:
              (WebCore::Chrome::delegatedScrollRequested):
              * page/Chrome.h:
              * page/ChromeClient.h:
              * platform/HostWindow.h:
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::setScrollPosition):
      2010-11-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
      
              Reviewed by David Hyatt.
      
              Delegate scrolling via a separate method
              https://bugs.webkit.org/show_bug.cgi?id=48988
      
              Add delegatedScrollRequested method to WebChromeClient,
              which is only used in conjunging with tiling, and thus ifdef'ed.
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::delegatedScrollRequested):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9667f50d
  6. 25 Oct, 2010 1 commit
    • noam.rosenthal@nokia.com's avatar
      2010-10-25 No'am Rosenthal <noam.rosenthal@nokia.com> · ecdfeac3
      noam.rosenthal@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Texmap] [Qt] Texture mapper initial implementation
              https://bugs.webkit.org/show_bug.cgi?id=47070
      
              Glue layer (WebCoreSupport) changes to allow connecting TextureMapper to a Qt PageClient, i.e.
              a QWebView or a QGraphicsWebView. This enables the new type, TextureMapperPlatformLayer, to be recognized both by
              the compositor and by the page client.
              Note that this is temporarily an opt-in, under USE(TEXTURE_MAPPER)
      
              No new tests: the existing tests under LayoutTests/compositing already cover this.
      
              * platform/graphics/GraphicsLayer.h:
              * platform/qt/QWebPageClient.h:
              (QWebPageClient::setRootGraphicsLayer):
      2010-10-25  No'am Rosenthal  <noam.rosenthal@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Texmap] [Qt] Texture mapper initial implementation
              https://bugs.webkit.org/show_bug.cgi?id=47070
      
              Glue layer (WebCoreSupport) changes to allow connecting TextureMapper to a Qt PageClient, i.e.
              a QWebView or a QGraphicsWebView. This enables the new type, TextureMapperPlatformLayer, to be recognized both by
              the compositor and by the page client.
              Note that this is temporarily an opt-in, under USE(TEXTURE_MAPPER)
      
              * Api/qwebframe.h:
              * Api/qwebframe_p.h:
              (QWebFramePrivate::QWebFramePrivate):
              * Api/qwebpage.cpp:
              (QWebPage::setView):
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::attachRootGraphicsLayer):
              * WebCoreSupport/PageClientQt.cpp:
              (WebCore::PlatformLayerProxyQt::PlatformLayerProxyQt):
              (WebCore::PlatformLayerProxyQt::~PlatformLayerProxyQt):
              (WebCore::PlatformLayerProxyQt::setSizeChanged):
              (WebCore::PlatformLayerProxyQWidget::PlatformLayerProxyQWidget):
              (WebCore::PlatformLayerProxyQWidget::eventFilter):
              (WebCore::PlatformLayerProxyQWidget::setNeedsDisplay):
              (WebCore::PlatformLayerProxyQWidget::setNeedsDisplayInRect):
              (WebCore::PlatformLayerProxyQGraphicsObject::PlatformLayerProxyQGraphicsWidget):
              (WebCore::PlatformLayerProxyQGraphicsObject::setNeedsDisplay):
              (WebCore::PlatformLayerProxyQGraphicsObject::setNeedsDisplayInRect):
              (WebCore::PageClientQWidget::setRootGraphicsLayer):
              (WebCore::PageClientQWidget::markForSync):
              (WebCore::PageClientQWidget::syncLayers):
              (WebCore::PageClientQGraphicsWidget::updateCompositingScrollPosition):
              (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
              (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
              * WebCoreSupport/PageClientQt.h:
              (WebCore::PageClientQWidget::PageClientQWidget):
              (WebCore::PageClientQWidget::allowsAcceleratedCompositing):
              (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecdfeac3
  7. 22 Oct, 2010 1 commit
    • weinig@apple.com's avatar
      WebKit2 needs to pass the current event modifier flags when requesting a new window · 140e06f0
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48140
      
      Reviewed by Anders Carlsson.
      
      WebCore: 
      
      Store the NavigationAction used for the newWindowPolicyDecision in the PolicyCallback
      so that it can be used after the decision has been made in further callbacks.
      
      * WebCore.exp.in: Fix export name for new function signature.
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::createWindow):
      (WebCore::EmptyFrameLoaderClient::dispatchCreatePage):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
      (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
      (WebCore::createWindow):
      * loader/FrameLoader.h:
      * loader/FrameLoaderClient.h:
      * loader/PolicyCallback.cpp:
      (WebCore::PolicyCallback::set):
      (WebCore::PolicyCallback::call):
      (WebCore::PolicyCallback::cancel):
      * loader/PolicyCallback.h:
      * loader/PolicyChecker.cpp:
      (WebCore::PolicyChecker::checkNewWindowPolicy):
      * page/Chrome.cpp:
      (WebCore::Chrome::createWindow):
      * page/Chrome.h:
      * page/ChromeClient.h:
      * page/ContextMenuController.cpp:
      (WebCore::openNewWindow):
      
      WebKit/chromium: 
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::createWindow):
      * src/ChromeClientImpl.h:
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchCreatePage):
      * src/FrameLoaderClientImpl.h:
      Add NavigationAction parameter.
      
      WebKit/efl: 
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::createWindow):
      * WebCoreSupport/ChromeClientEfl.h:
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::dispatchCreatePage):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      Add NavigationAction parameter.
      
      WebKit/gtk: 
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::createWindow):
      * WebCoreSupport/ChromeClientGtk.h:
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchCreatePage):
      * WebCoreSupport/FrameLoaderClientGtk.h:
      Add NavigationAction parameter.
      
      WebKit/haiku: 
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::createWindow):
      * WebCoreSupport/ChromeClientHaiku.h:
      * WebCoreSupport/FrameLoaderClientHaiku.cpp:
      (WebCore::FrameLoaderClientHaiku::dispatchCreatePage):
      * WebCoreSupport/FrameLoaderClientHaiku.h:
      Add NavigationAction parameter.
      
      WebKit/mac: 
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::createWindow):
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchCreatePage):
      Add NavigationAction parameter.
      
      WebKit/qt: 
      
      * Api/qwebpage.cpp:
      (openNewWindow):
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::createWindow):
      * WebCoreSupport/ChromeClientQt.h:
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchCreatePage):
      * WebCoreSupport/FrameLoaderClientQt.h:
      Add NavigationAction parameter.
      
      WebKit/win: 
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::createWindow):
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::dispatchCreatePage):
      * WebCoreSupport/WebFrameLoaderClient.h:
      Add NavigationAction parameter.
      
      WebKit/wince: 
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::createWindow):
      * WebCoreSupport/ChromeClientWinCE.h:
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::dispatchCreatePage):
      * WebCoreSupport/FrameLoaderClientWinCE.h:
      Add NavigationAction parameter.
      
      WebKit/wx: 
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::createWindow):
      * WebKitSupport/ChromeClientWx.h:
      * WebKitSupport/FrameLoaderClientWx.cpp:
      (WebCore::FrameLoaderClientWx::dispatchCreatePage):
      * WebKitSupport/FrameLoaderClientWx.h:
      Add NavigationAction parameter.
      
      WebKit2: 
      
      In addition to passing modifier flags from the now passed NavigationAction, also pass
      the WindowFeatures to the UIProcess.
      
      * Platform/CoreIPC/HandleMessage.h:
      (CoreIPC::callMemberFunction):
      * Shared/WebCoreArgumentCoders.h:
      * Shared/WebEvent.h:
      (WebKit::WebEvent::modifiers):
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::createNewPage):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * UIProcess/WebUIClient.cpp:
      (WebKit::WebUIClient::createNewPage):
      * UIProcess/WebUIClient.h:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::createWindow):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchCreatePage):
      (WebKit::modifiersForNavigationAction):
      (WebKit::mouseButtonForNavigationAction):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      WebKitTools: 
      
      * MiniBrowser/mac/BrowserWindowController.m:
      (createNewPage):
      * WebKitTestRunner/TestController.cpp:
      (WTR::createOtherPage):
      Update for new signature for the WKPageCreateNewPageCallback.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      140e06f0
  8. 05 Oct, 2010 1 commit
  9. 04 Oct, 2010 1 commit
    • luiz@webkit.org's avatar
      2010-09-28 Luiz Agostini <luiz.agostini@openbossa.org> · ced742e1
      luiz@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Viewport data change notifications
              https://bugs.webkit.org/show_bug.cgi?id=46755
      
              Regarding viewport meta tags, what matters for browser developers is to know when the viewport data has
              changed and its current value. Viewport data belongs to the document, but it is useful to keep the current
              viewport data in Page as a reference, to be able to send notifications only when the current viewport
              has changed.
      
              * dom/Document.cpp:
              (WebCore::Document::processViewport):
              (WebCore::Document::setInPageCache):
              * dom/ViewportArguments.h:
              (WebCore::ViewportArguments::operator==):
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::HTMLBodyElement):
              * page/Chrome.cpp:
              (WebCore::Chrome::viewportDataChanged):
              * page/Chrome.h:
              * page/ChromeClient.h:
              (WebCore::ChromeClient::viewportDataChanged):
              * page/Page.cpp:
              (WebCore::Page::updateViewportArguments):
              * page/Page.h:
              (WebCore::Page::viewportArguments):
      2010-09-28  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Viewport data change notifications
              https://bugs.webkit.org/show_bug.cgi?id=46755
      
              Regarding viewport meta tags, what matters for browser developers is to know when the viewport data has
              changed and its current value. Viewport data belongs to the document, but it is useful to keep the current
              viewport data in Page as a reference, to be able to send notifications only when the current viewport
              has changed.
      
              * Api/qwebframe.cpp:
              * Api/qwebframe_p.h:
              * Api/qwebpage.cpp:
              (QWebPagePrivate::viewportArguments):
              (QWebPage::viewportConfigurationForSize):
              * Api/qwebpage_p.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::viewportDataChanged):
              * WebCoreSupport/ChromeClientQt.h:
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::viewportAsText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ced742e1
  10. 24 Sep, 2010 1 commit
    • luiz@webkit.org's avatar
      2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org> · e0514c5b
      luiz@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Keep viewport information in Document
              https://bugs.webkit.org/show_bug.cgi?id=46385
      
              The viewport meta data (layout viewport, scale) needs to be set again when bringing
              back a page from the page cache. As the viewport metadata is only retrieved while parsing
              the document, we need to store it in the Document class.
      
              * fast/viewport/viewport-128-expected.txt: Copied from LayoutTests/fast/viewport/viewport-19-expected.txt.
              * fast/viewport/viewport-128.html: Added.
      2010-09-24  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Keep viewport information in Document
              https://bugs.webkit.org/show_bug.cgi?id=46385
      
              The viewport meta data (layout viewport, scale) needs to be set again when bringing
              back a page from the page cache. As the viewport metadata is only retrieved while parsing
              the document, we need to store it in the Document class.
      
              Test: fast/viewport/viewport-128.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * dom/Document.cpp:
              (WebCore::Document::processViewport):
              (WebCore::Document::setInPageCache):
              * dom/Document.h:
              (WebCore::Document::viewportArguments):
      2010-09-24  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Keep viewport information in Document
              https://bugs.webkit.org/show_bug.cgi?id=46385
      
              The viewport meta data (layout viewport, scale) needs to be set again when bringing
              back a page from the page cache. As the viewport metadata is only retrieved while parsing
              the document, we need to store it in the Document class.
      
              * Api/qwebframe.cpp:
              (QWebFramePrivate::viewportArguments):
              * Api/qwebframe_p.h:
              * Api/qwebpage.cpp:
              (QWebPage::viewportConfigurationForSize):
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::didReceiveViewportArguments):
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::viewportAsText):
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0514c5b
  11. 16 Sep, 2010 2 commits
    • robert@webkit.org's avatar
      2010-09-16 Robert Hogan <robert@webkit.org> · 672b9a50
      robert@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [Qt] Support globalhistory tests
              https://bugs.webkit.org/show_bug.cgi?id=45774
      
              * platform/qt/Skipped:
      2010-09-16  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Antonio Gomes.
      
              [Qt] Support globalhistory tests
              https://bugs.webkit.org/show_bug.cgi?id=45774
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::populateVisitedLinks):
              * WebCoreSupport/ChromeClientQt.h:
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::dumpHistoryCallbacks):
              (DumpRenderTreeSupportQt::dumpVisitedLinksCallbacks):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::setTitle):
              (WebCore::FrameLoaderClientQt::updateGlobalHistory):
              (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
              * WebCoreSupport/FrameLoaderClientQt.h:
      2010-09-16  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Antonio Gomes.
      
              [Qt] Support globalhistory tests
              https://bugs.webkit.org/show_bug.cgi?id=45774
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::isGlobalHistoryTest):
              (WebCore::DumpRenderTree::open):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::dumpHistoryCallbacks):
              (LayoutTestController::removeAllVisitedLinks):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      672b9a50
    • diegohcg@webkit.org's avatar
      2010-09-16 Diego Gonzalez <diegohcg@webkit.org> · 2f41e3ec
      diegohcg@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
              https://bugs.webkit.org/show_bug.cgi?id=42293
      
              * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              (WebCore::MediaPlayerPrivate::commitLoad):
      2010-09-16  Diego Gonzalez  <diegohcg@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
              https://bugs.webkit.org/show_bug.cgi?id=42293
      
              * Api/qwebframe.cpp:
              (QWebFrame::childFrames):
              (QWebFramePrivate::kit):
              * Api/qwebpage.cpp:
              (QWebPage::currentFrame):
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::runJavaScriptAlert):
              (WebCore::ChromeClientQt::runJavaScriptConfirm):
              (WebCore::ChromeClientQt::runJavaScriptPrompt):
              (WebCore::ChromeClientQt::contentsSizeChanged):
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::chooseFile):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f41e3ec
  12. 13 Sep, 2010 1 commit
    • kenneth@webkit.org's avatar
      WebCore: Update support for the viewport meta tag algorithm, to · 8a9df01b
      kenneth@webkit.org authored
      match the following draft spec:
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
      Reviewed by Antti Koivisto.
      
      http://people.opera.com/rune/TR/ED-css-viewport-20100806/
      
      Add common handling of viewport meta tag based on new Opera spec
      https://bugs.webkit.org/show_bug.cgi?id=44201
      
      Tests: fast/viewport/viewport-1.html
             fast/viewport/viewport-10.html
             fast/viewport/viewport-100.html
             fast/viewport/viewport-101.html
             fast/viewport/viewport-102.html
             fast/viewport/viewport-103.html
             fast/viewport/viewport-104.html
             fast/viewport/viewport-105.html
             fast/viewport/viewport-106.html
             fast/viewport/viewport-107.html
             fast/viewport/viewport-108.html
             fast/viewport/viewport-109.html
             fast/viewport/viewport-11.html
             fast/viewport/viewport-110.html
             fast/viewport/viewport-111.html
             fast/viewport/viewport-112.html
             fast/viewport/viewport-113.html
             fast/viewport/viewport-114.html
             fast/viewport/viewport-115.html
             fast/viewport/viewport-116.html
             fast/viewport/viewport-117.html
             fast/viewport/viewport-118.html
             fast/viewport/viewport-119.html
             fast/viewport/viewport-12.html
             fast/viewport/viewport-120.html
             fast/viewport/viewport-121.html
             fast/viewport/viewport-122.html
             fast/viewport/viewport-123.html
             fast/viewport/viewport-124.html
             fast/viewport/viewport-125.html
             fast/viewport/viewport-126.html
             fast/viewport/viewport-127.html
             fast/viewport/viewport-13.html
             fast/viewport/viewport-14.html
             fast/viewport/viewport-15.html
             fast/viewport/viewport-16.html
             fast/viewport/viewport-17.html
             fast/viewport/viewport-18.html
             fast/viewport/viewport-19.html
             fast/viewport/viewport-2.html
             fast/viewport/viewport-20.html
             fast/viewport/viewport-21.html
             fast/viewport/viewport-22.html
             fast/viewport/viewport-23.html
             fast/viewport/viewport-24.html
             fast/viewport/viewport-25.html
             fast/viewport/viewport-26.html
             fast/viewport/viewport-27.html
             fast/viewport/viewport-28.html
             fast/viewport/viewport-29.html
             fast/viewport/viewport-3.html
             fast/viewport/viewport-30.html
             fast/viewport/viewport-31.html
             fast/viewport/viewport-32.html
             fast/viewport/viewport-33.html
             fast/viewport/viewport-34.html
             fast/viewport/viewport-35.html
             fast/viewport/viewport-36.html
             fast/viewport/viewport-37.html
             fast/viewport/viewport-38.html
             fast/viewport/viewport-39.html
             fast/viewport/viewport-4.html
             fast/viewport/viewport-40.html
             fast/viewport/viewport-41.html
             fast/viewport/viewport-42.html
             fast/viewport/viewport-43.html
             fast/viewport/viewport-44.html
             fast/viewport/viewport-45.html
             fast/viewport/viewport-46.html
             fast/viewport/viewport-47.html
             fast/viewport/viewport-48.html
             fast/viewport/viewport-49.html
             fast/viewport/viewport-5.html
             fast/viewport/viewport-50.html
             fast/viewport/viewport-51.html
             fast/viewport/viewport-52.html
             fast/viewport/viewport-53.html
             fast/viewport/viewport-54.html
             fast/viewport/viewport-55.html
             fast/viewport/viewport-56.html
             fast/viewport/viewport-57.html
             fast/viewport/viewport-58.html
             fast/viewport/viewport-59.html
             fast/viewport/viewport-6.html
             fast/viewport/viewport-60.html
             fast/viewport/viewport-61.html
             fast/viewport/viewport-62.html
             fast/viewport/viewport-63.html
             fast/viewport/viewport-64.html
             fast/viewport/viewport-65.html
             fast/viewport/viewport-66.html
             fast/viewport/viewport-67.html
             fast/viewport/viewport-68.html
             fast/viewport/viewport-69.html
             fast/viewport/viewport-7.html
             fast/viewport/viewport-70.html
             fast/viewport/viewport-71.html
             fast/viewport/viewport-72.html
             fast/viewport/viewport-73.html
             fast/viewport/viewport-74.html
             fast/viewport/viewport-75.html
             fast/viewport/viewport-76.html
             fast/viewport/viewport-77.html
             fast/viewport/viewport-78.html
             fast/viewport/viewport-79.html
             fast/viewport/viewport-8.html
             fast/viewport/viewport-80.html
             fast/viewport/viewport-81.html
             fast/viewport/viewport-82.html
             fast/viewport/viewport-83.html
             fast/viewport/viewport-84.html
             fast/viewport/viewport-85.html
             fast/viewport/viewport-86.html
             fast/viewport/viewport-87.html
             fast/viewport/viewport-88.html
             fast/viewport/viewport-9.html
             fast/viewport/viewport-90.html
      
      * dom/ViewportArguments.cpp:
      (WebCore::findConfigurationForViewportData):
      (WebCore::findSizeValue):
      (WebCore::findScaleValue):
      (WebCore::findUserScalableValue):
      (WebCore::findTargetDensityDPIValue):
      (WebCore::setViewportFeature):
      * dom/ViewportArguments.h:
      (WebCore::ViewportArguments::):
      (WebCore::ViewportArguments::ViewportArguments):
      (WebCore::ViewportArguments::hasCustomArgument):
      
      WebKit/qt: Add a Qt API for the viewport meta tag support based on the
      following draft spec:
      
      Reviewed by Antti Koivisto.
      
      http://people.opera.com/rune/TR/ED-css-viewport-20100806/
      
      Add common handling of viewport meta tag based on new Opera spec
      https://bugs.webkit.org/show_bug.cgi?id=44201
      
      * Api/qwebframe_p.h:
      (QWebFramePrivate::QWebFramePrivate):
      * Api/qwebpage.cpp:
      (QWebPage::ViewportConfiguration::ViewportConfiguration):
      (QWebPage::ViewportConfiguration::~ViewportConfiguration):
      (QWebPage::ViewportConfiguration::operator=):
      (QWebPage::viewportConfigurationForSize):
      (QWebPage::setPreferredContentsSize):
      * Api/qwebpage.h:
      * Api/qwebpage_p.h:
      (QtViewportConfigurationPrivate::QtViewportConfigurationPrivate):
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::didReceiveViewportArguments):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::viewportAsText):
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
      
      WebKitTools: Add support for testing the viewport meta tag algorithm,
      based on the following draft spec:
      
      Reviewed by Antti Koivisto.
      
      http://people.opera.com/rune/TR/ED-css-viewport-20100806/
      
      Add common handling of viewport meta tag based on new Opera spec
      https://bugs.webkit.org/show_bug.cgi?id=44201
      
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::dumpConfigurationForViewport):
      * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      LayoutTests: Add tests for the viewport meta tag algorithm and parsing,
      based on a test suite developed by Opera employees
      Rune Lillesveen and Øyvind Stenhaug.
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
      Reviewed by Antti Koivisto.
      
      * fast/viewport/viewport-1-expected.txt: Added.
      * fast/viewport/viewport-1.html: Added.
      * fast/viewport/viewport-10-expected.txt: Added.
      * fast/viewport/viewport-10.html: Added.
      * fast/viewport/viewport-100-expected.txt: Added.
      * fast/viewport/viewport-100.html: Added.
      * fast/viewport/viewport-101-expected.txt: Added.
      * fast/viewport/viewport-101.html: Added.
      * fast/viewport/viewport-102-expected.txt: Added.
      * fast/viewport/viewport-102.html: Added.
      * fast/viewport/viewport-103-expected.txt: Added.
      * fast/viewport/viewport-103.html: Added.
      * fast/viewport/viewport-104-expected.txt: Added.
      * fast/viewport/viewport-104.html: Added.
      * fast/viewport/viewport-105-expected.txt: Added.
      * fast/viewport/viewport-105.html: Added.
      * fast/viewport/viewport-106-expected.txt: Added.
      * fast/viewport/viewport-106.html: Added.
      * fast/viewport/viewport-107-expected.txt: Added.
      * fast/viewport/viewport-107.html: Added.
      * fast/viewport/viewport-108-expected.txt: Added.
      * fast/viewport/viewport-108.html: Added.
      * fast/viewport/viewport-109-expected.txt: Added.
      * fast/viewport/viewport-109.html: Added.
      * fast/viewport/viewport-11-expected.txt: Added.
      * fast/viewport/viewport-11.html: Added.
      * fast/viewport/viewport-110-expected.txt: Added.
      * fast/viewport/viewport-110.html: Added.
      * fast/viewport/viewport-111-expected.txt: Added.
      * fast/viewport/viewport-111.html: Added.
      * fast/viewport/viewport-112-expected.txt: Added.
      * fast/viewport/viewport-112.html: Added.
      * fast/viewport/viewport-113-expected.txt: Added.
      * fast/viewport/viewport-113.html: Added.
      * fast/viewport/viewport-114-expected.txt: Added.
      * fast/viewport/viewport-114.html: Added.
      * fast/viewport/viewport-115-expected.txt: Added.
      * fast/viewport/viewport-115.html: Added.
      * fast/viewport/viewport-116-expected.txt: Added.
      * fast/viewport/viewport-116.html: Added.
      * fast/viewport/viewport-117-expected.txt: Added.
      * fast/viewport/viewport-117.html: Added.
      * fast/viewport/viewport-118-expected.txt: Added.
      * fast/viewport/viewport-118.html: Added.
      * fast/viewport/viewport-119-expected.txt: Added.
      * fast/viewport/viewport-119.html: Added.
      * fast/viewport/viewport-12-expected.txt: Added.
      * fast/viewport/viewport-12.html: Added.
      * fast/viewport/viewport-120-expected.txt: Added.
      * fast/viewport/viewport-120.html: Added.
      * fast/viewport/viewport-121-expected.txt: Added.
      * fast/viewport/viewport-121.html: Added.
      * fast/viewport/viewport-122-expected.txt: Added.
      * fast/viewport/viewport-122.html: Added.
      * fast/viewport/viewport-123-expected.txt: Added.
      * fast/viewport/viewport-123.html: Added.
      * fast/viewport/viewport-124-expected.txt: Added.
      * fast/viewport/viewport-124.html: Added.
      * fast/viewport/viewport-125-expected.txt: Added.
      * fast/viewport/viewport-125.html: Added.
      * fast/viewport/viewport-126.html: Added.
      * fast/viewport/viewport-127.html: Added.
      * fast/viewport/viewport-13-expected.txt: Added.
      * fast/viewport/viewport-13.html: Added.
      * fast/viewport/viewport-14-expected.txt: Added.
      * fast/viewport/viewport-14.html: Added.
      * fast/viewport/viewport-15-expected.txt: Added.
      * fast/viewport/viewport-15.html: Added.
      * fast/viewport/viewport-16-expected.txt: Added.
      * fast/viewport/viewport-16.html: Added.
      * fast/viewport/viewport-17-expected.txt: Added.
      * fast/viewport/viewport-17.html: Added.
      * fast/viewport/viewport-18-expected.txt: Added.
      * fast/viewport/viewport-18.html: Added.
      * fast/viewport/viewport-19-expected.txt: Added.
      * fast/viewport/viewport-19.html: Added.
      * fast/viewport/viewport-2-expected.txt: Added.
      * fast/viewport/viewport-2.html: Added.
      * fast/viewport/viewport-20-expected.txt: Added.
      * fast/viewport/viewport-20.html: Added.
      * fast/viewport/viewport-21-expected.txt: Added.
      * fast/viewport/viewport-21.html: Added.
      * fast/viewport/viewport-22-expected.txt: Added.
      * fast/viewport/viewport-22.html: Added.
      * fast/viewport/viewport-23-expected.txt: Added.
      * fast/viewport/viewport-23.html: Added.
      * fast/viewport/viewport-24-expected.txt: Added.
      * fast/viewport/viewport-24.html: Added.
      * fast/viewport/viewport-25-expected.txt: Added.
      * fast/viewport/viewport-25.html: Added.
      * fast/viewport/viewport-26-expected.txt: Added.
      * fast/viewport/viewport-26.html: Added.
      * fast/viewport/viewport-27-expected.txt: Added.
      * fast/viewport/viewport-27.html: Added.
      * fast/viewport/viewport-28-expected.txt: Added.
      * fast/viewport/viewport-28.html: Added.
      * fast/viewport/viewport-29-expected.txt: Added.
      * fast/viewport/viewport-29.html: Added.
      * fast/viewport/viewport-3-expected.txt: Added.
      * fast/viewport/viewport-3.html: Added.
      * fast/viewport/viewport-30-expected.txt: Added.
      * fast/viewport/viewport-30.html: Added.
      * fast/viewport/viewport-31-expected.txt: Added.
      * fast/viewport/viewport-31.html: Added.
      * fast/viewport/viewport-32-expected.txt: Added.
      * fast/viewport/viewport-32.html: Added.
      * fast/viewport/viewport-33-expected.txt: Added.
      * fast/viewport/viewport-33.html: Added.
      * fast/viewport/viewport-34-expected.txt: Added.
      * fast/viewport/viewport-34.html: Added.
      * fast/viewport/viewport-35-expected.txt: Added.
      * fast/viewport/viewport-35.html: Added.
      * fast/viewport/viewport-36-expected.txt: Added.
      * fast/viewport/viewport-36.html: Added.
      * fast/viewport/viewport-37-expected.txt: Added.
      * fast/viewport/viewport-37.html: Added.
      * fast/viewport/viewport-38-expected.txt: Added.
      * fast/viewport/viewport-38.html: Added.
      * fast/viewport/viewport-39-expected.txt: Added.
      * fast/viewport/viewport-39.html: Added.
      * fast/viewport/viewport-4-expected.txt: Added.
      * fast/viewport/viewport-4.html: Added.
      * fast/viewport/viewport-40-expected.txt: Added.
      * fast/viewport/viewport-40.html: Added.
      * fast/viewport/viewport-41-expected.txt: Added.
      * fast/viewport/viewport-41.html: Added.
      * fast/viewport/viewport-42-expected.txt: Added.
      * fast/viewport/viewport-42.html: Added.
      * fast/viewport/viewport-43-expected.txt: Added.
      * fast/viewport/viewport-43.html: Added.
      * fast/viewport/viewport-44-expected.txt: Added.
      * fast/viewport/viewport-44.html: Added.
      * fast/viewport/viewport-45-expected.txt: Added.
      * fast/viewport/viewport-45.html: Added.
      * fast/viewport/viewport-46-expected.txt: Added.
      * fast/viewport/viewport-46.html: Added.
      * fast/viewport/viewport-47-expected.txt: Added.
      * fast/viewport/viewport-47.html: Added.
      * fast/viewport/viewport-48-expected.txt: Added.
      * fast/viewport/viewport-48.html: Added.
      * fast/viewport/viewport-49-expected.txt: Added.
      * fast/viewport/viewport-49.html: Added.
      * fast/viewport/viewport-5-expected.txt: Added.
      * fast/viewport/viewport-5.html: Added.
      * fast/viewport/viewport-50-expected.txt: Added.
      * fast/viewport/viewport-50.html: Added.
      * fast/viewport/viewport-51-expected.txt: Added.
      * fast/viewport/viewport-51.html: Added.
      * fast/viewport/viewport-52-expected.txt: Added.
      * fast/viewport/viewport-52.html: Added.
      * fast/viewport/viewport-53-expected.txt: Added.
      * fast/viewport/viewport-53.html: Added.
      * fast/viewport/viewport-54-expected.txt: Added.
      * fast/viewport/viewport-54.html: Added.
      * fast/viewport/viewport-55-expected.txt: Added.
      * fast/viewport/viewport-55.html: Added.
      * fast/viewport/viewport-56-expected.txt: Added.
      * fast/viewport/viewport-56.html: Added.
      * fast/viewport/viewport-57-expected.txt: Added.
      * fast/viewport/viewport-57.html: Added.
      * fast/viewport/viewport-58-expected.txt: Added.
      * fast/viewport/viewport-58.html: Added.
      * fast/viewport/viewport-59-expected.txt: Added.
      * fast/viewport/viewport-59.html: Added.
      * fast/viewport/viewport-6-expected.txt: Added.
      * fast/viewport/viewport-6.html: Added.
      * fast/viewport/viewport-60-expected.txt: Added.
      * fast/viewport/viewport-60.html: Added.
      * fast/viewport/viewport-61-expected.txt: Added.
      * fast/viewport/viewport-61.html: Added.
      * fast/viewport/viewport-62-expected.txt: Added.
      * fast/viewport/viewport-62.html: Added.
      * fast/viewport/viewport-63-expected.txt: Added.
      * fast/viewport/viewport-63.html: Added.
      * fast/viewport/viewport-64-expected.txt: Added.
      * fast/viewport/viewport-64.html: Added.
      * fast/viewport/viewport-65.html: Added.
      * fast/viewport/viewport-66-expected.txt: Added.
      * fast/viewport/viewport-66.html: Added.
      * fast/viewport/viewport-67-expected.txt: Added.
      * fast/viewport/viewport-67.html: Added.
      * fast/viewport/viewport-68-expected.txt: Added.
      * fast/viewport/viewport-68.html: Added.
      * fast/viewport/viewport-69-expected.txt: Added.
      * fast/viewport/viewport-69.html: Added.
      * fast/viewport/viewport-7-expected.txt: Added.
      * fast/viewport/viewport-7.html: Added.
      * fast/viewport/viewport-70-expected.txt: Added.
      * fast/viewport/viewport-70.html: Added.
      * fast/viewport/viewport-71-expected.txt: Added.
      * fast/viewport/viewport-71.html: Added.
      * fast/viewport/viewport-72-expected.txt: Added.
      * fast/viewport/viewport-72.html: Added.
      * fast/viewport/viewport-73-expected.txt: Added.
      * fast/viewport/viewport-73.html: Added.
      * fast/viewport/viewport-74-expected.txt: Added.
      * fast/viewport/viewport-74.html: Added.
      * fast/viewport/viewport-75-expected.txt: Added.
      * fast/viewport/viewport-75.html: Added.
      * fast/viewport/viewport-76-expected.txt: Added.
      * fast/viewport/viewport-76.html: Added.
      * fast/viewport/viewport-77-expected.txt: Added.
      * fast/viewport/viewport-77.html: Added.
      * fast/viewport/viewport-78-expected.txt: Added.
      * fast/viewport/viewport-78.html: Added.
      * fast/viewport/viewport-79-expected.txt: Added.
      * fast/viewport/viewport-79.html: Added.
      * fast/viewport/viewport-8-expected.txt: Added.
      * fast/viewport/viewport-8.html: Added.
      * fast/viewport/viewport-80-expected.txt: Added.
      * fast/viewport/viewport-80.html: Added.
      * fast/viewport/viewport-81-expected.txt: Added.
      * fast/viewport/viewport-81.html: Added.
      * fast/viewport/viewport-82.html: Added.
      * fast/viewport/viewport-83-expected.txt: Added.
      * fast/viewport/viewport-83.html: Added.
      * fast/viewport/viewport-84.html: Added.
      * fast/viewport/viewport-85-expected.txt: Added.
      * fast/viewport/viewport-85.html: Added.
      * fast/viewport/viewport-86-expected.txt: Added.
      * fast/viewport/viewport-86.html: Added.
      * fast/viewport/viewport-87.html: Added.
      * fast/viewport/viewport-88-expected.txt: Added.
      * fast/viewport/viewport-88.html: Added.
      * fast/viewport/viewport-9-expected.txt: Added.
      * fast/viewport/viewport-9.html: Added.
      * fast/viewport/viewport-90-expected.txt: Added.
      * fast/viewport/viewport-90.html: Added.
      * platform/gtk/Skipped: Skip tests due to missing DRT support.
      * platform/mac/Skipped: Skip tests due to missing DRT support.
      * platform/win/Skipped: Skip tests due to missing DRT support.
      * platform/qt/Skipped: Skip failing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a9df01b
  13. 05 Sep, 2010 2 commits
  14. 01 Sep, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-09-01 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> · 63ddb60a
      commit-queue@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt] QWebPage::allowGeolocationRequest should be async API
              https://bugs.webkit.org/show_bug.cgi?id=41364
      
              Enable all geolocation delayed permission layout test for Qt port
      
              * platform/qt/Skipped:
      2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] QWebPage::allowGeolocationRequest should be async API
              https://bugs.webkit.org/show_bug.cgi?id=41364
      
              Adding GeolocationPermissionClientQt.cpp/h to build script
      
              * WebCore.pro:
      2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] QWebPage::allowGeolocationRequest should be async API
              https://bugs.webkit.org/show_bug.cgi?id=41364
      
              Provides a new async API for geolocation permission. Using
              Notification API approach from qtwebkit. GeolocationPermissionClientQt
              maintains list of pending requests from WebCore and intimates them
              when client either allowes/denies the request. Also implements
              ChromeClientQt::cancelGeolocationPermissionRequestForFrame.
      
              * Api/qwebpage.cpp:
              (QWebPage::setUserPermission):
              * Api/qwebpage.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
              (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
              * WebCoreSupport/ChromeClientQt.h:
              * WebCoreSupport/GeolocationPermissionClientQt.cpp: Added.
              (WebCore::GeolocationPermissionClientQt::geolocationPermissionClient):
              (WebCore::GeolocationPermissionClientQt::GeolocationPermissionClientQt):
              (WebCore::GeolocationPermissionClientQt::~GeolocationPermissionClientQt):
              (WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
              (WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
              (WebCore::GeolocationPermissionClientQt::setPermission):
              * WebCoreSupport/GeolocationPermissionClientQt.h: Added.
              * tests/qwebpage/tst_qwebpage.cpp:
              (JSTestPage::requestPermission):
              (tst_QWebPage::geolocationRequestJS):
      2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
      
              Reviewed by Laszlo Gombos.
      
              [Qt] QWebPage::allowGeolocationRequest should be async API
              https://bugs.webkit.org/show_bug.cgi?id=41364
      
              Implements new async API for geolocation permission similar to
              Notification. WebPage maintains list of geolocation permission request
              QtWebkit and set's when LayoutTestController gets the access from test JS
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::WebPage::WebPage):
              (WebCore::WebPage::resetSettings):
              (WebCore::WebPage::requestPermission):
              (WebCore::WebPage::cancelPermission):
              (WebCore::WebPage::permissionSet):
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::processLine):
              (WebCore::DumpRenderTree::geolocationPermissionSet):
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::setGeolocationPermission):
              (LayoutTestController::setGeolocationPermissionCommon):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63ddb60a
  15. 27 Aug, 2010 1 commit
  16. 19 Aug, 2010 1 commit
  17. 17 Aug, 2010 1 commit
  18. 06 Aug, 2010 2 commits
    • commit-queue@webkit.org's avatar
      2010-08-06 Luiz Agostini <luiz.agostini@openbossa.org> · 11f86205
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Move Qt's popup menu implementation from WebCore to WebKit layer
              https://bugs.webkit.org/show_bug.cgi?id=43427
      
              After PopupMenu changes in bug 42592 class QtAbstractWebPopup became unecessary and
              there is no need to keep any Qt specific code for popup menus in WebCore/platform/qt.
      
              PopupMenuQt has been moved from WebCore/platform/qt to WebKit/qt/WebCoreSupport and
              assumed the responsibilities of QtAbstractWebPopup. SearchPopupMenuQt has been moved
              to WebKit/qt/WebCoreSupport as well.
      
              All classes that previously inherited from QtAbstractWebPopup now inherit from
              QWebSelectMethod and QtPlatformPlugin's method createSelectInputMethod now returns an
              instance of class QWebSelectMethod instead of QtAbstractWebPopup.
      
              * WebCore.pro:
              * platform/qt/PopupMenuQt.cpp: Removed.
              * platform/qt/PopupMenuQt.h: Removed.
              * platform/qt/QtAbstractWebPopup.cpp: Removed.
              * platform/qt/QtAbstractWebPopup.h: Removed.
              * platform/qt/SearchPopupMenuQt.cpp: Removed.
              * platform/qt/SearchPopupMenuQt.h: Removed.
      2010-08-06  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Move Qt's popup menu implementation from WebCore to WebKit layer
              https://bugs.webkit.org/show_bug.cgi?id=43427
      
              After PopupMenu changes in bug 42592 class QtAbstractWebPopup became unecessary and
              there is no need to keep any Qt specific code for popup menus in WebCore/platform/qt.
      
              PopupMenuQt has been moved from WebCore/platform/qt to WebKit/qt/WebCoreSupport and
              assumed the responsibilities of QtAbstractWebPopup. SearchPopupMenuQt has been moved
              to WebKit/qt/WebCoreSupport as well.
      
              All classes that previously inherited from QtAbstractWebPopup now inherit from
              QWebSelectMethod and QtPlatformPlugin's method createSelectInputMethod now returns an
              instance of class QWebSelectMethod instead of QtAbstractWebPopup.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::createSelectPopup):
              (WebCore::ChromeClientQt::createPopupMenu):
              (WebCore::ChromeClientQt::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientQt.h:
              * WebCoreSupport/PopupMenuQt.cpp: Added.
              (SelectData::SelectData):
              (SelectData::itemText):
              (SelectData::itemToolTip):
              (SelectData::itemIsEnabled):
              (SelectData::itemCount):
              (SelectData::itemIsSelected):
              (SelectData::multiple):
              (SelectData::itemType):
              (WebCore::PopupMenuQt::PopupMenuQt):
              (WebCore::PopupMenuQt::~PopupMenuQt):
              (WebCore::PopupMenuQt::disconnectClient):
              (WebCore::PopupMenuQt::show):
              (WebCore::PopupMenuQt::didHide):
              (WebCore::PopupMenuQt::hide):
              (WebCore::PopupMenuQt::updateFromElement):
              (WebCore::PopupMenuQt::selectItem):
              * WebCoreSupport/PopupMenuQt.h: Added.
              * WebCoreSupport/QtFallbackWebPopup.cpp:
              (WebCore::QtFallbackWebPopupCombo::hidePopup):
              (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
              (WebCore::QtFallbackWebPopup::show):
              (WebCore::QtFallbackWebPopup::populate):
              (WebCore::QtFallbackWebPopup::activeChanged):
              (WebCore::QtFallbackWebPopup::pageClient):
              * WebCoreSupport/QtFallbackWebPopup.h:
              (WebCore::QtFallbackWebPopup::setGeometry):
              (WebCore::QtFallbackWebPopup::geometry):
              (WebCore::QtFallbackWebPopup::setFont):
              (WebCore::QtFallbackWebPopup::font):
              * WebCoreSupport/QtMaemoWebPopup.cpp:
              (WebCore::Maemo5Popup::populateList):
              (WebCore::QtMaemoWebPopup::QtMaemoWebPopup):
              (WebCore::QtMaemoWebPopup::createSingleSelectionPopup):
              (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup):
              (WebCore::QtMaemoWebPopup::createPopup):
              (WebCore::QtMaemoWebPopup::show):
              (WebCore::QtMaemoWebPopup::popupClosed):
              (WebCore::QtMaemoWebPopup::itemClicked):
              (WebCore::Maemo5SingleSelectionPopup::Maemo5SingleSelectionPopup):
              (WebCore::Maemo5MultipleSelectionPopup::Maemo5MultipleSelectionPopup):
              * WebCoreSupport/QtMaemoWebPopup.h:
              (WebCore::Maemo5Popup::Maemo5Popup):
              * WebCoreSupport/QtPlatformPlugin.cpp:
              (WebCore::QtPlatformPlugin::createSelectInputMethod):
              * WebCoreSupport/QtPlatformPlugin.h:
              * WebCoreSupport/SearchPopupMenuQt.cpp: Added.
              (WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
              (WebCore::SearchPopupMenuQt::popupMenu):
              (WebCore::SearchPopupMenuQt::saveRecentSearches):
              (WebCore::SearchPopupMenuQt::loadRecentSearches):
              (WebCore::SearchPopupMenuQt::enabled):
              * WebCoreSupport/SearchPopupMenuQt.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11f86205
    • kenneth@webkit.org's avatar
      2010-08-06 Kenneth Rohde Christiansen <kenneth@webkit.org> · a6fac293
      kenneth@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [Qt] Add support for the Android viewport meta tag extensions.
              http://webkit.org/b/43567
      
              * Api/qwebpage.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::didReceiveViewportArguments):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6fac293
  19. 02 Aug, 2010 2 commits
    • luiz@webkit.org's avatar
      2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> · 260550a6
      luiz@webkit.org authored
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes PopupMenu and SearchPopupMenu have been made pure virtual.
      
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::~PopupMenu):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::~SearchPopupMenu):
      
              Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
              the new pure virtual PopupMenu and SearchPopupMenu.
      
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      
              Chrome and ChromeClient were made responsible for providing instances of classes
              PopupMenu and SearchPopupMenu to its users.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyPopupMenu::show):
              (WebCore::EmptyPopupMenu::hide):
              (WebCore::EmptyPopupMenu::updateFromElement):
              (WebCore::EmptyPopupMenu::disconnectClient):
              (WebCore::EmptySearchPopupMenu::popupMenu):
              (WebCore::EmptySearchPopupMenu::saveRecentSearches):
              (WebCore::EmptySearchPopupMenu::loadRecentSearches):
              (WebCore::EmptySearchPopupMenu::enabled):
              (WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural):
              (WebCore::EmptyChromeClient::createPopupMenu):
              (WebCore::EmptyChromeClient::createSearchPopupMenu):
              * page/Chrome.cpp:
              (WebCore::Chrome::selectItemWritingDirectionIsNatural):
              (WebCore::Chrome::createPopupMenu):
              (WebCore::Chrome::createSearchPopupMenu):
              * page/Chrome.h:
              * page/ChromeClient.h:
      
              Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
              in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
              Each of new the files contain the concrete classes that inherit form PopupMenu or
              SearchPopupMenu and are specific for the corresponding platform.
      
              brew:
      
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenuBrew::PopupMenuBrew):
              (WebCore::PopupMenuBrew::~PopupMenuBrew):
              (WebCore::PopupMenuBrew::disconnectClient):
              (WebCore::PopupMenuBrew::show):
              (WebCore::PopupMenuBrew::hide):
              (WebCore::PopupMenuBrew::updateFromElement):
              * platform/brew/PopupMenuBrew.h: Added.
              (WebCore::PopupMenuBrew::client):
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenuBrew::saveRecentSearches):
              (WebCore::SearchPopupMenuBrew::loadRecentSearches):
              (WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew):
              (WebCore::SearchPopupMenuBrew::enabled):
              (WebCore::SearchPopupMenuBrew::popupMenu):
              * platform/brew/SearchPopupMenuBrew.h: Added.
      
              chromium:
      
              * WebCore.gypi:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenuChromium::PopupMenuChromium):
              (WebCore::PopupMenuChromium::~PopupMenuChromium):
              (WebCore::PopupMenuChromium::show):
              (WebCore::PopupMenuChromium::hide):
              (WebCore::PopupMenuChromium::updateFromElement):
              (WebCore::PopupMenuChromium::disconnectClient):
              * platform/chromium/PopupMenuChromium.h:
              (WebCore::PopupMenuChromium::client):
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium):
              (WebCore::SearchPopupMenuChromium::popupMenu):
              (WebCore::SearchPopupMenuChromium::enabled):
              (WebCore::SearchPopupMenuChromium::saveRecentSearches):
              (WebCore::SearchPopupMenuChromium::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Added.
      
              efl:
      
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenuEfl::PopupMenuEfl):
              (WebCore::PopupMenuEfl::~PopupMenuEfl):
              (WebCore::PopupMenuEfl::show):
              (WebCore::PopupMenuEfl::hide):
              (WebCore::PopupMenuEfl::updateFromElement):
              (WebCore::PopupMenuEfl::disconnectClient):
              * platform/efl/PopupMenuEfl.h: Added.
              (WebCore::PopupMenuEfl::client):
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
              (WebCore::SearchPopupMenuEfl::popupMenu):
              (WebCore::SearchPopupMenuEfl::saveRecentSearches):
              (WebCore::SearchPopupMenuEfl::loadRecentSearches):
              (WebCore::SearchPopupMenuEfl::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Added.
      
              gtk:
      
              * GNUmakefile.am:
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenuGtk::PopupMenuGtk):
              (WebCore::PopupMenuGtk::~PopupMenuGtk):
              (WebCore::PopupMenuGtk::show):
              (WebCore::PopupMenuGtk::hide):
              (WebCore::PopupMenuGtk::updateFromElement):
              (WebCore::PopupMenuGtk::disconnectClient):
              (WebCore::PopupMenuGtk::menuItemActivated):
              (WebCore::PopupMenuGtk::menuUnmapped):
              (WebCore::PopupMenuGtk::menuPositionFunction):
              (WebCore::PopupMenuGtk::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Added.
              (WebCore::PopupMenuGtk::client):
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk):
              (WebCore::SearchPopupMenuGtk::popupMenu):
              (WebCore::SearchPopupMenuGtk::saveRecentSearches):
              (WebCore::SearchPopupMenuGtk::loadRecentSearches):
              (WebCore::SearchPopupMenuGtk::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Added.
      
              haiku:
      
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::HaikuPopup::HaikuPopup):
              (WebCore::HaikuPopup::~HaikuPopup):
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::show):
              (WebCore::PopupMenuHaiku::hide):
              (WebCore::PopupMenuHaiku::updateFromElement):
              * platform/haiku/PopupMenuHaiku.h: Added.
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::client):
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku):
              (WebCore::SearchPopupMenuHaiku::saveRecentSearches):
              (WebCore::SearchPopupMenuHaiku::loadRecentSearches):
              (WebCore::SearchPopupMenuHaiku::enabled):
              (WebCore::SearchPopupMenuHaiku::popupMenu):
              * platform/haiku/SearchPopupMenuHaiku.h: Added.
      
              mac:
      
              * WebCore.exp.in:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/mac/PopupMenuMac.h: Added.
              (WebCore::PopupMenuMac::disconnectClient):
              (WebCore::PopupMenuMac::client):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenuMac::PopupMenuMac):
              (WebCore::PopupMenuMac::~PopupMenuMac):
              (WebCore::PopupMenuMac::clear):
              (WebCore::PopupMenuMac::populate):
              (WebCore::PopupMenuMac::show):
              (WebCore::PopupMenuMac::hide):
              (WebCore::PopupMenuMac::updateFromElement):
              (WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Added.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenuMac::SearchPopupMenuMac):
              (WebCore::SearchPopupMenuMac::popupMenu):
              (WebCore::SearchPopupMenuMac::enabled):
              (WebCore::SearchPopupMenuMac::saveRecentSearches):
              (WebCore::SearchPopupMenuMac::loadRecentSearches):
      
              qt:
      
              * WebCore.pro:
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenuQt::PopupMenuQt):
              (WebCore::PopupMenuQt::~PopupMenuQt):
              (WebCore::PopupMenuQt::disconnectClient):
              (WebCore::PopupMenuQt::show):
              (WebCore::PopupMenuQt::hide):
              (WebCore::PopupMenuQt::updateFromElement):
              * platform/qt/PopupMenuQt.h: Added.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
              (WebCore::SearchPopupMenuQt::popupMenu):
              (WebCore::SearchPopupMenuQt::saveRecentSearches):
              (WebCore::SearchPopupMenuQt::loadRecentSearches):
              (WebCore::SearchPopupMenuQt::enabled):
              * platform/qt/SearchPopupMenuQt.h: Added.
      
              win:
      
              * WebCore.vcproj/WebCore.vcproj:
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenuWin::PopupMenuWin):
              (WebCore::PopupMenuWin::~PopupMenuWin):
              (WebCore::PopupMenuWin::disconnectClient):
              (WebCore::PopupMenuWin::popupClassName):
              (WebCore::PopupMenuWin::show):
              (WebCore::PopupMenuWin::hide):
              (WebCore::PopupMenuWin::calculatePositionAndSize):
              (WebCore::PopupMenuWin::setFocusedIndex):
              (WebCore::PopupMenuWin::visibleItems):
              (WebCore::PopupMenuWin::listIndexAtPoint):
              (WebCore::PopupMenuWin::focusedIndex):
              (WebCore::PopupMenuWin::focusFirst):
              (WebCore::PopupMenuWin::focusLast):
              (WebCore::PopupMenuWin::down):
              (WebCore::PopupMenuWin::up):
              (WebCore::PopupMenuWin::invalidateItem):
              (WebCore::PopupMenuWin::clientRect):
              (WebCore::PopupMenuWin::incrementWheelDelta):
              (WebCore::PopupMenuWin::reduceWheelDelta):
              (WebCore::PopupMenuWin::scrollToRevealSelection):
              (WebCore::PopupMenuWin::updateFromElement):
              (WebCore::PopupMenuWin::paint):
              (WebCore::PopupMenuWin::valueChanged):
              (WebCore::PopupMenuWin::invalidateScrollbarRect):
              (WebCore::PopupMenuWin::registerClass):
              (WebCore::PopupMenuWin::PopupMenuWndProc):
              (WebCore::PopupMenuWin::wndProc):
              * platform/win/PopupMenuWin.h: Added.
              (WebCore::PopupMenuWin::client):
              (WebCore::PopupMenuWin::scrollbar):
              (WebCore::PopupMenuWin::itemHeight):
              (WebCore::PopupMenuWin::windowRect):
              (WebCore::PopupMenuWin::popupHandle):
              (WebCore::PopupMenuWin::setWasClicked):
              (WebCore::PopupMenuWin::wasClicked):
              (WebCore::PopupMenuWin::setScrollOffset):
              (WebCore::PopupMenuWin::scrollOffset):
              (WebCore::PopupMenuWin::wheelDelta):
              (WebCore::PopupMenuWin::scrollbarCapturingMouse):
              (WebCore::PopupMenuWin::setScrollbarCapturingMouse):
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenuWin::SearchPopupMenuWin):
              (WebCore::SearchPopupMenuWin::popupMenu):
              (WebCore::SearchPopupMenuWin::enabled):
              (WebCore::SearchPopupMenuWin::saveRecentSearches):
              (WebCore::SearchPopupMenuWin::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Added.
      
              wx:
      
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenuWx::PopupMenuWx):
              (WebCore::PopupMenuWx::~PopupMenuWx):
              (WebCore::PopupMenuWx::disconnectClient):
              (WebCore::PopupMenuWx::show):
              (WebCore::PopupMenuWx::OnMenuItemSelected):
              (WebCore::PopupMenuWx::hide):
              (WebCore::PopupMenuWx::updateFromElement):
              * platform/wx/PopupMenuWx.h: Added.
              (WebCore::PopupMenuWx::client):
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenuWx::SearchPopupMenuWx):
              (WebCore::SearchPopupMenuWx::saveRecentSearches):
              (WebCore::SearchPopupMenuWx::loadRecentSearches):
              (WebCore::SearchPopupMenuWx::enabled):
              (WebCore::SearchPopupMenuWx::popupMenu):
              * platform/wx/SearchPopupMenuWx.h: Added.
      
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClientImpl::createPopupMenu):
              (WebKit::ChromeClientImpl::createSearchPopupMenu):
              * src/ChromeClientImpl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientEfl::createPopupMenu):
              (WebCore::ChromeClientEfl::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientEfl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClient::createPopupMenu):
              (WebKit::ChromeClient::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientGtk.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              (WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientHaiku::createPopupMenu):
              (WebCore::ChromeClientHaiku::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientQt::createPopupMenu):
              (WebCore::ChromeClientQt::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientQt.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
              * WebCoreSupport/WebChromeClient.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientWx::createPopupMenu):
              (WebCore::ChromeClientWx::createSearchPopupMenu):
              * WebKitSupport/ChromeClientWx.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
              SearchPopupMenu respectively. At this point they are just empty implementations.
      
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added.
              (WebKit::WebPopupMenu::WebPopupMenu):
              (WebKit::WebPopupMenu::~WebPopupMenu):
              (WebKit::WebPopupMenu::disconnectClient):
              (WebKit::WebPopupMenu::show):
              (WebKit::WebPopupMenu::hide):
              (WebKit::WebPopupMenu::updateFromElement):
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added.
              (WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
              (WebKit::WebSearchPopupMenu::popupMenu):
              (WebKit::WebSearchPopupMenu::saveRecentSearches):
              (WebKit::WebSearchPopupMenu::loadRecentSearches):
              (WebKit::WebSearchPopupMenu::enabled):
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::WebChromeClient::createPopupMenu):
              (WebKit::WebChromeClient::createSearchPopupMenu):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      
              build issues:
      
              * WebKit2.xcodeproj/project.pbxproj:
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      260550a6
    • jorlow@chromium.org's avatar
      2010-08-02 Jeremy Orlow <jorlow@chromium.org> · 4409cc88
      jorlow@chromium.org authored
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * loader/EmptyClients.h:
              * page/Chrome.cpp:
              * page/Chrome.h:
              * page/ChromeClient.h:
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::create):
              (WebCore::PopupMenu::disconnectClient):
              (WebCore::PopupMenu::client):
              (WebCore::PopupMenu::scrollbar):
              (WebCore::PopupMenu::itemHeight):
              (WebCore::PopupMenu::windowRect):
              (WebCore::PopupMenu::popupHandle):
              (WebCore::PopupMenu::setWasClicked):
              (WebCore::PopupMenu::wasClicked):
              (WebCore::PopupMenu::setScrollOffset):
              (WebCore::PopupMenu::scrollOffset):
              (WebCore::PopupMenu::wheelDelta):
              (WebCore::PopupMenu::scrollbarCapturingMouse):
              (WebCore::PopupMenu::setScrollbarCapturingMouse):
              (WebCore::PopupMenu::isActive):
              (WebCore::PopupMenu::scrollbarCornerPresent):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::create):
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/brew/PopupMenuBrew.h: Removed.
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              * platform/brew/SearchPopupMenuBrew.h: Removed.
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/chromium/PopupMenuChromium.h:
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Removed.
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/efl/PopupMenuEfl.h: Removed.
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Removed.
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              (WebCore::PopupMenu::menuItemActivated):
              (WebCore::PopupMenu::menuUnmapped):
              (WebCore::PopupMenu::menuPositionFunction):
              (WebCore::PopupMenu::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Removed.
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Removed.
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/haiku/PopupMenuHaiku.h: Removed.
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/haiku/SearchPopupMenuHaiku.h: Removed.
              * platform/mac/PopupMenuMac.h: Removed.
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::clear):
              (WebCore::PopupMenu::populate):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Removed.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/qt/PopupMenuQt.h: Removed.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/qt/SearchPopupMenuQt.h: Removed.
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::popupClassName):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::calculatePositionAndSize):
              (WebCore::PopupMenu::setFocusedIndex):
              (WebCore::PopupMenu::visibleItems):
              (WebCore::PopupMenu::listIndexAtPoint):
              (WebCore::PopupMenu::focusedIndex):
              (WebCore::PopupMenu::focusFirst):
              (WebCore::PopupMenu::focusLast):
              (WebCore::PopupMenu::down):
              (WebCore::PopupMenu::up):
              (WebCore::PopupMenu::invalidateItem):
              (WebCore::PopupMenu::clientRect):
              (WebCore::PopupMenu::incrementWheelDelta):
              (WebCore::PopupMenu::reduceWheelDelta):
              (WebCore::PopupMenu::scrollToRevealSelection):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              (WebCore::PopupMenu::paint):
              (WebCore::PopupMenu::valueChanged):
              (WebCore::PopupMenu::invalidateScrollbarRect):
              (WebCore::PopupMenu::registerClass):
              (WebCore::PopupMenu::PopupMenuWndProc):
              (WebCore::PopupMenu::wndProc):
              * platform/win/PopupMenuWin.h: Removed.
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Removed.
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::OnMenuItemSelected):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/wx/PopupMenuWx.h: Removed.
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/wx/SearchPopupMenuWx.h: Removed.
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * src/ChromeClientImpl.cpp:
              * src/ChromeClientImpl.h:
              * tests/PopupMenuTest.cpp:
              (WebKit::SelectPopupMenuTest::SetUp):
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              * WebCoreSupport/ChromeClientEfl.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              * WebCoreSupport/ChromeClientGtk.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/ChromeClientQt.cpp:
              * WebCoreSupport/ChromeClientQt.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/WebChromeClient.cpp:
              * WebCoreSupport/WebChromeClient.h:
              * WebView.cpp:
              (WebView::mouseWheel):
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebKitSupport/ChromeClientWx.cpp:
              * WebKitSupport/ChromeClientWx.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              * WebProcess/WebCoreSupport/WebChromeClient.h:
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Removed.
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Removed.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Removed.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Removed.
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4409cc88
  20. 31 Jul, 2010 3 commits
    • luiz@webkit.org's avatar
      2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> · 46462155
      luiz@webkit.org authored
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes PopupMenu and SearchPopupMenu have been made pure virtual.
      
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::~PopupMenu):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::~SearchPopupMenu):
      
              Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
              the new pure virtual PopupMenu and SearchPopupMenu.
      
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      
              Chrome and ChromeClient were made responsible for providing instances of classes
              PopupMenu and SearchPopupMenu to its users.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyPopupMenu::show):
              (WebCore::EmptyPopupMenu::hide):
              (WebCore::EmptyPopupMenu::updateFromElement):
              (WebCore::EmptyPopupMenu::disconnectClient):
              (WebCore::EmptySearchPopupMenu::popupMenu):
              (WebCore::EmptySearchPopupMenu::saveRecentSearches):
              (WebCore::EmptySearchPopupMenu::loadRecentSearches):
              (WebCore::EmptySearchPopupMenu::enabled):
              (WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural):
              (WebCore::EmptyChromeClient::createPopupMenu):
              (WebCore::EmptyChromeClient::createSearchPopupMenu):
              * page/Chrome.cpp:
              (WebCore::Chrome::selectItemWritingDirectionIsNatural):
              (WebCore::Chrome::createPopupMenu):
              (WebCore::Chrome::createSearchPopupMenu):
              * page/Chrome.h:
              * page/ChromeClient.h:
      
              Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
              in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
              Each of new the files contain the concrete classes that inherit form PopupMenu or
              SearchPopupMenu and are specific for the corresponding platform.
      
              brew:
      
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenuBrew::PopupMenuBrew):
              (WebCore::PopupMenuBrew::~PopupMenuBrew):
              (WebCore::PopupMenuBrew::disconnectClient):
              (WebCore::PopupMenuBrew::show):
              (WebCore::PopupMenuBrew::hide):
              (WebCore::PopupMenuBrew::updateFromElement):
              * platform/brew/PopupMenuBrew.h: Added.
              (WebCore::PopupMenuBrew::client):
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenuBrew::saveRecentSearches):
              (WebCore::SearchPopupMenuBrew::loadRecentSearches):
              (WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew):
              (WebCore::SearchPopupMenuBrew::enabled):
              (WebCore::SearchPopupMenuBrew::popupMenu):
              * platform/brew/SearchPopupMenuBrew.h: Added.
      
              chromium:
      
              * WebCore.gypi:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenuChromium::PopupMenuChromium):
              (WebCore::PopupMenuChromium::~PopupMenuChromium):
              (WebCore::PopupMenuChromium::show):
              (WebCore::PopupMenuChromium::hide):
              (WebCore::PopupMenuChromium::updateFromElement):
              (WebCore::PopupMenuChromium::disconnectClient):
              * platform/chromium/PopupMenuChromium.h:
              (WebCore::PopupMenuChromium::client):
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium):
              (WebCore::SearchPopupMenuChromium::popupMenu):
              (WebCore::SearchPopupMenuChromium::enabled):
              (WebCore::SearchPopupMenuChromium::saveRecentSearches):
              (WebCore::SearchPopupMenuChromium::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Added.
      
              efl:
      
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenuEfl::PopupMenuEfl):
              (WebCore::PopupMenuEfl::~PopupMenuEfl):
              (WebCore::PopupMenuEfl::show):
              (WebCore::PopupMenuEfl::hide):
              (WebCore::PopupMenuEfl::updateFromElement):
              (WebCore::PopupMenuEfl::disconnectClient):
              * platform/efl/PopupMenuEfl.h: Added.
              (WebCore::PopupMenuEfl::client):
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
              (WebCore::SearchPopupMenuEfl::popupMenu):
              (WebCore::SearchPopupMenuEfl::saveRecentSearches):
              (WebCore::SearchPopupMenuEfl::loadRecentSearches):
              (WebCore::SearchPopupMenuEfl::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Added.
      
              gtk:
      
              * GNUmakefile.am:
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenuGtk::PopupMenuGtk):
              (WebCore::PopupMenuGtk::~PopupMenuGtk):
              (WebCore::PopupMenuGtk::show):
              (WebCore::PopupMenuGtk::hide):
              (WebCore::PopupMenuGtk::updateFromElement):
              (WebCore::PopupMenuGtk::disconnectClient):
              (WebCore::PopupMenuGtk::menuItemActivated):
              (WebCore::PopupMenuGtk::menuUnmapped):
              (WebCore::PopupMenuGtk::menuPositionFunction):
              (WebCore::PopupMenuGtk::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Added.
              (WebCore::PopupMenuGtk::client):
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk):
              (WebCore::SearchPopupMenuGtk::popupMenu):
              (WebCore::SearchPopupMenuGtk::saveRecentSearches):
              (WebCore::SearchPopupMenuGtk::loadRecentSearches):
              (WebCore::SearchPopupMenuGtk::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Added.
      
              haiku:
      
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::HaikuPopup::HaikuPopup):
              (WebCore::HaikuPopup::~HaikuPopup):
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::show):
              (WebCore::PopupMenuHaiku::hide):
              (WebCore::PopupMenuHaiku::updateFromElement):
              * platform/haiku/PopupMenuHaiku.h: Added.
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::client):
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku):
              (WebCore::SearchPopupMenuHaiku::saveRecentSearches):
              (WebCore::SearchPopupMenuHaiku::loadRecentSearches):
              (WebCore::SearchPopupMenuHaiku::enabled):
              (WebCore::SearchPopupMenuHaiku::popupMenu):
              * platform/haiku/SearchPopupMenuHaiku.h: Added.
      
              mac:
      
              * WebCore.exp.in:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/mac/PopupMenuMac.h: Added.
              (WebCore::PopupMenuMac::disconnectClient):
              (WebCore::PopupMenuMac::client):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenuMac::PopupMenuMac):
              (WebCore::PopupMenuMac::~PopupMenuMac):
              (WebCore::PopupMenuMac::clear):
              (WebCore::PopupMenuMac::populate):
              (WebCore::PopupMenuMac::show):
              (WebCore::PopupMenuMac::hide):
              (WebCore::PopupMenuMac::updateFromElement):
              (WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Added.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenuMac::SearchPopupMenuMac):
              (WebCore::SearchPopupMenuMac::popupMenu):
              (WebCore::SearchPopupMenuMac::enabled):
              (WebCore::SearchPopupMenuMac::saveRecentSearches):
              (WebCore::SearchPopupMenuMac::loadRecentSearches):
      
              qt:
      
              * WebCore.pro:
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenuQt::PopupMenuQt):
              (WebCore::PopupMenuQt::~PopupMenuQt):
              (WebCore::PopupMenuQt::disconnectClient):
              (WebCore::PopupMenuQt::show):
              (WebCore::PopupMenuQt::hide):
              (WebCore::PopupMenuQt::updateFromElement):
              * platform/qt/PopupMenuQt.h: Added.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
              (WebCore::SearchPopupMenuQt::popupMenu):
              (WebCore::SearchPopupMenuQt::saveRecentSearches):
              (WebCore::SearchPopupMenuQt::loadRecentSearches):
              (WebCore::SearchPopupMenuQt::enabled):
              * platform/qt/SearchPopupMenuQt.h: Added.
      
              win:
      
              * WebCore.vcproj/WebCore.vcproj:
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenuWin::PopupMenuWin):
              (WebCore::PopupMenuWin::~PopupMenuWin):
              (WebCore::PopupMenuWin::disconnectClient):
              (WebCore::PopupMenuWin::popupClassName):
              (WebCore::PopupMenuWin::show):
              (WebCore::PopupMenuWin::hide):
              (WebCore::PopupMenuWin::calculatePositionAndSize):
              (WebCore::PopupMenuWin::setFocusedIndex):
              (WebCore::PopupMenuWin::visibleItems):
              (WebCore::PopupMenuWin::listIndexAtPoint):
              (WebCore::PopupMenuWin::focusedIndex):
              (WebCore::PopupMenuWin::focusFirst):
              (WebCore::PopupMenuWin::focusLast):
              (WebCore::PopupMenuWin::down):
              (WebCore::PopupMenuWin::up):
              (WebCore::PopupMenuWin::invalidateItem):
              (WebCore::PopupMenuWin::clientRect):
              (WebCore::PopupMenuWin::incrementWheelDelta):
              (WebCore::PopupMenuWin::reduceWheelDelta):
              (WebCore::PopupMenuWin::scrollToRevealSelection):
              (WebCore::PopupMenuWin::updateFromElement):
              (WebCore::PopupMenuWin::paint):
              (WebCore::PopupMenuWin::valueChanged):
              (WebCore::PopupMenuWin::invalidateScrollbarRect):
              (WebCore::PopupMenuWin::registerClass):
              (WebCore::PopupMenuWin::PopupMenuWndProc):
              (WebCore::PopupMenuWin::wndProc):
              * platform/win/PopupMenuWin.h: Added.
              (WebCore::PopupMenuWin::client):
              (WebCore::PopupMenuWin::scrollbar):
              (WebCore::PopupMenuWin::itemHeight):
              (WebCore::PopupMenuWin::windowRect):
              (WebCore::PopupMenuWin::popupHandle):
              (WebCore::PopupMenuWin::setWasClicked):
              (WebCore::PopupMenuWin::wasClicked):
              (WebCore::PopupMenuWin::setScrollOffset):
              (WebCore::PopupMenuWin::scrollOffset):
              (WebCore::PopupMenuWin::wheelDelta):
              (WebCore::PopupMenuWin::scrollbarCapturingMouse):
              (WebCore::PopupMenuWin::setScrollbarCapturingMouse):
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenuWin::SearchPopupMenuWin):
              (WebCore::SearchPopupMenuWin::popupMenu):
              (WebCore::SearchPopupMenuWin::enabled):
              (WebCore::SearchPopupMenuWin::saveRecentSearches):
              (WebCore::SearchPopupMenuWin::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Added.
      
              wx:
      
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenuWx::PopupMenuWx):
              (WebCore::PopupMenuWx::~PopupMenuWx):
              (WebCore::PopupMenuWx::disconnectClient):
              (WebCore::PopupMenuWx::show):
              (WebCore::PopupMenuWx::OnMenuItemSelected):
              (WebCore::PopupMenuWx::hide):
              (WebCore::PopupMenuWx::updateFromElement):
              * platform/wx/PopupMenuWx.h: Added.
              (WebCore::PopupMenuWx::client):
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenuWx::SearchPopupMenuWx):
              (WebCore::SearchPopupMenuWx::saveRecentSearches):
              (WebCore::SearchPopupMenuWx::loadRecentSearches):
              (WebCore::SearchPopupMenuWx::enabled):
              (WebCore::SearchPopupMenuWx::popupMenu):
              * platform/wx/SearchPopupMenuWx.h: Added.
      
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClientImpl::createPopupMenu):
              (WebKit::ChromeClientImpl::createSearchPopupMenu):
              * src/ChromeClientImpl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientEfl::createPopupMenu):
              (WebCore::ChromeClientEfl::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientEfl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClient::createPopupMenu):
              (WebKit::ChromeClient::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientGtk.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              (WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientHaiku::createPopupMenu):
              (WebCore::ChromeClientHaiku::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientQt::createPopupMenu):
              (WebCore::ChromeClientQt::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientQt.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
              * WebCoreSupport/WebChromeClient.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientWx::createPopupMenu):
              (WebCore::ChromeClientWx::createSearchPopupMenu):
              * WebKitSupport/ChromeClientWx.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
              SearchPopupMenu respectively. At this point they are just empty implementations.
      
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added.
              (WebKit::WebPopupMenu::WebPopupMenu):
              (WebKit::WebPopupMenu::~WebPopupMenu):
              (WebKit::WebPopupMenu::disconnectClient):
              (WebKit::WebPopupMenu::show):
              (WebKit::WebPopupMenu::hide):
              (WebKit::WebPopupMenu::updateFromElement):
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added.
              (WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
              (WebKit::WebSearchPopupMenu::popupMenu):
              (WebKit::WebSearchPopupMenu::saveRecentSearches):
              (WebKit::WebSearchPopupMenu::loadRecentSearches):
              (WebKit::WebSearchPopupMenu::enabled):
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::WebChromeClient::createPopupMenu):
              (WebKit::WebChromeClient::createSearchPopupMenu):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      
              build issues:
      
              * WebKit2.xcodeproj/project.pbxproj:
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46462155
    • commit-queue@webkit.org's avatar
      2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com> · 5b1ae2ea
      commit-queue@webkit.org authored
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * loader/EmptyClients.h:
              * page/Chrome.cpp:
              * page/Chrome.h:
              * page/ChromeClient.h:
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::create):
              (WebCore::PopupMenu::disconnectClient):
              (WebCore::PopupMenu::client):
              (WebCore::PopupMenu::scrollbar):
              (WebCore::PopupMenu::itemHeight):
              (WebCore::PopupMenu::windowRect):
              (WebCore::PopupMenu::popupHandle):
              (WebCore::PopupMenu::setWasClicked):
              (WebCore::PopupMenu::wasClicked):
              (WebCore::PopupMenu::setScrollOffset):
              (WebCore::PopupMenu::scrollOffset):
              (WebCore::PopupMenu::wheelDelta):
              (WebCore::PopupMenu::scrollbarCapturingMouse):
              (WebCore::PopupMenu::setScrollbarCapturingMouse):
              (WebCore::PopupMenu::isActive):
              (WebCore::PopupMenu::scrollbarCornerPresent):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::create):
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/brew/PopupMenuBrew.h: Removed.
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              * platform/brew/SearchPopupMenuBrew.h: Removed.
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/chromium/PopupMenuChromium.h:
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Removed.
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/efl/PopupMenuEfl.h: Removed.
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Removed.
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              (WebCore::PopupMenu::menuItemActivated):
              (WebCore::PopupMenu::menuUnmapped):
              (WebCore::PopupMenu::menuPositionFunction):
              (WebCore::PopupMenu::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Removed.
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Removed.
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/haiku/PopupMenuHaiku.h: Removed.
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/haiku/SearchPopupMenuHaiku.h: Removed.
              * platform/mac/PopupMenuMac.h: Removed.
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::clear):
              (WebCore::PopupMenu::populate):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Removed.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/qt/PopupMenuQt.h: Removed.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/qt/SearchPopupMenuQt.h: Removed.
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::popupClassName):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::calculatePositionAndSize):
              (WebCore::PopupMenu::setFocusedIndex):
              (WebCore::PopupMenu::visibleItems):
              (WebCore::PopupMenu::listIndexAtPoint):
              (WebCore::PopupMenu::focusedIndex):
              (WebCore::PopupMenu::focusFirst):
              (WebCore::PopupMenu::focusLast):
              (WebCore::PopupMenu::down):
              (WebCore::PopupMenu::up):
              (WebCore::PopupMenu::invalidateItem):
              (WebCore::PopupMenu::clientRect):
              (WebCore::PopupMenu::incrementWheelDelta):
              (WebCore::PopupMenu::reduceWheelDelta):
              (WebCore::PopupMenu::scrollToRevealSelection):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              (WebCore::PopupMenu::paint):
              (WebCore::PopupMenu::valueChanged):
              (WebCore::PopupMenu::invalidateScrollbarRect):
              (WebCore::PopupMenu::registerClass):
              (WebCore::PopupMenu::PopupMenuWndProc):
              (WebCore::PopupMenu::wndProc):
              * platform/win/PopupMenuWin.h: Removed.
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Removed.
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::OnMenuItemSelected):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/wx/PopupMenuWx.h: Removed.
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/wx/SearchPopupMenuWx.h: Removed.
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * src/ChromeClientImpl.cpp:
              * src/ChromeClientImpl.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              * WebCoreSupport/ChromeClientEfl.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              * WebCoreSupport/ChromeClientGtk.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/ChromeClientQt.cpp:
              * WebCoreSupport/ChromeClientQt.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/WebChromeClient.cpp:
              * WebCoreSupport/WebChromeClient.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebKitSupport/ChromeClientWx.cpp:
              * WebKitSupport/ChromeClientWx.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              * WebProcess/WebCoreSupport/WebChromeClient.h:
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Removed.
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Removed.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Removed.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Removed.
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b1ae2ea
    • luiz@webkit.org's avatar
      2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> · 3f46b6e6
      luiz@webkit.org authored
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes PopupMenu and SearchPopupMenu have been made pure virtual.
      
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::~PopupMenu):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::~SearchPopupMenu):
      
              Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
              the new pure virtual PopupMenu and SearchPopupMenu.
      
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      
              Chrome and ChromeClient were made responsible for providing instances of classes
              PopupMenu and SearchPopupMenu to its users.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyPopupMenu::show):
              (WebCore::EmptyPopupMenu::hide):
              (WebCore::EmptyPopupMenu::updateFromElement):
              (WebCore::EmptyPopupMenu::disconnectClient):
              (WebCore::EmptySearchPopupMenu::popupMenu):
              (WebCore::EmptySearchPopupMenu::saveRecentSearches):
              (WebCore::EmptySearchPopupMenu::loadRecentSearches):
              (WebCore::EmptySearchPopupMenu::enabled):
              (WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural):
              (WebCore::EmptyChromeClient::createPopupMenu):
              (WebCore::EmptyChromeClient::createSearchPopupMenu):
              * page/Chrome.cpp:
              (WebCore::Chrome::selectItemWritingDirectionIsNatural):
              (WebCore::Chrome::createPopupMenu):
              (WebCore::Chrome::createSearchPopupMenu):
              * page/Chrome.h:
              * page/ChromeClient.h:
      
              Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
              in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
              Each of new the files contain the concrete classes that inherit form PopupMenu or
              SearchPopupMenu and are specific for the corresponding platform.
      
              brew:
      
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenuBrew::PopupMenuBrew):
              (WebCore::PopupMenuBrew::~PopupMenuBrew):
              (WebCore::PopupMenuBrew::disconnectClient):
              (WebCore::PopupMenuBrew::show):
              (WebCore::PopupMenuBrew::hide):
              (WebCore::PopupMenuBrew::updateFromElement):
              * platform/brew/PopupMenuBrew.h: Added.
              (WebCore::PopupMenuBrew::client):
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenuBrew::saveRecentSearches):
              (WebCore::SearchPopupMenuBrew::loadRecentSearches):
              (WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew):
              (WebCore::SearchPopupMenuBrew::enabled):
              (WebCore::SearchPopupMenuBrew::popupMenu):
              * platform/brew/SearchPopupMenuBrew.h: Added.
      
              chromium:
      
              * WebCore.gypi:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenuChromium::PopupMenuChromium):
              (WebCore::PopupMenuChromium::~PopupMenuChromium):
              (WebCore::PopupMenuChromium::show):
              (WebCore::PopupMenuChromium::hide):
              (WebCore::PopupMenuChromium::updateFromElement):
              (WebCore::PopupMenuChromium::disconnectClient):
              * platform/chromium/PopupMenuChromium.h:
              (WebCore::PopupMenuChromium::client):
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium):
              (WebCore::SearchPopupMenuChromium::popupMenu):
              (WebCore::SearchPopupMenuChromium::enabled):
              (WebCore::SearchPopupMenuChromium::saveRecentSearches):
              (WebCore::SearchPopupMenuChromium::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Added.
      
              efl:
      
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenuEfl::PopupMenuEfl):
              (WebCore::PopupMenuEfl::~PopupMenuEfl):
              (WebCore::PopupMenuEfl::show):
              (WebCore::PopupMenuEfl::hide):
              (WebCore::PopupMenuEfl::updateFromElement):
              (WebCore::PopupMenuEfl::disconnectClient):
              * platform/efl/PopupMenuEfl.h: Added.
              (WebCore::PopupMenuEfl::client):
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
              (WebCore::SearchPopupMenuEfl::popupMenu):
              (WebCore::SearchPopupMenuEfl::saveRecentSearches):
              (WebCore::SearchPopupMenuEfl::loadRecentSearches):
              (WebCore::SearchPopupMenuEfl::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Added.
      
              gtk:
      
              * GNUmakefile.am:
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenuGtk::PopupMenuGtk):
              (WebCore::PopupMenuGtk::~PopupMenuGtk):
              (WebCore::PopupMenuGtk::show):
              (WebCore::PopupMenuGtk::hide):
              (WebCore::PopupMenuGtk::updateFromElement):
              (WebCore::PopupMenuGtk::disconnectClient):
              (WebCore::PopupMenuGtk::menuItemActivated):
              (WebCore::PopupMenuGtk::menuUnmapped):
              (WebCore::PopupMenuGtk::menuPositionFunction):
              (WebCore::PopupMenuGtk::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Added.
              (WebCore::PopupMenuGtk::client):
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk):
              (WebCore::SearchPopupMenuGtk::popupMenu):
              (WebCore::SearchPopupMenuGtk::saveRecentSearches):
              (WebCore::SearchPopupMenuGtk::loadRecentSearches):
              (WebCore::SearchPopupMenuGtk::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Added.
      
              haiku:
      
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::HaikuPopup::HaikuPopup):
              (WebCore::HaikuPopup::~HaikuPopup):
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::show):
              (WebCore::PopupMenuHaiku::hide):
              (WebCore::PopupMenuHaiku::updateFromElement):
              * platform/haiku/PopupMenuHaiku.h: Added.
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::client):
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku):
              (WebCore::SearchPopupMenuHaiku::saveRecentSearches):
              (WebCore::SearchPopupMenuHaiku::loadRecentSearches):
              (WebCore::SearchPopupMenuHaiku::enabled):
              (WebCore::SearchPopupMenuHaiku::popupMenu):
              * platform/haiku/SearchPopupMenuHaiku.h: Added.
      
              mac:
      
              * WebCore.exp.in:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/mac/PopupMenuMac.h: Added.
              (WebCore::PopupMenuMac::disconnectClient):
              (WebCore::PopupMenuMac::client):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenuMac::PopupMenuMac):
              (WebCore::PopupMenuMac::~PopupMenuMac):
              (WebCore::PopupMenuMac::clear):
              (WebCore::PopupMenuMac::populate):
              (WebCore::PopupMenuMac::show):
              (WebCore::PopupMenuMac::hide):
              (WebCore::PopupMenuMac::updateFromElement):
              (WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Added.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenuMac::SearchPopupMenuMac):
              (WebCore::SearchPopupMenuMac::popupMenu):
              (WebCore::SearchPopupMenuMac::enabled):
              (WebCore::SearchPopupMenuMac::saveRecentSearches):
              (WebCore::SearchPopupMenuMac::loadRecentSearches):
      
              qt:
      
              * WebCore.pro:
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenuQt::PopupMenuQt):
              (WebCore::PopupMenuQt::~PopupMenuQt):
              (WebCore::PopupMenuQt::disconnectClient):
              (WebCore::PopupMenuQt::show):
              (WebCore::PopupMenuQt::hide):
              (WebCore::PopupMenuQt::updateFromElement):
              * platform/qt/PopupMenuQt.h: Added.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
              (WebCore::SearchPopupMenuQt::popupMenu):
              (WebCore::SearchPopupMenuQt::saveRecentSearches):
              (WebCore::SearchPopupMenuQt::loadRecentSearches):
              (WebCore::SearchPopupMenuQt::enabled):
              * platform/qt/SearchPopupMenuQt.h: Added.
      
              win:
      
              * WebCore.vcproj/WebCore.vcproj:
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenuWin::PopupMenuWin):
              (WebCore::PopupMenuWin::~PopupMenuWin):
              (WebCore::PopupMenuWin::disconnectClient):
              (WebCore::PopupMenuWin::popupClassName):
              (WebCore::PopupMenuWin::show):
              (WebCore::PopupMenuWin::hide):
              (WebCore::PopupMenuWin::calculatePositionAndSize):
              (WebCore::PopupMenuWin::setFocusedIndex):
              (WebCore::PopupMenuWin::visibleItems):
              (WebCore::PopupMenuWin::listIndexAtPoint):
              (WebCore::PopupMenuWin::focusedIndex):
              (WebCore::PopupMenuWin::focusFirst):
              (WebCore::PopupMenuWin::focusLast):
              (WebCore::PopupMenuWin::down):
              (WebCore::PopupMenuWin::up):
              (WebCore::PopupMenuWin::invalidateItem):
              (WebCore::PopupMenuWin::clientRect):
              (WebCore::PopupMenuWin::incrementWheelDelta):
              (WebCore::PopupMenuWin::reduceWheelDelta):
              (WebCore::PopupMenuWin::scrollToRevealSelection):
              (WebCore::PopupMenuWin::updateFromElement):
              (WebCore::PopupMenuWin::paint):
              (WebCore::PopupMenuWin::valueChanged):
              (WebCore::PopupMenuWin::invalidateScrollbarRect):
              (WebCore::PopupMenuWin::registerClass):
              (WebCore::PopupMenuWin::PopupMenuWndProc):
              (WebCore::PopupMenuWin::wndProc):
              * platform/win/PopupMenuWin.h: Added.
              (WebCore::PopupMenuWin::client):
              (WebCore::PopupMenuWin::scrollbar):
              (WebCore::PopupMenuWin::itemHeight):
              (WebCore::PopupMenuWin::windowRect):
              (WebCore::PopupMenuWin::popupHandle):
              (WebCore::PopupMenuWin::setWasClicked):
              (WebCore::PopupMenuWin::wasClicked):
              (WebCore::PopupMenuWin::setScrollOffset):
              (WebCore::PopupMenuWin::scrollOffset):
              (WebCore::PopupMenuWin::wheelDelta):
              (WebCore::PopupMenuWin::scrollbarCapturingMouse):
              (WebCore::PopupMenuWin::setScrollbarCapturingMouse):
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenuWin::SearchPopupMenuWin):
              (WebCore::SearchPopupMenuWin::popupMenu):
              (WebCore::SearchPopupMenuWin::enabled):
              (WebCore::SearchPopupMenuWin::saveRecentSearches):
              (WebCore::SearchPopupMenuWin::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Added.
      
              wx:
      
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenuWx::PopupMenuWx):
              (WebCore::PopupMenuWx::~PopupMenuWx):
              (WebCore::PopupMenuWx::disconnectClient):
              (WebCore::PopupMenuWx::show):
              (WebCore::PopupMenuWx::OnMenuItemSelected):
              (WebCore::PopupMenuWx::hide):
              (WebCore::PopupMenuWx::updateFromElement):
              * platform/wx/PopupMenuWx.h: Added.
              (WebCore::PopupMenuWx::client):
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenuWx::SearchPopupMenuWx):
              (WebCore::SearchPopupMenuWx::saveRecentSearches):
              (WebCore::SearchPopupMenuWx::loadRecentSearches):
              (WebCore::SearchPopupMenuWx::enabled):
              (WebCore::SearchPopupMenuWx::popupMenu):
              * platform/wx/SearchPopupMenuWx.h: Added.
      
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClientImpl::createPopupMenu):
              (WebKit::ChromeClientImpl::createSearchPopupMenu):
              * src/ChromeClientImpl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientEfl::createPopupMenu):
              (WebCore::ChromeClientEfl::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientEfl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClient::createPopupMenu):
              (WebKit::ChromeClient::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientGtk.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              (WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientHaiku::createPopupMenu):
              (WebCore::ChromeClientHaiku::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientQt::createPopupMenu):
              (WebCore::ChromeClientQt::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientQt.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
              * WebCoreSupport/WebChromeClient.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientWx::createPopupMenu):
              (WebCore::ChromeClientWx::createSearchPopupMenu):
              * WebKitSupport/ChromeClientWx.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
              SearchPopupMenu respectively. At this point they are just empty implementations.
      
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added.
              (WebKit::WebPopupMenu::WebPopupMenu):
              (WebKit::WebPopupMenu::~WebPopupMenu):
              (WebKit::WebPopupMenu::disconnectClient):
              (WebKit::WebPopupMenu::show):
              (WebKit::WebPopupMenu::hide):
              (WebKit::WebPopupMenu::updateFromElement):
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added.
              (WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
              (WebKit::WebSearchPopupMenu::popupMenu):
              (WebKit::WebSearchPopupMenu::saveRecentSearches):
              (WebKit::WebSearchPopupMenu::loadRecentSearches):
              (WebKit::WebSearchPopupMenu::enabled):
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::WebChromeClient::createPopupMenu):
              (WebKit::WebChromeClient::createSearchPopupMenu):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      
              build issues:
      
              * WebKit2.xcodeproj/project.pbxproj:
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f46b6e6
  21. 30 Jul, 2010 2 commits
    • commit-queue@webkit.org's avatar
      2010-07-30 Luiz Agostini <luiz.agostini@openbossa.org> · dd10dbe8
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Enabling view modes to all platforms
              https://bugs.webkit.org/show_bug.cgi?id=37505
      
              Removing ENABLE_WIDGETS_10_SUPPORT flag.
      
              As view mode media feature is not part of widget 1.0 specification
              any more the ENABLE_WIDGETS_10_SUPPORT flag may be removed. The only use
              of this flag was related to view mode media feature implementation in Qt.
      
              * wtf/Platform.h:
      2010-07-30  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Simon Fraser.
      
              Enabling view modes to all platforms
              https://bugs.webkit.org/show_bug.cgi?id=37505
      
              Removing 'widget' reference from the layout tests because the view mode media feature
              is not part of widget 1.0 specification any more.
      
              The layout tests are stil skipped for all platforms except Qt because of the lack
              of support of LayoutTestController in those platforms.
      
              * fast/media/view-mode-media-feature-expected.txt: Renamed from LayoutTests/fast/media/media-feature-wgt-view-mode-expected.txt.
              * fast/media/view-mode-media-feature.html: Renamed from LayoutTests/fast/media/media-feature-wgt-view-mode.html.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/win/Skipped:
      2010-07-30  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Simon Fraser.
      
              Enabling view modes to all platforms
              https://bugs.webkit.org/show_bug.cgi?id=37505
      
              View mode media feature implementation as specified in http://www.w3.org/TR/view-mode.
      
              The view mode media feature layout tests are stil skipped for all platforms except Qt
              because of the lack of support of LayoutTestController in those platforms.
      
              Test: fast/media/view-mode-media-feature.html
      
              * css/MediaFeatureNames.h:
              * css/MediaQueryEvaluator.cpp:
              (WebCore::view_modeMediaFeatureEval):
              * page/ChromeClient.h:
              * page/Page.cpp:
              (WebCore::Page::Page):
              (WebCore::createViewModesSet):
              (WebCore::Page::setViewMode):
              * page/Page.h:
              (WebCore::Page::viewMode):
      2010-07-30  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Simon Fraser.
      
              Enabling view modes to all platforms
              https://bugs.webkit.org/show_bug.cgi?id=37505
      
              As view mode media feature is now supported by WebCore there is no need
              to keep its implementation here. QtWebKit now uses WebCore's view mode media feature
              implementation.
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::dynamicPropertyChangeEvent):
              * Api/qwebpage_p.h:
              * WebCoreSupport/ChromeClientQt.cpp:
              * WebCoreSupport/ChromeClientQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd10dbe8
    • joepeck@webkit.org's avatar
      2010-07-30 Joseph Pecoraro <joepeck@webkit.org> · 263d1335
      joepeck@webkit.org authored
      Reviewed by David Kilzer.
      
      WebCore:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Part 4 - Client Notification when the Quota is Reached
      
                  Notify the WebKit client when the per-origin quota is reached
                  via a delegate method reachedApplicationCacheOriginQuota.
      
                    Call the delegate method when the quota is reached.
      
                  * loader/appcache/ApplicationCacheGroup.cpp:
                  (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
                  (WebCore::ApplicationCacheGroup::didFinishLoading):
                  (WebCore::ApplicationCacheGroup::didReachOriginQuota):
                  (WebCore::ApplicationCacheGroup::cacheUpdateFailedDueToOriginQuota):
                  (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
                  (WebCore::ApplicationCacheGroup::scheduleReachedOriginQuotaCallback):
                  * loader/appcache/ApplicationCacheGroup.h:
      
                    Some minor refactoring to access more quota information
                    without repeating code. Such as origin usage, and creating
                    an origin record.
      
                  * loader/appcache/ApplicationCacheStorage.cpp:
                  (WebCore::ApplicationCacheStorage::usageForOrigin):
                  (WebCore::ApplicationCacheStorage::storeUpdatedQuotaForOrigin):
                  (WebCore::ApplicationCacheStorage::store):
                  (WebCore::ApplicationCacheStorage::ensureOriginRecord):
                  * loader/appcache/ApplicationCacheStorage.h:
      
                    Boilerplate. Exports and definition of the delegate method.
      
                  * WebCore.OfflineWebApplications.exp:
                  * loader/EmptyClients.h:
                  (WebCore::EmptyChromeClient::reachedApplicationCacheOriginQuota):
                  * page/ChromeClient.h:
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
      WebKit:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
                  * WebKit.xcodeproj/project.pbxproj:
                  * efl/WebCoreSupport/ChromeClientEfl.cpp:
                  (WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):
                  * efl/WebCoreSupport/ChromeClientEfl.h:
      
      WebKit/chromium:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
                  * src/ChromeClientImpl.cpp:
                  (WebKit::ChromeClientImpl::reachedApplicationCacheOriginQuota):
                  * src/ChromeClientImpl.h:
      
      WebKit/gtk:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
                  * WebCoreSupport/ChromeClientGtk.cpp:
                  (WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
                  * WebCoreSupport/ChromeClientGtk.h:
      
      WebKit/haiku:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
                  * WebCoreSupport/ChromeClientHaiku.cpp:
                  (WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):
                  * WebCoreSupport/ChromeClientHaiku.h:
      
      WebKit/mac:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Part 4 - Client Notification when the Quota is Reached
      
                  Notify the WebKit client when the per-origin quota is reached
                  via a delegate method reachedApplicationCacheOriginQuota.
      
                    Refactor the WebSecurityOrigin class to be generic enough to
                    allow quota management of both Databases or Application Caches
                    via subclasses.
      
                  * Storage/WebDatabaseSecurityOrigin.h: Added.
                  * Storage/WebDatabaseSecurityOrigin.mm: Added.
                  (-[WebDatabaseSecurityOrigin quota]):
                  (-[WebDatabaseSecurityOrigin setQuota:]):
                  * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Added.
                  * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Added.
                  (-[WebApplicationCacheSecurityOrigin quota]):
                  (-[WebApplicationCacheSecurityOrigin setQuota:]):
                  * Storage/WebSecurityOrigin.mm: Removed. (Moved to WebCoreSupport)
                  * Storage/WebSecurityOriginPrivate.h: Removed. (Moved to WebCoreSupport)
                  * WebCoreSupport/WebSecurityOrigin.mm: Added.
                  (-[WebSecurityOrigin usage]): to be implemented by subclasses.
                  (-[WebSecurityOrigin quota]): to be implemented by subclasses.
                  (-[WebSecurityOrigin setQuota:]): to be implemented by subclasses.
                  * WebCoreSupport/WebSecurityOriginInternal.h: Renamed from WebKit/mac/Storage/WebSecurityOriginInternal.h.
                  * WebCoreSupport/WebSecurityOriginPrivate.h: Added.
      
                    Turn the notification into a WebUI Delegate to call. Following
                    the example of Databases.
      
                  * DefaultDelegates/WebDefaultUIDelegate.m:
                  (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]):
                  * WebCoreSupport/WebChromeClient.h:
                  * WebCoreSupport/WebChromeClient.mm:
                  (WebChromeClient::exceededDatabaseQuota): use the Databases Security Origin subclass.
                  (WebChromeClient::reachedApplicationCacheOriginQuota): use the Application Cache Security Origin subclass.
                  * WebView/WebUIDelegatePrivate.h:
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
      WebKit/qt:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
                  * WebCoreSupport/ChromeClientQt.cpp:
                  (WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
                  * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
                  * WebCoreSupport/WebChromeClient.cpp:
                  (WebChromeClient::reachedApplicationCacheOriginQuota):
                  * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
                  * WebKitSupport/ChromeClientWx.cpp:
                  (WebCore::ChromeClientWx::reachedApplicationCacheOriginQuota):
                  * WebKitSupport/ChromeClientWx.h:
      
      WebKit2:
      
          2010-07-30  Joseph Pecoraro  <joepeck@webkit.org>
      
                  Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
                  https://bugs.webkit.org/show_bug.cgi?id=40627
      
                  * WebProcess/WebCoreSupport/WebChromeClient.cpp:
                  (WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):
                  * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      263d1335
  22. 14 Jul, 2010 1 commit
    • weinig@apple.com's avatar
      Patch for https://bugs.webkit.org/show_bug.cgi?id=42232 · ee7d0271
      weinig@apple.com authored
      Make changing Cursors work in WebKit2.
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      - Converted Mac and Windows Cursor implementations to lazily
        create the platform cursor.
      - Add HostWindow function to set the cursor and use it from Widget::setCursor.
      - Rework Windows cursor code to use fewer global variables.
      
      * WebCore.exp.in: Updated
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::setCursor): 
      (WebCore::EmptyChromeClient::setLastSetCursorToCurrentCursor):
      Added empty implementations.
      
      * page/Chrome.cpp:
      (WebCore::Chrome::setCursor):
      * page/Chrome.h:
      * page/ChromeClient.h:
      Change existing setCursor() function to take a Cursor instead of a
      PlatformCursorHandle. Added setLastSetCursorToCurrentCursor.
      
      * platform/Cursor.cpp:
      * platform/Cursor.h:
      Added Cursor Type and the option of lazily creating the native cursor
      (used on Mac and Windows for now).
      
      * platform/HostWindow.h:
      Add setCursor.
      
      * platform/mac/CursorMac.mm:
      (WebCore::createCustomCursor): This no longer needs to call determineHotSpot
      as that is done when on construction of the cursor now and the hotSpot passed
      in is correct.
      (WebCore::Cursor::ensurePlatformCursor):
      (WebCore::Cursor::Cursor):
      (WebCore::Cursor::~Cursor):
      (WebCore::Cursor::operator=):
      (WebCore::Cursor::platformCursor):
      Convert to lazily creating the native cursor on the first request and
      storing the type.
      
      * platform/mac/WidgetMac.mm:
      (WebCore::Widget::setCursor):
      Use HostWindow::setCursor to set the cursor. This in turn will call the
      ChromeClient.
      
      * platform/win/CursorWin.cpp:
      (WebCore::createSharedCursor):
      (WebCore::loadSharedCursor):
      (WebCore::loadCursorByName):
      (WebCore::Cursor::ensurePlatformCursor):
      (WebCore::SharedCursor::~SharedCursor):
      (WebCore::Cursor::Cursor):
      (WebCore::Cursor::~Cursor):
      (WebCore::Cursor::operator=):
      (WebCore::Cursor::platformCursor):
      Convert to lazily creating the native cursor on the first request and
      storing the type.
      
      * platform/win/WidgetWin.cpp:
      (WebCore::Widget::setCursor):
      Use HostWindow::setCursor to set the cursor. This in turn will call the
      ChromeClient.
      
      * plugins/win/PluginViewWin.cpp:
      (WebCore::PluginView::handleMouseEvent):
      Use the new setLastSetCursorToCurrentCursor client function to ensure
      the cursor is properly updated when over a plugin.
      
      * platform/chromium/CursorChromium.cpp:
      * platform/efl/CursorEfl.cpp:
      * platform/gtk/CursorGtk.cpp:
      * platform/haiku/CursorHaiku.cpp:
      * platform/wince/CursorWince.cpp:
      * platform/wx/CursorWx.cpp:
      * platform/qt/CursorQt.cpp:
      Change m_impl -> m_platformCursor.
      
      WebKit: 
      
      * efl/WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::setCursor):
      * efl/WebCoreSupport/ChromeClientEfl.h:
      Change prototype to match new one.
      
      WebKit/chromium: 
      
      * src/ChromeClientImpl.h:
      (WebKit::ChromeClientImpl::setCursor):
      Change prototype to match new one.
      
      * src/WebPopupMenuImpl.cpp:
      (WebKit::WebPopupMenuImpl::setCursor):
      * src/WebPopupMenuImpl.h:
      Add empty setCursor function to satisfy the HostWindow interface.
      
      WebKit/gtk: 
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::setCursor):
      * WebCoreSupport/ChromeClientGtk.h:
      Change prototype to match new one.
      
      WebKit/haiku: 
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::setCursor):
      * WebCoreSupport/ChromeClientHaiku.h:
      Change prototype to match new one.
      
      WebKit/mac: 
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::setCursor):
      * WebView/WebView.mm:
      Implement cursor changing at the WebKit level for the sake of WebKit2.
      This functionality is being moved from WidgetMac.mm.
      (+[WebView _pointingHandCursor]):
      Update to use platformCursor() instead of impl().
      
      WebKit/qt: 
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::setCursor):
      * WebCoreSupport/ChromeClientQt.h:
      Change prototype to match new one.
      
      WebKit/win: 
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::setCursor):
      We now need to grab the native cursor out of the WebCore cursor.
      
      (WebChromeClient::setLastSetCursorToCurrentCursor):
      Sets the WebView's "last set cursor" to be the current cursor so that
      the cursor is set correctly for plugins.
      * WebCoreSupport/WebChromeClient.h:
      * WebView.cpp:
      (WebView::WebView):
      (WebView::WebViewWndProc):
      * WebView.h:
      (WebView::setLastCursor):
      Change the "last set cursor" to be stored as a member instead of a global.
      
      WebKit/wx: 
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::setCursor):
      * WebKitSupport/ChromeClientWx.h:
      Change prototype to match new one.
      
      WebKit2: 
      
      * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
      Add SetCursor message.
      
      * Shared/WebCoreArgumentCoders.h:
      Add encoding/decoding of Cursors. For now we don't support Custom
      cursors.
      
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::setCursor):
      * UIProcess/PageClient.h:
      Add pass through functions to get the cursor from the WebPageProxy
      to the WKView.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _setCursor:]):
      * UIProcess/API/mac/WKViewInternal.h:
      Implement changing the cursor.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didReceiveMessage):
      (WebKit::WebPageProxy::setCursor):
      * UIProcess/WebPageProxy.h:
      Decode the cursor.
      
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::wndProc):
      (WebKit::WebView::WebView):
      (WebKit::WebView::onSetCursor):
      (WebKit::WebView::setCursor):
      * UIProcess/win/WebView.h:
      Implement changing the cursor.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::setCursor):
      (WebKit::WebChromeClient::setLastSetCursorToCurrentCursor):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      Encode the cursor when setCursor is called.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee7d0271
  23. 22 Jun, 2010 1 commit
  24. 17 Jun, 2010 1 commit
    • jesus@webkit.org's avatar
      Add viewport meta tag support to QtWebKit API layer · 640b6b2f
      jesus@webkit.org authored
      [Qt] QtWebKit does not support viewport meta tag
      https://bugs.webkit.org/show_bug.cgi?id=39902
      
      Patch by Jesus Sanchez-Palencia  <jesus@webkit.org>, Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-06-01
      Reviewed by Simon Hausmann.
      
      WebCore:
      
      Add windowRect() to page client.
      
      * platform/qt/QWebPageClient.h:
      
      WebKit/qt:
      
      This implements didReceiveViewportArguments in our ChromeClientQt
      which is hooked up with QWebPage::viewportChangeRequested().
      This signal does not affect the current default behavior.
      The documentation of the signal explains how to make use of this new feature.
      
      * Api/qwebframe_p.h:
      (QWebFramePrivate::QWebFramePrivate):
      Store information about whether the page has been laid out or not.
      * Api/qwebpage.cpp:
      (QWebPage::viewportChangeRequested):
      * Api/qwebpage_p.h:
      Added class QtViewportHintsPrivate.
      * Api/qwebpage.h:
      (QWebPage::setPreferredContentsSize):
      Improved documentation and now only layout if the page had already
      passed layout phase.
      Added class QWebPage::ViewportHints.
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::windowRect):
      Modified to work as intended by the DOM, for both QWebView
      and QGraphicsWebView.
      (WebCore::ChromeClientQt::didReceiveViewportArguments):
      Emits the signal QWebPage::viewportChangeRequested.
      * WebCoreSupport/ChromeClientQt.h:
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
      Update information about whether the page has been laid out or not.
      If the page has been laid out we ignore any further viewport meta data.
      * WebCoreSupport/PageClientQt.cpp:
      (WebCore::PageClientQWidget::windowRect):
      (WebCore::PageClientQGraphicsWidget::windowRect):
      (WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):
      * WebCoreSupport/PageClientQt.h:
      The PageClient is now responsible for providing the right window rect.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      640b6b2f
  25. 14 Jun, 2010 1 commit
    • ossy@webkit.org's avatar
      [Qt] navigator.geolocation support for Qt port · 2880b949
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39724
      
      Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-06-14
      Reviewed by Laszlo Gombos.
      
      WebCore: 
      
      Implemetion for Qt port of navigator.gelocation. Using qtmobility location service.
      
      * WebCore.pri:
      * WebCore.pro:
      * platform/qt/GeolocationServiceQt.cpp: Added.
      (WebCore::GeolocationServiceQt::create):
      (WebCore::GeolocationServiceQt::GeolocationServiceQt):
      (WebCore::GeolocationServiceQt::~GeolocationServiceQt):
      (WebCore::GeolocationServiceQt::positionUpdated):
      (WebCore::GeolocationServiceQt::startUpdating):
      (WebCore::GeolocationServiceQt::stopUpdating):
      * platform/qt/GeolocationServiceQt.h: Added.
      (WebCore::GeolocationServiceQt::lastPosition):
      (WebCore::GeolocationServiceQt::lastError):
      
      WebKit/qt: 
      
      Implement ChromeClientQt::requestGeolocationPermissionForFrame() which delegates call to QWebPage::allowGeolocationRequest
      Layout and unit test cases for the are also added. 
      
      * Api/qwebpage.cpp:
      (QWebPage::allowGeolocationRequest):
      * Api/qwebpage.h:
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setMockGeolocationPosition):
      (DumpRenderTreeSupportQt::setMockGeolocationError):
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      * tests/qwebpage/tst_qwebpage.cpp:
      (JSTestPage::shouldInterruptJavaScript):
      (JSTestPage::allowGeolocationRequest):
      (JSTestPage::setGeolocationPermission):
      (tst_QWebPage::geolocationRequestJS):
      
      WebKitTools: 
      
      Implementation for geolocation cases to DumpRenderTreeQt
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::WebPage::allowGeolocationRequest):
      * DumpRenderTree/qt/DumpRenderTreeQt.h:
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::setGeolocationPermission):
      (LayoutTestController::setMockGeolocationError):
      (LayoutTestController::setMockGeolocationPosition):
      * DumpRenderTree/qt/LayoutTestControllerQt.h:
      (LayoutTestController::isGeolocationPermissionSet):
      (LayoutTestController::geolocationPermission):
      
      LayoutTests: 
      
      Uncommenting gelocation cases from Qt. Skipped one case: fast/dom/Geolocation/callback-to-remote-context2.html
      
      * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2880b949
  26. 09 Jun, 2010 1 commit
  27. 02 Jun, 2010 1 commit
    • yael.aharon@nokia.com's avatar
      [Qt] Fix the lifecycle of notification objects · bdc54d7f
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=40003
      
      Reviewed by Kenneth Rohde Christiansen.
      
      WebKit/qt: 
      
      Notification objects are not tightly related to the page that created them,
      and should be decoupled from the page.
      Create one NotificationPresenter that handles all notifications.
      Add ref/deref to the notification objects when they are added/removed from
      the queue of active notifications. The same technique is used for XMLHttpRequest.
      Instead of deleting all notifications associated with a page when the page is navigated,
      delete them on a timer, using the same timeout that QSystemTrayIcon is using.
      Break up the show() method into smaller methods.
      Use OwnPtr instead of raw pointer for QSystemTrayIcon.
      Move creating the QIcon to just before showing it in the QSyetemTrayIcon.
      
      No new tests as this is just a refactoring. Existing notifications test cover the code.
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::QWebPagePrivate):
      (QWebPagePrivate::~QWebPagePrivate):
      * Api/qwebpage_p.h:
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::notificationPresenter):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setNotificationsReceiver):
      (DumpRenderTreeSupportQt::allowNotificationForOrigin):
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::notificationPresenter):
      (WebCore::NotificationIconWrapper::NotificationIconWrapper):
      (WebCore::NotificationIconWrapper::~NotificationIconWrapper):
      (WebCore::NotificationIconWrapper::close):
      (WebCore::NotificationPresenterClientQt::NotificationPresenterClientQt):
      (WebCore::NotificationPresenterClientQt::removeClient):
      (WebCore::NotificationPresenterClientQt::show):
      (WebCore::NotificationPresenterClientQt::displayNotification):
      (WebCore::NotificationPresenterClientQt::cancel):
      (WebCore::NotificationPresenterClientQt::notificationObjectDestroyed):
      (WebCore::NotificationPresenterClientQt::requestPermission):
      (WebCore::NotificationPresenterClientQt::sendEvent):
      (WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
      (WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
      (WebCore::NotificationPresenterClientQt::dumpShowText):
      * WebCoreSupport/NotificationPresenterClientQt.h:
      (WebCore::NotificationPresenterClientQt::addClient):
      
      WebKitTools: 
      
      Remove the dependency of notifications on QWebPage.
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::requestPermissionCallback):
      (WebCore::WebPage::WebPage):
      (WebCore::DumpRenderTree::requestPermission):
      * DumpRenderTree/qt/DumpRenderTreeQt.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdc54d7f
  28. 19 May, 2010 1 commit
  29. 17 May, 2010 2 commits
    • eric@webkit.org's avatar
      2010-05-17 Tasuku Suzuki <tasuku.suzuki@nokia.com> · 6f51309e
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Fix compilation with QT_NO_COMBOBOX
              https://bugs.webkit.org/show_bug.cgi?id=38324
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::createSelectPopup):
              * WebCoreSupport/QtFallbackWebPopup.cpp:
              * WebCoreSupport/QtFallbackWebPopup.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f51309e
    • antti.j.koivisto@nokia.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=39218 · 0087a4d1
      antti.j.koivisto@nokia.com authored
      [Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation
              
      Reviewed by Kenneth Rohde Christiansen.
      
      WebCore: 
      
      Tiles sometimes flicker when exiting a zoom animation. This happens as a result
      of the visible rectangle being momentarily out of sync.
              
      Instead of updating the visible rect by explicitly setting it, pull it through
      the client and recompute in the WebKit level.
      
      * page/ChromeClient.h:
      (WebCore::ChromeClient::visibleRectForTiledBackingStore):
      * page/Frame.cpp:
      (WebCore::Frame::tiledBackingStoreVisibleRect):
      * page/Frame.h:
      * platform/graphics/TiledBackingStore.cpp:
      (WebCore::TiledBackingStore::checkVisibleRectChanged):
      (WebCore::TiledBackingStore::createTiles):
      * platform/graphics/TiledBackingStore.h:
      * platform/graphics/TiledBackingStoreClient.h:
      
      WebKit/qt: 
      
      Tiles sometimes flicker when exiting a zoom animation. This happens as a result
      of the visible rectangle being momentarily out of sync.
              
      Instead of updating the visible rect by explicitly setting it, pull it through
      the client and recompute in WebKit the level.
      
      * Api/qgraphicswebview.cpp:
      (QGraphicsWebView::paint):
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::visibleRectForTiledBackingStore):
      * WebCoreSupport/ChromeClientQt.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0087a4d1
  30. 08 May, 2010 1 commit
    • eric@webkit.org's avatar
      2010-05-08 Luiz Agostini <luiz.agostini@openbossa.org> · fbf80da4
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Platform plugin
              https://bugs.webkit.org/show_bug.cgi?id=38438
      
              Select popups delegate private API. To provide select popup delegates
              a plugin that implements QWebKitPlatformPlugin must be found
              in QCoreApplication::libraryPaths.
      
              * WebCore.pro:
      2010-05-08  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Platform plugin
              https://bugs.webkit.org/show_bug.cgi?id=38438
      
              Select popups delegate private API. To provide select popup delegates
              a plugin that implements QWebKitPlatformPlugin must be found
              in QCoreApplication::libraryPaths.
      
              * Api/headers.pri:
              * Api/qwebkitplatformplugin.h: Added.
              (QWebSelectData::~QWebSelectData):
              (QWebSelectData::):
              (QWebSelectMethod::~QWebSelectMethod):
              (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
              (QWebKitPlatformPlugin::):
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::createSelectPopup):
              * WebCoreSupport/ChromeClientQt.h:
              * WebCoreSupport/QtPlatformPlugin.cpp: Added.
              (WebCore::SelectData::SelectData):
              (WebCore::SelectData::itemText):
              (WebCore::SelectData::itemToolTip):
              (WebCore::SelectData::itemIsEnabled):
              (WebCore::SelectData::itemCount):
              (WebCore::SelectData::itemIsSelected):
              (WebCore::SelectData::multiple):
              (WebCore::SelectData::itemType):
              (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper):
              (WebCore::SelectInputMethodWrapper::show):
              (WebCore::SelectInputMethodWrapper::hide):
              (WebCore::SelectInputMethodWrapper::selectItem):
              (WebCore::SelectInputMethodWrapper::didHide):
              (WebCore::getPluginObject):
              (WebCore::QtPlatformPlugin::~QtPlatformPlugin):
              (WebCore::QtPlatformPlugin::plugin):
              (WebCore::QtPlatformPlugin::createSelectInputMethod):
              * WebCoreSupport/QtPlatformPlugin.h: Added.
              (WebCore::QtPlatformPlugin::QtPlatformPlugin):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbf80da4
  31. 29 Apr, 2010 1 commit
  32. 21 Apr, 2010 1 commit