1. 04 Dec, 2008 1 commit
    • ap@webkit.org's avatar
      2008-12-03 Dmitry Titov <dimich@chromium.org> · efccd59c
      ap@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Using ActiveDOMObject as base class for DOMTimer.
              https://bugs.webkit.org/show_bug.cgi?id=22620
      
              Using ActiveDOMObject simplifies the code because ActiveDOMObject
              is wired for stop/pause/resume on loading/unloading/caching the page etc
              so the timer-specific code that does the same can be removed.
              In addition, timers can be now paused/resumed 'in place' which
              makes it unnecessary to 'serialize' them into special PausedTimeouts
              instance, so pause/resumeTimeouts implementation in JSDOMWindowBase can also be removed.
              Also, moving TimeoutMap from JSDOMWindowBase to Document matches lifetime
              of timeouts and makes it possible to not roundtrip them via PausedTimeouts 
              every time when JSDOMWindow wrapper is destroyed while the page is in the b/f cache.
      
              Timeouts are now paused with other ActiveDOMObjects:
              - before creating CachedPage in FrameLoader::commitProvisionalLoad()
              - in JavaScriptDebugServer::setJavaScriptPaused
              - during modal UI operations in Chrome::*
              this is equivalent to previous usage of JSDOMWindowBase::pauseTimeouts()
      
              Timeouts are stopped to prevent future firing from:
              - FrameLoader::clear()
              - FrameLoader::frameDetached()
              this is equivalent to previous usage of JSDOMWindowBase::clearAllTimeouts()
      
              This is also one of the steps to having timers in Workers. See the plan of
              the next steps in the bug above.
      
              * bindings/js/DOMTimer.cpp:
              (WebCore::DOMTimer::DOMTimer):
              (WebCore::DOMTimer::fired):
              (WebCore::DOMTimer::hasPendingActivity):
              (WebCore::DOMTimer::contextDestroyed):
              (WebCore::DOMTimer::stop):
              (WebCore::DOMTimer::suspend):
              (WebCore::DOMTimer::resume):
              (WebCore::DOMTimer::canSuspend): Implemented ActiveDOMObject methods.
      
              * bindings/js/DOMTimer.h:
              * bindings/js/JSDOMBinding.cpp: ActiveDOMObject can have no JS wrapper
              (WebCore::markActiveObjectsForContext): 
      
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
              (WebCore::JSDOMWindowBase::clear):
              (WebCore::JSDOMWindowBase::installTimeout):
              (WebCore::JSDOMWindowBase::removeTimeout):
              (WebCore::JSDOMWindowBase::timerFired):
              (WebCore::JSDOMWindowBase::disconnectFrame):
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptController.h:
      
              * dom/Document.cpp: Document now holds a hash map id->timeout
              (WebCore::Document::addTimeout):
              (WebCore::Document::removeTimeout):
              (WebCore::Document::findTimeout):
              * dom/Document.h:
              * history/CachedPage.cpp:
              (WebCore::CachedPage::CachedPage):
              (WebCore::CachedPage::restore):
              (WebCore::CachedPage::clear):
              * history/CachedPage.h:
              * inspector/JavaScriptDebugServer.cpp:
              (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer):
              (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
              * inspector/JavaScriptDebugServer.h:
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::commitProvisionalLoad): 
              removed clearAllTimeouts since all ActiveDOMObjects will be stopped in FrameLoader::clear();
              I don't see how the old comment can be correct - the code in the same method proceeds to invoke 'onunload'
              and then calls into client which can be external code and can cause any active object created in onunload
              to fire. We can stop them all before firing onunload but it does not make a lot of sense.
              I have a test to go with the next patch which verifies that timers set in onunload do not fire.
      
              (WebCore::FrameLoader::open):
              * page/Chrome.cpp:
              (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
              (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efccd59c
  2. 03 Dec, 2008 39 commits
    • barraclough@apple.com's avatar
      2008-12-03 Gavin Barraclough <barraclough@apple.com> · e367b001
      barraclough@apple.com authored
              Reviewed by Camron Zwarich.
      
              Allow JIT to operate without the call-repatching optimization.
              Controlled by ENABLE(JIT_OPTIMIZE_CALL), defaults on, disabling
              this leads to significant performance regression.
      
              https://bugs.webkit.org/show_bug.cgi?id=22639
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * jit/JIT.cpp:
              (JSC::JIT::privateCompileSlowCases):
              * jit/JIT.h:
              * jit/JITCall.cpp: Copied from jit/JIT.cpp.
              (JSC::JIT::compileOpCallInitializeCallFrame):
              (JSC::JIT::compileOpCallSetupArgs):
              (JSC::JIT::compileOpCallEvalSetupArgs):
              (JSC::JIT::compileOpConstructSetupArgs):
              (JSC::JIT::compileOpCall):
              (JSC::JIT::compileOpCallSlowCase):
              (JSC::unreachable):
              * jit/JITInlineMethods.h: Copied from jit/JIT.cpp.
              (JSC::JIT::checkStructure):
              (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
              (JSC::JIT::emitTagAsBoolImmediate):
              * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e367b001
    • justin.garcia@apple.com's avatar
      WebCore: · b7785054
      justin.garcia@apple.com authored
      2008-12-03  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Beth Dakin.
      
              <rdar://problem/6018653> Extra blank line when pasting paragraph in plain text
              
              In SnowLeopard, Mail occasionally adds an empty, unstyled paragraph at the
              end of pasted content so that users don't get stuck with non-standard pargraph
              spacing.  This content threw off our handling of interchange newlines.  Any interchange
              newline, regardless of it's position in the incoming fragment was considered to be
              "at the start" of the fragment, and would result in us inserting in a newline before 
              inserted content.  This patch makes the checks for interchange newlines more strict, 
              and treats interchange newlines found elsewhere as normal <br>s.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment):
              (WebCore::ReplacementFragment::removeInterchangeNodes):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::init):
              (WebCore::VisiblePosition::canonicalPosition):
              * editing/VisiblePosition.h:
      
      LayoutTests:
      
      2008-12-03  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Beth Dakin.
      
              <rdar://problem/6018653> Extra blank line when pasting paragraph in plain text
      
              * editing/pasteboard/6018653-expected.txt: Added.
              * editing/pasteboard/6018653.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7785054
    • andersca@apple.com's avatar
      2008-12-03 Anders Carlsson <andersca@apple.com> · b6290d56
      andersca@apple.com authored
              Reviewed by Sam Weinig.
              
              Move WebPluginRequest to its own file.
              
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6290d56
    • andersca@apple.com's avatar
      2008-12-03 Anders Carlsson <andersca@apple.com> · 6bc7407c
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Move WebPluginRequest to its own file.
              
              * Plugins/WebNetscapePluginView.mm:
              * Plugins/WebPluginRequest.h: Added.
              * Plugins/WebPluginRequest.m: Added.
              (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
              (-[WebPluginRequest dealloc]):
              (-[WebPluginRequest request]):
              (-[WebPluginRequest frameName]):
              (-[WebPluginRequest isCurrentEventUserGesture]):
              (-[WebPluginRequest sendNotification]):
              (-[WebPluginRequest notifyData]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bc7407c
    • eric@webkit.org's avatar
      Rubber-stamped by David Hyatt. · 194d6db3
      eric@webkit.org authored
              Bring the WebCore chromium build a couple steps closer to building.
      
              * WebCore.scons:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      194d6db3
    • andersca@apple.com's avatar
      2008-12-03 Anders Carlsson <andersca@apple.com> · 6203e449
      andersca@apple.com authored
              Handle the CA model.
      
              * Plugins/WebNetscapePluginView.mm:
              (-[WebNetscapePluginView setWindowIfNecessary]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6203e449
    • kevino@webkit.org's avatar
      wx build fix. · 4f3bb0a9
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f3bb0a9
    • zimmermann@webkit.org's avatar
      Reviewed by George Staikos. · 18f3684c
      zimmermann@webkit.org authored
      Forgot to rerun make-js-test-wrappers, and update some fast/wml results.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18f3684c
    • weinig@apple.com's avatar
      2008-12-03 Sam Weinig <sam@webkit.org> · abc4d8de
      weinig@apple.com authored
              Fix build.
      
              * assembler/X86Assembler.h:
              (JSC::X86Assembler::orl_i32r):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abc4d8de
    • weinig@apple.com's avatar
      2008-12-03 Sam Weinig <sam@webkit.org> · b196ff33
      weinig@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Remove shared AssemblerBuffer 1MB buffer and instead give AssemblerBuffer
              an 256 byte inline capacity.
      
              1% progression on Sunspider.
      
              * assembler/AssemblerBuffer.h:
              (JSC::AssemblerBuffer::AssemblerBuffer):
              (JSC::AssemblerBuffer::~AssemblerBuffer):
              (JSC::AssemblerBuffer::grow):
              * assembler/MacroAssembler.h:
              (JSC::MacroAssembler::MacroAssembler):
              * assembler/X86Assembler.h:
              (JSC::X86Assembler::X86Assembler):
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::Interpreter):
              * interpreter/Interpreter.h:
              * jit/JIT.cpp:
              (JSC::JIT::JIT):
              * parser/Nodes.cpp:
              (JSC::RegExpNode::emitBytecode):
              * runtime/RegExp.cpp:
              (JSC::RegExp::RegExp):
              (JSC::RegExp::create):
              * runtime/RegExp.h:
              * runtime/RegExpConstructor.cpp:
              (JSC::constructRegExp):
              * runtime/RegExpPrototype.cpp:
              (JSC::regExpProtoFuncCompile):
              * runtime/StringPrototype.cpp:
              (JSC::stringProtoFuncMatch):
              (JSC::stringProtoFuncSearch):
              * wrec/WREC.cpp:
              (JSC::WREC::Generator::compileRegExp):
              * wrec/WRECGenerator.h:
              (JSC::WREC::Generator::Generator):
              * wrec/WRECParser.h:
              (JSC::WREC::Parser::Parser):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b196ff33
    • zimmermann@webkit.org's avatar
      Reviewed by George Staikos. · b60b8221
      zimmermann@webkit.org authored
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=22636
      
      Implement WML variable substitution & validation.
      Created a framework for scriptable WML layout tests, that are able to test variable substiution & validation.
      
      Tests: wml/variable-reference-invalid-character.html
             wml/variable-reference-valid.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b60b8221
    • eric@webkit.org's avatar
      Build fix for --gtk and --chromium, no review. · 8208a463
      eric@webkit.org authored
              Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
              through to build-jsc.
      
              * Scripts/build-jsc:
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8208a463
    • zimmermann@webkit.org's avatar
      Reviewed by Cameron Zwarich. · 789df80c
      zimmermann@webkit.org authored
      Further preparations for WML layout tests.
      - Enable variable substitution in Text.cpp - if the parent is a WMLElement derived class.
      - Dump WMLMessageSource messages to the console, just like it's done for JSMessageSource
      - Add helper method in Document.idl, to reset the WML page state to a well-known default state.
        (will be used in the upcoming LayoutTests/wml testcases)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      789df80c
    • ggaren@apple.com's avatar
      2008-12-03 Geoffrey Garen <ggaren@apple.com> · d892a205
      ggaren@apple.com authored
              Reviewed by Oliver Hunt, with help from Gavin Barraclough.
              
              orl_i32r was actually coded as an 8bit OR. So, I renamed orl_i32r to
              orl_i8r, changed all orl_i32r clients to use orl_i8r, and then added
              a new orl_i32r that actually does a 32bit OR.
              
              (32bit OR is currently unused, but a patch I'm working on uses it.)
      
              * assembler/MacroAssembler.h:
              (JSC::MacroAssembler::or32): Updated to choose between 8bit and 32bit OR.
      
              * assembler/X86Assembler.h:
              (JSC::X86Assembler::orl_i8r): The old orl_i32r.
              (JSC::X86Assembler::orl_i32r): The new orl_i32r.
              
              * jit/JIT.cpp:
              (JSC::JIT::emitFastArithPotentiallyReTagImmediate):
              (JSC::JIT::emitTagAsBoolImmediate): Use orl_i8r, since we're ORing 8bit
              values.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d892a205
    • antti@apple.com's avatar
      2008-12-03 Antti Koivisto <antti@apple.com> · da12c2a7
      antti@apple.com authored
              Reviewed by Sam Weinig.
      
              Don't leak selectors in case selector list parsing failed.
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::~CSSParser):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da12c2a7
    • simon.fraser@apple.com's avatar
      2008-12-03 Simon Fraser <simon.fraser@apple.com> · 3f5c5b76
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt
      
              Clean up and unify transition and animation test cases that destroy
              the renderer in the 'ended' event callback, either through setting display:none,
              or removing the element.
      
              * animations/animation-end-event-destroy-renderer-expected.txt: Added.
              * animations/animation-end-event-destroy-renderer.html: Added.
              * animations/transform-animation-event-destroy-element-expected.txt: Removed.
              * animations/transform-animation-event-destroy-element.html: Removed.
              * transitions/transform-transition-event-destroy-element-expected.txt: Removed.
              * transitions/transform-transition-event-destroy-element.html: Removed.
              * transitions/transition-end-event-destroy-renderer-expected.txt: Added.
              * transitions/transition-end-event-destroy-renderer.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f5c5b76
    • cmarrin@apple.com's avatar
      2008-12-03 Chris Marrin <cmarrin@apple.com> · 3b4741c9
      cmarrin@apple.com authored
              Reviewed by Dave Hyatt.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=22520
      
              This is a regression (causes a crash of LayoutTests/animations/transform-animation-event-destroy-element.html).
              This patch fixes the testcase.
      
              This is another case of animations getting destroyed in the end animation callback and causing dangling
              pointers on return. This one involves iterating over the CompositeAnimation, which has been destroyed.
              So I now check for a null m_object pointer (which is nullified when the CompositeAnimation is destroyed)
              and skip that call.
      
              * page/animation/AnimationBase.cpp:
              (WebCore::AnimationBase::updateStateMachine):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b4741c9
    • andersca@apple.com's avatar
      Add radar number · b1359a5a
      andersca@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1359a5a
    • andersca@apple.com's avatar
      2008-12-03 Anders Carlsson <andersca@apple.com> · 685a2adf
      andersca@apple.com authored
              Reviewed by Kevin Decker.
              
              Call NPP_SetWindow for CA plug-ins.
              
              * Plugins/WebNetscapePluginView.mm:
              (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
              (-[WebNetscapePluginView restorePortState:]):
              (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
              (-[WebNetscapePluginView updateAndSetWindow]):
              (-[WebNetscapePluginView setWindowIfNecessary]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      685a2adf
    • eric@webkit.org's avatar
      Build fix only, no review. · 4c78b7f4
      eric@webkit.org authored
              Remove support for build-webkit --svg-experimental.
              All of the "experimental" svg features have their own toggles anyway.
              I broke --svg-experimental in my last commit (which then broke clean builds)
              I can't find any use of --svg-experimental in our source tree, so removing it.
      
              * Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c78b7f4
    • antti@apple.com's avatar
      2008-12-03 Antti Koivisto <antti@apple.com> · 60488ab1
      antti@apple.com authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=22379
              Make CSSOM use less memory
      
              Reduce size of the CSSSelector by one more pointer by using an array
              instead of a linked list to store them.
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::parseSelector):
              (WebCore::CSSParser::createStyleRule):
              * css/CSSParser.h:
              (WebCore::CSSParser::reusableSelectorVector):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::CSSSelector):
              (WebCore::CSSSelector::~CSSSelector):
              (WebCore::CSSSelector::isLastInSelectorList):
              (WebCore::CSSSelector::setLastInSelectorList):
              * css/CSSStyleRule.cpp:
              (WebCore::CSSStyleRule::CSSStyleRule):
              (WebCore::CSSStyleRule::~CSSStyleRule):
              (WebCore::CSSStyleRule::selectorText):
              * css/CSSStyleRule.h:
              (WebCore::CSSStyleRule::adoptSelectorVector):
              (WebCore::CSSStyleRule::selectorList):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSRuleSet::addRulesFromSheet):
              * dom/Node.cpp:
              (WebCore::forEachSelector):
              (WebCore::selectorNeedsNamespaceResolution):
              (WebCore::Node::querySelector):
              (WebCore::Node::querySelectorAll):
              * dom/SelectorNodeList.cpp:
              (WebCore::createSelectorNodeList):
              * dom/SelectorNodeList.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60488ab1
    • dino@apple.com's avatar
      2008-12-03 Dean Jackson <dino@apple.com> · cb5c6116
      dino@apple.com authored
              CSSTransforms.html +
              CSSTransforms3D.html:
      
              * Use SYNTAX_ERR for exceptions that are
                parsing errors in CSSMatrix
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb5c6116
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 1686055e
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=22630
              Assertion failure in XMLHttpRequest::contextDestroyed
      
              Test: http/tests/xmlhttprequest/close-window.html
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::commitProvisionalLoad):
              Move stopping active objects to clear(), so that closing a window is also covered.
      
              * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort): Protect the object in abort(),
              because internalAbort() deref()'s.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1686055e
    • dino@apple.com's avatar
      2008-12-03 Dean Jackson <dino@apple.com> · 1828632c
      dino@apple.com authored
              Added links to the WebKit and Mozilla bugs for pointer-events.
      
              * specs/PointerEventsProperty.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1828632c
    • eric@webkit.org's avatar
      Reviewed by David Hyatt (and Mark Rowe). · dbd3e367
      eric@webkit.org authored
              Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
              Move --coverage support out of run-javascriptcore-tests and into build-jsc
      
              Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
              there from build-webkit (to allow future sharing with other build-* scripts)
      
              Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
              picking through ARGV with a blacklist of what arguments weren't jsDriver args
              this makes run-javascriptcore-tests transparently support all arguments which
              webkitdirs.pm gives it support for.
      
              Make run-javascriptcore-tests actually print what commands it's running before running them.
      
              Add --help support to build-jsc and run-javascriptcore-tests!
      
              Make code to support --svg-experimental defaults take up half as many lines.
      
              * Scripts/build-jsc:
              * Scripts/build-webkit:
              * Scripts/run-javascriptcore-tests:
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbd3e367
    • dino@apple.com's avatar
      2008-12-03 Dean Jackson <dino@apple.com> · bd011fd4
      dino@apple.com authored
              Reviewed by Dan Bernstein.
      
              JavaScriptCore:
                  Helper functions for turn -> degrees.
                  https://bugs.webkit.org/show_bug.cgi?id=22497
      
                  * wtf/MathExtras.h:
                  (turn2deg):
                  (deg2turn):
      
              WebCore:
                  Implement CSS 3 <angle> turn unit and support it
                  in rotations.
                  https://bugs.webkit.org/show_bug.cgi?id=22497
      
                  * css/CSSGrammar.y:
                  * css/CSSParser.cpp:
                  (WebCore::CSSParser::validUnit):
                  (WebCore::unitFromString):
                  (WebCore::CSSParser::lex):
                  * css/CSSPrimitiveValue.cpp:
                  (WebCore::CSSPrimitiveValue::cssText):
                  (WebCore::CSSPrimitiveValue::parserValue):
                  * css/CSSPrimitiveValue.h:
                  (WebCore::CSSPrimitiveValue::):
                  * css/CSSStyleSelector.cpp:
                  (WebCore::CSSStyleSelector::createTransformOperations):
                  * css/tokenizer.flex:
      
              LayoutTests:
                  Tests for CSS 3 <angle> turn unit
                  https://bugs.webkit.org/show_bug.cgi?id=22497
      
                  * transforms/2d/transform-2d-expected.txt:
                  * transforms/2d/transform-2d.html:
                  * transforms/transform-value-types-expected.txt:
                  * transforms/transform-value-types.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd011fd4
    • andersca@apple.com's avatar
      2008-12-03 Anders Carlsson <andersca@apple.com> · 97ba17ef
      andersca@apple.com authored
              Fix the release build.
      
              * Plugins/Hosted/NetscapePluginHostProxy.mm:
              (WebKit::NetscapePluginHostProxy::deadNameNotificationCallback):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97ba17ef
    • dino@apple.com's avatar
      2008-12-03 Dean Jackson <dino@apple.com> · 60c426ae
      dino@apple.com authored
              Reviewed by Dan Bernstein.
      
              Clean up some tests for private DRT API.
              https://bugs.webkit.org/show_bug.cgi?id=22498
      
              * platform/win/Skipped:
              * transitions/transition-drt-api-delay-expected.txt:
              * transitions/transition-drt-api-delay.html:
              * transitions/transition-shorthand-delay-expected.txt:
              * transitions/transition-shorthand-delay.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60c426ae
    • sfalken@apple.com's avatar
      Update strings not to be localized. · 1a4c78c0
      sfalken@apple.com authored
              Reviewed by Adam Roben.
      
              * StringsNotToBeLocalized.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a4c78c0
    • aroben@apple.com's avatar
      Fix a leak in WinLauncher shutdown · c709bdc5
      aroben@apple.com authored
              Reviewed by Sam Weinig.
      
              * WinLauncher/WinLauncher.cpp:
              (_tWinMain): Replaced a delete with a Release. We can't delete the
              WebView properly since we only have a pointer to one of its
              interfaces. We also shouldn't be deleting COM objects directly anyway,
              for a number of reasons.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c709bdc5
    • aroben@apple.com's avatar
      Fix a crash on exit in WinLauncher · 6144f1ac
      aroben@apple.com authored
              Reviewed by Sam Weinig.
      
              * WinLauncher/WinLauncher.cpp:
              (_tWinMain): Call shutDownWebKit before exiting.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6144f1ac
    • aroben@apple.com's avatar
      Add a Debug_Internal configuration to WinLauncher · 9aacc740
      aroben@apple.com authored
              This matches our other projects.
      
              Reviewed by Sam Weinig.
      
              * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
              configuration, which is identical to Debug except that it also
              references debug_internal.vsprops. Also removed some settings that we
              should be picking up from the .vsprops files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aacc740
    • krit@webkit.org's avatar
      2008-12-03 Dirk Schulze <krit@webkit.org> · 1bd39c3e
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              WebCore:
      
              Make use of the gradient code in GraphicsContext and get rid of most of the
              platform dependent code.
      
              SVG should use the new Gradient support on GraphicsContext
              https://bugs.webkit.org/show_bug.cgi?id=20543
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/FloatSize.h:
              (WebCore::FloatSize::shrunkTo):
              * svg/SVGLinearGradientElement.cpp:
              (WebCore::SVGLinearGradientElement::buildGradient):
              * svg/SVGRadialGradientElement.cpp:
              (WebCore::SVGRadialGradientElement::buildGradient):
              * svg/graphics/SVGPaintServer.h:
              * svg/graphics/SVGPaintServerGradient.cpp:
              (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
              (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient):
              (WebCore::SVGPaintServerGradient::gradient):
              (WebCore::SVGPaintServerGradient::setGradient):
              (WebCore::findTextRootObject):
              (WebCore::createMaskAndSwapContextForTextGradient):
              (WebCore::clipToTextMask):
              (WebCore::SVGPaintServerGradient::setup):
              (WebCore::SVGPaintServerGradient::renderPath):
              (WebCore::SVGPaintServerGradient::teardown):
              * svg/graphics/SVGPaintServerGradient.h:
              (WebCore::SVGPaintServerGradient::setGradientStops):
              (WebCore::SVGPaintServerGradient::gradientStops):
              * svg/graphics/SVGPaintServerLinearGradient.h:
              * svg/graphics/SVGPaintServerRadialGradient.h:
              * svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: Removed.
              * svg/graphics/cg/SVGPaintServerCg.cpp:
              * svg/graphics/cg/SVGPaintServerGradientCg.cpp: Removed.
              * svg/graphics/qt/SVGPaintServerGradientQt.cpp: Removed.
              * svg/graphics/qt/SVGPaintServerLinearGradientQt.cpp: Removed.
              * svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp: Removed.
      
              LayoutTests:
      
              Updated/Correcte the SVG pixel tests.
              We pass two more SVG tests now.
      
              * platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
              * platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
              * platform/mac/svg/batik/text/textEffect3-expected.checksum:
              * platform/mac/svg/batik/text/textEffect3-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bd39c3e
    • weinig@apple.com's avatar
      2008-12-03 Sam Weinig <sam@webkit.org> · 81d54583
      weinig@apple.com authored
              Reviewed by Mark Rowe.
      
              Fix formatting.
      
              * css/CSSSelector.h:
              (WebCore::CSSSelector::createRareData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81d54583
    • andersca@apple.com's avatar
      2008-12-03 Anders Carlsson <andersca@apple.com> · e9a78c13
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              <rdar://problem/6412234>
              Don't crash if we can't launch the plug-in host.
      
              * Plugins/Hosted/NetscapePluginHostManager.mm:
              (WebKit::NetscapePluginHostManager::instantiatePlugin):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9a78c13
    • zimmermann@webkit.org's avatar
      Reviewed by Adam Roben. · 0787259f
      zimmermann@webkit.org authored
      As Adam Roben noticed, synchronize MessageSource enum with Console.js, and add a comment.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0787259f
    • zimmermann@webkit.org's avatar
      Reviewed by Alexey Proskuryakov. · 2ea0e889
      zimmermann@webkit.org authored
      Next steps to make LayoutTests work:
      Never access the main frame from WMLRefreshElement/WMLCardElement, but
      the current documents frame (WML layout tests will run in an <iframe>)
      
      Prepare WMLErrorHandling for the case that no tokenizer is available anymore
      -> report errors through Console::addMessage(), so they get logged in the
         expected layout test results.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ea0e889
    • vestbo@webkit.org's avatar
      2008-12-03 Tor Arne Vestbø <tavestbo@trolltech.com> · 8126f620
      vestbo@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Allow passing jsNull and jsUndefined to Qt plugins
      
              Currently limited to functions with QString and QVariant arguments,
              and properties of these types. Both jsNull and jsUndefined ends up
              as default-constructed QStrings and QVariants, which means you can
              check for isEmpty() and isValid() in the native plugin code.
      
              Based on patches by Jade Han <jade.han@nokia.com>
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8126f620
    • hausmann@webkit.org's avatar
      2008-12-03 Trenton Schulz <trenton.schulz@nokia.com> · 949a1db8
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fix the build with Qt for Mac OS X.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      949a1db8