1. 16 Feb, 2011 22 commits
    • zimmermann@webkit.org's avatar
      2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com> · ef9f8f1d
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Pixel tests differences on 10.6.6 32bit vs. 64bit
              https://bugs.webkit.org/show_bug.cgi?id=54474
      
              Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
              This is the third chunk.
      
              It should pass on modern 64bit machines as well, using tolerance 0.01.
      
              * platform/mac/svg/clip-path/clip-in-mask-expected.checksum:
              * platform/mac/svg/clip-path/clip-in-mask-expected.png:
              * platform/mac/svg/clip-path/clip-path-child-clipped-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-child-clipped-expected.png:
              * platform/mac/svg/clip-path/clip-path-childs-clipped-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png:
              * platform/mac/svg/clip-path/clip-path-clipped-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-clipped-expected.png:
              * platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png:
              * platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png:
              * platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png:
              * platform/mac/svg/clip-path/clip-path-on-g-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-on-g-expected.png:
              * platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png:
              * platform/mac/svg/clip-path/clip-path-on-svg-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-on-svg-expected.png:
              * platform/mac/svg/clip-path/clip-path-use-as-child-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-use-as-child-expected.png:
              * platform/mac/svg/clip-path/clip-path-use-as-child2-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png:
              * platform/mac/svg/clip-path/clip-path-use-as-child3-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png:
              * platform/mac/svg/clip-path/clip-path-use-as-child4-expected.checksum:
              * platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png:
              * platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum:
              * platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
              * platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum:
              * platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
              * platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum:
              * platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
              * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum:
              * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
              * platform/mac/svg/custom/animate-path-discrete-expected.checksum:
              * platform/mac/svg/custom/animate-path-discrete-expected.png:
              * platform/mac/svg/custom/convolution-crash-expected.checksum:
              * platform/mac/svg/custom/convolution-crash-expected.png:
              * platform/mac/svg/custom/createImageElement2-expected.checksum:
              * platform/mac/svg/custom/createImageElement2-expected.png:
              * platform/mac/svg/custom/dynamic-svg-document-creation-expected.checksum:
              * platform/mac/svg/custom/dynamic-svg-document-creation-expected.png:
              * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.checksum:
              * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
              * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.checksum:
              * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
              * platform/mac/svg/custom/feComponentTransfer-Linear-expected.checksum:
              * platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
              * platform/mac/svg/custom/feComponentTransfer-Table-expected.checksum:
              * platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
              * platform/mac/svg/custom/focus-ring-expected.checksum:
              * platform/mac/svg/custom/focus-ring-expected.png:
              * platform/mac/svg/custom/foreign-object-skew-expected.checksum:
              * platform/mac/svg/custom/foreign-object-skew-expected.png:
              * platform/mac/svg/custom/glyph-transformation-with-hkern-expected.checksum:
              * platform/mac/svg/custom/glyph-transformation-with-hkern-expected.png:
              * platform/mac/svg/custom/gradient-rotated-bbox-expected.checksum:
              * platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
              * platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
              * platform/mac/svg/custom/gradient-stroke-width-expected.png:
              * platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
              * platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
              * platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
              * platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
              * platform/mac/svg/custom/invalid-css-expected.checksum:
              * platform/mac/svg/custom/invalid-css-expected.png:
              * platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.checksum:
              * platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
              * platform/mac/svg/custom/js-late-clipPath-creation-expected.checksum:
              * platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
              * platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
              * platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
              * platform/mac/svg/custom/js-late-gradient-creation-expected.checksum:
              * platform/mac/svg/custom/js-late-gradient-creation-expected.png:
              * platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
              * platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
              * platform/mac/svg/custom/linking-a-03-b-all-expected.checksum:
              * platform/mac/svg/custom/linking-a-03-b-all-expected.png:
              * platform/mac/svg/custom/linking-a-03-b-transform-expected.checksum:
              * platform/mac/svg/custom/linking-a-03-b-transform-expected.png:
              * platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
              * platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
              * platform/mac/svg/custom/marker-default-width-height-expected.checksum:
              * platform/mac/svg/custom/marker-default-width-height-expected.png:
              * platform/mac/svg/custom/marker-opacity-expected.checksum:
              * platform/mac/svg/custom/marker-opacity-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
              * platform/mac/svg/custom/non-scaling-stroke-expected.checksum:
              * platform/mac/svg/custom/non-scaling-stroke-expected.png:
              * platform/mac/svg/custom/pattern-skew-transformed-expected.checksum:
              * platform/mac/svg/custom/pattern-skew-transformed-expected.png:
              * platform/mac/svg/custom/pattern-with-transformation-expected.checksum:
              * platform/mac/svg/custom/pattern-with-transformation-expected.png:
              * platform/mac/svg/custom/pointer-events-image-expected.checksum:
              * platform/mac/svg/custom/pointer-events-image-expected.png:
              * platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
              * platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
              * platform/mac/svg/custom/relative-sized-content-with-resources-expected.checksum:
              * platform/mac/svg/custom/relative-sized-content-with-resources-expected.png:
              * platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum:
              * platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
              * platform/mac/svg/custom/relative-sized-use-on-symbol-expected.checksum:
              * platform/mac/svg/custom/relative-sized-use-on-symbol-expected.png:
              * platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum:
              * platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
              * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum:
              * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
              * platform/mac/svg/custom/shapes-supporting-markers-expected.checksum:
              * platform/mac/svg/custom/shapes-supporting-markers-expected.png:
              * platform/mac/svg/custom/stroked-pattern-expected.checksum:
              * platform/mac/svg/custom/stroked-pattern-expected.png:
              * platform/mac/svg/custom/struct-use-09-b-expected.checksum:
              * platform/mac/svg/custom/struct-use-09-b-expected.png:
              * platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
              * platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
              * platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
              * platform/mac/svg/custom/svg-fonts-in-html-expected.png:
              * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
              * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
              * platform/mac/svg/custom/text-rotated-gradient-expected.checksum:
              * platform/mac/svg/custom/text-rotated-gradient-expected.png:
              * platform/mac/svg/custom/tref-update-expected.checksum:
              * platform/mac/svg/custom/tref-update-expected.png:
              * platform/mac/svg/custom/use-css-events-expected.checksum:
              * platform/mac/svg/custom/use-css-events-expected.png:
              * platform/mac/svg/custom/use-detach-expected.checksum:
              * platform/mac/svg/custom/use-detach-expected.png:
              * platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.checksum:
              * platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.png:
              * platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
              * platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.png:
              * platform/mac/svg/custom/width-full-percentage-expected.checksum:
              * platform/mac/svg/custom/width-full-percentage-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef9f8f1d
    • zimmermann@webkit.org's avatar
      2011-02-16 Nikolas Zimmermann <nzimmermann@rim.com> · 3f4ab6d3
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Pixel tests differences on 10.6.6 32bit vs. 64bit
              https://bugs.webkit.org/show_bug.cgi?id=54474
      
              Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
              This is the second chunk.
      
              It should pass on modern 64bit machines as well, using tolerance 0.01.
      
              * platform/mac/svg/batik/masking/maskRegions-expected.checksum:
              * platform/mac/svg/batik/masking/maskRegions-expected.png:
              * platform/mac/svg/batik/text/smallFonts-expected.checksum:
              * platform/mac/svg/batik/text/smallFonts-expected.png:
              * platform/mac/svg/batik/text/textAnchor-expected.checksum:
              * platform/mac/svg/batik/text/textAnchor-expected.png:
              * platform/mac/svg/batik/text/textEffect-expected.checksum:
              * platform/mac/svg/batik/text/textEffect-expected.png:
              * platform/mac/svg/batik/text/textEffect3-expected.checksum:
              * platform/mac/svg/batik/text/textEffect3-expected.png:
              * platform/mac/svg/batik/text/textFeatures-expected.checksum:
              * platform/mac/svg/batik/text/textFeatures-expected.png:
              * platform/mac/svg/batik/text/textOnPath2-expected.checksum:
              * platform/mac/svg/batik/text/textOnPath2-expected.png:
              * platform/mac/svg/batik/text/textOnPath3-expected.checksum:
              * platform/mac/svg/batik/text/textOnPath3-expected.png:
              * platform/mac/svg/batik/text/verticalTextOnPath-expected.checksum:
              * platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
              * platform/mac/svg/carto.net/button-expected.checksum:
              * platform/mac/svg/carto.net/button-expected.png:
              * platform/mac/svg/carto.net/colourpicker-expected.checksum:
              * platform/mac/svg/carto.net/colourpicker-expected.png:
              * platform/mac/svg/carto.net/combobox-expected.checksum:
              * platform/mac/svg/carto.net/combobox-expected.png:
              * platform/mac/svg/carto.net/scrollbar-expected.checksum:
              * platform/mac/svg/carto.net/scrollbar-expected.png:
              * platform/mac/svg/carto.net/selectionlist-expected.checksum:
              * platform/mac/svg/carto.net/selectionlist-expected.png:
              * platform/mac/svg/carto.net/slider-expected.checksum:
              * platform/mac/svg/carto.net/slider-expected.png:
              * platform/mac/svg/carto.net/textbox-expected.checksum:
              * platform/mac/svg/carto.net/textbox-expected.png:
              * platform/mac/svg/carto.net/window-expected.checksum:
              * platform/mac/svg/carto.net/window-expected.png:
              * platform/mac/svg/css/composite-shadow-example-expected.checksum:
              * platform/mac/svg/css/composite-shadow-example-expected.png:
              * platform/mac/svg/css/composite-shadow-text-expected.checksum:
              * platform/mac/svg/css/composite-shadow-text-expected.png:
              * platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum:
              * platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
              * platform/mac/svg/css/group-with-shadow-expected.checksum:
              * platform/mac/svg/css/group-with-shadow-expected.png:
              * platform/mac/svg/dom/SVGTransformList-basics-expected.checksum:
              * platform/mac/svg/dom/SVGTransformList-basics-expected.png:
              * svg/batik/masking/maskRegions.svg:
              * svg/zoom/page/zoom-mask-with-percentages.svg:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f4ab6d3
    • mnaganov@chromium.org's avatar
      2011-02-16 Sheriff Bot <webkit.review.bot@gmail.com> · 4ed5f905
      mnaganov@chromium.org authored
      	Unreviewed, rolling out r78678.
      	http://trac.webkit.org/changeset/78678
      	https://bugs.webkit.org/show_bug.cgi?id=54554
      
      	Breaks NaCl tests in Chromium (Requested by mnaganov on
      	#webkit).
      
      	* src/WebURLRequest.cpp:
      	(WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl):
      	(WebKit::WebURLRequest::downloadToFile):
      	(WebKit::WebURLRequest::setDownloadToFile):
      	* src/WebURLRequestPrivate.h:
      	(WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
      	* src/WebURLResponse.cpp:
      	(WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl):
      	(WebKit::WebURLResponse::downloadFilePath):
      	(WebKit::WebURLResponse::setDownloadFilePath):
      	* src/WebURLResponsePrivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ed5f905
    • zimmermann@webkit.org's avatar
      2011-02-15 Nikolas Zimmermann <nzimmermann@rim.com> · 3271ebe2
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Pixel tests differences on 10.6.6 32bit vs. 64bit
              https://bugs.webkit.org/show_bug.cgi?id=54474
      
              When generating a SVG pixel test baseline with a vanilla 10.6.6 installation on a 32bit machine (Core Duo MBP)
              and comparing the run with a software-identical 64bit machine (Core 2 Duo MBP), there are about 250 differences.
      
              These fall in two categories:
              a) 1px differences in text AA, or when drawing circles (all _below_ a tolerance of 0.01). Only visible in the subtracted difference image.
                 The reason is probably CGFloat being typedefed to double on 64bit machines, and float on 32bit machines.
                 AffineTransform stores doubles, so on 32bit machines we loose precision from AffineTransform -> CGAffineTransform.
      
              b) Failures >0.1% (text origin/scale is slightly different, user-visible).
                 Caused by several sources of numerical instabilities within the SVG rendering code.
      
                 -> SVGPreserveAspectRatio::getCTM() computes an AffineTransform using doubles as input parameters, but floats are passed (like everywhere else in SVG).
                    This method is used to compute the viewBox AffineTransform, that affects the rendering of every content in the document. RenderSVGRoot concats
                    this transformation matrix to the GraphicsContext CTM, resulting in a source of numerical imprecision.
      
                 -> SVGInlineTextBox::paintTextWithShadows() calculates a scaling factor for text, to scale up the specified font size, to the actual on-screen size.
                    SVGInlineTextBox uses the scaled Font object, to draw in an unscaled context, that gets scaled up again afterwards.
                    context->scale(1 / scalingFactor); scaledFont.drawText(); context->scale(scalingFactor);
      
                    To remove the scale from the current GraphicsContext CTM, "context->scale(FloatSize(1 / scalingFactor, ...)" is used. As AffineTransform stores
                    doubles internally, it's likely that "context->scale(FloatSize(1 / ctm.a(), .." doesn't give you a matrix with a=1, but something close to 1.
                    Using "context->concatCTM(AffineTransform().scale(1 / ctm.a(), ..." could be used as workaround, to preserve double precision.
                    Fixing that brings us down to just a few pixel tests that differ between 32 & 64bit. There is still numerical imprecision, as floating-point
                    number representations aren't always precise. Unfortunately CoreGraphics doesn't provide a public way to just set a CTM, it only allows to concat them.
                    Fortunately CGContextSetCTM() is available, as private method, that allows me to switch the context CTM to any arbitary CGAffineTransform.
      
                    -> Add GraphicsContext::setCTM(const AffineTransform&) and implement it for all platforms (each explicitely exposes a 'setCTM' concept, except CG)
                       Use CGContextSetCTM() for CG, which appears to be present since at least 10.4, Cairo is using it for the same purpose since some years!
      
                    -> Instead of scaling the GraphicsContext before drawing text, grab the current CTM using context->getCTM(), scale it by '1 / scalingFactor'
                       normalize the transform (look for values close to 0/1 using float precision, and round!), and assign it using context->setCTM(normalizedTransform).
                       After drawing, just switch back to the preserved original CTM, both operations need GraphicsContext::setCTM.
                       This fixes all pixel test differences between 32/64 bit machines that fall into category b).
                       The use of GraphicsContext::setCTM() allows to switch between arbitary context transformations _without_ inducing accumulated rounding imprecision.
      
              These combined patches fix the pixel test baseline changes.
      
              Updated existing Snow Leopard pixel test baseline with a 32bit machine, passes here with tolerance 0.
              The 64bit machine passes the baseline with tolerance 0.01.
      
              * platform/graphics/GraphicsContext.h: Add setCTM(const AffineTransform&) method.
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::setCTM): Implement setCTM.
              * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
              (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::setCTM): Ditto.
              * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
              (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
              * platform/graphics/chromium/GLES2Canvas.cpp:
              (WebCore::GLES2Canvas::setCTM): Ditto.
              * platform/graphics/chromium/GLES2Canvas.h:
              * platform/graphics/haiku/GraphicsContextHaiku.cpp:
              (WebCore::GraphicsContext::setCTM): Ditto.
              * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
              (WebCore::GraphicsContext::setCTM): Ditto.
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::setCTM): Ditto.
              * platform/graphics/skia/GraphicsContextSkia.cpp:
              (WebCore::GraphicsContext::setCTM): Ditto.
              * platform/graphics/win/GraphicsContextWin.cpp:
              (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
              * platform/graphics/wince/GraphicsContextWinCE.cpp:
              (WebCore::GraphicsContextPlatformPrivate::concatCTM):
              (WebCore::GraphicsContextPlatformPrivate::setCTM): Ditto.
              (WebCore::GraphicsContext::setCTM):
              * platform/graphics/wx/GraphicsContextWx.cpp:
              (WebCore::GraphicsContext::setCTM): Ditto.
              * rendering/svg/SVGInlineTextBox.cpp: Use setCTM() to switch to a scale-free AffineTransform, and also to switch back to the original CTM after rendering text.
              (WebCore::normalizeTransform):
              (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
              (WebCore::SVGInlineTextBox::paintTextWithShadows):
              * svg/SVGPreserveAspectRatio.cpp: s/double/float/.
              (WebCore::SVGPreserveAspectRatio::getCTM):
              * svg/SVGPreserveAspectRatio.h:
              * svg/SVGSVGElement.cpp: Simplify viewport() code, avoid using doubles.
              (WebCore::SVGSVGElement::viewport):
      
      2011-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Dirk Schulze.
      
              Pixel tests differences on 10.6.6 32bit vs. 64bit
              https://bugs.webkit.org/show_bug.cgi?id=54474
      
              Update SnowLeopard SVG pixel test baseline, generated on a 32bit machine, where it passes with tolerance 0.
              This is the first chunk of several commits, as one commit is too huge for SVN.
      
              It should pass on modern 64bit machines as well, using tolerance 0.01.
      
              * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-15-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
              * platform/mac/svg/batik/masking/maskRegions-expected.txt:
              * platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
              * platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
              * platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
              * platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
              * platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
              * platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt:
              * platform/mac/svg/custom/stroked-pattern-expected.txt:
              * platform/mac/svg/custom/text-rotated-gradient-expected.txt:
              * platform/mac/svg/custom/use-detach-expected.txt:
              * platform/mac/svg/hixie/links/001-expected.txt:
              * platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
              * platform/mac/svg/text/small-fonts-2-expected.txt:
              * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3271ebe2
    • andreas.kling@nokia.com's avatar
      2011-02-16 Andreas Kling <kling@webkit.org> · 2b3335c3
      andreas.kling@nokia.com authored
              Reviewed by Dirk Schulze.
      
              SVGAnimateElement incorrectly uses Color::nameForRenderTreeAsText()
              https://bugs.webkit.org/show_bug.cgi?id=54547
      
              * svg/SVGAnimateElement.cpp:
              (WebCore::SVGAnimateElement::applyResultsToTarget):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b3335c3
    • mnaganov@chromium.org's avatar
      2011-02-16 Mikhail Naganov <mnaganov@chromium.org> · 2ac7b19b
      mnaganov@chromium.org authored
              [Chromium] Unreviewed rebaseline of media video-controls-rendering for Windows.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ac7b19b
    • philn@webkit.org's avatar
      2011-02-16 Philippe Normand <pnormand@igalia.com> · 4d5deeda
      philn@webkit.org authored
              Reviewed by Adam Roben.
      
              media/audio-delete-while-slider-thumb-clicked.html failing on Windows since r78562
              https://bugs.webkit.org/show_bug.cgi?id=54502
      
              * media/audio-delete-while-slider-thumb-clicked.html: Avoid deleting the element twice.
              * platform/win/Skipped: unskip the test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d5deeda
    • mnaganov@chromium.org's avatar
      2011-02-14 Mikhail Naganov <mnaganov@chromium.org> · 2d703185
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Landing detailed heap snapshots, part 3.
              https://bugs.webkit.org/show_bug.cgi?id=54385
      
              Provide node classes for data grid views:
               - summary -- list of objects by constuctor;
               - diff -- summaries btw two snapshots;
               - explorer -- explore heap graph;
               - dominators tree;
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/DetailedHeapshotGridNodes.js: Added.
              * inspector/front-end/HeapSnapshot.js:
              (WebInspector.HeapSnapshotFilteredOrderedIterator):
              (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.incInstancesCount):
              (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get instancesCount):
              (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.next):
              (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.resetInstancesCount):
              (WebInspector.HeapSnapshotEdgesProvider):
              (WebInspector.HeapSnapshotNodesProvider):
              * inspector/front-end/PleaseWaitMessage.js:
              (WebInspector.PleaseWaitMessage.prototype.get instance):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d703185
    • loislo@chromium.org's avatar
      2011-02-16 Ilya Tikhonovsky <loislo@chromium.org> · 7064b610
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: chromium: DRT is crashing on the tests in inspector-enabled folder.
              https://bugs.webkit.org/show_bug.cgi?id=54548
      
              Bug in chromium DRT implementation was fixed.
              The tests were enabled.
      
              * platform/chromium/test_expectations.txt:
      2011-02-16  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: chromium: DRT is crashing on the tests in inspector-enabled folder.
              https://bugs.webkit.org/show_bug.cgi?id=54548
      
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::runFileTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7064b610
    • mnaganov@chromium.org's avatar
      2011-02-16 Mikhail Naganov <mnaganov@chromium.org> · 8217a3de
      mnaganov@chromium.org authored
              [Chromium] Unreviewed rebaseline of 2 more media tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8217a3de
    • mnaganov@chromium.org's avatar
      2011-02-16 Mikhail Naganov <mnaganov@chromium.org> · 8bc1536b
      mnaganov@chromium.org authored
              [Chromium] Unreviewed rebaseline of media tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bc1536b
    • philn@webkit.org's avatar
      2011-02-16 Philippe Normand <pnormand@igalia.com> · 253e06ca
      philn@webkit.org authored
              Unreviewed, qt and mac rebaseline of test after r78690.
      
              * media/controls-without-preload-expected.txt:
              * platform/qt/media/controls-without-preload-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      253e06ca
    • philn@webkit.org's avatar
      2011-02-16 Philippe Normand <pnormand@igalia.com> · b44e618c
      philn@webkit.org authored
              Unreviewed, rebaseline test after r78690.
      
              * media/controls-without-preload-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b44e618c
    • mnaganov@chromium.org's avatar
      2011-02-16 Sheriff Bot <webkit.review.bot@gmail.com> · 51e07477
      mnaganov@chromium.org authored
              Unreviewed, rolling out r78655.
              http://trac.webkit.org/changeset/78655
              https://bugs.webkit.org/show_bug.cgi?id=54543
      
              Causes too many test failures in chromium (Requested by
              mnaganov on #webkit).
      
              * storage/indexeddb/exception-in-event-aborts-expected.txt: Removed.
              * storage/indexeddb/exception-in-event-aborts.html: Removed.
              * storage/indexeddb/queued-commands-expected.txt:
              * storage/indexeddb/queued-commands.html:
              * storage/indexeddb/request-event-propagation-expected.txt:
              * storage/indexeddb/request-event-propagation.html:
              * storage/indexeddb/resources/shared.js:
              (unexpectedErrorCallback):
              * storage/indexeddb/transaction-event-propagation-expected.txt:
              * storage/indexeddb/transaction-event-propagation.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51e07477
    • philn@webkit.org's avatar
      2011-02-16 Philippe Normand <pnormand@igalia.com> · 74b83795
      philn@webkit.org authored
              Unreviewed rebaseline GTK media test result.
      
              * platform/gtk/media/video-controls-rendering-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74b83795
    • loislo@chromium.org's avatar
      2011-02-16 Ilya Tikhonovsky <loislo@chromium.org> · 64f5d3a7
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: move Database and DOMStorage related things from InspectorAgent to the corresponding agents.
      
              https://bugs.webkit.org/show_bug.cgi?id=54455
      
              Some set of instrumentation calls should work even if we have no InspectorFrontend instance and corresponding agents.
              At the moment we are using InspectorAgent instance for such calls.
      
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::createFrontendLifetimeAgents):
              (WebCore::InspectorAgent::pushDataCollectedOffline):
              (WebCore::InspectorAgent::didCommitLoad):
              * inspector/InspectorAgent.h:
              (WebCore::InspectorOfflineResourcesBase::~InspectorOfflineResourcesBase):
              (WebCore::InspectorOfflineResourcesBase::InspectorOfflineResourcesBase):
              (WebCore::InspectorAgent::databaseAgentResources):
              (WebCore::InspectorAgent::domStorageAgentResources):
              * inspector/InspectorDOMStorageAgent.cpp:
              (WebCore::InspectorDOMStorageAgent::Resources::clear):
              (WebCore::InspectorDOMStorageAgent::Resources::pushDataCollectedOffline):
              (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
              (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
              (WebCore::InspectorDOMStorageAgent::createOfflineStorage):
              (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
              (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
              (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
              * inspector/InspectorDOMStorageAgent.h:
              (WebCore::InspectorDOMStorageAgent::create):
              * inspector/InspectorDatabaseAgent.cpp:
              (WebCore::InspectorDatabaseAgent::Resources::clear):
              (WebCore::InspectorDatabaseAgent::Resources::pushDataCollectedOffline):
              (WebCore::InspectorDatabaseAgent::didOpenDatabase):
              (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
              (WebCore::InspectorDatabaseAgent::createOfflineStorage):
              (WebCore::InspectorDatabaseAgent::databaseForId):
              (WebCore::InspectorDatabaseAgent::selectDatabase):
              * inspector/InspectorDatabaseAgent.h:
              (WebCore::InspectorDatabaseAgent::create):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
              (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64f5d3a7
    • commit-queue@webkit.org's avatar
      2011-02-16 Sheriff Bot <webkit.review.bot@gmail.com> · b4232b23
      commit-queue@webkit.org authored
              Unreviewed, rolling out r77898.
              http://trac.webkit.org/changeset/77898
              https://bugs.webkit.org/show_bug.cgi?id=54541
      
              Leopard Debug hasn't compiled for a long time (Requested by
              abarth on #webkit).
      
              * Scripts/webkitpy/common/net/buildbot/buildbot.py:
              * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4232b23
    • philn@webkit.org's avatar
      2011-02-15 Philippe Normand <pnormand@igalia.com> · b8b2f8fc
      philn@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] media/controls-without-preload.html is flacky on 32-bits Debug
              https://bugs.webkit.org/show_bug.cgi?id=50518
      
              Refactored 2 media tests to avoid use of setTimeout and possible
              flakyness.
      
              * media/controls-without-preload.html:
              * media/video-display-toggle.html:
              * platform/gtk/Skipped:
              * platform/gtk/media/controls-without-preload-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8b2f8fc
    • philn@webkit.org's avatar
      2011-02-15 Philippe Normand <pnormand@igalia.com> · 41b8caa0
      philn@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GStreamer] wrong media duration report in media/controls-after-reload.html
              https://bugs.webkit.org/show_bug.cgi?id=51602
      
              Refactored some media tests to be less flaky-prone.
      
              * media/controls-after-reload.html: Trigger playback just before
              rendering the controls.
              * media/video-paint-test.js: Ditto.
              (init.document.addEventListener.):
              (init):
              * media/video-volume-slider.html: Trigger DRT dump after volume
              was updated.
              * platform/gtk/Skipped: Unskip fixed tests.
              * platform/gtk/media/video-controls-rendering-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41b8caa0
    • commit-queue@webkit.org's avatar
      2011-02-16 Aparna Nandyal <aparna.nand@wipro.com> · e1d85012
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] QWebFrame: When a relative url is loaded then it will make it absolute internally, however this strips out any query/fragments
              https://bugs.webkit.org/show_bug.cgi?id=29424
      
              ensureAbsoluteUrl function was stripping the query and the
              fragment part of the url. Corrected this.
      
              * Api/qwebframe.cpp:
              (ensureAbsoluteUrl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1d85012
    • sullivan@apple.com's avatar
      Dan Bernstein came up with this fix while we debugged it. I just typed. · 54b4eba0
      sullivan@apple.com authored
      Reviewed by Antti Koivisto.
      
      https://bugs.webkit.org/show_bug.cgi?id=54532
      On platforms without platformWidgets, going Back to a scrolled page 
      draws at the top-left before drawing at the restored scroll position
              
      <rdar://problem/8998838>
              
      * page/FrameView.cpp:
      (WebCore::FrameView::performPostLayoutTasks):
      Don't send the didFirstLayout and didFirstVisuallyNonEmptyLayout callbacks
      for nested layouts. Doing so was causing ScrollView::setScrollPosition()
      to short-circuit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54b4eba0
    • ossy@webkit.org's avatar
      Unreviewed. · e6d55a7f
      ossy@webkit.org authored
      [Qt][V8] Buildfix. Add missing USE(JSC) guard.
      
      Source/WebCore: 
      
      * plugins/qt/PluginViewQt.cpp:
      
      Source/WebKit/qt: 
      
      * Api/qwebelement.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6d55a7f
  2. 15 Feb, 2011 18 commits
    • commit-queue@webkit.org's avatar
      2011-02-15 Xianzhu Wang <wangxianzhu@google.com> · a1042bf0
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Fixed a small bug about --no-timeout option.
              https://bugs.webkit.org/show_bug.cgi?id=52873
      
              * DumpRenderTree/chromium/DumpRenderTree.cpp:
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1042bf0
    • tkent@chromium.org's avatar
      2011-02-15 Kent Tamura <tkent@chromium.org> · e2b6492d
      tkent@chromium.org authored
              Unreviewed, test expectation update.
      
              Chromium-Mac-Leopard baseline files for r78677.
      
              * platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
              * platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2b6492d
    • tkent@chromium.org's avatar
      2011-02-15 Kent Tamura <tkent@chromium.org> · 03a1c3d2
      tkent@chromium.org authored
              Unreviewed, test expectation update.
      
              Chromium baseline files for a new test of r78677.
      
              * platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
              * platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
              * platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
              * platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
              * platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
              * platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03a1c3d2
    • commit-queue@webkit.org's avatar
      2011-02-15 Ami Fischman <fischman@chromium.org> · 692cf891
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Remove the artificial -32px shift for media controls in mediaDocuments
              so that they overlap the canvas as they do in non-mediaDocuments.
              This also fixes test_shell failing to update the media slider (see
              linked crbug below).
      
              https://bugs.webkit.org/show_bug.cgi?id=27798
              http://crbug.com/72623
      
              Test: media/video-controls-in-media-document.html
              Added a render test that asserts that the controls show up in the
              expected spot (0,208) instead of below the canvas (0,240).
      
              * css/mediaControlsChromium.css:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      692cf891
    • rniwa@webkit.org's avatar
      2011-02-15 Ryosuke Niwa <rniwa@webkit.org> · 077e7702
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Extract a function to process ancestor and their sibling nodes from processContents
              https://bugs.webkit.org/show_bug.cgi?id=54425
      
              Extracted processAncestorsAndTheirSiblings.
      
              * dom/Range.cpp:
              (WebCore::Range::processContents): Calls processContents.
              (WebCore::Range::processAncestorsAndTheirSiblings): Extracted from processContents.
              * dom/Range.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      077e7702
    • commit-queue@webkit.org's avatar
      2011-02-15 Bill Budge <bbudge@chromium.org> · b54516ce
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
              https://bugs.webkit.org/show_bug.cgi?id=54489
      
              No tests needed, exposes no new functionality
      
              * src/WebURLRequest.cpp:
              (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl):
              (WebKit::WebURLRequest::downloadToFile):
              (WebKit::WebURLRequest::setDownloadToFile):
              * src/WebURLRequestPrivate.h:
              (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
              * src/WebURLResponse.cpp:
              (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl):
              (WebKit::WebURLResponse::downloadFilePath):
              (WebKit::WebURLResponse::setDownloadFilePath):
              * src/WebURLResponsePrivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b54516ce
    • tkent@chromium.org's avatar
      [Chromium] Rendering error of spin buttons on layers · eb14de0a
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=54427
      
      Reviewed by Darin Fisher.
      
      Source/WebCore:
      
      Test: fast/forms/input-appearance-spinbutton-layer.html
      
      * rendering/RenderThemeChromiumWin.cpp:
        Add checks for multiple ThemePainter instances.
      (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
        Avoid to create multiple ThemePainter instances.
      
      LayoutTests:
      
      * fast/forms/input-appearance-spinbutton-layer.html: Added.
      * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
      * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
      * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb14de0a
    • andersca@apple.com's avatar
      2011-02-15 Anders Carlsson <andersca@apple.com> · 37bdf9c8
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              WebPluginSiteDataManager should work with plug-in process
              https://bugs.webkit.org/show_bug.cgi?id=54523
              <rdar://problem/8689312>
      
              * PluginProcess/PluginProcess.cpp:
              (WebKit::PluginProcess::removeWebProcessConnection):
              Call startShutdownTimerIfNecessary().
      
              (WebKit::PluginProcess::getSitesWithData):
              Ask the plug-in module for the sites with data and send them back
              in a PluginProcessProxy::DidGetSitesWithData message.
      
              (WebKit::PluginProcess::clearSiteData):
              Clear site data and send back a DidClearSiteData message.
      
              (WebKit::PluginProcess::startShutdownTimerIfNecessary):
              Factor code out from removeWebProcessConnection.
      
              * PluginProcess/PluginProcess.messages.in:
              Add new messages.
      
              * UIProcess/Plugins/PluginInfoStore.cpp:
              (WebKit::PluginInfoStore::plugins):
              New function for getting all plug-ins.
      
              * UIProcess/Plugins/PluginProcessManager.cpp:
              (WebKit::PluginProcessManager::getPluginProcessConnection):
              Call getOrCreatePluginProcess.
      
              (WebKit::PluginProcessManager::getSitesWithData):
              Get a plug-in process proxy and call getSitesWithData.
      
              (WebKit::PluginProcessManager::clearSiteData):
              Get a plug-in process proxy and call clearSiteData.
      
              (WebKit::PluginProcessManager::getOrCreatePluginProcess):
              Factor code to create a plug-in process out into a separate function.
      
              * UIProcess/Plugins/PluginProcessProxy.cpp:
              (WebKit::PluginProcessProxy::getSitesWithData):
              (WebKit::PluginProcessProxy::clearSiteData):
              Update the pending reply struct. If the process is still launching,
              enqueue the request. Otherwise, just send the message.
      
              (WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
              Make sure that pending replies are sent out.
      
              (WebKit::PluginProcessProxy::didFinishLaunching):
              Send our pending requests.
      
              (WebKit::PluginProcessProxy::didGetSitesWithData):
              (WebKit::PluginProcessProxy::didClearSiteData):
              Call down to the plug-in site data manager.
      
              * UIProcess/Plugins/PluginProcessProxy.messages.in:
              Add DidGetSitesWithData and DidClearSiteData messages.
      
              * UIProcess/Plugins/WebPluginSiteDataManager.cpp:
              (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState):
              Initialize the state.
      
              (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::getSitesWithDataForNextPlugin):
              If the plug-in queue is empty, call didGetSitesWithDataForAllPlugins. Otherwise, ask
              the plug-in process manager to get sites for the next plug-in.
      
              (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::didGetSitesWithDataForSinglePlugin):
              Update the sites set and get sites for the next plug-in.
      
              (WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState):
              Initialize the state.
      
              (WebKit::WebPluginSiteDataManager::ClearSiteDataState::clearSiteDataForNextPlugin):
              If the plug-in queue is empty, call didClearSiteDataForAllPlugins. Otherwise, ask
              the plug-in process manager to get sites for the next plug-in.
              
              (WebKit::WebPluginSiteDataManager::ClearSiteDataState::didClearSiteDataForSinglePlugin):
              Update the sites set and ask the next plug-in to clear site data.
      
              (WebKit::WebPluginSiteDataManager::~WebPluginSiteDataManager):
              Assert that all maps are empty.
      
              (WebKit::WebPluginSiteDataManager::invalidate):
              Delete and clear the pending state maps.
      
              (WebKit::WebPluginSiteDataManager::getSitesWithData):
              In the ENABLE(PLUGIN_PROCESS) case, allocate a new GetSitesWithDataState object and
              tell it to get sites for the next plug-in. Otherwise, make sure that the web process
              is alive before sending a GetSitesWithPluginData message.
              
              (WebKit::WebPluginSiteDataManager::clearSiteData):
              In the ENABLE(PLUGIN_PROCESS) case, allocate a new ClearSiteDataState object and
              tell it to get sites for the next plug-in. Otherwise, make sure that the web process
              is alive before sending a ClearPluginSiteData message.
              
              (WebKit::WebPluginSiteDataManager::didGetSitesWithDataForSinglePlugin):
              Call down to the GetSitesWithDataState object.
      
              (WebKit::WebPluginSiteDataManager::didGetSitesWithDataForAllPlugins):
              Free the GetSitesWithDataState object and invoke the callback.
      
              (WebKit::WebPluginSiteDataManager::didClearSiteDataForSinglePlugin):
              Call down to the GetSitesWithDataState object.
              
              (WebKit::WebPluginSiteDataManager::didClearSiteDataForAllPlugins):
              Free the GetSitesWithDataState object and invoke the callback.
      
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::processDidClose):
              Don't invalidate the plug-in site data manager if we're using a plug-in process.
      
              * WebProcess/WebProcess.cpp:
              (WebKit::WebProcess::getSitesWithPluginData):
              (WebKit::WebProcess::clearPluginSiteData):
              Call shutdownIfPossible().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37bdf9c8
    • mrobinson@webkit.org's avatar
      2011-02-15 Martin Robinson <mrobinson@igalia.com> · 17ac09d2
      mrobinson@webkit.org authored
              Skip all Hixie SVG performance tests on GTK+. They seem
              to be timing out on the GTK+ debug bots.
      
              * platform/gtk/Skipped: Skip Hixie SVG performance tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17ac09d2
    • ddkilzer@apple.com's avatar
      2011-02-15 David Kilzer <ddkilzer@apple.com> · 0f91cc56
      ddkilzer@apple.com authored
              <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
      
              Reviewed by Darin Adler.
      
              * WebView/WebDynamicScrollBarsView.h:
              (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
              declaration.
              * WebView/WebDynamicScrollBarsView.mm:
              (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
              implementation into correct category.
              * WebView/WebDynamicScrollBarsViewInternal.h:
              (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
              declaration.
              * WebView/WebHTMLView.mm: Included
              WebDynamicScrollBarsViewInternal.h instead of
              WebDynamicScrollBarsView.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f91cc56
    • jhoneycutt@apple.com's avatar
      Copy over new WebKit 2 header. · 151e453d
      jhoneycutt@apple.com authored
      Rubber-stamped by Alice Liu.
      
      * win/WebKit2Generated.make:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      151e453d
    • sfalken@apple.com's avatar
      Skipped crashing test on Windows. · e0e6ba43
      sfalken@apple.com authored
      Tracked by https://bugs.webkit.org/show_bug.cgi?id=54519
      
      * platform/win/Skipped: Skip fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0e6ba43
    • crogers@google.com's avatar
      2011-02-15 Chris Rogers <crogers@google.com> · 7712a9a8
      crogers@google.com authored
              Reviewed by Kenneth Russell.
      
              Fix race condition in JavaScriptAudioNode
              https://bugs.webkit.org/show_bug.cgi?id=54518
      
              No new tests since audio API is not yet implemented.
      
              * webaudio/JavaScriptAudioNode.cpp:
              (WebCore::JavaScriptAudioNode::process):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7712a9a8
    • pkasting@chromium.org's avatar
      Unreviewed, Chromium test expectations update. · 3abb12ea
      pkasting@chromium.org authored
      Remove line with dupe expectations.
      
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3abb12ea
    • andersca@apple.com's avatar
      2011-02-15 Anders Carlsson <andersca@apple.com> · d08dc073
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              Implement WKPluginSiteDataManagerClearSiteData
              https://bugs.webkit.org/show_bug.cgi?id=54512
              <rdar://problem/8689312>
      
              * UIProcess/API/C/WKPluginSiteDataManager.cpp:
              (WKPluginSiteDataManagerGetTypeID):
              Implement this.
      
              (toNPClearSiteDataFlags):
              Convert WKClearSiteDataFlags to NPP_ClearSiteData flags.
              
              (WKPluginSiteDataManagerClearSiteData):
              (WKPluginSiteDataManagerClearAllSiteData):
              Call through to WebPluginSiteDataManager::clearSiteData.
      
              * UIProcess/API/C/WKPluginSiteDataManager.h:
              Change the clear functions to take a completion callback.
      
              * UIProcess/Plugins/WebPluginSiteDataManager.cpp:
              (WebKit::WebPluginSiteDataManager::clearSiteData):
              Ask the plug-in info store for all plug-in paths and send a
              ClearPluginSiteData message to the web process.
              
              (WebKit::WebPluginSiteDataManager::didClearSiteData):
              call the callback.
      
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::didClearPluginSiteData):
              Call through to the plug-in site data manager.
      
              * UIProcess/WebContext.messages.in:
              Add ClearPluginSiteData message.
      
              * WebProcess/WebProcess.cpp:
              (WebKit::WebProcess::clearPluginSiteData):
              Iterate over all the plug-in paths, creating plug-in modules and calling
              clearSiteData for each one.
      
              * WebProcess/WebProcess.h:
              * WebProcess/WebProcess.messages.in:
              Add DidClearPluginSiteData message.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d08dc073
    • mihaip@chromium.org's avatar
      2011-02-15 Mihai Parparita <mihaip@chromium.org> · c36f7499
      mihaip@chromium.org authored
              Unreviewed chromium-gpu-linux rebaseline of
              compositing/geometry/vertical-scroll-composited.html.
      
              * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
              * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c36f7499
    • pkasting@chromium.org's avatar
      Unreviewed, Chromium test expectations update. · 7fc89679
      pkasting@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fc89679
    • jorlow@chromium.org's avatar
      2011-02-10 Jeremy Orlow <jorlow@chromium.org> · bfea2341
      jorlow@chromium.org authored
              Reviewed by Nate Chapin.
      
              Throwing in an IndexedDB error or success event should lead to the transaction aborting
              https://bugs.webkit.org/show_bug.cgi?id=54249
      
              * storage/indexeddb/exception-in-event-aborts-expected.txt: Added.
              * storage/indexeddb/exception-in-event-aborts.html: Added.
                  tests new feature
              * storage/indexeddb/queued-commands-expected.txt:
              * storage/indexeddb/queued-commands.html:
                  cleaned up (while debuggign something else)
              * storage/indexeddb/request-event-propagation-expected.txt:
              * storage/indexeddb/request-event-propagation.html:
                  a few additional tests + cleanup
              * storage/indexeddb/transaction-event-propagation-expected.txt:
              * storage/indexeddb/transaction-event-propagation.html:
                  a few additional tests + cleanup
      2011-02-10  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Nate Chapin.
      
              Throwing in an IndexedDB error or success event should lead to the transaction aborting
              https://bugs.webkit.org/show_bug.cgi?id=54249
      
              When an exception is thrown but not handled  within an IDBRequests success/error event,
              we should abort the transaction.
      
              Test: storage/indexeddb/exception-in-event-aborts.html
      
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::handleEvent):
              * bindings/js/JSEventTarget.cpp:
              (WebCore::toJS):
              * bindings/v8/V8AbstractEventListener.cpp:
              (WebCore::V8AbstractEventListener::invokeEventHandler):
              * dom/EventTarget.cpp:
              (WebCore::EventTarget::uncaughtExceptionInEventHandler):
              * dom/EventTarget.h:
              * storage/IDBRequest.cpp:
              (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
              * storage/IDBRequest.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfea2341