1. 27 Aug, 2013 12 commits
    • akling@apple.com's avatar
      FocusController::focusedOrMainFrame() should return a reference. · ef7cefa6
      akling@apple.com authored
      <https://webkit.org/b/120339>
      
      Reviewed by Antti Koivisto.
      
      Now that Page::mainFrame() returns a reference, we can make this return a reference
      too, since there's always either a focused or a main frame.
      
      One hectogram of null checks removed as a result.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef7cefa6
    • kov@webkit.org's avatar
      [l10n] Updated Polish translation of WebKitGTK+ · a5dea8b3
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119986
      
      Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-08-27
      Reviewed by Gustavo Noronha Silva.
      
      * pl.po: updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5dea8b3
    • akling@apple.com's avatar
      Document's renderer is always a RenderView. · fa64c887
      akling@apple.com authored
      <https://webkit.org/b/120304>
      
      Reviewed by Darin Adler.
      
      Let's enforce this better by storing a RenderView* instead of a plain RenderObject*.
      We should switch callers that grab at Document::renderer() to calling renderView()
      instead, but that's better done separately.
      
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::~Document):
      (WebCore::Document::setRenderView):
      (WebCore::Document::createRenderTree):
      (WebCore::Document::detach):
      (WebCore::Document::setInPageCache):
      * dom/Document.h:
      (WebCore::Document::renderView):
      (WebCore::Document::renderer):
      * html/parser/HTMLResourcePreloader.cpp:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::setStyle):
      * rendering/RenderView.h:
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::updateCurrentTranslate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa64c887
    • g.czajkowski@samsung.com's avatar
      grammar-markers.html and grammar-markers-hidpi.html pass even if element does... · d2a110f7
      g.czajkowski@samsung.com authored
      grammar-markers.html and grammar-markers-hidpi.html pass even if element does not have grammar marker
      https://bugs.webkit.org/show_bug.cgi?id=119797
      
      Reviewed by Ryosuke Niwa.
      
      After tenth attempts of verifying the grammar marker, the tests call'notifyDone'
      even if grammar marker was not be found.
      
      Both grammar-marker.html and grammar-marker-hidpi.html call the text checker
      asynchronously. Therefore, we need to wait until either the grammar marker
      is found or number of attempts is reached.
      
      Dump more information whether the grammar marker was found to be sure that
      the tests do not pass when the element does not have the marker.
      
      * editing/spelling/grammar-markers-expected.txt:
      * editing/spelling/grammar-markers-hidpi-expected.txt:
      Update the expectations.
      
      * editing/spelling/grammar-markers-hidpi.html:
      * editing/spelling/grammar-markers.html:
      Dump more information.
      Additionally, pass 'document' to hasGrammarMarker instead of
      'target' as the method does not work for target/source elements.
      
      * platform/mac/editing/spelling/grammar-markers-expected.png:
      * platform/mac/editing/spelling/grammar-markers-hidpi-expected.png: Added.
      Update the expectations for Mac.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2a110f7
    • allan.jensen@digia.com's avatar
      Font's fast code path doesn't handle partial runs correctly when kerning or ligatures are enabled · 5fb0af8e
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100050
      
      Reviewed by Darin Adler.
      
      Renamed m_characterIndex to m_characterIndexOfGlyph and gave it an inline size of 10,
      which covers around 66% of all cases. The rest of the cases are now preallocated to the
      upper limit which is length of the original TextRun.
      
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::getGlyphsAndAdvancesForSimpleText):
      (WebCore::Font::selectionRectForSimpleText):
      (WebCore::Font::offsetForPositionForSimpleText):
      * platform/graphics/WidthIterator.cpp:
      (WebCore::WidthIterator::WidthIterator):
      (WebCore::WidthIterator::advanceInternal):
      * platform/graphics/WidthIterator.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fb0af8e
    • ch.dumez@sisa.samsung.com's avatar
      Implement DOM3 wheel event · 181483e1
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=94081
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Add support for DOM Level 3 WheelEvent:
      http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent
      
      Firefox, IE10 and since recently Blink already support it so
      it increases our cross-browser compatibility.
      
      The non-standard 'mousewheel' event is still supported for backward
      compatibility. Note that the deltas returned by the mousewheel and
      the wheel events are not identical:
      - They have opposite signs.
      - The wheel event reports the actual amount of pixels that should be
      scrolled while the legacy mousewheel event reports a factor of the
      number of mouse wheel ticks (using a constant multiplier).
      
      Tests: fast/events/wheelevent-basic.html
             fast/events/wheelevent-constructor.html
             fast/events/wheelevent-mousewheel-interaction.html
      
      * dom/Document.h:
      * dom/Document.idl:
      * dom/Element.h:
      * dom/Element.idl:
      * dom/EventNames.h:
      * dom/EventTarget.cpp:
      (WebCore::legacyType):
      (WebCore::EventTarget::shouldObserveLegacyType):
      (WebCore::EventTarget::setupLegacyTypeObserverIfNeeded):
      (WebCore::EventTarget::fireEventListeners):
      * dom/EventTarget.h:
      * dom/Node.cpp:
      (WebCore::Node::didMoveToNewDocument):
      (WebCore::tryAddEventListener):
      (WebCore::tryRemoveEventListener):
      (WebCore::Node::defaultEventHandler):
      * dom/WheelEvent.cpp:
      (WebCore::WheelEventInit::WheelEventInit):
      (WebCore::WheelEvent::WheelEvent):
      (WebCore::WheelEvent::initWheelEvent):
      * dom/WheelEvent.h:
      (WebCore::WheelEvent::deltaX):
      (WebCore::WheelEvent::deltaY):
      (WebCore::WheelEvent::deltaZ):
      (WebCore::WheelEvent::wheelDelta):
      (WebCore::WheelEvent::wheelDeltaX):
      (WebCore::WheelEvent::wheelDeltaY):
      * dom/WheelEvent.idl:
      * html/HTMLAttributeNames.in:
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::eventNameForAttributeName):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::addEventListener):
      (WebCore::DOMWindow::removeEventListener):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      * page/EventHandler.cpp:
      (WebCore::EventHandler::defaultWheelEventHandler):
      * plugins/blackberry/PluginViewBlackBerry.cpp:
      (WebCore::PluginView::handleWheelEvent):
      * svg/SVGElementInstance.cpp:
      * svg/SVGElementInstance.h:
      * svg/SVGElementInstance.idl:
      
      LayoutTests:
      
      Add several layout tests to check support for DOM3 wheel event.
      
      * fast/events/wheelevent-basic-expected.txt: Added.
      * fast/events/wheelevent-basic.html: Added.
      * fast/events/wheelevent-constructor-expected.txt: Added.
      * fast/events/wheelevent-constructor.html: Added.
      * fast/events/wheelevent-mousewheel-interaction-expected.txt: Added.
      * fast/events/wheelevent-mousewheel-interaction.html: Added.
      * platform/efl/fast/events/wheelevent-basic-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      181483e1
    • allan.jensen@digia.com's avatar
      Assertion while scrolling news.google.com · e57434c7
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115303
      
      Reviewed by Anders Carlsson.
      
      Do not relayout when accessing script elements during painting.
      
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e57434c7
    • hausmann@webkit.org's avatar
      [Qt] Let Page create the main Frame. · 754dada6
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120349
      
      Adjust to latest changes in WebCore::Page to create the main frame.
      
      Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-08-27
      Reviewed by Simon Hausmann.
      
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameData::QWebFrameData):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::initializeWebCorePage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      754dada6
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix GTK+ build after r154601. · b9bb159e
      carlosgc@webkit.org authored
      * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
      compilation added by mistake in r154601.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9bb159e
    • benjamin@webkit.org's avatar
      Remove DOMSettableTokenList's overload of add() and remove() · a52d31f9
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120341
      
      Reviewed by Ryosuke Niwa.
      
      Little refactoring to make other cleanups easier. Instead of modifying
      SpaceSplitString directly, rely on DOMTokenList ultimately changing
      the value, which in turn updates the tokens.
      
      * html/DOMSettableTokenList.cpp:
      * html/DOMSettableTokenList.h:
      * html/DOMTokenList.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a52d31f9
    • calvaris@igalia.com's avatar
      [GTK] Volume slider shows incorrect track when muted · d4c93624
      calvaris@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120253
      
      Reviewed by Philippe Normand.
      
      When painting the volume bar, consider that it could be muted even
      then volume is different than zero.
      
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
      painted volume as 0 when media is muted.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c93624
    • zandobersek@gmail.com's avatar
      Unreviewed GTK build fix. · 5fec8e3d
      zandobersek@gmail.com authored
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::FrameLoaderClient): Remove an assertion that was not removed in r154658.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fec8e3d
  2. 26 Aug, 2013 28 commits
    • weinig@apple.com's avatar
      EditorInternalCommand should use Frame& where possible · 1c6f6d70
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120340
      
      Reviewed by Andreas Kling.
      
      Only isSupportedFromDOM still takes a Frame*, as it still has callers that expect null to work.
      
      * dom/UserTypingGestureIndicator.cpp:
      * dom/UserTypingGestureIndicator.h:
      * editing/Editor.cpp:
      * editing/EditorCommand.cpp:
      * page/EventHandler.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c6f6d70
    • rniwa@webkit.org's avatar
      Elements in a node list of the form element's name getter should not be added to the past names map · fbb44563
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120279
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Don't add the element in the named items to the past names map when there are multiple elements.
      This matches IE10's behavior and the specified behavior in HTML5:
      http://www.w3.org/TR/2013/WD-html51-20130528/forms.html#dom-form-nameditem
      
      Test: fast/forms/past-names-map-should-not-contain-nodelist-item.html
      
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::getNamedElements):
      
      LayoutTests: 
      
      Add a regression test.
      
      * fast/forms/past-names-map-should-not-contain-nodelist-item-expected.txt: Added.
      * fast/forms/past-names-map-should-not-contain-nodelist-item.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbb44563
    • rniwa@webkit.org's avatar
      Another Windows build fix after r154658. · 60b759b1
      rniwa@webkit.org authored
      * WebView.cpp:
      (WebView::shouldClose):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60b759b1
    • commit-queue@webkit.org's avatar
      Fixing compilation warning "unused parameter" in WebPageProxy.cpp · 4088ce76
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120205
      
      Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-08-26
      Reviewed by Anders Carlsson.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::findPlugin):
      (WebKit::WebPageProxy::didBlockInsecurePluginVersion):
      Added UNUSED_PARAM to avoid warning.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4088ce76
    • rniwa@webkit.org's avatar
      Windows build fix after r154658. · dec26ee4
      rniwa@webkit.org authored
      * page/AutoscrollController.cpp:
      (WebCore::getMainFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dec26ee4
    • akling@apple.com's avatar
      Page::mainFrame() should return a reference. · 095b544b
      akling@apple.com authored
      <http://webkit.org/b/119677>
      
      Reviewed by Antti Koivisto.
      
      Page always creates the main Frame by itself now, so it will never be null during the Page's lifetime.
      
      Let Page::mainFrame() return Frame& and remove a sea of null checks.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      095b544b
    • aestes@apple.com's avatar
      Don't leak objects in HardAutorelease when OBJC_NO_GC is undefined but · 8e5f637b
      aestes@apple.com authored
      Objective-C GC is disabled at runtime.
      
      Reviewed by Darin Adler.
      
      * wtf/ObjcRuntimeExtras.h:
      (HardAutorelease):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e5f637b
    • weinig@apple.com's avatar
      Remove two unnecessary .get()s. · 29d9c7e2
      weinig@apple.com authored
      Reviewed by Anders Carlsson.
      
      * editing/Editor.h:
      (WebCore::Editor::killRing):
      (WebCore::Editor::spellChecker):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29d9c7e2
    • ap@apple.com's avatar
      [Mac] can-read-in-dragstart-event.html and can-read-in-copy-and-cut-events.html fail · a0f98c59
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=113094
      
              * platform/mac-wk2/TestExpectations:
              * platform/mac/TestExpectations:
              Updated expectations, these tests should be good now.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0f98c59
    • ap@apple.com's avatar
      WebKitTestRunner needs to protect the user's pasteboard contents while running · 68e3d992
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=81419
              <rdar://problem/11066794>
      
              Reviewed by Darin Adler.
      
              Mostly a copy/paste of DRT code.
      
              Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
              doesn't interfere with my clipboard while being run in a loop.
      
              * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
              * WebKitTestRunner/mac/PoseAsClass.h: Added.
              * WebKitTestRunner/mac/PoseAsClass.mm: Added.
              * WebKitTestRunner/mac/TestControllerMac.mm:
              (WTR::TestController::platformInitialize):
              (WTR::TestController::platformDestroy):
              * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
              * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68e3d992
    • joepeck@webkit.org's avatar
      Web Inspector: We should regenerate InspectorBackendCommands.js for Legacy Inspector.json versions · ae227297
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120242
      
      Reviewed by NOBODY (OOPS!).
      
      Source/WebCore:
      
      - Update the Inspector.json CodeGenerator to include an output_js_dir.
      - Cleanup multiple trailing newlines in some of the generated files.
      - Provide a way to not verify runtime casts, needed for Legacy inputs.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.am:
      * inspector/CodeGeneratorInspector.py:
      (resolve_all_types):
      (SmartOutput.close):
      
      Source/WebInspectorUI:
      
      - Include the iOS 6.0 Inspector.json which maps to Legacy/6.0/InspectorBackendCommands.js.
      - Provide a helper script to regenerate the backend commands file for trunk and Versions.
      - Regenerated file now includes enums and other minor changes.
      
      * Scripts/update-InspectorBackendCommands.rb: Added.
      * UserInterface/InspectorBackendCommands.js:
      * UserInterface/Legacy/6.0/InspectorBackendCommands.js:
      * Versions/Inspector-iOS-6.0.json: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae227297
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r154640. · 132bec82
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/154640
      https://bugs.webkit.org/show_bug.cgi?id=120329
      
      Caused flaky crashes on a lot of editing tests (Requested by
      rniwa on #webkit).
      
      * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
      * WebKitTestRunner/mac/PoseAsClass.h: Removed.
      * WebKitTestRunner/mac/PoseAsClass.mm: Removed.
      * WebKitTestRunner/mac/TestControllerMac.mm:
      (WTR::TestController::platformInitialize):
      (WTR::TestController::platformDestroy):
      * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
      * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      132bec82
    • mitz@apple.com's avatar
      Automatic bug reports case pain · f5e5752d
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120330
      
      Reviewed by Anders Carlsson.
      
      * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description
      of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
      “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5e5752d
    • weinig@apple.com's avatar
      AlternativeTextController should hold onto Frame as a reference · a59243b8
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120327
      
      Reviewed by Andreas Kling.
      
      While in the area I also:
        - Reference-ified Editor::killRing().
        - Const-ified Editor::m_killRing, Editor::m_spellChecker, and Editor::m_alternativeTextController.
      
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::AlternativeTextController):
      (WebCore::AlternativeTextController::stopPendingCorrection):
      (WebCore::AlternativeTextController::isSpellingMarkerAllowed):
      (WebCore::AlternativeTextController::applyAlternativeTextToRange):
      (WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
      (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
      (WebCore::AlternativeTextController::timerFired):
      (WebCore::AlternativeTextController::handleAlternativeTextUIResult):
      (WebCore::AlternativeTextController::rootViewRectForRange):
      (WebCore::AlternativeTextController::respondToChangedSelection):
      (WebCore::AlternativeTextController::respondToAppliedEditing):
      (WebCore::AlternativeTextController::respondToUnappliedEditing):
      (WebCore::AlternativeTextController::alternativeTextClient):
      (WebCore::AlternativeTextController::editorClient):
      (WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
      (WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
      (WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
      (WebCore::AlternativeTextController::insertDictatedText):
      (WebCore::AlternativeTextController::applyDictationAlternative):
      * editing/AlternativeTextController.h:
      (WebCore::AlternativeTextController::UNLESS_ENABLED):
      * editing/Editor.cpp:
      (WebCore::Editor::Editor):
      (WebCore::Editor::addToKillRing):
      * editing/Editor.h:
      (WebCore::Editor::killRing):
      * editing/EditorCommand.cpp:
      (WebCore::executeYank):
      (WebCore::executeYankAndSelect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a59243b8
    • aestes@apple.com's avatar
      Fix issues found by the Clang Static Analyzer · a872654a
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120230
      
      Reviewed by Darin Adler.
      
      Source/JavaScriptCore:
      
      * API/JSValue.mm:
      (valueToString): Don't leak every CFStringRef when in Objective-C GC.
      * API/ObjCCallbackFunction.mm:
      (JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl): Don't
      release m_invocation's target since NSInvocation will do it for us on
      -dealloc.
      (objCCallbackFunctionForBlock): Tell NSInvocation to retain its target
      and -release our reference to the copied block.
      * API/tests/minidom.c:
      (createStringWithContentsOfFile): Free buffer before returning.
      * API/tests/testapi.c:
      (createStringWithContentsOfFile): Ditto.
      
      Source/WebCore:
      
      * WebCore.xcodeproj/project.pbxproj: Removed FoundationExtras.h.
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed CFAutoreleaseHelper().
      (AXTextMarkerRange): Used HardAutorelease() instead of
      CFAutoreleaseHelper().
      (AXTextMarkerRangeStart): Ditto.
      (AXTextMarkerRangeEnd): Ditto.
      (textMarkerForVisiblePosition): Ditto.
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (-[WebCoreAVFMovieObserver initWithCallback:]): Called [super init]
      first so that we don't later use ivars from the wrong self.
      (-[WebCoreAVFLoaderDelegate initWithCallback:]): Ditto.
      * platform/mac/FoundationExtras.h: Removed.
      * platform/mac/KURLMac.mm:
      (WebCore::KURL::operator NSURL *): Used WTF's HardAutorelease().
      * platform/mac/WebCoreNSURLExtras.mm:
      (WebCore::mapHostNameWithRange): Used HardAutorelease() instead of
      WebCoreCFAutorelease().
      (WebCore::URLWithData): Ditto.
      (WebCore::userVisibleString): Ditto.
      (WebCore::URLByRemovingComponentAndSubsequentCharacter): Used Vector<>
      with an inline capacity rather than heap-allocating a buffer.
      * platform/mac/WebCoreObjCExtras.h: Used HardAutorelease() instead of
      WebCoreCFAutorelease().
      * platform/text/mac/StringImplMac.mm:
      (WTF::StringImpl::operator NSString *): Used WTF's HardAutorelease().
      
      Source/WebKit/mac:
      
      * Misc/WebNSFileManagerExtras.mm:
      (-[NSFileManager _webkit_startupVolumeName]): Used HardAutorelease()
      instead of WebCFAutorelease().
      * Misc/WebNSObjectExtras.h: Removed definition of WebCFAutorelease().
      * Misc/WebNSURLExtras.mm:
      (-[NSURL _web_URLWithLowercasedScheme]): Used HardAutorelease()
      instead of WebCFAutorelease().
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView createPluginLayer]): Stop leaking
      CGColors (CALayer retains its backgroundColor property despite the
      property attributes claiming otherwise).
      * Plugins/WebBasePluginPackage.mm:
      (+[WebBasePluginPackage preferredLocalizationName]): Used
      HardAutorelease() instead of WebCFAutorelease().
      * WebView/WebDeviceOrientationProviderMock.mm:
      (-[WebDeviceOrientationProviderMockInternal lastOrientation]): Stop
      leaking WebDeviceOrientations.
      * WebView/WebPDFRepresentation.mm:
      (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Used
      HardAutorelease() instead of WebCFAutorelease().
      * WebView/WebView.mm:
      (+[WebView _setCacheModel:]): Ditto.
      (-[WebView _removeObjectForIdentifier:]): Ditto.
      
      Source/WebKit2:
      
      * UIProcess/API/mac/WKBrowsingContextController.mm:
      (autoreleased): Don't leak CFURLs when in Objective-C GC.
      * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
      (-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
      Don't leak CFStrings when in Objective-C GC.
      
      Source/WTF:
      
      * wtf/ObjcRuntimeExtras.h:
      (HardAutorelease): Added a canonical implementation of HardAutorelease.
      
      Tools:
      
      * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
      (-[LocalPasteboard initWithName:]): Called [super init] first so that we
      don't later use ivars from the wrong self.
      * DumpRenderTree/mac/TestRunnerMac.mm:
      (-[APITestDelegate initWithCompletionCondition:]): Ditto.
      * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
      (TestWebKitAPI::TEST): Don't leak WKProcessGroups,
      WKBrowsingContextGroups, and WKViews.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a872654a
    • ossy@webkit.org's avatar
      [WK2] Buildfix for non Mac platforms · fffbb73f
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120294
      
      Reviewed by Darin Adler.
      
      * NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
      (WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):
      * NetworkProcess/NetworkResourceLoader.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fffbb73f
    • psolanki@apple.com's avatar
      Page::console() should return a reference · e21e3899
      psolanki@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120320
      
      Reviewed by Darin Adler.
      
      Page::m_console is never NULL so console() can just return a reference.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::logError):
      * dom/Document.cpp:
      (WebCore::Document::addConsoleMessage):
      (WebCore::Document::addMessage):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::pageConsole):
      * page/Page.h:
      (WebCore::Page::console):
      * xml/XSLStyleSheetLibxslt.cpp:
      (WebCore::XSLStyleSheet::parseString):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::docLoaderFunc):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e21e3899
    • rwlbuis@webkit.org's avatar
      Lonely stop crashes · a945c700
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87964
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint.
      
      Test: svg/custom/stop-crash-hittest.svg
      
      * rendering/svg/RenderSVGGradientStop.h:
      
      LayoutTests:
      
      Add testcase by taking stop-crash.svg and adding hittest instructions.
      
      * svg/custom/stop-crash-hittest-expected.txt: Added.
      * svg/custom/stop-crash-hittest.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a945c700
    • weinig@apple.com's avatar
      Editor::spellChecker() should return a reference · 35ba0bb9
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120325
      
      Reviewed by Anders Carlsson.
      
      * editing/Editor.cpp:
      (WebCore::Editor::Editor):
      * editing/Editor.h:
      (WebCore::Editor::spellChecker):
      * editing/SpellChecker.cpp:
      (WebCore::SpellChecker::SpellChecker):
      (WebCore::SpellChecker::client):
      (WebCore::SpellChecker::isAsynchronousEnabled):
      (WebCore::SpellChecker::didCheck):
      (WebCore::SpellChecker::didCheckSucceed):
      * editing/SpellChecker.h:
      * page/EditorClient.h:
      * testing/Internals.cpp:
      (WebCore::Internals::lastSpellCheckRequestSequence):
      (WebCore::Internals::lastSpellCheckProcessedSequence):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35ba0bb9
    • roger_fong@apple.com's avatar
      AppleWin build fix following r154627. · e8a3063f
      roger_fong@apple.com authored
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8a3063f
    • bjonesbe@adobe.com's avatar
      Optimize FloatIntervalSearchAdapter::collectIfNeeded · 0b48ff6d
      bjonesbe@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120237
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      This is a port of 3 Blink patches:
      https://codereview.chromium.org/22463002 (By shatch@chromium.org)
      https://chromiumcodereview.appspot.com/22909005 (By me)
      https://chromiumcodereview.appspot.com/23084002 (By me)
      
      shatch optimized FloatIntervalSearchAdapter by having it store the
      outermost float instead of making a bunch of calls to
      logical(Left/Right/Bottom)ForFloat, and then only making that call
      once when heightRemaining needs to be computed.
      
      I noticed that now we were storing both the last float encountered and
      the outermost float, and that the behavior for shape-outside wasn't
      significantly changed by using the outermost float instead of the last
      float encountered (and in most cases, using the outermost float gives
      more reasonable behavior). Since this isn't covered in the spec yet, I
      changed shape-outside to use the outermost float, making it so that we
      only need to store one float pointer when walking the placed floats
      tree, and keeping the performance win.
      
      Also while changing updateOffsetIfNeeded, removed const, since that is
      a lie. Nothing about that method is const.
      
      Test: fast/shapes/shape-outside-floats/shape-outside-floats-outermost.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::::updateOffsetIfNeeded):
      (WebCore::::collectIfNeeded):
      (WebCore::::getHeightRemaining):
      (WebCore::RenderBlock::logicalLeftFloatOffsetForLine):
      (WebCore::RenderBlock::logicalRightFloatOffsetForLine):
      * rendering/RenderBlock.h:
      (WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
      (WebCore::RenderBlock::FloatIntervalSearchAdapter::outermostFloat):
      
      LayoutTests:
      
      Test shape-outside behavior when there is more than one float on a
      given line.
      
      * fast/shapes/shape-outside-floats/shape-outside-floats-outermost-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-outermost.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b48ff6d
    • ap@apple.com's avatar
      WebKitTestRunner needs to protect the user's pasteboard contents while running · 94145085
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=81419
              <rdar://problem/11066794>
      
              Reviewed by Darin Adler.
      
              Mostly a copy/paste of DRT code.
      
              Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
              doesn't interfere with my clipboard while being run in a loop.
      
              * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
              * WebKitTestRunner/mac/PoseAsClass.h: Added.
              * WebKitTestRunner/mac/PoseAsClass.mm: Added.
              * WebKitTestRunner/mac/TestControllerMac.mm:
              (WTR::TestController::platformInitialize):
              (WTR::TestController::platformDestroy):
              * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
              * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94145085
    • ap@apple.com's avatar
      [Mac] can-read-in-dragstart-event.html and can-read-in-copy-and-cut-events.html fail · 430f15b8
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=113094
      
              Reviewed by Darin Adler.
      
              Mac platform implementation has checks for pasteboard change count, but it
              didn't use to update the count when writing to pasteboad from JavaScript.
      
              * platform/PasteboardStrategy.h: Changed changeCount function to return a long
              instead of an int, as the underlying Mac type is NSInteger. Changed all methods
              that modify the pasteboard to return a new change count.
      
              * platform/PlatformPasteboard.h: Changed all methods that modify the pasteboard
              to return a new change count.
      
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::clear): Update m_changeCount.
              (WebCore::Pasteboard::writeSelectionForTypes): Ditto.
              (WebCore::Pasteboard::writePlainText): Ditto.
              (WebCore::writeURLForTypes): Ditto.
              (WebCore::Pasteboard::writeURL): Ditto.
              (WebCore::writeFileWrapperAsRTFDAttachment): Ditto.
              (WebCore::Pasteboard::writeImage): Ditto.
              (WebCore::Pasteboard::writePasteboard): Ditto.
              (WebCore::addHTMLClipboardTypesForCocoaType): Ditto.
              (WebCore::Pasteboard::writeString): Ditto.
      
              * platform/mac/PlatformPasteboardMac.mm:
              (WebCore::PlatformPasteboard::changeCount): Changed returned type to long to avoid
              data loss.
              (WebCore::PlatformPasteboard::copy): Return new change count.
              (WebCore::PlatformPasteboard::addTypes): Ditto.
              (WebCore::PlatformPasteboard::setTypes): Ditto.
              (WebCore::PlatformPasteboard::setBufferForType): Ditto.
              (WebCore::PlatformPasteboard::setPathnamesForType): Ditto.
              (WebCore::PlatformPasteboard::setStringForType): Ditto. Replaced -[NSURL writeToPasteboard:]
              with an equivalent implemnentation that tells use whether writing was successful.
              There is difference with invalid URL string handling - we used to silently ignore
              such requets, but set pasteboard content to empty URL now.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      430f15b8
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build fix after r154629. · 15802aa3
      bfulgham@apple.com authored
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add missing build files.
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15802aa3
    • rniwa@webkit.org's avatar
      Another GTK+ build fix. · 0ed17abb
      rniwa@webkit.org authored
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ed17abb
    • rniwa@webkit.org's avatar
      GTK+ build fix. Like r154620. · ecee4cb7
      rniwa@webkit.org authored
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_new):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecee4cb7
    • rniwa@webkit.org's avatar
      Windows build fix attempt after r154629. · a4cd5517
      rniwa@webkit.org authored
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4cd5517
    • roger_fong@apple.com's avatar
      Unreviewed. Add missing interface files that were left out in r154627. · 4c1ed0d6
      roger_fong@apple.com authored
      * Interfaces/Accessible2/AccessibleEditableText.idl: Added.
      * Interfaces/Accessible2/AccessibleText.idl: Added.
      * Interfaces/Accessible2/AccessibleText2.idl: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c1ed0d6