1. 18 Apr, 2012 13 commits
    • antti@apple.com's avatar
      matchMedia() MediaQueryList not updating · ef75e9e9
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75903
      
      Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-18
      Reviewed by Antti Koivisto.
      
      Source/WebCore: 
      
      Test: fast/media/media-query-list-08.html
      
      Viewport related MediaQueryList listeners were not triggered and the value
      of matches were not updated if the document's style selector were not
      affected by viewport changes.
      
      The new method evaluateMediaQueries() is now called by FrameView instead of
      styleSelectorChanged() if the style selector is not affected by viewport changes.
      
      * dom/Document.cpp:
      (WebCore::Document::evaluateMediaQueries):
      (WebCore):
      (WebCore::Document::styleSelectorChanged):
      * dom/Document.h:
      (Document):
      * page/FrameView.cpp:
      (WebCore::FrameView::layout):
      
      LayoutTests: 
      
      Testing MediaQueryLists listeners related to viewport changes.
      
      * fast/media/media-query-list-08-expected.txt: Added.
      * fast/media/media-query-list-08.html: Added.
      
      Skipping the new test in Mac and Qt due to an issue in its DumpRenderTree.
      
      * platform/qt/Skipped:
      * platform/mac/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef75e9e9
    • philn@webkit.org's avatar
      Unreviewed, GTK test_expectations update. · e65320a4
      philn@webkit.org authored
      * platform/gtk/test_expectations.txt: Skip some failing tests and
      mark 3 more frame flattening tests flaky.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e65320a4
    • pfeldman@chromium.org's avatar
      Source/WebCore: Web Inspector: [Chromium] Module's require injects scripts... · 46849f81
      pfeldman@chromium.org authored
      Source/WebCore: Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
      https://bugs.webkit.org/show_bug.cgi?id=84166
      
      Re-applying r114497.
      
      * bindings/v8/V8IsolatedContext.cpp:
      (WebCore::setInjectedScriptContextDebugId):
      (WebCore):
      (WebCore::V8IsolatedContext::V8IsolatedContext):
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::evaluateInIsolatedWorld):
      * bindings/v8/V8Proxy.h:
      (V8Proxy):
      
      LayoutTests: Unreviewed, rolling out r114506.
      http://trac.webkit.org/changeset/114506
      https://bugs.webkit.org/show_bug.cgi?id=84254
      
      Seems to be making gtk's DumpRenderTree crash occasionally
      (Requested by tomz on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
      
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46849f81
    • enne@google.com's avatar
      [chromium] Unreviewed, rebaseline compositing tests after r114283. · 6017295a
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84083
      
      * platform/chromium-linux/compositing/overflow/overflow-positioning-expected.png:
      * platform/chromium-mac-leopard/compositing/overflow/overflow-positioning-expected.png: Added.
      * platform/chromium-mac-snowleopard/compositing/overflow/overflow-positioning-expected.png:
      * platform/chromium-mac/compositing/overflow/overflow-positioning-expected.png:
      * platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt: Added.
      * platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
      * platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt: Added.
      * platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
      * platform/chromium-win/compositing/overflow/overflow-positioning-expected.png:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6017295a
    • tomz@codeaurora.org's avatar
      Unreviewed, rolling out r114506. · eb66fc4a
      tomz@codeaurora.org authored
      http://trac.webkit.org/changeset/114506
      https://bugs.webkit.org/show_bug.cgi?id=84254
      
      Seems to be making gtk's DumpRenderTree crash occasionally
      (Requested by tomz on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebsettings.cpp:
      (webkit_web_settings_class_init):
      (webkit_web_settings_set_property):
      (webkit_web_settings_get_property):
      * webkit/webkitwebsettingsprivate.h:
      * webkit/webkitwebview.cpp:
      (webkit_web_view_update_settings):
      (webkit_web_view_settings_notify):
      
      Tools:
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (resetDefaultsToConsistentValues):
      
      LayoutTests:
      
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb66fc4a
    • simon.fraser@apple.com's avatar
      ASSERT when a layer with a foreground layer is in 'paint into ancestor' mode · c0fc313a
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84221
      
      Source/WebCore:
      
      Reviewed by Dean Jackson.
      
      When a RenderLayerBacking doesn't require its own backing store, and is
      in "paintIntoCompositingAncestor" mode, we would assert when trying to
      paint its m_foregroundLayer if it had one (because of a negative z-index child).
      
      The fix is to set the 'drawsContent' state on the m_foregroundLayer
      as well as m_graphicsLayer.
      
      Test: compositing/backing/no-backing-foreground-layer.html
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateDrawsContent):
      
      LayoutTests:
      
      Reviewed by Dean Jackson.
      
      New testcase.
      
      * compositing/backing/no-backing-foreground-layer-expected.txt: Added.
      * compositing/backing/no-backing-foreground-layer.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0fc313a
    • commit-queue@webkit.org's avatar
      [GTK] r114021 triggered media flakyness · 49ee4cd4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83874
      
      Patch by Simon Pena <spena@igalia.com> on 2012-04-18
      Reviewed by Philippe Normand.
      
      Source/WebKit/gtk:
      
      When the MediaPlaybackRequiresUserGesture setting was added, no gtk
      API was implemented to access it.
      
      This adds a property to gtk WebKit WebSettings, and connects it to
      WebKit WebView, thus allowing clients to programmatically modify it.
      
      * webkit/webkitwebsettings.cpp:
      (webkit_web_settings_class_init):
      (webkit_web_settings_set_property):
      (webkit_web_settings_get_property):
      * webkit/webkitwebsettingsprivate.h:
      * webkit/webkitwebview.cpp:
      (webkit_web_view_update_settings):
      (webkit_web_view_settings_notify):
      
      Tools:
      
      Now that there is gtk API to update the
      MediaPlaybackRequiresUserGesture property, set it to false from the
      DumpRenderTree tool when resetting defaults to consistent values.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (resetDefaultsToConsistentValues):
      
      LayoutTests:
      
      media/video-load-require-user-gesture.html and
      media/video-play-require-user-gesture.html where enabling
      MediaPlaybackRequiresUserGesture when run, so tests running
      concurrently would fail -they would pass when run independently.
      
      Since new API is added to ensure DumpRenderTree is able to reset
      that setting, having media/video-load-require-user-gesture.html and
      media/video-play-require-user-gesture.html no longer causes
      flakiness.
      
      * platform/gtk/test_expectations.txt: Unskip
      media/video-load-require-user-gesture.html and
      media/video-play-require-user-gesture.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49ee4cd4
    • yurys@chromium.org's avatar
      Web Inspector: DataGrid should use explicit root node · 9afdfc33
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84240
      
      DataGrid now has an explicit root node. All children are added/removed
      to that node.
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * inspector/front-end/ApplicationCacheItemsView.js:
      (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
      (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
      * inspector/front-end/CSSSelectorProfileView.js:
      (WebInspector.CSSSelectorProfileView):
      (WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
      (WebInspector.CSSSelectorProfileView.prototype.refreshData):
      * inspector/front-end/CookieItemsView.js:
      (WebInspector.SimpleCookiesTable):
      (WebInspector.SimpleCookiesTable.prototype.setCookies):
      * inspector/front-end/CookiesTable.js:
      (WebInspector.CookiesTable):
      (WebInspector.CookiesTable.prototype._rebuildTable):
      * inspector/front-end/DOMStorageItemsView.js:
      (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
      * inspector/front-end/DataGrid.js:
      (WebInspector.DataGrid):
      (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
      (WebInspector.DataGrid.createSortableDataGrid):
      (WebInspector.DataGrid.prototype.setRootNode):
      (WebInspector.DataGrid.prototype.rootNode):
      (WebInspector.DataGrid.prototype.autoSizeColumns):
      (WebInspector.DataGrid.prototype._enumerateChildren):
      (WebInspector.DataGrid.prototype._keyDown):
      (WebInspector.DataGrid.prototype._contextMenuInDataTable):
      (WebInspector.DataGridNode.prototype.get revealed):
      (WebInspector.DataGridNode.prototype.get depth):
      (WebInspector.DataGridNode.prototype.appendChild):
      (WebInspector.DataGridNode.prototype.insertChild):
      (WebInspector.DataGridNode.prototype.removeChild):
      (WebInspector.DataGridNode.prototype.removeChildren):
      (WebInspector.DataGridNode.prototype.collapse):
      (WebInspector.DataGridNode.prototype.expand):
      (WebInspector.DataGridNode.prototype.reveal):
      (WebInspector.DataGridNode.prototype.revealAndSelect):
      (WebInspector.DataGridNode.prototype.traverseNextNode):
      (WebInspector.DataGridNode.prototype.traversePreviousNode):
      * inspector/front-end/HeapSnapshotDataGrids.js:
      (WebInspector.HeapSnapshotSortableDataGrid):
      (WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
      (WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
      (WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
      (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
      (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
      (WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
      (WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
      (WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
      (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
      (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
      (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
      (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
      (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
      (WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
      (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
      * inspector/front-end/HeapSnapshotGridNodes.js:
      (WebInspector.HeapSnapshotGenericObjectNode):
      * inspector/front-end/HeapSnapshotView.js:
      (WebInspector.HeapSnapshotView.prototype.performSearch):
      (WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
      * inspector/front-end/IndexedDBViews.js:
      (WebInspector.IDBDataView.prototype._createDataGrid):
      (WebInspector.IDBDataView.prototype._updateData.callback):
      (WebInspector.IDBDataView.prototype._updateData):
      (WebInspector.IDBDataView.prototype.clear):
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkLogView.prototype._createTable):
      (WebInspector.NetworkLogView.prototype.refresh):
      (WebInspector.NetworkLogView.prototype._reset):
      * inspector/front-end/ProfileDataGridTree.js:
      (WebInspector.ProfileDataGridNode.prototype.insertChild):
      (WebInspector.ProfileDataGridNode.prototype.removeChild):
      (WebInspector.ProfileDataGridNode.prototype.removeChildren):
      * inspector/front-end/ProfileView.js:
      (WebInspector.CPUProfileView.prototype.refresh):
      * inspector/front-end/treeoutline.js:
      
      LayoutTests:
      
      * inspector/profiler/heap-snapshot-test.js:
      (initialize_HeapSnapshotTest):
      * inspector/storage-panel-dom-storage.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9afdfc33
    • schenney@chromium.org's avatar
      Layout Test svg/transforms/transform-origin-css-property.xhtml is failing · c0d9c8d2
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84203
      
      Unreviewed test expectation fix.
      
      The svg/transforms/transform-origin-css-property.xhtml test has a
      ref-test for it, so there should not be any image expectations. If the
      test if failing, we need to look at why the ref test is not valid, or
      why we differ.
      
      The expectations file update here is just some cleanup for
      https://bugs.webkit.org/show_bug.cgi?id=84230.
      
      * platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Removed.
      * platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Removed.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0d9c8d2
    • toyoshim@chromium.org's avatar
      Unreviewed, update expectations · 975e96e5
      toyoshim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84230
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      975e96e5
    • pfeldman@chromium.org's avatar
      Web Inspector: document.open removes the documentElement, but does not clear the elements panel. · 21ca2f19
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84179
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Perform total update upon modifications of the document node.
      
      Test: inspector/elements/delete-from-document.html
      
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::didRemoveDOMNode):
      * inspector/front-end/ElementsTreeOutline.js:
      
      LayoutTests:
      
      * http/tests/inspector/elements-test.js:
      (initialize_ElementTest.InspectorTest.dumpElementsTree.print):
      (initialize_ElementTest.InspectorTest.dumpElementsTree):
      * inspector/elements/delete-from-document-expected.txt: Added.
      * inspector/elements/delete-from-document.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21ca2f19
    • commit-queue@webkit.org's avatar
      Source/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio · 1ed2613e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82930
      Support for concurrent HTML5 audio improvements being made in
      the platform library, which need to be aware of tabs and tab
      visibility. PR96004.
      
      Patch by Max Feil <mfeil@rim.com> on 2012-04-18
      Reviewed by George Staikos.
      
      Test: media/audio-concurrent-supported.html
      
      * platform/blackberry/PageClientBlackBerry.h:
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
      (WebCore::MediaPlayerPrivate::showErrorDialog):
      (WebCore::MediaPlayerPrivate::isTabVisible):
      (WebCore):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
      (MediaPlayerPrivate):
      
      Source/WebKit/blackberry: [BlackBerry] Tab awareness for HTML5 concurrent audio
      https://bugs.webkit.org/show_bug.cgi?id=82930
      Support for concurrent HTML5 audio improvements being made in
      the platform library, which need to be aware of tabs and tab
      visibility. PR96004.
      
      Patch by Max Feil <mfeil@rim.com> on 2012-04-18
      Reviewed by George Staikos.
      
      * Api/WebPageClient.h:
      * Api/WebPage_p.h:
      (BlackBerry::WebKit::WebPagePrivate::isVisible):
      
      LayoutTests: [BlackBerry] Tab awareness for HTML5 concurrent audio
      https://bugs.webkit.org/show_bug.cgi?id=82930
      Layout test for concurrent HTML5 audio. This is a simple test
      to confirm that multiple audio elements can play at the same time.
      
      Patch by Max Feil <mfeil@rim.com> on 2012-04-18
      Reviewed by George Staikos.
      
      * media/audio-concurrent-supported-expected.txt: Added.
      * media/audio-concurrent-supported.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ed2613e
    • kkristof@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM · a97b6fb9
      kkristof@inf.u-szeged.hu authored
      Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-18
      
      * platform/qt/Skipped: fast/dom/shadow/adopt-node-with-shadow-root.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a97b6fb9
  2. 17 Apr, 2012 27 commits