1. 24 May, 2007 7 commits
  2. 23 May, 2007 32 commits
    • hyatt's avatar
      Add a table test for comment nodes. · fe679e1b
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe679e1b
    • hyatt's avatar
      Make the delete/InsertRows/Cells methods as well as the rowIndex method · 4e410bd7
      hyatt authored
              able to work properly even when whitespace or comment nodes are present.
      
              Reviewed by aroben
      
              fast/table/rowindex-comment-nodes.html
      
              * html/HTMLTableRowElement.cpp:
              (WebCore::HTMLTableRowElement::rowIndex):
              (WebCore::HTMLTableRowElement::insertCell):
              (WebCore::HTMLTableRowElement::deleteCell):
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::insertRow):
              (WebCore::HTMLTableSectionElement::deleteRow):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e410bd7
    • hyatt's avatar
      Land optgroup DTD test. · c1f254d0
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1f254d0
    • hyatt's avatar
      <optgroup> should allow <script> and text nodes inside it, just like · a9490fe9
      hyatt authored
              <select> does.
      
              Reviewed by aroben
      
              fast/forms/stuff-on-my-optgroup.html
      
              * html/HTMLOptGroupElement.cpp:
              (WebCore::HTMLOptGroupElement::checkDTD):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::checkDTD):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9490fe9
    • hyatt's avatar
      Add gigantic z-index test. · e64a85d6
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e64a85d6
    • hyatt's avatar
      Framesets should allow whitespace text nodes as children. · 4f25e175
      hyatt authored
              Reviewed by aroben
      
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::checkDTD):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f25e175
    • bdash's avatar
      Fix the Qt build after r21685. · 131a68c9
      bdash authored
              * platform/qt/CursorQt.cpp:
              (WebCore::notAllowedCursor):
              (WebCore::zoomInCursor):
              (WebCore::zoomOutCursor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      131a68c9
    • bdash's avatar
      Reviewed by Adam. · c16ac6a4
      bdash authored
              Fix the gdk build following changes in r21685.
      
              * platform/gdk/CursorGdk.cpp:
              (WebCore::zoomInCursor):
              (WebCore::zoomOutCursor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c16ac6a4
    • hyatt's avatar
      Fix for <rdar://problem/5222611> REGRESSION: Paint ordering problems at · fe9c69b1
      hyatt authored
              http://buymeasoda.com/dev/issues/image_onload/image_onload.html
      
              Clamp z-index so that values that exceed maxint (or that are below minint)
              are clamped to those values.
      
              Reviewed by darin
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe9c69b1
    • ddkilzer's avatar
      LayoutTests: · 27a28d44
      ddkilzer authored
              Reviewed by David Hyatt.
      
              - tests for http://bugs.webkit.org/show_bug.cgi?id=13563
                REGRESSION: Crash loading message in Yahoo! Mail
      
              * fast/css/stale-style-selector-crash-1-expected.txt: Added.
              * fast/css/stale-style-selector-crash-1.html: Added.
              * fast/css/stale-style-selector-crash-2-expected.txt: Added.
              * fast/css/stale-style-selector-crash-2.html: Added.
      
      WebCore:
      
              Reviewed by David Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13563
                REGRESSION: Crash loading message in Yahoo! Mail
      
              Tests: fast/css/stale-style-selector-crash-1.html
                     fast/css/stale-style-selector-crash-2.html
      
              * dom/Document.cpp:
              (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector
              flag to 'false'.
              (WebCore::Document::updateStyleSelector): Do not bail out if we have ever
              calculated a non-trivial style selector, even if at the moment we are
              pending style sheets. We could have calculated a non-trivial selector
              already either because at some point there were no pending style sheets
              (so the currently pending ones were added dynamically) or because we were
              forced to do a layout ignoring pending style sheets. Either way, once
              there is a style selector, we need to keep it up to date, otherwise we can
              crash under recalcStyle() during updateRendering() or simply not recalculate
              style correctly for dynamic changes.
              (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector
              to 'true' when creating a new style selector.
              * dom/Document.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27a28d44
    • andersca's avatar
      Reviewed by Adam. · 9a44838d
      andersca authored
              <rdar://problem/5224749> Show a zoom/unzoom cursor for resizable image documents
              
              * WebCore.xcodeproj/project.pbxproj:
              Install the zoom cursors.
              
              * loader/ImageDocument.cpp:
              (WebCore::ImageDocument::resizeImageToFit):
              Set the cursor to the zoom in cursor.
              
              (WebCore::ImageDocument::restoreImageSize):
              If the image fits, reset the cursor. Otherwise, set it to the zoom in cursor.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a44838d
    • andersca's avatar
      Reviewed by Geoff. · 662d7bac
      andersca authored
              <rdar://problem/3663808> Resize large images to fit in the browser window
              
              Add new WebPreferences SPI.
              
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.m:
              (+[WebPreferences initialize]):
              (-[WebPreferences enableAutomaticImageResizing]):
              (-[WebPreferences setEnableAutomaticImageResizing:]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _updateWebCoreSettingsFromPreferences:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      662d7bac
    • darin's avatar
      LayoutTests: · 258af4a1
      darin authored
              Reviewed by Hyatt.
      
              - updated the many tests with an extra newline or two at the end
                because of the bug where plain-text serialization will consider
                nodes that are not rendered
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix problems where unrendered nodes were affecting on plain text serialization
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for
              nodes without renderers.
              (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding
              if this is the last node in the document.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      258af4a1
    • andersca's avatar
      Reviewed by Geoff. · 542a4a0d
      andersca authored
              <rdar://problem/3663808> Resize large images to fit in the browser window
              
              * WebCore.exp:
              Add new settings method.
              
              * loader/ImageDocument.cpp:
              (WebCore::ImageEventListener::ImageEventListener):
              New class that handles resize events and click events and forwards them to the image document.
              
              (WebCore::ImageTokenizer::ImageTokenizer):
              (WebCore::ImageTokenizer::writeRawData):
              (WebCore::ImageTokenizer::finish):
              (WebCore::ImageDocument::ImageDocument):
              (WebCore::ImageDocument::createDocumentStructure):
              (WebCore::ImageDocument::cachedImage):
              Let the ImageDocument class keep track of its document structure.
              
              (WebCore::ImageDocument::scale):
              Returns the scale that should be used when resizing the image.
              
              (WebCore::ImageDocument::resizeImage):
              Update the image size.
              
              (WebCore::ImageDocument::imageClicked):
              Toggle between resized and not resized. When restoring the size, scroll the image so that the area under
              the mouse stays the same.
              
              (WebCore::ImageDocument::imageChanged):
              When the image size is known, resize the image if needed.
              
              (WebCore::ImageDocument::restoreImageSize):
              Restore the image size.
              
              (WebCore::ImageDocument::imageNeedsResizing):
              Return whether the image is too big for its window or not.
              
              (WebCore::ImageDocument::windowSizeChanged):
              Called when the window's size changes. Determine if the window fits or not and resize it if it doesn't fit.
              
              (WebCore::ImageEventListener::handleEvent):
              Forward events to the image document.
              
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setEnableAutomaticImageResizing):
              * page/Settings.h:
              (WebCore::Settings::enableAutomaticImageResizing):
              Add new setting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      542a4a0d
    • andersca's avatar
      Reviewed by Darin. · 1500e83b
      andersca authored
              Add -webkit-zoom-in and -webkit-zoom-out cursors.
              
              * Resources/zoomInCursor.png: Added.
              * Resources/zoomOutCursor.png: Added.
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSValueKeywords.in:
              * page/EventHandler.cpp:
              (WebCore::selectCursor):
              * platform/Cursor.h:
              * platform/mac/CursorMac.mm:
              (WebCore::zoomInCursor):
              (WebCore::zoomOutCursor):
              * rendering/RenderStyle.h:
              (WebCore::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1500e83b
    • weinig's avatar
      Reviewed by Darin. · 6f17861a
      weinig authored
              Part one of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              - Just the HTMLElement part.
      
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLElement::getValueProperty):
              (KJS::JSHTMLElement::putValueProperty):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * html/HTMLElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f17861a
    • kmccullo's avatar
      LayoutTests: · ef9bbdef
      kmccullo authored
              Reviewed by Darin.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of 
              the rest of HTMLElement
      
              - Corrects prototype chain for JSHTMLDocument and adds test
                for HTMLFormElement.
      
              * fast/dom/prototype-chain-expected.txt:
              * fast/dom/prototype-chain.html:
      
      WebCore:
      
              Reviewed by Darin.
      
              - rdar://problem/5183523
              - We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::load):
              (WebCore::FrameLoader::open):
              * platform/PlatformString.h:
              (WebCore::debugPrintString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef9bbdef
    • weinig's avatar
      LayoutTests: · 661a37fc
      weinig authored
              Reviewed by Darin.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of 
              the rest of HTMLElement
      
              - Corrects prototype chain for JSHTMLDocument and adds test
                for HTMLFormElement.
      
              * fast/dom/prototype-chain-expected.txt:
              * fast/dom/prototype-chain.html:
      
      WebCore:
      
              Reviewed by Darin.
      
              Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              - Just the HTMLDocument part.
      
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLDocumentCustom.cpp: Added.
              (WebCore::JSHTMLDocument::canGetItemsForName):
              (WebCore::JSHTMLDocument::nameGetter):
              (WebCore::JSHTMLDocument::all):
              (WebCore::JSHTMLDocument::setAll):
              (WebCore::JSHTMLDocument::location):
              (WebCore::JSHTMLDocument::setLocation):
              (WebCore::JSHTMLDocument::open):
              (WebCore::writeHelper):
              (WebCore::JSHTMLDocument::write):
              (WebCore::JSHTMLDocument::writeln):
              (WebCore::JSHTMLDocument::clear):
              * bindings/js/kjs_dom.cpp:
              (KJS::toJS):
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_html.cpp:
              * bindings/js/kjs_html.h:
              * bindings/objc/DOMPrivate.h:
              * bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property
              for Document.all and fix HasOverridingNameGetter to allow correct
              prototype chain
              * dom/Document.cpp:
              (WebCore::Document::plugins): adds alias to embeds() for bindings
              * dom/Document.h:
              * html/HTMLDocument.cpp:
              (WebCore::HTMLDocument::width):
              (WebCore::HTMLDocument::height):
              (WebCore::HTMLDocument::dir):
              (WebCore::HTMLDocument::setDir):
              (WebCore::HTMLDocument::designMode):
              (WebCore::HTMLDocument::setDesignMode):
              (WebCore::HTMLDocument::bgColor):
              (WebCore::HTMLDocument::setBgColor):
              (WebCore::HTMLDocument::fgColor):
              (WebCore::HTMLDocument::setFgColor):
              (WebCore::HTMLDocument::alinkColor):
              (WebCore::HTMLDocument::setAlinkColor):
              (WebCore::HTMLDocument::linkColor):
              (WebCore::HTMLDocument::setLinkColor):
              (WebCore::HTMLDocument::vlinkColor):
              (WebCore::HTMLDocument::setVlinkColor):
              (WebCore::HTMLDocument::captureEvents):
              (WebCore::HTMLDocument::releaseEvents):
              * html/HTMLDocument.h:
              * html/HTMLDocument.idl:
      
      WebKit:
      
              Reviewed by Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              * MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      661a37fc
    • hyatt's avatar
      · dff3c4d7
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dff3c4d7
    • hyatt's avatar
      Fix for <rdar://problem/5221838> REGRESSION (r21581): no content in idisk · 10059be9
      hyatt authored
              window at mac.com.
      
              Back out the change to make self-closed <script/> into a Dashboard quirk
              only.
      
              Reviewed by aroben
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseTag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10059be9
    • oliver's avatar
      Reviewed by Geoff. · 54d2763d
      oliver authored
              Fix for <rdar://problem/5223782> REGRESSION: Can't drag and drop a standalone image
      
              The main resource for a standalone image webarchive has the same mimetype as the
              underlying image.
      
              * Misc/WebNSPasteboardExtras.mm:
              (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54d2763d
    • kmccullo's avatar
      Reviewed by. · 649a9edd
      kmccullo authored
              - Fixed build breakage.
      
              * fast/dom/open-and-close-by-DOM-expected.txt: Added.
              * fast/dom/open-and-close-by-DOM.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      649a9edd
    • pyeh's avatar
      <rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns... · aed6bd6a
      pyeh authored
      <rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns kAXErrorNoValue for attachment range
              
              Floating objects, such as aligned images, are not included as part of any line.  So when the given 
              text marker is on the floating object, the returned line edge cannot be found and asserts are fired.
              In addition, this paints an inconsistent text layout (in the accessibility sense) of where the floating 
              object resides.  Character/word methods report floating object at the beginning of the text line(s).  Yet
              line methods never present floating objects anywhere.  
              To fix this, the ax line methods will now do more checking to ensure floating object nodes are included
              when determining the line range/position. That way, assistive apps won't get stuck using the line methods 
              to read line-by-line
      
              * bridge/mac/WebCoreAXObject.mm:
              (updateAXLineStartForVisiblePosition):
              Added a helper method to adjust line start position to account for floating objects
              (-[WebCoreAXObject doAXLeftLineTextMarkerRangeForTextMarker:]):
              (-[WebCoreAXObject doAXRightLineTextMarkerRangeForTextMarker:]):
              (-[WebCoreAXObject doAXNextLineEndTextMarkerForTextMarker:]):
              (-[WebCoreAXObject doAXPreviousLineStartTextMarkerForTextMarker:]):
              Fixed up line routines to include floating object nodes in line position calculation.
              startOfLine/endOLine may return null for position next to a floating position.  So now there's extra checks to prevent
              returning null line position/ranges back to AX.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aed6bd6a
    • kmccullo's avatar
      Reviewed by. · 5fd81f18
      kmccullo authored
              - Removing failing tests until I've fixed them.
      
              * fast/dom/open-and-close-by-DOM-expected.txt: Removed.
              * fast/dom/open-and-close-by-DOM.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fd81f18
    • hausmann's avatar
      Added support for per-QWebPage network interface handlers, clean up the · 5482b095
      hausmann authored
      http and file loading and fixed a bug in the HTTP redirect handling.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5482b095
    • rwlbuis's avatar
      Reviewed by Dave Hyatt. · a215bbc6
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=13174
              line-height in font shorthand does not override a previously stated line-height property
      
              Make sure line-height is calculated against definite font-size and
              uses the last set line-height, ie. directly or through font shorthand.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a215bbc6
    • lars's avatar
      Reviewed by Zack · 187bdff4
      lars authored
              Don't do HTTP downloads in a second thread. Simplifies
              the code significantly and fixes crashes on some
              Web pages.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      187bdff4
    • lars's avatar
      Reviewed by Zack and Valgrind · 58eae66e
      lars authored
              Initialize variable.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58eae66e
    • rwlbuis's avatar
      Reviewed by Darin. · abbef99e
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=13784
              REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas
      
              Fix crash by testing for zero stops, and returning transparent black
              in this case.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abbef99e
    • rwlbuis's avatar
      Reviewed by Darin. · 0c6da947
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=13801
              Crash when loading nonexisting symbol
      
              Check for referenced element and when not found just return.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c6da947
    • lars's avatar
      Fix Host: line in HTTP headers and resolving of relative URLs · 724ee47b
      lars authored
      when redirecting and clean up qHash forward declaration a bit.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      724ee47b
    • hausmann's avatar
      Fix signal/slot connection for load progress. · 0645bc22
      hausmann authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0645bc22
  3. 22 May, 2007 1 commit