1. 03 Jan, 2006 2 commits
    • eseidel's avatar
      Bug #: 6109 · ef508986
      eseidel authored
      Submitted by: eseidel
      Reviewed by: darin
              No functionality changes, no tests possible.
      
              khtml/editing should use RefPtr instead of manual ref/deref
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6109
      
              Results in a slight performance gain < 1% on the PLT.
      
              * khtml/editing/SelectionController.cpp:
              (khtml::SelectionController::toRange):
              * khtml/editing/SelectionController.h:
              * khtml/editing/append_node_command.cpp:
              (khtml::AppendNodeCommand::AppendNodeCommand):
              (khtml::AppendNodeCommand::doApply):
              (khtml::AppendNodeCommand::doUnapply):
              * khtml/editing/append_node_command.h:
              (khtml::AppendNodeCommand::~AppendNodeCommand):
              (khtml::AppendNodeCommand::appendChild):
              (khtml::AppendNodeCommand::parentNode):
              * khtml/editing/apply_style_command.cpp:
              (khtml::StyleChange::init):
              (khtml::ApplyStyleCommand::removeInlineStyle):
              * khtml/editing/apply_style_command.h:
              * khtml/editing/composite_edit_command.cpp:
              (khtml::CompositeEditCommand::deleteInsignificantText):
              * khtml/editing/delete_from_text_node_command.cpp:
              (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
              * khtml/editing/delete_from_text_node_command.h:
              (khtml::DeleteFromTextNodeCommand::~DeleteFromTextNodeCommand):
              (khtml::DeleteFromTextNodeCommand::node):
              * khtml/editing/delete_selection_command.cpp:
              (khtml::DeleteSelectionCommand::initializePositionData):
              (khtml::DeleteSelectionCommand::saveTypingStyleState):
              (khtml::DeleteSelectionCommand::handleGeneralDelete):
              (khtml::DeleteSelectionCommand::calculateEndingPosition):
              (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
              (khtml::DeleteSelectionCommand::clearTransientState):
              * khtml/editing/delete_selection_command.h:
              * khtml/editing/edit_command.cpp:
              (khtml::EditCommand::EditCommand):
              (khtml::EditCommand::~EditCommand):
              (khtml::EditCommand::setTypingStyle):
              (khtml::EditCommand::styleAtPosition):
              * khtml/editing/edit_command.h:
              (khtml::EditCommand::document):
              (khtml::EditCommand::typingStyle):
              * khtml/editing/insert_into_text_node_command.cpp:
              (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
              * khtml/editing/insert_into_text_node_command.h:
              (khtml::InsertIntoTextNodeCommand::~InsertIntoTextNodeCommand):
              (khtml::InsertIntoTextNodeCommand::node):
              * khtml/editing/insert_node_before_command.cpp:
              (khtml::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
              (khtml::InsertNodeBeforeCommand::doApply):
              (khtml::InsertNodeBeforeCommand::doUnapply):
              * khtml/editing/insert_node_before_command.h:
              (khtml::InsertNodeBeforeCommand::~InsertNodeBeforeCommand):
              (khtml::InsertNodeBeforeCommand::insertChild):
              (khtml::InsertNodeBeforeCommand::refChild):
              * khtml/editing/insert_paragraph_separator_command.cpp:
              (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand):
              (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand):
              (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
              (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
              * khtml/editing/insert_paragraph_separator_command.h:
              * khtml/editing/join_text_nodes_command.cpp:
              (khtml::JoinTextNodesCommand::JoinTextNodesCommand):
              (khtml::JoinTextNodesCommand::doApply):
              (khtml::JoinTextNodesCommand::doUnapply):
              * khtml/editing/join_text_nodes_command.h:
              (khtml::JoinTextNodesCommand::~JoinTextNodesCommand):
              (khtml::JoinTextNodesCommand::firstNode):
              (khtml::JoinTextNodesCommand::secondNode):
              * khtml/editing/jsediting.cpp:
              * khtml/editing/markup.cpp:
              (khtml::createMarkup):
              (khtml::createFragmentFromMarkup):
              (khtml::createFragmentFromText):
              (khtml::createFragmentFromNodeList):
              * khtml/editing/markup.h:
              * khtml/editing/merge_identical_elements_command.cpp:
              (khtml::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
              (khtml::MergeIdenticalElementsCommand::doApply):
              (khtml::MergeIdenticalElementsCommand::doUnapply):
              * khtml/editing/merge_identical_elements_command.h:
              (khtml::MergeIdenticalElementsCommand::~MergeIdenticalElementsCommand):
              * khtml/editing/move_selection_command.cpp:
              (khtml::MoveSelectionCommand::MoveSelectionCommand):
              (khtml::MoveSelectionCommand::~MoveSelectionCommand):
              (khtml::MoveSelectionCommand::doApply):
              * khtml/editing/move_selection_command.h:
              * khtml/editing/rebalance_whitespace_command.cpp:
              * khtml/editing/rebalance_whitespace_command.h:
              (khtml::RebalanceWhitespaceCommand::~RebalanceWhitespaceCommand):
              * khtml/editing/remove_css_property_command.cpp:
              (khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
              * khtml/editing/remove_css_property_command.h:
              (khtml::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):
              (khtml::RemoveCSSPropertyCommand::styleDeclaration):
              * khtml/editing/remove_node_attribute_command.cpp:
              (khtml::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
              * khtml/editing/remove_node_attribute_command.h:
              (khtml::RemoveNodeAttributeCommand::~RemoveNodeAttributeCommand):
              (khtml::RemoveNodeAttributeCommand::element):
              * khtml/editing/remove_node_command.cpp:
              (khtml::RemoveNodeCommand::RemoveNodeCommand):
              (khtml::RemoveNodeCommand::doApply):
              (khtml::RemoveNodeCommand::doUnapply):
              * khtml/editing/remove_node_command.h:
              (khtml::RemoveNodeCommand::~RemoveNodeCommand):
              (khtml::RemoveNodeCommand::node):
              * khtml/editing/remove_node_preserving_children_command.cpp:
              (khtml::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
              * khtml/editing/remove_node_preserving_children_command.h:
              (khtml::RemoveNodePreservingChildrenCommand::~RemoveNodePreservingChildrenCommand):
              (khtml::RemoveNodePreservingChildrenCommand::node):
              * khtml/editing/replace_selection_command.cpp:
              (khtml::ReplacementFragment::ReplacementFragment):
              (khtml::ReplacementFragment::~ReplacementFragment):
              (khtml::ReplacementFragment::enclosingBlock):
              (khtml::ReplacementFragment::removeNodePreservingChildren):
              (khtml::ReplacementFragment::removeNode):
              (khtml::ReplacementFragment::insertFragmentForTestRendering):
              (khtml::ReplacementFragment::restoreTestRenderingNodesToFragment):
              (khtml::ReplaceSelectionCommand::fixupNodeStyles):
              (khtml::computeAndStoreNodeDesiredStyle):
              (khtml::NodeDesiredStyle::NodeDesiredStyle):
              (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand):
              (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand):
              (khtml::ReplaceSelectionCommand::doApply):
              (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
              (khtml::ReplaceSelectionCommand::updateNodesInserted):
              * khtml/editing/replace_selection_command.h:
              (khtml::NodeDesiredStyle::node):
              (khtml::NodeDesiredStyle::style):
              (khtml::ReplacementFragment::root):
              * khtml/editing/set_node_attribute_command.cpp:
              (khtml::SetNodeAttributeCommand::SetNodeAttributeCommand):
              * khtml/editing/set_node_attribute_command.h:
              (khtml::SetNodeAttributeCommand::~SetNodeAttributeCommand):
              (khtml::SetNodeAttributeCommand::element):
              * khtml/editing/split_element_command.cpp:
              (khtml::SplitElementCommand::SplitElementCommand):
              (khtml::SplitElementCommand::doApply):
              (khtml::SplitElementCommand::doUnapply):
              * khtml/editing/split_element_command.h:
              (khtml::SplitElementCommand::~SplitElementCommand):
              * khtml/editing/split_text_node_command.cpp:
              (khtml::SplitTextNodeCommand::SplitTextNodeCommand):
              (khtml::SplitTextNodeCommand::doApply):
              (khtml::SplitTextNodeCommand::doUnapply):
              * khtml/editing/split_text_node_command.h:
              (khtml::SplitTextNodeCommand::~SplitTextNodeCommand):
              (khtml::SplitTextNodeCommand::node):
              * khtml/editing/split_text_node_containing_element.cpp:
              (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
              (khtml::SplitTextNodeContainingElementCommand::doApply):
              * khtml/editing/split_text_node_containing_element_command.h:
              (khtml::SplitTextNodeContainingElementCommand::~SplitTextNodeContainingElementCommand):
              * khtml/editing/visible_position.cpp:
              (khtml::makeRange):
              * khtml/editing/visible_position.h:
              * khtml/editing/visible_text.cpp:
              (khtml::TextIterator::range):
              (khtml::SimplifiedBackwardsTextIterator::range):
              (khtml::CharacterIterator::range):
              (khtml::findPlainText):
              * khtml/editing/visible_text.h:
              (khtml::WordAwareIterator::range):
              * khtml/editing/wrap_contents_in_dummy_span_command.cpp:
              (khtml::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
              (khtml::WrapContentsInDummySpanCommand::doApply):
              (khtml::WrapContentsInDummySpanCommand::doUnapply):
              * khtml/editing/wrap_contents_in_dummy_span_command.h:
              (khtml::WrapContentsInDummySpanCommand::~WrapContentsInDummySpanCommand):
              * kwq/DOMHTML.mm:
              (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
              (-[DOMHTMLDocument _createDocumentFragmentWithText:]):
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]):
              (-[WebCoreBridge documentFragmentWithText:]):
              (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef508986
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · c70d1c6a
      andersca authored
              Reviewed by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5177
              Javascript cloneNode(deep) does not clone form elements correctly
      
              * khtml/html/html_elementimpl.cpp:
              (HTMLElementImpl::cloneNode):
              Call copyNonAttributeProperties on the new node.
      
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLInputElementImpl::copyNonAttributeProperties):
              * khtml/html/html_formimpl.h:
              Copy m_value, m_checked and m_indeterminate here.
      
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::importNode):
              Call copyNonAttributeProperties on the new node.
      
              * khtml/xml/dom_elementimpl.cpp:
              (ElementImpl::cloneNode):
              Call copyNonAttributeProperties on the new node.
      
              * khtml/xml/dom_elementimpl.h:
              (DOM::ElementImpl::copyNonAttributeProperties):
              Add function declaration.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c70d1c6a
  2. 02 Jan, 2006 3 commits
  3. 30 Dec, 2005 7 commits
    • darin's avatar
      Reviewed by Maciej. · 7baeccde
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=4557
                rename unusual strcmp and strcasecmp for DOMString family
      
              Added new functions named equal and equalIgnoringCase.
      
              * khtml/xml/dom_stringimpl.h: Changed the type of the length parameter to computeHash to unsigned
              to match the rest of the interface. Added equal and equalIgnoringCase functions. Added a
              version of the hash function that works on char* to CaseInsensitiveHash as preparation for an
              atomic string change.
              * khtml/xml/dom_stringimpl.cpp: Moved the QT_ALLOC_QCHAR_VEC and QT_DELETE_QCHAR_VEC macros
              here, and changed them into inline functions.
              (DOM::equal): Implemented.
              (DOM::equalIgnoringCase): Implemented.
              (DOM::DOMStringImpl::computeHash): Changed parameter type to unsigned to match other similar
              functions.
      
              * khtml/dom/dom_string.h: Removed unnecessary friend declarations. Changed operator
              overloads for == and != to call through inline to DOMStringImpl. Replaced strcasecmp
              with equalIgnoringCase, overloaded for one more combination of parameters. Removed strcmp.
              * khtml/dom/dom_string.cpp: Removed functions that are now implemented in DOMStringImpl*.
      
              * khtml/xml/dom_atomicstring.h: Removed a redundant const. Removed unnecessary
              friend declarations. Removed AtomicString::equal. Filled out a larger set of == and
              != operator implementations, mostly with inlines calling through to DOMStringImpl.
              Renamed equalsIgnoreCase to equalIgnoringCase and filled out a larger set as above.
              * khtml/xml/dom_atomicstring.cpp: Renamed AtomicString::equal to just ==.
              Removed some implementation of == and equalsIgnoreCase that are replaced by inlines.
      
              * khtml/html/html_listimpl.cpp:
              (DOM::HTMLOListElementImpl::parseMappedAttribute):
              (DOM::HTMLLIElementImpl::parseMappedAttribute):
              Use the "==" operator instead of strcmp.
      
              * khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
              Use equalIgnoringCase instead of equalsIgnoreCase.
      
              * khtml/rendering/render_form.cpp:
              (RenderSlider::updateFromElement): Fixed bug where a temporary DOMString was put into
              a const DOMString&. Changed some DOMString to AtomicString as appropriate, and also
              used equalIgnoringCase instead of strcasecmp.
              (RenderSlider::slotSliderValueChanged): More of the same.
      
              * khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Replaced use of strcasecmp
              with equalIgnoringCase. Added parentheses to fix incorrect operator precedence in one case
              (&& binds tighter than ||) which fixes a crash when using a http-equiv pragma when there
              is no part (not sure how to reproduce that).
      
              * khtml/khtml_part.cpp:
              (updateState):
              (KHTMLPart::selectionStartHasStyle):
              * khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
              * khtml/editing/apply_style_command.cpp:
              (khtml::StyleChange::checkForLegacyHTMLStyleChange):
              (khtml::StyleChange::currentlyHasStyle):
              (khtml::hasTextDecorationProperty):
              (khtml::ApplyStyleCommand::extractTextDecorationStyle):
              (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
              * khtml/html/html_baseimpl.cpp:
              (HTMLBodyElementImpl::parseMappedAttribute):
              (HTMLFrameElementImpl::parseMappedAttribute):
              * khtml/html/html_blockimpl.cpp:
              (HTMLDivElementImpl::parseMappedAttribute):
              (HTMLHRElementImpl::parseMappedAttribute):
              (HTMLParagraphElementImpl::parseMappedAttribute):
              (HTMLMarqueeElementImpl::parseMappedAttribute):
              * khtml/html/html_elementimpl.cpp:
              (HTMLElementImpl::parseMappedAttribute):
              (HTMLElementImpl::addHTMLAlignment):
              (HTMLElementImpl::setContentEditable):
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLFormElementImpl::parseMappedAttribute):
              (DOM::HTMLButtonElementImpl::parseMappedAttribute):
              (DOM::HTMLInputElementImpl::setInputType):
              (DOM::HTMLInputElementImpl::parseMappedAttribute):
              (DOM::HTMLKeygenElementImpl::appendFormData):
              (DOM::HTMLTextAreaElementImpl::parseMappedAttribute):
              * khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::parseMappedAttribute):
              * khtml/html/html_inlineimpl.cpp: (DOM::HTMLBRElementImpl::parseMappedAttribute):
              * khtml/html/html_tableimpl.cpp: (DOM::HTMLTablePartElementImpl::parseMappedAttribute):
              * khtml/html/htmlparser.cpp: (HTMLParser::handleError):
              Use equalIgnoringCase instead of strcasecmp.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7baeccde
    • ap's avatar
      Reviewed by Darin, landed by ap. · 2734996c
      ap authored
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5461
                Text width measured incorrectly when text-align: justify
      
      WebCore:
              * khtml/rendering/font.h:
              * khtml/rendering/font.cpp:
              (khtml::Font::selectionRectForText): Added.
              * khtml/rendering/render_text.cpp:
              (kthml::InlineTextBox::selectionRect): Use selectionRectForText. This
              works for justified text as well, and avoids intermediate rounding which
              resulted in selection rects narrower than AppKit's.
              (khtml::InlineTextBox::positionForOffset): Use selectionRectForText,
              which works for justified text as well.
              * kwq/KWQFontMetrics.h:
              * kwq/KWQFontMetrics.mm:
              (QFontMetrics::selectionRectForText): Added.
              * kwq/WebCoreTextRenderer.h:
      
      WebKit:
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (-[WebTextRenderer selectionRectForRun:style:geometry:]): Added.
              (CG_drawHighlight): Use new function CG_selectionRect.
              (CG_selectionRect): New function to compute the selection rect.
              Eliminated rounding hackery that was required for keeping the highlight
              rect within the selection rect computed by
              InlineTextBox::selectionRect, since the latter uses this function now.
              The new selection rect is wider and matches AppKit more closely,
              although the right hand side is roundf()ed instead of cielf()ed for
              optimal caret positioning.
              (ATSU_drawHighlight): Use new function ATSU_selectionRect.
              (ATSU_selectionRect): New function to compute the selection rect.
              Much like CG_selectionRect.
      LayoutTests:
              * fast/text/justified-text-rect-expected.checksum: Added.
              * fast/text/justified-text-rect-expected.png: Added.
              * fast/text/justified-text-rect-expected.txt: Added.
              * fast/text/justified-text-rect.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2734996c
    • ap's avatar
      - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6289 · 9bbc4e38
      ap authored
              REGRESSION: firstCharacterForRange(0, 0) returns a 0x0 rect
      
              * khtml/editing/visible_text.cpp:
              (khtml::TextIterator::rangeFromLocationAndLength):
              Only special-case (0, 0) ranges for empty documents.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bbc4e38
    • ggaren's avatar
      Remove conflict marker from ChangeLog · b9fc7fa2
      ggaren authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9fc7fa2
    • ggaren's avatar
      WebCore: · 3d613f1f
      ggaren authored
              Added test case for <rdar://problem/4268278> Submitting a form in onUnload event
              handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]
      
              * manual-tests/onunload-form-submit-crash.html: Added.
      
      WebKit:
      
              Reviewed by Eric.
      
              Manual testcase added:
              WebCore/manual-tests/onunload-form-submit-crash.html
      
              - Fixed <rdar://problem/4268278> Submitting a form in onUnload event
              handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]
      
              The problem is that the form submission in the unload event kicks off
              a new load in the midst of the load that caused the unload event to
              fire in the first place, so the two loads stomp each other.
      
              The solution is to cancel the first load and let the unload handler's
              load win. (Firefox does the same.)
      
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _transitionToCommitted:]): Moved call to -closeURL up
              the call stack to _continueLoadRequest. (See below.) This has the
              side-effect of always firing the unload event, even if the new
              datasource never becomes committed, which seems like a good thing.
      
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
              Call -closeURL here, instead of in _transitionToCommitted,  so that the
              unload handler can fire before we initialize any part of the load.
      
              Check provisionalDataSource for nil to discover if the unload event
              kicked off its own load.
      
              Cleared up some coments.
      
              (-[WebFrame _detachFromParent]):
              It turns out that if you close the window instead of just navigating
              to a new page, you get an alternate assertion failure/crash because
              the load kicked off by the unload event handler generates resource
              loader callbacks after the associated WebFrame/WebView has disappeared.
      
              The nifty solution here is just to reverse the order of calls to
              -stopLoading and -closeURL, thus guaranteeing that -stopLoading has the
              last word when you close a window.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d613f1f
    • andersca's avatar
      2005-12-30 Anders Carlsson <andersca@mac.com> · e1be1a16
      andersca authored
              Reviewed by Eric.
      
      		- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6297
      		XMLSerializer should use createMarkup.
      
              * khtml/ecma/xmlserializer.cpp:
              (KJS::XMLSerializerProtoFunc::callAsFunction):
      		Use createMarkup instead of NodeImpl::toString.
      
              * khtml/editing/markup.cpp:
              (khtml::startMarkup):
      		escape attribute values and ignore document fragment nodes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1be1a16
    • eseidel's avatar
      Bug #: 6299 · a55f252f
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              No functional changes, thus no layout test.
      
              Just removes debug NSLog() calls from ksvg2/kcanvas.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6299
      
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              (KCanvasFilterQuartz::prepareFilter):
              (KCanvasFilterQuartz::applyFilter):
              (KCanvasFilterQuartz::getCIFilterStack):
              (KCanvasFilterQuartz::imageForName):
              (KCanvasFEBlendQuartz::getCIFilter):
              (KCanvasFEColorMatrixQuartz::getCIFilter):
              (KCanvasFEGaussianBlurQuartz::getCIFilter):
              * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
              (KCanvasClipperQuartz::applyClip):
              * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
              (KRenderingDeviceContextQuartz::mapFromVisual):
              (KRenderingDeviceContextQuartz::mapToVisual):
              (KRenderingDeviceQuartz::createResource):
              (KRenderingDeviceQuartz::createFilterEffect):
              * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
              (drawShadingWithStyle):
              (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
              * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
              (KRenderingPaintServerPatternQuartz::draw):
              * ksvg2/svg/svgpathparser.cpp:
              (SVGPathParser::parseSVG):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a55f252f
  4. 29 Dec, 2005 13 commits
    • darin's avatar
      LayoutTests: · c230576d
      darin authored
              Reviewed and refined by Darin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
                In-place style-switching is leaving junk behind, messing up styles
      
              * fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
              * fast/css/margin-top-bottom-dynamic-expected.png: Added.
              * fast/css/margin-top-bottom-dynamic-expected.txt: Added.
              * fast/css/margin-top-bottom-dynamic.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
                In-place style-switching is leaving junk behind, messing up styles
      
              * khtml/rendering/render_block.h: (khtml::RenderBlock::initMaxMarginValues):
              Set all margin values in all cases.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c230576d
    • eseidel's avatar
      Bug #: 6290 · 1fda09d0
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              XML documents with "html" in dtd name use XHTML entities when they shouldn't
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6290
      
              * khtml/xml/xml_tokenizer.cpp:
              (khtml::externalSubsetHandler): check for exact xhtml types
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fda09d0
    • eseidel's avatar
      Bug #: 6295 · ab66b6b1
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Close leak in CollectionInfo due to HashMap migration
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6295
      
              * khtml/html/html_miscimpl.cpp:
              (DOM::HTMLCollectionImpl::CollectionInfo::~CollectionInfo):
              * khtml/html/html_miscimpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab66b6b1
    • eseidel's avatar
      Bug #: 6101 · bf437b45
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Leaks in XSLTProcessorImpl due to early exit in failure case
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6101
      
              * khtml/xsl/xslt_processorimpl.cpp:
              (DOM::xmlDocPtrFromNode): add "shouldDelete" argument
              (DOM::XSLTProcessorImpl::transformToString): delete new'd xmlDoc
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf437b45
    • mjs's avatar
      WebCore: · 6b709be4
      mjs authored
              Reviewed by Eric.
      
              - finished frame traversal cleanup
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6293
      
              * kwq/WebCoreBridge.h: Removed childFrames method from WebCoreBridge protocol
      	since it is not actually used.
      
      WebKit:
      
              Reviewed by Eric.
      
              - finished frame traversal cleanup
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6293
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge childFrames]): Removed (this was unused)
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _removeChild::]): Moved to FrameTraversal category.
              (-[WebFrame _childFrameCount]): New frame traversal method to avoid
      	getting the count from the array directly.
              (-[WebFrame _appendChild:]): Factored out the parts of addChild: that
      	seem directly relevant to adding a child.
              (-[WebFrame _removeChild:]): Moved to FrameTraversal category.
              (-[WebFrame _detachChildren]): Don't deallocate children array because
      	there's no particular need to.
              (-[WebFrame _setDataSource:]): make the assert use _childFrameCount
              (-[WebFrame _opened]):
              (-[WebFrame _checkLoadComplete]): Instead of checking all frames starting
      	from the main frame, check this frame and all ancestors. If a resource
      	for a frame completes, that con only possibly finish loading for that
      	frame and its ancestors, not any other frame in the tree.
      	(-[WebFrame _recursiveCheckLoadComplete]): Removed, no longer needed.
              (-[WebFrame _childFramesMatchItem:]): Get child frame count in the new
      	approved way.
              (-[WebFrame _internalChildFrames]): removed
      	(-[WebFrame _addChild:]): Use _appendChild: for most of the work.
              (-[WebFrame _generateFrameName]): Get child frame count in the new
      	approved way.
              (-[WebFrame _stopLoadingSubframes]): Use new frame traversal mechanisms,
      	upon further consideration there's no need to copy part of the frame tree here.
              (-[WebFrame findFrameNamed:]): Remove extra braces.
              (-[WebFrame childFrames]): Make a new array using the frame traversal methods.
              * WebView.subproj/WebFramePrivate.h: Remove some methods.
              * WebView.subproj/WebMainResourceLoader.m:
              (-[WebMainResourceLoader didReceiveResponse:]): Do _checkLoadComplete on the current
      	frame not the main frame (before there was no difference and now the new version is
      	what is desired).
              * WebView.subproj/WebView.m:
              (-[WebView _finishedLoadingResourceFromDataSource:]): Remove stray space
              (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]): Remove stray spaces
      	and update FIXME comment.
              (-[WebView _receivedError:fromDataSource:]): Remove stray space
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b709be4
    • eseidel's avatar
      Bug #: 6230 · 07480eea
      eseidel authored
      Submitted by: eseidel
      Reviewed by: build fix only.
              File accidentally omitted from previous commit.
      
              Remove QDict from khtml/html
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
      
              * khtml/ecma/kjs_html.cpp:
              (KJS::KJS::HTMLCollection::getNamedItems):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07480eea
    • eseidel's avatar
      Bug #: 6230 · 31504afb
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              Remove QDict from khtml/html
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
              Uses HashMap instead.
      
              * khtml/html/html_miscimpl.cpp:
              (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo):
              (DOM::HTMLCollectionImpl::CollectionInfo::reset):
              (DOM::HTMLCollectionImpl::namedItem):
              (DOM::HTMLCollectionImpl::updateNameCache):
              (DOM::HTMLCollectionImpl::namedItems):
              (DOM::HTMLCollectionImpl::nextNamedItem):
              (DOM::HTMLFormCollectionImpl::nextNamedItemInternal):
              (DOM::HTMLFormCollectionImpl::updateNameCache):
              * khtml/html/html_miscimpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31504afb
    • eseidel's avatar
      Bug #: 6228 · ccbf3d76
      eseidel authored
      Submitted by: eseidel
      Reviewed by: mjs
              DOMString/DOMStringImpl/AtomicString need enhancements before replacing QString
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6228
              Added find(), contains(), startsWith() and endsWith() to DOMString
              Uses the above functions throughout the code.
              Small performance boost.
      
              * khtml/css/css_base.cpp:
              (CSSSelector::print):
              * khtml/css/css_ruleimpl.cpp:
              (DOM::CSSImportRuleImpl::init):
              * khtml/css/css_valueimpl.cpp:
              (DOM::CSSStyleDeclarationImpl::setProperty):
              * khtml/css/cssparser.cpp:
              (CSSParser::parseValue):
              (CSSParser::parseDeclaration):
              (CSSParser::parseContent):
              * khtml/css/cssstyleselector.cpp:
              (khtml::CSSStyleSelector::CSSStyleSelector):
              (khtml::CSSStyleSelector::setEncodedURL):
              (khtml::parseUASheet):
              (khtml::cleanpath):
              (khtml::CSSStyleSelector::checkSelector):
              (khtml::CSSStyleSelector::checkOneSelector):
              (khtml::CSSRuleSet::addRulesFromSheet):
              (khtml::CSSStyleSelector::applyProperty):
              * khtml/dom/dom_string.cpp:
              * khtml/dom/dom_string.h:
              (DOM::DOMString::contains):
              (DOM::DOMString::find):
              (DOM::DOMString::startsWith):
              (DOM::DOMString::endsWith):
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLFormElementImpl::parseEnctype):
              * khtml/khtml_part.cpp:
              (KHTMLPart::requestFrame):
              (KHTMLPart::submitForm):
              * khtml/misc/decoder.cpp:
              (Decoder::decode):
              * khtml/xml/dom_atomicstring.h:
              (DOM::AtomicString::length):
              (DOM::AtomicString::operator []):
              (DOM::AtomicString::contains):
              (DOM::AtomicString::find):
              (DOM::AtomicString::startsWith):
              (DOM::AtomicString::endsWith):
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::processHttpEquiv):
              * khtml/xml/dom_stringimpl.cpp:
              (DOM::equal):
              (DOM::equalCaseInsensitive):
              (DOM::DOMStringImpl::find):
              (DOM::DOMStringImpl::endsWith):
              * khtml/xml/dom_stringimpl.h:
              (DOM::DOMStringImpl::startsWith):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccbf3d76
    • eseidel's avatar
      Bug #: 6157 · b401952a
      eseidel authored
      Submitted by: rob buis
      Reviewed by: eseidel
              WebCore+SVG has some problems with rounded rectangles
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
      
              * ksvg2/svg/SVGRectElementImpl.cpp:
              (SVGRectElementImpl::toPathData): fixed round rect calculations
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b401952a
    • eseidel's avatar
      Bug #: 4301 · c5f7f219
      eseidel authored
      Submitted by: mark rowe
      Reviewed by: eseidel, ggaren, darin
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
              Support HTML entities on pages parsed as XHTML
      
              Added layout tests:
              * fast/parser/entities-in-xhtml.xhtml
      
              * khtml/xml/xml_tokenizer.cpp:
              (khtml::XMLTokenizer::setIsXHTMLDocument): Track whether the XML document is XHTML.
              (khtml::XMLTokenizer::isXHTMLDocument): Ditto.
              (khtml::externalSubsetHandler): Ditto.
              (khtml::XMLTokenizer::finish): Ditto.
              (khtml::getXHTMLEntity): Look up the HTML entity.
              (khtml::getEntityHandler): Look up the HTML entity if this is an XHTML document.
              * khtml/html/kentities.h: Added.
              * khtml/html/kentities.gperf: changed entity to Entity
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5f7f219
    • ggaren's avatar
      WebCore: · 633ffe2a
      ggaren authored
              Reviewed by darin
      
              - WebCore part of fix for
                http://bugzilla.opendarwin.org/show_bug.cgi?id=3922
                Variable word/letter spacing and full justification not supported for
                ATSUI-rendered text
      
              * khtml/rendering/font.h:
              (khtml::Font::checkSelectionPoint): Make sure the complete run, used for
              counting spaces and determining padding per space does not go beyond the
              text box.
      
      WebKit:
      
              Reviewed by darin
      
              Test: fast/text/atsui-spacing-features.html
      
              - WebKit part of fix for
                http://bugzilla.opendarwin.org/show_bug.cgi?id=3922
                Variable word/letter spacing and full justification not supported for
                ATSUI-rendered text
      
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (overrideLayoutOperation): Add letter- and word-spacing and padding for
              justification.
              (createATSULayoutParameters): Compute padding per space.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      633ffe2a
    • ggaren's avatar
      Reviewed by mjs. · 4392ffac
      ggaren authored
              - Fixed <rdar://problem/4325722> crash in KJS::Bindings::dispatchJNICall
              due to liveconnect call from Java after Java PlugInView has been
              deallocated @ www.binarybet.com
              AKA
              http://bugzilla.opendarwin.org/show_bug.cgi?id=5518
      
              We had code that checked for whether a call came from a live PlugIn,
              but the live PlugIn dictionary would only get cleared when the
              KWQKHTMLPart was destroyed. Since a single part can service multiple
              loads, the dictionary needs to clear after each one.
      
              No layout test because this bug is difficult to reproduce.
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::~KWQKHTMLPart):
              (1) Unrelated cleanup: Removed manual clearing of form values,
              replaced with call to clearRecordedFormValues().
              (2) Replaced PlugIn dictionary cleanup code and view deref call
              with call to setView(0), since much of this code was duplicated in
              setView, and the stuff that wasn't duplicated needed to be.
      
              (KWQKHTMLPart::setView):
              (1) Removed some unnecessary braces.
              (2) Added PlugIn dictionary cleanup code.
              (3) New behavior: clear _bindingRoot and _windowScriptObject after
              each view change. This is needed because after a call to
              clenaupPluginRootObjects(), both objects have stale references.
              (4) Changed a NULL to a 0.
      
              (KWQKHTMLPart::cleanupPluginRootObjects): Removed extra space.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4392ffac
    • andersca's avatar
      2005-12-28 Anders Carlsson <andersca@mac.com> · eb283f2c
      andersca authored
              Reviewed by Maciej.
      
              - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6268
              Add undetectable document.all
      
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLDocument::getValueProperty):
              If "all" has been set to a new value, return the new value.
      
              (KJS::KJS::HTMLDocument::putValueProperty):
              Allow "all" to be set to a new value.
      
              (KJS::HTMLAllCollection::toPrimitive):
              Return jsNull() if the preferred type is NullType.
      
              (KJS::getAllHTMLCollection):
              * khtml/ecma/kjs_html.h:
              (KJS::HTMLAllCollection::HTMLAllCollection):
              Add HTMLAllCollection, a subclass of HTMLCollection which should
              be undetectable.
      
              (KJS::HTMLAllCollection::toBoolean):
              Return false.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb283f2c
  5. 28 Dec, 2005 4 commits
  6. 27 Dec, 2005 5 commits
    • darin's avatar
      Reviewed by Hyatt, landed by Darin. · da54727b
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5699
                REGRESSION: incomplete repaint
      
              * khtml/rendering/render_object.cpp:
              (RenderObject::repaintAfterLayoutIfNeeded): Return false if only the
              size changed and not everything was repainted.
              * manual-tests/bugzilla-5699.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da54727b
    • darin's avatar
      LayoutTests: · 73178835
      darin authored
              Reviewed by Maciej, landed by Darin.
      
              - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4101>
              CSS Fibonacci spiral using 4 images doesn't render correctly
      
              * fast/replaced/absolute-image-sizing-expected.checksum: Added.
              * fast/replaced/absolute-image-sizing-expected.png: Added.
              * fast/replaced/absolute-image-sizing-expected.txt: Added.
              * fast/replaced/absolute-image-sizing.html: Added.
      
      WebCore:
      
              Reviewed by Maciej, landed by Darin.
      
              - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4101>
              CSS Fibonacci spiral using 4 images doesn't render correctly
      
              Added layout tests:
              * fast/replaced/absolute-image-sizing.html
      
              * khtml/rendering/render_box.cpp:
              (RenderBox::calcAbsoluteHorizontalValues): Use calcReplacedWidth() instead of intrinsicWidth()
              for replaced elements.
              (RenderBox::calcAbsoluteVerticalValues): Same thing for height.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73178835
    • darin's avatar
      Reviewed by Geoff and Eric. · 2a4c3747
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=6198
                use RefPtr a few places in RenderText and related classes
      
              * khtml/html/htmltokenizer.h: Use RefPtr for some data members in Token.
              Also removed use of bitfields in Token, since there's no need to optimize storage here.
              * khtml/html/htmlparser.cpp:
              (HTMLParser::parseToken): Update for use of RefPtr in Token.
              (HTMLParser::textCreateErrorCheck): Ditto.
              (HTMLParser::commentCreateErrorCheck): Ditto.
              (HTMLParser::handleIsindex): Ditto.
              * khtml/html/htmltokenizer.cpp:
              (khtml::Token::addAttribute): Ditto.
              (khtml::HTMLTokenizer::processToken): Ditto.
      
              * khtml/rendering/render_text.h: Reduce the number of includes, change
              SOFT_HYPHEN from a macro into a constant. Change originalString function
              to return a PassRefPtr instead of a RefPtr. Make str and m_generatedContentStr
              member be a RefPtr.
              * khtml/rendering/render_text.cpp:
              (khtml::RenderText::previousOffset): Update for use of RefPtr for str.
              (khtml::RenderText::nextOffset): Ditto.
              (khtml::RenderText::RenderText): Ditto.
              (khtml::RenderText::originalString): Change to return PassRefPtr, even though
              it's not necessary at this level (since it's a virtual function).
              (khtml::RenderText::posOfChar): Update for use of RefPtr for str.
              (khtml::RenderText::setText): Ditto.
              (khtml::RenderTextFragment::RenderTextFragment): Ditto.
              (khtml::RenderTextFragment::originalString): Change to return PassRefPtr.
      
              * khtml/html/html_inlineimpl.cpp: Re-sorted list of includes, added newly-needed ones.
              * kwq/KWQRenderTreeDebug.cpp: Added new include needed since QPtrVector is no longer
              included by render_text.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a4c3747
    • darin's avatar
      Fix suggested by Mitz. · c4190e9f
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6240
                REGRESSION: scrollbars in overflows don't work
      
              * khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::computePositions):
              Remove the code to compute pageX/Y from clientX/Y, because clientX/Y are not passed
              in correctly (in fact, what's passed in is pageX/Y)! I accidentally included part
              of my fix for clientX/Y in the original patch.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4190e9f
    • mjs's avatar
      LayoutTests: · 9c780ce0
      mjs authored
              Reviewed, tweaked and landed by Maciej.
      
      	- test case for 4405: <button> not listed in form collections.
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=4405
      
              * fast/forms/button-in-forms-collection-expected.txt: Added.
              * fast/forms/button-in-forms-collection.html: Added.
      
      WebCore:
      
              Reviewed and landed by Maciej.
      
      	- fixed 4405: <button> not listed in form collections.
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=4405
      
      	Test: fast/forms/button-in-forms-collection.html
      
              * khtml/html/html_formimpl.h:
              (DOM::HTMLButtonElementImpl::isEnumeratable): override to return true
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c780ce0
  7. 26 Dec, 2005 1 commit
    • mjs's avatar
      WebCore: · 158ad488
      mjs authored
              Reviewed by Geoff.
      
              - Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6241
      
              * kwq/WebCoreBridge.h:
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge parent]): New method, relies on the KHTMLPart's
      	parent pointer.
      
      WebKit:
      
              Reviewed by Geoff
      
              - Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6241
      
              * WebCoreSupport.subproj/WebBridge.h:
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge canTargetLoadInFrame:]): Use bridge parent method instead of needlessly
      	asking for parent via WebFrame
              (-[WebBridge frameDetached]): Don't call _removeChild on the parent frame any more
      	because WebFame's _detachFromParent takes care of that now.
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Fix stray spaces
              (-[WebFrame _detachChildren]): Don't remove children as we loop any more, they
      	can remove themselves.
              (-[WebFrame _detachFromParent]): Remove self from parent; don't nil out bridge
      	until we are done with it.
              (-[WebFrame _transitionToCommitted:]): Remove some extra braces.
              (-[WebFrame _goToItem:withLoadType:]): Use parentFrame method in assert instead of parent
      	field directly.
              (-[WebFrame _addChild:]): Don't poke at parent frame pointer in _private
      	since it is not there any more.
              (-[WebFrame _removeChild:]): Remove extra braces and don't clear parent pointer
      	explicitly any more.
              (-[WebFrame _addFramePathToString:]): Get parentFrame from method, not field.
              (-[WebFrame _loadDataSource:withLoadType:formState:]): Remove extra braces.
              (-[WebFrame _nextFrameWithWrap:]): Get parent in the proper way and clean up the
      	coding style.
              (-[WebFrame _previousFrameWithWrap:]): Ditto.
              (-[WebFrame parentFrame]): Get parent from the bridge.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      158ad488
  8. 25 Dec, 2005 1 commit
  9. 24 Dec, 2005 4 commits
    • eseidel's avatar
      Bug #: 6326 · 29ee4e21
      eseidel authored
      Submitted by: mitz
      Reviewed by: eseidel
              Test: fast/forms/domstring-replace-crash.html
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6236
                REGRESSION: Crash in DOMString::replace() in ToT (12/24/05)
      
              * khtml/dom/dom_string.h:
              (DOMString::replace): Added check for null m_impl.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29ee4e21
    • mjs's avatar
      Reviewed by Eric. · c307dcb3
      mjs authored
              - replaced QPtrDict for Accessors structs with HashMap (also renamed some
      	stray getSetInfo methods)
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=6223
      
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLElement::accessors):
              (KJS::HTMLElement::getValueProperty):
              (KJS::HTMLElement::putValueProperty):
              * khtml/ecma/kjs_html.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c307dcb3
    • ggaren's avatar
      Reviewed by eric. · d259de26
      ggaren authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6231
      
              - Fixed assertion failure in QString::mid caused by my last checkin.
              parseWindowFeatuers() sometimes called QString::mid() with a start
              index past the end of the string but a length of 0. There were two
              problems there. (1) parseWindowString() shouldn't have gotten past the
              end of the string. (2) QString had range truncating code that was
              borked. So I fixed both.
      
              * khtml/ecma/kjs_window.cpp:
              (KJS::parseWindowFeatures): One of the "past the end" tests was >
              instead of >=.
              * kwq/KWQString.mm:
              (QString::mid): Truncate length *before* deciding whether to return
              early. Also, compare start and data._length before computing
              data._length - start, because the error case we're trying to catch
              will almost certainly cause unsigned overflow.
              * manual-tests/window-open-features-parsing.html: Added trailing ','
              to uber-test to catch this failure, too.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d259de26
    • ap's avatar
      Reviewed by Maciej. · 5c8c5ed7
      ap authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6221
                REGRESSION: Password field is blank error for secure websites using
                password field (ToT, 12/24/05)
      
              * khtml/kwq/KWQSlot.mm:
              (KWQSlot::KWQSlot): Changed the parameter type of slotTextChanged to const DOMString &
              * khtml/rendering/render_form.h:
              * khtml/rendering/render_form.cpp:
              (RenderLineEdit::RenderLineEdit): ditto.
              (RenderLineEdit::slotTextChanged): ditto.
              (RenderFileButton::RenderFileButton): ditto.
              (RenderFileButton::slotTextChanged): ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c8c5ed7