1. 05 Jul, 2011 1 commit
    • vsevik@chromium.org's avatar
      2011-07-05 Vsevolod Vlasov <vsevik@chromium.org> · d8b27104
      vsevik@chromium.org authored
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Added GTK symbols for new window.internals methods.
      
              Reviewed by Pavel Feldman.
      
              * Source/autotools/symbols.filter:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Added tests for plugin content saving and replacing in NetworkResourcesData.
              Adjusted older tests to use new window.internals method setInspectorResourcesDataSizeLimits
              to ensure NetworkResourcesData is in the correct state before test.
      
              Reviewed by Pavel Feldman.
      
              * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-embed.html: Added.
              * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-xhr.html: Added.
              * http/tests/inspector/network/network-embed-expected.txt: Added.
              * http/tests/inspector/network/network-embed.html: Added.
              * http/tests/inspector/network/network-xhr-async-expected.txt:
              * http/tests/inspector/network/network-xhr-async.html:
              * http/tests/inspector/network/network-xhr-sync-expected.txt:
              * http/tests/inspector/network/network-xhr-sync.html:
              * http/tests/inspector/network/resources/cp1251.xml: Added.
              * http/tests/inspector/network/resources/plugin-data.php: Added.
              * http/tests/inspector/network/resources/resource.php:
              * http/tests/inspector/network/resources/utf8.xml: Added.
              * platform/chromium/test_expectations.txt:
      2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Now the data from didReceiveData callback is passed to inspector.
              It is then saved in NetworkResourcesData structure for plugin requests.
              Added window.internals.setInspectorResourcesDataSizeLimits() method
              for testing replacement logic.
      
              Reviewed by Pavel Feldman.
      
              Tests: http/tests/inspector/network/network-content-replacement-embed.html
                     http/tests/inspector/network/network-content-replacement-xhr.html
                     http/tests/inspector/network/network-embed.html
      
              * WebCore.exp.in:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveDataImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didReceiveData):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveData):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/NetworkResourcesData.cpp:
              (WebCore::NetworkResourcesData::ResourceData::ResourceData):
              (WebCore::NetworkResourcesData::ResourceData::setContent):
              (WebCore::NetworkResourcesData::ResourceData::purgeContent):
              (WebCore::NetworkResourcesData::ResourceData::createDecoder):
              (WebCore::NetworkResourcesData::ResourceData::dataLength):
              (WebCore::NetworkResourcesData::ResourceData::appendData):
              (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
              (WebCore::NetworkResourcesData::NetworkResourcesData):
              (WebCore::NetworkResourcesData::responseReceived):
              (WebCore::NetworkResourcesData::setResourceContent):
              (WebCore::NetworkResourcesData::maybeAddResourceData):
              (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
              (WebCore::NetworkResourcesData::data):
              (WebCore::NetworkResourcesData::clear):
              (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
              (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
              (WebCore::NetworkResourcesData::ensureFreeSpace):
              * inspector/NetworkResourcesData.h:
              (WebCore::NetworkResourcesData::ResourceData::hasContent):
              (WebCore::NetworkResourcesData::ResourceData::content):
              (WebCore::NetworkResourcesData::ResourceData::decoder):
              (WebCore::NetworkResourcesData::ResourceData::buffer):
              (WebCore::NetworkResourcesData::ResourceData::setBuffer):
              (WebCore::NetworkResourcesData::ResourceData::hasData):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.get contentEncoded):
              * inspector/front-end/ResourcePreviewView.js:
              (WebInspector.ResourcePreviewView.prototype.contentLoaded):
              (WebInspector.ResourcePreviewView.prototype._createEmptyView):
              (WebInspector.ResourcePreviewView.prototype._createPreviewView):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.hasTextContent):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::didReceiveData):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::willLoadMediaElementURL):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didReceiveData):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
              (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
              * loader/ResourceLoadNotifier.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveData):
              * testing/Internals.cpp:
              (WebCore::Internals::setInspectorResourcesDataSizeLimits):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Added win symbols for new window.internals methods.
      
              Reviewed by Pavel Feldman.
      
              * win/WebKit2.def:
              * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8b27104
  2. 04 Jul, 2011 2 commits
    • commit-queue@webkit.org's avatar
      2011-07-04 Sheriff Bot <webkit.review.bot@gmail.com> · 1e1df61f
      commit-queue@webkit.org authored
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * Source/autotools/symbols.filter:
      2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Removed.
              * http/tests/inspector/network/network-content-replacement-embed.html: Removed.
              * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Removed.
              * http/tests/inspector/network/network-content-replacement-xhr.html: Removed.
              * http/tests/inspector/network/network-embed-expected.txt: Removed.
              * http/tests/inspector/network/network-embed.html: Removed.
              * http/tests/inspector/network/network-xhr-async-expected.txt:
              * http/tests/inspector/network/network-xhr-async.html:
              * http/tests/inspector/network/network-xhr-sync-expected.txt:
              * http/tests/inspector/network/network-xhr-sync.html:
              * http/tests/inspector/network/resources/cp1251.xml: Removed.
              * http/tests/inspector/network/resources/plugin-data.php: Removed.
              * http/tests/inspector/network/resources/resource.php:
              * http/tests/inspector/network/resources/utf8.xml: Removed.
              * platform/chromium/test_expectations.txt:
      2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * WebCore.exp.in:
              * inspector/InspectorController.cpp:
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didReceiveContentLength):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveContentLength):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/NetworkResourcesData.cpp:
              (WebCore::NetworkResourcesData::ResourceData::ResourceData):
              (WebCore::NetworkResourcesData::ResourceData::content):
              (WebCore::NetworkResourcesData::ResourceData::appendContent):
              (WebCore::NetworkResourcesData::ResourceData::purgeContent):
              (WebCore::NetworkResourcesData::NetworkResourcesData):
              (WebCore::NetworkResourcesData::responseReceived):
              (WebCore::NetworkResourcesData::addResourceContent):
              (WebCore::NetworkResourcesData::data):
              (WebCore::NetworkResourcesData::clear):
              (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
              (WebCore::NetworkResourcesData::ensureFreeSpace):
              * inspector/NetworkResourcesData.h:
              (WebCore::NetworkResourcesData::ResourceData::hasContent):
              (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged):
              (WebCore::NetworkResourcesData::ResourceData::textEncodingName):
              (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
              * inspector/front-end/Resource.js:
              * inspector/front-end/ResourcePreviewView.js:
              (WebInspector.ResourcePreviewView.prototype.contentLoaded):
              (WebInspector.ResourcePreviewView.prototype._createInnerView):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.hasTextContent):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::didReceiveData):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::willLoadMediaElementURL):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didReceiveData):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
              (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
              * loader/ResourceLoadNotifier.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveData):
              * testing/Internals.cpp:
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r90373.
              http://trac.webkit.org/changeset/90373
              https://bugs.webkit.org/show_bug.cgi?id=63917
      
              Breaks Qt Linux Release minimal (Requested by vsevik on
              #webkit).
      
              * win/WebKit2.def:
              * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e1df61f
    • vsevik@chromium.org's avatar
      2011-07-04 Vsevolod Vlasov <vsevik@chromium.org> · 169a9b5d
      vsevik@chromium.org authored
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              * Source/autotools/symbols.filter:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              * http/tests/inspector/network/network-content-replacement-embed-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-embed.html: Added.
              * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: Added.
              * http/tests/inspector/network/network-content-replacement-xhr.html: Added.
              * http/tests/inspector/network/network-embed-expected.txt: Added.
              * http/tests/inspector/network/network-embed.html: Added.
              * http/tests/inspector/network/network-xhr-async-expected.txt:
              * http/tests/inspector/network/network-xhr-async.html:
              * http/tests/inspector/network/network-xhr-sync-expected.txt:
              * http/tests/inspector/network/network-xhr-sync.html:
              * http/tests/inspector/network/resources/cp1251.xml: Added.
              * http/tests/inspector/network/resources/plugin-data.php: Added.
              * http/tests/inspector/network/resources/resource.php:
              * http/tests/inspector/network/resources/utf8.xml: Added.
              * platform/chromium/test_expectations.txt:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              Tests: http/tests/inspector/network/network-content-replacement-embed.html
                     http/tests/inspector/network/network-content-replacement-xhr.html
                     http/tests/inspector/network/network-embed.html
      
              * WebCore.exp.in:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveDataImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didReceiveData):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveData):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::setInitialXHRContent):
              (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
              (WebCore::InspectorResourceAgent::getResourceContent):
              * inspector/InspectorResourceAgent.h:
              * inspector/NetworkResourcesData.cpp:
              (WebCore::NetworkResourcesData::ResourceData::ResourceData):
              (WebCore::NetworkResourcesData::ResourceData::setContent):
              (WebCore::NetworkResourcesData::ResourceData::purgeContent):
              (WebCore::NetworkResourcesData::ResourceData::createDecoder):
              (WebCore::NetworkResourcesData::ResourceData::dataLength):
              (WebCore::NetworkResourcesData::ResourceData::appendData):
              (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
              (WebCore::NetworkResourcesData::NetworkResourcesData):
              (WebCore::NetworkResourcesData::responseReceived):
              (WebCore::NetworkResourcesData::setResourceContent):
              (WebCore::NetworkResourcesData::maybeAddResourceData):
              (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
              (WebCore::NetworkResourcesData::data):
              (WebCore::NetworkResourcesData::clear):
              (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
              (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
              (WebCore::NetworkResourcesData::ensureFreeSpace):
              * inspector/NetworkResourcesData.h:
              (WebCore::NetworkResourcesData::ResourceData::hasContent):
              (WebCore::NetworkResourcesData::ResourceData::content):
              (WebCore::NetworkResourcesData::ResourceData::decoder):
              (WebCore::NetworkResourcesData::ResourceData::buffer):
              (WebCore::NetworkResourcesData::ResourceData::setBuffer):
              (WebCore::NetworkResourcesData::ResourceData::hasData):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.get contentEncoded):
              * inspector/front-end/ResourcePreviewView.js:
              (WebInspector.ResourcePreviewView.prototype.contentLoaded):
              (WebInspector.ResourcePreviewView.prototype._createEmptyView):
              (WebInspector.ResourcePreviewView.prototype._createPreviewView):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.hasTextContent):
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::didReceiveData):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::willLoadMediaElementURL):
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::loadResourceSynchronously):
              (WebCore::FrameLoader::loadedResourceFromMemoryCache):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::didReceiveData):
              (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
              (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
              * loader/ResourceLoadNotifier.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::didReceiveData):
              * testing/Internals.cpp:
              (WebCore::Internals::setInspectorResourcesDataSizeLimits):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Web Inspector: Show content for plugin requests in network panel.
              https://bugs.webkit.org/show_bug.cgi?id=30080
      
              Reviewed by Pavel Feldman.
      
              * win/WebKit2.def:
              * win/WebKit2CFLite.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      169a9b5d
  3. 25 Jun, 2011 1 commit
  4. 24 Jun, 2011 1 commit
    • dominicc@chromium.org's avatar
      2011-06-24 Dominic Cooney <dominicc@chromium.org> · 958d2e44
      dominicc@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * Source/autotools/symbols.filter: Export symbols for GTK.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Update tests to use internals.{ensureShadowRoot, shadowRoot,
              shadowPseudoId, removeShadowRoot} instead of layoutTestController.
      
              * fast/dom/HTMLKeygenElement/keygen-expected.txt:
              * fast/dom/HTMLKeygenElement/keygen.html:
              * fast/dom/HTMLMeterElement/meter-clone-expected.txt:
              * fast/dom/HTMLMeterElement/meter-clone.html:
              * fast/dom/HTMLProgressElement/progress-clone-expected.txt:
              * fast/dom/HTMLProgressElement/progress-clone.html:
              * fast/dom/shadow/activeelement-should-be-shadowhost.html:
              * fast/dom/shadow/create-content-element.html:
              * fast/dom/shadow/gc-shadow-expected.txt:
              * fast/dom/shadow/gc-shadow.html:
              * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
              * fast/dom/shadow/layout-tests-can-access-shadow.html:
              * fast/dom/shadow/nodetype.html:
              * fast/dom/shadow/tab-order-iframe-and-shadow.html:
              * fast/events/shadow-boundary-crossing.html:
              * fast/forms/resources/common.js:
              (getValidationMessageBubbleNode):
              * fast/html/clone-keygen-expected.txt:
              * fast/html/clone-keygen.html:
              * fast/html/clone-range-expected.txt:
              * fast/html/clone-range.html:
              * fast/html/details-clone.html:
              * fullscreen/video-controls-override-expected.txt:
              * fullscreen/video-controls-override.html:
              * media/audio-controls-do-not-fade-out.html:
              * media/media-controls.js:
              (mediaControlsButtonCoordinates):
              * media/video-controls-in-media-document.html:
              * platform/win/Skipped: shadowRoot and friends now available on win.
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              * WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
              * testing/Internals.cpp: The new home of shadowRoot and friends.
              (WebCore::Internals::ensureShadowRoot):
              (WebCore::Internals::shadowRoot):
              (WebCore::Internals::removeShadowRoot):
              (WebCore::Internals::shadowPseudoId):
              * testing/Internals.h:
              * testing/Internals.idl:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Chromium API. These are not
              required any more.
      
              * public/WebElement.h:
              * src/WebElement.cpp:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from GTK DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from Mac API. These are not
              required any more.
      
              * DOM/WebDOMOperations.mm:
              * DOM/WebDOMOperationsPrivate.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow-DOM related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow-DOM related methods from Qt DRT API. These are not
              required any more.
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-06-24  Dominic Cooney  <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove shadow DOM-related methods from WebKit2 API. These are not
              required any more.
      
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
              * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
              * win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
              * win/WebKit2CFLite.def: Same for Cairo.
      2011-06-24  Dominic Cooney   <dominicc@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Convert shadow DOM-related tests to use window.internals
              https://bugs.webkit.org/show_bug.cgi?id=61671
      
              Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
              removeShadowRoot from layoutTestController; these have been
              replaced by equivalents in window.internals instead.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      958d2e44
  5. 20 Jun, 2011 1 commit
  6. 06 Jun, 2011 1 commit
  7. 15 Jan, 2011 1 commit
    • abarth@webkit.org's avatar
      Move WebKit2 into Source · be159d97
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52438
      
      Rubber-stamped by Eric Seidel.
      
      .: 
      
      Update reference to WebKit2.
      
      * DerivedSources.pro:
      * GNUmakefile.am:
      * Makefile:
      * Source/cmake/WebKitPackaging.cmake:
      * WebKit.pro:
      * configure.ac:
      
      Source/WebCore: 
      
      * WebCore.pro:
      
      Source/WebKit2: 
      
      * DerivedSources.pro:
      * GNUmakefile.am:
      * WebKit2.pro:
      * WebProcess.pro:
      * win/WebKit2.vcproj:
      * win/WebKit2WebProcess.vcproj:
      
      Tools: 
      
      * MiniBrowser/qt/MiniBrowser.pro:
      * Scripts/build-webkit:
      * Scripts/do-file-rename:
      * Scripts/do-webcore-rename:
      * Scripts/test-webkitpy:
      * Scripts/webkitdirs.pm:
      * Scripts/webkitpy/style/checker.py:
      * WebKitTestRunner/DerivedSources.pro:
      * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
      * WebKitTestRunner/qt/WebKitTestRunner.pro:
      
      WebKit/win: 
      
      Update reference to WebKit2.
      
      * WebKit.vcproj/WebKit.sln:
      
      Websites/bugs.webkit.org: 
      
      Remove WebKit2 from the list of top-level source directories.
      
      * PrettyPatch/PrettyPatch.rb:
      
      
      
      git-svn-id: http://svn.webkit.org/...
      be159d97
  8. 15 Jul, 2010 1 commit
    • bfulgham@webkit.org's avatar
      Patch for https://bugs.webkit.org/show_bug.cgi?id=42299 · 1a238f22
      bfulgham@webkit.org authored
      Correct WinCairo build for new WebKit2 project structure.
      
      Reviewed by Steve Falkenburg.
      
      WebKit/win: 
      
      * WebKit.vcproj/WebKit.sln:
      
      WebKit2: 
      
      * win/WebKit2Apple.vsprops: Put WebKit2.def here.
      * win/WebKit2CFLite.def: Added CFLite version of def file.
      * win/WebKit2CFLite.vsprops: Add new WebKit2CFLite.def here.
      * win/WebKit2Common.vsprops: Remove WebKit2.def definition as
        WinCairo and Apple need different versions of this.
      * win/WebKit2WebProcess.vcproj: Add a new Debug_Cairo target
        for the WebKit2WebProcess project.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a238f22
  9. 12 Jul, 2010 1 commit
    • sfalken@apple.com's avatar
      WebKit/win: <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL · 31f61300
      sfalken@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=40921
      
      Reviewed by Alice Liu.
      
      Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
      WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
              
      This is a first step. We'll likely want to migrate the remainder of
      the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
      
      * WebKit.vcproj/WebKit.def: Removed.
      * WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL.
      * WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib.
      Renamed project name to WebKitLib to avoid confusion and naming conflicts.
      Generate intermediate pdb file for debuggability of static lib.
      Removed DLL-related options.        
      * WebKit.vcproj/deleteButton.png: Removed.
      * WebKit.vcproj/deleteButtonPressed.png: Removed.
      * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed.
      * WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed.
      * WebKit.vcproj/fsVideoExitFullscreen.png: Removed.
      * WebKit.vcproj/fsVideoPause.png: Removed.
      * WebKit.vcproj/fsVideoPlay.png: Removed.
      * WebKit.vcproj/missingImage.png: Removed.
      * WebKit.vcproj/nullplugin.png: Removed.
      * WebKit.vcproj/panEastCursor.png: Removed.
      * WebKit.vcproj/panIcon.png: Removed.
      * WebKit.vcproj/panNorthCursor.png: Removed.
      * WebKit.vcproj/panNorthEastCursor.png: Removed.
      * WebKit.vcproj/panNorthWestCursor.png: Removed.
      * WebKit.vcproj/panSouthCursor.png: Removed.
      * WebKit.vcproj/panSouthEastCursor.png: Removed.
      * WebKit.vcproj/panSouthWestCursor.png: Removed.
      * WebKit.vcproj/panWestCursor.png: Removed.
      * WebKit.vcproj/searchCancel.png: Removed.
      * WebKit.vcproj/searchCancelPressed.png: Removed.
      * WebKit.vcproj/searchMagnifier.png: Removed.
      * WebKit.vcproj/searchMagnifierResults.png: Removed.
      * WebKit.vcproj/textAreaResizeCorner.png: Removed.
      * WebKit.vcproj/verticalTextCursor.png: Removed.
      * WebKit.vcproj/zoomInCursor.png: Removed.
      * WebKit.vcproj/zoomOutCursor.png: Removed.
      
      WebKit2: <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
      https://bugs.webkit.org/show_bug.cgi?id=40921
              
      Reviewed by Alice Liu.
      
      Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
      WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
      
      This is a first step. We'll likely want to migrate the remainder of
      the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
      
      * UIProcess/API/C/WKBase.h: Updated to new BUILDING_ name.
      * WebProcess/InjectedBundle/API/c/WKBundleBase.h: Updated to new BUILDING_ name.
      * WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Removed.
      * WebProcess/win/DllMain.cpp: Removed. Overlaps with implementation in WebKitLib.lib.
      * WebProcess/win/WebLocalizableStrings.cpp: Removed. Overlaps with implementation in WebKitLib.lib.
      * WebProcess/win/WebLocalizableStrings.h: Removed. Overlaps with implementation in WebKitLib.lib.
      * win/WebKit2.def: Added. Copied from WebKit project.
      * win/WebKit2.rc: Added resources previously in WebKit.
      * win/WebKit2.vcproj: Changed project name to WebKit so we will link output to WebKit.dll.
      Removed implementations overlapping with WebKitLib (WebCoreLocalizedStrings, DllMain, WebLocalizableStrings, WebProcessMain).
      * win/WebKit2Common.vsprops: Use a framework name of WebKit instead of WebKit2 to reflect project name.
      Renamed BUILDING_WEBKIT2 to BUILDING_WEBKIT since there is now just a single WebKit.dll.
      * win/WebKit2WebProcess.vcproj: Link against WebKit instead of WebKit2 due to renaming.        
      * win/deleteButton.png: Copied from ../WebKit/win/WebKit.vcproj/deleteButton.png.
      * win/deleteButtonPressed.png: Copied from ../WebKit/win/WebKit.vcproj/deleteButtonPressed.png.
      * win/fsVideoAudioVolumeHigh.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoAudioVolumeHigh.png.
      * win/fsVideoAudioVolumeLow.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoAudioVolumeLow.png.
      * win/fsVideoExitFullscreen.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoExitFullscreen.png.
      * win/fsVideoPause.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoPause.png.
      * win/fsVideoPlay.png: Copied from ../WebKit/win/WebKit.vcproj/fsVideoPlay.png.
      * win/missingImage.png: Copied from ../WebKit/win/WebKit.vcproj/missingImage.png.
      * win/nullplugin.png: Copied from ../WebKit/win/WebKit.vcproj/nullplugin.png.
      * win/panEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panEastCursor.png.
      * win/panIcon.png: Copied from ../WebKit/win/WebKit.vcproj/panIcon.png.
      * win/panNorthCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthCursor.png.
      * win/panNorthEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthEastCursor.png.
      * win/panNorthWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panNorthWestCursor.png.
      * win/panSouthCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthCursor.png.
      * win/panSouthEastCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthEastCursor.png.
      * win/panSouthWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panSouthWestCursor.png.
      * win/panWestCursor.png: Copied from ../WebKit/win/WebKit.vcproj/panWestCursor.png.
      * win/searchCancel.png: Copied from ../WebKit/win/WebKit.vcproj/searchCancel.png.
      * win/searchCancelPressed.png: Copied from ../WebKit/win/WebKit.vcproj/searchCancelPressed.png.
      * win/searchMagnifier.png: Copied from ../WebKit/win/WebKit.vcproj/searchMagnifier.png.
      * win/searchMagnifierResults.png: Copied from ../WebKit/win/WebKit.vcproj/searchMagnifierResults.png.
      * win/textAreaResizeCorner.png: Copied from ../WebKit/win/WebKit.vcproj/textAreaResizeCorner.png.
      * win/verticalTextCursor.png: Copied from ../WebKit/win/WebKit.vcproj/verticalTextCursor.png.
      * win/zoomInCursor.png: Copied from ../WebKit/win/WebKit.vcproj/zoomInCursor.png.
      * win/zoomOutCursor.png: Copied from ../WebKit/win/WebKit.vcproj/zoomOutCursor.png.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31f61300
  10. 22 Feb, 2010 1 commit
  11. 18 Feb, 2010 1 commit
  12. 13 May, 2009 1 commit
    • dimich@chromium.org's avatar
      JavaScriptCore: · c85b91df
      dimich@chromium.org authored
      2009-05-13  Dmitry Titov  <dimich@chromium.org>
      
              Rubber-stamped by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=25746
              Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
      
              * JavaScriptCore.exp:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
              * bytecode/SamplingTool.cpp:
              (JSC::SamplingThread::start):
              (JSC::SamplingThread::stop):
              * bytecode/SamplingTool.h:
              * wtf/CrossThreadRefCounted.h:
              (WTF::CrossThreadRefCounted::CrossThreadRefCounted):
              (WTF::::ref):
              (WTF::::deref):
              * wtf/Threading.h:
              * wtf/ThreadingNone.cpp:
              * wtf/ThreadingPthreads.cpp:
              (WTF::threadMapMutex):
              (WTF::initializeThreading):
              (WTF::threadMap):
              (WTF::identifierByPthreadHandle):
              (WTF::establishIdentifierForPthreadHandle):
              (WTF::pthreadHandleForIdentifier):
              (WTF::clearPthreadHandleForIdentifier):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::detachThread):
              (WTF::currentThread):
              * wtf/ThreadingWin.cpp:
              (WTF::threadMapMutex):
              (WTF::initializeThreading):
              (WTF::threadMap):
              (WTF::storeThreadHandleByIdentifier):
              (WTF::threadHandleForIdentifier):
              (WTF::clearThreadHandleForIdentifier):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::detachThread):
              (WTF::currentThread):
              * wtf/gtk/ThreadingGtk.cpp:
              (WTF::threadMapMutex):
              (WTF::initializeThreading):
              (WTF::threadMap):
              (WTF::identifierByGthreadHandle):
              (WTF::establishIdentifierForThread):
              (WTF::threadForIdentifier):
              (WTF::clearThreadForIdentifier):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
              * wtf/qt/ThreadingQt.cpp:
              (WTF::threadMapMutex):
              (WTF::threadMap):
              (WTF::identifierByQthreadHandle):
              (WTF::establishIdentifierForThread):
              (WTF::clearThreadForIdentifier):
              (WTF::threadForIdentifier):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
      WebCore:
      
      2009-05-13  Dmitry Titov  <dimich@chromium.org>
      
              Rubber-stamped by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=25746
              Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::matchFunc):
              (WebCore::openFunc):
              (WebCore::createStringParser):
              (WebCore::createMemoryParser):
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):
              * platform/sql/SQLiteDatabase.cpp:
              (WebCore::SQLiteDatabase::SQLiteDatabase):
              (WebCore::SQLiteDatabase::close):
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::DatabaseThread):
              (WebCore::DatabaseThread::start):
              (WebCore::DatabaseThread::databaseThread):
              * storage/LocalStorageThread.cpp:
              (WebCore::LocalStorageThread::LocalStorageThread):
              (WebCore::LocalStorageThread::start):
              (WebCore::LocalStorageThread::localStorageThread):
              (WebCore::LocalStorageThread::scheduleImport):
              (WebCore::LocalStorageThread::scheduleSync):
              (WebCore::LocalStorageThread::terminate):
              * workers/WorkerThread.cpp:
              (WebCore::WorkerThread::WorkerThread):
              (WebCore::WorkerThread::start):
      
      WebKit/win:
      
      2009-05-13  Dmitry Titov  <dimich@chromium.org>
      
              Rubber-stamped by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=25746
              Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c85b91df
  13. 11 May, 2009 1 commit
    • dimich@chromium.org's avatar
      JavaScriptCore: · 558a0efc
      dimich@chromium.org authored
      2009-05-11  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              * wtf/Threading.h:
              (WTF::ThreadIdentifier::ThreadIdentifier):
              (WTF::ThreadIdentifier::isValid):
              (WTF::ThreadIdentifier::invalidate):
              (WTF::ThreadIdentifier::platformId):
              ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
              methods that are used across the code on thread ids: construction, comparisons,
              check for 'valid' state etc. '0' is used as invalid id, which happens to just work
              with all platform-specific thread id implementations.
      
              All the following files repeatedly reflect the new ThreadIdentifier for each platform.
              We remove ThreadMap and threadMapMutex from all of them, remove the functions that
              populated/searched/cleared the map and add platform-specific comparison operators
              for ThreadIdentifier.
      
              There are specific temporary workarounds for Safari 4 beta on OSX and Win32 since the
              public build uses WTF threading functions with old type of ThreadingIdentifier.
              The next time Safari 4 is rebuilt, it will 'automatically' pick up the new type and new
              functions so the deprecated ones can be removed.
      
              * wtf/gtk/ThreadingGtk.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
              * wtf/ThreadingNone.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
      
              * wtf/ThreadingPthreads.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::detachThread):
              (WTF::currentThread):
              (WTF::waitForThreadCompletion): This is a workaround for Safari 4 beta on Mac.
              Safari 4 is linked against old definition of ThreadIdentifier so it treats it as uint32_t.
              This 'old' variant of waitForThreadCompletion takes uint32_t and has the old decorated name, so Safari can
              load it from JavaScriptCore library. The other functions (CurrentThread() etc) happen to match their previous
              decorated names and, while they return pthread_t now, it is a pointer which round-trips through a uint32_t.
              This function will be removed as soon as Safari 4 will release next public build.
      
              * wtf/qt/ThreadingQt.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
              * wtf/ThreadingWin.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
              counter as a thread ID and mapped it into platform ID. Windows was using native thread
              id and mapped it into thread handle. Since we can always obtain a thread handle
              by thread id, createThread now closes the handle.
              (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
              it means the thread already exited.
              (WTF::detachThread):
              (WTF::currentThread):
              (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
              (WTF::waitForThreadCompletionDeprecated): same.
              (WTF::currentThreadDeprecated): same.
              (WTF::createThreadDeprecated): same.
      
              * bytecode/SamplingTool.h:
              * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
      
              * JavaScriptCore.exp: export lists - updated decorated names of the WTF threading functions
              since they now take a different type as a parameter.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
              that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
      
      WebCore:
      
      2009-05-11  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              Most of the change is in WTF.
              Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
              method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
              is now a class rather then an integer.
              Also, there is no need to initialize threadID in constructors to 0 now.
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
              since now ThreadIdentifier needs construction and we avoid having global initializers.
              (WebCore::matchFunc): use the new accessor function.
              (WebCore::openFunc): ditto.
              (WebCore::createStringParser): ditto.
              (WebCore::createMemoryParser): ditto.
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):
              * platform/sql/SQLiteDatabase.cpp:
              (WebCore::SQLiteDatabase::SQLiteDatabase):
              (WebCore::SQLiteDatabase::close):
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::start):
              (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
              * storage/LocalStorageThread.cpp:
              (WebCore::LocalStorageThread::start):
              (WebCore::LocalStorageThread::scheduleImport):
              (WebCore::LocalStorageThread::scheduleSync):
              (WebCore::LocalStorageThread::terminate):
              * workers/WorkerThread.cpp:
              (WebCore::WorkerThread::start):
              (WebCore::WorkerThread::WorkerThread):
              (WebCore::WorkerThread::start):
      
      WebKit/win:
      
      2009-05-11  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              Most of the change is in WTF and WebCore.
      
              * WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones.
              Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions
              which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones
              can be removed.
              * WebKit.vcproj/WebKit_debug.def: same.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      558a0efc
  14. 08 May, 2009 1 commit
  15. 07 May, 2009 1 commit
    • dimich@chromium.org's avatar
      JavaScriptCore: · 4b43290e
      dimich@chromium.org authored
      2009-05-07  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              * wtf/Threading.h:
              (WTF::ThreadIdentifier::ThreadIdentifier):
              (WTF::ThreadIdentifier::isValid):
              (WTF::ThreadIdentifier::invalidate):
              (WTF::ThreadIdentifier::platformId):
              ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and
              methods that are used across the code on thread ids: construction, comparisons,
              check for 'valid' state etc. '0' is used as invalid id, which happens to just work
              with all platform-specific thread id implementations.
      
              All the following files repeatedly reflect the new ThreadIdentifier for each platform.
              We remove ThreadMap and threadMapMutex from all of them, remove the functions that
              populated/searched/cleared the map and add platform-specific comparison operators
              for ThreadIdentifier.
      
              * wtf/gtk/ThreadingGtk.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
              * wtf/ThreadingNone.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
      
              * wtf/ThreadingPthreads.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::detachThread):
              (WTF::currentThread):
      
              * wtf/qt/ThreadingQt.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal):
              (WTF::waitForThreadCompletion):
              (WTF::currentThread):
      
              * wtf/ThreadingWin.cpp:
              (WTF::ThreadIdentifier::operator==):
              (WTF::ThreadIdentifier::operator!=):
              (WTF::initializeThreading):
              (WTF::createThreadInternal): All the platforms (except Windows) used a sequential
              counter as a thread ID and mapped it into platform ID. Windows was using native thread
              id and mapped it into thread handle. Since we can always obtain a thread handle
              by thread id, createThread now closes the handle.
              (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle,
              it means the thread already exited.
              (WTF::detachThread):
              (WTF::currentThread):
              (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now).
              (WTF::waitForThreadCompletionDeprecated): same.
              (WTF::currentThreadDeprecated): same.
              (WTF::createThreadDeprecated): same.
      
              * bytecode/SamplingTool.h:
              * bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
      
              * JavaScriptCore.exp: export lists - updated the WTF threading functions decorated names
              since they now take a different type as a parameter.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions
              that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.
      
      WebCore:
      
      2009-05-07  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              Most of the change is in WTF.
              Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
              method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
              is now a class rather then an integer.
              Also, there is no need to initialize threadID in constructors to 0 now.
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
              since now ThreadIdentifier needs construction and we avoid having global initializers.
              (WebCore::matchFunc): use the new accessor function.
              (WebCore::openFunc): ditto.
              (WebCore::createStringParser): ditto.
              (WebCore::createMemoryParser): ditto.
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):
              * platform/sql/SQLiteDatabase.cpp:
              (WebCore::SQLiteDatabase::SQLiteDatabase):
              (WebCore::SQLiteDatabase::close):
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::start):
              (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
              * storage/LocalStorageThread.cpp:
              (WebCore::LocalStorageThread::start):
              (WebCore::LocalStorageThread::scheduleImport):
              (WebCore::LocalStorageThread::scheduleSync):
              (WebCore::LocalStorageThread::terminate):
              * workers/WorkerThread.cpp:
              (WebCore::WorkerThread::start):
              (WebCore::WorkerThread::WorkerThread):
              (WebCore::WorkerThread::start):
      
      WebKit/win:
      
      2009-05-07  Dmitry Titov  <dimich@chromium.org>
      
              Reviewed by Alexey Proskuryakov and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=25348
              Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
      
              Most of the change is in WTF and WebCore.
      
              * WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones.
              Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions
              which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones
              can be removed.
              * WebKit.vcproj/WebKit_debug.def: same.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b43290e
  16. 21 Apr, 2009 1 commit
    • sfalken@apple.com's avatar
      WebKit/win: · 77458d83
      sfalken@apple.com authored
      2009-04-21  Steve Falkenburg  <sfalken@apple.com>
      
              Add registry-free CoCreateInstance API for WebKit clients: WebKitCreateInstance.
      
              Manifest-based registry-free COM continues to work for clients that have embedded
              manifests with isolated COM information.
              
              Reviewed by Adam Roben.
      
              * WebKit.vcproj/WebKit.def: Added WebKitCreateInstance.
              * WebKit.vcproj/WebKit.vcproj: Link against rpcrt4.dll for UUID hashing.
              * WebKit.vcproj/WebKit_debug.def: Added WebKitCreateInstance.
              * WebKitCOMAPI.cpp: Added.
              (CLSIDHash::hash):
              (CLSIDHash::equal):
              (CLSIDHashTraits::constructDeletedValue):
              (CLSIDHashTraits::isDeletedValue):
              (classFactory):
              (WebKitCreateInstance): New API.
              * WebKitCOMAPI.h: Added.
      
      WebKitTools:
      
      2009-04-21  Steve Falkenburg  <sfalken@apple.com>
      
              Use new WebKitCreateInstance API instead of CoCreateInstance
              or COMPtr's createInstance to instantiate WebKit COM objects.
      
              Reviewed by Adam Roben.
      
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (initialize):
              (runTest):
              (createWebViewAndOffscreenWindow):
              (main):
              * DumpRenderTree/win/DumpRenderTree.vcproj:
              * DumpRenderTree/win/GCControllerWin.cpp:
              (GCController::collect):
              (GCController::collectOnAlternateThread):
              (GCController::getJSObjectCount):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::keepWebHistory):
              (LayoutTestController::webHistoryItemCount):
              (LayoutTestController::setIconDatabaseEnabled):
              * DumpRenderTree/win/WorkQueueItemWin.cpp:
              (LoadItem::invoke):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77458d83
  17. 20 Apr, 2009 1 commit
    • sfalken@apple.com's avatar
      JavaScriptCore: · 46fc85ac
      sfalken@apple.com authored
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * API/JSBase.h: Export symbols with JS_EXPORT when using MSVC.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj: Build JavaScriptCore as a DLL instead of a static library.
              * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
              * runtime/InternalFunction.h: Specify JS_EXPORTDATA on exported data.
              * runtime/JSArray.h: Specify JS_EXPORTDATA on exported data.
              * runtime/JSFunction.h: Specify JS_EXPORTDATA on exported data.
              * runtime/StringObject.h: Specify JS_EXPORTDATA on exported data.
              * runtime/UString.h: Specify JS_EXPORTDATA on exported data.
      
      WebCore:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * config.h: Specify __declspec(dllexport/dllimport) appropriately when exporting data.
      
      WebKit/cf:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
              
              Reviewed by Oliver Hunt.
      
              * WebCoreSupport/WebInspectorClientCF.cpp: Workaround for lack of config.h in shared WebKit file (WebKit/win uses config.h from WebCore).
      
      WebKit/win:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * WebKit.vcproj/WebKit.def: Mark JavaScriptCore re-exports as deprecated.
              * WebKit.vcproj/WebKit.vcproj: Link against JavaScriptCore.dll
              * WebKit.vcproj/WebKit_debug.def: Mark JavaScriptCore re-exports as deprecated.
      
      WebKitLibraries:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * win/tools/vsprops/common.vsprops: Add BUILDING_{project} preprocessor define.
      
      WebKitTools:
      
      2009-04-20  Steve Falkenburg  <sfalken@apple.com>
      
              Separate JavaScriptCore.dll from WebKit.dll.
              Slight performance improvement or no change on benchmarks.
              
              Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
              and simplifies standalone JavaScriptCore builds.
      
              Reviewed by Oliver Hunt.
      
              * DumpRenderTree/config.h: Specify JS, WebKit exported data as __declspec(dllimport)
              * DumpRenderTree/win/DumpRenderTree.vcproj: Link against JavaScriptCore.dll
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46fc85ac
  18. 11 Mar, 2009 1 commit
  19. 25 Feb, 2009 1 commit
  20. 24 Feb, 2009 1 commit
  21. 02 Dec, 2008 1 commit
  22. 29 Oct, 2008 2 commits
    • sfalken@apple.com's avatar
      JavaScriptCore: · 621341ba
      sfalken@apple.com authored
      2008-10-29  Steve Falkenburg  <sfalken@apple.com>
      
              <rdar://problem/6326563> Crash on launch
      
              For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
              
              Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
              callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
              the explicit lock/unlock functions, we can avoid this.
              
              Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
              
              Reviewed by Darin Adler.
      
              * wtf/Threading.h:
              (WTF::lockAtomicallyInitializedStaticMutex):
              (WTF::unlockAtomicallyInitializedStaticMutex):
              * wtf/ThreadingWin.cpp:
              (WTF::lockAtomicallyInitializedStaticMutex):
              (WTF::unlockAtomicallyInitializedStaticMutex):
      
      WebKit/win:
      
      2008-10-29  Steve Falkenburg  <sfalken@apple.com>
      
              <rdar://problem/6326563> Crash on launch
              
              For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
              
              Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
              callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
              the explicit lock/unlock functions, we can avoid this.
              
              Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
              
              Reviewed by Darin Adler.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      621341ba
    • jhoneycutt@apple.com's avatar
      2008-10-29 Jon Honeycutt <jhoneycutt@apple.com> · fa3ac1af
      jhoneycutt@apple.com authored
              Export atomicallyInitializedStaticMutex.
      
              Rubber-stamped by Steve Falkenburg.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa3ac1af
  23. 17 Oct, 2008 1 commit
  24. 15 Oct, 2008 1 commit
  25. 14 Oct, 2008 1 commit
  26. 29 Jul, 2008 2 commits
    • aroben@apple.com's avatar
      Export detachThread · 76f11066
      aroben@apple.com authored
              Reviewed by Geoff Garen.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76f11066
    • aroben@apple.com's avatar
      Add support for setting thread names on Windows · f0c8f24b
      aroben@apple.com authored
      JavaScriptCore:
      
              Add support for setting thread names on Windows
      
              These thread names make it much easier to identify particular threads
              in Visual Studio's Threads panel.
      
              WTF::createThread now takes a const char* representing the thread's
              name. On Windows, we throw a special exception to set this string as
              the thread's name. Other platforms do nothing with this name for now.
      
              Reviewed by Anders Carlsson.
      
              * JavaScriptCore.exp: Export the new version of createThread that
              takes 3 arguments (the old one continues to be exported for backward
              compatibility).
              * wtf/Threading.h: Add a threadName argument to createThread.
      
              * wtf/ThreadingGtk.cpp:
              (WTF::createThread):
              * wtf/ThreadingNone.cpp:
              (WTF::createThread):
              Updated for function signature change.
      
              * wtf/ThreadingPthreads.cpp:
              (WTF::createThread): Updated for function signature change. We keep
              around the old 2-argument version of createThread for backward
              compatibility.
      
              * wtf/ThreadingWin.cpp:
              (WTF::setThreadName): Added. This function's implementation came from
              MSDN.
              (WTF::initializeThreading): Set the name of the main thread.
              (WTF::createThread): Call setThreadName. We keep around the old
              2-argument version of createThread for backward compatibility.
      
      WebCore:
      
              Add names for WebCore's threads
      
              Reviewed by Anders Carlsson.
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::start):
              * storage/LocalStorageThread.cpp:
              (WebCore::LocalStorageThread::start):
              Pass in names to createThread.
      
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::runLoaderThread):
              (WebCore::ResourceHandle::loaderRunLoop):
              Changed to use WTF::createThread.
      
      WebKit/win:
      
              Export the new version of createThread
      
              Reviewed by Anders Carlsson.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
              Also moved the old version of createThread into the deprecated
              section.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0c8f24b
  27. 15 Jul, 2008 1 commit
    • aroben@apple.com's avatar
      Add WebKit[Set]ShouldUseFontSmoothing functions · a4595650
      aroben@apple.com authored
      WebCore:
      
              WebCore part of adding WebKit[Set]ShouldUseFontSmoothing functions
      
              <rdar://6059127>
      
              Reviewed by John Sullivan.
      
              * platform/graphics/win/FontCGWin.cpp:
              (WebCore::Font::drawGlyphs): Pass the result of
              WebCoreShouldUseFontSmoothing() into wkSetFontSmoothingStyle.
              * platform/win/WebCoreTextRenderer.cpp:
              (WebCore::WebCoreSetShouldUseFontSmoothing):
              (WebCore::WebCoreShouldUseFontSmoothing):
              Added.
              * platform/win/WebCoreTextRenderer.h:
      
      WebKit/win:
      
              Add WebKit[Set]ShouldUseFontSmoothing functions
      
              <rdar://6059127>
      
              Reviewed by John Sullivan.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
              Export the new functions.
              * WebKitGraphics.cpp:
              (WebKitSetShouldUseFontSmoothing):
              (WebKitShouldUseFontSmoothing):
              Call through to the relevant WebCore functions.
              * WebKitGraphics.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4595650
  28. 09 May, 2008 1 commit
    • beidson@apple.com's avatar
      WebKit/win: · 2de2bcf0
      beidson@apple.com authored
              Reviewed by Adam Roben
      
              Fix a hang-on-quit bug where in the DLL_PROCESS_DETACH DllMain callback, we assummed that
              we could cleanly shutdown WebKit but we couldn't because any background threads have already
              been uncleanly aborted at that point.
              
              * ForEachCoClass.cpp:
              (shutDownWebKit): Moved from WebKitDLL to here, to be exposed via WebKit.def
              * ForEachCoClass.h:
              
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
              
              * WebKitDLL.cpp:
              (DllMain): Don't call shutDownWebKit here
              
      WebKitTools:
              Reviewed by Adam Roben
      
              Explicitly call shutDownWebKit() before quitting.
      
              * Drosera/win/Drosera.cpp:
              (_tWinMain):
      
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (main):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2de2bcf0
  29. 29 Apr, 2008 1 commit
  30. 08 Apr, 2008 1 commit
  31. 07 Apr, 2008 1 commit
  32. 20 Dec, 2007 1 commit
    • kmccullough@apple.com's avatar
      WebKit/win: · 2370fa42
      kmccullough@apple.com authored
              Reviewed by Steve.
      
              - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to 
              WebKit.
      
              - Drosera and Safari need to use the same ProgIDs in order for
              CoCreateInstance to work properly.  The most robust way to do this is
              for WebKit to dynamically publish those ProgIDs.
      
              * ForEachCoClass.cpp: Added.
              (setUseOpenSourceWebKit):
              (progIDForClass):
              * ForEachCoClass.h: Added functionality to publish ProgIDs.
              * WebKit.vcproj/WebKit.def: Exposed added functions for applications.
              * WebKit.vcproj/WebKit.vcproj: Added ForEachCoClass.cpp
              * WebKit.vcproj/WebKit_debug.def: Exposed added functions fori
              applications.
      
      WebKitTools:
      
              Reviewed by Steve.
      
              - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
              WebKit.
      
              - Drosera and Safari need to use the same ProgIDs in order for
              CoCreateInstance to work properly.  The most robust way to do this is
              for WebKit to dynamically publish those ProgIDs.
      
              * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
              (DebuggerClient::createWebViewWithRequest):
              * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
              statics.
              (Drosera::initUI):
              (Drosera::attach):
              (Drosera::attemptToCreateServerConnection):
              * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
              * Drosera/win/ServerConnection.cpp: Reformat the connection function and
              make use of the published ProgIDs.
              (ServerConnection::attemptToCreateServerConnection):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2370fa42
  33. 10 Dec, 2007 1 commit
    • aroben@apple.com's avatar
      Make WebLocalizableStrings work a little more like the Mac version · 22a1a3d9
      aroben@apple.com authored
               Reviewed by Steve.
      
               * WebKit.vcproj/WebKit.def: Deprecated SetWebLocalizedStringMainBundle.
               * WebKit.vcproj/WebKit_debug.def: Ditto.
               * WebLocalizableStrings.cpp:
               (createWebKitBundle): Changed to only create the bundle once.
               (cfBundleForStringsBundle): Added. Code was factored out of
               copyLocalizedStringFromBundle. We now use the CFBundleGetMainBundle to
               get the main bundle and WebLocalizableStringsBundle's identifier to
               fetch the framework's bundle.
               (copyLocalizedStringFromBundle): Changed to call
               cfBundleForStringsBundle.
               (cacheString): Cleaned up logic a bit with an early return.
               (SetWebLocalizedStringMainBundle): Moved down with the other
               deprecated functions and made into a no-op.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22a1a3d9
  34. 29 Nov, 2007 1 commit
    • kmccullough@apple.com's avatar
      WebKit/win: · dde9c54a
      kmccullough@apple.com authored
              Reviewed by Sam.
      
              - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
              dying and vice versa.
      
              * Interfaces/IWebScriptDebugListener.idl: Added the new function to the
              interface.
              * WebKit.vcproj/WebKit.def: Added the new function to the def file so
              Safari can tell WebKit when the server is dying.
              * WebKit.vcproj/WebKit_debug.def: Ditto.
              * WebKitDLL.cpp: Added the new function for Safari to call.
              (RunAsLocalServer):
              (LocalServerDidDie):
              * WebScriptDebugServer.cpp: 
              (WebScriptDebugServer::WebScriptDebugServer): Removed unused member.
              (WebScriptDebugServer::sharedWebScriptDebugServer): Ditto, and added new
              member to prevent adding or removing listeners when the server is dying.
              (WebScriptDebugServer::addListener): Don't let new listeners be added
              when the server is dying.
              (WebScriptDebugServer::removeListener): Don't let listeners remove
              themselves when the server is dying.  The server will remove them all
              anyways.
              (WebScriptDebugServer::serverDidDie): Notify all listeners that the
              server is dying and remove all listeners.
              * WebScriptDebugServer.h: Added the new method and removed an unused
              member.
      
      WebKitTools:
      
              Reviewed by Sam.
      
              - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
              dying and vice versa.
              - This fix will allow Drosera and Safari to reconnect if either of them
              closes correctly, but does not fix the case where one of them dies
              silently.
      
              * Drosera/win/ServerConnection.cpp:
              (ServerConnection::attemptToCreateServerConnection): Added a safety
              check, because it's possilbe to try to connect to a server that's dying.
              (ServerConnection::serverDidDie): Implemented. This resets Drosera when
              the server has died.
              * Drosera/win/ServerConnection.h: Added the new function and removed
              an unnecessary member.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dde9c54a
  35. 12 Nov, 2007 1 commit
  36. 06 Nov, 2007 1 commit
    • aroben's avatar
      Change WebLocalizableStrings to take UTF-8 C strings · 0cd3ba58
      aroben authored
               This matches the way things work on the Mac, and will allow source
               files containing localizable strings to be shared between Mac and
               Windows. The old functions have not been removed for compatibility
               reasons, but are now just wrappers around the new UTF-8 functions.
      
               Reviewed by Ada.
      
               * WebKit.vcproj/WebKit.def: Added new functions.
               * WebKit.vcproj/WebKit_debug.def: Ditto.
               * WebLocalizableStrings.cpp:
               (copyLocalizedStringFromBundle): Changed to take a WebCore::String
               representing the key.
               (localizedString): Refactored from WebLocalizedString. Takes a
               WebCore::String representing the key.
               (localizedLPCTSTR): Ditto for WebLocalizedLPCTSTR.
               (WebLocalizedStringUTF8): Added. Takes a UTF-8 C string as the key.
               (WebLocalizedLPCTSTRUTF8): Ditto.
               (WebLocalizedString): Changed to call localizedString.
               (WebLocalizedLPCTSTR): Changed to call localizedLPCTSTR.
               * WebLocalizableStrings.h: Changed macros to use the new UTF-8
               functions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cd3ba58
  37. 26 Oct, 2007 1 commit
    • kmccullo's avatar
      JavaScriptCore: · 8baf9b90
      kmccullo authored
              Reviewed by Sam and Steve.
      
              - Added convenience methods for converting between BSTR and JSStringRefs
      
              * API/JSStringRefCOM.cpp: Added.
              (JSStringCreateWithCFString):
              (JSStringCopyCFString):
              * API/JSStringRefCOM.h: Added.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      win:
      
              Reviewed by Sam and Steve.
      
              - Added convenience methods for converting between BSTR and JSSTringRefs
              - Added WebKit_debug.def to the project.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit.vcproj:
              * WebKit.vcproj/WebKit_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8baf9b90