1. 13 Jul, 2011 40 commits
    • levin@chromium.org's avatar
      Possible race condition in ThreadIdentifierData::initializeKeyOnce and shouldCallRealDebugger. · eeedb3da
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64465
      
      Reviewed by Dmitry Titov.
      
      There isn't a good way to test this as it is very highly unlikely to occur.
      
      Source/JavaScriptCore:
      
      * wtf/ThreadIdentifierDataPthreads.cpp:
      (WTF::ThreadIdentifierData::initializeKeyOnce): Since scoped static initialization
      isn't thread-safe, change the initialization to be global.
      
      Source/WebKit2:
      
      * PluginProcess/mac/PluginProcessMac.mm:
      (WebKit::shouldCallRealDebugger): :Since scoped static initialization
      isn't thread-safe, change the initialization to be global.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eeedb3da
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=64424 · 4710a59a
      barraclough@apple.com authored
      Our direct eval behaviour deviates slightly from the spec.
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore: 
      
      The ES5 spec defines a concept of 'Direct Call to Eval' (see section 15.1.2.1.1), where
      behaviour will differ from that of an indirect call (e.g. " { eval: window.eval }.eval();"
      or "var a = eval; a();" are indirect calls), particularly in non-strict scopes variables
      may be introduced into the caller's environment.
      
      ES5 direct calls are any call where the callee function is provided by a reference, a base
      of that Reference is an EnvironmentRecord (this corresponds to all productions
      "PrimaryExpression: Identifier", see 10.2.2.1 GetIdentifierReference), and where the name
      of the reference is "eval". This means any expression of the form "eval(...)", and that
      calls the standard built in eval method from on the Global Object, is considered to be
      direct.
      
      In JavaScriptCore we are currently overly restrictive. We also check that the
      EnvironmentRecord that is the base of the reference is the Declaractive Environment Record
      at the root of the scope chain, corresponding to the Global Object - an "eval(..)" statement
      that hits a var eval in a nested scope is not considered to be direct. This behaviour does
      not emanate from the spec, and is incorrect.
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::privateExecute):
          - Fixed direct eval check in op_call_eval.
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
          - Fixed direct eval check in op_call_eval.
      * runtime/Executable.h:
      (JSC::isHostFunction):
          - Added check for host function with specific NativeFunction.
      
      LayoutTests: 
      
      Correct expected results.
      
      * fast/js/eval-keyword-vs-function-expected.txt:
      * fast/js/eval-keyword-vs-function.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4710a59a
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] Fix for comment #23 on wrap-shape parsing bug 61726 · 68340cff
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64464
      
      Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-13
      Reviewed by Tony Chang.
      
      No new tests needed.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseWrapShapeRect): Removed the "valid" local.
      (WebCore::CSSParser::parseWrapShapeCircle): Removed the "valid" local.
      (WebCore::CSSParser::parseWrapShapeEllipse): Removed the "valid" local.
      * css/CSSPrimitiveValue.cpp:
      * css/CSSWrapShapes.h:
      (WebCore::CSSWrapShapePolygon::getXAt): Replaced bit shift with multiplication.
      (WebCore::CSSWrapShapePolygon::getYAt): Replaced bit shift with multiplication.
      * rendering/style/RenderStyle.cpp:
      * rendering/style/StyleRareNonInheritedData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68340cff
    • inferno@chromium.org's avatar
      Source/WebCore: Patch by Abhishek Arya <inferno@chromium.org> on 2011-07-13 · 670ab750
      inferno@chromium.org authored
      Reviewed by Adam Barth.
      
      Issue with Frame lifetime due to deletion in beforeload event.
      https://bugs.webkit.org/show_bug.cgi?id=64457
      
      Copy the Frame protector higher in the stack from loadWithDocumentLoader
      to loadFrameRequest since any of loadPostRequest or loadURL can call
      loadWithDocumentLoader, thereby dispatching the beforeload event and
      blowing away the frame. This deleted frame will be later accessed in
      the loadFrameRequest function causing a crash.
      
      Test: fast/events/form-iframe-target-before-load-crash2.html
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::loadFrameRequest):
      (WebCore::FrameLoader::loadWithDocumentLoader):
      
      LayoutTests: Tests that we do not crash when frame is blown away in a beforeload
      event.
      https://bugs.webkit.org/show_bug.cgi?id=64457
      
      Reviewed by Adam Barth.
      
      * fast/events/form-iframe-target-before-load-crash.html:
      * fast/events/form-iframe-target-before-load-crash2-expected.txt: Added.
      * fast/events/form-iframe-target-before-load-crash2.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      670ab750
    • commit-queue@webkit.org's avatar
      [CSSRegions]content:-webkit-from-flow not applied correctly · 0d19ba11
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64438
      
      Patch by Mihnea Ovidenie <mihnea@adobe.com> on 2011-07-13
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Forgot to modify getStringValue(), i was modifying only getStringValue(ExceptionCode&).
      
      Test: fast/regions/content-webkit-from-flow-parsing.html (existing).
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::getStringValue):
      
      LayoutTests:
      
      Correct the layout test for content:-webkit-from-flow parsing. Testing getComputedStyle values for content property
      was not done properly, as "flow-name" was passed instead of "-webkit-from-flow:'flow-name'".
      
      * fast/regions/content-webkit-from-flow-parsing-expected.txt:
      * fast/regions/script-tests/content-webkit-from-flow-parsing.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d19ba11
    • dglazkov@chromium.org's avatar
      Eliminate TestExpectationsFile. · eb48819d
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64458
      
      Turns out, we can just use a Python list.
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationsFile.append into TestExpectationParser.parse_list,
          removed TestExpectationsFile.
      * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Moved tests to better reflect new names, removed iterator test,
          since there's no more custom iterator machinery.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb48819d
    • rniwa@webkit.org's avatar
      Don't reuse the last InsertTextCommand · 1a364300
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64416
      
      Reviewed by Justin Garcia.
      
      This patch makes the interface of InsertTextCommand less foreign. It now takes arguments in
      its constructor and executes the command in doApply like other edit commands.
      
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::applyCommandToComposite): Added.
      * editing/CompositeEditCommand.h:
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::InsertTextCommand): Takes arguments input used to take.
      (WebCore::InsertTextCommand::doApply): Renamed from input.
      * editing/InsertTextCommand.h:
      (WebCore::InsertTextCommand::create): Takes arguments input used to take.
      * editing/TypingCommand.cpp:
      (WebCore::TypingCommand::insertTextRunWithoutNewlines): Creates InsertTextCommand.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a364300
    • philn@webkit.org's avatar
      2011-07-13 Philippe Normand <pnormand@igalia.com> · a4d83f9d
      philn@webkit.org authored
              Unreviewed, added my other email addresses.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4d83f9d
    • dslomov@google.com's avatar
      2011-07-12 Dmitry Lomov <dslomov@google.com> · 40f7d99b
      dslomov@google.com authored
              https://bugs.webkit.org/show_bug.cgi?id=63041
              [Chromium][V8] Make DOMDataStore per-isolate
              This patch:
               - makes DOMData class an utility class with static members only
               - adds an isolate-specific DOMDataStore in V8BindingPerIsolateData.
              Dromaeo benchmarks are not affected.
      
              Reviewed by Adam Barth.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40f7d99b
    • abarth@webkit.org's avatar
      Folks should only be listed once. · 29d91b4f
      abarth@webkit.org authored
      * Scripts/webkitpy/common/config/committers.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29d91b4f
    • philn@webkit.org's avatar
      2011-07-13 Philippe Normand <pnormand@igalia.com> · 7808a230
      philn@webkit.org authored
              Unreviewed, adding myself as Reviewer.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7808a230
    • abarth@webkit.org's avatar
      Fix flickering bug introduced by my previous patch. I forgot to change · 3c1b2656
      abarth@webkit.org authored
      the name of the class everywhere.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c1b2656
    • philn@webkit.org's avatar
      [GTK] media/media-blocked-by-willsendrequest.html fails · 2bac19c4
      philn@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=63699
      
              Reviewed by Martin Robinson.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (willSendRequestCallback): Abort the request if explicitely asked
              by the LayoutTestController's willSendRequestReturnsNull() function.
      
      LayoutTests:
      
              [GTK] media/media-blocked-by-willsendrequest.html fails
              https://bugs.webkit.org/show_bug.cgi?id=63699
      
              Reviewed by Martin Robinson.
      
              * platform/gtk/Skipped: Unskip fixed test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bac19c4
    • abarth@webkit.org's avatar
      Remove "Dismiss" button from garden-o-matic butterbar · 49097b5c
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64443
      
      Reviewed by Dimitri Glazkov.
      
      We don't have any persistent butter bar messages yet, so the dismiss
      button is premature (and fairly heavy, visually).
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49097b5c
    • simon.fraser@apple.com's avatar
      2011-07-12 Simon Fraser <simon.fraser@apple.com> · 9f6e15a8
      simon.fraser@apple.com authored
              Rename compositing-related updateContentsScale() methods
              https://bugs.webkit.org/show_bug.cgi?id=64430
      
              Reviewed by Joseph Pecoraro.
      
              Rename updateContentsScale() to something less presumptuous; layers may choose
              to do something other than update their contents scale when the page scale factor
              changes. pageScaleFactorChanged() is a better name.
      
              * page/Frame.cpp:
              (WebCore::Frame::pageScaleFactorChanged):
              (WebCore::Frame::scalePage):
              * page/Frame.h:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::pageScaleFactorChanged):
              * rendering/RenderLayer.h:
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::pageScaleFactorChanged):
              * rendering/RenderLayerBacking.h:
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::pageScaleFactorChanged):
              * rendering/RenderLayerCompositor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f6e15a8
    • abarth@webkit.org's avatar
      Refine garden-o-matic status pane · 38a952ee
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64442
      
      Reviewed by Dimitri Glazkov.
      
      This patch makes two improvements to the status pane:
      
      1) We only query the server for failure types that we're expecting.
         This dramatically reduces the number of HTTP requests, making
         loading the status pane faster.
      
      2) The status pane now displays which test and which builder it is
         showing results for.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38a952ee
    • abarth@webkit.org's avatar
      garden-o-matic should show test results · e5211ca0
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64440
      
      Reviewed by Adam Roben.
      
      This patch introduces the results detail pane, which appears at the
      bottom of the window and contains test results from the bots.
      Currently, you can activate the pane by mousing over one of the builder
      names associated with a failing test.
      
      This is just a first iteration of the UI.  There's no way to resize or
      zoom in on elements of the details pane, and images likely aren't sized
      correctly, but it's a place to start.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
          - Add constants for our data attributes so we don't typo them!
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
          - Add DOM structure for the details pane.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
          - Bind events for showing and hiding the details pane.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
          - Reduce the number of result types that we query for to avoid
            overfilling the details pane.  We'll probably need another
            solution here in the long-term.  For example, we could use tabs
            to pack more results into the pane.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
          - Now that we're using the config package during testing, we need
            to include it in the testing HTML.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
          - Change the DOM structure of the results detail to make it fit
            nicely in the details pane (rather than flowing freely in the
            body, as it did before).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5211ca0
    • aroben@apple.com's avatar
      Make TestFailures show every time a possibly-flaky test failed, but hide it by default · cd44cbdb
      aroben@apple.com authored
      It's useful to be able to see every time a flaky test failed to see whether it failed the
      same way every time. But doing so takes a lot of space, so the list of failures is now
      collapsed by default and can be revealed using a disclosure triangle.
      
      Fixes <http://webkit.org/b/64455> TestFailures page doesn't show as much information for
      flaky tests as I would like, even though the page is already so long
      
      Reviewed by Dimitri Glazkov.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
      (FlakyLayoutTestDetector.prototype.allFailures): Replaced flakinessExamples with this
      function. Now returns all failures for the given test.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
      Added. This just contains some simple tests of the FlakyLayoutTestDetector class. We'll add
      more over time.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
      (LayoutTestHistoryAnalyzer.prototype.start): Updated the documentation comment to reflect
      that we no longer return passing builds for possibly-flaky tests.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
      (.existing-bugs-list, .suspect-revisions-list, .flakiness-examples-list): Make the list of
      flakiness examples small, too, since it can get quite long.
      
      (.disclosure-triangle):
      (.expanded > .disclosure-triangle):
      Simple styles for the disclosure triangle.
      
      (.flakiness-examples-list): Collapse the list by default.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
      (ViewController.prototype._displayBuilder): Pass the total number of builds analyzed to
      _domForPossiblyFlakyTests.
      (ViewController.prototype._domForPossiblyFlakyTests): Put a disclosure triangle to the left
      of each test name, and the number of failures to the right. When the disclosure triangle is
      clicked for the first time, we build up the list of failures and expand the element. After
      that we just collapse or expand the element on subsequent clicks.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
      Pulled in new tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd44cbdb
    • aroben@apple.com's avatar
      Teach TestFailures to understand NRWT's output when it exits early due to too many failures · 6b70121b
      aroben@apple.com authored
      Fixes <http://webkit.org/b/64456> TestFailures page reports way too many failures when NRWT
      exits early
      
      Reviewed by Dimitri Glazkov.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
      (Builder.prototype.getNumberOfFailingTests): Relaxed the "Exiting early" test not to require
      it to be at the beginning of the line, since NRWT prints a bunch of junk earlier in the
      line. Tightened up the regex that's used to parse the number of failing tests to require the
      leading number to be followed by whitespace so that we won't parse the "2011" in
      "2011-07-13" as a number of failures.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
      Added a test for the above.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b70121b
    • dglazkov@chromium.org's avatar
      Extract model-like TestExpectationLine and TestExpectationFile from TestExpectations. · 556eef81
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64386
      
      This is the first step in converting TestExpectations to a real model.
      * TestExpectationsLine represents a line in the test_expectations.txt file, and
      * TestExpectationsFile represents the file, which is a collection of lines.
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
      * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      556eef81
    • commit-queue@webkit.org's avatar
      Fix compile for QRawFont. · 68b21210
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64453
      
      Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-07-13
      Reviewed by Andreas Kling.
      
      * platform/graphics/GraphicsContext.h:
      * platform/graphics/qt/FontQt.cpp:
      (WebCore::Font::drawGlyphs):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68b21210
    • xan@webkit.org's avatar
      2011-07-13 Xan Lopez <xlopez@igalia.com> · 2465ab3c
      xan@webkit.org authored
              [GTK] Do not grab focus too early in DRT.
      
              Reviewed by Gustavo Noronha.
      
              It causes a layout to happen and a progress signal to be emitted
              since r90900, but at this point we don't have a
              LayoutTestController object and we'll eventually crash. Since we
              already grab focus at the beginning of runTest() this is
              redundant, so get rid of it to fix the crash.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (main): remove call to grab_focus
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2465ab3c
    • loki@webkit.org's avatar
      2011-07-13 Gabor Loki <loki@webkit.org> · 1a8cd615
      loki@webkit.org authored
              [Qt] Flakey test: xmlhttprequest-50ms-download-dispatch.html on ARM
              https://bugs.webkit.org/show_bug.cgi?id=64452
      
              Rubber-stamped by Csaba Osztrogonác
      
              * platform/qt-arm/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a8cd615
    • ademar.reis@openbossa.org's avatar
      Reviewed by Andreas Kling. · 8c72ce68
      ademar.reis@openbossa.org authored
      Broken build on QNX
      https://bugs.webkit.org/show_bug.cgi?id=63717
      
      QNX doesn't support pthread's SA_RESTART (required by
      JSC_MULTIPLE_THREADS), JIT is broken at runtime and there a
      few minor compilation errors here and there.
      
      Original patch by Ritt Konstantin <ritt.ks@gmail.com>, also
      tested by him on QNX v6.5 (x86)
      
      * wtf/DateMath.cpp: fix usage of abs/labs
      * wtf/Platform.h: Disable JIT and JSC_MULTIPLE_THREADS
      * wtf/StackBounds.cpp: Add a couple of missing includes (and sort them)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c72ce68
    • andersca@apple.com's avatar
      If a compiler has nullptr support, include <cstddef> to get the nullptr_t definition · 2ee785e4
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64429
      
      Include the cstddef which has the nullptr_t typedef according to the C++0x standard.
      
      * wtf/NullPtr.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ee785e4
    • jknotten@chromium.org's avatar
      Reference Geolocation object from GeoNotifier and Geolocation::setIsAllowed. · 239d9416
      jknotten@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64363
      
      Reviewed by Tony Gentilcore.
      
      Source/WebCore:
      
      Test: fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html
      
      * page/Geolocation.cpp:
      (WebCore::Geolocation::setIsAllowed):
      * page/Geolocation.h:
      
      LayoutTests:
      
      * fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html: Added.
      * fast/dom/Geolocation/resources/remove-remote-context-in-error-callback-crash-inner.html: Added.
      * fast/dom/Geolocation/script-tests/remove-remote-context-in-error-callback-crash.js: Added.
      * fast/dom/Geolocation/remove-remote-context-in-error-callback-crash-expected.txt: Added.
      (gc):
      (onIframeReady):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      239d9416
    • vsevik@chromium.org's avatar
      Web Inspector: Network panel search needs each resource to have unique identifier. · 6b88b8d6
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64287
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/NetworkManager.js:
      (WebInspector.NetworkManager.prototype.requestContent):
      (WebInspector.NetworkDispatcher):
      (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
      (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
      (WebInspector.NetworkDispatcher.prototype._appendRedirect):
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkPanel.prototype._appendResource):
      (WebInspector.NetworkPanel.prototype._frameNavigated):
      (WebInspector.NetworkPanel.prototype._updateSearchMatchedListAfterResourceIdentifierChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b88b8d6
    • commit-queue@webkit.org's avatar
      Bridge RenderBoxModelObject::calculateBackgroundImageGeometry parameters into a class · f00baeb2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63987
      
      Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-13
      Reviewed by Hajime Morita.
      
      Change doesn't add new functionality. No test needed.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::maskClipRect):
      (WebCore::RenderBox::repaintLayerRectsForImage):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase):
      (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
      * rendering/RenderBoxModelObject.h:
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseX):
      (WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseY):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f00baeb2
    • morrita@google.com's avatar
      Refactoring: Ignored ExceptionCode value should be less annoying. · 0e64a691
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=63688
      
      Source/JavaScriptCore:
      
      Added ASSERT_AT macro.
      
      Reviewed by Darin Adler.
      
      * wtf/Assertions.h:
      
      Source/WebCore:
      
      - Introduced ExceptionCodePlaceholder class for the default parameter of ExceptionCode.
      - Introduced ASSERT_NO_EXCEPTION to check ExceptionCode not set to non-zero after the call.
      - Adopted ASSERT_NO_EXCEPTION in Range.cpp
      
      No new tests. No behaviour change.
      
      Reviewed by Darin Adler.
      
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/ExceptionCodePlaceholder.h: Added.
      (WebCore::ExceptionCodePlaceholder::ExceptionCodePlaceholder):
      (WebCore::ExceptionCodePlaceholder::operator ExceptionCode& ):
      (WebCore::IgnorableExceptionCode::IgnorableExceptionCode):
      (WebCore::CheckedExceptionCode::CheckedExceptionCode):
      (WebCore::CheckedExceptionCode::~CheckedExceptionCode):
      * dom/Range.cpp:
      (WebCore::Range::Range):
      (WebCore::Range::editingStartPosition):
      * dom/Range.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e64a691
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening. · 24f36e03
      ossy@webkit.org authored
      * platform/qt-mac/Skipped: Skip failing tests.
      * platform/qt/Skipped: Skip svg/text/small-fonts-2.svg because of the 32/64 bit bug.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24f36e03
    • andreas.kling@nokia.com's avatar
      [Qt][WK2] Remove invalid signal/slot connection in QTouchWebView. · 4e07c724
      andreas.kling@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64450
      
      Reviewed by Benjamin Poulain.
      
      The focusNextPrevChild() signal was removed, so we shouldn't try to
      connect to it.
      
      * UIProcess/API/qt/qtouchwebpage.cpp:
      (QTouchWebPagePrivate::setPage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e07c724
    • zimmermann@webkit.org's avatar
      2011-07-13 Nikolas Zimmermann <nzimmermann@rim.com> · e141ff12
      zimmermann@webkit.org authored
              Regression: OOB read in svg text run
              https://bugs.webkit.org/show_bug.cgi?id=63627
      
              Not reviewed.
      
              Fixed last minute typo leading to assertions.
      
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paintSelection):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e141ff12
    • andreas.kling@nokia.com's avatar
      [Qt][WK2] Undelayed WorkItems are leaked after execution. · 16d8fad3
      andreas.kling@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64447
      
      Reviewed by Benjamin Poulain.
      
      * Platform/qt/WorkQueueQt.cpp:
      (WorkQueue::WorkItemQt::executeAndDelete):
      (WorkQueue::WorkItemQt::timerEvent):
      (WorkQueue::scheduleWork):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16d8fad3
    • benjamin.poulain@nokia.com's avatar
      [Qt] REGRESSION(r90634): It made http/tests/misc/script-async.html fail with Qt 4.8.x · 3bfe6a1b
      benjamin.poulain@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64352
      
      Reviewed by Andreas Kling.
      
      Unskip http/tests/misc/script-async.html since the original change has been reverted.
      
      * platform/qt-4.8/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bfe6a1b
    • vsevik@chromium.org's avatar
      Chromium DevTools: Enable clear cache and cookies from network panel in chromium. · 9812a944
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64095
      
      Reviewed by Pavel Feldman.
      
      * src/js/DevTools.js:
      ():
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9812a944
    • caseq@chromium.org's avatar
      2011-07-12 Andrey Kosyakov <caseq@chromium.org> · 6439397e
      caseq@chromium.org authored
              Web Inspector: factor NetworkLogView out of Network panel
              https://bugs.webkit.org/show_bug.cgi?id=64366
      
              Reviewed by Pavel Feldman.
      
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkLogView):
              (WebInspector.NetworkLogView.prototype.get useLargeRows):
              (WebInspector.NetworkLogView.prototype.set allowPopover):
              (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor):
              (WebInspector.NetworkLogView.prototype.resize):
              (WebInspector.NetworkLogView.prototype._createTable):
              (WebInspector.NetworkLogView.prototype.show):
              (WebInspector.NetworkLogView.prototype.hide):
              (WebInspector.NetworkLogView.prototype._reset):
              (WebInspector.NetworkLogView.prototype.switchToDetailedView):
              (WebInspector.NetworkLogView.prototype.switchToBriefView):
              (WebInspector.NetworkLogView.prototype.get _setLargerResources):
              (WebInspector.NetworkLogView.prototype._getPopoverAnchor):
              (WebInspector.NetworkPanel):
              (WebInspector.NetworkPanel.prototype.get toolbarItemLabel):
              (WebInspector.NetworkPanel.prototype.get statusBarItems):
              (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor):
              (WebInspector.NetworkPanel.prototype.resize):
              (WebInspector.NetworkPanel.prototype._reset):
              (WebInspector.NetworkPanel.prototype.updateSidebarWidth):
              (WebInspector.NetworkPanel.prototype.updateMainViewWidth):
              (WebInspector.NetworkPanel.prototype.handleShortcut):
              (WebInspector.NetworkPanel.prototype.show):
              (WebInspector.NetworkPanel.prototype.hide):
              (WebInspector.NetworkPanel.prototype.get resources):
              (WebInspector.NetworkPanel.prototype.resourceById):
              (WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
              (WebInspector.NetworkPanel.prototype.showAnchorLocation):
              (WebInspector.NetworkPanel.prototype._onViewCleared):
              (WebInspector.NetworkPanel.prototype._onRowSizeChanged):
              (WebInspector.NetworkPanel.prototype._onResourceSelected):
              (WebInspector.NetworkPanel.prototype._showResource):
              (WebInspector.NetworkPanel.prototype._closeVisibleResource):
              (WebInspector.NetworkPanel.prototype._toggleGridMode):
              (WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
              (WebInspector.NetworkPanel.prototype.performSearch):
              (WebInspector.NetworkPanel.prototype.jumpToPreviousSearchResult):
              (WebInspector.NetworkPanel.prototype.jumpToNextSearchResult):
              (WebInspector.NetworkPanel.prototype.searchCanceled):
              (WebInspector.NetworkDataGridNode):
              (WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
              (WebInspector.NetworkDataGridNode.prototype.select):
              (WebInspector.NetworkDataGridNode.prototype.get selectable):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6439397e
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r90634. · 356a884e
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/90634
      https://bugs.webkit.org/show_bug.cgi?id=64448
      
      Qt HTTP Pipelining is not robust enough to be used in that
      generic way. (Requested by benjaminp on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-13
      
      * platform/network/qt/ResourceRequestQt.cpp:
      (WebCore::ResourceRequest::toNetworkRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      356a884e
    • ossy@webkit.org's avatar
      [Qt] Add expected results for the new passing tests and unskip them. · f9a2a195
      ossy@webkit.org authored
      Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-07-13
      Reviewed by Csaba Osztrogonác.
      
      * platform/qt/Skipped:
      * platform/qt/fast/[...]: Added.
      * platform/qt/svg/[...]: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9a2a195
    • zimmermann@webkit.org's avatar
      2011-07-13 Nikolas Zimmermann <nzimmermann@rim.com> · b7161461
      zimmermann@webkit.org authored
              Regression: OOB read in svg text run
              https://bugs.webkit.org/show_bug.cgi?id=63627
      
              Reviewed by Zoltan Herczeg.
      
              A TextRun is constructed for a portion of a string [a,b] whose original length is c (0 < a < b < c).
              The TextRun charactersLength variable stores the length of the remaining text from (b..c) in order
              to support ligatures in SVG Fonts. Example: <text>ffl</text>. When measuring the advance from char 0
              to char 1 the whole 'ffl' text must be passed to the SVG glyph selection code, as the SVG Font may
              define a single glyph for the characters 'ffl' thus leading to a single character long text
              pointing to the ffl ligature, not three individual 'f' / 'f' / 'l' characters anymore.
      
              constructTextRun(..const UChar*, int length, ..) did not correctly calculate the maximum length (b..c).
              The passed in UChar buffer starts at eg. textRenderer->characters() + start(), and following condition
              holds true for 'length': start() + length <= textRenderer->textLength() (which denotes the maximum length
              of the textRenderer->characters() buffer). We have to keep track of the start() offset, so that we
              can calculate the charactersLength for the TextRun correctly: textRenderer->textLength() - start().
      
              There are also other cases like RenderCombinedText and/or the presence of hyphens that were incorrectly
              tracked. Only InlineTextBox had to be fixed, the other callsites in eg. RenderBlockLineLayout already
              computed the maximum length correctly - I assured this by valgrind runs on all SVG Font tests.
      
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paint):
              (WebCore::InlineTextBox::paintSelection):
              (WebCore::InlineTextBox::constructTextRun): Add maximumLength parameter to constructTextRun.
              * rendering/InlineTextBox.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7161461
    • antti@apple.com's avatar
      didFirstVisuallyNonEmptyLayout dispatched too early · 17978ce2
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64412
      
      Reviewed by Darin Adler and Sam Weinig.
      
      Improve the mechanism that dispatches didFirstVisuallyNonEmptyLayout
      
      - Wait until a threshold of characters and pixels has been exceeded before dispatching.
      - Wait until stylesheets are loaded (painting is disabled in this case).
      
      * page/FrameView.cpp:
      (WebCore::FrameView::reset):
      (WebCore::FrameView::performPostLayoutTasks):
      * page/FrameView.h:
      (WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
      (WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::RenderImage):
      (WebCore::RenderImage::imageChanged):
      * rendering/RenderImage.h:
      * rendering/RenderText.cpp:
      (WebCore::RenderText::RenderText):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17978ce2