1. 04 Dec, 2013 40 commits
    • fpizlo@apple.com's avatar
      Fold constant typed arrays · ee327c85
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125205
      
      Source/JavaScriptCore: 
      
      Reviewed by Oliver Hunt and Mark Hahnenberg.
              
      If by some other mechanism we have a typed array access on a compile-time constant
      typed array pointer, then fold:
              
      - Array bounds checks. Specifically, fold the load of length.
              
      - Loading the vector.
              
      This needs to install a watchpoint on the array itself because of the possibility of
      neutering. Neutering is ridiculous. We do this without bloating the size of
      ArrayBuffer or JSArrayBufferView in the common case (i.e. the case where you
      allocated an array that didn't end up becoming a compile-time constant). To install
      the watchpoint, we slowDownAndWasteMemory and then create an incoming reference to
      the ArrayBuffer, where that incoming reference is from a watchpoint object. The
      ArrayBuffer already knows about such incoming references and can fire the
      watchpoints that way.
              
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * dfg/DFGDesiredWatchpoints.cpp:
      (JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):
      (JSC::DFG::DesiredWatchpoints::addLazily):
      * dfg/DFGDesiredWatchpoints.h:
      (JSC::DFG::GenericSetAdaptor::add):
      (JSC::DFG::GenericSetAdaptor::hasBeenInvalidated):
      (JSC::DFG::ArrayBufferViewWatchpointAdaptor::hasBeenInvalidated):
      (JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
      (JSC::DFG::GenericDesiredWatchpoints::areStillValid):
      (JSC::DFG::GenericDesiredWatchpoints::isStillValid):
      (JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState):
      (JSC::DFG::DesiredWatchpoints::isStillValid):
      (JSC::DFG::DesiredWatchpoints::shouldAssumeMixedState):
      (JSC::DFG::DesiredWatchpoints::isValidOrMixed):
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::tryGetFoldableView):
      * dfg/DFGGraph.h:
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::jumpForTypedArrayOutOfBounds):
      (JSC::DFG::SpeculativeJIT::emitTypedArrayBoundsCheck):
      (JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
      (JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
      (JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
      (JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
      (JSC::DFG::SpeculativeJIT::compileConstantIndexedPropertyStorage):
      (JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
      * dfg/DFGSpeculativeJIT.h:
      * dfg/DFGWatchpointCollectionPhase.cpp:
      (JSC::DFG::WatchpointCollectionPhase::handle):
      (JSC::DFG::WatchpointCollectionPhase::addLazily):
      * ftl/FTLLowerDFGToLLVM.cpp:
      (JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
      (JSC::FTL::LowerDFGToLLVM::compileGetByVal):
      (JSC::FTL::LowerDFGToLLVM::compilePutByVal):
      (JSC::FTL::LowerDFGToLLVM::typedArrayLength):
      * runtime/ArrayBuffer.cpp:
      (JSC::ArrayBuffer::transfer):
      * runtime/ArrayBufferNeuteringWatchpoint.cpp: Added.
      (JSC::ArrayBufferNeuteringWatchpoint::ArrayBufferNeuteringWatchpoint):
      (JSC::ArrayBufferNeuteringWatchpoint::~ArrayBufferNeuteringWatchpoint):
      (JSC::ArrayBufferNeuteringWatchpoint::finishCreation):
      (JSC::ArrayBufferNeuteringWatchpoint::destroy):
      (JSC::ArrayBufferNeuteringWatchpoint::create):
      (JSC::ArrayBufferNeuteringWatchpoint::createStructure):
      * runtime/ArrayBufferNeuteringWatchpoint.h: Added.
      (JSC::ArrayBufferNeuteringWatchpoint::set):
      * runtime/VM.cpp:
      (JSC::VM::VM):
      * runtime/VM.h:
      
      LayoutTests: 
      
      Reviewed by Oliver Hunt and Mark Hahnenberg.
      
      * js/regress/fixed-typed-array-storage-expected.txt: Added.
      * js/regress/fixed-typed-array-storage-var-index-expected.txt: Added.
      * js/regress/fixed-typed-array-storage-var-index.html: Added.
      * js/regress/fixed-typed-array-storage.html: Added.
      * js/regress/script-tests/fixed-typed-array-storage-var-index.js: Added.
      (foo):
      * js/regress/script-tests/fixed-typed-array-storage.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee327c85
    • commit-queue@webkit.org's avatar
      Update jhbuild revision. · 16c7d7a2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124966
      
      Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-04
      Reviewed by Gyuyoung Kim.
      
      Used version of Jhbuild failed to create directories and caused
      update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
      
      * jhbuild/jhbuild-wrapper:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16c7d7a2
    • weinig@apple.com's avatar
      [Cocoa] Make WKConnection work with WKObject wrapping · 7206d0db
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125266
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/API/Cocoa/WKConnection.mm:
      (-[WKConnection dealloc]):
      (didReceiveMessage):
      (didClose):
      (setUpClient):
      (-[WKConnection delegate]):
      (-[WKConnection setDelegate:]):
      (-[WKConnection sendMessageWithName:body:]):
      (-[WKConnection remoteObjectRegistry]):
      (-[WKConnection API::]):
      * UIProcess/API/Cocoa/WKConnectionInternal.h:
      (WebKit::wrapper):
      * UIProcess/API/Cocoa/WKProcessGroup.mm:
      (didCreateConnection):
      * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
      (-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundleRef:]):
      (-[WKWebProcessPlugInController connection]):
      (-[WKWebProcessPlugInController _bundleRef]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7206d0db
    • benjamin@webkit.org's avatar
      Remove spaces on a blank line to have ResourceHandleCFNet.cpp identical to iOS · 3d7ac80f
      benjamin@webkit.org authored
      Unreviewed.
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-04
      
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::platformLoadResourceSynchronously):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d7ac80f
    • andersca@apple.com's avatar
      Add a WeakObjCPtr class · 06f7733b
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125267
      
      Reviewed by Geoffrey Garen.
      
      Source/WebKit2:
      
      WeakObjCPtr is a zeroing weak reference class template that will be used for delegates.
      
      * Shared/mac/WeakObjCPtr.h: Added.
      (WebKit::WeakObjCPtr::WeakObjCPtr):
      (WebKit::WeakObjCPtr::~WeakObjCPtr):
      (WebKit::WeakObjCPtr::operator=):
      (WebKit::WeakObjCPtr::get):
      * WebKit2.xcodeproj/project.pbxproj:
      
      Tools:
      
      Add API tests for WeakObjCPtr.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
      (TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06f7733b
    • graouts@apple.com's avatar
      Web Inspector: ColorWheel uses old Color constructor · b0f03099
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125260
      
      Reviewed by Joseph Pecoraro.
      
      Update to new WebInspector.Color constructor signature and use a clear color.
      
      * UserInterface/ColorWheel.js:
      (WebInspector.ColorWheel.prototype.get tintedColor):
      (WebInspector.ColorWheel.prototype.get rawColor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0f03099
    • graouts@apple.com's avatar
      Web Inspector: color picker doesn't work with "blue" · 93373a76
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125262
      
      Reviewed by Joseph Pecoraro.
      
      Under certain circumstances rounding issues would have us compare
      two equal numbers that differ by 0.00000001 and sometime trip this
      if statement and yield a null color. We now add a little fudge to
      the test and also return a clear color rather than null to match what
      we do in the getters for "tintedColor" and "rawColor".
      
      * UserInterface/ColorWheel.js:
      (WebInspector.ColorWheel.prototype._colorAtPointWithBrightness):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93373a76
    • graouts@apple.com's avatar
      Web Inspector: use only two decimals for opacity in rgba/hsla colors · 46c2c3d4
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125261
      
      Reviewed by Joseph Pecoraro.
      
      * UserInterface/ColorPicker.js:
      (WebInspector.ColorPicker.prototype._updateColor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46c2c3d4
    • ryuan.choi@samsung.com's avatar
      Unreviewed EFL build fix after r160135 · 4ccff6cd
      ryuan.choi@samsung.com authored
      * CMakeLists.txt: Added rendering/line to include lists.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ccff6cd
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r160116. · fcbd99f5
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/160116
      https://bugs.webkit.org/show_bug.cgi?id=125264
      
      Change doesn't work as intended. See bug comments for details.
      (Requested by bfulgham on #webkit).
      
      * runtime/InitializeThreading.cpp:
      (JSC::initializeThreading):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcbd99f5
    • antti@apple.com's avatar
      Move pseudo element construction out from Element · 194e98b3
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125257
      
      Reviewed by Anders Carlsson.
      
      This is logically part of the style resolve/render tree construction. This will make future
      refactoring easier.
      
      * dom/Element.cpp:
      * dom/Element.h:
      * style/StyleResolveTree.cpp:
      (WebCore::Style::beforeOrAfterPseudoElement):
      (WebCore::Style::setBeforeOrAfterPseudoElement):
      (WebCore::Style::clearBeforeOrAfterPseudoElement):
      (WebCore::Style::needsPseudeElement):
      (WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
      (WebCore::Style::attachRenderTree):
      (WebCore::Style::updateBeforeOrAfterPseudoElement):
      (WebCore::Style::resolveTree):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      194e98b3
    • andersca@apple.com's avatar
      Make the estimatedProgress property observable using KVO · dd0fe107
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125259
      
      Reviewed by Dan Bernstein.
      
      Source/WebKit2:
      
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      * UIProcess/PageLoadState.cpp:
      (WebKit::PageLoadState::PageLoadState):
      (WebKit::PageLoadState::reset):
      (WebKit::PageLoadState::activeURL):
      (WebKit::PageLoadState::estimatedProgress):
      (WebKit::PageLoadState::setPendingAPIRequestURL):
      (WebKit::PageLoadState::clearPendingAPIRequestURL):
      (WebKit::PageLoadState::didStartProgress):
      (WebKit::PageLoadState::didChangeProgress):
      (WebKit::PageLoadState::didFinishProgress):
      * UIProcess/PageLoadState.h:
      Move m_estimatedProgress to the page load state and call the observers when it changes.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      (WebKit::WebPageProxy::estimatedProgress):
      (WebKit::WebPageProxy::didStartProgress):
      (WebKit::WebPageProxy::didChangeProgress):
      (WebKit::WebPageProxy::didFinishProgress):
      (WebKit::WebPageProxy::resetState):
      Call through to m_pageLoadState.
      
      * UIProcess/WebPageProxy.h:
      
      Tools:
      
      Bind the progress indicator value to the "estimatedProgress" property.
      
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController dealloc]):
      (-[WK2BrowserWindowController awakeFromNib]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd0fe107
    • commit-queue@webkit.org's avatar
      [WK2] Including SecItemShim.h should be guarded by ENABLE(SEC_ITEM_SHIM) · 8ebf19c2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125255
      
      Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
      Reviewed by Anders Carlsson.
      
      * UIProcess/WebProcessProxy.cpp:
      * WebProcess/WebProcess.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ebf19c2
    • zoltan@webkit.org's avatar
      Move TrailingObjects class into its own h/cpp · 02a031b5
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124956
      
      Reviewed by David Hyatt.
      
      Since I moved space-ignoring inline functions into MidpointState in r160074,
      I can nicely separate TrailingObjects class from BreakingContextInlineHeader.h.
      This change improves the readability, and it's part of the RenderBlockLineLayout
      refactoring campaign, which is tracked under bug #121261.
      
      No new tests, no behavior change.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.xcodeproj/project.pbxproj:
      * rendering/RenderBlock.h:
      * rendering/RenderBlockFlow.h:
      * rendering/line/BreakingContextInlineHeaders.h:
      * rendering/line/TrailingObjects.cpp: Added.
      (WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
      * rendering/line/TrailingObjects.h: Added.
      (WebCore::TrailingObjects::TrailingObjects):
      (WebCore::TrailingObjects::setTrailingWhitespace):
      (WebCore::TrailingObjects::clear):
      (WebCore::TrailingObjects::appendBoxIfNeeded):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02a031b5
    • graouts@apple.com's avatar
      Web Inspector: "data detectors" menu on hover for actionable tokens · e3186aeb
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124363
      
      Reviewed by Timothy Hatcher.
      
      Add a new WebInspector.HoverMenu class to display an overlay menu that is presented
      with respect to a target frame that it draws itself around adding a customizable
      action button to its right. The menu uses fade animations as it's presented and
      dismissed and a single delegation method is fired when the button is pressed. Finally,
      just like a popover, it automatically dismisses itself upon scrolling anywhere
      outside of its bounds.
      
      * UserInterface/HoverMenu.css: Added.
      * UserInterface/HoverMenu.js: Added.
      (WebInspector.HoverMenu):
      (WebInspector.HoverMenu.prototype.get element):
      (WebInspector.HoverMenu.prototype.dismiss):
      (WebInspector.HoverMenu.prototype.handleEvent):
      (WebInspector.HoverMenu.prototype._handleClickEvent):
      * UserInterface/Images/HoverMenuButton.png: Added.
      * UserInterface/Images/HoverMenuButton@2x.png: Added.
      * UserInterface/Main.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3186aeb
    • oliver@apple.com's avatar
      Refactor static getter function prototype to include thisValue in addition to the base object · 965cdde6
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124461
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Add thisValue parameter to static getter prototype, and switch
      from JSValue to EncodedJSValue for parameters and return value.
      
      Currently none of the static getters use the thisValue, but
      separating out the refactoring will prevent future changes
      from getting lost in the noise of refactoring.  This means
      that this patch does not result in any change in behaviour.
      
      * API/JSCallbackObject.h:
      * API/JSCallbackObjectFunctions.h:
      (JSC::::asCallbackObject):
      (JSC::::staticFunctionGetter):
      (JSC::::callbackGetter):
      * jit/JITOperations.cpp:
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::argumentsGetter):
      * runtime/JSActivation.h:
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::argumentsGetter):
      (JSC::JSFunction::callerGetter):
      (JSC::JSFunction::lengthGetter):
      (JSC::JSFunction::nameGetter):
      * runtime/JSFunction.h:
      * runtime/JSObject.h:
      (JSC::PropertySlot::getValue):
      * runtime/NumberConstructor.cpp:
      (JSC::numberConstructorNaNValue):
      (JSC::numberConstructorNegInfinity):
      (JSC::numberConstructorPosInfinity):
      (JSC::numberConstructorMaxValue):
      (JSC::numberConstructorMinValue):
      * runtime/PropertySlot.h:
      * runtime/RegExpConstructor.cpp:
      (JSC::asRegExpConstructor):
      (JSC::regExpConstructorDollar1):
      (JSC::regExpConstructorDollar2):
      (JSC::regExpConstructorDollar3):
      (JSC::regExpConstructorDollar4):
      (JSC::regExpConstructorDollar5):
      (JSC::regExpConstructorDollar6):
      (JSC::regExpConstructorDollar7):
      (JSC::regExpConstructorDollar8):
      (JSC::regExpConstructorDollar9):
      (JSC::regExpConstructorInput):
      (JSC::regExpConstructorMultiline):
      (JSC::regExpConstructorLastMatch):
      (JSC::regExpConstructorLastParen):
      (JSC::regExpConstructorLeftContext):
      (JSC::regExpConstructorRightContext):
      * runtime/RegExpObject.cpp:
      (JSC::asRegExpObject):
      (JSC::regExpObjectGlobal):
      (JSC::regExpObjectIgnoreCase):
      (JSC::regExpObjectMultiline):
      (JSC::regExpObjectSource):
      
      Source/WebCore:
      
      Change bindings codegen to produce static getter functions
      with the correct types.  Also update the many custom implementations
      to the new type.
      
      No change in behaviour.
      
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
      (WebCore::cssPropertyGetterCallback):
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::objectToStringFunctionGetter):
      * bindings/js/JSDOMBinding.h:
      * bindings/js/JSDOMMimeTypeArrayCustom.cpp:
      (WebCore::JSDOMMimeTypeArray::nameGetter):
      * bindings/js/JSDOMPluginArrayCustom.cpp:
      (WebCore::JSDOMPluginArray::nameGetter):
      * bindings/js/JSDOMPluginCustom.cpp:
      (WebCore::JSDOMPlugin::nameGetter):
      * bindings/js/JSDOMStringMapCustom.cpp:
      (WebCore::JSDOMStringMap::nameGetter):
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::nonCachingStaticFunctionGetter):
      (WebCore::childFrameGetter):
      (WebCore::indexGetter):
      (WebCore::namedItemGetter):
      * bindings/js/JSHTMLAllCollectionCustom.cpp:
      (WebCore::JSHTMLAllCollection::nameGetter):
      * bindings/js/JSHTMLCollectionCustom.cpp:
      (WebCore::JSHTMLCollection::nameGetter):
      * bindings/js/JSHTMLDocumentCustom.cpp:
      (WebCore::JSHTMLDocument::nameGetter):
      * bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
      (WebCore::JSHTMLFormControlsCollection::nameGetter):
      * bindings/js/JSHTMLFormElementCustom.cpp:
      (WebCore::JSHTMLFormElement::nameGetter):
      * bindings/js/JSHTMLFrameSetElementCustom.cpp:
      (WebCore::JSHTMLFrameSetElement::nameGetter):
      * bindings/js/JSHistoryCustom.cpp:
      (WebCore::nonCachingStaticBackFunctionGetter):
      (WebCore::nonCachingStaticForwardFunctionGetter):
      (WebCore::nonCachingStaticGoFunctionGetter):
      * bindings/js/JSJavaScriptCallFrameCustom.cpp:
      (WebCore::JSJavaScriptCallFrame::scopeType):
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::nonCachingStaticReplaceFunctionGetter):
      (WebCore::nonCachingStaticReloadFunctionGetter):
      (WebCore::nonCachingStaticAssignFunctionGetter):
      * bindings/js/JSNamedNodeMapCustom.cpp:
      (WebCore::JSNamedNodeMap::nameGetter):
      * bindings/js/JSNodeListCustom.cpp:
      (WebCore::JSNodeList::nameGetter):
      * bindings/js/JSPluginElementFunctions.cpp:
      (WebCore::pluginElementPropertyGetter):
      * bindings/js/JSPluginElementFunctions.h:
      * bindings/js/JSRTCStatsResponseCustom.cpp:
      (WebCore::JSRTCStatsResponse::nameGetter):
      * bindings/js/JSStorageCustom.cpp:
      (WebCore::JSStorage::nameGetter):
      * bindings/js/JSStyleSheetListCustom.cpp:
      (WebCore::JSStyleSheetList::nameGetter):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (GenerateParametersCheck):
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::lengthGetter):
      (JSC::RuntimeArray::indexGetter):
      * bridge/runtime_array.h:
      * bridge/runtime_method.cpp:
      (JSC::RuntimeMethod::lengthGetter):
      * bridge/runtime_method.h:
      * bridge/runtime_object.cpp:
      (JSC::Bindings::RuntimeObject::fallbackObjectGetter):
      (JSC::Bindings::RuntimeObject::fieldGetter):
      (JSC::Bindings::RuntimeObject::methodGetter):
      * bridge/runtime_object.h:
      
      Source/WebKit2:
      
      Update the WK2 JSC usage to the new static getter API
      
      * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
      (WebKit::callMethod):
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::callNPJSObject):
      (WebKit::constructWithConstructor):
      (WebKit::JSNPObject::propertyGetter):
      (WebKit::JSNPObject::methodGetter):
      * WebProcess/Plugins/Netscape/JSNPObject.h:
      * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
      (WebKit::NPRuntimeObjectMap::getOrCreateNPObject):
      (WebKit::NPRuntimeObjectMap::finalize):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::frameForContext):
      (WebKit::WebFrame::counterValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      965cdde6
    • graouts@apple.com's avatar
      Web Inspector: edited color should serialize back to original format when possible · 10e771e5
      graouts@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125244
      
      Reviewed by Joseph Pecoraro.
      
      Profoundly reworked WebInspector.Color to be more efficient and more flexible when
      serializing the color to the various supported formats.
      
      * UserInterface/CSSStyleDeclarationTextEditor.js:
      (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
      Use new WebInspector.Color.fromString() factory and check for a null return value
      rather than an exception to identify invalid color tokens.
      
      * UserInterface/Color.js:
      (WebInspector.Color):
      Rewrote WebInspector.Color such that it would have, at all times, a canonical
      representation in terms of either RGBA or HSLA depending on the format used to
      create the color. The new constructor parameters lets the user pass a format
      and the RGBA or HSLA components, allowing to bypass the string-only creation
      system which was sub-optimal for the new color picker. Additionally, the toString()
      method now can provide the most accurate serialization of the color based on the
      provided format with a fallback mechanism to RGB/RGBA in cases where the desired
      format would incur a loss of fidelity. Finally, simplified the API to only feature
      essential features.
      
      (WebInspector.Color.fromString):
      New factory method used to create a color from a string.
      
      * UserInterface/ColorPicker.js:
      (WebInspector.ColorPicker.prototype.set color):
      Keep track of the original color format so that we can use it as the preferred format
      when serializing the updated color in _updateColor().
      
      (WebInspector.ColorPicker.prototype._updateColor):
      Use the original color format as the prefered formation for color serialization. Also,
      use the new WebInspector.Color constructor in lieu of the removed .fromRGBA factory.
      
      (WebInspector.ColorPicker.prototype._updateSliders):
      Use the new WebInspector.Color constructor in lieu of the removed .fromRGBA factory.
      
      * UserInterface/ColorWheel.js:
      (WebInspector.ColorWheel.prototype._colorAtPointWithBrightness):
      Use the new WebInspector.Color constructor in lieu of the removed .fromRGB factory.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10e771e5
    • dbates@webkit.org's avatar
      [iOS] Enable Objective-C ARC when building JSC tools for iOS simulator · 5e423cb9
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125170
      
      Reviewed by Geoffrey Garen.
      
      * API/tests/testapi.mm:
      * Configurations/ToolExecutable.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e423cb9
    • zoltan@webkit.org's avatar
      [CSS Shapes] Support inset for shape-outside · c9ab7882
      zoltan@webkit.org authored
      <https://webkit.org/b/125112>
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      This patch adds inset support for shape-outside. Parsing has previously landed in r159968.
      Specification: http://dev.w3.org/csswg/css-shapes/#supported-basic-shapes
      
      Tests: fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-left.html
             fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-right.html
             fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-left.html
             fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-right.html
             fast/shapes/shape-outside-floats/shape-outside-floats-inset.html
      
      * platform/LengthSize.h:
      (WebCore::LengthSize::floatSize): Add conversion to FloatSize.
      * rendering/shapes/Shape.cpp:
      (WebCore::Shape::createShape): Handle inset case.
      
      LayoutTests:
      
      * fast/shapes/resources/rounded-rectangle.js: Add support to generate partially rounded rectangles.
      (scanConvertRoundedRectangleOutside):
      (genLeftRoundedRectFloatShapeOutsideRefTest):
      (genRightRoundedRectFloatShapeOutsideRefTest):
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-left-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-left.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-right-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-bottom-right.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-left-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-left.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-right-expected.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-top-right.html: Added.
      * fast/shapes/shape-outside-floats/shape-outside-floats-inset.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9ab7882
    • andersca@apple.com's avatar
      Add a loading property to WKBrowsingContextController · 42190963
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125256
      
      Reviewed by Dan Bernstein.
      
      Source/WebKit2:
      
      * UIProcess/API/Cocoa/WKBrowsingContextController.h:
      Add loading property.
      
      * UIProcess/API/Cocoa/WKBrowsingContextConteroller.mm:
      Implement willChangeIsLoading and didChangeIsLoading and call the relevant KVO methods.
      
      (-[WKBrowsingContextController isLoading]):
      Call through to the PageLoadState.
      
      * UIProcess/PageLoadState.cpp:
      (WebKit::PageLoadState::reset):
      Use setState.
      
      (WebKit::PageLoadState::isLoading):
      Call isLoadingState.
      
      (WebKit::PageLoadState::didStartProvisionalLoad):
      Use setState.
      
      (WebKit::PageLoadState::didFailProvisionalLoad):
      Use setState.
      
      (WebKit::PageLoadState::didCommitLoad):
      Use setState.
      
      (WebKit::PageLoadState::didFinishLoad):
      Use setState.
      
      (WebKit::PageLoadState::didFailLoad):
      Use setState.
      
      (WebKit::PageLoadState::isLoadingState):
      Helper function for determining whether a state is a loading state or not.
      
      (WebKit::PageLoadState::setState):
      If setting the state will cause "isLoading" to change, call out to the observers.
      
      * UIProcess/PageLoadState.h:
      
      Tools:
      
      Bind the progress indicator visibility to the "loading" property.
      
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController dealloc]):
      (-[WK2BrowserWindowController awakeFromNib]):
      (-[WK2BrowserWindowController didStartProgress]):
      (-[WK2BrowserWindowController didFinishProgress]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42190963
    • commit-queue@webkit.org's avatar
      Source/WebKit2: [EFL][GTK][WK2] Remove unnecessary reinterpret_casts when setting API clients · 514166e9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125231
      
      Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
      Reviewed by Anders Carlsson.
      
      After r159988, WKClients have to be instantiated with a specific
      version of that client and its Base field has to used when setting it.
      Eg:
      
          WKFullScreenClientV0 wkClient = {
              {
                  0, // version
                  this, // clientInfo
              },
                  willEnterFullScreen,
                  willExitFullScreen
          };
          WKViewSetFullScreenClientGtk(this, &wkClient.base);
      
      So we don't need the reinterpret_casts introduced in r160075.
      
      * UIProcess/API/gtk/WebKitFullscreenClient.cpp:
      (attachFullScreenClientToView): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
      * UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
      (attachRequestManagerClientToContext): Ditto.
      * UIProcess/API/gtk/WebKitTextChecker.cpp:
      (WebKitTextChecker::WebKitTextChecker): Ditto.
      * UIProcess/API/gtk/WebKitWebInspector.cpp:
      (webkitWebInspectorCreate): Ditto.
      * UIProcess/efl/BatteryProvider.cpp:
      (BatteryProvider::BatteryProvider): Ditto.
      * UIProcess/efl/NetworkInfoProvider.cpp:
      (NetworkInfoProvider::NetworkInfoProvider): Ditto.
      * UIProcess/efl/PageUIClientEfl.cpp:
      (WebKit::PageUIClientEfl::PageUIClientEfl): Ditto.
      * UIProcess/efl/RequestManagerClientEfl.cpp:
      (WebKit::RequestManagerClientEfl::RequestManagerClientEfl): Ditto.
      * UIProcess/efl/TextCheckerClientEfl.cpp:
      (TextCheckerClientEfl::TextCheckerClientEfl): Ditto.
      * UIProcess/efl/VibrationClientEfl.cpp:
      (VibrationClientEfl::VibrationClientEfl): Ditto.
      * UIProcess/efl/ViewClientEfl.cpp:
      (WebKit::ViewClientEfl::ViewClientEfl): Ditto.
      
      Tools: [EFL][WK2] Buildfix after r160104
      https://bugs.webkit.org/show_bug.cgi?id=125231
      
      Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
      Reviewed by Anders Carlsson.
      
      * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
      (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
      * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
      (TestWebKitAPI::setViewClient): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      514166e9
    • betravis@adobe.com's avatar
      Web Inspector: [CSS Shapes] Support raster shape visualizations · c9f2fded
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124080
      
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      Create an inspector visualization for a shape created from an image.
      The visualization takes each line of the image, combining where possible.
      
      Test added to inspector-protocol/model/highlight-shape-outside.html
      
      * rendering/shapes/RasterShape.cpp:
      (WebCore::RasterShapeIntervals::buildBoundsPath): Create a path representing the
      RasterShapeIntervals.
      * rendering/shapes/RasterShape.h:
      
      LayoutTests:
      
      Add a test for data sent to the inspector for a raster shape.
      
      * inspector-protocol/model/highlight-shape-outside-expected.txt:
      * inspector-protocol/model/highlight-shape-outside.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9f2fded
    • zoltan@webkit.org's avatar
      [CSS Shapes] Remove explicit numbering from BasicShape::Type and CSSBasicShape::Type enums · e5db8c16
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125163
      
      Reviewed by Rob Buis.
      
      I don't see any reason to have explicit numbering for the Type enum in our [CSS]BasicShape classes.
      I removed numbering, which will decrease for instance the merge conflicts on Type changes.
      
      No new tests, no behavior change.
      
      * css/CSSBasicShapes.h:
      * rendering/style/BasicShapes.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5db8c16
    • commit-queue@webkit.org's avatar
      [GTK][WK2] Fix build after r160104 · 119210aa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125240
      
      Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
      Reviewed by Anders Carlsson.
      
      Using specific version of API client when instantiating them.
      Applied that same change to the following files:
      
      * UIProcess/API/gtk/WebKitContextMenuClient.cpp:
      * UIProcess/API/gtk/WebKitCookieManager.cpp:
      * UIProcess/API/gtk/WebKitDownloadClient.cpp:
      * UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
      * UIProcess/API/gtk/WebKitFindController.cpp:
      * UIProcess/API/gtk/WebKitFormClient.cpp:
      * UIProcess/API/gtk/WebKitGeolocationProvider.cpp:
      * UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
      * UIProcess/API/gtk/WebKitLoaderClient.cpp:
      * UIProcess/API/gtk/WebKitPolicyClient.cpp:
      * UIProcess/API/gtk/WebKitUIClient.cpp:
      * WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
      * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      119210aa
    • commit-queue@webkit.org's avatar
      check-webkit-style detected some ternary statements as initialization lists · 251bfc33
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125246
      
      Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-04
      Reviewed by Dean Jackson.
      
      The regular expression that check-webkit-tests uses to detect initialization
      lists was too broad, resulting in false positives. This patch makes the
      regex more specific
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_member_initialization_list):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (WebKitStyleTest.test_member_initialization_list):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      251bfc33
    • mitz@apple.com's avatar
      Fixed the 32-bit Mac build. · be7eba98
      mitz@apple.com authored
      * Shared/mac/WebCoreArgumentCodersMac.mm:
      (CoreIPC::::encodePlatformData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be7eba98
    • mitz@apple.com's avatar
      [Mac] When NSError user info is missing NSErrorPeerCertificateChainKey,... · b5e28dc9
      mitz@apple.com authored
      [Mac] When NSError user info is missing NSErrorPeerCertificateChainKey, ArgumentCoder should extract it from NSURLErrorFailingURLPeerTrustErrorKey
      https://bugs.webkit.org/show_bug.cgi?id=125251
      
      Reviewed by Anders Carlsson.
      
      * Shared/mac/WebCoreArgumentCodersMac.mm:
      (CoreIPC::::encodePlatformData): If the user info doesn’t include
      NSURLErrorFailingURLPeerTrustErrorKey, copy the peer certificate chain from the peer trust
      under NSURLErrorFailingURLPeerTrustErrorKey. On the decoding side, it will appear under the
      NSURLErrorFailingURLPeerTrustErrorKey, because a trust object can’t be fully serialized.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5e28dc9
    • commit-queue@webkit.org's avatar
      Allow ImageBuffer to use an IOSurface that is larger than necessary · 60dcc5f6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124626
      
      Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-04
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Because creating ImageBuffer's backing store can be so expensive, it
      would be beneficial to have a pool of pre-created backing stores
      available. However, this means that ImageBuffer might have to use a
      backing store that is larger than the exact dimensions that it needs.
      This patch adds a field, m_backingStoreSize, to CG's ImageBufferData
      class, and uses this new field when performing ImageBuffer operations
      to allow for larger-than-necessary backing stores. Content is always
      drawn in the top left corner of the backing store.
      
      No new tests are necessary because there is no behavior change.
      
      * platform/graphics/ImageBuffer.h:
      (WebCore::ImageBuffer::baseTransform): The base transform has to put
      content at the top left corner instead of bottom left
      * platform/graphics/cg/ImageBufferCG.cpp:
      (WebCore::createCroppedImageIfNecessary): Convenience function to figure out
      the dimensions of the backing texture in user space
      (WebCore::ImageBuffer::ImageBuffer): Set up new m_backingStoreSize member
      (WebCore::maybeCropToBounds): Some ImageBuffer API functions require
      outputting an image with logical size. This function performs the cropping
      (WebCore::ImageBuffer::copyImage): Updated for larger-than-necessary
      backing stores
      (WebCore::ImageBuffer::copyNativeImage): Ditto
      (WebCore::ImageBuffer::draw): Ditto
      (WebCore::ImageBuffer::clip): Ditto
      (WebCore::ImageBuffer::putByteArray): Ditto
      (WebCore::ImageBuffer::toDataURL): Ditto
      * platform/graphics/cg/ImageBufferDataCG.cpp:
      (WebCore::ImageBufferData::getData): Ditto
      (WebCore::ImageBufferData::putData): Ditto
      * platform/graphics/cg/ImageBufferDataCG.h: New m_backingStoreSize field
      
      LayoutTests:
      
      Update tests to be more robust with respect to accelerated vs
      non-accelerated ImageBuffers.
      
      * fast/canvas/script-tests/canvas-fillPath-shadow.js: Don't sample a canvas at exactly
      the corner of a drawn shape (because the corner might be antialiased). Instead, sample
      a single pixel inside the shape
      * fast/canvas/script-tests/canvas-scale-shadowBlur.js: Don't sample a canvas at exactly
      the edge of the blur radius. Instead, sample a single pixel past the blur radius.
      * fast/canvas/script-tests/canvas-scale-strokePath-shadow.js:
      (shouldBeAround): Allow this test to be less strict when sampling inside a blurred region
      * platform/mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Matching update w/r/t
      canvas-scale-shadowBlur.js
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60dcc5f6
    • dino@apple.com's avatar
      Source/WebCore: [WebGL] Support for texImage2D of type HALF_FLOAT_OES · 32904690
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=110936
      
      Reviewed by Brent Fulgham.
      
      Add support for the HALF_FLOAT_OES texture format from texImage2D
      and texSubImage2D.
      
      A lot of this patch comes from the original patch on the bug
      by Nayan Kumar, and the Blink commit:
      https://codereview.chromium.org/13842017
      
      Tests: fast/canvas/webgl/oes-texture-half-float-with-canvas.html
             fast/canvas/webgl/oes-texture-half-float-with-image.html
             fast/canvas/webgl/oes-texture-half-float-with-video.html
      
      * html/canvas/OESTextureHalfFloat.idl: New HALF_FLOAT_OES constant value.
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::validateTexFunc): Remove the code that
      would bail if half-float values were used.
      * platform/graphics/GraphicsContext3D.cpp:
      - Return appropriate DataFormats for half floating point types.
      - Copy the float -> half-float code from Blink
      - New pack functions for half floats
      * platform/graphics/GraphicsContext3D.h: New format types.
      * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
      (WebCore::GraphicsContext3D::texSubImage2D): Use GL_HALF_FLOAT_ARB if we're passed
      a HALF_FLOAT_OES.
      
      LayoutTests: [WebGL] Support for texImage2D/texSubImage2D of type HALF_FLOAT_OES
      https://bugs.webkit.org/show_bug.cgi?id=110936
      
      Reviewed by Brent Fulgham.
      
      New tests for half-float textures.
      
      * fast/canvas/webgl/oes-texture-half-float-expected.txt:
      * fast/canvas/webgl/oes-texture-half-float-not-supported-expected.txt: Removed.
      * fast/canvas/webgl/oes-texture-half-float-not-supported.html: Removed.
      * fast/canvas/webgl/oes-texture-half-float-with-canvas-expected.txt: Added.
      * fast/canvas/webgl/oes-texture-half-float-with-canvas.html: Added.
      * fast/canvas/webgl/oes-texture-half-float-with-image-expected.txt: Added.
      * fast/canvas/webgl/oes-texture-half-float-with-image.html: Added.
      * fast/canvas/webgl/oes-texture-half-float-with-video-expected.txt: Added.
      * fast/canvas/webgl/oes-texture-half-float-with-video.html: Added.
      * fast/canvas/webgl/oes-texture-half-float.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32904690
    • bfulgham@apple.com's avatar
      [Win] Correct WebKit.make copy command to land resources in proper directory. · 1a235dc7
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125249
      
      Reviewed by Tim Horton.
      
      * WebKit.vcxproj/WebKit.make: Correct the copy command.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a235dc7
    • mitz@apple.com's avatar
      Replace USE(SECURITY_FRAMEWORK) with finer-grained defines · da402b76
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125242
      
      Reviewed by Sam Weinig.
      
      Source/WebKit2: 
      
      * Configurations/WebKit2.xcconfig: Removed “-framework Security” from the linker flags, now
      that it’s included in the target’s Link Binary with Libraries build phase.
      * NetworkProcess/NetworkProcess.cpp:
      (WebKit::NetworkProcess::initializeConnection): Changed to use ENABLE(SEC_ITEM_SHIM).
      * NetworkProcess/mac/NetworkProcessMac.mm:
      (WebKit::NetworkProcess::platformInitializeNetworkProcess): Ditto.
      * Shared/Authentication/AuthenticationManager.cpp: Changed to use HAVE(SEC_IDENTITY).
      * Shared/Authentication/mac/AuthenticationManager.mac.mm: Ditto.
      * Shared/cf/ArgumentCodersCF.cpp:
      (CoreIPC::typeFromCFTypeRef): Removed use of USE(SECURITY_FRAMEWORK) since all CF platforms
      use it. Added HAVE(SEC_KEYCHAIN) where needed.
      (CoreIPC::encode): Ditto.
      (CoreIPC::decode): Ditto.
      * Shared/cf/ArgumentCodersCF.h: Ditto.
      * Shared/mac/SecItemShim.cpp: Chanegd to use ENABLE(SEC_ITEM_SHIM).
      * Shared/mac/SecItemShim.h: Ditto.
      * Shared/mac/SecItemShim.messages.in: Ditto.
      * UIProcess/Network/NetworkProcessProxy.cpp:
      (WebKit::NetworkProcessProxy::connectionWillOpen): Ditto.
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::connectionWillOpen): Ditto.
      * UIProcess/mac/SecItemShimProxy.cpp: Ditto.
      * UIProcess/mac/SecItemShimProxy.h: Ditto,
      * UIProcess/mac/SecItemShimProxy.messages.in: Ditto.
      * WebKit2.xcodeproj/project.pbxproj: Link Security.framework unconditionally.
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeConnection): Changed to use ENABLE(SEC_ITEM_SHIM).
      * WebProcess/mac/WebProcessMac.mm:
      (WebKit::WebProcess::platformInitializeProcess): Ditto.
      * config.h: Defined ENABLE_SEC_ITEM_SHIM.
      
      Source/WTF: 
      
      * wtf/Platform.h: Removed definitions of WTF_USE_SECURITY_FRAMEWORK, and defined
      HAVE_SEC_IDENTITY and HAVE_SEC_KEYCHAIN.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da402b76
    • commit-queue@webkit.org's avatar
      Use ThreadingOnce class to encapsulate pthread_once functionality. · 7dec9a92
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125228
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-04
      Reviewed by Brent Fulgham.
      
      * runtime/InitializeThreading.cpp:
      (JSC::initializeThreading):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dec9a92
    • mark.lam@apple.com's avatar
      Remove unneeded semicolons. · cc0975a1
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125083.
      
      Rubber-stamped by Filip Pizlo.
      
      * debugger/Debugger.h:
      (JSC::Debugger::detach):
      (JSC::Debugger::sourceParsed):
      (JSC::Debugger::exception):
      (JSC::Debugger::atStatement):
      (JSC::Debugger::callEvent):
      (JSC::Debugger::returnEvent):
      (JSC::Debugger::willExecuteProgram):
      (JSC::Debugger::didExecuteProgram):
      (JSC::Debugger::didReachBreakpoint):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc0975a1
    • dbates@webkit.org's avatar
      Fix the Apple Windows build after <http://trac.webkit.org/changeset/160113> · cde133db
      dbates@webkit.org authored
      (https://bugs.webkit.org/show_bug.cgi?id=125193)
      
      * rendering/RenderThemeWin.cpp:
      (WebCore::RenderThemeWin::paintMenuList): Substitute paintInfo for i.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cde133db
    • dbates@webkit.org's avatar
      Rename RenderTheme::paintMenuListButton() · 7072add8
      dbates@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125193
      
      Reviewed by Simon Fraser.
      
      Towards upstreaming the iOS concept of render theme decorations we should rename
      RenderTheme::paintMenuListButton() to RenderTheme::paintMenuListButtonDecorations()
      to better describe its purpose.
      
      Also, fix code style issues.
      
      * platform/blackberry/RenderThemeBlackBerry.cpp:
      (WebCore::RenderThemeBlackBerry::paintMenuListButtonDecorations):
      * platform/blackberry/RenderThemeBlackBerry.h:
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintMenuListButtonDecorations):
      * platform/efl/RenderThemeEfl.h:
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::RenderThemeGtk::paintMenuListButtonDecorations):
      * platform/gtk/RenderThemeGtk.h:
      * platform/nix/RenderThemeNix.h:
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::paintDecorations): Rename argument o, r to renderer and rect, respectively.
      * rendering/RenderTheme.h:
      (WebCore::RenderTheme::paintMenuListButtonDecorations):
      * rendering/RenderThemeMac.h:
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::paintMenuListButtonDecorations): Rename argument o, r to renderer and rect,
      respectively; also remove extraneous white space and substitute 1 for 1.0f.
      * rendering/RenderThemeSafari.cpp:
      (WebCore::RenderThemeSafari::paintMenuListButtonDecorations): Ditto.
      * rendering/RenderThemeSafari.h:
      * rendering/RenderThemeWin.cpp:
      (WebCore::RenderThemeWin::paintMenuList): Rename argument o, i, r to renderer, paintInfo, and rect,
      respectively.
      (WebCore::RenderThemeWin::paintMenuListButtonDecorations): Ditto.
      * rendering/RenderThemeWin.h:
      * rendering/RenderThemeWinCE.cpp:
      (WebCore::RenderThemeWinCE::paintMenuList): Ditto.
      (WebCore::RenderThemeWinCE::paintMenuListButtonDecorations): Ditto.
      * rendering/RenderThemeWinCE.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7072add8
    • commit-queue@webkit.org's avatar
      [Win][64-bit] Link error. · e7c2fff1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125234
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-12-04
      Reviewed by Brent Fulgham.
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Changed 64-bit version of symbol.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7c2fff1
    • aestes@apple.com's avatar
      [iOS] Build projects with $(ARCHS_STANDARD_32_64_BIT) · 2412219f
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125236
      
      Reviewed by Sam Weinig.
      
      $(ARCHS_STANDARD_32_64_BIT) is what we want for both device and simulator builds.
      
      Source/JavaScriptCore:
      
      * Configurations/DebugRelease.xcconfig:
      
      Source/WebCore:
      
      * Configurations/DebugRelease.xcconfig:
      
      Source/WebKit/mac:
      
      * Configurations/DebugRelease.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2412219f
    • mihnea@adobe.com's avatar
      [CSSRegions] Test dynamic change of position for out-of-flow transformed element · 1313145c
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124978
      
      Reviewed by Alexandru Chiculita.
      
      Test that a 3D transformed absolutely positioned element inside a named flow
      whose position is dynamic changed is displayed in the right position in the associated region.
      
      * compositing/regions/abs-transformed-dynamic-update-expected.html: Added.
      * compositing/regions/abs-transformed-dynamic-update.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1313145c
    • fpizlo@apple.com's avatar
      Infer constant closure variables · 88fedde1
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124630
      
      Source/JavaScriptCore: 
      
      Reviewed by Geoffrey Garen.
              
      Captured variables that are assigned once (not counting op_enter's Undefined
      initialization) and that are contained within a function that has thus far only been
      entered once are now constant folded. It's pretty awesome.
              
      This involves a watchpoint on the assignment to variables and a watchpoint on entry
      into the function. The former is reused from global variable constant inference and the
      latter is reused from one-time closure inference.
      
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dumpBytecode):
      (JSC::CodeBlock::CodeBlock):
      * bytecode/Instruction.h:
      (JSC::Instruction::Instruction):
      * bytecode/Opcode.h:
      (JSC::padOpcodeName):
      * bytecode/UnlinkedCodeBlock.h:
      (JSC::UnlinkedInstruction::UnlinkedInstruction):
      * bytecode/VariableWatchpointSet.h:
      (JSC::VariableWatchpointSet::invalidate):
      * bytecode/Watchpoint.h:
      (JSC::WatchpointSet::invalidate):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::addVar):
      (JSC::BytecodeGenerator::BytecodeGenerator):
      (JSC::BytecodeGenerator::emitInitLazyRegister):
      (JSC::BytecodeGenerator::emitMove):
      (JSC::BytecodeGenerator::emitNewFunctionInternal):
      (JSC::BytecodeGenerator::createArgumentsIfNecessary):
      * bytecompiler/BytecodeGenerator.h:
      (JSC::BytecodeGenerator::addVar):
      (JSC::BytecodeGenerator::watchableVariable):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::getLocal):
      (JSC::DFG::ByteCodeParser::inferredConstant):
      (JSC::DFG::ByteCodeParser::parseBlock):
      (JSC::DFG::ByteCodeParser::parse):
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::tryGetActivation):
      (JSC::DFG::Graph::tryGetRegisters):
      * dfg/DFGGraph.h:
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      (JSC::JIT::privateCompileSlowCases):
      * jit/JIT.h:
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_mov):
      (JSC::JIT::emit_op_captured_mov):
      (JSC::JIT::emit_op_new_captured_func):
      (JSC::JIT::emitSlow_op_captured_mov):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emit_op_mov):
      (JSC::JIT::emit_op_captured_mov):
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * runtime/CommonSlowPaths.cpp:
      (JSC::SLOW_PATH_DECL):
      * runtime/CommonSlowPaths.h:
      * runtime/ConstantMode.h: Added.
      * runtime/JSGlobalObject.h:
      * runtime/JSScope.cpp:
      (JSC::abstractAccess):
      * runtime/SymbolTable.cpp:
      (JSC::SymbolTableEntry::prepareToWatch):
      
      LayoutTests: 
      
      Reviewed by Geoffrey Garen.
              
      This adds both correctness and performance tests for constant closure variable
      inference.
      
      * js/regress/infer-closure-const-then-mov-expected.txt: Added.
      * js/regress/infer-closure-const-then-mov-no-inline-expected.txt: Added.
      * js/regress/infer-closure-const-then-mov-no-inline.html: Added.
      * js/regress/infer-closure-const-then-mov.html: Added.
      * js/regress/infer-closure-const-then-put-to-scope-expected.txt: Added.
      * js/regress/infer-closure-const-then-put-to-scope-no-inline-expected.txt: Added.
      * js/regress/infer-closure-const-then-put-to-scope-no-inline.html: Added.
      * js/regress/infer-closure-const-then-put-to-scope.html: Added.
      * js/regress/infer-closure-const-then-reenter-expected.txt: Added.
      * js/regress/infer-closure-const-then-reenter-no-inline-expected.txt: Added.
      * js/regress/infer-closure-const-then-reenter-no-inline.html: Added.
      * js/regress/infer-closure-const-then-reenter.html: Added.
      * js/regress/script-tests/infer-closure-const-then-mov-no-inline.js: Added.
      * js/regress/script-tests/infer-closure-const-then-mov.js: Added.
      * js/regress/script-tests/infer-closure-const-then-put-to-scope-no-inline.js: Added.
      (thingy.):
      (thingy):
      * js/regress/script-tests/infer-closure-const-then-put-to-scope.js: Added.
      (thingy.):
      (thingy):
      * js/regress/script-tests/infer-closure-const-then-reenter-no-inline.js: Added.
      (.return.foo):
      (foo):
      * js/regress/script-tests/infer-closure-const-then-reenter.js: Added.
      (.return.foo):
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88fedde1
    • mhahnenberg@apple.com's avatar
      run-jsc-stress-tests can only run locally · 07923100
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124551
      
      Reviewed by Filip Pizlo.
      
      * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
      killed before the lock directory was removed, future executions wouldn't make any progress. Also
      added a couple more signals to handle gracefully at shutdown.
      * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
      * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
      The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
      it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
      toward the end of the script to make it easier to tell which of the various modes do what.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07923100