- 21 Jun, 2009 3 commits
-
-
darin@apple.com authored
* platform/gtk/Skipped: Skip one more test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
* platform/gtk/Skipped: Skip some new tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Sam Weinig. <rdar://problem/6964221> Need more processing of pluginspage. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 20 Jun, 2009 19 commits
-
-
alice.liu@apple.com authored
2009-06-19 Alice Liu <alice.liu@apple.com> Fix https://bugs.webkit.org/show_bug.cgi?id=26568 Repro crash animating GIF if previously used in a closed window's back/forward list Also filed as <rdar://problem/6978362> Reviewed by Maciej Stachowiak. Can't test this bug with an automated layout test since it requires b/f caching * manual-tests/animated-gif-bfcache-crash.html: Added. * manual-tests/resources/containsAnimatedGif.html: Added. Adding checks for hostWindow() since there is no guarantee that the Page is alive * platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::wheelEvent): LayoutTests: 2009-06-19 Alice Liu <alice.liu@apple.com> Fix https://bugs.webkit.org/show_bug.cgi?id=26568 Repro crash animating GIF if previously used in a closed window's back/forward list Also filed as <rdar://problem/6978362> Reviewed by Maciej Stachowiak. Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html * http/tests/misc/resources/animated-gif-with-offsets.gif: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrowe@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
2009-06-20 Sam Weinig <sam@webkit.org> Reviewed by Adam Barth. Fix for https://bugs.webkit.org/show_bug.cgi?id=26554 Shadowing of top and parent * page/DOMWindow.idl: LayoutTests: 2009-06-20 Sam Weinig <sam@webkit.org> Reviewed by Adam Barth. Test for https://bugs.webkit.org/show_bug.cgi?id=26554 Test writing to parent and top. * http/tests/security/cross-frame-access-put-expected.txt: * http/tests/security/cross-frame-access-put.html: * http/tests/security/resources/cross-frame-iframe-for-put-test.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
2009-06-20 Darin Adler <darin@apple.com> Reviewed by Sam Weinig. <rdar://problem/6964221> Need more processing of pluginspage. * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily. WebKit/win: 2009-06-20 Darin Adler <darin@apple.com> Reviewed by Sam Weinig. <rdar://problem/6964221> Need more processing of pluginspage. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jmalonzo@webkit.org authored
[Gtk] Implement DRT XSS auditor support https://bugs.webkit.org/show_bug.cgi?id=26571 * webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy): * webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify): * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jmalonzo@webkit.org authored
Reviewed by Gustavo Noronha and Xan Lopez. webkit_web_back_forward_list_add_item() should add a ref for the history item https://bugs.webkit.org/show_bug.cgi?id=26517 Add a ref to the WebHistoryItem when it's added to the back forward list through webkit_web_back_forward_list_add_item. This keeps the history item alive and prevents pywebkitgtk from crashing * tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item): * webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_add_item): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=15106mrowe@apple.com authored
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none Reviewed by Dan Bernstein. We allow selections to begin within an element that has -webkit-user-select: none set, unless the element is draggable as dragging should take priority over starting a selection. Test: editing/selection/user-drag-element-and-user-select-none.html * dom/Node.cpp: (WebCore::Node::canStartSelection): Test for <https://bugs.webkit.org/show_bug.cgi?id=15106>. Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none * editing/selection/user-drag-element-and-user-select-none-expected.txt: Added. * editing/selection/user-drag-element-and-user-select-none.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
2009-06-20 Darin Adler <darin@apple.com> Reviewed by Dan Bernstein. Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com https://bugs.webkit.org/show_bug.cgi?id=26528 rdar://problem/6985329 * editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): When entering a text control, start at the top of the shadow tree (by calling shadowTreeRootNode). Also remove assumption that innerTextElement will never be 0 since RenderTextControl doesn't really guarantee this. LayoutTests: 2009-06-20 Darin Adler <darin@apple.com> Reviewed by Dan Bernstein. Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com https://bugs.webkit.org/show_bug.cgi?id=26528 rdar://problem/6985329 * editing/selection/find-in-text-control-expected.txt: Updated to expect finding text in <input type="text"> and <input type="search">, but not in <input type="password">. * editing/selection/find-in-text-control.html: Added tests for <input> elements as well as <textarea> elements. Also tweaked result output format to accomodate multiple text nodes. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer@apple.com authored
* wtf/SegmentedVector.h: Updated namespace comment to reflect new namespace after r44897. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer@apple.com authored
Bug 24986: ARM JIT port <https://bugs.webkit.org/show_bug.cgi?id=24986> Reviewed by Oliver Hunt. An Iterator added for SegmentedVector. Currently only the pre ++ operator is supported. * wtf/SegmentedVector.h: (WTF::SegmentedVectorIterator::~SegmentedVectorIterator): (WTF::SegmentedVectorIterator::operator*): (WTF::SegmentedVectorIterator::operator->): (WTF::SegmentedVectorIterator::operator++): (WTF::SegmentedVectorIterator::operator==): (WTF::SegmentedVectorIterator::operator!=): (WTF::SegmentedVectorIterator::operator=): (WTF::SegmentedVectorIterator::SegmentedVectorIterator): (WTF::SegmentedVector::alloc): (WTF::SegmentedVector::begin): (WTF::SegmentedVector::end): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Reviewed by Jan Alonzo. Initial test case for loading statuses. * tests/testloading.c: Added. (load_finished_cb): (status_changed_cb): (test_loading_status): (main): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer@apple.com authored
Bug 24986: ARM JIT port <https://bugs.webkit.org/show_bug.cgi?id=24986> Reviewed by Oliver Hunt. Move SegmentedVector to /wtf subdirectory and change "namespace JSC" to "namespace WTF" Additional build file updates by David Kilzer. * GNUmakefile.am: Updated path to SegmentedVector.h. * JavaScriptCore.order: Updated SegmentedVector namespace from JSC to WTF in mangled C++ method name. * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to bytecompiler\SegmentedVector.h. * JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to wtf\SegmentedVector.h. * JavaScriptCore.xcodeproj/project.pbxproj: Moved SegmentedVector.h definition from bytecompiler subdirectory to wtf subdirectory. * bytecompiler/BytecodeGenerator.h: Updated #include path to SegmentedVector.h and prepended WTF:: namespace to its use. * parser/Lexer.h: Ditto. * wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h. (WTF::SegmentedVector::SegmentedVector): (WTF::SegmentedVector::~SegmentedVector): (WTF::SegmentedVector::size): (WTF::SegmentedVector::at): (WTF::SegmentedVector::operator[]): (WTF::SegmentedVector::last): (WTF::SegmentedVector::append): (WTF::SegmentedVector::removeLast): (WTF::SegmentedVector::grow): (WTF::SegmentedVector::clear): (WTF::SegmentedVector::deleteAllSegments): (WTF::SegmentedVector::segmentExistsFor): (WTF::SegmentedVector::segmentFor): (WTF::SegmentedVector::subscriptFor): (WTF::SegmentedVector::ensureSegmentsFor): (WTF::SegmentedVector::ensureSegment): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Rubber-stamped by Jan Alonzo. Fix the ordering in which the new load status goes into the enum to avoid ABI breakage. * webkit/webkitwebframe.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jmalonzo@webkit.org authored
Reviewed by NOBODY. Speculative Qt build fix - add HTMLDataGridColElement to the build script. * WebCore.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=26561 Remove a memcpy by retrieving the already existing copy of a string instead of making a new one. * bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::source): * bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::source): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Skip new accessibility test, we still lack and accessibilityController. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
We don't seem to support these new HTTP tests either, skip them. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Skip test that requires eventSender. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken@apple.com authored
Reviewed by Steve Falkenburg. https://bugs.webkit.org/show_bug.cgi?id=26494 Bug 26494: RenderTheme::themeForPage reads from Settings before it has been initialized by WebKit Get the shouldPaintNativeControls preference and update the settings before initializing the page, as the page depends on it after the themeForPage change. * WebView.cpp: (WebView::initWithFrame): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 19 Jun, 2009 18 commits
-
-
barraclough@apple.com authored
Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h). * jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister): * jit/JIT.h: * jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp): * jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall): * jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::checkStructure): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_get_by_val): * jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): * jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
* Scripts/do-webcore-rename: More renaming ideas. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by NOBODY (Windows build fix). * jit/JIT.h: * jit/JITInlineMethods.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by Gavin Barraclough. Reorganize ARM architecture specific macros. Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7). Bug 24986: ARM JIT port <https://bugs.webkit.org/show_bug.cgi?id=24986> * assembler/ARMv7Assembler.h: * assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32): * assembler/MacroAssembler.h: * assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr): * jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush): * jit/JIT.h: * jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline): * jit/JITStubs.cpp: * jit/JITStubs.h: * wtf/Platform.h: * yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by Oliver Hunt. Fix armv7 JIT build issues. Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types), and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros. * Replace offsetofs with FIELD_OFFSETs (safe on C++ objects). * Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor. * jit/JIT.cpp: * jit/JIT.h: * jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch): * jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
Reviewed by Steve Falkenburg. https://bugs.webkit.org/show_bug.cgi?id=26488 No Support for Single Finger or Two Finger Panning in Windows 7 The code in WebCore allows us to interpret a Pan gesture as a mousewheel event, and we are able to reuse the scrolling code. Another constructor was created in WheelEventWin which takes data better suited to the pan guesture than what was currently there. Unable to add tests to simulate touch behavior/gestures. * platform/PlatformWheelEvent.h: * platform/win/WheelEventWin.cpp: 2009-06-19 Brian Weinstein <bweinstein@apple.com> Reviewed by Steve Falkenburg. https://bugs.webkit.org/show_bug.cgi?id=26488 No Support for Single Finger or Two Finger Panning in Windows 7 The code in WebCore allows us to interpret a Pan gesture as a mousewheel event, and we are able to reuse the scrolling code. Another constructor was created in WheelEventWin which takes data better suited to the pan guesture than what was currently there. Unable to add tests to simulate touch behavior/gestures. * platform/PlatformWheelEvent.h: * platform/win/WheelEventWin.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@webkit.org authored
Reviewed by Maciej Stachowiak. This fixs the bug 26361. The original test case did not invoke the event that triggered the actual test. This patch adds code to invoke this event, and also converts it from a pixel test to a dumpAsText test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cmarrin@apple.com authored
* platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Oliver Hunt. <rdar://problem/6988385> REGRESSION: In full page video player, movie's video track becomes detached from its controller. When in the media document, the MediaPlayer should not report that it is capable of hardware acceleration, because it renders via a QTMovieView which is already accelerated. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=26544cmarrin@apple.com authored
If I am doing a Matrix hardware animation and any matrix is singular, I revert to software. This is not really testable, since we can't see what the hardware animation is doing. * platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Maciej Stachowiak. An additional fix for Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected <https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385> Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame accessors, so the type of object you get to wrap a function is the same, regardless of whether the access to the function is cross-frame. This is faster and more idiomatic than what we had before. It also would have avoided Bug 26532 because it would have prevented a conflicting PrototypeFunction from being allocated to wrap postMessage, where a NativeFunctionWrapper had been allocated previously. * bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter): * bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): * bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter): * bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by John Sullivan <rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent Fix a crash that could occur in complex content due to timing issues when doing a partial layer tree rebuild which is required when painting; setCompositingParent() could be called with a parent which has not been made compositing yet. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Build fix. Adding missing HTMLDataGrid* files to the build. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pkasting@chromium.org authored
Reviewed by Eric Seidel. https://bugs.webkit.org/show_bug.cgi?id=26460 part three Make BMPImageReader a standalone class that is used by ICOImageDecoder and BMPImageDecoder to decode individual BMPs within a file. These decoders now inherit directly from ImageDecoder. This also makes these decoders decode on-demand in isSizeAvailable() and frameBufferAtIndex(), like the other decoders, instead of when setData() is called, like before. This should provide a speedup on pages containing BMPs that aren't immediately onscreen. * platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::processFileHeader): * platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32): * platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): (WebCore::BMPImageReader::setFailed): * platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::setBuffer): (WebCore::BMPImageReader::setData): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::setRGBA): * platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): (WebCore::ICOImageDecoder::processImageType): * platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
treat@webkit.org authored
Blind attempt at build fix. * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-