1. 12 May, 2011 40 commits
    • paroga@webkit.org's avatar
      2011-05-12 Patrick Gansterer <paroga@webkit.org> · ece87828
      paroga@webkit.org authored
              Reviewed by Darin Adler.
      
              Rename SimpleFontData::scaledFontData to createScaledFontData
              https://bugs.webkit.org/show_bug.cgi?id=60723
      
              * platform/graphics/SimpleFontData.h:
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
              * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
              * platform/graphics/mac/SimpleFontDataMac.mm:
              * platform/graphics/pango/SimpleFontDataPango.cpp:
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              * platform/graphics/win/SimpleFontDataWin.cpp:
              * platform/graphics/wince/SimpleFontDataWinCE.cpp:
              * platform/graphics/wx/SimpleFontDataWx.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ece87828
    • leviw@chromium.org's avatar
      2011-05-12 Levi Weintraub <leviw@chromium.org> · b80b4638
      leviw@chromium.org authored
              Reviewed by Simon Fraser.
      
              Switch paintOutline to use IntRect
              https://bugs.webkit.org/show_bug.cgi?id=60718
      
              Switching paintOutline to use an IntRect instead of 4 ints.
      
              No new tests as this is just refactoring.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintObject):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::paintOutline):
              * rendering/RenderObject.h:
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintObject):
              * rendering/svg/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::paint):
              * rendering/svg/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::paint):
              * rendering/svg/RenderSVGPath.cpp:
              (WebCore::RenderSVGPath::paint):
              * rendering/svg/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::paint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b80b4638
    • tkent@chromium.org's avatar
      2011-05-12 Kent Tamura <tkent@chromium.org> · b22b6131
      tkent@chromium.org authored
              [Chromium] Update test expectations for r86224.
      
              * platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
              * platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
              * platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
              * platform/chromium-mac/fast/forms/validation-message-appearance-expected.png: Removed.
              * platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.png: Added.
              * platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b22b6131
    • andersca@apple.com's avatar
      Address review comment by Dan Bernstein. · c4c99be1
      andersca@apple.com authored
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4c99be1
    • andersca@apple.com's avatar
      2011-05-12 Anders Carlsson <andersca@apple.com> · 36727c6f
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              Crash when a plug-in tries to load a resource from the application cache
              https://bugs.webkit.org/show_bug.cgi?id=60735
              <rdar://problem/8216142>
      
              When loading application cache resources from disk, we would never restore the
              HTTP status code, which means that resources would always have a 0 status code.
              This led to the plug-in stream loader canceling the load, something which the application
              cache loading machinery couldn't deal and thus would crash.
      
              Fix the reading of the HTTP status code, and make the loader more robust against
              application cache loads being canceled.
      
              Unfortunately, I couldn't come up with a test for this because I couldn't find a reliable way
              to force the application cache to be read from disk, so all resources would have valid values.
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::loadCache):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36727c6f
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/60710> JavaScriptGlue should compile with -Wmissing-prototypes · b8de5e55
      ddkilzer@apple.com authored
      Reviewed by Geoffrey Garen.
      
      Enabling -Wmissing-prototypes fixes an Xcode 4 project warning.
      
      This also fixes the following compiler warning:
      
          JavaScriptGlue/JSUtils.cpp:407:15: error: no previous prototype for function 'getThreadGlobalData' [-Werror,-Wmissing-prototypes,3]
           JSGlobalData* getThreadGlobalData()
                         ^
      
      * Configurations/Base.xcconfig: Set
      GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES.
      * JSUtils.cpp:
      (getThreadGlobalData): Made static.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8de5e55
    • eae@chromium.org's avatar
      2011-05-12 Emil A Eklund <eae@chromium.org> · be9be86e
      eae@chromium.org authored
              Reviewed by Darin Adler.
      
              Convert RenderBox::setLocation, setLogicalLocation and setLogicalSize to IntPoint/IntSize
              https://bugs.webkit.org/show_bug.cgi?id=60585
      
              Refactoring, covered by existing tests.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::positionLineBox):
              * rendering/RenderBox.h:
              (WebCore::RenderBox::setLogicalLocation):
              (WebCore::RenderBox::setLogicalSize):
              (WebCore::RenderBox::setLocation):
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::positionFrames):
              (WebCore::RenderFrameSet::positionFramesWithFlattening):
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::layout):
              * rendering/RenderScrollbarPart.cpp:
              (WebCore::RenderScrollbarPart::paintIntoRect):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::adjustLogicalHeightForCaption):
              (WebCore::RenderTable::layout):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::layoutRows):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::layout):
              * rendering/svg/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::layoutRootBox):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be9be86e
    • enne@google.com's avatar
      2011-05-12 Adrienne Walker <enne@google.com> · 56d3618d
      enne@google.com authored
              Reviewed by James Robinson.
      
              [chromium] show-composited-layer-tree crashes on null ptr deref
              https://bugs.webkit.org/show_bug.cgi?id=60734
      
              The tiler is created lazily, so it won't not be around for the first
              dumpLayerProperties call.
      
              * platform/graphics/chromium/ContentLayerChromium.cpp:
              (WebCore::ContentLayerChromium::dumpLayerProperties):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56d3618d
    • lforschler@apple.com's avatar
      Versioning. · 4e64f922
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e64f922
    • paroga@webkit.org's avatar
      2011-05-12 Patrick Gansterer <paroga@webkit.org> · 03df15be
      paroga@webkit.org authored
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in PluginHalter
              https://bugs.webkit.org/show_bug.cgi?id=60681
      
              Pass PluginHalterClient as (Pass)OwnPtr to Page and PluginHalter.
      
              * WebCore.exp.in:
              * page/Page.cpp:
              (WebCore::Page::Page):
              (WebCore::Page::PageClients::PageClients):
              * page/Page.h:
              * page/PluginHalter.cpp:
              (WebCore::PluginHalter::PluginHalter):
              * page/PluginHalter.h:
      2011-05-12  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in PluginHalter
              https://bugs.webkit.org/show_bug.cgi?id=60681
      
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
      2011-05-12  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Adam Barth.
      
              Enable OwnPtr strict mode in PluginHalter
              https://bugs.webkit.org/show_bug.cgi?id=60681
      
              * WebView.cpp:
              (WebView::initWithFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03df15be
    • dbates@webkit.org's avatar
      2011-05-12 Daniel Bates <dbates@rim.com> · ee1c625e
      dbates@webkit.org authored
              Reviewed by Adele Peterson.
      
              Frame's noResize attribute can not be set by JavaScript
              https://bugs.webkit.org/show_bug.cgi?id=14845
      
              Tests that frame resizing is allowed and disallowed depending on the value of the noResize property.
      
              Also, tests to ensure that frame resizing is allowed and disallowed when programmatically
              removing and adding the noresize attribute, respectively.
      
              * fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Added.
              * fast/frames/frame-inherit-noresize-from-frameset.html: Added. See <https://bugs.webkit.org/show_bug.cgi?id=57604>.
              * fast/frames/frame-programmatic-noresize-expected.txt: Added.
              * fast/frames/frame-programmatic-noresize.html: Added.
              * fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Added.
              * fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html: Added.
              * fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Added.
              * fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html: Added.
              * fast/frames/resources/frame-programmatic-resize.js: Added.
              (setTestFrameById):
              (deltaWidth):
              (shouldAllowFrameResize):
              (shouldDisallowFrameResize):
              (shouldDisallowFrameResizeAfterProcessingFrame):
              (shouldAllowFrameResizeAfterProcessingFrame):
              (checkTestFrameWidthEquals):
              (resizeTestFrameBy):
              (log):
              (description):
      2011-05-12  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Adele Peterson.
      
              Frame's noResize attribute can not be set by JavaScript
              https://bugs.webkit.org/show_bug.cgi?id=14845
      
              Tests: fast/frames/frame-inherit-noresize-from-frameset.html
                     fast/frames/frame-programmatic-noresize.html
                     fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
                     fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html
      
              Implements support to programmatically allow and disallow frame resizing.
      
              Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
              m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
              point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
              frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
              attribute.
      
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::HTMLFrameElement):
              (WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this
              code path isn't performance critical.
              (WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from
              parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo().
              (WebCore::HTMLFrameElement::parseMappedAttribute):
              * html/HTMLFrameElement.h:
              * rendering/RenderFrame.cpp:
              (WebCore::RenderFrame::updateFromElement): Added.
              * rendering/RenderFrame.h:
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
              * rendering/RenderFrameSet.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee1c625e
    • eae@chromium.org's avatar
      2011-05-12 Emil A Eklund <eae@chromium.org> · 3b4922f9
      eae@chromium.org authored
              Reviewed by Darin Adler.
      
              Replace IntPoint with const IntPoint& in RenderFlexibleBox::placeChild
              https://bugs.webkit.org/show_bug.cgi?id=60640
      
              Pass by const reference instead of by value for consistency reasons.
      
              Refactoring, covered by existing tests.
      
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::placeChild):
              * rendering/RenderFlexibleBox.h:
              Use const IntPoint& instead of just IntPoint to avoid extra constructor overhead
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b4922f9
    • mitz@apple.com's avatar
      Corrected Radar links · 1d6bbd96
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d6bbd96
    • mitz@apple.com's avatar
      Source/WebCore: <rdar://problem/8970549> WebFindOptionsAtWordStarts still... · 94157cab
      mitz@apple.com authored
      Source/WebCore: <rdar://problem/8970549> WebFindOptionsAtWordStarts still fails with some Japanese words
      https://bugs.webkit.org/show_bug.cgi?id=60730
      
      Reviewed by Sam Weinig.
      
      * editing/TextIterator.cpp:
      (WebCore::SearchBuffer::isWordStartMatch): Consider all positions before a CJK ideograph as
      word starts.
      
      LayoutTests: Updated results for <rdar://problem/8970549> WebFindOptionsAtWordStarts still fails with some Japanese words
      https://bugs.webkit.org/show_bug.cgi?id=60730
      
      Reviewed by Sam Weinig.
      
      * editing/text-iterator/findString-expected.txt:
      * editing/text-iterator/findString.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94157cab
    • lforschler@apple.com's avatar
      2011-05-12 Lucas Forschler <lforschler@apple.com> · ba37113a
      lforschler@apple.com authored
              Reviewed by Stephanie Lewis.
      
              Add SnowLeopard Debug builder and Test bot.
              apple-xserve-8 = SL Debug Tester.
              apple-xserve-9 = SL Debug Builder.
      
              * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba37113a
    • leviw@chromium.org's avatar
      2011-05-12 Levi Weintraub <leviw@chromium.org> · e2b364f3
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Switch paintBoxDecorationWithSize to IntRect
              https://bugs.webkit.org/show_bug.cgi?id=60679
      
              Switching paintBoxDecorationWithSize to take an IntRect instead of 4 ints.
      
              No new tests as this is simple refactoring.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintBoxDecorations): Cleaning up amazingly confusing logic.
              (WebCore::RenderBox::paintBoxDecorationsWithSize):
              * rendering/RenderBox.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::paintBoxDecorations):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2b364f3
    • leviw@chromium.org's avatar
      2011-05-12 Levi Weintraub <leviw@chromium.org> · eea900e9
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Switch paintBoxShadow to use IntRect
              https://bugs.webkit.org/show_bug.cgi?id=60713
      
              Switching paintBoxShadow from taking four ints to taking an IntRect.
      
              No new tests since this is refactoring.
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paintBoxShadow):
              (WebCore::InlineFlowBox::paintBoxDecorations):
              * rendering/InlineFlowBox.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintBoxDecorationsWithSize):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintBoxShadow):
              * rendering/RenderBoxModelObject.h:
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::paintBoxDecorations):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintBoxDecorations):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paintBoxDecorations):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eea900e9
    • paroga@webkit.org's avatar
      2011-05-12 Maciej Stachowiak <mjs@apple.com> · e729ed16
      paroga@webkit.org authored
              Reviewed by Darin Adler.
      
              XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
              https://bugs.webkit.org/show_bug.cgi?id=59394
      
              This portion of the change introduces a PassTraits template, which
              is used to enable takeFirst() to work for a Deque holding OwnPtrs,
              and optimize it for a Deque holding RefPtrs. In the future it can
              be deployed elsewhere to make our data structures work better with
              our smart pointers.
      
              * GNUmakefile.list.am:
              * JavaScriptCore.gypi:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * wtf/CMakeLists.txt:
              * wtf/Deque.h:
              (WTF::::takeFirst):
              * wtf/PassTraits.h: Added.
              (WTF::PassTraits::transfer):
      2011-05-12  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Darin Adler.
      
              XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
              https://bugs.webkit.org/show_bug.cgi?id=59394
      
              Properly fix this (formerly rolled out for breaking the build). I think the original
              failure had nothing to do with Deque<OwnPtr>, which in fact appears to work fine.
      
              * dom/XMLDocumentParserLibxml2.cpp:
              (WebCore::PendingCallbacks::~PendingCallbacks):
              (WebCore::PendingCallbacks::create):
              (WebCore::PendingCallbacks::appendStartElementNSCallback):
              (WebCore::PendingCallbacks::appendEndElementNSCallback):
              (WebCore::PendingCallbacks::appendCharactersCallback):
              (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
              (WebCore::PendingCallbacks::appendCDATABlockCallback):
              (WebCore::PendingCallbacks::appendCommentCallback):
              (WebCore::PendingCallbacks::appendInternalSubsetCallback):
              (WebCore::PendingCallbacks::appendErrorCallback):
              (WebCore::PendingCallbacks::PendingCallbacks):
              (WebCore::XMLDocumentParser::XMLDocumentParser):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e729ed16
    • abarth@webkit.org's avatar
      2011-05-12 Adam Barth <abarth@webkit.org> · ab797127
      abarth@webkit.org authored
              This patch disables sheriffbot's bug postings.  He's just been way too
              spammy recently due to test flakiness.
      
              * Scripts/webkitpy/tool/commands/sheriffbot.py:
              * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab797127
    • dbates@webkit.org's avatar
      2011-05-12 Daniel Bates <dbates@rim.com> · f28ec400
      dbates@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing
              https://bugs.webkit.org/show_bug.cgi?id=58863
      
              Fixes an issue where a platform mouse event corresponding to mouse button A
              may be associated with the wrong WebCore mouse button when the event occurs
              while pressing and holding a mouse button B, where A != B.
      
              For example, a person clicks the middle mouse button while pressing and holding
              the left mouse button. Then we dispatch the following DOM events: mouse down for
              left button, mouse down for left button, mouse up for left button. But, we should
              have dispatched: mouse down for left button, mouse down for middle button, mouse up
              for middle button.
      
              * platform/qt/PlatformMouseEventQt.cpp:
              (WebCore::mouseEventTypeAndMouseButtonFromQEvent): Added.
              (WebCore::PlatformMouseEvent::PlatformMouseEvent): Modified to call mouseEventTypeAndMouseButtonFromQEvent()
              to determine the WebCore mouse event type and button from the platform-specific event.
      2011-05-12  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] fast/events/fire-mousedown-while-pressing-mouse-button.html failing
              https://bugs.webkit.org/show_bug.cgi?id=58863
      
              Remove test case fast/events/fire-mousedown-while-pressing-mouse-button.html
              from the Skipped list since it now passes.
      
              * platform/qt/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f28ec400
    • bweinstein@apple.com's avatar
      WebKit2: Implement plugin quirk for Mozilla user agent for older Flash · 61be250f
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=60726
      <rdar://problem/8470824>
              
      Reviewed by Adam Roben.
      
      Implement the quirk for versions of Flash before v10 that only request windowless plugins
      if we use a Mozilla user agent.
      
      * Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
      (WebKit::NetscapePluginModule::determineQuirks): If we have a plugin that handles the
          "application/x-shockwave-flash" MIME type with a version less than 10, tell it to use
          the Mozilla user agent.
      * Shared/Plugins/PluginQuirks.h:
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::userAgent): Add an early return if the plugin uses the Mozilla user
          agent.
      * win/WebKit2.vcproj: Add PluginQuirks.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61be250f
    • andersca@apple.com's avatar
      2011-05-12 Anders Carlsson <andersca@apple.com> · 847f29f9
      andersca@apple.com authored
              Reviewed by Simon Fraser.
      
              PluginView::invalidateRect doesn't work for transformed plug-ins
              https://bugs.webkit.org/show_bug.cgi?id=60727
              <rdar://problem/9331244>
      
              Ask the RenderObject to repaint the plug-in instead of using invalidateContentsAndWindow.
              This matches what we do in WebKit1.
      
              * WebProcess/Plugins/PluginView.cpp:
              (WebKit::PluginView::invalidateRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      847f29f9
    • atwilson@chromium.org's avatar
      Unreviewed expectations update for Chromium. · 6f7d433c
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f7d433c
    • leviw@chromium.org's avatar
      2011-05-12 Levi Weintraub <leviw@chromium.org> · 8e91c079
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Switch paintMask and paintMaskImages off of ints
              https://bugs.webkit.org/show_bug.cgi?id=60578
      
              Primarily switching paintMask and paintMaskImages to use IntSize and IntRect respectively.
              In the process of that:
               - added an "expand" function to IntRect that allows you to add an IntSize or pair of
                 integers to the size portion of an IntRect.
               - changed borderFitAdjust to take an IntRect. It modifies only the x and width attributes.
      
              No new tests since this refactoring.
      
              * platform/graphics/IntRect.h:
              (WebCore::IntRect::expand): Added for convenience.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintObject):
              (WebCore::RenderBlock::borderFitAdjust):
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintBoxDecorationsWithSize):
              (WebCore::RenderBox::paintMask):
              (WebCore::RenderBox::paintMaskImages):
              * rendering/RenderBox.h:
              (WebCore::RenderBox::borderFitAdjust):
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::paintMask):
              * rendering/RenderFieldset.h:
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              * rendering/RenderReplica.cpp:
              (WebCore::RenderReplica::paint):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintObject):
              (WebCore::RenderTable::paintMask):
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paintMask):
              * rendering/RenderTableCell.h:
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e91c079
    • commit-queue@webkit.org's avatar
      2011-05-12 Chang Shu <cshu@webkit.org> · e8652c7e
      commit-queue@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              [Qt] Rebaseline editing/execCommand tests that are working
              https://bugs.webkit.org/show_bug.cgi?id=60717
      
              Also based on digging of Zsolt Fehér.
      
              * platform/qt/Skipped:
              * platform/qt/editing/execCommand/4580583-1-expected.png: Added.
              * platform/qt/editing/execCommand/4580583-1-expected.txt:
              * platform/qt/editing/execCommand/4580583-2-expected.png: Added.
              * platform/qt/editing/execCommand/4580583-2-expected.txt:
              * platform/qt/editing/execCommand/4641880-1-expected.png: Added.
              * platform/qt/editing/execCommand/4641880-1-expected.txt:
              * platform/qt/editing/execCommand/4641880-2-expected.png: Added.
              * platform/qt/editing/execCommand/4641880-2-expected.txt:
              * platform/qt/editing/execCommand/4747450-expected.png: Added.
              * platform/qt/editing/execCommand/4747450-expected.txt:
              * platform/qt/editing/execCommand/4786404-1-expected.png: Added.
              * platform/qt/editing/execCommand/4786404-2-expected.png: Added.
              * platform/qt/editing/execCommand/4916402-expected.png: Added.
              * platform/qt/editing/execCommand/4916402-expected.txt:
              * platform/qt/editing/execCommand/4916541-expected.png: Added.
              * platform/qt/editing/execCommand/4916541-expected.txt:
              * platform/qt/editing/execCommand/4924441-expected.png: Added.
              * platform/qt/editing/execCommand/4924441-expected.txt:
              * platform/qt/editing/execCommand/5049671-expected.png: Added.
              * platform/qt/editing/execCommand/5062376-expected.png: Added.
              * platform/qt/editing/execCommand/5062376-expected.txt:
              * platform/qt/editing/execCommand/5080333-1-expected.png: Added.
              * platform/qt/editing/execCommand/5080333-1-expected.txt:
              * platform/qt/editing/execCommand/5080333-2-expected.png: Added.
              * platform/qt/editing/execCommand/5080333-2-expected.txt:
              * platform/qt/editing/execCommand/5136770-expected.png: Added.
              * platform/qt/editing/execCommand/5136770-expected.txt:
              * platform/qt/editing/execCommand/5138441-expected.png: Added.
              * platform/qt/editing/execCommand/5138441-expected.txt:
              * platform/qt/editing/execCommand/5142012-1-expected.png: Added.
              * platform/qt/editing/execCommand/5142012-1-expected.txt:
              * platform/qt/editing/execCommand/5142012-2-expected.png: Added.
              * platform/qt/editing/execCommand/5142012-2-expected.txt:
              * platform/qt/editing/execCommand/5190926-expected.png: Added.
              * platform/qt/editing/execCommand/5190926-expected.txt:
              * platform/qt/editing/execCommand/5481523-expected.png: Added.
              * platform/qt/editing/execCommand/5481523-expected.txt: Added.
              * platform/qt/editing/execCommand/5482023-expected.png: Added.
              * platform/qt/editing/execCommand/5482023-expected.txt: Added.
              * platform/qt/editing/execCommand/5569741-expected.png: Added.
              * platform/qt/editing/execCommand/5569741-expected.txt: Added.
              * platform/qt/editing/execCommand/create-list-with-hr-expected.png: Added.
              * platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
              * platform/qt/editing/execCommand/find-after-replace-expected.png: Added.
              * platform/qt/editing/execCommand/find-after-replace-expected.txt:
              * platform/qt/editing/execCommand/findString-2-expected.png: Added.
              * platform/qt/editing/execCommand/findString-2-expected.txt:
              * platform/qt/editing/execCommand/findString-expected.png: Added.
              * platform/qt/editing/execCommand/findString-expected.txt:
              * platform/qt/editing/execCommand/format-block-with-trailing-br-expected.png: Added.
              * platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt:
              * platform/qt/editing/execCommand/indent-empty-root-expected.png: Added.
              * platform/qt/editing/execCommand/indent-empty-root-expected.txt:
              * platform/qt/editing/execCommand/indent-list-item-expected.png: Added.
              * platform/qt/editing/execCommand/indent-list-item-expected.txt:
              * platform/qt/editing/execCommand/indent-selection-expected.png: Added.
              * platform/qt/editing/execCommand/indent-selection-expected.txt:
              * platform/qt/editing/execCommand/insert-list-and-stitch-expected.png: Added.
              * platform/qt/editing/execCommand/insert-list-and-stitch-expected.txt:
              * platform/qt/editing/execCommand/insert-list-with-id-expected.png: Added.
              * platform/qt/editing/execCommand/insert-list-with-id-expected.txt:
              * platform/qt/editing/execCommand/insertHorizontalRule-expected.png: Added.
              * platform/qt/editing/execCommand/insertHorizontalRule-expected.txt:
              * platform/qt/editing/execCommand/insertImage-expected.png: Added.
              * platform/qt/editing/execCommand/insertImage-expected.txt:
              * platform/qt/editing/execCommand/nsresponder-indent-expected.png: Added.
              * platform/qt/editing/execCommand/nsresponder-indent-expected.txt: Added.
              * platform/qt/editing/execCommand/nsresponder-outdent-expected.png: Added.
              * platform/qt/editing/execCommand/nsresponder-outdent-expected.txt: Added.
              * platform/qt/editing/execCommand/outdent-blockquote-test1-expected.png: Added.
              * platform/qt/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
              * platform/qt/editing/execCommand/outdent-blockquote-test2-expected.png: Added.
              * platform/qt/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
              * platform/qt/editing/execCommand/outdent-blockquote-test3-expected.png: Added.
              * platform/qt/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
              * platform/qt/editing/execCommand/outdent-blockquote-test4-expected.png: Added.
              * platform/qt/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
              * platform/qt/editing/execCommand/outdent-selection-expected.png: Added.
              * platform/qt/editing/execCommand/outdent-selection-expected.txt:
              * platform/qt/editing/execCommand/paste-1-expected.png: Added.
              * platform/qt/editing/execCommand/paste-1-expected.txt:
              * platform/qt/editing/execCommand/paste-2-expected.png: Added.
              * platform/qt/editing/execCommand/paste-2-expected.txt:
              * platform/qt/editing/execCommand/print-expected.png: Added.
              * platform/qt/editing/execCommand/print-expected.txt:
              * platform/qt/editing/execCommand/remove-list-from-range-selection-expected.png: Added.
              * platform/qt/editing/execCommand/remove-list-from-range-selection-expected.txt:
              * platform/qt/editing/execCommand/remove-list-item-1-expected.png: Added.
              * platform/qt/editing/execCommand/remove-list-item-1-expected.txt:
              * platform/qt/editing/execCommand/selectAll-expected.png: Added.
              * platform/qt/editing/execCommand/selectAll-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8652c7e
    • paroga@webkit.org's avatar
      2011-05-12 Patrick Gansterer <paroga@webkit.org> · 1d6efc45
      paroga@webkit.org authored
              Reviewed by Eric Seidel.
      
              SimpleFontData::scaledFontData should return a PassOwnPtr
              https://bugs.webkit.org/show_bug.cgi?id=60657
      
              Let scaledFontData return a PassOwnPtr instead of a raw pointer
              to make SimpleFontData build without LOOSE_PASS_OWN_PTR.
      
              * platform/graphics/SimpleFontData.h:
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::scaledFontData):
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              (WebCore::SimpleFontData::scaledFontData):
              * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
              (WebCore::SimpleFontData::scaledFontData):
              * platform/graphics/haiku/SimpleFontDataHaiku.cpp:
              (WebCore::SimpleFontData::scaledFontData):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::scaledFontData):
              * platform/graphics/pango/SimpleFontDataPango.cpp:
              (WebCore::SimpleFontData::scaledFontData):
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              (WebCore::SimpleFontData::scaledFontData):
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::scaledFontData):
              * platform/graphics/wince/SimpleFontDataWinCE.cpp:
              (WebCore::SimpleFontData::scaledFontData):
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              (WebCore::SimpleFontData::scaledFontData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d6efc45
    • commit-queue@webkit.org's avatar
      2011-05-12 Chang Shu <cshu@webkit.org> · 0beebda7
      commit-queue@webkit.org authored
              Reviewed by Csaba Osztrogonác.
      
              [Qt] Rebaseline editing/pasteboard tests that are working
              https://bugs.webkit.org/show_bug.cgi?id=60707
      
              * platform/qt/Skipped:
              * platform/qt/editing/pasteboard/4076267-2-expected.png: Added.
              * platform/qt/editing/pasteboard/4076267-2-expected.txt: Added.
              * platform/qt/editing/pasteboard/4076267-expected.png: Added.
              * platform/qt/editing/pasteboard/4076267-expected.txt: Added.
              * platform/qt/editing/pasteboard/4806874-expected.png: Added.
              * platform/qt/editing/pasteboard/4806874-expected.txt:
              * platform/qt/editing/pasteboard/5387578-expected.png: Added.
              * platform/qt/editing/pasteboard/5387578-expected.txt:
              * platform/qt/editing/pasteboard/bad-placeholder-expected.png: Added.
              * platform/qt/editing/pasteboard/bad-placeholder-expected.txt:
              * platform/qt/editing/pasteboard/block-wrappers-necessary-expected.png: Added.
              * platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt:
              * platform/qt/editing/pasteboard/input-field-1-expected.png: Added.
              * platform/qt/editing/pasteboard/input-field-1-expected.txt:
              * platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
              * platform/qt/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
              * platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
              * platform/qt/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
              * platform/qt/editing/pasteboard/paste-text-008-expected.png: Added.
              * platform/qt/editing/pasteboard/paste-text-008-expected.txt: Added.
              * platform/qt/editing/pasteboard/smart-paste-008-expected.png: Added.
              * platform/qt/editing/pasteboard/smart-paste-008-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0beebda7
    • atwilson@chromium.org's avatar
      Unreviewed expectations update for Chromium. · c2457ccc
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2457ccc
    • atwilson@chromium.org's avatar
      Unreviewed expectations update for Chromium. · ea886f91
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea886f91
    • jberlin@webkit.org's avatar
      Assertion failure when requesting that storage be deleted for an origin without storage. · 994f6a03
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60709
      
      Reviewed by Darin Adler.
      
      * storage/StorageTracker.cpp:
      (WebCore::StorageTracker::syncDeleteOrigin):
      If the path to the storage location for the givin origin is empty, return early instead of
      asserting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      994f6a03
    • demarchi@webkit.org's avatar
      2011-05-12 Lucas De Marchi <lucas.demarchi@profusion.mobi> · ab338d63
      demarchi@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [CMAKE] Add option to unconditionally enable/disable a feature
              https://bugs.webkit.org/show_bug.cgi?id=60643
      
              Create an argument to be used in WEBKIT_FEATURE macro, allowing a port
              to enable a feature without showing to user that it can be disabled.
              This is useful if a port needs an option to be always ON/OFF and
              changing it will break the build.
      
              This way it's possible to add mandatory features to each port without
              touching the cmakeconfig.cmake file.
      
              * Source/cmake/WebKitFeatures.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab338d63
    • jberlin@webkit.org's avatar
      [Windows WebKit2] Use cookies set in WebKit1 · e09492e9
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60274
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Make sure any Private Browsing session is based off the default session.
      
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
      
      Source/WebKit2: 
      
      Properly handle the case where there is no serialized default storage session by not trying
      to encode or decode 0, while still making sure to decode any valid storage session.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
      (WebKit::WebProcessCreationParameters::encode):
      Only encode the storage session if there is one to encode.
      (WebKit::WebProcessCreationParameters::decode):
      Only decode the storage session there is one to decode.
      * Shared/WebProcessCreationParameters.h:
      
      WebKitLibraries: 
      
      Update WKSI with the changes to wkCreatePrivateStorageSession.
      
      * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
      * win/lib/WebKitSystemInterface.lib:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e09492e9
    • atwilson@chromium.org's avatar
      Unreviewed expectations update for Chromium. · bd01e397
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd01e397
    • atwilson@chromium.org's avatar
      Unreviewed expectations update for chromium. · b7bac222
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7bac222
    • jeffm@apple.com's avatar
      Ignore Visual Studio *.user files. · 555643e0
      jeffm@apple.com authored
      * gtest/msvc: Added property svn:ignore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      555643e0
    • rwlbuis@webkit.org's avatar
      2011-05-12 Rob Buis <rbuis@rim.com> · e12e3d44
      rwlbuis@webkit.org authored
              Reviewed by Eric Seidel.
      
              SVGStyledElement::resolveStyle(RenderStyle*) must be removed/fixed!
              https://bugs.webkit.org/show_bug.cgi?id=15479
      
              Finally remove resolveStyle, it is not used anymore.
      
              * svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::childrenChanged):
              * svg/SVGStyledElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e12e3d44
    • abarth@webkit.org's avatar
      2011-05-12 Adam Barth <abarth@webkit.org> · c4d1975d
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              REGRESSION (r65868): createContextualFragment does not work with <style>
              https://bugs.webkit.org/show_bug.cgi?id=60155
      
              These test results match Firefox.
      
              * fast/parser/style-in-create-contextual-fragment-expected.txt: Added.
              * fast/parser/style-in-create-contextual-fragment-head-expected.txt: Added.
              * fast/parser/style-in-create-contextual-fragment-head.html: Added.
              * fast/parser/style-in-create-contextual-fragment.html: Added.
      2011-05-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              REGRESSION (r65868): createContextualFragment does not work with <style>
              https://bugs.webkit.org/show_bug.cgi?id=60155
      
              createContextualFragment doesn't have a spec, so it's hard to tell what
              we're supposed to do exactly.  This patch appears to make our behavior
              more like Firefox and should fix the compat issue with this site.
      
              Tests: fast/parser/style-in-create-contextual-fragment-head.html
                     fast/parser/style-in-create-contextual-fragment.html
      
              * dom/Element.cpp:
              (WebCore::Element::deprecatedCreateContextualFragment):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4d1975d
    • commit-queue@webkit.org's avatar
      2011-05-12 David Grogan <dgrogan@chromium.org> · 2f975c92
      commit-queue@webkit.org authored
              Reviewed by Nate Chapin.
      
              IndexedDB: fix up database-quota.html layout test
              https://bugs.webkit.org/show_bug.cgi?id=60519
      
              Remove commitAndContinue idiom; translate some missed instances of
              event.code to event.target.errorCode from bug 54331
      
              * storage/indexeddb/database-quota-expected.txt:
              * storage/indexeddb/database-quota.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f975c92
    • jam@chromium.org's avatar
      Fix mismatched virtual function from previous checkin · 0d3fbb94
      jam@chromium.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d3fbb94
    • mrobinson@webkit.org's avatar
      2011-05-12 Martin Robinson <mrobinson@igalia.com> · 018621b6
      mrobinson@webkit.org authored
              Attempt to fix the GTK+ unit test testwebview on the 32-bit Release
              bot which appears to be more sensitive to timing issues than the
              other bots.
      
              * tests/testwebview.c: Add another short pause waiting for adjustments to update.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      018621b6