GitLab

        Unreviewed, Chromium build fix.

        Add special case in CodeGeneratorV8.pm for named getters for html plugin-related elements.

        CodeGeneratorV8.pm was relying on HasOverridingNameGetter to hint
        that a custom named getter was needed. That hint was removed in
        http://trac.webkit.org/changeset/55104.

        * bindings/scripts/CodeGeneratorV8.pm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] fast/encoding/invalid-UTF-8-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=35263

Qt Linux Release buildbot got the platform independent result for
fast/encoding/invalid-UTF-8-2.html instead of Qt specific one.

Qt specific expected file is removed to make buildbot green,
but it needs more investigation.

* platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rename RuntimeObjectImp to RuntimeObject.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

and in the worst case can lead to heap corruption.
https://bugs.webkit.org/show_bug.cgi?id=35167

Reviewed by Eric Seidel.

WebCore: 

Test: fast/images/bad-png.html

* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::decode):

LayoutTests: 

* fast/images/bad-png-expected.txt: Added.
* fast/images/bad-png.html: Added.
* fast/images/resources/bad-png.png: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254

Reviewed by Tim Hatcher.

WebCore: 

* WebCore.base.exp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Provide a utility for WebKits to make a showWindow()
  decision based on if attachment would be allowed or not.
(WebCore::InspectorController::attachWindow): Don't attach if the view is too small to attach to.
* inspector/InspectorController.h:

WebKit/mac: 

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector 
  window attached if WebCore says it shouldn't be attached.

WebKit/win: 

* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector 
  window attached if WebCore says it shouldn't be attached.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * WebCore.base.exp: Export Instance::newRuntimeObject, it's virtual!



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Let's keep the instance local
        variable as RefPtr for safety.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=35260
        Eliminate __apple_runtime_object

        No change in functionality, so no tests.

        * WebCore.base.exp: Don't export Instance::newRuntimeObject, WebKit doesn't need it.

        * bindings/js/JSHTMLAppletElementCustom.cpp:
        * bindings/js/JSHTMLEmbedElementCustom.cpp:
        * bindings/js/JSHTMLObjectElementCustom.cpp:
        * html/HTMLAppletElement.idl:
        * html/HTMLEmbedElement.idl:
        * html/HTMLObjectElement.idl:
        These objects no longer need overriding name getters, as they no longer intercept the
        __apple_runtime_object property.

        * bindings/js/JSPluginElementFunctions.cpp:
        (WebCore::pluginInstance): This is no longer static. It was used for callPlugin() in
        this file, and now it's also used elsewhere when calling plug-in methods.
        (WebCore::runtimeObjectGetter): Removed. This function was only used by the intercepting
        name getters.

        * bindings/js/JSPluginElementFunctions.h: Export pluginInstance().

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
        * bridge/runtime_method.cpp:
        (JSC::callRuntimeMethod):
        Take plug-in element's instance directly, without relying on fake attribute lookup.
        One change resulting from this is that RuntimeObjectImp may not be created in some cases -
        this code only needs an instance, but the old code had to pass the instance wrapped into
        RuntimeObjectImp.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=32937
        LayoutTests/fast/encoding/invalid-UTF-8.html fails on Qt.

        The test was verifying two things: first, that U+FFFD is rendered by the browser, and second,
        that ill-formed UTF-8 sequences are turned into U+FFFD. Some aspects of the latter are not
        precisely defined by the Unicode specification, so different platforms may legitimately
        have different results.

        Split the test into two: one to test the rendering of invalid UTF-8 sequences, and the other
        to protect against regressions in each platform's decoding behaviour.

        * fast/encoding/invalid-UTF-8-2-expected.txt: Added.
        * fast/encoding/invalid-UTF-8-2.html: Added.
        * fast/encoding/invalid-UTF-8.html:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.png:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
        * platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=35186

Fixing layout test failure.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index

Reviewed by Tim Hatcher.

No new tests because this code path is not used for JS-initiated changes.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
Bail out if the to-be-selected index matches the already-selected index.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by John Sullivan.

        <rdar://problem/7285392>
        On Leopard, we have to disable hardware acceleration if we detect that the
        installed Core Video framework has bug <rdar://problem/7228836>.

        * WebView/WebView.mm:
        (coreVideoHas7228836Fix):
        (-[WebView _preferencesChangedNotification:]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/7615758>
https://bugs.webkit.org/show_bug.cgi?id=35060

Reviewed by Dan Bernstein.

WebCore: 

Test: editing/selection/extend-byline-withfloat.html

* editing/visible_units.cpp:
(WebCore::previousLinePosition): Skip elements with zero height.
(WebCore::nextLinePosition): Skip elements with zero height.

LayoutTests: 

* editing/selection/extend-byline-withfloat-expected.txt: Added.
* editing/selection/extend-byline-withfloat.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, Chromium build fix.

        * bindings/scripts/CodeGeneratorV8.pm: Compile break due to bad patch merge.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dimitri Glazkov.

        [V8] Streamline V8 event listener code. Merge all the variants of
        V8DOMWrapper::getEventListner() into a single version and generate
        addEventListener() and removeEventListener() bindings for all objects 
        except DOMWindow.

        https://bugs.webkit.org/show_bug.cgi?id=35245



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=35186

Reviewed by Beth Dakin.

WebCore: 

Test: platform/mac/accessibility/element-focus.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

LayoutTests: 

* platform/mac/accessibility/element-focus-expected.txt: Added.
* platform/mac/accessibility/element-focus.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed Symbian build fix.

        [Qt] Updated the def file with new exports to enable
        building DumpRenderTree.

        * symbian/eabi/QtWebKitu.def:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Oliver Hunt.

* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::build):
* runtime/StringBuilder.h:
(JSC::StringBuilder::build):
* wtf/Vector.h:
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::::tryExpandCapacity):
(WTF::::tryReserveCapacity):
(WTF::::tryAppend):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Gustavo Noronha.

        Bump library versioning for 1.1.22 release.

        * configure.ac:

WebKit/gtk:

2010-02-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update for release.

        * NEWS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        [BREWMP] Map FastMalloc to BREW memory allocator
        https://bugs.webkit.org/show_bug.cgi?id=33570

        Use MALLOC macro instead of the standard malloc function.
        Although RVCT provides malloc, we can't use it in BREW
        because the loader does not initialize the base address properly.

        * wtf/FastMalloc.cpp:
        * wtf/brew/SystemMallocBrew.h: Added.
        (mallocBrew):
        (callocBrew):
        (freeBrew):
        (reallocBrew):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein, Darin Adler.

        Remove addScrolledContentOffset/subtractScrolledContentOffset
        https://bugs.webkit.org/show_bug.cgi?id=35225

        Remove RenderLayer's addScrolledContentOffset() and subtractScrolledContentOffset()
        methods, and instead use the existing scrolledContentOffset(), and use
        IntSize and IntPoint instead of lots of x, y variables.

        Added new IntPoint toPoint(const IntSize&) method as a convenience to convert a size to a point,
        which is needed in a few places.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleDrag): Use the new toPoint() convenience.
        * platform/graphics/IntPoint.h:
        (WebCore::toPoint): New convenience method to convert an IntSize to an IntPoint.
        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::selectionGapRectsForRepaint):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::offsetForContents):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::clippedOverflowRectForRepaint):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::size):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::computeRectForRepaint):
        * rendering/TextControlInnerElements.cpp:
        (WebCore::RenderTextControlInnerBlock::positionForPoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Fisher.

        fontconfig on Linux can change the render preferences on a per strike
        basis (a strike a combination of face and size). Because of this, we
        need to query fontconfig each time a new FontPlatformData is created
        for a new size.

        This patch adds support for querying this via ChromiumBridge.

        https://bugs.webkit.org/show_bug.cgi?id=33065

        * platform/chromium/ChromiumBridge.h: add getRenderStyleForStrike
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::setupPaint):
        (WebCore::FontPlatformData::queryStyle):
          add code to query fontconfig via ChromiumBridge
        * platform/graphics/chromium/FontPlatformDataLinux.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Kenneth Rohde Christiansen.

        Fix compiler warning "suggest parentheses around"
        https://bugs.webkit.org/show_bug.cgi?id=35197

        No new tests as there is no new functionality.

        * wml/WMLVariables.cpp:
        (WebCore::substituteVariableReferences):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2010-02-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
        https://bugs.webkit.org/show_bug.cgi?id=35093

        Store message flags in WebCore objects, and set them on the
        SoupMessage, when creating one from them.

        No behaviour change.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):
        * platform/network/soup/ResourceRequest.h:
        (WebCore::ResourceRequest::soupMessageFlags):
        (WebCore::ResourceRequest::setSoupMessageFlags):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):
        * platform/network/soup/ResourceResponse.h:
        (WebCore::ResourceResponse::soupMessageFlags):
        (WebCore::ResourceResponse::setSoupMessageFlags):
        * platform/network/soup/ResourceResponseSoup.cpp:
        (WebCore::ResourceResponse::toSoupMessage):
        (WebCore::ResourceResponse::updateFromSoupMessage):

WebKit/gtk

2010-02-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
        https://bugs.webkit.org/show_bug.cgi?id=35093

        Update the flags that are stored in the request, when the response
        is received.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Kenneth Rohde Christiansen.

* DumpRenderTree/qt/DumpRenderTree.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Nate Chapin.

        Shared worker types used in globalObjectPrototypeIsDOMWindow are not properly guarded
        https://bugs.webkit.org/show_bug.cgi?id=35238

        No new tests, build fix only.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::globalObjectPrototypeIsDOMWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed build fix.

        [Qt] Build fix for RVCT.

        Fix after r55024. The "-i" option is for perl not for the
        script.

        * DerivedSources.pro:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add support for layout tests on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31589

        * WebKit.pro:
2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add support for layout tests on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31589

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        * DumpRenderTree/qt/main.cpp:
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon Fraser.

        Simplifies calculation of the transform in RenderLayer::paintLayer
        https://bugs.webkit.org/show_bug.cgi?id=35101

        No new tests, optimization only.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Maciej Stachowiak.

        Don't reset the assignee back to default on component change

        https://bugs.webkit.org/show_bug.cgi?id=35236

        There's a risk of reseting a valid assignee for example when
        triaging a bug. All components in WebKit have the default
        assignee set to webkit-unassigned@webkit.org so this should
        not cause problems for people relying on this functionality.

        * template/en/custom/bug/edit.html.tmpl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Nicholas Young <nicholas.young@nokia.com> on 2010-02-22
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=34631

No new tests. This patch only affects multimedia backend.

* WebCore.pro: Build depends on Qt version.
* css/mediaControlsQt.css: Updated media controls.
* platform/graphics/MediaPlayer.cpp: Different backend included depending on Qt version.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::supportsMuting):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::mediaStatusChanged):
(WebCore::MediaPlayerPrivate::handleError):
(WebCore::MediaPlayerPrivate::stateChanged):
(WebCore::MediaPlayerPrivate::nativeSizeChanged):
(WebCore::MediaPlayerPrivate::queuedSeekTimeout):
(WebCore::MediaPlayerPrivate::seekTimeout):
(WebCore::MediaPlayerPrivate::positionChanged):
(WebCore::MediaPlayerPrivate::durationChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::mutedChanged):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::repaint):
* platform/graphics/qt/MediaPlayerPrivateQt.h: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::isAvailable):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::mediaControlsBaselineOpacity): New method.
(WebCore::RenderThemeQt::paintMediaBackground): Background depends on baseline opacity.
(WebCore::RenderThemeQt::paintMediaMuteButton): Changed styling.
(WebCore::RenderThemeQt::paintMediaCurrentTime): Added current time display.
(WebCore::RenderThemeQt::formatMediaControlsCurrentTime): Added time formatting.
(WebCore::RenderThemeQt::formatMediaControlsRemainingTime): Added time formatting.
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack): Volume slider added.
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb): Volume slider added.
(WebCore::RenderThemeQt::paintMediaSliderTrack): Updated for QtMultimedia.
(WebCore::RenderThemeQt::paintMediaSliderThumb): Dropped an unnecessary check.
(WebCore::RenderThemeQt::adjustSliderThumbSize): Handle a missing case.
* platform/qt/RenderThemeQt.h: Reimplemented a few more methods.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Not reviewed: mac build fix

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::ScriptDebugServer):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Pavel Feldman.

        Web Inspector: there should be a way to "deactivate" or "skip" all breakpoints while debugging.
        https://bugs.webkit.org/show_bug.cgi?id=33217

        WebCore:
        * English.lproj/localizedStrings.js:
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::ScriptDebugServer):
        (WebCore::ScriptDebugServer::hasBreakpoint):
        (WebCore::ScriptDebugServer::setBreakpointsActivated):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/ScriptDebugServer.h:
        (WebCore::ScriptDebugServer::setBreakpointsActivated):
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::activateBreakpoints):
        (WebCore::InspectorBackend::deactivateBreakpoints):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png: Added.
        * inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png: Added.
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.activateBreakpoints):
        (.WebInspector.InspectorBackendStub.prototype.deactivateBreakpoints):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.get breakpointsActivated):
        (WebInspector.ScriptsPanel.prototype.addBreakpoint):
        (WebInspector.ScriptsPanel.prototype._stepOutClicked):
        (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
        * inspector/front-end/inspector.css:
        * inspector/front-end/textViewer.css:

        WebKit/chromium:
        * src/js/DebuggerAgent.js:
        (devtools.DebuggerAgent):
        (devtools.DebuggerAgent.prototype.setBreakpointsActivated):
        (devtools.DebuggerAgent.prototype.handleBreakEvent_):
        (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl.prototype.activateBreakpoints):
        (devtools.InspectorBackendImpl.prototype.deactivateBreakpoints):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<http://webkit.org/b/35222> / <rdar://problem/7673523>

Rubber-stamped by Sam Weinig and Maciej Stachowiak.

Roll out r55039 (related to <http://webkit.org/b/35115>) as it causes animated GIFs
to skip intermediate frames when loading over a slower network.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        
Revert the previous change.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin Adler.

        Cache JavaScript wrappers inline in DOM nodes
        https://bugs.webkit.org/show_bug.cgi?id=35226
        <rdar://problem/7664202>

        8.8% speedup on Dromaeo DOM Core tests.
        3.3% speedup on Hixie DOM Core tests.
        
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::forgetDOMNode): Clear wrapper pointer.
        (WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
        * bindings/js/JSDOMBinding.h:
        (WebCore::DOMObjectWrapperMapFor): 
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::toJS): Remove unneeded argument from getCachedDOMNodeWrapper.
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapperInline): Renamed version of original createWrapper.
        (WebCore::createWrapper): Call createWrapperInline. Out-of-line version.
        (WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
        * bindings/js/JSNodeCustom.h: Added.
        (WebCore::getCachedDOMNodeWrapper): Moved here so it can be inlined.
        (WebCore::toJS): Moved here so it can be inlined.
        * bindings/js/ScriptWrappable.h:
        (WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious
        way for JavaScriptCore.
        (WebCore::ScriptWrappable::wrapper):
        (WebCore::ScriptWrappable::setWrapper):
        (WebCore::ScriptWrappable::clearWrapper):
        * bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders
        in the header, not just the impl file, so they can add inlining.
        * dom/Node.idl: Add CustomHeader directive.
        
        Add new files to build.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Not reviewed: windows build fix.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Timothy Hatcher.

        Web Inspector: stop on inline breakpoints on reload.
        - ScriptBreakpoint struct has been introduced and reused in InspectorController
          and debug server.
        - JavaScriptDebugServer was moved to bindings/js and renamed to ScriptDebugServer
          There were no changes to semantics, only some mechanical changes:
            - addBreakpoint and updateBreakpoint were merged into setBreakpoint
            - ScriptDebugServer now operates ScriptBreakpoint instances instead of
              BreakpointInfo.
            - It no longer allocates maps and breakpoint info in heap - all done on stack.
            - JavaScriptDebugListener is now ScriptDebugServer::Listener
            - Listener methods no longer have ExecState (was unused).
            - addListener/removeListener pair wuth no page argument removed (was unused).
        - InspectorController now binds sourceID to url and maintains a map of 'sticky'
          breakpoints. Whenever script is loaded and there is a sticky breakpoint url matching,
          breakpoint is being 'restored' synchronously in debug server and pushed to frontend.
          Front-end no longer stores map of sticky breakpoints.
            - setBreakpoint/removeBreakpoint/didParseSource trio handle this logic.
        - A bunch of if(USE_JSC/V8/other) forks removed.
        - InspectorFrontend now operates primitive types only, got rid of USE_JSC as well.

        https://bugs.webkit.org/show_bug.cgi?id=28799

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.gypi:
        * WebCore.order:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::currentCallFrame):
        (WebCore::JSInjectedScriptHost::isActivation):
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::shared):
        (WebCore::ScriptDebugServer::ScriptDebugServer):
        (WebCore::ScriptDebugServer::~ScriptDebugServer):
        (WebCore::ScriptDebugServer::addListener):
        (WebCore::ScriptDebugServer::removeListener):
        (WebCore::ScriptDebugServer::pageCreated):
        (WebCore::ScriptDebugServer::hasListenersInterestedInPage):
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        (WebCore::ScriptDebugServer::hasBreakpoint):
        (WebCore::ScriptDebugServer::clearBreakpoints):
        (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
        (WebCore::ScriptDebugServer::pauseProgram):
        (WebCore::ScriptDebugServer::continueProgram):
        (WebCore::ScriptDebugServer::stepIntoStatement):
        (WebCore::ScriptDebugServer::stepOverStatement):
        (WebCore::ScriptDebugServer::stepOutOfFunction):
        (WebCore::ScriptDebugServer::currentCallFrame):
        (WebCore::ScriptDebugServer::currentCallFrameState):
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        (WebCore::ScriptDebugServer::dispatchFailedToParseSource):
        (WebCore::toPage):
        (WebCore::ScriptDebugServer::detach):
        (WebCore::ScriptDebugServer::sourceParsed):
        (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
        (WebCore::ScriptDebugServer::setJavaScriptPaused):
        (WebCore::ScriptDebugServer::pauseIfNeeded):
        (WebCore::ScriptDebugServer::callEvent):
        (WebCore::ScriptDebugServer::atStatement):
        (WebCore::ScriptDebugServer::returnEvent):
        (WebCore::ScriptDebugServer::exception):
        (WebCore::ScriptDebugServer::willExecuteProgram):
        (WebCore::ScriptDebugServer::didExecuteProgram):
        (WebCore::ScriptDebugServer::didReachBreakpoint):
        (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
        (WebCore::ScriptDebugServer::recompileAllJSFunctions):
        (WebCore::ScriptDebugServer::didAddListener):
        (WebCore::ScriptDebugServer::didRemoveListener):
        (WebCore::ScriptDebugServer::didRemoveLastListener):
        * bindings/js/ScriptDebugServer.h:
        (WebCore::ScriptDebugServer::Listener::~Listener):
        (WebCore::ScriptDebugServer::):
        (WebCore::ScriptDebugServer::pauseOnExceptionsState):
        (WebCore::ScriptDebugServer::hasListeners):
        (WebCore::ScriptDebugServer::hasGlobalListeners):
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::shared):
        * bindings/v8/ScriptDebugServer.h:
        (WebCore::ScriptDebugServer::Listener::~Listener):
        (WebCore::ScriptDebugServer::addListener):
        (WebCore::ScriptDebugServer::removeListener):
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        (WebCore::ScriptDebugServer::clearBreakpoints):
        (WebCore::ScriptDebugServer::):
        (WebCore::ScriptDebugServer::pauseOnExceptionsState):
        (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
        (WebCore::ScriptDebugServer::pauseProgram):
        (WebCore::ScriptDebugServer::continueProgram):
        (WebCore::ScriptDebugServer::stepIntoStatement):
        (WebCore::ScriptDebugServer::stepOverStatement):
        (WebCore::ScriptDebugServer::stepOutOfFunction):
        (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
        (WebCore::ScriptDebugServer::recompileAllJSFunctions):
        (WebCore::ScriptDebugServer::currentCallFrameState):
        (WebCore::ScriptDebugServer::pageCreated):
        (WebCore::ScriptDebugServer::ScriptDebugServer):
        (WebCore::ScriptDebugServer::~ScriptDebugServer):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
        (WebCore::V8InjectedScriptHost::isActivationCallback):
        * inspector/InjectedScriptHost.cpp:
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::setBreakpoint):
        (WebCore::InspectorBackend::removeBreakpoint):
        (WebCore::InspectorBackend::pauseInDebugger):
        (WebCore::InspectorBackend::stepOverStatementInDebugger):
        (WebCore::InspectorBackend::stepIntoStatementInDebugger):
        (WebCore::InspectorBackend::stepOutOfFunctionInDebugger):
        (WebCore::InspectorBackend::pauseOnExceptionsState):
        (WebCore::InspectorBackend::setPauseOnExceptionsState):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/ScriptBreakpoint.h: Added.
        (WebCore::InspectorBreakpoint::InspectorBreakpoint):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::stopUserInitiatedProfiling):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::resumeDebugger):
        (WebCore::InspectorController::setBreakpoint):
        (WebCore::InspectorController::removeBreakpoint):
        (WebCore::InspectorController::didParseSource):
        (WebCore::InspectorController::failedToParseSource):
        (WebCore::InspectorController::didPause):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::parsedScriptSource):
        (WebCore::InspectorFrontend::restoredBreakpoint):
        (WebCore::InspectorFrontend::failedToParseScriptSource):
        (WebCore::InspectorFrontend::resumedScript):
        * inspector/InspectorFrontend.h:
        * inspector/JavaScriptDebugListener.h: Removed.
        * inspector/JavaScriptDebugServer.cpp: Removed.
        * inspector/JavaScriptDebugServer.h: Removed.
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint.prototype.set condition):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
        (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.sourceFrameForResource):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.addScript):
        (WebInspector.ScriptsPanel.prototype.addBreakpoint):
        (WebInspector.ScriptsPanel.prototype.removeBreakpoint):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        * inspector/front-end/inspector.js:
        (WebInspector.restoredBreakpoint):
        * page/Page.cpp:
        (WebCore::Page::Page):
        * platform/android/TemporaryLinkStubs.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55071 268f45cc-cd09-0410-ab3c-d52691b4dbfc