1. 29 Apr, 2009 40 commits
    • eric@webkit.org's avatar
      No review, build fix only. · eb7f9305
      eric@webkit.org authored
              Fix m_offset uses added while I wasn't looking.
      
              * editing/visible_units.cpp:
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb7f9305
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · 4e32ebc3
      eric@webkit.org authored
              Make m_offset private and change all callers to use deprecatedEditingOffset().
              https://bugs.webkit.org/show_bug.cgi?id=25472
      
              Per Darin's suggestion, this was just a simple search replace
              of .m_offset with .deprecatedEditingOffset().
      
              There was one change in InsertParagraphSeparatorCommand::doApply to use
              Position::moveToOffset(0) instead of .m_offset = 0;
      
              * dom/Position.cpp:
              (WebCore::Position::rendersInDifferentPosition):
              (WebCore::Position::leadingWhitespacePosition):
              * dom/Position.h:
              (WebCore::Position::deprecatedEditingOffset):
              (WebCore::Position::moveToOffset):
              (WebCore::operator==):
              * dom/PositionIterator.h:
              (WebCore::PositionIterator::PositionIterator):
              * dom/Range.cpp:
              (WebCore::Range::create):
              (WebCore::Range::compareBoundaryPoints):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::nodeFullySelected):
              (WebCore::ApplyStyleCommand::nodeFullyUnselected):
              (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
              (WebCore::ApplyStyleCommand::joinChildTextNodes):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::insertNodeAt):
              (WebCore::CompositeEditCommand::positionOutsideTabSpan):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
              (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
              (WebCore::CompositeEditCommand::deleteInsignificantText):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::updatePositionForNodeRemoval):
              (WebCore::updatePositionForTextRemoval):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              * editing/Editor.cpp:
              (WebCore::Editor::setComposition):
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::getCompositionSelection):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::performTrivialReplace):
              (WebCore::InsertTextCommand::input):
              (WebCore::InsertTextCommand::insertTab):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::debugRenderer):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::rangeFromLocationAndLength):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::debugPosition):
              (WebCore::makeRange):
              (WebCore::setStart):
              (WebCore::setEnd):
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::toNormalizedRange):
              (WebCore::makeSearchRange):
              (WebCore::VisibleSelection::debugPosition):
              (WebCore::VisibleSelection::showTreeForThis):
              * editing/htmlediting.cpp:
              (WebCore::comparePositions):
              (WebCore::rangeCompliantEquivalent):
              * editing/visible_units.cpp:
              (WebCore::previousBoundary):
              (WebCore::nextBoundary):
              (WebCore::startPositionForLine):
              (WebCore::startOfLine):
              (WebCore::endPositionForLine):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/AccessibilityObject.cpp:
              (WebCore::updateAXLineStartForVisiblePosition):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorOffset):
              (WebCore::DOMSelection::focusOffset):
              (WebCore::DOMSelection::baseOffset):
              (WebCore::DOMSelection::extentOffset):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * page/Frame.cpp:
              (WebCore::Frame::selectionLayoutChanged):
              * page/mac/AccessibilityObjectWrapper.mm:
              (textMarkerForVisiblePosition):
              (visiblePositionForTextMarker):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::indexForVisiblePosition):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e32ebc3
    • eric@webkit.org's avatar
      Reviewed by Oliver Hunt. · 1fce1e2a
      eric@webkit.org authored
              Re-write image-clipped-hit.svg to be dumpAsText() (and clean up the code to be less insane)
      
              * platform/mac/svg/custom/image-clipped-hit-expected.checksum: Removed.
              * platform/mac/svg/custom/image-clipped-hit-expected.png: Removed.
              * platform/mac/svg/custom/image-clipped-hit-expected.txt: Removed.
              * platform/qt/svg/custom/image-clipped-hit-expected.txt: Removed.
              * svg/custom/image-clipped-hit.svg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fce1e2a
    • kov@webkit.org's avatar
      2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · d13b5cc6
      kov@webkit.org authored
              Second try at making the bot green.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d13b5cc6
    • mitz@apple.com's avatar
      WebCore: · 1f71fe22
      mitz@apple.com authored
      2009-04-29  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=24168
              RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
      
              Test: editing/selection/home-end.html
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
              to logicalEndOfLine() when granularity is LineBoundary.
              (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
              to logicalEndOfLine() when granularity is LineBoundary
              (WebCore::SelectionController::modifyExtendingBackward): Change calling 
              startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
              (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine() 
              to logicalStartOfLine() when granularity is LineBoundary.
              * editing/visible_units.cpp:
              (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
              (WebCore::getLogicalStartBoxAndNode): Added.
              (WebCore::getLogicalEndBoxAndNode): Added.
              (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
              (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
              (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
              (WebCore::inSameLogicalLine): Added.
              (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
              * editing/visible_units.h:
      
      LayoutTests:
      
      2009-04-29  Xiaomei Ji  <xji@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=24168
              RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
      
              * editing/selection/extend-selection-expected.txt: Added result for extend in
              lineBoundary.
              * editing/selection/extend-selection.html: Added test cases and script for extend
              in lineBoundary.
              * editing/selection/home-end-expected.txt: Added.
              * editing/selection/home-end.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f71fe22
    • ojan@chromium.org's avatar
      2009-04-29 Ojan Vafai <ojan@chromium.org> · 2e677e28
      ojan@chromium.org authored
              Reviewed by NOBODY (OOPS!).
      
              Fix this test to only use a setTimeout in IE.
              It doesn't need a timeout in WebKit and the
              timeout requires using waitUntilDone/notifyDone,
              which doesn't play nicely with JS tests.
      
              See https://bugs.webkit.org/show_bug.cgi?id=25471
      
              * fast/forms/resources/textarea-metrics.js:
              (assertTextareaMetrics):
              * fast/forms/textarea-metrics-expected.txt:
              * platform/win/fast/forms/textarea-metrics-expected.txt:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e677e28
    • ojan@chromium.org's avatar
      Ojan Vafai <ojan@chromium.org> · 46a08657
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              Put this file in the right place to fix the bot failure.
      
              * platform/mac-tiger/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/platform/mac-tiger/text-control-intrinsic-widths-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46a08657
    • ojan@chromium.org's avatar
      2009-04-29 Ojan Vafai <ojan@chromium.org> · fdf95055
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              Skip fast/forms/textarea-metrics.html. It's printing the TEST PASSED
              before the test is finished. There's a race with any JS tests that
              use setTimeout. Fortunately, this test doesn't need the setTimeout,
              so it's easy to fix.
      
              See https://bugs.webkit.org/show_bug.cgi?id=25471
      
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdf95055
    • eric@webkit.org's avatar
      2009-04-29 Eric Seidel <eric@webkit.org> · 037bfe8f
      eric@webkit.org authored
              No review, rolling out a patch.
      
              Revert http://trac.webkit.org/changeset/43019
      
              New tests failed because I removed the tabs from them
              when landing (since we avoid tabs in WebKit files).
              I couldn't tell if the new results were correct with
              spaces or not.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingForward):
              (WebCore::SelectionController::modifyMovingForward):
              (WebCore::SelectionController::modifyExtendingBackward):
              (WebCore::SelectionController::modifyMovingBackward):
              * editing/visible_units.cpp:
              * editing/visible_units.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      037bfe8f
    • eric@webkit.org's avatar
      2009-04-29 Eric Seidel <eric@webkit.org> · 3f436f73
      eric@webkit.org authored
              No review, rolling out a patch.
      
              Revert 43020 as it caused accessibility/lists.html to fail
              and no one is around to tell me if it's a progression or not.
      
              * page/AccessibilityObject.h:
              (WebCore::):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::roleValue):
              (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
              * page/mac/AccessibilityObjectWrapper.mm:
              (RoleEntry::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f436f73
    • hyatt@apple.com's avatar
      2009-04-29 David Hyatt <hyatt@apple.com> · 3f7e9f82
      hyatt@apple.com authored
              Reviewed by Dan Bernstein.
      
              Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
              when the FrameView is resized.  This bug was exposed by the elimination of the separate WebKit layout
              flag on Mac.  
              
              FrameView now defers setNeedsLayouts during size changes.  Once all of the size changes are finished (including re-entrant ones
              from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::FrameView):
              (WebCore::FrameView::setContentsSize):
              (WebCore::FrameView::layout):
              (WebCore::FrameView::needsLayout):
              (WebCore::FrameView::setNeedsLayout):
              * page/FrameView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f7e9f82
    • hyatt@apple.com's avatar
      2009-04-29 David Hyatt <hyatt@apple.com> · 75adf9ae
      hyatt@apple.com authored
              Reviewed by Dan Bernstein.
      
              Fix a bug in the bounds checking for setNeedsLayout dirtying when a WebView's size changes.  The superview
              of the WebView was being incorrectly checked instead of the WebView itself.
      
              * WebView/WebView.mm:
              (-[WebView _boundsChanged]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75adf9ae
    • ojan@chromium.org's avatar
      Fix ChangeLog description. · dcb1eadf
      ojan@chromium.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcb1eadf
    • ojan@chromium.org's avatar
      2009-04-29 Ojan Vafai <ojan@chromium.org> · 432b1749
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              Add expected results for failing tests.
      
              * platform/win/fast/forms/textarea-metrics-expected.txt:
              Issue with running JS tests that use setTimeout.
              See https://bugs.webkit.org/show_bug.cgi?id=25469
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      432b1749
    • eric@webkit.org's avatar
      2009-04-29 Antony Sargent <asargent@chromium.org> · 0ca159c9
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov and Eric Seidel.
      
              Use AtomicString to speed up window and document interceptors.
              https://bugs.webkit.org/show_bug.cgi?id=25275
      
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::NAMED_PROPERTY_GETTER):
              * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
              (WebCore::NAMED_PROPERTY_DELETER):
              (WebCore::NAMED_PROPERTY_GETTER):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ca159c9
    • mrowe@apple.com's avatar
      Update build.webkit.org configuration for the addition of the new GTK buildbot. · c0e64465
      mrowe@apple.com authored
      * BuildSlaveSupport/build.webkit.org-config/config.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0e64465
    • eric@webkit.org's avatar
      2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com> · f10f5478
      eric@webkit.org authored
              Reviewed by Jon Honeycutt.
      
              Add a new accessibility role for list items. Part of
              http://bugs.webkit.org/show_id.cgi?id=20013
      
              * win/AccessibleBase.cpp:
              (MSAARole): Return ROLE_SYSTEM_LISTITEM for list item role.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f10f5478
    • eric@webkit.org's avatar
      2009-04-29 Xiaomei Ji <xji@chromium.org> · 78c1356a
      eric@webkit.org authored
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=24168
              RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
      
              Test: editing/selection/home-end.html
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
              to logicalEndOfLine() when granularity is LineBoundary.
              (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
              to logicalEndOfLine() when granularity is LineBoundary
              (WebCore::SelectionController::modifyExtendingBackward): Change calling
              startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
              (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
              to logicalStartOfLine() when granularity is LineBoundary.
              * editing/visible_units.cpp:
              (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
              (WebCore::getLogicalStartBoxAndNode): Added.
              (WebCore::getLogicalEndBoxAndNode): Added.
              (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
              (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
              (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
              (WebCore::inSameLogicalLine): Added.
              (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
              * editing/visible_units.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78c1356a
    • eric@webkit.org's avatar
      2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com> · 839d810c
      eric@webkit.org authored
              Reviewed by Adele Peterson.
      
              https://bugs.webkit.org/show_bug.cgi?id=23583
              Populate role attribute for document objects correctly
              on Windows platform.
      
              * AccessibleDocument.cpp:
              (AccessibleDocument::role): Return ROLE_SYSTEM_DOCUMENT for
              document objects on windows. (Matching Firefox).
              * AccessibleDocument.h: Add the role function prototype in
              header file.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      839d810c
    • mrowe@apple.com's avatar
      Ignore the --use-remote-links-to-tests option for GTK as it leads to · a75f2ccb
      mrowe@apple.com authored
      perl errors being spewed at the end of run-webkit-tests.
      
      * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a75f2ccb
    • mrowe@apple.com's avatar
      Implement test-result-archive for GTK. · bab89d18
      mrowe@apple.com authored
      * BuildSlaveSupport/test-result-archive:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bab89d18
    • eric@webkit.org's avatar
      2009-03-27 Benjamin C Meyer <benjamin.meyer@torchmobile.com> · 03750e16
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Update the page actions when a finishing loading even if the frame is
              not the top frame such as when browsing inside of a website with frames.
              https://bugs.webkit.org/show_bug.cgi?id=24890
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
              * tests/qwebpage/frametest/frame_a.html: Added.
              * tests/qwebpage/frametest/index.html: Added.
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::backActionUpdate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03750e16
    • eric@webkit.org's avatar
      2009-04-29 Mike Belshe <mike@belshe.com> · 75431e71
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Update location while page is loading.
              https://bugs.webkit.org/show_bug.cgi?id=21597
      
              Tested by:
              - fast/dom/location-new-window-no-crash
              - fast/dom/Window/window-open-pending-url
      
              * page/Location.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75431e71
    • kov@webkit.org's avatar
      2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 52f001f1
      kov@webkit.org authored
              Rubber-stamped by Mark Rowe.
      
              Disable failing tests to make the bot green for its new debut, so
              that we can more easily track regressions.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52f001f1
    • eric@webkit.org's avatar
      2009-04-29 Feng Qian <feng@chromium.org> · b3352b18
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Add Android port files to WebCore/platform.
              https://bugs.webkit.org/show_bug.cgi?id=23296
      
              * platform/android: Added.
              * platform/android/ClipboardAndroid.cpp: Added.
              * platform/android/ClipboardAndroid.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3352b18
    • eric@webkit.org's avatar
      2009-04-29 Feng Qian <feng@chromium.org> · b571ff84
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Add Android-specific files to the WebCore/page directory.
              https://bugs.webkit.org/show_bug.cgi?id=23295
      
              * page/android: Added.
              * page/android/DragControllerAndroid.cpp: Added.
              * page/android/EventHandlerAndroid.cpp: Added.
              * page/android/InspectorControllerAndroid.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b571ff84
    • eric@webkit.org's avatar
      2009-04-29 Pavel Feldman <pfeldman@chromium.org> · 8142c31c
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Extract PageGroupLoadDeferrer from Chrome.cpp
      
              * GNUmakefile.am: added PageGroupLoadDeferrer
              * WebCore.pro: ditto
              * WebCore.scons: ditto
              * WebCore.vcproj/WebCore.vcproj: ditto
              * WebCore.xcodeproj/project.pbxproj: ditto
              * WebCoreSources.bkl: ditto
              * page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
              * page/PageGroupLoadDeferrer.cpp: Added.
              (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
              (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
              * page/PageGroupLoadDeferrer.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8142c31c
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlson. · 3945607a
      kdecker@apple.com authored
              Allow WKN_CheckIfAllowedToLoadURL() to take an optional void* context parameter.
              
              * Plugins/WebNetscapeContainerCheckContextInfo.h:
              * Plugins/WebNetscapeContainerCheckContextInfo.mm:
              (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
              (-[WebNetscapeContainerCheckContextInfo callback]):
              (-[WebNetscapeContainerCheckContextInfo context]):
              * Plugins/WebNetscapeContainerCheckPrivate.h:
              * Plugins/WebNetscapeContainerCheckPrivate.mm:
              (browserContainerCheckFuncs):
              * Plugins/WebNetscapePluginView.h:
              * Plugins/WebNetscapePluginView.mm:
              (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
              (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
              * Plugins/npapi.mm:
              (WKN_CheckIfAllowedToLoadURL):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3945607a
    • eric@webkit.org's avatar
      2009-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 9690cb4e
      eric@webkit.org authored
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=25334
      
              Fix Qt build when ENABLE_JIT is explicitly set to 1
              to overrule defaults.
      
              * JavaScriptCore.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9690cb4e
    • ojan@chromium.org's avatar
      Reviewed by Dan Bernstein. · 149606a8
      ojan@chromium.org authored
              Make textarea and text input metrics more closely match IEs.
      
              This involves:
              -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
              -set textarea width to cols*avgCharWidth
              -Make default CSS match IEs
              -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
      
              Those values for textarea and inputs were derived by doing a ton of manual
              testing of IE's width values for various textareas and fonts. On Windows we match
              IE exactly except for a couple fonts of the ~12 tested.
      
              To get the average and max character width of a font, we do the following
              for each platform:
              -Win: TextMetrics expose avgCharWidth and maxCharWidth
              -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
                  maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
              -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
                  maxCharWidth = max of avgCharWidth and m_ascent
              -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
                  If either one is non-positive, then calculate the value using the Linux approach.
      
              Tests: fast/forms/text-control-intrinsic-widths.html
                     fast/forms/textarea-metrics.html
                     svg/custom/svg-fonts-in-text-controls.html
      
              * css/html4.css:
              * css/themeWin.css:
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData):
              (WebCore::SimpleFontData::initCharWidths):
              * platform/graphics/SimpleFontData.h:
              (WebCore::SimpleFontData::maxCharWidth):
              (WebCore::SimpleFontData::avgCharWidth):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataGtk.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataPango.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::initGDIFont):
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::calcPrefWidths):
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      149606a8
    • oliver@apple.com's avatar
      Crash in profiler due to incorrect assuming displayName would be a string. · b9e6943b
      oliver@apple.com authored
      Reviewed by Steve Falkenburg
      
      Fixed by adding a type guard.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9e6943b
    • beidson@apple.com's avatar
      2009-04-29 Brady Eidson <beidson@apple.com> · 21ad71b7
      beidson@apple.com authored
              Reviewed by Darin Adler.
      
              * bindings/objc/DOMCSS.mm:
              (kitClass):  Added CSS_INITIAL to the switch statement, and changed to use the WebCore
                type and not the binding type.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21ad71b7
    • eric@webkit.org's avatar
      2009-04-29 John Abd-El-Malek <jam@google.com> · 0c85a7c8
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Reverted my previous change to add resetChromiumPluginCache().
              https://bugs.webkit.org/show_bug.cgi?id=25318
      
              * plugins/chromium/PluginDataChromium.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c85a7c8
    • beidson@apple.com's avatar
      2009-04-29 Brady Eidson <beidson@apple.com> · 2be522ca
      beidson@apple.com authored
              Reviewed by Darin Adler
      
              <rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail
      
              Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>
      
              Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::subresource): Remove the preload referenced check.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2be522ca
    • eric@webkit.org's avatar
      2009-04-29 Alpha Lam <hclam@chromium.org> · e0b7c0eb
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              https://bugs.webkit.org/show_bug.cgi?id=25430
      
              Provide style sheet for UI controls of media elements for Chromium port.
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0b7c0eb
    • eric@webkit.org's avatar
      2009-04-29 John Abd-El-Malek <jam@chromium.org> · 0baa1ed7
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Expose sudden termination to Chromium port.
              https://bugs.webkit.org/show_bug.cgi?id=25457
      
              * platform/SuddenTermination.h:
              * platform/chromium/ChromiumBridge.h:
              * platform/chromium/SuddenTerminationChromium.cpp: Added.
              (WebCore::disableSuddenTermination):
              (WebCore::enableSuddenTermination):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0baa1ed7
    • weinig@apple.com's avatar
      2009-04-29 Sam Weinig <sam@webkit.org> · 3fb735be
      weinig@apple.com authored
              Reviewed by Dimitri Glazkov.
      
              Remove unused EventListeners.
      
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fb735be
    • hyatt@apple.com's avatar
      2009-04-29 David Hyatt <hyatt@apple.com> · a9520545
      hyatt@apple.com authored
              Reviewed by John Sullivan.
      
              Fix for <rdar://problem/6835573>, Find Banner turns invisible when WebView is resized.  Make sure
              not to resize the interior views of a WebView in response to its bounds changing when not using
              viewless WebKit.  Auto-resizing rules were already in place to handle size adjustments for us.
              Just mark as needing layout and do nothing else.
      
              This does mean viewless WebKit is broken with the Find Banner, and that will likely require a
              Safari change (using a new API that will enable clients to define the edges of the content area as offsets
              from the sides of the WebView).
      
              * WebView/WebView.mm:
              (-[WebView _boundsChanged]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9520545
    • eric.carlson@apple.com's avatar
      2009-04-29 Eric Carlson <eric.carlson@apple.com> · efd3ba32
      eric.carlson@apple.com authored
              Disable media/video-zoom-controls.html on Windows for now.
      
              * platform/win/Skipped: add media/video-zoom-controls.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efd3ba32
    • timothy@apple.com's avatar
      Reveal current execution line once SourceFrame content is loaded. · b34156f9
      timothy@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=25448
      
              Reviewed by Timothy Hatcher.
      
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._loaded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b34156f9