GitLab

        - Fixed <rdar://problem/4378159> crash in KWQKHTMLPart::userGestureHint
        from javascript enabled/disabled inconsistency when pasting webpage 
        into email or blot

        * page/Frame.cpp:
        (Frame::userGestureHint): Check root frame's jScript() for NULL instead
        of checking inner frame's jScript().
        
        After init() has been called on a frame, but before begin() has been 
        called, the frame can have JavaScript enabled when its parent doesn't.
        (That seems wrong, so I've filed <rdar://problem/4426499> Child frame 
        momentarily has JavaScript enabled even though parent frame doesn't.)
        
        Regardless, it's better programming practice to NULL check the actual 
        pointer you're going to use, so that's what I've done here.

        * manual-tests/paste-crash.html: Added.
        (No automated test because the crash depends on JavaScript being
        disabled.)



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        KWQCheckIfReloading at http://www.inquisitorx.com/beta/


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix for <rdar://problem/4298052> Crash in KWQCheckIfReloading at 
        http://www.inquisitorx.com/beta/

        It is possible for the DocLoader's frame to be nil when the 
        DocLoader is not nil, so we need nil checks.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Add #import "KWQFontMetrics.h" to fix no-svg build.

        * kwq/KWQPainter.mm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - updated test result for rect changes

        * fast/box-sizing/percentage-height-expected.txt: A bunch of strange empty
        clip rects are now dumping as (0,0) 0x0.

WebCore:

        Reviewed by Eric.

        - cleanup of Int/Float-Size/Point/Rect classes

        I did this as part of a redo of QMatrix, but I decided I should
        land this part separately.

        Eliminated the concept of a null rect or point, which used to be
        indicated by negative width and height.

        Changed right and bottom to to be, e.g., 2 for a rect at (0,0) 2x2.
        The old code followed Qt's system that says right is 1 in those cases,
        which is inappropriate for floating point, and old fashioned because
        modern graphics systems use coordinates for lines between pixels, not
        the pixels themselves.

        Other API improvements to the point, size, and rect classes. For example,
        functions named with verbs now always modify the object itself.

        * rendering/render_theme_mac.mm: (RenderThemeMac::paintButton): Fixed
        a bug where it said x() where it should say y().

        * bridge/mac/MacFrame.h:
        * bridge/mac/MacFrame.mm:
        * bridge/mac/WebCoreFrameBridge.mm:
        * kcanvas/KCanvasContainer.cpp:
        * kcanvas/KCanvasItem.cpp:
        * kcanvas/RenderSVGImage.cpp:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        * khtml/ecma/kjs_dom.cpp:
        * khtml/ecma/kjs_window.cpp:
        * khtml/editing/SelectionController.cpp:
        * khtml/html/html_inlineimpl.cpp:
        * khtml/html/html_objectimpl.cpp:
        * khtml/html/html_objectimpl.h:
        * khtml/misc/khtmllayout.h:
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        * kwq/KWQAccObject.mm:
        * kwq/KWQComboBox.mm:
        * kwq/KWQFileButton.mm:
        * kwq/KWQFontMetrics.mm:
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        * kwq/KWQRegion.cpp:
        * kwq/KWQRenderTreeDebug.cpp:
        * kwq/KWQScrollView.mm:
        * kwq/KWQWMatrix.cpp:
        * kwq/KWQWidget.h:
        * kwq/KWQWidget.mm:
        * kwq/KWQWindowWidget.mm:
        * loader/CachedImage.cpp:
        * page/Frame.cpp:
        * page/FrameView.cpp:
        * platform/FloatPoint.cpp:
        * platform/FloatPoint.h:
        * platform/FloatRect.cpp:
        * platform/FloatRect.h:
        * platform/FloatSize.cpp:
        * platform/FloatSize.h:
        * platform/Image.h:
        * platform/IntPoint.cpp:
        * platform/IntPoint.h:
        * platform/IntPointArray.cpp:
        * platform/IntPointArray.h:
        * platform/IntRect.cpp:
        * platform/IntRect.h:
        * platform/IntSize.cpp:
        * platform/IntSize.h:
        * platform/mac/FloatPoint.mm:
        * platform/mac/FloatRect.mm:
        * platform/mac/FloatSize.mm:
        * platform/mac/Image.mm:
        * platform/mac/IntPoint.mm:
        * platform/mac/IntRect.mm:
        * platform/mac/IntSize.mm:
        * platform/mac/Screen.mm:
        * rendering/InlineTextBox.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        * rendering/RenderTable.cpp:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderText.cpp:
        * rendering/render_box.cpp:
        * rendering/render_canvas.cpp:
        * rendering/render_canvasimage.cpp:
        * rendering/render_flow.cpp:
        * rendering/render_form.cpp:
        * rendering/render_frames.cpp:
        * rendering/render_layer.cpp:
        * rendering/render_line.cpp:
        * rendering/render_list.cpp:
        * rendering/render_object.cpp:
        * rendering/render_object.h:
        * rendering/render_replaced.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - Remove QSortedList and QPtrList sorting support
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6929

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/device/KRenderingPaintServerGradient.cpp:
        (operator<<): Implement for Vector<KCGradientStop>
        (KRenderingPaintServerGradient::gradientStops): Use a Vector, not a subclass of
        QPtrList that sorts on every insert
        (compareStopOffset): Comparison function for sorting.
        (KRenderingPaintServerGradient::setGradientStops): Add a version that takes a Vector which sorts,
        and another which knows how to copy from another gradient paint server.
        * kcanvas/device/KRenderingPaintServerGradient.h:
        (makeGradientStop): Make a gradient stop pair.
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): use delete
        on stops cache
        (KRenderingPaintServerGradientQuartz::updateQuartzGradientStopsCache): adapt to Vector
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
        * khtml/editing/visible_text.cpp:
        (khtml::compareBoxStart): Comparison function for sorting.
        (khtml::TextIterator::handleTextNode): Use Vector and std::sort instead of QSortedList
        for sorting. Keep current position as an index.
        (khtml::TextIterator::handleTextBox): Adapt for Vector use.
        * khtml/editing/visible_text.h:
        * ksvg2/svg/SVGGradientElementImpl.cpp:
        (SVGGradientElementImpl::rebuildStops): Use a Vector. Instead of modifying the existing one,
        make a fresh one and assign it.
        * ksvg2/svg/SVGLinearGradientElementImpl.cpp:
        (SVGLinearGradientElementImpl::buildGradient): don't copy item by item, just assign directly.
        * ksvg2/svg/SVGRadialGradientElementImpl.cpp:
        (SVGRadialGradientElementImpl::buildGradient): ditto
        * ksvg2/svg/SVGStopElementImpl.h:
        * kwq/KWQListImpl.cpp:
        * kwq/KWQPtrList.h:
        (QPtrList::sort): Removed.
        * kwq/KWQSortedList.h: Removed.
        * rendering/InlineTextBox.h: Remove now unneeded operator< and operator=



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - killed more KWQ, KWinModule and QVariant

        * ForwardingHeaders/kwinmodule.h: Removed.
        * ForwardingHeaders/qvariant.h: Removed.

        * kwq/KWQKWinModule.h: Removed.
        * kwq/KWQKWinModule.mm: Removed.
        * kwq/KWQVariant.cpp: Removed.
        * kwq/KWQVariant.h: Removed.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removal.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_binding.cpp: Remove QVariant stuff.

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        * khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
        * khtml/ecma/kjs_proxy.h:
        * khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate):
        * page/Frame.h:
        * page/Frame.cpp:
        (getString):
        (Frame::replaceContentsWithScriptResult):
        (Frame::executeScript):
        (Frame::executeScheduledScript):
        (Frame::changeLocation):
        (Frame::urlSelected):
        (Frame::submitForm):
        Changed to use JSValue instead of QVariant for result of executing JavaScript.

        * kwq/KWQObject.h: Removed a bunch of unneeded includes and forward declarations.

        * bridge/mac/MacFrame.mm:
        * khtml/ecma/kjs_window.h:
        * khtml/ecma/kjs_window.cpp:
        * khtml/html/html_inlineimpl.cpp:
        * khtml/html/htmltokenizer.cpp:
        * khtml/xml/DocumentImpl.cpp:
        * khtml/xml/NodeImpl.cpp:
        * khtml/xml/dom2_eventsimpl.cpp:
        * khtml/xml/xml_tokenizer.cpp:
        * kwq/KWQComboBox.mm:
        * kwq/KWQFileButton.mm:
        * kwq/KWQListBox.mm:
        * kwq/KWQObject.cpp:
        * kwq/KWQSlider.mm:
        * kwq/KWQTextArea.mm:
        * kwq/KWQTextField.mm:
        * loader/CachedImage.h:
        * page/FrameView.h:
        * page/FrameView.cpp:
        * rendering/render_form.cpp:
        Updated includes, since KWQObject.h now includes less.
        Also updated callers to executeScript since one overload was removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        
        - properly define Vector assignment operator; the private version was accidentally left
        in, and the template version is not enough to replace the default

        * kxmlcore/Vector.h:
        (KXMLCore::Vector::operator=):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by darin.

        Added back #include <qvaluelist.h> to fix WIN32 build.

        * rendering/render_style.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - fixed just-introduced crash dragging images

        I don't know how to make a layout test for this.

        * kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): Fixed crash on
        dragging by initializing m_dragImage to 0.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6923
          remove more of KWQ, including the screen functions from QDesktopWidget

        * kwq/KWQApplication.h: Removed.
        * kwq/KWQApplication.mm: Removed.
        * kwq/KWQGlobal.cpp: Removed.
        * kwq/KWQKPartsEvent.cpp: Removed.
        * kwq/KWQKPartsEvent.h: Removed.
        * kwq/KWQPair.h: Removed.
        * kwq/KWQStyle.cpp: Removed.
        * kwq/KWQStyle.h: Removed.

        * ForwardingHeaders/kparts/event.h: Removed.
        * ForwardingHeaders/qapplication.h: Removed.
        * ForwardingHeaders/qstyle.h: Removed.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * platform/Screen.h: Added. Replaces the desktop widget stuff in KWQApplication.mm.
        * platform/mac/Screen.mm: Added.

        * kwq/KWQDef.h: Removed everything except for kMin and kMax from here.
        We should port to std::min and std::max, and then we can get rid of this
        header altogether.

        * kwq/KWQKCursor.h: Removed setAutoHideCursor.
        * kwq/KWQKCursor.mm: Ditto.

        * kwq/KWQWidget.h: Removed style() and setStyle() functions.
        * kwq/KWQWidget.mm: Ditto.

        * khtml/ecma/kjs_window.h:
        * khtml/ecma/kjs_window.cpp:
        (KJS::Screen::Screen): Store a pointer to the Frame.
        (KJS::Screen::getValueProperty): Port to use the new Screen.h functions.
        (KJS::showModalDialog): Ditto.
        (KJS::Window::getValueProperty): Ditto.
        (KJS::WindowFunc::callAsFunction): Ditto.

        * khtml/khtml_events.h:
        * khtml/khtml_events.cpp: Removed much of the code here.
        This can be cut down even more.

        * khtml/misc/khtmllayout.h: Removed unused stuff and updated for KWQ changes.

        * kwq/KWQCString.cpp:
        * kwq/KWQKURL.mm:
        * kwq/KWQPainter.mm:
        * kwq/KWQRegExp.cpp:
        * kwq/KWQRenderTreeDebug.cpp:
        * kwq/KWQString.h:
        * kwq/KWQString.mm:
        * kwq/KWQTextCodec.cpp:
        * WebCore+SVG/KDOMSettings.cpp:
        * bridge/mac/MacFrame.mm:
        * bridge/mac/WebCoreFrameBridge.mm:
        * css/cssparser.cpp:
        * kcanvas/KCanvasItem.cpp:
        * khtml/ecma/kjs_navigator.cpp:
        * khtml/html/HTMLSelectElementImpl.cpp:
        * khtml/html/html_tableimpl.h:
        * khtml/html/htmltokenizer.cpp:
        * khtml/misc/decoder.cpp:
        * ksvg2/css/KSVGCSSParser.cpp:
        * ksvg2/css/SVGRenderStyle.h:
        * page/Frame.h:
        * page/Frame.cpp:
        * page/FrameView.cpp:
        * platform/IntPointArray.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderTable.cpp:
        * rendering/bidi.cpp:
        * rendering/bidi.h:
        * rendering/render_form.cpp:
        * rendering/render_object.cpp:
        * rendering/render_object.h:
        * rendering/render_replaced.cpp:
        * rendering/render_style.h:
        * rendering/table_layout.cpp:
        Updated for above KWQ changes. Changed tabs to spaces.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by darin.

        Fix the build by applying a GCC-specific namespace hack.

        * kjs/lookup.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by hyatt.

        Fix build for Win32.

        * WebCore.vcproj/WebCore/WebCore.vcproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by hyatt.

        Fix build on Win32.

        * kjs/lookup.h: fixed ::cacheGlobalObject
        * kxmlcore/Vector.h:
        (KXMLCore::Vector::operator[]): use unsigned long



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix for bug 6910, don't let Image be assignable or copiable.  It will soon represent  the actual
        original Image (including the data) and as such must remain unique.

        Reviewed by darin

        * kcanvas/KCanvasFilters.cpp:
        (KCanvasFEImage::~KCanvasFEImage):
        (KCanvasFEImage::setCachedImage):
        * kcanvas/KCanvasFilters.h:
        (KCanvasFEImage::KCanvasFEImage):
        (KCanvasFEImage::cachedImage):
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFEImageQuartz::getCIFilter):
        * khtml/ecma/kjs_events.cpp:
        (KJS::ClipboardProtoFunc::callAsFunction):
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::Context2DFunction::callAsFunction):
        (KJS::drawPattern):
        (KJS::_rh):
        (KJS::ImagePattern::~ImagePattern):
        (KJS::ImagePattern::createPattern):
        * khtml/ecma/kjs_html.h:
        (KJS::ImagePattern::cachedImage):
        * khtml/html/html_imageimpl.h:
        (WebCore::HTMLImageElementImpl::cachedImage):
        * khtml/xml/dom2_eventsimpl.h:
        * ksvg2/svg/SVGCursorElementImpl.cpp:
        (SVGCursorElementImpl::~SVGCursorElementImpl):
        (SVGCursorElementImpl::parseMappedAttribute):
        * ksvg2/svg/SVGCursorElementImpl.h:
        (KSVG::SVGCursorElementImpl::cachedImage):
        * ksvg2/svg/SVGFEImageElementImpl.cpp:
        (SVGFEImageElementImpl::~SVGFEImageElementImpl):
        (SVGFEImageElementImpl::parseMappedAttribute):
        (SVGFEImageElementImpl::notifyFinished):
        * kwq/KWQClipboard.h:
        * kwq/KWQClipboard.mm:
        (WebCore::KWQClipboard::dragImage):
        (WebCore::KWQClipboard::setDragImage):
        (WebCore::KWQClipboard::setDragImageElement):
        (WebCore::KWQClipboard::imageChanged):
        (WebCore::KWQClipboard::dragNSImage):
        * platform/Image.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6914
          REGRESSION: fast/block/basic/014.html crashes Safari

        * rendering/render_image.h:
        (WebCore::RenderImage::image): Return a null image when m_cachedImage is 0.
        (WebCore::RenderImage::errorOccurred): Return false when m_cachedImage is 0.
        * rendering/render_image.cpp: (WebCore::RenderImage::nullImage): Added.
        Returns a global null image for use when we have no cached image.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6919
          REGRESSION: Background images don't paint when they are finished loading

        * rendering/render_object.h: Renamed the old setImage to imageChanged, the
        new name for the same function.
        * rendering/render_object.cpp: (WebCore::RenderObject::imageChanged): Ditto.
        * rendering/render_list.cpp: (RenderListMarker::imageChanged): Changed the
        call to parent to call the new imageChanged instead of the old setImage.

        - fixed something else that was causing some layout test crashes

        * kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Rearrange so we won't
        ever dereference a null pointer here.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - fixed some tests that were missing test images

        * fast/replaced/resources/sample.gif: Added.
        * fast/replaced/resources/1x1-green.png: Added.
        * fast/replaced/resources/1x1-red.png: Added.

        * fast/replaced/001.html: Changed images to point to actual images.
        * fast/replaced/002.html: Ditto.
        * fast/replaced/003.html: Ditto.
        * fast/replaced/004.html: Ditto.

        * fast/replaced/002-expected.txt: Updated.
        * fast/replaced/003-expected.txt: Updated.

        * fast/replaced/001-expected.png: Updated.
        * fast/replaced/001-expected.checksum: Updated.
        * fast/replaced/002-expected.png: Updated.
        * fast/replaced/002-expected.checksum: Updated.
        * fast/replaced/003-expected.png: Updated.
        * fast/replaced/003-expected.checksum: Updated.
        * fast/replaced/004-expected.png: Updated.
        * fast/replaced/004-expected.checksum: Updated.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - replace QValueVector and QPtrVector use with Vector, and remove them.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6909

        * ForwardingHeaders/q3valuevector.h: Removed.
        * ForwardingHeaders/qptrvector.h: Removed.
        * ForwardingHeaders/qvector.h: Removed.
        * WebCore+SVG/KDOMSettings.cpp:
        (KDOMSettings::init):
        (KDOMSettings::isAdFiltered):
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge elementWithName:inForm:]):
        (-[WebCoreFrameBridge controlsInForm:]):
        * css/cssstyleselector.h:
        * khtml/html/HTMLCollectionImpl.cpp:
        (WebCore::HTMLCollectionImpl::updateNameCache):
        (WebCore::HTMLCollectionImpl::namedItems):
        * khtml/html/HTMLCollectionImpl.h:
        * khtml/html/HTMLFormCollectionImpl.cpp:
        (WebCore::HTMLFormCollectionImpl::HTMLFormCollectionImpl):
        (WebCore::HTMLFormCollectionImpl::calcLength):
        (WebCore::HTMLFormCollectionImpl::item):
        (WebCore::HTMLFormCollectionImpl::getNamedFormItem):
        (WebCore::HTMLFormCollectionImpl::updateNameCache):
        * khtml/html/HTMLFormElementImpl.cpp:
        (WebCore::HTMLFormElementImpl::~HTMLFormElementImpl):
        (WebCore::HTMLFormElementImpl::length):
        (WebCore::HTMLFormElementImpl::submitClick):
        (WebCore::HTMLFormElementImpl::formData):
        (WebCore::HTMLFormElementImpl::submit):
        (WebCore::HTMLFormElementImpl::reset):
        (WebCore::insertIntoVector):
        (WebCore::removeFromVector):
        (WebCore::HTMLFormElementImpl::formElementIndex):
        (WebCore::HTMLFormElementImpl::registerImgElement):
        * khtml/html/HTMLFormElementImpl.h:
        * ksvg2/svg/SVGTextElementImpl.cpp:
        * kwq/KWQComboBox.h:
        * kwq/KWQListBox.h:
        * kwq/KWQPtrVector.h: Removed.
        * kwq/KWQRenderTreeDebug.cpp:
        (writeLayers):
        * kwq/KWQValueVector.h: Removed.
        * kwq/KWQVectorImpl.cpp: Removed.
        * kwq/KWQVectorImpl.h: Removed.
        * loader/loader.cpp:
        (WebCore::Loader::cancelRequests):
        * rendering/render_layer.cpp:
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::compareZIndex):
        (WebCore::RenderLayer::updateZOrderLists):
        (WebCore::RenderLayer::collectLayers):
        * rendering/render_layer.h:
        (khtml::RenderLayer::posZOrderList):
        (khtml::RenderLayer::negZOrderList):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6888
          Collapsed borders appear on the wrong side or on the wrong cell in RTL tables

        * fast/table/border-collapsing/rtl-border-collapsing.html: Added.
        * fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Added.
        * fast/table/border-collapsing/rtl-border-collapsing-expected.checksum: Added.
        * fast/table/border-collapsing/rtl-border-collapsing-expected.png: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6888
          Collapsed borders appear on the wrong side or on the wrong cell in RTL tables

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::cellBefore): Renamed cellLeft to this.
        (WebCore::RenderTable::cellAfter): Renamed cellRight to this.
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::collapsedLeftBorder): Added the RTL case.
        (WebCore::RenderTableCell::collapsedRightBorder): Ditto.
        (WebCore::RenderTableCell::borderLeft):
        (WebCore::RenderTableCell::borderRight):
        (WebCore::RenderTableCell::collectBorders):
        (WebCore::RenderTableCell::paintCollapsedBorder):
        * rendering/RenderTableCell.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6550
          REGRESSION: window.open('myurl', '_self') fails to load myurl in current window

        * fast/dom/Window/window-open-parent.html: Added.
        * fast/dom/Window/window-open-parent-no-parent.html: Added.
        * fast/dom/Window/window-open-self.html: Added.
        * fast/dom/Window/window-open-top.html: Added.

        * fast/dom/Window/resources: Added.
        * fast/dom/Window/resources/destination.html: Added.
        * fast/dom/Window/window-open-parent-expected.txt: Added.
        * fast/dom/Window/window-open-parent-no-parent-expected.txt: Added.
        * fast/dom/Window/window-open-self-expected.txt: Added.
        * fast/dom/Window/window-open-top-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6550
          REGRESSION: window.open('myurl', '_self') fails to load myurl in current window

        Tests:
        * fast/dom/Window/window-open-parent-no-parent.html: Added.
        * fast/dom/Window/window-open-parent.html: Added.
        * fast/dom/Window/window-open-self.html: Added.
        * fast/dom/Window/window-open-top.html: Added.

        * khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
        Fix check for special frame names. These special frame names are supposed
        to always be unaffected by pop-up blocking. But the code instead was
        saying that the special frame names are always blocked. Oops!



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

          in my last commit until I made the fix Alexey suggested

        * fast/dom/Range: Added.
        * fast/dom/Range/range-exceptions.html: Added.
        * fast/dom/Range/resources: Added.
        * fast/dom/Range/resources/range-exceptions.js: Added.
        * fast/dom/Range/resources/TEMPLATE.html: Added.

        * fast/js/resources/js-test-pre.js: Escape & and < characters in the
        output so you can have tests with HTML fragments as expected results.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - fixed something Alexey noticed in the new exception names

        Test: fast/dom/Range/range-exceptions.html

        * khtml/ecma/kjs_binding.cpp: Added 0 to fix an off-by-one error for the
        names of the two DOM range exceptions.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        1) Arrowing up or down to an empty list item skipped the list item
        2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

        * editing/selection/move-by-line-002-expected.png: Added.
        * editing/selection/move-by-line-002-expected.checksum: Added.
        * editing/selection/move-by-line-002-expected.txt: Added.
        * editing/selection/move-by-line-002.html: Added.
        * editing/deleting/delete-listitem-002-expected.checksum: Added.
        * editing/deleting/delete-listitem-002-expected.png: Added.
        * editing/deleting/delete-listitem-002-expected.txt: Added.
        * editing/deleting/delete-listitem-002.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix two problems with editing around empty list items:
        1) Arrowing up or down to an empty list item skipped the list item
        2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

        Added tests:
        * selection/move-by-line-002.html
        * deleting/delete-listitem-002.html
        
        * khtml/editing/composite_edit_command.cpp:
        (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
        - special check for empty list item because list marker assures non-zero height()
        
        * khtml/xml/dom_position.cpp:
        (DOM::Position::inRenderedContent):
        - fix check wrt BRs because text box is not required
        
        * rendering/bidi.cpp:
        (khtml::RenderBlock::constructLine):
        - make sure that br by itself in a list item gets a text-style box
        
        (khtml::RenderBlock::findNextLineBreak):
        - make sure that br by itself in a list item gets a box at all



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by hyatt & darin.

        There are a few small, but intertwined fixes in this patch:

        Remaining fixes for SVGTetris:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

        Testing blocked by: http://bugzilla.opendarwin.org/show_bug.cgi?id=6905

        Fix for CDF support:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6025

        Updated test: svg/custom/simpleCDF.xml

        Fix for filter updating:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6849

        Testing blocked by: http://bugzilla.opendarwin.org/show_bug.cgi?id=6904

        Also, as a side effect of 6849, fixed double-apply of filters, improving:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6713

        Results updated for most tests, pixel results improved for filter tests.

        * kcanvas/KCanvasFilters.cpp:
        (KCanvasFilter::filterBBoxForItemBBox): moved into baseclass
        * kcanvas/KCanvasFilters.h:
        * kcanvas/RenderSVGImage.cpp:
        (RenderSVGImage::paint): use relativeBBox
        (RenderSVGImage::relativeBBox): added
        (RenderSVGImage::imageChanged): added
        (RenderSVGImage::getAbsoluteRepaintRect): fixed
        * kcanvas/RenderSVGImage.h:
        (KSVG::RenderSVGImage::imageChanged): added.
        * kcanvas/device/quartz/KCanvasFilterQuartz.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFilterQuartz::applyFilter): use new baseclass method
        (KCanvasFEFloodQuartz::getCIFilter): fixed.
        * kcanvas/device/quartz/KCanvasItemQuartz.h:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (KCanvasItemQuartz::layout): update width/height
        (KCanvasItemQuartz::getAbsoluteRepaintRect): fixed.
        (KCanvasItemQuartz::requiresLayer): moved to .cpp
        (KCanvasItemQuartz::lineHeight): added.
        (KCanvasItemQuartz::baselinePosition): added.
        * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        (KCanvasContainerQuartz::canHaveChildren): moved to .cpp
        (KCanvasContainerQuartz::requiresLayer): moved to .cpp
        (KCanvasContainerQuartz::lineHeight): added.
        (KCanvasContainerQuartz::baselinePosition): added.
        (KCanvasContainerQuartz::paint): fixed.
        (KCanvasContainerQuartz::viewportTransform): fixed.
        (KCanvasContainerQuartz::getAbsoluteRepaintRect): fixed.
        (KCanvasContainerQuartz::absoluteTransform): fixed.
        * rendering/render_object.cpp:
        (WebCore::RenderObject::absoluteTransform): fixed apply order.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * kxmlcore/Vector.h:
        (KXMLCore::Vector::operator[]): Add unsigned overload



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by hyatt.

        First set of fixes for SVG Tetris:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

        Tests:
        * svg/custom/viewport-update.svg
        Key press test not yet possible:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6906

        * bridge/mac/MacFrame.mm:
        (MacFrame::keyEvent): pass key events to things other than HTML
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        (WebCore::SVGSVGElementImpl::parseMappedAttribute): update viewport


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Somehow this file was missed in the last commit. Since it's just a delete, do it without a new ChangeLog entry.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

          include exception names in JavaScript form of DOM exception

        * dom/xhtml/level1/core/hc_nodevalue03-expected.txt:
        * dom/xhtml/level3/core/canonicalform06-expected.txt:
        * dom/xhtml/level3/core/documentgetdoctype01-expected.txt:
        * dom/xhtml/level3/core/infoset06-expected.txt:
        * dom/xhtml/level3/core/infoset07-expected.txt:
        * dom/xhtml/level3/core/nodecomparedocumentposition02-expected.txt:
        * dom/xhtml/level3/core/nodeinsertbefore02-expected.txt:
        * dom/xhtml/level3/core/nodeinsertbefore05-expected.txt:
        * dom/xhtml/level3/core/nodeisequalnode17-expected.txt:
        * dom/xhtml/level3/core/noderemovechild04-expected.txt:
        * dom/xhtml/level3/core/noderemovechild05-expected.txt:
        * dom/xhtml/level3/core/nodereplacechild13-expected.txt:
        * dom/xhtml/level3/core/wellformed01-expected.txt:
        * dom/xhtml/level3/core/wellformed02-expected.txt:
        * dom/xhtml/level3/core/wellformed03-expected.txt:
        * dom/xhtml/level3/core/wellformed04-expected.txt:

        - for these, also changed the tests to be dumpAsText at the same time

        * fast/dom/outerText-no-element.html:
        * fast/dom/outerText-no-element-expected.txt:
        * fast/dynamic/outerHTML-no-element.html:
        * fast/dynamic/outerHTML-no-element-expected.txt:

        * fast/dom/outerText-no-element-expected.checksum: Removed.
        * fast/dom/outerText-no-element-expected.png: Removed.
        * fast/dynamic/outerHTML-no-element-expected.checksum: Removed.
        * fast/dynamic/outerHTML-no-element-expected.png: Removed.

        - removed test results for tests that are either disabled or not checked in

        * dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: Removed.
        * dom/xhtml/level3/core/documentadoptnode22-expected.txt: Removed.
        * editing/execCommand/boldCharacter-expected.txt: Removed.
        * fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
        * fast/parser/remove-block-in-residual-style-expected.png: Removed.
        * fast/parser/remove-block-in-residual-style-expected.txt: Removed.
        * fast/plugins: Removed.
        * fast/plugins/netscape-back-forward-expected.txt: Removed.
        * fast/plugins/resources: Removed.
        * fast/plugins/resources/go-back.html: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by mjs.

        Fix SVG layout tests crash due to Vector change.

        * kcanvas/device/KRenderingDevice.cpp:
        (KRenderingDevice::currentContext): check isEmpty, return 0


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by mjs.

        Remove bogus IntRect operator.

        * platform/FloatRect.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Cleanup of RenderImage.  Eliminate unneeded members and methods.

        Reviewed by darin

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge elementAtPoint:]):
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::Context2DFunction::callAsFunction):
        (KJS::drawPattern):
        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::attach):
        * khtml/html/html_imageimpl.cpp:
        (WebCore::HTMLImageLoader::notifyFinished):
        (WebCore::HTMLImageElementImpl::attach):
        * khtml/html/html_imageimpl.h:
        (WebCore::HTMLImageElementImpl::compositeOperator):
        * khtml/html/html_objectimpl.cpp:
        (WebCore::HTMLObjectElementImpl::attach):
        * ksvg2/svg/SVGImageElementImpl.cpp:
        (SVGImageElementImpl::attach):
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (WebCore::QPainter::drawImageAtPoint):
        (WebCore::QPainter::drawImageInRect):
        (WebCore::QPainter::drawImage):
        (WebCore::QPainter::drawFloatImage):
        (WebCore::QPainter::drawTiledImage):
        (WebCore::QPainter::drawScaledAndTiledImage):
        * kwq/WebCoreImageRenderer.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::ref):
        (WebCore::CachedImage::notifyObservers):
        (WebCore::CachedImage::data):
        (WebCore::CachedImage::error):
        * loader/CachedImage.h:
        * loader/CachedObjectClient.h:
        (WebCore::CachedObjectClient::imageChanged):
        * platform/Image.h:
        (WebCore::Image::):
        * platform/mac/Image.mm:
        (WebCore::Image::Image):
        (WebCore::Image::resetAnimation):
        (WebCore::Image::operator=):
        (WebCore::Image::stopAnimations):
        (WebCore::):
        (WebCore::Image::compositeOperatorFromString):
        * rendering/render_box.cpp:
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/render_canvasimage.cpp:
        (WebCore::RenderCanvasImage::paint):
        * rendering/render_image.cpp:
        (WebCore::RenderImage::RenderImage):
        (WebCore::RenderImage::~RenderImage):
        (WebCore::RenderImage::setContentObject):
        (WebCore::RenderImage::setCachedImage):
        (WebCore::RenderImage::imageChanged):
        (WebCore::RenderImage::resetAnimation):
        (WebCore::RenderImage::paint):
        (WebCore::RenderImage::layout):
        (WebCore::RenderImage::updateAltText):
        (WebCore::RenderImage::calcReplacedWidth):
        (WebCore::RenderImage::calcReplacedHeight):
        * rendering/render_image.h:
        (WebCore::RenderImage::cachedImage):
        (WebCore::RenderImage::image):
        (WebCore::RenderImage::errorOccurred):
        * rendering/render_list.cpp:
        (RenderListMarker::paint):
        (RenderListMarker::imageChanged):
        * rendering/render_list.h:
        * rendering/render_object.cpp:
        (WebCore::RenderObject::paintBorderImage):
        (WebCore::RenderObject::setImage):
        * rendering/render_object.h:

WebKit:

        Clean up RenderImage, eliminating unneeded members and methods.
	
        Reviewed by darin

        * WebCoreSupport.subproj/WebImageRenderer.h:
        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer copyWithZone:]):
        (-[WebImageRenderer size]):
        (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6870
          REGRESSION: JavaScript Date constructor won't accept another Date object

        * fast/js/date-constructor.html: Added.
        * fast/js/date-constructor-expected.txt: Added.
        * fast/js/resources/date-constructor.js: Added.

        * fast/js/resources/date-big-constructor.js: Formatting tweak.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6895
          include exception names in JavaScript form of DOM exception

        * khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the
        exception in the error message.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6711
          crash if an event is dispatched to a listener that uses handleEvent

        * fast/events/dispatch-to-handle-event.html: Added.
        * fast/events/dispatch-to-handle-event-expected.txt: Added.

WebCore:

        Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6711
          crash if an event is dispatched to a listener that uses handleEvent

        Test: fast/events/dispatch-to-handle-event.html

        * khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
        Remove boolean that is always false, and correct the one place that was
        checking it to check the correct pointer instead.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - remove QPtrStack, replace with Vector or traverseNextNode as appropriate

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/device/KRenderingDevice.cpp:
        (KRenderingDevice::currentContext):
        (KRenderingDevice::popContext):
        (KRenderingDevice::pushContext):
        * kcanvas/device/KRenderingDevice.h:
        * khtml/html/html_documentimpl.cpp:
        * khtml/xml/DocumentImpl.cpp:
        * khtml/xml/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject addChildrenToArray:]):
        * kwq/KWQPainter.mm:
        (WebCore::QPainter::save):
        (WebCore::QPainter::restore):
        * kwq/KWQPtrStack.h: Removed.
        * ForwardingHeaders/qptrstack.h: Removed.
        * ForwardingHeaders/q3ptrstack.h: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        
        - miscellaneous Vector improvements

        * kxmlcore/Vector.h:
        (KXMLCore::Vector::at): Add range-checking asserts.
        (KXMLCore::Vector::first): Added as a convenience.
        (KXMLCore::Vector::last): Convenience for stack-style use.
        (KXMLCore::Vector::removeLast): ditto



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        
        * ForwardingHeaders/kxmlcore/Vector.h: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12441 268f45cc-cd09-0410-ab3c-d52691b4dbfc