1. 15 Feb, 2011 1 commit
    • tkent@chromium.org's avatar
      [Chromium] Rendering error of spin buttons on layers · eb14de0a
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=54427
      
      Reviewed by Darin Fisher.
      
      Source/WebCore:
      
      Test: fast/forms/input-appearance-spinbutton-layer.html
      
      * rendering/RenderThemeChromiumWin.cpp:
        Add checks for multiple ThemePainter instances.
      (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
        Avoid to create multiple ThemePainter instances.
      
      LayoutTests:
      
      * fast/forms/input-appearance-spinbutton-layer.html: Added.
      * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
      * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
      * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb14de0a
  2. 02 Feb, 2011 1 commit
    • dglazkov@chromium.org's avatar
      2011-02-02 Dimitri Glazkov <dglazkov@chromium.org> · 1543444a
      dglazkov@chromium.org authored
              Update more references to right() and bottom() in Chromium Win.
      
              * platform/graphics/chromium/TransparencyWin.cpp:
              (WebCore::TransparencyWin::compositeOpaqueComposite): Replaced bottom/right with maxY/maxX.
              (WebCore::TransparencyWin::compositeTextComposite): Ditto.
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintMenuList): Ditto.
      2011-02-02  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Update more references to right() and bottom() in Chromium Win.
      
              * tests/TransparencyWinTest.cpp:
              (WebCore::TEST): Replaced bottom/right with maxY/maxX.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1543444a
  3. 21 Jan, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-01-21 Adam Klein <adamk@chromium.org> · 4ceaac17
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [chromium] Rename ChromiumBridge to PlatformBridge
              https://bugs.webkit.org/show_bug.cgi?id=52471
      
              No tests added as this is a rename; no change in behavior.
      
              * WebCore.gypi:
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::reportFatalErrorInV8):
              * page/PageGroup.cpp:
              (WebCore::PageGroup::isLinkVisited):
              * platform/android/PlatformBridge.h:
              * platform/audio/chromium/AudioBusChromium.cpp:
              (WebCore::createBusFromInMemoryAudioFile):
              * platform/chromium/ChromiumBridge.h: Removed.
              * platform/chromium/ChromiumDataObjectLegacy.cpp:
              (WebCore::ChromiumDataObjectLegacy::getData):
              * platform/chromium/DragDataChromium.cpp:
              (WebCore::DragData::asURL):
              * platform/chromium/FileSystemChromium.cpp:
              (WebCore::deleteFile):
              (WebCore::deleteEmptyDirectory):
              (WebCore::getFileSize):
              (WebCore::getFileModificationTime):
              (WebCore::revealFolderInOS):
              (WebCore::directoryName):
              (WebCore::pathByAppendingComponent):
              (WebCore::makeAllDirectories):
              (WebCore::fileExists):
              (WebCore::openFile):
              (WebCore::closeFile):
              (WebCore::seekFile):
              (WebCore::truncateFile):
              (WebCore::readFromFile):
              (WebCore::writeToFile):
              * platform/chromium/LanguageChromium.cpp:
              (WebCore::platformDefaultLanguage):
              * platform/chromium/LinkHashChromium.cpp:
              (WebCore::visitedLinkHash):
              * platform/chromium/MIMETypeRegistryChromium.cpp:
              (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
              (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
              * platform/chromium/PasteboardChromium.cpp:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writePlainText):
              (WebCore::Pasteboard::writeURL):
              (WebCore::Pasteboard::writeImage):
              (WebCore::Pasteboard::canSmartReplace):
              (WebCore::Pasteboard::plainText):
              (WebCore::Pasteboard::documentFragment):
              * platform/chromium/PlatformBridge.h:
              * platform/chromium/PlatformScreenChromium.cpp:
              (WebCore::screenDepth):
              (WebCore::screenDepthPerComponent):
              (WebCore::screenIsMonochrome):
              (WebCore::screenRect):
              (WebCore::screenAvailableRect):
              * platform/chromium/ReadableDataObject.cpp:
              (WebCore::ReadableDataObject::getData):
              (WebCore::ReadableDataObject::urlTitle):
              (WebCore::ReadableDataObject::htmlBaseUrl):
              (WebCore::ReadableDataObject::filenames):
              (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
              * platform/chromium/SSLKeyGeneratorChromium.cpp:
              (WebCore::signedPublicKeyAndChallengeString):
              * platform/chromium/ScrollbarThemeChromium.cpp:
              * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
              (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumLinux::paintButton):
              (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
              (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
              (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
              * platform/chromium/ScrollbarThemeChromiumMac.mm:
              (WebCore::scrollbarStateToThemeState):
              (WebCore::ScrollbarThemeChromiumMac::paint):
              * platform/chromium/ScrollbarThemeChromiumWin.cpp:
              (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumWin::paintButton):
              (WebCore::ScrollbarThemeChromiumWin::paintThumb):
              (WebCore::ScrollbarThemeChromiumWin::buttonSize):
              * platform/chromium/SharedTimerChromium.cpp:
              (WebCore::setSharedTimerFiredFunction):
              (WebCore::setSharedTimerFireTime):
              (WebCore::stopSharedTimer):
              * platform/chromium/SuddenTerminationChromium.cpp:
              (WebCore::disableSuddenTermination):
              (WebCore::enableSuddenTermination):
              * platform/chromium/SystemTimeChromium.cpp:
              (WebCore::currentTime):
              * platform/chromium/WritableDataObject.cpp:
              (WebCore::WritableDataObject::setData):
              * platform/graphics/chromium/CrossProcessFontLoading.mm:
              * platform/graphics/chromium/FontCacheChromiumWin.cpp:
              (WebCore::fontContainsCharacter):
              (WebCore::FillLogFont):
              * platform/graphics/chromium/FontCacheLinux.cpp:
              (WebCore::FontCache::getFontDataForCharacters):
              * platform/graphics/chromium/FontChromiumWin.cpp:
              (WebCore::Font::drawGlyphs):
              * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
              (WebCore::FontPlatformData::scriptFontProperties):
              * platform/graphics/chromium/FontPlatformDataLinux.cpp:
              (WebCore::FontPlatformData::querySystemForRenderStyle):
              * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
              (WebCore::fillBMPGlyphs):
              * platform/graphics/chromium/ImageChromium.cpp:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/ImageChromiumMac.mm:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::determinePitch):
              (WebCore::SimpleFontData::platformWidthForGlyph):
              * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
              (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
              * platform/graphics/skia/FontCustomPlatformData.cpp:
              (WebCore::FontCustomPlatformData::fontPlatformData):
              * platform/network/chromium/CookieJarChromium.cpp:
              (WebCore::setCookies):
              (WebCore::cookies):
              (WebCore::cookieRequestHeaderFieldValue):
              (WebCore::cookiesEnabled):
              (WebCore::getRawCookies):
              (WebCore::deleteCookie):
              * platform/network/chromium/DNSChromium.cpp:
              (WebCore::prefetchDNS):
              * platform/qt/PlatformBridge.h:
              * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
              (WebCore::SQLiteFileSystem::deleteDatabaseFile):
              (WebCore::SQLiteFileSystem::getDatabaseFileSize):
              * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
              (chromiumOpen):
              (chromiumDelete):
              (chromiumAccess):
              * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
              * plugins/chromium/PluginDataChromium.cpp:
              (WebCore::PluginCache::plugins):
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
              (WebCore::RenderThemeChromiumWin::systemColor):
              (WebCore::RenderThemeChromiumWin::paintButton):
              (WebCore::RenderThemeChromiumWin::paintSliderTrack):
              (WebCore::menuListButtonWidth):
              (WebCore::RenderThemeChromiumWin::paintMenuList):
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
              * storage/chromium/IDBFactoryBackendInterface.cpp:
              (WebCore::IDBFactoryBackendInterface::create):
              (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
              * storage/chromium/IDBKeyPathBackendImpl.cpp:
              (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
      2011-01-21  Adam Klein  <adamk@chromium.org>
      
              Reviewed by Eric Seidel.
      
              [chromium] Rename ChromiumBridge to PlatformBridge
              https://bugs.webkit.org/show_bug.cgi?id=52471
      
              * WebKit.gyp:
              * src/AssertMatchingEnums.cpp:
              * src/PlatformBridge.cpp:
              (WebCore::toChromeClientImpl):
              (WebCore::toWebWidgetClient):
              (WebCore::getCookieJar):
              (WebCore::PlatformBridge::cacheMetadata):
              (WebCore::PlatformBridge::clipboardIsFormatAvailable):
              (WebCore::PlatformBridge::clipboardReadPlainText):
              (WebCore::PlatformBridge::clipboardReadHTML):
              (WebCore::PlatformBridge::clipboardWriteSelection):
              (WebCore::PlatformBridge::clipboardWritePlainText):
              (WebCore::PlatformBridge::clipboardWriteURL):
              (WebCore::PlatformBridge::clipboardWriteImage):
              (WebCore::PlatformBridge::clipboardWriteData):
              (WebCore::PlatformBridge::clipboardReadAvailableTypes):
              (WebCore::PlatformBridge::clipboardReadData):
              (WebCore::PlatformBridge::clipboardReadFilenames):
              (WebCore::PlatformBridge::setCookies):
              (WebCore::PlatformBridge::cookies):
              (WebCore::PlatformBridge::cookieRequestHeaderFieldValue):
              (WebCore::PlatformBridge::rawCookies):
              (WebCore::PlatformBridge::deleteCookie):
              (WebCore::PlatformBridge::cookiesEnabled):
              (WebCore::PlatformBridge::prefetchDNS):
              (WebCore::PlatformBridge::fileExists):
              (WebCore::PlatformBridge::deleteFile):
              (WebCore::PlatformBridge::deleteEmptyDirectory):
              (WebCore::PlatformBridge::getFileSize):
              (WebCore::PlatformBridge::revealFolderInOS):
              (WebCore::PlatformBridge::getFileModificationTime):
              (WebCore::PlatformBridge::directoryName):
              (WebCore::PlatformBridge::pathByAppendingComponent):
              (WebCore::PlatformBridge::makeAllDirectories):
              (WebCore::PlatformBridge::getAbsolutePath):
              (WebCore::PlatformBridge::isDirectory):
              (WebCore::PlatformBridge::filePathToURL):
              (WebCore::PlatformBridge::openFile):
              (WebCore::PlatformBridge::closeFile):
              (WebCore::PlatformBridge::seekFile):
              (WebCore::PlatformBridge::truncateFile):
              (WebCore::PlatformBridge::readFromFile):
              (WebCore::PlatformBridge::writeToFile):
              (WebCore::PlatformBridge::ensureFontLoaded):
              (WebCore::PlatformBridge::getFontFamilyForCharacters):
              (WebCore::PlatformBridge::getRenderStyleForStrike):
              (WebCore::PlatformBridge::loadFont):
              (WebCore::PlatformBridge::databaseOpenFile):
              (WebCore::PlatformBridge::databaseDeleteFile):
              (WebCore::PlatformBridge::databaseGetFileAttributes):
              (WebCore::PlatformBridge::databaseGetFileSize):
              (WebCore::PlatformBridge::idbFactory):
              (WebCore::PlatformBridge::idbShutdown):
              (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
              (WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
              (WebCore::PlatformBridge::computedDefaultLanguage):
              (WebCore::PlatformBridge::layoutTestMode):
              (WebCore::PlatformBridge::isSupportedImageMIMEType):
              (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
              (WebCore::PlatformBridge::isSupportedNonImageMIMEType):
              (WebCore::PlatformBridge::mimeTypeForExtension):
              (WebCore::PlatformBridge::mimeTypeFromFile):
              (WebCore::PlatformBridge::preferredExtensionForMIMEType):
              (WebCore::PlatformBridge::plugins):
              (WebCore::PlatformBridge::pluginScriptableObject):
              (WebCore::PlatformBridge::loadPlatformImageResource):
              (WebCore::PlatformBridge::loadPlatformAudioResource):
              (WebCore::PlatformBridge::decodeAudioFileData):
              (WebCore::PlatformBridge::sandboxEnabled):
              (WebCore::PlatformBridge::setSharedTimerFiredFunction):
              (WebCore::PlatformBridge::setSharedTimerFireTime):
              (WebCore::PlatformBridge::stopSharedTimer):
              (WebCore::PlatformBridge::decrementStatsCounter):
              (WebCore::PlatformBridge::incrementStatsCounter):
              (WebCore::PlatformBridge::histogramCustomCounts):
              (WebCore::PlatformBridge::histogramEnumeration):
              (WebCore::PlatformBridge::suddenTerminationChanged):
              (WebCore::PlatformBridge::currentTime):
              (WebCore::PlatformBridge::paintButton):
              (WebCore::PlatformBridge::paintMenuList):
              (WebCore::PlatformBridge::paintScrollbarArrow):
              (WebCore::PlatformBridge::paintScrollbarThumb):
              (WebCore::PlatformBridge::paintScrollbarTrack):
              (WebCore::PlatformBridge::paintSpinButton):
              (WebCore::PlatformBridge::paintTextField):
              (WebCore::PlatformBridge::paintTrackbar):
              (WebCore::PlatformBridge::paintProgressBar):
              (WebCore::WebThemePart):
              (WebCore::WebThemeState):
              (WebCore::GetWebThemeExtraParams):
              (WebCore::PlatformBridge::getThemePartSize):
              (WebCore::PlatformBridge::paintThemePart):
              (WebCore::PlatformBridge::traceEventBegin):
              (WebCore::PlatformBridge::traceEventEnd):
              (WebCore::PlatformBridge::visitedLinkHash):
              (WebCore::PlatformBridge::isLinkVisited):
              (WebCore::PlatformBridge::notifyJSOutOfMemory):
              (WebCore::PlatformBridge::memoryUsageMB):
              (WebCore::PlatformBridge::actualMemoryUsageMB):
              (WebCore::PlatformBridge::screenDepth):
              (WebCore::PlatformBridge::screenDepthPerComponent):
              (WebCore::PlatformBridge::screenIsMonochrome):
              (WebCore::PlatformBridge::screenRect):
              (WebCore::PlatformBridge::screenAvailableRect):
              (WebCore::PlatformBridge::popupsAllowed):
              (WebCore::WorkerContextProxy::create):
              * src/ResourceHandle.cpp:
              (WebCore::ResourceHandle::cacheMetadata):
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::WebFrameImpl):
              (WebKit::WebFrameImpl::~WebFrameImpl):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ceaac17
  4. 19 Jan, 2011 2 commits
    • dimich@chromium.org's avatar
      2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com> · d95c3038
      dimich@chromium.org authored
              Unreviewed, rolling out r76203.
              http://trac.webkit.org/changeset/76203
              https://bugs.webkit.org/show_bug.cgi?id=52784
      
              Broke Win compile on Chromium bots (Requested by dimich on
              #webkit).
      
              * WebCore.gypi:
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::reportFatalErrorInV8):
              * page/PageGroup.cpp:
              (WebCore::PageGroup::isLinkVisited):
              * platform/android/PlatformBridge.h:
              * platform/audio/chromium/AudioBusChromium.cpp:
              (WebCore::createBusFromInMemoryAudioFile):
              * platform/chromium/ChromiumBridge.h: Added.
              * platform/chromium/ChromiumDataObjectLegacy.cpp:
              (WebCore::ChromiumDataObjectLegacy::getData):
              * platform/chromium/DragDataChromium.cpp:
              (WebCore::DragData::asURL):
              * platform/chromium/FileSystemChromium.cpp:
              (WebCore::deleteFile):
              (WebCore::deleteEmptyDirectory):
              (WebCore::getFileSize):
              (WebCore::getFileModificationTime):
              (WebCore::revealFolderInOS):
              (WebCore::directoryName):
              (WebCore::pathByAppendingComponent):
              (WebCore::makeAllDirectories):
              (WebCore::fileExists):
              (WebCore::openFile):
              (WebCore::closeFile):
              (WebCore::seekFile):
              (WebCore::truncateFile):
              (WebCore::readFromFile):
              (WebCore::writeToFile):
              * platform/chromium/LanguageChromium.cpp:
              (WebCore::platformDefaultLanguage):
              * platform/chromium/LinkHashChromium.cpp:
              (WebCore::visitedLinkHash):
              * platform/chromium/MIMETypeRegistryChromium.cpp:
              (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
              (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
              * platform/chromium/PasteboardChromium.cpp:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writePlainText):
              (WebCore::Pasteboard::writeURL):
              (WebCore::Pasteboard::writeImage):
              (WebCore::Pasteboard::canSmartReplace):
              (WebCore::Pasteboard::plainText):
              (WebCore::Pasteboard::documentFragment):
              * platform/chromium/PlatformBridge.h:
              * platform/chromium/PlatformScreenChromium.cpp:
              (WebCore::screenDepth):
              (WebCore::screenDepthPerComponent):
              (WebCore::screenIsMonochrome):
              (WebCore::screenRect):
              (WebCore::screenAvailableRect):
              * platform/chromium/ReadableDataObject.cpp:
              (WebCore::ReadableDataObject::getData):
              (WebCore::ReadableDataObject::urlTitle):
              (WebCore::ReadableDataObject::htmlBaseUrl):
              (WebCore::ReadableDataObject::filenames):
              (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
              * platform/chromium/SSLKeyGeneratorChromium.cpp:
              (WebCore::signedPublicKeyAndChallengeString):
              * platform/chromium/ScrollbarThemeChromium.cpp:
              * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
              (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumLinux::paintButton):
              (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
              (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
              (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
              * platform/chromium/ScrollbarThemeChromiumMac.mm:
              (WebCore::scrollbarStateToThemeState):
              (WebCore::ScrollbarThemeChromiumMac::paint):
              * platform/chromium/ScrollbarThemeChromiumWin.cpp:
              (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumWin::paintButton):
              (WebCore::ScrollbarThemeChromiumWin::paintThumb):
              (WebCore::ScrollbarThemeChromiumWin::buttonSize):
              * platform/chromium/SharedTimerChromium.cpp:
              (WebCore::setSharedTimerFiredFunction):
              (WebCore::setSharedTimerFireTime):
              (WebCore::stopSharedTimer):
              * platform/chromium/SuddenTerminationChromium.cpp:
              (WebCore::disableSuddenTermination):
              (WebCore::enableSuddenTermination):
              * platform/chromium/SystemTimeChromium.cpp:
              (WebCore::currentTime):
              * platform/chromium/WritableDataObject.cpp:
              (WebCore::WritableDataObject::setData):
              * platform/graphics/chromium/CrossProcessFontLoading.mm:
              * platform/graphics/chromium/FontCacheChromiumWin.cpp:
              (WebCore::fontContainsCharacter):
              (WebCore::FillLogFont):
              * platform/graphics/chromium/FontCacheLinux.cpp:
              (WebCore::FontCache::getFontDataForCharacters):
              * platform/graphics/chromium/FontChromiumWin.cpp:
              (WebCore::Font::drawGlyphs):
              * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
              (WebCore::FontPlatformData::scriptFontProperties):
              * platform/graphics/chromium/FontPlatformDataLinux.cpp:
              (WebCore::FontPlatformData::querySystemForRenderStyle):
              * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
              (WebCore::fillBMPGlyphs):
              * platform/graphics/chromium/ImageChromium.cpp:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/ImageChromiumMac.mm:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::determinePitch):
              (WebCore::SimpleFontData::platformWidthForGlyph):
              * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
              (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
              * platform/graphics/skia/FontCustomPlatformData.cpp:
              (WebCore::FontCustomPlatformData::fontPlatformData):
              * platform/network/chromium/CookieJarChromium.cpp:
              (WebCore::setCookies):
              (WebCore::cookies):
              (WebCore::cookieRequestHeaderFieldValue):
              (WebCore::cookiesEnabled):
              (WebCore::getRawCookies):
              (WebCore::deleteCookie):
              * platform/network/chromium/DNSChromium.cpp:
              (WebCore::prefetchDNS):
              * platform/qt/PlatformBridge.h:
              * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
              (WebCore::SQLiteFileSystem::deleteDatabaseFile):
              (WebCore::SQLiteFileSystem::getDatabaseFileSize):
              * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
              (chromiumOpen):
              (chromiumDelete):
              (chromiumAccess):
              * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
              * plugins/chromium/PluginDataChromium.cpp:
              (WebCore::PluginCache::plugins):
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
              (WebCore::RenderThemeChromiumWin::systemColor):
              (WebCore::RenderThemeChromiumWin::paintButton):
              (WebCore::RenderThemeChromiumWin::paintSliderTrack):
              (WebCore::menuListButtonWidth):
              (WebCore::RenderThemeChromiumWin::paintMenuList):
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
              * storage/chromium/IDBFactoryBackendInterface.cpp:
              (WebCore::IDBFactoryBackendInterface::create):
              (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
              * storage/chromium/IDBKeyPathBackendImpl.cpp:
              (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
      2011-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r76203.
              http://trac.webkit.org/changeset/76203
              https://bugs.webkit.org/show_bug.cgi?id=52784
      
              Broke Win compile on Chromium bots (Requested by dimich on
              #webkit).
      
              * WebKit.gyp:
              * src/AssertMatchingEnums.cpp:
              * src/ChromiumBridge.cpp: Renamed from Source/WebKit/chromium/src/PlatformBridge.cpp.
              (WebCore::toChromeClientImpl):
              (WebCore::toWebWidgetClient):
              (WebCore::getCookieJar):
              (WebCore::ChromiumBridge::cacheMetadata):
              (WebCore::ChromiumBridge::clipboardIsFormatAvailable):
              (WebCore::ChromiumBridge::clipboardReadPlainText):
              (WebCore::ChromiumBridge::clipboardReadHTML):
              (WebCore::ChromiumBridge::clipboardWriteSelection):
              (WebCore::ChromiumBridge::clipboardWritePlainText):
              (WebCore::ChromiumBridge::clipboardWriteURL):
              (WebCore::ChromiumBridge::clipboardWriteImage):
              (WebCore::ChromiumBridge::clipboardWriteData):
              (WebCore::ChromiumBridge::clipboardReadAvailableTypes):
              (WebCore::ChromiumBridge::clipboardReadData):
              (WebCore::ChromiumBridge::clipboardReadFilenames):
              (WebCore::ChromiumBridge::setCookies):
              (WebCore::ChromiumBridge::cookies):
              (WebCore::ChromiumBridge::cookieRequestHeaderFieldValue):
              (WebCore::ChromiumBridge::rawCookies):
              (WebCore::ChromiumBridge::deleteCookie):
              (WebCore::ChromiumBridge::cookiesEnabled):
              (WebCore::ChromiumBridge::prefetchDNS):
              (WebCore::ChromiumBridge::fileExists):
              (WebCore::ChromiumBridge::deleteFile):
              (WebCore::ChromiumBridge::deleteEmptyDirectory):
              (WebCore::ChromiumBridge::getFileSize):
              (WebCore::ChromiumBridge::revealFolderInOS):
              (WebCore::ChromiumBridge::getFileModificationTime):
              (WebCore::ChromiumBridge::directoryName):
              (WebCore::ChromiumBridge::pathByAppendingComponent):
              (WebCore::ChromiumBridge::makeAllDirectories):
              (WebCore::ChromiumBridge::getAbsolutePath):
              (WebCore::ChromiumBridge::isDirectory):
              (WebCore::ChromiumBridge::filePathToURL):
              (WebCore::ChromiumBridge::openFile):
              (WebCore::ChromiumBridge::closeFile):
              (WebCore::ChromiumBridge::seekFile):
              (WebCore::ChromiumBridge::truncateFile):
              (WebCore::ChromiumBridge::readFromFile):
              (WebCore::ChromiumBridge::writeToFile):
              (WebCore::ChromiumBridge::ensureFontLoaded):
              (WebCore::ChromiumBridge::getFontFamilyForCharacters):
              (WebCore::ChromiumBridge::getRenderStyleForStrike):
              (WebCore::ChromiumBridge::loadFont):
              (WebCore::ChromiumBridge::databaseOpenFile):
              (WebCore::ChromiumBridge::databaseDeleteFile):
              (WebCore::ChromiumBridge::databaseGetFileAttributes):
              (WebCore::ChromiumBridge::databaseGetFileSize):
              (WebCore::ChromiumBridge::idbFactory):
              (WebCore::ChromiumBridge::idbShutdown):
              (WebCore::ChromiumBridge::createIDBKeysFromSerializedValuesAndKeyPath):
              (WebCore::ChromiumBridge::signedPublicKeyAndChallengeString):
              (WebCore::ChromiumBridge::computedDefaultLanguage):
              (WebCore::ChromiumBridge::layoutTestMode):
              (WebCore::ChromiumBridge::isSupportedImageMIMEType):
              (WebCore::ChromiumBridge::isSupportedJavaScriptMIMEType):
              (WebCore::ChromiumBridge::isSupportedNonImageMIMEType):
              (WebCore::ChromiumBridge::mimeTypeForExtension):
              (WebCore::ChromiumBridge::mimeTypeFromFile):
              (WebCore::ChromiumBridge::preferredExtensionForMIMEType):
              (WebCore::ChromiumBridge::plugins):
              (WebCore::ChromiumBridge::pluginScriptableObject):
              (WebCore::ChromiumBridge::loadPlatformImageResource):
              (WebCore::ChromiumBridge::loadPlatformAudioResource):
              (WebCore::ChromiumBridge::decodeAudioFileData):
              (WebCore::ChromiumBridge::sandboxEnabled):
              (WebCore::ChromiumBridge::setSharedTimerFiredFunction):
              (WebCore::ChromiumBridge::setSharedTimerFireTime):
              (WebCore::ChromiumBridge::stopSharedTimer):
              (WebCore::ChromiumBridge::decrementStatsCounter):
              (WebCore::ChromiumBridge::incrementStatsCounter):
              (WebCore::ChromiumBridge::histogramCustomCounts):
              (WebCore::ChromiumBridge::histogramEnumeration):
              (WebCore::ChromiumBridge::suddenTerminationChanged):
              (WebCore::ChromiumBridge::currentTime):
              (WebCore::ChromiumBridge::paintButton):
              (WebCore::ChromiumBridge::paintMenuList):
              (WebCore::ChromiumBridge::paintScrollbarArrow):
              (WebCore::ChromiumBridge::paintScrollbarThumb):
              (WebCore::ChromiumBridge::paintScrollbarTrack):
              (WebCore::ChromiumBridge::paintSpinButton):
              (WebCore::ChromiumBridge::paintTextField):
              (WebCore::ChromiumBridge::paintTrackbar):
              (WebCore::ChromiumBridge::paintProgressBar):
              (WebCore::WebThemePart):
              (WebCore::WebThemeState):
              (WebCore::GetWebThemeExtraParams):
              (WebCore::ChromiumBridge::getThemePartSize):
              (WebCore::ChromiumBridge::paintThemePart):
              (WebCore::ChromiumBridge::traceEventBegin):
              (WebCore::ChromiumBridge::traceEventEnd):
              (WebCore::ChromiumBridge::visitedLinkHash):
              (WebCore::ChromiumBridge::isLinkVisited):
              (WebCore::ChromiumBridge::notifyJSOutOfMemory):
              (WebCore::ChromiumBridge::memoryUsageMB):
              (WebCore::ChromiumBridge::actualMemoryUsageMB):
              (WebCore::ChromiumBridge::screenDepth):
              (WebCore::ChromiumBridge::screenDepthPerComponent):
              (WebCore::ChromiumBridge::screenIsMonochrome):
              (WebCore::ChromiumBridge::screenRect):
              (WebCore::ChromiumBridge::screenAvailableRect):
              (WebCore::ChromiumBridge::popupsAllowed):
              (WebCore::WorkerContextProxy::create):
              * src/ResourceHandle.cpp:
              (WebCore::ResourceHandle::cacheMetadata):
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::WebFrameImpl):
              (WebKit::WebFrameImpl::~WebFrameImpl):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d95c3038
    • commit-queue@webkit.org's avatar
      2011-01-19 Adam Klein <adamk@chromium.org> · bd7bcda0
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [chromium] Rename ChromiumBridge to PlatformBridge
              https://bugs.webkit.org/show_bug.cgi?id=52471
      
              No tests added as this is a rename; no change in behavior.
      
              * WebCore.gypi:
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::reportFatalErrorInV8):
              * page/PageGroup.cpp:
              (WebCore::PageGroup::isLinkVisited):
              * platform/android/PlatformBridge.h:
              * platform/audio/chromium/AudioBusChromium.cpp:
              (WebCore::createBusFromInMemoryAudioFile):
              * platform/chromium/ChromiumBridge.h: Removed.
              * platform/chromium/ChromiumDataObjectLegacy.cpp:
              (WebCore::ChromiumDataObjectLegacy::getData):
              * platform/chromium/DragDataChromium.cpp:
              (WebCore::DragData::asURL):
              * platform/chromium/FileSystemChromium.cpp:
              (WebCore::deleteFile):
              (WebCore::deleteEmptyDirectory):
              (WebCore::getFileSize):
              (WebCore::getFileModificationTime):
              (WebCore::revealFolderInOS):
              (WebCore::directoryName):
              (WebCore::pathByAppendingComponent):
              (WebCore::makeAllDirectories):
              (WebCore::fileExists):
              (WebCore::openFile):
              (WebCore::closeFile):
              (WebCore::seekFile):
              (WebCore::truncateFile):
              (WebCore::readFromFile):
              (WebCore::writeToFile):
              * platform/chromium/LanguageChromium.cpp:
              (WebCore::platformDefaultLanguage):
              * platform/chromium/LinkHashChromium.cpp:
              (WebCore::visitedLinkHash):
              * platform/chromium/MIMETypeRegistryChromium.cpp:
              (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
              (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
              * platform/chromium/PasteboardChromium.cpp:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writePlainText):
              (WebCore::Pasteboard::writeURL):
              (WebCore::Pasteboard::writeImage):
              (WebCore::Pasteboard::canSmartReplace):
              (WebCore::Pasteboard::plainText):
              (WebCore::Pasteboard::documentFragment):
              * platform/chromium/PlatformBridge.h:
              * platform/chromium/PlatformScreenChromium.cpp:
              (WebCore::screenDepth):
              (WebCore::screenDepthPerComponent):
              (WebCore::screenIsMonochrome):
              (WebCore::screenRect):
              (WebCore::screenAvailableRect):
              * platform/chromium/ReadableDataObject.cpp:
              (WebCore::ReadableDataObject::getData):
              (WebCore::ReadableDataObject::urlTitle):
              (WebCore::ReadableDataObject::htmlBaseUrl):
              (WebCore::ReadableDataObject::filenames):
              (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
              * platform/chromium/SSLKeyGeneratorChromium.cpp:
              (WebCore::signedPublicKeyAndChallengeString):
              * platform/chromium/ScrollbarThemeChromium.cpp:
              * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
              (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumLinux::paintButton):
              (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
              (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
              (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
              * platform/chromium/ScrollbarThemeChromiumMac.mm:
              (WebCore::scrollbarStateToThemeState):
              (WebCore::ScrollbarThemeChromiumMac::paint):
              * platform/chromium/ScrollbarThemeChromiumWin.cpp:
              (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumWin::paintButton):
              (WebCore::ScrollbarThemeChromiumWin::paintThumb):
              (WebCore::ScrollbarThemeChromiumWin::buttonSize):
              * platform/chromium/SharedTimerChromium.cpp:
              (WebCore::setSharedTimerFiredFunction):
              (WebCore::setSharedTimerFireTime):
              (WebCore::stopSharedTimer):
              * platform/chromium/SuddenTerminationChromium.cpp:
              (WebCore::disableSuddenTermination):
              (WebCore::enableSuddenTermination):
              * platform/chromium/SystemTimeChromium.cpp:
              (WebCore::currentTime):
              * platform/chromium/WritableDataObject.cpp:
              (WebCore::WritableDataObject::setData):
              * platform/graphics/chromium/CrossProcessFontLoading.mm:
              * platform/graphics/chromium/FontCacheChromiumWin.cpp:
              (WebCore::fontContainsCharacter):
              (WebCore::FillLogFont):
              * platform/graphics/chromium/FontCacheLinux.cpp:
              (WebCore::FontCache::getFontDataForCharacters):
              * platform/graphics/chromium/FontChromiumWin.cpp:
              (WebCore::Font::drawGlyphs):
              * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
              (WebCore::FontPlatformData::scriptFontProperties):
              * platform/graphics/chromium/FontPlatformDataLinux.cpp:
              (WebCore::FontPlatformData::querySystemForRenderStyle):
              * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
              (WebCore::fillBMPGlyphs):
              * platform/graphics/chromium/ImageChromium.cpp:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/ImageChromiumMac.mm:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::determinePitch):
              (WebCore::SimpleFontData::platformWidthForGlyph):
              * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
              (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
              * platform/graphics/skia/FontCustomPlatformData.cpp:
              (WebCore::FontCustomPlatformData::fontPlatformData):
              * platform/network/chromium/CookieJarChromium.cpp:
              (WebCore::setCookies):
              (WebCore::cookies):
              (WebCore::cookieRequestHeaderFieldValue):
              (WebCore::cookiesEnabled):
              (WebCore::getRawCookies):
              (WebCore::deleteCookie):
              * platform/network/chromium/DNSChromium.cpp:
              (WebCore::prefetchDNS):
              * platform/qt/PlatformBridge.h:
              * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
              (WebCore::SQLiteFileSystem::deleteDatabaseFile):
              (WebCore::SQLiteFileSystem::getDatabaseFileSize):
              * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
              (chromiumOpen):
              (chromiumDelete):
              (chromiumAccess):
              * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
              * plugins/chromium/PluginDataChromium.cpp:
              (WebCore::PluginCache::plugins):
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
              (WebCore::RenderThemeChromiumWin::systemColor):
              (WebCore::RenderThemeChromiumWin::paintButton):
              (WebCore::RenderThemeChromiumWin::paintSliderTrack):
              (WebCore::menuListButtonWidth):
              (WebCore::RenderThemeChromiumWin::paintMenuList):
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
              * storage/chromium/IDBFactoryBackendInterface.cpp:
              (WebCore::IDBFactoryBackendInterface::create):
              (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
              * storage/chromium/IDBKeyPathBackendImpl.cpp:
              (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
      2011-01-19  Adam Klein  <adamk@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [chromium] Rename ChromiumBridge to PlatformBridge
              https://bugs.webkit.org/show_bug.cgi?id=52471
      
              * WebKit.gyp:
              * src/AssertMatchingEnums.cpp:
              * src/PlatformBridge.cpp:
              (WebCore::toChromeClientImpl):
              (WebCore::toWebWidgetClient):
              (WebCore::getCookieJar):
              (WebCore::PlatformBridge::cacheMetadata):
              (WebCore::PlatformBridge::clipboardIsFormatAvailable):
              (WebCore::PlatformBridge::clipboardReadPlainText):
              (WebCore::PlatformBridge::clipboardReadHTML):
              (WebCore::PlatformBridge::clipboardWriteSelection):
              (WebCore::PlatformBridge::clipboardWritePlainText):
              (WebCore::PlatformBridge::clipboardWriteURL):
              (WebCore::PlatformBridge::clipboardWriteImage):
              (WebCore::PlatformBridge::clipboardWriteData):
              (WebCore::PlatformBridge::clipboardReadAvailableTypes):
              (WebCore::PlatformBridge::clipboardReadData):
              (WebCore::PlatformBridge::clipboardReadFilenames):
              (WebCore::PlatformBridge::setCookies):
              (WebCore::PlatformBridge::cookies):
              (WebCore::PlatformBridge::cookieRequestHeaderFieldValue):
              (WebCore::PlatformBridge::rawCookies):
              (WebCore::PlatformBridge::deleteCookie):
              (WebCore::PlatformBridge::cookiesEnabled):
              (WebCore::PlatformBridge::prefetchDNS):
              (WebCore::PlatformBridge::fileExists):
              (WebCore::PlatformBridge::deleteFile):
              (WebCore::PlatformBridge::deleteEmptyDirectory):
              (WebCore::PlatformBridge::getFileSize):
              (WebCore::PlatformBridge::revealFolderInOS):
              (WebCore::PlatformBridge::getFileModificationTime):
              (WebCore::PlatformBridge::directoryName):
              (WebCore::PlatformBridge::pathByAppendingComponent):
              (WebCore::PlatformBridge::makeAllDirectories):
              (WebCore::PlatformBridge::getAbsolutePath):
              (WebCore::PlatformBridge::isDirectory):
              (WebCore::PlatformBridge::filePathToURL):
              (WebCore::PlatformBridge::openFile):
              (WebCore::PlatformBridge::closeFile):
              (WebCore::PlatformBridge::seekFile):
              (WebCore::PlatformBridge::truncateFile):
              (WebCore::PlatformBridge::readFromFile):
              (WebCore::PlatformBridge::writeToFile):
              (WebCore::PlatformBridge::ensureFontLoaded):
              (WebCore::PlatformBridge::getFontFamilyForCharacters):
              (WebCore::PlatformBridge::getRenderStyleForStrike):
              (WebCore::PlatformBridge::loadFont):
              (WebCore::PlatformBridge::databaseOpenFile):
              (WebCore::PlatformBridge::databaseDeleteFile):
              (WebCore::PlatformBridge::databaseGetFileAttributes):
              (WebCore::PlatformBridge::databaseGetFileSize):
              (WebCore::PlatformBridge::idbFactory):
              (WebCore::PlatformBridge::idbShutdown):
              (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
              (WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
              (WebCore::PlatformBridge::computedDefaultLanguage):
              (WebCore::PlatformBridge::layoutTestMode):
              (WebCore::PlatformBridge::isSupportedImageMIMEType):
              (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
              (WebCore::PlatformBridge::isSupportedNonImageMIMEType):
              (WebCore::PlatformBridge::mimeTypeForExtension):
              (WebCore::PlatformBridge::mimeTypeFromFile):
              (WebCore::PlatformBridge::preferredExtensionForMIMEType):
              (WebCore::PlatformBridge::plugins):
              (WebCore::PlatformBridge::pluginScriptableObject):
              (WebCore::PlatformBridge::loadPlatformImageResource):
              (WebCore::PlatformBridge::loadPlatformAudioResource):
              (WebCore::PlatformBridge::decodeAudioFileData):
              (WebCore::PlatformBridge::sandboxEnabled):
              (WebCore::PlatformBridge::setSharedTimerFiredFunction):
              (WebCore::PlatformBridge::setSharedTimerFireTime):
              (WebCore::PlatformBridge::stopSharedTimer):
              (WebCore::PlatformBridge::decrementStatsCounter):
              (WebCore::PlatformBridge::incrementStatsCounter):
              (WebCore::PlatformBridge::histogramCustomCounts):
              (WebCore::PlatformBridge::histogramEnumeration):
              (WebCore::PlatformBridge::suddenTerminationChanged):
              (WebCore::PlatformBridge::currentTime):
              (WebCore::PlatformBridge::paintButton):
              (WebCore::PlatformBridge::paintMenuList):
              (WebCore::PlatformBridge::paintScrollbarArrow):
              (WebCore::PlatformBridge::paintScrollbarThumb):
              (WebCore::PlatformBridge::paintScrollbarTrack):
              (WebCore::PlatformBridge::paintSpinButton):
              (WebCore::PlatformBridge::paintTextField):
              (WebCore::PlatformBridge::paintTrackbar):
              (WebCore::PlatformBridge::paintProgressBar):
              (WebCore::WebThemePart):
              (WebCore::WebThemeState):
              (WebCore::GetWebThemeExtraParams):
              (WebCore::PlatformBridge::getThemePartSize):
              (WebCore::PlatformBridge::paintThemePart):
              (WebCore::PlatformBridge::traceEventBegin):
              (WebCore::PlatformBridge::traceEventEnd):
              (WebCore::PlatformBridge::visitedLinkHash):
              (WebCore::PlatformBridge::isLinkVisited):
              (WebCore::PlatformBridge::notifyJSOutOfMemory):
              (WebCore::PlatformBridge::memoryUsageMB):
              (WebCore::PlatformBridge::actualMemoryUsageMB):
              (WebCore::PlatformBridge::screenDepth):
              (WebCore::PlatformBridge::screenDepthPerComponent):
              (WebCore::PlatformBridge::screenIsMonochrome):
              (WebCore::PlatformBridge::screenRect):
              (WebCore::PlatformBridge::screenAvailableRect):
              (WebCore::PlatformBridge::popupsAllowed):
              (WebCore::WorkerContextProxy::create):
              * src/ResourceHandle.cpp:
              (WebCore::ResourceHandle::cacheMetadata):
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::WebFrameImpl):
              (WebKit::WebFrameImpl::~WebFrameImpl):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd7bcda0
  5. 18 Jan, 2011 3 commits
    • morrita@google.com's avatar
      2011-01-18 MORITA Hajime <morrita@google.com> · e90fa1a9
      morrita@google.com authored
              Reviewed by Simon Fraser.
      
              Refactoring: Extract RoundedIntRect class
              https://bugs.webkit.org/show_bug.cgi?id=51664
      
              RoundedIntRect is a pair of rect and four IntSize objects which represent
              corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
              Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
              return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
              and other functions accept RoundedIntRect as an argument.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::addRoundedRectClip):
              (WebCore::GraphicsContext::clipOutRoundedRect):
              (WebCore::GraphicsContext::fillRoundedRect):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/RoundedIntRect.cpp: Added.
              (WebCore::RoundedIntRect::Radii::isZero):
              (WebCore::RoundedIntRect::Radii::scale):
              (WebCore::RoundedIntRect::Radii::expand):
              (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
              (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
              (WebCore::RoundedIntRect::RoundedIntRect):
              (WebCore::RoundedIntRect::includeLogicalEdges):
              (WebCore::RoundedIntRect::excludeLogicalEdges):
              * platform/graphics/RoundedIntRect.h: Added.
              (WebCore::RoundedIntRect::Radii::Radii):
              (WebCore::RoundedIntRect::Radii::setTopLeft):
              (WebCore::RoundedIntRect::Radii::setTopRight):
              (WebCore::RoundedIntRect::Radii::setBottomLeft):
              (WebCore::RoundedIntRect::Radii::setBottomRight):
              (WebCore::RoundedIntRect::Radii::topLeft):
              (WebCore::RoundedIntRect::Radii::topRight):
              (WebCore::RoundedIntRect::Radii::bottomLeft):
              (WebCore::RoundedIntRect::Radii::bottomRight):
              (WebCore::RoundedIntRect::Radii::expand):
              (WebCore::RoundedIntRect::Radii::shrink):
              (WebCore::RoundedIntRect::rect):
              (WebCore::RoundedIntRect::radii):
              (WebCore::RoundedIntRect::isRounded):
              (WebCore::RoundedIntRect::isEmpty):
              (WebCore::RoundedIntRect::setRect):
              (WebCore::RoundedIntRect::setRadii):
              (WebCore::RoundedIntRect::move):
              (WebCore::RoundedIntRect::inflate):
              (WebCore::RoundedIntRect::inflateWithRadii):
              (WebCore::RoundedIntRect::expandRadii):
              (WebCore::RoundedIntRect::shrinkRadii):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::pushContentsClip):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              (WebCore::RenderBoxModelObject::paintBorder):
              (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
              (WebCore::RenderBoxModelObject::paintBoxShadow):
              * rendering/RenderBoxModelObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::drawBoxSideFromPath):
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintMenuListButtonGradients):
              (WebCore::RenderThemeMac::paintSliderTrack):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
              (WebCore::RenderThemeSafari::paintSliderTrack):
              * rendering/RenderThemeWinCE.cpp:
              (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint):
              * rendering/style/BorderData.h:
              * rendering/style/RenderStyle.cpp:
              (WebCore::calcRadiiFor):
              (WebCore::calcConstraintScaleFor):
              (WebCore::RenderStyle::getRoundedBorderFor):
              (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::setBorderRadius):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e90fa1a9
    • morrita@google.com's avatar
      2011-01-18 MORITA Hajime <morrita@google.com> · fdba390e
      morrita@google.com authored
              Unreviewed, rolling out r76004, r76005, r76007, and r76011.
              http://trac.webkit.org/changeset/76004
              http://trac.webkit.org/changeset/76005
              http://trac.webkit.org/changeset/76007
              http://trac.webkit.org/changeset/76011
              https://bugs.webkit.org/show_bug.cgi?id=51664
      
              The r76004 broke pixel tests.
              (The failure was missed due to the tolerance.)
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::addRoundedRectClip):
              (WebCore::GraphicsContext::clipOutRoundedRect):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/RoundedIntRect.cpp: Removed.
              * platform/graphics/RoundedIntRect.h: Removed.
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::pushContentsClip):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              (WebCore::RenderBoxModelObject::paintBorder):
              (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
              (WebCore::uniformlyExpandBorderRadii):
              (WebCore::RenderBoxModelObject::paintBoxShadow):
              * rendering/RenderBoxModelObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::drawBoxSideFromPath):
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintMenuListButtonGradients):
              (WebCore::RenderThemeMac::paintSliderTrack):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
              (WebCore::RenderThemeSafari::paintSliderTrack):
              * rendering/RenderThemeWinCE.cpp:
              (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint):
              * rendering/style/BorderData.h:
              * rendering/style/RenderStyle.cpp:
              (WebCore::constrainCornerRadiiForRect):
              (WebCore::RenderStyle::getBorderRadiiForRect):
              (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
              * rendering/style/RenderStyle.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdba390e
    • morrita@google.com's avatar
      2011-01-17 MORITA Hajime <morrita@google.com> · 1da9327b
      morrita@google.com authored
              Reviewed by Simon Fraser.
      
              Refactoring: Extract RoundedIntRect class
              https://bugs.webkit.org/show_bug.cgi?id=51664
      
              RoundedIntRect is a pair of rect and four IntSize objects which represent
              corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
              Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
              return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
              and other functions accept RoundedIntRect as an argument.
      
              No new tests. No behavioral change.
      
              * Android.mk:
              * CMakeLists.txt:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::addRoundedRectClip):
              (WebCore::GraphicsContext::clipOutRoundedRect):
              (WebCore::GraphicsContext::fillRoundedRect):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/RoundedIntRect.cpp: Added.
              (WebCore::RoundedIntRect::Radii::isZero):
              (WebCore::RoundedIntRect::Radii::scale):
              (WebCore::RoundedIntRect::Radii::expand):
              (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
              (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
              (WebCore::RoundedIntRect::RoundedIntRect):
              (WebCore::RoundedIntRect::includeLogicalEdges):
              (WebCore::RoundedIntRect::excludeLogicalEdges):
              * platform/graphics/RoundedIntRect.h: Added.
              (WebCore::RoundedIntRect::Radii::Radii):
              (WebCore::RoundedIntRect::Radii::setTopLeft):
              (WebCore::RoundedIntRect::Radii::setTopRight):
              (WebCore::RoundedIntRect::Radii::setBottomLeft):
              (WebCore::RoundedIntRect::Radii::setBottomRight):
              (WebCore::RoundedIntRect::Radii::topLeft):
              (WebCore::RoundedIntRect::Radii::topRight):
              (WebCore::RoundedIntRect::Radii::bottomLeft):
              (WebCore::RoundedIntRect::Radii::bottomRight):
              (WebCore::RoundedIntRect::Radii::expand):
              (WebCore::RoundedIntRect::Radii::shrink):
              (WebCore::RoundedIntRect::location):
              (WebCore::RoundedIntRect::size):
              (WebCore::RoundedIntRect::x):
              (WebCore::RoundedIntRect::y):
              (WebCore::RoundedIntRect::width):
              (WebCore::RoundedIntRect::height):
              (WebCore::RoundedIntRect::right):
              (WebCore::RoundedIntRect::bottom):
              (WebCore::RoundedIntRect::rect):
              (WebCore::RoundedIntRect::radii):
              (WebCore::RoundedIntRect::isRounded):
              (WebCore::RoundedIntRect::isEmpty):
              (WebCore::RoundedIntRect::setRect):
              (WebCore::RoundedIntRect::setRadii):
              (WebCore::RoundedIntRect::move):
              (WebCore::RoundedIntRect::inflate):
              (WebCore::RoundedIntRect::inflateWithRadii):
              (WebCore::RoundedIntRect::expandRadii):
              (WebCore::RoundedIntRect::shrinkRadii):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::pushContentsClip):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              (WebCore::RenderBoxModelObject::paintBorder):
              (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
              (WebCore::RenderBoxModelObject::paintBoxShadow):
              * rendering/RenderBoxModelObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::drawBoxSideFromPath):
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintMenuListButtonGradients):
              (WebCore::RenderThemeMac::paintSliderTrack):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
              (WebCore::RenderThemeSafari::paintSliderTrack):
              * rendering/RenderThemeWinCE.cpp:
              (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint):
              * rendering/style/BorderData.h:
              * rendering/style/RenderStyle.cpp:
              (WebCore::calcRadiiFor):
              (WebCore::calcConstraintScaleFor):
              (WebCore::RenderStyle::getRoundedBorderFor):
              (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::setBorderRadius):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1da9327b
  6. 14 Jan, 2011 1 commit
    • tonyg@chromium.org's avatar
      2011-01-14 Tony Gentilcore <tonyg@chromium.org> · b138b1e3
      tonyg@chromium.org authored
              Reviewed by David Levin.
      
              Do some forward declaration in RenderStyle.h
              https://bugs.webkit.org/show_bug.cgi?id=52453
      
              No new tests because no new functionality.
      
              * css/CSSComputedStyleDeclaration.cpp:
              * css/CSSStyleSelector.cpp:
              * editing/Editor.cpp:
              * page/EventHandler.cpp:
              * rendering/EllipsisBox.cpp:
              * rendering/InlineBox.cpp:
              * rendering/InlineTextBox.cpp:
              * rendering/RenderBlock.cpp:
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              * rendering/RenderBox.h:
              * rendering/RenderEmbeddedObject.cpp:
              * rendering/RenderFieldset.cpp:
              * rendering/RenderFileUploadControl.cpp:
              * rendering/RenderFrameSet.cpp:
              * rendering/RenderHTMLCanvas.cpp:
              * rendering/RenderImageResource.cpp:
              * rendering/RenderInputSpeech.cpp:
              * rendering/RenderLayer.h:
              * rendering/RenderLineBoxList.cpp:
              * rendering/RenderListBox.cpp:
              * rendering/RenderMediaControlsChromium.cpp:
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderObjectChildList.cpp:
              * rendering/RenderProgress.cpp:
              * rendering/RenderScrollbarPart.cpp:
              * rendering/RenderTable.cpp:
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/RenderTheme.cpp:
              * rendering/RenderThemeChromiumSkia.cpp:
              * rendering/RenderThemeChromiumWin.cpp:
              * rendering/RootInlineBox.cpp:
              * rendering/style/RenderStyle.cpp:
              * rendering/style/RenderStyle.h:
              * rendering/style/StyleRareInheritedData.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b138b1e3
  7. 08 Jan, 2011 1 commit
  8. 03 Sep, 2010 1 commit
  9. 19 Jul, 2010 1 commit
    • tkent@chromium.org's avatar
      2010-07-19 Kent Tamura <tkent@chromium.org> · 299b6a10
      tkent@chromium.org authored
              Reviewed by Shinichiro Hamaji.
      
              [Chromium] Fix style errors of RenderThemeChromiumWin.cpp
              https://bugs.webkit.org/show_bug.cgi?id=42568
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::):
              (WebCore::getNonClientMetrics):
              (WebCore::systemFontSize):
              (WebCore::pointsToPixels):
              (WebCore::querySystemBlinkInterval):
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
              (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor):
              (WebCore::RenderThemeChromiumWin::paintButton):
              (WebCore::RenderThemeChromiumWin::paintSliderTrack):
              (WebCore::RenderThemeChromiumWin::paintMenuList):
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      299b6a10
  10. 16 Jul, 2010 2 commits
    • tkent@chromium.org's avatar
      2010-07-16 Kent Tamura <tkent@chromium.org> · 2f05dd42
      tkent@chromium.org authored
              Unreviewed, build fix.
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::getThemeData): Fix a typo.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f05dd42
    • tkent@chromium.org's avatar
      2010-07-16 Kent Tamura <tkent@chromium.org> · e5051187
      tkent@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] <input type=number> UI implementation for Windows
              https://bugs.webkit.org/show_bug.cgi?id=42259
      
              No additional tests.  Existing tests cover this change and we'll
              update expectations.
      
              * platform/chromium/ChromiumBridge.h: Add paintSpinButton().
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::determineState):
               Add ControlSubPart parameter and add support for spin buttons.
              (WebCore::RenderThemeChromiumWin::determineClassicState): ditto.
              (WebCore::RenderThemeChromiumWin::getThemeData): ditto.
              (WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle): Added.
              (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): Added.
              * rendering/RenderThemeChromiumWin.h:
                Declare ControlSubpart, and add it to some functions.
      2010-07-16  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Chromium] <input type=number> UI implementation for Windows
              https://bugs.webkit.org/show_bug.cgi?id=42259
      
              * public/WebThemeEngine.h:
              (WebKit::WebThemeEngine::paintSpinButton): Added.
              * src/ChromiumBridge.cpp:
              (WebCore::ChromiumBridge::paintSpinButton):
                Added. It calls WebThemeEngine::paintSpinButton().
      2010-07-16  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Chromium] <input type=number> UI implementation for Windows
              https://bugs.webkit.org/show_bug.cgi?id=42259
      
              * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
              (WebThemeEngineDRT::paintSpinButton):
               Added. Check state consistency and use existing arrow painting code.
              * DumpRenderTree/chromium/WebThemeEngineDRT.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5051187
  11. 15 Jul, 2010 1 commit
  12. 02 Jul, 2010 1 commit
    • tkent@chromium.org's avatar
      2010-07-02 Kent Tamura <tkent@chromium.org> · 8106f3db
      tkent@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
              https://bugs.webkit.org/show_bug.cgi?id=41508
      
              * platform/chromium/test_expectations.txt:
                fast/forms/indeterminate.html fails temporarily.
      2010-07-02  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
              https://bugs.webkit.org/show_bug.cgi?id=41508
      
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::paintCheckbox):
                Use dedicated images for indeterminate states.
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::determineClassicState):
                Do not use DFCS_CHECKED in a case of indeterminate state in
                order to have consistent appearance of indeterminate checkbox.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8106f3db
  13. 01 Jul, 2010 1 commit
  14. 29 Jun, 2010 2 commits
    • morrita@google.com's avatar
      2010-06-29 MORITA Hajime <morrita@google.com> · b8ce05a5
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              REGRESSION: [Chromium] <progress> appearance on windows looks not good
              https://bugs.webkit.org/show_bug.cgi?id=41343
      
              Skipped a test with outdated expectation. We need to rebaseline it.
      
              * platform/chromium/test_expectations.txt:
      2010-06-29  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              REGRESSION: [Chromium] <progress> appearance on windows looks not good
              https://bugs.webkit.org/show_bug.cgi?id=41343
      
              RenderThemeChromiumWin::paintProgressBar() should return false,
              which indicates the widget is painted.
      
              Test: fast/dom/HTMLProgressElement/progress-element.html
                    * rebaselined with a wrong expectation.
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8ce05a5
    • zimmermann@webkit.org's avatar
      2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com> · 427c02f4
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Move PaintInfo/PaintPhase into their own headers, out of RenderObject
              https://bugs.webkit.org/show_bug.cgi?id=41342
      
              1) Move enums PaintPhase/PaintBehaviorFlags and the PaintBehaviour typedef from RenderObject into PaintPhase.h.
                 Move PaintInfo from RenderObject into PaintInfo.h. Replace s/RenderObject::PaintInfo/PaintInfo/ throughout WebCore/.
                 Also move the OverlapTestRequestMap typedef into PaintInfo.h, and replace s/RenderObject::OverlapTestRequestMap/OverlapTestRequestMap/ everywhere.
      
              2) Move "RenderObject* paintingRootForChildren(PaintInfo& paintInfo) const" from RenderObject to PaintInfo
                 and modify it to take a renderer: "void updatePaintingRootForChildren(const RenderObject* renderer)".
      
              This changes a common idiom:
              -    info.paintingRoot = paintingRootForChildren(paintInfo);
              +    info.updatePaintingRootForChildren(this);
      
              We save resetting the paintingRoot to 0 if it was 0 already and thus do less work.
      
              3) Move "bool shouldPaintWithinRoot(PaintInfo& paintInfo) const" from RenderObject to PaintInfo
                 and modify it to take a renderer: "bool shouldPaintWithinRoot(const RenderObject* renderer) const".
      
              This changes a common idiom:
              -    if (!shouldPaintWithinRoot(paintInfo))
              +    if (!paintInfo.shouldPaintWithinRoot(this))
      
              4) Move "void applyTransformToPaintInfo(RenderObject::PaintInfo&, const AffineTransform& localToChildTransform)"
                 from SVGRenderSupport to PaintInfo and rename it to "applyTransform", guarded with ENABLE(SVG) blocks.
      
              This changes a common idiom:
              -    applyTransformToPaintInfo(childPaintInfo, localToParentTransform());
              +    childPaintInfo.applyTransform(localToParentTransform());
      
              Add PaintInfo.h / PaintPhase.h to all build systems that list headers.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/android/RenderThemeAndroid.cpp:
              (WebCore::getCanvasFromInfo):
              (WebCore::RenderThemeAndroid::paintCheckbox):
              (WebCore::RenderThemeAndroid::paintButton):
              (WebCore::RenderThemeAndroid::paintRadio):
              (WebCore::RenderThemeAndroid::paintTextField):
              (WebCore::RenderThemeAndroid::paintTextArea):
              (WebCore::RenderThemeAndroid::paintSearchField):
              (WebCore::RenderThemeAndroid::paintCombo):
              (WebCore::RenderThemeAndroid::paintMenuList):
              (WebCore::RenderThemeAndroid::paintMenuListButton):
              * platform/android/RenderThemeAndroid.h:
              * platform/efl/RenderThemeEfl.cpp:
              (WebCore::RenderThemeEfl::paintThemePart):
              (WebCore::RenderThemeEfl::paintCheckbox):
              (WebCore::RenderThemeEfl::paintRadio):
              (WebCore::RenderThemeEfl::paintButton):
              (WebCore::RenderThemeEfl::paintMenuList):
              (WebCore::RenderThemeEfl::paintTextField):
              (WebCore::RenderThemeEfl::paintTextArea):
              (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
              (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
              (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
              (WebCore::RenderThemeEfl::paintSearchField):
              * platform/efl/RenderThemeEfl.h:
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::paintMozillaGtkWidget):
              (WebCore::RenderThemeGtk::paintCheckbox):
              (WebCore::RenderThemeGtk::paintRadio):
              (WebCore::RenderThemeGtk::paintButton):
              (WebCore::RenderThemeGtk::paintMenuList):
              (WebCore::RenderThemeGtk::paintTextField):
              (WebCore::RenderThemeGtk::paintTextArea):
              (WebCore::RenderThemeGtk::paintSearchFieldResultsButton):
              (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
              (WebCore::RenderThemeGtk::paintSearchField):
              (WebCore::RenderThemeGtk::paintSliderTrack):
              (WebCore::RenderThemeGtk::paintSliderThumb):
              (WebCore::RenderThemeGtk::paintMediaFullscreenButton):
              (WebCore::RenderThemeGtk::paintMediaMuteButton):
              (WebCore::RenderThemeGtk::paintMediaPlayButton):
              (WebCore::RenderThemeGtk::paintMediaSeekBackButton):
              (WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
              (WebCore::RenderThemeGtk::paintMediaSliderTrack):
              (WebCore::RenderThemeGtk::paintMediaSliderThumb):
              (WebCore::RenderThemeGtk::paintProgressBar):
              * platform/gtk/RenderThemeGtk.h:
              * platform/haiku/RenderThemeHaiku.cpp:
              (WebCore::RenderThemeHaiku::paintCheckbox):
              (WebCore::RenderThemeHaiku::paintRadio):
              (WebCore::RenderThemeHaiku::paintMenuList):
              * platform/haiku/RenderThemeHaiku.h:
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::StylePainter::StylePainter):
              (WebCore::RenderThemeQt::paintCheckbox):
              (WebCore::RenderThemeQt::paintRadio):
              (WebCore::RenderThemeQt::paintButton):
              (WebCore::RenderThemeQt::paintTextField):
              (WebCore::RenderThemeQt::paintTextArea):
              (WebCore::RenderThemeQt::paintMenuList):
              (WebCore::RenderThemeQt::paintMenuListButton):
              (WebCore::RenderThemeQt::paintProgressBar):
              (WebCore::RenderThemeQt::paintSliderTrack):
              (WebCore::RenderThemeQt::paintSliderThumb):
              (WebCore::RenderThemeQt::paintSearchField):
              (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
              (WebCore::RenderThemeQt::paintSearchFieldDecoration):
              (WebCore::RenderThemeQt::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeQt::paintMediaFullscreenButton):
              (WebCore::RenderThemeQt::paintMediaMuteButton):
              (WebCore::RenderThemeQt::paintMediaPlayButton):
              (WebCore::RenderThemeQt::paintMediaSeekBackButton):
              (WebCore::RenderThemeQt::paintMediaSeekForwardButton):
              (WebCore::RenderThemeQt::paintMediaCurrentTime):
              (WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
              (WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
              (WebCore::RenderThemeQt::paintMediaSliderTrack):
              (WebCore::RenderThemeQt::paintMediaSliderThumb):
              * platform/qt/RenderThemeQt.h:
              * platform/wx/RenderThemeWx.cpp:
              (WebCore::RenderThemeWx::paintCheckbox):
              (WebCore::RenderThemeWx::paintRadio):
              (WebCore::RenderThemeWx::paintButton):
              (WebCore::RenderThemeWx::paintTextField):
              (WebCore::RenderThemeWx::paintMenuList):
              (WebCore::RenderThemeWx::paintMenuListButton):
              * rendering/EllipsisBox.cpp:
              (WebCore::EllipsisBox::paint):
              * rendering/EllipsisBox.h:
              * rendering/InlineBox.cpp:
              (WebCore::InlineBox::paint):
              * rendering/InlineBox.h:
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paint):
              (WebCore::InlineFlowBox::paintFillLayers):
              (WebCore::InlineFlowBox::paintFillLayer):
              (WebCore::InlineFlowBox::paintBoxDecorations):
              (WebCore::InlineFlowBox::paintMask):
              (WebCore::InlineFlowBox::paintTextDecorations):
              * rendering/InlineFlowBox.h:
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paint):
              * rendering/InlineTextBox.h:
              * rendering/PaintInfo.h: Added.
              (WebCore::PaintInfo::PaintInfo):
              (WebCore::PaintInfo::updatePaintingRootForChildren):
              (WebCore::PaintInfo::shouldPaintWithinRoot):
              (WebCore::PaintInfo::applyTransform):
              * rendering/PaintPhase.h: Added.
              (WebCore::):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paint):
              (WebCore::RenderBlock::paintChildren):
              (WebCore::RenderBlock::paintEllipsisBoxes):
              (WebCore::clipOutPositionedObjects):
              (WebCore::RenderBlock::layoutColumns):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paint):
              (WebCore::RenderBox::paintBoxDecorations):
              (WebCore::RenderBox::paintMask):
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::paintBoxDecorations):
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::paint):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paint):
              (WebCore::performOverlapTests):
              (WebCore::RenderLayer::paintLayer):
              (WebCore::RenderLayer::paintList):
              (WebCore::RenderLayer::paintPaginatedChildLayer):
              (WebCore::RenderLayer::paintChildLayerIntoColumns):
              * rendering/RenderLayer.h:
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::paintIntoLayer):
              * rendering/RenderLineBoxList.cpp:
              (WebCore::RenderLineBoxList::paint):
              * rendering/RenderLineBoxList.h:
              * rendering/RenderMediaControls.cpp:
              (WebCore::RenderMediaControls::paintMediaControlsPart):
              * rendering/RenderMediaControls.h:
              * rendering/RenderMediaControlsChromium.cpp:
              (WebCore::paintMediaMuteButton):
              (WebCore::paintMediaPlayButton):
              (WebCore::paintMediaSlider):
              (WebCore::paintMediaSliderThumb):
              (WebCore::paintMediaVolumeSlider):
              (WebCore::paintMediaVolumeSliderThumb):
              (WebCore::paintMediaTimelineContainer):
              (WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
              * rendering/RenderMediaControlsChromium.h:
              * rendering/RenderObject.h:
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::paint):
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              (WebCore::RenderReplaced::shouldPaint):
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::paint):
              * rendering/RenderSVGResourceMarker.cpp:
              (WebCore::RenderSVGResourceMarker::draw):
              * rendering/RenderSVGResourceMarker.h:
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::paint):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::paint):
              * rendering/RenderScrollbarPart.cpp:
              (WebCore::RenderScrollbarPart::paintIntoRect):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintObject):
              (WebCore::RenderTable::paintBoxDecorations):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paint):
              (WebCore::RenderTableCell::paintBackgroundsBehindCell):
              (WebCore::RenderTableCell::paintBoxDecorations):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::paint):
              (WebCore::RenderTheme::paintBorderOnly):
              (WebCore::RenderTheme::paintDecorations):
              (WebCore::RenderTheme::paintMeter):
              * rendering/RenderTheme.h:
              (WebCore::RenderTheme::paintCapsLockIndicator):
              (WebCore::RenderTheme::paintCheckbox):
              (WebCore::RenderTheme::paintRadio):
              (WebCore::RenderTheme::paintButton):
              (WebCore::RenderTheme::paintInnerSpinButton):
              (WebCore::RenderTheme::paintOuterSpinButton):
              (WebCore::RenderTheme::paintTextField):
              (WebCore::RenderTheme::paintTextArea):
              (WebCore::RenderTheme::paintMenuList):
              (WebCore::RenderTheme::paintMenuListButton):
              (WebCore::RenderTheme::paintProgressBar):
              (WebCore::RenderTheme::paintSliderTrack):
              (WebCore::RenderTheme::paintSliderThumb):
              (WebCore::RenderTheme::paintSearchField):
              (WebCore::RenderTheme::paintSearchFieldCancelButton):
              (WebCore::RenderTheme::paintSearchFieldDecoration):
              (WebCore::RenderTheme::paintSearchFieldResultsDecoration):
              (WebCore::RenderTheme::paintSearchFieldResultsButton):
              (WebCore::RenderTheme::paintMediaFullscreenButton):
              (WebCore::RenderTheme::paintMediaPlayButton):
              (WebCore::RenderTheme::paintMediaMuteButton):
              (WebCore::RenderTheme::paintMediaSeekBackButton):
              (WebCore::RenderTheme::paintMediaSeekForwardButton):
              (WebCore::RenderTheme::paintMediaSliderTrack):
              (WebCore::RenderTheme::paintMediaSliderThumb):
              (WebCore::RenderTheme::paintMediaVolumeSliderContainer):
              (WebCore::RenderTheme::paintMediaVolumeSliderTrack):
              (WebCore::RenderTheme::paintMediaVolumeSliderThumb):
              (WebCore::RenderTheme::paintMediaRewindButton):
              (WebCore::RenderTheme::paintMediaReturnToRealtimeButton):
              (WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):
              (WebCore::RenderTheme::paintMediaControlsBackground):
              (WebCore::RenderTheme::paintMediaCurrentTime):
              (WebCore::RenderTheme::paintMediaTimeRemaining):
              * rendering/RenderThemeChromiumMac.h:
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
              (WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
              (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
              (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
              (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack):
              (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::paintCheckbox):
              (WebCore::RenderThemeChromiumSkia::paintRadio):
              (WebCore::paintButtonLike):
              (WebCore::RenderThemeChromiumSkia::paintButton):
              (WebCore::RenderThemeChromiumSkia::paintTextField):
              (WebCore::RenderThemeChromiumSkia::paintTextArea):
              (WebCore::RenderThemeChromiumSkia::paintSearchField):
              (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
              (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
              (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground):
              (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack):
              (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack):
              (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb):
              (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb):
              (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):
              (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton):
              (WebCore::RenderThemeChromiumSkia::paintMenuList):
              (WebCore::RenderThemeChromiumSkia::paintMenuListButton):
              (WebCore::RenderThemeChromiumSkia::paintSliderTrack):
              (WebCore::RenderThemeChromiumSkia::paintSliderThumb):
              (WebCore::RenderThemeChromiumSkia::paintProgressBar):
              * rendering/RenderThemeChromiumSkia.h:
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintCheckbox):
              (WebCore::RenderThemeChromiumWin::paintRadio):
              (WebCore::RenderThemeChromiumWin::paintButton):
              (WebCore::RenderThemeChromiumWin::paintTextField):
              (WebCore::RenderThemeChromiumWin::paintSliderTrack):
              (WebCore::RenderThemeChromiumWin::paintSliderThumb):
              (WebCore::RenderThemeChromiumWin::paintMenuList):
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
              * rendering/RenderThemeChromiumWin.h:
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintTextField):
              (WebCore::RenderThemeMac::paintCapsLockIndicator):
              (WebCore::RenderThemeMac::paintTextArea):
              (WebCore::RenderThemeMac::paintMenuList):
              (WebCore::RenderThemeMac::paintMeter):
              (WebCore::RenderThemeMac::paintProgressBar):
              (WebCore::RenderThemeMac::paintMenuListButtonGradients):
              (WebCore::RenderThemeMac::paintMenuListButton):
              (WebCore::RenderThemeMac::paintSliderTrack):
              (WebCore::RenderThemeMac::paintSliderThumb):
              (WebCore::RenderThemeMac::paintSearchField):
              (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
              (WebCore::RenderThemeMac::paintSearchFieldDecoration):
              (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
              (WebCore::getUnzoomedRectAndAdjustCurrentContext):
              (WebCore::RenderThemeMac::paintMediaFullscreenButton):
              (WebCore::RenderThemeMac::paintMediaMuteButton):
              (WebCore::RenderThemeMac::paintMediaPlayButton):
              (WebCore::RenderThemeMac::paintMediaSeekBackButton):
              (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
              (WebCore::RenderThemeMac::paintMediaSliderTrack):
              (WebCore::RenderThemeMac::paintMediaSliderThumb):
              (WebCore::RenderThemeMac::paintMediaRewindButton):
              (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
              (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
              (WebCore::RenderThemeMac::paintMediaControlsBackground):
              (WebCore::RenderThemeMac::paintMediaCurrentTime):
              (WebCore::RenderThemeMac::paintMediaTimeRemaining):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintCheckbox):
              (WebCore::RenderThemeSafari::paintRadio):
              (WebCore::RenderThemeSafari::paintButton):
              (WebCore::RenderThemeSafari::paintTextField):
              (WebCore::RenderThemeSafari::paintCapsLockIndicator):
              (WebCore::RenderThemeSafari::paintTextArea):
              (WebCore::RenderThemeSafari::paintMenuList):
              (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
              (WebCore::RenderThemeSafari::paintMenuListButton):
              (WebCore::RenderThemeSafari::paintSliderTrack):
              (WebCore::RenderThemeSafari::paintSliderThumb):
              (WebCore::RenderThemeSafari::paintSearchField):
              (WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
              (WebCore::RenderThemeSafari::paintSearchFieldDecoration):
              (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
              (WebCore::RenderThemeSafari::paintMediaFullscreenButton):
              (WebCore::RenderThemeSafari::paintMediaMuteButton):
              (WebCore::RenderThemeSafari::paintMediaPlayButton):
              (WebCore::RenderThemeSafari::paintMediaSeekBackButton):
              (WebCore::RenderThemeSafari::paintMediaSeekForwardButton):
              (WebCore::RenderThemeSafari::paintMediaSliderTrack):
              (WebCore::RenderThemeSafari::paintMediaSliderThumb):
              * rendering/RenderThemeSafari.h:
              * rendering/RenderThemeWin.cpp:
              (WebCore::RenderThemeWin::paintButton):
              (WebCore::RenderThemeWin::paintTextField):
              (WebCore::RenderThemeWin::paintMenuList):
              (WebCore::RenderThemeWin::paintMenuListButton):
              (WebCore::RenderThemeWin::paintSliderTrack):
              (WebCore::RenderThemeWin::paintSliderThumb):
              (WebCore::RenderThemeWin::paintSearchField):
              (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
              (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
              (WebCore::RenderThemeWin::paintMediaFullscreenButton):
              (WebCore::RenderThemeWin::paintMediaMuteButton):
              (WebCore::RenderThemeWin::paintMediaPlayButton):
              (WebCore::RenderThemeWin::paintMediaSeekBackButton):
              (WebCore::RenderThemeWin::paintMediaSeekForwardButton):
              (WebCore::RenderThemeWin::paintMediaSliderTrack):
              (WebCore::RenderThemeWin::paintMediaSliderThumb):
              (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
              * rendering/RenderThemeWin.h:
              (WebCore::RenderThemeWin::paintCheckbox):
              (WebCore::RenderThemeWin::paintRadio):
              (WebCore::RenderThemeWin::paintTextArea):
              (WebCore::RenderThemeWin::paintSearchFieldDecoration):
              * rendering/RenderThemeWince.cpp:
              (WebCore::RenderThemeWince::paintButton):
              (WebCore::RenderThemeWince::paintTextField):
              (WebCore::RenderThemeWince::paintMenuList):
              (WebCore::RenderThemeWince::paintMenuListButton):
              (WebCore::RenderThemeWince::paintSearchField):
              (WebCore::RenderThemeWince::paintSearchFieldCancelButton):
              (WebCore::RenderThemeWince::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeWince::paintSearchFieldResultsButton):
              (WebCore::RenderThemeWince::paintSliderTrack):
              (WebCore::RenderThemeWince::paintSliderThumb):
              (WebCore::RenderThemeWince::paintMediaFullscreenButton):
              (WebCore::RenderThemeWince::paintMediaMuteButton):
              (WebCore::RenderThemeWince::paintMediaPlayButton):
              (WebCore::RenderThemeWince::paintMediaSeekBackButton):
              (WebCore::RenderThemeWince::paintMediaSeekForwardButton):
              (WebCore::RenderThemeWince::paintMediaSliderTrack):
              (WebCore::RenderThemeWince::paintMediaSliderThumb):
              * rendering/RenderThemeWince.h:
              (WebCore::RenderThemeWince::paintCheckbox):
              (WebCore::RenderThemeWince::paintRadio):
              (WebCore::RenderThemeWince::paintTextArea):
              (WebCore::RenderThemeWince::paintSearchFieldDecoration):
              * rendering/RootInlineBox.cpp:
              (WebCore::RootInlineBox::paintEllipsisBox):
              (WebCore::RootInlineBox::paintCustomHighlight):
              (WebCore::RootInlineBox::paint):
              (WebCore::RootInlineBox::fillLineSelectionGap):
              * rendering/RootInlineBox.h:
              * rendering/SVGInlineFlowBox.cpp:
              (WebCore::SVGInlineFlowBox::paint):
              * rendering/SVGInlineFlowBox.h:
              * rendering/SVGInlineTextBox.cpp:
              (WebCore::SVGInlineTextBox::paint):
              * rendering/SVGInlineTextBox.h:
              * rendering/SVGMarkerLayoutInfo.cpp:
              (WebCore::SVGMarkerLayoutInfo::drawMarkers):
              * rendering/SVGMarkerLayoutInfo.h:
              * rendering/SVGRenderSupport.cpp:
              (WebCore::SVGRenderBase::prepareToRenderSVGContent):
              (WebCore::SVGRenderBase::finishRenderSVGContent):
              (WebCore::renderSubtreeToImage):
              * rendering/SVGRenderSupport.h:
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::paint):
              * rendering/SVGRootInlineBox.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      427c02f4
  15. 06 Jun, 2010 2 commits
    • morrita@google.com's avatar
      2010-06-06 MORITA Hajime <morrita@google.com> · 99e169f8
      morrita@google.com authored
              Unreviewd, Chromium windows build fix.
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99e169f8
    • morrita@google.com's avatar
      2010-06-06 MORITA Hajime <morrita@google.com> · be71a74d
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              ASSERTION FAILED with -webkit-appearance:progress-bar for non-progress bar elements
              https://bugs.webkit.org/show_bug.cgi?id=40158
      
              * fast/css/invalid-appearance-progress-bar-meter-expected.txt: Added.
              * fast/css/invalid-appearance-progress-bar-meter.html: Added.
              * fast/css/script-tests/invalid-appearance-progress-bar-meter.js: Added.
      2010-06-06  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              ASSERTION FAILED with -webkit-appearance:progress-bar for non <progress> elements
              https://bugs.webkit.org/show_bug.cgi?id=40158
      
              paintProgressBar() and paintMeter() assumed given RenderObject is
              RenderProgress or RenderMeter respectively, but arbitrary elements
              can have -webkit-appearance: progress-bar and such elements
              violates that assumption. So this change added type check before
              downcasting the RenderObject.
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::paintProgressBar):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::paintMeter):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::paintProgressBar):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintProgressBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be71a74d
  16. 02 Jun, 2010 2 commits
    • morrita@google.com's avatar
      2010-06-02 MORITA Hajime <morrita@google.com> · af1c0522
      morrita@google.com authored
              Unreviewd, Chromium windows build fix.
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af1c0522
    • morrita@google.com's avatar
      2010-06-02 MORITA Hajime <morrita@google.com> · 9a6daa63
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              [Chromium] Support HTML5 <progress> element on Linux.
              https://bugs.webkit.org/show_bug.cgi?id=37310
      
              Implemented RenderThemeChromiumSkia::paintProgressBar(), extracing
              determinateProgressValueRectFor() from RenderThemeChromiumWin to
              RenderThemeChromiumSkia
      
              No new tests. Expectations will come after ENABLE_PROGRESS_BAR get
              enabled on chromium.
      
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::determinateProgressValueRectFor):
              (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor):
              (WebCore::RenderThemeChromiumSkia::animationRepeatIntervalForProgressBar):
              (WebCore::RenderThemeChromiumSkia::animationDurationForProgressBar):
              (WebCore::RenderThemeChromiumSkia::paintProgressBar):
              (WebCore::RenderThemeChromiumSkia::progressValueRectFor):
              * rendering/RenderThemeChromiumSkia.h:
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a6daa63
  17. 21 May, 2010 1 commit
  18. 18 May, 2010 1 commit
    • morrita@google.com's avatar
      2010-05-18 MORITA Hajime <morrita@google.com> · 2c89b8ce
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              [Chromium] Windows: Determinate progress bar should have glossy overlay
              https://bugs.webkit.org/show_bug.cgi?id=39269
      
              - Moved animation code from RenderThemeChromiumWin to chromium tree
                because it should be behind the theme implementation, which lives
                in chromium tree.
              - Passed current time to the bridge, which will be used to compute
                the state of the theme animation.
      
              No new tests, animation effect can be confirmed only manually.
      
              * platform/chromium/ChromiumBridge.h:
              * rendering/RenderProgress.h:
              (WebCore::RenderProgress::animationStartTime): Added.
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar):
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
      2010-05-18  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              [Chromium] Windows: Determinate progress bar should have glossy overlay
              https://bugs.webkit.org/show_bug.cgi?id=39269
      
              Changed WebThemeEngine::drawProgressBar() signature to delegate
              theme implementation detail to the engine.
              Chromium side will come to http://crbug.com/44430.
      
              No new tests, animation effect can be confirmed only manually.
      
              * public/WebThemeEngine.h:
              (WebKit::WebThemeEngine::paintProgressBar):
              * src/ChromiumBridge.cpp:
              (WebCore::ChromiumBridge::paintProgressBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c89b8ce
  19. 17 May, 2010 1 commit
  20. 12 May, 2010 1 commit
    • morrita@google.com's avatar
      2010-05-12 MORITA Hajime <morrita@google.com> · 05e6d133
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              [Chromium] Support HTML5 <progress> element on Windows.
              https://bugs.webkit.org/show_bug.cgi?id=37308
      
              Extended ChromiumBridge to handle progress bar painting,
              and added delegations to it.
      
              No new tests. Test cases should be shared with existing ones for
              progress element.  Expectaions will be added after PROGRESS_TAG is
              enabled on Chromium tree.
      
              * platform/chromium/ChromiumBridge.h:
              * rendering/RenderProgress.cpp:
              (WebCore::RenderProgress::animationProgress):
              (WebCore::RenderProgress::isDeterminate):
              * rendering/RenderProgress.h:
              (WebCore::RenderProgress::position):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::animationRepeatIntervalForProgressBar):
              (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar):
              (WebCore::RenderThemeChromiumWin::adjustProgressBarStyle):
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
              * rendering/RenderThemeChromiumWin.h:
      2010-05-12  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              [Chromium] Support HTML5 <progress> element on Windows.
              https://bugs.webkit.org/show_bug.cgi?id=37308
      
              Extended ChromiumBridge to handle progress bar painting,
              and added delegations to it.
      
              No new tests. Test cases should be shared with existing ones for
              progress element.  Expectaions will be added after PROGRESS_TAG is
              enabled on Chromium tree.
      
              * public/WebThemeEngine.h:
              (WebKit::WebThemeEngine::paintProgressBar):
              * src/ChromiumBridge.cpp:
              (WebCore::ChromiumBridge::paintProgressBar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05e6d133
  21. 08 Feb, 2010 1 commit
  22. 28 Oct, 2009 1 commit
    • eric@webkit.org's avatar
      2009-10-28 Jonathan Dixon <joth@chromium.org> · 5f06c3fc
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
              https://bugs.webkit.org/show_bug.cgi?id=30547
      
              * fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
              * fast/css/text-input-with-webkit-border-radius-expected.png: Added.
              * fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
              * fast/css/text-input-with-webkit-border-radius.html: Added.
      2009-10-28  Jonathan Dixon  <joth@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
              https://bugs.webkit.org/show_bug.cgi?id=30547
      
              Test: fast/css/text-input-with-webkit-border-radius.html
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
                Implemented rounded border rendering in Chromium Windows theme renderer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f06c3fc
  23. 22 Sep, 2009 1 commit
  24. 14 Sep, 2009 1 commit
    • eric@webkit.org's avatar
      2009-09-14 Dirk Pranke <dpranke@chromium.org> · 1a947e05
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Fix RenderThemeChromiumWin::determineClassicState so that classic_state
              matches the state values (and you get a single classic_state value
              for a given {part,state} value. This change will be tested by a
              chromium patch that will land after this.
      
              This will be tested by code landing downstream on Chromium.org; the
              code does not execute on webkit.org.
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::determineClassicState):
              (WebCore::RenderThemeChromiumWin::getThemeData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a947e05
  25. 05 Aug, 2009 1 commit
    • darin@apple.com's avatar
      2009-08-05 Darin Adler <darin@apple.com> · b6cb2561
      darin@apple.com authored
              Reviewed by David Levin.
      
              Use checked casts for render tree
              https://bugs.webkit.org/show_bug.cgi?id=23522
      
              Last patch. Makes all the casts of RenderObject use checked
              casts instead of using static_cast directly.
      
              * accessibility/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::visibleChildren):
              (WebCore::AccessibilityListBox::doAccessibilityHitTest):
              * accessibility/AccessibilityListBoxOption.cpp:
              (WebCore::AccessibilityListBoxOption::elementRect):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::textUnderElement):
              (WebCore::AccessibilityRenderObject::stringValue):
              (WebCore::AccessibilityRenderObject::titleUIElement):
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
              * accessibility/AccessibilitySlider.cpp:
              (WebCore::AccessibilitySliderThumb::elementRect):
              * dom/InputElement.cpp:
              (WebCore::InputElement::updatePlaceholderVisibility):
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::scrollToSelection):
              (WebCore::SelectElement::recalcStyle):
              (WebCore::SelectElement::setRecalcListItems):
              (WebCore::SelectElement::menuListDefaultEventHandler):
              (WebCore::SelectElement::listBoxDefaultEventHandler):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::reset):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::updateWidget):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::attach):
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::defaultEventHandler):
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::attach):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::defaultEventHandler):
              (WebCore::HTMLInputElement::addSearchResult):
              (WebCore::HTMLInputElement::onSearch):
              * html/HTMLLIElement.cpp:
              (WebCore::HTMLLIElement::parseMappedAttribute):
              (WebCore::HTMLLIElement::attach):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::setReadyState):
              (WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
              (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
              (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
              (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
              (WebCore::HTMLMediaElement::defaultEventHandler):
              (WebCore::HTMLMediaElement::finishParsingChildren):
              * html/HTMLOListElement.cpp:
              (WebCore::HTMLOListElement::parseMappedAttribute):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::updateWidget):
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::defaultEventHandler):
              * page/DragController.cpp:
              (WebCore::DragController::concludeEditDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::capsLockStateMayHaveChanged):
              * page/Frame.cpp:
              (WebCore::Frame::ownerRenderer):
              * page/FrameView.cpp:
              (WebCore::FrameView::detachCustomScrollbars):
              * page/wince/FrameWince.cpp:
              (WebCore::computePageRectsForFrame):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally):
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlTimelineElement::defaultEventHandler):
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::findNextLineBreak):
              * rendering/RenderCounter.cpp:
              (WebCore::planCounter):
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::computeEdgeInfo):
              (WebCore::RenderFrameSet::setIsResizing):
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::contentsBox):
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::updateBacking):
              (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
              * rendering/RenderListItem.cpp:
              (WebCore::previousListItem):
              (WebCore::RenderListItem::explicitValueChanged):
              * rendering/RenderObject.cpp:
              (WebCore::updateListMarkerNumbers):
              * rendering/RenderObjectChildList.cpp:
              (WebCore::updateListMarkerNumbers):
              (WebCore::invalidateCountersInContainer):
              * rendering/RenderScrollbarTheme.cpp:
              (WebCore::RenderScrollbarTheme::minimumThumbLength):
              (WebCore::RenderScrollbarTheme::backButtonRect):
              (WebCore::RenderScrollbarTheme::forwardButtonRect):
              (WebCore::RenderScrollbarTheme::trackRect):
              (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
              (WebCore::RenderScrollbarTheme::paintScrollbarBackground):
              (WebCore::RenderScrollbarTheme::paintTrackBackground):
              (WebCore::RenderScrollbarTheme::paintTrackPiece):
              (WebCore::RenderScrollbarTheme::paintButton):
              (WebCore::RenderScrollbarTheme::paintThumb):
              * rendering/RenderSlider.cpp:
              (WebCore::SliderThumbElement::defaultEventHandler):
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::paintSliderThumb):
              (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintSliderThumb):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintSliderThumb):
              * rendering/RenderThemeWin.cpp:
              (WebCore::RenderThemeWin::determineSliderThumbState):
              * rendering/SVGCharacterLayoutInfo.cpp:
              (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::findSVGRootObject):
              * rendering/TextControlInnerElements.cpp:
              (WebCore::RenderTextControlInnerBlock::nodeAtPoint):
              (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
              * svg/SVGImageElement.cpp:
              (WebCore::SVGImageElement::attach):
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::canvasResource):
              * svg/SVGTextContentElement.cpp:
              (WebCore::rootInlineBoxForTextContentElement):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::defaultEventHandler):
              Use checked casts.
      
              * rendering/RenderApplet.h:
              * rendering/RenderCounter.h:
              * rendering/RenderFieldset.h:
              * rendering/RenderFileUploadControl.h:
              * rendering/RenderFrame.h:
              * rendering/RenderFrameSet.h:
              * rendering/RenderHTMLCanvas.h:
              * rendering/RenderListBox.h:
              * rendering/RenderListItem.h:
              * rendering/RenderListMarker.h:
              * rendering/RenderMedia.h:
              * rendering/RenderMenuList.h:
              * rendering/RenderPart.h:
              * rendering/RenderPartObject.h:
              * rendering/RenderPath.h:
              * rendering/RenderSVGContainer.h:
              * rendering/RenderSVGRoot.h:
              * rendering/RenderSVGTextPath.h:
              * rendering/RenderSVGViewportContainer.h:
              * rendering/RenderScrollbar.h:
              * rendering/RenderSlider.h:
              * rendering/RenderTextControlMultiLine.h:
              * rendering/RenderTextControlSingleLine.h:
              * rendering/RenderVideo.h:
              Added a checked cast. Also made most members protected or private.
      
              * rendering/RenderBlock.h:
              * rendering/RenderInline.h:
              * rendering/RenderReplaced.h:
              * rendering/RenderSVGBlock.h:
              * rendering/RenderSVGImage.h:
              * rendering/RenderSVGInlineText.h:
              * rendering/RenderSVGText.h:
              * rendering/RenderTextControl.h:
              Made most members protected or private.
      
              * rendering/RenderInline.cpp:
              * rendering/RenderSVGContainer.cpp:
              * rendering/RenderSVGHiddenContainer.cpp:
              * rendering/RenderSVGImage.cpp:
              * rendering/RenderSVGRoot.cpp:
              Removed unneeded destructor.
      
              * rendering/RenderSVGHiddenContainer.h:
              Removed unneeded virtual function overrides that did the same as
              the default and base class.
      
              * rendering/RenderSVGViewportContainer.cpp:
              (WebCore::RenderSVGViewportContainer::paint): Updated to use m_viewport
              directly instead of using a function call.
              (WebCore::RenderSVGViewportContainer::applyViewportClip): Ditto.
              (WebCore::RenderSVGViewportContainer::viewportTransform): Ditto.
              (WebCore::RenderSVGViewportContainer::localToParentTransform): Ditto.
              (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Ditto.
      
              * rendering/RenderScrollbar.cpp:
              (WebCore::pseudoForScrollbarPart): Changed switch statement to use cases for
              all values instead of using a default case.
      
              * rendering/RenderTreeAsText.cpp:
              (WebCore::operator<<): Removed dependency on casting to types that don't
              have any public members we need to get at. Instead, use function names to
              identify the type rather than doing so much overloading. Changed to use
              checked casts.
              (WebCore::write): Ditto.
      
              * rendering/SVGRenderSupport.cpp:
              (WebCore::renderSubtreeToImage): Changed to use a checked cast and also
              added a comment about the fact that the code does not do sufficient type
              checking before doing the cast.
      
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::writeRenderSVGTextBox): Renamed this from operator<<.
              (WebCore::writeSVGInlineTextBoxes): Renamed this from writeSVGInlineText.
              (WebCore::writeSVGText): Renamed this from write.
              (WebCore::writeSVGInlineText): Ditto.
              (WebCore::writeSVGImage): Ditto.
              * rendering/SVGRenderTreeAsText.h: Updated for name changes. Removed
              unneeded default arguments.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6cb2561
  26. 03 Aug, 2009 1 commit
  27. 08 Jul, 2009 1 commit
    • ddkilzer@apple.com's avatar
      2009-07-08 Shinichiro Hamaji <hamaji@chromium.org> · dfdc3fd5
      ddkilzer@apple.com authored
              Reviewed by David Kilzer.
      
              WebKit needs a style linting tool
              https://bugs.webkit.org/show_bug.cgi?id=25884
      
              Fix bunch of style issues in WebCore/rendering.
              This patch is created to demonstrate cpplint.py.
      
              No testcase because it's just a style fixes.
      
              * rendering/AutoTableLayout.cpp:
              (WebCore::AutoTableLayout::recalcColumn):
              (WebCore::AutoTableLayout::layout):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeEllipsisBox):
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paintTextMatchMarker):
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlTimelineElement::defaultEventHandler):
              * rendering/MediaControlElements.h:
              * rendering/RenderArena.cpp:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::startDelayUpdateScrollInfo):
              (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
              (WebCore::RenderBlock::updateScrollInfoAfterLayout):
              (WebCore::RenderBlock::positionNewFloats):
              (WebCore::RenderBlock::newLine):
              (WebCore::RenderBlock::floatBottom):
              (WebCore::RenderBlock::leftBottom):
              (WebCore::RenderBlock::rightBottom):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcReplacedWidthUsing):
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::layoutLegend):
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::FlexBoxIterator::FlexBoxIterator):
              (WebCore::FlexBoxIterator::reset):
              (WebCore::FlexBoxIterator::first):
              (WebCore::FlexBoxIterator::next):
              (WebCore::RenderFlexibleBox::layoutVerticalBox):
              * rendering/RenderFrameSet.cpp:
              (WebCore::borderStartEdgeColor):
              * rendering/RenderFrameSet.h:
              * rendering/RenderImage.cpp:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateVisibilityStatus):
              (WebCore::RenderLayer::calculateClipRects):
              (WebCore::RenderLayer::calculateRects):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::panScroll):
              * rendering/RenderMarquee.cpp:
              (WebCore::RenderMarquee::updateMarqueeStyle):
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::updateControls):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::drawLineForBoxSide):
              (WebCore::RenderObject::localCaretRect):
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
              * rendering/RenderSlider.h:
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::outerBorderBottom):
              * rendering/RenderTableCol.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::itemIsSeparator):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::supportsHover):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::supportsFocusRing):
              * rendering/SVGCharacterLayoutInfo.cpp:
              (WebCore::SVGCharacterLayoutInfo::addStackContent):
              * rendering/SVGCharacterLayoutInfo.h:
              * rendering/TextControlInnerElements.h:
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::computeHorizontalPositionsForLine):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfdc3fd5
  28. 25 Jun, 2009 1 commit
  29. 17 Jun, 2009 2 commits
    • levin@chromium.org's avatar
      2009-06-17 Albert J. Wong <ajwong@chromium.org> · 3b8f0304
      levin@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=26148
              Remove common code from RenderThemeChromiumWin that is shared with
              RenderThemeChromiumSkia.
      
              Also move supportsControlTints to RenderThemeChromiumLinux since it
              is linux specific.
      
              There are no tests changed because this just removes functions with
              duplicate implementations between the base and derived classes.
      
              * rendering/RenderThemeChromiumLinux.cpp:
              (WebCore::RenderThemeChromiumLinux::supportsControlTints):
              * rendering/RenderThemeChromiumLinux.h:
              * rendering/RenderThemeChromiumSkia.cpp:
              * rendering/RenderThemeChromiumSkia.h:
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::):
              (WebCore::getNonClientMetrics):
              (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
              (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
              (WebCore::RenderThemeChromiumWin::systemFont):
              (WebCore::RenderThemeChromiumWin::paintCheckbox):
              (WebCore::RenderThemeChromiumWin::paintRadio):
              (WebCore::RenderThemeChromiumWin::paintSliderThumb):
              (WebCore::RenderThemeChromiumWin::caretBlinkIntervalInternal):
              * rendering/RenderThemeChromiumWin.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b8f0304
    • aroben@apple.com's avatar
      2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org> · cb3261ef
      aroben@apple.com authored
      Reviewed by Dave Hyatt and Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=26278
              Patch that make WebCore have a RenderTheme per page
      
              Create a different RenderTheme per page, so that RenderTheme has
              access to page specific theming. This is needed for the Qt port, as Qt
              supports setting the theme (style) per widget.
      
              This change was suggested and discussed with Dave Hyatt.
      
              More detailed:
      
              1) Create a theme per page or one global one, depending on the needs
                 of the platform.
              2) Add an accesser to the theme from RenderObject.
              3) Change all uses of the theming to access the theme through
                 RenderObject, using the global default theme as fallback, when the
                 document of RenderObject has no page.
                 When we don't have access to a RenderObject, use the default theme.
              4) Modify all RenderTheme platform implementations to work with the
                 above changes, still creating only one global theme.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb3261ef
  30. 21 May, 2009 1 commit
    • levin@chromium.org's avatar
      2009-05-21 Albert J. Wong <ajwong@chromium.org> · f1045aa3
      levin@chromium.org authored
              Reviewed by Eric Seidel.
      
              Bug 25903: Create a default UI theme for media controls in Chromium.
              https://bugs.webkit.org/show_bug.cgi?id=25903
      
              Implement a default UI for chromium.  Add a style sheet for Chromium
              media controls with good defaults and implemented basic draw functions
              for play/pause & mute buttons.
      
              * css/mediaControlsChromium.css: Added.
              * rendering/RenderThemeChromiumLinux.cpp:
              (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
              our custom media controls style sheet.
              (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint
              buttons respecting chromium media controls color scheme.
              (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic
              specific to play/pause button.
              (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint
              specific to mute button.
              * rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export
              our custom media controls style sheet.
              (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint
              buttons respecting chromium media controls color scheme.
              (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic
              specific to play/pause button.
              (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific
              to mute button.
              (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate
              header changes.
              * rendering/RenderThemeChromiumWin.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1045aa3
  31. 20 May, 2009 1 commit
    • eric@webkit.org's avatar
      2009-05-20 Takeshi Yoshino <tyoshino@google.com> · 709f8428
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
              https://bugs.webkit.org/show_bug.cgi?id=24539
      
              Fix RenderThemeChromiumWin::paintTextFieldInternal().
      
              We shouldn't paint the content area of text fields when o->style() has
              background image or transparent background color. paintTextFieldInternal() is
              used for painting inner area of HTML option elements by Chromium.
      
              When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
              the background image rendered by RenderBoxModelObject. So, we should set
              fillContentArea = false in such case.
      
              Besides, when background-color:transparent is specified for CSS property,
              o->style().backgroundColor returns black color with alpha channel == 0. But
              since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
              recognize alpha channel, it fills the rect with black. I made workaround to set
              fillContentArea = false when alpha channel == 0 to avoid this.
      
              And more, I'd like to fallback the color passed to ChromiumBridge to white when
              o->style()->backgroundColor() is invalid.
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      709f8428
  32. 29 Apr, 2009 1 commit