1. 23 Sep, 2011 40 commits
    • fpizlo@apple.com's avatar
      Resolve opcodes should have value profiling. · eaaa4081
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68723
      
      Reviewed by Oliver Hunt.
              
      This adds value profiling to all forms of op_resolve in the
      old JIT, and patches that information into the DFG along with
      performing the appropriate type propagation.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGGraph.h:
      (JSC::DFG::Graph::predict):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasIdentifier):
      (JSC::DFG::Node::resolveGlobalDataIndex):
      (JSC::DFG::Node::hasPrediction):
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_resolve):
      (JSC::JIT::emit_op_resolve_base):
      (JSC::JIT::emit_op_resolve_skip):
      (JSC::JIT::emit_op_resolve_global):
      (JSC::JIT::emitSlow_op_resolve_global):
      (JSC::JIT::emit_op_resolve_with_base):
      (JSC::JIT::emit_op_resolve_with_this):
      (JSC::JIT::emitSlow_op_resolve_global_dynamic):
      * jit/JITStubCall.h:
      (JSC::JITStubCall::callWithValueProfiling):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaaa4081
    • commit-queue@webkit.org's avatar
      Remove preserves3D() from CCLayerDelegate, replacing it by setting the · 04f485d6
      commit-queue@webkit.org authored
      value explicitly after creating a layer, or setting its delegate.
      https://bugs.webkit.org/show_bug.cgi?id=68295
      
      Patch by Antoine Labour <piman@chromium.org> on 2011-09-23
      Reviewed by James Robinson.
      
      Covered by compositing/ layeout tests.
      
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      (WebCore::GraphicsLayerChromium::setContentsToCanvas):
      (WebCore::GraphicsLayerChromium::setContentsToMedia):
      (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
      (WebCore::GraphicsLayerChromium::setupContentsLayer):
      * platform/graphics/chromium/GraphicsLayerChromium.h:
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::LayerChromium):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::setPreserves3D):
      (WebCore::LayerChromium::preserves3D):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04f485d6
    • commit-queue@webkit.org's avatar
      chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL... · e70ec422
      commit-queue@webkit.org authored
      chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
      https://bugs.webkit.org/show_bug.cgi?id=51639
      
      Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-23
      Reviewed by Tony Chang.
      
      Add repro for a crash inside WebCore::ApplyStyleCommand::applyBlockStyle. Fixed by r94840.
      
      * editing/style/justify-without-enclosing-block-expected.txt: Added.
      * editing/style/justify-without-enclosing-block.xhtml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e70ec422
    • oliver@apple.com's avatar
      Fix windows build. · 6af13a03
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6af13a03
    • abarth@webkit.org's avatar
      Note flaky test. · c85cd8a9
      abarth@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c85cd8a9
    • mrowe@apple.com's avatar
      Versioning. · 71e2a0a5
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71e2a0a5
    • commit-queue@webkit.org's avatar
      Add a few more possiblities to the test cases for xss denial. · 241463a5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=47120
      
      Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-23
      Reviewed by Adam Barth.
      
      * http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt: Added.
      * http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces.html: Added.
      * http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt: Added.
      * http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      241463a5
    • jchaffraix@webkit.org's avatar
      Implicit conversion double to float in ShadowBlur::adjustBlurRadius · 18bc6bc8
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68722
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/ShadowBlur.cpp:
      (WebCore::ShadowBlur::adjustBlurRadius): Added 2 explicit
      conversions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18bc6bc8
    • commit-queue@webkit.org's avatar
      [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender · c5aed241
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68556
      
      Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
      
      Source/WebKit2:
      
      Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
      Reviewed by Darin Adler.
      
      * Shared/API/c/WKGeometry.h:
      (operator==):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::mouseEventSyncForTesting): initialize "handled"
      
      Tools:
      
      Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
      Reviewed by Darin Adler.
      
      * WebKitTestRunner/EventSenderProxy.h:
      * WebKitTestRunner/InjectedBundle/EventSendingController.h:
      * WebKitTestRunner/PlatformWebView.h:
      * WebKitTestRunner/mac/EventSenderProxy.mm:
      (WTR::EventSenderProxy::EventSenderProxy):
      (WTR::EventSenderProxy::leapForward):
      * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
      (WTR::EventSenderProxy::EventSenderProxy):
      (WTR::getMouseButton):
      (WTR::getModifiers):
      (WTR::EventSenderProxy::updateClickCountForButton):
      (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
      (WTR::EventSenderProxy::mouseDown):
      (WTR::EventSenderProxy::mouseUp):
      (WTR::EventSenderProxy::mouseMoveTo):
      (WTR::EventSenderProxy::leapForward):
      (WTR::EventSenderProxy::sendOrQueueEvent):
      (WTR::EventSenderProxy::replaySavedEvents):
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::PlatformWebView::postEvent):
      * WebKitTestRunner/qt/WebKitTestRunner.pro:
      
      LayoutTests:
      
      Unskip passed tests.
      
      Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
      Reviewed by Darin Adler.
      
      * platform/qt-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5aed241
    • barraclough@apple.com's avatar
      Source/JavaScriptCore: Strict mode does not work in non-trivial nested functions. · 1440c07a
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68740
      
      Reviewed by Oliver Hunt.
      
      Function-info caching does not preserve all state that it should.
      
      * parser/JSParser.cpp:
      (JSC::JSParser::Scope::saveFunctionInfo):
      (JSC::JSParser::Scope::restoreFunctionInfo):
      (JSC::JSParser::parseFunctionInfo):
      * parser/SourceProviderCacheItem.h:
      
      LayoutTests: gh@apple.com>
      
      Strict mode does not work in non-trivial nested functions.
      https://bugs.webkit.org/show_bug.cgi?id=68740
      
      Reviewed by Oliver Hunt.
      
      Function-info caching does not preserve all state that it should.
      
      * fast/js/nested-functions-expected.txt: Added.
      * fast/js/nested-functions.html: Added.
      * fast/js/script-tests/nested-functions.js: Added.
      (runTests.test1):
      (runTests.test2):
      (runTests.test3):
      (runTests):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1440c07a
    • fpizlo@apple.com's avatar
      ValueToDouble handling in prediction propagation should be ASSERT_NOT_REACHED · c5e62973
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68724
      
      Reviewed by Oliver Hunt.
      
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5e62973
    • commit-queue@webkit.org's avatar
      [chromium] Make the layout test script's kill timeout proportional to --time-out-ms · c679aa4f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68026
      
      Patch by Lei Zhang <thestig@chromium.org> on 2011-09-23
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c679aa4f
    • mitz@apple.com's avatar
      <rdar://problem/10178576> REGRESSION (r95391): Crash in -[WebCascadeList... · 0190f2cc
      mitz@apple.com authored
      <rdar://problem/10178576> REGRESSION (r95391): Crash in -[WebCascadeList objectAtIndex:] when a font-family list contains missing fonts
      https://bugs.webkit.org/show_bug.cgi?id=68737
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: fast/text/combining-character-sequence-fallback-crash.html
      
      * platform/graphics/mac/ComplexTextControllerCoreText.mm:
      (-[WebCascadeList initWithFont:WebCore::character:]): Changed to intialize _count to the exact
      number of FontData instances in the fallback list rather than the number of font families in the
      font description.
      
      LayoutTests: 
      
      * fast/text/combining-character-sequence-fallback-crash-expected.txt: Added.
      * fast/text/combining-character-sequence-fallback-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0190f2cc
    • adamk@chromium.org's avatar
      [chromium] Remove WEBWIDGET_HAS_ANIMATE_CHANGES #define · f77f1222
      adamk@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68720
      
      Reviewed by James Robinson.
      
      References to this macro were removed in http://crrev.com/102314.
      
      * public/WebWidget.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f77f1222
    • oliver@apple.com's avatar
      Build fix. · f18cd993
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f18cd993
    • commit-queue@webkit.org's avatar
      [Chromium] Crash in WebCore::DatabaseObserver · 9925d300
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67805
      
      Patch by Stephen Chenney <schenney@chromium.org> on 2011-09-23
      Reviewed by David Levin.
      
      * src/DatabaseObserver.cpp:
      (WebCore::DatabaseObserver::canEstablishDatabase): Added a check for a
      null frame or page, and return false if null. Investigated
      changing the fall-through return value to false but decided against
      it given the way the code is used and existing default values for
      related code. Reproduction and testing depends on having a document
      with no frame or no page, which sometimes happens in practice but is
      hard to construct explicitly.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9925d300
    • commit-queue@webkit.org's avatar
      [Chromium] Fix CSS 3D corner anti-aliasing. · 8aaef514
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68087
      
      Patch by David Reveman <reveman@chromium.org> on 2011-09-23
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Render sharp corners more correctly by adding bounding box
      edges to anti-aliasing shaders.
      
      Test: platform/chromium/compositing/3d-corners.html
      
      * platform/graphics/chromium/ShaderChromium.cpp:
      (WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
      (WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
      (WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
      (WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):
      * platform/graphics/chromium/cc/CCRenderSurface.cpp:
      (WebCore::CCRenderSurface::drawLayer):
      (WebCore::CCRenderSurface::drawSurface):
      * platform/graphics/chromium/cc/CCRenderSurface.h:
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      (WebCore::CCTiledLayerImpl::draw):
      (WebCore::CCTiledLayerImpl::drawTiles):
      * platform/graphics/chromium/cc/CCTiledLayerImpl.h:
      
      LayoutTests:
      
      Add a test to check sharp corner rendering of CSS 3D transformed
      elements.
      
      * platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Removed.
      * platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
      * platform/chromium-gpu-linux/platform/chromium/compositing/3d-corners-expected.png: Added.
      * platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
      * platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
      * platform/chromium/compositing/3d-corners-expected.txt: Added.
      * platform/chromium/compositing/3d-corners.html: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8aaef514
    • mihaip@chromium.org's avatar
      Add failing expectations for tests added by r95852. · b41f7079
      mihaip@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b41f7079
    • oliver@apple.com's avatar
      DFG implementation of PutScopedVar corrupts register allocation · e0dfbb10
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68735
      
      Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-23
      Reviewed by Oliver Hunt.
      
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0dfbb10
    • barraclough@apple.com's avatar
      Updating now-passing Layout test. · 12ab4878
      barraclough@apple.com authored
      Rubber stamped by geoff garen
      
      * fast/js/Object-getOwnPropertyNames-expected.txt:
      * fast/js/script-tests/Object-getOwnPropertyNames.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12ab4878
    • oliver@apple.com's avatar
      Make write barriers actually do something when enabled · 0cae6935
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68717
      
      Reviewed by Geoffrey Garen.
      
      ../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:
      
      Add a basic card marking style write barrier to JSC (currently
      turned off).  This requires two scratch registers in the JIT
      so there was some register re-arranging to satisfy that requirement.
      Happily this produced a minor perf bump in sunspider (~0.5%).
      
      Turning the barriers on causes an overall regression of around 1.5%
      
      * JavaScriptCore.exp:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * assembler/MacroAssemblerX86Common.h:
      (JSC::MacroAssemblerX86Common::store8):
      * assembler/X86Assembler.h:
      (JSC::X86Assembler::movb_i8m):
      * dfg/DFGJITCodeGenerator.cpp:
      (JSC::DFG::JITCodeGenerator::isKnownNotCell):
      (JSC::DFG::JITCodeGenerator::writeBarrier):
      (JSC::DFG::JITCodeGenerator::markCellCard):
      (JSC::DFG::JITCodeGenerator::cachedPutById):
      * dfg/DFGJITCodeGenerator.h:
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::tryCachePutByID):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * heap/CardSet.h: Added.
      (JSC::CardSet::CardSet):
      (JSC::::cardForAtom):
      (JSC::::cardMarkedForAtom):
      (JSC::::markCardForAtom):
      * heap/Heap.cpp:
      * heap/Heap.h:
      (JSC::Heap::addressOfCardFor):
      (JSC::Heap::writeBarrierFastCase):
      * heap/MarkedBlock.h:
      (JSC::MarkedBlock::setDirtyObject):
      (JSC::MarkedBlock::addressOfCardFor):
      (JSC::MarkedBlock::offsetOfCards):
      * jit/JIT.h:
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emit_op_put_by_val):
      (JSC::JIT::emit_op_put_by_id):
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::emit_op_put_scoped_var):
      (JSC::JIT::emit_op_put_global_var):
      (JSC::JIT::emitWriteBarrier):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::emit_op_put_by_val):
      (JSC::JIT::emit_op_put_by_id):
      (JSC::JIT::emitSlow_op_put_by_id):
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::emit_op_put_scoped_var):
      (JSC::JIT::emit_op_put_global_var):
      
      ../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:
      
      Add a forwarding header, and fix an evaluation ordering
      issue that shows up if you try to use write barriers.
      
      * ForwardingHeaders/heap/CardSet.h: Added.
      * bindings/js/JSEventListener.h:
      (WebCore::JSEventListener::jsFunction):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cae6935
    • commit-queue@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=68077 · 82c90401
      commit-queue@webkit.org authored
      SH4 assemblers doesn't refer to executable memory handle.
      
      Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-09-23
      Reviewed by Gavin Barraclough.
      
      * assembler/MacroAssemblerSH4.h:
      (JSC::MacroAssemblerSH4::branch8):
      * assembler/SH4Assembler.h:
      (JSC::SH4Assembler::executableCopy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82c90401
    • jamesr@google.com's avatar
      Avoid updating compositing state during paint · ef5cfe20
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68727
      
      Reviewed by Simon Fraser.
      
      We shouldn't update our compositing state in the middle of a paint. The call to
      updateCompositingAndLayerListsIfNeeded() was added to RenderLayer::paintLayer in r45715, which was intended to
      fix this exact issue. Based off the ChangeLog entries, I think that this was just a typo.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintLayer):
      (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::updateCompositingLayers):
      * rendering/RenderLayerCompositor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef5cfe20
    • inferno@chromium.org's avatar
      Unreviewed. Chromium rebaselines for r95857. · 66af5675
      inferno@chromium.org authored
      * platform/chromium-linux/fast/ruby/ruby-text-before-after-content-expected.png: Added.
      * platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.png: Added.
      * platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66af5675
    • commit-queue@webkit.org's avatar
      occasional crash in Chromium in dispatching keyEvent · aa1f0692
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67941
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-09-23
      Reviewed by Darin Fisher.
      
      Use focusedWebCoreNode() to handle null document for frame when
      retrieving focused node in handling keyEvent.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::keyEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa1f0692
    • fsamuel@chromium.org's avatar
      Refactor paintOverhangAreas to allow non-Mac Chromium platforms to reuse code · 41ed8679
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68648
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      No new tests because there's no change in functionality (yet).
      
      * platform/chromium/ScrollbarThemeChromium.cpp:
      (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
      (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
      (WebCore::ScrollbarThemeChromium::paintOverhangAreas):
      * platform/chromium/ScrollbarThemeChromium.h:
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      
      Source/WebKit/chromium:
      
      * features.gypi:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41ed8679
    • ojan@chromium.org's avatar
      remove physical flex-flow values to match the updated spec · 68237c01
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68728
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator EFlexFlow):
      * css/CSSValueKeywords.in:
      * rendering/style/RenderStyleConstants.h:
      
      LayoutTests:
      
      * css3/flexbox/css-properties-expected.txt:
      * css3/flexbox/script-tests/css-properties.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68237c01
    • inferno@chromium.org's avatar
      Source/WebCore: Style not updated for :before, :after content · b16d1a4c
      inferno@chromium.org authored
      in ruby text.
      https://bugs.webkit.org/show_bug.cgi?id=68625
      
      Reviewed by Dave Hyatt.
      
      Test: fast/ruby/ruby-text-before-after-content.html
      
      * rendering/RenderRubyText.cpp:
      (WebCore::RenderRubyText::updateBeforeAfterContent):
      * rendering/RenderRubyText.h:
      
      LayoutTests: Style not updated for :before, :after content
      in ruby text.
      https://bugs.webkit.org/show_bug.cgi?id=68625
              
      Reviewed by Dave Hyatt.
      
      * fast/ruby/ruby-text-before-after-content-expected.png: Added.
      * fast/ruby/ruby-text-before-after-content-expected.txt: Added.
      * fast/ruby/ruby-text-before-after-content.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b16d1a4c
    • ojan@chromium.org's avatar
      refactor RenderFlexibleBox to use flex-flow aware methods · e3b8170b
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68665
      
      Reviewed by Tony Chang.
      
      This is just a refactor. Just move the all the code that needs to
      be flow aware into helper functions. Actually making them flow-aware
      can be done in a followup patch.
      
      * rendering/RenderBlock.cpp:
      * rendering/RenderBlock.h:
      Moved setLogicalLocationForChild into RenderFlexibleBox since that was the only caller.
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::hasOrthogonalFlow):
      (WebCore::RenderFlexibleBox::isHorizontalFlow):
      (WebCore::RenderFlexibleBox::isLeftToRightFlow):
      (WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
      (WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
      (WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
      (WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
      (WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
      (WebCore::RenderFlexibleBox::flowAwareAvailableLogicalWidth):
      (WebCore::RenderFlexibleBox::flowAwareBorderStart):
      (WebCore::RenderFlexibleBox::flowAwareBorderBefore):
      (WebCore::RenderFlexibleBox::flowAwareBorderAfter):
      (WebCore::RenderFlexibleBox::flowAwarePaddingStart):
      (WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
      (WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
      (WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
      (WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
      (WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
      (WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
      (WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
      (WebCore::RenderFlexibleBox::setFlowAwareLogicalLocationForChild):
      (WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
      (WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
      (WebCore::RenderFlexibleBox::marginStartStyleForChild):
      (WebCore::RenderFlexibleBox::marginEndStyleForChild):
      (WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
      (WebCore::RenderFlexibleBox::layoutInlineDirection):
      (WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
      (WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
      (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
      (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
      (WebCore::RenderFlexibleBox::setLogicalOverrideSize):
      (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
      * rendering/RenderFlexibleBox.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b8170b
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=68719 · 1fb7d582
      hyatt@apple.com authored
              
      Push through multiple regions when an object doesn't fit in any of them. Unlike with pages and
      columns, when regions have a non-uniform height, we may need to push through multiple regions
      in order to find one that fits.
              
      Added an optimization for quickly noticing if regions do have a uniform height so that we can
      treat them like columns and pages if so.
      
      Also fixed the end line matchup to properly null out endLine when no next line box exists. The new
      layout tests I wrote to cover this feature exposed this crasher, so fixing it in order to land
      the new tests.
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Added new tests in fast/regions.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::adjustForUnsplittableChild):
      (WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
      (WebCore::RenderBlock::adjustLinePositionForPagination):
      * rendering/RenderBlock.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::matchedEndLine):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::RenderFlowThread):
      (WebCore::RenderFlowThread::layout):
      * rendering/RenderFlowThread.h:
      
      LayoutTests: 
      
      * fast/regions/webkit-flow-float-pushed-to-last-region.html: Added.
      * fast/regions/webkit-flow-float-unable-to-push.html: Added.
      * platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
      * platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
      * platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
      * platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fb7d582
    • oliver@apple.com's avatar
      PutScopedVar nodes should report that it has a var number · 273cb6ac
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68721
      
      Reviewed by Anders Carlsson.
      
      Another assertion fix.
      
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasVarNumber):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      273cb6ac
    • andersca@apple.com's avatar
      Move WebHitTestResult files to Shared/ in the Xcode project · 3a8d816a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68718
      
      Reviewed by Sam Weinig.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a8d816a
    • jchaffraix@webkit.org's avatar
      Redrawing dirty parts of a large table is very slow · 38e74af0
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64546
      
      Patch by Konstantin Scheglov <scheglov@google.com> on 2011-09-23
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Move CollapsedBorderValues into RenderTable.h.
      Calculate collapsed borders only once and re-use during paintObject().
      Invalidate cache when cell, row, row group, col, col group or table border is changed.
      
      Tests: fast/table/border-collapsing/cached-cell-append.html
             fast/table/border-collapsing/cached-cell-remove.html
             fast/table/border-collapsing/cached-change-cell-border-color.html
             fast/table/border-collapsing/cached-change-cell-border-width.html
             fast/table/border-collapsing/cached-change-col-border-color.html
             fast/table/border-collapsing/cached-change-col-border-width.html
             fast/table/border-collapsing/cached-change-colgroup-border-color.html
             fast/table/border-collapsing/cached-change-colgroup-border-width.html
             fast/table/border-collapsing/cached-change-row-border-color.html
             fast/table/border-collapsing/cached-change-row-border-width.html
             fast/table/border-collapsing/cached-change-table-border-color.html
             fast/table/border-collapsing/cached-change-table-border-width.html
             fast/table/border-collapsing/cached-change-tbody-border-color.html
             fast/table/border-collapsing/cached-change-tbody-border-width.html
      
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::RenderTable):
      (WebCore::RenderTable::styleDidChange): Invalidate cache on border change.
      (WebCore::RenderTable::layout): Invalidate cache if layout changed.
      (WebCore::RenderTable::recalcCollapsedBorders): Ensures that cache is valid.
      (WebCore::RenderTable::paintObject): Use cached collapsed borders.
      * rendering/RenderTable.h:
      (WebCore::RenderTable::invalidateCollapsedBorders): Accessor to mark cache invalid.
      (WebCore::RenderTable::currentBorderValue): Rename to use word "value".
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::styleDidChange): If border changed, invalidate cache.
      
      Rename to use word "value".
      (WebCore::addBorderStyle):
      (WebCore::RenderTableCell::collectBorderValues):
      (WebCore::compareBorderValuesForQSort):
      (WebCore::RenderTableCell::sortBorderValues):
      (WebCore::RenderTableCell::paintCollapsedBorder):
      * rendering/RenderTableCell.h:
      
      If border changed, invalidate cache.
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::styleDidChange):
      * rendering/RenderTableCol.h:
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::styleDidChange):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::styleDidChange):
      
      LayoutTests:
      
      Tests for invalidating collapsed borders cache.
      
      * fast/table/border-collapsing/cached-cell-append-expected.png: Added.
      * fast/table/border-collapsing/cached-cell-append-expected.txt: Added.
      * fast/table/border-collapsing/cached-cell-append.html: Added.
      * fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
      * fast/table/border-collapsing/cached-cell-remove-expected.txt: Added.
      * fast/table/border-collapsing/cached-cell-remove.html: Added.
      * fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-cell-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-cell-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-col-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-col-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-col-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-col-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-row-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-row-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-row-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-table-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-table-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-width.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38e74af0
    • oliver@apple.com's avatar
      Add a bunch of unhandled node types to the propagator · bb4455db
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68716
      
      Reviewed by Darin Adler.
      
      Remove the ASSERT_NOT_REACHED() default for debug builds in the
      prediction propagator, this way unhandled nodes will just cause
      compile time failures rather than failing at some point in the
      future.
      
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb4455db
    • mihaip@chromium.org's avatar
      update layout_tests to account for new default of use_skia=1 · b99a6dfc
      mihaip@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68698
      
      Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
      from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
      (Chromium-on-Mac now uses the Skia graphics library instead of
      Core Graphics).
      
      Also updates layout_test code to work with that change.
      
      Patch by Elliot Poger <epoger@google.com> on 2011-09-23
      Reviewed by Mihai Parparita.
      
      Source/WebKit/chromium:
      
      * DEPS:
      
      Tools:
      
      * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
      * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b99a6dfc
    • mhahnenberg@apple.com's avatar
      Add static version of JSCell::visitChildren · 982c9ea2
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68404
      
      Reviewed by Darin Adler.
      
      .: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * Source/autotools/symbols.filter:
      
      Source/JavaScriptCore: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * API/JSCallbackObject.h:
      (JSC::JSCallbackObject::visitChildrenVirtual):
      (JSC::JSCallbackObject::visitChildren):
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::visitChildrenVirtual):
      (JSC::DebuggerActivation::visitChildren):
      * debugger/DebuggerActivation.h:
      * heap/MarkStack.cpp:
      (JSC::SlotVisitor::visitChildren):
      (JSC::SlotVisitor::drain):
      * runtime/Arguments.cpp:
      (JSC::Arguments::visitChildrenVirtual):
      (JSC::Arguments::visitChildren):
      * runtime/Arguments.h:
      * runtime/Executable.cpp:
      (JSC::EvalExecutable::visitChildrenVirtual):
      (JSC::EvalExecutable::visitChildren):
      (JSC::ProgramExecutable::visitChildrenVirtual):
      (JSC::ProgramExecutable::visitChildren):
      (JSC::FunctionExecutable::visitChildrenVirtual):
      (JSC::FunctionExecutable::visitChildren):
      * runtime/Executable.h:
      * runtime/GetterSetter.cpp:
      (JSC::GetterSetter::visitChildrenVirtual):
      (JSC::GetterSetter::visitChildren):
      * runtime/GetterSetter.h:
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::visitChildrenVirtual):
      (JSC::JSActivation::visitChildren):
      * runtime/JSActivation.h:
      * runtime/JSArray.cpp:
      (JSC::JSArray::visitChildrenVirtual):
      (JSC::JSArray::visitChildren):
      * runtime/JSArray.h:
      * runtime/JSBoundFunction.cpp:
      (JSC::JSBoundFunction::visitChildrenVirtual):
      (JSC::JSBoundFunction::visitChildren):
      * runtime/JSBoundFunction.h:
      * runtime/JSCell.h:
      (JSC::JSCell::visitChildrenVirtual):
      (JSC::JSCell::visitChildren):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::visitChildrenVirtual):
      (JSC::JSFunction::visitChildren):
      * runtime/JSFunction.h:
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::visitChildrenVirtual):
      (JSC::JSGlobalObject::visitChildren):
      * runtime/JSGlobalObject.h:
      * runtime/JSObject.cpp:
      (JSC::JSObject::visitChildrenVirtual):
      (JSC::JSObject::visitChildren):
      * runtime/JSObject.h:
      (JSC::JSObject::visitChildrenDirect):
      * runtime/JSPropertyNameIterator.cpp:
      (JSC::JSPropertyNameIterator::visitChildrenVirtual):
      (JSC::JSPropertyNameIterator::visitChildren):
      * runtime/JSPropertyNameIterator.h:
      * runtime/JSStaticScopeObject.cpp:
      (JSC::JSStaticScopeObject::visitChildrenVirtual):
      (JSC::JSStaticScopeObject::visitChildren):
      * runtime/JSStaticScopeObject.h:
      * runtime/JSWrapperObject.cpp:
      (JSC::JSWrapperObject::visitChildrenVirtual):
      (JSC::JSWrapperObject::visitChildren):
      * runtime/JSWrapperObject.h:
      * runtime/NativeErrorConstructor.cpp:
      (JSC::NativeErrorConstructor::visitChildrenVirtual):
      (JSC::NativeErrorConstructor::visitChildren):
      * runtime/NativeErrorConstructor.h:
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::visitChildrenVirtual):
      (JSC::RegExpObject::visitChildren):
      * runtime/RegExpObject.h:
      * runtime/ScopeChain.cpp:
      (JSC::ScopeChainNode::visitChildrenVirtual):
      (JSC::ScopeChainNode::visitChildren):
      * runtime/ScopeChain.h:
      * runtime/Structure.cpp:
      (JSC::Structure::visitChildrenVirtual):
      (JSC::Structure::visitChildren):
      * runtime/Structure.h:
      * runtime/StructureChain.cpp:
      (JSC::StructureChain::visitChildrenVirtual):
      (JSC::StructureChain::visitChildren):
      * runtime/StructureChain.h:
      
      Source/JavaScriptGlue: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * UserObjectImp.cpp:
      (UserObjectImp::visitChildrenVirtual):
      (UserObjectImp::visitChildren):
      * UserObjectImp.h:
      
      Source/WebCore: 
      
      No new tests.
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * WebCore.exp.in:
      * bindings/js/JSAttrCustom.cpp:
      (WebCore::JSAttr::visitChildrenVirtual):
      (WebCore::JSAttr::visitChildren):
      * bindings/js/JSAudioContextCustom.cpp:
      (WebCore::JSAudioContext::visitChildrenVirtual):
      (WebCore::JSAudioContext::visitChildren):
      * bindings/js/JSCSSRuleCustom.cpp:
      (WebCore::JSCSSRule::visitChildrenVirtual):
      (WebCore::JSCSSRule::visitChildren):
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
      (WebCore::JSCSSStyleDeclaration::visitChildren):
      * bindings/js/JSCanvasRenderingContextCustom.cpp:
      (WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
      (WebCore::JSCanvasRenderingContext::visitChildren):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::visitChildrenVirtual):
      (WebCore::JSDOMGlobalObject::visitChildren):
      * bindings/js/JSDOMGlobalObject.h:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::visitChildrenVirtual):
      (WebCore::JSDOMWindow::visitChildren):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::visitChildrenVirtual):
      (WebCore::JSDOMWindowShell::visitChildren):
      * bindings/js/JSDOMWindowShell.h:
      * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
      (WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
      (WebCore::JSJavaScriptAudioNode::visitChildren):
      * bindings/js/JSMessageChannelCustom.cpp:
      (WebCore::JSMessageChannel::visitChildrenVirtual):
      (WebCore::JSMessageChannel::visitChildren):
      * bindings/js/JSMessagePortCustom.cpp:
      (WebCore::JSMessagePort::visitChildrenVirtual):
      (WebCore::JSMessagePort::visitChildren):
      * bindings/js/JSNamedNodeMapCustom.cpp:
      (WebCore::JSNamedNodeMap::visitChildrenVirtual):
      (WebCore::JSNamedNodeMap::visitChildren):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::JSNode::visitChildrenVirtual):
      (WebCore::JSNode::visitChildren):
      * bindings/js/JSNodeFilterCustom.cpp:
      (WebCore::JSNodeFilter::visitChildrenVirtual):
      (WebCore::JSNodeFilter::visitChildren):
      * bindings/js/JSNodeIteratorCustom.cpp:
      (WebCore::JSNodeIterator::visitChildrenVirtual):
      (WebCore::JSNodeIterator::visitChildren):
      * bindings/js/JSSVGElementInstanceCustom.cpp:
      (WebCore::JSSVGElementInstance::visitChildrenVirtual):
      (WebCore::JSSVGElementInstance::visitChildren):
      * bindings/js/JSSharedWorkerCustom.cpp:
      (WebCore::JSSharedWorker::visitChildrenVirtual):
      (WebCore::JSSharedWorker::visitChildren):
      * bindings/js/JSStyleSheetCustom.cpp:
      (WebCore::JSStyleSheet::visitChildrenVirtual):
      (WebCore::JSStyleSheet::visitChildren):
      * bindings/js/JSTreeWalkerCustom.cpp:
      (WebCore::JSTreeWalker::visitChildrenVirtual):
      (WebCore::JSTreeWalker::visitChildren):
      * bindings/js/JSWebGLRenderingContextCustom.cpp:
      (WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
      (WebCore::JSWebGLRenderingContext::visitChildren):
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::visitChildrenVirtual):
      (WebCore::JSWorkerContext::visitChildren):
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::visitChildrenVirtual):
      (WebCore::JSXMLHttpRequest::visitChildren):
      * bindings/js/JSXPathResultCustom.cpp:
      (WebCore::JSXPathResult::visitChildrenVirtual):
      (WebCore::JSXPathResult::visitChildren):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::JSTestObj::visitChildrenVirtual):
      (WebCore::JSTestObj::visitChildren):
      * bindings/scripts/test/JS/JSTestObj.h:
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
      (JSC::Bindings::QtRuntimeObject::visitChildren):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
      (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
      * bridge/qt/qt_runtime.h:
      * workers/WorkerContext.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      982c9ea2
    • andersca@apple.com's avatar
      Axe WebImageRendererFactory · 6504077a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68715
      
      Reviewed by Darin Adler.
      
      ../..: 
      
      Remove WebImageRendererFactory.m from the Xcode project.
      
      * WebKit.xcodeproj/project.pbxproj:
      
      ../../mac: 
      
      Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.
      
      * WebCoreSupport/WebImageRendererFactory.m: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6504077a
    • andersca@apple.com's avatar
      Add OVERRIDE to a bunch of virtual member functions on clients · 2fccbb0f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68712
      
      Reviewed by Sam Weinig.
      
      ../..: 
      
      * WebKit.xcodeproj/project.pbxproj:
      
      ../../mac: 
      
      * Configurations/Base.xcconfig:
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebContextMenuClient.h:
      * WebCoreSupport/WebDeviceOrientationClient.h:
      * WebCoreSupport/WebDragClient.h:
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebFrameNetworkingContext.h:
      * WebCoreSupport/WebGeolocationClient.h:
      * WebCoreSupport/WebIconDatabaseClient.h:
      * WebCoreSupport/WebInspectorClient.h:
      * WebCoreSupport/WebPlatformStrategies.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fccbb0f
    • oliver@apple.com's avatar
      Node propagation doesn't handle PutScopedVar · 5bc8af1d
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68713
      
      Reviewed by Sam Weinig.
      
      This was causing assertion failures.
      
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bc8af1d
    • jochen@chromium.org's avatar
      Clarify wording in cross origin XSL tests and enable on all platforms · 63184e94
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68683
      
      The condition for passing the test should be more clear now. Also, since the redirect case works on all platforms, the regular case should also work on all platforms.
      
      Reviewed by Alexey Proskuryakov.
      
      * http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * http/tests/security/cross-origin-xsl-BLOCKED.html:
      * http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
      * platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/gtk/Skipped:
      * platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/wk2/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63184e94