1. 13 Jun, 2009 12 commits
    • abarth@webkit.org's avatar
      2009-06-13 Ben Murdoch <benm@google.com> · ea665a21
      abarth@webkit.org authored
              Reviewed by David Kilzer.  Landed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=26189
      
              This patch changes the way PageGroups create their localStorage
              objects. Rather than creating a local storage object for the page group
              when a page is added to the group, the local storage object is now
              created lazily when the local storage object is requested by the
              DOMWindow.
      
              * page/PageGroup.cpp:
              (WebCore::PageGroup::closeLocalStorage): Before attempting to close a local storage object for a page group, ensure one has been created.
              (WebCore::PageGroup::addPage): Do not automatically try to create a local storage object when a page is added to the group.
              (WebCore::PageGroup::localStorage): Create a local storage object if one does not exist and return it.
              * page/PageGroup.h: Add private hasLocalStorage method to PageGroup.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea665a21
    • abarth@webkit.org's avatar
      2009-06-13 Ben Murdoch <benm@google.com> · 1095f23d
      abarth@webkit.org authored
              Reviewed by Eric Seidel.  Landed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=26189
      
              Add ENABLE(DOM_STORAGE) guards to the dom storage source files.
      
              * storage/LocalStorage.cpp: Add ENABLE(DOM_STORAGE) guards to the file.
              * storage/LocalStorage.h: Ditto
              * storage/LocalStorageArea.cpp: Ditto
              * storage/LocalStorageArea.h: Ditto
              * storage/LocalStorageTask.cpp: Ditto
              * storage/LocalStorageTask.h: Ditto
              * storage/LocalStorageThread.cpp: Ditto
              * storage/LocalStorageThread.h: Ditto
              * storage/SessionStorage.cpp: Ditto
              * storage/SessionStorage.h: Ditto
              * storage/SessionStorageArea.cpp: Ditto
              * storage/SessionStorageArea.h: Ditto
              * storage/Storage.cpp: Ditto
              * storage/Storage.h: Ditto
              * storage/StorageArea.cpp: Ditto
              * storage/StorageArea.h: Ditto
              * storage/StorageEvent.cpp: Ditto
              * storage/StorageEvent.h: Ditto
              * storage/StorageMap.cpp: Ditto
              * storage/StorageMap.h: Ditto
              * storage/StorageEvent.idl: Add Conditional=DOM_STORAGE attribute.
              * storage/Storage.idl: Ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1095f23d
    • pkasting@chromium.org's avatar
      2009-06-13 Peter Kasting <pkasting@google.com> · 0da40070
      pkasting@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25709 part ten
              Make Skia use the root directory ImageDecoder.h and factor out most
              Skia-specific bits into skia/ImageDecoderSkia.cpp.  Also fix a pair of
              style violations in ImageDecoderCairo.cpp.  This is the last patch for
              this bug, everything beyond this is an enhancement rather than
              unforking.
      
              * platform/image-decoders/ImageDecoder.h:
              (WebCore::RGBA32Buffer::getAddr):
              * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
              (WebCore::RGBA32Buffer::hasAlpha):
              (WebCore::RGBA32Buffer::setHasAlpha):
              (WebCore::setStatus):
              * platform/image-decoders/skia/ImageDecoder.h: Removed.
              * platform/image-decoders/skia/ImageDecoderSkia.cpp: Added.
              (WebCore::RGBA32Buffer::RGBA32Buffer):
              (WebCore::RGBA32Buffer::clear):
              (WebCore::RGBA32Buffer::zeroFill):
              (WebCore::RGBA32Buffer::copyBitmapData):
              (WebCore::RGBA32Buffer::setSize):
              (WebCore::RGBA32Buffer::asNewNativeImage):
              (WebCore::RGBA32Buffer::hasAlpha):
              (WebCore::RGBA32Buffer::setHasAlpha):
              (WebCore::RGBA32Buffer::setStatus):
              (WebCore::RGBA32Buffer::operator=):
              (WebCore::RGBA32Buffer::width):
              (WebCore::RGBA32Buffer::height):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0da40070
    • abarth@webkit.org's avatar
      2009-06-13 Victor Wang <victorw@chromium.org> · 15a81fcd
      abarth@webkit.org authored
              Reviewed by Eric Seidel.  Landed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=26333
              Alert during a dragenter event handler will crash the renderer
              
              This crash is casued by calling NULL pointer m_documentUnderMouse in
              DragController::tryDocumentDrag()
      
              tryDHTMLDrag fires dragenter event. The event listener that listens
              to this event may create a nested message loop (open a modal dialog),
              which could process dragleave event and reset m_documentUnderMouse in
              dragExited.
      
              Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
              do not continue if the pointer has been set to NULL.
      
              Test: DRT does not show alerts so add a manual test:
                    manual-tests/drag-enter-alert.html
      
              * manual-tests/drag-enter-alert.html: Added.
              * manual-tests/resources/drag-image.png: Added.
              * page/DragController.cpp:
              (WebCore::DragController::tryDocumentDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15a81fcd
    • abarth@webkit.org's avatar
      2009-06-13 Nate Chapin <japhet@google.com> · 82eca6c2
      abarth@webkit.org authored
              Reviewed by Dimitri Glazkov.  Landed by Adam Barth.
      
              Moved V8 Bindings for V8CustomXPathNSResolver to svn.webkit.org.
      
              https://bugs.webkit.org/show_bug.cgi?id=26227
      
              * bindings/v8/custom/V8CustomXPathNSResolver.cpp: Added.
              (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): Moved from src.chromium.org.
              (WebCore::V8CustomXPathNSResolver::~V8CustomXPathNSResolver): Moved from src.chromium.org.
              (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI): Moved from src.chromium.org.
              * bindings/v8/custom/V8CustomXPathNSResolver.h: Added.
              * bindings/v8/custom/V8DocumentCustom.cpp: Updated includes.
              (WebCore::CALLBACK_FUNC_DECL): Updated class name.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82eca6c2
    • abarth@webkit.org's avatar
      2009-06-13 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 689eba06
      abarth@webkit.org authored
              Reviewed by Mark Rowe.  Landed by Adam Barth.
      
              Remove obsolete declarations for old Symbian port
              https://bugs.webkit.org/show_bug.cgi?id=26339
      
              * platform/graphics/FloatPoint.h: Remove declarations for native SYMBIAN adaptation.
              * platform/graphics/FloatRect.h: Ditto.
              * platform/graphics/IntPoint.h: Ditto.
              * platform/graphics/IntRect.h: Ditto.
              * platform/graphics/IntSize.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      689eba06
    • krit@webkit.org's avatar
      2009-06-13 Dirk Schulze <krit@webkit.org> · ec7c26d6
      krit@webkit.org authored
              Reviewed by Eric Seidel.
      
              Added subRegion calculation to SVG filter. Every filter effect is
              clipped to the filter region (according to the spec). This makes
              ImageBuffers for filter effects smaller and we just need to take
              care about big filter regions.
              SVGFEImage needed a correction, to avoid an ASSERT. The two filter
              effects feOffset and feFlood help to test the new subRegion code.
      
              Tests: svg/filters/subRegion-one-effect.svg
                     svg/filters/subRegion-two-effects.svg
      
              Added tests for the new subRgion-code on SVG filters.
      
              * platform/mac/svg/filters: Added.
              * platform/mac/svg/filters/subRegion-one-effect-expected.checksum: Added.
              * platform/mac/svg/filters/subRegion-one-effect-expected.png: Added.
              * platform/mac/svg/filters/subRegion-one-effect-expected.txt: Added.
              * platform/mac/svg/filters/subRegion-two-effects-expected.checksum: Added.
              * platform/mac/svg/filters/subRegion-two-effects-expected.png: Added.
              * platform/mac/svg/filters/subRegion-two-effects-expected.txt: Added.
              * svg/filters: Added.
              * svg/filters/subRegion-one-effect.svg: Added.
              * svg/filters/subRegion-two-effects.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec7c26d6
    • pkasting@chromium.org's avatar
      2009-06-13 Peter Kasting <pkasting@google.com> · fa104a99
      pkasting@chromium.org authored
              Bustage: Fix broken GIFs on Cairo due to subtle typo.  Fix a warning.
      
              * platform/image-decoders/ImageDecoder.h:
              (WebCore::RGBA32Buffer::copyRowNTimes):
              * platform/image-decoders/bmp/BMPImageReader.cpp:
              (WebCore::BMPImageReader::processBitmasks):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa104a99
    • pkasting@chromium.org's avatar
      2009-06-13 Peter Kasting <pkasting@google.com> · ea7ce88e
      pkasting@chromium.org authored
              GTK bustage fix.  "inline" is handled differently by different compilers.
      
              * platform/image-decoders/ImageDecoder.h:
              (WebCore::RGBA32Buffer::getAddr):
              * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea7ce88e
    • pkasting@chromium.org's avatar
      2009-06-13 Peter Kasting <pkasting@google.com> · e0a21476
      pkasting@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25709 part nine
              Factor Cairo-specific implementation out of ImageDecoder.h into
              ImageDecoderCairo.cpp.  Add some comments to functions declared
              in ImageDecoder.h.
      
              * GNUmakefile.am:
              * WebCore.vcproj/WebCore.vcproj:
              * platform/image-decoders/ImageDecoder.h:
              * platform/image-decoders/cairo: Added.
              * platform/image-decoders/cairo/ImageDecoderCairo.cpp: Added.
              (WebCore::RGBA32Buffer::RGBA32Buffer):
              (WebCore::RGBA32Buffer::clear):
              (WebCore::RGBA32Buffer::zeroFill):
              (WebCore::RGBA32Buffer::copyBitmapData):
              (WebCore::RGBA32Buffer::setSize):
              (WebCore::RGBA32Buffer::asNewNativeImage):
              (WebCore::RGBA32Buffer::hasAlpha):
              (WebCore::RGBA32Buffer::setHasAlpha):
              (WebCore::RGBA32Buffer::operator=):
              (WebCore::RGBA32Buffer::width):
              (WebCore::RGBA32Buffer::height):
              (WebCore::RGBA32Buffer::getAddr):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0a21476
    • hyatt@apple.com's avatar
      2009-06-13 David Hyatt <hyatt@apple.com> · 1a5ffd8e
      hyatt@apple.com authored
              Reviewed by Darin Adler.
      
              Cleanup of the new MidpointState class.  Turn it into a struct instead.  Fix a mistaken
              assertion removal and some unintentional whitespace changes.
      
              * platform/text/BidiResolver.h:
              (WebCore::MidpointState::reset):
              * rendering/RenderBlock.h:
              * rendering/bidi.cpp:
              (WebCore::BidiRun::operator delete):
              (WebCore::chopMidpointsAt):
              (WebCore::checkMidpoints):
              (WebCore::addMidpoint):
              (WebCore::appendRunsForObject):
              (WebCore::RenderBlock::findNextLineBreak):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a5ffd8e
    • hyatt@apple.com's avatar
      2009-06-12 David Hyatt <hyatt@apple.com> · b3466afc
      hyatt@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=26367
      
              Remove the global variables in bidi.cpp.  Make a new struct, MidpointState, that holds all of the
              midpoint information.  Add the remaining global variables as arguments passed down through functions
              as needed.
      
              * platform/text/BidiResolver.h:
              (WebCore::MidpointState::MidpointState):
              (WebCore::MidpointState::reset):
              (WebCore::BidiResolver::midpointState):
              * rendering/RenderBlock.h:
              * rendering/bidi.cpp:
              (WebCore::BidiRun::operator delete):
              (WebCore::chopMidpointsAt):
              (WebCore::checkMidpoints):
              (WebCore::addMidpoint):
              (WebCore::appendRunsForObject):
              (WebCore::RenderBlock::bidiReorderLine):
              (WebCore::RenderBlock::layoutInlineChildren):
              (WebCore::RenderBlock::determineStartPosition):
              (WebCore::skipNonBreakingSpace):
              (WebCore::shouldCollapseWhiteSpace):
              (WebCore::requiresLineBox):
              (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
              (WebCore::RenderBlock::skipTrailingWhitespace):
              (WebCore::RenderBlock::skipLeadingWhitespace):
              (WebCore::shouldSkipWhitespaceAfterStartObject):
              (WebCore::RenderBlock::findNextLineBreak):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3466afc
  2. 12 Jun, 2009 18 commits
    • zecke@webkit.org's avatar
      Build fix for Qt. After recent ImageDeocder.h changes. · 2eeb97b5
      zecke@webkit.org authored
      I want the original change to be backed out as the whole
      Skia merging is going in the wrong direction. The discussion
      will happen in the bugtracker.
      
      https://bugs.webkit.org/show_bug.cgi?id=25709.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2eeb97b5
    • jmalonzo@webkit.org's avatar
      2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org> · f86a8ea6
      jmalonzo@webkit.org authored
              Gtk build fix: include cstdio so we can use sscanf
      
              Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
              Suggested by Brent Fulgham
      
              * platform/image-decoders/xbm/XBMImageDecoder.cpp:
              (WebCore::XBMImageDecoder::decodeDatum):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f86a8ea6
    • pkasting@chromium.org's avatar
      2009-06-12 Peter Kasting <pkasting@google.com> · ace59596
      pkasting@chromium.org authored
              Yet another Skia bustage fix.
      
              * platform/image-decoders/skia/ImageDecoder.h:
              (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash.  The better fix is to take an IntSize(); I'll do that later.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ace59596
    • pkasting@chromium.org's avatar
      2009-06-12 Peter Kasting <pkasting@google.com> · 6e3aec20
      pkasting@chromium.org authored
              Fix remaining Cairo build bustage from
              https://bugs.webkit.org/show_bug.cgi?id=25709 changes.  Use
              Vector<char> in place of std::string.
      
              * platform/image-decoders/xbm/XBMImageDecoder.cpp:
              (WebCore::XBMImageDecoder::setData):
              (WebCore::XBMImageDecoder::decodeHeader):
              (WebCore::XBMImageDecoder::decodeDatum):
              * platform/image-decoders/xbm/XBMImageDecoder.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e3aec20
    • levin@chromium.org's avatar
      JavaScriptCore: · 1ef10580
      levin@chromium.org authored
      2009-06-12  David Levin  <levin@chromium.org>
      
              Reviewed by Darin Adler.
      
              UString shouldn't create sharedBuffer for SmallStrings.
              https://bugs.webkit.org/show_bug.cgi?id=26360
      
              The methods changed are not used by JSC, so there is no JS perf impact.  However,
              there is a potential DOM perf impact, so I re-ran several of the tests that
              I ran previously and ensured that the perf stay the same which caused me to
              adjust the minLengthToShare.
      
              * JavaScriptCore.exp:
              * runtime/UString.cpp:
              (JSC::UString::Rep::sharedBuffer):
                  Determines if the buffer being shared is big enough before doing so.
                  Previously, BaseString::sharedBuffer was called but it would only know
                  the length of the base string (BaseString::len) which may not be the same
                  as the string being shared (Rep::len).
              (JSC::UString::BaseString::sharedBuffer):
                  This is now only be used by Rep::sharedBuffer. which does the length check.
              * runtime/UString.h:
      
      WebCore:
      
      2009-06-12  David Levin  <levin@chromium.org>
      
              Reviewed by Darin Adler.
      
              UString shouldn't create sharedBuffer for SmallStrings.
              https://bugs.webkit.org/show_bug.cgi?id=26347
      
              Change the call to use the method UString::Rep::sharedBuffer due
              to changes in UString.
      
              No noticable change in behavior, so no test.
      
              * platform/text/StringImpl.cpp:
              (WebCore::StringImpl::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ef10580
    • simon.fraser@apple.com's avatar
      2009-06-12 Simon Fraser <simon.fraser@apple.com> · e553b25a
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein
      
              https://bugs.webkit.org/show_bug.cgi?id=26095
      
              Fix crash when a renderer for an anonymous node is composited
              by null-checking renderer()->node().
      
              Test: compositing/generated-content.html
      
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::createGraphicsLayer):
              (WebCore::RenderLayerBacking::rendererHasBackground):
              (WebCore::RenderLayerBacking::rendererBackgroundColor):
              (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
              (WebCore::RenderLayerBacking::paintIntoLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e553b25a
    • pkasting@chromium.org's avatar
      2009-06-12 Peter Kasting <pkasting@google.com> · 282482eb
      pkasting@chromium.org authored
              Fix Chromium and some of Cairo build bustage, fallout from
              https://bugs.webkit.org/show_bug.cgi?id=25709 changes.
      
              * WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
              * platform/image-decoders/skia/ImageDecoder.h:
              (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      282482eb
    • simon.fraser@apple.com's avatar
      2009-06-12 Simon Fraser <simon.fraser@apple.com> · 721311f4
      simon.fraser@apple.com authored
              Fix build when ACCELERATED_COMPOSITING is defined.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::attachRootGraphicsLayer):
              (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization):
              (WebCore::EmptyChromeClient::scheduleViewUpdate):
              Add stubs for the compositing-related ChromeClient methods.
      
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::updateRootLayerPosition):
              (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
              docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which
              matches what is used to size the WebHTMLView.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      721311f4
    • dimich@chromium.org's avatar
      2009-06-12 jorlow <jorlow@chromium.org> · 709bab38
      dimich@chromium.org authored
              Reviewed by David Levin.
      
              https://bugs.webkit.org/show_bug.cgi?id=26356
              http://crbug.com/14006
              Create custom bindings for v8.  The rest of these files are still
              forked (so the review is happening on the chromium review site).
              These bindings have been tested on a hacked up Chromium instance
              (also running --single-process) and Android.
      
              * bindings/v8/custom/V8StorageCustom.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      709bab38
    • dimich@chromium.org's avatar
      2009-06-12 Dmitry Titov <dimich@chromium.org> · 4fd3295a
      dimich@chromium.org authored
              Reviewed by David Levin.
      
              https://bugs.webkit.org/show_bug.cgi?id=26359
              [v8] Add XMLHttpRequest to WorkerContextExecutionProxy.
      
              * bindings/v8/WorkerContextExecutionProxy.cpp:
              (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types.
              (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
              * bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fd3295a
    • pkasting@chromium.org's avatar
      2009-06-12 Peter Kasting <pkasting@google.com> · 10e5b780
      pkasting@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
              Replace placeholder Cairo BMP, ICO, XBM decoders with real ones.  Remove
              all the decoders from skia/ since they are now just mirrors of the Cairo
              ones.
      
              * GNUmakefile.am:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCoreSources.bkl:
              * platform/graphics/cairo/ImageSourceCairo.cpp:
              (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.  Enable XBM decoding on Windows.
              * platform/graphics/skia/ImageSourceSkia.cpp:
              * platform/graphics/wx/ImageSourceWx.cpp:
              (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
              * platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
              * platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
              * platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
              * platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
              * platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
              * platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
              * platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
              * platform/image-decoders/skia/BMPImageDecoder.h: Removed.
              * platform/image-decoders/skia/BMPImageReader.cpp: Removed.
              * platform/image-decoders/skia/BMPImageReader.h: Removed.
              * platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
              * platform/image-decoders/skia/GIFImageDecoder.h: Removed.
              * platform/image-decoders/skia/GIFImageReader.cpp: Removed.
              * platform/image-decoders/skia/GIFImageReader.h: Removed.
              * platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
              * platform/image-decoders/skia/ICOImageDecoder.h: Removed.
              * platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
              * platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
              * platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
              * platform/image-decoders/skia/PNGImageDecoder.h: Removed.
              * platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
              * platform/image-decoders/skia/XBMImageDecoder.h: Removed.
              * platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
              * platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10e5b780
    • pkasting@chromium.org's avatar
      2009-06-11 Peter Kasting <pkasting@google.com> · 6b9aef2c
      pkasting@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
              Update Skia's ImageDecoder.h with a few changes designed to reduce the
              delta between specific implementations of ImageDecoder.h.  Update
              Cairo's ImageDecoder.h to sync up with the API changes in the Skia
              version in the last two chage sets.  Update Cairo's PNG/JPEG/GIF
              decoders to use the APIs as well.  All the Cairo image decoder changes
              are direct copies of the Skia versions except ImageDecoder.h, which is
              modified in the necessary ways for the differences between Cairo and
              Skia.
      
              * platform/graphics/cairo/ImageSourceCairo.cpp:
              (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
              * platform/image-decoders/ImageDecoder.h: Sync up with Skia version.
              (WebCore::RGBA32Buffer::):
              (WebCore::RGBA32Buffer::RGBA32Buffer):
              (WebCore::RGBA32Buffer::clear):
              (WebCore::RGBA32Buffer::zeroFill):
              (WebCore::RGBA32Buffer::copyBitmapData):
              (WebCore::RGBA32Buffer::copyRowNTimes):
              (WebCore::RGBA32Buffer::setSize):
              (WebCore::RGBA32Buffer::asNewNativeImage):
              (WebCore::RGBA32Buffer::hasAlpha):
              (WebCore::RGBA32Buffer::disposalMethod):
              (WebCore::RGBA32Buffer::setHasAlpha):
              (WebCore::RGBA32Buffer::setDisposalMethod):
              (WebCore::RGBA32Buffer::setRGBA):
              (WebCore::RGBA32Buffer::operator=):
              (WebCore::RGBA32Buffer::width):
              (WebCore::RGBA32Buffer::height):
              (WebCore::RGBA32Buffer::getAddr):
              * platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version.
              (WebCore::GIFImageDecoder::initFrameBuffer):
              (WebCore::GIFImageDecoder::haveDecodedRow):
              * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version.
              (WebCore::JPEGImageDecoder::outputScanlines):
              * platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version.
              (WebCore::PNGImageDecoder::rowAvailable):
              * platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version.  Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability.
              (WebCore::RGBA32Buffer::):
              (WebCore::RGBA32Buffer::copyRowNTimes):
              (WebCore::RGBA32Buffer::setSize):
              (WebCore::RGBA32Buffer::asNewNativeImage):
              (WebCore::RGBA32Buffer::hasAlpha):
              (WebCore::RGBA32Buffer::disposalMethod):
              (WebCore::RGBA32Buffer::setHasAlpha):
              (WebCore::RGBA32Buffer::setStatus):
              (WebCore::RGBA32Buffer::setDisposalMethod):
              (WebCore::RGBA32Buffer::setRGBA):
              (WebCore::RGBA32Buffer::operator=):
              (WebCore::RGBA32Buffer::width):
              (WebCore::RGBA32Buffer::height):
              (WebCore::RGBA32Buffer::getAddr):
              * platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b9aef2c
    • bfulgham@webkit.org's avatar
      2009-06-12 Brent Fulgham <bfulgham@webkit.org> · 147773fa
      bfulgham@webkit.org authored
              Unreviewed build correction.
      
              Revert accidental configuration checkin.  Was not meant to
              be part of the last changeset.
      
              * config.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      147773fa
    • bfulgham@webkit.org's avatar
      2009-06-12 Brent Fulgham <bfulgham@webkit.org> · 1d791242
      bfulgham@webkit.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=26353
              Corrects handling of Cairo fonts that were getting out of
              sync due to default copy construction.  Also refactors
              some incorrect platform font destruction code that belongs
              in the font object's destructor.
      
              * platform/graphics/win/FontPlatformData.h:
              * platform/graphics/win/FontPlatformDataCGWin.cpp:
              (WebCore::FontPlatformData::~FontPlatformData):
              * platform/graphics/win/FontPlatformDataCairoWin.cpp:
              (WebCore::FontPlatformData::platformDataInit):
              (WebCore::FontPlatformData::FontPlatformData):
              (WebCore::FontPlatformData::setFont):
              (WebCore::FontPlatformData::~FontPlatformData):
              * platform/graphics/win/FontPlatformDataWin.cpp:
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformWidthForGlyph):
              * platform/graphics/win/SimpleFontDataWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d791242
    • pkasting@chromium.org's avatar
      JavaScriptCore: · a3a95dfb
      pkasting@chromium.org authored
      2009-06-12  Peter Kasting  <pkasting@google.com>
      
              Reviewed by Eric Seidel.
      
              * ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.
      
      WebCore:
      
      2009-06-12  Peter Kasting  <pkasting@google.com>
      
              Reviewed by Eric Seidel.
      
              * ChangeLog-2007-10-14: Update my email address.
              * ChangeLog-2008-08-10: Update my email address.
      
      WebKit/mac:
      
      2009-06-12  Peter Kasting  <pkasting@google.com>
      
              Reviewed by Eric Seidel.
      
              * ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.
      
      WebKit/win:
      
      2009-06-12  Peter Kasting  <pkasting@google.com>
      
              Reviewed by Eric Seidel.
      
              * ChangeLog: Update my email address.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3a95dfb
    • levin@chromium.org's avatar
      2009-06-12 Nate Chapin <japhet@google.com> · 072383c5
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Upstream V8Helpers.
      
              https://bugs.webkit.org/show_bug.cgi?id=26332
      
              * bindings/v8/V8Helpers.cpp: Added.
              (wrapNPObject): Moved from v8_helpers.cpp.
              (toV8Context): Moved from v8_helpers.cpp.
              (toV8Proxy): Moved from v8_helpers.cpp.
              * bindings/v8/V8Helpers.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      072383c5
    • jberlin@apple.com's avatar
      Index: WebCore/ChangeLog · 50b7aa71
      jberlin@apple.com authored
      ===================================================================
      --- WebCore/ChangeLog	(revision 44622)
      +++ WebCore/ChangeLog	(working copy)
      @@ -1,3 +1,23 @@
      +2009-06-12  Jessie Berlin  <jberlin@apple.com>
      +
      +        Reviewed by Mark Rowe.
      +
      +        https://bugs.webkit.org/show_bug.cgi?id=24792
      +        rdar://problem/6933055
      +
      +        Changes the radius in which cursor movement around the 4 arrow icon
      +        while pan-scrolling does not cause scrolling from around 10 pixels to
      +        15 pixels, similar to what is found in IE and Firefox.
      +
      +        * page/EventHandler.cpp:
      +        (WebCore::EventHandler::setPanScrollCursor):
      +        Factor out the no-pan-scroll radius.
      +        * platform/ScrollView.h:
      +        Create a constant for the no-pan-scroll radius.
      +        * rendering/RenderLayer.cpp:
      +        (WebCore::RenderLayer::panScrollFromPoint):
      +        Factor out the no-pan-scroll radius.
      +
       2009-06-12  Xan Lopez  <xlopez@igalia.com>
       
               Reviewed by Gustavo Noronha.
      Index: WebCore/page/EventHandler.cpp
      ===================================================================
      --- WebCore/page/EventHandler.cpp	(revision 44622)
      +++ WebCore/page/EventHandler.cpp	(working copy)
      @@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()
       
           // At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
           // So we don't want to change the cursor over this area
      -    const int noScrollRadius = 9;
      -    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
      -    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
      -    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
      -    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);
      +    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
      +    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
      +    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
      +    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);
                
           if (north) {
               if (east)
      Index: WebCore/platform/ScrollView.h
      ===================================================================
      --- WebCore/platform/ScrollView.h	(revision 44622)
      +++ WebCore/platform/ScrollView.h	(working copy)
      @@ -214,7 +214,8 @@ public:
           virtual void hide();
           virtual void setParentVisible(bool);
           
      -    // Pan scrolling methods.
      +    // Pan scrolling.
      +    static const int noPanScrollRadius = 15;
           void addPanScrollIcon(const IntPoint&);
           void removePanScrollIcon();
       
      Index: WebCore/rendering/RenderLayer.cpp
      ===================================================================
      --- WebCore/rendering/RenderLayer.cpp	(revision 44622)
      +++ WebCore/rendering/RenderLayer.cpp	(working copy)
      @@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con
           const int shortDistanceLimit = 100;  // We delimit a 200 pixels long square enclosing the original point
           const int speedReducer = 2;          // Within this square we divide the scrolling speed by 2
           
      -    const int iconRadius = 10;
           Frame* frame = renderer()->document()->frame();
           if (!frame)
               return;
      @@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con
           int xDelta = currentMousePosition.x() - sourcePoint.x();
           int yDelta = currentMousePosition.y() - sourcePoint.y();
       
      -    if (abs(xDelta) < iconRadius) // at the center we let the space for the icon
      +    if (abs(xDelta) < ScrollView::noPanScrollRadius) // at the center we let the space for the icon
               xDelta = 0;
      -    if (abs(yDelta) < iconRadius)
      +    if (abs(yDelta) < ScrollView::noPanScrollRadius)
               yDelta = 0;
       
           // Let's attenuate the speed for the short distances
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50b7aa71
    • xan@webkit.org's avatar
      2009-06-12 Xan Lopez <xlopez@igalia.com> · f5b9f7d1
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=25609
              [GTK] Implement support for get_selection and get_n_selections
      
              Only use the VisibleSelection object if it actually belongs to the
              object we are using.
      
              This is pretty hacky-ish, but I can't seem to find a direct API to
              get the VisibleSelection for a given object, only the global one.
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (selectionBelongsToObject):
              (webkit_accessible_text_get_n_selections):
              (webkit_accessible_text_get_selection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5b9f7d1
  3. 11 Jun, 2009 4 commits
  4. 10 Jun, 2009 6 commits
    • pkasting@chromium.org's avatar
      2009-06-10 Peter Kasting <pkasting@google.com> · 2c3b8b1d
      pkasting@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25709 part six
              Miscellaneous tiny changes.  The important bits here are the ANSI C++
              compliance fix in skia/ImageDecoders.h (needed to compile this file on
              non-MSVC) and some behavioral fixes for the XBM decoder that Chromium
              unit tests partly exposed.  Other changes are mostly cosmetic.
      
              * platform/image-decoders/ImageDecoder.h: Make some variables private again.  This will break QTWebKit but those guys have agreed to wait on my finishing the ImageDecoder changes.
              * platform/image-decoders/gif/GIFImageDecoder.cpp:
              (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0).
              (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
              * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
              (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
              * platform/image-decoders/png/PNGImageDecoder.cpp:
              (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
              * platform/image-decoders/skia/BMPImageReader.cpp:
              (WebCore::BMPImageReader::decodeBMP): Make more in line with other decoders' comments and structure, use a ref to decrease verbosity.
              (WebCore::BMPImageReader::processRLEData): Use a ref to decrease verbosity.
              (WebCore::BMPImageReader::processNonRLEData): Use a ref to decrease verbosity.
              * platform/image-decoders/skia/GIFImageDecoder.cpp: Use IntPoint() instead of the redundant IntPoint(0, 0).
              (WebCore::GIFImageDecoder::initFrameBuffer): Use IntPoint() instead of the redundant IntPoint(0, 0).
              (WebCore::GIFImageDecoder::frameComplete): Use IntPoint() instead of the redundant IntPoint(0, 0).
              * platform/image-decoders/skia/ImageDecoder.h:
              (WebCore::RGBA32Buffer::copyRowNTimes): Fix ANSI violation that MSVC let me compile (!).
              * platform/image-decoders/skia/JPEGImageDecoder.cpp:
              (WebCore::JPEGImageDecoder::outputScanlines): Remove obvious comments.
              * platform/image-decoders/skia/PNGImageDecoder.cpp:
              (WebCore::PNGImageDecoder::rowAvailable): Remove obvious comments.
              * platform/image-decoders/skia/XBMImageDecoder.cpp:
              (WebCore::XBMImageDecoder::frameBufferAtIndex): Return 0 for non-zero indexes, don't try to decode unnecessarily after failure or when the size couldn't be computed, make more in line with other decoders' comments and structure, call RGBA32Buffer::setRect() appropriately.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c3b8b1d
    • ojan@chromium.org's avatar
      Fix collapsing empty shadow nodes in textareas. · 6f202efb
      ojan@chromium.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f202efb
    • xan@webkit.org's avatar
      2009-06-10 Xan Lopez <xlopez@igalia.com> · be75e3e8
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=25609
              [GTK] Implement support for get_selection and get_n_selections
      
              Implement atk_text_get_n_selections.
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (webkit_accessible_text_get_n_selections):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be75e3e8
    • mitz@apple.com's avatar
      WebCore: · af63be9e
      mitz@apple.com authored
              Reviewed by Anders Carlsson.
      
              - fix <rdar://problem/6958664> REGRESSION (r42665): When I drag to pan a
                Google map in iPhoto Places, it drags a map tile instead
      
              Calling stopLoadRequest() from notifyFinished() removed the
              ScriptElementData from the CachedScript's client set, which could make
              it eligible for purging. The fix is to call removeClient() only after
              executing the script, which protects it from being purged while it is
              in the document's queue of scripts to execute soon.
      
              * dom/ScriptElement.cpp:
              (WebCore::ScriptElementData::execute): Call removeClient() here.
              (WebCore::ScriptElementData::notifyFinished): Instead of calling
              stopLoadRequest(), which calls removeClient(), just reset
              m_cachedScript.
      
      WebKitTools:
      
              Reviewed by Adele Peterson.
      
              - add a LayoutTestController method for temporarily changing the WebKit
                cache model
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setCacheModelCallback): Added. Calls
              LayoutTestController::setCacheModel() with the first argument as an
              integer.
              (LayoutTestController::staticFunctions): Added setCacheModel.
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setCacheModel):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (setDefaultsToConsistentValuesForTesting): Reset the cache model to
              WebCacheModelDocumentBrowser.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setCacheModel): Added. Calls -[WebPreferences
              setCacheModel:].
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setCacheModel):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setCacheModel):
      
      LayoutTests:
      
              Reviewed by Adele Peterson.
      
              - updated test to cover <rdar://problem/6958664> REGRESSION (r42665):
                When I drag to pan a Google map in iPhoto Places, it drags a map tile
                instead
      
              * fast/dom/HTMLScriptElement/nested-execution.html:
              * fast/dom/HTMLScriptElement/resources/nested-execution.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af63be9e
    • jmalonzo@webkit.org's avatar
      2009-06-10 Jan Michael Alonzo <jmalonzo@webkit.org> · dee30d27
      jmalonzo@webkit.org authored
              Reviewed by Mark Rowe and Eric Seidel.
      
              Update WebInspector localizedStrings.js with new resource tracking strings
              https://bugs.webkit.org/show_bug.cgi?id=26247
      
              * English.lproj/localizedStrings.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dee30d27
    • bfulgham@webkit.org's avatar
      2009-06-10 Feng Qian <feng@chromium.org> · 2a9c3b72
      bfulgham@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add Android specific files.
              https://bugs.webkit.org/show_bug.cgi?id=26280
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a9c3b72