- 10 Dec, 2010 25 commits
-
-
pfeldman@chromium.org authored
Not reviewed. Updated chromium test expectations. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jocelyn.turcotte@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Make QtTestBrowser spawn QNAM in a secondary thread. A menu allows to switch QNAM back to the same thread. * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView): (LauncherWindow::createChrome): (LauncherWindow::toggleThreadedQnam): * QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions): * QtTestBrowser/webpage.cpp: (WebPage::WebPage): (WebPage::setQnamThreaded): * QtTestBrowser/webpage.h: (QnamThread::QnamThread): (QnamThread::~QnamThread): (QnamThread::networkAccessManager): (QnamThread::run): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Not reviewed. Mark inspector tests as slow in Chromium expectations. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jocelyn.turcotte@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Support a QNetworkAccessManager affined to a different thread. https://bugs.webkit.org/show_bug.cgi?id=50080 This patch introduce thread safe proxy classes for QNetworkAccessManager and QNetworkReply. If run in the same thread, these objects will forward the calls with Qt::DirectConnection bindings, while in the other case they will use Qt::QueuedConnection to carry requests accross threads. This patch basically: - Makes sure that all access goes through these objects - Reorders signal connections to make sure we are connected when the signal comes - Makes sure that no QObject in the WebCore thread is a child of the reply which might be in a different thread. - Forward the data directly in QByteArrays in signals instead of collecting the data when the signal is handled. New test: tst_QWebPage::networkAccessManagerOnDifferentThread * WebCore.pro: * platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad): * platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::FormDataIODevice::FormDataIODevice): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::~QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::setLoadMode): (WebCore::QNetworkReplyHandler::abort): (WebCore::QNetworkReplyHandler::release): (WebCore::ignoreHttpError): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::start): (WebCore::QNetworkReplyHandler::sendQueuedItems): * platform/network/qt/QNetworkReplyHandler.h: * platform/network/qt/QtNAMThreadSafeProxy.cpp: Added. * platform/network/qt/QtNAMThreadSafeProxy.h: Added. * platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::willLoadFromCache): * platform/qt/CookieJarQt.cpp: (WebCore::networkAccessManager): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): 2010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> Reviewed by Kenneth Rohde Christiansen. [Qt] Support a QNetworkAccessManager affined to a different thread. https://bugs.webkit.org/show_bug.cgi?id=50080 This patch introduce thread safe proxy classes for QNetworkAccessManager and QNetworkReply. If run in the same thread, these objects will forward the calls with Qt::DirectConnection bindings, while in the other case they will use Qt::QueuedConnection to carry requests accross threads. This patch basically: - Makes sure that all access goes through these objects - Reorders signal connections to make sure we are connected when the signal comes - Makes sure that no QObject in the WebCore thread is a child of the reply which might be in a different thread. - Forward the data directly in QByteArrays in signals instead of collecting the data when the signal is handled. New test: tst_QWebPage::networkAccessManagerOnDifferentThread * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): * tests/qwebpage/tst_qwebpage.cpp: (QtNAMThread::QtNAMThread): (QtNAMThread::~QtNAMThread): (QtNAMThread::networkAccessManager): (QtNAMThread::run): (tst_QWebPage::networkAccessManagerOnDifferentThread): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Flush IPC connection send buffer after each message. [Qt] [WK2] IPC messages are not sent until send buffer fills up https://bugs.webkit.org/show_bug.cgi?id=50667 * Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::sendOutgoingMessage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jocelyn.turcotte@nokia.com authored
https://bugs.webkit.org/show_bug.cgi?id=50761 Reviewed by Kenneth Rohde Christiansen. This patch change the order to check if m_reply is null instead, explicitly deleting the reply before calling start() for a redirect, or after calling didFinishLoading()/didFail() in other cases. * platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jocelyn.turcotte@nokia.com authored
https://bugs.webkit.org/show_bug.cgi?id=50760 Reviewed by Kenneth Rohde Christiansen. This patch make sure the data available flag is set before we call sendResponseIfNeeded. * platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::finish): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded): (WebCore::QNetworkReplyHandler::forwardData): (WebCore::QNetworkReplyHandler::resetState): * platform/network/qt/QNetworkReplyHandler.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Dan Bernstein. Bopomofo should be part of CJK Ideographs in WebCore/platform/graphics/Font.cpp https://bugs.webkit.org/show_bug.cgi?id=50668 No new tests. Note that, as said in the bug report discussion, I did have a test case for the bug. However, to show the test case you need some "broken" Microsoft copyrighted fonts, such as DFKai-SB. * platform/graphics/Font.cpp: (WebCore::Font::isCJKIdeograph): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Reviewed by Gustavo Noronha Silva. [GStreamer] un-needed methods https://bugs.webkit.org/show_bug.cgi?id=50805 No new tests, code cleanup only. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Eric Seidel. Cleanup StringWx.cpp https://bugs.webkit.org/show_bug.cgi?id=50525 Use StringImpl::createUninitialized to avoid memcpy and fix style issues. * wtf/wx/StringWx.cpp: (WTF::String::String): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Martin Robinson. [GTK] Simplify context-menu handling code https://bugs.webkit.org/show_bug.cgi?id=49658 * wtf/PlatformRefPtr.h: 2010-12-10 Carlos Garcia Campos <cgarcia@igalia.com> Reviewed by Martin Robinson. [GTK] Simplify context-menu handling code https://bugs.webkit.org/show_bug.cgi?id=49658 * platform/ContextMenuItem.h: * platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::appendItem): * platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Reviewed by Martin Robinson. [GTK] Split webkitprivate.{cpp,h} in more manageable chunks https://bugs.webkit.org/show_bug.cgi?id=50698 Split private bits of WebKitWebInspector to its own private header, and to its implementation file. * WebCoreSupport/InspectorClientGtk.cpp: * webkit/webkitprivate.cpp: * webkit/webkitprivate.h: * webkit/webkitwebinspector.cpp: (isSchemaAvailable): (inspectorGSettings): * webkit/webkitwebinspectorprivate.h: Added. * webkit/webkitwebview.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Reviewed by Martin Robinson. [GTK] Split webkitprivate.{cpp,h} in more manageable chunks https://bugs.webkit.org/show_bug.cgi?id=50698 Split private bits of WebKitNetworkRequest to its own private header, and to its implementation file. Also take the opportunity to use PlatformRefPtr for NetworkRequest where it makes sense, and make the creation less verbose by adding kitNew. * WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::download): (WebKit::FrameLoaderClient::startDownload): * webkit/webkitdownload.cpp: * webkit/webkitnetworkrequest.cpp: (WebKit::kitNew): (WebKit::core): * webkit/webkitnetworkrequestprivate.h: Added. * webkit/webkitprivate.cpp: * webkit/webkitprivate.h: * webkit/webkitwebdatasource.cpp: (webkit_web_data_source_get_initial_request): (webkit_web_data_source_get_request): * webkit/webkitwebframe.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Reviewed by Gustavo Noronha Silva. [GStreamer] data: source could also support non-base64 encoded URIs https://bugs.webkit.org/show_bug.cgi?id=30007 Removed our ancient implementation of dataurisrc. We should now use the one in gst-plugins-bad which is more mature. * GNUmakefile.am: * platform/graphics/gstreamer/DataSourceGStreamer.cpp: Removed. * platform/graphics/gstreamer/DataSourceGStreamer.h: Removed. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::doGstInit): LayoutTests: Reviewed by Gustavo Noronha Silva. [GStreamer] data: source could also support non-base64 encoded URIs https://bugs.webkit.org/show_bug.cgi?id=30007 * platform/gtk/Skipped: Unskipped media/audio-data-url.html. It should now be much more reliable on the bots running latest GStreamer versions. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zherczeg@webkit.org authored
Reviewed by Eric Seidel. [Qt] Fix crashes in debug mode https://bugs.webkit.org/show_bug.cgi?id=49976 The m_methods hashmap of QtInstance contains InternalFunctions whose depend on the current RuntimeObject. When we recreate the RuntimeObject, we should also reset this hashmap. * bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::newRuntimeObject): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. MathML: update baselinePosition() call in RenderMathMLBlock.cpp https://bugs.webkit.org/show_bug.cgi?id=50540 The call of baselinePosition() is outdated: new arguments added. * mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::paint): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hans@chromium.org authored
Reviewed by Jeremy Orlow. IndexedDB: Numeric keys are floats. https://bugs.webkit.org/show_bug.cgi?id=50674 Update layout tests to use floating-point values for keys. * storage/indexeddb/keyrange-expected.txt: * storage/indexeddb/keyrange.html: Make sure creating the keys works. * storage/indexeddb/objectstore-cursor-expected.txt: * storage/indexeddb/objectstore-cursor.html: Make sure retrieving the keys from the DB objectstore works. 2010-12-10 Hans Wennborg <hans@chromium.org> Reviewed by Jeremy Orlow. IndexedDB: Numeric keys are floats. https://bugs.webkit.org/show_bug.cgi?id=50674 Use floating point to represent numeric keys, add version meta data to the SQLite db, and migrate object stores that use integers. * bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue): * bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8): * storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables): (WebCore::migrateDatabase): (WebCore::IDBFactoryBackendImpl::open): * storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls): * storage/IDBKey.h: (WebCore::IDBKey::create): (WebCore::IDBKey::number): 2010-12-10 Hans Wennborg <hans@chromium.org> Reviewed by Jeremy Orlow. IndexedDB: Numeric keys are floats. https://bugs.webkit.org/show_bug.cgi?id=50674 Represent numeric keys as floating point values. * public/WebIDBKey.h: (WebKit::WebIDBKey::WebIDBKey): * src/WebIDBKey.cpp: (WebKit::WebIDBKey::assign): (WebKit::WebIDBKey::number): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
Reviewed by Martin Robinson. [GTK] Split webkitprivate.{cpp,h} in more manageable chunks https://bugs.webkit.org/show_bug.cgi?id=50698 Split private bits of WebKitWebFrame to its own private header, and to its implementation file. * GNUmakefile.am: * WebCoreSupport/ChromeClientGtk.cpp: * WebCoreSupport/DragClientGtk.cpp: * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: * WebCoreSupport/FrameLoaderClientGtk.cpp: * webkit/webkitprivate.cpp: * webkit/webkitprivate.h: * webkit/webkitwebdatasource.cpp: * webkit/webkitwebframe.cpp: (WebKit::getViewFromFrame): (WebKit::core): (WebKit::kit): * webkit/webkitwebframeprivate.h: Added. * webkit/webkitwebpolicydecision.cpp: * webkit/webkitwebview.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Xan Lopez. [Gtk] style="font-family: courier" makes text disappear https://bugs.webkit.org/show_bug.cgi?id=47452 Added a GTK+ test for invalid fonts. * platform/gtk/fonts/font-with-no-valid-encoding-expected.checksum: Added. * platform/gtk/fonts/font-with-no-valid-encoding-expected.png: Added. * platform/gtk/fonts/font-with-no-valid-encoding-expected.txt: Added. * platform/gtk/fonts/font-with-no-valid-encoding.html: Added. 2010-12-10 Martin Robinson <mrobinson@igalia.com> Reviewed by Xan Lopez. [Gtk] style="font-family: courier" makes text disappear https://bugs.webkit.org/show_bug.cgi?id=47452 Don't ever use fonts that do not have any of the three charmaps that Fontconfig supports (Unicode, Apple Roman and Symbol). If we select a font that doesn't have one of these charmaps, use the next font in the list. Test: platform/gtk/fonts/font-with-no-valid-encoding.html * platform/graphics/freetype/FontCacheFreeType.cpp: (WebCore::FontCache::createFontPlatformData): Check whether the font we selected has a valid Fontconfig charmap. * platform/graphics/freetype/FontPlatformData.h: Added new method definition. * platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::hasCompatibleCharmap): Added this method which verifies that a font has a valid Fontconfig charmap. 2010-12-10 Martin Robinson <mrobinson@igalia.com> Reviewed by Xan Lopez. [Gtk] style="font-family: courier" makes text disappear https://bugs.webkit.org/show_bug.cgi?id=47452 Add a test that verifies that fonts without valid charmaps are never selected. * DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Initialize DRT with our font (derived from Ahem) that has no valid charmap. * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added. * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users' settings which may disable selection of bitmap fonts. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed. The commit-queue should file bugs about flaky tests it encounters https://bugs.webkit.org/show_bug.cgi?id=50803 create_bug_for_flaky_test was insufficiently tested, thus buggy. Now it's tested. * Scripts/webkitpy/tool/bot/flakytestreporter.py: * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
[Qt] enable orientation flag when QtMobility available https://bugs.webkit.org/show_bug.cgi?id=50781 * platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt: Added. * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/prototype-inheritance-expected.txt: * platform/qt/fast/js/global-constructors-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed. Somehow this last-minute edit didn't quite get committed. The commit-queue should file bugs about flaky tests it encounters https://bugs.webkit.org/show_bug.cgi?id=50803 * Scripts/webkitpy/tool/bot/flakytestreporter.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. The commit-queue should file bugs about flaky tests it encounters https://bugs.webkit.org/show_bug.cgi?id=50803 This change got a bit big. I also added a new config.urls file because I needed to share the view_source_url code with committervalidator.py. This adds a new class FlakyTestReporter which holds all the logic about reporting flaky tests to bugzilla. Right now this code knows how to look up bugs for flaky tests. If it can't find a bug filed from the commit-queue, it will open a new one, ccing the relevant people and adding information about the failure. It is not yet smart enough to chase down duplicate chains, or to include the actual failure diff. But those can be added in later iterations. * Scripts/webkitpy/common/checkout/api.py: * Scripts/webkitpy/common/checkout/changelog.py: * Scripts/webkitpy/common/checkout/commitinfo.py: * Scripts/webkitpy/common/config/committervalidator.py: * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added. * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py. * Scripts/webkitpy/tool/bot/irc_command.py: * Scripts/webkitpy/tool/bot/sheriff.py: * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/queues.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/comments.py: * Scripts/webkitpy/tool/mocktool.py: * Scripts/webkitpy/tool/steps/commit.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Reviewed by Ojan Vafai. Make DOM Mutation Events Asynchronous https://bugs.webkit.org/show_bug.cgi?id=46936 Implemented DOM mutations events as scoped events. A scoped event is an event whose dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by EventQueueScope objects (RAII idiom), which increments and decrements the scoping level on its constructor and destructor respectively. When the scoping level is 0 (initial level), scoped events are dispatched as soon as they are enqueued and act like synchronous events. When the scoping level is greater than 0, however, events are queued in ScopedEventQueue and their dispatches are delayed until the scoping level goes back to 0 (by the destruction of EventQueueScope). DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument, DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches of the events until the completion of each call of EditCommand::doApply. Test: fast/events/mutation/execCommands.html * Android.mk: Added ScopedEventQueue.cpp. * CMakeLists.txt: Ditto. * WebCore.pro: Ditto. * GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h. * WebCore.gypi: Ditto. * WebCore.vcproj/project.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent. (WebCore::dispatchChildRemovalEvents): Ditto. * dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp. * dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Ditto. (WebCore::Element::dispatchAttrAdditionEvent): Ditto. * dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Added. (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent. * dom/Node.h: * dom/ScopedEventQueue.cpp: Added. (WebCore::ScopedEventQueue::initialize): Added. (WebCore::ScopedEventQueue::enqueueEvent): Added. (WebCore::ScopedEventQueue::dispatchAllEvents): Added. (WebCore::ScopedEventQueue::dispatchEvent): Added. (WebCore::ScopedEventQueue::instance): Added. (WebCore::ScopedEventQueue::incrementScopingLevel): Added. (WebCore::ScopedEventQueue::decrementScopingLevel): Added. * dom/ScopedEventQueue.h: Added. (WebCore::ScopedEventQueue::~ScopedEventQueue): Added. (WebCore::ScopedEventQueue::ScopedEventQueue): Added. (WebCore::EventQueueScope::EventQueueScope): Added. (WebCore::EventQueueScope::~EventQueueScope): Added. * editing/EditCommand.cpp: (WebCore::EditCommand::apply): Instantiates EventQueueScope. 2010-12-09 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Ojan Vafai. Make DOM Mutation Events Asynchronous https://bugs.webkit.org/show_bug.cgi?id=46936 Added a test to ensure no DOM mutation events are fired while execCommand is in progress. * fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached from the document, and can't be observed. Modify the DOM when text node is inserted. * fast/events/scoped: Added. * fast/events/scoped/editing-commands-expected.txt: Added. * fast/events/scoped/editing-commands.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Unreviewed, rolling out r73684. http://trac.webkit.org/changeset/73684 https://bugs.webkit.org/show_bug.cgi?id=50801 "missing bug number" (Requested by rniwa on #webkit). * Android.mk: * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents): * dom/DOMAllInOne.cpp: * dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent): * dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchUIEvent): * dom/Node.h: * dom/ScopedEventQueue.cpp: Removed. * dom/ScopedEventQueue.h: Removed. * editing/EditCommand.cpp: (WebCore::EditCommand::apply): 2010-12-09 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r73684. http://trac.webkit.org/changeset/73684 https://bugs.webkit.org/show_bug.cgi?id=50801 "missing bug number" (Requested by rniwa on #webkit). * fast/events/crash-on-mutate-during-drop.html: * fast/events/scoped/editing-commands-expected.txt: Removed. * fast/events/scoped/editing-commands.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 09 Dec, 2010 15 commits
-
-
eric@webkit.org authored
Reviewed by Adam Barth. Teach webkit-patch how to search bugzilla https://bugs.webkit.org/show_bug.cgi?id=50500 This is a step towards teaching webkitpy how to file new bugs for flaky tests and update them when new flakes occur. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: * Scripts/webkitpy/tool/commands/__init__.py: * Scripts/webkitpy/tool/commands/bugsearch.py: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] enable orientation flag when QtMobility available https://bugs.webkit.org/show_bug.cgi?id=50781 When QtMobility available, enable orientation flag by default. * features.pri: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kent Tamura. Improve validation API support of <object> and <keygen> https://bugs.webkit.org/show_bug.cgi?id=50663 Adds tests for validation API for <object>. Tests for <output> and <keygen> are also added. * fast/dom/plugin-attributes-enumeration-expected.txt: Updated. * fast/forms/ValidityState-001-expected.txt: Updated. * fast/forms/ValidityState-001.html: Updated. * fast/forms/checkValidity-001-expected.txt: Updated. * fast/forms/checkValidity-001.html: Updated. * fast/forms/script-tests/setCustomValidity-existence.js: Added. * fast/forms/script-tests/validationMessage.js: Updated. * fast/forms/script-tests/willvalidate.js: Updated. * fast/forms/setCustomValidity-existence-expected.txt: Added. * fast/forms/setCustomValidity-existence.html: Added. * fast/forms/validationMessage-expected.txt: Updated. * fast/forms/willvalidate-expected.txt: Updated. 2010-12-09 Kenichi Ishibashi <bashi@google.com> Reviewed by Kent Tamura. Improve validation API support of <object> and <keygen> https://bugs.webkit.org/show_bug.cgi?id=50663 Adds validation API to HTMLObjectElement class. Makes HTMLKeygenElement::willValidate() return false. Test: fast/forms/setCustomValidity-existence.html * html/HTMLKeygenElement.h: (WebCore::HTMLKeygenElement::willValidate): Added. * html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::validationMessage): Added. (WebCore::HTMLObjectElement::checkValidity): Added. (WebCore::HTMLObjectElement::setCustomValidity): Added. * html/HTMLObjectElement.idl: Added validation API properties. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kent Tamura. Make sure a non-zero value is used for tile-width to avoid a crash https://bugs.webkit.org/show_bug.cgi?id=50341 The scaled tile width can be very small at times (e.g. with 'style: font 1 required'). So use a minimum width of 1 instead of using 0 (which leads to a crash). * fast/dom/HTMLProgressElement/progress-element-with-style-crash.html: Added. * fast/dom/HTMLProgressElement/progress-element-with-style-crash-expected.txt: Added. 2010-12-09 Sadrul Habib Chowdhury <sadrul@chromium.org> Reviewed by Kent Tamura. Make sure a non-zero value is used for tile-width to avoid a crash https://bugs.webkit.org/show_bug.cgi?id=50341 The scaled tile width can be very small at times (e.g. with 'style: font 1 required'). So use a minimum width of 1 instead of using 0 (which leads to a crash). Tests: fast/dom/HTMLProgressElement/progress-element-with-style-crash.html * rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintProgressBar): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Reviewed by Ojan Vafai. Implemented DOM mutations events as scoped events. A scoped event is an event whose dispatch is done via ScopedEventQueue. The behavior of the queue is controlled by EventQueueScope objects (RAII idiom), which increments and decrements the scoping level on its constructor and destructor respectively. When the scoping level is 0 (initial level), scoped events are dispatched as soon as they are enqueued and act like synchronous events. When the scoping level is greater than 0, however, events are queued in ScopedEventQueue and their dispatches are delayed until the scoping level goes back to 0 (by the destruction of EventQueueScope). DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument, DOMNodeInsertedIntoDocument, DOMFocusIn, DOMFocusOut, focusin, and focusout are treated as scoped events, and a scope object is instantiated in EditCommand::apply to delay dispatches of the events until the completion of each call of EditCommand::doApply. Test: fast/events/mutation/execCommands.html * Android.mk: Added ScopedEventQueue.cpp. * CMakeLists.txt: Ditto. * WebCore.pro: Ditto. * GNUmakefile.am: Added ScopedEventQueue.cpp and ScopedEventQueue.h. * WebCore.gypi: Ditto. * WebCore.vcproj/project.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Calls dispatchScopedEvent. (WebCore::dispatchChildRemovalEvents): Ditto. * dom/DOMAllInOne.cpp: Added ScopedEventQueue.cpp. * dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Ditto. (WebCore::Element::dispatchAttrAdditionEvent): Ditto. * dom/Node.cpp: (WebCore::Node::dispatchScopedEvent): Added. (WebCore::Node::dispatchSubtreeModifiedEvent): Calls dispatchScopedEvent. * dom/Node.h: * dom/ScopedEventQueue.cpp: Added. (WebCore::ScopedEventQueue::initialize): Added. (WebCore::ScopedEventQueue::enqueueEvent): Added. (WebCore::ScopedEventQueue::dispatchAllEvents): Added. (WebCore::ScopedEventQueue::dispatchEvent): Added. (WebCore::ScopedEventQueue::instance): Added. (WebCore::ScopedEventQueue::incrementScopingLevel): Added. (WebCore::ScopedEventQueue::decrementScopingLevel): Added. * dom/ScopedEventQueue.h: Added. (WebCore::ScopedEventQueue::~ScopedEventQueue): Added. (WebCore::ScopedEventQueue::ScopedEventQueue): Added. (WebCore::EventQueueScope::EventQueueScope): Added. (WebCore::EventQueueScope::~EventQueueScope): Added. * editing/EditCommand.cpp: (WebCore::EditCommand::apply): Instantiates EventQueueScope. 2010-12-09 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Ojan Vafai. Added a test to ensure no DOM mutation events are fired while execCommand is in progress. * fast/events/crash-on-mutate-during-drop.html: DOMNodeInserted is fired after BR is detached from the document, and can't be observed. Modify the DOM when text node is inserted. * fast/events/mutation: Added. * fast/events/mutation/execCommands.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
we coalesce wheel events, we can re-enable this. Reviewed by Gavin Barraclough. * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::scroll): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Ojan Vafai. commit-queue errors out due to local commits https://bugs.webkit.org/show_bug.cgi?id=50766 We seem to be tripping over having local commits in the working copy a lot recently. I don't quite fully understand what the issue is, but this patch attempts to solve the problem by adding an explicit clean step before processing a patch. Previously, we did the cleaning as part of the apply-attachment step, so this might not actually fix the problem. * Scripts/webkitpy/tool/bot/commitqueuetask.py: * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
inferno@chromium.org authored
Reviewed by James Robinson. For details element, ensure that if we ended up being inline that we set out replaced flag so that we are treated like an inline block. https://bugs.webkit.org/show_bug.cgi?id=50671 Test: fast/html/details-element-render-inline-crash.html * rendering/RenderDetails.cpp: (WebCore::RenderDetails::styleDidChange): setReplaced to true if we are set as inline. * rendering/RenderDetails.h: function definition. 2010-12-09 Abhishek Arya <inferno@chromium.org> Reviewed by James Robinson. Tests that we do not crash when we set details element with children to show as inline. https://bugs.webkit.org/show_bug.cgi?id=50671 * fast/html/details-element-render-inline-crash-expected.txt: Added. * fast/html/details-element-render-inline-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
Unreviewed. Update Chromium GPU test expecations for canvas/philip. * platform/chromium-gpu/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Alexey Proskuryakov. Test for a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation. https://bugs.webkit.org/show_bug.cgi?id=50708 * fast/xsl/utf8-chunks-expected.txt: Added. * fast/xsl/utf8-chunks.xml: Added. * fast/xsl/utf8-chunks.xsl: Added. 2010-12-09 Jasmin Lapalme <jlapalme@druide.com> Reviewed by Alexey Proskuryakov. Fix a faulty conversion from UTF-8 to UTF-16 in WebCore during an XSLT transformation. https://bugs.webkit.org/show_bug.cgi?id=50708 Test: fast/xsl/utf8-chunks.xml * xml/XSLTProcessorLibxslt.cpp: (WebCore::writeToVector): now converts and returns the correct byte count when the end of the chunk is in the middle of a multibyte UTF-8 character. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
inferno@chromium.org authored
Reviewed by James Robinson. Clip update rectangle for Texture::updateSubRect to texture size https://bugs.webkit.org/show_bug.cgi?id=49929 Test: fast/canvas/canvas-largedraws.html * platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect): 2010-12-09 Vincent Scheib <scheib@chromium.org> Reviewed by James Robinson. Clip update rectangle for Texture::updateSubRect to texture size https://bugs.webkit.org/show_bug.cgi?id=49929 * fast/canvas/canvas-largedraws-expected.txt: Added. * fast/canvas/canvas-largedraws.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jocelyn.turcotte@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt][WK2] Use a single QNetworkAccessManager per web process. https://bugs.webkit.org/show_bug.cgi?id=50757 This allows a better management of network resources and the use of global cookie jar and disk cache across all frames. * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: (WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext): (WebCore::WebFrameNetworkingContext::networkAccessManager): * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::shutdownIfPossible): * WebProcess/WebProcess.h: (WebKit::WebProcess::networkAccessManager): * WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown): * WebProcess/qt/WebProcessQt.cpp: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown): * WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::WebProcess::platformShutdown): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrowe@apple.com authored
* Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::sizeForNumberType): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs@apple.com authored
Reviewed by Brady Eidson. WebKit2: Control-click doesn't invoke context menu https://bugs.webkit.org/show_bug.cgi?id=50793 <rdar://problem/8664800> * WebProcess/WebPage/WebPage.cpp: (WebKit::isContextClick): New helper function - on Mac, not only right clicks but also control-left-clicks are context clicks. (WebKit::handleMouseEvent): Use above. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbr@google.com authored
Unreviewed. Another speculative Gtk build fix after r73669. Add needed derived sources to GNUmakefile.am. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-