- 28 Feb, 2006 1 commit
-
-
justing authored
Reviewed by darin <http://bugzilla.opendarwin.org/show_bug.cgi?id=6893> REGRESSION: Major bug with TinyMCE, no value submitted from textarea <rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted <rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped * fast/forms/textarea-hard-linewrap-expected.txt: Added. * fast/forms/textarea-hard-linewrap.html: Added. * fast/forms/textarea-setvalue-submit-expected.txt: Added. * fast/forms/textarea-setvalue-submit.html: Added. WebCore: Reviewed by darin <http://bugzilla.opendarwin.org/show_bug.cgi?id=6893> REGRESSION: Major bug with TinyMCE, no value submitted from textarea <rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted <rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped Canonicalize line endings in textareas to avoid the workarounds that were a source of bugs, Also call textWithHardLineWraps inside appendFormData (and nowhere else) if wrap="hard". * khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): (WebCore::HTMLTextAreaElementImpl::select): (WebCore::HTMLTextAreaElementImpl::appendFormData): (WebCore::HTMLTextAreaElementImpl::rendererWillBeDestroyed): (WebCore::HTMLTextAreaElementImpl::updateValue): (WebCore::HTMLTextAreaElementImpl::value): (WebCore::HTMLTextAreaElementImpl::setValue): (WebCore::HTMLTextAreaElementImpl::defaultValue): * khtml/html/HTMLTextAreaElementImpl.h: (DOM::HTMLTextAreaElementImpl::invalidateValue): * kwq/KWQTextArea.h: * kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView text]): (-[KWQTextAreaTextView textWithHardLineBreaks]): (-[KWQTextAreaTextView setSelectedRange:]): (-[KWQTextAreaTextView selectedRange]): (-[KWQTextAreaTextView getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph): (-[KWQTextAreaTextView textView:shouldChangeTextInRange:replacementString:]): * rendering/render_form.cpp: (WebCore::RenderTextArea::destroy): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::text): (WebCore::RenderTextArea::textWithHardLineBreaks): * rendering/render_form.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 27 Feb, 2006 5 commits
-
-
darin authored
Reviewed by Darin. - added test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=7338 Incorrect selectorText for multiple subselectors * fast/dom/css-selectorText-expected.checksum: Updated. * fast/dom/css-selectorText-expected.png: Updated. * fast/dom/css-selectorText-expected.txt: Updated. * fast/dom/css-selectorText.html: Added a case with multiple subselectors. WebCore: Test: added to fast/dom/css-selectorText.html Reviewed by Darin. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7338 Incorrect selectorText for multiple subselectors. * css/css_base.cpp: (CSSSelector::selectorText): Iterate over subselectors git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13048 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
Reviewed by Darin. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7433 REGRESSION (r12789): Second RTL text run on a line cannot be selected * fast/text/in-rendered-text-rtl-expected.checksum: Added. * fast/text/in-rendered-text-rtl-expected.png: Added. * fast/text/in-rendered-text-rtl-expected.txt: Added. * fast/text/in-rendered-text-rtl.html: Added. WebCore: Test: fast/text/in-rendered-text-rtl.html Reviewed by Darin. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7433 REGRESSION (r12789): Second RTL text run on a line cannot be selected * dom/dom_position.cpp: (WebCore::Position::inRenderedText): If the RenderText contains reversed text, the text boxes are not necessarily ordered by start position, so iterate through all of them. (WebCore::Position::isRenderedCharacter): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13045 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
Reviewed by Darin. - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7321 REGRESSION: style tag in body causes two head elements to appear in the DOM The head-check.html document uses an iframe as a laboratory for loading each head-check-N.html file and checking its DOM, with inspiration from Ian Hixie's Live DOM Viewer: http://software.hixie.ch/utilities/js/live-dom-viewer/ Each of the four head-check-N.html files tests a different code path for creating a document's head element in WebCore/khtml/html/htmlparser.cpp. * editing/inserting/editing-empty-divs-expected.txt: Corrected <html> child index for <body> since the document previously had two <head> nodes. * fast/dom/HTMLHeadElement: Added. * fast/dom/HTMLHeadElement/head-check-expected.txt: Added. * fast/dom/HTMLHeadElement/head-check.html: Added. * fast/dom/HTMLHeadElement/resources: Added. * fast/dom/HTMLHeadElement/resources/head-check-1.html: Added. * fast/dom/HTMLHeadElement/resources/head-check-2.html: Added. * fast/dom/HTMLHeadElement/resources/head-check-3.html: Added. * fast/dom/HTMLHeadElement/resources/head-check-4.html: Added. * fast/dom/HTMLHeadElement/resources/head-check.js: Added. WebCore: Reviewed by Darin. - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7321 REGRESSION: style tag in body causes two head elements to appear in the DOM * khtml/html/htmlparser.cpp: Handle the head node like form and map nodes. (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::headCreateErrorCheck): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13044 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
Reviewed by darin Test for: <http://bugzilla.opendarwin.org/show_bug.cgi?id=6844> elementAtPoint returns the list when the point is over a list marker * fast/events/onclick-list-marker-expected.txt: Added. * fast/events/onclick-list-marker.html: Added. WebCore: Reviewed by darin <http://bugzilla.opendarwin.org/show_bug.cgi?id=6844> elementAtPoint returns the list when the point is over a list marker Consider the case of outside list markers in nodeAtPoint. Had to pull the code out of RenderListMarker::paint that computed the position/size of the list marker. Added: * fast/events/onclick-list-marker.html * rendering/render_list.cpp: (RenderListItem::nodeAtPoint): (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::nodeAtPoint): (RenderListMarker::getRelativeMarkerRect): * rendering/render_list.h: * rendering/render_object.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13028 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Reviewed by ggaren. Test new PlugInInfoStore class (used to be KConfig). * plugins/plugin-javascript-access-expected.txt: Added. * plugins/plugin-javascript-access.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 26 Feb, 2006 2 commits
-
-
ggaren authored
- Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=4977 <form> not being displayed at all. * fast/forms/form-hides-table-expected.checksum: Added. * fast/forms/form-hides-table-expected.png: Added. * fast/forms/form-hides-table-expected.txt: Added. * fast/forms/form-hides-table.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12998 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ggaren authored
Test by Geoff, automated by me, reviewed by Darin. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7293 REGRESSION: Using Javascript Bookmarklets that reference location.href on a blank tab crashes WebKit * fast/frames/empty-frame-document-expected.txt: Added. * fast/frames/empty-frame-document.html: Added. WebKit: Test: fast/frames/empty-frame-document.html Reviewed by Darin. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7293 REGRESSION: Using Javascript Bookmarklets that reference location.href on a blank tab crashes WebKit The crash happened because an empty frame did not have a document. * WebView/WebFrame.m: (-[WebFrame _commitProvisionalLoad:]): Use "about:blank" instead of an empty URL for empty frames. This causes a document to be created for the frame. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 25 Feb, 2006 1 commit
-
-
ggaren authored
-tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5146 Re-landing results after adding missing png's to the test. * fast/replaced/resources/1x1-blue.png: Added. * fast/replaced/resources/square-blue-100x100.png: Added. * fast/replaced/maxheight-percent-expected.checksum: Added. * fast/replaced/maxheight-percent-expected.png: Added. * fast/replaced/maxheight-percent-expected.txt: * fast/replaced/maxheight-pxs-expected.checksum: Added. * fast/replaced/maxheight-pxs-expected.png: Added. * fast/replaced/maxheight-pxs-expected.txt: * fast/replaced/maxwidth-percent-expected.checksum: Added. * fast/replaced/maxwidth-percent-expected.png: Added. * fast/replaced/maxwidth-percent-expected.txt: * fast/replaced/maxwidth-pxs-expected.checksum: Added. * fast/replaced/maxwidth-pxs-expected.png: Added. * fast/replaced/maxwidth-pxs-expected.txt: * fast/replaced/minheight-percent-expected.checksum: Added. * fast/replaced/minheight-percent-expected.png: Added. * fast/replaced/minheight-percent-expected.txt: * fast/replaced/minheight-pxs-expected.checksum: Added. * fast/replaced/minheight-pxs-expected.png: Added. * fast/replaced/minheight-pxs-expected.txt: * fast/replaced/minwidth-percent-expected.checksum: Added. * fast/replaced/minwidth-percent-expected.png: Added. * fast/replaced/minwidth-percent-expected.txt: * fast/replaced/minwidth-pxs-expected.checksum: Added. * fast/replaced/minwidth-pxs-expected.png: Added. * fast/replaced/minwidth-pxs-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 24 Feb, 2006 6 commits
-
-
antti authored
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7440 Floats not positioned correctly * fast/block/float/multiple-float-positioning-expected.checksum: Added. * fast/block/float/multiple-float-positioning-expected.png: Added. * fast/block/float/multiple-float-positioning-expected.txt: Added. * fast/block/float/multiple-float-positioning.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12988 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
Reviewed by justin <http://bugzilla.opendarwin.org/show_bug.cgi?id=6933> Selection extends beyond focus ring for some contentEditable divs * editing/selection/extend-by-word-002-expected.checksum: * editing/selection/extend-by-word-002-expected.png: * editing/selection/select-all-001-expected.checksum: * editing/selection/select-all-001-expected.png: * editing/selection/select-all-002-expected.checksum: * editing/selection/select-all-002-expected.png: WebCore: <http://bugzilla.opendarwin.org/show_bug.cgi?id=6933> Selection extends beyond focus ring for some contentEditable divs Reviewed by justin * rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): Have root editable elements paint their own selection gaps. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12986 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin authored
- test <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188) * fast/dom/Window/redirect-with-timer.html: Added. * fast/dom/Window/redirect-with-timer-expected.txt: Added. WebCore: Reviewed by Maciej. - fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188) Test: fast/dom/Window/redirect-with-timer.html * platform/Timer.h: Made isActive no longer inline. Added inHeap function. * platform/Timer.cpp: Changed assertions to use inHeap function for clarity. (WebCore::TimerBase::isActive): Return true for timers that are ready to fire. They have a next fire time of 0, but they should still be considered active. (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new rule is that timers with a next fire time of 0 are not in the heap, and all other timers are. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12985 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7245> caret does not display at the end of some lines in contenteditable divs Reviewed by justin * editing/deleting/delete-block-merge-contents-018-expected.txt: * editing/deleting/delete-block-merge-contents-021-expected.txt: * editing/deleting/delete-line-end-ws-001-expected.txt: * editing/deleting/delete-line-end-ws-002-expected.txt: * editing/deleting/forward-delete-expected.txt: * editing/execCommand/boldSelection-expected.txt: * editing/execCommand/italicizeByCharacter-expected.txt: * editing/execCommand/modifyForeColorByCharacter-expected.txt: * editing/execCommand/print-expected.txt: * editing/execCommand/selectAll-expected.txt: * editing/execCommand/strikethroughSelection-expected.txt: * editing/inserting/insert-div-019-expected.txt: * editing/inserting/insert-div-027-expected.txt: * editing/inserting/typing-003-expected.txt: * editing/pasteboard/paste-text-012-expected.txt: * editing/pasteboard/paste-text-013-expected.txt: * editing/pasteboard/paste-text-014-expected.txt: * editing/selection/extend-by-character-003-expected.txt: * editing/selection/extend-by-character-005-expected.txt: * editing/selection/extend-by-word-002-expected.checksum: * editing/selection/extend-by-word-002-expected.png: * editing/selection/extend-by-word-002-expected.txt: * editing/selection/move-by-character-003-expected.txt: * editing/selection/move-by-character-005-expected.txt: * editing/selection/select-all-001-expected.txt: * editing/selection/select-all-002-expected.checksum: * editing/selection/select-all-002-expected.png: * editing/selection/select-all-002-expected.txt: * editing/selection/select-all-003-expected.txt: * editing/style/create-block-for-style-001-expected.txt: * editing/style/create-block-for-style-002-expected.txt: * editing/style/create-block-for-style-003-expected.txt: * editing/style/create-block-for-style-004-expected.txt: * editing/style/create-block-for-style-005-expected.txt: * editing/style/create-block-for-style-006-expected.txt: * editing/style/create-block-for-style-007-expected.txt: * editing/style/create-block-for-style-008-expected.txt: * editing/style/create-block-for-style-009-expected.txt: * editing/style/create-block-for-style-010-expected.txt: * editing/style/create-block-for-style-011-expected.txt: * editing/style/create-block-for-style-012-expected.txt: * editing/style/create-block-for-style-013-expected.txt: * editing/style/relative-font-size-change-001-expected.txt: * editing/style/relative-font-size-change-002-expected.txt: * editing/style/relative-font-size-change-003-expected.txt: * editing/style/relative-font-size-change-004-expected.txt: * fast/clip/outline-overflowClip-expected.txt: * fast/overflow/overflow-focus-ring-expected.checksum: * fast/overflow/overflow-focus-ring-expected.png: * fast/overflow/overflow-focus-ring-expected.txt: * fast/text/justified-text-rect-expected.checksum: * fast/text/justified-text-rect-expected.png: * fast/text/justified-text-rect-expected.txt: * fast/text/justified-text-rect.html: WebCore: <http://bugzilla.opendarwin.org/show_bug.cgi?id=7245> caret does not display at the end of some lines in contenteditable divs Reviewed by justin * khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::setContentEditable): * page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::removeEditingStyleFromElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12984 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ggaren authored
Reviewed by Hyatt. -tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5146 * fast/replaced/maxheight-percent.html: Added. * fast/replaced/maxheight-pxs.html: Added. * fast/replaced/maxwidth-percent.html: Added. * fast/replaced/maxwidth-pxs.html: Added. * fast/replaced/minheight-percent.html: Added. * fast/replaced/minheight-pxs.html: Added. * fast/replaced/minwidth-percent.html: Added. * fast/replaced/minwidth-pxs.html: Added. * fast/replaced/resources/1x1-blue.png: Added. * fast/replaced/resources/square-blue-100x100.png: Added. WebCore: Reviewed by Hyatt, tweaked and landed by ggaren. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5146 max-height/max-width not resizing images with correct aspect ratio This patch is a port and adaptation of Allan Sandfeld Jensen's (carewolf) patch of http://bugs.kde.org/show_bug.cgi?id=120107 with the needed modifications to suit the Webcore tree. Makes images respect min/max sizes and their intrinsic aspect ratios at the same time according to CSS 2.1 (http://www.w3.org/TR/CSS21/visudet.html#min-max-widths). Test: fast/replaced/maxheight-percent.html Test: fast/replaced/maxheight-pxs.html Test: fast/replaced/maxwidth-percent.html Test: fast/replaced/maxwidth-pxs.html Test: fast/replaced/minheight-percent.html Test: fast/replaced/minheight-pxs.html Test: fast/replaced/minwidth-percent.html Test: fast/replaced/minwidth-pxs.html * rendering/render_box.cpp: (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing): Calculate percent heights correctly * rendering/render_image.cpp: Respect aspect ratios and calculate max/min (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight): (WebCore::RenderImage::calcAspectRatioWidth): Added (WebCore::RenderImage::calcAspectRatioHeight): Added (WebCore::RenderImage::calcMinMaxWidth): Added * rendering/render_image.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12981 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ap authored
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7435 Add Ian Hickson's XMLHttpRequest tests * http/conf/httpd.conf: Enable send-as-is handler, required by the tests. * http/tests/xmlhttprequest/web-apps: Added (recursively). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 21 Feb, 2006 5 commits
-
-
ap authored
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7409 Some minor fixes to http tests. LayoutTests: * http/conf/httpd.conf: don't define CustomLog and ErrorLog - these are now passed from run-webkit-tests. * http/tests/favicon.ico: Added. * http/tests/incremental/slow-utf8-text.text: Remove an unused variable, * http/tests/incremental/split-hex-entities.html: Ditto. * http/tests/xmlhttprequest/interactive-state.cgi: Ditto. WebKitTools: * Scripts/run-webkit-tests: Pass CustomLog and ErrorLog directives to httpd. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12931 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
- Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7330 baselinePosition is wrong for new text field when empty * fast/forms/input-baseline-expected.checksum: Added. * fast/forms/input-baseline-expected.png: Added. * fast/forms/input-baseline-expected.txt: Added. * fast/forms/input-baseline.html: Added. * fast/inline-block/contenteditable-baseline-expected.checksum: Added. * fast/inline-block/contenteditable-baseline-expected.png: Added. * fast/inline-block/contenteditable-baseline-expected.txt: Added. * fast/inline-block/contenteditable-baseline.html: Added. Reviewed by Hyatt. Tests: * fast/forms/input-baseline.html * fast/inline-block/contenteditable-baseline.html - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7330 baselinePosition is wrong for new text field when empty * rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox): If we're dealing with an empty contenteditable block, then we've added height to the block to make room for the caret, and there are no children to give us the baseline. Instead, compute the baseline for the block itself, and factor in the border and the padding. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12929 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ap authored
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6197 Would like to use locally installed Apache for testing. Added two run-webkit-tests options: --http (--nohttp) - whether to launch Apache (defaults to yes); --port - which port to listen on (defaults to 8000). Tests in LayoutTests/http are not run directly, and Apache is used instead. For example, http/tests/xmlhttprequest/post-content-type.html is loaded as http://127.0.0.1:8000/xmlhttprequest/post-content-type.html. Also added support for .shtml and .text files. Text files give an empty *-expected.txt, but a correct image. Apache only listens on the loopback interface. It writes logs to /tmp/WebKit. * Scripts/run-webkit-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12923 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs authored
Reviewed by Geoff and Darin. Patch from Maks Orlovich, based on work by David Faure, hand-applied and significantly reworked by me. - Patch: give internal function names (KJS merge) http://bugzilla.opendarwin.org/show_bug.cgi?id=6279 Updated test results, now showing correct function string. * fast/dom/xmlhttprequest-get-expected.txt: * fast/js/kde/function-expected.txt: * fast/js/kde/inbuilt_function_tostring-expected.txt: WebCore: Reviewed by Geoff and Darin. Patch from Maks Orlovich, based on work by David Faure, hand-applied and significantly reworked by me. - Patch: give internal function names (KJS merge) http://bugzilla.opendarwin.org/show_bug.cgi?id=6279 * khtml/ecma/kjs_binding.h: * khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::HTMLElementFunction): * kwq/WebCoreScriptDebugger.mm: ... -
darin authored
- test http://bugzilla.opendarwin.org/show_bug.cgi?id=6831 contentEditable outline darkens as caret moves * editing/selection/move-by-character-6.html: Added. * editing/selection/move-by-character-6-expected.txt: Added. * editing/selection/move-by-character-6-expected.checksum: Added. * editing/selection/move-by-character-6-expected.png: Added. WebCore: Collaborated with Graham Dennis <Graham.Dennis@gmail.com> on this. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6831 contentEditable outline darkens as caret moves Test: editing/selection/move-by-character-6.html The trick was to draw the focus ring clipped to a list of rectangles instead of clipped to exactly one. * kwq/KWQPainter.h: Move Color parameter from initFocusRing to drawFocusRing. * kwq/KWQPainter.mm: (WebCore::QPainterPrivate::QPainterPrivate): Change focusRingPath from an NSBezierPath t...
-
- 18 Feb, 2006 2 commits
-
-
darin authored
Test: fast/js/toString-exception.html Reviewed by Maciej. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7343 REGRESSION: fast/js/toString-overrides.html fails when run multiple times * kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Remove the object from the visited elements set before returning an error. LayoutTests: Reviewed by Maciej. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7343 REGRESSION: fast/js/toString-overrides.html fails when run multiple times * fast/js/resources/toString-exception.js: Added. * fast/js/toString-exception-expected.txt: Added. * fast/js/toString-exception.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12890 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
lypanov authored
Reviewed by Maciej. - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7199. Testcase: svg/custom/text-gradient-no-content.svg * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::teardown): 2006-02-18 Alexander Kellett <lypanov@kde.org> Reviewed by Maciej. - new test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7199 Text gradient fills entire screen if text empty * svg/custom/text-gradient-no-content.svg: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 17 Feb, 2006 5 commits
-
-
adele authored
Reviewed by Darin. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4227 The ex unit doesn't work for font-variant: small-caps * fast/css/ex-after-font-variant-expected.checksum: Added. * fast/css/ex-after-font-variant-expected.png: Added. * fast/css/ex-after-font-variant-expected.txt: Added. * fast/css/ex-after-font-variant.html: Added. WebCore: Test: fast/css/ex-after-font-variant.html Reviewed by Darin. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4227 The ex unit doesn't work for font-variant: small-caps * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): Added CSS_PROP_FONT_VARIANT to the properties that need to be applied first, since it dirties the font. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12883 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
This test appears to be occasionally hanging. Disabling it while I figure out why. * editing/selection/drag-to-contenteditable-iframe.html: Removed. * editing/selection/drag-to-contenteditable-iframe.html-disabled: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12879 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Anders Carlsson. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7265 REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag * fast/parser/nofoo-tags-inside-paragraph-expected.checksum: Added. * fast/parser/nofoo-tags-inside-paragraph-expected.png: Added. * fast/parser/nofoo-tags-inside-paragraph-expected.txt: Added. * fast/parser/nofoo-tags-inside-paragraph.html: Added. WebCore: Test: fast/parser/nofoo-tags-inside-paragraph.html Reviewed by Anders Carlsson. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7265 REGRESSION: noscript, noframes, nolayer, noembed tags insert break inside paragraph tag * khtml/html/htmlparser.cpp: (HTMLParser::isInline): Treat noframes, nolayer, noembed and skipped noscript as inline elements. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12871 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Maciej. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7218 Text underlined on mouse over * fast/css/universal-hover-quirk-expected.checksum: Added. * fast/css/universal-hover-quirk-expected.png: Added. * fast/css/universal-hover-quirk-expected.txt: Added. * fast/css/universal-hover-quirk.html: Added. WebCore: Test: fast/css/universal-hover-quirk.html Reviewed by Maciej. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7218 Text underlined on mouse over * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active from matching anything in quirks mode. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12869 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Reviewed by Dave Hyatt. - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7216 white-space: pre-wrap collapses leading whitespace following a newline * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added. * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added. * fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Added. * fast/text/whitespace/pre-wrap-spaces-after-newline.html: Added. WebCore: Test: fast/text/whitespace/pre-wrap-spaces-after-newline.html Reviewed by Dave Hyatt. - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7216 white-space: pre-wrap collapses leading whitespace following a newline * rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Use previousLineBrokeCleanly instead of resetBidiAtEnd now that the former is always correct. (khtml::RenderBlock::layoutInlineChildren): Use new skipTrailingNewline flag. (khtml::RenderBlock::findNextLineBreak): Set previousLineBrokeCleanly for line breaks caused by newlines as well. Added skipTrailingNewline flag. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 16 Feb, 2006 2 commits
-
-
adele authored
Updating results for fix: http://bugzilla.opendarwin.org/show_bug.cgi?id=6812 Missing focus ring on new text fields * fast/forms/input-appearance-focus-expected.checksum: * fast/forms/input-appearance-focus-expected.png: WebCore: Reviewed by Darin. - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6812 Missing focus ring on new text fields Tests: * fast/forms/input-appearance-focus.html: Updated. * rendering/render_object.cpp: (WebCore::RenderObject::paintOutline): call supportsFocusRing instead of checking the appearance. * rendering/render_theme.cpp: (khtml::RenderTheme::supportsFocusRing): Added. Checks appearance. Theme will draw focus ring if there's an appearance, but not for the new text fields. * rendering/render_theme.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12855 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
justing authored
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7148> Add drag and drop support to DumpRenderTree * css1/basic/comments-expected.checksum: * css1/basic/comments-expected.png: * css1/basic/containment-expected.checksum: * css1/basic/containment-expected.png: * css1/basic/id_as_selector-expected.checksum: * css1/basic/id_as_selector-expected.png: * css1/basic/inheritance-expected.checksum: * css1/basic/inheritance-expected.png: * css1/box_properties/border-expected.checksum: * css1/box_properties/border-expected.png: * css1/box_properties/border_bottom-expected.checksum: * css1/box_properties/border_bottom-expected.png: * css1/box_properties/border_bottom_width-expected.checksum: * css1/box_properties/border_bottom_width-expected.png: * css1/box_properties/border_left-expected.checksum: * css1/box_properties/border_left-expected.png: * css1/box_properties/border_left_width-expected.checksum: * css1/box_properties/border_left_width-expected.png: * css1/box_properties/border_right_inline-expected.checksum: * css1/box_properties/border_right_inline-expected.png: * css1/box_properties/border_right_width-expected.checksum: * css1/box_properties/border_right_width-expected.png: * css1/box_properties/border_style-expected.checksum: * css1/box_properties/border_style-expected.png: * css1/box_properties/border_top-expected.checksum: * css1/box_properties/border_top-expected.png: * css1/box_properties/border_top_width-expected.checksum: * css1/box_properties/border_top_width-expected.png: * css1/box_properties/border_width-expected.checksum: * css1/box_properties/border_width-expected.png: * css1/box_properties/clear-expected.checksum: * css1/box_properties/clear-expected.png: * css1/box_properties/clear_float-expected.checksum: * css1/box_properties/clear_float-expected.png: * css1/box_properties/float_elements_in_series-expected.checksum: * css1/box_properties/float_elements_in_series-expected.png: * css1/box_properties/float_margin-expected.checksum: * css1/box_properties/float_margin-expected.png: * css1/box_properties/float_on_text_elements-expected.checksum: * css1/box_properties/float_on_text_elements-expected.png: * css1/box_properties/height-expected.checksum: * css1/box_properties/height-expected.png: * css1/box_properties/margin-expected.checksum: * css1/box_properties/margin-expected.png: * css1/box_properties/margin_bottom-expected.checksum: * css1/box_properties/margin_bottom-expected.png: * css1/box_properties/margin_inline-expected.checksum: * css1/box_properties/margin_inline-expected.png: * css1/box_properties/margin_left-expected.checksum: * css1/box_properties/margin_left-expected.png: * css1/box_properties/margin_right-expected.checksum: * css1/box_properties/margin_right-expected.png: * css1/box_properties/margin_top-expected.checksum: * css1/box_properties/margin_top-expected.png: * css1/box_properties/padding-expected.checksum: * css1/box_properties/padding-expected.png: * css1/box_properties/padding_bottom-expected.checksum: * css1/box_properties/padding_bottom-expected.png: * css1/box_properties/padding_inline-expected.checksum: * css1/box_properties/padding_inline-expected.png: * css1/box_properties/padding_left-expected.checksum: * css1/box_properties/padding_left-expected.png: * css1/box_properties/padding_right-expected.checksum: * css1/box_properties/padding_right-expected.png: * css1/box_properties/padding_top-expected.checksum: * css1/box_properties/padding_top-expected.png: * css1/box_properties/width-expected.checksum: * css1/box_properties/width-expected.png: * css1/cascade/cascade_order-expected.checksum: * css1/cascade/cascade_order-expected.png: * css1/classification/display-expected.checksum: * css1/classification/display-expected.png: * css1/classification/list_style_type-expected.checksum: * css1/classification/list_style_type-expected.png: * css1/classification/white_space-expected.checksum: * css1/classification/white_space-expected.png: * css1/color_and_background/background-expected.checksum: * css1/color_and_background/background-expected.png: * css1/color_and_background/background_attachment-expected.checksum: * css1/color_and_background/background_attachment-expected.png: * css1/color_and_background/background_position-expected.checksum: * css1/color_and_background/background_position-expected.png: * css1/color_and_background/background_repeat-expected.checksum: * css1/color_and_background/background_repeat-expected.png: * css1/conformance/forward_compatible_parsing-expected.checksum: * css1/conformance/forward_compatible_parsing-expected.png: * css1/font_properties/font-expected.checksum: * css1/font_properties/font-expected.png: * css1/font_properties/font_family-expected.checksum: * css1/font_properties/font_family-expected.png: * css1/font_properties/font_size-expected.checksum: * css1/font_properties/font_size-expected.png: * css1/font_properties/font_weight-expected.checksum: * css1/font_properties/font_weight-expected.png: * css1/formatting_model/floating_elements-expected.checksum: * css1/formatting_model/floating_elements-expected.png: * css1/formatting_model/height_of_lines-expected.checksum: * css1/formatting_model/height_of_lines-expected.png: * css1/formatting_model/horizontal_formatting-expected.checksum: * css1/formatting_model/horizontal_formatting-expected.png: * css1/formatting_model/inline_elements-expected.checksum: * css1/formatting_model/inline_elements-expected.png: * css1/formatting_model/replaced_elements-expected.checksum: * css1/formatting_model/replaced_elements-expected.png: * css1/formatting_model/vertical_formatting-expected.checksum: * css1/formatting_model/vertical_formatting-expected.png: * css1/pseudo/anchor-expected.checksum: * css1/pseudo/anchor-expected.png: * css1/pseudo/firstletter-expected.checksum: * css1/pseudo/firstletter-expected.png: * css1/pseudo/firstline-expected.checksum: * css1/pseudo/firstline-expected.png: * css1/pseudo/multiple_pseudo_elements-expected.checksum: * css1/pseudo/multiple_pseudo_elements-expected.png: * css1/text_properties/letter_spacing-expected.checksum: * css1/text_properties/letter_spacing-expected.png: * css1/text_properties/line_height-expected.checksum: * css1/text_properties/line_height-expected.png: * css1/text_properties/text-transCapitalize-expected.checksum: * css1/text_properties/text-transCapitalize-expected.png: * css1/text_properties/text_decoration-expected.checksum: * css1/text_properties/text_decoration-expected.png: * css1/text_properties/text_indent-expected.checksum: * css1/text_properties/text_indent-expected.png: * css1/text_properties/text_transform-expected.checksum: * css1/text_properties/text_transform-expected.png: * css1/text_properties/vertical_align-expected.checksum: * css1/text_properties/vertical_align-expected.png: * css1/text_properties/word_spacing-expected.checksum: * css1/text_properties/word_spacing-expected.png: * css1/units/color_units-expected.checksum: * css1/units/color_units-expected.png: * css1/units/length_units-expected.checksum: * css1/units/length_units-expected.png: * css2.1/t0801-c412-hz-box-00-b-a-expected.checksum: * css2.1/t0801-c412-hz-box-00-b-a-expected.png: * css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: * css2.1/t0803-c5502-mrgn-r-02-c-expected.png: * css2.1/t0803-c5505-mrgn-02-c-expected.checksum: * css2.1/t0803-c5505-mrgn-02-c-expected.png: * css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: * css2.1/t080301-c411-vt-mrgn-00-b-expected.png: * css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: * css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: * css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: * css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: * css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: * css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: * css2.1/t1002-c5523-width-02-b-g-expected.checksum: * css2.1/t1002-c5523-width-02-b-g-expected.png: * css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: * css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: * css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: * css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: * css2.1/t1508-c527-font-07-b-expected.checksum: * css2.1/t1508-c527-font-07-b-expected.png: * editing/deleting/delete-after-span-ws-001-expected.checksum: * editing/deleting/delete-after-span-ws-001-expected.png: * editing/deleting/delete-after-span-ws-002-expected.checksum: * editing/deleting/delete-after-span-ws-002-expected.png: * editing/deleting/delete-after-span-ws-003-expected.checksum: * editing/deleting/delete-after-span-ws-003-expected.png: * editing/deleting/delete-and-undo-expected.checksum: * editing/deleting/delete-and-undo-expected.png: * editing/deleting/delete-and-undo-expected.txt: * editing/deleting/delete-line-end-ws-001-expected.checksum: * editing/deleting/delete-line-end-ws-001-expected.png: * editing/deleting/delete-line-end-ws-002-expected.checksum: * editing/deleting/delete-line-end-ws-002-expected.png: * editing/inserting/insert-div-023-expected.checksum: * editing/inserting/insert-div-023-expected.png: * editing/selection/caret-and-focus-ring.html: * editing/selection/drag-to-contenteditable-iframe-expected.checksum: Added. * editing/selection/drag-to-contenteditable-iframe-expected.png: Added. * editing/selection/drag-to-contenteditable-iframe-expected.txt: Added. * editing/selection/drag-to-contenteditable-iframe.html: Added. * editing/selection/focus_editable_html-expected.checksum: * editing/selection/focus_editable_html-expected.png: * editing/selection/iframe-expected.checksum: * editing/selection/iframe-expected.png: * editing/selection/replaced-boundaries-3-expected.checksum: * editing/selection/replaced-boundaries-3-expected.png: * editing/selection/select-all-001-expected.checksum: * editing/selection/select-all-001-expected.png: * editing/selection/select-all-002-expected.checksum: * editing/selection/select-all-002-expected.png: * editing/selection/select-all-003-expected.checksum: * editing/selection/select-all-003-expected.png: * editing/selection/select-all-004-expected.checksum: * editing/selection/select-all-004-expected.png: * editing/selection/select-box-expected.checksum: * editing/selection/select-box-expected.png: * editing/selection/selection-background.html: * editing/selection/unrendered-001-expected.checksum: * editing/selection/unrendered-001-expected.png: * editing/selection/unrendered-002-expected.checksum: * editing/selection/unrendered-002-expected.png: * editing/selection/unrendered-003-expected.checksum: * editing/selection/unrendered-003-expected.png: * editing/selection/unrendered-004-expected.checksum: * editing/selection/unrendered-004-expected.png: * editing/selection/unrendered-005-expected.checksum: * editing/selection/unrendered-005-expected.png: * editing/undo/4063751-expected.txt: * editing/undo/redo-typing-001-expected.txt: * editing/undo/undo-typing-001-expected.checksum: * editing/undo/undo-typing-001-expected.png: * editing/undo/undo-typing-001-expected.txt: * fast/block/basic/016-expected.checksum: * fast/block/basic/016-expected.png: * fast/block/basic/text-indent-rtl-expected.checksum: * fast/block/float/008-expected.checksum: * fast/block/float/008-expected.png: * fast/block/float/013-expected.checksum: * fast/block/float/013-expected.png: * fast/block/float/019-expected.checksum: * fast/block/float/019-expected.png: * fast/block/float/021-expected.checksum: * fast/block/float/021-expected.png: * fast/block/float/025-expected.checksum: * fast/block/float/025-expected.png: * fast/block/float/026-expected.checksum: * fast/block/float/026-expected.png: * fast/block/float/027-expected.checksum: * fast/block/float/027-expected.png: * fast/block/float/028-expected.checksum: * fast/block/float/028-expected.png: * fast/block/float/032-expected.checksum: * fast/block/float/032-expected.png: * fast/block/float/033-expected.checksum: * fast/block/float/033-expected.png: * fast/block/margin-collapse/103-expected.checksum: * fast/block/margin-collapse/103-expected.png: * fast/block/margin-collapse/104-expected.checksum: * fast/block/margin-collapse/104-expected.png: * fast/block/positioning/047-expected.checksum: * fast/block/positioning/047-expected.png: * fast/block/positioning/051-expected.checksum: * fast/block/positioning/051-expected.png: * fast/block/positioning/055-expected.checksum: * fast/block/positioning/055-expected.png: * fast/block/positioning/auto/007-expected.checksum: * fast/block/positioning/auto/007-expected.png: * fast/block/positioning/relayout-on-position-change-expected.checksum: * fast/box-sizing/box-sizing-expected.checksum: * fast/box-sizing/box-sizing-expected.png: * fast/clip/014-expected.checksum: * fast/clip/014-expected.png: * fast/css-generated-content/014-expected.checksum: * fast/css-generated-content/014-expected.png: * fast/css/005-expected.checksum: * fast/css/005-expected.png: * fast/css/MarqueeLayoutTest-expected.checksum: * fast/css/MarqueeLayoutTest-expected.png: * fast/css/imageTileOpacity-expected.checksum: * fast/css/imageTileOpacity-expected.png: * fast/css/word-space-extra-expected.checksum: * fast/css/word-space-extra-expected.png: * fast/dom/HTMLObjectElement/object-as-frame.html: * fast/dom/focus-contenteditable-expected.checksum: * fast/dom/focus-contenteditable-expected.png: * fast/dom/window-onFocus.html: * fast/dynamic/008-expected.checksum: * fast/dynamic/008-expected.png: * fast/encoding/utf-16-big-endian-expected.checksum: * fast/encoding/utf-16-big-endian-expected.png: * fast/encoding/utf-16-little-endian-expected.checksum: * fast/encoding/utf-16-little-endian-expected.png: * fast/flexbox/009-expected.checksum: * fast/flexbox/009-expected.png: * fast/flexbox/016-expected.checksum: * fast/flexbox/016-expected.png: * fast/forms/001-expected.checksum: * fast/forms/001-expected.png: * fast/forms/003-expected.checksum: * fast/forms/003-expected.png: * fast/forms/004-expected.checksum: * fast/forms/004-expected.png: * fast/forms/HTMLOptionElement_label01-expected.checksum: * fast/forms/HTMLOptionElement_label01-expected.png: * fast/forms/HTMLOptionElement_label02-expected.checksum: * fast/forms/HTMLOptionElement_label02-expected.png: * fast/forms/HTMLOptionElement_label03-expected.checksum: * fast/forms/HTMLOptionElement_label03-expected.png: * fast/forms/HTMLOptionElement_label04-expected.checksum: * fast/forms/HTMLOptionElement_label04-expected.png: * fast/forms/button-sizes-expected.checksum: * fast/forms/button-sizes-expected.png: * fast/forms/checkbox-radio-onchange-expected.checksum: * fast/forms/checkbox-radio-onchange-expected.png: * fast/forms/form-element-geometry-expected.checksum: * fast/forms/form-element-geometry-expected.png: * fast/forms/indeterminate-expected.checksum: * fast/forms/indeterminate-expected.png: * fast/forms/option-script-expected.checksum: * fast/forms/option-script-expected.png: * fast/forms/option-strip-whitespace-expected.checksum: * fast/forms/option-strip-whitespace-expected.png: * fast/forms/radio_checked-expected.checksum: * fast/forms/radio_checked-expected.png: * fast/forms/radio_checked_dynamic-expected.checksum: * fast/forms/radio_checked_dynamic-expected.png: * fast/forms/textAreaLineHeight-expected.checksum: * fast/forms/textAreaLineHeight-expected.png: * fast/inline-block/tricky-baseline-expected.checksum: * fast/inline-block/tricky-baseline-expected.png: * fast/invalid/014-expected.checksum: * fast/invalid/014-expected.png: * fast/lists/008-expected.checksum: * fast/lists/008-expected.png: * fast/lists/li-br-expected.checksum: * fast/lists/li-br-expected.png: * fast/lists/olstart-expected.checksum: * fast/lists/olstart-expected.png: * fast/loader/form-events-back-forward.html: Removed. * fast/loader/form-events-back-forward.html-disabled: Added. * fast/overflow/002-expected.checksum: * fast/overflow/002-expected.png: * fast/overflow/003-expected.checksum: * fast/overflow/003-expected.png: * fast/overflow/005-expected.checksum: * fast/overflow/005-expected.png: * fast/overflow/006-expected.checksum: * fast/overflow/006-expected.png: * fast/overflow/007-expected.checksum: * fast/overflow/007-expected.png: * fast/overflow/image-selection-highlight-expected.checksum: * fast/overflow/image-selection-highlight-expected.png: * fast/overflow/overflow-auto-table-expected.checksum: * fast/overflow/overflow-auto-table-expected.png: * fast/overflow/overflow-rtl-expected.checksum: * fast/overflow/overflow-rtl-expected.png: * fast/overflow/overflow-text-hit-testing-expected.checksum: * fast/overflow/overflow-text-hit-testing-expected.png: * fast/overflow/scrollRevealButton-expected.checksum: * fast/overflow/scrollRevealButton-expected.png: * fast/parser/comments-expected.checksum: * fast/parser/comments-expected.png: * fast/parser/document-write-option-expected.checksum: * fast/parser/document-write-option-expected.png: * fast/parser/entities-in-xhtml-expected.checksum: * fast/parser/entities-in-xhtml-expected.png: * fast/replaced/005-expected.checksum: * fast/replaced/005-expected.png: * fast/replaced/width100percent-expected.checksum: * fast/replaced/width100percent-expected.png: * fast/selectors/166-expected.checksum: * fast/selectors/166-expected.png: * fast/table/023-expected.checksum: * fast/table/023-expected.png: * fast/table/034-expected.checksum: * fast/table/034-expected.png: * fast/table/040-expected.checksum: * fast/table/040-expected.png: * fast/table/border-collapsing/004-expected.checksum: * fast/table/border-collapsing/004-expected.png: * fast/table/edge-offsets-expected.checksum: * fast/table/edge-offsets-expected.png: * fast/table/height-percent-test-expected.checksum: * fast/table/height-percent-test-expected.png: * fast/table/overflowHidden-expected.checksum: * fast/table/overflowHidden-expected.png: * fast/table/wide-colspan-expected.checksum: * fast/table/wide-colspan-expected.png: * fast/table/wide-column-expected.checksum: * fast/table/wide-column-expected.png: * fast/text/softHyphen-expected.checksum: * fast/text/softHyphen-expected.png: * fast/text/whitespace/024-expected.checksum: * fast/text/whitespace/024-expected.png: * fast/tokenizer/004-expected.checksum: * fast/tokenizer/004-expected.png: * svg/custom/feDisplacementMap-01-expected.png: Removed. * svg/custom/junk-data-expected.checksum: * svg/custom/junk-data-expected.png: * svg/custom/missing-xlink-expected.checksum: * svg/custom/missing-xlink-expected.png: * svg/custom/path-bad-data-expected.checksum: * svg/custom/path-bad-data-expected.png: * traversal/tree-walker-004-expected.checksum: * traversal/tree-walker-004-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 15 Feb, 2006 4 commits
-
-
ggaren authored
Reviewed by Maciej, Eric. - WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type() WebCore and JavaScriptCore weren't sharing Instance objects very nicely. I made them use RefPtrs, and sent them to bed without dessert. * bindings/jni/jni_instance.cpp: Made _instance a RefPtr (JavaInstance::~JavaInstance): (JObjectWrapper::JObjectWrapper): * bindings/jni/jni_instance.h: (KJS::Bindings::JObjectWrapper::ref): (KJS::Bindings::JObjectWrapper::deref): * bindings/jni/jni_runtime.cpp: Made _array a RefPtr (JavaArray::~JavaArray): (JavaArray::JavaArray): * bindings/jni/jni_runtime.h: (KJS::Bindings::JavaArray::operator=): * bindings/objc/objc_runtime.h: - Prohibited copying because that would muss the ref count. - Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug. * bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp): * bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject): * bindings/runtime.h: (KJS::Bindings::Instance::ref): (KJS::Bindings::Instance::deref): * bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): * bindings/runtime_object.h: - Removed ownsInstance data member because RefPtr takes care of instance lifetime now. - Prohibited copying because that would muss the ref count. - Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug. (KJS::RuntimeObjectImp::getInternalInstance): LayoutTests: Reviewed by Eric. - Layout test for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type() * plugins: Added. * plugins/undefined-property-crash-expected.txt: Added. * plugins/undefined-property-crash.html: Added. WebCore: Reviewed by Maciej, Eric. - WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type() WebCore and JavaScriptCore weren't sharing Instance objects very nicely. I made them use RefPtrs, and sent them to bed without dessert. * khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made appletInstance a RefPtr (WebCore::HTMLAppletElementImpl::getAppletInstance): (WebCore::HTMLAppletElementImpl::detach): (WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made embedInstance a RefPtr (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLEmbedElementImpl::detach): (WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made objectInstance a RefPtr (WebCore::HTMLObjectElementImpl::getObjectInstance): (WebCore::HTMLObjectElementImpl::detach): * bindings/js/JSDOMCore.cpp: * khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject): * khtml/html/html_objectimpl.h: WebKitTools: Reviewed by Eric. * DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]): Added a dummy method for the sake of LayoutTests/plugins/ undefined-property-crash.html. (It tests a crash due to fallback object use. WebCore won't create a fallback object if the method is not defined.) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12840 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Add files missing from previous commit. * svg/custom/feDisplacementMap-01-expected.checksum: Added. * svg/custom/feDisplacementMap-01-expected.png: Added. * svg/custom/feDisplacementMap-01-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12838 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Reviewed by eseidel. Landed by eseidel. Implemented feDisplacementMap. http://bugzilla.opendarwin.org/show_bug.cgi?id=5862 Test: svg/custom/feDisplacementMap-01.svg * WebCore.xcodeproj/project.pbxproj: added files. * kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFEDisplacementMap::externalRepresentation): * kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap): (WebCore::KCanvasFEDisplacementMap::xChannelSelector): (WebCore::KCanvasFEDisplacementMap::setXChannelSelector): (WebCore::KCanvasFEDisplacementMap::yChannelSelector): (WebCore::KCanvasFEDisplacementMap::setYChannelSelector): (WebCore::KCanvasFEDisplacementMap::scale): (WebCore::KCanvasFEDisplacementMap::setScale): * kcanvas/device/quartz/KCanvasFilterQuartz.h: * kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::getVectorForChannel): (WebCore::KCanvasFEDisplacementMapQuartz::getCIFilter): * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createFilterEffect): * kcanvas/device/quartz/filters/WKDisplacementMapFilter.cikernel: Added. * kcanvas/device/quartz/filters/WKDisplacementMapFilter.h: Added. * kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: Added. (+[WKDisplacementMapFilter initialize]): (+[WKDisplacementMapFilter filterWithName:]): (-[WKDisplacementMapFilter init]): (-[WKDisplacementMapFilter outputImage]): * ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: Added. (SVGFEDisplacementMapElementImpl::SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::~SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::in1): (SVGFEDisplacementMapElementImpl::in2): (SVGFEDisplacementMapElementImpl::xChannelSelector): (SVGFEDisplacementMapElementImpl::yChannelSelector): (SVGFEDisplacementMapElementImpl::scale): (SVGFEDisplacementMapElementImpl::stringToChannel): (SVGFEDisplacementMapElementImpl::parseMappedAttribute): (SVGFEDisplacementMapElementImpl::filterEffect): * ksvg2/svg/SVGFEDisplacementMapElementImpl.h: Added. * ksvg2/svg/svgtags.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12819 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Update missing result from last commit. * fast/xsl/xslt-recursion-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 14 Feb, 2006 7 commits
-
-
ap authored
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6452 KURL::appendEscapingBadChars() doesn't know about %u-escaping. Test case: fast/encoding/percent-escaping.html * kwq/KWQKURL.mm: (appendEscapingBadChars): Rather than adding support for %u, remove the existing "do what I mean" escaping of percent characters that do not look like a result of prior escaping. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12814 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eseidel authored
Reviewed by darin. Add incremental parsing support to XMLTokenizer. This patch also does a few other little things: - removes (unused) onHold support from Tokenizer - adds serialization of DOCTYPEs for xml documents - fixes xslt support to no longer depend on synchronous parsing - fixes css styling for pages where xsl recursion is blocked http://bugzilla.opendarwin.org/show_bug.cgi?id=6057 * dom/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::createProcessingInstruction): (WebCore::DocumentImpl::open): (WebCore::DocumentImpl::recalcStyleSelector): * dom/dom_xmlimpl.cpp: (WebCore::ProcessingInstructionImpl::checkStyleSheet): * dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::write): (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::error): (WebCore::XMLTokenizer::initializeParserContext): (WebCore::XMLTokenizer::finish): (WebCore::xmlDocPtrForString): (WebCore::parseAttributes): * dom/xml_tokenizer.h: * khtml/editing/markup.cpp: (khtml::startMarkup): DOCTYPE serialization * khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): removed onHold (WebCore::HTMLTokenizer::reset): removed onHold (WebCore::HTMLTokenizer::begin): removed onHold (WebCore::HTMLTokenizer::write): removed onHold (WebCore::HTMLTokenizer::finish): removed onHold * khtml/html/htmltokenizer.h: removed onHold support * khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::document): (WebCore::XSLStyleSheetImpl::setDocument): (WebCore::XSLStyleSheetImpl::parseString): (WebCore::XSLStyleSheetImpl::loadChildSheets): (WebCore::XSLStyleSheetImpl::compileStyleSheet): (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource): * khtml/xsl/xsl_stylesheetimpl.h: moved functions to .cpp file git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12812 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6815 Calculate correct width for new text fields * fast/forms/input-appearance-width.html: Added. * fast/forms/input-appearance-width-expected.txt: Added. * fast/forms/input-appearance-width-expected.png: Added. * fast/forms/input-appearance-width-expected.checksum: Added. * fast/forms/input-appearance-minWidth.html: Added. * fast/forms/input-appearance-minWidth-expected.txt: Added. * fast/forms/input-appearance-minWidth-expected.png: Added. * fast/forms/input-appearance-minWidth-expected.checksum: Added. WebCore: Reviewed by Maciej. http://bugzilla.opendarwin.org/show_bug.cgi?id=6815 Calculate correct width for new text fields Tests: fast/forms/input-appearance-width.html fast/forms/input-appearance-minWidth.html * rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Remove fixed width for text field. (WebCore::RenderTextField::calcMinMaxWidth): Added. This calls RenderBlock::calcMinMaxWidth and then uses the size attribute to determine what the maxWidth should be. * rendering/RenderTextField.h: Added calcMinMaxWidth. * rendering/render_theme_mac.h: Added adjustTextFieldStyle. * rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): Remove inflation of rect. This is no longer necessary. (WebCore::RenderThemeMac::paintTextField): ditto. (WebCore::RenderThemeMac::setTextFieldCellState): change true to YES. (WebCore::RenderThemeMac::adjustTextFieldStyle): Added. This is the temporary home of the code to set the right padding and margins. When we flip the switch, this will go in html4.css. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12810 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
* fast/forms/HTMLOptionElement_label05-expected.checksum: Added. * fast/forms/HTMLOptionElement_label05-expected.png: Added. * fast/forms/HTMLOptionElement_label05-expected.txt: Added. * fast/forms/HTMLOptionElement_label05.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12806 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
* fast/forms/HTMLOptionElement_label04-expected.checksum: Added. * fast/forms/HTMLOptionElement_label04-expected.png: Added. * fast/forms/HTMLOptionElement_label04-expected.txt: Added. * fast/forms/HTMLOptionElement_label04.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12805 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
adele authored
Moving these tests to a better location. * dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Removed. * dom/html/level2/html/HTMLOptionElement_label01-expected.png: Removed. * dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Removed. * dom/html/level2/html/HTMLOptionElement_label01.html: Removed. * dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Removed. * dom/html/level2/html/HTMLOptionElement_label02-expected.png: Removed. * dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Removed. * dom/html/level2/html/HTMLOptionElement_label02.html: Removed. * dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Removed. * dom/html/level2/html/HTMLOptionElement_label03-expected.png: Removed. * dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Removed. * dom/html/level2/html/HTMLOptionElement_label03.html: Removed. * fast/forms/HTMLOptionElement_label01-expected.checksum: Added. * fast/forms/HTMLOptionElement_label01-expected.png: Added. * fast/forms/HTMLOptionElement_label01-expected.txt: Added. * fast/forms/HTMLOptionElement_label01.html: Added. * fast/forms/HTMLOptionElement_label02-expected.checksum: Added. * fast/forms/HTMLOptionElement_label02-expected.png: Added. * fast/forms/HTMLOptionElement_label02-expected.txt: Added. * fast/forms/HTMLOptionElement_label02.html: Added. * fast/forms/HTMLOptionElement_label03-expected.checksum: Added. * fast/forms/HTMLOptionElement_label03-expected.png: Added. * fast/forms/HTMLOptionElement_label03-expected.txt: Added. * fast/forms/HTMLOptionElement_label03.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12804 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sullivan authored
- tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7255 label attribute in option elements is ignored * dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Added. * dom/html/level2/html/HTMLOptionElement_label01-expected.png: Added. * dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Added. * dom/html/level2/html/HTMLOptionElement_label01.html: Added. * dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Added. * dom/html/level2/html/HTMLOptionElement_label02-expected.png: Added. * dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Added. * dom/html/level2/html/HTMLOptionElement_label02.html: Added. * dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Added. * dom/html/level2/html/HTMLOptionElement_label03-expected.png: Added. * dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Added. * dom/html/level2/html/HTMLOptionElement_label03.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
