1. 30 Aug, 2011 40 commits
    • rniwa@webkit.org's avatar
      GTK build fix after r94142. · e935b95a
      rniwa@webkit.org authored
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::setAutofilled):
      (DumpRenderTreeSupportGtk::setValueForUser):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e935b95a
    • rniwa@webkit.org's avatar
      Chromium build fix after r94142. · 7149e518
      rniwa@webkit.org authored
      * src/EditorClientImpl.cpp:
      (WebKit::EditorClientImpl::textFieldDidEndEditing):
      (WebKit::EditorClientImpl::doTextFieldCommandFromEvent):
      * src/WebPasswordFormUtils.cpp:
      (WebKit::findPasswordFormFields):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7149e518
    • levin@chromium.org's avatar
      [chromium] New baselines due to r94109. · 8f548bb7
      levin@chromium.org authored
      * platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Removed.
      * platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Removed.
      * platform/chromium-linux/fast/table/table-after-child-in-table-expected.txt: Removed.
      * platform/chromium-linux/fast/table/table-before-child-in-table-expected.txt: Removed.
      * platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.txt: Removed.
      * platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.txt: Removed.
      * platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.txt: Removed.
      * platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.txt: Removed.
      * platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
      * platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
      * platform/chromium-win/fast/table/table-after-child-in-table-expected.txt:
      * platform/chromium-win/fast/table/table-before-child-in-table-expected.txt:
      * platform/chromium-win/fast/table/table-before-child-style-update-expected.png: Added.
      * platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt:
      * platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt:
      * platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt:
      * platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt:
      * platform/chromium-win/fast/table/table-row-before-child-style-update-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f548bb7
    • rniwa@webkit.org's avatar
      Get rid of toInputElement() · 7a7015f1
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67175
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Got rid of Node::toInputElement and HTMLInputElement::toInputElement and replaced them by
      a global toHTMLInputElement.
      
      * WebCore.order:
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isPasswordField):
      (WebCore::AccessibilityRenderObject::isIndeterminate):
      (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
      (WebCore::AccessibilityRenderObject::isChecked):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::canShareStyleWithControl):
      (WebCore::CSSStyleSelector::adjustRenderStyle):
      (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
      (WebCore::CSSStyleSelector::applyProperty):
      * dom/CheckedRadioButtons.cpp:
      (WebCore::CheckedRadioButtons::addButton):
      (WebCore::CheckedRadioButtons::removeButton):
      * dom/Node.cpp:
      * dom/Node.h:
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::isInPasswordField):
      * html/HTMLInputElement.h:
      (WebCore::toHTMLInputElement):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::sliderThumbElementOf):
      (WebCore::RenderSliderThumb::layout):
      (WebCore::RenderSliderContainer::layout):
      (WebCore::SliderThumbElement::hostInput):
      (WebCore::trackLimiterElementOf):
      * html/shadow/TextControlInnerElements.cpp:
      (WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
      (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
      (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
      (WebCore::SpinButtonElement::defaultEventHandler):
      (WebCore::SpinButtonElement::repeatingTimerFired):
      (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
      (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
      * page/DragController.cpp:
      (WebCore::asFileInput):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintThemePart):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
      (WebCore::RenderTextControlSingleLine::inputElement):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isChecked):
      (WebCore::RenderTheme::isIndeterminate):
      
      Source/WebKit/chromium: 
      
      * src/WebInputElement.cpp:
      (WebKit::toWebInputElement):
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setAutofilled):
      (DumpRenderTreeSupportQt::setValueForUser):
      (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a7015f1
    • rniwa@webkit.org's avatar
      Speculative WinCairo build fix after r94093. · 05b6fb69
      rniwa@webkit.org authored
      * platform/network/ResourceHandle.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05b6fb69
    • ojan@chromium.org's avatar
      add a test for border/padding/margin on the flexbox container · a1a4c14f
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67243
      
      Reviewed by Tony Chang.
      
      * css3/flexbox/001-expected.txt:
      * css3/flexbox/001.html:
      * css3/flexbox/resources/flexbox.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1a4c14f
    • rniwa@webkit.org's avatar
      Mac build fix after r94128. · db4c07b4
      rniwa@webkit.org authored
      * WebCore.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db4c07b4
    • commit-queue@webkit.org's avatar
      Correctly report selected text range for accessibility APIs for role=textbox · f0a44e41
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65900
      
      Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-30
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Test: accessibility/textbox-role-reports-selection.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
      (WebCore::AccessibilityRenderObject::rootEditableElementForPosition):
      (WebCore::AccessibilityRenderObject::nodeIsTextControl):
      (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
      * accessibility/AccessibilityRenderObject.h:
      
      LayoutTests:
      
      * accessibility/textbox-role-reports-selection-expected.txt: Added.
      * accessibility/textbox-role-reports-selection.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0a44e41
    • nduca@chromium.org's avatar
      Unreviewed, fix WebGL layout tests due to missing WebView pointer. · 193fc1d4
      nduca@chromium.org authored
      * src/GraphicsContext3DChromium.cpp:
      (WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      193fc1d4
    • commit-queue@webkit.org's avatar
      The "port" property of an <a> whose href does not specify a port returns the wrong value · b3745700
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66081
      
      Source/WebCore:
      
      HTMLAnchorElement now returns "" instead of "0" for unset port
      Fixed KURLGoogle.cpp to have same behavior as KURL.cpp when setting port 0
      Fixed Location.cpp to have same behavior as KURL.cpp when setting port 0
      
      Patch by Rachel Blum <groby@chromium.org> on 2011-08-30
      Reviewed by Adam Barth.
      
      Tests: fast/dom/HTMLAnchorElement/get-href-attribute-port.html
             fast/dom/HTMLAnchorElement/set-href-attribute-port.html
             fast/loader/location-port.html
             fast/url/segments-from-data-url.html
             fast/url/segments.html
             fast/url/trivial-segments.html
             platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port.html
      
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::port):
      * page/Location.cpp:
      (WebCore::Location::host):
      (WebCore::Location::port):
      (WebCore::Location::setPort):
      * platform/KURLGoogle.cpp:
      (WebCore::KURL::setPort):
      
      LayoutTests:
      
      Updated tests to reflect behavior change around invalid port strings.
      Updated chromium location-port test to reflect chromium issues
      
      Patch by Rachel Blum <groby@chromium.org> on 2011-08-30
      Reviewed by Adam Barth.
      
      * fast/dom/HTMLAnchorElement/get-href-attribute-port-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/get-href-attribute-port.html: Added.
      * fast/dom/HTMLAnchorElement/script-tests/get-href-attribute-port.js: Added.
      * fast/loader/location-port-expected.txt:
      * fast/loader/location-port.html:
      * fast/url/script-tests/segments-from-data-url.js:
      * fast/url/script-tests/segments.js:
      * fast/url/script-tests/trivial-segments.js:
      * fast/url/segments-expected.txt:
      * fast/url/segments-from-data-url-expected.txt:
      * fast/url/trivial-segments-expected.txt:
      * platform/chromium-cg-mac/fast/loader/location-port-expected.txt:
      * platform/chromium-win/fast/loader/location-port-expected.txt:
      * platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3745700
    • commit-queue@webkit.org's avatar
      Fix pan scrolling on Windows to be clamped · 731c4678
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66910
      
      Source/WebCore:
      
      With the recent change to support rubberband scrolling on the Mac, pan
      scrolling of overflow divs became unclamped and would scroll infinitely
      and along an axis without a scrollbar.
      
      Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
      Reviewed by Simon Fraser
      
      Test: platform/win/fast/events/panScroll-correct-direction.html
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::panScrollFromPoint):
      (WebCore::RenderLayer::scrollByRecursively):
      * rendering/RenderLayer.h:
      
      LayoutTests:
      
      With the recent change to support rubberband scrolling on the Mac, pan
      scrolling of overflow divs became unclamped and would scroll infinitely
      and along an axis without a scrollbar.
      
      Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
      Reviewed by Simon Fraser
      
      * platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png:
      * platform/win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
      * platform/win/fast/events/panScroll-correct-direction-expected.txt: Added.
      * platform/win/fast/events/panScroll-correct-direction.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      731c4678
    • commit-queue@webkit.org's avatar
      This patch makes the XMLHttpRequest method/header validation logic available as · 988e6498
      commit-queue@webkit.org authored
      static methods so URL loaders can perform the same checks for untrusted HTTP requests
      coming from plugins.
      https://bugs.webkit.org/show_bug.cgi?id=66909
      
      Patch by Bill Budge <bbudge@chromium.org> on 2011-08-30
      Reviewed by David Levin.
      
      No new tests. Exposes no new functionality.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * platform/network/HTTPValidation.cpp: Added.
      (WebCore::isValidHTTPToken):
      (WebCore::isValidHTTPHeaderValue):
      * platform/network/HTTPValidation.h: Added.
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::isAllowedHTTPMethod):
      (WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):
      (WebCore::XMLHttpRequest::isAllowedHTTPHeader):
      (WebCore::XMLHttpRequest::open):
      (WebCore::XMLHttpRequest::setRequestHeader):
      * xml/XMLHttpRequest.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      988e6498
    • crogers@google.com's avatar
      Don't allow nodes of one context to be connected to nodes of another context · f64e987d
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67245
      
      Source/WebCore:
      
      Reviewed by Dimitri Glazkov.
      
      Tests: updated webaudio/audionode.html
      
      * webaudio/AudioNode.cpp:
      (WebCore::AudioNode::connect):
      
      LayoutTests:
      
      Reviewed by Dimitri Glazkov.
      
      * webaudio/audionode-expected.txt:
      * webaudio/audionode.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f64e987d
    • rniwa@webkit.org's avatar
      WinCE build fix attempt after r94080. · 7ac16a81
      rniwa@webkit.org authored
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::scrollRectIntoView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ac16a81
    • mitz@apple.com's avatar
      Source/WebCore: WebCore part of <rdar://problem/9281695> Add text search API... · 9ac3b8c5
      mitz@apple.com authored
      Source/WebCore: WebCore part of <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
      https://bugs.webkit.org/show_bug.cgi?id=67230
      
      Reviewed by Darin Adler.
      
      Test: TestWebKitAPI/Tests/mac/DOMRangeOfString.
      
      * WebCore.exp.in: Export Page::rangeOfString().
      * dom/Range.h: Added a default ASSERT_NO_EXCEPTION to a few more member functions.
      * editing/Editor.cpp:
      (WebCore::Editor::findString): Moved most of the logic into rangeOfString(), which this function
      now calls, passing in the current selection as the reference range and setting the selection to
      the returned range.
      (WebCore::Editor::rangeOfString): Added. Contains the find logic from findString().
      * editing/Editor.h:
      * page/Page.cpp:
      (WebCore::Page::rangeOfString): Added. This function is similar to findString(), but it takes an optional
      reference range and returns a Range, rather than using the current selection as the reference range and setting the
      selection to the next match.
      * page/Page.h:
      
      Source/WebKit/mac: <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
      https://bugs.webkit.org/show_bug.cgi?id=67230
      
      Reviewed by Darin Adler.
      
      * WebView/WebHTMLView.mm:
      * WebView/WebView.mm:
      (coreOptions): Moved this function from WebHTMLView.mm to here and made
      it accessible from both this file and WebHTMLView.mm.
      (-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API.
      * WebView/WebViewInternal.h:
      * WebView/WebViewPrivate.h:
      
      Tools: Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
      https://bugs.webkit.org/show_bug.cgi?id=67230
      
      Reviewed by Darin Adler.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
      * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
      (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
      (TestWebKitAPI::TEST):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ac3b8c5
    • weinig@apple.com's avatar
      Add additional convertValue overloads to JSDictionary · 138f267d
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67244
      
      Reviewed by Darin Adler.
      
      Add overloads for convertValue that will be needed for Event
      constructors.
      
      * bindings/js/JSDictionary.cpp:
      (WebCore::JSDictionary::convertValue):
      * bindings/js/JSDictionary.h:
      Add overloads.  Remove #include of <runtime/Error.h> and just include
      <interpreter/CallFrame.h>
      
      * bindings/js/JSEventConstructors.cpp:
      Add now necessary #include of <runtime/Error.h>.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      138f267d
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=67150 · 41d74127
      bdakin@apple.com authored
      Would like API to use a custom device scale factor for a particular WebView/WKView
      -and corresponding-
      <rdar://problem/10041016>
      
      Reviewed by Darin Adler.
      
      Source/WebKit/mac: 
      
      New API is _setOverrideBackingScaleFactor:(CGFloat)
      * WebView/WebView.mm:
      (-[WebView _setOverrideBackingScaleFactor:]):
      (-[WebView _deviceScaleFactor]):
      * WebView/WebViewData.h:
      * WebView/WebViewPrivate.h:
      
      Source/WebKit2: 
      
      New API is setOverrideBackingScaleFactor() on WKPage
      * UIProcess/API/C/WKPage.cpp:
      (WKPageGetOverrideBackingScaleFactor):
      (WKPageSetOverrideBackingScaleFactor):
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      (WebKit::WebPageProxy::deviceScaleFactor):
      (WebKit::WebPageProxy::setOverrideBackingScaleFactor):
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::overrideBackingScaleFactor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41d74127
    • commit-queue@webkit.org's avatar
      Add MediaSource API to HTMLMediaElement · 7b352317
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64731
      
      Patch by Aaron Colwell <acolwell@chromium.org> on 2011-08-30
      Reviewed by Eric Carlson.
      
      .:
      
      * configure.ac:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      Tests: http/tests/media/media-source/webm/video-media-source-errors.html
             http/tests/media/media-source/webm/video-media-source-play.html
             http/tests/media/media-source/webm/video-media-source-seek.html
             http/tests/media/media-source/webm/video-media-source-state-changes.html
      
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * dom/EventNames.h:
      * features.pri:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Added initializers for new member variables.
      (WebCore::HTMLMediaElement::prepareForLoad): Close the media source before starting a new load.
      (WebCore::HTMLMediaElement::loadResource):
          Fail loading if the media source url from another media element is used.
      (WebCore::HTMLMediaElement::mediaEngineError):
          Make sure the source is in the closed state before firing an emptied event.
      (WebCore::HTMLMediaElement::mediaPlayerSourceOpened):
          New method called by WebCore::MediaPlayer to signal when the source is open.
      (WebCore::HTMLMediaElement::mediaPlayerSourceURL):
          New method called by the WebCore::MediaPlayer to determine what the media source URL is for this
          HTMLMediaElement instance.
      (WebCore::HTMLMediaElement::seek):
          Disabled noSeekRequired optimization if a media source is open and resets the source state to SOURCE_OPEN if
          it was in the SOURCE_ENDED state when seek() was called.
      (WebCore::HTMLMediaElement::webkitSourceAppend):
          New method for passing media data from JavaScript to the WebCore::MediaPlayer.
      (WebCore::HTMLMediaElement::webkitSourceEndOfStream):
          New method that allows JavaScript to signal the end of the stream.
      (WebCore::HTMLMediaElement::webkitSourceState): New method allowing JavaScript to read the current source state.
      (WebCore::HTMLMediaElement::setSourceState): New method for updating the current source state.
      (WebCore::HTMLMediaElement::userCancelledLoad):
          Transitions an open source to the closed state before firing an emptied event.
      * html/HTMLMediaElement.h:
      (WebCore::HTMLMediaElement::webkitMediaSourceURL):
          New method providing the media source URL to JavaScript for this HTMLMediaElement instance.
      * html/HTMLMediaElement.idl: Added new methods, attributes, and constants for the media source api.
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::NullMediaPlayerPrivate::sourceAppend):
          Stub implementation of new WebCore::MediaPlayerPrivateInterface::sourceAppend.
      (WebCore::NullMediaPlayerPrivate::sourceEndOfStream):
          Stub implementation of new WebCore::MediaPlayerPrivateInterface::sourceEndOfStream.
      (WebCore::MediaPlayer::sourceAppend): New method for receiving media data from WebCore::HTMLMediaElement.
      (WebCore::MediaPlayer::sourceEndOfStream): New method for receiving end of stream from WebCore::HTMLMediaElement.
      (WebCore::MediaPlayer::sourceOpened):
          New method called by the MediaPlayerPrivate object to notify the MediaPlayer when the source has opened.
      (WebCore::MediaPlayer::sourceURL):
          New method called by the MediaPlayerPrivate implementation to get the media source URL from the MediaPlayer.
      * platform/graphics/MediaPlayer.h:
      (WebCore::MediaPlayerClient::mediaPlayerSourceOpened):
          Interface method used by the MediaPlayer to tell the HTMLMediaElement when the media source has been opened.
      (WebCore::MediaPlayerClient::mediaPlayerSourceURL):
          Interface method used by the MediaPlayer to get the media source URL from the HTMLMediaElement.
      * platform/graphics/MediaPlayerPrivate.h:
      (WebCore::MediaPlayerPrivateInterface::sourceAppend):
          Interface method used by the MediaPlayer to pass media data to the MediaPlayerPrivate object.
      (WebCore::MediaPlayerPrivateInterface::sourceEndOfStream):
          Interface method used by the MediaPlayer to pass end of stream information to the MediaPlayerPrivate object.
      
      Source/WebKit/chromium:
      
      * public/WebMediaPlayer.h:
      (WebKit::WebMediaPlayer::sourceAppend):
      (WebKit::WebMediaPlayer::sourceEndOfStream):
      * public/WebMediaPlayerClient.h:
      * src/WebMediaPlayerClientImpl.cpp:
      (WebKit::WebMediaPlayerClientImpl::sourceOpened):
      (WebKit::WebMediaPlayerClientImpl::sourceURL):
      (WebKit::WebMediaPlayerClientImpl::sourceAppend):
      (WebKit::WebMediaPlayerClientImpl::sourceEndOfStream):
      * src/WebMediaPlayerClientImpl.h:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      * Scripts/build-webkit:
      
      WebKitLibraries:
      
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      LayoutTests:
      
      * http/tests/media/media-source/webm/video-media-source-errors-expected.txt: Added.
      * http/tests/media/media-source/webm/video-media-source-errors.html: Added.
      * http/tests/media/media-source/webm/video-media-source-play-expected.txt: Added.
      * http/tests/media/media-source/webm/video-media-source-play.html: Added.
      * http/tests/media/media-source/webm/video-media-source-seek-expected.txt: Added.
      * http/tests/media/media-source/webm/video-media-source-seek.html: Added.
      * http/tests/media/media-source/webm/video-media-source-state-changes-expected.txt: Added.
      * http/tests/media/media-source/webm/video-media-source-state-changes.html: Added.
      * http/tests/media/media-source/webm/webm-media-source.js: Added.
      (getData):
      (getHeaders):
      (getClusterCount):
      (getCluster):
      (getClusterTimeForIndex):
      (getClusterIndexForTimestamp):
      (setSrcToMediaSourceURL):
      (appendHeaders):
      (appendCluster):
      (appendUntilEndOfStream):
      (logSourceState):
      (getSourceStateName):
      (expectSourceState):
      * http/tests/media/resources/media-source/webm/test.webm: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-0: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-1: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-10: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-11: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-12: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-13: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-14: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-15: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-2: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-3: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-4: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-5: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-6: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-7: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-8: Added.
      * http/tests/media/resources/media-source/webm/test.webm.cluster-9: Added.
      * http/tests/media/resources/media-source/webm/test.webm.headers: Added.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b352317
    • inferno@chromium.org's avatar
      Unreviewed. Chromium rebaselines for r94109. · f5c84d99
      inferno@chromium.org authored
      * platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
      * platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
      * platform/chromium-linux/fast/table/table-after-child-in-table-expected.txt: Added.
      * platform/chromium-linux/fast/table/table-before-child-in-table-expected.txt: Added.
      * platform/chromium-linux/fast/table/table-before-child-style-update-expected.png: Added.
      * platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.txt: Added.
      * platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.txt: Added.
      * platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.txt: Added.
      * platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.txt: Added.
      * platform/chromium-linux/fast/table/table-row-before-child-style-update-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5c84d99
    • weinig@apple.com's avatar
      Refactor JS dictionary code into helper class and covert geolocation code to use it · b45f6eb5
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67213
      
      Reviewed by Darin Adler.
      
      * GNUmakefile.list.am:
      * UseJSC.cmake:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSBindingsAllInOne.cpp:
      Add new files.
      
      * bindings/js/JSDictionary.cpp: Added.
      (WebCore::JSDictionary::convertValue):
      * bindings/js/JSDictionary.h: Added.
      (WebCore::JSDictionary::JSDictionary):
      (WebCore::JSDictionary::tryGetProperty):
      Encapsulate dictionary initialization code into JSDictionary class.
      
      * bindings/js/JSEventConstructors.cpp:
      (WebCore::constructJSEventWithInitializer):
      Use JSDictionary.
      
      * bindings/js/JSGeolocationCustom.cpp:
      (WebCore::setEnableHighAccuracy):
      (WebCore::setTimeout):
      (WebCore::setMaximumAge):
      (WebCore::createPositionOptions):
      Use JSDictionary.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b45f6eb5
    • commit-queue@webkit.org's avatar
      Switch chromium to use ScrollAnimatorNone on Windows. · 7e8d0fc4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67000
      
      Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
      Reviewed by Adam Barth.
      
      Testing covered by Chromium webkit_unit_tests ScrollAnimatorNoneTest.*
      
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e8d0fc4
    • tony@chromium.org's avatar
      refactor and cleanup RenderFlexibleBox · 97231feb
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67165
      
      Reviewed by Ojan Vafai.
      
      No new tests, just refactoring code.
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::layoutHorizontalBlock):
      (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmHorizontal): Make childSizes a param so we can pass the results to layoutAndPlaceChildrenHorizontal.
      (WebCore::hasPackingSpace): Move closer to where it's used.
      (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenHorizontal):
          Pull this code out into its own function because it's not part of running the free space allocation algorithm.
      * rendering/RenderFlexibleBox.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97231feb
    • timothy_horton@apple.com's avatar
      getBBox() on a SVGPathElement with curves incorrectly includes control points · 47c6523e
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53512
      <rdar://problem/9861154>
      
      Reviewed by Dirk Schulze.
      
      The CoreGraphics implementation of Path::boundingRect() called
      CGPathGetBoundingBox, which includes the path's control points in its
      calculations. Snow Leopard added CGPathGetPathBoundingBox, which
      finds the bounding box of only points within the path, and does not
      include control points. On Snow Leopard and above, we now use the latter.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47c6523e
    • adachan@apple.com's avatar
      Laying some groundwork to fetch performance statistics from WebProcess. · e51a25ac
      adachan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67160
      
      Reviewed by Darin Adler.
      
      Add WKContextGetStatistics() which sends a message to WebProcess to fetch the performance statistics.
      * UIProcess/API/C/WKContext.cpp:
      (WKContextGetStatistics):
      * UIProcess/API/C/WKContext.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::~WebContext):
      (WebKit::WebContext::getWebCoreStatistics):
      (WebKit::WebContext::didGetWebCoreStatistics):
      * UIProcess/WebContext.h:
      * UIProcess/WebContext.messages.in: Add the DidGetWebCoreStatistics message that WebProcess can send when it has
      the performance statistics ready.
      
      Add WebProcess::getWebCoreStatistics().  Currently it just sends back an empty StatisticsData object.
      It will gather the performance statistics to store in the StatisticsData object in a future patch.
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::getWebCoreStatistics):
      * WebProcess/WebProcess.h:
      * WebProcess/WebProcess.messages.in:
      
      Add the skeleton for StatisticsData.
      * Scripts/webkit2/messages.py:
      * Shared/StatisticsData.cpp: Added.
      (WebKit::StatisticsData::encode):
      (WebKit::StatisticsData::decode):
      (WebKit::StatisticsData::StatisticsData):
      * Shared/StatisticsData.h: Added.
      
      Add StatisticsData.h/cpp to project.
      * CMakeLists.txt:
      * GNUmakefile.am:
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e51a25ac
    • timothy_horton@apple.com's avatar
      SVG panning y-axis is flipped in WebKit2 · bad6e837
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65800
      <rdar://problem/9908012>
      
      Reviewed by Darin Adler.
      
      We previously were not transforming the pointer coordinates passed
      to SVGDocument's panning implementation into the coordinate space of
      the contents, so on different platforms, the drag direction was different.
      
      Test: svg/custom/pan-direction.svg
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bad6e837
    • caryclark@google.com's avatar
      LayoutTest expected results for Skia on Mac (animations and canvas directories only) · 835b589c
      caryclark@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67218
      
      Reviewed by Adam Barth.
      
      * platform/chromium-mac/animations: Added.
      * platform/chromium-mac/animations/missing-values-first-keyframe-expected.png: Added.
      * platform/chromium-mac/animations/missing-values-last-keyframe-expected.png: Added.
      * platform/chromium-mac/animations/opacity-transform-animation-expected.png: Added.
      * platform/chromium-mac/animations/state-at-end-event-expected.png: Added.
      * platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: Added.
      * platform/chromium-mac/canvas: Added.
      * platform/chromium-mac/canvas/philip: Added.
      * platform/chromium-mac/canvas/philip/tests: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.composite.operation.clear-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.composite.operation.darker-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.fill.copy-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.drawImage.broken-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.outside3-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.imageData.create1.type-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.imageData.create2.type-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.imageData.get.type-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.imageData.object.round-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.imageData.object.wrap-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.missingargs-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.path.arc.angle.3-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.path.arc.angle.5-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.pattern.image.incomplete.omitted-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.pattern.image.string-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.pattern.image.undefined-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.pattern.paint.norepeat.coord3-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.pattern.paint.repeatx.coord1-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.pattern.paint.repeaty.coord1-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.alpha-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.basic-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.shadow.image.alpha-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.shadow.image.basic-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.shadow.image.scale-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.align.center-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.text.measure.width.space-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.
      * platform/chromium-mac/canvas/philip/tests/type.prototype-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      835b589c
    • abarth@webkit.org's avatar
      Flaky crash with JavaScript URLs · 0cb1dfce
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66360
      
      Reviewed by Nate Chapin.
      
      Source/WebCore: 
      
      This patch teaches DocumentWriter::begin to make a copy of the URL
      before beginning a new document to avoid a crash.
      
      Test: fast/loader/javascript-url-iframe-crash.html
      
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::begin):
      
      LayoutTests: 
      
      * fast/loader/javascript-url-iframe-crash-expected.txt: Added.
      * fast/loader/javascript-url-iframe-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cb1dfce
    • tonyg@chromium.org's avatar
      PreloadScanner shouldn't load images inside noscript via doc.write · 17f15f50
      tonyg@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67214
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      The problem was that the tokenizer state was lost between each call to document.write.
      This works around that bug by making all document.write()s in the same script block share
      the same tokenizer state.
      
      Test: fast/preloader/document-write-noscript.html
      
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::~HTMLDocumentParser):
      (WebCore::HTMLDocumentParser::detach):
      (WebCore::HTMLDocumentParser::insert):
      * html/parser/HTMLDocumentParser.h:
      
      LayoutTests:
      
      * fast/preloader/document-write-noscript-expected.txt: Added.
      * fast/preloader/document-write-noscript.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17f15f50
    • dimich@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=67210 · 992f8f72
      dimich@chromium.org authored
      [Chromium] Use after free in ScheduledAction::execute(WebCore::V8Proxy*)
      
      Reviewed by David Levin.
      
      * bindings/v8/ScheduledAction.cpp:
      (WebCore::ScheduledAction::execute):
      Removed usage of V8Proxy instance after it could have been deleted.
      
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::V8Proxy):
      * bindings/v8/V8Proxy.h:
      Removed unused timerCallback() and setTimerCallback().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      992f8f72
    • inferno@chromium.org's avatar
      Source/WebCore: Style not updated for table parts in :before, :after content. · 5cc5f9c7
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66141        
      
      Reviewed by Dave Hyatt.
      
      Tests: fast/table/table-before-child-style-update.html
             fast/table/table-row-before-child-style-update.html
      
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::updateBeforeAfterContent):
      
      LayoutTests: Style not updated for table parts in :before, :after content.
      https://bugs.webkit.org/show_bug.cgi?id=66141
      
      1. 2 new tests show that the blue and green boxes don't overlap
      after the fix.
      2. update r93794 tests showing that style info is propagated.
      
      Reviewed by Dave Hyatt.
      
      * fast/table/table-before-child-style-update-expected.png: Added.
      * fast/table/table-before-child-style-update-expected.txt: Added.
      * fast/table/table-before-child-style-update.html: Added.
      * fast/table/table-row-before-child-style-update-expected.png: Added.
      * fast/table/table-row-before-child-style-update-expected.txt: Added.
      * fast/table/table-row-before-child-style-update.html: Added.
      * platform/mac/fast/table/table-after-child-in-table-expected.txt:
      * platform/mac/fast/table/table-before-child-in-table-expected.txt:
      * platform/mac/fast/table/table-row-after-child-in-block-expected.txt:
      * platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
      * platform/mac/fast/table/table-row-before-child-in-block-expected.txt:
      * platform/mac/fast/table/table-row-before-child-in-table-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cc5f9c7
    • tony@chromium.org's avatar
      refactor box-ordinal-group handling so we don't timeout on large values · 58afcb04
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65783
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      The old code walked from 1 to the last box-ordinal-group while
      iterating over each flex item.  The new code collects ordinals as
      we do the first walk and sorts them.  Each additional iteration
      through the flex items gets the next oridnal from the sorted list.
      
      This maintains the single pass for the common case of no
      box-ordinal-groups specified.  If there are ordinal groups,
      the runtime is O(n*m + m lg m) where n is the # of flex items and
      m is the number of unique box-ordinal-group values.  The memory
      usage is O(2m).
      
      Test: fast/flexbox/box-ordinal-group.html
      
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::FlexBoxIterator::FlexBoxIterator):
      (WebCore::FlexBoxIterator::reset):
      (WebCore::FlexBoxIterator::next):
      (WebCore::FlexBoxIterator::compareFlexOrder):
      
      LayoutTests:
      
      * fast/flexbox/box-ordinal-group-expected.txt: Added.
      * fast/flexbox/box-ordinal-group.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58afcb04
    • inferno@chromium.org's avatar
      Removed m_owner accessed in custom scrollbars. · 2cc6f339
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64737
      
      Reviewed by David Hyatt.
      
      Problem does not reproduce in DRT, even with Eventhandler tricks
      and gc(). So, adding a manual test.
      
      * manual-tests/custom-scrollbar-renderer-removed-crash.html: Added.
      * page/FrameView.cpp:
      (WebCore::FrameView::clearOwningRendererForCustomScrollbars):
      * page/FrameView.h:
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::willBeDestroyed): when this renderbox is getting
      destroyed, clear the custom scrollbar in this frameview having this renderbox
      as its owning renderer.
      * rendering/RenderScrollbar.cpp:
      (WebCore::RenderScrollbar::getScrollbarPseudoStyle): fix the null check.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cc6f339
    • nduca@chromium.org's avatar
      [chromium] Allow GraphicsContexts to be created from MockWebGraphicsContexts · 4601260f
      nduca@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67179
      
      Reviewed by Kenneth Russell.
      
      * WebKit.gypi:
      * src/GraphicsContext3DChromium.cpp:
      (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
      (WebCore::GraphicsContext3DInternal::create):
      (WebCore::GraphicsContext3DInternal::createFromWebContext):
      (WebCore::GraphicsContext3D::create):
      * src/GraphicsContext3DInternal.h:
      * tests/MockGraphicsContext3DTest.cpp: Renamed from Source/WebKit/chromium/tests/MockWebGraphicsContext3DTest.cpp.
      (FrameCountingContext::FrameCountingContext):
      (FrameCountingContext::prepareTexture):
      (FrameCountingContext::frameCount):
      (TEST):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4601260f
    • caio.oliveira@openbossa.org's avatar
      Emit last progress notification before calling dispatchDidFinishLoad · 93e017d7
      caio.oliveira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28851
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Original patch by Xan Lopez. Change FrameLoader to dispatch the notifications in
      a more natural sequence.
      
      Test: http/tests/loading/progress-finished-callback.html
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      
      Source/WebKit/qt:
      
      Add infrastructure to dump progressFinishedNotification callback in DRT.
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::dumpProgressFinishedCallback):
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
      * WebCoreSupport/FrameLoaderClientQt.h:
      
      Tools:
      
      Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
      Chromium and GTK ports. The first two were simple changes.
      
      Some refactoring was needed in GTK port to assure that the dumps are emitted
      correctly and the processing after the page load finished is in the right place.
      
      To detect the load finished, we use the callback for the "load-status" notifier
      signal of the top loading frame. And we use the deprecated "load-finished" signal
      for dumping (if enabled) the progress finished expected output.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (dumpProgressFinishedCallbackCallback):
      (LayoutTestController::staticFunctions):
      * DumpRenderTree/LayoutTestController.h:
      (LayoutTestController::dumpProgressFinishedCallback):
      (LayoutTestController::setDumpProgressFinishedCallback):
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (LayoutTestController::dumpProgressFinishedCallback):
      (LayoutTestController::reset):
      * DumpRenderTree/chromium/LayoutTestController.h:
      (LayoutTestController::shouldDumpProgressFinishedCallback):
      (LayoutTestController::setShouldDumpProgressFinishedCallback):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::didStopLoading):
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (webViewLoadFinished):
      (topLoadingFrameLoadFinished):
      (webFrameLoadStatusNotified):
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::reset):
      (LayoutTestController::dumpProgressFinishedCallback):
      * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      LayoutTests:
      
      Keep track of the order expected for the progressFinishedNotification, which is
      before the didFinishLoadForFrame.
      
      * http/tests/loading/progress-finished-callback-expected.txt: Added.
      * http/tests/loading/progress-finished-callback.html: Added.
      * platform/mac/Skipped:
      * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93e017d7
    • ojan@chromium.org's avatar
      CSS parsing for -webkit-flex-flow · b04b9bc9
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67224
      
      Source/WebCore:
      
      Reviewed by Tony Chang.
      
      Adds support for the first value of -webkit-flex-flow.
      Later we'll need to add support for the second "wrap" value,
      but that can wait until we are ready to implement multiline
      flex and the spec has stabilized a bit.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator EFlexFlow):
      * css/CSSPropertyNames.in:
      * css/CSSStyleApplyProperty.cpp:
      (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      * css/CSSValueKeywords.in:
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::flexFlow):
      (WebCore::InheritedFlags::setFlexFlow):
      (WebCore::InheritedFlags::initialFlexFlow):
      * rendering/style/RenderStyleConstants.h:
      * rendering/style/StyleFlexibleBoxData.cpp:
      (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
      (WebCore::StyleFlexibleBoxData::operator==):
      * rendering/style/StyleFlexibleBoxData.h:
      
      LayoutTests:
      
      Reviewed by Tony Chang.
      
      * css3/flexbox/css-properties-expected.txt:
      * css3/flexbox/script-tests/css-properties.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b04b9bc9
    • fpizlo@apple.com's avatar
      JavaScriptCore does not have a good mechanism for performance · 8044d9f0
      fpizlo@apple.com authored
      regression testing
      https://bugs.webkit.org/show_bug.cgi?id=67177
      
      Reviewed by Darin Adler.
      
      Added a new script, which allows for testing one, two, or more VMs
      at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
      are interleaved at random to minimize systematics.  The results
      that bencher prints includes all possible relevant information about
      how bencher was invoked.  Bencher can be easily used to measure
      performance changes down to fractions of a percent.
      
      Bencher also includes experimental support for running benchmarks in
      a DumpRenderTree release build.  This works in SunSpider and V8, but
      not yet in Kraken.  Running benchmarks in DumpRenderTree more
      closely mimics the performance when running in browser.
      
      * Scripts/bencher: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8044d9f0
    • abarth@webkit.org's avatar
      [Chromium] Add null checks for document()->loader() · 2d3e53be
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67077
      
      Reviewed by Nate Chapin.
      
      Document::loader can return 0 for a number of reasons.  Call sites need
      to null check the result, like we do for Document::frame.  I suspect
      some of these are real crashes, along the lines of
      http://trac.webkit.org/changeset/93692, but null checking this function
      is just good practice.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
      * src/WebSearchableFormData.cpp:
      (HTMLNames::GetFormEncoding):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::pageEncoding):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d3e53be
    • commit-queue@webkit.org's avatar
      [Qt] Replace QLibrary("libgtk-x11-2.0.so.0") with QLibrary("libgtk-x11-2.0", 0) · b1d6ba06
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66627
      
      Patch by Dawit Alemayehu <adawit@kde.org> on 2011-08-30
      Reviewed by Simon Hausmann.
      
      * plugins/qt/PluginPackageQt.cpp:
      (WebCore::initializeGtk):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1d6ba06
    • levin@chromium.org's avatar
      [chromium] Add baselines for due to r94092 and r93909. · 3460a3fe
      levin@chromium.org authored
      * platform/chromium-cg-mac/fast/multicol/overflow-across-columns-expected.png: Added.
      * platform/chromium-cg-mac/fast/multicol/overflow-unsplittable-expected.png: Added.
      * platform/chromium-linux/fast/multicol/overflow-across-columns-expected.png: Added.
      * platform/chromium-linux/fast/multicol/overflow-unsplittable-expected.png: Added.
      * platform/chromium-win/fast/multicol/overflow-across-columns-expected.png: Added.
      * platform/chromium-win/fast/multicol/overflow-across-columns-expected.txt: Added.
      * platform/chromium-win/fast/multicol/overflow-unsplittable-expected.png: Added.
      * platform/chromium-win/fast/multicol/overflow-unsplittable-expected.txt: Added.
      * platform/chromium-win/fast/text/complex-preferred-logical-widths-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3460a3fe
    • ap@apple.com's avatar
      fast/loader/document-destruction-within-unload.html causes an assertion failure in the next · fcdc7578
      ap@apple.com authored
              test (currently, document-with-fragment-url-1.html)
              https://bugs.webkit.org/show_bug.cgi?id=66783
      
              * platform/mac/Skipped: Skipping the offending test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcdc7578