1. 28 Apr, 2010 22 commits
    • eric@webkit.org's avatar
      2010-04-28 Andrey Kosyakov <caseq@chromium.org> · e8bb8648
      eric@webkit.org authored
              Reviewed by Yury Semikhatsky.
      
              Log error message to inspector console if a resource fails to load.
              Moved console-tests.js to http tests. Added support for sorting
              console messages, in case order may vary.
              https://bugs.webkit.org/show_bug.cgi?id=37215
      
              * http/tests/inspector/console-resource-errors-expected.txt: Added.
              * http/tests/inspector/console-resource-errors.html: Added.
              * http/tests/inspector/console-tests.js: Added.
              (dumpConsoleMessages.callback):
              (dumpConsoleMessages):
              (dumpConsoleMessagesWithClasses.callback):
              (dumpConsoleMessagesWithClasses):
              (frontend_dumpConsoleMessages):
              * inspector/console-clear.html:
              * inspector/console-dir.html:
              * inspector/console-dirxml.html:
              * inspector/console-format-collections-expected.txt:
              * inspector/console-format-collections.html:
              * inspector/console-format.html:
              * inspector/console-log-before-inspector-open.html:
              * inspector/console-tests.html:
              * inspector/console-tests.js: Removed.
              * platform/mac-tiger/http/tests/inspector: Added.
              * platform/mac-tiger/http/tests/inspector/console-resource-errors-expected.txt: Added.
      2010-04-28  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Log error message to inspector console if a resource fails to load.
              Disable checking of mime-type consistency for failed resources.
              https://bugs.webkit.org/show_bug.cgi?id=37215
      
              Test: http/tests/inspector/console-resource-errors.html
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didFailLoading):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8bb8648
    • eric@webkit.org's avatar
      2010-04-28 Yury Semikhatsky <yurys@chromium.org> · 00f16c11
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Support pause on exceptions in v8 implementation of ScriptDebugServer.
      
              https://bugs.webkit.org/show_bug.cgi?id=38205
      
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::addListener):
              (WebCore::ScriptDebugServer::pauseOnExceptionsState):
              (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
              (WebCore::ScriptDebugServer::currentCallFrame):
              (WebCore::ScriptDebugServer::handleV8DebugMessage):
              (WebCore::ScriptDebugServer::dispatchDidParseSource):
              * bindings/v8/ScriptDebugServer.h:
      2010-04-28  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Support pause on exceptions in v8 implementation of ScriptDebugServer.
      
              https://bugs.webkit.org/show_bug.cgi?id=38205
      
              * src/js/DebuggerScript.js:
              (debuggerScriptConstructor.DebuggerScript.getScripts):
              (debuggerScriptConstructor.DebuggerScript.pauseOnExceptionsState):
              (debuggerScriptConstructor.DebuggerScript.setPauseOnExceptionsState):
              (debuggerScriptConstructor.DebuggerScript._v8ToWebkitLineNumber):
              (debuggerScriptConstructor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00f16c11
    • eric@webkit.org's avatar
      2010-04-28 Chris Jerdonek <cjerdonek@webkit.org> · 4a831099
      eric@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Adjusted check-webkit-style so that files with file type NONE
              are automatically skipped without warning.
      
              https://bugs.webkit.org/show_bug.cgi?id=38197
      
              This change simplifies configuring which files to skip.  It also
              addresses an issue whereby check-webkit-style was unintentionally
              checking .vcproj files for carriage returns.
      
              * Scripts/webkitpy/style/checker.py:
                - Moved the C++, Python, and text file extensions to new
                  module-level configuration variables.
                - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration
                  variable.
                - Changed the numeric values of the FileType enum so that
                  FileType.NONE evaluates to False.
                - For ProcessorDispatcher.should_skip_without_warning():
                  - Changed the method to return True for FileType.NONE files.
                  - Made ChangeLog files an exception to getting skipped.
                - Changed the StyleProcessor.process() method to raise an
                  exception if given a file path that should not be processed.
      
              * Scripts/webkitpy/style/checker_unittest.py:
                - Updated the unit tests and added more test cases as necessary.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a831099
    • jorlow@chromium.org's avatar
      2010-04-28 Sheriff Bot <webkit.review.bot@gmail.com> · a363da2f
      jorlow@chromium.org authored
              Unreviewed, rolling out r58313.
              http://trac.webkit.org/changeset/58313
              https://bugs.webkit.org/show_bug.cgi?id=38253
      
              Regression evident in pixel tests: the search icon is always
              clipped at the bottom. (Requested by jorlow on #webkit).
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::controlClipRect):
              * rendering/RenderTextControl.h:
              (WebCore::RenderTextControl::hasControlClip):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::paint):
              * rendering/RenderTextControlSingleLine.h:
      2010-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r58313.
              http://trac.webkit.org/changeset/58313
              https://bugs.webkit.org/show_bug.cgi?id=38253
      
              Regression evident in pixel tests: the search icon is always
              clipped at the bottom. (Requested by jorlow on #webkit).
      
              * fast/css/input-search-padding.html: Removed.
              * platform/mac/fast/css/input-search-padding-expected.checksum: Removed.
              * platform/mac/fast/css/input-search-padding-expected.png: Removed.
              * platform/mac/fast/css/input-search-padding-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a363da2f
    • hausmann@webkit.org's avatar
      3eb5fed6
    • hamaji@chromium.org's avatar
      2010-04-28 Shinichiro Hamaji <hamaji@chromium.org> · 098c2b61
      hamaji@chromium.org authored
              Unreviewed.  Disable printing/media-queries-print for now.
      
              Add layoutTestController.setPrinting()
              https://bugs.webkit.org/show_bug.cgi?id=37203
      
              * platform/mac/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      098c2b61
    • ukai@chromium.org's avatar
      2010-04-28 Eric Seidel <eric@webkit.org> · 648b0984
      ukai@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
              https://bugs.webkit.org/show_bug.cgi?id=38248
      
              The previous code did not check the return code of taskkill.
              When I moved that callsite from using subprocess.call to
              Executive.run_command having a non-zero return code became an error.
      
              In this change I've centralized our killall handling in executive,
              and added tests for it to make sure it works.
      
              Currently kill_process and kill_all swallow exceptions in the cases
              where the process(es) to be killed do(es) not exist.
      
              * Scripts/webkitpy/common/system/executive.py:
              * Scripts/webkitpy/common/system/executive_unittest.py:
              * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
              * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
              * Scripts/webkitpy/layout_tests/port/chromium_win.py:
              * Scripts/webkitpy/layout_tests/port/gtk.py:
              * Scripts/webkitpy/layout_tests/port/mac.py:
              * Scripts/webkitpy/layout_tests/port/qt.py:
              * Scripts/webkitpy/layout_tests/port/win.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      648b0984
    • hamaji@chromium.org's avatar
      2010-04-28 Shinichiro Hamaji <hamaji@chromium.org> · 780ddc97
      hamaji@chromium.org authored
              Unreviewed.  Added missing expectation files missed in r58386.
      
              Add layoutTestController.setPrinting()
              https://bugs.webkit.org/show_bug.cgi?id=37203
      
              * platform/mac/printing/media-queries-print-expected.checksum: Added.
              * platform/mac/printing/media-queries-print-expected.png: Added.
              * platform/mac/printing/media-queries-print-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      780ddc97
    • eric@webkit.org's avatar
      2010-04-28 Eric Seidel <eric@webkit.org> · 774991a9
      eric@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              wdiff_text throws ScriptError because wdiff returns non-zero when files differ
              https://bugs.webkit.org/show_bug.cgi?id=38246
      
              wdiff returns 0 when files are the same, 1 when they differ.
              run_command by default raises ScriptError if the return code is non-zero.
              Fixed this by adding a custom error handler which only raises if the
              return code is not 1.
      
              I broke up the huge wdiff_text() method into little pieces
              for easier unit testing.  There is only one functional change here
              and that is the addition of the custom error handler.
      
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      774991a9
    • ukai@chromium.org's avatar
      Unreviewed build fix. · db7ccfd7
      ukai@chromium.org authored
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::willSendRequest): too few arguments for format.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db7ccfd7
    • hausmann@webkit.org's avatar
      JSC's currentThreadStackBase is not reentrant on some platforms · 1923ee4b
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=37195
      
      Patch by Simon Hausmann  <simon.hausmann@nokia.com>, Kent Hansen <kent.hansen@nokia.com> on 2010-04-28
      Reviewed by Darin Adler.
      
      This function needs to be reentrant to avoid memory corruption on platforms where
      the implementation uses global variables.
      
      This patch adds a mutex lock where necessary and makes the Symbian implementation
      reentrant.
      
      * runtime/Collector.cpp:
      (JSC::currentThreadStackBaseMutex):
      (JSC::currentThreadStackBase):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1923ee4b
    • hausmann@webkit.org's avatar
      Fix compilation with gcc 3.4. · f2933708
      hausmann@webkit.org authored
      Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-04-28
      Reviewed by Simon Hausmann.
      
      AtomicStringImpl.h:29: error: base `WebCore::StringImpl' with only
      non-default constructor in class without a constructor
      
      * wtf/text/AtomicStringImpl.h:
      (WebCore::AtomicStringImpl::AtomicStringImpl): Provide a default constructor.
      * wtf/text/StringImpl.h: Allow AtomicStringImpl to call a StringImpl constructor through a friend declaration.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2933708
    • hausmann@webkit.org's avatar
      [Qt] WINS DEF file freeze · d12b409d
      hausmann@webkit.org authored
      Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-04-28
      Reviewed by Simon Hausmann <simon.hausmann@nokia.com>
      
      Updated WINSCW def file with added and removed symbols.
      
      * symbian/bwins/QtWebKitu.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d12b409d
    • hausmann@webkit.org's avatar
      [Qt] Fix detection of Qt 4.7's multimedia libraries · 59ca134a
      hausmann@webkit.org authored
      Patch by Justin McPherson <justin.mcpherson@nokia.com> on 2010-04-28
      Reviewed by Simon Hausmann.
      
      QtMultimedia has been split into an additional media services library, which
      we're using. mediaservices depends on multimedia.
      
      * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59ca134a
    • hamaji@chromium.org's avatar
      2010-04-28 Shinichiro Hamaji <hamaji@chromium.org> · 3ba6d93e
      hamaji@chromium.org authored
              Unreviewed attempt to fix the chromium build.
      
              Add layoutTestController.setPrinting()
              https://bugs.webkit.org/show_bug.cgi?id=37203
      
              * rendering/RenderTreeAsText.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ba6d93e
    • dbates@webkit.org's avatar
      2010-04-28 Daniel Bates <dbates@rim.com> · fb513124
      dbates@webkit.org authored
              Unreviewed, rebase expected result of failing test.
      
              Rebasing Qt expected result for selection-gap-overflow-scroll-2.html.
              Following the landing of bug #37686, this test started failing despite
              being unrelated to this bug. From looking at the diff of the result,
              which shows a 1 pixel shift in widths, and based on Csaba Osztrogonac's
              comment, we have decided to rebase this result.
      
              * platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb513124
    • sfalken@apple.com's avatar
      WebView drawing code may access null backing store dirty region · 8ece1dac
      sfalken@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=38245
      <rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)
              
      Reviewed by Maciej Stachowiak.
      
      * WebView.cpp:
      (WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ece1dac
    • hamaji@chromium.org's avatar
      2010-04-27 Shinichiro Hamaji <hamaji@chromium.org> · fbee9667
      hamaji@chromium.org authored
              Reviewed by Darin Adler and Eric Seidel.
      
              Add layoutTestController.setPrinting()
              https://bugs.webkit.org/show_bug.cgi?id=37203
      
              Now we can test media queries with the new function because the
              render tree has the color information of the box.
      
              Note that the pixel test is currently failing. We'll need another
              patch to enable printing mode for pixel tests.
      
              * platform/mac/Skipped:
              * platform/mac/printing/media-queries-print-expected.checksum: Added.
              * platform/mac/printing/media-queries-print-expected.png: Added.
              * platform/mac/printing/media-queries-print-expected.txt: Added.
              * printing/media-queries-print.html:
      2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler and Eric Seidel.
      
              Add layoutTestController.setPrinting()
              https://bugs.webkit.org/show_bug.cgi?id=37203
      
              Added RenderAsTextPrintingMode as a behavior of externalRepresentation.
      
              Now ~PrintContext() calls end() automatically.
      
              * page/PrintContext.cpp:
              (WebCore::PrintContext::~PrintContext):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::externalRepresentation):
              * rendering/RenderTreeAsText.h:
              (WebCore::):
      2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler and Eric Seidel.
      
              Add layoutTestController.setPrinting()
              https://bugs.webkit.org/show_bug.cgi?id=37203
      
              * Misc/WebCoreStatistics.h:
              * Misc/WebCoreStatistics.mm:
              (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):
      2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler and Eric Seidel.
      
              Add layoutTestController.setPrinting()
              https://bugs.webkit.org/show_bug.cgi?id=37203
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (setPrintingCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              (LayoutTestController::isPrinting):
              (LayoutTestController::setIsPrinting):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (dump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbee9667
    • yuzo@google.com's avatar
      2010-04-27 Yuzo Fujishima <yuzo@google.com> · 77d5c0cd
      yuzo@google.com authored
              Reviewed by Eric Seidel.
      
              Enhance CSS parser for Paged Media (Iteration 4)
              Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
              https://bugs.webkit.org/show_bug.cgi?id=35853
      
              * printing/page-rule-css-text-expected.txt:
              * printing/page-rule-css-text.html:
      2010-04-27  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Eric Seidel.
      
              Enhance CSS parser for Paged Media (Iteration 4)
              Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
              https://bugs.webkit.org/show_bug.cgi?id=35853
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parsePage):
              * css/CSSParser.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77d5c0cd
    • yuzo@google.com's avatar
      2010-04-27 Yuzo Fujishima <yuzo@google.com> · 734dc152
      yuzo@google.com authored
              Reviewed by Dimitri Glazkov.
      
              Enhance CSS parser for Paged Media (Iteration 3)
              Implement size parameter parsing for Paged Media.
              https://bugs.webkit.org/show_bug.cgi?id=35851
      
              * printing/page-rule-css-text-expected.txt:
              * printing/page-rule-css-text.html:
      2010-04-27  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Enhance CSS parser for Paged Media (Iteration 3)
              Implement size parameter parsing for Paged Media.
              https://bugs.webkit.org/show_bug.cgi?id=35851
      
              I believe size property hasn't been used so far because (1) it hasn't been properly parsed and
              (2) a comment in CSSComputedStyleDeclaration::getPropertyCSSValue says so.
              Changing the way of parsing it should not cause any regressions -- no existing tests fail because of this change.
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseSize):
              (WebCore::CSSParser::parseSizeParameter):
              * css/CSSParser.h:
              (WebCore::CSSParser::):
              * css/CSSValueKeywords.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      734dc152
    • yuzo@google.com's avatar
      2010-04-27 Yuzo Fujishima <yuzo@google.com> · 4e988936
      yuzo@google.com authored
              Reviewed by Eric Seidel.
      
              Enhance CSS parser for Paged Media (Iteration 2)
              Parse and hold paged media rules in CSSStyleSelector.
      
              fast/dom/script-tests/prototype-inheritance-2.js is rebaselined because it assumes @page is ignored.
      
              https://bugs.webkit.org/show_bug.cgi?id=35782
      
              * fast/dom/prototype-inheritance-2-expected.txt:
              * fast/dom/script-tests/prototype-inheritance-2.js:
              * printing/page-rule-css-text-expected.txt: Added.
              * printing/page-rule-css-text.html: Added.
      2010-04-27  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Eric Seidel.
      
              Enhance CSS parser for Paged Media (Iteration 2)
              Parse and hold paged media rules in CSSStyleSelector.
      
              https://bugs.webkit.org/show_bug.cgi?id=35782
      
              Test: printing/page-rule-css-text.html
      
              * css/CSSGrammar.y:
              * css/CSSPageRule.cpp:
              (WebCore::CSSPageRule::CSSPageRule):
              (WebCore::CSSPageRule::selectorText):
              * css/CSSPageRule.h:
              (WebCore::CSSPageRule::create):
              (WebCore::CSSPageRule::isPageRule):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::createPageRule):
              * css/CSSStyleRule.h:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSRuleSet::getPageRules):
              (WebCore::CSSRuleSet::CSSRuleSet):
              (WebCore::CSSRuleSet::~CSSRuleSet):
              (WebCore::CSSRuleSet::addPageRule):
              (WebCore::CSSRuleSet::addRulesFromSheet):
              * css/CSSStyleSelector.h:
              * css/StyleBase.h:
              (WebCore::StyleBase::isPageRule):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e988936
    • eric@webkit.org's avatar
      2010-04-27 Jens Alfke <snej@chromium.org> · 9f8cb6db
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [chromium] Fix bug that prevents autosave of forms without action attribute
              https://bugs.webkit.org/show_bug.cgi?id=38014
              Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
              It needs a native unit test, which would go in the Chromium repo, not WebKit.
      
              * src/WebPasswordFormData.cpp:
              (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f8cb6db
  2. 27 Apr, 2010 18 commits
    • dbates@webkit.org's avatar
      2010-04-27 Daniel Bates <dbates@rim.com> · 8ef22da0
      dbates@webkit.org authored
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=37686
      
              Fixes an issue where the canvas method strokeRect will stroke a
              rectangle whose dimensions are 0 when lineWidth > 1.
      
              As per the definition of strokeRect in the HTML Canvas 2D Context
              spec. <http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>,
              this method should have no effect when both the height and width
              are zero.
      
              Tests: fast/canvas/canvas-clearRect.html
                     fast/canvas/canvas-fillRect.html
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::validateRectForCanvas): Return false if height, width == 0.
      2010-04-27  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=37686
      
              Tests that strokeRect does not paint any artifacts when the
              specified rectangle has height, width = 0 and lineWidth > 1.
      
              Also tests that clearRect, fillRect, and rect are ignored when
              height, width = 0.
      
              * fast/canvas/canvas-clearRect-expected.txt: Added.
              * fast/canvas/canvas-clearRect.html: Added.
              * fast/canvas/canvas-fillRect-expected.txt: Added.
              * fast/canvas/canvas-fillRect.html: Added.
              * fast/canvas/canvas-modify-emptyPath-expected.txt:
              * fast/canvas/canvas-strokeRect-expected.txt: Updated results.
              * fast/canvas/script-tests/canvas-clearRect.js: Added.
              * fast/canvas/script-tests/canvas-fillRect.js: Added.
              * fast/canvas/script-tests/canvas-modify-emptyPath.js: Added test case.
              * fast/canvas/script-tests/canvas-strokeRect.js: Ditto. Also, added
              debug statements so as to distinguish the results for each test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ef22da0
    • eric@webkit.org's avatar
      2010-04-27 Michael Nordman <michaeln@google.com> · 0a1d68fc
      eric@webkit.org authored
              Reviewed by Dmitry Titov.
      
              [Chromium] Add two things to the webkit API to support appcaches in workers.
              1) WebURLRequest TargetTypes for worker and shared worker main resources.
              2) Factory method on class WebCommonWorkerClient to
                 createApplicationCacheHost() for the associated worker.
      
              https://bugs.webkit.org/show_bug.cgi?id=38147
      
              * public/WebCommonWorkerClient.h: add the factory method
              * public/WebURLRequest.h: add the TargetTypes
              * src/WebWorkerBase.cpp: call the embedder's factory when needed
              (WebKit::WebWorkerBase::didCreateDataSource)
              (WebKit::WebWorkerBase::createApplicationCacheHost)
              * src/WebWorkerBase.h: ditto
              * src/WebWorkerClientImpl.h: add a stub impl of the factory method
              (WebKit::WebWorkerClientImpl::createApplicationCacheHost):
      2010-04-27  Michael Nordman  <michaeln@google.com>
      
              Reviewed by Dmitry Titov.
      
              [Chromium] Add two things to the webkit API to support appcaches in workers.
              1) WebURLRequest TargetTypes for worker and shared worker main resources.
              2) Factory method on class WebCommonWorkerClient to
                 createApplicationCacheHost() for the associated worker.
      
              https://bugs.webkit.org/show_bug.cgi?id=38147
      
              * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method
              (TestWebWorker::createApplicationCacheHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a1d68fc
    • eric@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · 8d9ea0cd
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove obsolete custom bindings file
              https://bugs.webkit.org/show_bug.cgi?id=38223
      
              We don't need these files anymore because they are empty.
      
              * Android.jscbindings.mk:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSAbstractWorkerCustom.cpp: Removed.
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSDocumentFragmentCustom.cpp: Removed.
              * bindings/js/JSEventSourceCustom.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d9ea0cd
    • eric@webkit.org's avatar
      2010-04-27 Daniel Cheng <dcheng@chromium.org> · 8a8b11d5
      eric@webkit.org authored
              Reviewed by Jian Li.
      
              [Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.
              https://bugs.webkit.org/show_bug.cgi?id=38227
      
              Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work
              since the default drop handling uses the drag data URL to navigate to dropped files/URLs.
              For now, we hack around the problem in the Chromium platform, but the proper long term
              solution is to change DragController::performDrag to check dragData::asFilenames().
      
              No new tests.
      
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::ClipboardChromium::getData):
              (WebCore::ClipboardChromium::types):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a8b11d5
    • tkent@chromium.org's avatar
      2010-04-27 Kent Tamura <tkent@chromium.org> · 6d26e81d
      tkent@chromium.org authored
              Reviewed by Shinichiro Hamaji.
      
              [DRT/Chromium] Enable Windows project generation
              https://bugs.webkit.org/show_bug.cgi?id=38103
      
              - Avoid platform.system(), which causes a crash with python.exe in
                depot_tools. Use sys.platform instead.
              - Process DumpRenderTree.gyp on all platforms.
      
              * gyp_webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d26e81d
    • eric@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · 2c4ea47d
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              run-bindings-tests doesn't work in an SVN checkout
              https://bugs.webkit.org/show_bug.cgi?id=38225
      
              Previously detect_scm_system needed an absolute path for SVN.  Now we
              accept a relative path.
      
              * Scripts/webkitpy/common/checkout/scm.py:
              * Scripts/webkitpy/common/checkout/scm_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c4ea47d
    • simon.fraser@apple.com's avatar
      2010-04-27 Simon Fraser <simon.fraser@apple.com> · b30d73b5
      simon.fraser@apple.com authored
              Reviewed by the inimitable Dan Bernstein.
      
              SVG as background image renders incorrectly after zooming
              https://bugs.webkit.org/show_bug.cgi?id=38215
      
              When doing a partial redraw of an SVGImage used as a CSS background
              image, we're limited to drawing the entire Frame, clipped to the dirty rect.
              Because of this, we need to fix up the CTM so that the origin is at the
              top left of the unclipped image, rather than the top left of the
              portion being redrawn.
      
              Test: fast/images/svg-background-partial-redraw.html
      
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::draw):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b30d73b5
    • yuzo@google.com's avatar
      2010-04-27 Yuzo Fujishima <yuzo@google.com> · 1fcfaa52
      yuzo@google.com authored
              Reviewed by David Hyatt.
      
              Retry of: Enhance CSS parser for Paged Media (Iteration 1)
      
              In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
              The contents of the methods should be implemented by other changes.
      
              https://bugs.webkit.org/show_bug.cgi?id=35329
      
              * fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
              * fast/css/parsing-page-rule.html: Added.
      2010-04-27  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by David Hyatt.
      
              Retry of: Enhance CSS parser for Paged Media (Iteration 1)
      
              In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
              The contents of the methods should be implemented by other changes.
      
              https://bugs.webkit.org/show_bug.cgi?id=35329
      
              Test: fast/css/parsing-page-rule.html
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::clearProperties):
              (WebCore::CSSParser::createPageRule):
              (WebCore::CSSParser::createMarginAtRule):
              (WebCore::CSSParser::startDeclarationsForMarginBox):
              (WebCore::CSSParser::endDeclarationsForMarginBox):
              * css/CSSParser.h:
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::pseudoId):
              (WebCore::nameToPseudoTypeMap):
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/tokenizer.flex:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fcfaa52
    • jchaffraix@webkit.org's avatar
      Unreviewed, rolling out my changes as it rendered the Qt bot unreliable. · 5cc9ccfc
      jchaffraix@webkit.org authored
      WebCore:
      
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
      (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
      (WebCore::DocumentThreadableLoader::loadRequest):
      
      LayoutTests:
      
      * http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Removed.
      * http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Removed.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Removed.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Removed.
      * http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Removed.
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cc9ccfc
    • jchaffraix@webkit.org's avatar
      Unreviewed. · e741bf14
      jchaffraix@webkit.org authored
      * platform/qt/Skipped: Add the 2 newly added test cases to the list
      as they involve preflight requests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e741bf14
    • jchaffraix@webkit.org's avatar
      [XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR · 9c946e8d
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=37781
      <rdar://problem/7905150>
      
      Reviewed by Alexey Proskuryakov.
      
      WebCore:
      
      Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
             http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
      
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
      credential from the request here to avoid forgetting to do so in the different code path.
      (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
      "Origin" header.
      (WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
      been removed so that we don't leak them. Also tweaked a comment to make it clear that
      the URL check has issue when credential is involved.
      
      LayoutTests:
      
      Test that doing a cross-origin request with a preflight check does
      not raise a NETWORK_ERR exception and does not send the credentials.
      
      * http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
      * http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
      * http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c946e8d
    • eric@webkit.org's avatar
      2010-04-27 Jay Civelli <jcivelli@chromium.org> · 851ec1e4
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Makes clicking a select element close its associated popup if
              it is open.
              https://bugs.webkit.org/show_bug.cgi?id=38105
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::mouseDown):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      851ec1e4
    • eric@webkit.org's avatar
      2010-04-27 Jay Civelli <jcivelli@chromium.org> · 0094033c
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [chromium] Merged the WebView public method to close suggestion popups
              into a single method to close all popups (select and suggestions).
              That ensures select popups are closed when the browser window is moved
              or resized.
              https://bugs.webkit.org/show_bug.cgi?id=37837
      
              * public/WebView.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::hidePopups):
              (WebKit::WebViewImpl::hideSuggestionsPopup):
              * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0094033c
    • weinig@apple.com's avatar
      Always build WebKit2 when building on SnowLeopard and later. · fb6885b2
      weinig@apple.com authored
      Reviewed by Stephanie Lewis.
      
      * Scripts/build-webkit:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb6885b2
    • weinig@apple.com's avatar
      Fix for https://bugs.webkit.org/show_bug.cgi?id=38238 · 6eef403f
      weinig@apple.com authored
      Allow both WebKit and WebKit2 to link to the same WebCore.framework
      
      Reviewed by Maciej Stachowiak.
      
      WebCore: 
      
      * Configurations/WebCore.xcconfig: Use -allowable_client WebKit2 to add
      WebKit2 to the list of frameworks that can link directly to WebCore. It
      is not necessary for it to be an umbrella since we don't need to reexport
      any symbols.
      
      WebKit2: 
      
      * Configurations/WebKit2.xcconfig: Remove the OTHER_LDFLAGS. We don't
      need to set WebCore as a sub_umbrella of WebKit2, since we are not
      reexporting any of its symbols.
      
      WebKitTools: 
      
      * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
      WebCore for WebKit2, it is no longer necessary.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6eef403f
    • dumi@chromium.org's avatar
      WebCore: Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases. · f5e8310e
      dumi@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=38191
      
      Reviewed by David Levin.
      
      Vacuum all databases when the number of free pages is at least 10%
      of the number of total pages. Also, add a guard against a bug that
      was fixed in SQLite only starting with version 3.6.16.
      
      * platform/sql/SQLiteDatabase.cpp:
      (WebCore::SQLiteDatabase::maximumSize):
      (WebCore::SQLiteDatabase::freeSpaceSize):
      (WebCore::SQLiteDatabase::totalSize):
      (WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
      (WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
      * platform/sql/SQLiteDatabase.h:
      (WebCore::SQLiteDatabase::):
      * platform/sql/SQLiteStatement.cpp:
      (WebCore::SQLiteStatement::prepare):
      (WebCore::SQLiteStatement::step):
      * storage/Database.cpp:
      (WebCore::Database::performOpenAndVerify):
      (WebCore::Database::incrementalVacuumIfNeeded):
      * storage/Database.h:
      * storage/SQLTransaction.cpp:
      (WebCore::SQLTransaction::postflightAndCommit):
      
      LayoutTests: Adjusting the expected amount of space used by quota-tracking.html.
      https://bugs.webkit.org/show_bug.cgi?id=38191
      
      Reviewed by David Levin.
      
      The expectations changed because of AUTO_VACUUM's overhead.
      
      * platform/chromium/test_expectations.txt:
      * storage/quota-tracking-expected.txt:
      * storage/quota-tracking.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5e8310e
    • jam@chromium.org's avatar
      2010-04-27 John Abd-El-Malek <jam@chromium.org> · f0d72f45
      jam@chromium.org authored
              Reviewed by Darin Adler.
      
              Remove unnecessary header now that Chrome is updated
              https://bugs.webkit.org/show_bug.cgi?id=38211
      
              * public/win/WebThemeEngine.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0d72f45
    • jamesr@google.com's avatar
      2010-04-27 James Robinson <jamesr@chromium.org> · 92d1cf8e
      jamesr@google.com authored
              Reviewed by David Levin.
      
              Fix a typo in chromium.py that causes NRWT to fail in --verbose
              mode in a Chromium checkout.
              https://bugs.webkit.org/show_bug.cgi?id=38234
      
              * Scripts/webkitpy/layout_tests/port/chromium.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92d1cf8e