1. 24 May, 2007 8 commits
    • thatcher's avatar
      Reviewed by Sam Weinig. · e83e7f4c
      thatcher authored
              Remove the OBJC_NEW_PROPERTIES #ifdef and only export the new @property syntax.
      
              * bindings/objc/DOMObject.h:
              * bindings/scripts/CodeGeneratorObjC.pm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e83e7f4c
    • weinig's avatar
      LayoutTests: · deaa7704
      weinig authored
              Reviewed by Anders.
      
              - update results to account for the new JSHTMLFrameSetElement
                that is being autogenerated and can now produce a constructor.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Anders.
      
              Uncomment HTMLFramesSetElement constructor now that it exists.
      
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deaa7704
    • andersca's avatar
      Try fixing the buildbot build. · 964d84c8
      andersca authored
              
              * loader/ImageDocument.cpp:
              (WebCore::ImageDocument::resizeImageToFit):
              (WebCore::ImageDocument::imageClicked):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      964d84c8
    • weinig's avatar
      Reviewed by Darin. · 622da3cf
      weinig authored
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13853
              Autogenerate the JS bindings for the HTMLFrameSetElement
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/JSHTMLFrameSetCustom.cpp: Added.
              (WebCore::JSHTMLFrameSetElement::canGetItemsForName):
              (WebCore::JSHTMLFrameSetElement::nameGetter):
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::JSHTMLElement::getOwnPropertySlot):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * html/HTMLFrameSetElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      622da3cf
    • zack's avatar
      Fixing check for incorrent font size - it should · 66430b86
      zack authored
      check fixed not normal.
      
      r=andersca
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66430b86
    • bdash's avatar
      Speculative buildbot build fix. · 25f3bcfd
      bdash authored
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25f3bcfd
    • aroben's avatar
      Made Chrome::addMessageToConsole more flexible · 377f2797
      aroben authored
      addMessageToConsole now takes two additional parameters to specify the
      message source (HTML, JS, CSS, XML) and level (error, warning, log). To
      maintain our old behavior, all current messages were given
      JSMessageSource and ErrorMessageLevel parameters. Messages matching
      these characteristics are passed up to the ChromeClient.
      
      Reviewed by Hyatt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      377f2797
    • hyatt's avatar
      Rework how HTML handles line numbering so that it is not fooled by · ec064cb5
      hyatt authored
              \r without a following \n and so that document.write doesn't lead
              to line numbering confusion.
      
              Reviewed by aroben
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::reportErrorToConsole):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::processListing):
              (WebCore::HTMLTokenizer::parseSpecial):
              (WebCore::HTMLTokenizer::parseComment):
              (WebCore::HTMLTokenizer::parseServer):
              (WebCore::HTMLTokenizer::parseProcessingInstruction):
              (WebCore::HTMLTokenizer::parseText):
              (WebCore::HTMLTokenizer::parseEntity):
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::write):
              (WebCore::HTMLTokenizer::processToken):
              (WebCore::HTMLTokenizer::setSrc):
              * html/HTMLTokenizer.h:
              (WebCore::HTMLTokenizer::lineNumberPtr):
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::addLine):
              * loader/TextDocument.cpp:
              (WebCore::TextTokenizer::write):
              * platform/SegmentedString.cpp:
              (WebCore::SegmentedString::SegmentedString):
              (WebCore::SegmentedString::operator=):
              (WebCore::SegmentedString::clear):
              * platform/SegmentedString.h:
              (WebCore::SegmentedString::SegmentedString):
              (WebCore::SegmentedString::advance):
              (WebCore::SegmentedString::escaped):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec064cb5
  2. 23 May, 2007 21 commits
    • hyatt's avatar
      Make the delete/InsertRows/Cells methods as well as the rowIndex method · 4e410bd7
      hyatt authored
              able to work properly even when whitespace or comment nodes are present.
      
              Reviewed by aroben
      
              fast/table/rowindex-comment-nodes.html
      
              * html/HTMLTableRowElement.cpp:
              (WebCore::HTMLTableRowElement::rowIndex):
              (WebCore::HTMLTableRowElement::insertCell):
              (WebCore::HTMLTableRowElement::deleteCell):
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::insertRow):
              (WebCore::HTMLTableSectionElement::deleteRow):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e410bd7
    • hyatt's avatar
      <optgroup> should allow <script> and text nodes inside it, just like · a9490fe9
      hyatt authored
              <select> does.
      
              Reviewed by aroben
      
              fast/forms/stuff-on-my-optgroup.html
      
              * html/HTMLOptGroupElement.cpp:
              (WebCore::HTMLOptGroupElement::checkDTD):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::checkDTD):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9490fe9
    • hyatt's avatar
      Framesets should allow whitespace text nodes as children. · 4f25e175
      hyatt authored
              Reviewed by aroben
      
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::checkDTD):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f25e175
    • bdash's avatar
      Fix the Qt build after r21685. · 131a68c9
      bdash authored
              * platform/qt/CursorQt.cpp:
              (WebCore::notAllowedCursor):
              (WebCore::zoomInCursor):
              (WebCore::zoomOutCursor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      131a68c9
    • bdash's avatar
      Reviewed by Adam. · c16ac6a4
      bdash authored
              Fix the gdk build following changes in r21685.
      
              * platform/gdk/CursorGdk.cpp:
              (WebCore::zoomInCursor):
              (WebCore::zoomOutCursor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c16ac6a4
    • hyatt's avatar
      Fix for <rdar://problem/5222611> REGRESSION: Paint ordering problems at · fe9c69b1
      hyatt authored
              http://buymeasoda.com/dev/issues/image_onload/image_onload.html
      
              Clamp z-index so that values that exceed maxint (or that are below minint)
              are clamped to those values.
      
              Reviewed by darin
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe9c69b1
    • ddkilzer's avatar
      LayoutTests: · 27a28d44
      ddkilzer authored
              Reviewed by David Hyatt.
      
              - tests for http://bugs.webkit.org/show_bug.cgi?id=13563
                REGRESSION: Crash loading message in Yahoo! Mail
      
              * fast/css/stale-style-selector-crash-1-expected.txt: Added.
              * fast/css/stale-style-selector-crash-1.html: Added.
              * fast/css/stale-style-selector-crash-2-expected.txt: Added.
              * fast/css/stale-style-selector-crash-2.html: Added.
      
      WebCore:
      
              Reviewed by David Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13563
                REGRESSION: Crash loading message in Yahoo! Mail
      
              Tests: fast/css/stale-style-selector-crash-1.html
                     fast/css/stale-style-selector-crash-2.html
      
              * dom/Document.cpp:
              (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector
              flag to 'false'.
              (WebCore::Document::updateStyleSelector): Do not bail out if we have ever
              calculated a non-trivial style selector, even if at the moment we are
              pending style sheets. We could have calculated a non-trivial selector
              already either because at some point there were no pending style sheets
              (so the currently pending ones were added dynamically) or because we were
              forced to do a layout ignoring pending style sheets. Either way, once
              there is a style selector, we need to keep it up to date, otherwise we can
              crash under recalcStyle() during updateRendering() or simply not recalculate
              style correctly for dynamic changes.
              (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector
              to 'true' when creating a new style selector.
              * dom/Document.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27a28d44
    • andersca's avatar
      Reviewed by Adam. · 9a44838d
      andersca authored
              <rdar://problem/5224749> Show a zoom/unzoom cursor for resizable image documents
              
              * WebCore.xcodeproj/project.pbxproj:
              Install the zoom cursors.
              
              * loader/ImageDocument.cpp:
              (WebCore::ImageDocument::resizeImageToFit):
              Set the cursor to the zoom in cursor.
              
              (WebCore::ImageDocument::restoreImageSize):
              If the image fits, reset the cursor. Otherwise, set it to the zoom in cursor.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a44838d
    • darin's avatar
      LayoutTests: · 258af4a1
      darin authored
              Reviewed by Hyatt.
      
              - updated the many tests with an extra newline or two at the end
                because of the bug where plain-text serialization will consider
                nodes that are not rendered
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix problems where unrendered nodes were affecting on plain text serialization
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for
              nodes without renderers.
              (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding
              if this is the last node in the document.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      258af4a1
    • andersca's avatar
      Reviewed by Geoff. · 542a4a0d
      andersca authored
              <rdar://problem/3663808> Resize large images to fit in the browser window
              
              * WebCore.exp:
              Add new settings method.
              
              * loader/ImageDocument.cpp:
              (WebCore::ImageEventListener::ImageEventListener):
              New class that handles resize events and click events and forwards them to the image document.
              
              (WebCore::ImageTokenizer::ImageTokenizer):
              (WebCore::ImageTokenizer::writeRawData):
              (WebCore::ImageTokenizer::finish):
              (WebCore::ImageDocument::ImageDocument):
              (WebCore::ImageDocument::createDocumentStructure):
              (WebCore::ImageDocument::cachedImage):
              Let the ImageDocument class keep track of its document structure.
              
              (WebCore::ImageDocument::scale):
              Returns the scale that should be used when resizing the image.
              
              (WebCore::ImageDocument::resizeImage):
              Update the image size.
              
              (WebCore::ImageDocument::imageClicked):
              Toggle between resized and not resized. When restoring the size, scroll the image so that the area under
              the mouse stays the same.
              
              (WebCore::ImageDocument::imageChanged):
              When the image size is known, resize the image if needed.
              
              (WebCore::ImageDocument::restoreImageSize):
              Restore the image size.
              
              (WebCore::ImageDocument::imageNeedsResizing):
              Return whether the image is too big for its window or not.
              
              (WebCore::ImageDocument::windowSizeChanged):
              Called when the window's size changes. Determine if the window fits or not and resize it if it doesn't fit.
              
              (WebCore::ImageEventListener::handleEvent):
              Forward events to the image document.
              
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setEnableAutomaticImageResizing):
              * page/Settings.h:
              (WebCore::Settings::enableAutomaticImageResizing):
              Add new setting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      542a4a0d
    • andersca's avatar
      Reviewed by Darin. · 1500e83b
      andersca authored
              Add -webkit-zoom-in and -webkit-zoom-out cursors.
              
              * Resources/zoomInCursor.png: Added.
              * Resources/zoomOutCursor.png: Added.
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSValueKeywords.in:
              * page/EventHandler.cpp:
              (WebCore::selectCursor):
              * platform/Cursor.h:
              * platform/mac/CursorMac.mm:
              (WebCore::zoomInCursor):
              (WebCore::zoomOutCursor):
              * rendering/RenderStyle.h:
              (WebCore::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1500e83b
    • weinig's avatar
      Reviewed by Darin. · 6f17861a
      weinig authored
              Part one of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              - Just the HTMLElement part.
      
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLElement::getValueProperty):
              (KJS::JSHTMLElement::putValueProperty):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * html/HTMLElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f17861a
    • kmccullo's avatar
      LayoutTests: · ef9bbdef
      kmccullo authored
              Reviewed by Darin.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of 
              the rest of HTMLElement
      
              - Corrects prototype chain for JSHTMLDocument and adds test
                for HTMLFormElement.
      
              * fast/dom/prototype-chain-expected.txt:
              * fast/dom/prototype-chain.html:
      
      WebCore:
      
              Reviewed by Darin.
      
              - rdar://problem/5183523
              - We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::load):
              (WebCore::FrameLoader::open):
              * platform/PlatformString.h:
              (WebCore::debugPrintString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef9bbdef
    • weinig's avatar
      LayoutTests: · 661a37fc
      weinig authored
              Reviewed by Darin.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of 
              the rest of HTMLElement
      
              - Corrects prototype chain for JSHTMLDocument and adds test
                for HTMLFormElement.
      
              * fast/dom/prototype-chain-expected.txt:
              * fast/dom/prototype-chain.html:
      
      WebCore:
      
              Reviewed by Darin.
      
              Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              - Just the HTMLDocument part.
      
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLDocumentCustom.cpp: Added.
              (WebCore::JSHTMLDocument::canGetItemsForName):
              (WebCore::JSHTMLDocument::nameGetter):
              (WebCore::JSHTMLDocument::all):
              (WebCore::JSHTMLDocument::setAll):
              (WebCore::JSHTMLDocument::location):
              (WebCore::JSHTMLDocument::setLocation):
              (WebCore::JSHTMLDocument::open):
              (WebCore::writeHelper):
              (WebCore::JSHTMLDocument::write):
              (WebCore::JSHTMLDocument::writeln):
              (WebCore::JSHTMLDocument::clear):
              * bindings/js/kjs_dom.cpp:
              (KJS::toJS):
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_html.cpp:
              * bindings/js/kjs_html.h:
              * bindings/objc/DOMPrivate.h:
              * bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property
              for Document.all and fix HasOverridingNameGetter to allow correct
              prototype chain
              * dom/Document.cpp:
              (WebCore::Document::plugins): adds alias to embeds() for bindings
              * dom/Document.h:
              * html/HTMLDocument.cpp:
              (WebCore::HTMLDocument::width):
              (WebCore::HTMLDocument::height):
              (WebCore::HTMLDocument::dir):
              (WebCore::HTMLDocument::setDir):
              (WebCore::HTMLDocument::designMode):
              (WebCore::HTMLDocument::setDesignMode):
              (WebCore::HTMLDocument::bgColor):
              (WebCore::HTMLDocument::setBgColor):
              (WebCore::HTMLDocument::fgColor):
              (WebCore::HTMLDocument::setFgColor):
              (WebCore::HTMLDocument::alinkColor):
              (WebCore::HTMLDocument::setAlinkColor):
              (WebCore::HTMLDocument::linkColor):
              (WebCore::HTMLDocument::setLinkColor):
              (WebCore::HTMLDocument::vlinkColor):
              (WebCore::HTMLDocument::setVlinkColor):
              (WebCore::HTMLDocument::captureEvents):
              (WebCore::HTMLDocument::releaseEvents):
              * html/HTMLDocument.h:
              * html/HTMLDocument.idl:
      
      WebKit:
      
              Reviewed by Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              * MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      661a37fc
    • hyatt's avatar
      Fix for <rdar://problem/5221838> REGRESSION (r21581): no content in idisk · 10059be9
      hyatt authored
              window at mac.com.
      
              Back out the change to make self-closed <script/> into a Dashboard quirk
              only.
      
              Reviewed by aroben
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseTag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10059be9
    • pyeh's avatar
      <rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns... · aed6bd6a
      pyeh authored
      <rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns kAXErrorNoValue for attachment range
              
              Floating objects, such as aligned images, are not included as part of any line.  So when the given 
              text marker is on the floating object, the returned line edge cannot be found and asserts are fired.
              In addition, this paints an inconsistent text layout (in the accessibility sense) of where the floating 
              object resides.  Character/word methods report floating object at the beginning of the text line(s).  Yet
              line methods never present floating objects anywhere.  
              To fix this, the ax line methods will now do more checking to ensure floating object nodes are included
              when determining the line range/position. That way, assistive apps won't get stuck using the line methods 
              to read line-by-line
      
              * bridge/mac/WebCoreAXObject.mm:
              (updateAXLineStartForVisiblePosition):
              Added a helper method to adjust line start position to account for floating objects
              (-[WebCoreAXObject doAXLeftLineTextMarkerRangeForTextMarker:]):
              (-[WebCoreAXObject doAXRightLineTextMarkerRangeForTextMarker:]):
              (-[WebCoreAXObject doAXNextLineEndTextMarkerForTextMarker:]):
              (-[WebCoreAXObject doAXPreviousLineStartTextMarkerForTextMarker:]):
              Fixed up line routines to include floating object nodes in line position calculation.
              startOfLine/endOLine may return null for position next to a floating position.  So now there's extra checks to prevent
              returning null line position/ranges back to AX.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aed6bd6a
    • hausmann's avatar
      Added support for per-QWebPage network interface handlers, clean up the · 5482b095
      hausmann authored
      http and file loading and fixed a bug in the HTTP redirect handling.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5482b095
    • rwlbuis's avatar
      Reviewed by Dave Hyatt. · a215bbc6
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=13174
              line-height in font shorthand does not override a previously stated line-height property
      
              Make sure line-height is calculated against definite font-size and
              uses the last set line-height, ie. directly or through font shorthand.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a215bbc6
    • lars's avatar
      Reviewed by Zack and Valgrind · 58eae66e
      lars authored
              Initialize variable.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58eae66e
    • rwlbuis's avatar
      Reviewed by Darin. · abbef99e
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=13784
              REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas
      
              Fix crash by testing for zero stops, and returning transparent black
              in this case.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abbef99e
    • rwlbuis's avatar
      Reviewed by Darin. · 0c6da947
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=13801
              Crash when loading nonexisting symbol
      
              Check for referenced element and when not found just return.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c6da947
  3. 22 May, 2007 11 commits
    • weinig's avatar
      Rubber stamped by Adam. · a0c15a43
      weinig authored
              Fix license.
      
              * bindings/js/JSHTMLAnchorElementCustom.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0c15a43
    • weinig's avatar
      LayoutTests: · 40d22abd
      weinig authored
              Reviewed by Adam.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              * fast/dom/wrapper-classes-expected.txt:
              * fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a 
              DOMHTMLMarqueeElement
      
      WebCore:
      
              Reviewed by Adam.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              - Also adds missing DOMHTMLFramePrivate.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              (WebCore::createElementClassMap):
              * bindings/objc/DOMHTML.h:
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMPrivate.h:
              * bindings/objc/PublicDOMInterfaces.h:
      
      WebKit:
      
              Reviewed by Adam.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              - Also adds missing DOMHTMLFramePrivate.
      
              * MigrateHeaders.make:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40d22abd
    • justing's avatar
      LayoutTests: · bac741c4
      justing authored
              Reviewed by darin
              
              http://bugs.webkit.org/show_bug.cgi?id=13804
              REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)
      
              * editing/selection/13804-expected.checksum: Added.
              * editing/selection/13804-expected.png: Added.
              * editing/selection/13804-expected.txt: Added.
              * editing/selection/13804.html: Added.
              These were missing:
              * editing/selection/5076323-1-expected.png: Added.
              * editing/selection/5076323-2-expected.png: Added.
              * editing/selection/5076323-3-expected.png: Added.
      
      WebCore:
      
              Reviewed by darin, who found the fix independently.
      
              http://bugs.webkit.org/show_bug.cgi?id=13804
              REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)
              
              r21611 exposed a bug in the way removeMarkers computes
              the end of the range to remove markers from.  It also
              introduced a bug: removeMarkers expects a startOffset
              and a length, not a startOffset and an endOffset (added 
              a layout test).
      
              * dom/Document.cpp:
              (WebCore::Document::removeMarkers): The other removeMarkers
              expects a startOffset and a length, not a startOffset and
              an endOffset.
              (WebCore::Document::removeMarkers): Fixed the endOffset
              from length and startOffset calculation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bac741c4
    • hyatt's avatar
      Fix for bug 13802, background colors can't be reset to default · 0beef8a8
      hyatt authored
              color.  Fix the value cssText method to do the right thing for background
              and background-position values.
      
              Reviewed by beth
      
              fast/dom/background-shorthand-csstext.html
      
              * css/CSSInitialValue.h:
              (WebCore::CSSInitialValue:::m_implicit):
              (WebCore::CSSInitialValue::isImplicitInitialValue):
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
              (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
              * css/CSSMutableStyleDeclaration.h:
              * css/CSSValue.h:
              (WebCore::CSSValue::isImplicitInitialValue):
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseBackgroundShorthand):
              (WebCore::CSSParser::parseShorthand):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0beef8a8
    • darin's avatar
      LayoutTests: · cc06b695
      darin authored
              Reviewed by Geoff.
      
              - test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
      
              * fast/dom/iframe-document.html: Updated test to expect no document property.
              * fast/dom/iframe-document-expected.txt: Updated.
      
              * fast/forms/focus2.html: Changed test to use ownerDocument instead of document.
      
      WebCore:
      
              Reviewed by Geoff.
      
              - fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
      
              The code on ebay was looking for the "document" property on a iframe.
              We changed that to be the ownerDocument rather than the contentDocument,
              which was not what ebay was expecting. The best fix seems to be removing
              the document property altogether.
      
              Test: fast/dom/iframe-document.html
      
              * bindings/js/kjs_html.h: Remove ElementDocument.
              * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.
      
      WebKit:
      
              Reviewed by Geoff.
      
              * WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard
              document property.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc06b695
    • adele's avatar
      Reviewed by Darin. · e1787a6a
      adele authored
              A little cleanup from my last checkin.
      
              * page/Chrome.h: Formatting change.
              * page/mac/ChromeMac.mm: Fixed copyright.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1787a6a
    • adele's avatar
      LayoutTests: · 82c11d19
      adele authored
              Reviewed by Darin.
      
              Test for http://bugs.webkit.org/show_bug.cgi?id=13796
              Crash in [NSInputContext currentInputContext] when you click on this map
      
              * fast/frames/frame-display-none-focus-expected.txt: Added.
              * fast/frames/frame-display-none-focus.html: Added.
              * fast/frames/resources/iframe-focus.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
              Crash in [NSInputContext currentInputContext] when you click on this map
      
              This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
      
              Test: fast/frames/frame-display-none-focus.html
      
              * WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
              * page/Chrome.h:
              * page/mac/ChromeMac.mm: Added.
              (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
              * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
              * platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82c11d19
    • justing's avatar
      LayoutTests: · 384cf314
      justing authored
              Reviewed by darin
              
              <rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters
      
              Moved from unsupported-content because we've supported editing lists
              for a while now:
              * editing/deleting/4875189-expected.checksum: Added.
              * editing/deleting/4875189-expected.png: Added.
              * editing/deleting/4875189-expected.txt: Added.
              * editing/deleting/4875189.html: Added.
              * editing/unsupported-content/list-delete-002-expected.checksum: Removed.
              * editing/unsupported-content/list-delete-002-expected.png: Removed.
              * editing/unsupported-content/list-delete-002-expected.txt: Removed.
              * editing/unsupported-content/list-delete-002.html: Removed.
              
              Reflects new behavior:
              * editing/deleting/delete-select-all-003-expected.checksum:
              * editing/deleting/delete-select-all-003-expected.png:
              * editing/deleting/delete-select-all-003-expected.txt:
              
              Ditto and also removed a FIXME:
              * editing/deleting/list-item-1-expected.checksum:
              * editing/deleting/list-item-1-expected.png:
              * editing/deleting/list-item-1-expected.txt:
              * editing/deleting/list-item-1.html:
      
      WebCore:
      
              Reviewed by darin
              
              <rdar://problem/4875189> 
              List is deleted when replacing contents with Chinese/Japanese characters
      
              * editing/htmlediting.cpp:
              (WebCore::isSpecialElement): Lists are no longer special.
              They can be removed by removing their content and then 
              then hitting delete inside of the empty list item that's 
              left over. Even when that list item is the first thing 
              in the editable region.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      384cf314
    • darin's avatar
      Reviewed by Tim Hatcher. · da7cd15c
      darin authored
              - fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories"
                tab makes page content disappear
      
              The contentWindow property was doing a cross-frame security check, but it shouldn't.
              Window objects are responsible for protecting themselves from cross-frame activity.
              Because contentWindow returned undefined, we then ended up setting visibility on the
              body of the main frame to "hidden".
      
              No layout test yet. When we make cross-domain tests, we should include this one.
      
              * html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
              * html/HTMLIFrameElement.idl: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da7cd15c
    • justing's avatar
      LayoutTests: · 00b7e557
      justing authored
              Reviewed by oliver
      
              <rdar://problem/5213963> 
              REGRESSION(r21467): Active selection remains in text field after clicking on a button
      
              Demonstrates bug:
              * editing/selection/5213963-expected.checksum: Added.
              * editing/selection/5213963-expected.png: Added.
              * editing/selection/5213963-expected.txt: Added.
              * editing/selection/5213963.html: Added.
              We now clear the selection on mouse down (but not before
              the mousedown event is fired):
              * fast/forms/focus-selection-input-expected.txt:
              * fast/forms/focus-selection-textarea-expected.txt:
      
      WebCore:
      
              Reviewed by oliver
      
              <rdar://problem/5213963>
              REGRESSION(r21467): Active selection remains in text field after clicking on a button
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEvent): Call
              FocusController::setFocusedNode, because Document::setFocusedNode
              no longer clears the selection.
              Begin passing the new focused frame to 
              FocusController::setFocusedNode, because when the 
              new focus node is null, the selection should only be 
              cleared if the focused frame isn't changing.
              (WebCore::Element::focus): Begin passing the new focused
              frame.
              (WebCore::Element::blur): Ditto.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::focus): Ditto.
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::focus): Ditto.
              * page/Frame.cpp:
              (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
              * page/FocusController.cpp:
              (WebCore::clearSelectionIfNeeded): Take in the new
              focused frame.  If it's not changing, don't clear the
              selection.
              (WebCore::FocusController::setFocusedNode): Take
              in the new focused frame.
              * page/FocusController.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00b7e557
    • zack's avatar
      Path implementing more Cliboard from Marius Bugge Monsen. · 329e627d
      zack authored
      Adding implementations of some of the missing methods.
      r=me
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      329e627d