1. 08 Apr, 2011 40 commits
    • jberlin@webkit.org's avatar
      Windows build warning fix. · e831e6af
      jberlin@webkit.org authored
      * WebCore.vcproj/WebCore.vcproj:
      Since ShadowRoot.cpp is included in the DOMAllInOne.cpp file, it should be excluded from
      the build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e831e6af
    • yi.4.shen@nokia.com's avatar
      2011-04-08 Yi Shen <yi.4.shen@nokia.com> · e80e3dbe
      yi.4.shen@nokia.com authored
              Reviewed by Antonio Gomes.
      
              [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
              https://bugs.webkit.org/show_bug.cgi?id=57472
      
              Unskips the fast/events/onsearch-enter.html test.
      
              * platform/qt/Skipped:
      2011-04-08  Yi Shen  <yi.4.shen@nokia.com>
      
              Reviewed by Antonio Gomes.
      
              [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
              https://bugs.webkit.org/show_bug.cgi?id=57472
      
              Avoid to insert new line for both keydown event & keypress event.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::handleInputMethodKeydown):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e80e3dbe
    • podivilov@chromium.org's avatar
      2011-04-07 Pavel Podivilov <podivilov@chromium.org> · 13b82ef5
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: update breakpoints according to source frame decorations after live edit.
              https://bugs.webkit.org/show_bug.cgi?id=58029
      
              * inspector/debugger/live-edit-expected.txt:
              * inspector/debugger/live-edit.html:
      2011-04-07  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: update breakpoints according to source frame decorations after live edit.
              https://bugs.webkit.org/show_bug.cgi?id=58029
      
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent.didEditScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype._updateResourceContent):
              * inspector/front-end/SourceFile.js:
              (WebInspector.SourceFile.prototype.set content):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
              (WebInspector.SourceFrame.prototype._handleSave):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13b82ef5
    • podivilov@chromium.org's avatar
      2011-04-08 Pavel Podivilov <podivilov@chromium.org> · bb843073
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: fix scripts concatenation in scripts panel.
              https://bugs.webkit.org/show_bug.cgi?id=58138
      
              When there is just one script starting at 0:0 it should not be surrounded by <script> framing.
      
              * inspector/front-end/SourceFile.js:
              (WebInspector.SourceFile.prototype._loadResourceContent):
              (WebInspector.SourceFile.prototype._loadAndConcatenateScriptsContent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb843073
    • steveblock@google.com's avatar
      2011-04-08 Steve Block <steveblock@google.com> · 63d1254e
      steveblock@google.com authored
              Unreviewed build fix.
      
              Media Stream API: add the getUserMedia method and the Javascript bindings
              https://bugs.webkit.org/show_bug.cgi?id=56586
      
              Add new tests to skipped lists for platforms where the feature is not
              enabled.
      
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63d1254e
    • yurys@chromium.org's avatar
      2011-04-08 Yury Semikhatsky <yurys@chromium.org> · 76b4e593
      yurys@chromium.org authored
              Unreviewed. Update Chromium test expectations to match results after rolling
              v8 revision that reports stack overflow exception to the console.
      
              * platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
              * platform/chromium-win/fast/js/recursion-limit-equal-expected.txt: Removed.
              * platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt.
              * platform/chromium/fast/js/recursion-limit-equal-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/js/recursion-limit-equal-expected.txt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76b4e593
    • pfeldman@chromium.org's avatar
      2011-04-08 Pavel Feldman <pfeldman@chromium.org> · 99d6041b
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements.
              https://bugs.webkit.org/show_bug.cgi?id=58118
      
              This change reuses location for call frames in the protocol + structures script
              location <-> source lines interaction better. When we need UI columns, we will add
              them, but we should distinguish between script and UI terms on the type level, not naming.
      
              * English.lproj/localizedStrings.js:
              * bindings/v8/DebuggerScript.js:
              * inspector/InjectedScriptSource.js:
              * inspector/Inspector.json:
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine):
              (WebInspector.CallStackSidebarPane.prototype.update):
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage):
              (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
              (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
              (WebInspector.PresenationCallFrame):
              (WebInspector.PresenationCallFrame.prototype.sourceLine.didRequestSourceMapping):
              (WebInspector.PresenationCallFrame.prototype.sourceLine):
              * inspector/front-end/ScriptFormatter.js:
              (WebInspector.ScriptFormatter.locationToPosition):
              (WebInspector.ScriptFormatter.lineToPosition):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
              (WebInspector.ScriptsPanel.prototype._debuggerPaused):
              (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
              (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
              (WebInspector.ScriptsPanel.prototype._callFrameSelected):
              * inspector/front-end/SourceFile.js:
              (WebInspector.SourceMapping.prototype.scriptLocationToSourceLine):
              (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation):
              (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
              (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99d6041b
    • podivilov@chromium.org's avatar
      2011-04-08 Pavel Podivilov <podivilov@chromium.org> · 6782b967
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: distinguish breakpoints set on de-obfuscated sources from breakponts set on original sources.
              https://bugs.webkit.org/show_bug.cgi?id=58133
      
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
              (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
              (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
              (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
              (WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
              (WebInspector.DebuggerPresentationModel.prototype._reset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6782b967
    • podivilov@chromium.org's avatar
      2011-04-07 Pavel Podivilov <podivilov@chromium.org> · 9a8b7d06
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: make SourceFrame TextViewer's delegate for editing operations.
              https://bugs.webkit.org/show_bug.cgi?id=58026
      
              This is the first step of decoupling TextViewer from SourceFrame.
      
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype.show):
              (WebInspector.SourceFrame.prototype.hide):
              (WebInspector.SourceFrame.prototype._ensureContentLoaded):
              (WebInspector.SourceFrame.prototype.contentEditable):
              (WebInspector.SourceFrame.prototype.startEditing):
              (WebInspector.SourceFrame.prototype.endEditing):
              (WebInspector.SourceFrame.prototype._createTextViewer):
              (WebInspector.SourceFrame.prototype._handleSave):
              (WebInspector.SourceFrame.prototype._handleRevertEditing):
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
              (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
              (WebInspector.TextViewer.prototype._syncDecorationsForLine):
              (WebInspector.TextViewer.prototype._doubleClick):
              (WebInspector.TextViewerDelegate):
              (WebInspector.TextViewerDelegate.prototype.contentEditable):
              (WebInspector.TextViewerDelegate.prototype.startEditing):
              (WebInspector.TextViewerDelegate.prototype.endEditing):
              (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
              (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
              * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a8b7d06
    • steveblock@google.com's avatar
      2011-04-08 Leandro Gracia Gil <leandrogracia@chromium.org> · fab8862c
      steveblock@google.com authored
              Reviewed by Steve Block.
      
              Media Stream API: add the getUserMedia method and the Javascript bindings.
              https://bugs.webkit.org/show_bug.cgi?id=56586
      
              Test the Javascript behaviour of the getUserMedia method with different types of arguments.
              Current specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication
      
              * fast/dom/MediaStream/argument-types-expected.txt: Added.
              * fast/dom/MediaStream/argument-types.html: Added.
              * fast/dom/MediaStream/enabled-expected.txt: Added.
              * fast/dom/MediaStream/enabled.html: Added.
              * fast/dom/MediaStream/no-interface-object-expected.txt: Added.
              * fast/dom/MediaStream/no-interface-object.html: Added.
              * fast/dom/MediaStream/script-tests/argument-types.js: Added.
              (shouldNotThrow):
              (test):
              (emptyFunction):
              ():
              (ObjectThrowingException.prototype.valueOf):
              (ObjectThrowingException.prototype.toString):
              * fast/dom/MediaStream/script-tests/enabled.js: Added.
              (hasGetUserMediaProperty):
              * fast/dom/MediaStream/script-tests/no-interface-object.js: Added.
              (test):
      2011-04-08  Leandro Gracia Gil  <leandrogracia@chromium.org>
      
              Reviewed by Steve Block.
      
              Media Stream API: add the getUserMedia method and the Javascript bindings.
              https://bugs.webkit.org/show_bug.cgi?id=56586
      
              Add the getUserMedia method to the navigator and its new Javascript types.
              Current specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#video-conferencing-and-peer-to-peer-communication
      
              Tests: fast/dom/MediaStream/argument-types.html
                     fast/dom/MediaStream/enabled.html
                     fast/dom/MediaStream/no-interface-object.html
      
              * Android.derived.jscbindings.mk:
              * Android.derived.v8bindings.mk:
              * Android.v8bindings.mk:
              * CMakeLists.txt:
              * CodeGenerators.pri:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.list.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSNavigatorCustom.cpp:
              (WebCore::JSNavigator::webkitGetUserMedia):
              * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
              (WebCore::V8Navigator::webkitGetUserMediaCallback):
              * page/Navigator.cpp:
              (WebCore::Navigator::webkitGetUserMedia):
              * page/Navigator.h:
              * page/Navigator.idl:
              * page/NavigatorUserMediaError.h: Added.
              (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
              (WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
              (WebCore::NavigatorUserMediaError::code):
              * page/NavigatorUserMediaError.idl: Added.
              * page/NavigatorUserMediaErrorCallback.h: Added.
              (WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):
              * page/NavigatorUserMediaErrorCallback.idl: Added.
              * page/NavigatorUserMediaSuccessCallback.h: Added.
              (WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):
              * page/NavigatorUserMediaSuccessCallback.idl: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fab8862c
    • mnaganov@chromium.org's avatar
      2011-04-08 Mikhail Naganov <mnaganov@chromium.org> · 25c17aa9
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
              https://bugs.webkit.org/show_bug.cgi?id=58010
              https://bugs.webkit.org/show_bug.cgi?id=58011
      
              Added tests for "Containment" view. Minor refactorings, bugs fixed.
              Split one large tests into smaller ones to avoid timing out in debug mode.
      
              Tests: inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html
                     inspector/profiler/detailed-heapshots-containment-show-all.html
                     inspector/profiler/detailed-heapshots-containment-show-next.html
                     inspector/profiler/detailed-heapshots-containment-sorting.html
                     inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html
                     inspector/profiler/detailed-heapshots-summary-show-all.html
                     inspector/profiler/detailed-heapshots-summary-show-next.html
                     inspector/profiler/detailed-heapshots-summary-sorting.html
      
              * inspector/front-end/DetailedHeapshotGridNodes.js:
              (WebInspector.HeapSnapshotGridNode):
              (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
              (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
              (WebInspector.HeapSnapshotGridNode.prototype.sort):
              (WebInspector.HeapSnapshotGenericObjectNode):
              (WebInspector.HeapSnapshotObjectNode):
              (WebInspector.HeapSnapshotInstanceNode):
              (WebInspector.HeapSnapshotConstructorNode):
              (WebInspector.HeapSnapshotDiffNode):
              (WebInspector.HeapSnapshotDominatorObjectNode):
              * inspector/front-end/DetailedHeapshotView.js:
              (WebInspector.HeapSnapshotContainmentDataGrid):
              (WebInspector.HeapSnapshotDominatorsDataGrid):
      
      2011-04-08  Mikhail Naganov  <mnaganov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
              https://bugs.webkit.org/show_bug.cgi?id=58010
              https://bugs.webkit.org/show_bug.cgi?id=58011
      
              Added tests for "Containment" view. Minor refactorings, bugs fixed.
              Split one large tests into smaller ones to avoid timing out in debug mode.
      
              * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html: Added.
              * inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-containment-show-all.html: Added.
              * inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-containment-show-next.html: Added.
              * inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-containment-sorting.html: Added.
              * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html: Added.
              * inspector/profiler/detailed-heapshots-summary-expected.txt: Removed.
              * inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-summary-show-all.html: Added.
              * inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-summary-show-next.html: Added.
              * inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-summary-sorting.html: Added.
              * inspector/profiler/detailed-heapshots-summary.html: Removed.
              * inspector/profiler/detailed-heapshots-test.js:
              (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
              (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest):
              (initialize_DetailedHeapshotTest.):
              (initialize_DetailedHeapshotTest):
              * platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Copied from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
              * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
              * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25c17aa9
    • podivilov@chromium.org's avatar
      2011-04-08 Andrey Adaikin <aandrey@google.com> · 9fdebe06
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Bugs in some corner cases in the text editor
              https://bugs.webkit.org/show_bug.cgi?id=58025
      
              This solves the following bugs:
              1) The very last _empty_ line would not be deleted if you hit a Backspace on it, or the selection text to be deleted is extended to the very bottom of the editor.
              2) An odd corner case: delete all source code from the editor, hit backspace on the only empty line, then add a character. In this case the browser will insert a TEXT node instead of a DIV node for a lineRow.
      
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
              (WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
              (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
              (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
              (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fdebe06
    • podivilov@chromium.org's avatar
      2011-04-07 Pavel Podivilov <podivilov@chromium.org> · 68c7ef15
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: add test for script formatter worker.
              https://bugs.webkit.org/show_bug.cgi?id=57447
      
              * inspector/debugger/script-formatter-expected.txt: Added.
              * inspector/debugger/script-formatter.html: Added.
              * platform/chromium/test_expectations.txt:
      2011-04-07  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: add test for script formatter worker.
              https://bugs.webkit.org/show_bug.cgi?id=57447
      
              Test: inspector/debugger/script-formatter.html
      
              * GNUmakefile.am:
              * WebCore.xcodeproj/project.pbxproj:
              * gyp/streamline-inspector-source.sh:
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype._addScript):
              (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
              (WebInspector.DebuggerPresentationModel.prototype._formatter):
              * inspector/front-end/ScriptFormatterWorker.js:
      2011-04-07  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: add test for script formatter worker.
              https://bugs.webkit.org/show_bug.cgi?id=57447
      
              * WebKit.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68c7ef15
    • tkent@chromium.org's avatar
      2011-04-08 Kent Tamura <tkent@chromium.org> · 051d41fb
      tkent@chromium.org authored
              [Chromium] Note some flaky tests.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      051d41fb
    • tkent@chromium.org's avatar
      2011-04-08 Kent Tamura <tkent@chromium.org> · 2f7f1e85
      tkent@chromium.org authored
              [Chromium] The second attempt of fixing for Windows (dbg)(shared) build.
      
              * WebKit.gyp: webkit should not depend on webkit_support.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f7f1e85
    • carlosgc@webkit.org's avatar
      2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com> · f8c95ba9
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Do not destroy WorkQueue event sources unless they have been cancelled
              https://bugs.webkit.org/show_bug.cgi?id=57611
      
              * Platform/WorkQueue.h:
              * Platform/gtk/WorkQueueGtk.cpp:
              (WorkQueue::EventSource::EventSource): Remove unused member
              m_dispatchSource.
              (WorkQueue::EventSource::executeEventSource): Make it return void
              instead of boolean since we are always ignoring the return value.
              (WorkQueue::EventSource::performWork): Return FALSE from the
              callback only when the source has been cancelled (condition = 0)
              to make sure it's destroyed when the even source handler is
              unregistered.
              (WorkQueue::registerEventSourceHandler): Use GRefPtr for the
              source, to avoid leaking it.
              (WorkQueue::scheduleWorkOnSource): Receive the source callback as
              parameter so that it can be used by scheduleWorkOnTermination() too.
              (WorkQueue::scheduleWork):
              (WorkQueue::scheduleWorkAfterDelay):
              (WorkQueue::scheduleWorkOnTermination): Use
              scheduleWorkOnSource().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8c95ba9
    • carlosgc@webkit.org's avatar
      2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com> · 14f0499e
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Close connection when web process finishes
              https://bugs.webkit.org/show_bug.cgi?id=57540
      
              * Platform/CoreIPC/Connection.h:
              * Platform/CoreIPC/unix/ConnectionUnix.cpp:
              * Platform/PlatformProcessIdentifier.h: Use GPid as process
              identifier.
              * Platform/WorkQueue.h:
              * Platform/gtk/WorkQueueGtk.cpp:
              (WorkQueue::EventSource::EventSource): Add cancellable parameter.
              (WorkQueue::EventSource::cancel): New method to cancel the source.
              (WorkQueue::EventSource::performWorkOnTermination): New method to
              execute a work item called when child process has finished.
              (WorkQueue::registerEventSourceHandler): Create a GCancellable for
              the socket source.
              (WorkQueue::unregisterEventSourceHandler): Cancel the source
              instead of destroying it, this will cause the source to trigger
              with condition = 0, which makes the callback return FALSE and the
              source is destroyed.
              (WorkQueue::scheduleWorkOnSource): Pass NULL as cancellable for
              idle and timeout sources.
              (WorkQueue::scheduleWorkOnTermination): Create a child watch
              source to monitor the child process.
              * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
              (WebKit::ProcessLauncher::launchProcess): Use GPid instead of int
              as process identifier.
              * UIProcess/WebProcessProxy.cpp:
              (WebKit::WebProcessProxy::didFinishLaunching): Call
              WorkQueue::scheduleWorkOnTermination() for GTK platform too when
              web process has been launched.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14f0499e
    • caseq@chromium.org's avatar
      2011-04-08 Andrey Kosyakov <caseq@chromium.org> · 91206bc4
      caseq@chromium.org authored
              Unreviewed. Adjusted test expectations following r83275.
      
              * http/tests/inspector/resource-har-conversion-expected.txt:
              * http/tests/inspector/resource-parameters-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91206bc4
    • carlosgc@webkit.org's avatar
      2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com> · e1e700b0
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Implement scheduleWorkAfterDelay() in WorkQueueGtk
              https://bugs.webkit.org/show_bug.cgi?id=57434
      
              * Platform/WorkQueue.h:
              * Platform/gtk/WorkQueueGtk.cpp:
              (WorkQueue::EventSource::executeEventSource): This new method
              contains the common code to execute a work item.
              (WorkQueue::EventSource::performWorkOnce): Use
              executeEventSource() to execute the work item.
              (WorkQueue::EventSource::performWork): Use executeEventSource() to
              execute the work item.
              (WorkQueue::registerEventSourceHandler): Use a GSocket instead of
              a GIOChannel since the API is newer and allows us to pass a
              cancellable object to be able to cancel the source.
              (WorkQueue::scheduleWorkOnSource): This new method contains the
              common code to attach a source to a context. It doesn't use a lock
              anymore, since g_source_attach() uses its own mutex internally.
              (WorkQueue::scheduleWork): Use an idle source instead of a timeout
              one, changing the priority to G_PRIORITY_DEFAULT.
              (WorkQueue::scheduleWorkAfterDelay): Implement it using a timeout
              source with the given delay.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1e700b0
    • carlosgc@webkit.org's avatar
      2011-04-08 Carlos Garcia Campos <cgarcia@igalia.com> · 3e085bd0
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Use glib API instead of fork + execl in ProcessLauncherGtk
              https://bugs.webkit.org/show_bug.cgi?id=57234
      
              * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
              (WebKit::childSetupFunction): close the socket and use prctl()
              when platform is Linux to kill the child process when the parent
              finishes.
              (WebKit::ProcessLauncher::launchProcess): Use g_spawn_async() to
              launch the web process.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e085bd0
    • podivilov@chromium.org's avatar
      2011-04-08 Andrey Adaikin <aandrey@google.com> · bb318949
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Tweak dynamically constants for the async highlighting in text editor
              https://bugs.webkit.org/show_bug.cgi?id=58035
      
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextEditorMainPanel.prototype._expandChunks):
              (WebInspector.TextEditorMainPanel.prototype._schedulePaintLines):
              (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
              (WebInspector.TextEditorMainPanel.prototype._restorePaintLinesOperationsCredit):
              (WebInspector.TextEditorMainPanel.prototype._adjustPaintLinesOperationsRefreshValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb318949
    • caseq@chromium.org's avatar
      2011-04-08 Andrey Kosyakov <caseq@chromium.org> · 2116b004
      caseq@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: HAR compliance fixes
              https://bugs.webkit.org/show_bug.cgi?id=58124
      
              - Always provide some values for queryString and cookies, even though arrays may be empty
              - Always provide an empty cache object
              - Added entire HARLog to test
              - Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms)
      
              * inspector/front-end/HAREntry.js:
              (WebInspector.HAREntry.prototype.build):
              (WebInspector.HAREntry.prototype._buildRequest):
              (WebInspector.HAREntry.prototype._buildResponse):
      
      2011-04-08  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: HAR compliance fixes
              https://bugs.webkit.org/show_bug.cgi?id=58124
      
              - Added entire HARLog to test
              - Workaround in test to avoid custom expectations (favicon.ico appears in log on certain platforms
      
              * http/tests/inspector/resource-har-conversion-expected.txt:
              * http/tests/inspector/resource-har-conversion.html:
              * http/tests/inspector/resources-test.js:
              * platform/mac-wk2/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2116b004
    • tkent@chromium.org's avatar
      2011-04-08 Kent Tamura <tkent@chromium.org> · b54a4de2
      tkent@chromium.org authored
              [Chromium] Build fix for Windows (dbg)(shared).
      
              * WebKit.gyp: Add webkit_support dependency, which is required for webkit_unittest_files.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b54a4de2
    • sergio@webkit.org's avatar
      2011-04-08 Sergio Villar Senin <svillar@igalia.com> · 5df259b0
      sergio@webkit.org authored
              Unreviewed, added new GTK+ test expectations.
      
              * platform/gtk/fast/block/positioning/complex-positioned-movement-expected.checksum: Added.
              * platform/gtk/fast/block/positioning/complex-positioned-movement-expected.png: Added.
              * platform/gtk/fast/block/positioning/complex-positioned-movement-expected.txt: Added.
              * platform/gtk/fast/text/decorations-transformed-expected.checksum: Added.
              * platform/gtk/fast/text/decorations-transformed-expected.png: Added.
              * platform/gtk/fast/text/decorations-transformed-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5df259b0
    • commit-queue@webkit.org's avatar
      2011-04-08 Dominic Cooney <dominicc@google.com> · f529509b
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              layoutTestController.shadowRoot should return undefined if its
              argument is not an element.
              https://bugs.webkit.org/show_bug.cgi?id=58119
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::shadowRoot):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f529509b
    • mario@webkit.org's avatar
      2011-04-08 Mario Sanchez Prada <msanchez@igalia.com> · ae17af2f
      mario@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
              https://bugs.webkit.org/show_bug.cgi?id=58039
      
              Implemented missing functions in GTK's DRT.
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.h:
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (modifyAccessibilityValue): Helper function to increment or decrement
              the current value for an object through the AccessibilityObject's API.
              (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function,
              to be used from GTK's DRT.
              (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.
      2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
              https://bugs.webkit.org/show_bug.cgi?id=58039
      
              Implement missing functions in GTK's DRT.
      
              * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
              (AccessibilityUIElement::increment): Implemented.
              (AccessibilityUIElement::decrement): Implemented.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae17af2f
    • commit-queue@webkit.org's avatar
      2011-04-08 Dominic Cooney <dominicc@google.com> · 82731cc9
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Make WK2 layoutTestController.shadowRoot return undefined, not
              null, when its argument is not an element.
              https://bugs.webkit.org/show_bug.cgi?id=58121
      
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::shadowRoot):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82731cc9
    • antonm@chromium.org's avatar
      2011-04-08 Anton Muhin <antonm@chromium.org> · a1ad846d
      antonm@chromium.org authored
              Reviewed by Adam Barth.
      
              [v8] Change expectations for plugins/netscape-plugin-poperty-access-exception test
              https://bugs.webkit.org/show_bug.cgi?id=54681
      
              This a patch which should be landed when fix for exception handling in v8 is landed
              (see http://codereview.chromium.org/6397011/)
      
              * platform/chromium-mac/plugins/netscape-plugin-property-access-exception-expected.txt:
              * platform/chromium-win/plugins/netscape-plugin-property-access-exception-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1ad846d
    • rniwa@webkit.org's avatar
      2011-04-08 Ryosuke Niwa <rniwa@webkit.org> · 8d2e1c50
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html
              https://bugs.webkit.org/show_bug.cgi?id=58074
      
              Converted 5065605.html and display-block-on-spans.html to dump-as-markup tests.
      
              * editing/pasteboard/5065605-expected.txt: Added.
              * editing/pasteboard/5065605.html:
              * editing/pasteboard/display-block-on-spans-expected.txt: Added.
              * editing/pasteboard/display-block-on-spans.html:
              * platform/chromium-linux/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/5065605-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/5065605-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/5065605-expected.png: Removed.
              * platform/gtk/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/gtk/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
              * platform/mac-leopard/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/5065605-expected.png: Removed.
              * platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/mac/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/5065605-expected.png: Removed.
              * platform/mac/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
              * platform/qt/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d2e1c50
    • ossy@webkit.org's avatar
      [Qt] Add platform specific expected file after r83235. · 4072bea9
      ossy@webkit.org authored
      * platform/qt/http/tests/security/contentSecurityPolicy: Added.
      * platform/qt/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4072bea9
    • tkent@chromium.org's avatar
      2011-04-08 Kent Tamura <tkent@chromium.org> · 1b64daa1
      tkent@chromium.org authored
              [Chromium] Update expectations for r82899 and r83253.
      
              * platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
              * platform/chromium-mac-leopard/fast/box-shadow/border-radius-big-expected.png: Added.
              * platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
              * platform/chromium-mac/fast/borders/border-radius-circle-expected.png: Added.
              * platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/border-radius-big-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/spread-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/spread-multiple-normal-expected.png: Added.
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b64daa1
    • ossy@webkit.org's avatar
      Flaky Test: fast/events/tabindex-focus-blur-all.html · 33fb4ee5
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52115
      
      * platform/qt/Skipped: Add fast/events/tabindex-focus-blur-all.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33fb4ee5
    • abarth@webkit.org's avatar
      2011-04-08 Adam Barth <abarth@webkit.org> · a1b677c8
      abarth@webkit.org authored
              Attempt to fix the Qt build.
      
              * css/CSSStyleApplyProperty.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1b677c8
    • abarth@webkit.org's avatar
      2011-04-07 Adam Barth <abarth@webkit.org> · 1f7a5939
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Refactor WebCore/GNUMakefile.am to separate list of files
              https://bugs.webkit.org/show_bug.cgi?id=58116
      
              This change is similar to the cooresponding to change to
              JavaScriptCore.  We hope to generate GNUmakefile.list.am automatically
              using GYP.
      
              * GNUmakefile.am:
              * GNUmakefile.list.am: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f7a5939
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · 2823d79d
      rniwa@webkit.org authored
              Chromium rebaseline after r83246.
      
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2823d79d
    • ggaren@apple.com's avatar
      Not reviewed. · 17075df5
      ggaren@apple.com authored
      Rolled out some accidentally-committed changes in my last commit.
      
      * dom/EventTarget.cpp:
      (WebCore::EventTarget::addEventListener):
      (WebCore::EventTarget::removeEventListener):
      * dom/EventTarget.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17075df5
    • commit-queue@webkit.org's avatar
      2011-04-07 Julien Chaffraix <jchaffraix@codeaurora.org> · 9d3fc5b1
      commit-queue@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              EventSource should only accept UTF-8 charset
              https://bugs.webkit.org/show_bug.cgi?id=56942
      
              * ChangeLog-2011-02-16: Corrected previous commit message. Pointed out by Alexey.
      
              * http/tests/eventsource/eventsource-bad-mime-type-expected.txt: Updated with the new console message.
      
              * http/tests/eventsource/eventsource-content-type-charset-expected.txt:
              * http/tests/eventsource/eventsource-content-type-charset.html: Beefed up this test and merged
              the following test into it. The new tests check that we dispatch a console error if the charset is
              wrong.
      
              * http/tests/eventsource/eventsource-content-type-text-event-stream-foobar-expected.txt: Removed.
              * http/tests/eventsource/eventsource-content-type-text-event-stream-foobar.html: Removed.
      
              * http/tests/eventsource/resources/response-content-type-charset.php: Return the charset passed
              in the URL. Also added PHP's magic quotes handling as this would make the test fail on Mac.
      
              * http/tests/eventsource/resources/response-content-type-event-stream-foobar.php: Removed.
      2011-04-07  Julien Chaffraix  <jchaffraix@codeaurora.org>
      
              Reviewed by Alexey Proskuryakov.
      
              EventSource should only accept UTF-8 charset
              https://bugs.webkit.org/show_bug.cgi?id=56942
      
              Following the discussion on bug 45372, this change implements the recommended
              way of handling "charset". We only accept UTF-8 but no other encoding. This matches
              the encoding of the EventSource and also may fix TomCat that automatically send this
              charset.
      
              * page/EventSource.cpp:
              (WebCore::EventSource::didReceiveResponse): We now check the charset attribute and if it is
              not UTF-8, abort the connection and log the error to the console. Also we log if the MIME type
              is wrong to the console to help debugging (only in the case of an HTTP 200 response though).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d3fc5b1
    • ggaren@apple.com's avatar
      2011-04-07 Geoffrey Garen <ggaren@apple.com> · 264f9e28
      ggaren@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Some Handle<T> cleanup
              https://bugs.webkit.org/show_bug.cgi?id=58109
      
              * bytecode/SamplingTool.h: Sorted alphabetically because that's the
              WebKit style. Added a Global.h #include that was previously missing
              but harmless.
      
              * collector/handles/Global.h:
              (JSC::Global::Global): Added a null constructor. No need for a special
              tag, and the tag is incompatible with some data structures.
              
              (JSC::Global::isHashTableDeletedValue):
              (JSC::Global::~Global):
              (JSC::Global::set):
              (JSC::Global::operator=):
              (JSC::Global::clear):
              (JSC::Global::hashTableDeletedValue): Reordered constructors to be near
              each other.
      
              (JSC::Global::setWithWriteBarrier): Renamed internalSet to
              setWithWriteBarrier for clarity, and funneled more code into using set
              and setWithWriteBarrier to reduce duplication.
      
              * collector/handles/Handle.h:
              (JSC::HandleBase::operator!):
              (JSC::HandleBase::HandleBase): Removed isEmpty(), since we already have
              boolean and ! operators.
      
              (JSC::HandleBase::slot):
              (JSC::HandleBase::setSlot):
              (JSC::Handle::Handle): Added general support for null Handles. This was
              previously outlawed by ASSERTs, but our code has grown to support and
              rely on null Handles.
              
              * collector/handles/HandleHeap.cpp:
              (JSC::HandleHeap::markWeakHandles):
              (JSC::HandleHeap::finalizeWeakHandles):
              (JSC::HandleHeap::isValidWeakNode): Migrated from isValidWeakHandle,
              and beefed this up a bit.
      
              * collector/handles/HandleHeap.h:
              (JSC::HandleHeap::globalData): Added accessor, used by some new set functions.
      
              * collector/handles/Local.h: Moved hash traits to the bottom of the file,
              since this file is about the Local class, not the traits.
      
              (JSC::::Local): Updated for removal of invalidate().
      
              (JSC::::operator): Deployed "using" to avoid a lot of this->
              template funny business.
      
              (JSC::::setWithSlotCheck): Renamed from internalSet, more specific now.
      
              * interpreter/RegisterFile.h:
              (JSC::RegisterFile::RegisterFile): Updated to use null constructor.
      
              * jit/JITStubs.cpp:
              (JSC::JITThunks::hostFunctionStub):
      
              * runtime/JSPropertyNameIterator.h:
              (JSC::Structure::setEnumerationCache):
              * runtime/Structure.h: Removed clearEnumerationCache
              because it was an unused holdover from when the enumeration cache was
              not a handle.
      
              * runtime/WeakGCMap.h:
              (JSC::WeakGCMap::set): Finish initializing our handle before putting it
              in the table. This seemed more logical, and at one point was required
              to avoid triggering an ASSERT.
      
              * runtime/WeakGCPtr.h: Inherit from Handle instead of rolling our own
              handle-like behavior, to avoid duplication.
      
              (JSC::WeakGCPtr::WeakGCPtr):
              (JSC::WeakGCPtr::~WeakGCPtr):
              (JSC::WeakGCPtr::get):
              (JSC::WeakGCPtr::clear):
              (JSC::WeakGCPtr::set):
              (JSC::WeakGCPtr::setWithWriteBarrier): Removed duplicate code and
              standardized on Handle idioms.
      2011-04-07  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Some Handle<T> cleanup
              https://bugs.webkit.org/show_bug.cgi?id=58109
      
              * JSRun.h:
              * JSValueWrapper.h: #include a file that was missing before, but was
              harmlessly so until now.
      2011-04-07  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Some Handle<T> cleanup
              https://bugs.webkit.org/show_bug.cgi?id=58109
      
              * bindings/js/ScriptValue.h:
              (WebCore::ScriptValue::ScriptValue): Updated for new null constructor.
              (WebCore::ScriptValue::hasNoValue): Updated for removal of isEmpty().
      2011-04-07  Geoffrey Garen  <ggaren@apple.com>
      
              Some Handle<T> cleanup
              https://bugs.webkit.org/show_bug.cgi?id=58109
      
              * WebProcess/Plugins/Netscape/NPJSObject.cpp:
              (WebKit::NPJSObject::NPJSObject): Updated for new null constructor.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      264f9e28
    • kinuko@chromium.org's avatar
      2011-04-07 Kinuko Yasuda <kinuko@chromium.org> · 8f74be2d
      kinuko@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Add WebKit API to query and request unified offline-storage quota
              https://bugs.webkit.org/show_bug.cgi?id=57849
              Just adding the API, this does not do anything yet.
      
              The API is based on the public discussion for unified quota API:
              http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
              (The detail is not yet fully specified and might be subject to change.)
      
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::queryStorageUsageAndQuota): Added.
              (WebKit::WebFrameClient::requestStorageQuota): Added.
              * public/WebStorageQuotaCallbacks.h: Added.
              (WebKit::WebStorageQuotaCallbacks::~WebStorageQuotaCallbacks):
              * public/WebStorageQuotaType.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f74be2d
    • tkent@chromium.org's avatar
      2011-04-07 Kent Tamura <tkent@chromium.org> · 67d4cd87
      tkent@chromium.org authored
              [Chromium] Update expectations for xsl-blocked.php and pate-text-011.html.
      
              * platform/chromium/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67d4cd87