1. 18 Sep, 2009 11 commits
    • kenneth@webkit.org's avatar
      Make PlatformWindow return something else than PlatformWidget · e8249bf2
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=29085
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-17
      Reviewed by Simon Hausmann.
      
      WebCore:
      
      Make platformWindow return a PlatformPageClient
      (for now typedef'ed to PlatformWidget)
      
      Also, change the name of platformWindow to platformPageClient()
      
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (getPangoLayoutForAtk):
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::platformPageClient):
      * page/Chrome.cpp:
      (WebCore::Chrome::platformPageClient):
      * page/Chrome.h:
      * page/ChromeClient.h:
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::wheelEvent):
      (WebCore::EventHandler::currentPlatformMouseEvent):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      * platform/HostWindow.h:
      * platform/Widget.h:
      * platform/gtk/PlatformScreenGtk.cpp:
      (WebCore::getVisual):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenu::show):
      * platform/gtk/ScrollViewGtk.cpp:
      (WebCore::ScrollView::platformAddChild):
      (WebCore::ScrollView::platformRemoveChild):
      (WebCore::ScrollView::visibleContentRect):
      * platform/gtk/WidgetGtk.cpp:
      (WebCore::Widget::setFocus):
      (WebCore::Widget::setCursor):
      * platform/qt/PlatformScreenQt.cpp:
      (WebCore::screenDepth):
      (WebCore::screenDepthPerComponent):
      (WebCore::screenIsMonochrome):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      * platform/qt/PopupMenuQt.cpp:
      (WebCore::PopupMenu::show):
      * platform/qt/WidgetQt.cpp:
      (WebCore::Widget::setCursor):
      * platform/win/PlatformScreenWin.cpp:
      (WebCore::monitorInfoForWidget):
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::show):
      (WebCore::PopupMenu::calculatePositionAndSize):
      (WebCore::PopupMenu::wndProc):
      * platform/wx/RenderThemeWx.cpp:
      (WebCore::nativeWindowForRenderObject):
      * platform/wx/ScrollbarThemeWx.cpp:
      (WebCore::ScrollbarThemeWx::paint):
      * plugins/gtk/PluginViewGtk.cpp:
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::forceRedraw):
      (WebCore::PluginView::platformStart):
      * plugins/mac/PluginViewMac.cpp:
      (WebCore::PluginView::platformStart):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::handleKeyboardEvent):
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::platformStart):
      * plugins/win/PluginViewWin.cpp:
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::forceRedraw):
      (WebCore::PluginView::platformStart):
      
      WebKit/gtk:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::platformPageClient):
      (WebKit::ChromeClient::runOpenPanel):
      * WebCoreSupport/ChromeClientGtk.h:
      * webkit/webkitprivate.cpp:
      (currentToplevelCallback):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_popup_menu_handler):
      
      WebKit/haiku:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::platformPageClient):
      * WebCoreSupport/ChromeClientHaiku.h:
      
      WebKit/mac:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::platformPageClient):
      
      WebKit/qt:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::platformPageClient):
      * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
      Reflect the rename of platformWindow and it's return type.
      
      * AccessibleBase.cpp:
      (AccessibleBase::get_accParent):
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::platformPageClient):
      * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::platformPageClient):
      * WebKitSupport/ChromeClientWx.h:
      * WebKitSupport/EditorClientWx.cpp:
      (WebCore::EditorClientWx::isEditable):
      (WebCore::EditorClientWx::registerCommandForUndo):
      (WebCore::EditorClientWx::registerCommandForRedo):
      (WebCore::EditorClientWx::clearUndoRedoOperations):
      (WebCore::EditorClientWx::canUndo):
      (WebCore::EditorClientWx::canRedo):
      (WebCore::EditorClientWx::undo):
      (WebCore::EditorClientWx::redo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8249bf2
    • hausmann@webkit.org's avatar
      [Qt] Web inspector UI adjustments specific to the Qt platform: · daa9f964
      hausmann@webkit.org authored
      - Hide the close button
      - Hide the dock button
      - Disable the draggable toolbar
      
      Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      https://bugs.webkit.org/show_bug.cgi?id=29384
      
      * inspector/front-end/inspector.css:
      * inspector/front-end/inspector.js:
      (WebInspector.toolbarDragStart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daa9f964
    • hausmann@webkit.org's avatar
      Fix the Qt/Windows CE build. · fe9f3fda
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * JavaScriptCore.pri: Build the ce_time.cpp functions from
      within Qt externally.
      * wtf/DateMath.cpp: Removed unnecessary Qt #ifdef, for the
      Qt build these functions are no external, too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe9f3fda
    • hausmann@webkit.org's avatar
      QtWebKit Windows CE compile fixes · 7f26dc14
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      Exclude certain pure-WINCE specific code paths from the Qt build.
      
      * platform/graphics/BitmapImage.h:
      * platform/graphics/FontCache.h:
      * platform/graphics/MediaPlayer.cpp:
      * platform/text/TextEncodingRegistry.cpp:
      (WebCore::buildBaseTextCodecMaps):
      (WebCore::extendTextCodecMaps):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::stop): Guard this code block with NETSCAPE_PLUGIN_API as
      the corresponding PluginViewWndProc has the same guard in the header file.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f26dc14
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · 59eabdbb
      xan@webkit.org authored
              Reviewed by Jan Alonzo.
      
              Document webkit_web_view_stop_loading.
      
              * webkit/webkitwebview.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59eabdbb
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · fd4dd8e1
      xan@webkit.org authored
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add new tests to the build.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2009-09-18  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add webkit_web_view_get_hit_test_result, a function to get a hit
              test result from a GdkEventButton. Useful to let applications
              decide between several actions on button press depending on what
              is being pressed.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_stop_loading):
              (documentPointForWindowPoint):
              (webkit_web_view_get_hit_test_result):
              * webkit/webkitwebview.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd4dd8e1
    • xan@webkit.org's avatar
      2009-09-14 Xan Lopez <xlopez@igalia.com> · 2266a5b0
      xan@webkit.org authored
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add WebKitHitTestResult to the build.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2009-09-18  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add WebKitHitTestResult, a wrapper over HitTestResult. It contains
              context information about a point in the web page.
      
              * webkit/webkit.h:
              * webkit/webkitdefines.h:
              * webkit/webkithittestresult.cpp: Added.
              (webkit_hit_test_result_finalize):
              (webkit_hit_test_result_get_property):
              (webkit_hit_test_result_set_property):
              (webkit_hit_test_result_class_init):
              (webkit_hit_test_result_init):
              * webkit/webkithittestresult.h: Added.
              * webkit/webkitprivate.cpp:
              (WebKit::kit):
              * webkit/webkitprivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2266a5b0
    • hausmann@webkit.org's avatar
      [Qt] Add persistence support for configuration options in the · 9a2d46fb
      hausmann@webkit.org authored
      inspector.
      
      Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * Api/qwebinspector.cpp:
      * QtLauncher/main.cpp:
      (main):
      * WebCoreSupport/InspectorClientQt.cpp:
      (WebCore::InspectorClientQt::populateSetting):
      (WebCore::InspectorClientQt::storeSetting):
      (WebCore::variantToSetting):
      (WebCore::settingToVariant):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a2d46fb
    • eric@webkit.org's avatar
      2009-09-18 Steve Block <steveblock@google.com> · a05aaad4
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Geolocation does not correctly handle Infinity for PositionOptions properties.
              https://bugs.webkit.org/show_bug.cgi?id=29099
      
              * fast/dom/Geolocation/resources/argument-types.js: Modified. Test passing positive and negative Infinity to Geolocation methods.
              * fast/dom/Geolocation/argument-types-expected.txt: Modified. Expected result for above test.
      2009-09-18  Steve Block  <steveblock@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Geolocation does not correctly handle Infinity for PositionOptions properties.
              https://bugs.webkit.org/show_bug.cgi?id=29099
      
              * bindings/js/JSGeolocationCustom.cpp: Modified.
              (WebCore::createPositionOptions): Modified. If timeout or maximumAge is positive infinity, applies these values as a special case.
              * page/PositionOptions.h: Modified.
              (WebCore::PositionOptions::hasMaximumAge): Added. Determines whether the object has a maximum age.
              (WebCore::PositionOptions::maximumAge): Modified. Asserts that the object has a maximum age.
              (WebCore::PositionOptions::clearMaximumAge): Added. Clears the maximum age.
              (WebCore::PositionOptions::setMaximumAge): Modified. Registers that the maximum age has been set.
              (WebCore::PositionOptions::PositionOptions): Modified. Registers that the maximum age has been set.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a05aaad4
    • hausmann@webkit.org's avatar
      Fixed a bunch of documentation warnings. · ee26bcb7
      hausmann@webkit.org authored
      Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-18
      Reviewed by Ariya Hidayat.
      
      * Api/qwebgraphicsitem.cpp:
      * Api/qwebplugindatabase.cpp:
      * Api/qwebpluginfactory.cpp:
      * Api/qwebsecurityorigin.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee26bcb7
    • hausmann@webkit.org's avatar
      Added a test that console output works. · ba1be41c
      hausmann@webkit.org authored
      Patch by Warwick Allison <warwick.allison@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * tests/qwebpage/tst_qwebpage.cpp:
      (ConsolePage::ConsolePage):
      (ConsolePage::javaScriptConsoleMessage):
      (tst_QWebPage::consoleOutput):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba1be41c
  2. 17 Sep, 2009 29 commits
    • weinig@apple.com's avatar
      Fix for https://bugs.webkit.org/show_bug.cgi?id=29276 · 7c2f4a32
      weinig@apple.com authored
      REGRESSION(r48334): WebKit crashes on file select by drag
      
      Reviewed by Adele Peterson.
      
      Document.elementFromPoint now takes point in client space, not page space.
      
      * page/DragController.cpp:
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::concludeEditDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c2f4a32
    • ajwong@chromium.org's avatar
      2009-09-17 Albert J. Wong <ajwong@chromium.org> · 85a391e1
      ajwong@chromium.org authored
              Reviewed by David Levin.
      
              Reimplement default media UI for Mac Chromium to match the style
              of the Windows and Linux versions.  Also breaks the dependency
              on the internal wk* functions that were previously used to
              render the media controller widgets.
              https://bugs.webkit.org/show_bug.cgi?id=29161
      
              No media layout tests are currently enabled in Mac Chromium, so
              nothing needs rebaselineing, etc.
      
              This is a recommit of r48438 with a compile fix and merges of
              recent changes to the file.
      
              * css/mediaControlsChromium.css:
              * rendering/RenderThemeChromiumMac.h:
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::mediaElementParent):
              (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet):
              (WebCore::mediaSliderThumbImage):
              (WebCore::mediaVolumeSliderThumbImage):
              (WebCore::RenderThemeChromiumMac::paintSliderTrack):
              (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize):
              (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal):
              (WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
              (WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
              (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
              (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack):
              (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
              (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
              (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85a391e1
    • bweinstein@apple.com's avatar
      2009-09-17 Brian Weinstein <bweinstein@apple.com> · 3508659c
      bweinstein@apple.com authored
              Rubber-stamped by Steve Falkenburg.
      
              Add failing test on both Windows Debug and Release to the
              Windows Skipped List.
              
              http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html is
              being tracked by <https://bugs.webkit.org/show_bug.cgi?id=29353>.
      
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3508659c
    • bweinstein@apple.com's avatar
      2009-09-17 Brian Weinstein <bweinstein@apple.com> · e72263c6
      bweinstein@apple.com authored
              Reviewed by Timothy Hatcher.
      
              The Console scope bar should have a divider between All and the other possible
              values (Errors, Warnings, Logs). It will look something like:
              
              All | Errors Warnings Logs.
      
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.createDividerElement):
              (WebInspector.ConsoleView):
              * inspector/front-end/inspector.css:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e72263c6
    • bweinstein@apple.com's avatar
      2009-09-17 Brian Weinstein <bweinstein@apple.com> · a7e66e1d
      bweinstein@apple.com authored
              Reviewed by Adam Roben.
      
              Remove assertions that were being hit by calls to
              m_verticalScrollbar->invalidate(). These assertions were valid,
              but they were causing tests to fail, so replacing with a FIXME 
              until we can find out the real cause/solution that is being tracked 
              by http://webkit.org/b/29350.
      
              * WebView.cpp:
              (WebView::addToDirtyRegion):
              (WebView::paintIntoBackingStore):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7e66e1d
    • weinig@apple.com's avatar
      Remove additional references to JSVoidCallback which no longer exists. · 8911af2f
      weinig@apple.com authored
      Reviewed by Mark Rowe.
      
      * DerivedSources.cpp:
      * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8911af2f
    • eric@webkit.org's avatar
      2009-09-17 Alpha Lam <hclam@chromium.org> · 5e00a66b
      eric@webkit.org authored
              Reviewed by Eric Carlson.
      
              Media layout tests should have a way to provide test files in different formats
              https://bugs.webkit.org/show_bug.cgi?id=28327
      
              Updating 19 media layout tests to use media files based on supported codecs.
      
              * media/media-file.js: Prefer .wav over other formats as this is used the most in tests for mac port.
              Most of audio tests use media/content/test.wav as test file for mac, so this change would make sure
              findMediaFile() will return test.wav but not test.mp3 or other formats.
              (setSrcById): Fixing bug in code.
              * media/video-canvas-source.html: Use findMediaFile() to locate a media file based on supported types.
              * media/video-click-dblckick-standalone.html: ditto.
              * media/video-controls-transformed.html: ditto.
              * media/video-controls-visible-audio-only.html: ditto.
              * media/video-controls-zoomed.html: ditto.
              * media/video-controls.html: ditto.
              * media/video-currentTime-set.html: ditto.
              * media/video-currentTime-set2.html: ditto.
              * media/video-currentTime.html: ditto.
              * media/video-display-none-crash.html: ditto.
              * media/video-display-toggle.html: ditto.
              * media/video-dom-autoplay.html: ditto.
              * media/video-dom-src.html: ditto.
              * media/video-error-abort.html: ditto.
              * media/video-load-networkState.html: ditto.
              * media/video-load-readyState.html: ditto.
              * media/video-loop.html: ditto.
              * media/video-muted.html: ditto.
              * media/video-no-autoplay.html: ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e00a66b
    • weinig@apple.com's avatar
      Remove commented out onhashchange attribute now that it is implemented. · 9363f63c
      weinig@apple.com authored
      Reviewed by Brady Eidson.
      
      * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9363f63c
    • andersca@apple.com's avatar
      WebCore: <rdar://problem/7007541> · 5efc6b59
      andersca@apple.com authored
      CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...
              
      Reviewed by Oliver Hunt.
      
      Make RuntimeObjectImp more robust against m_instance being a null (which can happen if an OOP plug-in
      crashes while we're calling into it).
              
      * bridge/runtime_object.cpp:
      (JSC::RuntimeObjectImp::RuntimeObjectImp):
      (JSC::RuntimeObjectImp::~RuntimeObjectImp):
      (JSC::RuntimeObjectImp::invalidate):
      (JSC::RuntimeObjectImp::fallbackObjectGetter):
      (JSC::RuntimeObjectImp::fieldGetter):
      (JSC::RuntimeObjectImp::methodGetter):
      (JSC::RuntimeObjectImp::getOwnPropertySlot):
      (JSC::RuntimeObjectImp::getOwnPropertyDescriptor):
      (JSC::RuntimeObjectImp::put):
      (JSC::RuntimeObjectImp::defaultValue):
      (JSC::RuntimeObjectImp::getCallData):
      (JSC::RuntimeObjectImp::getConstructData):
      (JSC::RuntimeObjectImp::getPropertyNames):
      * bridge/runtime_object.h:
      (JSC::RuntimeObjectImp::getInternalInstance):
      
      WebKit/mac: <rdar://problem/7007541> 
      CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...
      
      Reviewed by Oliver Hunt.
      
      Add null checks for m_instanceProxy (It will be null when a plug-in has crashed).
              
      * Plugins/Hosted/ProxyInstance.mm:
      (WebKit::ProxyInstance::invoke):
      (WebKit::ProxyInstance::supportsInvokeDefaultMethod):
      (WebKit::ProxyInstance::supportsConstruct):
      (WebKit::ProxyInstance::getPropertyNames):
      (WebKit::ProxyInstance::methodsNamed):
      (WebKit::ProxyInstance::fieldNamed):
      (WebKit::ProxyInstance::fieldValue):
      (WebKit::ProxyInstance::setFieldValue):
      (WebKit::ProxyInstance::invalidate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5efc6b59
    • eric@webkit.org's avatar
      2009-09-17 Yury Semikhatsky <yurys@chromium.org> · 703a517d
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Wrap primitive values (as objects) in InspectorController::wrap.
      
              https://bugs.webkit.org/show_bug.cgi?id=28983
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::wrapObject): objects of any type will be wrapped into proxies,
               only object proxies will have objectId.
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype.completions): there is InjectedScript.getCompletionsi
               that accepts an expression and returns possible completions. This way we don't need to wrap
               and unwrap the completions result into a proxy object.
              * inspector/front-end/InjectedScript.js:
              (InjectedScript.getCompletions):
              (InjectedScript.evaluate):
              (InjectedScript._evaluateOn):
              (InjectedScript.createProxyObject):
              * inspector/front-end/InjectedScriptAccess.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      703a517d
    • japhet@chromium.org's avatar
      2009-09-17 Nate Chapin <japhet@chromium.org> · 4404a525
      japhet@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Wrap PageTransitionEvents properly for V8's use.
      
              https://bugs.webkit.org/show_bug.cgi?id=29340
      
              Fixes Chromium's failures for LayoutTests/fast/events/pageshow-pagehide.html.
      
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::convertEventToV8Object): Wrap PageTransitionEvents properly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4404a525
    • simon.fraser@apple.com's avatar
      2009-09-17 Simon Fraser <simon.fraser@apple.com> · f159ab01
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Hardware-accelerated opacity transition on inline asserts
              https://bugs.webkit.org/show_bug.cgi?id=29342
      
              Remove an erroneous toRenderBox() that could be called on a RenderInline; we can just
              pass an empty size, because the box size is only required for transform animations.
      
              Test: compositing/transitions/opacity-on-inline.html
      
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::startTransition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f159ab01
    • eric@webkit.org's avatar
      2009-09-17 Eric Seidel <eric@webkit.org> · 97b5bb0d
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Update contributing.html to mention recently added tools.
              https://bugs.webkit.org/show_bug.cgi?id=29318
      
              Update our contributing instructions to mention
              the new tools (check-webkit-style and commit-queue)
              recently added to make contributions easier.
      
              * coding/contributing.html:
               - Mention check-webkit-style as an optional helper tool.
               - Mention checking the 'patch' checkbox.
               - Mention the commit-queue as an optional helper tool.
               - Remove "or in email" since patch reviews are all done via bugzilla.
               - Encourage contributers to be responsible for getting their patch landed.  Provide a list of committers.
               - Mention commit-queue as an optional help in getting your patch landed.
               - Give an overview of the commit-queue process and link to the Commit Queue docs.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97b5bb0d
    • kov@webkit.org's avatar
      2009-09-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 473997ad
      kov@webkit.org authored
              Rubber-stamped by Brady Eidson.
      
              Tiger fails test http/tests/loading/redirect-with-no-location-crash.html added in r48413
              https://bugs.webkit.org/show_bug.cgi?id=29329
      
              Skip test that fails on Tiger because of a bug in its version of
              CFNetwork.
      
              * platform/mac-tiger/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      473997ad
    • eric@webkit.org's avatar
      2009-09-17 Adam Barth <abarth@webkit.org> · a0074eea
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [V8] OwnHandle might get a weak callback after destruction
              https://bugs.webkit.org/show_bug.cgi?id=29172
      
              Be sure to clear out weak reference so we don't get a weak callback
              after we've destructed ourselves.  Also, removed some tricky methods
              that had no clients.
      
              * bindings/v8/OwnHandle.h:
              (WebCore::OwnHandle::clear):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0074eea
    • eric@webkit.org's avatar
      2009-09-17 Eric Seidel <eric@webkit.org> · 7c91b19a
      eric@webkit.org authored
              Reviewed by Simon Fraser.
      
              REGRESSION: media/video-size-intrinsic-scale.html (and other media tests?) crashing/timing-out intermittently
              https://bugs.webkit.org/show_bug.cgi?id=28845
      
              Skip media/video-size-intrinsic-scale.html in hopes of stopping the crashers.
              I ran the media tests with --iterations 30 w/o seeing a crash.
              I also re-enabled media/video-source-add-src.html now that we know it is not at fault.
      
              * media/video-source-add-src.html: Renamed from LayoutTests/media/video-source-add-src.html-disabled.
              * platform/mac-leopard/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c91b19a
    • eric@webkit.org's avatar
      2009-09-17 Anton Muhin <antonm@chromium.org> · c32b0531
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Add layout tests to verify there is no security leaks if someone sets a prototype of top
              window to its child window.
              https://bugs.webkit.org/show_bug.cgi?id=29334
      
              * http/tests/security/resources/iframe-with-element.html: Added.
              * http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt: Added.
              * http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto.html: Added.
              * http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt: Added.
              * http/tests/security/xss-DENIED-method-with-iframe-proto.html: Added.
              * http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto-expected.txt: Added.
              * http/tests/security/xss-DENIED-non-shadowable-propterty-with-iframe-proto.html: Added.
              * http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto-expected.txt: Added.
              * http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c32b0531
    • dglazkov@chromium.org's avatar
      2009-09-17 Dimitri Glazkov <dglazkov@chromium.org> · 02e94c42
      dglazkov@chromium.org authored
              Unreviewed, build fix.
      
              [V8] Partial roll out of http://trac.webkit.org/changeset/48455 to
              fix crashes that started happening in V8Proxy::getEnteredContext().
      
              * bindings/v8/ScheduledAction.cpp:
              (WebCore::ScheduledAction::execute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02e94c42
    • cfleizach@apple.com's avatar
      AX: labels of checkboxes should, when hit-tested, return the checkbox · 3b920269
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29335
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      When an accessibility hit test is done and it hits the label of a control element,
      the control element should be returned instead of nothing, since the label
      itself is usually ignored.
      
      Test: accessibility/label-for-control-hittest.html
      
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::correspondingControlForLabelElement):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
      (WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
      * accessibility/AccessibilityRenderObject.h:
      
      LayoutTests: 
      
      * accessibility/label-for-control-hittest-expected.txt: Added.
      * accessibility/label-for-control-hittest.html: Added.
      * platform/gtk/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b920269
    • dglazkov@chromium.org's avatar
      2009-09-17 Avi Drissman <avi@chromium.org> · 1b42b7eb
      dglazkov@chromium.org authored
              Reviewed by Dimitri Glazkov, build fix.
      
              Change to make RenderThemeChromiumMac compile inside of non PLATFORM(MAC).
              https://bugs.webkit.org/show_bug.cgi?id=29243
      
              Covered by existing tests.
      
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b42b7eb
    • dglazkov@chromium.org's avatar
      2009-09-17 Dimitri Glazkov <dglazkov@chromium.org> · 2bd9bd3d
      dglazkov@chromium.org authored
              Reviewed by Eric Seidel.
      
              [V8] Accessing properties/methods of an object, created with document.implementation.createDocumentType
              creates nodes that have no document (ScriptExecutionContext), which in turn produces NULL-ref crashes.
              https://bugs.webkit.org/show_bug.cgi?id=26402
      
              Test: fast/dom/DOMImplementation/detached-doctype.html
                    fast/dom/doctype-event-listener-crash.html
      
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::getEventListener): Added an extra NULL-check.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bd9bd3d
    • bweinstein@apple.com's avatar
      2009-09-17 Brian Weinstein <bweinstein@apple.com> · 95c84c38
      bweinstein@apple.com authored
              Rubber-stamped by Adam Roben.
      
              Add a newline to the end of the expected file, should fix results.
      
              * platform/win/transforms/2d/hindi-rotated-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95c84c38
    • adachan@apple.com's avatar
      Post WebViewDidChangeSelectionNotification when the text selection changes. · 02e2c60f
      adachan@apple.com authored
              Fixes <http://webkit.org/b/29321>
      
              Reviewed by Adam Roben.
      
              * Interfaces/IWebView.idl:
              * WebCoreSupport/WebEditorClient.cpp:
              (WebEditorClient::respondToChangedSelection):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02e2c60f
    • kevino@webkit.org's avatar
      wx build fix, add missing dependency. · d180fd89
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d180fd89
    • bweinstein@apple.com's avatar
      2009-09-17 Brian Weinstein <bweinstein@apple.com> · d4a4eca6
      bweinstein@apple.com authored
              Rubber-stamped by Adam Roben.
      
              Updated Windows results on three failing tests, adding font-smoothing to computed-style,
              and udpated the hindi-rotated-expected to what it has been getting on the bots.
      
              * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
              * platform/win/transforms/2d/hindi-rotated-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4a4eca6
    • mitz@apple.com's avatar
      Add file that was missing from the last change · 1ac6272f
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ac6272f
    • mitz@apple.com's avatar
      FontDescription.h includes RenderStyleConstants.h, which violates layering · 0c9a5dda
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29327
      
      Reviewed by Simon Fraser.
      
      * GNUmakefile.am: Added FontSmoothingMode.h.
      * WebCore.gypi: Added FontSmoothingMode.h.
      * WebCore.vcproj/WebCore.vcproj: Added FontSmoothingMode.h.
      * WebCore.xcodeproj/project.pbxproj: Added FontSmoothingMode.h and made
          it a private header.
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Get the
          font smoothing mode via the font description.
      * css/CSSPrimitiveValueMappings.h: Include FontSmoothingMode.h
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Updated for the rename
          of FontSmoothing to FontSmoothingMode.
      (WebCore::CSSPrimitiveValue::operator FontSmoothingMode): Ditto.
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty): Get the font smoothing mode
          via the font description.
      * platform/graphics/FontDescription.h: Do not include
          RenderStyleConstants.h.
      (WebCore::FontDescription::fontSmoothing): Updated for the rename of
          FontSmoothing to FontSmoothingMode.
      (WebCore::FontDescription::setFontSmoothing): Ditto.
      * platform/graphics/FontSmoothingMode.h: Added.
      (WebCore::FontSmoothingMode): Moved the FontSmoothing enum from
          RenderStyleConstants here and renamed it to this.
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::fontSmoothing): Removed this getter, since
          this can be accessed via the font description.
      * rendering/style/RenderStyleConstants.h: Moved the FontSmoothing enum
          from here to FontSmoothingMode.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c9a5dda
    • aroben@apple.com's avatar
      Fix a crash when a WebView's HWND is destroyed before IWebView::close is called · 8e07dbd4
      aroben@apple.com authored
      WebView's HWND was being sent a WM_TIMER message after the WebView was
      destroyed. This normally isn't possible (we call DestroyWindow inside
      WebView's destructor to ensure the HWND doesn't outlive the WebView),
      but r48060 changed WebView to call SetParent(m_viewWindow,
      HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the
      HWND into some weird half-destroyed state where it can still receive
      WM_TIMER messages.
      
      Fixes <http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION
      (r48060): unrepro but frequent crash in WebViewWndProc
      
      Reviewed by Steve Falkenburg.
      
      * WebView.cpp:
      (WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed()
      before calling close(). This allows setHostWindow to detect that we're
      handling WM_DESTROY. No other code in close() cared whether
      isBeingDestroyed() was true or not.
      (WebView::setHostWindow): If our host window is being set to 0 and
      we're being destroyed, don't become a message-only window. Doing this
      while handling WM_DESTROY seems to lead to crashes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e07dbd4
    • kevino@webkit.org's avatar
      wx 2.9 build fix. · c3f23b6f
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3f23b6f