1. 09 Sep, 2011 7 commits
    • commit-queue@webkit.org's avatar
      Crashes in WebCore::AppendNodeCommand::create(). · e7d6fb2a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67767
      
      Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-09
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      In CompositeEditCommand::closeParagraphUnderNewElement(), lastNode could be a non Element node.
      The current code assumes lastNode is an Element node. This patch checks it.
      
      Test: editing/execCommand/ident-crashes-topnode-is-text.html
      
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added an element node check.
      
      LayoutTests:
      
      Added a crash test case.
      
      * editing/execCommand/ident-crashes-topnode-is-text-expected.txt: Added.
      * editing/execCommand/ident-crashes-topnode-is-text.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7d6fb2a
    • commit-queue@webkit.org's avatar
      Crashes in WebCore::ApplyStyleCommand.doApply() · fddb7234
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67765
      
      Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-09
      Reviewed by Ryosuke Niwa.
      
      WebCore::enclosingBlock may return null, but ApplyStyleCommand::applyBlockStyle did not check it. This patch make it to be checked.
      
      Source/WebCore:
      
      Test: editing/style/remove-format-without-enclosing-block.html
      
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::applyBlockStyle): Added null check.
      
      LayoutTests:
      
      * editing/style/remove-format-without-enclosing-block-expected.txt: Added.
      * editing/style/remove-format-without-enclosing-block.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fddb7234
    • loislo@chromium.org's avatar
      2011-09-09 Ilya Tikhonovsky <loislo@chromium.org> · a82a94c1
      loislo@chromium.org authored
              Unreviewed. Update test expectations for hyphenate-limit-lines.html.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a82a94c1
    • simonjam@chromium.org's avatar
      [Chromium] Fix leak of Skia stream with custom CSS fonts · 9dacf219
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67815
      
      Reviewed by Adam Barth.
      
      Test: fast/css/font-face-opentype.html under valgrind
      
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      (WebCore::createFontCustomPlatformData):
      * platform/graphics/skia/FontCustomPlatformData.cpp:
      (WebCore::createFontCustomPlatformData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dacf219
    • loislo@chromium.org's avatar
      2011-09-08 Ilya Tikhonovsky <loislo@chromium.org> · 3e4fa066
      loislo@chromium.org authored
              Unreviewed, remove wrong chromium expectations for hyphenate-limit-lines.html and mark the test as failing IMAGE+TEXT.
      
              I rebaselined the expectations yesterday but actualy Chromium doesn't support hyphenation yet.
              See CR47083. 
      
              * platform/chromium-cg-mac/fast/text/hyphenate-limit-lines-expected.png: Removed.
              * platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Removed.
              * platform/chromium-mac/fast/text/hyphenate-limit-lines-expected.png: Removed.
              * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Removed.
              * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.txt: Removed.
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e4fa066
    • rniwa@webkit.org's avatar
      Push more code from HTMLInputElement::setValue to TextFieldInputType::setValue · bf110973
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67742
      
      Reviewed by Darin Adler.
      
      Moved more code in HTMLInputElement::setValue to TextFieldInputType::setValue, and merged
      InputType::valueChanged into InputType::setValue. Also introduced
      InputType::dispatchChangeEventInResponseToSetValue to be overridden by TextFieldInputType.
      
      * html/BaseButtonInputType.cpp:
      (WebCore::BaseButtonInputType::setValue):
      * html/BaseButtonInputType.h:
      * html/BaseCheckableInputType.cpp:
      (WebCore::BaseCheckableInputType::setValue):
      * html/BaseCheckableInputType.h:
      * html/ColorInputType.cpp:
      * html/ColorInputType.h:
      * html/FileInputType.cpp:
      (WebCore::FileInputType::setValue):
      * html/FileInputType.h:
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::setValue):
      * html/HTMLInputElement.h:
      (WebCore::HTMLInputElement::cacheSelectionInResponseToSetValue):
      * html/HiddenInputType.cpp:
      (WebCore::HiddenInputType::setValue):
      * html/HiddenInputType.h:
      * html/InputType.cpp:
      (WebCore::InputType::setValue):
      (WebCore::InputType::dispatchChangeEventInResponseToSetValue):
      * html/InputType.h:
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::setValue):
      * html/RangeInputType.h:
      * html/TextFieldInputType.cpp:
      (WebCore::TextFieldInputType::setValue):
      (WebCore::TextFieldInputType::dispatchChangeEventInResponseToSetValue):
      * html/TextFieldInputType.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf110973
    • rniwa@webkit.org's avatar
      REGRESSION(r94811): Assertion failure in 2 worker tests · 3db7d55c
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67829
      
      Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-08
      Reviewed by Sam Weinig.
      
      Fixing a couple tests that were broken due to the wrong values being 
      set in the parent class pointers in the ClassInfo structs for 
      TerminatedExecutionError and InterruptedExecutionError.
      
      * runtime/ExceptionHelpers.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3db7d55c
  2. 08 Sep, 2011 33 commits