1. 13 Jun, 2013 13 commits
    • bfulgham@apple.com's avatar
      [WinCairo] Unreviewed build correction. · e7578a6d
      bfulgham@apple.com authored
      * WebCore.vcxproj/WebCoreCairo.props: Use proper WebKit_Libraries
      environment variable, rather than older WebKitLibraries.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7578a6d
    • ch.dumez@sisa.samsung.com's avatar
      Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings · 847cf9d1
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117593
      
      Reviewed by Geoffrey Garen.
      
      Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings by
      calling asInt32() / asUInt32() instead of toInt32() / toUInt32()
      when we already know the value is a int32 / uint32.
      
      No new tests, no behavior change.
      
      * bindings/js/JSDOMBinding.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      847cf9d1
    • commit-queue@webkit.org's avatar
      Setting overflow:hidden on position:absolute does not repaint hidden content · d1da5939
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116994
      
      Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-06-13
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Since a container which has overflow clip of RenderBox which has self painting layer doesn't have a rect of the RenderBox as visual overflow,
      the container should not clip request repainting rect of the RenderBox.
      
      Test: fast/repaint/change-overflow-and-display-of-relative.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeRectForRepaint):
      * rendering/RenderLayerModelObject.cpp:
      (WebCore::RenderLayerModelObject::shouldUseClipForRepaint): If this has self painting layer, we should not clip for repaint.
      * rendering/RenderLayerModelObject.h:
      
      LayoutTests:
      
      * fast/repaint/change-overflow-and-display-of-relative-expected.txt: Added.
      * fast/repaint/change-overflow-and-display-of-relative.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1da5939
    • commit-queue@webkit.org's avatar
      [CSS Background Blending] Gradients don't blend with any of the layers behind. · 25c87cfe
      commit-queue@webkit.org authored
      First, allow the layers behind opaque gradients to be drawn, then add the blending filters
      when working with gradients.
      
      Source/WebCore:
      
      https://bugs.webkit.org/show_bug.cgi?id=117532
      
      Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
      Reviewed by Dirk Schulze.
      
      Tests: css3/compositing/background-blend-mode-gradient-color.html
             css3/compositing/background-blend-mode-gradient-gradient.html
             css3/compositing/background-blend-mode-gradient-image.html
             css3/compositing/background-blend-mode-multiple-background-layers.html
      
      * platform/graphics/GeneratorGeneratedImage.cpp:
      (WebCore::GeneratorGeneratedImage::draw):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::paintFillLayers):
      
      LayoutTests:
      
      https://bugs.webkit.org/show_bug.cgi?id=117532
      Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
      Reviewed by Dirk Schulze.
      
      * css3/compositing/background-blend-mode-gradient-color-expected.txt: Added.
      * css3/compositing/background-blend-mode-gradient-color.html: Added.
      * css3/compositing/background-blend-mode-gradient-gradient-expected.txt: Added.
      * css3/compositing/background-blend-mode-gradient-gradient.html: Added.
      * css3/compositing/background-blend-mode-gradient-image-expected.txt: Added.
      * css3/compositing/background-blend-mode-gradient-image.html: Added.
      * css3/compositing/background-blend-mode-multiple-background-layers-expected.txt: Added.
      * css3/compositing/background-blend-mode-multiple-background-layers.html: Added.
      * platform/mac/css3/compositing/background-blend-mode-gradient-color-expected.png: Added.
      * platform/mac/css3/compositing/background-blend-mode-gradient-gradient-expected.png: Added.
      * platform/mac/css3/compositing/background-blend-mode-gradient-image-expected.png: Added.
      * platform/mac/css3/compositing/background-blend-mode-multiple-background-layers-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25c87cfe
    • michael.bruning@digia.com's avatar
      [Qt][Mac] Disable QTKit video on OS X. · ca67018b
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117591
      
      Reviewed by Tor Arne Vestbø.
      
      Source/WebCore:
      
      Deployment of the same Qt binaries to different
      Mac OS X version makes it impossible to link against
      the correct WebKitSystemInterface version at build time.
      
      No new tests, no behavioural change.
      
      * WebCore.pri:
      
      Tools:
      
      Deployment of Qt binaries to different Mac OS X
      platform version makes it impossible to link against
      the correct version of the WebKitSystemInterface library,
      so we need to disable QTKit for media elements.
      
      * qmake/mkspecs/features/features.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca67018b
    • commit-queue@webkit.org's avatar
      Column balancing support in the region based multicol implementation · 2a7d9989
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116033
      
      Source/WebCore:
      
      Start by setting the column height to the flow thread's height divided
      by the number of columns. Then stretch the column height until
      contents fits without creating overflowing columns, or until the
      maximum allowed column height is reached, whichever comes first. This
      may require several layout iterations (but normally only a
      couple). For each time we stretch, stretch by the least amount
      required to make a difference to which box goes where.
      
      Also make sure that the columns get tall enough to honor orphans
      and widows settings.
      
      This change takes some tiny steps in preparing for multiple column
      set support. There is also some minor cleanup and bugfixing; see
      details below.
      
      Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13
      Reviewed by David Hyatt.
      
      Tests: fast/multicol/newmulticol/balance-images.html
             fast/multicol/newmulticol/balance-maxheight1.html
             fast/multicol/newmulticol/balance-maxheight2.html
             fast/multicol/newmulticol/balance1.html
             fast/multicol/newmulticol/balance2.html
             fast/multicol/newmulticol/balance3.html
             fast/multicol/newmulticol/balance4.html
             fast/multicol/newmulticol/balance5.html
             fast/multicol/newmulticol/balance6.html
             fast/multicol/newmulticol/balance7.html
             fast/multicol/newmulticol/balance8.html
             fast/multicol/newmulticol/balance9.html
             fast/multicol/newmulticol/cell-shrinkback.html
             fast/multicol/newmulticol/columns-shorthand-parsing.html
             fast/multicol/newmulticol/orphans-and-widows-balance.html
             fast/multicol/newmulticol/single-line.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::adjustForUnsplittableChild):
      (WebCore::RenderBlock::setPageBreak):
      (WebCore):
      (WebCore::RenderBlock::updateMinimumPageHeight):
      (WebCore::calculateMinimumPageHeight):
      (WebCore::RenderBlock::adjustLinePositionForPagination):
      (WebCore::RenderBlock::adjustBlockChildForPagination): If no lines
      cross the boundaries, we need to report where blocks cross
      instead, so that the column balancer knows how much to stretch
      columns if necessary.
      * rendering/RenderBlock.h:
      * rendering/RenderFlowThread.h:
      * rendering/RenderMultiColumnBlock.cpp:
      (WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
      (WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
      (WebCore::RenderMultiColumnBlock::relayoutForPagination):
      (WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
      * rendering/RenderMultiColumnBlock.h:
      (WebCore::RenderMultiColumnBlock::columnHeightAvailable):
      (WebCore::RenderMultiColumnBlock::requiresBalancing):
      (RenderMultiColumnBlock):
      * rendering/RenderMultiColumnFlowThread.cpp:
      (WebCore::RenderMultiColumnFlowThread::autoGenerateRegionsToBlockOffset):
      (WebCore::RenderMultiColumnFlowThread::setPageBreak):
      (WebCore):
      (WebCore::RenderMultiColumnFlowThread::updateMinimumPageHeight):
      * rendering/RenderMultiColumnFlowThread.h:
      (RenderMultiColumnFlowThread):
      * rendering/RenderMultiColumnSet.cpp: Get rid of
      RenderMultiColumnSet::updateLogicalHeight() override. Make
      RenderMultiColumnSet behave more like normal blocks, by having
      computeLogicalHeight() calculate logical top in addition to
      height, just like any other block.
      (WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
      (WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset): This
      method will become more meaningful once we add support for
      multiple column sets.
      (WebCore):
      (WebCore::RenderMultiColumnSet::pageLogicalTopForOffset):
      (WebCore::RenderMultiColumnSet::setAndConstrainColumnHeight):
      (WebCore::RenderMultiColumnSet::calculateBalancedHeight):
      (WebCore::RenderMultiColumnSet::recordSpaceShortage):
      (WebCore::RenderMultiColumnSet::updateLogicalWidth):
      (WebCore::RenderMultiColumnSet::prepareForLayout):
      (WebCore::RenderMultiColumnSet::computeLogicalHeight):
      (WebCore::RenderMultiColumnSet::columnCount):
      (WebCore::RenderMultiColumnSet::columnIndexAtOffset):
      repaintFlowThreadContent() could end up in an infinite loop
      because columnIndexAtOffset() could return UINT_MAX
      (subtracting 1 from unsigned 0, which columnCount() could return),
      which an unsigned integer obviously can never become larger
      than. Also always call columnIndexAtOffset() if we want to get the
      column index for some offset, rather than doing it on our own
      sometimes. To make this work also during layout, we cannot just
      return the last column created so far if we're past it, since
      adding new columns is exactly what we want to do at this point.
      * rendering/RenderMultiColumnSet.h:
      (RenderMultiColumnSet):
      
      LayoutTests:
      
      Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13
      Reviewed by David Hyatt.
      
      * fast/multicol/newmulticol/balance-images-expected.txt: Added.
      * fast/multicol/newmulticol/balance-images.html: Added.
      * fast/multicol/newmulticol/balance-maxheight1-expected.txt: Added.
      * fast/multicol/newmulticol/balance-maxheight1.html: Added.
      * fast/multicol/newmulticol/balance-maxheight2-expected.txt: Added.
      * fast/multicol/newmulticol/balance-maxheight2.html: Added.
      * fast/multicol/newmulticol/balance1-expected.txt: Added.
      * fast/multicol/newmulticol/balance1.html: Added.
      * fast/multicol/newmulticol/balance2-expected.txt: Added.
      * fast/multicol/newmulticol/balance2.html: Added.
      * fast/multicol/newmulticol/balance3-expected.txt: Added.
      * fast/multicol/newmulticol/balance3.html: Added.
      * fast/multicol/newmulticol/balance4-expected.txt: Added.
      * fast/multicol/newmulticol/balance4.html: Added.
      * fast/multicol/newmulticol/balance5-expected.txt: Added.
      * fast/multicol/newmulticol/balance5.html: Added.
      * fast/multicol/newmulticol/balance6-expected.txt: Added.
      * fast/multicol/newmulticol/balance6.html: Added.
      * fast/multicol/newmulticol/balance7-expected.txt: Added.
      * fast/multicol/newmulticol/balance7.html: Added.
      * fast/multicol/newmulticol/balance8-expected.txt: Added.
      * fast/multicol/newmulticol/balance8.html: Added.
      * fast/multicol/newmulticol/balance9-expected.txt: Added.
      * fast/multicol/newmulticol/balance9.html: Added.
      * fast/multicol/newmulticol/cell-shrinkback-expected.html: Added.
      * fast/multicol/newmulticol/cell-shrinkback.html: Added.
      * fast/multicol/newmulticol/columns-shorthand-parsing-expected.html: Added.
      * fast/multicol/newmulticol/columns-shorthand-parsing.html: Added.
      * fast/multicol/newmulticol/orphans-and-widows-balance-expected.txt: Added.
      * fast/multicol/newmulticol/orphans-and-widows-balance.html: Added.
      * fast/multicol/newmulticol/single-line-expected.html: Added.
      * fast/multicol/newmulticol/single-line.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a7d9989
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Unskipping passing test and move to the right place. · 14ef2dbe
      zarvai@inf.u-szeged.hu authored
      Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-13
      
      * platform/qt-5.0-wk2/TestExpectations:
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14ef2dbe
    • ossy@webkit.org's avatar
      [ARM] Unreviewed gardening, skip one more test to paint the bot green. · dffe4aa9
      ossy@webkit.org authored
      * platform/qt-arm/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dffe4aa9
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 8c46432b
      zandobersek@gmail.com authored
      Adding failure expectations for most of the current failures.
      
      * platform/gtk-wk1/TestExpectations:
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c46432b
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied · 50e00eea
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116610
      
      Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-06-13
      Reviewed by Noam Rosenthal.
      
      Source/WebKit2:
      
      WebKit2 EFL uses fixed layout - because of this ScrollView::contentsToWindow, does
      not take scroll into account, as it is meant to be handled by UI application.
      When popup and context menu are created, after calling contentsToWindow their position
      are not adjusted to page scroll.
      Added two functions to EwkView and WKView, converting contents position to user viewport
      coordinates, to adjust popup and context menu positions.
      
      * UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
      (WKViewContentsToUserViewport):
      * UIProcess/API/C/CoordinatedGraphics/WKView.h:
      * UIProcess/API/efl/EwkView.cpp:
      (EwkView::showContextMenu):
      (EwkView::requestPopupMenu):
      * UIProcess/CoordinatedGraphics/WebView.cpp:
      (WebKit::WebView::contentsToUserViewport):
      * UIProcess/CoordinatedGraphics/WebView.h:
      
      Tools:
      
      Remove unnecessary code adjusting context menu position to webview position.
      Now position is calculcated in EwkView.
      
      * MiniBrowser/efl/main.c:
      (on_context_menu_show):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50e00eea
    • ryuan.choi@samsung.com's avatar
      [EFL] Refactor ewk_view_scroll to remove internal structure. · 00f5f457
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115713
      
      Reviewed by Gyuyoung Kim.
      
      After removed c-ism from WebKit/Efl, There is no reason to keep internal
      structures like Ewk_Scroll_Request.
      This patch refactored ewk_view_scroll to use WTF instead of Ewk_Scroll_Request
      and scrolls of SmartData.
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::scroll):
      * ewk/ewk_view.cpp: Removed functions to manage Ewk_Scroll_Request.
      (_Ewk_View_Private_Data):
      (_ewk_view_scrolls_flush):
      (_ewk_view_priv_del):
      (_ewk_view_smart_calculate):
      (ewk_view_scroll_offsets_get):
      (ewk_view_scroll_rects_get):
      (ewk_view_scroll):
      * ewk/ewk_view.h: Removed Ewk_Scroll_Request which is private structure.
      * ewk/ewk_view_private.h:
      (WebCore):
      * ewk/ewk_view_single.cpp:
      (_ewk_view_single_scroll_process_single):
      (_ewk_view_single_smart_scrolls_process):
      * ewk/ewk_view_tiled.cpp:
      (_ewk_view_tiled_smart_scrolls_process):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00f5f457
    • lforschler@apple.com's avatar
      Versioning. · 8dce1eb0
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dce1eb0
    • ossy@webkit.org's avatar
      [ARM] Unreviewed gardening, skip one more test to paint the bot green. · c0fac7e0
      ossy@webkit.org authored
      * platform/qt-arm/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0fac7e0
  2. 12 Jun, 2013 27 commits
    • bfulgham@apple.com's avatar
      [WinCairo] Unreviewed build correction. · 0f82e4ff
      bfulgham@apple.com authored
      * win/tools32/vsprops/WinCairo.props: Switch from using the
        $WebKitLibraries environment variable to the newer
        $WebKit_Libraries.
      * win/tools32/vsprops/debug_wincairo.props: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f82e4ff
    • roger_fong@apple.com's avatar
      Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests. · 80d76b21
      roger_fong@apple.com authored
      * Scripts/webkitpy/common/config/ews.json:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80d76b21
    • roger_fong@apple.com's avatar
      Update webkit.org build instructions for Apple Windows port. · ea23feb4
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117563.
      
      Reviewed by Brent Fulgham.
      
      * building/build.html:
      * building/debug.html:
      * building/launch-debugger-vs2005.png: Removed.
      * building/launch-debugger-vs2010.png: Copied from webkit.org/building/launch-debugger-vs2005.png.
      * building/set-as-startup-project-vs2005.png: Removed.
      * building/set-as-startup-project-vs2010.png: Copied from webkit.org/building/set-as-startup-project-vs2005.png.
      * building/set-debugging-properties-vs2005.png: Removed.
      * building/set-debugging-properties-vs2010.png: Copied from webkit.org/building/set-debugging-properties-vs2005.png.
      * building/tools.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea23feb4
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed. EFL Gardening. Needs to add new baseline for some tests, which are passing on EFL bots. · 541a488c
      gyuyoung.kim@samsung.com authored
      * platform/efl-wk1/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/efl/editing/selection/3690703-2-expected.png: Added.
      * platform/efl/editing/selection/3690703-2-expected.txt: Added.
      * platform/efl/editing/selection/3690703-expected.png: Added.
      * platform/efl/editing/selection/3690703-expected.txt: Added.
      * platform/efl/editing/selection/3690719-expected.png: Added.
      * platform/efl/editing/selection/3690719-expected.txt: Added.
      * platform/efl/editing/selection/4397952-expected.png: Added.
      * platform/efl/editing/selection/4397952-expected.txt: Added.
      * platform/efl/editing/selection/4895428-3-expected.png: Added.
      * platform/efl/editing/selection/4895428-3-expected.txt: Added.
      * platform/efl/editing/selection/4975120-expected.png: Added.
      * platform/efl/editing/selection/4975120-expected.txt: Added.
      * platform/efl/editing/selection/5007143-2-expected.png: Added.
      * platform/efl/editing/selection/5007143-2-expected.txt: Added.
      * platform/efl/editing/selection/5007143-expected.png: Added.
      * platform/efl/editing/selection/5007143-expected.txt: Added.
      * platform/efl/editing/selection/5057506-expected.png: Added.
      * platform/efl/editing/selection/5057506-expected.txt: Added.
      * platform/efl/editing/selection/5195166-1-expected.txt: Added.
      * platform/efl/editing/selection/7152-2-expected.png: Added.
      * platform/efl/editing/selection/7152-2-expected.txt: Added.
      * platform/efl/editing/selection/caret-before-select-expected.png: Added.
      * platform/efl/editing/selection/caret-before-select-expected.txt: Added.
      * platform/efl/editing/selection/caret-ltr-right-expected.png: Added.
      * platform/efl/editing/selection/caret-ltr-right-expected.txt: Added.
      * platform/efl/editing/selection/caret-rtl-2-left-expected.png: Added.
      * platform/efl/editing/selection/caret-rtl-2-left-expected.txt: Added.
      * platform/efl/editing/selection/caret-rtl-right-expected.png: Added.
      * platform/efl/editing/selection/caret-rtl-right-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      541a488c
    • bfulgham@apple.com's avatar
      Remove irrelevant blog from Planet WebKit. · 802a161f
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117572
      
      Reviewed by Mark Rowe.
      
      * config.ini: Remove Chromium blog from planet.webkit.org
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      802a161f
    • bfulgham@apple.com's avatar
      [Windows] Activate supported C++11 Features for VS2010 · ab565981
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117569
      
      Reviewed by Anders Carlsson.
      
      * wtf/Compiler.h: Turn on rvalue references and static_assert
      when compiling with VS2010 (or newer)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab565981
    • andersca@apple.com's avatar
      Remove the notion of inactive plug-ins · 3acc4d1d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117570
      <rdar://problem/13484213>
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      Remove RenderEmbeddedObject::PluginInactive and the replacement text.
      
      * English.lproj/Localizable.strings:
      * platform/LocalizedStrings.cpp:
      * platform/LocalizedStrings.h:
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::unavailablePluginReplacementText):
      * rendering/RenderEmbeddedObject.h:
      
      Source/WebKit/mac:
      
      Remove code that deals with inactive plug-ins.
      
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::shouldUnavailablePluginMessageBeButton):
      (WebChromeClient::unavailablePluginButtonClicked):
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::createPlugin):
      
      Source/WebKit2:
      
      Remove code that deals with inactive plug-ins. We still keep around the kWKPluginLoadPolicyInactive API enum for now.
      
      * Shared/Plugins/PluginModuleInfo.h:
      * UIProcess/API/C/WKAPICast.h:
      (WebKit::toWKPluginLoadPolicy):
      (WebKit::toPluginModuleLoadPolicy):
      * UIProcess/Plugins/PluginInfoStore.cpp:
      * UIProcess/Plugins/PluginInfoStore.h:
      * UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
      (WebKit::PluginInfoStore::shouldUsePlugin):
      (WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::findPlugin):
      (WebKit::WebPageProxy::unavailablePluginButtonClicked):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
      (WebKit::WebChromeClient::unavailablePluginButtonClicked):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3acc4d1d
    • bfulgham@apple.com's avatar
      [Windows] Implement Accessibility2 APIs in Windows. · 8096265c
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117561
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit: 
      
      * WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Add new IAccessible2 IDL files.
      * WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Ditto.
      * WebKit.vcxproj/Interfaces/InterfacesCommon.props: Reference new Accessible2 folder.
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Build IAccessible2 symbols.
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Ditto.
      
      Source/WebKit/win: 
      
      * AccessibleBase.cpp: Add stubs for IAccessible2 interface, replace attributeValue
      method with get_attribute from IAccessible2 API.
      * AccessibleBase.h: Ditto.
      * AccessibleDocument.cpp: Revise signatures for IAccessible2.
      * AccessibleDocument.h: Ditto.
      * AccessibleImage.cpp: Revise signatures for IAccessible2.
      * AccessibleImage.h: Ditto.
      * Interfaces/Accessible2: Added.
      * Interfaces/Accessible2/Accessible2.idl: Added.
      * Interfaces/Accessible2/Accessible2_2.idl: Added.
      * Interfaces...
      8096265c
    • dino@apple.com's avatar
      [Mac] Change default Traditional Chinese serif font on 10.9 · 668b6ed2
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117568
      
      Reviewed by Alexey Proskuryakov.
      
      Change default font on newer versions of OS X.
      
      * page/mac/SettingsMac.mm:
      (WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti TC'
      on 10.9 and above.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      668b6ed2
    • hugo.lima@openbossa.org's avatar
      [GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used. · 23ee895e
      hugo.lima@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117564
      
      Reviewed by Martin Robinson.
      
      * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23ee895e
    • dino@apple.com's avatar
      [Mac] Change default Simplified Chinese serif font on 10.9 · fff53825
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117567
      
      Reviewed by Alexey Proskuryakov.
      
      Change default font on newer versions of OS X.
      
      * page/mac/SettingsMac.mm:
      (WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti SC'
      instead of 'STSong' on newer systems.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fff53825
    • gyuyoung.kim@samsung.com's avatar
      Fix crashes due to failed ImageBuffer allocation · 66a95b96
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117541
      
      Reviewed by Andreas Kling.
      
      From Blink r152268 by <pdr@chromium.org>
      
      A crash can happen due to a failed ImageBuffer allocation in
      SVGImage::drawPatternForContainer(). Added a check for that failed allocation.
      
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::drawPatternForContainer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66a95b96
    • commit-queue@webkit.org's avatar
      [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree · 120f565e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115647
      
      Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-12
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Override the get_object_locale() method of WebkitAccessibleWrapperAtk's internal
      AtkObject, to include custom implementations for AtkDocument and AtkText objects,
      taking the logic as-is from AtkDocument::get_document_locale() and DumpRenderTree's
      AccessibilityUIElementAtk::language(), respectively.
      
      Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
      method.
      
      No new functionality, no new tests.
      
      * accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
      (webkitAccessibleDocumentInterfaceInit): Chains implementation of
      AtkDocument::get_document_locale() to AtkObject::get_object_locale().
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      (webkitAccessibleGetObjectLocale): Add implementation of locale resolution for
      objects of type AtkDocument and AtkText.
      (webkitAccessibleClassInit): Override AtkObject::get_object_locale() method.
      
      Tools:
      
      Locale resolution is moved to WebKitAccessibleWrapperAtk using
      AtkObject::get_object_locale() API. Now, implementation of
      AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
      be leveraged to get_object_locale() of AtkObject.
      
      Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
      method.
      
      No new functionality, no new tests.
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (AccessibilityUIElement::language): Leverage locale resolution to
      AtkObject::get_object_locale().
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::AccessibilityUIElement::language): Leverage locale resolution to
      AtkObject::get_object_locale().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      120f565e
    • hugo.lima@openbossa.org's avatar
      Remove last bits of GYP from build-webkit and update-webkit scripts · 6fbadb36
      hugo.lima@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117557
      
      Reviewed by Ryosuke Niwa.
      
      * Scripts/build-webkit:
      * Scripts/update-webkit:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fbadb36
    • zandobersek@gmail.com's avatar
      [GTK] Move more build targets for source code that's free of layer violations into libPlatform · 60be53da
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115936
      
      Reviewed by Martin Robinson.
      
      Source/Platform: 
      
      * GNUmakefile.am: Add additional Source/WebCore/platform subdirectories to the list of the directories
      that are specific to the platform layer but still located in WebCore. Add Enchant and Freetype dependencies'
      CFLAGS to the list of libPlatform CPPFLAGS. Add GStreamer dependency's CFLAGS to the list of libPlatformGtk
      CPPFLAGS.
      
      Source/WebCore: 
      
      No new tests - no new functionality.
      
      * GNUmakefile.list.am: Move more build targets under the platform_sources and platformgtk_sources listing.
      These build targets represent source files that are already free of platform layer violations and are as such
      ready to be pushed down from the WebCore layer into the Platform layer.
      
      Source/WebKit2: 
      
      * GNUmakefile.am: Add GStreamer dependency's CFLAGS to the list of libPlatformGtk2 CPPFLAGS.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60be53da
    • hugo.lima@openbossa.org's avatar
      Remove forgotten unused Tools/Script/make-gypi script · 3bf132b7
      hugo.lima@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117558
      
      Reviewed by Ryosuke Niwa.
      
      This script isn't used since the GYP removal from WebKit.
      
      * Scripts/make-gypi: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bf132b7
    • commit-queue@webkit.org's avatar
      "Open Video in New Window" doesn't make sense in fullscreen · 05cdf156
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117556
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      No new tests needed.
      
      * WebCore.exp.in: Added WebKit2 hook for mediaIsInFullscreen() method.
      
      Source/WebKit2:
      
      Adds method mediaIsInFullscreen() that checks if a media element is in
      fullscreen mode, which is needed to decide when to display the
      "Open Video in New Window" context menu item.
      
      * WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
      (WKBundleHitTestResultMediaIsInFullscreen): Added.
      Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method.
      * WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
      * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
      (WebKit::InjectedBundleHitTestResult::mediaIsInFullscreen): Added.
      Checks if media element is in fullscreen.
      * WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05cdf156
    • rniwa@webkit.org's avatar
      Accessibility code assumes an area element's parent is a map element · f902007d
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117496
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore: 
      
      We can't make such an assumption. Scripts can insert any element between area and map elements.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.
      
      Test: accessibility/image-map-with-indirect-area-crash.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
      
      LayoutTests: 
      
      Add a regression test from https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.
      
      * accessibility/image-map-with-indirect-area-crash-expected.txt: Added.
      * accessibility/image-map-with-indirect-area-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f902007d
    • robert@webkit.org's avatar
      Source/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit... · c522345e
      robert@webkit.org authored
      Source/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit parent gets a line-break when it shouldn't
      https://bugs.webkit.org/show_bug.cgi?id=117370
      
      Reviewed by David Hyatt.
      
      Test: fast/text/whitespace/inline-whitespace-wrapping-8.html
      
      A no-wrap inline shouldn't include trailing space when deciding whether it fits on a line.
      Likewise when we finish iterating through the objects on a line we should clear our linebreak
      if the only thing that prevents us fitting on the line is our collapsed trailing whitespace.
      
      Removing the trailing space from this measurement means we need to watch out for potential
      breaks between no-wrap inlines, in particular if we leave a no-wrap inline ignoring spaces
      and enter an autowrap inline then we need to mark the beginning of the autowrap inline
      as a potential linebreak. The test fast/text/whitespace/inline-whitespace-wrapping-5.html
      is an example of such a case.
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::LineWidth::LineWidth):
      (WebCore::LineWidth::fitsOnLine):
      (WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
      (WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
      (WebCore::LineWidth::setTrailingWhitespaceWidth):
      (WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
      
      LayoutTests: Whitespace between inlines with nowrap and a shrink-to-fit parent line-break incorrectly
      https://bugs.webkit.org/show_bug.cgi?id=117370
      
      Reviewed by David Hyatt.
      
      * fast/text/whitespace/inline-whitespace-wrapping-8-expected.html: Added.
      * fast/text/whitespace/inline-whitespace-wrapping-8.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c522345e
    • commit-queue@webkit.org's avatar
      [CSS Shapes] rectangle and inset-rectangle do not properly handle rx and ry · ebbe06f8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116745
      
      Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-06-12
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      If ry is not supplied, it now defaults to the rx value. Also, if rx
      and ry are not supplied, they default to 0px. This also has the effect
      that the computed style for any rectangle or inset-rectangle now
      contains all six parameters.
      
      If rx > width/2 then it is clamped to width/2, and if ry > height/2,
      then it is clamped to height/2. This happens at layout time because
      given mixed units and relative units, that is the only time this
      determination can be made.
      
      Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html
             fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html
      
      * css/BasicShapeFunctions.cpp:
      (WebCore::valueForBasicShape): Remove checks for undefined, since rx
          and ry cannot be undefined in BasicShapes anymore.
      (WebCore::basicShapeForValue): If radii are undefined in CSS, set
          default values in the BasicShape, per the spec.
      * rendering/ExclusionShape.cpp:
      (WebCore::ensureRadiiDoNotOverlap): Utility method to ensure radii
          don't overlap.
      (WebCore::ExclusionShape::createExclusionShape): Remove defaulting to
          zero, clamp radii per the spec.
      * rendering/style/BasicShapes.cpp:
      (WebCore::BasicShapeRectangle::path): Remove defaulting.
      (WebCore::BasicShapeRectangle::blend): Ditto.
      (WebCore::BasicShapeInsetRectangle::path): Ditto.
      (WebCore::BasicShapeInsetRectangle::blend): Ditto.
      * rendering/style/BasicShapes.h:
      (WebCore::BasicShapeRectangle::BasicShapeRectangle): Remove defaulting
          to undefined for radii.
      (WebCore::BasicShapeRectangle::setCornerRadiusX): Add assert to
          prevent undefined.
             (WebCore::BasicShapeRectangle::setCornerRadiusY): Add assert to
          prevent undefined.
      (WebCore::BasicShapeInsetRectangle::BasicShapeInsetRectangle): Ditto.
      (WebCore::BasicShapeInsetRectangle::setCornerRadiusX): Add assert to
          prevent undefined.
             (WebCore::BasicShapeInsetRectangle::setCornerRadiusY): Add assert to
          prevent undefined.
      
      LayoutTests:
      
      Update tests to check for the rx and ry conditions.
      
      * fast/exclusions/parsing/parsing-shape-inside-expected.txt: New results.
      * fast/exclusions/parsing/parsing-shape-outside-expected.txt: New results.
      * fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Update
          to reflect that the computed value now always has rx and ry.
      * fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Ditto.
      * fast/exclusions/parsing/script-tests/parsing-test-utils.js: Ditto.
      * fast/exclusions/resources/rounded-rectangle.js:
      (genLeftRightRoundedRectFloatShapeOutsideRefTest): Factor out left and
          right into separate methods so that they can be used in tests that
          only have left floats or only right floats.
      (genLeftRoundedRectFloatShapeOutsideRefTest): Ditto.
      (genRightRoundedRectFloatShapeOutsideRefTest): Ditto.
      * fast/exclusions/shape-inside/shape-inside-animation-expected.txt: New results.
      * fast/exclusions/shape-inside/shape-inside-animation.html: Change to
          reflect new computed style value.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Added.
      * fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius-expected.html: Added.
      * fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html: Added.
          Note that the expected test here uses shape-inside, because we
          really are just testing that the behavior is the same as a
          shape-inside with rx and ry set to 50%, and it turned out to be
          very hard to construct an expected result that didn't use
          shape-inside and wasn't off by a pixel.
      * css3/masking/clip-path-animation.html: Update expected value.
      * css3/masking/clip-path-animation-expected.txt: New results.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebbe06f8
    • bfulgham@apple.com's avatar
      [Windows] Support Title UI Element Accessibility Attribute · 1b60f890
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117530
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Fixes: accessibility/list-item-role.html
             accessibility/hidden-legend.html
      
      * accessibility/win/AccessibilityObjectWrapperWin.cpp:
      (WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Extend to support access
      for the Title UI Element object.
      * accessibility/win/AccessibilityObjectWrapperWin.h: Revise interface to use Variant output,
      which is more in keeping with the Mac's 'id' method signature.
      
      Source/WebKit/win: 
      
      * AccessibleBase.cpp:
      (AccessibleBase::attributeValue): Extend to handle Title UI Element.
      * AccessibleBase.h: Revise signature to use a variant argument.
      * Interfaces/AccessibleComparable.idl:  Revise interface to use variant
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b60f890
    • timothy@apple.com's avatar
      Add new Web Inspector images for a blog post. · c2134315
      timothy@apple.com authored
      * blog-files/new-inspector/activity-viewer.png: Added.
      * blog-files/new-inspector/codemirror.png: Added.
      * blog-files/new-inspector/console.png: Added.
      * blog-files/new-inspector/hero-labeled.png: Added.
      * blog-files/new-inspector/hero.png: Added.
      * blog-files/new-inspector/layer-borders.png: Added.
      * blog-files/new-inspector/layers.png: Added.
      * blog-files/new-inspector/navigation-bar.png: Added.
      * blog-files/new-inspector/open-sign.png: Added.
      * blog-files/new-inspector/reasons.png: Added.
      * blog-files/new-inspector/save.png: Added.
      * blog-files/new-inspector/source-map.png: Added.
      * blog-files/new-inspector/styles.png: Added.
      * blog-files/new-inspector/toolbar-context-menu.png: Added.
      * blog-files/new-inspector/toolbar-docked.png: Added.
      * blog-files/new-inspector/toolbar.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2134315
    • leoyang@rim.com's avatar
      [BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData · f7286af0
      leoyang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117553
      
      Reviewed by Carlos Garcia Campos.
      
      In CredentialTransformData we should use RefPtr for
      m_userNameElement, m_passwordElement and m_oldPasswordElement
      because otherwise the elements could go away when the form
      elements get destroyed.
      
      Also add *const* for the parameter of CredentialTransformData::findPasswordFormFields().
      
      No functionalities changed no new tests.
      
      * WebCoreSupport/CredentialTransformData.cpp:
      (WebCore::CredentialTransformData::findPasswordFormFields):
      (WebCore::CredentialTransformData::locateSpecificPasswords):
      * WebCoreSupport/CredentialTransformData.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7286af0
    • commit-queue@webkit.org's avatar
      [CSS Shaders] Animations and transitions should use validated custom programs · 028b821a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117550
      
      Run filters used for animations and transitions through RenderLayer::computeFilterOperations
      in order to validate custom filter operations.
      
      Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-12
      Reviewed by Alexandru Chiculita.
      
      No new tests as no platform can run custom filters with accelerated animations yet.
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::startAnimation):
      (WebCore::RenderLayerBacking::startTransition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      028b821a
    • commit-queue@webkit.org's avatar
      Allow for toggling fullscreen on <video> elements · 0f4ee83b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117220
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      This patch adds the ability for fullscreen
      context menu item on <video> elements to switch between "Enter Fullscreen"
      and "Exit Fullscreen" and behave appropriately.
      
      No new tests. media/context-menu-action.html,
      which has been disabled by bug 116651, is used to test context menus.
      
      * English.lproj/Localizable.strings: Add "Exit Fullscreen" string.
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::toggleFullscreenState): Added to appropriately enter/exit fullscreen.
      * html/HTMLMediaElement.h:
      * page/ContextMenuController.cpp:
      * platform/ContextMenuItem.h:
      * platform/LocalizedStrings.cpp:
      * platform/LocalizedStrings.h:
      Updated to rename variables more appropriately to reflect the toggle-ability of video fullscreen.
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::mediaIsInFullscreen): Added to check if an element
      was a media element in fullscreen.
      (WebCore::HitTestResult::toggleMediaFullscreenState): Added to hook into
      HTMLMediaElement::toggleFullscreenState.
      * rendering/HitTestResult.h:
      
      Source/WebKit2:
      
      * Shared/API/c/WKContextMenuItemTypes.h:
      * Shared/API/c/WKSharedAPICast.h:
      Added variables to support the toggle-ability of the fullscreen
      video context menu item.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f4ee83b
    • ossy@webkit.org's avatar
      [ARM] Unreviewed gardening, unskip now passing tests and try to paint the bot green. · 24c0bd0a
      ossy@webkit.org authored
      * platform/qt-arm/TestExpectations:
      * platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
      * platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
      * platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24c0bd0a
    • sergio@webkit.org's avatar
      Skipping {}, () and [] blocks while error recovering in CSS · 8828148a
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116071
      
      Reviewed by Darin Adler.
      
      From Blink r150201 and r150755 by <serya@chromium.org>
      
      Source/WebCore:
      
      Test: fast/css/parsing-expr-error-recovery.html
      
      The CSS parser should properly recover from invalid {}, () and []
      blocks skipping them instead of discarding the whole declaration
      as invalid. This merge is actually made of two different changes
      from Blink, the original one that fixes the bug and another one
      which refactors a bit the code making it more legible.
      
      * css/CSSGrammar.y.in:
      
      LayoutTests:
      
      * fast/css/parsing-expr-error-recovery-expected.txt: Added.
      * fast/css/parsing-expr-error-recovery.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8828148a