1. 19 Nov, 2006 5 commits
  2. 18 Nov, 2006 14 commits
    • rwlbuis's avatar
      LayoutTests: · 8f4e862d
      rwlbuis authored
              Reviewed by Maciej.
      
              Testcase for:
              http://bugs.webkit.org/show_bug.cgi?id=11321
              Element with :target pseudo-class still matched after fragment identifier change
      
              * fast/css/target-fragment-match-expected.checksum: Added.
              * fast/css/target-fragment-match-expected.png: Added.
              * fast/css/target-fragment-match-expected.txt: Added.
              * fast/css/target-fragment-match.html: Added.
      
      WebCore:
              Reviewed by Maciej.
      
              http://bugs.webkit.org/show_bug.cgi?id=11321
              Element with :target pseudo-class still matched after fragment identifier change
      
              Make sure the page does a style recalculation and possible rendering
              when navigating back from a page with an anchor to a page without
              an anchor.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::gotoAnchor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f4e862d
    • ap's avatar
      2006-11-18 Don Gibson <dgibson77@gmail.com> · b2127b75
      ap authored
              Reviewed by Sam Weinig.
      
              http://bugs.webkit.org/show_bug.cgi?id=11634:
              Fix segfault on startup for Windows build.  Also fix segfault when
              typing in a URL.
              Clean up some of the style of the patch that landed in r17816.
      
      WebCore:
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * bridge/win/ChromeClientWin.h:
              (WebCore::ChromeClientWin::~ChromeClientWin):
              (WebCore::ChromeClientWin::ref):
              (WebCore::ChromeClientWin::deref):
              * bridge/win/ContextMenuClientWin.h:
              (WebCore::ContextMenuClientWin::~ContextMenuClientWin):
              (WebCore::ContextMenuClientWin::ref):
              (WebCore::ContextMenuClientWin::deref):
              * bridge/win/EditorClientWin.h:
              (WebCore::EditorClientWin::~EditorClientWin):
              (WebCore::EditorClientWin::ref):
              (WebCore::EditorClientWin::deref):
              * bridge/win/FrameWin.cpp:
              (WebCore::FrameWin::FrameWin):
              * bridge/win/FrameWin.h:
              (WebCore::Win):
              * loader/win/FrameLoaderClientWin.h: Added.
              (WebCore::FrameLoaderClientWin::~FrameLoaderClientWin):
              (WebCore::FrameLoaderClientWin::ref):
              (WebCore::FrameLoaderClientWin::deref):
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::ChromeClientWin::createWindow):
              (WebCore::ChromeClientWin::createModalDialog):
              (WebCore::EditorClientWin::selectWordBeforeMenuEvent):
              (WebCore::EditorClientWin::isEditable):
              (WebCore::EditorClientWin::shouldBeginEditing):
              (WebCore::EditorClientWin::shouldEndEditing):
              (WebCore::EditorClientWin::shouldApplyStyle):
              (WebCore::EditorClientWin::didBeginEditing):
              (WebCore::EditorClientWin::respondToChangedContents):
              (WebCore::EditorClientWin::didEndEditing):
              (WebCore::EditorClientWin::registerCommandForUndo):
              (WebCore::EditorClientWin::registerCommandForRedo):
              (WebCore::EditorClientWin::clearUndoRedoOperations):
              (WebCore::EditorClientWin::canUndo):
              (WebCore::EditorClientWin::canRedo):
              (WebCore::EditorClientWin::undo):
              (WebCore::EditorClientWin::redo):
              (WebCore::FrameLoader::createFrame):
              (WebCore::FrameLoader::createPlugin):
              (WebCore::FrameLoaderClientWin::hasWebView):
              (WebCore::FrameLoaderClientWin::hasFrameView):
              (WebCore::FrameLoaderClientWin::hasBackForwardList):
              (WebCore::FrameLoaderClientWin::resetBackForwardList):
              (WebCore::FrameLoaderClientWin::provisionalItemIsTarget):
              (WebCore::FrameLoaderClientWin::loadProvisionalItemFromPageCache):
              (WebCore::FrameLoaderClientWin::invalidateCurrentItemPageCache):
              (WebCore::FrameLoaderClientWin::privateBrowsingEnabled):
              (WebCore::FrameLoaderClientWin::makeDocumentView):
              (WebCore::FrameLoaderClientWin::makeRepresentation):
              (WebCore::FrameLoaderClientWin::forceLayout):
              (WebCore::FrameLoaderClientWin::forceLayoutForNonHTML):
              (WebCore::FrameLoaderClientWin::updateHistoryForCommit):
              (WebCore::FrameLoaderClientWin::updateHistoryForBackForwardNavigation):
              (WebCore::FrameLoaderClientWin::updateHistoryForReload):
              (WebCore::FrameLoaderClientWin::updateHistoryForStandardLoad):
              (WebCore::FrameLoaderClientWin::updateHistoryForInternalLoad):
              (WebCore::FrameLoaderClientWin::updateHistoryAfterClientRedirect):
              (WebCore::FrameLoaderClientWin::setCopiesOnScroll):
              (WebCore::FrameLoaderClientWin::tokenForLoadErrorReset):
              (WebCore::FrameLoaderClientWin::resetAfterLoadError):
              (WebCore::FrameLoaderClientWin::doNotResetAfterLoadError):
              (WebCore::FrameLoaderClientWin::willCloseDocument):
              (WebCore::FrameLoaderClientWin::detachedFromParent1):
              (WebCore::FrameLoaderClientWin::detachedFromParent2):
              (WebCore::FrameLoaderClientWin::detachedFromParent3):
              (WebCore::FrameLoaderClientWin::detachedFromParent4):
              (WebCore::FrameLoaderClientWin::loadedFromPageCache):
              (WebCore::FrameLoaderClientWin::dispatchDidHandleOnloadEvents):
              (WebCore::FrameLoaderClientWin::dispatchDidReceiveServerRedirectForProvisionalLoad):
              (WebCore::FrameLoaderClientWin::dispatchDidCancelClientRedirect):
              (WebCore::FrameLoaderClientWin::dispatchWillPerformClientRedirect):
              (WebCore::FrameLoaderClientWin::dispatchDidChangeLocationWithinPage):
              (WebCore::FrameLoaderClientWin::dispatchWillClose):
              (WebCore::FrameLoaderClientWin::dispatchDidReceiveIcon):
              (WebCore::FrameLoaderClientWin::dispatchDidStartProvisionalLoad):
              (WebCore::FrameLoaderClientWin::dispatchDidReceiveTitle):
              (WebCore::FrameLoaderClientWin::dispatchDidCommitLoad):
              (WebCore::FrameLoaderClientWin::dispatchDidFinishLoad):
              (WebCore::FrameLoaderClientWin::dispatchDidFirstLayout):
              (WebCore::FrameLoaderClientWin::dispatchShow):
              (WebCore::FrameLoaderClientWin::cancelPolicyCheck):
              (WebCore::FrameLoaderClientWin::dispatchWillSubmitForm):
              (WebCore::FrameLoaderClientWin::dispatchDidLoadMainResource):
              (WebCore::FrameLoaderClientWin::clearLoadingFromPageCache):
              (WebCore::FrameLoaderClientWin::isLoadingFromPageCache):
              (WebCore::FrameLoaderClientWin::revertToProvisionalState):
              (WebCore::FrameLoaderClientWin::clearUnarchivingState):
              (WebCore::FrameLoaderClientWin::progressStarted):
              (WebCore::FrameLoaderClientWin::progressCompleted):
              (WebCore::FrameLoaderClientWin::setMainFrameDocumentReady):
              (WebCore::FrameLoaderClientWin::willChangeTitle):
              (WebCore::FrameLoaderClientWin::didChangeTitle):
              (WebCore::FrameLoaderClientWin::finishedLoading):
              (WebCore::FrameLoaderClientWin::finalSetupForReplace):
              (WebCore::FrameLoaderClientWin::setDefersLoading):
              (WebCore::FrameLoaderClientWin::isArchiveLoadPending):
              (WebCore::FrameLoaderClientWin::cancelPendingArchiveLoad):
              (WebCore::FrameLoaderClientWin::clearArchivedResources):
              (WebCore::FrameLoaderClientWin::canShowMIMEType):
              (WebCore::FrameLoaderClientWin::representationExistsForURLScheme):
              (WebCore::FrameLoaderClientWin::generatedMIMETypeForURLScheme):
              (WebCore::FrameLoaderClientWin::frameLoadCompleted):
              (WebCore::FrameLoaderClientWin::restoreScrollPositionAndViewState):
              (WebCore::FrameLoaderClientWin::provisionalLoadStarted):
              (WebCore::FrameLoaderClientWin::shouldTreatURLAsSameAsCurrent):
              (WebCore::FrameLoaderClientWin::addHistoryItemForFragmentScroll):
              (WebCore::FrameLoaderClientWin::didFinishLoad):
              (WebCore::FrameLoaderClientWin::prepareForDataSourceReplacement):
              (WebCore::FrameLoaderClientWin::setTitle):
              (WebCore::FrameLoaderClientWin::userAgent):
      
      WebKit:
              * COM/WebFrame.cpp:
              (WebFrame::initWithName):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2127b75
    • ap's avatar
      Reviewed by Rob (yay!). · 88d5ca47
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=11640
              XMLHttpRequest produces undefined:undefined HTTP authentication
      
      WebCore:
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
              Treat undefined credentials as missing ones.
      
      LayoutTests:
              * http/tests/xmlhttprequest/basic-auth-expected.txt:
              * http/tests/xmlhttprequest/basic-auth.html:
              Added tests for undefined.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88d5ca47
    • ap's avatar
      2006-11-17 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk> · 3677cb06
      ap authored
              Reviewed by Tim H.
      
              http://bugs.webkit.org/show_bug.cgi?id=11638
              [CSS 2.1+3] add support for alias, progress, no-drop and not-allowed cursor styles
      
              * Resources/aliasCursor.png: Added.
              * Resources/noDropCursor.png: Added.
              * Resources/progressCursor.png: Added.
              * WebCore.xcodeproj/project.pbxproj:
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSValueKeywords.in:
              * manual-tests/cursor.html:
              * page/EventHandler.cpp:
              (WebCore::selectCursor):
              * platform/Cursor.h:
              * platform/mac/CursorMac.mm:
              (WebCore::handCursor):
              (WebCore::aliasCursor):
              (WebCore::progressCursor):
              (WebCore::noDropCursor):
              * rendering/RenderStyle.h:
              (WebCore::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3677cb06
    • ap's avatar
      2006-11-18 Mitz Pettel <mitz@webkit.org> · 05f2a1cb
      ap authored
              Reviewed by Maciej.
      
              Gender-neutrality fix.
      
              * coding/contributing.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05f2a1cb
    • sfalken's avatar
      2006-11-18 Steve Falkenburg <sfalken@apple.com> · b001e45e
      sfalken authored
              Reviewed by Adam.
      
              Properly adjust CFAbsoluteTime to time_t to fix date calculations.
              
              Compare lastModified w/ MAX_TIME_T when setting last modified date
              instead of comparing expiration against MAX_TIME_T.
      
              * platform/network/cf/ResourceResponseCFNet.cpp:
              (WebCore::getResourceResponse): Add kCFAbsoluteTimeIntervalSince1970 in assignment
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b001e45e
    • andersca's avatar
      Reviewed by Geoff. · 202e8653
      andersca authored
              More conversions from DeprecatedValueList to Vector and HashSet.
              
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::~CSSValueList):
              (WebCore::CSSValueList::append):
              (WebCore::CSSValueList::cssText):
              * css/CSSValueList.h:
              (WebCore::CSSValueList::length):
              (WebCore::CSSValueList::item):
              * dom/Document.cpp:
              (WebCore::Document::attachNodeIterator):
              (WebCore::Document::notifyBeforeNodeRemoval):
              * dom/Document.h:
              * ksvg2/svg/SVGGradientElement.cpp:
              (WebCore::SVGGradientElement::notifyAttributeChange):
              * ksvg2/svg/SVGPatternElement.cpp:
              (WebCore::SVGPatternElement::notifyClientsToRepaint):
              * platform/graphics/svg/SVGResource.cpp:
              (WebCore::SVGResource::invalidate):
              (WebCore::SVGResource::addClient):
              * platform/graphics/svg/SVGResource.h:
              * rendering/RenderBlock.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      202e8653
    • andersca's avatar
      2006-11-17 Anders Carlsson <acarlsson@apple.com> · cdd6842b
      andersca authored
              Reviewed by Adam.
      
              Make sure that we always use std::min and std::max instead of macros.
              
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * kjs/config.h:
              * wtf/Vector.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdd6842b
    • thatcher's avatar
      Fixing the assertion failure, forgot to remove an enable() call. · 5250e7f7
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5250e7f7
    • thatcher's avatar
      Versioning · 1ce659f5
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ce659f5
    • thatcher's avatar
      Reviewed by Harrison. · 3d53764a
      thatcher authored
              <rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made
      
              Disable the delete button controller when cloning nodes, Mail does this before saving a draft.
      
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::cloneChildNodes):
              * editing/markup.cpp:
              (WebCore::createFragmentFromNodes):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d53764a
    • justing's avatar
      LayoutTests: · e3143cdd
      justing authored
              Reviewed by harrison
              
              <rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
              <rdar://problem/4017358> quoted text is wrong color, when pasted as quotation
      
              Fixed:
              * editing/pasteboard/merge-end-blockquote-expected.checksum:
              * editing/pasteboard/merge-end-blockquote-expected.png:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              * editing/pasteboard/merge-end-blockquote.html:
              
              Added:
              * editing/pasteboard/paste-blockquote-1-expected.checksum: Added.
              * editing/pasteboard/paste-blockquote-1-expected.png: Added.
              * editing/pasteboard/paste-blockquote-1-expected.txt: Added.
              * editing/pasteboard/paste-blockquote-1.html: Added.
              * editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
              * editing/pasteboard/paste-blockquote-2-expected.png: Added.
              * editing/pasteboard/paste-blockquote-2-expected.txt: Added.
              * editing/pasteboard/paste-blockquote-2.html: Added.
              * editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
              * editing/pasteboard/paste-blockquote-3-expected.png: Added.
              * editing/pasteboard/paste-blockquote-3-expected.txt: Added.
              * editing/pasteboard/paste-blockquote-3.html: Added.
      
      WebCore:
      
              Reviewed by harrison
              
              <rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
              <rdar://problem/4017358> quoted text is wrong color, when pasted as quotation
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::isMailPasteAsQuotationNode): Added.  Checks for the node
              that Mail wraps around an incoming fragment when it wants it to be pasted
              with quoting (no merging should be done).
              (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Added
              this virtual method in order to adjust the nodes that ReplaceSelectionCommand
              tracks.
              (WebCore::ReplaceSelectionCommand::shouldMerge): Don't merge from content
              inside a Mail Paste as Quotation node.  Allow merging from Mail blockquotes.
              (WebCore::ReplaceSelectionCommand::removeRedundantStyles): When pasting into
              a Mail blockquote, we ignore the parts of the source document's default style
              that are overriden by styles from the Mail blockquote.  This is necessary in order
              for text that's black (because black is the source document's default font color) 
              to appear blue/green/whatever when it's pasted into a Mail blockquote.
              (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Turn an inserted
              Mail Paste as Quotation node into a normal Mail blockquote.  This will prevent
              a copied blockquote that was inserted into the document using Paste as Quotation
              from triggering Paste as Quotation behavior when it's pasted.
              (WebCore::ReplaceSelectionCommand::doApply): Call the new/altered methods.
              * editing/ReplaceSelectionCommand.h:
              * editing/markup.cpp:
              (WebCore::styleFromMatchedRulesForElement): Put this code into a subroutine.
              (WebCore::removeEnclosingMailBlockquoteStyle): Added.
              (WebCore::startMarkup): When wrapping text nodes in style spans, leave out
              styles that Mail blockquotes contribute, so that Mail blockquote styles can
              be differentiated from styles that the user has applied.  When creating markup
              for elements, do the same thing.
              (WebCore::createMarkup): Call the new subroutine.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3143cdd
    • thatcher's avatar
      Forgoet the project change. · ec59bd55
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec59bd55
    • thatcher's avatar
      Reviewed by Geoff. · 961724ed
      thatcher authored
              <rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebView.mm:
              (+[WebView initialize]):
              (-[WebView setPreferences:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      961724ed
  3. 17 Nov, 2006 7 commits
    • rwlbuis's avatar
      Reviewed by Mitz. · 11fc281b
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=11635
              Bug 11635: Fix potential issue with non-xslt build
      
              Fix the issue and do style guideline corrections.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11fc281b
    • thatcher's avatar
      Reviewed by Harrison. · be8aefa3
      thatcher authored
              <rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it
      
              Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
              This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
      
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply):
              (WebCore::EditCommand::unapply):
              (WebCore::EditCommand::reapply):
              (WebCore::applyCommand):
              * editing/EditCommand.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be8aefa3
    • zimmermann's avatar
      Reviewed by Mitz. Landed by Niko. · 961ceeb7
      zimmermann authored
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=11617
      Adapt to latest API changes, fixing Qt/Linux build.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      961ceeb7
    • harrison's avatar
      Reviewed by Adele. · 7ffc4030
      harrison authored
              <rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer
      
              Replace an assert with a fixme that refers to this bug.
              
              * page/Frame.cpp:
              (WebCore::Frame::revealSelection):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ffc4030
    • beidson's avatar
      LayoutTests: · e79e9456
      beidson authored
              Reviewed and landed by Brady
      
              Testcase for:
              http://bugs.webkit.org/show_bug.cgi?id=11590
              Bug 11590: REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
      
              * fast/css/import-rule-regression-11590-expected.txt: Added.
              * fast/css/import-rule-regression-11590.html: Added.
              * fast/css/resources/imports.css: Added.
              * fast/css/resources/style.css: Added.
      
      WebCore:
      
              Reviewed and landed by Brady
      
              Fixes http://bugs.webkit.org/show_bug.cgi?id=11590 -
              REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
              Fix the regression by setting m_loadCompleted correctly.
      
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::checkLoaded):
              * dom/Node.h:
              (WebCore::Node::sheetLoaded):
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::sheetLoaded):
              * dom/ProcessingInstruction.h:
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::sheetLoaded):
              * html/HTMLLinkElement.h:
              * html/HTMLStyleElement.cpp:
              (WebCore::HTMLStyleElement::sheetLoaded):
              * html/HTMLStyleElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e79e9456
    • harrison's avatar
      Reviewed by Beth. · b100b8e7
      harrison authored
              <rdar://problem/4056100> REGRESSION (Tiger): Deleting top part of reply email leaves fails to clear text at end of message
      
              The problem was triggered by the fact that the parent div was changing both
              in position and in height. The renderer normally bifurcates its logic for
              x-position changes vs height changes.
      
              Call repaintDuringLayoutIfMoved() with old rect (incl. width and height) instead of just the old position.
      
              Test added:
              * manual-tests/delete-into-nested-block.html
              
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlockChildren):
              (WebCore::RenderBlock::positionNewFloats):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::repaintDuringLayoutIfMoved):
              * rendering/RenderBox.h:
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::placeChild):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::repaintDuringLayoutIfMoved):
              * rendering/RenderObject.h:
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::layoutRows):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b100b8e7
    • adele's avatar
      Reviewed by Adam. · a3f13fdc
      adele authored
              Slider cleanup.  Let the theme set the size of the slider thumb.
      
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::setStyle): Moving the thumb's appearance adjustment to createThumbStyle.
              (WebCore::RenderSlider::createThumbStyle):
              (WebCore::RenderSlider::layout): Let the theme set the size of the thumb.
              * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbSize):  Added.
              * rendering/RenderTheme.h: ditto.
              * rendering/RenderThemeMac.h: ditto.
              * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3f13fdc
  4. 16 Nov, 2006 14 commits
    • andersca's avatar
      Reviewed by Darin. · 02b2f195
      andersca authored
              Use Vector instead of DeprecatedValueList in a few places.
              
              * bindings/js/kjs_dom.cpp:
              (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
              (KJS::DOMNamedNodesCollection::lengthGetter):
              (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLDocument::namedItemGetter):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::JSHTMLCollection::getNamedItems):
              * bindings/objc/DOM.mm:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::dashboardRegionsDictionary):
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::diff):
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::namedItems):
              * html/HTMLCollection.h:
              * kcanvas/KCanvasFilters.cpp:
              (WebCore::KCanvasFilter::externalRepresentation):
              * kcanvas/KCanvasFilters.h:
              (WebCore::KCanvasFEColorMatrix::values):
              (WebCore::KCanvasFEColorMatrix::setValues):
              (WebCore::KCanvasFEConvolveMatrix::kernel):
              (WebCore::KCanvasFEConvolveMatrix::setKernel):
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              (WebCore::KCanvasFilterQuartz::getCIFilterStack):
              (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
              * ksvg2/svg/SVGFEColorMatrixElement.cpp:
              (WebCore::SVGFEColorMatrixElement::filterEffect):
              * platform/graphics/svg/SVGResourceClipper.h:
              * platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
              (WebCore::SVGResourceClipper::applyClip):
              * platform/network/FormData.h:
              * rendering/RenderPath.h:
              * rendering/SVGRenderTreeAsText.h:
              (WebCore::operator<<):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02b2f195
    • andersca's avatar
      Reviewed by Tim. · c98a54f5
      andersca authored
              * editing/markup.cpp:
              (WebCore::createMarkup):
              Add null-checks for the frame, it might not exist for all documents.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c98a54f5
    • ap's avatar
      2006-11-16 Don Gibson <dgibson77@gmail.com> · b2aa0fc0
      ap authored
              Reviewed and landed by ap.
      
              http://bugs.webkit.org/show_bug.cgi?id=11509:
              Windows build bustage.
      
              Also reorganizes WebCore.vcproj to add files whose absence wasn't
              causing compile errors, but which should have been there, and to
              make the include directory ordering (and contents) sane.
              Also reorganizes TemporaryLinkStubs.cpp to put headers and
              function groups in alphabetical order, and ensure that all functions
              in the file call notImplemented().
      
      WebCore:
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * bridge/win/ChromeClientWin.h:
              (WebCore::ChromeClientWin::ref):
              (WebCore::ChromeClientWin::deref):
              * bridge/win/ContextMenuClientWin.h: Added.
              (WebCore::ContextMenuClientWin::~ContextMenuClientWin):
              (WebCore::ContextMenuClientWin::ref):
              (WebCore::ContextMenuClientWin::deref):
              * bridge/win/EditorClientWin.h:
              * bridge/win/FrameWin.cpp:
              (WebCore::FrameWin::~FrameWin):
              (WebCore::FrameWin::keyPress):
              * bridge/win/FrameWin.h:
              * bridge/win/PageWin.cpp: Removed.
              * editing/EditCommand.h:
              * loader/FormState.h:
              * loader/FrameLoader.h:
              * page/EventHandler.cpp:
              * platform/MimeTypeRegistry.cpp:
              (WebCore::initialiseSupportedImageMIMETypes):
              * platform/graphics/win/ImageWin.cpp:
              * platform/network/ResourceError.cpp:
              * platform/network/ResourceHandleInternal.h:
              * platform/network/win/ResourceHandleWin.cpp:
              (WebCore::ResourceHandle::onHandleCreated):
              (WebCore::ResourceHandle::onRequestRedirected):
              (WebCore::ResourceHandle::start):
              (WebCore::ResourceHandle::cancel):
              * platform/win/ScreenWin.cpp:
              (WebCore::monitorInfo):
              (WebCore::screenRect):
              (WebCore::screenAvailableRect):
              (WebCore::screenDepth):
              * platform/win/SoundWin.cpp: Added.
              (WebCore::systemBeep):
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::CacheObjectExpiresTime):
              (WebCore::CheckCacheObjectStatus):
              (WebCore::CheckIfReloading):
              (WebCore::defaultLanguage):
              (WebCore::fileButtonChooseFileLabel):
              (WebCore::fileButtonNoFileSelectedLabel):
              (WebCore::findNextSentenceFromIndex):
              (WebCore::findNextWordFromIndex):
              (WebCore::findSentenceBoundary):
              (WebCore::findWordBoundary):
              (WebCore::focusRingColor):
              (WebCore::historyContains):
              (WebCore::inputElementAltText):
              (WebCore::IsResponseURLEqualToURL):
              (WebCore::cellCursor):
              (WebCore::contextMenuCursor):
              (WebCore::moveCursor):
              (WebCore::verticalTextCursor):
              (WebCore::refreshPlugins):
              (WebCore::resetButtonDefaultLabel):
              (WebCore::ResponseIsMultipart):
              (WebCore::ResponseMIMEType):
              (WebCore::ResponseURL):
              (WebCore::screenDepthPerComponent):
              (WebCore::screenIsMonochrome):
              (WebCore::searchableIndexIntroduction):
              (WebCore::ServeSynchronousRequest):
              (WebCore::setFocusRingColorChangeFunction):
              (WebCore::submitButtonDefaultLabel):
              (WebCore::CachedResource::setPlatformResponse):
              (WebCore::CachedResource::setAllData):
              (WebCore::ChromeClientWin::setWindowRect):
              (WebCore::ChromeClientWin::windowRect):
              (WebCore::ChromeClientWin::pageRect):
              (WebCore::ChromeClientWin::scaleFactor):
              (WebCore::ChromeClientWin::focus):
              (WebCore::ChromeClientWin::unfocus):
              (WebCore::ChromeClientWin::createWindow):
              (WebCore::ChromeClientWin::createModalDialog):
              (WebCore::ChromeClientWin::show):
              (WebCore::ChromeClientWin::canRunModal):
              (WebCore::ChromeClientWin::runModal):
              (WebCore::ChromeClientWin::setToolbarsVisible):
              (WebCore::ChromeClientWin::toolbarsVisible):
              (WebCore::ChromeClientWin::setStatusbarVisible):
              (WebCore::ChromeClientWin::statusbarVisible):
              (WebCore::ChromeClientWin::setScrollbarsVisible):
              (WebCore::ChromeClientWin::scrollbarsVisible):
              (WebCore::ChromeClientWin::setMenubarVisible):
              (WebCore::ChromeClientWin::menubarVisible):
              (WebCore::ChromeClientWin::setResizable):
              (WebCore::ContextMenu::appendItem):
              (WebCore::ContextMenuClientWin::addCustomContextMenuItems):
              (WebCore::DocumentLoader::setFrame):
              (WebCore::DocumentLoader::frameLoader):
              (WebCore::DocumentLoader::URL):
              (WebCore::DocumentLoader::isStopping):
              (WebCore::DocumentLoader::stopLoading):
              (WebCore::DocumentLoader::setLoading):
              (WebCore::DocumentLoader::updateLoading):
              (WebCore::DocumentLoader::setupForReplaceByMIMEType):
              (WebCore::DocumentLoader::isLoadingInAPISense):
              (WebCore::DocumentLoader::stopRecordingResponses):
              (WebCore::EditorClientWin::shouldDeleteRange):
              (WebCore::EditorClientWin::shouldShowDeleteInterface):
              (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
              (WebCore::EditorClientWin::isGrammarCheckingEnabled):
              (WebCore::EditorClientWin::spellCheckerDocumentTag):
              (WebCore::EventHandler::focusDocumentView):
              (WebCore::EventHandler::handleDrag):
              (WebCore::EventHandler::handleMouseUp):
              (WebCore::EventHandler::lastEventIsMouseUp):
              (WebCore::EventHandler::passMousePressEventToSubframe):
              (WebCore::EventHandler::passMouseMoveEventToSubframe):
              (WebCore::EventHandler::passMouseReleaseEventToSubframe):
              (WebCore::EventHandler::passWheelEventToSubframe):
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              (WebCore::EventHandler::passMousePressEventToScrollbar):
              (WebCore::EventHandler::shouldDragAutoNode):
              (WebCore::EventHandler::tabsToAllControls):
              (WebCore::EventHandler::tabsToLinks):
              (WebCore::Frame::setNeedsReapplyStyles):
              (WebCore::FrameLoader::didFirstLayout):
              (WebCore::FrameLoader::overrideMediaType):
              (WebCore::FrameLoader::createJavaAppletWidget):
              (WebCore::FrameLoader::redirectDataToPlugin):
              (WebCore::FrameLoader::getHistoryLength):
              (WebCore::FrameLoader::setTitle):
              (WebCore::FrameLoader::referrer):
              (WebCore::FrameLoader::saveDocumentState):
              (WebCore::FrameLoader::restoreDocumentState):
              (WebCore::FrameLoader::goBackOrForward):
              (WebCore::FrameLoader::historyURL):
              (WebCore::FrameLoader::urlSelected):
              (WebCore::FrameLoader::createFrame):
              (WebCore::FrameLoader::submitForm):
              (WebCore::FrameLoader::partClearedInBegin):
              (WebCore::FrameLoader::originalRequestURL):
              (WebCore::FrameLoader::canGoBackOrForward):
              (WebCore::FrameLoader::objectContentType):
              (WebCore::FrameLoader::createPlugin):
              (WebCore::FrameLoader::detachFromParent):
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
              (WebCore::FrameView::updateBorder):
              (WebCore::FrameWin::bindingRootObject):
              (WebCore::FrameWin::canPaste):
              (WebCore::FrameWin::issuePasteAndMatchStyleCommand):
              (WebCore::FrameWin::markedTextRange):
              (WebCore::FrameWin::passSubframeEventToSubframe):
              (WebCore::FrameWin::lastEventIsMouseUp):
              (WebCore::FrameWin::addMessageToConsole):
              (WebCore::FrameWin::shouldChangeSelection):
              (WebCore::FrameWin::respondToChangedSelection):
              (WebCore::FrameWin::clearUndoRedoOperations):
              (WebCore::FrameWin::markMisspellingsInAdjacentWords):
              (WebCore::FrameWin::respondToChangedContents):
              (WebCore::GraphicsContext::addRoundedRectClip):
              (WebCore::GraphicsContext::setShadow):
              (WebCore::GraphicsContext::clearShadow):
              (WebCore::GraphicsContext::beginTransparencyLayer):
              (WebCore::GraphicsContext::endTransparencyLayer):
              (WebCore::GraphicsContext::clearRect):
              (WebCore::GraphicsContext::strokeRect):
              (WebCore::GraphicsContext::setLineWidth):
              (WebCore::GraphicsContext::setLineCap):
              (WebCore::GraphicsContext::setLineJoin):
              (WebCore::GraphicsContext::setMiterLimit):
              (WebCore::GraphicsContext::setAlpha):
              (WebCore::GraphicsContext::setCompositeOperation):
              (WebCore::GraphicsContext::clip):
              (WebCore::GraphicsContext::rotate):
              (WebCore::GraphicsContext::scale):
              (WebCore::Icon::Icon):
              (WebCore::Icon::~Icon):
              (WebCore::Icon::newIconForFile):
              (WebCore::Icon::paint):
              (WebCore::IconDatabase::isIconExpiredForIconURL):
              (WebCore::IconDatabase::hasEntryForIconURL):
              (WebCore::IconDatabase::sharedIconDatabase):
              (WebCore::IconDatabase::setIconURLForPageURL):
              (WebCore::IconDatabase::setIconDataForIconURL):
              (WebCore::Image::drawTiled):
              (WebCore::Image::getHBITMAP):
              (WebCore::Path::Path):
              (WebCore::Path::~Path):
              (WebCore::Path::contains):
              (WebCore::Path::translate):
              (WebCore::Path::boundingRect):
              (WebCore::Path::operator=):
              (WebCore::Path::clear):
              (WebCore::Path::moveTo):
              (WebCore::Path::addLineTo):
              (WebCore::Path::addQuadCurveTo):
              (WebCore::Path::addBezierCurveTo):
              (WebCore::Path::addArcTo):
              (WebCore::Path::closeSubpath):
              (WebCore::Path::addArc):
              (WebCore::Path::addRect):
              (WebCore::Path::addEllipse):
              (WebCore::Path::transform):
              (WebCore::PlatformMouseEvent::PlatformMouseEvent):
              (WebCore::PlatformScrollbar::PlatformScrollbar):
              (WebCore::PlatformScrollbar::~PlatformScrollbar):
              (WebCore::PlatformScrollbar::width):
              (WebCore::PlatformScrollbar::height):
              (WebCore::PlatformScrollbar::setEnabled):
              (WebCore::PlatformScrollbar::paint):
              (WebCore::PlatformScrollbar::updateThumbPosition):
              (WebCore::PlatformScrollbar::updateThumbProportion):
              (WebCore::PlatformScrollbar::setRect):
              (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
              (WebCore::PlugInInfoStore::pluginCount):
              (WebCore::PlugInInfoStore::supportsMIMEType):
              (WebCore::PolicyCheck::PolicyCheck):
              (WebCore::PolicyCheck::clear):
              (WebCore::PolicyCheck::clearRequest):
              (WebCore::PolicyCheck::call):
              (WebCore::RenderThemeWin::systemFont):
              (WebCore::RenderThemeWin::paintMenuList):
              (WebCore::RenderThemeWin::adjustMenuListStyle):
              (WebCore::ResourceLoader::cancel):
              (WebCore::ScrollView::addChild):
              (WebCore::ScrollView::removeChild):
              (WebCore::ScrollView::scrollPointRecursively):
              (WebCore::ScrollView::inWindow):
              (WebCore::ScrollView::paint):
              (WebCore::ScrollView::wheelEvent):
              (WebCore::ScrollView::themeChanged):
              (WebCore::ScrollView::convertChildToSelf):
              (WebCore::ScrollView::convertSelfToChild):
              (WebCore::ScrollView::geometryChanged):
              (WebCore::ScrollView::scrollbarUnderMouse):
              (WebCore::ScrollView::setFrameGeometry):
              (WebCore::ScrollView::windowResizerRect):
              (WebCore::ScrollView::resizerOverlapsContent):
              (WebCore::TextField::selectAll):
              (WebCore::TextField::addSearchResult):
              (WebCore::TextField::selectionStart):
              (WebCore::TextField::hasSelectedText):
              (WebCore::TextField::selectedText):
              (WebCore::TextField::setAutoSaveName):
              (WebCore::TextField::checksDescendantsForFocus):
              (WebCore::TextField::setSelection):
              (WebCore::TextField::setMaxResults):
              (WebCore::TextField::edited):
              (WebCore::TextField::focusPolicy):
              (WebCore::TextField::TextField):
              (WebCore::TextField::~TextField):
              (WebCore::TextField::setFont):
              (WebCore::TextField::setAlignment):
              (WebCore::TextField::setWritingDirection):
              (WebCore::TextField::maxLength):
              (WebCore::TextField::setMaxLength):
              (WebCore::TextField::text):
              (WebCore::TextField::setText):
              (WebCore::TextField::cursorPosition):
              (WebCore::TextField::setCursorPosition):
              (WebCore::TextField::setEdited):
              (WebCore::TextField::setReadOnly):
              (WebCore::TextField::setPlaceholderString):
              (WebCore::TextField::setColors):
              (WebCore::TextField::sizeForCharacterWidth):
              (WebCore::TextField::baselinePosition):
              (WebCore::TextField::setLiveSearch):
              (WebCore::Widget::enableFlushDrawing):
              (WebCore::Widget::isEnabled):
              (WebCore::Widget::focusPolicy):
              (WebCore::Widget::disableFlushDrawing):
              (WebCore::Widget::removeFromParent):
              (WebCore::Widget::lockDrawingFocus):
              (WebCore::Widget::unlockDrawingFocus):
              (WebCore::Widget::capturingMouse):
              (WebCore::Widget::setCapturingMouse):
              (WebCore::Widget::capturingTarget):
              (WebCore::Widget::capturingChild):
              (WebCore::Widget::setCapturingChild):
              (WebCore::Widget::convertChildToSelf):
              (WebCore::Widget::convertSelfToChild):
              (WebCore::Widget::setParent):
              (WebCore::Widget::parent):
              (WebCore::Widget::setEnabled):
              (WebCore::Widget::paint):
              (WebCore::Widget::setIsSelected):
              (WebCore::Widget::invalidate):
              (WebCore::Widget::invalidateRect):
              * platform/win/WidgetWin.cpp:
              (WebCore::Widget::clearFocus):
      
      WebKit:
              * COM/WebFrame.cpp:
              (WebFrame::initWithName):
              (WebFrame::loadHTMLString):
              (WebFrame::stopLoading):
              (WebFrame::reload):
              (WebFrame::loadDataSource):
              (WebFrame::didReceiveData):
              (WebFrame::receivedResponse):
              (WebFrame::receivedAllData):
              * COM/WebFrame.h:
              * COM/WebView.cpp:
              (WebView::mouseMoved):
              (WebView::mouseDown):
              (WebView::mouseUp):
              (WebView::mouseDoubleClick):
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2aa0fc0
    • thatcher's avatar
      Reviewed by Adam. · 26684cf2
      thatcher authored
              <rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made
      
              * editing/markup.cpp:
              (WebCore::createMarkup): disable the delete button so it's elements are not serialized into the markup
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26684cf2
    • staikos's avatar
      Rubberstamped by Maciej. · 827e1ff2
      staikos authored
              Making the code valgrind clean.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      827e1ff2
    • andersca's avatar
      Reviewed by Tim. · ec07cf2b
      andersca authored
              <rdar://problem/4841123>
              REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message
              
              * Misc/WebNSAttributedStringExtras.m:
              (+[NSAttributedString _web_attributedStringFromRange:]):
              If the range passed in is null, return null. When this function was in the bridge, it would never get called
              with a null range when nothing was selected. Instead, the range would just have invalid boundary points.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec07cf2b
    • thatcher's avatar
      Adding back a correct version of this assert. · c9a5ea9f
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9a5ea9f
    • harrison's avatar
      Reviewed by Darin and Tim. · c757b385
      harrison authored
              <rdar://problem/4799949> REGRESSION: Crash in FrameMac::eventMayStartDrag() by clicking on a page
              
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::eventMayStartDrag):
              Add nil check of hitTest's result.innerNode().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c757b385
    • thatcher's avatar
      Reviewed by Darin. · f03df1ae
      thatcher authored
              <rdar://problem/4836897> Deletion rectangle disappears when multiple list items are selected
      
              Consider the container of the selection range for deletion before asking enclosingNodeOfType().
      
              * editing/DeleteButtonController.cpp:
              (WebCore::enclosingDeletableElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f03df1ae
    • rwlbuis's avatar
      Reviewed by hyatt. · 1de7c5bb
      rwlbuis authored
              Removal of unused m_styleElement.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1de7c5bb
    • aroben's avatar
      Build fix. · 85252fc1
      aroben authored
              Rename the items in the ContextMenuAction enum so that they don't
              conflict with WebKit names.
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/ContextMenu.cpp:
              (WebCore::ContextMenu::populate):
              * platform/ContextMenu.h:
              (WebCore::):
              (WebCore::ContextMenuItem::ContextMenuItem):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85252fc1
    • aroben's avatar
      Reviewed by Anders. · d4284311
      aroben authored
              Change m_contextMenu to an OwnPtr.
      
              * WebCore.xcodeproj/project.pbxproj:
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::handleContextMenuEvent):
              * page/ContextMenuController.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4284311
    • aroben's avatar
      WebCore: · 769ddd85
      aroben authored
              Reviewed by Anders.
      
              Add new ContextMenuController and ContextMenuClient classes, and move
              context menu responsibilities from Chrome and ChromeClient to them.
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj: Add new files to project, and
              alphabetize some others.
              * page/Chrome.cpp: Remove context menu-related code.
              * page/Chrome.h: Ditto.
              * page/ChromeClient.h:
              * page/ContextMenuClient.h: Added.
              * page/ContextMenuController.cpp: Added.
              (WebCore::ContextMenuController::ContextMenuController):
              (WebCore::ContextMenuController::~ContextMenuController):
              (WebCore::ContextMenuController::handleContextMenuEvent):
              (WebCore::ContextMenuController::contextMenuActionSelected):
              * page/ContextMenuController.h: Added.
              (WebCore::ContextMenuController::client):
              * page/Page.cpp: Every Page now has a ContextMenuController.
              (WebCore::Page::Page):
              * page/Page.h: Made m_dragCaretController and m_chrome objects instead
              of pointers to objects.
              (WebCore::Page::contextMenuController):
              * platform/ContextMenu.cpp:
              (WebCore::ContextMenu::populate): Removed the call to Chrome to ask the
              delegate to add its menu items, and moved the code from the static
              addDefaultItems function into this method.
              * platform/ContextMenu.h:
              (WebCore::ContextMenu::show): Added an empty method body since this
              method is now called from ContextMenuController (although no one calls
              into ContextMenuController yet, so it's OK for this to be empty).
              (WebCore::ContextMenu::hide): Ditto.
      
      WebKit:
      
              Reviewed by Anders.
      
              Added new WebContextMenuClient class to act as WebCore's ChromeClient,
              and moved context menu-related code there from WebChromeClient.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              * WebCoreSupport/WebContextMenuClient.h: Added.
              (WebContextMenuClient::webView):
              * WebCoreSupport/WebContextMenuClient.mm: Added.
              (WebContextMenuClient::create):
              (WebContextMenuClient::WebContextMenuClient):
              (WebContextMenuClient::ref):
              (WebContextMenuClient::deref):
              (WebContextMenuClient::addCustomContextMenuItems):
              * WebKit.xcodeproj/project.pbxproj: Added new files.
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      769ddd85
    • thatcher's avatar
      Removing this assert until I can look into the problem further. · 2bfb171a
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bfb171a