1. 06 Nov, 2008 29 commits
  2. 05 Nov, 2008 11 commits
    • alp@webkit.org's avatar
      Attempt to fix the GTK build bot after the latest kjs -> runtime move: · d4ff35ba
      alp@webkit.org authored
      Remove the built products directory completely rather than using distclean.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4ff35ba
    • barraclough@apple.com's avatar
      JavaScriptCore: · e3aaa165
      barraclough@apple.com authored
      2008-11-05  Gavin Barraclough  <barraclough@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              https://bugs.webkit.org/show_bug.cgi?id=22094
      
              Fix for bug where the callee incorrectly recieves the caller's lexical
              global object as this, rather than its own.  Implementation closely
              follows the spec, passing jsNull, checking in the callee and replacing
              with the global object where necessary.
      
              * VM/CTI.cpp:
              (JSC::CTI::compileOpCall):
              * VM/Machine.cpp:
              (JSC::Machine::cti_op_call_NotJSFunction):
              (JSC::Machine::cti_op_call_eval):
              * runtime/JSCell.h:
              (JSC::JSValue::toThisObject):
              * runtime/JSImmediate.cpp:
              (JSC::JSImmediate::toThisObject):
              * runtime/JSImmediate.h:
      
      LayoutTests:
      
      2008-11-05  Gavin Barraclough  <barraclough@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Previosly the test 'cross-site-this' checked that the second level deep method called
              across frames recieved the correct this pointer, when no base object is provided.
              
              Test updated so that it check that the code in the child frame, and both the first
              and second functions called in the parent frame recieve the correct this values.
      
              * fast/frames/cross-site-this.html:
              * fast/frames/resources/cross-site-this-helper.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3aaa165
    • antti@apple.com's avatar
      2008-11-05 Antti Koivisto <antti@apple.com> · c5a3853c
      antti@apple.com authored
              Reviewed by Dan Bernstein.
              
              https://bugs.webkit.org/show_bug.cgi?id=22093
              Don't keep decoded stylesheet data in cache
              
              <rdar://problem/6343588>
      
              Don't keep decoded stylesheet string around in the cache. There are no sharing benefits and
              performance benefits are negligible (no measured PLT impact). Reduces memory consumption of
              style sheet data in cache by 2/3 in common case.  
      
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::sheetText):
              (WebCore::CachedCSSStyleSheet::data):
              * loader/CachedCSSStyleSheet.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5a3853c
    • kevino@webkit.org's avatar
      wx build fix after Operations.cpp move. · 3368923b
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3368923b
    • ddkilzer@apple.com's avatar
      Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers · b02df967
      ddkilzer@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=21596>
      
              Reviewed by Antti.
      
              This patch adds real parsing for Pragma and Cache-Control headers
              based on RFC 2616, Sections 2, 14.9 and 14.32.  It also adds some
              new String and StringImpl methods to assist with the parsing.
      
              * loader/Cache.cpp:
              (WebCore::Cache::dumpStats): Added.  Convenience method for dumping
              stats outside of Safari.
              * loader/Cache.h: Declared dumpStats().
      
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::mustRevalidate): Updated to use
              ResourceResponseBase::cacheControlDirectives() instead of substring
              matching of the entire Cache-Control header.
      
              * loader/loader.cpp:
              (WebCore::Loader::Host::didReceiveResponse): Used the local
              'resource' variable instead of 'request->cachedResource()'.
      
              * platform/network/ResourceResponseBase.cpp:
              (WebCore::ResourceResponseBase::setHTTPHeaderField): Set
              m_haveParsedCacheControlHeader to false when a "Cache-Control"
              header is set.  Ditto for m_haveParsedPragmaHeader and "Pragma".
              (WebCore::ResourceResponseBase::parsePragmaDirectives): Added.
              Provides parsed Pragma header directives.
              (WebCore::ResourceResponseBase::parseCacheControlDirectives): Added.
              Provides parsed Cache-Control header directives.
              (WebCore::isCacheHeaderSeparator): Added.  Returns true if a
              character is a separator character per RFC 2616, Section 2.2, else
              returns false.
              (WebCore::isControlCharacter): Added.  Returns true if a character
              is a control character per RFC 2616 Section 2.2, else returns false.
              (WebCore::trimToNextSeparator): Added.  Returns a string truncated
              at the first separator character per isCacheHeaderSeparator().
              (WebCore::parseCacheHeader): Added.  This is the main parsing
              routine for both Cache-Control and Pragma headers.
              (WebCore::parseCacheControlDirectiveValues): Added.  This splits
              certain Cache-Control directive values into a vector of strings.
              * platform/network/ResourceResponseBase.h:
              (WebCore::CacheControlDirectiveMap): Added.  Typedef for a parsed
              Cache-Control header.
              (WebCore::PragmaDirectiveMap): Added.  Typedef for a parsed Pragma
              header.
              (WebCore::ResourceResponseBase::parsePragmaDirectives): Added
              declaration.
              (WebCore::ResourceResponseBase::parseCacheControlDirectives): Ditto.
              (WebCore::ResourceResponseBase::m_haveParsedCacheControlHeader):
              Added.  Boolean to describe when the "Cache-Control" header needs to
              be reparsed.
              (WebCore::ResourceResponseBase::m_haveParsedPragmaHeader):  Added.
              Boolean to describe when the "Pragma" header needs to be reparsed.
              (WebCore::ResourceResponseBase::m_cacheControlDirectiveMap): Added.
              Cached map to hold parsed "Cache-Control" headers.
              (WebCore::ResourceResponseBase::m_pragmaDirectiveMap): Added.
              Cached map to hold parsed "Pragma" headers.
      
              * platform/text/PlatformString.h:
              (WebCore::String::find): Added.  Returns the first match based on
              the character-matching function pointer passed in.
              (WebCore::String::removeCharacters): Added declaration.
              (WebCore::find): Added.  Inline method that takes a character-
              matching function pointer.  Called by StringImpl::find().
              * platform/text/String.cpp:
              (WebCore::String::removeCharacters): Added.  Calls
              StringImpl::removeCharacters().
              * platform/text/StringImpl.cpp:
              (WebCore::StringImpl::removeCharacters): Added.  Returns a string
              with all characters removed that match the character-matching
              function pointer passed in.  If there is no change to the string, it
              returns itself.  Based heavily on StringImpl::simplifyWhitespace().
              (WebCore::StringImpl::find): Added.  Calls WebCore::find().
              * platform/text/StringImpl.h:
              (WebCore::FindMatchFunctionPtr): Added.  Typedef for a character-
              matching function pointer.
              (WebCore::StringImpl::removeCharacters): Added declaration.
              (WebCore::StringImpl::find): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b02df967
    • justin.garcia@apple.com's avatar
      WebCore: · 41ed13a7
      justin.garcia@apple.com authored
      2008-11-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Beth Dakin.
      
              <rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break
              
              As a rule, we don't allow merges out of blockquotes.  In the bug, we are inserting a text node 
              between two blockquotes.  Because the start merge moves the text node into a blockquote, when we
              determine whether or not we should do the end merge, it incorrectly appears as though the end merge 
              is merging out of a blockquote.  The fix is to determine whether or not we should do the end merge
              before we do the start merge, so that the start merge doesn't effect our decision.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Initialize the new boolean.
              (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Moved code from doApply() here for clarity.
              (WebCore::ReplaceSelectionCommand::doApply): Set m_shouldMergeEnd before we do the start merge.
              * editing/ReplaceSelectionCommand.h: Added m_shouldMergeEnd.
      
      LayoutTests:
      
      2008-11-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Beth Dakin.
              
              <rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break
      
              * editing/pasteboard/5480736-expected.txt: Added.
              * editing/pasteboard/5480736.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41ed13a7
    • andersca@apple.com's avatar
      2008-11-05 Anders Carlsson <andersca@apple.com> · 9ab35ff7
      andersca@apple.com authored
              Reviewed by Mark Rowe.
      
              Keep track of which plug-in host architecture would be needed for a given plug-in package.
              
              * Plugins/WebNetscapePluginPackage.h:
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage _initWithPath:]):
              * WebKitPrefix.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ab35ff7
    • cwzwarich@webkit.org's avatar
      2008-11-05 Cameron Zwarich <zwarich@apple.com> · 36c7fc7d
      cwzwarich@webkit.org authored
              Not reviewed.
      
              Speculatively fix the Windows build, even though these changes may not
              actually matter for anything in the build, because the Windows bots are
              behind.
      
              * WebCore.vcproj/WebCore.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36c7fc7d
    • cwzwarich@webkit.org's avatar
      2008-11-05 Cameron <zwarich@apple.com> · 9eece252
      cwzwarich@webkit.org authored
              Not reviewed.
      
              Fix the Qt build.
      
              * bridge/qt/qt_class.cpp:
              * bridge/qt/qt_runtime.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9eece252
    • cwzwarich@webkit.org's avatar
      2008-11-05 Cameron Zwarich <zwarich@apple.com> · 3e348675
      cwzwarich@webkit.org authored
              Not reviewed.
      
              Fix the build for case-sensitive build systems and wxWindows.
      
              * JavaScriptCoreSources.bkl:
              * kjs/create_hash_table:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e348675
    • cwzwarich@webkit.org's avatar
      2008-11-05 Cameron Zwarich <zwarich@apple.com> · 7764713e
      cwzwarich@webkit.org authored
              Not reviewed.
      
              Fix the build for case-sensitive build systems.
      
              * JavaScriptCoreSources.bkl:
              * kjs/Shell.cpp:
              * runtime/Interpreter.cpp:
              * runtime/JSArray.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7764713e