1. 09 Jul, 2006 2 commits
    • thatcher's avatar
      LayoutTests: · e6e3e565
      thatcher authored
              Reviewed by Maciej.
      
              Bug 5312: comments aren't available via DOM
              http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
      
              New tests for DOM comment nodes. Updated results to account for new
              nodes in the DOM (editing offsets changed.)
      
              * editing/deleting/delete-line-013-expected.txt:
              * editing/deleting/delete-line-014-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-div-009-expected.txt:
              * editing/inserting/insert-div-010-expected.txt:
              * editing/selection/extend-by-character-006-expected.txt:
              * editing/selection/move-between-blocks-no-001-expected.txt:
              * editing/selection/move-between-blocks-yes-001-expected.txt:
              * fast/dom/HTMLDocument/object-by-name-or-id-expected.txt:
              * fast/dom/HTMLDocument/object-by-name-or-id.html:
              * fast/dom/comment-document-fragment-expected.txt: Added.
              * fast/dom/comment-document-fragment.html: Added.
              * fast/dom/comment-dom-node-expected.txt: Added.
              * fast/dom/comment-dom-node.html: Added.
              * fast/dom/comment-not-documentElement-expected.checksum: Added.
              * fast/dom/comment-not-documentElement-expected.png: Added.
              * fast/dom/comment-not-documentElement-expected.txt: Added.
              * fast/dom/comment-not-documentElement.html: Added.
              * fast/text/atsui-pointtooffset-calls-cg-expected.txt:
              * fast/text/atsui-rtl-override-selection-expected.txt:
      
      WebCore:
      
              Reviewed by Maciej.
      
              Bug 5312: comments aren't available via DOM
              http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
      
              <rdar://problem/4564414> getting comments via DOM isn't working (5312)
              <rdar://problem/4545691> DOM_COMMENT node masking out real DOM elements
      
              * dom/Document.cpp:
              (WebCore::Document::removedLastRef): set m_documentElement to 0
              (WebCore::Document::childrenChanged): invalidate the document element we have cached in case it was replaced
              (WebCore::Document::documentElement): cache the first element as the document node if m_documentElement is 0
              * dom/Document.h: added m_documentElement
              * html/HTMLDocument.cpp: removed documentElement(), HTML documents just use Document's documentElement()
              * html/HTMLDocument.h: ditto
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError): make a new HTML node is the document's firstChild is NULL or
              the firstChild is not a HTML element (like a comment)
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseComment): removed the #ifdef to include comment nodes
      
      WebKit:
      
              Reviewed by Maciej.
      
              Bug 5312: comments aren't available via DOM
              http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
      
              Makes the Web Inspector show comment node contents.
      
              * WebInspector/WebInspector.m:
              (-[DOMNode _displayName]): return the contents of the comment
              * WebInspector/webInspector/inspector.js: check for comment nodes
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e3e565
    • ap's avatar
      Reviewed by Darin. · f3cdbab5
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9572
              Add application/xhtml+xml to the Accept header
      
              * WebView/WebFrame.m:
              (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Add an Accept header
              to main resource requests.
              * English.lproj/StringsNotToBeLocalized.txt: Added new strings.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3cdbab5
  2. 08 Jul, 2006 14 commits
  3. 07 Jul, 2006 22 commits
    • ggaren's avatar
      - build fix · b2a04bbe
      ggaren authored
              * JSUtils.cpp:
              (KJSValueToCFTypeInternal):
              * JSValueWrapper.cpp:
              (JSValueWrapper::JSObjectCopyPropertyNames):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2a04bbe
    • justing's avatar
      LayoutTests: · acef81d1
      justing authored
              Reviewed by levi
      
              * editing/selection/editable-non-editable-crash-expected.checksum: Added.
              * editing/selection/editable-non-editable-crash-expected.png: Added.
              * editing/selection/editable-non-editable-crash-expected.txt: Added.
              * editing/selection/editable-non-editable-crash.html: Added.
              * editing/selection/skip-non-editable-1-expected.txt:
              * editing/selection/skip-non-editable-1.html:
      
      WebCore:
      
              Reviewed by levi
              
              Fix Mail ToDo crashers.
      
              * dom/Range.cpp:
              (WebCore::Range::compareBoundaryPoints): Added an ASSERT that both
              containers are non-null and an early return.
              * editing/Selection.cpp:
              (WebCore::Selection::validate): Fix a dangling start/end.
              (WebCore::Selection::adjustForEditableContent): Added an early return if
              m_start or m_end are null.
              (WebCore::Selection::isContentEditable): Use isRichlyEditablePosition.
              (WebCore::Selection::isContentRichlyEditable): Ditto.
              * editing/Selection.h:
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::next): Use the new highestEditableRoot.
              (WebCore::VisiblePosition::previous): Ditto.
              * editing/htmlediting.cpp:
              (WebCore::highestEditableRoot): Takes in a position.
              (WebCore::isEditablePosition): Added.
              (WebCore::isRichlyEditablePosition): Added.
              (WebCore::rootEditableElement): Added.
              (WebCore::nextCandidate): Moved and split out from nextVisiblePosition.
              (WebCore::nextVisuallyDistinctCandidate): Ditto.
              (WebCore::previousCandidate): Moved and split out from previousVisiblePosition.
              (WebCore::previousVisuallyDistinctCandidate): Ditto.
              (WebCore::firstEditablePositionAfterPositionInRoot): Iterate over positions,
              using nextVisuallyDistinctCandidate, skipping atomic nodes that are non-editable.
              (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
              * editing/htmlediting.h:
              * editing/visible_units.cpp:
              (WebCore::startOfWord): Added a FIXME.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acef81d1
    • ggaren's avatar
      Reviewed by Maciej. · 2564df29
      ggaren authored
              
              - Standardized which functions take a JSContext as an argument. The rule is:
              if you might execute JavaScript, you take a JSContext, otherwise you don't.
              
              The FIXME in JSObjectRef.h requires refactoring some parts of Interpreter,
              but not API changes, so I'm putting it off until later.
      
              * API/JSCallbackObject.cpp:
              (KJS::JSCallbackObject::JSCallbackObject):
              (KJS::JSCallbackObject::init):
              * API/JSCallbackObject.h:
              * API/JSContextRef.cpp:
              (JSContextCreate):
              * API/JSContextRef.h:
              * API/JSObjectRef.cpp:
              (JSObjectMake):
              (JSPropertyEnumeratorGetNext):
              * API/JSObjectRef.h:
              * API/testapi.c:
              (MyObject_initialize):
              (main):
              * JavaScriptCore.exp:
              * kjs/array_object.cpp:
              (ArrayInstance::setLength):
              (ArrayInstance::pushUndefinedObjectsToEnd):
              * kjs/nodes.cpp:
              (ForInNode::execute):
              * kjs/reference.cpp:
              (KJS::Reference::getPropertyName):
              (KJS::Reference::getValue):
              * kjs/reference.h:
              * kjs/scope_chain.cpp:
              (KJS::ScopeChain::print):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2564df29
    • ggaren's avatar
      Reviewed by Maciej. · 554ad6fb
      ggaren authored
              
              More API action.
              
              - Headerdoc finished
      
              Semantic Changes:
              - Added a JSContextRef argument to many functions, because you need a 
              JSContextRef for doing virtually anything. I expect to add this argument
              to even more functions in a future patch.
              
              - Removed the globalObjectPrototype argument to JSContextCreate because
              you can't create an object until you have a context, so it's impossible
              to pass a prototype object to JSContextCreate. That's OK because (1) there's
              no reason to give the global object a prototype and (2) if you really want
              to, you can just use a separate call to JSObjectSetPrototype.
              
              - Removed the JSClassRef argument to JSClassCreate because it was unnecessary,
              and you need to be able to make the global object's class before you've
              created a JSContext.
              
              - Added an optional exception parameter to JSFunctionMakeWithBody because anything
              less would be uncivilized.
              
              - Made the return value parameter to JSObjectGetProperty optional to match
              all other return value parameters in the API.
              
              - Made JSObjectSetPrivate/JSObjectGetPrivate work on JSCallbackFunctions
              and JSCallbackConstructors. You could use an abstract base class or strategic
              placement of m_privateData in the class structure to implement this, but 
              the former seemed like overkill, and the latter seemed too dangerous.
              
              - Fixed a bug where JSPropertyEnumeratorGetNext would skip the first property.
      
              Cosmetic Changes:
              - Reversed the logic of the JSChar #ifdef to avoid confusing headerdoc
              
              - Removed function names from @function declarations because headeroc
              can parse them automatically, and I wanted to rule out manual mismatch.
      
              - Changed Error::create to take a const UString& instead of a UString*
              because it was looking at me funny.
              
              - Renamed JSStringBufferCreateWithCFString to JSStringBufferCreateCF
              because the latter is more concise and it matches JSStringBufferCreateUTF8.
              
              * API/JSCallbackObject.cpp:
              (KJS::JSCallbackObject::getOwnPropertySlot):
              (KJS::JSCallbackObject::put):
              (KJS::JSCallbackObject::deleteProperty):
              (KJS::JSCallbackObject::getPropertyList):
              (KJS::JSCallbackObject::toBoolean):
              (KJS::JSCallbackObject::toNumber):
              (KJS::JSCallbackObject::toString):
              * API/JSClassRef.cpp:
              (JSClassCreate):
              * API/JSContextRef.cpp:
              (JSContextCreate):
              (JSContextSetException):
              * API/JSContextRef.h:
              * API/JSNode.c:
              (JSNodePrototype_class):
              (JSNode_class):
              * API/JSNodeList.c:
              (JSNodeListPrototype_class):
              (JSNodeList_class):
              * API/JSObjectRef.cpp:
              (JSObjectGetProperty):
              (JSObjectGetPrivate):
              (JSObjectSetPrivate):
              (JSObjectCallAsFunction):
              (JSObjectCallAsConstructor):
              (JSPropertyEnumeratorGetNext):
              * API/JSObjectRef.h:
              * API/JSStringBufferRef.cpp:
              (JSStringBufferCreateCF):
              * API/JSStringBufferRef.h:
              * API/JSValueRef.cpp:
              (JSValueIsInstanceOf):
              * API/JSValueRef.h:
              * API/minidom.c:
              (main):
              * API/minidom.js:
              * API/testapi.c:
              (MyObject_hasProperty):
              (MyObject_setProperty):
              (MyObject_deleteProperty):
              (MyObject_getPropertyList):
              (MyObject_convertToType):
              (MyObject_class):
              (main):
              * JavaScriptCore.exp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      554ad6fb
    • lweintraub's avatar
      Reviewed by NOBODY · bec59b8c
      lweintraub authored
              Missed a few in the last update...
      
              * fast/forms/input-delete-expected.txt:
              * fast/repaint/inline-outline-repaint-expected.txt:
              * fast/repaint/selection-after-delete-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bec59b8c
    • lweintraub's avatar
      LayoutTests: · 1bb7d0bf
      lweintraub authored
              Reviewed by justin
      
              Deletion editing deligates now show up!
      
              * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * editing/deleting/delete-3608430-fix-expected.txt:
              * editing/deleting/delete-3608445-fix-expected.txt:
              * editing/deleting/delete-3608462-fix-expected.txt:
              * editing/deleting/delete-3775172-fix-expected.txt:
              * editing/deleting/delete-3800834-fix-expected.txt:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-3865854-fix-expected.txt:
              * editing/deleting/delete-3928305-fix-expected.txt:
              * editing/deleting/delete-3959464-fix-expected.txt:
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/deleting/delete-4083333-fix-expected.txt:
              * editing/deleting/delete-after-span-ws-001-expected.txt:
              * editing/deleting/delete-after-span-ws-002-expected.txt:
              * editing/deleting/delete-after-span-ws-003-expected.txt:
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-and-undo-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
              * editing/deleting/delete-block-contents-001-expected.txt:
              * editing/deleting/delete-block-contents-002-expected.txt:
              * editing/deleting/delete-block-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-block-merge-contents-023-expected.txt:
              * editing/deleting/delete-block-merge-contents-024-expected.txt:
              * editing/deleting/delete-br-001-expected.txt:
              * editing/deleting/delete-br-002-expected.txt:
              * editing/deleting/delete-br-003-expected.txt:
              * editing/deleting/delete-br-004-expected.txt:
              * editing/deleting/delete-br-005-expected.txt:
              * editing/deleting/delete-br-006-expected.txt:
              * editing/deleting/delete-br-007-expected.txt:
              * editing/deleting/delete-br-008-expected.txt:
              * editing/deleting/delete-br-009-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-br-011-expected.txt:
              * editing/deleting/delete-character-001-expected.txt:
              * editing/deleting/delete-contiguous-ws-001-expected.txt:
              * editing/deleting/delete-image-001-expected.txt:
              * editing/deleting/delete-image-002-expected.txt:
              * editing/deleting/delete-image-003-expected.txt:
              * editing/deleting/delete-image-004-expected.txt:
              * editing/deleting/delete-leading-ws-001-expected.txt:
              * editing/deleting/delete-line-001-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-003-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-005-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-009-expected.txt:
              * editing/deleting/delete-line-010-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-line-013-expected.txt:
              * editing/deleting/delete-line-014-expected.txt:
              * editing/deleting/delete-line-015-expected.txt:
              * editing/deleting/delete-line-016-expected.txt:
              * editing/deleting/delete-line-017-expected.txt:
              * editing/deleting/delete-line-end-ws-001-expected.txt:
              * editing/deleting/delete-line-end-ws-002-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-listitem-002-expected.txt:
              * editing/deleting/delete-select-all-001-expected.txt:
              * editing/deleting/delete-select-all-002-expected.txt:
              * editing/deleting/delete-select-all-003-expected.txt:
              * editing/deleting/delete-selection-001-expected.txt:
              * editing/deleting/delete-tab-001-expected.txt:
              * editing/deleting/delete-tab-002-expected.txt:
              * editing/deleting/delete-tab-003-expected.txt:
              * editing/deleting/delete-tab-004-expected.txt:
              * editing/deleting/delete-trailing-ws-001-expected.txt:
              * editing/deleting/delete-trailing-ws-002-expected.txt:
              * editing/deleting/delete-ws-fixup-001-expected.txt:
              * editing/deleting/delete-ws-fixup-002-expected.txt:
              * editing/deleting/delete-ws-fixup-003-expected.txt:
              * editing/deleting/delete-ws-fixup-004-expected.txt:
              * editing/deleting/forward-delete-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-endOfParagraph-expected.txt:
              * editing/deleting/merge-into-empty-block-1-expected.txt:
              * editing/deleting/merge-into-empty-block-2-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/merge-unrendered-space-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/deleting/smart-delete-001-expected.txt:
              * editing/deleting/smart-delete-002-expected.txt:
              * editing/deleting/table-cells-expected.txt:
              * editing/execCommand/insertHTML-expected.txt:
              * editing/input/text-input-controller-expected.txt:
              * editing/inserting/insert-3775316-fix-expected.txt:
              * editing/inserting/insert-3851164-fix-expected.txt:
              * editing/inserting/insert-after-delete-001-expected.txt:
              * editing/inserting/insert-div-021-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4076267-3-expected.txt:
              * editing/pasteboard/4076267-expected.txt:
              * editing/pasteboard/paste-table-002-expected.txt:
              * editing/pasteboard/paste-text-015-expected.txt:
              * editing/selection/move-between-blocks-no-001-expected.txt:
              * editing/selection/select-all-iframe-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/style-3681552-fix-002-expected.txt:
              * editing/style/typing-style-001-expected.txt:
              * editing/style/typing-style-002-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
              * editing/unsupported-content/list-delete-002-expected.txt:
              * editing/unsupported-content/list-delete-003-expected.txt:
              * editing/unsupported-content/table-delete-001-expected.txt:
              * editing/unsupported-content/table-delete-002-expected.txt:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * fast/forms/input-text-option-delete-expected.checksum:
              * fast/forms/input-text-option-delete-expected.txt:
      
      WebCore:
      
              Reviewed by justin
      
              Allowed deletion typing commands to take in a granularity
      
              * bridge/mac/WebCoreFrameBridge.h: Pass granularity across the bridge
              * bridge/mac/WebCoreFrameBridge.mm: Ditto
              (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
              (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
              * editing/TypingCommand.cpp: Constructors take in a granularity
              (WebCore::TypingCommand::TypingCommand):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/TypingCommand.h: ditto
              * page/Frame.h: Fixed bug that shouldDeleteSelection wasn't virtual
      
      WebKit:
      
              Reviewed by justin
      
              Finished moving deletion selection expansion across the bridge... say that 3 times fast.
      
              * WebView/WebHTMLView.m:  Pass granularity to WebCore to handle expansion
              (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
              (-[WebHTMLView _deleteSelection]):
              (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
              (-[NSArray deleteToMark:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bb7d0bf
    • beidson's avatar
      Reviewed by Anders and Tim Hatcher · f39c2c2e
      beidson authored
              Added an accessor to a SQLite config option to change its disk-syncing behavior.
              Used this accessor to significantly speed up writes to the Icon DB.
      
              * icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):  Disable full syncing to the SQLite db to speed up writes to the icondb
      
              * icon/SQLDatabase.cpp:
              (SQLDatabase::setFullsync):
              (SQLDatabase::setSynchronous):
              * icon/SQLDatabase.h:
              (WebCore::SQLDatabase::):  Added accessor to the SQLite config pragma "synchronous"
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f39c2c2e
    • darin's avatar
      Reviewed by Maciej. · f6420c4e
      darin authored
              - fixed a storage leak noticed by the buildbot
      
              * dom/Document.cpp: (WebCore::Document::removedLastRef):
              Call delete on the markers before clearing the map containing them.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6420c4e
    • andersca's avatar
      2006-07-08 Anders Carlsson <acarlsson@apple.com> · ee9cb8ce
      andersca authored
              Reviewed by Brady.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9777
              Reproducible crash in Loading/Frames in ToT.
              
              The problem was that the renderpart destructor resets the frame's 
              owner element. For iframes, this should only be done when the element is 
              going to be removed from the document.
              
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::~HTMLIFrameElement):
              (WebCore::HTMLIFrameElement::willRemove):
              (WebCore::HTMLIFrameElement::removedFromDocument):
              (WebCore::HTMLIFrameElement::detach):        
              * html/HTMLIFrameElement.h:
              Remove the frame in willRemove instead.
              
              * rendering/RenderPart.cpp:
              (WebCore::RenderPart::RenderPart):
              (WebCore::RenderPart::~RenderPart):
              * rendering/RenderPart.h:
              Don't call setFrame(0) in the destructor when the element is an iframe element.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee9cb8ce
    • darin's avatar
      Reviewed by Anders. · ffcfdbfc
      darin authored
              - fixed a storage leak noticed by the buildbot
      
              * page/FrameView.cpp: (WebCore::FrameViewPrivate::~FrameViewPrivate):
              Delete m_scheduledEvents.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffcfdbfc
    • sullivan's avatar
      Added a bug number to an existing entry. · 022d8cc6
      sullivan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      022d8cc6
    • darin's avatar
      Reviewed by Adele. · 3e71c118
      darin authored
              - fixed a couple of storage leaks noticed by the buildbot
      
              * html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach):
              Call deref on the style after calling setRenderStyle, since styleForRenderer
              returns us a "ref'd" RenderStyle object.
              * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e71c118
    • darin's avatar
      Reviewed by Adele. · 22a690e4
      darin authored
              - fix some license mistakes
      
              * LICENSE-APPLE: Added more years of publication to the copyright here.
      
              * html/CanvasGradient.idl: Corrected license on this file. It had the wrong one.
              * html/CanvasPattern.idl: Ditto.
              * html/CanvasRenderingContext2D.idl: Ditto.
              * html/HTMLCanvasElement.idl: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22a690e4
    • beidson's avatar
      Reviewed by John · cc1903cb
      beidson authored
              Changed an ASSERT to a LOG_ERROR for an error that could be handled gracefully, but
              whose assertion was reproducibly causing a build bot failure
      
              * Misc/WebIconDatabase.m:
              (-[WebIconDatabase _releaseIconForIconURLString:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc1903cb
    • ggaren's avatar
      Reviewed by John. · a7735565
      ggaren authored
              
              - Fixed a few crashes resulting from NULL parameters to JSClassCreate.
      
              * API/JSClassRef.cpp:
              (JSClassCreate):
              (JSClassRelease):
              * API/testapi.c: Added test for NULL parameters.
              (main):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7735565
    • ggaren's avatar
      Reviewed by John, mocked by Darin. · 80b420ae
      ggaren authored
              
              - Changed JSEvaluate to take a JSObjectRef instead of a JSValueRef as
              "this," since "this" must be an object.
      
              * API/JSContextRef.cpp:
              (JSEvaluate):
              * API/JSContextRef.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80b420ae
    • ggaren's avatar
      Reviewed by John. · ab28d0b7
      ggaren authored
              
              - More headerdoc
      
              * API/JSBase.h:
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab28d0b7
    • lweintraub's avatar
      LayoutTests: · 6d377800
      lweintraub authored
              Reviewed by justin
      
              Improved table editing
      
              * editing/deleting/delete-to-select-table-expected.checksum: Added.
              * editing/deleting/delete-to-select-table-expected.png: Added.
              * editing/deleting/delete-to-select-table-expected.txt: Added.
              * editing/deleting/delete-to-select-table.html: Added.
              * editing/input/text-input-controller-expected.txt:
      
      WebCore:
      
              Reviewed by justin
      
              Improved table editing: pressing delete directly before or after a table will now select
              the table first, then delete it, instead of just deleting it. Useful for when the table's
              existence is non-obvious.
      
              * bridge/mac/FrameMac.h: Added shouldDeleteSelection, which allows WebCore to trigger
              deletion editing deligates
              * bridge/mac/FrameMac.mm: ditto
              (WebCore::FrameMac::shouldDeleteSelection):
              * bridge/mac/WebCoreFrameBridge.h: ditto
              * editing/TypingCommand.cpp: Implemented check for a caret position next to a table, and
              subsequent selection (as opposed to removal)
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * page/Frame.cpp: shouldDeleteSelection added
              (WebCore::Frame::shouldDeleteSelection):
              * page/Frame.h: ditto
      
      WebKit:
      
              Reviewed by justin
      
              Improved table editing
      
              * WebCoreSupport/WebFrameBridge.m: Added method to allow WebCore to trigger
              deletion editing delegate
              (-[WebFrameBridge shouldDeleteSelectedDOMRange:]):
              * WebView/WebHTMLView.m: Moved code that expanded a selection when the delete
              key is pressed over to WebCore so we can be more intelligent about how to handle it
              (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]):
              (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d377800
    • weinig's avatar
      Reviewed by Eric. · 22601712
      weinig authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9768
                Split XSLImportRule out of XSLStyleSheet.* into separate 
                files (one class per file).
      
              * WebCore.xcodeproj/project.pbxproj:
              * xml/XSLImportRule.cpp: Added.
              (WebCore::XSLImportRule::XSLImportRule):
              (WebCore::XSLImportRule::parentStyleSheet):
              (WebCore::XSLImportRule::loadSheet):
              * xml/XSLImportRule.h: Added.
              * xml/XSLStyleSheet.cpp:
              * xml/XSLStyleSheet.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22601712
    • andersca's avatar
      WebCore: · 10c1e341
      andersca authored
      2006-07-07  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8300
              REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons
              
              * css/html4.css:
              Set "-webkit-user-select: ignore" on radio buttons and check boxes .
              
      LayoutTests:
      
      2006-07-07  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8300
              REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons
      
              * fast/forms/radio-check-click-and-drag-expected.txt: Added.
              * fast/forms/radio-check-click-and-drag.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10c1e341
    • sullivan's avatar
      Reviewed by Tim Hatcher · dc734562
      sullivan authored
              * WebKit.exp:
              added surprisingly missing _WebPreferencesChangedNotification, defined in
              WebPreferences.h
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc734562
    • mjs's avatar
      Reviewed by Tim Hatcher. · 1e8c96ae
      mjs authored
              - fix 20 Node leaks on fast/events tests - these should be the last ones
      
              * bindings/objc/DOMEvents.mm:
              (-[DOMEvent dealloc]): implement - deref the event!
              (-[DOMEvent finalize]): ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e8c96ae
  4. 06 Jul, 2006 2 commits
    • mjs's avatar
      Reviewed by Tim Hatcher. · e2d9abc1
      mjs authored
              - fix 26 Node leaks on fast/dom tests
      
              * dom/Document.cpp:
              (WebCore::Document::removedLastRef): delete tokenizer - if we are still parsing at this point, we don't
              want nodes held by the parser to keep the document alive.
              * html/HTMLParser.cpp:
              (WebCore::RefNonDocNodePtr::RefNonDocNodePtr): Smart pointer that acts like RefPtr for Node,
              but avoids refing document nodes to avoid cycles.
              (WebCore::RefNonDocNodePtr::~RefNonDocNodePtr):
              (WebCore::RefNonDocNodePtr::get):
              (WebCore::RefNonDocNodePtr::operator*):
              (WebCore::RefNonDocNodePtr::operator->):
              (WebCore::RefNonDocNodePtr::operator!):
              (WebCore::RefNonDocNodePtr::operator UnspecifiedBoolType):
              (WebCore::RefNonDocNodePtr::operator=):
              (WebCore::operator==):
              (WebCore::operator!=):
              (WebCore::HTMLStackElem): Use a RefNonDocNodePtr instead of RefPtr<Node>
              (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Use a RefPtr here to avoid crashing
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2d9abc1
    • adele's avatar
      Reviewed by Maciej. · c1577332
      adele authored
              Fixed new popup control to open up when the spacebar and the up and down arrows are pressed.
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9762
              [Native pop up] Highlighted item text is black instead of white
      
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::isKeyboardFocusable): Added.
              (WebCore::HTMLSelectElement::isMouseFocusable): Added.
              (WebCore::HTMLSelectElement::defaultEventHandler): Updated to showPopup for up and down arrow keys and spacebar.
              * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Made this const.
              * rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Added FIXME.
              * rendering/RenderPopupMenuMac.mm:
              (WebCore::RenderPopupMenuMac::showPopup): Updated to save the NSEvent that triggers the popup, so we can send
              fake mouseUp and keyUp events when the NSMenu returns.
              (WebCore::RenderPopupMenuMac::addGroupLabel): Only set the NSForegroundColorAttributeName attribute if the text isn't black.
              Follow-up bug about other colors: http://bugzilla.opendarwin.org/show_bug.cgi?id=9769
              (WebCore::RenderPopupMenuMac::addOption): ditto.
              * bridge/mac/FrameMac.h: (WebCore::FrameMac::currentEvent): Returns the current NSEvent.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1577332