1. 23 Jan, 2013 1 commit
    • mark.lam@apple.com's avatar
      Change the Supplementable class to not use AtomicString. · e69ee170
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107535.
      
      Reviewed by Adam Barth.
      
      Replaced the use of AtomicString keys with literal const char* keys.
      This simplifies the SupplementMap and makes it slightly leaner and faster.
      
      Source/WebCore: 
      
      No new tests.
      
      * Modules/battery/BatteryController.cpp:
      (WebCore::BatteryController::supplementName):
      * Modules/battery/BatteryController.h:
      (BatteryController):
      * Modules/battery/NavigatorBattery.cpp:
      (WebCore::NavigatorBattery::supplementName):
      (WebCore):
      (WebCore::NavigatorBattery::from):
      * Modules/battery/NavigatorBattery.h:
      (NavigatorBattery):
      * Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
      (WebCore::DraggedIsolatedFileSystem::supplementName):
      * Modules/filesystem/chromium/DraggedIsolatedFileSystem.h:
      (DraggedIsolatedFileSystem):
      * Modules/gamepad/NavigatorGamepad.cpp:
      (WebCore::NavigatorGamepad::supplementName):
      (WebCore):
      (WebCore::NavigatorGamepad::from):
      * Modules/gamepad/NavigatorGamepad.h:
      (NavigatorGamepad):
      * Modules/geolocation/GeolocationController.cpp:
      (WebCore::GeolocationController::supplementName):
      * Modules/geolocation/GeolocationController.h:
      (GeolocationController):
      * Modules/geolocation/NavigatorGeolocation.cpp:
      (WebCore::NavigatorGeolocation::supplementName):
      (WebCore):
      (WebCore::NavigatorGeolocation::from):
      * Modules/geolocation/NavigatorGeolocation.h:
      (NavigatorGeolocation):
      * Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
      (WebCore::DOMWindowIndexedDatabase::supplementName):
      (WebCore):
      (WebCore::DOMWindowIndexedDatabase::from):
      * Modules/indexeddb/DOMWindowIndexedDatabase.h:
      (DOMWindowIndexedDatabase):
      * Modules/indexeddb/PageGroupIndexedDatabase.cpp:
      (WebCore::PageGroupIndexedDatabase::supplementName):
      (WebCore):
      (WebCore::PageGroupIndexedDatabase::from):
      * Modules/indexeddb/PageGroupIndexedDatabase.h:
      (PageGroupIndexedDatabase):
      * Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
      (WebCore::WorkerContextIndexedDatabase::supplementName):
      (WebCore):
      (WebCore::WorkerContextIndexedDatabase::from):
      * Modules/indexeddb/WorkerContextIndexedDatabase.h:
      (WorkerContextIndexedDatabase):
      * Modules/intents/DOMWindowIntents.cpp:
      (WebCore::DOMWindowIntents::supplementName):
      (WebCore):
      (WebCore::DOMWindowIntents::from):
      * Modules/intents/DOMWindowIntents.h:
      (DOMWindowIntents):
      * Modules/mediastream/UserMediaController.cpp:
      (WebCore::UserMediaController::supplementName):
      * Modules/mediastream/UserMediaController.h:
      (UserMediaController):
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
      (WebCore::NavigatorContentUtils::supplementName):
      * Modules/navigatorcontentutils/NavigatorContentUtils.h:
      (NavigatorContentUtils):
      * Modules/networkinfo/NavigatorNetworkInfoConnection.cpp:
      (WebCore::NavigatorNetworkInfoConnection::supplementName):
      (WebCore):
      (WebCore::NavigatorNetworkInfoConnection::from):
      * Modules/networkinfo/NavigatorNetworkInfoConnection.h:
      (NavigatorNetworkInfoConnection):
      * Modules/networkinfo/NetworkInfoController.cpp:
      (WebCore::NetworkInfoController::supplementName):
      * Modules/networkinfo/NetworkInfoController.h:
      (NetworkInfoController):
      * Modules/notifications/DOMWindowNotifications.cpp:
      (WebCore::DOMWindowNotifications::supplementName):
      (WebCore):
      (WebCore::DOMWindowNotifications::from):
      * Modules/notifications/DOMWindowNotifications.h:
      (DOMWindowNotifications):
      * Modules/notifications/NotificationController.cpp:
      (WebCore::NotificationController::supplementName):
      * Modules/notifications/NotificationController.h:
      (NotificationController):
      * Modules/notifications/WorkerContextNotifications.cpp:
      (WebCore::WorkerContextNotifications::supplementName):
      (WebCore):
      (WebCore::WorkerContextNotifications::from):
      * Modules/notifications/WorkerContextNotifications.h:
      (WorkerContextNotifications):
      * Modules/quota/DOMWindowQuota.cpp:
      (WebCore::DOMWindowQuota::supplementName):
      (WebCore):
      (WebCore::DOMWindowQuota::from):
      * Modules/quota/DOMWindowQuota.h:
      (DOMWindowQuota):
      * Modules/speech/DOMWindowSpeechSynthesis.cpp:
      (WebCore::DOMWindowSpeechSynthesis::supplementName):
      (WebCore):
      (WebCore::DOMWindowSpeechSynthesis::from):
      * Modules/speech/DOMWindowSpeechSynthesis.h:
      (DOMWindowSpeechSynthesis):
      * Modules/speech/SpeechRecognitionController.cpp:
      (WebCore::SpeechRecognitionController::supplementName):
      * Modules/speech/SpeechRecognitionController.h:
      (SpeechRecognitionController):
      * Modules/vibration/Vibration.cpp:
      (WebCore::Vibration::supplementName):
      * Modules/vibration/Vibration.h:
      (Vibration):
      * Modules/webdatabase/DatabaseContext.cpp:
      (WebCore::DatabaseContext::supplementName):
      (WebCore):
      (WebCore::DatabaseContext::existingDatabaseContextFrom):
      (WebCore::DatabaseContext::from):
      * Modules/webdatabase/DatabaseContext.h:
      (DatabaseContext):
      * dom/ContextFeatures.cpp:
      (WebCore::ContextFeatures::supplementName):
      * dom/ContextFeatures.h:
      * dom/DeviceMotionController.cpp:
      (WebCore::DeviceMotionController::supplementName):
      * dom/DeviceMotionController.h:
      (DeviceMotionController):
      * dom/DeviceOrientationController.cpp:
      (WebCore::DeviceOrientationController::supplementName):
      * dom/DeviceOrientationController.h:
      (DeviceOrientationController):
      * loader/PrerendererClient.cpp:
      (WebCore::PrerendererClient::supplementName):
      * loader/PrerendererClient.h:
      (PrerendererClient):
      * page/DOMWindowPagePopup.cpp:
      (WebCore::DOMWindowPagePopup::supplementName):
      * page/DOMWindowPagePopup.h:
      (DOMWindowPagePopup):
      * page/SpeechInput.cpp:
      (WebCore::SpeechInput::supplementName):
      * page/SpeechInput.h:
      (SpeechInput):
      * platform/RefCountedSupplement.h:
      (WebCore::RefCountedSupplement::provideTo):
      (WebCore::RefCountedSupplement::from):
      * platform/Supplementable.h:
      (WebCore):
      (WebCore::Supplement::provideTo):
      (WebCore::Supplement::from):
      (WebCore::Supplementable::provideSupplement):
      (WebCore::Supplementable::removeSupplement):
      (WebCore::Supplementable::requireSupplement):
      (Supplementable):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::supplementName):
      (WebCore):
      (WebCore::InternalSettings::from):
      * testing/InternalSettings.h:
      (InternalSettings):
      
      Source/WebKit/chromium: 
      
      * src/ContextFeaturesClientImpl.cpp:
      (ContextFeaturesCache):
      (WebKit::ContextFeaturesCache::supplementName):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e69ee170
  2. 09 Nov, 2012 1 commit
    • benjamin@webkit.org's avatar
      Improve the use of AtomicString with literals · dbf9529b
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101298
      
      Reviewed by Darin Adler.
      
      Fix a bunch of cases of AtomicString with literals:
      -Do not create temporary AtomicString to perform a comparison, that is very wasteful.
      -Use the ConstructFromLiteral constructor whenever it makes sense.
      -Make "x-frame-options" static instead of creating it for each response.
      -Use ASCIILiteral() instead of AtomicString() in EventHandler, the function takes a String,
       not an AtomicString.
      
      * Modules/battery/BatteryController.cpp:
      (WebCore::BatteryController::supplementName):
      * Modules/battery/NavigatorBattery.cpp:
      (WebCore::NavigatorBattery::from):
      * Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
      (WebCore::DraggedIsolatedFileSystem::supplementName):
      * Modules/gamepad/NavigatorGamepad.cpp:
      (WebCore::NavigatorGamepad::from):
      * Modules/geolocation/GeolocationController.cpp:
      (WebCore::GeolocationController::supplementName):
      * Modules/geolocation/NavigatorGeolocation.cpp:
      (WebCore::NavigatorGeolocation::from):
      * Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
      (WebCore::DOMWindowIndexedDatabase::from):
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::directionNext):
      (WebCore::IDBCursor::directionNextUnique):
      (WebCore::IDBCursor::directionPrev):
      (WebCore::IDBCursor::directionPrevUnique):
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::readyState):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::modeReadOnly):
      (WebCore::IDBTransaction::modeReadWrite):
      (WebCore::IDBTransaction::modeVersionChange):
      (WebCore::IDBTransaction::modeReadOnlyLegacy):
      (WebCore::IDBTransaction::modeReadWriteLegacy):
      * Modules/indexeddb/PageGroupIndexedDatabase.cpp:
      (WebCore::PageGroupIndexedDatabase::from):
      * Modules/intents/DOMWindowIntents.cpp:
      (WebCore::DOMWindowIntents::from):
      * Modules/mediastream/UserMediaController.cpp:
      (WebCore::UserMediaController::supplementName):
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
      (WebCore::NavigatorContentUtils::supplementName):
      * Modules/networkinfo/NavigatorNetworkInfoConnection.cpp:
      (WebCore::NavigatorNetworkInfoConnection::from):
      * Modules/networkinfo/NetworkInfoController.cpp:
      (WebCore::NetworkInfoController::supplementName):
      * Modules/notifications/DOMWindowNotifications.cpp:
      (WebCore::DOMWindowNotifications::from):
      * Modules/notifications/NotificationController.cpp:
      (WebCore::NotificationController::supplementName):
      * Modules/quota/DOMWindowQuota.cpp:
      (WebCore::DOMWindowQuota::from):
      * Modules/speech/SpeechRecognitionController.cpp:
      (WebCore::SpeechRecognitionController::supplementName):
      * Modules/vibration/Vibration.cpp:
      (WebCore::Vibration::supplementName):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::invalidStatus):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
      (WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::V8DOMWindow::namedSecurityCheck):
      * bindings/v8/custom/V8NodeListCustom.cpp:
      (WebCore::V8NodeList::namedPropertyGetter):
      * dom/ContextFeatures.cpp:
      (WebCore::ContextFeatures::supplementName):
      * dom/DeviceMotionController.cpp:
      (WebCore::DeviceMotionController::supplementName):
      * dom/DeviceOrientationController.cpp:
      (WebCore::DeviceOrientationController::supplementName):
      * dom/Element.cpp:
      (WebCore::Element::webkitRegionOverset):
      * dom/MutationRecord.cpp:
      * html/FileInputType.cpp:
      (WebCore::UploadButtonElement::shadowPseudoId):
      * html/FormController.cpp:
      (WebCore::SavedFormState::getReferencedFilePaths):
      (WebCore::FormKeyGenerator::formKey):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::formControlType):
      * html/HTMLDetailsElement.cpp:
      (WebCore::summaryQuerySelector):
      * html/HTMLFieldSetElement.cpp:
      (WebCore::HTMLFieldSetElement::formControlType):
      * html/HTMLKeygenElement.cpp:
      (WebCore::KeygenSelectElement::shadowPseudoId):
      (WebCore::HTMLKeygenElement::formControlType):
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::formControlType):
      * html/HTMLOutputElement.cpp:
      (WebCore::HTMLOutputElement::formControlType):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::formControlType):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::formControlType):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::directionString):
      * html/shadow/DateTimeEditElement.cpp:
      (WebCore::DateTimeEditElement::DateTimeEditElement):
      * html/shadow/DateTimeFieldElements.cpp:
      (WebCore::DateTimeAMPMFieldElement::create):
      (WebCore::DateTimeDayFieldElement::create):
      (WebCore::DateTimeHourFieldElement::create):
      (WebCore::DateTimeMillisecondFieldElement::create):
      (WebCore::DateTimeMinuteFieldElement::create):
      (WebCore::DateTimeMonthFieldElement::create):
      (WebCore::DateTimeSecondFieldElement::create):
      (WebCore::DateTimeSymbolicMonthFieldElement::create):
      (WebCore::DateTimeWeekFieldElement::create):
      (WebCore::DateTimeYearFieldElement::create):
      * html/shadow/DetailsMarkerControl.cpp:
      (WebCore::DetailsMarkerControl::shadowPseudoId):
      * html/shadow/ImageInnerElement.cpp:
      (WebCore::ImageInnerElement::shadowPseudoId):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::shadowPseudoId):
      (WebCore::MediaControlTimelineContainerElement::shadowPseudoId):
      (WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId):
      (WebCore::MediaControlStatusDisplayElement::shadowPseudoId):
      (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId):
      (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId):
      (WebCore::MediaControlPlayButtonElement::shadowPseudoId):
      (WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId):
      (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId):
      (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId):
      (WebCore::MediaControlRewindButtonElement::shadowPseudoId):
      (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId):
      (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
      (WebCore::MediaControlTimelineElement::shadowPseudoId):
      (WebCore::MediaControlVolumeSliderElement::shadowPseudoId):
      (WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId):
      (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId):
      (WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId):
      (WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId):
      (WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId):
      (WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId):
      (WebCore::MediaControlTextTrackContainerElement::shadowPseudoId):
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::shadowPseudoId):
      * html/shadow/MediaControlRootElementChromium.cpp:
      (WebCore::MediaControlPanelEnclosureElement::shadowPseudoId):
      (WebCore::MediaControlRootElementChromium::shadowPseudoId):
      * html/shadow/MediaControlRootElementChromiumAndroid.cpp:
      (WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId):
      * html/shadow/MeterShadowElement.cpp:
      (WebCore::MeterInnerElement::shadowPseudoId):
      (WebCore::MeterBarElement::shadowPseudoId):
      (WebCore::MeterValueElement::shadowPseudoId):
      * html/shadow/ProgressShadowElement.cpp:
      (WebCore::ProgressInnerElement::shadowPseudoId):
      (WebCore::ProgressBarElement::shadowPseudoId):
      (WebCore::ProgressValueElement::shadowPseudoId):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::sliderThumbShadowPseudoId):
      (WebCore::mediaSliderThumbShadowPseudoId):
      (WebCore::SliderContainerElement::shadowPseudoId):
      * html/shadow/SpinButtonElement.cpp:
      (WebCore::SpinButtonElement::shadowPseudoId):
      * html/shadow/TextControlInnerElements.cpp:
      (WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
      (WebCore::SearchFieldCancelButtonElement::shadowPseudoId):
      (WebCore::InputFieldSpeechButtonElement::shadowPseudoId):
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId):
      * loader/CrossOriginAccessControl.cpp:
      (WebCore::passesAccessControlCheck):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::didReceiveResponse):
      * loader/PrerendererClient.cpp:
      (WebCore::PrerendererClient::supplementName):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::updateResponseAfterRevalidation):
      * page/DOMWindowPagePopup.cpp:
      (WebCore::DOMWindowPagePopup::supplementName):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handlePasteGlobalSelection):
      (WebCore::focusDirectionForKey):
      * page/SpeechInput.cpp:
      (WebCore::SpeechInput::supplementName):
      * page/animation/CompositeAnimation.cpp:
      (WebCore::CompositeAnimation::updateKeyframeAnimations):
      * platform/graphics/FontCache.cpp:
      (WebCore::alternateFamilyName):
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::applicationOctetStream):
      (WebCore::textPlain):
      (WebCore::codecs):
      * platform/graphics/chromium/FontCacheAndroid.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/filters/SourceAlpha.cpp:
      (WebCore::SourceAlpha::effectName):
      * platform/graphics/filters/SourceGraphic.cpp:
      (WebCore::SourceGraphic::effectName):
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/skia/FontCacheSkia.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/win/FontCacheWin.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/wx/FontCacheWx.cpp:
      (WebCore::FontCache::getSimilarFontPlatformData):
      * platform/network/ResourceResponseBase.cpp:
      (WebCore::ResourceResponseBase::setHTTPHeaderField):
      (WebCore::ResourceResponseBase::parseCacheControlDirectives):
      (WebCore::ResourceResponseBase::hasCacheValidatorFields):
      (WebCore::ResourceResponseBase::date):
      (WebCore::ResourceResponseBase::age):
      (WebCore::ResourceResponseBase::expires):
      (WebCore::ResourceResponseBase::lastModified):
      (WebCore::ResourceResponseBase::isAttachment):
      * rendering/RenderTextControlMultiLine.cpp:
      (WebCore::RenderTextControlMultiLine::getAvgCharWidth):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::getAvgCharWidth):
      (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      * svg/SVGAnimateColorElement.cpp:
      (WebCore::attributeValueIsCurrentColor):
      * svg/SVGAnimateMotionElement.cpp:
      (WebCore::SVGAnimateMotionElement::rotateMode):
      * svg/SVGAnimationElement.cpp:
      (WebCore::SVGAnimationElement::setCalcMode):
      (WebCore::SVGAnimationElement::setAttributeType):
      (WebCore::SVGAnimationElement::isAdditive):
      (WebCore::SVGAnimationElement::isAccumulated):
      (WebCore::inheritsFromProperty):
      * svg/SVGFEConvolveMatrixElement.cpp:
      (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier):
      (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier):
      (WebCore::SVGFEConvolveMatrixElement::orderXIdentifier):
      (WebCore::SVGFEConvolveMatrixElement::orderYIdentifier):
      * svg/SVGFEDiffuseLightingElement.cpp:
      (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier):
      (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier):
      * svg/SVGFEDropShadowElement.cpp:
      (WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier):
      (WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier):
      * svg/SVGFEGaussianBlurElement.cpp:
      (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier):
      (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier):
      * svg/SVGFEMorphologyElement.cpp:
      (WebCore::SVGFEMorphologyElement::radiusXIdentifier):
      (WebCore::SVGFEMorphologyElement::radiusYIdentifier):
      * svg/SVGFESpecularLightingElement.cpp:
      (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier):
      (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier):
      * svg/SVGFETurbulenceElement.cpp:
      (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier):
      (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier):
      * svg/SVGFilterElement.cpp:
      (WebCore::SVGFilterElement::filterResXIdentifier):
      (WebCore::SVGFilterElement::filterResYIdentifier):
      * svg/SVGLangSpace.cpp:
      (WebCore::SVGLangSpace::xmlspace):
      (WebCore::SVGLangSpace::addSupportedAttributes):
      * svg/SVGMarkerElement.cpp:
      (WebCore::SVGMarkerElement::orientTypeIdentifier):
      (WebCore::SVGMarkerElement::orientAngleIdentifier):
      (WebCore::SVGMarkerElement::synchronizeOrientType):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::contentScriptType):
      (WebCore::SVGSVGElement::contentStyleType):
      * svg/SVGStyleElement.cpp:
      (WebCore::SVGStyleElement::type):
      (WebCore::SVGStyleElement::media):
      * svg/SVGTextContentElement.cpp:
      (WebCore::SVGTextContentElement::collectStyleForAttribute):
      * svg/SVGViewSpec.cpp:
      (WebCore::SVGViewSpec::viewBoxIdentifier):
      (WebCore::SVGViewSpec::preserveAspectRatioIdentifier):
      (WebCore::SVGViewSpec::transformIdentifier):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::parseClockValue):
      (WebCore::SVGSMILElement::restart):
      (WebCore::SVGSMILElement::fill):
      (WebCore::SVGSMILElement::repeatCount):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::from):
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::processDOCTYPE):
      (WebCore::XMLTreeBuilder::processXMLEntity):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbf9529b
  3. 29 Aug, 2012 1 commit
    • abarth@webkit.org's avatar
      Convert more static Strings to use ASCIILiteral · b1e7d635
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95313
      
      Reviewed by Eric Seidel.
      
      This patch converts another swath of static strings to use ASCIILiteral
      as recommended by http://trac.webkit.org/wiki/EfficientStrings.
      
      * Modules/mediasource/MediaSource.cpp:
      (WebCore::MediaSource::openKeyword):
      (WebCore):
      (WebCore::MediaSource::closedKeyword):
      (WebCore::MediaSource::endedKeyword):
      * Modules/mediasource/MediaSource.h:
      (MediaSource):
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
      (WebCore::customHandlersStateString):
      * Modules/notifications/Notification.cpp:
      (WebCore::Notification::permissionString):
      * accessibility/AccessibilityMediaControls.cpp:
      (WebCore::AccessibilityMediaControl::controlTypeName):
      (WebCore::AccessibilityMediaControl::title):
      (WebCore::AccessibilityMediaControlsContainer::elementTypeName):
      (WebCore::AccessibilityMediaTimeline::helpText):
      * bindings/js/JSInspectorFrontendHostCustom.cpp:
      (WebCore::JSInspectorFrontendHost::platform):
      (WebCore::JSInspectorFrontendHost::port):
      * bindings/js/ScriptEventListener.cpp:
      (WebCore::eventParameterName):
      * bindings/v8/ScriptEventListener.cpp:
      (WebCore::eventParameterName):
      * css/CSSWrapShapes.cpp:
      (WebCore::CSSWrapShapeRectangle::cssText):
      (WebCore::CSSWrapShapeCircle::cssText):
      (WebCore::CSSWrapShapeEllipse::cssText):
      (WebCore::CSSWrapShapePolygon::cssText):
      * css/StyleSheetContents.cpp:
      (WebCore::StyleSheetContents::parseAuthorStyleSheet):
      * dom/Document.cpp:
      (WebCore::Document::readyState):
      * editing/MarkupAccumulator.cpp:
      (WebCore::appendCharactersReplacingEntities):
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
      (WebCore::StyledMarkupAccumulator::styleNodeCloseTag):
      (WebCore::StyledMarkupAccumulator::appendElement):
      (WebCore::createMarkup):
      * html/track/TextTrackCue.cpp:
      (WebCore::startKeyword):
      (WebCore::middleKeyword):
      (WebCore::endKeyword):
      (WebCore::verticalGrowingLeftKeyword):
      (WebCore::verticalGrowingRightKeyword):
      (WebCore::TextTrackCue::updateDisplayTree):
      (WebCore::TextTrackCue::settingName):
      * page/DiagnosticLoggingKeys.cpp:
      (WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
      (WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
      (WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
      (WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
      (WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
      (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
      (WebCore::DiagnosticLoggingKeys::passKey):
      (WebCore::DiagnosticLoggingKeys::failKey):
      (WebCore::DiagnosticLoggingKeys::noopKey):
      * page/PageVisibilityState.cpp:
      (WebCore::pageVisibilityStateString):
      * page/UserContentURLPattern.cpp:
      (WebCore::UserContentURLPattern::parse):
      * platform/KURLWTFURL.cpp:
      (WebCore::KURL::string):
      * platform/MIMETypeRegistry.cpp:
      (WebCore::defaultMIMEType):
      (WebCore::mimeTypeAssociationMap):
      * platform/network/ContentTypeParser.cpp:
      (WebCore::ContentTypeParser::parse):
      * platform/network/win/DownloadBundleWin.cpp:
      (WebCore::DownloadBundle::fileExtension):
      * storage/StorageTracker.cpp:
      (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
      * svg/SVGAnimatedBoolean.cpp:
      (WebCore::SVGAnimatedBooleanAnimator::constructFromString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1e7d635
  4. 27 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Rename RegisterProtocolHandler API to NavigatorContentUtils · 30167703
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94920
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-27
      Reviewed by Adam Barth.
      
      .:
      
      Modified configuration files so that they contain renamed NavigatorContentUtils-prefixed files.
      
      * Source/cmake/OptionsBlackBerry.cmake:
      * Source/cmake/OptionsEfl.cmake:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/JavaScriptCore:
      
      ENABLE_REGISTER_PROTOCOL_HANDLER is renamed to ENABLE_NAVIGATOR_CONTENT_UTILS.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
      Module 'protocolhandler' is renamed to 'navigatorcontentutils'.
      
      No new tests as there is no new functionality.
      
      * CMakeLists.txt:
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * GNUmakefile.features.am:
      * GNUmakefile.list.am:
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp: Renamed from Source/WebCore/Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp.
      (WebCore):
      (WebCore::initProtocolHandlerWhitelist):
      (WebCore::verifyCustomHandlerURL):
      (WebCore::isProtocolWhitelisted):
      (WebCore::verifyProtocolHandlerScheme):
      (WebCore::NavigatorContentUtils::from):
      (WebCore::NavigatorContentUtils::~NavigatorContentUtils):
      (WebCore::NavigatorContentUtils::create):
      (WebCore::NavigatorContentUtils::registerProtocolHandler):
      (WebCore::customHandlersStateString):
      (WebCore::NavigatorContentUtils::isProtocolHandlerRegistered):
      (WebCore::NavigatorContentUtils::unregisterProtocolHandler):
      (WebCore::NavigatorContentUtils::supplementName):
      (WebCore::provideNavigatorContentUtilsTo):
      * Modules/navigatorcontentutils/NavigatorContentUtils.h: Renamed from Source/WebCore/Modules/protocolhandler/NavigatorRegisterProtocolHandler.h.
      (WebCore):
      (NavigatorContentUtils):
      (WebCore::NavigatorContentUtils::NavigatorContentUtils):
      (WebCore::NavigatorContentUtils::client):
      * Modules/navigatorcontentutils/NavigatorContentUtils.idl: Renamed from Source/WebCore/Modules/protocolhandler/NavigatorRegisterProtocolHandler.idl.
      * Modules/navigatorcontentutils/NavigatorContentUtilsClient.h: Renamed from Source/WebCore/Modules/protocolhandler/RegisterProtocolHandlerClient.h.
      (WebCore):
      (NavigatorContentUtilsClient):
      (WebCore::NavigatorContentUtilsClient::~NavigatorContentUtilsClient):
      * Target.pri:
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * WebCore.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcproj/WebCoreCommon.vsprops:
      * WebCore.vcproj/copyForwardingHeaders.cmd:
      
      Source/WebKit:
      
      Modified PlatformEfl.cmake so that it includes the renamed files.
      
      * PlatformEfl.cmake:
      
      Source/WebKit/blackberry:
      
      Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore):
      (WebCore::ChromeClientBlackBerry::registerProtocolHandler):
      * WebCoreSupport/ChromeClientBlackBerry.h:
      (ChromeClientBlackBerry):
      
      Source/WebKit/chromium:
      
      Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
      RegisterProtocolHandlerClientImpl is renamed to NavigatorContentUtilsClientImpl.
      
      * features.gypi:
      * src/ChromeClientImpl.cpp:
      (WebKit):
      (WebKit::NavigatorContentUtilsClientImpl::create):
      (WebKit::NavigatorContentUtilsClientImpl::NavigatorContentUtilsClientImpl):
      (WebKit::NavigatorContentUtilsClientImpl::registerProtocolHandler):
      * src/ChromeClientImpl.h:
      (NavigatorContentUtilsClientImpl):
      (WebKit::NavigatorContentUtilsClientImpl::~NavigatorContentUtilsClientImpl):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl):
      * src/WebViewImpl.h:
      
      Source/WebKit/efl:
      
      Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
      RegisterProtocolHandlerClientEfl is renamed to NavigatorContentUtilsClientEfl.
      
      * WebCoreSupport/NavigatorContentUtilsClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp.
      (WebCore):
      (WebCore::customHandlerDataCreate):
      (WebCore::customHandlerDataDelete):
      (WebCore::NavigatorContentUtilsClientEfl::create):
      (WebCore::NavigatorContentUtilsClientEfl::NavigatorContentUtilsClientEfl):
      (WebCore::NavigatorContentUtilsClientEfl::registerProtocolHandler):
      (WebCore::NavigatorContentUtilsClientEfl::isProtocolHandlerRegistered):
      (WebCore::NavigatorContentUtilsClientEfl::unregisterProtocolHandler):
      * WebCoreSupport/NavigatorContentUtilsClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.h.
      (NavigatorContentUtilsClientEfl):
      (WebCore::NavigatorContentUtilsClientEfl::~NavigatorContentUtilsClientEfl):
      * ewk/ewk_custom_handler.cpp:
      * ewk/ewk_custom_handler_private.h:
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (_ewk_view_priv_new):
      
      Source/WebKit/gtk:
      
      Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
      RegisterProtocolHandlerClientGtk is renamed to NavigatorContentUtilsClientGtk.
      
      * GNUmakefile.am:
      * WebCoreSupport/NavigatorContentUtilsClientGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp.
      (WebKit):
      (WebKit::NavigatorContentUtilsClient::create):
      (WebKit::NavigatorContentUtilsClient::NavigatorContentUtilsClient):
      (WebKit::NavigatorContentUtilsClient::registerProtocolHandler):
      * WebCoreSupport/NavigatorContentUtilsClientGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/RegisterProtocolHandlerClientGtk.h.
      (WebKit):
      (NavigatorContentUtilsClient):
      (WebKit::NavigatorContentUtilsClient::~NavigatorContentUtilsClient):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_init):
      * webkit/webkitwebviewprivate.h:
      
      Source/WebKit/mac:
      
      ENABLE_REGISTER_PROTOCOL_HANDLER is renamed to ENABLE_NAVIGATOR_CONTENT_UTILS.
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
      
      * Configurations/FeatureDefines.xcconfig:
      * WebProcess/WebCoreSupport/WebNavigatorContentUtilsClient.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h.
      (WebKit):
      (WebNavigatorContentUtilsClient):
      (WebKit::WebNavigatorContentUtilsClient::~WebNavigatorContentUtilsClient):
      (WebKit::WebNavigatorContentUtilsClient::isProtocolHandlerRegistered):
      (WebKit::WebNavigatorContentUtilsClient::unregisterProtocolHandler):
      
      Tools:
      
      Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.
      
      * Scripts/webkitperl/FeatureList.pm:
      * qmake/mkspecs/features/features.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30167703
  5. 07 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      CUSTOM_SCHEME_HANDLER flag should depend on REGISTER_PROTOCOL_HANDLER · 00c9d1cb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93081
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-07
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.
      The whole NavigatorRegisterProtocolHandler interface is conditional on REGISTER_PROTOCOL_HANDLER
      CUSTOM_SCHEME_HANDLER-specific methods only are conditional on CUSTOM_SCHEME_HANDLER.
      
      No new tests. No new functionality is added.
      
      * Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp:
      (WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):
      * Modules/protocolhandler/NavigatorRegisterProtocolHandler.h:
      (NavigatorRegisterProtocolHandler):
      * Modules/protocolhandler/NavigatorRegisterProtocolHandler.idl:
      * Modules/protocolhandler/RegisterProtocolHandlerClient.h:
      
      Source/WebKit:
      
      Modified PlatformEfl.cmake so that CUSTOM_SCHEME_HANDLER flag cannot act without REGISTER_PROTOCOL_HANDLER being set.
      
      * PlatformEfl.cmake:
      
      Source/WebKit/efl:
      
      CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.
      
      * WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:
      (WebCore::RegisterProtocolHandlerClientEfl::registerProtocolHandler):
      * WebCoreSupport/RegisterProtocolHandlerClientEfl.h:
      * ewk/ewk_custom_handler.cpp:
      (ewk_custom_handler_register_protocol_handler):
      * ewk/ewk_custom_handler_private.h:
      * ewk/ewk_view.cpp:
      (_ewk_view_priv_new):
      
      Source/WebKit2:
      
      CUSTOM_SCHEME_HANDLER #if guards are enclosed in the REGISTER_PROTOCOL_HANDLER guards.
      
      * WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h:
      (WebRegisterProtocolHandlerClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00c9d1cb
  6. 17 Jul, 2012 1 commit
    • gyuyoung.kim@samsung.com's avatar
      Add RegisterProtocolHandlerClient to the Modules/protocolhandler · cd6b2961
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=90940
      
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
      to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
      protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
      
      In addition, NavigatorRegisterProtocolHandler should be supplementable.
      
      No new tests. Covered by existing tests.
      
      * GNUmakefile.list.am:
      * Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp:
      (WebCore::NavigatorRegisterProtocolHandler::from):
      (WebCore::NavigatorRegisterProtocolHandler::create):
      (WebCore):
      (WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):
      (WebCore::customHandlersStateString):
      (WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered):
      (WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler):
      (WebCore::NavigatorRegisterProtocolHandler::supplementName):
      (WebCore::provideRegisterProtocolHandlerTo):
      * Modules/protocolhandler/NavigatorRegisterProtocolHandler.h:
      (WebCore):
      (NavigatorRegisterProtocolHandler):
      (WebCore::NavigatorRegisterProtocolHandler::NavigatorRegisterProtocolHandler):
      (WebCore::NavigatorRegisterProtocolHandler::client):
      * Modules/protocolhandler/RegisterProtocolHandlerClient.h: Added.
      (WebCore):
      (RegisterProtocolHandlerClient):
      * WebCore.gypi:
      * loader/EmptyClients.h:
      * page/ChromeClient.h:
      (ChromeClient):
      * platform/network/soup/CookieJarSoup.cpp:
      (WebCore::setCookies):
      (WebCore::getRawCookies):
      
      Source/WebKit:
      
      As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
      to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
      protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
      
      * PlatformEfl.cmake: Add RegisterProtocolHandlerEfl files and include path.
      
      Source/WebKit/chromium:
      
      As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
      to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
      protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
      
      In order to support this, RegisterProtocolHandlerClientImpl class is added to ChromeClientImpl files.
      
      In addition, existing functions related to protocol handler in ChromeClientImpl class are moved to
      RegisterProtocolHandlerClientImpl class.
      
      * WebKit.gyp:
      * src/ChromeClientImpl.cpp: Implement RegisterProtocolHandlerClientImpl class.
      (WebKit):
      (WebKit::RegisterProtocolHandlerClientImpl::create):
      (WebKit::RegisterProtocolHandlerClientImpl::RegisterProtocolHandlerClientImpl):
      (WebKit::RegisterProtocolHandlerClientImpl::registerProtocolHandler):
      * src/ChromeClientImpl.h:
      (ChromeClientImpl):
      (RegisterProtocolHandlerClientImpl):
      (WebKit::RegisterProtocolHandlerClientImpl::~RegisterProtocolHandlerClientImpl):
      (WebKit):
      * src/WebViewImpl.cpp: Register RegisterProtocolHandlerClientImpl in order to support supplement.
      (WebKit::WebViewImpl::WebViewImpl):
      * src/WebViewImpl.h:
      
      Source/WebKit/efl:
      
      As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
      to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
      protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient
      
      In order to support this, RegisterProtocolHandlerClientEfl class is added and ewk_view registers
      RegisterProtocolHandlerClientEfl. In addition, existing concrete functions in ChromeClientEfl are moved
      to RegisterProtocolHandlerClientEfl.
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore):
      * WebCoreSupport/ChromeClientEfl.h:
      * WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp: Added.
      (WebCore):
      (WebCore::customHandlerDataCreate):
      (WebCore::customHandlerDataDelete):
      (WebCore::RegisterProtocolHandlerClientEfl::RegisterProtocolHandlerClientEfl):
      (WebCore::RegisterProtocolHandlerClientEfl::registerProtocolHandler):
      (WebCore::RegisterProtocolHandlerClientEfl::isProtocolHandlerRegistered):
      (WebCore::RegisterProtocolHandlerClientEfl::unregisterProtocolHandler):
      * WebCoreSupport/RegisterProtocolHandlerClientEfl.h: Added.
      (RegisterProtocolHandlerClientEfl):
      (WebCore::RegisterProtocolHandlerClientEfl::~RegisterProtocolHandlerClientEfl):
      * ewk/ewk_view.cpp:
      (_ewk_view_priv_new):
      
      Source/WebKit/gtk:
      
      As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
      to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
      protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
      
      In order to support this, RegisterProtocolHandlerClientGtk class is added and webview registers
      RegisterProtocolHandlerClientGtk. In addition, existing concrete functions in ChromeClientGtk are moved
      to RegisterProtocolHandlerClientGtk.
      
      * GNUmakefile.am:
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/ChromeClientGtk.h:
      (ChromeClient):
      * WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp: Added.
      (WebKit):
      (WebKit::RegisterProtocolHandlerClient::RegisterProtocolHandlerClient):
      (WebKit::RegisterProtocolHandlerClient::registerProtocolHandler):
      * WebCoreSupport/RegisterProtocolHandlerClientGtk.h: Added.
      (WebKit):
      (RegisterProtocolHandlerClient):
      (WebKit::RegisterProtocolHandlerClient::~RegisterProtocolHandlerClient):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_init):
      
      Source/WebKit2:
      
      As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
      to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
      protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.
      
      In order to support this, WebRegisterProtocolHandlerClient class is added. However, this is not implemented yet.
      In addition, existing virtual functions in WebChromeClient are moved to WebRegisterProtocolHandlerClient.
      
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h: Added.
      (WebKit):
      (WebRegisterProtoclHandlerClient):
      (WebKit::WebRegisterProtoclHandlerClient::isProtocolHandlerRegistered):
      (WebKit::WebRegisterProtoclHandlerClient::unregisterProtocolHandler):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd6b2961
  7. 12 Jul, 2012 1 commit
    • gyuyoung.kim@samsung.com's avatar
      Register protocol handler files should be in Modules/protocolhandler · 02f69142
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=90766
      
      Reviewed by Hajime Morita.
      
      The register protocol handler files are now self-contained. This patch is moved to the Modules.
      
      No new tests. Covered by existing tests.
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp: Renamed from Source/WebCore/page/NavigatorRegisterProtocolHandler.cpp.
      (WebCore):
      (WebCore::initProtocolHandlerWhitelist):
      (WebCore::verifyCustomHandlerURL):
      (WebCore::isProtocolWhitelisted):
      (WebCore::verifyProtocolHandlerScheme):
      (WebCore::NavigatorRegisterProtocolHandler::NavigatorRegisterProtocolHandler):
      (WebCore::NavigatorRegisterProtocolHandler::~NavigatorRegisterProtocolHandler):
      (WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):
      (WebCore::customHandlersStateString):
      (WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered):
      (WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler):
      * Modules/protocolhandler/NavigatorRegisterProtocolHandler.h: Renamed from Source/WebCore/page/NavigatorRegisterProtocolHandler.h.
      (WebCore):
      (NavigatorRegisterProtocolHandler):
      * Modules/protocolhandler/NavigatorRegisterProtocolHandler.idl: Renamed from Source/WebCore/page/NavigatorRegisterProtocolHandler.idl.
      * Target.pri:
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * WebCore.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcproj/WebCoreCommon.vsprops:
      * WebCore.vcproj/copyForwardingHeaders.cmd:
      * WebCore.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02f69142
  8. 03 Jul, 2012 1 commit
  9. 05 Jun, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'. · 3401b2d0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73176
      
      Patch by Dongwoo Im <dw.im@samsung.com> on 2012-06-05
      Reviewed by Adam Barth.
      
      Two more APIs are added in Custom Scheme Handler specification.
      http://dev.w3.org/html5/spec/Overview.html#custom-handlers
      One is 'isProtocolHandlerRegistered' to query whether the specific URL
      is registered or not.
      The other is 'unregisterProtocolHandler' to remove the registered URL.
      
      .:
      
      * Source/cmake/WebKitFeatures.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      * Source/cmakeconfig.h.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      
      Source/WebCore:
      
      Test: fast/dom/unregister-protocol-handler.html
      
      * Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      * loader/EmptyClients.h: Add prototypes.
      (EmptyChromeClient):
      (WebCore::EmptyChromeClient::isProtocolHandlerRegistered):
      (WebCore::EmptyChromeClient::unregisterProtocolHandler):
      * page/ChromeClient.h:
      (ChromeClient):
      * page/NavigatorRegisterProtocolHandler.cpp:
      (WebCore):
      (WebCore::customHandlersStateString):
      (WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered): Query if the handler is registered.
      (WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler): Unregister the registered handler.
      * page/NavigatorRegisterProtocolHandler.h:
      (NavigatorRegisterProtocolHandler):
      * page/NavigatorRegisterProtocolHandler.idl:
      
      Source/WebKit/chromium:
      
      * features.gypi: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::customHandlerDataCreate):
      (WebCore::customHandlerDataDelete):
      (WebCore::ChromeClientEfl::registerProtocolHandler):
      (WebCore):
      (WebCore::ChromeClientEfl::isProtocolHandlerRegistered): Query if the handler is registered.
      (WebCore::ChromeClientEfl::unregisterProtocolHandler): Unregister the registered handler.
      * WebCoreSupport/ChromeClientEfl.h:
      (ChromeClientEfl):
      * ewk/ewk_custom_handler.cpp:
      (ewk_custom_handler_is_protocol_handler_registered): Query if the handler is registered.
      (ewk_custom_handler_unregister_protocol_handler): Unregister the registered handler.
      * ewk/ewk_custom_handler_private.h: Adds private function.
      * ewk/ewk_view.h: Adds enumeration.
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      
      WebKitLibraries:
      
      * win/tools/vsprops/FeatureDefines.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      * win/tools/vsprops/FeatureDefinesCairo.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
      
      LayoutTests:
      
      * fast/dom/unregister-protocol-handler-expected.txt: Added.
      * fast/dom/unregister-protocol-handler.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3401b2d0
  10. 09 May, 2012 1 commit
  11. 26 Feb, 2012 1 commit
  12. 22 Feb, 2012 1 commit