1. 22 Jan, 2013 1 commit
    • mark.lam@apple.com's avatar
      Change the Supplementable class to not use AtomicString. · e69ee170
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107535.
      
      Reviewed by Adam Barth.
      
      Replaced the use of AtomicString keys with literal const char* keys.
      This simplifies the SupplementMap and makes it slightly leaner and faster.
      
      Source/WebCore: 
      
      No new tests.
      
      * Modules/battery/BatteryController.cpp:
      (WebCore::BatteryController::supplementName):
      * Modules/battery/BatteryController.h:
      (BatteryController):
      * Modules/battery/NavigatorBattery.cpp:
      (WebCore::NavigatorBattery::supplementName):
      (WebCore):
      (WebCore::NavigatorBattery::from):
      * Modules/battery/NavigatorBattery.h:
      (NavigatorBattery):
      * Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
      (WebCore::DraggedIsolatedFileSystem::supplementName):
      * Modules/filesystem/chromium/DraggedIsolatedFileSystem.h:
      (DraggedIsolatedFileSystem):
      * Modules/gamepad/NavigatorGamepad.cpp:
      (WebCore::NavigatorGamepad::supplementName):
      (WebCore):
      (WebCore::NavigatorGamepad::from):
      * Modules/gamepad/NavigatorGamepad.h:
      (NavigatorGamepad):
      * Modules/geolocation/GeolocationController.cpp:
      (WebCore::GeolocationController::supplementName):
      * Modules/geolocation/GeolocationController.h:
      (GeolocationController):
      * Modules/geolocation/NavigatorGeolocation.cpp:
      (WebCore::NavigatorGeolocation::supplementName):
      (WebCore):
      (WebCore::NavigatorGeolocation::from):
      * Modules/geolocation/NavigatorGeolocation.h:
      (NavigatorGeolocation):
      * Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
      (WebCore::DOMWindowIndexedDatabase::supplementName):
      (WebCore):
      (WebCore::DOMWindowIndexedDatabase::from):
      * Modules/indexeddb/DOMWindowIndexedDatabase.h:
      (DOMWindowIndexedDatabase):
      * Modules/indexeddb/PageGroupIndexedDatabase.cpp:
      (WebCore::PageGroupIndexedDatabase::supplementName):
      (WebCore):
      (WebCore::PageGroupIndexedDatabase::from):
      * Modules/indexeddb/PageGroupIndexedDatabase.h:
      (PageGroupIndexedDatabase):
      * Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
      (WebCore::WorkerContextIndexedDatabase::supplementName):
      (WebCore):
      (WebCore::WorkerContextIndexedDatabase::from):
      * Modules/indexeddb/WorkerContextIndexedDatabase.h:
      (WorkerContextIndexedDatabase):
      * Modules/intents/DOMWindowIntents.cpp:
      (WebCore::DOMWindowIntents::supplementName):
      (WebCore):
      (WebCore::DOMWindowIntents::from):
      * Modules/intents/DOMWindowIntents.h:
      (DOMWindowIntents):
      * Modules/mediastream/UserMediaController.cpp:
      (WebCore::UserMediaController::supplementName):
      * Modules/mediastream/UserMediaController.h:
      (UserMediaController):
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
      (WebCore::NavigatorContentUtils::supplementName):
      * Modules/navigatorcontentutils/NavigatorContentUtils.h:
      (NavigatorContentUtils):
      * Modules/networkinfo/NavigatorNetworkInfoConnection.cpp:
      (WebCore::NavigatorNetworkInfoConnection::supplementName):
      (WebCore):
      (WebCore::NavigatorNetworkInfoConnection::from):
      * Modules/networkinfo/NavigatorNetworkInfoConnection.h:
      (NavigatorNetworkInfoConnection):
      * Modules/networkinfo/NetworkInfoController.cpp:
      (WebCore::NetworkInfoController::supplementName):
      * Modules/networkinfo/NetworkInfoController.h:
      (NetworkInfoController):
      * Modules/notifications/DOMWindowNotifications.cpp:
      (WebCore::DOMWindowNotifications::supplementName):
      (WebCore):
      (WebCore::DOMWindowNotifications::from):
      * Modules/notifications/DOMWindowNotifications.h:
      (DOMWindowNotifications):
      * Modules/notifications/NotificationController.cpp:
      (WebCore::NotificationController::supplementName):
      * Modules/notifications/NotificationController.h:
      (NotificationController):
      * Modules/notifications/WorkerContextNotifications.cpp:
      (WebCore::WorkerContextNotifications::supplementName):
      (WebCore):
      (WebCore::WorkerContextNotifications::from):
      * Modules/notifications/WorkerContextNotifications.h:
      (WorkerContextNotifications):
      * Modules/quota/DOMWindowQuota.cpp:
      (WebCore::DOMWindowQuota::supplementName):
      (WebCore):
      (WebCore::DOMWindowQuota::from):
      * Modules/quota/DOMWindowQuota.h:
      (DOMWindowQuota):
      * Modules/speech/DOMWindowSpeechSynthesis.cpp:
      (WebCore::DOMWindowSpeechSynthesis::supplementName):
      (WebCore):
      (WebCore::DOMWindowSpeechSynthesis::from):
      * Modules/speech/DOMWindowSpeechSynthesis.h:
      (DOMWindowSpeechSynthesis):
      * Modules/speech/SpeechRecognitionController.cpp:
      (WebCore::SpeechRecognitionController::supplementName):
      * Modules/speech/SpeechRecognitionController.h:
      (SpeechRecognitionController):
      * Modules/vibration/Vibration.cpp:
      (WebCore::Vibration::supplementName):
      * Modules/vibration/Vibration.h:
      (Vibration):
      * Modules/webdatabase/DatabaseContext.cpp:
      (WebCore::DatabaseContext::supplementName):
      (WebCore):
      (WebCore::DatabaseContext::existingDatabaseContextFrom):
      (WebCore::DatabaseContext::from):
      * Modules/webdatabase/DatabaseContext.h:
      (DatabaseContext):
      * dom/ContextFeatures.cpp:
      (WebCore::ContextFeatures::supplementName):
      * dom/ContextFeatures.h:
      * dom/DeviceMotionController.cpp:
      (WebCore::DeviceMotionController::supplementName):
      * dom/DeviceMotionController.h:
      (DeviceMotionController):
      * dom/DeviceOrientationController.cpp:
      (WebCore::DeviceOrientationController::supplementName):
      * dom/DeviceOrientationController.h:
      (DeviceOrientationController):
      * loader/PrerendererClient.cpp:
      (WebCore::PrerendererClient::supplementName):
      * loader/PrerendererClient.h:
      (PrerendererClient):
      * page/DOMWindowPagePopup.cpp:
      (WebCore::DOMWindowPagePopup::supplementName):
      * page/DOMWindowPagePopup.h:
      (DOMWindowPagePopup):
      * page/SpeechInput.cpp:
      (WebCore::SpeechInput::supplementName):
      * page/SpeechInput.h:
      (SpeechInput):
      * platform/RefCountedSupplement.h:
      (WebCore::RefCountedSupplement::provideTo):
      (WebCore::RefCountedSupplement::from):
      * platform/Supplementable.h:
      (WebCore):
      (WebCore::Supplement::provideTo):
      (WebCore::Supplement::from):
      (WebCore::Supplementable::provideSupplement):
      (WebCore::Supplementable::removeSupplement):
      (WebCore::Supplementable::requireSupplement):
      (Supplementable):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::supplementName):
      (WebCore):
      (WebCore::InternalSettings::from):
      * testing/InternalSettings.h:
      (InternalSettings):
      
      Source/WebKit/chromium: 
      
      * src/ContextFeaturesClientImpl.cpp:
      (ContextFeaturesCache):
      (WebKit::ContextFeaturesCache::supplementName):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e69ee170
  2. 08 Nov, 2012 1 commit
    • benjamin@webkit.org's avatar
      Improve the use of AtomicString with literals · dbf9529b
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101298
      
      Reviewed by Darin Adler.
      
      Fix a bunch of cases of AtomicString with literals:
      -Do not create temporary AtomicString to perform a comparison, that is very wasteful.
      -Use the ConstructFromLiteral constructor whenever it makes sense.
      -Make "x-frame-options" static instead of creating it for each response.
      -Use ASCIILiteral() instead of AtomicString() in EventHandler, the function takes a String,
       not an AtomicString.
      
      * Modules/battery/BatteryController.cpp:
      (WebCore::BatteryController::supplementName):
      * Modules/battery/NavigatorBattery.cpp:
      (WebCore::NavigatorBattery::from):
      * Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
      (WebCore::DraggedIsolatedFileSystem::supplementName):
      * Modules/gamepad/NavigatorGamepad.cpp:
      (WebCore::NavigatorGamepad::from):
      * Modules/geolocation/GeolocationController.cpp:
      (WebCore::GeolocationController::supplementName):
      * Modules/geolocation/NavigatorGeolocation.cpp:
      (WebCore::NavigatorGeolocation::from):
      * Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
      (WebCore::DOMWindowIndexedDatabase::from):
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::directionNext):
      (WebCore::IDBCursor::directionNextUnique):
      (WebCore::IDBCursor::directionPrev):
      (WebCore::IDBCursor::directionPrevUnique):
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::readyState):
      * Modules/indexeddb/IDBTransaction.cpp:
      (WebCore::IDBTransaction::modeReadOnly):
      (WebCore::IDBTransaction::modeReadWrite):
      (WebCore::IDBTransaction::modeVersionChange):
      (WebCore::IDBTransaction::modeReadOnlyLegacy):
      (WebCore::IDBTransaction::modeReadWriteLegacy):
      * Modules/indexeddb/PageGroupIndexedDatabase.cpp:
      (WebCore::PageGroupIndexedDatabase::from):
      * Modules/intents/DOMWindowIntents.cpp:
      (WebCore::DOMWindowIntents::from):
      * Modules/mediastream/UserMediaController.cpp:
      (WebCore::UserMediaController::supplementName):
      * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
      (WebCore::NavigatorContentUtils::supplementName):
      * Modules/networkinfo/NavigatorNetworkInfoConnection.cpp:
      (WebCore::NavigatorNetworkInfoConnection::from):
      * Modules/networkinfo/NetworkInfoController.cpp:
      (WebCore::NetworkInfoController::supplementName):
      * Modules/notifications/DOMWindowNotifications.cpp:
      (WebCore::DOMWindowNotifications::from):
      * Modules/notifications/NotificationController.cpp:
      (WebCore::NotificationController::supplementName):
      * Modules/quota/DOMWindowQuota.cpp:
      (WebCore::DOMWindowQuota::from):
      * Modules/speech/SpeechRecognitionController.cpp:
      (WebCore::SpeechRecognitionController::supplementName):
      * Modules/vibration/Vibration.cpp:
      (WebCore::Vibration::supplementName):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::invalidStatus):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
      (WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::V8DOMWindow::namedSecurityCheck):
      * bindings/v8/custom/V8NodeListCustom.cpp:
      (WebCore::V8NodeList::namedPropertyGetter):
      * dom/ContextFeatures.cpp:
      (WebCore::ContextFeatures::supplementName):
      * dom/DeviceMotionController.cpp:
      (WebCore::DeviceMotionController::supplementName):
      * dom/DeviceOrientationController.cpp:
      (WebCore::DeviceOrientationController::supplementName):
      * dom/Element.cpp:
      (WebCore::Element::webkitRegionOverset):
      * dom/MutationRecord.cpp:
      * html/FileInputType.cpp:
      (WebCore::UploadButtonElement::shadowPseudoId):
      * html/FormController.cpp:
      (WebCore::SavedFormState::getReferencedFilePaths):
      (WebCore::FormKeyGenerator::formKey):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::formControlType):
      * html/HTMLDetailsElement.cpp:
      (WebCore::summaryQuerySelector):
      * html/HTMLFieldSetElement.cpp:
      (WebCore::HTMLFieldSetElement::formControlType):
      * html/HTMLKeygenElement.cpp:
      (WebCore::KeygenSelectElement::shadowPseudoId):
      (WebCore::HTMLKeygenElement::formControlType):
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::formControlType):
      * html/HTMLOutputElement.cpp:
      (WebCore::HTMLOutputElement::formControlType):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::formControlType):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::formControlType):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::directionString):
      * html/shadow/DateTimeEditElement.cpp:
      (WebCore::DateTimeEditElement::DateTimeEditElement):
      * html/shadow/DateTimeFieldElements.cpp:
      (WebCore::DateTimeAMPMFieldElement::create):
      (WebCore::DateTimeDayFieldElement::create):
      (WebCore::DateTimeHourFieldElement::create):
      (WebCore::DateTimeMillisecondFieldElement::create):
      (WebCore::DateTimeMinuteFieldElement::create):
      (WebCore::DateTimeMonthFieldElement::create):
      (WebCore::DateTimeSecondFieldElement::create):
      (WebCore::DateTimeSymbolicMonthFieldElement::create):
      (WebCore::DateTimeWeekFieldElement::create):
      (WebCore::DateTimeYearFieldElement::create):
      * html/shadow/DetailsMarkerControl.cpp:
      (WebCore::DetailsMarkerControl::shadowPseudoId):
      * html/shadow/ImageInnerElement.cpp:
      (WebCore::ImageInnerElement::shadowPseudoId):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::shadowPseudoId):
      (WebCore::MediaControlTimelineContainerElement::shadowPseudoId):
      (WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId):
      (WebCore::MediaControlStatusDisplayElement::shadowPseudoId):
      (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId):
      (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId):
      (WebCore::MediaControlPlayButtonElement::shadowPseudoId):
      (WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId):
      (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId):
      (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId):
      (WebCore::MediaControlRewindButtonElement::shadowPseudoId):
      (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId):
      (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
      (WebCore::MediaControlTimelineElement::shadowPseudoId):
      (WebCore::MediaControlVolumeSliderElement::shadowPseudoId):
      (WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId):
      (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId):
      (WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId):
      (WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId):
      (WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId):
      (WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId):
      (WebCore::MediaControlTextTrackContainerElement::shadowPseudoId):
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::shadowPseudoId):
      * html/shadow/MediaControlRootElementChromium.cpp:
      (WebCore::MediaControlPanelEnclosureElement::shadowPseudoId):
      (WebCore::MediaControlRootElementChromium::shadowPseudoId):
      * html/shadow/MediaControlRootElementChromiumAndroid.cpp:
      (WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId):
      * html/shadow/MeterShadowElement.cpp:
      (WebCore::MeterInnerElement::shadowPseudoId):
      (WebCore::MeterBarElement::shadowPseudoId):
      (WebCore::MeterValueElement::shadowPseudoId):
      * html/shadow/ProgressShadowElement.cpp:
      (WebCore::ProgressInnerElement::shadowPseudoId):
      (WebCore::ProgressBarElement::shadowPseudoId):
      (WebCore::ProgressValueElement::shadowPseudoId):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::sliderThumbShadowPseudoId):
      (WebCore::mediaSliderThumbShadowPseudoId):
      (WebCore::SliderContainerElement::shadowPseudoId):
      * html/shadow/SpinButtonElement.cpp:
      (WebCore::SpinButtonElement::shadowPseudoId):
      * html/shadow/TextControlInnerElements.cpp:
      (WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
      (WebCore::SearchFieldCancelButtonElement::shadowPseudoId):
      (WebCore::InputFieldSpeechButtonElement::shadowPseudoId):
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId):
      * loader/CrossOriginAccessControl.cpp:
      (WebCore::passesAccessControlCheck):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::didReceiveResponse):
      * loader/PrerendererClient.cpp:
      (WebCore::PrerendererClient::supplementName):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::updateResponseAfterRevalidation):
      * page/DOMWindowPagePopup.cpp:
      (WebCore::DOMWindowPagePopup::supplementName):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handlePasteGlobalSelection):
      (WebCore::focusDirectionForKey):
      * page/SpeechInput.cpp:
      (WebCore::SpeechInput::supplementName):
      * page/animation/CompositeAnimation.cpp:
      (WebCore::CompositeAnimation::updateKeyframeAnimations):
      * platform/graphics/FontCache.cpp:
      (WebCore::alternateFamilyName):
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::applicationOctetStream):
      (WebCore::textPlain):
      (WebCore::codecs):
      * platform/graphics/chromium/FontCacheAndroid.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/filters/SourceAlpha.cpp:
      (WebCore::SourceAlpha::effectName):
      * platform/graphics/filters/SourceGraphic.cpp:
      (WebCore::SourceGraphic::effectName):
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore::FontCache::getSimilarFontPlatformData):
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/skia/FontCacheSkia.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/win/FontCacheWin.cpp:
      (WebCore::FontCache::getLastResortFallbackFont):
      * platform/graphics/wx/FontCacheWx.cpp:
      (WebCore::FontCache::getSimilarFontPlatformData):
      * platform/network/ResourceResponseBase.cpp:
      (WebCore::ResourceResponseBase::setHTTPHeaderField):
      (WebCore::ResourceResponseBase::parseCacheControlDirectives):
      (WebCore::ResourceResponseBase::hasCacheValidatorFields):
      (WebCore::ResourceResponseBase::date):
      (WebCore::ResourceResponseBase::age):
      (WebCore::ResourceResponseBase::expires):
      (WebCore::ResourceResponseBase::lastModified):
      (WebCore::ResourceResponseBase::isAttachment):
      * rendering/RenderTextControlMultiLine.cpp:
      (WebCore::RenderTextControlMultiLine::getAvgCharWidth):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::getAvgCharWidth):
      (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      * svg/SVGAnimateColorElement.cpp:
      (WebCore::attributeValueIsCurrentColor):
      * svg/SVGAnimateMotionElement.cpp:
      (WebCore::SVGAnimateMotionElement::rotateMode):
      * svg/SVGAnimationElement.cpp:
      (WebCore::SVGAnimationElement::setCalcMode):
      (WebCore::SVGAnimationElement::setAttributeType):
      (WebCore::SVGAnimationElement::isAdditive):
      (WebCore::SVGAnimationElement::isAccumulated):
      (WebCore::inheritsFromProperty):
      * svg/SVGFEConvolveMatrixElement.cpp:
      (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier):
      (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier):
      (WebCore::SVGFEConvolveMatrixElement::orderXIdentifier):
      (WebCore::SVGFEConvolveMatrixElement::orderYIdentifier):
      * svg/SVGFEDiffuseLightingElement.cpp:
      (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier):
      (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier):
      * svg/SVGFEDropShadowElement.cpp:
      (WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier):
      (WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier):
      * svg/SVGFEGaussianBlurElement.cpp:
      (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier):
      (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier):
      * svg/SVGFEMorphologyElement.cpp:
      (WebCore::SVGFEMorphologyElement::radiusXIdentifier):
      (WebCore::SVGFEMorphologyElement::radiusYIdentifier):
      * svg/SVGFESpecularLightingElement.cpp:
      (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier):
      (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier):
      * svg/SVGFETurbulenceElement.cpp:
      (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier):
      (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier):
      * svg/SVGFilterElement.cpp:
      (WebCore::SVGFilterElement::filterResXIdentifier):
      (WebCore::SVGFilterElement::filterResYIdentifier):
      * svg/SVGLangSpace.cpp:
      (WebCore::SVGLangSpace::xmlspace):
      (WebCore::SVGLangSpace::addSupportedAttributes):
      * svg/SVGMarkerElement.cpp:
      (WebCore::SVGMarkerElement::orientTypeIdentifier):
      (WebCore::SVGMarkerElement::orientAngleIdentifier):
      (WebCore::SVGMarkerElement::synchronizeOrientType):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::contentScriptType):
      (WebCore::SVGSVGElement::contentStyleType):
      * svg/SVGStyleElement.cpp:
      (WebCore::SVGStyleElement::type):
      (WebCore::SVGStyleElement::media):
      * svg/SVGTextContentElement.cpp:
      (WebCore::SVGTextContentElement::collectStyleForAttribute):
      * svg/SVGViewSpec.cpp:
      (WebCore::SVGViewSpec::viewBoxIdentifier):
      (WebCore::SVGViewSpec::preserveAspectRatioIdentifier):
      (WebCore::SVGViewSpec::transformIdentifier):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::parseClockValue):
      (WebCore::SVGSMILElement::restart):
      (WebCore::SVGSMILElement::fill):
      (WebCore::SVGSMILElement::repeatCount):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::from):
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::processDOCTYPE):
      (WebCore::XMLTreeBuilder::processXMLEntity):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbf9529b
  3. 28 Mar, 2012 1 commit
    • gyuyoung.kim@samsung.com's avatar
      Remove ScriptExecutionContext from NavigatorBattery.idl · 3eb50926
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=82556
      
      Reviewed by Adam Barth.
      
      As Bug 73528 comment #71, NavigatorBattery.idl doesn't need to have ScriptExecutionContext.
      Document can be used instead of ScriptExecutionContext.
      
      Tests: batterystatus/add-listener-from-callback.html
             batterystatus/basic-all-types-of-events.html
             batterystatus/basic-operation.html
             batterystatus/event-after-navigation.html
             batterystatus/multiple-frames.html
             batterystatus/updates.html
             batterystatus/window-property.html
      
      * Modules/battery/BatteryManager.cpp:
      (WebCore::BatteryManager::create):
      (WebCore::BatteryManager::BatteryManager):
      * Modules/battery/BatteryManager.h:
      (BatteryManager):
      * Modules/battery/NavigatorBattery.cpp:
      (WebCore::NavigatorBattery::webkitBattery):
      * Modules/battery/NavigatorBattery.h:
      (NavigatorBattery):
      * Modules/battery/NavigatorBattery.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3eb50926
  4. 22 Mar, 2012 1 commit
  5. 16 Mar, 2012 1 commit
    • commit-queue@webkit.org's avatar
      .: Support for Battery Status API. · 0de163f6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=62698
      
      Enable BATTERY_STATUS for WebKit-Efl.
      http://www.w3.org/TR/battery-status/
      
      Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
      Reviewed by Adam Barth.
      
      * Source/cmake/OptionsEfl.cmake:
      * Source/cmakeconfig.h.cmake:
      
      Source/WebCore: Support for Battery Status API
      https://bugs.webkit.org/show_bug.cgi?id=62698
      
      Battery Status API is implemented under the Navigator class.
      Battery Status API has four types of events, and all events are operated based on a callback mechanism.
       : onchargingchange, onchargingtimechange, ondischargingtimechange, onlevelchange.
      The battery status can be accessed using BatteryManager(navigator.webkitBattery), and battery status is controlled by BatteryController which manages instances of BatteryManager.
      When battery status event is raised, BatteryController calls all registered BatteryManager's event dispatcher.
      http://www.w3.org/TR/battery-status/
      
      Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
      Reviewed by Adam Barth.
      
      Tests: batterystatus/add-listener-from-callback.html
             batterystatus/basic-all-types-of-events.html
             batterystatus/basic-operation.html
             batterystatus/event-after-navigation.html
             batterystatus/multiple-frames.html
             batterystatus/updates.html
             batterystatus/window-property.html
      
      * CMakeLists.txt:
      * Modules/battery/BatteryClient.h: Added.
      (WebCore):
      (BatteryClient):
      (WebCore::BatteryClient::~BatteryClient):
      * Modules/battery/BatteryController.cpp: Added.
      (WebCore):
      (WebCore::BatteryController::BatteryController):
      (WebCore::BatteryController::~BatteryController):
      (WebCore::BatteryController::create):
      (WebCore::BatteryController::addListener):
      (WebCore::BatteryController::removeListener):
      (WebCore::BatteryController::didChangeBatteryStatus):
      (WebCore::BatteryController::supplementName):
      (WebCore::BatteryController::isActive):
      (WebCore::provideBatteryTo):
      * Modules/battery/BatteryController.h: Added.
      (WebCore):
      (BatteryController):
      (WebCore::BatteryController::client):
      (WebCore::BatteryController::from):
      * Modules/battery/BatteryManager.cpp: Added.
      (WebCore):
      (WebCore::BatteryManager::create):
      (WebCore::BatteryManager::~BatteryManager):
      (WebCore::BatteryManager::BatteryManager):
      (WebCore::BatteryManager::charging):
      (WebCore::BatteryManager::chargingTime):
      (WebCore::BatteryManager::dischargingTime):
      (WebCore::BatteryManager::level):
      (WebCore::BatteryManager::didChangeBatteryStatus):
      (WebCore::BatteryManager::suspend):
      (WebCore::BatteryManager::resume):
      (WebCore::BatteryManager::stop):
      * Modules/battery/BatteryManager.h: Added.
      (WebCore):
      (BatteryManager):
      (WebCore::BatteryManager::interfaceName):
      (WebCore::BatteryManager::scriptExecutionContext):
      (WebCore::BatteryManager::batteryControllerDestroyed):
      (WebCore::BatteryManager::canSuspend):
      (WebCore::BatteryManager::eventTargetData):
      (WebCore::BatteryManager::ensureEventTargetData):
      (WebCore::BatteryManager::refEventTarget):
      (WebCore::BatteryManager::derefEventTarget):
      * Modules/battery/BatteryManager.idl: Added.
      * Modules/battery/BatteryStatus.cpp: Added.
      (WebCore):
      (WebCore::BatteryStatus::create):
      (WebCore::BatteryStatus::BatteryStatus):
      * Modules/battery/BatteryStatus.h: Added.
      (WebCore):
      (BatteryStatus):
      (WebCore::BatteryStatus::charging):
      (WebCore::BatteryStatus::chargingTime):
      (WebCore::BatteryStatus::dischargingTime):
      (WebCore::BatteryStatus::level):
      * Modules/battery/NavigatorBattery.cpp: Added.
      (WebCore):
      (WebCore::NavigatorBattery::NavigatorBattery):
      (WebCore::NavigatorBattery::~NavigatorBattery):
      (WebCore::NavigatorBattery::webkitBattery):
      (WebCore::NavigatorBattery::from):
      (WebCore::NavigatorBattery::batteryManager):
      * Modules/battery/NavigatorBattery.h: Added.
      (WebCore):
      (NavigatorBattery):
      * Modules/battery/NavigatorBattery.idl: Added.
      * dom/EventNames.h:
      (WebCore):
      * dom/EventTargetFactory.in:
      * testing/Internals.cpp:
      (WebCore::Internals::setBatteryStatus):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit: Support for Battery Status API
      https://bugs.webkit.org/show_bug.cgi?id=62698
      
      Add include directory and file.
      http://www.w3.org/TR/battery-status/
      
      Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
      Reviewed by Adam Barth.
      
      * PlatformEfl.cmake:
      
      Source/WebKit/efl: Support for Battery Status API
      https://bugs.webkit.org/show_bug.cgi?id=62698
      
      Add BatteryClientEfl class implementation for the layout tests now.
      BatteryClientEfl class is not fully implemented in this patch.
      (It will be completed by other patch as necessary in the Efl port.)
      http://www.w3.org/TR/battery-status/
      
      Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
      Reviewed by Adam Barth.
      
      * WebCoreSupport/BatteryClientEfl.cpp: Added.
      (WebCore):
      (WebCore::BatteryClientEfl::BatteryClientEfl):
      (WebCore::BatteryClientEfl::setController):
      (WebCore::BatteryClientEfl::startUpdating):
      (WebCore::BatteryClientEfl::stopUpdating):
      (WebCore::BatteryClientEfl::batteryControllerDestroyed):
      (WebCore::BatteryClientEfl::setBatteryStatus):
      * WebCoreSupport/BatteryClientEfl.h: Added.
      (WebCore):
      (BatteryClientEfl):
      (WebCore::BatteryClientEfl::~BatteryClientEfl):
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (_ewk_view_priv_new):
      
      Tools: Support for Battery Status API
      https://bugs.webkit.org/show_bug.cgi?id=62698
      
      Add include directory and file.
      http://www.w3.org/TR/battery-status/
      
      Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
      Reviewed by Adam Barth.
      
      * Scripts/build-webkit:
      
      LayoutTests: Support for Battery Status API.
      https://bugs.webkit.org/show_bug.cgi?id=62698
      
      Add new test cases for Battery Status API.
      http://www.w3.org/TR/battery-status/
      
      Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
      Reviewed by Adam Barth.
      
      * batterystatus/add-listener-from-callback-expected.txt: Added.
      * batterystatus/add-listener-from-callback.html: Added.
      * batterystatus/basic-all-types-of-events-expected.txt: Added.
      * batterystatus/basic-all-types-of-events.html: Added.
      * batterystatus/basic-operation-expected.txt: Added.
      * batterystatus/basic-operation.html: Added.
      * batterystatus/event-after-navigation-expected.txt: Added.
      * batterystatus/event-after-navigation.html: Added.
      * batterystatus/multiple-frames-expected.txt: Added.
      * batterystatus/multiple-frames.html: Added.
      * batterystatus/resources/event-after-navigation-new.html: Added.
      * batterystatus/script-tests/add-listener-from-callback.js: Added.
      (checkBatteryStatus):
      (firstListener):
      (secondListener):
      (maybeFinishTest):
      * batterystatus/script-tests/basic-all-types-of-events.js: Added.
      (checkBatteryStatus):
      (battery):
      * batterystatus/script-tests/basic-operation.js: Added.
      * batterystatus/script-tests/event-after-navigation.js: Added.
      * batterystatus/script-tests/multiple-frames.js: Added.
      (checkBatteryStatus):
      (checkChildBatteryStatus):
      (mainFrameListener):
      (childFrameListener):
      (maybeFinishTest):
      * batterystatus/script-tests/updates.js: Added.
      (checkBatteryStatus):
      (setBatteryStatus):
      (firstListener):
      (updateListener):
      * batterystatus/script-tests/window-property.js: Added.
      (hasOnBatteryProperty):
      * batterystatus/updates-expected.txt: Added.
      * batterystatus/updates.html: Added.
      * batterystatus/window-property-expected.txt: Added.
      * batterystatus/window-property.html: Added.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      * platform/wincairo/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0de163f6