1. 20 Apr, 2013 15 commits
  2. 19 Apr, 2013 25 commits
    • ryuan.choi@samsung.com's avatar
      [EFL] Arrow of combo box are drawn twice · a3cb8832
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113917
      
      Reviewed by Gyuyoung Kim.
      
      combo_button_icon part is for arrow so that images of combo_button part should
      not contain arrow.
      
      No new tests required due to no behavioral change.
      
      * platform/efl/DefaultTheme/widget/combo/combo_focus_button.png:
      * platform/efl/DefaultTheme/widget/combo/combo_hover_button.png:
      * platform/efl/DefaultTheme/widget/combo/combo_press_button.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3cb8832
    • betravis@adobe.com's avatar
      [css exclusions] Fix up shape-inside-recursive-layout test case · cf19f74a
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114890
      
      Reviewed by Dirk Schulze.
      
      The children of the old-flexbox, new-flexbox, and grid shape-inside  containers
      should have their display value set to -webkit-inline-box, -webkit-inline-flex,
      and -webkit-inline-grid respectively. These values should not be set for
      the containers themselves, as we are interested in the behavior of descendants
      of the shape-inside container.
      
      * fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
      * fast/exclusions/shape-inside/shape-inside-recursive-layout.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf19f74a
    • commit-queue@webkit.org's avatar
      Add interfaces and stubs for audio and video tracks · 159869e5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113965
      
      Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-19
      Reviewed by Jer Noble.
      
      No new tests because there's no implementations, so there's nothing
      interesting to test.
      
      * CMakeLists.txt: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
      * DerivedSources.cpp: Same.
      * DerivedSources.make: Same.
      * DerivedSources.pri: Same.
      * GNUmakefile.list.am: Same.
      * Target.pri: Same.
      * UseJSC.cmake: Same.
      * WebCore.vcproj/WebCore.vcproj: Same.
      * WebCore.xcodeproj/project.pbxproj: Same.
      * bindings/gobject/GNUmakefile.am: Same.
      * bindings/js/JSAudioTrackCustom.cpp: Added, based on JSTestTrackCustom
      * bindings/js/JSAudioTrackListCustom.cpp: Same.
      * bindings/js/JSBindingsAllInOne.cpp: Add AudioTrack, VideoTrack, AudioTrackList and VideoTrackList.
      * bindings/js/JSVideoTrackCustom.cpp: Added, based on JSTestTrackCustom
      * bindings/js/JSVideoTrackListCustom.cpp: Same.
      * dom/EventTarget.h: Make AudioTrackList and VideoTrackList event targets.
      * dom/EventTargetFactory.in: Same.
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Add m_audioTracks and m_videoTracks
      (WebCore::HTMLMediaElement::~HTMLMediaElement): Clear clients for audio and video tracks
      (WebCore::HTMLMediaElement::audioTrackEnabledChanged): Added.
      (WebCore::HTMLMediaElement::videoTrackSelectedChanged): Added.
      (WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
      (WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Same.
      (WebCore::HTMLMediaElement::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
      (WebCore::HTMLMediaElement::mediaPlayerDidRemoveVideoTrack): Same.
      (WebCore::HTMLMediaElement::addAudioTrack): Added, based on addTextTrack
      (WebCore::HTMLMediaElement::addVideoTrack): Same.
      (WebCore::HTMLMediaElement::removeAudioTrack): Added, based on removeTextTrack
      (WebCore::HTMLMediaElement::removeVideoTrack): Added, based on removeTextTrack
      (WebCore::HTMLMediaElement::removeAllInbandTracks): Remove audio and video tracks too
      (WebCore::HTMLMediaElement::audioTracks): Added, based on textTracks
      (WebCore::HTMLMediaElement::videoTracks): Added, based on textTracks
      (WebCore::HTMLMediaElement::reportMemoryUsage): Add audio and video tracks
      * html/HTMLMediaElement.h: Add audioTracks and videoTracks and related functions
      * html/HTMLMediaElement.idl: Add audioTracks and videoTracks
      * html/track/AudioTrack.cpp: Added, based on TextTrack and InbandTextTrack.
      * html/track/AudioTrack.h: Same.
      * html/track/AudioTrack.idl: Added.
      * html/track/AudioTrackList.cpp: Added, based on TextTrackList
      * html/track/AudioTrackList.h: Same.
      * html/track/AudioTrackList.idl: Added.
      * html/track/TextTrackList.h: Add missing OVERRIDE on interfaceName()
      * html/track/VideoTrack.cpp: Added, based on TextTrack and InbandTextTrack.
      * html/track/VideoTrack.h: Same.
      * html/track/VideoTrack.idl: Added.
      * html/track/VideoTrackList.cpp: Added, based on TextTrackList
      * html/track/VideoTrackList.h: Same.
      * html/track/VideoTrackList.idl: Added.
      * platform/graphics/AudioTrackPrivate.h: Added, based on InbandTextTrackPrivate.h
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::addAudioTrack): Added, based on addTextTrack
      (WebCore::MediaPlayer::removeAudioTrack): Added, based on removeTextTrack
      (WebCore::MediaPlayer::addVideoTrack): Added, based on addTextTrack
      (WebCore::MediaPlayer::removeVideoTrack): Added, based on removeTextTrack
      * platform/graphics/MediaPlayer.h:
      (WebCore::MediaPlayerClient::mediaPlayerDidAddAudioTrack): Added, based on mediaPlayerDidAddTextTrack
      (WebCore::MediaPlayerClient::mediaPlayerDidAddVideoTrack): Same
      (WebCore::MediaPlayerClient::mediaPlayerDidRemoveAudioTrack): Added, based on mediaPlayerDidRemoveTextTrack
      (WebCore::MediaPlayerClient::mediaPlayerDidRemoveVideoTrack): Same
      * platform/graphics/VideoTrackPrivate.h: Added, based on InbandTextTrackPrivate.h
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      159869e5
    • fpizlo@apple.com's avatar
      Whenever it is cheap and non-invasive, SunSpider tests should validate their... · 22b04633
      fpizlo@apple.com authored
      Whenever it is cheap and non-invasive, SunSpider tests should validate their results to ensure that the browser runs them correctly
      https://bugs.webkit.org/show_bug.cgi?id=114852
      
      Reviewed by Geoffrey Garen.
              
      This adds low-overhead checking of the results of each SunSpider tests. This is not
      meant to be an exhaustive test that everything was executed correctly, but rather a
      simple sanity check that will catch glaring mistakes. The philosophy here is that we're
      not trying to prevent all forms of cheating, or that we're trying to prove the
      browser's correctness. Moreover, these checks are meant to incur minimal overhead;
      they currently clock in at <2% slow-down in SunSpider 1.0.
              
      The test expectations were generated using the LLInt on command-line, and I've verified
      that Firefox 20, Chrome 26, IE 10, Safari 6, and ToT with all of the JITs agree. Note
      that some tests cannot be precisely validated because they use Math functions, which
      ECMAScript chooses to not formally specify - those functions like sin() and friends are
      allowed to return implementation-dependent results. Also some tests cannot be validated
      at all because their behavior is either intentionally random or is timezone-dependent.
      But 23 out of 26 tests now have some kind of validation.
              
      I've updated the harnesses to show erroneous runs when displaying results.
      
      * resources/TEMPLATE.html:
      * resources/driver-TEMPLATE.html:
      * resources/sunspider-analyze-results.js:
      (formatResult):
      (resultLine):
      (printOutput):
      * resources/sunspider-compare-results.js:
      (.formatMean):
      (.resultLine):
      (.printOutput):
      (sunspiderCompareResults):
      * resources/sunspider-standalone-driver.js:
      * tests/sunspider-1.0/3d-cube.js:
      (Init):
      * tests/sunspider-1.0/3d-morph.js:
      * tests/sunspider-1.0/3d-raytrace.js:
      * tests/sunspider-1.0/access-binary-trees.js:
      * tests/sunspider-1.0/access-fannkuch.js:
      * tests/sunspider-1.0/access-nbody.js:
      * tests/sunspider-1.0/access-nsieve.js:
      (sieve):
      * tests/sunspider-1.0/bitops-3bit-bits-in-byte.js:
      * tests/sunspider-1.0/bitops-bits-in-byte.js:
      * tests/sunspider-1.0/bitops-bitwise-and.js:
      * tests/sunspider-1.0/bitops-nsieve-bits.js:
      * tests/sunspider-1.0/controlflow-recursive.js:
      * tests/sunspider-1.0/crypto-aes.js:
      * tests/sunspider-1.0/crypto-md5.js:
      * tests/sunspider-1.0/crypto-sha1.js:
      * tests/sunspider-1.0/date-format-tofte.js:
      * tests/sunspider-1.0/date-format-xparb.js:
      * tests/sunspider-1.0/math-cordic.js:
      * tests/sunspider-1.0/math-partial-sums.js:
      (partial):
      * tests/sunspider-1.0/math-spectral-norm.js:
      * tests/sunspider-1.0/regexp-dna.js:
      * tests/sunspider-1.0/string-base64.js:
      * tests/sunspider-1.0/string-fasta.js:
      (fastaRepeat):
      (fastaRandom):
      * tests/sunspider-1.0/string-tagcloud.js:
      * tests/sunspider-1.0/string-unpack-code.js:
      * tests/sunspider-1.0/string-validate-input.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22b04633
    • jer.noble@apple.com's avatar
      Unreviewed, revert r148782. It was not reviewed by a WebKit2 owner. · 713b9623
      jer.noble@apple.com authored
      * PluginProcess/mac/PluginProcessShim.mm:
      * Shared/mac/CookieStorageShim.cpp: Removed.
      * Shared/mac/CookieStorageShim.h: Removed.
      * Shared/mac/CookieStorageShimLibrary.cpp: Removed.
      * Shared/mac/CookieStorageShimLibrary.h: Removed.
      * Shared/mac/DYLDInterpose.h: Removed.
      * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
      (WebKit::addDYLDEnvironmentAdditions):
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
      (WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
      * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
      * WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
      (WebContentServiceInitializer):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      * WebProcess/mac/SecItemShimLibrary.mm:
      * WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
      * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      713b9623
    • jer.noble@apple.com's avatar
      WWDC session videos don’t play at developer.apple.com · ec62bd7c
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114858
      
      Reviewed by Eric Carlson.
      
      AVFoundation uses CFNetwork to store and retrieve cookies from the global store.
      However, in the case where network access happens in the NetworkProcess, session
      cookies are stored in-memory, and are not accessable in the WebProcess. Until such
      a time as AVFoundation can provide an API which would allow us to provide cookies
      for a specific request, we will interpose the CFNetwork method which they use to
      retrieve the cookie string from the cookie store for their pending request.
      
      Duplicate the previous SecItemShim target to a new, WebProcessShim target. This
      target includes the SecItemShim functionality, but will add a new shim for cookie
      retrieval:
      * Shared/mac/CookieStorageShimLibrary.h: Added
      (CookieStorageShimCallbacks):
      * Shared/mac/CookieStorageShimLibrary.cpp: Added.
      (WebKit::ShimProtector::ShimProtector): A simple stack-based counter class.
      (WebKit::ShimProtector::~ShimProtector):
      (WebKit::ShimProtector::count):
      (WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL): Interpose
          the CFNetwork call, and pass to the registered callback.
      (WebKit::WebKitCookieStorageShimInitialize): Register the callbacks.
      
      Add a helper singleton class which will talk to the shim through the
      registered callbacks:
      * Shared/mac/CookieStorageShim.h: Added
      (WebKit::CookieStorageShim::CookieStorageShim):
      * Shared/mac/CookieStorageShim.cpp: Added.
      (WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Pass the request
          over to the NetworkProcess.
      (WebKit::CookieStorageShim::shared): Simple singleton.
      (WebKit::CookieStorageShim::initialize): Call the library initializer.
      
      Initialize the shim only when the WebProcess is delegating network loading
      to the NetworkProcess:
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      
      Rename the WebProcess's shim from SecItemShim -> WebProcessShim:
      * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
      (WebKit::addDYLDEnvironmentAdditions):
      * WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
      (WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
      * WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
      * WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
      (WebContentServiceInitializer):
      
      As the DYLD_INTERPOSE macro is used in multiple files now, put it in its
      own header:
      * Shared/mac/DYLDInterpose.h: Added.
      * PluginProcess/mac/PluginProcessShim.mm:
      * WebProcess/mac/SecItemShimLibrary.mm:
      
      Add new files to the project:
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec62bd7c
    • betravis@adobe.com's avatar
      [CSS Exclusions] Implement empty segments for multiple-segment shape-insides · 9e5e8249
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100049
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Content should not overflow a shape-inside segment, even if that means no content
      will be placed in that segment. Overflow may be pushed to outside the shape. This
      patch removes the restriction that every line must consume at least some text
      input while inside a shape-inside. Content that does not fit is pushed down until
      it does, either inside the shape or just below it.
      
      Test: fast/exclusions/shape-inside/shape-inside-empty-segments.html
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::constructBidiRunsForSegment): Do not include empty segments for
      consideration, as the actual BidiRuns construction expects to consume at
      least one character.
      (WebCore::constructBidiRunsForLine): Ditto.
      (WebCore::firstPositiveWidth): Find the first positive word measurement width,
      as there may be some empty word break measurements inserted.
      (WebCore::adjustLogicalLineTop): Move the current line down, if necessary, to
      fit it within the shape inside.
      (WebCore::RenderBlock::layoutRunsAndFloatsInRange): If nothing fit in the
      current segment, find the first available position for the smallest item
      at the beginning of the text.
      (WebCore::RenderBlock::LineBreaker::nextLineBreak): Return an empty segment
      for a line that is inside the shape, but has no segments.
      (WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Do not consume
      input to meet minimum size requirements if you are inside a shape.
      
      LayoutTests:
      
      Testing that shape-insides do not place content where it will not fit. Also
      fixing up some previous tests and expectations.
      
      * fast/exclusions/resources/multi-segment-polygon.js:
      (simulateWithText): Enable multi-line shape expectations using arrays.
      * fast/exclusions/resources/simple-rectangle.js:
      (createRectangleTest): Add overflow: break-word property to tests.
      (createRectangleTestResult): Ditto.
      * fast/exclusions/shape-inside/shape-inside-empty-expected.html: Adjust results
      for tests where content should be pushed down.
      * fast/exclusions/shape-inside/shape-inside-empty-segments-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-empty-segments.html: Added.
      * fast/exclusions/shape-inside/shape-inside-empty.html: Shapes with height but
      no width should still push content down below the shape.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e5e8249
    • roger_fong@apple.com's avatar
      Remove uses of WebKit_Source from AppleWin build in WTF and JavaScriptCore. · 54aed783
      roger_fong@apple.com authored
      * JavaScriptCore.vcxproj/JavaScriptCore.make:
      * JavaScriptCore.vcxproj/build-generated-files.sh:
      * JavaScriptCore.vcxproj/copy-files.cmd:
      * JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
      * WTF.vcxproj/WTF.make:
      * WTF.vcxproj/copy-files.cmd:
      * WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:
      (react_to_vsprops_changes):
      (react_to_webkit1_interface_changes):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54aed783
    • rniwa@webkit.org's avatar
      Build fixes for the flakiness dashboard. · dd531c5c
      rniwa@webkit.org authored
      * TestResultServer/static-dashboards/flakiness_dashboard.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd531c5c
    • rniwa@webkit.org's avatar
      Add a missing null pointer check after r148759. · 2a42cf1e
      rniwa@webkit.org authored
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::containingBlock):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a42cf1e
    • jberlin@webkit.org's avatar
      [Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug builders · 521912ac
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114571
      
      * platform/mac-wk2/TestExpectations:
      The bots are also seeing image failures flakily, so add that expectation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      521912ac
    • jberlin@webkit.org's avatar
      [Mac Lion] media/W3C/video/events/event_canplay.html is flakey, sometimes times out · b45ce371
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114889
      
      * platform/mac-lion/TestExpectations:
      Mark it as such.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b45ce371
    • benjamin@webkit.org's avatar
      Use Vector instead of StringBuilder for CSSPreloadScanner's buffers · 0b08145a
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114794
      
      Reviewed by Ryosuke Niwa.
      
      Cleanup for other String changes.
      
      CSSPreloadScanner only handles UChar, StringBuilder was a little
      overkill.
      
      * html/parser/CSSPreloadScanner.cpp:
      (WebCore):
      (WebCore::ruleEqualIgnoringCase):
      (WebCore::CSSPreloadScanner::emitRule):
      * html/parser/CSSPreloadScanner.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b08145a
    • benjamin@webkit.org's avatar
      Remove the declaration of MemoryObjectInfo from StringImpl · 5a7fe1dd
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114788
      
      Reviewed by Andreas Kling.
      
      * wtf/text/StringImpl.h: The declaration is an other left over from chromium.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a7fe1dd
    • benjamin@webkit.org's avatar
      StyledMarkupAccumulator::appendText() should not allocate an intermediary StringBuilder · b171493f
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114847
      
      Reviewed by Geoffrey Garen.
      
      For some reason StyledMarkupAccumulator::appendText() was allocating a separate buffer
      for invoking appendStyleNodeOpenTag. This is a bad idea.
      
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
      (WebCore::StyledMarkupAccumulator::appendText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b171493f
    • joepeck@webkit.org's avatar
      Web Inspector: Support the SourceMap header, X-SourceMap was deprecated · 36fece81
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114888
      
      Check first for SourceMap, then fallback to X-SourceMap. Leaving in
      support for the deprecated header because most tools and articles
      online mention that version and have not yet updated.
      
      Reviewed by Timothy Hatcher.
      
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::sourceMapURLForResource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36fece81
    • joepeck@webkit.org's avatar
      Web Inspector: Backend should detect sourceMappingURLs in CSS Resources · 1a56ea53
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114854
      
      Source/WebCore:
      
      Reviewed by Timothy Hatcher.
      
      Test: http/tests/inspector/network/css-source-mapping-url.html
      
      * inspector/Inspector.json:
      - Page.getResourceTree - add sourceMapURL to resource payloads
      - Network.loadingFinished and Network.requestServedFromMemoryCache,
        include extra resource info object with possible sourceMapURL.
      
      * inspector/ContentSearchUtils.h:
      * inspector/ContentSearchUtils.cpp:
      (WebCore::ContentSearchUtils::scriptCommentPattern):
      (WebCore::ContentSearchUtils::stylesheetCommentPattern):
      (WebCore::ContentSearchUtils::findMagicComment):
      (WebCore::ContentSearchUtils::findScriptSourceURL):
      (WebCore::ContentSearchUtils::findScriptSourceMapURL):
      (WebCore::ContentSearchUtils::findStylesheetSourceMapURL):
      Separate Script and Stylesheet regex pattern creation, but
      share the search function using the pattern.
      
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
      (WebCore::InspectorDebuggerAgent::didParseSource):
      Update function names. Check for the SourceMap header before
      checking for a sourceMappingURL comment.
      
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::sourceMapURLForResource):
      (WebCore::InspectorPageAgent::buildObjectForFrameTree):
      Provide the sourceMapURL for Page.getResourceTree.
      
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::buildObjectForExtraResourceInfo):
      (WebCore::buildObjectForCachedResource):
      (WebCore::InspectorResourceAgent::didFinishLoading):
      (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
      Include ExtraResourceInfo objects in finish loading and
      request served from cache.
      
      LayoutTests:
      
      Test a different ways we would expect to see a sourceMapURL for
      stylesheet resources.
      
      Reviewed by NOBODY (OOPS!).
      
      * http/tests/inspector/network/css-source-mapping-url-expected.txt: Added.
      * http/tests/inspector/network/css-source-mapping-url.html: Added.
      * http/tests/inspector/network/resources/source-map-test-style.css: Added.
      * http/tests/inspector/network/resources/source-map-test-style.css.map: Added.
      * http/tests/inspector/network/resources/source-map-test-style.scss: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a56ea53
    • benjamin@webkit.org's avatar
      Rename JSStringJoiner::build() to join() · 0d9ed8b2
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114845
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-19
      Reviewed by Geoffrey Garen.
      
      The method name build() came from StringBuilder history. It does not make much
      sense on the StringJoiner.
      
      * runtime/ArrayPrototype.cpp:
      (JSC::arrayProtoFuncToString):
      (JSC::arrayProtoFuncToLocaleString):
      (JSC::arrayProtoFuncJoin):
      * runtime/JSStringJoiner.cpp:
      (JSC::JSStringJoiner::join):
      * runtime/JSStringJoiner.h:
      (JSStringJoiner):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d9ed8b2
    • benjamin@webkit.org's avatar
      Make StringImpl::cost const · f311e4e1
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114790
      
      Reviewed by Andreas Kling.
      
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::cost):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f311e4e1
    • shawnsingh@chromium.org's avatar
      Remove non-overlap testing code in RenderLayerCompositor · 905d0538
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85521
      
      Reviewed by Simon Fraser.
      
      m_compositingConsultsOverlap is always true in the current
      code. This patch removes this flag, and removes dead code that is
      never executed because it was never false.
      
      No new tests, no change in behavior.  The cleanup is covered by
      existing tests.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateCompositingLayersAfterScroll):
      removed if-statement that is always true.
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::shouldClipCompositedBounds):
      removed if-statement that would never get triggered.
      
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::RenderLayerCompositor):
      (WebCore::RenderLayerCompositor::updateCompositingLayers):
      removed m_compositingConsultsOverlap, and retained the code as if the flag were "true".
      
      * rendering/RenderLayerCompositor.h:
      (RenderLayerCompositor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      905d0538
    • commit-queue@webkit.org's avatar
      [BlackBerry] Find-on-page should do the scoping again when highlight policy changed · a2359989
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114885
      
      Patch by Andy Chen <andchen@blackberry.com> on 2013-04-19
      Reviewed by Rob Buis.
      
      PR 195773
      Internally reviewed by Mike Fenton.
      For find on page, we need to treat it as a new search if highlightAllMatches
      changes but the text is not changed.
      
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::findNextString):
      (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2359989
    • roger_fong@apple.com's avatar
      Unreviewed. WebKit_Source is incorrectly set. · 883ac6b3
      roger_fong@apple.com authored
      * WTF.vcxproj/WTF.make:
      * JavaScriptCore.vcxproj/JavaScriptCore.make:
      * WebCore.vcxproj/WebCore.make:
      * WebKit.vcxproj/WebKit.make:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      883ac6b3
    • rniwa@webkit.org's avatar
      Make loops in RenderObject::containingBlock homogeneous in their forms to simplify · f1835a14
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114853
      
      Reviewed by David Hyatt.
      
      This patch prepares us to avoid computing containing blocks during a depth-first traversal of the render tree.
      
      Extracted inline functions out of RenderBlock::containingBlock to make the code simpler. Also moved the code
      to obtain the nearest containing block out of the loop for a relatively positioned inline.
      
      * rendering/RenderObject.cpp:
      (WebCore::isNonReplacedInlineInFlowPosition): Extracted.
      (WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Extracted.
      (WebCore::isNonRenderBlockInline): Extracted.
      (WebCore::RenderObject::containingBlock): Refactored as stated above.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1835a14
    • timothy_horton@apple.com's avatar
      WebKit should not decode or support PDF favicons · 198e7c3d
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114650
      <rdar://problem/10133914>
      
      Reviewed by Dan Bernstein.
      
      Drop the image data on the floor if it begins with the PDF magic number.
      No other browser I can find on OS X supports PDF favicons (by experimentation),
      and we do not properly display them.
      
      * loader/icon/IconLoader.cpp:
      (WebCore::IconLoader::notifyFinished):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      198e7c3d
    • mrobinson@webkit.org's avatar
      Remove the OpenVG backend · 4447dfdd
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114881
      
      Reviewed by Tim Horton.
      
      * platform/graphics/FloatRect.h:
      (FloatRect): Remove #ifdefs for OpenVG backend.
      * platform/graphics/GraphicsContext.cpp:
      (WebCore): Ditto.
      * platform/graphics/GraphicsContext.h:
      * platform/graphics/NativeImagePtr.h:
      (WebCore): Ditto.
      * platform/graphics/Path.cpp:
      (WebCore): Ditto.
      * platform/graphics/Path.h:
      * platform/graphics/openvg/EGLDisplayOpenVG.cpp: Removed.
      * platform/graphics/openvg/EGLDisplayOpenVG.h: Removed.
      * platform/graphics/openvg/EGLUtils.h: Removed.
      * platform/graphics/openvg/GraphicsContextOpenVG.cpp: Removed.
      * platform/graphics/openvg/ImageOpenVG.cpp: Removed.
      * platform/graphics/openvg/PainterOpenVG.cpp: Removed.
      * platform/graphics/openvg/PainterOpenVG.h: Removed.
      * platform/graphics/openvg/PathOpenVG.cpp: Removed.
      * platform/graphics/openvg/PlatformPathOpenVG.h: Removed.
      * platform/graphics/openvg/SharedResourceOpenVG.cpp: Removed.
      * platform/graphics/openvg/SharedResourceOpenVG.h: Removed.
      * platform/graphics/openvg/SurfaceOpenVG.cpp: Removed.
      * platform/graphics/openvg/SurfaceOpenVG.h: Removed.
      * platform/graphics/openvg/TiledImageOpenVG.cpp: Removed.
      * platform/graphics/openvg/TiledImageOpenVG.h: Removed.
      * platform/graphics/openvg/VGUtils.cpp: Removed.
      * platform/graphics/openvg/VGUtils.h: Removed.
      * platform/graphics/transforms/AffineTransform.h:
      (AffineTransform): Ditto.
      * platform/graphics/transforms/TransformationMatrix.h:
      (TransformationMatrix): Ditto.
      * platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4447dfdd