1. 24 Sep, 2012 40 commits
    • paroga@webkit.org's avatar
      Remove String::operator+=() · e65252dc
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96172
      
      Reviewed by Benjamin Poulain.
      
      Source/WebCore:
      
      Replace the last usage with String::append() in Gtk.
      
      * platform/gtk/GtkInputMethodFilter.cpp:
      (WebCore::GtkInputMethodFilter::handleCommit):
      
      Source/WTF:
      
      * wtf/Platform.h:
      * wtf/text/WTFString.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e65252dc
    • pilgrim@chromium.org's avatar
      [Chromium][Mac] Remove loadFont from PlatformSupport · 32f73c9f
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97360
      
      Reviewed by Adam Barth.
      
      Part of a refactoring series. See tracking bug 82948.
      
      Source/WebCore:
      
      * platform/chromium/PlatformSupport.h:
      (PlatformSupport):
      * platform/graphics/chromium/CrossProcessFontLoading.mm:
      
      Source/WebKit/chromium:
      
      * src/PlatformSupport.cpp:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32f73c9f
    • tony@chromium.org's avatar
      Replace 2 uses of updateLogicalHeight with computeLogicalHeight · c3853eca
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97486
      
      Reviewed by Ojan Vafai.
      
      More work for bug 96804.  This is just a refactoring.
      
      No new tests, behavior should be the same as before.
      
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::computeLogicalHeight):
      * rendering/RenderFlowThread.h:
      * rendering/RenderMultiColumnFlowThread.cpp:
      (WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):
      (WebCore):
      * rendering/RenderMultiColumnFlowThread.h:
      (RenderMultiColumnFlowThread):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3853eca
    • kbr@google.com's avatar
      [V8] ArrayBuffer code should not pass a negative length to... · a188079a
      kbr@google.com authored
      [V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExternalArrayData()
      https://bugs.webkit.org/show_bug.cgi?id=96703
      
      Reviewed by Adam Barth.
      
      Check length arguments that may be passed to SetIndexedPropertiesToExternalArrayData.
      
      No tests because it is not guaranteed that buffers this large can actually be allocated.
      
      * bindings/v8/custom/V8ArrayBufferViewCustom.h:
      (WebCore::wrapArrayBufferView):
      (WebCore::constructWebGLArrayWithArrayBufferArgument):
      (WebCore::constructWebGLArray):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a188079a
    • antti@apple.com's avatar
      Split stylesheet related code out from Document · e5a88a78
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97353
      
      Reviewed by Andreas Kling.
      
      Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.
              
      The patch moves stylesheet upkeep, collection and invalidation code from Document to a separate
      DocumentStyleSheetCollection class. There are no functional changes.
              
      The usesLinkRules stylesheet feature bit and the related code is removed as no one was using it.
      
      * WebCore.xcodeproj/project.pbxproj:
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOneSelector):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver):
      (WebCore::StyleResolver::Features::Features):
      (WebCore::StyleResolver::Features::add):
      (WebCore::StyleResolver::Features::clear):
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * css/StyleResolver.h:
      (WebCore::StyleResolver::usesBeforeAfterRules):
      (Features):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::~Document):
      (WebCore::Document::setCompatibilityMode):
      (WebCore::Document::recalcStyle):
      (WebCore):
      (WebCore::Document::createStyleResolver):
      (WebCore::Document::seamlessParentUpdatedStylesheets):
      (WebCore::Document::didRemoveAllPendingStylesheet):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::styleSheets):
      (WebCore::Document::preferredStylesheetSet):
      (WebCore::Document::selectedStylesheetSet):
      (WebCore::Document::setSelectedStylesheetSet):
      (WebCore::Document::styleResolverChanged):
      (WebCore::Document::reportMemoryUsage):
      (WebCore::Document::haveStylesheetsLoaded):
      * dom/Document.h:
      (WebCore):
      (Document):
      (WebCore::Document::styleSheetCollection):
      (WebCore::Document::hasNodesWithPlaceholderStyle):
      (WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet):
      (WebCore::Document::inStyleRecalc):
      * dom/DocumentStyleSheetCollection.cpp: Added.
      (WebCore):
      (WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::pageUserSheet):
      (WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
      (WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
      (WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):
      (WebCore::DocumentStyleSheetCollection::clearPageGroupUserSheets):
      (WebCore::DocumentStyleSheetCollection::updatePageGroupUserSheets):
      (WebCore::DocumentStyleSheetCollection::addUserSheet):
      (WebCore::DocumentStyleSheetCollection::removePendingSheet):
      (WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
      (WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode):
      (WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
      (WebCore::DocumentStyleSheetCollection::testAddedStyleSheetRequiresStyleRecalc):
      (WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
      (WebCore::styleSheetsUseRemUnits):
      (WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
      (WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
      (WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
      (WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
      * dom/DocumentStyleSheetCollection.h: Added.
      (WebCore):
      (DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::authorStyleSheets):
      (WebCore::DocumentStyleSheetCollection::documentUserSheets):
      (WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
      (WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::addPendingSheet):
      (WebCore::DocumentStyleSheetCollection::hasPendingSheets):
      (WebCore::DocumentStyleSheetCollection::usesSiblingRules):
      (WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride):
      (WebCore::DocumentStyleSheetCollection::usesFirstLineRules):
      (WebCore::DocumentStyleSheetCollection::usesFirstLetterRules):
      (WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules):
      (WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules):
      (WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride):
      (WebCore::DocumentStyleSheetCollection::usesRemUnits):
      (WebCore::DocumentStyleSheetCollection::setUsesRemUnit):
      * dom/Element.cpp:
      (WebCore::Element::recalcStyle):
      * dom/ProcessingInstruction.cpp:
      (WebCore::ProcessingInstruction::~ProcessingInstruction):
      (WebCore::ProcessingInstruction::checkStyleSheet):
      (WebCore::ProcessingInstruction::sheetLoaded):
      (WebCore::ProcessingInstruction::insertedInto):
      (WebCore::ProcessingInstruction::removedFrom):
      * dom/StyleElement.cpp:
      (WebCore::StyleElement::insertedIntoDocument):
      (WebCore::StyleElement::removedFromDocument):
      (WebCore::StyleElement::clearDocumentData):
      (WebCore::StyleElement::createSheet):
      (WebCore::StyleElement::sheetLoaded):
      (WebCore::StyleElement::startLoadingDynamicSheet):
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::~HTMLLinkElement):
      (WebCore::HTMLLinkElement::insertedInto):
      (WebCore::HTMLLinkElement::removedFrom):
      (WebCore::HTMLLinkElement::addPendingSheet):
      (WebCore::HTMLLinkElement::removePendingSheet):
      * html/HTMLQuoteElement.cpp:
      (WebCore::HTMLQuoteElement::insertedInto):
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
      * mathml/MathMLMathElement.cpp:
      (WebCore::MathMLMathElement::insertedInto):
      * page/Page.cpp:
      (WebCore::Page::userStyleSheetLocationChanged):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::resetUserStyleCacheInAllFrames):
      * rendering/RenderBR.cpp:
      (WebCore::RenderBR::lineHeight):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::styleDidChange):
      (WebCore::RenderBlock::splitBlocks):
      (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
      (WebCore::RenderBlock::lineHeight):
      (WebCore::RenderBlock::updateFirstLetter):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::styleDidChange):
      (WebCore::RenderInline::updateAlwaysCreateLineBoxes):
      (WebCore::RenderInline::addChildIgnoringContinuation):
      (WebCore::RenderInline::splitInlines):
      (WebCore::RenderInline::lineHeight):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::uncachedFirstLineStyle):
      (WebCore::RenderObject::firstLineStyleSlowCase):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::firstLineStyle):
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::updateBeforeAfterContent):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::updateBeforeAndAfterContent):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::verticalPositionForBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5a88a78
    • commit-queue@webkit.org's avatar
      [BlackBerry] Reverting implementation for 407 error pages · 6c65e821
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97455
      
      Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-24
      Reviewed by Rob Buis.
      
      Source/WebCore:
      
      Revert "[BlackBerry] Reverting implementation for 407 error pages"
      This reverts commit fda0a1b6.
      
      This revert also reverts commit 0cffe019
      due to dependency issues.
      
      * PlatformBlackBerry.cmake:
      * platform/blackberry/AuthenticationChallengeManager.cpp: Removed.
      * platform/blackberry/AuthenticationChallengeManager.h:
      * platform/blackberry/PageClientBlackBerry.h:
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
      (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
      (WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
      (WebCore::MediaPlayerPrivate::notifyChallengeResult):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
      (MediaPlayerPrivate):
      * platform/network/blackberry/NetworkJob.cpp:
      (WebCore::NetworkJob::NetworkJob):
      (WebCore::NetworkJob::handleNotifyStatusReceived):
      (WebCore::NetworkJob::notifyAuthReceived):
      (WebCore::NetworkJob::handleNotifyClose):
      (WebCore::NetworkJob::sendRequestWithCredentials):
      (WebCore::NetworkJob::notifyChallengeResult):
      * platform/network/blackberry/NetworkJob.h:
      (NetworkJob):
      
      Source/WebKit/blackberry:
      
      Revert "[BlackBerry] Really fix bug 95488 that user can get the
      authentication challenge dialog while the other tab has focus."
      https://bugs.webkit.org/show_bug.cgi?id=97348
      
      This reverts commit 0cffe019.
      
      * Api/BlackBerryGlobal.cpp:
      (BlackBerry::WebKit::globalInitialize):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
      (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
      (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
      (BlackBerry::WebKit::WebPage::setVisible):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c65e821
    • crogers@google.com's avatar
      [REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing · b36882e6
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97439
      
      Reviewed by Kenneth Russell.
      
      Fixes uninitialized member variable.
      
      This should fix flaky failing test: webaudio/biquad-getFrequencyResponse.html
      
      * Modules/webaudio/BiquadProcessor.cpp:
      (WebCore::BiquadProcessor::BiquadProcessor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b36882e6
    • tony@chromium.org's avatar
      flex-grow should be 1 when omitted from flex shorthand · f72f3535
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97480
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      We were using 0, based on an outdated version of the spec.
      
      Tests: css3/flexbox/flex-property-parsing.html
             css3/flexbox/flex-algorithm.html: New test case.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFlex):
      
      LayoutTests:
      
      Update tests due to default CSS value changes.
      
      * css3/flexbox/flex-algorithm-expected.txt:
      * css3/flexbox/flex-algorithm.html: Add test case using -webkit-flex: auto.
      * css3/flexbox/flex-property-parsing-expected.txt:
      * css3/flexbox/flex-property-parsing.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f72f3535
    • benjamin@webkit.org's avatar
      Add support for query encoding to WTFURL · 6aa72d8c
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97422
      
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      Add the Charset conversion on WebCore side.
      
      * platform/KURLWTFURL.cpp:
      (WebCore::KURL::KURL):
      (CharsetConverter):
      (WebCore::CharsetConverter::CharsetConverter):
      * platform/mac/KURLMac.mm:
      (WebCore::KURL::KURL):
      
      Source/WTF: 
      
      Expose character conversion through the new abstract class URLQueryCharsetConverter.
      URLQueryCharsetConverter is implemented by WebCore to expose the TextEncoding classes.
      
      Unfortunatelly that forces us to bring over URLBuffer in the public API. We may be able
      to mitigate that later when moving WTFURL to more templates.
      
      The change fixes 2 of the URL layout tests.
      
      * WTF.xcodeproj/project.pbxproj:
      * wtf/url/api/ParsedURL.cpp:
      (WTF::ParsedURL::ParsedURL):
      * wtf/url/api/ParsedURL.h:
      (ParsedURL):
      ParsedURL was using the same constructor for ParsedURLString, and URL without a base.
      That was a mistake on my part, I did not intend that, fixed it now :)
      
      * wtf/url/api/URLBuffer.h: Renamed from Source/WTF/wtf/url/src/URLBuffer.h.
      (URLBuffer):
      (WTF::URLBuffer::URLBuffer):
      (WTF::URLBuffer::~URLBuffer):
      (WTF::URLBuffer::at):
      (WTF::URLBuffer::set):
      (WTF::URLBuffer::capacity):
      (WTF::URLBuffer::length):
      (WTF::URLBuffer::data):
      (WTF::URLBuffer::setLength):
      (WTF::URLBuffer::append):
      (WTF::URLBuffer::grow):
      * wtf/url/api/URLQueryCharsetConverter.h: Added.
      (URLQueryCharsetConverter):
      (WTF::URLQueryCharsetConverter::URLQueryCharsetConverter):
      (WTF::URLQueryCharsetConverter::~URLQueryCharsetConverter):
      * wtf/url/src/URLCanon.h:
      (URLCanonicalizer):
      * wtf/url/src/URLCanonFilesystemurl.cpp:
      (WTF::URLCanonicalizer::canonicalizeFileSystemURL):
      (WTF::URLCanonicalizer::ReplaceFileSystemURL):
      * wtf/url/src/URLCanonFileurl.cpp:
      (WTF::URLCanonicalizer::CanonicalizeFileURL):
      (WTF::URLCanonicalizer::ReplaceFileURL):
      * wtf/url/src/URLCanonInternal.h:
      (URLCanonicalizer):
      * wtf/url/src/URLCanonQuery.cpp:
      (WTF::URLCanonicalizer::CanonicalizeQuery):
      (WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):
      * wtf/url/src/URLCanonRelative.cpp:
      (WTF::URLCanonicalizer::resolveRelativeURL):
      * wtf/url/src/URLCanonStdURL.cpp:
      (WTF::URLCanonicalizer::CanonicalizeStandardURL):
      (WTF::URLCanonicalizer::ReplaceStandardURL):
      * wtf/url/src/URLUtil.cpp:
      (URLUtilities):
      (WTF::URLUtilities::canonicalize):
      (WTF::URLUtilities::resolveRelative):
      (WTF::URLUtilities::ReplaceComponents):
      * wtf/url/src/URLUtil.h:
      (URLUtilities):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aa72d8c
    • benjamin@webkit.org's avatar
      Integrate most of GoogleURL in WTFURL · 5f163cc9
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97405
      
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      Loosen KURLWTFURL to be able to run most tests in Debug.
      
      * platform/KURLWTFURL.cpp:
      (WebCore::KURL::KURL):
      (WebCore::KURL::hasPort):
      (WebCore::KURL::user):
      (WebCore::KURL::pass):
      (WebCore::KURL::hasPath):
      (WebCore::KURL::path):
      (WebCore::KURL::query):
      (WebCore::KURL::fragmentIdentifier):
      (WebCore::KURL::fileSystemPath):
      
      Source/WTF: 
      
      This patch brings almost all of the implementatation of Google-URL in WTFURL
      with only minor changes.
      
      The changes from the original code are mostly:
      -Code cleaning.
      -Replace url_parse::Parsed by URLSegments.
      -Replace url_parse::Component by URLComponent
      -More code cleaning.
      -Adopt URLBuffer and RawURLBuffer instead of the CanonOutputT and RawCanonOutputT.
      -Use URLCharacterTypes instead of the litany of characters functions.
      -Some more code cleaning.
      -Fix the style to match WebKit as much as possible.
      -Rename the files to match WebKit style.
      
      * WTF.xcodeproj/project.pbxproj:
      * wtf/url/api/ParsedURL.cpp:
      (WTF::ParsedURL::ParsedURL):
      (WTF::ParsedURL::segment):
      * wtf/url/api/ParsedURL.h:
      (WTF::ParsedURL::isValid):
      * wtf/url/src/RawURLBuffer.h:
      * wtf/url/src/URLCanon.h: Added.
      (URLCanonicalizer):
      (CharsetConverter):
      (WTF::URLCanonicalizer::CharsetConverter::CharsetConverter):
      (WTF::URLCanonicalizer::CharsetConverter::~CharsetConverter):
      (CanonHostInfo):
      (WTF::URLCanonicalizer::CanonHostInfo::CanonHostInfo):
      (WTF::URLCanonicalizer::CanonHostInfo::IsIPAddress):
      (WTF::URLCanonicalizer::CanonHostInfo::AddressLength):
      (URLComponentSource):
      (WTF::URLCanonicalizer::URLComponentSource::URLComponentSource):
      (Replacements):
      (WTF::URLCanonicalizer::Replacements::Replacements):
      (WTF::URLCanonicalizer::Replacements::SetScheme):
      (WTF::URLCanonicalizer::Replacements::IsSchemeOverridden):
      (WTF::URLCanonicalizer::Replacements::SetUsername):
      (WTF::URLCanonicalizer::Replacements::ClearUsername):
      (WTF::URLCanonicalizer::Replacements::IsUsernameOverridden):
      (WTF::URLCanonicalizer::Replacements::SetPassword):
      (WTF::URLCanonicalizer::Replacements::ClearPassword):
      (WTF::URLCanonicalizer::Replacements::IsPasswordOverridden):
      (WTF::URLCanonicalizer::Replacements::SetHost):
      (WTF::URLCanonicalizer::Replacements::ClearHost):
      (WTF::URLCanonicalizer::Replacements::IsHostOverridden):
      (WTF::URLCanonicalizer::Replacements::SetPort):
      (WTF::URLCanonicalizer::Replacements::ClearPort):
      (WTF::URLCanonicalizer::Replacements::IsPortOverridden):
      (WTF::URLCanonicalizer::Replacements::SetPath):
      (WTF::URLCanonicalizer::Replacements::ClearPath):
      (WTF::URLCanonicalizer::Replacements::IsPathOverridden):
      (WTF::URLCanonicalizer::Replacements::SetQuery):
      (WTF::URLCanonicalizer::Replacements::ClearQuery):
      (WTF::URLCanonicalizer::Replacements::IsQueryOverridden):
      (WTF::URLCanonicalizer::Replacements::SetRef):
      (WTF::URLCanonicalizer::Replacements::ClearRef):
      (WTF::URLCanonicalizer::Replacements::IsRefOverridden):
      (WTF::URLCanonicalizer::Replacements::sources):
      (WTF::URLCanonicalizer::Replacements::components):
      (WTF::URLCanonicalizer::Replacements::Placeholder):
      * wtf/url/src/URLCanonEtc.cpp: Added.
      (WTF::URLCanonicalizer::removeURLWhitespace):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::canonicalSchemeChar):
      (WTF::URLCanonicalizer::CanonicalizeScheme):
      (WTF::URLCanonicalizer::CanonicalizeUserInfo):
      (WTF::URLCanonicalizer::CanonicalizePort):
      (WTF::URLCanonicalizer::CanonicalizeRef):
      * wtf/url/src/URLCanonFilesystemurl.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeFileSystemURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::ReplaceFileSystemURL):
      * wtf/url/src/URLCanonFileurl.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeFileURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::FileCanonicalizePath):
      (WTF::URLCanonicalizer::ReplaceFileURL):
      * wtf/url/src/URLCanonHost.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeHost):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::CanonicalizeHostVerbose):
      * wtf/url/src/URLCanonICU.cpp: Added.
      (WTF::URLCanonicalizer::IDNToASCII):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::readUTFChar):
      * wtf/url/src/URLCanonIP.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeIPAddress):
      (URLCanonicalizer):
      * wtf/url/src/URLCanonInternal.cpp: Added.
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::AppendInvalidNarrowString):
      (WTF::URLCanonicalizer::ConvertUTF16ToUTF8):
      (WTF::URLCanonicalizer::ConvertUTF8ToUTF16):
      (WTF::URLCanonicalizer::SetupOverrideComponents):
      (WTF::URLCanonicalizer::SetupUTF16OverrideComponents):
      (WTF::URLCanonicalizer::_itoa_s):
      (WTF::URLCanonicalizer::_itow_s):
      * wtf/url/src/URLCanonInternal.h: Added.
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::hexCharToValue):
      (WTF::URLCanonicalizer::isDot):
      (WTF::URLCanonicalizer::appendURLEscapedCharacter):
      (WTF::URLCanonicalizer::doAppendUTF8):
      (WTF::URLCanonicalizer::AppendCharToOutput):
      (WTF::URLCanonicalizer::AppendUTF8Value):
      (WTF::URLCanonicalizer::AppendUTF8EscapedValue):
      (WTF::URLCanonicalizer::AppendUTF16Value):
      (WTF::URLCanonicalizer::AppendUTF8EscapedChar):
      (WTF::URLCanonicalizer::Is8BitChar):
      (WTF::URLCanonicalizer::DecodeEscaped):
      (WTF::URLCanonicalizer::_itoa_s):
      (WTF::URLCanonicalizer::_itow_s):
      (WTF::URLCanonicalizer::_strtoui64):
      * wtf/url/src/URLCanonMailto.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeMailtoURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::ReplaceMailtoURL):
      * wtf/url/src/URLCanonPath.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizePath):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::CanonicalizePartialPath):
      * wtf/url/src/URLCanonPathurl.cpp: Added.
      (WTF::URLCanonicalizer::canonicalizePathURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::ReplacePathURL):
      * wtf/url/src/URLCanonQuery.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeQuery):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):
      * wtf/url/src/URLCanonRelative.cpp: Added.
      (WTF::URLCanonicalizer::isRelativeURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::resolveRelativeURL):
      * wtf/url/src/URLCanonStdURL.cpp: Added.
      (WTF::URLCanonicalizer::DefaultPortForScheme):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::CanonicalizeStandardURL):
      (WTF::URLCanonicalizer::ReplaceStandardURL):
      * wtf/url/src/URLCharacterTypes.cpp:
      * wtf/url/src/URLCharacterTypes.h:
      (WTF::URLCharacterTypes::isComponentChar):
      (WTF::URLCharacterTypes::isHexChar):
      (WTF::URLCharacterTypes::isIPv4Char):
      (WTF::URLCharacterTypes::isQueryChar):
      (WTF::URLCharacterTypes::isCharacterOfType):
      (URLCharacterTypes):
      * wtf/url/src/URLEscape.cpp: Removed.
      * wtf/url/src/URLFile.h: Added.
      (URLParser):
      (WTF::URLParser::isWindowsDriveSeparator):
      (WTF::URLParser::isWindowsDriveLetter):
      (WTF::URLParser::findNextSlash):
      (WTF::URLParser::doesBeginWindowsDriveSpec):
      (WTF::URLParser::doesBeginUNCPath):
      * wtf/url/src/URLParse.cpp: Added.
      (WTF::URLParser::ExtractScheme):
      (URLParser):
      (WTF::URLParser::IsAuthorityTerminator):
      (WTF::URLParser::ExtractFileName):
      (WTF::URLParser::ExtractQueryKeyValue):
      (WTF::URLParser::ParseAuthority):
      (WTF::URLParser::ParsePort):
      (WTF::URLParser::ParseStandardURL):
      (WTF::URLParser::ParsePathURL):
      (WTF::URLParser::ParseFileSystemURL):
      (WTF::URLParser::ParseMailtoURL):
      (WTF::URLParser::parsePathInternal):
      (WTF::URLParser::ParseAfterScheme):
      * wtf/url/src/URLParse.h: Added.
      (URLParser):
      * wtf/url/src/URLParseFile.cpp: Added.
      (WTF):
      (WTF::URLParser::ParseFileURL):
      (URLParser):
      * wtf/url/src/URLParseInternal.h: Added.
      (URLParser):
      (WTF::URLParser::isURLSlash):
      (WTF::URLParser::shouldTrimFromURL):
      (WTF::URLParser::trimURL):
      (WTF::URLParser::countConsecutiveSlashes):
      * wtf/url/src/URLParser.h: Removed.
      * wtf/url/src/URLQueryCanonicalizer.h: Removed.
      * wtf/url/src/URLSegments.cpp:
      * wtf/url/src/URLSegments.h:
      (WTF::URLSegments::URLSegments):
      (URLSegments):
      (WTF::URLSegments::operator=):
      (WTF::URLSegments::innerURLSegments):
      (WTF::URLSegments::setInnerURLSegments):
      (WTF::URLSegments::clearInnerURLSegments):
      * wtf/url/src/URLUtil.cpp: Added.
      (URLUtilities):
      (WTF::URLUtilities::IsStandard):
      (WTF::URLUtilities::FindAndCompareScheme):
      (WTF::URLUtilities::Canonicalize):
      (WTF::URLUtilities::resolveRelative):
      (WTF::URLUtilities::ReplaceComponents):
      (WTF::URLUtilities::LowerCaseEqualsASCII):
      (WTF::URLUtilities::DecodeURLEscapeSequences):
      (WTF::URLUtilities::EncodeURIComponent):
      (WTF::URLUtilities::CompareSchemeComponent):
      * wtf/url/src/URLUtil.h: Added.
      (URLUtilities):
      * wtf/url/src/URLUtilInternal.h: Renamed from Source/WTF/wtf/url/src/URLEscape.h.
      (URLUtilities):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f163cc9
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] ExclusionShape API should use logical coordinates for input/output · 5678f008
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96156
      
      Patch by Hans Muller <hmuller@adobe.com> on 2012-09-24
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Correct how ExclusionShapes deal with logical coordinates and enable
      shape-inside exclusion layout for vertical writing-modes.
      
      BasicShape's are defined in physical cooordinates, incoming line and box
      dimensions are logical coordinates, and the ExclusionShape internals assume
      that lines are aligned with the Y axis. The createExclusionShape() method
      is responsible for converting the BasicShape to the internal coordinate
      system when the writing-mode is vertical. Similarly, the getInclude,ExcludedIntervals()
      methods are responsible for converting their logical line parameters to Y
      values in the internal coordinate system. The min,maxYForLogicalLine()
      methods do the conversion, based on the WritingMode the ExclusionShape
      was created with. The getInclude,ExcludedIntervals() methods return the
      logical left and right edges of line segments. No transformation is needed for this.
      
      The ExclusionShape's internal coordinate system is essentially the
      "logical" one, except that top/bottom always map to Y, no matter what
      the writing-mode is.  This is just to simplify writing geometrical shape
      algorithms, notably the complex ones for polygons. The bug report includes a
      pair of diagrams that clarify how internal coordinates are related to logical
      and physical coordinates.
      
      Test: fast/exclusions/shape-inside/shape-inside-vertical-text.html
      
      * rendering/ExclusionRectangle.cpp:
      (WebCore::ExclusionRectangle::getExcludedIntervals): rename more accurately reflects return value
      (WebCore::ExclusionRectangle::getIncludedIntervals): rename for consistency with "excluded" version
      * rendering/ExclusionRectangle.h:
      * rendering/ExclusionShape.cpp:
      (WebCore):
      (WebCore::ExclusionShape::createExclusionShape):
      * rendering/ExclusionShape.h:
      (LineSegment):
      (WebCore::LineSegment::LineSegment): relocated from WrapShapeInfo.h
      (WebCore):
      (ExclusionShape):
      (WebCore::ExclusionShape::minYForLogicalLine):
      (WebCore::ExclusionShape::maxYForLogicalLine):
      (WebCore::ExclusionShape::internalToLogicalBoundingBox):
      * rendering/WrapShapeInfo.cpp:
      (WebCore::WrapShapeInfo::isWrapShapeInfoEnabledForRenderBlock):
      (WebCore::WrapShapeInfo::computeShapeSize): pass writingMode to createExclusionShape()
      (WebCore::WrapShapeInfo::computeSegmentsForLine): removed short-circuit for vertical writing-modes
      * rendering/WrapShapeInfo.h:
      (WebCore):
      
      LayoutTests:
      
      Verify that shape-inside respects the writing-mode, notably the vertical writing-modes.
      
      * fast/exclusions/shape-inside/shape-inside-vertical-text-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-vertical-text.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5678f008
    • tony@chromium.org's avatar
      Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight · 845cf6e1
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97475
      
      Reviewed by Ojan Vafai.
      
      Using RenderMeter::computeLogicalHeight is part of bug 96804.
      Also fix some code to be vertical writing mode aware. This doesn't actually cause
      a behavioral difference because we use percentage heights/widths which don't depend on
      updateLogicalWidth or computeLogicalHeight.  You can still see bugs if you try to set
      the min-width on a <meter> node in a vertical writing mode.
      
      No new tests, no behavioral changes.
      
      * rendering/RenderMeter.cpp:
      (WebCore::RenderMeter::updateLogicalWidth): Make vertical writing mode aware.
      (WebCore::RenderMeter::computeLogicalHeight): Switch from updateLogicalHeight and make vertical writing mode aware.
      * rendering/RenderMeter.h:
      (RenderMeter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      845cf6e1
    • dglazkov@chromium.org's avatar
      Remove unbaked support for :scope pseudo-class. · 2f0a4c13
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97467
      
      Reviewed by Antti Koivisto.
      
      It turns out, the Selectors 4 require ":scope" to match contextual reference element set, which would be the root node in querySelector:
      http://dev.w3.org/csswg/selectors4/#the-scope-pseudo
      
      Right now, we simply make ":scope" equivalent to ":root", which is not correct. Let's remove the partial implementation until we have
      time/energy to fully implement it.
      
      Source/WebCore:
      
      No new tests, removing half-baked feature.
      
      * css/CSSSelector.cpp:
      (WebCore::CSSSelector::pseudoId): Removed all mentions of PseudoScope
      (WebCore::nameToPseudoTypeMap): Ditto.
      (WebCore::CSSSelector::extractPseudoType): Ditto.
      * css/CSSSelector.h: Ditto.
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOneSelector): Ditto.
      
      LayoutTests:
      
      * fast/css/style-scoped/scope-pseudo-expected.txt: Removed.
      * fast/css/style-scoped/scope-pseudo.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f0a4c13
    • rniwa@webkit.org's avatar
      suspend/resumeWidgetHierarchyUpdates should be a RAII object · 04ec298c
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96706
      
      Reviewed by Simon Fraser.
      
      Source/WebCore: 
      
      Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.
      
      * WebCore.exp.in: Export new symbols.
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChild):
      (WebCore::ContainerNode::removeChildren):
      * dom/Document.cpp:
      (WebCore::Document::recalcStyle):
      * dom/Element.cpp:
      (WebCore::Element::attach):
      (WebCore::Element::detach):
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::passMouseDownEventToWidget):
      * rendering/RenderWidget.cpp:
      (WebCore):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
      (WebCore::moveWidgetToParentSoon):
      * rendering/RenderWidget.h:
      (WidgetHierarchyUpdatesSuspensionScope):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
      (WebCore):
      (RenderWidget):
      
      Source/WebKit/mac: 
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _invalidateGStatesForTree]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04ec298c
    • commit-queue@webkit.org's avatar
      [BlackBerry] Reverting implementation for 407 error pages · fda0a1b6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97455
      
      Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-24
      Reviewed by Rob Buis.
      
      Revert "[BlackBerry] Show custom error page when 407 is received"
      This reverts commit e6d14529428fe47916fcb997528095b8acad2f2b.
      
      * platform/network/blackberry/NetworkJob.cpp:
      (WebCore::NetworkJob::handleNotifyStatusReceived):
      (WebCore::NetworkJob::notifyAuthReceived):
      (WebCore::NetworkJob::sendRequestWithCredentials):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fda0a1b6
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r129388. · c4157489
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/129388
      https://bugs.webkit.org/show_bug.cgi?id=97477
      
      Caused an assertion in a WebKit2 unit test (Requested by
      abarth on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-24
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::didBeginDocument):
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::willSendRequest):
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedImage.h:
      (WebCore::CachedImage::stillNeedsLoad):
      (CachedImage):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::didAddClient):
      * loader/cache/CachedResource.h:
      (WebCore):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::CachedResourceLoader):
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::revalidateResource):
      (WebCore::CachedResourceLoader::loadResource):
      (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      (WebCore::CachedResourceLoader::setAutoLoadImages):
      * loader/cache/CachedResourceLoader.h:
      (CachedResourceLoader):
      * page/Settings.cpp:
      (WebCore::setLoadsImagesAutomaticallyInAllFrames):
      (WebCore::Settings::Settings):
      (WebCore::Settings::setLoadsImagesAutomatically):
      (WebCore::Settings::loadsImagesAutomaticallyTimerFired):
      (WebCore::Settings::setImagesEnabled):
      * page/Settings.h:
      (Settings):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::Backup::Backup):
      (WebCore::InternalSettings::Backup::restoreTo):
      * testing/InternalSettings.h:
      (Backup):
      (InternalSettings):
      * testing/InternalSettings.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      
      LayoutTests:
      
      * fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Removed.
      * fast/loader/display-image-unset-allows-cached-image-load.html: Removed.
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Removed.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Removed.
      * fast/loader/resources/image1.html: Removed.
      * fast/loader/resources/image2.html: Removed.
      * platform/chromium/permissionclient/image-permissions-expected.txt:
      * platform/chromium/permissionclient/image-permissions.html:
      * platform/chromium/permissionclient/resources/image.html:
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4157489
    • arv@chromium.org's avatar
      DOM4 remove method · 8b0430f0
      arv@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73885
      
      Reviewed by Ojan Vafai.
      
      This adds the DOM 4 remove method.
      
      http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-childnode-remove
      
      The remove method removes the node from its parent if it has a parent.
      
      Source/WebCore:
      
      Tests: fast/dom/Comment/remove.html
             fast/dom/DocumentType/remove.html
             fast/dom/Element/remove.html
             fast/dom/Text/remove.html
      
      * dom/CharacterData.idl:
      * dom/DocumentType.idl:
      * dom/Element.idl:
      * dom/Node.cpp:
      (WebCore::Node::remove): The spec says to do nothing if the node has no parent.
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processStartTagForInBody): Cleanup.
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCue::removeDisplayTree): No need to check parenNode twice.
      
      LayoutTests:
      
      * fast/dom/Comment/remove-expected.txt: Added.
      * fast/dom/Comment/remove.html: Added.
      * fast/dom/DocumentType/remove-expected.txt: Added.
      * fast/dom/DocumentType/remove.html: Added.
      * fast/dom/Element/remove-expected.txt: Added.
      * fast/dom/Element/remove.html: Added.
      * fast/dom/Text/remove-expected.txt: Added.
      * fast/dom/Text/remove.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b0430f0
    • tommyw@google.com's avatar
      MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback · 8d37900d
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97456
      
      Reviewed by Adam Barth.
      
      Renamed onnegotationneeded to onnegotiationneeded.
      
      Source/WebCore:
      
      Existing test updated.
      
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::negotiationNeeded):
      * Modules/mediastream/RTCPeerConnection.h:
      (RTCPeerConnection):
      * Modules/mediastream/RTCPeerConnection.idl:
      * dom/EventNames.h:
      (WebCore):
      
      LayoutTests:
      
      * fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
      * fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d37900d
    • peter@chromium.org's avatar
      Android's mock scrollbars shows up as a difference in layout test results · d59609b9
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96382
      
      Reviewed by Adam Barth.
      
      Remove the exceptions made for layout tests in Android's scrollbar theme.
      This will make our actual scrollbars show up in layout test pixel results,
      bringing the tests closer to what we actually ship.
      
      An important difference with other platforms is that scrollbars do not
      take any width on Android, they're rendered on top of the content. Therefore
      each test that has a visible scrollbar does not just need a new pixel
      result, but will also need a new text result. This will be handled as part
      of a larger rebaselining process.
      
      Will be exercised by every layout test that has a scrollbar.
      
      * platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
      (WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
      (WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
      (WebCore::ScrollbarThemeChromiumAndroid::hasThumb):
      * platform/chromium/ScrollbarThemeChromiumAndroid.h:
      (ScrollbarThemeChromiumAndroid):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d59609b9
    • commit-queue@webkit.org's avatar
      [BlackBerry] Basic authentication challenge credentials for stored credentials... · b65798e9
      commit-queue@webkit.org authored
      [BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
      https://bugs.webkit.org/show_bug.cgi?id=96362
      
      Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-09-24
      Reviewed by Rob Buis.
      
      Fix a mistake of the commit 11fdc73c
      Trunk has been changed during reviewing that patch.
      
      No new tests, this is to correct a build error.
      
      * platform/network/blackberry/CredentialBackingStore.cpp:
      (WebCore::CredentialBackingStore::getProtectionSpace):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b65798e9
    • mitz@apple.com's avatar
      Source/WebCore: Reverted r129176, the fix for <http://webkit.org/b/97269>, because it introduced a · 9f3c69c8
      mitz@apple.com authored
      discrepancy between line breaking and max width computation.
      
      Rubber-stamped by Anders Carlsson.
      
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
      
      LayoutTests: Reveted r129176 and r129185.
      
      Rubber-stamped by Anders Carlsson.
      
      * platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt:
      * platform/mac/fast/text/emphasis-expected.png:
      * platform/mac/fast/text/emphasis-expected.txt:
      * platform/mac/fast/text/sticky-typesetting-features-expected.png:
      * platform/mac/fast/text/sticky-typesetting-features-expected.txt:
      * platform/mac/fast/text/thai-combining-mark-positioning-expected.png:
      * platform/mac/fast/text/thai-combining-mark-positioning-expected.txt:
      * platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
      * platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f3c69c8
    • commit-queue@webkit.org's avatar
      Reland "Add in-place reload behavior to ImagesEnabled setting" with optimizations · 2a1dff26
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97055
      
      Patch by Bo Liu <boliu@chromium.org> on 2012-09-24
      Reviewed by Adam Barth.
      
      Relanding 128780, 128676, 128645. Was reverted in 128914 due to
      performance regression in Chromium.
      
      New changes in addition to previously reverted patches:
      
      Refactored CachedResource::requestResource, loadResource, and
      revalidateResource. Moved CachedResource::load method to end of
      requestResource so there is one place where load is called for all
      resources.
      
      Added a enum parameter for requestResource and
      determineRevalidationPolicy so that FrameLoaderClient::allowImage call
      do not need to be called multiple times.
      
      Removed CachedImage::load call in requestImage so it is not called
      twice.
      
      Removed unnecessary Frame.h includes in CachedResource and
      CachedImage.
      
      Removed dead load() method declaration in CachedImage.
      
      Updated text expectation for two image-permissions tests to reflect
      the removed calls to allowImage.
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Tests: fast/loader/display-image-unset-allows-cached-image-load.html
             fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html
             fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html
      
      * WebCore.exp.in:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::didBeginDocument):
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::willSendRequest):
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedImage.h:
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::didAddClient):
      * loader/cache/CachedResource.h:
      (WebCore):
      (WebCore::CachedResource::stillNeedsLoad):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::CachedResourceLoader):
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::revalidateResource):
      (WebCore::CachedResourceLoader::loadResource):
      (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      (WebCore::CachedResourceLoader::setAutoLoadImages):
      (WebCore):
      (WebCore::CachedResourceLoader::setImagesEnabled):
      (WebCore::CachedResourceLoader::clientDefersImage):
      (WebCore::CachedResourceLoader::shouldDeferImageLoad):
      (WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):
      * loader/cache/CachedResourceLoader.h:
      (CachedResourceLoader):
      * page/Settings.cpp:
      (WebCore::setImageLoadingSettings):
      (WebCore::Settings::Settings):
      (WebCore::Settings::setLoadsImagesAutomatically):
      (WebCore::Settings::imageLoadingSettingsTimerFired):
      (WebCore::Settings::setImagesEnabled):
      * page/Settings.h:
      (Settings):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::Backup::Backup):
      (WebCore::InternalSettings::Backup::restoreTo):
      (WebCore::InternalSettings::setImagesEnabled):
      (WebCore):
      * testing/InternalSettings.h:
      (Backup):
      (InternalSettings):
      * testing/InternalSettings.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      
      LayoutTests:
      
      * fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Added.
      * fast/loader/display-image-unset-allows-cached-image-load.html: Added.
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Added.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Added.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Added.
      * fast/loader/resources/image1.html: Added.
      * fast/loader/resources/image2.html: Added.
      * platform/chromium/permissionclient/image-permissions-expected.txt:
      * platform/chromium/permissionclient/image-permissions.html:
      * platform/chromium/permissionclient/resources/image.html:
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a1dff26
    • commit-queue@webkit.org's avatar
      [GTK] Implement GraphicsLayer using Clutter · e884aa4d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73767
      
      Source/WebCore:
      
      Patch by Joone Hur  <joone.hur@intel.com>, Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-09-24
      Reviewed by Martin Robinson.
      
      This patch is needed for enabling Accelerated Compositing(Clutter backend)
      with the patches submitted in bug 92045 and 91940.
      
      No new tests. This will be covered by pixel tests for Qt/GTK+ accelerated
      compositing and 3D transforms.
      
      * GNUmakefile.list.am:
      * platform/clutter/GRefPtrClutter.cpp: Removed.
      * platform/clutter/GRefPtrClutter.h: Removed.
      * platform/graphics/clutter/PlatformClutterLayerClient.h: Added.
      (WebCore):
      (PlatformClutterLayerClient):
      (WebCore::PlatformClutterLayerClient::~PlatformClutterLayerClient):
      * platform/graphics/clutter/TransformationMatrixClutter.cpp: Added to convert CoglMatrix to
      TransformationMatrix.
      (WebCore):
      (WebCore::TransformationMatrix::operator CoglMatrix):
      * platform/graphics/transforms/TransformationMatrix.h:
      (TransformationMatrix):
      
      Source/WebKit/gtk:
      
      Patch by Joone Hur <joone.hur@intel.com> on 2012-09-24
      Reviewed by Martin Robinson.
      
      This patch is needed for enabling Accelerated Compositing(Clutter backend)
      with the patches submitted in bug 92045 and 91940.
      
      * WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
      (WebKit::AcceleratedCompositingContext::scrollNonCompositedContents): Added to fix bulid break.
      (WebKit):
      
      Source/WebKit2:
      
      Patch by Joone Hur  <joone.hur@intel.com>, Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-09-24
      Reviewed by Martin Robinson.
      
      Fixed link errors by adding Clutter library and header to WebKit2 build.
      
      * GNUmakefile.am:
      
      Source/WTF:
      
      Patch by Joone Hur <joone.hur@intel.com> on 2012-09-24
      Reviewed by Martin Robinson.
      
      Add ClutterActor and GraphicsLayerActor to GTypedefs.h.
      
      * wtf/gobject/GTypedefs.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e884aa4d
    • dgrogan@chromium.org's avatar
      Unprefix IndexedDB · f5571a27
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96548
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      We are largely compatible with the FF implementation and the w3c test
      suite submitted by MS. The w3c test suite doesn't yet check
      for lack of prefix; this is mostly to signal to devs that we think our
      implementation is stable.
      
      This patch uses the new FeatureObserver to get data about prefixed
      vs unprefixed usage.
      
      Tests: storage/indexeddb/unprefix-workers.html
             storage/indexeddb/unprefix.html
      
      * Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
      (WebCore::DOMWindowIndexedDatabase::indexedDB):
      * Modules/indexeddb/DOMWindowIndexedDatabase.h:
      (DOMWindowIndexedDatabase):
      * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
      * Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
      (WebCore::WorkerContextIndexedDatabase::indexedDB):
      * Modules/indexeddb/WorkerContextIndexedDatabase.h:
      (WorkerContextIndexedDatabase):
      * Modules/indexeddb/WorkerContextIndexedDatabase.idl:
      * bindings/generic/RuntimeEnabledFeatures.h:
      Making the auxiliary objects RuntimeEnabled didn't make much sense as
      they are useless without the factory, so always enable them.
      
      (WebCore::RuntimeEnabledFeatures::indexedDBEnabled):
      * bindings/scripts/CodeGeneratorGObject.pm:
      (SkipAttribute):
      * page/FeatureObserver.h:
      
      LayoutTests:
      
      * storage/indexeddb/resources/unprefix.js: Added.
      (test):
      * storage/indexeddb/unprefix-expected.txt: Added.
      * storage/indexeddb/unprefix-workers-expected.txt: Added.
      * storage/indexeddb/unprefix-workers.html: Added.
      * storage/indexeddb/unprefix.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5571a27
    • commit-queue@webkit.org's avatar
      Web Inspector: [WebGL] First step towards 2D canvas instrumentation in injected script · d6d83d65
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96746
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-24
      Reviewed by Pavel Feldman.
      
      First step towards the 2D canvas instrumentation from the WebGL injected script module side.
      We trace and save all calls that affect the 2D canvas context state and it's resources (Gradient and Pattern)
      so that we could replay the context and resources states later.
      The 2D canvas context state consists of:
      - current transformation matrix
      - current default path
      - current clipping region (affected by the "clip" command)
      - current values of the context attributes (like strokeStyle, fillStyle, etc.)
      - a stack of saved drawing states (affected by the "save" and "restore" commands)
      
      * inspector/InjectedScriptCanvasModuleSource.js:
      (.):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6d83d65
    • commit-queue@webkit.org's avatar
      Web Inspector: [TextEditor] conditional breakpoint popup not showing up the first time · 689fbde1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97442
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-24
      Reviewed by Pavel Feldman.
      
      1) The conditional breakpoint popup may not show up the first time we click on the gutter.
      This was the case because the popup decoration element would be deleted from the line while
      it was being highlighted and appended afterwards. Now we do not remove decorations from the
      DOM while highlighting.
      
      2) Also the popup will close itself on any mouse click event, even if it's targeted to the
      input box itself. This was due to pointer-events: none; CSS style for the parent element.
      Now we just override this style for the input box.
      
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.TextEditorMainPanel.prototype._paintLine):
      (WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
      (WebInspector.TextEditorMainPanel.prototype._insertTextNodeBefore):
      * inspector/front-end/inspector.css:
      (.source-frame-breakpoint-condition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      689fbde1
    • commit-queue@webkit.org's avatar
      Web Inspector: [Canvas] set CanvasAgent in InstrumentingAgents upon calling enable command · 8d67cf8e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97331
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-24
      Reviewed by Yury Semikhatsky.
      
      We should set CanvasAgent in InstrumentingAgents from enable() command and remove from disable(), instead of doing this in constructor and destructor.
      
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
      (WebCore::InspectorCanvasAgent::~InspectorCanvasAgent):
      (WebCore::InspectorCanvasAgent::restore):
      (WebCore::InspectorCanvasAgent::enable):
      (WebCore::InspectorCanvasAgent::disable):
      * inspector/InspectorCanvasAgent.h:
      (InspectorCanvasAgent):
      * inspector/InspectorCanvasInstrumentation.h:
      (WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
      (WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d67cf8e
    • paroga@webkit.org's avatar
      Remove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files · 2fbdf5c8
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97412
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      * css/StylePropertySet.cpp: Removed useless define.
      
      Source/WebKit/chromium:
      
      * src/WebPageSerializerImpl.cpp:
      (WebKit::WebPageSerializerImpl::openTagToString): Replaced operator+= with StringBuilder::append().
      (WebKit::WebPageSerializerImpl::endTagToString): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fbdf5c8
    • eae@chromium.org's avatar
      snapToSize rounds the incorrectly for negative locations · e4e7ab94
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97265
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      Change snapSizeToPixel to preserve sign for location which
      affects rounding.
      
      Test: fast/sub-pixel/snap-negative-location.html
      
      * platform/FractionalLayoutUnit.h:
      (WebCore::snapSizeToPixel):
      
      LayoutTests: 
      
      Add test for snapSizeToPixel handling of negative locations.
      Skipped on platforms that do not enable subpixel layout.
      
      * fast/sub-pixel/snap-negative-location-expected.html: Added.
      * fast/sub-pixel/snap-negative-location.html: Added.
      * platform/mac-lion/Skipped:
      * platform/mac-snowleopard/Skipped:
      * platform/mac-wk2/Skipped:
      * platform/mac/Skipped:
      * platform/qt-4.8/Skipped:
      * platform/qt/Skipped:
      * platform/win-wk2/Skipped:
      * platform/win-xp/Skipped:
      * platform/win/Skipped:
      * platform/wincairo/Skipped:
      * platform/wk2/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4e7ab94
    • commit-queue@webkit.org's avatar
      Use unsigned char for bitfield instead of unsigned. · 31db2b6b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97447
      
      Patch by Jonathan Liu <net147@gmail.com> on 2012-09-24
      Reviewed by Andreas Kling.
      
      Not all compilers will pad an unsigned bitfield to the smallest size.
      Use unsigned char instead of unsigned to reduce padding for compilers
      that pad to the underlying type.
      
      No new tests. There is already a compile-time assertion.
      
      * css/CSSRule.cpp:
      (SameSizeAsCSSRule):
      * css/CSSRule.h:
      (CSSRule):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31db2b6b
    • commit-queue@webkit.org's avatar
      Web Inspector: don't allow exception in front-end when expanding function scope · 6f343273
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97346
      
      Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-09-24
      Reviewed by Yury Semikhatsky.
      
      A missing guard condition is added.
      
      * inspector/front-end/ObjectPropertiesSection.js:
      (WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
      (WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f343273
    • anilsson@rim.com's avatar
      [BlackBerry] Add cookie database API · 117cd7a8
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97102
      
      Reviewed by Antonio Gomes.
      
      Source/WebCore:
      
      Add a CookieManager method that takes a list of strings to parse
      instead of just one string. Expose CookieParser::parseOneCookie.
      
      Reviewed internally by Otto D. Cheung.
      
      No change in behavior, no new tests.
      
      * platform/blackberry/CookieManager.cpp:
      (WebCore::CookieManager::setCookies):
      (WebCore):
      * platform/blackberry/CookieManager.h:
      * platform/blackberry/CookieParser.cpp:
      (WebCore::CookieParser::parseOneCookie):
      (WebCore):
      * platform/blackberry/CookieParser.h:
      (CookieParser):
      
      Source/WebKit:
      
      Add cookie database file to build system.
      
      Reviewed internally by Otto D. Cheung.
      
      * PlatformBlackBerry.cmake:
      
      Source/WebKit/blackberry:
      
      The cookie database is exposed through WebCookieJar, which has only two
      methods: cookies() and setCookies().
      
      Also add a new WebString::fromUTF8 overload that takes a const char*
      and a length, in order to avoid a strlen call when converting from
      other string classes to WebString. This is useful for callers of the
      new cookie API when converting cookies to WebString.
      
      Reviewed internally by Otto D. Cheung.
      
      PR 209282
      
      * Api/WebCookieJar.cpp: Added.
      (WebKit):
      (BlackBerry::WebKit::WebCookieJar::WebCookieJar):
      (BlackBerry::WebKit::WebCookieJar::cookies):
      (BlackBerry::WebKit::WebCookieJar::setCookies):
      * Api/WebCookieJar.h: Added.
      (WebKit):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
      (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
      (BlackBerry::WebKit::WebPage::cookieJar):
      (WebKit):
      * Api/WebPage.h:
      (WebKit):
      * Api/WebPage_p.h:
      (WebKit):
      (WebPagePrivate):
      * Api/WebString.cpp:
      (BlackBerry::WebKit::WebString::fromUtf8):
      (WebKit):
      * Api/WebString.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      117cd7a8
    • vsevik@chromium.org's avatar
      Web Inspector: Open resource dialog has too many false positive matches. · 65319920
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97332
      
      Reviewed by Alexander Pavlov.
      
      Source/WebCore:
      
      Improved open resource dialog filtering to make the amount of false
      positive search results less.
      
      * inspector/front-end/FilteredItemSelectionDialog.js:
      (WebInspector.FilteredItemSelectionDialog.prototype._innerCreateSearchRegExp):
      (WebInspector.FilteredItemSelectionDialog.prototype._highlightItem.get var):
      (WebInspector.FilteredItemSelectionDialog.prototype._highlightItem):
      
      LayoutTests:
      
      * inspector/filtered-item-selection-dialog-filtering-expected.txt:
      * inspector/filtered-item-selection-dialog-filtering.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65319920
    • commit-queue@webkit.org's avatar
      Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code · 04782668
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97203
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-24
      Reviewed by Yury Semikhatsky.
      
      Implements wrapping a 2D canvas context through the injected canvas module script facility.
      
      * bindings/js/JSHTMLCanvasElementCustom.cpp:
      (WebCore::JSHTMLCanvasElement::getContext):
      * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
      (WebCore::V8HTMLCanvasElement::getContextCallback):
      * inspector/InjectedScriptCanvasModule.cpp:
      (WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
      (WebCore):
      (WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
      (WebCore::InjectedScriptCanvasModule::callWrapContextFunction):
      * inspector/InjectedScriptCanvasModule.h:
      (InjectedScriptCanvasModule):
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
      (WebCore):
      * inspector/InspectorCanvasAgent.h:
      (InspectorCanvasAgent):
      * inspector/InspectorCanvasInstrumentation.h:
      (WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
      (WebCore):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04782668
    • pfeldman@chromium.org's avatar
      Web Inspector:EXC_BAD_ACCESS upon closing page with node highlighted · ec9f9d74
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97446
      
      Reviewed by Alexander Pavlov.
      
      Added 0 check on frame view.
      
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::update):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec9f9d74
    • apavlov@chromium.org's avatar
      Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode... · 862a853b
      apavlov@chromium.org authored
      Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden
      https://bugs.webkit.org/show_bug.cgi?id=97249
      
      Reviewed by Yury Semikhatsky.
      
      Fix regression from r125871.
      
      * inspector/front-end/InspectorFrontendAPI.js:
      (InspectorFrontendAPI.enterInspectElementMode):
      * inspector/front-end/inspector.js:
      (WebInspector._createGlobalStatusBarItems):
      (WebInspector.documentKeyDown):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      862a853b
    • apavlov@chromium.org's avatar
      Web Inspector: Disable persistence of master switches in the "Overrides" settings tab · fea797ab
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97440
      
      Reviewed by Yury Semikhatsky.
      
      Disables enforcement of device metrics, geolocation, and device orientation overrides on Web Inspector start.
      
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::restore):
      * inspector/front-end/SettingsScreen.js:
      (WebInspector.UserAgentSettingsTab.prototype._onMetricsCheckboxClicked):
      (WebInspector.UserAgentSettingsTab.prototype._onGeolocationOverrideCheckboxClicked):
      (WebInspector.UserAgentSettingsTab.prototype._onDeviceOrientationOverrideCheckboxClicked):
      * inspector/front-end/UserAgentSupport.js:
      (WebInspector.UserAgentSupport):
      (WebInspector.UserAgentSupport.prototype.toggleDeviceMetricsOverride):
      (WebInspector.UserAgentSupport.prototype.toggleGeolocationPositionOverride):
      (WebInspector.UserAgentSupport.prototype.toggleDeviceOrientationOverride):
      * inspector/front-end/externs.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fea797ab
    • commit-queue@webkit.org's avatar
      Web Inspector: implement testing harness for pure protocol tests. · b3cd24a0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90675
      
      Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-09-24
      Reviewed by Yury Semikhatsky.
      
      .:
      
      Added export symbols required for Gtk+ to support the Inspector Protocol
      testing harness.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Implementing the testing harness as the APIs of Internals object not
      only reduced platform specific patching of DRTs but also minimized the
      the effort required to open up the new dummy inspector Frontend.
      
      The openDummyInspectorFrontend method will return the handle to newly
      created DOMWindow. This DOMWindow object can be utilized inside the test
      case to communicate using postMessage WebAPI.
      
      The newly created DOMWindow will host the protocol-test.html which
      will seed the necessary JS libraries to communicate with the
      InspectorBackend.
      
      Test: inspector-protocol/css-getSupportedCSSProperties.html
      
      * WebCore.exp.in:
      * WebCore.gypi:
      * inspector/InspectorClient.h:
      (InspectorClient):
      * testing/Internals.cpp:
      (InspectorFrontendClientDummy):
      (WebCore::InspectorFrontendClientDummy::~InspectorFrontendClientDummy):
      (WebCore):
      (WebCore::InspectorFrontendClientDummy::InspectorFrontendClientDummy):
      (InspectorFrontendChannelDummy):
      (WebCore::InspectorFrontendChannelDummy::~InspectorFrontendChannelDummy):
      (WebCore::InspectorFrontendChannelDummy::InspectorFrontendChannelDummy):
      (WebCore::InspectorFrontendChannelDummy::sendMessageToFrontend):
      (WebCore::Internals::consoleMessageArgumentCounts):
      (WebCore::Internals::openDummyInspectorFrontend):
      (WebCore::Internals::closeDummyInspectorFrontend):
      * testing/Internals.h:
      (WebCore):
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      Adding the export symbol definitions required on Apple Windows and WinCairo
      ports to support Inspector Protocol testing harness.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      Adding the resources required for the dummy frontend page to load minimal
      frontend. These resources provide the mechanism to talk to the Inspector Backend.
      
      Adding the inspector-protocol folder to host the relevant test cases
      utilizing the inspector protocol test harness. Added an example test
      case for getting all supported CSS properties using the inspector
      protocol and searching for a particular property being supported.
      
      * http/tests/inspector-protocol: Added.
      * http/tests/inspector-protocol/resources: Added.
      * http/tests/inspector-protocol/resources/InspectorTest.js: Added.
      (InspectorTest.sendCommand):
      (WebInspector.dispatchMessageFromBackend):
      (InspectorTest.log):
      (InspectorTest.completeTest):
      * http/tests/inspector-protocol/resources/protocol-test.html: Added.
      * http/tests/inspector-protocol/resources/protocol-test.js: Added.
      (log):
      (closeTest):
      (runTest):
      * inspector-protocol: Added.
      * inspector-protocol/css-getSupportedCSSProperties-expected.txt: Added.
      * inspector-protocol/css-getSupportedCSSProperties.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3cd24a0
    • keishi@webkit.org's avatar
      REGRESSION(r127727): Calendar picker focus doesn't loop in calendar-picker.html · 4d0ff26b
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97183
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Fixing bug calendar-picker.html. The page popup behaves fine because
      this code is only necessary in calendar-picker.html where the focus can
      move outside of the picker because we are just using an iframe.
      
      No new tests. Added tests to calendar-picker-key-operations.html.
      
      * Resources/pagepopups/calendarPicker.js:
      (YearMonthController.prototype.attachTo):
      (CalendarPicker.prototype._handleBodyKeyDown):
      
      LayoutTests:
      
      * fast/forms/date/calendar-picker-key-operations-expected.txt:
      * fast/forms/date/calendar-picker-key-operations.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d0ff26b
    • caseq@chromium.org's avatar
      Unreviewed follow-up to r129336 -- fixed closure compiler warnings. · 76f48774
      caseq@chromium.org authored
      * inspector/front-end/HAREntry.js:
      * inspector/front-end/TimelineModel.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76f48774