1. 08 Jun, 2012 40 commits
    • efidler@rim.com's avatar
      [BlackBerry] Default font settings are getting deleted · e6020fbc
      efidler@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88670
      
      Reviewed by Rob Buis.
      
      Source/WebKit/blackberry:
      
      RIM PR: 163720
      
      WebSettings is overriding the default font settings with "", which deletes them.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
      
      LayoutTests:
      
      This test crashes if -webkit-body (i.e.  WebCore::Settings::standardFontFamily())
      is not a valid font family.
      
      * fonts/valid-standard-font.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6020fbc
    • ggaren@apple.com's avatar
      Unreviewed, rolling back in part1 of r118646. · 218a16a3
      ggaren@apple.com authored
      This patch includes everything necessary for lazy finalization, but
      keeps eager finalization enabled for the time being.
      
      Weak pointer finalization should be lazy
      https://bugs.webkit.org/show_bug.cgi?id=87599
      
      Reviewed by Sam Weinig.
      
      * heap/MarkedBlock.cpp:
      * heap/MarkedBlock.h:
      (JSC::MarkedBlock::resetAllocator):
      * heap/MarkedSpace.cpp:
      (JSC::MarkedSpace::resetAllocators):
      * heap/MarkedSpace.h:
      (JSC::MarkedSpace::resetAllocators): Don't force allocator reset anymore.
      It will happen automatically when a weak set is swept. It's simpler to
      have only one canonical way for this to happen, and it wasn't buying
      us anything to do it eagerly.
      * heap/WeakBlock.cpp:
      (JSC::WeakBlock::sweep): Don't short-circuit a sweep unless we know
      the sweep would be a no-op. If even one finalizer is pending, we need to
      run it, since we won't get another chance.
      * heap/WeakSet.cpp:
      (JSC::WeakSet::sweep): This loop can be simpler now that
      WeakBlock::sweep() does what we mean.
      Reset our allocator after a sweep because this is the optimal time to
      start trying to recycle old weak pointers.
      (JSC::WeakSet::tryFindAllocator): Don't sweep when searching for an
      allocator because we've swept already, and forcing a new sweep would be
      wasteful.
      * heap/WeakSet.h:
      (JSC::WeakSet::shrink): Be sure to reset our allocator after a shrink
      because the shrink may have removed the block the allocator was going to
      allocate out of.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      218a16a3
    • ap@apple.com's avatar
      <rdar://problem/11412294> Add appropriate iOS default font settings · d6c0df08
      ap@apple.com authored
              Reviewed by Dan Bernstein.
      
              * page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6c0df08
    • charles.wei@torchmobile.com.cn's avatar
      IndexedDB: Transactions without any request scheduled should abort itself. · f3b125d0
      charles.wei@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=88052
      
      Reviewed by Kentaro Hara.
      
      This is needed for indexedDB to make it work for JSC. We need to clean up all the
      pending transactions(transactions without any request scheduled) when leaving Javascript context.
      
      Manually tested using the existing test LayoutTests/storage/indexeddb/tutorial.html
      
      * bindings/js/JSMainThreadExecState.cpp:
      (WebCore):
      (WebCore::JSMainThreadExecState::didLeaveScriptContext):
      * bindings/js/JSMainThreadExecState.h:
      (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
      (JSMainThreadExecState):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3b125d0
    • ojan@chromium.org's avatar
      Final set of chromium rebaselines for skia change. See crbug.com/131829. · 673f1fab
      ojan@chromium.org authored
      * platform/chromium-linux/svg/clip-path/clipper-placement-issue-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
      * platform/chromium-linux/svg/css/arrow-with-shadow-expected.png: Added.
      * platform/chromium-linux/svg/css/background-image-svg-expected.png: Added.
      * platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
      * platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Added.
      * platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Added.
      * platform/chromium-linux/svg/custom/svgpolyparser-extra-space-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
      * platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Added.
      * platform/chromium-linux/svg/custom/use-on-clip-path-with-transformation-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
      * platform/chromium-linux/svg/text/text-hkern-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
      * platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
      * platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
      * platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
      * platform/chromium-linux/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
      * platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
      * platform/chromium-linux/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
      * platform/chromium-linux/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
      * platform/chromium-win-xp/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Removed.
      * platform/chromium-win/svg/custom/js-late-marker-creation-expected.png:
      * platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
      * platform/chromium-win/svg/custom/js-update-bounce-expected.png:
      * platform/chromium-win/svg/custom/js-update-container-expected.png:
      * platform/chromium-win/svg/custom/js-update-path-changes-expected.png:
      * platform/chromium-win/svg/custom/js-update-path-removal-expected.png:
      * platform/chromium-win/svg/custom/js-update-polygon-changes-expected.png:
      * platform/chromium-win/svg/custom/js-update-polygon-removal-expected.png:
      * platform/chromium-win/svg/custom/js-update-transform-addition-expected.png:
      * platform/chromium-win/svg/custom/js-update-transform-changes-expected.png:
      * platform/chromium-win/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
      * platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
      * platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
      * platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
      * platform/chromium-win/svg/custom/linking-a-03-b-viewTarget-expected.png:
      * platform/chromium-win/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
      * platform/chromium-win/svg/custom/linking-uri-01-b-expected.png:
      * platform/chromium-win/svg/custom/marker-changes-expected.png:
      * platform/chromium-win/svg/custom/marker-child-changes-css-expected.png:
      * platform/chromium-win/svg/custom/marker-child-changes-expected.png:
      * platform/chromium-win/svg/custom/marker-opacity-expected.png:
      * platform/chromium-win/svg/custom/marker-referencePoint-expected.png:
      * platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png:
      * platform/chromium-win/svg/custom/marker-viewBox-changes-expected.png:
      * platform/chromium-win/svg/custom/mask-colorspace-expected.png:
      * platform/chromium-win/svg/custom/mask-on-multiple-objects-expected.png:
      * platform/chromium-win/svg/custom/no-inherited-dashed-stroke-expected.png:
      * platform/chromium-win/svg/custom/non-circular-marker-reference-expected.png:
      * platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.png:
      * platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.png:
      * platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.png:
      * platform/chromium-win/svg/filters/invalidate-on-child-layout-expected.png:
      * platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      673f1fab
    • mrobinson@webkit.org's avatar
      Fix the GTK+ build when OpenGL is enabled. · 214e0b8b
      mrobinson@webkit.org authored
      * configure.ac: Fix the build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      214e0b8b
    • ojan@chromium.org's avatar
      viewspec-parser tests still timeout in Chromium debug even when marked slow. · c24dcc05
      ojan@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c24dcc05
    • rniwa@webkit.org's avatar
      Crash in WebCore::CompositeEditCommand::breakOutOfEmptyListItem · c416e20a
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88361
      
      Reviewed by Levi Weintraub.
      
      Use RefPtr instead of raw pointers across DOM mutations.
      
      No tests are added for the lack of a reliable reduction.
      
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c416e20a
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r119514. · 362c93e5
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/119514
      https://bugs.webkit.org/show_bug.cgi?id=88664
      
      Broke JSFiddle.net (Requested by arv on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08
      
      Source/WebCore:
      
      * bindings/v8/V8DOMWindowShell.cpp:
      (WebCore::V8DOMWindowShell::initContextIfNeeded):
      * bindings/v8/WorkerContextExecutionProxy.cpp:
      (WebCore::WorkerContextExecutionProxy::initIsolate):
      
      LayoutTests:
      
      * fast/dom/Window/window-property-shadowing-name-expected.txt:
      * fast/dom/Window/window-property-shadowing-name.html:
      * fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
      * fast/dom/Window/window-property-shadowing-onclick.html: Removed.
      * platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Removed.
      * platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      362c93e5
    • rniwa@webkit.org's avatar
      Crash in WebCore::InsertParagraphSeparatorCommand::doApply · b6a8d0cf
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88108
      
      Reviewed by Levi Weintraub.
      
      Use NodeVector instead of walking through siblings as we mutate the DOM.
      
      No new tests are added since there is no reliable reduction.
      
      * editing/BreakBlockquoteCommand.cpp:
      (WebCore::BreakBlockquoteCommand::doApply):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::moveRemainingSiblingsToNewParent):
      (WebCore):
      * editing/CompositeEditCommand.h:
      (CompositeEditCommand):
      * editing/InsertParagraphSeparatorCommand.cpp:
      (WebCore::InsertParagraphSeparatorCommand::doApply):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6a8d0cf
    • mrobinson@webkit.org's avatar
      [GTK] build accelerated compositing on by default if OpenGL is present · 940af951
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88677
      
      Reviewed by Alejandro G. Castro.
      
      Build accelerated compositing by default if OpenGL is present, just like WebGL.
      Also prevent enabling WebGL if Clutter is turned on.
      
      * configure.ac: Build AC by default.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      940af951
    • dgrogan@chromium.org's avatar
      IndexedDB: rename some instances of open to registerFrontendCallbacks · bad6c335
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88611
      
      Source/WebCore:
      
      We should still make the change in the WebKit API.
      
      Reviewed by Tony Chang.
      
      No new tests, just a method rename.
      
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::registerFrontendCallbacks):
      * Modules/indexeddb/IDBDatabase.h:
      (IDBDatabase):
      * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
      (WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
      * Modules/indexeddb/IDBDatabaseBackendImpl.h:
      (IDBDatabaseBackendImpl):
      * Modules/indexeddb/IDBDatabaseBackendInterface.h:
      (IDBDatabaseBackendInterface):
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::onSuccess):
      
      Source/WebKit/chromium:
      
      Reviewed by Tony Chang.
      
      * src/IDBDatabaseBackendProxy.cpp:
      (WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
      * src/IDBDatabaseBackendProxy.h:
      (IDBDatabaseBackendProxy):
      * src/WebIDBDatabaseImpl.cpp:
      (WebKit::WebIDBDatabaseImpl::open):
      * src/WebIDBDatabaseImpl.h:
      (WebIDBDatabaseImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bad6c335
    • danakj@chromium.org's avatar
      [chromium] Skip willDraw() and didDraw() on fully occluded layers · cc04e867
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88435
      
      Reviewed by Adrienne Walker.
      
      Source/WebCore:
      
      Current willDraw() is called on all layers with non-empty
      visibleLayerRect and non-empty scissorRect. This excludes
      layers outside the viewport, but does not exclude occluded
      layers. We add a check for occlusion to calculateRenderPasses
      in order to avoid willDraw() when it will be culled anyway.
      
      We prevent didDraw() from being called for occluded layers, for
      which we did not call didDraw() by holding a vector of layers
      for which we did call willDraw(). This lets us avoid storing a
      flag on the layers, or computing occlusion again in
      didDrawAllLayers.
      
      Unit test: CCLayerTreeHostImplTest.willDrawNotCalledOnOccludedLayer
      
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
      (WebCore::CCLayerTreeHostImpl::prepareToDraw):
      (WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      (FrameData):
      (CCLayerTreeHostImpl):
      
      Source/WebKit/chromium:
      
      * tests/CCLayerTreeHostImplTest.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc04e867
    • ojan@chromium.org's avatar
      Second wave of Chromium rebaselines after skia change. See crbug.com/131829. · 79d909f5
      ojan@chromium.org authored
      List of changed expectations deleted because it's too long.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79d909f5
    • barraclough@apple.com's avatar
      Unreviewed roll out r119795. · 9dd771c0
      barraclough@apple.com authored
              
      This broke jquery/core.html
      
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitAllocateBasicJSObject):
      * llint/LowLevelInterpreter.asm:
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      * runtime/JSGlobalThis.cpp:
      (JSC::JSGlobalThis::setUnwrappedObject):
      * runtime/JSObject.cpp:
      (JSC::JSObject::visitChildren):
      (JSC::JSObject::createInheritorID):
      * runtime/JSObject.h:
      (JSObject):
      (JSC::JSObject::resetInheritorID):
      (JSC):
      (JSC::JSObject::offsetOfInheritorID):
      (JSC::JSObject::inheritorID):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dd771c0
    • mitz@apple.com's avatar
      Added Mac pixel results for canvas-imageSmoothingEnabled-patterns.html, and made the text · 37ce5aa5
      mitz@apple.com authored
      results shared between platforms.
      
      * fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
      * platform/chromium/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
      * platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
      * platform/mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37ce5aa5
    • tony@chromium.org's avatar
      [chromium] Unreviewed, rebaseline a chromium-win result that changed · 3e655626
      tony@chromium.org authored
      due to the various mock scrollbar changes.
      https://bugs.webkit.org/show_bug.cgi?id=88490
      
      * platform/chromium-win/fast/repaint/fixed-tranformed-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e655626
    • tonikitoo@webkit.org's avatar
      EventHandler shouldn't schedule the fake mousemove event timer when scrolling... · 352c8e3a
      tonikitoo@webkit.org authored
      EventHandler shouldn't schedule the fake mousemove event timer when scrolling on devices that don't have a mouse
      https://bugs.webkit.org/show_bug.cgi?id=88379
      
      Reviewed by James Robinson.
      Patch by Antonio Gomes <agomes@rim.com>
      
      Paraphrasing Andy Estes:
      "In <http://trac.webkit.org/changeset/119465> we stopped dispatching fake
      mousemove events when scrolling on devices that don't support mice. This event
      is dispatched on a timer, so one better would be to not even schedule the
      timer (rather than scheduling the timer but making it a no-op).
      
      No new tests, as no functionality has changed. We basically do not
      start a timer under a given circumstance instead of fire it, it times out,
      and we make the callback no-op when under the given circumstance.
      
      It is still possible though that we have the following scenario:
      - Setting::deviceSupportsMouse set as true;
      - we fire the timer;
      - before its callback gets executed (timed out) the setting gets toggled.
      So for sakeness, lets keep the check in both places.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
      (WebCore::EventHandler::fakeMouseMoveEventTimerFired):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      352c8e3a
    • jamesr@google.com's avatar
      [chromium] Clean up some unnecessary LayerChromium.h includes · 4cbc5e49
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88599
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Reworks test code slightly to use WebCore interfaces.
      
      * testing/Internals.cpp:
      (WebCore::Internals::setBackgroundBlurOnNode):
      
      Source/WebKit/chromium:
      
      Removes unused include, update comment.
      
      * src/WebMediaPlayerClientImpl.cpp:
      (WebKit::WebMediaPlayerClientImpl::platformLayer):
      (WebKit::WebMediaPlayerClientImpl::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cbc5e49
    • schenney@chromium.org's avatar
      WebCore::ImageBuffer.cpp has broken color table code · 26e83004
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80321
      
      Unreviewed Chromium test expectations update after changes to SVG filter color conversion.
      
      Full list of changed files excluded to to very large number.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26e83004
    • fpizlo@apple.com's avatar
    • fpizlo@apple.com's avatar
      PredictedType should be called SpeculatedType · 0bcbc11d
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88477
      
      Unreviewed, fix a renaming goof from http://trac.webkit.org/changeset/119660.
      I accidentally renamed ByteCodeParser::getPrediction to
      ByteCodeParser::getSpeculation.  That was not the intent. This changes it
      back.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::addCall):
      (JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
      (JSC::DFG::ByteCodeParser::getPrediction):
      (JSC::DFG::ByteCodeParser::handleCall):
      (JSC::DFG::ByteCodeParser::parseBlock):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bcbc11d
    • wingo@igalia.com's avatar
      Explictly mark stubs called by JIT as being internal · 332e9bfa
      wingo@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88552
      
      Reviewed by Filip Pizlo.
      
      Source/JavaScriptCore:
      
      * dfg/DFGOSRExitCompiler.h:
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h:
      * jit/HostCallReturnValue.h:
      * jit/JITStubs.cpp:
      * jit/JITStubs.h:
      * jit/ThunkGenerators.cpp:
      * llint/LLIntSlowPaths.h: Mark a bunch of stubs as being
      WTF_INTERNAL.  Change most calls to SYMBOL_STRING_RELOCATION to
      LOCAL_REFERENCE, or GLOBAL_REFERENCE in the case of the wrappers
      to truly global symbols.
      * offlineasm/asm.rb: Generate LOCAL_REFERENCE instead of
      SYMBOL_STRING_RELOCATION.
      
      Don't rely on weak pointers for eager CodeBlock finalization
      https://bugs.webkit.org/show_bug.cgi?id=88465
      
      Reviewed by Gavin Barraclough.
      
      This is incompatible with lazy weak pointer finalization.
      
      I considered just making CodeBlock finalization lazy-friendly, but it
      turns out that the heap is already way up in CodeBlock's business when
      it comes to finalization, so I decided to finish the job and move full
      responsibility for CodeBlock finalization into the heap.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Maybe this
      will build.
      
      * debugger/Debugger.cpp: Updated for rename.
      
      * heap/Heap.cpp:
      (JSC::Heap::deleteAllCompiledCode): Renamed for consistency. Fixed a bug
      where we would not delete code for a code block that had been previously
      jettisoned. I don't know if this happens in practice -- I mostly did
      this to improve consistency with deleteUnmarkedCompiledCode.
      
      (JSC::Heap::deleteUnmarkedCompiledCode): New function, responsible for
      eager finalization of unmarked code blocks.
      
      (JSC::Heap::collect): Updated for rename. Updated to call
      deleteUnmarkedCompiledCode(), which takes care of jettisoned DFG code
      blocks too.
      
      (JSC::Heap::addCompiledCode): Renamed, since this points to all code
      now, not just functions.
      
      * heap/Heap.h:
      (Heap): Keep track of all user code, not just functions. This is a
      negligible additional overhead, since most code is function code.
      
      * runtime/Executable.cpp:
      (JSC::*::finalize): Removed these functions, since we don't rely on
      weak pointer finalization anymore.
      
      (JSC::FunctionExecutable::FunctionExecutable): Moved linked-list stuff
      into base class so all executables can be in the list.
      
      (JSC::EvalExecutable::clearCode):
      (JSC::ProgramExecutable::clearCode):
      (JSC::FunctionExecutable::clearCode): All we need to do is delete our
      CodeBlock -- that will delete all of its internal data structures.
      
      (JSC::FunctionExecutable::clearCodeIfNotCompiling): Factored out a helper
      function to improve clarity.
      
      * runtime/Executable.h:
      (JSC::ExecutableBase): Moved linked-list stuff
      into base class so all executables can be in the list.
      
      (JSC::NativeExecutable::create):
      (NativeExecutable):
      (ScriptExecutable):
      (JSC::ScriptExecutable::finishCreation):
      (JSC::EvalExecutable::create):
      (EvalExecutable):
      (JSC::ProgramExecutable::create):
      (ProgramExecutable):
      (FunctionExecutable):
      (JSC::FunctionExecutable::create): Don't use a finalizer -- the heap
      will call us back to destroy our code block.
      
      (JSC::FunctionExecutable::discardCode): Renamed to clearCodeIfNotCompiling()
      for clarity.
      
      (JSC::FunctionExecutable::isCompiling): New helper function, for clarity.
      
      (JSC::ScriptExecutable::clearCodeVirtual): New helper function, since
      the heap needs to make polymorphic calls to clear code.
      
      * runtime/JSGlobalData.cpp:
      (JSC::StackPreservingRecompiler::operator()):
      * runtime/JSGlobalObject.cpp:
      (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
      renames.
      
      Source/WTF:
      
      * wtf/ExportMacros.h (WTF_INTERNAL, HAVE_INTERNAL_VISIBILITY): New
      defines.  Regardless of what the port does about visibility in
      general, for code referenced only from assembly it is useful to
      give it internal visibility.
      * wtf/InlineASM.h: Split SYMBOL_STRING_RELOCATION into
      LOCAL_REFERENCE and GLOBAL_REFERENCE; the former will try to avoid
      indirection if HAVE(INTERNAL_VISIBILITY).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      332e9bfa
    • jsbell@chromium.org's avatar
      IndexedDB: Add regression test to verify that legacy constants have been removed · ae8de23b
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88669
      
      Reviewed by Tony Chang.
      
      * storage/indexeddb/legacy-constants-expected.txt:
      * storage/indexeddb/mozilla/create-index-unique-expected.txt:
      * storage/indexeddb/mozilla/resources/create-index-unique.js:
      (createAndVerifyIndex):
      * storage/indexeddb/resources/constants.js:
      (test):
      * storage/indexeddb/resources/legacy-constants.js:
      (testObsoleteConstants):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae8de23b
    • ojan@chromium.org's avatar
      First wave of Chromium rebaselines after skia rollback. See crbug.com/131829. · 8334550e
      ojan@chromium.org authored
      List of changed expected files excluded because it's too long.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8334550e
    • ojan@chromium.org's avatar
      First wave of Chromium rebaselines after skia rollback. See crbug.com/131289. · cf29e9bc
      ojan@chromium.org authored
      List of changed expected files excluded because it's too long.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf29e9bc
    • arv@chromium.org's avatar
      [V8] Keep TextTrackList alive as long as its owner is alive · 7018c857
      arv@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88541
      
      Reviewed by Adam Barth.
      
      Add a hidden reference from the owner to the text track list.
      
      Source/WebCore:
      
      Covered by existing tests.
      
      * Target.pri: Add V8TextTrackListCustom.cpp.
      * UseV8.cmake: Ditto.
      * WebCore.gypi: Ditto.
      * bindings/v8/V8HiddenPropertyName.h:
      (WebCore):
      * bindings/v8/custom/V8TextTrackListCustom.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
      (WebCore):
      (WebCore::toV8): When the wrapper is created add a reference to the owner of the TextTrackList to the TextTrackList.
      * html/track/TextTrackList.idl:
      
      LayoutTests:
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7018c857
    • jochen@chromium.org's avatar
      Unreviewed. Rolled DEPS. · 29b5c823
      jochen@chromium.org authored
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29b5c823
    • commit-queue@webkit.org's avatar
      Add app_abi option for DumpRenderTree_apk · 00b8d1ef
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88626
      
      Patch by Wei James <james.wei@intel.com> on 2012-06-08
      Reviewed by Adam Barth.
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00b8d1ef
    • commit-queue@webkit.org's avatar
      [chromium] Accelerated animations should use WebTransformOperations · 51d35d62
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87686
      
      Patch by Ian Vollick <vollick@chromium.org> on 2012-06-08
      Reviewed by James Robinson.
      
      CCTransformKeyframe new owns a WebTransformOperations rather than a
      TransformOperations. LayerChromium's API has been changed so that
      LayerChromium::addAnimation should take only a CCActiveAnimation.
      GraphicsLayerChromium is new responsible for translating to
      WebTransformOperations and creating CCActiveAnimations. Tests that use
      the public API (that is, they call addAnimation with KeyframeValueList
      and Animation arguments) have been moved to GraphicsLayerChromiumTest.
      
      Source/WebCore:
      
       Unit tests:
          GraphicsLayerChromiumTest.createOpacityAnimation
          GraphicsLayerChromiumTest.createTransformAnimation
          GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
          GraphicsLayerChromiumTest.createTransformAnimationWithSingularMatrix
          GraphicsLayerChromiumTest.createReversedAnimation
          GraphicsLayerChromiumTest.createAlternatingAnimation
          GraphicsLayerChromiumTest.createReversedAlternatingAnimation
      
      * WebCore.gypi:
      * platform/graphics/chromium/AnimationTranslationUtil.cpp: Added.
      (WebCore):
      (WebCore::toWebTransformOperations):
      (WebCore::appendKeyframe):
      (WebCore::CCKeyframedTransformAnimationCurve):
      (WebCore::createActiveAnimation):
      * platform/graphics/chromium/AnimationTranslationUtil.h: Added.
      (WebCore):
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      (WebCore::GraphicsLayerChromium::addAnimation):
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::addAnimation):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore):
      (WebCore::LayerChromium::bounds):
      (LayerChromium):
      * platform/graphics/chromium/LinkHighlight.cpp:
      (WebCore::LinkHighlight::LinkHighlight):
      * platform/graphics/chromium/cc/CCAnimationCurve.h:
      (CCTransformAnimationCurve):
      * platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
      (WebCore::CCTransformKeyframe::create):
      (WebCore::CCTransformKeyframe::CCTransformKeyframe):
      (WebCore::CCTransformKeyframe::value):
      (WebCore::CCTransformKeyframe::clone):
      (WebCore::CCKeyframedTransformAnimationCurve::getValue):
      * platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
      (CCTransformKeyframe):
      (CCKeyframedTransformAnimationCurve):
      * platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
      (WebCore::CCLayerAnimationController::removeAnimation):
      (WebCore):
      (WebCore::CCLayerAnimationController::addAnimation):
      (WebCore::CCLayerAnimationController::getActiveAnimation):
      (WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
      (WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
      (WebCore::CCLayerAnimationController::tickAnimations):
      * platform/graphics/chromium/cc/CCLayerAnimationController.h:
      (CCLayerAnimationControllerClient):
      (CCLayerAnimationController):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore::CCLayerImpl::bounds):
      
      Source/WebKit/chromium:
      
      * tests/CCAnimationTestCommon.cpp:
      (WebCore::addOpacityTransition):
      (WebCore::addAnimatedTransform):
      (WebKitTests::FakeTransformTransition::getValue):
      * tests/CCAnimationTestCommon.h:
      * tests/CCKeyframedAnimationCurveTest.cpp:
      * tests/CCLayerAnimationControllerTest.cpp:
      * tests/CCLayerTreeHostTest.cpp:
      (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
      * tests/GraphicsLayerChromiumTest.cpp:
      (MockLayerTreeHostClient):
      (WebKitTests):
      (MockLayerTreeHost):
      (WebKitTests::MockLayerTreeHost::create):
      (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
      (WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
      (GraphicsLayerChromiumTest):
      (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
      (WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
      (WebKitTests::GraphicsLayerChromiumTest::expectTranslateX):
      (WebKitTests::TEST_F):
      * tests/LayerChromiumTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51d35d62
    • noam.rosenthal@nokia.com's avatar
      [Texmap] Accelerated versions of drop-shadow and blur filters · cb722ff4
      noam.rosenthal@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87695
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Added shaders for blur and drop-shadow effects.
      The shaders use sampling of multiple coordinates and averaging them with normal-
      distribution to create a fast gaussian blur effect.
      
      Covered by existing tests in css3/filters.
      
      * platform/graphics/texmap/TextureMapperGL.cpp:
      (WebCore::TextureMapperGL::drawFiltered):
          Call the prepare function explicitly, with a size argument that's used to calculate
          some of the uniform values.
      
      * platform/graphics/texmap/TextureMapperLayer.cpp:
      (WebCore::TextureMapperLayer::intermediateSurfaceRect):
          The outsets of the effect have to be considered when calculating the intermediate rect.
          Otherwise the resulting image is scaled instead of outsetted.
      
      (WebCore::applyFilters):
      * platform/graphics/texmap/TextureMapperShaderManager.cpp:
      (WebCore::StandardFilterProgram::StandardFilterProgram):
          Added the new shaders.
      
      (WebCore::StandardFilterProgram::prepare):
      (WebCore::TextureMapperShaderManager::getShaderForFilter):
      * platform/graphics/texmap/TextureMapperShaderManager.h:
      (StandardFilterProgram):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb722ff4
    • mitz@apple.com's avatar
      Tried to fix the build after r119844. · 7dd4e7c2
      mitz@apple.com authored
      * bindings/js/GCController.cpp:
      (WebCore::GCController::discardAllCompiledCode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dd4e7c2
    • ostapenko.viatcheslav@nokia.com's avatar
      [Qt] [WK2] API tests randomly assert in WebLayerTreeRenderer::assignImageToLayer · 4a6b3cec
      ostapenko.viatcheslav@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88667
      
      Reviewed by Noam Rosenthal.
      
      Move deactivation of WebLayerTreeRenderer from LayerTreeHostProxy::purgeBackingStores
      to WebLayerTreeRenderer::purgeGLResources. LayerTreeHostProxy::purgeBackingStores is
      invoked on main thread after going through call gate and it is too late to deactivate
      renderer here, because some update messages are able to go through.
      WebLayerTreeRenderer::purgeGLResources is called directly from render node deallocation
      and it is right place to deactivate renderer.
      
      * UIProcess/LayerTreeHostProxy.cpp:
      (WebKit::LayerTreeHostProxy::purgeBackingStores):
      * UIProcess/WebLayerTreeRenderer.cpp:
      (WebKit::WebLayerTreeRenderer::purgeGLResources):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a6b3cec
    • commit-queue@webkit.org's avatar
      Add COMPILE_ASSERT to StyledElement to ensure it doesn't accidentally grow larger. · 7ba10cc3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88627
      
      Patch by Mike West <mkwst@chromium.org> on 2012-06-08
      Reviewed by Adam Barth.
      
      No change in user-facing behavior.
      
      * dom/StyledElement.cpp:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ba10cc3
    • tony@chromium.org's avatar
      [chromium] Unreviewed, rebaseline... · e89a7691
      tony@chromium.org authored
      [chromium] Unreviewed, rebaseline platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html after skia gamma correction
      https://bugs.webkit.org/show_bug.cgi?id=88589
      
      
      * platform/chromium-linux/platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Added.
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e89a7691
    • ggaren@apple.com's avatar
      Don't rely on weak pointers for eager CodeBlock finalization · d7147575
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88465
      
      Reviewed by Gavin Barraclough.
      
      This is incompatible with lazy weak pointer finalization.
      
      I considered just making CodeBlock finalization lazy-friendly, but it
      turns out that the heap is already way up in CodeBlock's business when
      it comes to finalization, so I decided to finish the job and move full
      responsibility for CodeBlock finalization into the heap.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Maybe this
      will build.
      
      * debugger/Debugger.cpp: Updated for rename.
      
      * heap/Heap.cpp:
      (JSC::Heap::deleteAllCompiledCode): Renamed for consistency. Fixed a bug
      where we would not delete code for a code block that had been previously
      jettisoned. I don't know if this happens in practice -- I mostly did
      this to improve consistency with deleteUnmarkedCompiledCode.
      
      (JSC::Heap::deleteUnmarkedCompiledCode): New function, responsible for
      eager finalization of unmarked code blocks.
      
      (JSC::Heap::collect): Updated for rename. Updated to call
      deleteUnmarkedCompiledCode(), which takes care of jettisoned DFG code
      blocks too.
      
      (JSC::Heap::addCompiledCode): Renamed, since this points to all code
      now, not just functions.
      
      * heap/Heap.h:
      (Heap): Keep track of all user code, not just functions. This is a
      negligible additional overhead, since most code is function code.
      
      * runtime/Executable.cpp:
      (JSC::*::finalize): Removed these functions, since we don't rely on
      weak pointer finalization anymore.
      
      (JSC::FunctionExecutable::FunctionExecutable): Moved linked-list stuff
      into base class so all executables can be in the list.
      
      (JSC::EvalExecutable::clearCode):
      (JSC::ProgramExecutable::clearCode):
      (JSC::FunctionExecutable::clearCode): All we need to do is delete our
      CodeBlock -- that will delete all of its internal data structures.
      
      (JSC::FunctionExecutable::clearCodeIfNotCompiling): Factored out a helper
      function to improve clarity.
      
      * runtime/Executable.h:
      (JSC::ExecutableBase): Moved linked-list stuff
      into base class so all executables can be in the list.
      
      (JSC::NativeExecutable::create):
      (NativeExecutable):
      (ScriptExecutable):
      (JSC::ScriptExecutable::finishCreation):
      (JSC::EvalExecutable::create):
      (EvalExecutable):
      (JSC::ProgramExecutable::create):
      (ProgramExecutable):
      (FunctionExecutable):
      (JSC::FunctionExecutable::create): Don't use a finalizer -- the heap
      will call us back to destroy our code block.
      
      (JSC::FunctionExecutable::discardCode): Renamed to clearCodeIfNotCompiling()
      for clarity.
      
      (JSC::FunctionExecutable::isCompiling): New helper function, for clarity.
      
      (JSC::ScriptExecutable::clearCodeVirtual): New helper function, since
      the heap needs to make polymorphic calls to clear code.
      
      * runtime/JSGlobalData.cpp:
      (JSC::StackPreservingRecompiler::operator()):
      * runtime/JSGlobalObject.cpp:
      (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
      renames.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7147575
    • rjkroege@chromium.org's avatar
      More than 8 fingers get ignored by touch · 966d0ddd
      rjkroege@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88359
      
      Reviewed by James Robinson.
      
      * public/WebInputEvent.h: Increase of TouchPoints per TouchEvent from 8 to 12.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      966d0ddd
    • mitz@apple.com's avatar
      Added svg/filters/color-space-conversion.svg to the Mac skip list. It has been failing since · d4a9fcb2
      mitz@apple.com authored
      its addition in r119841. <http://webkit.org/b/88672> is tracking the failure.
      
      * platform/mac/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4a9fcb2
    • schenney@chromium.org's avatar
      WebCore::ImageBuffer.cpp has broken color table code · 8350e1e5
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80321
      
      Unreviewed Chromium expectations update.
      
      Adding tests that are failing pending a rebaseline.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8350e1e5
    • tony@chromium.org's avatar
      [chromium] Unreviewed, remove css3/flexbox/child-overflow.html from TestExpectations. · 370faa2a
      tony@chromium.org authored
      Since bug 77368 is now fixed, this test passes.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      370faa2a