1. 18 Apr, 2013 1 commit
    • andersca@apple.com's avatar
      Change storage factory functions to take a PageGroup and Page respectively · e44d33f5
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114776
      
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      Change StorageNamespace::localStorageNamespace to take a PageGroup since WebKit2 needs
      to know which local storage namespace belongs to which page group. Also remove the quota parameter from
      the sessionStorageNamespace function since that's trivial to get from the Page.
      
      * WebCore.exp.in:
      * page/Page.cpp:
      (WebCore::Page::sessionStorage):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::localStorage):
      * storage/StorageNamespace.cpp:
      (WebCore::StorageNamespace::localStorageNamespace):
      (WebCore::StorageNamespace::sessionStorageNamespace):
      * storage/StorageNamespace.h:
      * storage/StorageNamespaceImpl.cpp:
      (WebCore::StorageNamespaceImpl::localStorageNamespace):
      (WebCore::StorageNamespaceImpl::sessionStorageNamespace):
      * storage/StorageNamespaceImpl.h:
      * storage/StorageStrategy.cpp:
      (WebCore::StorageStrategy::localStorageNamespace):
      (WebCore::StorageStrategy::sessionStorageNamespace):
      * storage/StorageStrategy.h:
      
      Source/WebKit2:
      
      Update for WebCore changes.
      
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::localStorageNamespace):
      (WebKit::WebPlatformStrategies::sessionStorageNamespace):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      (WebPlatformStrategies):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e44d33f5
  2. 05 Apr, 2013 1 commit
  3. 18 Mar, 2013 1 commit
  4. 22 Jan, 2013 1 commit
    • andersca@apple.com's avatar
      Source/WebCore: Use a platform strategy for local storage · 89cf38d9
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107600
      
      Reviewed by Andreas Kling.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      Add new files.
      
      * platform/PlatformStrategies.h:
      Add a way to create/get the storage strategy.
      
      * storage/StorageNamespace.cpp:
      (WebCore::StorageNamespace::localStorageNamespace):
      (WebCore::StorageNamespace::sessionStorageNamespace):
      Call the storage strategy.
      
      * storage/StorageNamespace.h:
      * storage/StorageStrategy.cpp: Added.
      (WebCore::StorageStrategy::localStorageNamespace):
      (WebCore::StorageStrategy::sessionStorageNamespace):
      Call through to StorageNamespaceImpl.
      
      * storage/StorageStrategy.h: Added.
      
      Source/WebKit/efl: Use a platforom strategy for local storage
      https://bugs.webkit.org/show_bug.cgi?id=107600
      
      Reviewed by Andreas Kling.
      
      Update for new storage strategy.
      
      * WebCoreSupport/PlatformStrategiesEfl.cpp:
      (PlatformStrategiesEfl::createStorageStrategy):
      * WebCoreSupport/PlatformStrategiesEfl.h:
      (PlatformStrategiesEfl):
      
      Source/WebKit/gtk: Use a platforom strategy for local storage
      https://bugs.webkit.org/show_bug.cgi?id=107600
      
      Reviewed by Andreas Kling.
      
      Update for new storage strategy.
      
      * WebCoreSupport/PlatformStrategiesGtk.cpp:
      (PlatformStrategiesGtk::createStorageStrategy):
      * WebCoreSupport/PlatformStrategiesGtk.h:
      (PlatformStrategiesGtk):
      
      Source/WebKit/mac: Use a platforom strategy for local storage
      https://bugs.webkit.org/show_bug.cgi?id=107600
      
      Reviewed by Andreas Kling.
      
      Update for new storage strategy.
      
      * WebCoreSupport/WebPlatformStrategies.h:
      (WebPlatformStrategies):
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::createStorageStrategy):
      
      Source/WebKit/qt: Use a platforom strategy for local storage
      https://bugs.webkit.org/show_bug.cgi?id=107600
      
      Reviewed by Andreas Kling.
      
      Update for new storage strategy.
      
      * WebCoreSupport/PlatformStrategiesQt.cpp:
      (PlatformStrategiesQt::createStorageStrategy):
      * WebCoreSupport/PlatformStrategiesQt.h:
      (PlatformStrategiesQt):
      
      Source/WebKit/win: Use a platforom strategy for local storage
      https://bugs.webkit.org/show_bug.cgi?id=107600
      
      Reviewed by Andreas Kling.
      
      Update for new storage strategy.
      
      * WebCoreSupport/WebPlatformStrategies.cpp:
      (WebPlatformStrategies::createStorageStrategy):
      * WebCoreSupport/WebPlatformStrategies.h:
      (WebPlatformStrategies):
      
      Source/WebKit/wince: Use a platforom strategy for local storage
      https://bugs.webkit.org/show_bug.cgi?id=107600
      
      Reviewed by Andreas Kling.
      
      Update for new storage strategy.
      
      * WebCoreSupport/PlatformStrategiesWinCE.cpp:
      (PlatformStrategiesWinCE::createStorageStrategy):
      * WebCoreSupport/PlatformStrategiesWinCE.h:
      (PlatformStrategiesWinCE):
      
      Source/WebKit2: Use a platforom strategy for local storage
      https://bugs.webkit.org/show_bug.cgi?id=107600
      
      Reviewed by Andreas Kling.
      
      Update for new storage strategy.
      
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::createStorageStrategy):
      (WebKit):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      (WebPlatformStrategies):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89cf38d9
  5. 16 Oct, 2011 1 commit
    • abarth@webkit.org's avatar
      Always enable ENABLE(DOM_STORAGE) · 2eb9f99c
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=70189
      
      Reviewed by Eric Seidel.
      
      .:
      
      * Source/cmake/OptionsEfl.cmake:
      * Source/cmake/OptionsWinCE.cmake:
      * Source/cmakeconfig.h.cmake:
      * configure.ac:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      As discussed on webkit-dev, we are reducing the complexity of WebKit by
      removing unnecessary configuration options.  DOMStorage is not a core
      part of the web platform.  It should always be enabled.
      
      * CMakeLists.txt:
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * UseJSC.cmake:
      * WebCore.exp.in:
      * WebCore.pro:
      * bindings/js/JSEventCustom.cpp:
      * bindings/js/JSInjectedScriptHostCustom.cpp:
      * bindings/js/JSStorageCustom.cpp:
      * bindings/v8/custom/V8EventCustom.cpp:
      (WebCore::toV8):
      * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
      (WebCore::V8InjectedScriptHost::storageIdCallback):
      * bindings/v8/custom/V8StorageCustom.cpp:
      * dom/Document.cpp:
      (WebCore::Document::createEvent):
      * dom/Event.cpp:
      (WebCore::Event::isStorageEvent):
      * dom/Event.h:
      * dom/Node.cpp:
      * features.pri:
      * inspector/InjectedScriptHost.cpp:
      (WebCore::InjectedScriptHost::InjectedScriptHost):
      (WebCore::InjectedScriptHost::disconnect):
      (WebCore::InjectedScriptHost::storageIdImpl):
      * inspector/InjectedScriptHost.h:
      (WebCore::InjectedScriptHost::init):
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      (WebCore::InspectorController::connectFrontend):
      (WebCore::InspectorController::disconnectFrontend):
      (WebCore::InspectorController::restoreInspectorStateFromCookie):
      * inspector/InspectorController.h:
      * inspector/InspectorDOMStorageAgent.cpp:
      * inspector/InspectorDOMStorageResource.cpp:
      * inspector/InspectorDOMStorageResource.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::didUseDOMStorage):
      * inspector/InstrumentingAgents.h:
      (WebCore::InstrumentingAgents::InstrumentingAgents):
      * inspector/WorkerInspectorController.cpp:
      (WebCore::WorkerInspectorController::WorkerInspectorController):
      (WebCore::WorkerInspectorController::connectFrontend):
      * inspector/generate-inspector-idl:
      * page/Chrome.cpp:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::~DOMWindow):
      (WebCore::DOMWindow::clear):
      (WebCore::DOMWindow::localStorage):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      * page/Navigator.cpp:
      (WebCore::Navigator::getStorageUpdates):
      * page/Navigator.h:
      * page/Navigator.idl:
      * page/Page.cpp:
      * page/Page.h:
      * page/PageGroup.cpp:
      (WebCore::PageGroup::closeLocalStorage):
      * page/PageGroup.h:
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::setSessionStorageQuota):
      * page/Settings.h:
      (WebCore::Settings::sessionStorageQuota):
      * storage/LocalStorageTask.cpp:
      * storage/LocalStorageTask.h:
      * storage/LocalStorageThread.cpp:
      * storage/LocalStorageThread.h:
      * storage/Storage.cpp:
      * storage/Storage.h:
      * storage/Storage.idl:
      * storage/StorageArea.h:
      * storage/StorageAreaImpl.cpp:
      * storage/StorageAreaImpl.h:
      * storage/StorageAreaSync.cpp:
      (WebCore::StorageAreaSync::scheduleSync):
      * storage/StorageAreaSync.h:
      * storage/StorageEvent.cpp:
      * storage/StorageEvent.h:
      * storage/StorageEvent.idl:
      * storage/StorageEventDispatcher.cpp:
      * storage/StorageEventDispatcher.h:
      * storage/StorageMap.cpp:
      * storage/StorageMap.h:
      * storage/StorageNamespace.cpp:
      * storage/StorageNamespace.h:
      * storage/StorageNamespaceImpl.cpp:
      * storage/StorageNamespaceImpl.h:
      * storage/StorageSyncManager.cpp:
      (WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):
      * storage/StorageSyncManager.h:
      * storage/StorageTracker.cpp:
      * storage/StorageTracker.h:
      
      Source/WebKit/chromium:
      
      * features.gypi:
      * src/StorageAreaProxy.cpp:
      * src/StorageAreaProxy.h:
      * src/StorageEventDispatcherChromium.cpp:
      * src/StorageEventDispatcherImpl.cpp:
      * src/StorageEventDispatcherImpl.h:
      * src/StorageNamespaceProxy.cpp:
      * src/StorageNamespaceProxy.h:
      * src/WebRuntimeFeatures.cpp:
      (WebKit::WebRuntimeFeatures::enableLocalStorage):
      (WebKit::WebRuntimeFeatures::isLocalStorageEnabled):
      (WebKit::WebRuntimeFeatures::enableSessionStorage):
      (WebKit::WebRuntimeFeatures::isSessionStorageEnabled):
      * src/WebStorageAreaImpl.cpp:
      * src/WebStorageAreaImpl.h:
      * src/WebStorageEventDispatcherImpl.cpp:
      * src/WebStorageEventDispatcherImpl.h:
      * src/WebStorageNamespaceImpl.cpp:
      * src/WebStorageNamespaceImpl.h:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      * Storage/WebStorageManager.mm:
      * Storage/WebStorageManagerInternal.h:
      * Storage/WebStorageTrackerClient.h:
      * Storage/WebStorageTrackerClient.mm:
      (WebStorageTrackerClient::dispatchDidModifyOrigin):
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:]):
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      
      Tools:
      
      * Scripts/build-webkit:
      * waf/build/settings.py:
      
      WebKitLibraries:
      
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      LayoutTests:
      
      * fast/events/event-creation.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2eb9f99c
  6. 08 Jan, 2011 1 commit
  7. 19 Apr, 2010 1 commit
    • adachan@apple.com's avatar
      WebCore: https://bugs.webkit.org/show_bug.cgi?id=37717 · 19fb571c
      adachan@apple.com authored
      Allow clients concerned with memory consumption to set a quota on session storage
      since the memory used won't be released until the Page is destroyed.
      The default is noQuota, which matches the current behavior.
      
      Reviewed by Jeremy Orlow.
      
      * WebCore.base.exp: Export Settings::setSessionStorageQuota().
      * page/Page.cpp:
      (WebCore::Page::sessionStorage):
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::setSessionStorageQuota):
      * page/Settings.h:
      (WebCore::Settings::sessionStorageQuota):
      * storage/StorageNamespace.cpp:
      (WebCore::StorageNamespace::sessionStorageNamespace):
      * storage/StorageNamespace.h:
      * storage/StorageNamespaceImpl.cpp:
      (WebCore::StorageNamespaceImpl::sessionStorageNamespace):
      * storage/StorageNamespaceImpl.h:
      
      WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=37717
      Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
      StorageNamespace::sessionStorageNamespace() take in a quota parameter.
      
      Reviewed by Jeremy Orlow.
      
      * src/StorageNamespaceProxy.cpp:
      (WebCore::StorageNamespace::sessionStorageNamespace):
      * src/WebStorageNamespaceImpl.cpp:
      (WebKit::WebStorageNamespace::createSessionStorageNamespace):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19fb571c
  8. 13 Jan, 2010 2 commits
    • jorlow@chromium.org's avatar
      2010-01-13 Jeremy Orlow <jorlow@chromium.org> · e518e01d
      jorlow@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
              https://bugs.webkit.org/show_bug.cgi?id=33492
      
              * public/WebKitClient.h:
              * public/WebViewClient.h:
              (WebKit::WebViewClient::createSessionStorageNamespace):
              * src/StorageNamespaceProxy.cpp:
              (WebCore::StorageNamespace::sessionStorageNamespace):
      2010-01-13  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
              https://bugs.webkit.org/show_bug.cgi?id=33492
      
              * page/Page.cpp:
              (WebCore::Page::sessionStorage):
              * storage/StorageNamespace.cpp:
              (WebCore::StorageNamespace::sessionStorageNamespace):
              * storage/StorageNamespace.h:
              (WebCore::StorageNamespace::~StorageNamespace):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e518e01d
    • jorlow@chromium.org's avatar
      WebCore: No reviewer. More or less a build fix. My 53180 broke some · e38df662
      jorlow@chromium.org authored
      stuff on the Chromium port so I'm reverting.
      
      Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-13
      * page/Page.cpp:
      (WebCore::Page::sessionStorage):
      * storage/StorageNamespace.cpp:
      (WebCore::StorageNamespace::sessionStorageNamespace):
      * storage/StorageNamespace.h:
      (WebCore::StorageNamespace::~StorageNamespace):
      
      WebKit/chromium: No reviewer.  More or less a build fix.  My 53180 broke some 
      stuff on the Chromium port so I'm reverting.
      
      Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-13
      * public/WebKitClient.h:
      * public/WebViewClient.h:
      * src/StorageNamespaceProxy.cpp:
      (WebCore::StorageNamespace::sessionStorageNamespace):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e38df662
  9. 12 Jan, 2010 1 commit
  10. 02 Oct, 2009 1 commit
    • jorlow@chromium.org's avatar
      2009-10-02 Jeremy Orlow <jorlow@chromium.org> · f9c57a32
      jorlow@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Implement per-storage-area quotas for LocalStorage
              https://bugs.webkit.org/show_bug.cgi?id=29991
      
              I put 90% of the code in StorageMap since the decision to allow an update is
              closely tied to quota tracking.  The quota is set via a page's Settings class.
              Like with the local storage path and whether it's enabled, it's assumed that
              all pages in the same group will have the same settings.  The setting defaults
              to 5mb which is what the spec suggests, but it can easily be changed to
              anything else--including StorageMap::noQuota.  Any values in LocalStorage are
              grandfathered in regarudless of quota, so importItem only tracks (and will
              never block) imports.
      
              I believe this change is a good transition to more complex quota management.
              For example, if we wanted to track quotas in the SQLite DB, then we'd just add
              a function to the StorageMap that sets the quota.  This would be fine since all
              use of LocalStorage is blocked on the import completing, so you'd never hit a
              quota error in the mean time.  Also, if embedders wanted to ask the user
              whether to expand the quota whenever it's hit (before deciding whether or not
              to raise an exception), a callback via the chrome client should be fairly easy.
              That said, I think it's best to add these features in steps rather than one
              huge patch.  (Both of these are on my TODO list, btw.)
      
              Included is a layout test that verifies the behavior.  It assumes the default
              quota is 5mb (since that's what Settings defaults to).
      
              Test: storage/domstorage/localstorage/quota.html
      
              * page/PageGroup.cpp:
              (WebCore::PageGroup::localStorage):
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setLocalStorageQuota):
              * page/Settings.h:
              (WebCore::Settings::localStorageQuota):
              * storage/StorageAreaImpl.cpp:
              (WebCore::StorageAreaImpl::create):
              (WebCore::StorageAreaImpl::StorageAreaImpl):
              (WebCore::StorageAreaImpl::setItem):
              (WebCore::StorageAreaImpl::clear):
              * storage/StorageAreaImpl.h:
              * storage/StorageMap.cpp:
              (WebCore::StorageMap::create):
              (WebCore::StorageMap::StorageMap):
              (WebCore::StorageMap::copy):
              (WebCore::StorageMap::setItem):
              (WebCore::StorageMap::removeItem):
              (WebCore::StorageMap::importItem):
              * storage/StorageMap.h:
              (WebCore::StorageMap::quota):
              * storage/StorageNamespace.cpp:
              (WebCore::StorageNamespace::localStorageNamespace):
              * storage/StorageNamespace.h:
              * storage/StorageNamespaceImpl.cpp:
              (WebCore::StorageNamespaceImpl::localStorageNamespace):
              (WebCore::StorageNamespaceImpl::sessionStorageNamespace):
              (WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
              (WebCore::StorageNamespaceImpl::copy):
              (WebCore::StorageNamespaceImpl::storageArea):
              * storage/StorageNamespaceImpl.h:
      2009-10-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Implement per-storage-area quotas for LocalStorage
              https://bugs.webkit.org/show_bug.cgi?id=29991
      
              I put 90% of the code in StorageMap since the decision to allow an update is
              closely tied to quota tracking.  The quota is set via a page's Settings class. 
              Like with the local storage path and whether it's enabled, it's assumed that
              all pages in the same group will have the same settings.  The setting defaults
              to 5mb which is what the spec suggests, but it can easily be changed to
              anything else--including StorageMap::noQuota.  Any values in LocalStorage are
              grandfathered in regarudless of quota, so importItem only tracks (and will
              never block) imports.
      
              I believe this change is a good transition to more complex quota management. 
              For example, if we wanted to track quotas in the SQLite DB, then we'd just add
              a function to the StorageMap that sets the quota.  This would be fine since all
              use of LocalStorage is blocked on the import completing, so you'd never hit a
              quota error in the mean time.  Also, if embedders wanted to ask the user
              whether to expand the quota whenever it's hit (before deciding whether or not
              to raise an exception), a callback via the chrome client should be fairly easy.
              That said, I think it's best to add these features in steps rather than one
              huge patch.  (Both of these are on my TODO list, btw.)
      
              Included is a layout test that verifies the behavior.  It assumes the default
              quota is 5mb (since that's what Settings defaults to).
      
              * storage/domstorage/localstorage/quota-expected.txt: Added.
              * storage/domstorage/localstorage/quota.html: Added.
              * storage/domstorage/script-tests/quota.js: Added.
              (runTest):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9c57a32
  11. 08 Jul, 2009 3 commits
    • darin@chromium.org's avatar
      2009-07-08 Jeremy Orlow <jorlow@chromium.org> · aa0cdca8
      darin@chromium.org authored
              Reviewed by Darin Fisher.
      
              Split StorageArea and StorageNamespace into an interface and implementation.
              https://bugs.webkit.org/show_bug.cgi?id=27072
      
              I need to split StorageNamespace and StorageArea into an interface and
              implementation.  In a later patch, I'll implement a proxy interface
              that'll run inside the Chromium renderer process.
      
              Additionally, fix the alphabetical ordering of files I recently added
              in the project files.
      
              This is a continuation of other refactoring work:
              https://bugs.webkit.org/show_bug.cgi?id=25376
      
              * GNUmakefile.am:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * storage/StorageArea.cpp:
              (WebCore::StorageArea::create):
              * storage/StorageArea.h:
              (WebCore::StorageArea::~StorageArea):
              * storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp.
              (WebCore::StorageAreaImpl::create):
              (WebCore::StorageAreaImpl::~StorageAreaImpl):
              (WebCore::StorageAreaImpl::StorageAreaImpl):
              (WebCore::StorageAreaImpl::copy):
              (WebCore::StorageAreaImpl::length):
              (WebCore::StorageAreaImpl::key):
              (WebCore::StorageAreaImpl::getItem):
              (WebCore::StorageAreaImpl::setItem):
              (WebCore::StorageAreaImpl::removeItem):
              (WebCore::StorageAreaImpl::clear):
              (WebCore::StorageAreaImpl::contains):
              (WebCore::StorageAreaImpl::importItem):
              (WebCore::StorageAreaImpl::securityOrigin):
              (WebCore::StorageAreaImpl::close):
              (WebCore::StorageAreaImpl::blockUntilImportComplete):
              (WebCore::StorageAreaImpl::dispatchStorageEvent):
              * storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
              * storage/StorageAreaSync.h:
              * storage/StorageNamespace.cpp:
              (WebCore::StorageNamespace::localStorageNamespace):
              (WebCore::StorageNamespace::sessionStorageNamespace):
              * storage/StorageNamespace.h:
              (WebCore::StorageNamespace::~StorageNamespace):
              * storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp.
              (WebCore::StorageNamespaceImpl::localStorageNamespace):
              (WebCore::StorageNamespaceImpl::sessionStorageNamespace):
              (WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
              (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl):
              (WebCore::StorageNamespaceImpl::copy):
              (WebCore::StorageNamespaceImpl::storageArea):
              (WebCore::StorageNamespaceImpl::close):
              * storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa0cdca8
    • darin@chromium.org's avatar
      Reverting r45643 due to build bustage. · eed366ee
      darin@chromium.org authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eed366ee
    • darin@chromium.org's avatar
      2009-07-08 Jeremy Orlow <jorlow@chromium.org> · 0c62dd00
      darin@chromium.org authored
              Reviewed by Darin Fisher.
      
              Split StorageArea and StorageNamespace into an interface and implementation.
              https://bugs.webkit.org/show_bug.cgi?id=27072
      
              I need to split StorageNamespace and StorageArea into an interface and
              implementation.  In a later patch, I'll implement a proxy interface
              that'll run inside the Chromium renderer process.
      
              Additionally, fix the alphabetical ordering of files I recently added
              in the project files.
      
              This is a continuation of other refactoring work:
              https://bugs.webkit.org/show_bug.cgi?id=25376
      
              * WebCore.xcodeproj/project.pbxproj:
              * storage/StorageArea.cpp:
              (WebCore::StorageArea::create):
              (WebCore::StorageArea::~StorageArea):
              * storage/StorageArea.h:
              * storage/StorageAreaImpl.cpp: Copied from WebCore/storage/StorageArea.cpp.
              (WebCore::StorageAreaImpl::create):
              (WebCore::StorageAreaImpl::~StorageAreaImpl):
              (WebCore::StorageAreaImpl::StorageAreaImpl):
              (WebCore::StorageAreaImpl::copy):
              (WebCore::StorageAreaImpl::length):
              (WebCore::StorageAreaImpl::key):
              (WebCore::StorageAreaImpl::getItem):
              (WebCore::StorageAreaImpl::setItem):
              (WebCore::StorageAreaImpl::removeItem):
              (WebCore::StorageAreaImpl::clear):
              (WebCore::StorageAreaImpl::contains):
              (WebCore::StorageAreaImpl::importItem):
              (WebCore::StorageAreaImpl::securityOrigin):
              (WebCore::StorageAreaImpl::close):
              (WebCore::StorageAreaImpl::blockUntilImportComplete):
              (WebCore::StorageAreaImpl::dispatchStorageEvent):
              * storage/StorageAreaImpl.h: Copied from WebCore/storage/StorageArea.h.
              * storage/StorageAreaSync.cpp:
              (WebCore::StorageAreaSync::create):
              (WebCore::StorageAreaSync::StorageAreaSync):
              * storage/StorageAreaSync.h:
              * storage/StorageNamespace.cpp:
              (WebCore::StorageNamespace::localStorageNamespace):
              (WebCore::StorageNamespace::sessionStorageNamespace):
              (WebCore::StorageNamespace::~StorageNamespace):
              * storage/StorageNamespace.h:
              * storage/StorageNamespaceImpl.cpp: Copied from WebCore/storage/StorageNamespace.cpp.
              (WebCore::StorageNamespaceImpl::localStorageNamespace):
              (WebCore::StorageNamespaceImpl::sessionStorageNamespace):
              (WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
              (WebCore::StorageNamespaceImpl::~StorageNamespaceImpl):
              (WebCore::StorageNamespaceImpl::copy):
              (WebCore::StorageNamespaceImpl::storageArea):
              (WebCore::StorageNamespaceImpl::close):
              * storage/StorageNamespaceImpl.h: Copied from WebCore/storage/StorageNamespace.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c62dd00
  12. 30 Jun, 2009 1 commit
  13. 26 Jun, 2009 1 commit
    • dglazkov@chromium.org's avatar
      2009-06-26 Jeremy Orlow <jorlow@chromium.org> · 5626dd64
      dglazkov@chromium.org authored
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=26732
      
              For the final step of https://bugs.webkit.org/show_bug.cgi?id=25376,
              combine LocalStorage and SessionStorage into StorageNamespace. The
              synching code (for LocalStorage) has already been removed, so these
              classes are now very similar.  All they do is essentially contain a
              logical grouping of origins that are attached to specific contexts
              (be it PageGroups for LocalStorage and Page for SessionStorage).
      
              * GNUmakefile.am:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * page/Chrome.cpp:
              (WebCore::Chrome::createWindow):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::localStorage):
              * page/DOMWindow.h:
              * page/Page.cpp:
              (WebCore::Page::sessionStorage):
              (WebCore::Page::setSessionStorage):
              * page/Page.h:
              * page/PageGroup.cpp:
              (WebCore::PageGroup::localStorage):
              * page/PageGroup.h:
              * storage/LocalStorage.cpp: Removed.
              * storage/LocalStorage.h: Removed.
              * storage/LocalStorageTask.cpp:
              * storage/LocalStorageThread.cpp:
              * storage/SessionStorage.cpp: Removed.
              * storage/SessionStorage.h: Removed.
              * storage/StorageArea.cpp:
              (WebCore::StorageArea::create):
              (WebCore::StorageArea::StorageArea):
              (WebCore::StorageArea::copy):
              (WebCore::StorageArea::length):
              (WebCore::StorageArea::key):
              (WebCore::StorageArea::getItem):
              (WebCore::StorageArea::setItem):
              (WebCore::StorageArea::removeItem):
              (WebCore::StorageArea::clear):
              (WebCore::StorageArea::contains):
              (WebCore::StorageArea::importItem):
              (WebCore::StorageArea::close):
              (WebCore::StorageArea::dispatchStorageEvent):
              * storage/StorageArea.h:
              (WebCore::):
              * storage/StorageAreaSync.cpp:
              (WebCore::StorageAreaSync::scheduleFinalSync):
              * storage/StorageNamespace.cpp: Copied from WebCore/storage/LocalStorage.cpp.
              (WebCore::localStorageNamespaceMap):
              (WebCore::StorageNamespace::localStorageNamespace):
              (WebCore::StorageNamespace::sessionStorageNamespace):
              (WebCore::StorageNamespace::StorageNamespace):
              (WebCore::StorageNamespace::~StorageNamespace):
              (WebCore::StorageNamespace::copy):
              (WebCore::StorageNamespace::storageArea):
              (WebCore::StorageNamespace::close):
              * storage/StorageNamespace.h: Copied from WebCore/storage/LocalStorage.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5626dd64