1. 24 Apr, 2012 40 commits
    • tkent@chromium.org's avatar
      Calendar Picker: Open a calendar picker by keyboard operation · e3bf720b
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84680
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      - Open a calendar picker by the down arrow key.
      - Remove stepping down/up by keyboard and wheel operations.
        This behavior was for text fields with spin buttons. Because the date
      type doesn't have spin buttons, we should remove this behavior.
      
      No new tests for opening a calendar picker. This behavior is not
      testable by DRT yet. For removal of stepping up/down,
      fast/forms/date/date-stepup-stepdown-from-renderer.html is updated.
      
      * html/BaseDateAndTimeInputType.cpp:
      (WebCore::BaseDateAndTimeInputType::handleKeydownEvent):
      Check shouldHaveSpinButton() before spin button key operations.
      (WebCore::BaseDateAndTimeInputType::handleWheelEvent):
      Check shouldHaveSpinButton() before spin button wheel operations.
      * html/BaseDateAndTimeInputType.h:
      (BaseDateAndTimeInputType):
      Make handleKeydownEvent() protected because a subclass overrides it.
      * html/DateInputType.cpp:
      (WebCore::DateInputType::handleKeydownEvent):
      Open a calendar picker by the down arrow key.
      * html/DateInputType.h:
      (DateInputType): Add handleKeydownEvent() declaration.
      * html/shadow/CalendarPickerElement.h:
      (CalendarPickerElement): Make openPopup() public because DateInputType calls it.
      
      LayoutTests:
      
      * fast/forms/date/date-stepup-stepdown-from-renderer-expected.txt:
      * fast/forms/date/date-stepup-stepdown-from-renderer.html:
      Stepping up/down by kerboard was removed. Update the test to confirm it doesn't work.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3bf720b
    • hclam@chromium.org's avatar
      [chromium] Unreviewed test expectations update. · ce6fc322
      hclam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84813
      
      Suppress test image mismatch due to r115123. Rebaseline is coming soon.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce6fc322
    • yael.aharon@nokia.com's avatar
      [Qt] Move notification icon download out of WebCore · 1a5e9395
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=80700
      
      Reviewed by Jian Li.
      
      Remove http/tests/notifications after the code the tests were testing has been removed.
      
      * http/tests/notifications: Removed.
      * http/tests/notifications/icon-does-not-exist-expected.txt: Removed.
      * http/tests/notifications/icon-does-not-exist.html: Removed.
      * http/tests/notifications/icon-exists-cancel-expected.txt: Removed.
      * http/tests/notifications/icon-exists-cancel.html: Removed.
      * http/tests/notifications/icon-exists-expected.txt: Removed.
      * http/tests/notifications/icon-exists-show-alert-during-load-expected.txt: Removed.
      * http/tests/notifications/icon-exists-show-alert-during-load.html: Removed.
      * http/tests/notifications/icon-exists.html: Removed.
      * http/tests/notifications/icon-requires-auth-expected.txt: Removed.
      * http/tests/notifications/icon-requires-auth.html: Removed.
      * http/tests/notifications/resources: Removed.
      * http/tests/notifications/resources/icon-exists.png: Removed.
      * http/tests/notifications/resources/icon-requires-auth.php: Removed.
      * platform/chromium/test_expectations.txt:
      * platform/efl/Skipped:
      * platform/gtk/test_expectations.txt:
      * platform/mac/Skipped:
      * platform/qt-5.0-wk2/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      * platform/wincairo/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a5e9395
    • commit-queue@webkit.org's avatar
      [BlackBerry] Perform spellcheck before handling TouchRelease event · d4357e33
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84744
      
      After rebasing to master_35, it appears as though some code had been moved around.
      Here, we were handling the TouchReleased event before calling spellcheck.  This
      meant that when we finally got the call to spellcheck, the fatFinger result had been
      reset and the spelling markers had been removed.
      
      In addition, based on https://bugs.webkit.org/show_bug.cgi?id=66330
      I am also updating the BlackBerry specific documentMarkerContainingPoint to use
      LayoutPoint instead of IntPoint.
      
      Internally reviewed by Mike Fenton.
      
      Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-04-24
      Reviewed by Antonio Gomes.
      
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
      (BlackBerry::WebKit::TouchEventHandler::spellCheck):
      * dom/DocumentMarkerController.cpp:
      (WebCore::DocumentMarkerController::markerContainingPoint):
      * dom/DocumentMarkerController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4357e33
    • msaboff@apple.com's avatar
      objectProtoFuncToString creates new string every invocation · 8bbd1b15
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84781
      
      Reviewed by Geoffrey Garen.
      
      Cache the results of object toString() in the attached Structure.
      
      * runtime/ObjectPrototype.cpp:
      (JSC::objectProtoFuncToString):
      * runtime/Structure.cpp:
      (JSC::Structure::visitChildren): visit new m_hasObjectToStringValue.
      * runtime/Structure.h: Added new member m_hasObjectToStringValue
      (JSC):
      (JSC::Structure::objectToStringValue):
      (Structure):
      (JSC::Structure::setObjectToStringValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bbd1b15
    • yael.aharon@nokia.com's avatar
      Unreviewed rebaseline after r115134. · 99b1d082
      yael.aharon@nokia.com authored
      * platform/qt/fast/block/positioning/016-expected.txt:
      * platform/qt/fast/block/positioning/025-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99b1d082
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r115099, r115102, and r115127. · 9f42d4c4
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/115099
      http://trac.webkit.org/changeset/115102
      http://trac.webkit.org/changeset/115127
      https://bugs.webkit.org/show_bug.cgi?id=84809
      
      Made html5lib/runner.html crash, spot fix didn't help so
      rolling out so original author can do over. (Requested by
      kling on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24
      
      * dom/Element.cpp:
      (WebCore::Element::parserSetAttributes):
      (WebCore::Element::normalizeAttributes):
      * dom/Element.h:
      (Element):
      * dom/ElementAttributeData.cpp:
      (WebCore::AttributeVector::removeAttribute):
      (WebCore):
      * dom/ElementAttributeData.h:
      (AttributeVector):
      (WebCore::AttributeVector::AttributeVector):
      (WebCore):
      (WebCore::AttributeVector::getAttributeItem):
      (WebCore::AttributeVector::getAttributeItemIndex):
      (WebCore::AttributeVector::insertAttribute):
      (WebCore::ElementAttributeData::getAttributeItem):
      (WebCore::ElementAttributeData::getAttributeItemIndex):
      (WebCore::ElementAttributeData::attributeVector):
      (WebCore::ElementAttributeData::clonedAttributeVector):
      (ElementAttributeData):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
      * html/parser/HTMLToken.h:
      (WebCore::AtomicHTMLToken::AtomicHTMLToken):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processFakeStartTag):
      (WebCore::HTMLTreeBuilder::attributesForIsindexInput):
      * html/parser/HTMLTreeBuilder.h:
      * html/parser/TextDocumentParser.cpp:
      (WebCore::TextDocumentParser::insertFakePreElement):
      * xml/XMLErrors.cpp:
      (WebCore::createXHTMLParserErrorHeader):
      (WebCore::XMLErrors::insertErrorMessageBlock):
      * xml/parser/MarkupTokenBase.h:
      (WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
      (WebCore::AtomicMarkupTokenBase::getAttributeItem):
      (WebCore::AtomicMarkupTokenBase::attributes):
      (AtomicMarkupTokenBase):
      (WebCore::::initializeAttributes):
      * xml/parser/XMLToken.h:
      (WebCore::AtomicXMLToken::AtomicXMLToken):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f42d4c4
    • jpfau@apple.com's avatar
      Prevent drag and drop from setting file URLs · 573831f0
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=76596
      
      Reviewed by Enrica Casucci.
      
      Source/WebCore:
      
      Blacklisted file URLs from being set via dataTransfer.setData for specific types.
      
      * platform/mac/ClipboardMac.mm:
      (WebCore::ClipboardMac::setData):
      
      LayoutTests:
      
      Updated tests to reflect new expectations.
      
      * http/tests/security/dataTransfer-set-data-file-url.html:
      * platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      573831f0
    • hclam@chromium.org's avatar
      [chromium] Unreviewed test expectations update. · 901568cd
      hclam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84810
      
      Mark svg/carto.net/window.svg as fail due to changes in r115085.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      901568cd
    • dpranke@chromium.org's avatar
      nrwt: add ASAN handling to chromium crash logs · 46ed267b
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84664
      
      Reviewed by Ojan Vafai.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      (ChromiumPort._get_crash_log):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46ed267b
    • enrica@apple.com's avatar
      REGRESSION (r109022) Safari not placing service data on pasteboard. · beec6107
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84766
      <rdar://problem/11085756>
              
      The support for OS X services requires that the write operations to
      the pasteboard occur synchronously. This behavior was changed with r109022.
      This change removes the original synchronous call to the WebProcess to perform
      the pasteboard write that had become asynchronous after r109022.
      It implements instead a synchronous call to retrive the content to be placed
      in the pasteboard.
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * editing/Editor.h:
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::writeSelectionToPasteboard):
      (WebCore::Editor::stringSelectionForPasteboard): Added.
      (WebCore::Editor::dataSelectionForPasteboard): Added.
      * platform/Pasteboard.h:
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getStringSelection): Added.
      (WebCore::Pasteboard::getDataSelection): Added.
      (WebCore::Pasteboard::writeSelectionForTypes):
      (WebCore::Pasteboard::writeSelection):
      
      Source/WebKit2: 
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView writeSelectionToPasteboard:types:]): Uses new methods.
      * UIProcess/WebPageProxy.h:
      * UIProcess/mac/WebPageProxyMac.mm: Removed writeSelectionToPasteboard.
      (WebKit::WebPageProxy::getStringSelectionForPasteboard): Added.
      (WebKit::WebPageProxy::getBufferSelectionForPasteboard): Added.
      * WebProcess/WebPage/WebPage.h: Added support for the new messages and
      removed old message.
      * WebProcess/WebPage/WebPage.messages.in: Ditto.
      * WebProcess/WebPage/mac/WebPageMac.mm: Ditto.
      (WebKit::WebPage::readSelectionFromPasteboard): Added.
      (WebKit::WebPage::getBufferSelectionForPasteboard): Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      beec6107
    • commit-queue@webkit.org's avatar
      Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-04-24 · ef8c392f
      commit-queue@webkit.org authored
      Reviewed by Oliver Hunt.
      
      https://bugs.webkit.org/show_bug.cgi?id=84727.
      Fix build when ENABLE_JIT_CONSTANT_BLINDING enabled.
      
      * assembler/MacroAssemblerSH4.h:
      (JSC::MacroAssemblerSH4::or32):
      (JSC::MacroAssemblerSH4::and32):
      (JSC::MacroAssemblerSH4::lshift32):
      (JSC::MacroAssemblerSH4::xor32):
      (JSC::MacroAssemblerSH4::branchSub32):
      (JSC::MacroAssemblerSH4::urshift32):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef8c392f
    • hclam@chromium.org's avatar
      [chromium] Unreviewed test expectations update. · daaadb73
      hclam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84806
      
      html5lib/runner.html fails after r115099 and r115127, mark it so.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daaadb73
    • dpranke@chromium.org's avatar
      webkit-patch rebaseline-test is retrieving stale expectations · f29a20b8
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84762
      
      Reviewed by Ojan Vafai.
      
      webkit-patch rebaseline-expectations is fetching files directly
      from the layout-test-results directory on the buildbots, rather
      than fetching them from the archive. This is problematic because
      we don't clobber the directory after each run and so you can end
      up fetching stale failing results.
      
      This change temporarily changes the code to fetch the zip file
      instead -- making things much slower -- until I can confer w/
      abarth and ojan over the best way to fix this for the long-term.
      
      * Scripts/webkitpy/tool/commands/rebaseline.py:
      (RebaselineTest.__init__):
      (RebaselineTest._zip_file_set):
      (RebaselineTest):
      (RebaselineTest._fetch_baseline):
      (RebaselineTest._rebaseline_test):
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (TestRebaseline.stub_rebaseline_test_command_and_tool):
      (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
      (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
      (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
      (test_rebaseline_updates_expectations_file):
      (test_rebaseline_test):
      (test_rebaseline_and_copy_test):
      (test_rebaseline_and_copy_test_no_existing_result):
      (test_rebaseline_and_copy_test_with_lion_result):
      (test_rebaseline_and_copy_no_overwrite_test):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f29a20b8
    • barraclough@apple.com's avatar
      Add explicit patchableBranchPtrWithPatch/patchableJump methods · 959b92e2
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84498
      
      Reviewed by Filip Pizlo.
      
      Don't rely on inUninterruptedSequence to distinguish which jumps we need to be able to repatch.
      
      * assembler/AbstractMacroAssembler.h:
      (JSC::AbstractMacroAssembler::PatchableJump::PatchableJump):
      (PatchableJump):
      (JSC::AbstractMacroAssembler::PatchableJump::operator Jump&):
      (AbstractMacroAssembler):
      (JSC::AbstractMacroAssembler::AbstractMacroAssembler):
          - Added PatchableJump type, removed inUninterruptedSequence.
      * assembler/LinkBuffer.h:
      (LinkBuffer):
      (JSC::LinkBuffer::locationOf):
          - Only allow the location to be taken of patchable branches
      * assembler/MacroAssembler.h:
      (MacroAssembler):
      (JSC::MacroAssembler::patchableBranchPtrWithPatch):
      (JSC::MacroAssembler::patchableJump):
      (JSC::MacroAssembler::shouldBlind):
          - Added default implementation of patchableBranchPtrWithPatch, patchableJump.
      * assembler/MacroAssemblerARMv7.h:
      (JSC::MacroAssemblerARMv7::MacroAssemblerARMv7):
      (MacroAssemblerARMv7):
      (JSC::MacroAssemblerARMv7::patchableBranchPtrWithPatch):
      (JSC::MacroAssemblerARMv7::patchableJump):
      (JSC::MacroAssemblerARMv7::jump):
      (JSC::MacroAssemblerARMv7::makeBranch):
          - Added ARMv7 implementation of patchableBranchPtrWithPatch, patchableJump.
      * dfg/DFGCorrectableJumpPoint.h:
      (DFG):
      (JSC::DFG::CorrectableJumpPoint::switchToLateJump):
          - Late jumps are PatchableJumps.
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::linkOSRExits):
          - replace use of inUninterruptedSequence
      * dfg/DFGJITCompiler.h:
      (JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
      (PropertyAccessRecord):
          - replace use of inUninterruptedSequence
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::cachedGetById):
      (JSC::DFG::SpeculativeJIT::cachedPutById):
          - replace use of inUninterruptedSequence
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::cachedGetById):
      (JSC::DFG::SpeculativeJIT::cachedPutById):
          - replace use of inUninterruptedSequence
      * jit/JIT.h:
      (PropertyStubCompilationInfo):
          - replace use of inUninterruptedSequence
      * jit/JITInlineMethods.h:
      (JSC::JIT::beginUninterruptedSequence):
      (JSC::JIT::endUninterruptedSequence):
          - replace use of inUninterruptedSequence
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::compileGetByIdHotPath):
          - replace use of inUninterruptedSequence
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::compileGetByIdHotPath):
          - replace use of inUninterruptedSequence
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      959b92e2
    • crogers@google.com's avatar
      Fix layout test failures for Oscillator because WaveTable now normalizes to 0dBFS instead of -6dbFS · ab5a975a
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84799
      
      Reviewed by James Robinson.
      
      This fixes failures caused by: http://trac.webkit.org/changeset/115111
      We need to adjust the layout test itself to scale by 1/2 to compensate for the new WaveTable normalization.
      The reason we don't change the audio .wav file baselines themselves is because audio values can potentially
      clip past full scale, and we need to be able to avoid this "overshoot".
      
      * webaudio/resources/oscillator-testing.js:
      (generateExponentialOscillatorSweep):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab5a975a
    • danakj@chromium.org's avatar
      [chromium] Image masks are considered opaque incorrectly · ff7c8a79
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84275
      
      Reviewed by Adrienne Walker.
      
      Source/WebCore:
      
      Match the behaviour of SkCanvas layers more closely while tracking
      opaque paints. SkCanvas layers actually act as a separate device
      (ie. pixels) and when the layer is popped off, the pixels are copied
      down to the layer below.
      
      While we can use the total clip to decide what pixels the the
      drawing operation will affect in the final device, the blending
      down through layers needs to consider each layer carefully.
      
      In this case the image mask is drawn into a layer which is copied
      down using the DestinationIn operation. Since the layer contains
      non-opaque pixels, the DestinationIn copy can destroy opaque
      areas in the next layer. We add OpaqueRegionSkia::FillByCopy to
      distinguish the case where we are copying a block of pixels, and the
      alpha values are essentially unknown.
      
      Unit test: PlatformContextSkiaTest.trackImageMask
                 PlatformContextSkiaTest.trackImageMaskWithOpaqueRect
      
      * platform/graphics/skia/OpaqueRegionSkia.cpp:
      (WebCore::paintIsOpaque):
      (WebCore::OpaqueRegionSkia::applyOpaqueRegionFromLayer):
      (WebCore::OpaqueRegionSkia::pushCanvasLayer):
      (WebCore::OpaqueRegionSkia::popCanvasLayer):
      (WebCore::OpaqueRegionSkia::didDrawRect):
      (WebCore::OpaqueRegionSkia::didDrawPath):
      (WebCore::OpaqueRegionSkia::didDrawPoints):
      (WebCore::OpaqueRegionSkia::didDrawBounded):
      (WebCore::OpaqueRegionSkia::didDraw):
      (WebCore::OpaqueRegionSkia::didDrawUnbounded):
      (WebCore::OpaqueRegionSkia::markRectAsOpaque):
      (WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
      (WebCore::OpaqueRegionSkia::markAllAsNonOpaque):
      * platform/graphics/skia/OpaqueRegionSkia.h:
      (OpaqueRegionSkia):
      (CanvasLayerState):
      * platform/graphics/skia/PlatformContextSkia.cpp:
      (WebCore::PlatformContextSkia::restoreLayer):
      
      Source/WebKit/chromium:
      
      * tests/PlatformContextSkiaTest.cpp:
      (WebCore):
      (WebCore::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff7c8a79
    • achicu@adobe.com's avatar
      CSS Shaders: Repainting the FECustomFilter requires full source image · e1c7a30e
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=76689
      
      Source/WebCore:
      
      Reviewed by Dean Jackson..
      
      When a pixel of a filtered layer changes we need to update the whole bounding box of the layer and
      not just the dirty rectangle. That's because the shader might change the color of any of the pixels inside the box.
      
      Added tests where a shader is moving and rotating the contents and the actual
      dirty box of the source image is not the same as the output dirty rectangle.
      
      Tests: css3/filters/custom/filter-repaint-custom-clipped.html
             css3/filters/custom/filter-repaint-custom-rotated.html
             css3/filters/custom/filter-repaint-custom.html
      
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::FilterEffectRenderer):
      (WebCore::FilterEffectRenderer::build):
      (WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
      * rendering/FilterEffectRenderer.h:
      (FilterEffectRenderer):
      (WebCore::FilterEffectRenderer::hasCustomShaderFilter):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
      
      LayoutTests:
      
      Reviewed by Dean Jackson.
      
      * css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
      * css3/filters/custom/filter-repaint-custom-clipped-expected.txt: Added.
      * css3/filters/custom/filter-repaint-custom-clipped.html: Added.
      * css3/filters/custom/filter-repaint-custom-expected.png: Added.
      * css3/filters/custom/filter-repaint-custom-expected.txt: Added.
      * css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
      * css3/filters/custom/filter-repaint-custom-rotated-expected.txt: Added.
      * css3/filters/custom/filter-repaint-custom-rotated.html: Added.
      * css3/filters/custom/filter-repaint-custom.html: Added.
      * css3/filters/resources/color-add.fs: Added.
      * css3/filters/resources/vertex-horizontal-offset.vs: Added.
      * css3/filters/resources/vertex-rotate.vs: Added.
      * platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
      * platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png: Added.
      * platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1c7a30e
    • hclam@chromium.org's avatar
      [chromium] Unreviewed test expectations update. · 99d2e0b2
      hclam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84802
      
      New test added in r115096 is failing on Chromium, mark it so.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99d2e0b2
    • alexis.menard@openbossa.org's avatar
      Replace occurences of style selector from variables and methods names by style resolver. · 31b77cb7
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84765
      
      Reviewed by Andreas Kling.
      
      Rename methods and variables to follow the new name StyleResolver. It requires to update the
      local variables, methods parameters, and function names to match the new name and to remove
      the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
      will be to rename CSSStyleSelector file and update the includes.
      
      Source/WebCore: 
      
      No new tests : just renaming the variables and method names. No behavior changes expected.
      
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
      * css/CSSGradientValue.cpp:
      (WebCore::CSSGradientValue::addStops):
      * css/CSSPageRule.cpp:
      (WebCore::CSSPageRule::setSelectorText):
      * css/CSSStyleRule.cpp:
      (WebCore::CSSStyleRule::setSelectorText):
      * css/CSSStyleSheet.cpp:
      (WebCore::StyleSheetInternal::styleSheetChanged):
      * css/MediaQueryEvaluator.cpp:
      (WebCore::MediaQueryEvaluator::eval):
      * css/MediaQueryMatcher.cpp:
      (WebCore::MediaQueryMatcher::prepareEvaluator):
      (WebCore::MediaQueryMatcher::styleResolverChanged):
      * css/MediaQueryMatcher.h:
      (MediaQueryMatcher):
      * css/PropertySetCSSStyleDeclaration.cpp:
      (WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyExpanding::applyInheritValue):
      (WebCore::ApplyPropertyExpanding::applyInitialValue):
      (WebCore::ApplyPropertyExpanding::applyValue):
      (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
      (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
      (WebCore::ApplyPropertyDefault::applyValue):
      (WebCore::ApplyPropertyNumber::applyValue):
      (WebCore::ApplyPropertyStyleImage::applyValue):
      (WebCore::ApplyPropertyAuto::applyInheritValue):
      (WebCore::ApplyPropertyAuto::applyInitialValue):
      (WebCore::ApplyPropertyAuto::applyValue):
      (WebCore::ApplyPropertyClip::convertToLength):
      (WebCore::ApplyPropertyClip::applyInheritValue):
      (WebCore::ApplyPropertyClip::applyInitialValue):
      (WebCore::ApplyPropertyClip::applyValue):
      (WebCore::ApplyPropertyColor::applyInheritValue):
      (WebCore::ApplyPropertyColor::applyInitialValue):
      (WebCore::ApplyPropertyColor::applyValue):
      (WebCore::ApplyPropertyColor::applyColorValue):
      (WebCore::ApplyPropertyDirection::applyValue):
      (WebCore::ApplyPropertyLength::applyValue):
      (WebCore::ApplyPropertyString::applyValue):
      (WebCore::ApplyPropertyBorderRadius::applyValue):
      (WebCore::ApplyPropertyFillLayer::applyInheritValue):
      (WebCore::ApplyPropertyFillLayer::applyInitialValue):
      (WebCore::ApplyPropertyFillLayer::applyValue):
      (WebCore::ApplyPropertyComputeLength::applyValue):
      (WebCore::ApplyPropertyFont::applyInheritValue):
      (WebCore::ApplyPropertyFont::applyInitialValue):
      (WebCore::ApplyPropertyFont::applyValue):
      (WebCore::ApplyPropertyFontSize::applyInheritValue):
      (WebCore::ApplyPropertyFontSize::applyInitialValue):
      (WebCore::ApplyPropertyFontSize::applyValue):
      (WebCore::ApplyPropertyFontWeight::applyValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyValue):
      (WebCore::ApplyPropertyBorderImage::applyValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyValue):
      (WebCore::ApplyPropertyBorderImageSource::applyValue):
      (WebCore::ApplyPropertyCounter::applyInheritValue):
      (WebCore::ApplyPropertyCounter::applyValue):
      (WebCore::ApplyPropertyCursor::applyInheritValue):
      (WebCore::ApplyPropertyCursor::applyInitialValue):
      (WebCore::ApplyPropertyCursor::applyValue):
      (WebCore::ApplyPropertyTextAlign::applyValue):
      (WebCore::ApplyPropertyTextDecoration::applyValue):
      (WebCore::ApplyPropertyUnicodeBidi::applyValue):
      (WebCore::ApplyPropertyLineHeight::applyValue):
      (WebCore::ApplyPropertyPageSize::applyValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
      (WebCore::ApplyPropertyAnimation::map):
      (WebCore::ApplyPropertyAnimation::applyInheritValue):
      (WebCore::ApplyPropertyAnimation::applyInitialValue):
      (WebCore::ApplyPropertyAnimation::applyValue):
      (WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
      (WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
      (WebCore::ApplyPropertyOutlineStyle::applyValue):
      (WebCore::ApplyPropertyResize::applyValue):
      (WebCore::ApplyPropertyVerticalAlign::applyValue):
      (WebCore::ApplyPropertyAspectRatio::applyInheritValue):
      (WebCore::ApplyPropertyAspectRatio::applyInitialValue):
      (WebCore::ApplyPropertyAspectRatio::applyValue):
      (WebCore::ApplyPropertyZoom::resetEffectiveZoom):
      (WebCore::ApplyPropertyZoom::applyInheritValue):
      (WebCore::ApplyPropertyZoom::applyInitialValue):
      (WebCore::ApplyPropertyZoom::applyValue):
      (WebCore::ApplyPropertyDisplay::isValidDisplayValue):
      (WebCore::ApplyPropertyDisplay::applyInheritValue):
      (WebCore::ApplyPropertyDisplay::applyInitialValue):
      (WebCore::ApplyPropertyDisplay::applyValue):
      (WebCore::ApplyPropertyFlex::applyInheritValue):
      (WebCore::ApplyPropertyFlex::applyInitialValue):
      (WebCore::ApplyPropertyFlex::applyValue):
      * css/StyleBuilder.h:
      (WebCore::PropertyHandler::applyInheritValue):
      (WebCore::PropertyHandler::applyInitialValue):
      (WebCore::PropertyHandler::applyValue):
      * css/StyleMedia.cpp:
      (WebCore::StyleMedia::matchMedium):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::~Document):
      (WebCore::Document::setDocType):
      (WebCore::Document::childrenChanged):
      (WebCore::Document::setContentLanguage):
      (WebCore::Document::recalcStyle):
      (WebCore::Document::updateLayoutIgnorePendingStylesheets):
      (WebCore::Document::styleForElementIgnoringPendingStylesheets):
      (WebCore::Document::styleForPage):
      (WebCore::Document::combineCSSFeatureFlags):
      (WebCore::Document::resetCSSFeatureFlags):
      (WebCore::Document::createStyleResolver):
      (WebCore::Document::clearStyleResolver):
      (WebCore::Document::clearPageUserSheet):
      (WebCore::Document::updatePageUserSheet):
      (WebCore::Document::clearPageGroupUserSheets):
      (WebCore::Document::updatePageGroupUserSheets):
      (WebCore::Document::addUserSheet):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::setSelectedStylesheetSet):
      (WebCore::Document::removePendingSheet):
      (WebCore::Document::evaluateMediaQueryList):
      (WebCore::Document::styleResolverChanged):
      (WebCore::Document::analyzeStylesheetChange):
      (WebCore::Document::updateActiveStylesheets):
      * dom/Document.h:
      (WebCore::Document::styleResolverIfExists):
      (WebCore::Document::styleResolver):
      (Document):
      * dom/Element.cpp:
      (WebCore::StyleResolverParentPusher::StyleResolverParentPusher):
      (WebCore::StyleResolverParentPusher::push):
      (WebCore::StyleResolverParentPusher::~StyleResolverParentPusher):
      (StyleResolverParentPusher):
      (WebCore::Element::attributeChanged):
      (WebCore::Element::attach):
      (WebCore::Element::styleForRenderer):
      (WebCore::Element::recalcStyle):
      (WebCore::Element::beginParsingChildren):
      (WebCore::Element::finishParsingChildren):
      * dom/ProcessingInstruction.cpp:
      (WebCore::ProcessingInstruction::removedFrom):
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::attach):
      * dom/ShadowTree.cpp:
      (WebCore::ShadowTree::recalcShadowTreeStyle):
      * dom/StyleElement.cpp:
      (WebCore::StyleElement::removedFromDocument):
      * editing/EditingStyle.cpp:
      (WebCore::styleFromMatchedRulesForElement):
      * history/CachedPage.cpp:
      (WebCore::CachedPage::restore):
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::styleResolver):
      * html/HTMLCanvasElement.h:
      (HTMLCanvasElement):
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::setDisabledState):
      (WebCore::HTMLLinkElement::process):
      (WebCore::HTMLLinkElement::removedFrom):
      (WebCore::HTMLLinkElement::removePendingSheet):
      * html/HTMLStyleElement.cpp:
      (WebCore::HTMLStyleElement::registerWithScopingNode):
      (WebCore::HTMLStyleElement::unregisterWithScopingNode):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::setFont):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::recalcStyleForPseudoStateIfNeeded):
      (WebCore::InspectorCSSAgent::getMatchedStylesForNode):
      (WebCore::InspectorCSSAgent::buildArrayForRuleList):
      (WebCore::InspectorCSSAgent::clearPseudoState):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::updateViewMetrics):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::getMatchedCSSRules):
      * page/Frame.cpp:
      (WebCore::Frame::setPrinting):
      * page/FrameView.cpp:
      (WebCore::FrameView::layout):
      * page/Page.cpp:
      (WebCore::Page::setViewMode):
      (WebCore::Page::setNeedsRecalcStyleInAllFrames):
      (WebCore::Page::allVisitedStateChanged):
      (WebCore::Page::visitedStateChanged):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::KeyframeAnimation):
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
      (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
      (WebCore::RenderThemeEfl::adjustCheckboxStyle):
      (WebCore::RenderThemeEfl::adjustRadioStyle):
      (WebCore::RenderThemeEfl::adjustButtonStyle):
      (WebCore::RenderThemeEfl::adjustMenuListStyle):
      (WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
      (WebCore::RenderThemeEfl::adjustTextFieldStyle):
      (WebCore::RenderThemeEfl::adjustTextAreaStyle):
      (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
      (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
      (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
      (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
      (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
      (WebCore::RenderThemeEfl::adjustProgressBarStyle):
      * platform/gtk/RenderThemeGtk.cpp:
      (WebCore::RenderThemeGtk::adjustButtonStyle):
      (WebCore::RenderThemeGtk::adjustMenuListStyle):
      (WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
      (WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
      (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
      (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
      (WebCore::RenderThemeGtk::adjustSearchFieldStyle):
      (WebCore::RenderThemeGtk::adjustSliderThumbStyle):
      * platform/qt/RenderThemeQt.cpp:
      (WebCore::RenderThemeQt::adjustSliderThumbStyle):
      (WebCore::RenderThemeQt::adjustSearchFieldStyle):
      (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
      (WebCore::RenderThemeQt::adjustSearchFieldDecorationStyle):
      (WebCore::RenderThemeQt::adjustSearchFieldResultsDecorationStyle):
      (WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
      * platform/qt/RenderThemeQtMobile.cpp:
      (WebCore::RenderThemeQtMobile::adjustButtonStyle):
      (WebCore::RenderThemeQtMobile::adjustMenuListStyle):
      * platform/wx/RenderThemeWx.cpp:
      (WebCore::RenderThemeWx::adjustButtonStyle):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::updateFromElement):
      (WebCore::RenderListBox::paintItemForeground):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::fontSelector):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::getUncachedPseudoStyle):
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::styleDidChange):
      (WebCore::RenderRegion::computeStyleInRegion):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::fontSelector):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::adjustStyle):
      (WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):
      * rendering/RenderThemeChromiumSkia.cpp:
      (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
      (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::adjustMenuListStyle):
      (WebCore::RenderThemeMac::adjustSliderThumbStyle):
      (WebCore::RenderThemeMac::adjustSearchFieldStyle):
      * rendering/RenderThemeSafari.cpp:
      (WebCore::RenderThemeSafari::setFontFromControlSize):
      (WebCore::RenderThemeSafari::adjustButtonStyle):
      (WebCore::RenderThemeSafari::adjustMenuListStyle):
      (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
      (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
      (WebCore::RenderThemeSafari::adjustSearchFieldStyle):
      (WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
      (WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle):
      (WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle):
      (WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
      * rendering/RenderThemeWin.cpp:
      (WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
      (WebCore::RenderThemeWin::adjustMenuListStyle):
      (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
      (WebCore::RenderThemeWin::adjustSearchFieldStyle):
      (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
      (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
      (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
      (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
      * rendering/RenderThemeWinCE.cpp:
      (WebCore::RenderThemeWinCE::adjustMenuListStyle):
      (WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
      (WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
      (WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
      (WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
      (WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
      (WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
      * rendering/style/StyleGeneratedImage.cpp:
      (WebCore::StyleGeneratedImage::image):
      * rendering/svg/RenderSVGInlineText.cpp:
      (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::customStyleForRenderer):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::rebuildFontFace):
      (WebCore::SVGFontFaceElement::removedFrom):
      * xml/XMLTreeViewer.cpp:
      (WebCore::XMLTreeViewer::transformDocumentToTreeView):
      * xml/parser/XMLDocumentParser.cpp:
      (WebCore::XMLDocumentParser::end):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::doEnd):
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::XMLDocumentParser::doEnd):
      * WebCore.exp.in:
      
      Source/WebKit/chromium: 
      
      * src/AutofillPopupMenuClient.cpp:
      (WebKit::AutofillPopupMenuClient::fontSelector):
      (WebKit::AutofillPopupMenuClient::initialize):
      * src/WebDevToolsAgentImpl.cpp:
      (WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
      (WebKit::DeviceMetricsSupport::applySizeOverrideInternal):
      
      Source/WebKit/mac: 
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView reapplyStyles]):
      (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
      
      Source/WebKit/qt: 
      
      * Api/qwebelement.cpp:
      (QWebElement::styleProperty):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setMediaType):
      * WebCoreSupport/RenderThemeQStyle.cpp:
      (WebCore::RenderThemeQStyle::adjustButtonStyle):
      (WebCore::RenderThemeQStyle::adjustTextAreaStyle):
      (WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
      (WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
      (WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
      (WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31b77cb7
    • commit-queue@webkit.org's avatar
      [BlackBerry] setUserViewportArguments not always respected. · c6541ac1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84738
      
      Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-24
      Reviewed by Antonio Gomes.
      
      Remove the unnecessary logic in
      WebPagePrivate::recomputeVirtualViewportFromViewportArguments().
      Instead it is much simpler to just set the m_viewportArguments to
      m_userViewportArguments on LoadCommitted. If there is a viewport
      tag in the content, m_viewportArguments will be replaced with it
      as usual during normal page load.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setLoadState):
      (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6541ac1
    • yael.aharon@nokia.com's avatar
      Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt webkit2 · d611411a
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83980
      
      Reviewed by Simon Fraser.
      
      .: 
      
      * ManualTests/fixed-position-no-z-index.html: Added.
      
      Source/WebCore: 
      
      When a fixed position element does not have z-index explicitly specified, it does not create a
      stacking context. This results in fixed elements scrolling with the content layer.
      This patch creates a stacking context for fixed positioned elements for the Qt port, by enabling
      the flag ENABLE_FIXED_POSITION_CREATES_STACKING_CONTEXT.
      Added a manual test because this patch takes effect only during scrolling.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::collectMatchingRulesForList):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d611411a
    • ojan@chromium.org's avatar
      Improve code for embedding flakiness dashboard as an iframe · 95ce5204
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84782
      
      Reviewed by Dirk Pranke.
      
      -Include the horizontal scrollbar height in the measured height of the page.
      -Post a message everytime the height changes instead of in response to a queryContentHeight message.
      This way, the embedder doesn't need to poll.
      
      No new tests. This is hard to test because it involves postMessage and iframes.
      Once we switch the dashboard tests over to qunit, we should be able to write an
      asyncTest for this.
      
      * TestResultServer/static-dashboards/flakiness_dashboard.js:
      (generatePage):
      (appendHTML):
      (appendExpectations):
      (postHeightChangedMessage):
      (generatePageForIndividualTests.if):
      (generatePageForIndividualTests):
      * TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95ce5204
    • benjamin@webkit.org's avatar
      Generalize the single character optimization of r114072 · 3cdab957
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83961
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-24
      Reviewed by Eric Seidel.
      
      Source/JavaScriptCore: 
      
      Use the regular String::find(StringImpl*) in all cases now that it has been made faster.
      
      * runtime/StringPrototype.cpp:
      (JSC::replaceUsingStringSearch):
      
      Source/WTF: 
      
      This patch makes some improvment over String::find() in the case of lookup for a single
      character.
      
      The two function find(UChar|LChar) are replaced by a template.
      
      The case of searching a UChar in a 8bit string has a shortcut if the UChar cannot
      possibly match any character in the range of the type LChar.
      
      The slow case StringImpl::find(StringImpl*) is modified to
      -Do not allocate in the fast case if only one string is 8bit.
      -Use the shortcut for searching UChar in LChar.
      
      This speed up the function by about 7% when avoiding string conversion.
      
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::find):
      * wtf/text/StringImpl.h:
      (StringImpl):
      (WTF):
      (WTF::find):
      (WTF::StringImpl::find):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cdab957
    • ojan@chromium.org's avatar
      Replace garden-o-matic accordion UI with a panel UI · f0260478
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84081
      
      Reviewed by Dimitri Glazkov.
      
      This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
      since we can reuse the same iframe without moving it in the DOM.
      
      Also, excise unnecessary jquery-isms.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0260478
    • rwlbuis@webkit.org's avatar
      REGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests) · df41195d
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84783
      
      Reviewed by Dirk Schulze.
      
      Fix struct-use-09-b.svg missing test result by converting to a reftest.
      
      * platform/chromium-linux/svg/custom/struct-use-09-b-expected.png: Removed.
      * platform/chromium-mac-leopard/svg/custom/struct-use-09-b-expected.png: Removed.
      * platform/chromium-mac/svg/custom/struct-use-09-b-expected.png: Removed.
      * platform/chromium-mac/svg/custom/struct-use-09-b-expected.txt: Removed.
      * platform/chromium-win/svg/custom/struct-use-09-b-expected.png: Removed.
      * platform/chromium-win/svg/custom/struct-use-09-b-expected.txt: Removed.
      * platform/gtk/svg/custom/struct-use-09-b-expected.png: Removed.
      * platform/gtk/svg/custom/struct-use-09-b-expected.txt: Removed.
      * platform/mac-leopard/svg/custom/struct-use-09-b-expected.png: Removed.
      * platform/mac/svg/custom/struct-use-09-b-expected.png: Removed.
      * platform/qt/svg/custom/struct-use-09-b-expected.png: Removed.
      * platform/qt/svg/custom/struct-use-09-b-expected.txt: Removed.
      * svg/custom/struct-use-09-b-expected.svg:
      * svg/custom/struct-use-09-b.svg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df41195d
    • hclam@chromium.org's avatar
      [chromium] Unreviewd test expectations update. · f27075de
      hclam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84790
      
      Adding expectations for new tests added in r115091.
      
      * platform/chromium-mac/fast/css/table-rules-attribute-groups-with-frame-expected.png: Added.
      * platform/chromium-mac/fast/css/table-rules-attribute-with-frame1-expected.png: Added.
      * platform/chromium-mac/fast/css/table-rules-attribute-with-frame2-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f27075de
    • beidson@apple.com's avatar
      Fix Windows build. · 9093cc29
      beidson@apple.com authored
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
      (~InjectedBundleDOMWindowExtension): VS doesn't like OVERRIDE on d'tor's
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9093cc29
    • kling@webkit.org's avatar
      REGRESSION(r115099): html5lib/runner.html crashes. · 24377f35
      kling@webkit.org authored
      <http://webkit.org/b/84791>
      
      Reviewed by Anders Carlsson.
      
      Unbreak and simplify the code that filters attributes on isindex elements.
      It's perfectly safe to remove elements from a Vector while iterating over it.
      
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::attributesForIsindexInput):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24377f35
    • peter@chromium.org's avatar
      [Chromium] DumpRenderTree should depend on base.gyp:test_support_base · fe39ba3f
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84729
      
      Reviewed by Dirk Pranke.
      
      This dependency is necessary for Android since it'll soon be
      calling InitAndroidOSPathStub() in it's platform support. The
      TestWebKitAPI and webkit_unit_tests already have this dependency.
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe39ba3f
    • commit-queue@webkit.org's avatar
      Extra display logic for the media control panel element · 19f7c033
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82476
      
      Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-24
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      This patch fixes a bug which caused the controls to be displayed
      when they should remain hidden. Added an extra variable to the
      panel elements which properly keeps the state of the panel (visible or not).
      
      Test: media/video-controls-toggling.html
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::MediaControlPanelElement): Added the
      variable m_isDisplayed to hold the state whether the panel is visible or not.
      (WebCore::MediaControlPanelElement::makeOpaque): Showing the panel only if it
      is visible.
      (WebCore::MediaControlPanelElement::makeTransparent): Enabled the transition
      timer which sets the display:none property on the controls.
      (WebCore::MediaControlPanelElement::setIsDisplayed): Setter for the state variable.
      (WebCore):
      * html/shadow/MediaControlElements.h:
      (MediaControlPanelElement):
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::show): Updated the panel visibility state.
      (WebCore::MediaControlRootElement::hide): Updated the panel visibility state.
      * html/shadow/MediaControlRootElementChromium.cpp:
      (WebCore::MediaControlRootElementChromium::show): Updated the panel visibility state.
      (WebCore::MediaControlRootElementChromium::hide): Updated the panel visibility state.
      
      LayoutTests:
      
      Added test to ensure that controls are not displayed when
      the controls attribute is not set.
      
      * media/video-controls-toggling-expected.txt: Added.
      * media/video-controls-toggling.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19f7c033
    • ojan@chromium.org's avatar
      Replace vague informative statement with the list of builders where the test isn't listed · bf21cf25
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84779
      
      Reviewed by Dirk Pranke.
      
      This is more informative and more likely to be noticed. With the old UI, people never
      read the line and if they did, they didn't really understand what it meant. Hopefully
      have the list of builders will be more clear.
      
      * TestResultServer/static-dashboards/flakiness_dashboard.js:
      * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
      * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf21cf25
    • achicu@adobe.com's avatar
      CSS Shaders: Custom filters painting is broken · 19446367
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=82803
      
      Reviewed by Kenneth Russell.
      
      Source/WebCore:
      
      In this patch I moved CSS Shaders file loading notifications from FilterEffectRenderer to the new RenderLayerFilterInfo.
      That's because FilterEffectRenderer is only used when running the filters in the software pipeline
      and has a very short lifetime. Due to a recent change FilterEffectRenderer actually
      gets deleted if the shader is not loaded, so it doesn't live that much to be notified when the shader
      was actually loaded.
      
      Also removed the FilterEffectObserver, that was only used to notify the RenderLayer about the loaded shader.
      
      No new tests. This is making existing CSS Shaders tests pass again.
      Cannot un-skip on Mac for now because the feature is compile time disabled.
      
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/filters/CustomFilterOperation.h:
      (WebCore::CustomFilterOperation::affectsOpacity):
      (WebCore::CustomFilterOperation::movesPixels):
      * platform/graphics/filters/FilterOperations.cpp:
      (WebCore):
      (WebCore::FilterOperations::hasCustomFilter):
      * platform/graphics/filters/FilterOperations.h:
      (FilterOperations):
      * platform/graphics/texmap/TextureMapperImageBuffer.cpp:
      (WebCore::BitmapTextureImageBuffer::applyFilters):
      * rendering/FilterEffectObserver.h: Removed.
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::FilterEffectRenderer):
      (WebCore::FilterEffectRenderer::~FilterEffectRenderer):
      (WebCore::FilterEffectRenderer::build):
      * rendering/FilterEffectRenderer.h:
      (WebCore):
      (WebCore::FilterEffectRenderer::create):
      (FilterEffectRenderer):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateOrRemoveFilterEffect):
      * rendering/RenderLayer.h:
      * rendering/RenderLayerFilterInfo.cpp:
      (WebCore::RenderLayerFilterInfo::~RenderLayerFilterInfo):
      (WebCore::RenderLayerFilterInfo::notifyCustomFilterProgramLoaded):
      (WebCore):
      (WebCore::RenderLayerFilterInfo::updateCustomFilterClients):
      (WebCore::RenderLayerFilterInfo::removeCustomFilterClients):
      * rendering/RenderLayerFilterInfo.h:
      (WebCore):
      (RenderLayerFilterInfo):
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt: Un-skipping related tests on Chromium.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19446367
    • rwlbuis@webkit.org's avatar
      [SVG] convert use-css-events.svg to be a reftest · 8c0d7df7
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84788
      
      Reviewed by Andreas Kling.
      
      * platform/chromium-linux/svg/custom/use-css-events-expected.png: Removed.
      * platform/chromium-mac/svg/custom/use-css-events-expected.png: Removed.
      * platform/chromium-mac/svg/custom/use-css-events-expected.txt: Removed.
      * platform/chromium-win/svg/custom/use-css-events-expected.png: Removed.
      * platform/chromium-win/svg/custom/use-css-events-expected.txt: Removed.
      * platform/gtk/svg/custom/use-css-events-expected.png: Removed.
      * platform/gtk/svg/custom/use-css-events-expected.txt: Removed.
      * platform/mac-leopard/svg/custom/use-css-events-expected.png: Removed.
      * platform/mac-snowleopard/svg/custom/use-css-events-expected.png: Removed.
      * platform/mac/svg/custom/use-css-events-expected.png: Removed.
      * platform/mac/svg/custom/use-css-events-expected.txt: Removed.
      * platform/qt/svg/custom/use-css-events-expected.png: Removed.
      * platform/qt/svg/custom/use-css-events-expected.txt: Removed.
      * platform/win/svg/custom/use-css-events-expected.txt: Removed.
      * svg/custom/use-css-events-expected.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c0d7df7
    • antti@apple.com's avatar
      Another build fix. · 5845e4fc
      antti@apple.com authored
      Not reviewed.
      
      * css/MediaList.cpp:
      (WebCore::MediaQuerySet::MediaQuerySet):
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::StylePropertySet):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5845e4fc
    • rwlbuis@webkit.org's avatar
      REGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests) · 5cd5d3b3
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84783
      
      Reviewed by Andreas Kling.
      
      This regression was caused because the test results from an old patch were
      blindly taken, rebaseline these against trunk.
      
      * svg/custom/use-in-symbol-with-offset-expected.txt:
      * svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
      * svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cd5d3b3
    • hclam@chromium.org's avatar
      [chromium] Unreviewed test expectations update. · 6d6cfaa0
      hclam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84785
      
      Updating test expectation changes due to r115085.
      
      * platform/chromium-linux-x86/svg/custom/use-setAttribute-crash-expected.txt: Removed.
      * platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.txt: Removed.
      * platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt: Removed.
      * platform/chromium-mac/svg/custom/struct-use-09-b-expected.txt: Added.
      * platform/chromium-win-vista/svg/custom/use-setAttribute-crash-expected.txt: Removed.
      * platform/chromium-win-xp/svg/custom/use-setAttribute-crash-expected.txt: Removed.
      * platform/chromium-win/svg/custom/embedding-external-svgs-expected.txt:
      * platform/chromium-win/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
      * platform/chromium-win/svg/custom/relative-sized-use-on-symbol-expected.txt:
      * platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
      * platform/chromium-win/svg/custom/struct-use-09-b-expected.txt:
      * platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
      * platform/chromium/svg/custom/use-in-symbol-with-offset-expected.txt: Added.
      * platform/chromium/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt.
      * platform/chromium/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d6cfaa0
    • antti@apple.com's avatar
      Try to fix Qt build. · fbd5d9d0
      antti@apple.com authored
      Not reviewed.
      
      * css/StyleRule.h:
      (WebCore::StyleRuleBase::StyleRuleBase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbd5d9d0
    • tkent@chromium.org's avatar
      [Chromium] Implement WebCore::dateFormat{DayInMonth,Month,Year}Text() · 3b95f9c9
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84683
      
      Reviewed by Dimitri Glazkov.
      
      * public/platform/WebLocalizedString.h:
      Add DateFormat{DayInMonth,Month,Year}Label
      * src/LocalizedStrings.cpp:
      (WebCore::dateFormatYearText): Implemented.
      (WebCore::dateFormatMonthText): ditto.
      (WebCore::dateFormatDayInMonthText): ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b95f9c9
    • antti@apple.com's avatar
      Implement StyleRule copying · ca0770b0
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84752
      
      Reviewed by Andreas Kling.
              
      We'll need this for copy-on-write when style sheet data is shared between documents.
      
      Implement copy() and copy constructor for style rules their children as needed.
              
      The code is not yet used.
      
      * css/CSSSelectorList.cpp:
      (WebCore::CSSSelectorList::CSSSelectorList):
      (WebCore):
      * css/CSSSelectorList.h:
      (CSSSelectorList):
      * css/MediaList.h:
      (WebCore::MediaQuerySet::copy):
      (MediaQuerySet):
      * css/MediaQuery.cpp:
      (WebCore::MediaQuery::MediaQuery):
      (WebCore):
      * css/MediaQuery.h:
      (MediaQuery):
      (WebCore::MediaQuery::copy):
      * css/MediaQueryExp.h:
      (WebCore::MediaQueryExp::copy):
      (MediaQueryExp):
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::StylePropertySet):
      (WebCore):
      (WebCore::StylePropertySet::copy):
      * css/StylePropertySet.h:
              
          Make this copy parse mode too. As a result ElementAttributeData no longer needs to set it explicitly after copying.
      
      (StylePropertySet):
      * css/StyleRule.cpp:
      (WebCore::StyleRuleBase::copy):
      (WebCore):
      (WebCore::StyleRule::StyleRule):
      (WebCore::StyleRulePage::StyleRulePage):
      (WebCore::StyleRuleFontFace::StyleRuleFontFace):
      (WebCore::StyleRuleBlock::StyleRuleBlock):
      (WebCore::StyleRuleMedia::StyleRuleMedia):
      (WebCore::StyleRuleRegion::StyleRuleRegion):
      * css/StyleRule.h:
      (StyleRuleBase):
      (WebCore::StyleRuleBase::StyleRuleBase):
      (WebCore::StyleRule::copy):
      (StyleRule):
      (WebCore::StyleRuleFontFace::copy):
      (StyleRuleFontFace):
      (WebCore::StyleRulePage::copy):
      (StyleRulePage):
      (StyleRuleBlock):
      (WebCore::StyleRuleMedia::copy):
      (StyleRuleMedia):
      (WebCore::StyleRuleRegion::copy):
      (StyleRuleRegion):
      * css/WebKitCSSKeyframesRule.cpp:
      (WebCore):
      (WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
      * css/WebKitCSSKeyframesRule.h:
      (WebCore):
      (WebCore::StyleRuleKeyframes::copy):
      (StyleRuleKeyframes):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca0770b0