1. 19 Sep, 2011 40 commits
    • ggaren@apple.com's avatar
      Removed ENABLE_JSC_MULTIPLE_THREADS and related #ifdefs. · e2f27917
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68422
              
      As discussed on webkit-dev. All ports build with threads enabled in JSC now.
              
      This may break WinCE and other ports that have not built and tested with
      this configuration. I've filed bugs for port maintainers. It's time for
      WebKit to move forward.
      
      Reviewed by Sam Weinig.
      
      * API/APIShims.h:
      (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
      * API/JSContextRef.cpp:
      * heap/MachineStackMarker.cpp:
      (JSC::MachineThreads::MachineThreads):
      (JSC::MachineThreads::~MachineThreads):
      (JSC::MachineThreads::gatherConservativeRoots):
      * heap/MachineStackMarker.h:
      * runtime/InitializeThreading.cpp:
      (JSC::initializeThreadingOnce):
      (JSC::initializeThreading):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::sharedInstance):
      * runtime/JSGlobalData.h:
      (JSC::JSGlobalData::makeUsableFromMultipleThreads):
      * runtime/JSLock.cpp:
      * runtime/Structure.cpp:
      * wtf/Platform.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2f27917
    • rniwa@webkit.org's avatar
      Hit testing on margins of body and head elements doesn't recur · b03eb35f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=40753
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
      of head/body and html elements when hit testing was done inside margins of head and body elements.
      
      Fixed the bug by special-casing html element (any immediate child of render view with a render layer)
      since margins of head and body elements are special.
      
      Tests: editing/selection/click-on-body-margin.html
             editing/selection/click-on-head-margin.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::positionForPointRespectingEditingBoundaries):
      
      LayoutTests: 
      
      Add tests to click on margins of head and body elements. WebKit should not
      (attempt to) place the caret after or before head and body elements.
      
      * editing/selection/click-on-body-margin-expected.txt: Added.
      * editing/selection/click-on-body-margin.html: Added.
      * editing/selection/click-on-head-margin-expected.txt: Added.
      * editing/selection/click-on-head-margin.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b03eb35f
    • commit-queue@webkit.org's avatar
      Ask for audio hardware buffer size instead of using hardwired constants. · 04cac329
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67952
      
      Patch by Raymond Toy <rtoy@google.com> on 2011-09-19
      Reviewed by Kenneth Russell.
      
      * public/WebKitPlatformSupport.h:
      (WebKit::WebKitPlatformSupport::audioHardwareBufferSize): Declare
      new member function audioHardwareBufferSize.
      * src/AudioDestinationChromium.cpp:
      (WebCore::AudioDestinationChromium::AudioDestinationChromium):
      Call audioHardwareBufferSize() to get buffer size; update
      m_callbackBuffersize and m_renderCountPerCallback appropriately.
      Remove global variables callbackBufferSize and
      renderCountPerCallback.  Add constant for maximum
      allowed buffer size and verify we don't exceed it.
      (WebCore::AudioDestinationChromium::render): Use new member
      variables instead of globals.
      * src/AudioDestinationChromium.h:
      Define new member variables m_callbackBufferSize and
      m_renderCountPerCallback
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04cac329
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r95493 and r95496. · 27504650
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/95493
      http://trac.webkit.org/changeset/95496
      https://bugs.webkit.org/show_bug.cgi?id=68418
      
      Broke Windows build (Requested by rniwa on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19
      
      Source/JavaScriptCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.exp:
      * JavaScriptCore.gypi:
      * JavaScriptCore.pro:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * debugger/Debugger.cpp:
      (JSC::Debugger::recompileAllJSFunctions):
      * heap/AllocationSpace.cpp: Removed.
      * heap/AllocationSpace.h: Removed.
      * heap/Heap.cpp:
      (JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
      (JSC::CountFunctor::TakeIfEmpty::operator()):
      (JSC::CountFunctor::TakeIfEmpty::returnValue):
      (JSC::Heap::Heap):
      (JSC::Heap::reportExtraMemoryCostSlowCase):
      (JSC::Heap::tryAllocate):
      (JSC::Heap::allocateSlowCase):
      (JSC::Heap::getConservativeRegisterRoots):
      (JSC::Heap::markRoots):
      (JSC::Heap::clearMarks):
      (JSC::Heap::sweep):
      (JSC::Heap::objectCount):
      (JSC::Heap::size):
      (JSC::Heap::capacity):
      (JSC::Heap::globalObjectCount):
      (JSC::Heap::objectTypeCounts):
      (JSC::Heap::collect):
      (JSC::Heap::canonicalizeBlocks):
      (JSC::Heap::resetAllocator):
      (JSC::Heap::allocateBlock):
      (JSC::Heap::freeBlocks):
      (JSC::Heap::shrink):
      * heap/Heap.h:
      (JSC::Heap::markedSpace):
      (JSC::Heap::forEachCell):
      (JSC::Heap::forEachBlock):
      (JSC::Heap::sizeClassFor):
      (JSC::Heap::allocate):
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitAllocateBasicJSObject):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::recompileAllJSFunctions):
      (JSC::JSGlobalData::releaseExecutableMemory):
      
      Source/WebCore:
      
      * ForwardingHeaders/heap/AllocationSpace.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27504650
    • commit-queue@webkit.org's avatar
      [chromium] ContentLayer's texture updater deleted during paint when... · f82cc5ec
      commit-queue@webkit.org authored
      [chromium] ContentLayer's texture updater deleted during paint when compositing turns off in the middle of paint
      https://bugs.webkit.org/show_bug.cgi?id=68405
      
      Patch by James Robinson <jamesr@chromium.org> on 2011-09-19
      Reviewed by Kenneth Russell.
      
      Make TiledLayerChromium's textureUpdater refcounted and hold an explicit reference during paint in case
      compositing is turned off halfway through a paint.
      
      * platform/graphics/chromium/ContentLayerChromium.h:
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      (WebCore::ImageLayerTextureUpdater::create):
      * platform/graphics/chromium/ImageLayerChromium.h:
      * platform/graphics/chromium/LayerTextureUpdater.h:
      * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
      (WebCore::LayerTextureUpdaterBitmap::create):
      (WebCore::LayerTextureUpdaterSkPicture::create):
      * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::prepareToUpdate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f82cc5ec
    • barraclough@apple.com's avatar
      Errrk, missed stylebot comments in last commit. · 918a23c6
      barraclough@apple.com authored
      * runtime/StringPrototype.cpp:
      (JSC::stringProtoFuncSplit):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      918a23c6
    • barraclough@apple.com's avatar
      String#split is buggy · 83df0075
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68348
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      * runtime/StringPrototype.cpp:
      (JSC::jsStringWithReuse):
          - added helper function to reuse original JSString value.
      (JSC::stringProtoFuncSplit):
          - Rewritten from the spec.
      * tests/mozilla/ecma/String/15.5.4.8-2.js:
      (getTestCases):
          - This test is not ES5 compliant.
      
      LayoutTests: 
      
      * fast/js/script-tests/string-split-conformance.js: Added.
      * fast/js/string-split-conformance-expected.txt: Added.
      * fast/js/string-split-conformance.html: Added.
          - Added new Layout test based on:
              http://stevenlevithan.com/demo/split.cfm
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T6-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T7-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T8-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T9-expected.txt:
      * sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A2_T7-expected.txt:
          - Check in failing results for these 5 tests; they are all wrong
            (see https://bugs.ecmascript.org/show_bug.cgi?id=61).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83df0075
    • ggaren@apple.com's avatar
      Removed lots of friend declarations from JSCell, so we can more · 1caf69d3
      ggaren@apple.com authored
      effectively make use of private and protected.
      
      Reviewed by Sam Weinig.
      
      * runtime/JSCell.h: Removed MSVCBugWorkaround because it was a lot of
      confusion for not much safety.
      (JSC::JSCell::operator new): Made this public because it is used by a
      few clients, and not really dangerous.
      
      * runtime/JSObject.cpp:
      (JSC::JSObject::put):
      (JSC::JSObject::deleteProperty):
      (JSC::JSObject::defineGetter):
      (JSC::JSObject::defineSetter):
      (JSC::JSObject::getPropertySpecificValue):
      (JSC::JSObject::getOwnPropertyNames):
      (JSC::JSObject::seal):
      (JSC::JSObject::freeze):
      (JSC::JSObject::preventExtensions):
      (JSC::JSObject::removeDirect):
      (JSC::JSObject::createInheritorID):
      (JSC::JSObject::allocatePropertyStorage):
      (JSC::JSObject::getOwnPropertyDescriptor):
      * runtime/JSObject.h:
      (JSC::JSObject::getDirect):
      (JSC::JSObject::getDirectLocation):
      (JSC::JSObject::hasCustomProperties):
      (JSC::JSObject::hasGetterSetterProperties):
      (JSC::JSObject::isSealed):
      (JSC::JSObject::isFrozen):
      (JSC::JSObject::isExtensible):
      (JSC::JSObject::flattenDictionaryObject):
      (JSC::JSObject::finishCreation):
      (JSC::JSObject::prototype):
      (JSC::JSObject::setPrototype):
      (JSC::JSObject::inlineGetOwnPropertySlot):
      (JSC::JSCell::fastGetOwnProperty):
      (JSC::JSObject::putDirectInternal):
      (JSC::JSObject::putDirectWithoutTransition):
      (JSC::JSObject::transitionTo):
      (JSC::JSObject::visitChildrenDirect): Changed all use of m_structure to
      structure() / setStructure(), so we don't have to be a friend of JSCell.
      
      * runtime/Structure.h:
      (JSC::JSCell::setStructure): Added, to avoid direct access by JSObject
      to JSCell::m_structure.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1caf69d3
    • macpherson@chromium.org's avatar
      Eliminate Length::undefinedLength = -1 and replace with Undefined LengthType. · a28ed43d
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68057
      
      Reviewed by Darin Adler.
      
      There appear to be many cases where -1 is actually a valid Length.
      Encoding the validity of Length separately to the value is a natural solution.
      
      No new tests / no behavioral changes.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      * css/CSSStyleApplyProperty.cpp:
      (WebCore::ApplyPropertyLength::applyValue):
      * platform/Length.h:
      (WebCore::Length::Length):
      (WebCore::Length::value):
      (WebCore::Length::calcValue):
      (WebCore::Length::calcMinValue):
      (WebCore::Length::calcFloatValue):
      (WebCore::Length::isUndefined):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::computePreferredLogicalWidths):
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
      * rendering/RenderFileUploadControl.cpp:
      (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::isLogicalWidthSpecified):
      (WebCore::RenderImage::isLogicalHeightSpecified):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::computePreferredLogicalWidths):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::computePreferredLogicalWidths):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::computePreferredLogicalWidths):
      * rendering/RenderSlider.cpp:
      (WebCore::RenderSlider::computePreferredLogicalWidths):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::computePreferredLogicalWidths):
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::initialMaxSize):
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::computePreferredLogicalWidths):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a28ed43d
    • abarth@webkit.org's avatar
      Always enable ENABLE(EVENTSOURCE) · ff5a5ea0
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68414
      
      Reviewed by Eric Seidel.
      
      .:
      
      * Source/cmake/OptionsEfl.cmake:
      * Source/cmake/OptionsWinCE.cmake:
      * Source/cmakeconfig.h.cmake:
      * configure.ac:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      EventSource seems to be here to stay.  This patch makes WebKit more
      hackable by removing this ENABLE macro, as discussed on webkit-dev.
      
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * bindings/cpp/WebDOMEventTarget.cpp:
      (toWebKit):
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::eventSource):
      * bindings/js/JSEventSourceCustom.cpp:
      * bindings/js/JSEventTarget.cpp:
      (WebCore::toJS):
      (WebCore::toEventTarget):
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::eventSource):
      * bindings/v8/V8DOMWrapper.cpp:
      (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
      * features.pri:
      * page/DOMWindow.idl:
      * page/EventSource.cpp:
      * page/EventSource.h:
      * page/EventSource.idl:
      * workers/WorkerContext.idl:
      
      Source/WebKit/chromium:
      
      * features.gypi:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      * Scripts/build-webkit:
      
      WebKitLibraries:
      
      * win/tools/vsprops/FeatureDefines.vsprops:
      * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff5a5ea0
    • levin@chromium.org's avatar
      Sheriffbot rollout should be more intuitive. · f40d63ce
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68415
      
      Reviewed by Adam Barth.
      
      * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
      * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
        and a few others cases.
      * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f40d63ce
    • levin@chromium.org's avatar
      check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h · 68ec7258
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68391
      
      Reviewed by Darin Adler.
      
      * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
      * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68ec7258
    • commit-queue@webkit.org's avatar
      Enable JSC_MULTIPLE_THREADS for OS(QNX). · 804dc0ca
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68047
      
      Patch by Eli Fidler <efidler@rim.com> on 2011-09-19
      Reviewed by Daniel Bates.
      
      SA_RESTART was required for SIGUSR2-based debugging, but is not
      present on QNX. This debugging doesn't seem critical to
      JSC_MULTIPLE_THREADS, so allow it to proceed.
      
      * heap/MachineStackMarker.cpp:
      (JSC::MachineThreads::Thread::Thread):
      (JSC::getPlatformThreadRegisters):
      (JSC::otherThreadStackPointer):
      (JSC::freePlatformThreadRegisters):
      * wtf/Platform.h: enable PTHREADS for OS(QNX)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      804dc0ca
    • commit-queue@webkit.org's avatar
      Fix a use-after-free: clear the fullscreen change event target queue at · 49314b9b
      commit-queue@webkit.org authored
      detach time, rather than at destruction time. If this isn't done, it's
      possible for the event target queue to be the only thing that
      references the document. Then when the document is popped off the queue
      and dereferenced in Document::fullScreenChangeDelayTimerFired, the
      document is destroyed and the subsequent access to
      m_fullScreenChangeEventTargetQueue.isEmpty() accesses free'd memory.
      https://bugs.webkit.org/show_bug.cgi?id=67960
      
      Patch by Jeremy Apthorp <jeremya@chromium.org> on 2011-09-19
      Reviewed by Adam Barth.
      
      * dom/Document.cpp:
      (WebCore::Document::~Document):
      (WebCore::Document::detach):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49314b9b
    • oliver@apple.com's avatar
      Windows build fix. · 6c67a854
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c67a854
    • commit-queue@webkit.org's avatar
      Suppress flakey test on windows in Chromium gesture recognizer · 9120b8ae
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68408
      
      Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-19
      Reviewed by Adam Barth.
      
      * tests/InnerGestureRecognizerTest.cpp:
      (TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9120b8ae
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r95482. · e6012e03
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/95482
      https://bugs.webkit.org/show_bug.cgi?id=68410
      
      Broke chromium webkit-tests (Requested by dslomov on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19
      
      Source/WebCore:
      
      * platform/image-encoders/skia/JPEGImageEncoder.cpp:
      (WebCore::RGBAtoRGB):
      
      LayoutTests:
      
      * fast/canvas/webgl/premultiplyalpha-test-expected.txt:
      * fast/canvas/webgl/premultiplyalpha-test.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6012e03
    • oliver@apple.com's avatar
      Refactor Heap allocation logic into separate AllocationSpace class · 5f0e9c80
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68409
      
      Reviewed by Gavin Barraclough.
      
      ../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:
      
      This patch hoists direct manipulation of the MarkedSpace and related
      data out of Heap and into a separate class.  This will allow us to
      have multiple allocation spaces in future, so easing the way towards
      having GC'd backing stores for objects.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.exp:
      * JavaScriptCore.gypi:
      * JavaScriptCore.pro:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * debugger/Debugger.cpp:
      (JSC::Debugger::recompileAllJSFunctions):
      * heap/AllocationSpace.cpp: Added.
      (JSC::AllocationSpace::tryAllocate):
      (JSC::AllocationSpace::allocateSlowCase):
      (JSC::AllocationSpace::allocateBlock):
      (JSC::AllocationSpace::freeBlocks):
      (JSC::TakeIfEmpty::TakeIfEmpty):
      (JSC::TakeIfEmpty::operator()):
      (JSC::TakeIfEmpty::returnValue):
      (JSC::AllocationSpace::shrink):
      * heap/AllocationSpace.h: Added.
      (JSC::AllocationSpace::AllocationSpace):
      (JSC::AllocationSpace::blocks):
      (JSC::AllocationSpace::sizeClassFor):
      (JSC::AllocationSpace::setHighWaterMark):
      (JSC::AllocationSpace::highWaterMark):
      (JSC::AllocationSpace::canonicalizeBlocks):
      (JSC::AllocationSpace::resetAllocator):
      (JSC::AllocationSpace::forEachCell):
      (JSC::AllocationSpace::forEachBlock):
      (JSC::AllocationSpace::allocate):
      * heap/Heap.cpp:
      (JSC::Heap::Heap):
      (JSC::Heap::reportExtraMemoryCostSlowCase):
      (JSC::Heap::getConservativeRegisterRoots):
      (JSC::Heap::markRoots):
      (JSC::Heap::clearMarks):
      (JSC::Heap::sweep):
      (JSC::Heap::objectCount):
      (JSC::Heap::size):
      (JSC::Heap::capacity):
      (JSC::Heap::globalObjectCount):
      (JSC::Heap::objectTypeCounts):
      (JSC::Heap::collect):
      (JSC::Heap::canonicalizeBlocks):
      (JSC::Heap::resetAllocator):
      (JSC::Heap::freeBlocks):
      (JSC::Heap::shrink):
      * heap/Heap.h:
      (JSC::Heap::objectSpace):
      (JSC::Heap::sizeClassForObject):
      (JSC::Heap::allocate):
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitAllocateBasicJSObject):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::recompileAllJSFunctions):
      (JSC::JSGlobalData::releaseExecutableMemory):
      
      ../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:
      
      Adding a forwarding header.
      
      * ForwardingHeaders/heap/AllocationSpace.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f0e9c80
    • alexis.menard@openbossa.org's avatar
      [Qt] Unreviewed coding style fix. · e15cac14
      alexis.menard@openbossa.org authored
      * UIProcess/API/qt/qdesktopwebview.h:
      * UIProcess/API/qt/qtouchwebpage.h:
      * UIProcess/API/qt/qweberror.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e15cac14
    • commit-queue@webkit.org's avatar
      Expose AXObjectCache methods so that WebAccessibilityCache · 9fb154f4
      commit-queue@webkit.org authored
      can be deleted.
      https://bugs.webkit.org/show_bug.cgi?id=68225
      
      Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-19
      Reviewed by Dimitri Glazkov.
      
      This patch exposes the functionality needed from AXObjectCache
      with new methods in WebAccessibilityObject and WebDocument.
      Next, Chromium will be updated to use only these methods and
      not WebAccessibilityCache. Then, WebAccessibilityCache can be
      deleted from WebKit.
      
      * public/WebAccessibilityObject.h:
      * public/WebDocument.h:
      * src/WebAccessibilityObject.cpp:
      (WebKit::WebAccessibilityObject::enableAccessibility):
      (WebKit::WebAccessibilityObject::accessibilityEnabled):
      (WebKit::WebAccessibilityObject::axID):
      * src/WebDocument.cpp:
      (WebKit::WebDocument::accessibilityObject):
      (WebKit::WebDocument::accessibilityObjectFromID):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fb154f4
    • bbudge@chromium.org's avatar
      Perform HTTP method and header validation in AssociatedURLLoader for · a9719474
      bbudge@chromium.org authored
      requests coming from untrusted code (eg. Native Client in Chrome). Use
      the same code as XMLHttpRequest to reduce code duplication and have
      behavior identical to XHR in Javascript. Add an 'untrustedHTTP' option
      to WebURLLoaderOptions, which AssociatedURLLoader can use to determine
      if it should check the request method and headers.
      https://bugs.webkit.org/show_bug.cgi?id=67655
      
      Reviewed by Darin Fisher.
      
      * public/WebURLLoaderOptions.h:
      (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
      * src/AssociatedURLLoader.cpp:
      (WebKit::AssociatedURLLoader::ClientAdapter::setDelayedError):
      (WebKit::AssociatedURLLoader::loadAsynchronously):
      * tests/AssociatedURLLoaderTest.cpp:
      (WebKit::AssociatedURLLoaderTest::CheckMethodFails):
      (WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
      (WebKit::AssociatedURLLoaderTest::CheckFails):
      (WebKit::TEST_F):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9719474
    • abarth@webkit.org's avatar
      [V8] document.all gets confused about its prototype chain · dc55e1c7
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68393
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      GetRealNamedPropertyInPrototypeChain doesn't call interceptors, so it's
      not a good idea to use its return value.  It turns out that all the
      callers of the API only cared about whether it returns a null handle.
      
      Test: http/tests/security/document-all.html
      
      * bindings/v8/V8Collection.h:
      (WebCore::collectionNamedPropertyGetter):
      * bindings/v8/custom/V8DOMStringMapCustom.cpp:
      (WebCore::V8DOMStringMap::namedPropertyDeleter):
      (WebCore::V8DOMStringMap::namedPropertySetter):
      * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
      (WebCore::V8HTMLAllCollection::namedPropertyGetter):
      * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
      (WebCore::V8HTMLCollection::namedPropertyGetter):
      * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
      (WebCore::V8NamedNodeMap::namedPropertyGetter):
      * bindings/v8/custom/V8StorageCustom.cpp:
      (WebCore::storageSetter):
      
      LayoutTests: 
      
      Test how document.all behaves when you change its prototype chain.
      
      * http/tests/security/document-all-expected.txt: Added.
      * http/tests/security/document-all.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc55e1c7
    • abarth@webkit.org's avatar
      Named property confusion with __proto__ · 9e21c2a8
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68221
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      The __proto__ property is super magical because it's not a real named
      property and it has higher precedence than even interceptors.  This
      confuses this check, which is meant to detech which names will get
      handled by our interceptor.
      
      Test: http/tests/security/window-named-proto.html
      
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::V8DOMWindow::namedSecurityCheck):
      
      LayoutTests: 
      
      * http/tests/security/resources/innocent-victim-with-iframe.html: Added.
      * http/tests/security/window-named-proto-expected.txt: Added.
      * http/tests/security/window-named-proto.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e21c2a8
    • abarth@webkit.org's avatar
      Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER) · 2fca7fac
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68292
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      OpenType Sanitizer is a library for sanitizing type and not a feature.
      Therefore this macro should say that we USE the library.
      
      * platform/graphics/WOFFFileFormat.cpp:
      * platform/graphics/WOFFFileFormat.h:
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      (WebCore::createFontCustomPlatformData):
      * platform/graphics/opentype/OpenTypeSanitizer.cpp:
      * platform/graphics/opentype/OpenTypeSanitizer.h:
      * platform/graphics/skia/FontCustomPlatformData.cpp:
      (WebCore::createFontCustomPlatformData):
      (WebCore::FontCustomPlatformData::supportsFormat):
      
      Source/WebKit/chromium: 
      
      * features.gypi:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fca7fac
    • abarth@webkit.org's avatar
      Remove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code · 2080bef0
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68407
      
      Reviewed by Eric Seidel.
      
      As discussed on webkit-dev, no one appears to be using this code.
      
      * GNUmakefile.list.am:
      * UseJSC.cmake:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSBindingsAllInOne.cpp:
      * bindings/js/JSDOMApplicationCacheCustom.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2080bef0
    • aroben@apple.com's avatar
      Windows build fix after r95310 · 266dbc3b
      aroben@apple.com authored
      * JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops: Added
      include\private\JavaScriptCore to the include path so DFGIntrinsic.h can be found.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      266dbc3b
    • fpizlo@apple.com's avatar
      DFG speculation failures should act as additional value profiles · 9b0b31ef
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68335
      
      Reviewed by Oliver Hunt.
              
      This adds slow-case counters to the old JIT. It also ensures that
      negative zero in multiply is handled carefully. The old JIT
      previously took slow path if the result of a multiply was zero,
      which, without any changes, would cause the DFG to think that
      every such multiply produced a double result.
              
      This also fixes a bug in the old JIT's handling of decrements. It
      would take the slow path if the result was zero, but not if it
      underflowed.
              
      By itself, this would be a 1% slow-down on V8 and Kraken. But then
      I wrote optimizations in the DFG that take advantage of this new
      information. It's no longer the case that every multiply needs to
      do a check for negative zero; it only happens if the negative
      zero is ignored.
              
      This results in a 12% speed-up on v8-crypto, for a 1.4% geomean
      speed-up in V8. It's mostly neutral on Kraken. I can see an
      0.5% slow-down and it appears to be significant.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::resetRareCaseProfiles):
      (JSC::CodeBlock::dumpValueProfiles):
      * bytecode/CodeBlock.h:
      * bytecode/ValueProfile.h:
      (JSC::RareCaseProfile::RareCaseProfile):
      (JSC::getRareCaseProfileBytecodeOffset):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::toInt32):
      (JSC::DFG::ByteCodeParser::makeSafe):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGJITCodeGenerator.cpp:
      (JSC::DFG::GPRTemporary::GPRTemporary):
      * dfg/DFGJITCodeGenerator.h:
      * dfg/DFGNode.h:
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNode):
      (JSC::DFG::Propagator::fixupNode):
      (JSC::DFG::Propagator::clobbersWorld):
      (JSC::DFG::Propagator::performNodeCSE):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      (JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileSlowCases):
      * jit/JIT.h:
      (JSC::JIT::linkDummySlowCase):
      * jit/JITArithmetic.cpp:
      (JSC::JIT::emit_op_post_dec):
      (JSC::JIT::emit_op_pre_dec):
      (JSC::JIT::compileBinaryArithOp):
      (JSC::JIT::emit_op_add):
      (JSC::JIT::emitSlow_op_add):
      * jit/JITInlineMethods.h:
      (JSC::JIT::addSlowCase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b0b31ef
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r95385 and r95457. · edaa6a6c
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/95385
      http://trac.webkit.org/changeset/95457
      https://bugs.webkit.org/show_bug.cgi?id=68395
      
      Broke chromium browser_tests (Requested by dslomov on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19
      
      Source/WebCore:
      
      * bindings/v8/V8DOMWindowShell.cpp:
      (WebCore::V8DOMWindowShell::disposeContextHandles):
      (WebCore::V8DOMWindowShell::initContextIfNeeded):
      * bindings/v8/V8IsolatedContext.cpp:
      (WebCore::V8IsolatedContext::V8IsolatedContext):
      (WebCore::V8IsolatedContext::destroy):
      * bindings/v8/V8IsolatedContext.h:
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame):
      (WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame):
      (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
      * loader/FrameLoaderClient.h:
      
      Source/WebKit/chromium:
      
      * public/WebFrameClient.h:
      (WebKit::WebFrameClient::didCreateIsolatedScriptContext):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::didCreateScriptContextForFrame):
      (WebKit::FrameLoaderClientImpl::didDestroyScriptContextForFrame):
      (WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):
      * src/FrameLoaderClientImpl.h:
      * tests/WebFrameTest.cpp:
      (WebKit::TEST_F):
      * tests/data/context_notifications_test.html: Removed.
      * tests/data/context_notifications_test_frame.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edaa6a6c
    • commit-queue@webkit.org's avatar
      Fix nonpremultiplied webgl toDataURL to jpeg · 69e8c582
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68366
      
      Source/WebCore:
      
      The canvas spec says that toDataURL to formats without an alpha must
      be "composited onto a solid black background using the source-over
      operator." Do that.
      
      Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
      Reviewed by Kenneth Russell.
      
      * platform/image-encoders/skia/JPEGImageEncoder.cpp:
      (WebCore::RGBAtoRGB):
      
      LayoutTests:
      
      Update the premultiplyalpha-test from the WebGL conformance tests.
      
      Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
      Reviewed by Kenneth Russell.
      
      * fast/canvas/webgl/premultiplyalpha-test-expected.txt:
      * fast/canvas/webgl/premultiplyalpha-test.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69e8c582
    • aroben@apple.com's avatar
      Let Xcode 4 do its thang with ANGLE.xcodeproj · 48d99cd5
      aroben@apple.com authored
      * ANGLE.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48d99cd5
    • aroben@apple.com's avatar
      Windows build fix after r94575 · a62e87de
      aroben@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore.sln: Relinearized project dependencies. testRegExp
      now builds just before FindSafari.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a62e87de
    • cmarrin@apple.com's avatar
      2011-09-19 Chris Marrin <cmarrin@apple.com> · 73392e96
      cmarrin@apple.com authored
              Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction
              https://bugs.webkit.org/show_bug.cgi?id=67510
      
              Reviewed by Adam Roben.
              
              Another fix to take care of one last crash when running pause-crash.html. 
              CACF can't deal with null valueFunctions, so avoid setting it when it doesn't 
              exist.
              
              This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it 
              from catching the null pointer exception generated by the pause-crash.html test 
              before this bug was fixed. Windows was ignoring the exception, so the testcase 
              would appear to succeed, even though it should have crashed.
      
              This is a resubmission of http://trac.webkit.org/changeset/95243 with a build fix.
      
              * WebCore.vcproj/WebCore.vcproj:
              * platform/graphics/ca/win/LayerChangesFlusher.cpp:
              (WebCore::LayerChangesFlusher::hookCallback):
              * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
              (PlatformCAAnimation::copy):
              * platform/win/StructuredExceptionHandlerSupressor.h: Added.
              (WebCore::StructuredExceptionHandlerSupressor::StructuredExceptionHandlerSupressor):
              (WebCore::StructuredExceptionHandlerSupressor::~StructuredExceptionHandlerSupressor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73392e96
    • rniwa@webkit.org's avatar
      Incorrect selection with absolutely positioned div · 1060c36e
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39503
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore: 
      
      The bug was caused by a false assumption in RenderBlock::positionForPoint. Because the last child box
      can be positioned, floated, invisible, etc..., we can't always trust last child's logicalTop to tell us
      whether a given point is inside or below the last child box.
      
      Fixed the bug by using the last hit-test candidate instead.
      
      Test: editing/selection/block-with-positioned-lastchild.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::positionForPoint):
      
      LayoutTests: 
      
      Added a regression test for placing the caret inside a block with multiple logical lines
      with an absolutely positioned last child. WebKit should place the caret on the left of the first line
      (instead of after the last line) when the user clicks on the left of the first line.
      
      * editing/selection/block-with-positioned-lastchild-expected.txt: Added.
      * editing/selection/block-with-positioned-lastchild.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1060c36e
    • inferno@chromium.org's avatar
      Unreviewed. Chromium Rebaselines for r95461. · 32500f0f
      inferno@chromium.org authored
      * platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
      * platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
      * platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
      * platform/chromium-linux/fast/table/table-row-before-after-content-around-block-expected.png: Added.
      * platform/chromium-linux/fast/table/table-row-before-after-content-around-table-expected.png: Added.
      * platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
      * platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
      * platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
      * platform/chromium-mac/fast/table/table-row-before-after-content-around-block-expected.png: Added.
      * platform/chromium-mac/fast/table/table-row-before-after-content-around-table-expected.png: Added.
      * platform/chromium-win/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
      * platform/chromium-win/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
      * platform/chromium-win/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
      * platform/chromium-win/fast/table/table-row-before-after-content-around-block-expected.png: Added.
      * platform/chromium-win/fast/table/table-row-before-after-content-around-table-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32500f0f
    • andersca@apple.com's avatar
      Fix crashes when running WebKit1 tests. · fad83021
      andersca@apple.com authored
      -[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
      equivalent code directly into -[WebHTMLView drawRect:].
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView drawRect:]):
      * WebView/WebViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fad83021
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r95466. · a7d0ea5b
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/95466
      https://bugs.webkit.org/show_bug.cgi?id=68389
      
      Incorrect version of the patch. (Requested by mhahnenberg on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * runtime/JSCell.cpp:
      (JSC::JSCell::toPrimitive):
      * runtime/JSCell.h:
      (JSC::JSCell::JSValue::toPrimitive):
      * runtime/JSNotAnObject.cpp:
      (JSC::JSNotAnObject::toPrimitive):
      * runtime/JSNotAnObject.h:
      * runtime/JSObject.h:
      * runtime/JSString.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7d0ea5b
    • andersca@apple.com's avatar
      Remove the last remains of viewless WebKit1 · 1f29a045
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68388
      
      Reviewed by Darin Adler.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::forceLayoutForNonHTML):
      Remove null check.
      
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:]):
      Remove usesDocumentViews parameter and checks.
      
      (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
      Add an assertion that usesDocumentViews is always true.
      
      (-[WebView _isUsingAcceleratedCompositing]):
      Remove usesDocumentViews check.
      
      (-[WebView _isSoftwareRenderable]):
      Remove usesDocumentViews check.
      
      (-[WebView initWithFrame:frameName:groupName:]):
      Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.
              
      (-[WebView initWithCoder:]):
      Remove usesDocumentViews parameter.
      
      (-[WebView _frameViewAtWindowPoint:]):
      Remove usesDocumentViews check.
      
      * WebView/WebViewData.h:
      Remove usesDocumentViews ivar.
      
      * WebView/WebViewPrivate.h:
      Remove usesDocumentViews parameters.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f29a045
    • alexis.menard@openbossa.org's avatar
      [Qt][WK2] Make loading errors API easier to use. · 389c4043
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68357
      
      Reviewed by Tor Arne Vestbø.
      
      Make the API to get loading errors easier to use. 95197 introduced
      a QJSValue API that is a bit opaque for the client code. Rather than
      using a dedicated object, we can just pass the needed information as
      parameters of the slot.
      
      * UIProcess/API/qt/qdesktopwebview.cpp:
      (QDesktopWebViewPrivate::loadDidFail):
      * UIProcess/API/qt/qdesktopwebview.h:
      * UIProcess/API/qt/qdesktopwebview_p.h:
      * UIProcess/API/qt/qtouchwebpage.h:
      * UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
      (tst_CommonViewTests::loadNonexistentFileUrl):
      * UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
      (WebViewAbstraction::WebViewAbstraction):
      (WebViewAbstraction::touchViewLoadFailed):
      (WebViewAbstraction::desktopViewLoadFailed):
      * UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
      * UIProcess/qt/QtWebPageProxy.cpp:
      (QtWebPageProxy::loadDidFail):
      * UIProcess/qt/TouchViewInterface.cpp:
      (WebKit::TouchViewInterface::loadDidFail):
      * UIProcess/qt/TouchViewInterface.h:
      * UIProcess/qt/ViewInterface.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      389c4043
    • dimich@chromium.org's avatar
      [Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins. · 301ac2a8
      dimich@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68267
      Make adoptNode() to not enable live iframe transfer when the iframe's subtree contains plugins.
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Test: fast/frames/iframe-reparenting-embed-elements.html
      
      * dom/Document.cpp:
      (WebCore::Document::adoptNode):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::hasPluginElements):
      (WebCore::HTMLFrameElementBase::canRemainAliveOnRemovalFromTree):
      * html/HTMLFrameElementBase.h:
      
      LayoutTests:
      
      * fast/frames/iframe-reparenting-embed-elements-expected.txt: Added.
      * fast/frames/iframe-reparenting-embed-elements.html: Added.
      * fast/frames/resources/iframe-reparenting-embed-frame1.html: Added.
      * fast/frames/resources/iframe-reparenting-embed-iframe.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      301ac2a8
    • andersca@apple.com's avatar
      Remove WebViewEventHandling.mm · d74b500d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68387
      
      Reviewed by Adam Roben.
      
      ../..: 
      
      Remove WebViewEventHandling.mm from the Xcode project.
      
      * WebKit.xcodeproj/project.pbxproj:
      
      ../../mac: 
      
      WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
      we're getting rid of viewless WebKit1.
      
      * WebView/WebView.mm:
      (-[WebView _close]):
      * WebView/WebViewData.h:
      * WebView/WebViewEventHandling.mm: Removed.
      * WebView/WebViewInternal.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d74b500d