1. 15 Sep, 2006 15 commits
    • bdash's avatar
      2006-09-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com> · e2ec6f25
      bdash authored
              Reviewed by Adam.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
              Bug 10864: Linux\GDK build fixes
      
              * JavaScriptCoreSources.bkl:
              * jscore.bkl:
      
      2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
      
              Reviewed by Adam.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
              Bug 10864: Linux\GDK build fixes
      
              * Projects/gdk/webcore-gdk.bkl:
              * WebCoreSources.bkl:
              * platform/gdk/FontCacheGdk.cpp:
              * platform/gdk/FontDataGdk.cpp:
              (WebCore::FontData::platformInit):
              * platform/gdk/FontGdk.cpp:
              (WebCore::Font::drawGlyphs):
              * platform/gdk/FrameGdk.cpp:
              (WebCore::FrameGdk::handleGdkEvent):
              * platform/gdk/FrameGdk.h:
              * platform/gdk/ImageGdk.cpp: Added.
              (WebCore::Image::initPlatformData):
              (WebCore::Image::invalidatePlatformData):
              (WebCore::Image::loadPlatformResource):
              (WebCore::Image::supportsType):
              * platform/gdk/RenderPopupMenuGdk.cpp:
              (WebCore::RenderPopupMenuGdk::hidePopup):
              * platform/gdk/RenderPopupMenuGdk.h:
              * platform/gdk/ScreenGdk.cpp:
              (WebCore::drawableForPage):
              (WebCore::screenRect):
              (WebCore::screenDepth):
              (WebCore::usableScreenRect):
              (WebCore::scaleFactor):
              * platform/gdk/SystemTimeLinux.cpp:
              (WebCore::currentTime):
              * platform/gdk/TemporaryLinkStubs.cpp:
              (FrameGdk::bindingRootObject):
              (FrameGdk::markMisspellings):
              (WebCore::screenDepthPerComponent):
              (WebCore::screenIsMonochrome):
              (WebCore::fileButtonChooseFileLabel):
              (WebCore::fileButtonNoFileSelectedLabel):
              (FrameGdk::shouldChangeSelection):
              (FrameGdk::respondToChangedSelection):
              (FrameGdk::respondToChangedContents):
              (Path::contains):
              (PlatformScrollBar::PlatformScrollBar):
              (PlatformScrollBar::~PlatformScrollBar):
              (PlatformScrollBar::width):
              (PlatformScrollBar::height):
              (PlatformScrollBar::setEnabled):
              (PlatformScrollBar::paint):
              (PlatformScrollBar::setScrollBarValue):
              (PlatformScrollBar::setKnobProportion):
              (PlatformScrollBar::setRect):
              (ScrollBar::ScrollBar):
              (FileChooser::FileChooser):
              (FileChooser::~FileChooser):
              (FileChooser::openFileChooser):
              (FileChooser::basenameForWidth):
              (FileChooser::uploadControlDetaching):
              (FileChooser::chooseFile):
              (Icon::Icon):
              (Icon::~Icon):
              (Icon::newIconForFile):
              (Icon::paint):
              (IconLoader::stopLoading):
              (IconLoader::startLoading):
              (IconLoader::createForFrame):
              (IconDatabase::isIconExpiredForIconURL):
              (IconDatabase::hasEntryForIconURL):
              (IconDatabase::sharedIconDatabase):
              * platform/gdk/WidgetGdk.cpp:
              * webcore-base.bkl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2ec6f25
    • thatcher's avatar
      Reviewed by Justin. · ff5f543d
      thatcher authored
              Updating results to new expected values.
      
              * fast/lists/drag-into-marker-expected.txt:
              * fast/repaint/selection-after-delete-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff5f543d
    • aroben's avatar
      Windows build fix. · ecc3fa61
      aroben authored
              * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecc3fa61
    • thatcher's avatar
      Reviewed by Justin. · a1701ca5
      thatcher authored
              Updating results to new expected values.
      
              * editing/inserting/4278698-expected.txt:
              * fast/dom/window-xy-properties-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1701ca5
    • bdash's avatar
      2006-09-15 Nikolas Zimmermann <zimmermann@kde.org> · c8279fd2
      bdash authored
              Reviewed by Eric.
      
              Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
              Fix svg memory leaks.
      
              Reworked SVGList to deal with RefPtr's for ptr types
              which makes manual refcounting unnecessary, and is much safer.
      
              Removing all virtual functions (nullItem) from SVGList, and
              also remove SVGListBase. Switch to a similar concept like
              Vector/VectorTraits (see new file SVGListTraits.h).
      
              Credits go to Eric/Maciej for the inspiration.
      
              * CMakeLists.txt: Add SVGListTraits.cpp to build
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
              * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
              (WebCore::RenderSVGText::translationForAttributes):
              * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
              (WebCore::SVGAnimateTransformElement::handleTimerEvent):
              * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
              (WebCore::SVGElementInstanceList::SVGElementInstanceList):
              * ksvg2/svg/SVGElementInstanceList.h:
              * ksvg2/svg/SVGLengthList.cpp: Ditto.
              (WebCore::SVGLengthList::SVGLengthList):
              * ksvg2/svg/SVGLengthList.h: Ditto.
              * ksvg2/svg/SVGList.h: Rewrote, as described above.
              (WebCore::SVGListTypeOperations::nullItem):
              (WebCore::SVGList::SVGList):
              (WebCore::SVGList::~SVGList):
              (WebCore::SVGList::clear):
              (WebCore::SVGList::getFirst):
              (WebCore::SVGList::getLast):
              (WebCore::SVGList::getItem):
              (WebCore::SVGList::replaceItem):
              (WebCore::SVGList::removeItem):
              * ksvg2/svg/SVGListTraits.cpp: Added.
              * ksvg2/svg/SVGListTraits.h: Added.
              (WebCore::):
              * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
              (WebCore::SVGPathElement::toPathData):
              * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
              (WebCore::SVGPathSegList::SVGPathSegList):
              * ksvg2/svg/SVGPathSegList.h: Ditto.
              * ksvg2/svg/SVGTransform.cpp: Style cleanup.
              (SVGTransform::SVGTransform):
              * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
              (SVGTransformList::SVGTransformList):
              (SVGTransformList::createSVGTransformFromMatrix):
              (SVGTransformList::consolidate):
              * ksvg2/svg/SVGTransformList.h: Ditto.
              * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
              (SVGTransformable::parseTransformAttribute):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8279fd2
    • eseidel's avatar
      2006-09-15 Nikolas Zimmermann <zimmermann@kde.org> · 0267d152
      eseidel authored
              Reviewed by eseidel.  Landed by eseidel.
      
              Fix build on Qt/Linux and implement Frame::addMessageToConsole to
              be able to see javascript errors for instance.
      
              * CMakeLists.txt:
              * platform/qt/FrameQt.h:
              * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
              (WebCore::FrameQt::bindingRootObject):
              * platform/qt/TemporaryLinkStubs.cp
              (WebCore::IconDatabase::hasEntryForIconURL):
              (WebCore::IconDatabase::sharedIconDatabase):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0267d152
    • andersca's avatar
      2006-09-15 Anders Carlsson <acarlsson@apple.com> · 0281d295
      andersca authored
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              Fix the release build.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0281d295
    • aroben's avatar
      Reviewed by eseidel. · 6acc6b3a
      aroben authored
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10876
              containsItemForURLUnicode uses matchLetter instead of
              matchUnicodeLetter
      
              Small fixes for _WebCoreHistoryProvider.
      
              * History/WebHistory.m: Consistently use BUFFER_SIZE #define
              (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]):
              (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]):
              Replace incorrect call to matchLetter to matchUnicodeLetter
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6acc6b3a
    • weinig's avatar
      Reviewed by Tim H. · c6bbaebd
      weinig authored
              Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
              Auto-generate the internal methods for the Objective-C bindings
      
              - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
                implementations where standard.  For cases where a custom implementation was
                needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
      
              - Some general cleanup of some of the non-generated bindings, to bring them in-
                line with what the generated bindings look like.
      
              * bindings/objc/DOM.mm:
              (-[DOMNode description]):
              * bindings/objc/DOMCSS.mm:
              (-[DOMCSSPrimitiveValue WebCore::]):
              (-[DOMDocument getComputedStyle::]):
              (-[DOMDocument getMatchedCSSRules::]):
              * bindings/objc/DOMEvents.mm:
              (-[DOMEvent WebCore::]):
              * bindings/objc/DOMHTML.mm:
              * bindings/objc/DOMHTMLDocument.mm:
              (-[DOMHTMLDocument title]):
              (-[DOMHTMLDocument setTitle:]):
              (-[DOMHTMLDocument referrer]):
              (-[DOMHTMLDocument domain]):
              (-[DOMHTMLDocument URL]):
              (-[DOMHTMLDocument body]):
              (-[DOMHTMLDocument setBody:]):
              (-[DOMHTMLDocument images]):
              (-[DOMHTMLDocument applets]):
              (-[DOMHTMLDocument links]):
              (-[DOMHTMLDocument forms]):
              (-[DOMHTMLDocument anchors]):
              (-[DOMHTMLDocument cookie]):
              (-[DOMHTMLDocument setCookie:]):
              (-[DOMHTMLDocument open]):
              (-[DOMHTMLDocument close]):
              (-[DOMHTMLDocument write:]):
              (-[DOMHTMLDocument writeln:]):
              (-[DOMHTMLDocument getElementById:]):
              (-[DOMHTMLDocument getElementsByName:]):
              (-[DOMHTMLDocument WebCore::]):
              (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
              * bindings/objc/DOMHTMLOptionElement.mm:
              (-[DOMHTMLOptionElement form]):
              (-[DOMHTMLOptionElement defaultSelected]):
              (-[DOMHTMLOptionElement setDefaultSelected:]):
              (-[DOMHTMLOptionElement text]):
              (-[DOMHTMLOptionElement index]):
              (-[DOMHTMLOptionElement disabled]):
              (-[DOMHTMLOptionElement setDisabled:]):
              (-[DOMHTMLOptionElement label]):
              (-[DOMHTMLOptionElement setLabel:]):
              (-[DOMHTMLOptionElement selected]):
              (-[DOMHTMLOptionElement setSelected:]):
              (-[DOMHTMLOptionElement value]):
              (-[DOMHTMLOptionElement setValue:]):
              (-[DOMHTMLOptionElement WebCore::]):
              (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMNode.mm:
              (-[DOMNode dealloc]):
              (-[DOMNode finalize]):
              (-[DOMNode nodeName]):
              (-[DOMNode nodeValue]):
              (-[DOMNode setNodeValue:]):
              (-[DOMNode nodeType]):
              (-[DOMNode parentNode]):
              (-[DOMNode childNodes]):
              (-[DOMNode firstChild]):
              (-[DOMNode lastChild]):
              (-[DOMNode previousSibling]):
              (-[DOMNode nextSibling]):
              (-[DOMNode attributes]):
              (-[DOMNode ownerDocument]):
              (-[DOMNode insertBefore::]):
              (-[DOMNode replaceChild::]):
              (-[DOMNode removeChild:]):
              (-[DOMNode appendChild:]):
              (-[DOMNode hasChildNodes]):
              (-[DOMNode cloneNode:]):
              (-[DOMNode normalize]):
              (-[DOMNode isSupported::]):
              (-[DOMNode namespaceURI]):
              (-[DOMNode prefix]):
              (-[DOMNode setPrefix:]):
              (-[DOMNode localName]):
              (-[DOMNode hasAttributes]):
              (-[DOMNode isSameNode:]):
              (-[DOMNode isEqualNode:]):
              (-[DOMNode isDefaultNamespace:]):
              (-[DOMNode lookupPrefix:]):
              (-[DOMNode lookupNamespaceURI:]):
              (-[DOMNode textContent]):
              (-[DOMNode setTextContent:]):
              (-[DOMNode boundingBox]):
              (-[DOMNode lineBoxRects]):
              * bindings/objc/DOMObject.mm:
              (-[DOMObject _init]):
              * bindings/objc/DOMXPath.mm:
              (-[DOMNativeXPathNSResolver dealloc]):
              (-[DOMNativeXPathNSResolver finalize]):
              (-[DOMNativeXPathNSResolver WebCore::]):
              (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
              (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
              (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
              * bindings/scripts/CodeGeneratorObjC.pm:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
              * css/CSSCharsetRule.idl:
              * css/CSSFontFaceRule.idl:
              * css/CSSImportRule.idl:
              * css/CSSMediaRule.idl:
              * css/CSSPageRule.idl:
              * css/CSSPrimitiveValue.idl:
              * css/CSSRule.idl:
              * css/CSSStyleRule.idl:
              * css/CSSStyleSheet.idl:
              * css/CSSUnknownRule.idl:
              * css/CSSValue.idl:
              * css/CSSValueList.idl:
              * css/StyleSheet.idl:
              * dom/Event.idl:
              * dom/KeyboardEvent.idl:
              * dom/MouseEvent.idl:
              * dom/MutationEvent.idl:
              * dom/NodeIterator.idl:
              * dom/OverflowEvent.idl:
              * dom/TreeWalker.idl:
              * dom/UIEvent.idl:
              * dom/WheelEvent.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6bbaebd
    • aroben's avatar
      WebCore: · ac32dbd9
      aroben authored
              Reviewed by timothy.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
              New file upload control should match the width of the old one
      
              Make width of new file upload control match the old one as closely as
              possible.
      
              * rendering/RenderFileUploadControl.cpp:
      
      LayoutTests:
              Reviewed by timothy.
      
              Part of http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
              New file upload control should match the width of the old one
      
              Update tests to match new file upload control.
      
              * fast/forms/file-input-disabled-expected.txt:
              * fast/forms/form-element-geometry-expected.txt:
              * fast/forms/input-appearance-height-expected.txt:
              * fast/forms/input-value-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac32dbd9
    • thatcher's avatar
      Reviewed by Eric. · 95ed2ed8
      thatcher authored
              Remove the SVG IDL files from the Copy Resources phase.
      
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95ed2ed8
    • andersca's avatar
      2006-09-15 Anders Carlsson <acarlsson@apple.com> · 53794dc8
      andersca authored
              Reviewed by Steve.
      
              Add JavaScriptCore API to the build.
              * API/JSBase.cpp:
              * API/JSCallbackConstructor.cpp:
              * API/JSCallbackFunction.cpp:
              * API/JSCallbackObject.cpp:
              * API/JSClassRef.cpp:
              * API/JSContextRef.cpp:
              * API/JSObjectRef.cpp:
              * API/JSStringRef.cpp:
              * API/JSValueRef.cpp:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * os-win32/stdbool.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53794dc8
    • kmccullo's avatar
      - just layout test result changes · b8547191
      kmccullo authored
              * fast/dom/Range/range-compareNode-expected.txt:
              * fast/dom/Range/range-intersectsNode-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8547191
    • beidson's avatar
      Reviewed by Eric Siedel · 4b65da93
      beidson authored
              Dumped the use of CGColorRef and directly use the floating point data from
              WebCore::Color
      
              This fixes the performance regression found between 16285 and 16286
      
              * platform/mac/FontMac.mm:
              (WebCore::Font::drawComplexText):
              (WebCore::Font::drawGlyphs):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b65da93
    • bdash's avatar
      2006-09-14 Mark Rowe <opendarwin.org@bdash.net.nz> · eceeaea9
      bdash authored
              Reviewed by Adam.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
              Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate
      
              FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
              Frame::cleanupPluginObjects method is called from Frame's destructor, which results
              in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.
      
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
              will be called from Frame::clear
              * page/Frame.cpp:
              (WebCore::Frame::~Frame): Use cancelAndClear.
              (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
              FrameMac can use.
              * page/Frame.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eceeaea9
  2. 14 Sep, 2006 9 commits
    • beidson's avatar
      Reviewed by Maciej's rubber stamp · 6e301767
      beidson authored
              Exact same fix I just made, but in the other method I horked up
              Also added a reference to the bugzilla in comments
      
              * page/Frame.cpp:
              (WebCore::Frame::endIfNotLoading):
              (WebCore::Frame::stop):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e301767
    • beidson's avatar
      Reviewed by Maciej · 8804ba3a
      beidson authored
              Fixed a bad iFrame crash, resolving some of the layout test badness
            
              * page/Frame.cpp:
              (WebCore::Frame::endIfNotLoading):
              - Added a RefPtr to protect the frame itself to prevent its destruction during this method
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8804ba3a
    • justing's avatar
      LayoutTests: · 50dad02e
      justing authored
              Reviewed by harrison
              
              <rdar://problem/4655880> Up/Down arrows skip over To Do
      
              * editing/selection/mixed-editability-3-expected.checksum: Added.
              * editing/selection/mixed-editability-3-expected.png: Added.
              * editing/selection/mixed-editability-3-expected.txt: Added.
              * editing/selection/mixed-editability-3.html: Added.
              * editing/selection/mixed-editability-4-expected.checksum: Added.
              * editing/selection/mixed-editability-4-expected.png: Added.
              * editing/selection/mixed-editability-4-expected.txt: Added.
              * editing/selection/mixed-editability-4.html: Added.
              * editing/selection/mixed-editability-5-expected.checksum: Added.
              * editing/selection/mixed-editability-5-expected.png: Added.
              * editing/selection/mixed-editability-5-expected.txt: Added.
              * editing/selection/mixed-editability-5.html: Added.
      
      WebCore:
      
              Reviewed by harrison
              
              <rdar://problem/4655880> Up/Down arrows skip over To Do
      
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
              * dom/Node.cpp: Removed the unused inSameRootEditableElement.
              * dom/Node.h:
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
              * editing/visible_units.cpp:
              (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
              editable content into editable content that's embedded in non-editable content.
              (WebCore::nextLinePosition): Ditto.
              (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
              This is the behavior that callers desire.  This fixes Command + Up/Down.
              (WebCore::endOfEditableContent): Ditto.
              * editing/visible_units.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50dad02e
    • aroben's avatar
      2006-09-14 Karthik Kumar <karthikkumar@gmail.com> · 5fae3ba1
      aroben authored
              Reviewed by timothy. Landed by aroben.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
              Windows build fixes after r16360
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
              AdditionalIncludeDirectories
              * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
              IconDatabase
              (IconLoader::stopLoading):
              (IconLoader::startLoading):
              (IconLoader::createForFrame):
              (IconDatabase::isIconExpiredForIconURL):
              (IconDatabase::hasEntryForIconURL):
              (IconDatabase::sharedIconDatabase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fae3ba1
    • beidson's avatar
      Part of a build fix - rest will be filling in some temporary link stubs · ea15a6e9
      beidson authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea15a6e9
    • bdash's avatar
      2006-09-14 Graham Dennis <graham.dennis@gmail.com> · 0c1215a0
      bdash authored
              Reviewed by Justin Garcia.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
                Crash in ApplyStyleCommand::applyRelativeFontStyleChange
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
              makeing sure that the 'beyondEnd' node is after the start node.
      
      2006-09-14  Graham Dennis  <graham.dennis@gmail.com>
      
              Reviewed by Justin Garcia.
      
              Modified testcase for:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
              Crash in ApplyStyleCommand::applyRelativeFontStyleChange
      
              * editing/style/table-selection-expected.checksum:
              * editing/style/table-selection-expected.png:
              * editing/style/table-selection-expected.txt:
              * editing/style/table-selection.html:
              This testcase was for 10579, which is very similar to this bug (10726)
              Now the testcase tests both bugs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c1215a0
    • bdash's avatar
      2006-09-14 MorganL <morlmor@yahoo.com> · f96c521a
      bdash authored
              Reviewed by Brady.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
              Various bugs/crashes in ResourceLoaderWin with local files.
      
              * platform/ResourceLoaderInternal.h:
              (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
              * platform/win/ResourceLoaderWin.cpp:
              (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
              (WebCore::ResourceLoader::fileLoadTimer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f96c521a
    • beidson's avatar
      WebCore: · 2212efda
      beidson authored
              Reviewed by Maciej
      
              Icon loads now take place in WebCore
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:
              - Moved enforcement of a Mozilla Favicon extension elsewhere
              
              * bridge/mac/FrameMac.h: 
              * bridge/mac/FrameMac.mm: 
              (WebCore::FrameMac::originalRequestURL):
              - Added accessor to "original request URL"
              
              * bridge/mac/WebCoreFrameBridge.h: 
              - Removed methods to set the iconURL as all loading is now done in WebCore
              - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL
              
              * html/HTMLLinkElement.cpp: 
              (WebCore::HTMLLinkElement::process):
              - Moved enforcement of a Mozilla Favicon extension elsewhere
              
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::setIconURLForPageURL):
              - Changed an ASSERT to correctly handle a sketchy (invalid) situation
      
              * loader/icon/IconLoader.h: Added.
              * loader/icon/IconLoader.cpp: Added.
              (IconLoader::IconLoader):
              (IconLoader::createForFrame):
              - Static factory method with a private constructor to enforce 
                "you MUST have a Frame to create an IconLoader" semantics
              (IconLoader::~IconLoader):
              (IconLoader::startLoading):
              (IconLoader::stopLoading):
              (IconLoader::receivedData):
              - ResourceLoaderClient delegate
              (IconLoader::receivedAllData):
              - Ditto
      
              * loader/mac/IconLoaderMac.mm: Added.
              (IconLoader::receivedResponse):
              (IconLoader::notifyIconChanged):
              - For now, these are platform specific methods
              - One to get the HTTP response code of an icon load
              - The other to call through to the app when the icon has changed (loaded)
      
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::Frame::iconURL):
              (WebCore::Frame::setIconURL):
              - Frame objects now have an inherent icon URL and a way to calculate/access it
              (WebCore::Frame::endIfNotLoading):
              - This is where we actually kick off the IconLoader
              (WebCore::Frame::stop):
              - Added call to stop loading the icon
      
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):
              (WebCore::FramePrivate::~FramePrivate):
              - Added the icon URL as a private member
              - Added the IconLoader as a private member, and clean it up on deletion
      
              * platform/mac/ResourceLoaderMac.mm:
              (WebCore::ResourceLoader::start):  Added a valuable ASSERT
      
      WebKit:
      
              Reviewed by Maciej
      
              Add infrastructure to support icon loads taking place in WebCore
              Will remove WebKit icon loaders in a later patch
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge notifyIconChanged:]):
              (-[WebFrameBridge originalRequestURL]):
              - Nuked two old, obsolete methods
              - Added bridge for notifying of an icon change
              - Added bridge for getting the "original request URL" which is still needed
                until that info is available in the WebCore loaders
      
              * WebView/WebDataSource.m:
              (-[WebDataSource _loadIcon]):
              - Empty body just for now, as it still gets called - next patch will prune all the old impl out
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2212efda
    • hyatt's avatar
      Fix for 10841, unable to check checkboxes inside labels. · 942fd28f
      hyatt authored
              Reviewed by xenon, bradee-oh
      
              * css/html4.css:
              * dom/Element.cpp:
              (WebCore::Element::contains):
              * dom/Element.h:
              * html/HTMLLabelElement.cpp:
              (WebCore::HTMLLabelElement::defaultEventHandler):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      942fd28f
  3. 13 Sep, 2006 16 commits
    • bdash's avatar
      2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz> · b774c3f7
      bdash authored
              Reviewed by Adam.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
              Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller
      
              * platform/mac/FileChooserMac.mm:
              (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b774c3f7
    • aroben's avatar
      Rubberstamped by hyatt. · 1a4bb3b4
      aroben authored
              Updating tables results after hyatt landed a fix for
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8126
              Padding must not apply to columns
      
              * tables/mozilla/bugs/bug139524-2-expected.txt:
              * tables/mozilla/bugs/bug139524-4-expected.txt:
              * tables/mozilla/bugs/bug32841-expected.txt:
              * tables/mozilla/dom/appendCol2-expected.txt:
              * tables/mozilla/dom/deleteCol1-expected.txt:
              * tables/mozilla/dom/deleteCol2-expected.txt:
              * tables/mozilla/dom/deleteCol3-expected.txt:
              * tables/mozilla/dom/deleteColGroup1-expected.txt:
              * tables/mozilla/dom/deleteColGroup2-expected.txt:
              * tables/mozilla/dom/insertColGroups1-expected.txt:
              * tables/mozilla/dom/insertColGroups2-expected.txt:
              * tables/mozilla/dom/insertCols1-expected.txt:
              * tables/mozilla/dom/insertCols2-expected.txt:
              * tables/mozilla/dom/insertCols3-expected.txt:
              * tables/mozilla/dom/insertCols4-expected.txt:
              * tables/mozilla/dom/insertCols5-expected.txt:
              * tables/mozilla/marvin/body_col-expected.txt:
              * tables/mozilla/marvin/x_col_span-expected.txt:
              * tables/mozilla/marvin/x_col_width_px-expected.txt:
              * tables/mozilla/marvin/x_colgroup_span-expected.txt:
              * tables/mozilla/other/body_col-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
              * tables/mozilla_expected_failures/core/cols1-expected.txt:
              * tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
              * tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
              * tables/mozilla_expected_failures/other/test4-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a4bb3b4
    • bdash's avatar
      2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz> · 4c09792a
      bdash authored
              Reviewed by Eric.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
              Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef
      
              * platform/mac/FontMac.mm:
              (WebCore::Font::drawComplexText): Release CGColorRef after use.
              (WebCore::Font::drawGlyphs): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c09792a
    • andersca's avatar
      2006-09-14 Anders Carlsson <acarlsson@apple.com> · 00f72a1a
      andersca authored
              Try fixing the Win32 build.
              
              * bridge/win/FrameWin.h:
              * platform/win/TemporaryLinkStubs.cpp:
              (FrameWin::bindingRootObject):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00f72a1a
    • sfalken's avatar
      2006-09-12 Steve Falkenburg <sfalken@apple.com> · 44b3f483
      sfalken authored
              Reviewed by Ada.
              
              Build tweaks (doing JavaScriptCore now since it doesn't have
              dependencies).
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
              * JavaScriptCore.vcproj/JavaScriptCore/dstroot-to-sdk.cmd: Added.
              * JavaScriptCore.vcproj/dftables/dftables.vcproj:
              * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44b3f483
    • andersca's avatar
      2006-09-14 Anders Carlsson <acarlsson@apple.com> · cd71fdd1
      andersca authored
              Reviewed by Tim O.
      
              Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.
              
              * bindings/js/kjs_binding.cpp:
              (KJS::ScriptInterpreter::createLanguageInstanceForValue):
              * bindings/js/kjs_dom.cpp:
              (KJS::getRuntimeObject):
              * bridge/mac/FrameMac.h:
              * config.h:
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::~HTMLAppletElement):
              (WebCore::HTMLAppletElement::detach):
              * html/HTMLAppletElement.h:
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
              (WebCore::HTMLEmbedElement::detach):
              * html/HTMLEmbedElement.h:
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::~HTMLObjectElement):
              (WebCore::HTMLObjectElement::detach):
              * html/HTMLObjectElement.h:
              * html/HTMLPlugInElement.cpp:
              (WebCore::HTMLPlugInElement::HTMLPlugInElement):
              (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
              (WebCore::HTMLPlugInElement::createNPObject):
              * html/HTMLPlugInElement.h:
              * page/Frame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd71fdd1
    • thatcher's avatar
      Reviewed by Tim O. · 488f3d29
      thatcher authored
              <rdar://problem/4726416> obsolete confusing "ADVISORY NOTE" comment in WebHistory.h
      
              Removed the "ADVISORY NOTE: This method may change for the 1.0 SDK" comments.
      
              * History/WebHistory.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      488f3d29
    • hyatt's avatar
      Clean up the XBL and XSLT ifdefs to be consistent with the SVG · 5cc8ab82
      hyatt authored
              and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
              KHTML_XSLT is now XSLT_SUPPORT.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSXSLTProcessor.cpp:
              * bindings/js/JSXSLTProcessor.h:
              * bindings/js/kjs_window.cpp:
              (KJS::Window::getValueProperty):
              * config.h:
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::~Document):
              (WebCore::Document::recalcStyleSelector):
              * dom/Document.h:
              (WebCore::Document::bindingManager):
              * dom/Node.cpp:
              (WebCore::Node::createRendererIfNeeded):
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::ProcessingInstruction):
              (WebCore::ProcessingInstruction::checkStyleSheet):
              (WebCore::ProcessingInstruction::setStyleSheet):
              * dom/ProcessingInstruction.h:
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::processingInstruction):
              (WebCore::XMLTokenizer::insertErrorMessageBlock):
              * dom/XMLTokenizer.h:
              * loader/Cache.cpp:
              (WebCore::Cache::getStatistics):
              * loader/Cache.h:
              * loader/CachedResource.h:
              (WebCore::CachedResource::):
              * loader/CachedResourceClient.h:
              * loader/CachedXBLDocument.cpp:
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              * loader/CachedXSLStyleSheet.h:
              * loader/DocLoader.cpp:
              * loader/DocLoader.h:
              * rendering/RenderStyle.cpp:
              (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
              (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
              (WebCore::StyleCSS3NonInheritedData::operator==):
              * rendering/RenderStyle.h:
              * xml/XSLImportRule.cpp:
              * xml/XSLImportRule.h:
              * xml/XSLStyleSheet.cpp:
              * xml/XSLStyleSheet.h:
              * xml/XSLTProcessor.cpp:
              * xml/XSLTProcessor.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cc8ab82
    • eseidel's avatar
      2006-09-13 Nikolas Zimmermann <zimmermann@kde.org> · 278b9a39
      eseidel authored
              Reviewed by eseidel.  Landed by eseidel.
      
              Fix newly introduced memory leaks in SVG.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
      
              * ksvg2/svg/SVGList.h:
              (WebCore::SVGListBase::~SVGListBase):
              (WebCore::SVGListBase::clearVector):
              (WebCore::SVGListBase::clear):
              (WebCore::SVGList::clearVector):
              (WebCore::):
              * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
              (SVGNumberList::SVGNumberList):
              * ksvg2/svg/SVGNumberList.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      278b9a39
    • aroben's avatar
      2006-09-13 MorganL <morlmor@yahoo.com> · 37e6c0f9
      aroben authored
              Reviewed/landed by aroben.
      
              Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
              Windows build needs fixed after move to engine-rendered file upload widget
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
              remove RenderFileButton files
              * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
              (FileChooser::FileChooser):
              (FileChooser::~FileChooser):
              (FileChooser::openFileChooser):
              (FileChooser::basenameForWidth):
              (FileChooser::uploadControlDetaching):
              (FileChooser::chooseFile):
              (WebCore::fileButtonChooseFileLabel):
              (WebCore::fileButtonNoFileSelectedLabel):
              (Icon::Icon):
              (Icon::~Icon):
              (Icon::newIconForFile):
              (Icon::paint):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37e6c0f9
    • aroben's avatar
      2006-09-13 MorganL <morlmor@yahoo.com> · 4e2882cd
      aroben authored
              Reviewed/landed by aroben.
      
              Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
              Webkit WebCore build fails on Windows
      
              * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
              variable
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e2882cd
    • thatcher's avatar
      Forgot these added files. · 1f408138
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f408138
    • thatcher's avatar
      Reviewed by Tim H. · 16e61bbf
      thatcher authored
              Fix Qt/Linux build.
      
              * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
              * platform/Icon.h: Add wtf/Platform.h include
              * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
              (WebCore::FileChooser::FileChooser):
              (WebCore::FileChooser::~FileChooser):
              (WebCore::FileChooser::openFileChooser):
              (WebCore::FileChooser::basenameForWidth):
              (WebCore::FileChooser::uploadControlDetaching):
              (WebCore::FileChooser::chooseFile):
              * platform/qt/IconQt.cpp: Added as stub.
              (WebCore::Icon::Icon):
              (WebCore::Icon::~Icon):
              (WebCore::Icon::newIconForFile):
              (WebCore::Icon::paint):
              * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
              (searchableIndexIntroduction):
              (fileButtonChooseFileLabel):
              (fileButtonNoFileSelectedLabel):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16e61bbf
    • aroben's avatar
      Reviewed by eseidel. · 5be8e5bf
      aroben authored
              Switch back to passing relative paths to generate-bindings.pl when
              generating JS bindings.
      
              * DerivedSources.make: Pass in relative paths to generate-bindings.pl
              * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
              chdir and always construct absolute paths instead.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5be8e5bf
    • hyatt's avatar
      Fix for bug 3244, implement html4 label support. · 89040d01
      hyatt authored
              Reviewed by mjs, aroben
      
              Added fast/events/label-focus.html
      
              * css/html4.css:
              * html/HTMLLabelElement.cpp:
              (WebCore::HTMLLabelElement::formElement):
              (WebCore::HTMLLabelElement::setActive):
              (WebCore::HTMLLabelElement::setHovered):
              (WebCore::HTMLLabelElement::defaultEventHandler):
              * html/HTMLLabelElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89040d01
    • hyatt's avatar
      New label layout test. · dcf5cde3
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcf5cde3